smoogipoo
c787c008a5
Fix test potentially not waiting for player to load
2021-05-31 20:21:26 +09:00
Dean Herbert
17fa2426d4
Merge branch 'master' into legacy-skin-resource-improvements
2021-05-31 19:36:09 +09:00
Dean Herbert
ebfc24a499
Rename conflicting resources
2021-05-31 19:14:49 +09:00
Dean Herbert
b16d10bd95
Provide game-wide resources via IStorageResourceProvider
2021-05-31 18:57:47 +09:00
Dean Herbert
d4cb70735d
Merge branch 'master' into non-nullable-beatmapset-files
2021-05-31 18:19:57 +09:00
Dan Balasescu
d8768a8c01
Merge pull request #13254 from peppy/fix-editor-beatmap-creation-test-failure-again
...
Fix bindable lease failure in editor beatmap creation tests
2021-05-31 17:38:19 +09:00
Dean Herbert
de0e51a81d
Merge branch 'master' into fix-skin-sample-lookup
2021-05-31 15:27:39 +09:00
Salman Ahmed
02d18c7a49
Merge branch 'master' into remove-hud-component-lookup
2021-05-31 09:23:04 +03:00
ekrctb
771f3c48c0
Add failing test showing lifetime not recomputed with pooled objects
2021-05-31 14:48:52 +09:00
ekrctb
b7afea37c4
Test drawable lifetime change on entry lifetime change
2021-05-31 14:45:29 +09:00
Dan Balasescu
8c6277f0d8
Merge pull request #13235 from ekrctb/update-lifetime-1
...
Update hit object lifetime on `HitObject.DefaultsApplied`
2021-05-31 14:44:40 +09:00
Dean Herbert
5925beaf21
Fix bindable lease failure in editor beatmap creation tests
2021-05-31 14:24:46 +09:00
Bartłomiej Dach
ab077c6656
Merge branch 'master' into non-nullable-beatmapset-files
2021-05-31 00:10:03 +02:00
Bartłomiej Dach
78213e09d4
Merge branch 'master' into editor-exit-stability
2021-05-30 23:03:50 +02:00
Gagah Pangeran Rosfatiputra
3c7f1ae996
Merge branch 'master' into osu-wiki-overlay
2021-05-30 20:27:12 +07:00
Dean Herbert
f35cf2d846
Merge branch 'master' into main-page-wiki
2021-05-30 21:01:05 +09:00
Dean Herbert
dac1a98d8a
Merge branch 'master' into fix-skin-sample-lookup
2021-05-30 15:19:47 +09:00
Salman Ahmed
200fecc774
Fix missing using directive
2021-05-29 21:22:39 +03:00
Salman Ahmed
42618c713f
Merge branch 'master' into legacy-beatmap-skin-hud-fallback
2021-05-29 20:56:05 +03:00
Dean Herbert
951fc5ef6e
Remove misleading comment and misplaced bug fix
...
This shouldn't be fixed in a test scene; the underlying issue should be
fixed in actual game code.
2021-05-29 15:39:13 +09:00
Dean Herbert
9b239e308b
Merge branch 'master' into beatmap-skin
2021-05-29 15:36:43 +09:00
ekrctb
265dfe5416
Add test case of DHO setting LifetimeStart in OnApply
2021-05-28 21:51:48 +09:00
ekrctb
68c5f4813e
Add test of lifetime update on DefaultsApplied
2021-05-28 21:35:26 +09:00
Dean Herbert
8652ac05db
Merge branch 'editor-exit-stability' into non-nullable-beatmapset-files
2021-05-28 18:58:35 +09:00
Dean Herbert
ba80361c4c
Fix tests that were previously doing reference comparisons
2021-05-28 18:38:50 +09:00
Dean Herbert
6268bbea85
Merge branch 'master' into fix-skin-sample-lookup
2021-05-28 14:47:35 +09:00
Dean Herbert
581a86b91a
Revert "Revert "Fix editor tests failing due to empty files being specified""
...
This reverts commit 1af684c4b2
.
2021-05-28 14:33:06 +09:00
Dean Herbert
f1b5aced6f
Merge branch 'master' into editor-exit-stability
2021-05-28 14:32:32 +09:00
Dean Herbert
1af684c4b2
Revert "Fix editor tests failing due to empty files being specified"
...
This reverts commit fdbd421040
.
2021-05-28 14:15:28 +09:00
Dan Balasescu
1ffafdd854
Merge branch 'master' into single-bind-reset-button
2021-05-27 23:55:28 +09:00
Dan Balasescu
1a0ace8d58
Merge branch 'master' into fix-slow-load-test-failure
2021-05-27 23:15:42 +09:00
Dan Balasescu
0a3d3bc006
Merge pull request #12958 from peppy/fix-invalid-ssdq-access
...
Fix `BeatmapCarousel` accessing `ScreenSpaceDrawQuad` of non-loaded children
2021-05-27 23:15:06 +09:00
Dan Balasescu
6ddb2062cf
Merge pull request #13214 from peppy/fix-multiplayer-leaderboard-test-failure
...
Fix test failure in `TestSceneMultiplayerGameplayLeaderboard`
2021-05-27 22:44:05 +09:00
Dan Balasescu
f45c934dd5
Merge pull request #13213 from peppy/fix-storyboard-outro-test-failure
...
Fix test failures in `TestSceneStoryboardWithOutro`
2021-05-27 21:51:13 +09:00
Dean Herbert
121dd175e6
Fix test failure in TestSceneMultiplayerGameplayLeaderboard
...
The transfer of users was not accounting for the fact that the
`StartPlay` calls are now scheduled and not necessarily run in time.
2021-05-27 19:57:21 +09:00
Dean Herbert
bcf1e3db1e
Fix test failures in TestSceneStoryboardWithOutro
...
Test was not accounting for the fact that the results may not have
loaded in time.
2021-05-27 19:45:55 +09:00
Dean Herbert
a2ed85bf46
Fix broken formatting
2021-05-27 19:34:39 +09:00
Dean Herbert
0c4d4ee0d2
Fix collection import tests deadlocking due to TaskCompletionSource
continuation triggering host disposal
2021-05-27 19:16:22 +09:00
Gagah Pangeran Rosfatiputra
0b600db814
revert back main page test
2021-05-27 16:24:05 +07:00
Gagah Pangeran Rosfatiputra
820310543d
fix spacing style
2021-05-27 14:53:22 +07:00
Dean Herbert
aa23c4a4b9
Merge branch 'master' into keyboard_shortcuts
2021-05-27 16:30:34 +09:00
Gagah Pangeran Rosfatiputra
b55ac413e7
add many scenario of main page layout
2021-05-27 14:20:36 +07:00
Dean Herbert
5c44083856
Fix test potentially not waiting for drawable beatmaps to be loaded
2021-05-27 16:12:49 +09:00
Dean Herbert
c39ea85701
Fix TestSceneSkinnableSound
not doing DI correctly
2021-05-27 15:42:25 +09:00
Dean Herbert
70a844ac10
Remove allowFallback
parameters completely
2021-05-27 14:50:42 +09:00
Craftplacer
2166ab87c6
Change base type of tests
...
Fixes missing API property
2021-05-27 01:47:00 +02:00
Gagah Pangeran Rosfatiputra
649163e13b
Merge branch 'master' into main-page-wiki
2021-05-26 23:51:49 +07:00
Dean Herbert
74fc0a17d5
Remove unused using statement
2021-05-27 00:55:06 +09:00
Dean Herbert
c0a8382175
Remove local API construction
2021-05-27 00:12:22 +09:00
Gagah Pangeran Rosfatiputra
22a5af750e
fix test link external
2021-05-26 20:25:48 +07:00
Dean Herbert
8e923a5d8f
Instantiate immediately, rather than waiting for instantiation
2021-05-26 22:24:51 +09:00
Gagah Pangeran Rosfatiputra
fbfbd99223
change document url test to dev server
2021-05-26 19:20:39 +07:00
Dean Herbert
878079d3d7
Fix correct beatmap not being set if running test alone
2021-05-26 19:08:00 +09:00
Dean Herbert
a77de24746
Fix SlowLoadPlayer
potentially not being instantiated in time for test
2021-05-26 18:58:18 +09:00
Dean Herbert
14a4095140
Merge branch 'master' into beatmap-skin
2021-05-26 18:39:47 +09:00
Dean Herbert
7c9383b586
Combine RestorableKeyBindingRow
back into KeyBindingRow
2021-05-26 18:17:28 +09:00
Gagah Pangeran Rosfatiputra
71f77eb902
fix image test
2021-05-26 15:04:04 +07:00
Dean Herbert
98fa5b67d6
Merge branch 'master' into single-bind-reset-button
2021-05-26 17:01:16 +09:00
Dean Herbert
52ca2f4797
Merge branch 'master' into chat-mention
2021-05-26 16:00:26 +09:00
Swords
d5feb8353d
Formatting, renaming
2021-05-25 21:37:08 +10:00
Swords
d9f5b578bf
Restore class names
2021-05-25 21:08:40 +10:00
Dean Herbert
a249bb9e69
Merge branch 'master' into realm-key-binding-store
2021-05-25 17:18:33 +09:00
Dean Herbert
df703b68ec
Merge branch 'master' into realm-key-binding-store
2021-05-25 13:41:48 +09:00
Gagah Pangeran Rosfatiputra
2e6d463901
add test link with title
2021-05-24 20:45:47 +07:00
Dean Herbert
37f6ceef79
Add test coverage
2021-05-24 21:57:04 +09:00
Swords
518999ffab
Renaming files
2021-05-24 22:49:40 +10:00
Dean Herbert
29e1737f0d
Merge branch 'master' into mbd-beatmap-set-cover
2021-05-24 15:51:03 +09:00
Gagah Pangeran Rosfatiputra
0448f6fdb3
add main page markdown
2021-05-25 13:21:08 +07:00
Gagah Pangeran Rosfatiputra
b8a5b5aaf8
add test for image block and inline image
2021-05-23 17:22:31 +07:00
Salman Ahmed
afb33f1641
Remove no longer necessary test case
2021-05-21 20:21:50 +03:00
Salman Ahmed
4f6de6fdc6
Implement GetSkin()
for other working beatmaps
2021-05-21 20:21:29 +03:00
Dan Balasescu
5ad41ded94
Merge branch 'master' into fix-dho-lmc
2021-05-21 19:11:57 +09:00
Dean Herbert
f335337e5d
Merge pull request #12851 from vininew921/applause-stops-on-score-switch
...
Fix applause sound stopping after switching scores
2021-05-21 18:49:59 +09:00
Dean Herbert
2958b9adf4
Merge branch 'master' into import-from-stable-select-location
2021-05-21 17:37:34 +09:00
Dean Herbert
1ca563e831
Merge branch 'master' into applause-stops-on-score-switch
2021-05-21 17:28:28 +09:00
Dean Herbert
8085a54205
Add test coverage of different grade types to TestSceneResultsScreen
2021-05-21 17:28:25 +09:00
Gagah Pangeran Rosfatiputra
49aa0f3a18
initial main page
2021-05-21 10:04:45 +07:00
Bartłomiej Dach
f35a07fee7
Rename method for better comprehension
2021-05-20 20:47:50 +02:00
Bartłomiej Dach
b521405ec8
Trim redundant string interpolation
2021-05-20 20:46:18 +02:00
Gagah Pangeran Rosfatiputra
092d0f9b76
add breadcrumb header test scene
2021-05-21 01:21:31 +07:00
Salman Ahmed
c0dfe37965
Remove unused using directive
2021-05-20 21:08:36 +03:00
Salman Ahmed
eaae9a1b67
Remove unrequired null conditional
2021-05-20 21:08:31 +03:00
Salman Ahmed
262a27610c
Improve components assertion logic
2021-05-20 20:47:40 +03:00
Dan Balasescu
527847596e
Merge pull request #12884 from peppy/ternary-menu-item-refactor
...
Create base implementations of the two most common `TernaryStateMenuItem`s
2021-05-20 21:02:15 +09:00
Gagah Pangeran Rosfatiputra
1ad3aee126
add article page test wiki overlay
2021-05-20 17:49:20 +07:00
Dean Herbert
df5970fab4
Create base implementations of the two most common TernaryStateMenuItem
s
2021-05-20 19:34:53 +09:00
smoogipoo
a74405d0ed
Merge branch 'master' into restructure-spectator-client
2021-05-20 18:53:42 +09:00
smoogipoo
9d07749959
Improve implementation of TestSpectatorClient
...
There was a lot of weirdness here, such as storing the playing users,
clearing the playing users from test scenes (!!), and storing the users
being wathed.
This was all a thing because the previous implementation overrode the
base method implementations, which is no longer a thing.
2021-05-20 17:41:46 +09:00
Dean Herbert
fdbd421040
Fix editor tests failing due to empty files being specified
2021-05-20 17:09:55 +09:00
Gagah Pangeran Rosfatiputra
1109970278
add more test for Wiki Header
2021-05-20 14:24:28 +07:00
ekrctb
3018a41ab5
Remove redundant string interpolation
2021-05-20 16:00:49 +09:00
smoogipoo
6beeb7f7c4
Rename SpectatorStreamingClient -> SpectatorClient
2021-05-20 15:55:07 +09:00
smoogipoo
d197a7f6f5
Rename multiplayer client classes
2021-05-20 15:39:45 +09:00
ekrctb
abf96db545
Add regression test for the pattern of using DHO proxy in LifetimeManagementContainer
2021-05-20 15:27:08 +09:00
Dean Herbert
80a714a9c4
Merge pull request #12857 from Joehuu/dev-register-no-warning
...
Don't show warning screen when registering on dev server
2021-05-20 14:05:53 +09:00
Dean Herbert
f1fd40dcca
Fix test not working for various reasons
2021-05-20 13:19:00 +09:00
Joseph Madamba
85a3027f1b
Add failing test
2021-05-19 13:58:41 -07:00
Salman Ahmed
97c8499884
Add test coverage
2021-05-19 23:01:41 +03:00
Salman Ahmed
71da960000
Extract assert step addition out of assertion method
2021-05-19 22:53:22 +03:00
Salman Ahmed
21ca9c8431
Merge branch 'master' into beatmap-skin
2021-05-19 22:39:32 +03:00
Salman Ahmed
6fc06a10a1
Add extensible test scene for beatmap skins fallback instead
2021-05-19 21:52:29 +03:00
Dean Herbert
363aec8179
Merge branch 'master' into hit-error-skinnable
2021-05-20 01:51:45 +09:00
Dean Herbert
b33d5e7a7a
Add new test and assertions to existing DialogOverlay
test
2021-05-19 17:04:45 +09:00
Vinicius Barbosa
4f397ae7f5
Merge branch 'master' into applause-stops-on-score-switch
2021-05-19 09:52:31 +02:00
Dean Herbert
87833bfb61
Merge pull request #12736 from EVAST9919/news-sidebar-new
...
Implement NewsSideBar component
2021-05-19 16:29:52 +09:00
smoogipoo
e8bc2cac5b
Fix test not being marked as headless
2021-05-19 13:36:39 +09:00
Dan Balasescu
6717355fbe
Merge pull request #12627 from ekrctb/always-use-lifetime-entry
...
Always use lifetime entry to manage hit objects in HitObjectContainer
2021-05-19 13:12:01 +09:00
Andrei Zavatski
24af86689f
Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new
2021-05-18 22:18:52 +03:00
Vinicius Barbosa
d05ffdf120
Added constants for delay value
2021-05-18 20:19:18 +02:00
Dan Balasescu
ef81bdf63f
Merge branch 'master' into always-use-lifetime-entry
2021-05-18 20:10:12 +09:00
ekrctb
ee9fe3c4be
Revert "Add failing test showing lifetime not recomputed with pooled objects"
...
This reverts commit b88e5a31
2021-05-18 19:55:44 +09:00
smoogipoo
ab6a79f84c
Simplify
2021-05-18 19:15:46 +09:00
smoogipoo
97f4f7bbd1
Remove Component inheritance
2021-05-18 18:59:45 +09:00
smoogipoo
633f841a0f
Rename to HitObjectUsageEventBuffer
2021-05-18 18:57:02 +09:00
smoogipoo
a31a6947bb
Add test
2021-05-18 18:49:05 +09:00
Salman Ahmed
d1272d5e13
Group all skinnable test scenes to one TestSceneSkinnableHUDComponents
2021-05-18 12:38:06 +03:00
Dean Herbert
c885ad87d5
Update HitErrorDisplay
tests
2021-05-18 15:12:29 +09:00
Dean Herbert
06389c08dc
Add basic test to show data how one would expect it to be displayed
2021-05-18 13:11:22 +09:00
Bartłomiej Dach
400984457c
Fix weird behaviour in test scene
...
Due to a callback set up in another place, clicking away from the 2022
year after launching the test scene would remove the 2022 button
(because the callback was returning metadata without it). For simplicity
just trim the 2022 year to make sure both test scenes use the same
consistent set of years.
2021-05-17 19:16:30 +02:00
Lucas A
ed4c025c7e
Fix other tests and move TestPlaySongSelect class declaration.
2021-05-17 12:55:59 +02:00
Lucas A
fe11426238
Disable appearance of the stable import prompt waiting for user interaction in tests, which caused them to fail.
2021-05-17 12:55:59 +02:00
Dean Herbert
da0913ca2d
Make SongProgress
a skinnable component
2021-05-17 18:52:56 +09:00
Andrei Zavatski
fc6e65b7db
Delete TestSceneNewsSideBar.cs
2021-05-17 12:02:06 +03:00
Andrei Zavatski
01090de1fd
Fix filenames does not match contained type
2021-05-17 11:55:55 +03:00
Andrei Zavatski
586c5c7365
Emulate year changes in the test scene
2021-05-17 11:36:53 +03:00
Dean Herbert
ae1e62288d
Reorder tests to not have the first test show nothing
2021-05-17 16:16:50 +09:00
Dean Herbert
22561cda19
MonthDropdown -> MonthSection
2021-05-17 16:02:21 +09:00
Dean Herbert
50e2b5a327
SideBar -> Sidebar
2021-05-17 16:00:36 +09:00
Swords
264d8b9b86
Finishing requested changes, and tidy up
2021-05-16 14:48:00 +10:00
Andrei Zavatski
881d82ccb6
Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new
2021-05-15 19:08:48 +03:00
Swords
b5e1f78c06
Merge branch 'master' into single-bind-reset-button
2021-05-15 20:29:56 +10:00
Swords
c282f0e603
Fixing tests
...
For some reason moving the mouse and clicking doesn't work with "dotnet test", but works when you run the osu.Game.Tests project.
2021-05-15 19:42:33 +10:00
Dean Herbert
dc56250a3c
Merge branch 'master' into player-loader-star-rating
2021-05-15 15:39:57 +09:00
Dean Herbert
94b7e89ac0
Merge pull request #12747 from frenzibyte/current-star-rating
...
Allow changing current star difficulty of a `StarRatingDisplay`
2021-05-15 15:39:39 +09:00
Dean Herbert
bdcb1a624e
Merge pull request #12759 from Naxesss/beatmap-verifier-context
...
Encapsulate check arguments in context object
2021-05-15 15:39:12 +09:00
Swords
ecc260030a
Merge branch 'master' into single-bind-reset-button
2021-05-15 12:05:42 +10:00
Swords
304caf8bdf
Adding Requested changed
2021-05-15 11:24:08 +10:00
Bartłomiej Dach
7665bdfbbb
Merge branch 'master' into null-assignment-warning-enable
2021-05-15 01:08:34 +02:00
Bartłomiej Dach
d581e0a252
Ignore possible nulls in NotifyCollectionChangedArgs
...
Safe to access by the virtue of the preceding case labels on
`args.Action`. And they're in test code anyways.
2021-05-15 00:09:34 +02:00
Bartłomiej Dach
e62e473bb2
Ignore possible null in multiplayer test
...
A null value will fail the test anyhow.
2021-05-15 00:09:34 +02:00
Bartłomiej Dach
b51d038088
Ignore possible path-related nulls
...
They're all in test code anyway, so any issue there will cause a test to
fail.
2021-05-15 00:09:34 +02:00
Bartłomiej Dach
f2d0f7db99
Remove list null-checks in LogoTrackingContainer
test
...
If the null-checks were tripped, the test would crash anyway. It is not
possible to call `.Any()` and get a valid result instead of an exception
on a null reference.
2021-05-15 00:09:34 +02:00
Bartłomiej Dach
c9facf70f9
Use conditional nullability attribute
...
As it turns out, C# 8 provides an attribute that allows annotating that
an `out` parameter's nullability depends on the method's return value,
which is exactly what is desired here.
2021-05-15 00:09:34 +02:00
Bartłomiej Dach
1c92b3a8f5
De-duplicate star rating display creation in test
2021-05-14 22:03:44 +02:00
Swords
843da30f9d
Reformatting
2021-05-15 01:52:16 +10:00
Swords
6a52622b3f
Merge branch 'single-bind-reset-button' of https://github.com/holaswords/osu into single-bind-reset-button
2021-05-15 01:31:40 +10:00
Swords
1603b92211
Reformatting
2021-05-15 01:30:54 +10:00
Swords
85174793b1
Merge branch 'master' into single-bind-reset-button
2021-05-15 01:07:32 +10:00
Swords
0725088fde
Well it works, just pretty ugly looking.
2021-05-15 01:01:17 +10:00
Salman Ahmed
93007c1635
Merge branch 'current-star-rating' into player-loader-star-rating
2021-05-14 16:06:00 +03:00
Salman Ahmed
6cc678f497
Remove nullability and transition support from star rating display
2021-05-14 16:05:40 +03:00
Salman Ahmed
db361efecf
Add test beatmap difficulty cache with calc. blocking support
2021-05-14 15:53:56 +03:00
Salman Ahmed
34aab11ff3
Add null star rating display test case
2021-05-14 14:25:46 +03:00
Salman Ahmed
0655825057
Separate changing star rating display to own test
2021-05-14 14:25:13 +03:00
Dean Herbert
9069db0743
Fix case of hitObjects
variables
2021-05-14 16:22:19 +09:00
Dean Herbert
48672f8afd
Add very basic test logic to ensure PlayerLoader
is present for playlists
2021-05-14 15:02:36 +09:00
Naxess
9860e482af
Use TestWorkingBeatmap
instead of null in tests
...
Fixes the warning that #12801 will give.
2021-05-14 05:32:52 +02:00
Andrei Zavatski
94543bf000
Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new
2021-05-13 16:00:46 +03:00
Dan Balasescu
d5b14b6b99
Merge branch 'master' into remove-skinnable-hud-classes
2021-05-13 21:06:48 +09:00
Dan Balasescu
746862dcb1
Merge pull request #12750 from peppy/skin-serialisation
...
Add skin editor saving / loading support
2021-05-13 20:58:03 +09:00
Naxess
94538b3842
Remove accidental whitespace
2021-05-13 12:56:36 +02:00
Dan Balasescu
a3869c02f4
Merge branch 'master' into fix-two-hovered-handles
2021-05-13 19:24:42 +09:00
Dean Herbert
c8b7cfc753
Merge branch 'skin-serialisation' into remove-skinnable-hud-classes
2021-05-13 19:05:08 +09:00
Naxess
19800f5f7f
Move IBeatmap
arg into context
2021-05-13 11:24:22 +02:00
Dean Herbert
e0e9106921
Enable autoplay in skin editor tests
2021-05-13 14:55:11 +09:00
Naxess
e7c7786db3
Merge branch 'master' into beatmap-verifier-context
2021-05-13 07:40:33 +02:00
Dean Herbert
8b9ac86d4b
Merge branch 'master' into skin-serialisation
2021-05-13 12:35:06 +09:00
smoogipoo
5b03092968
Fix possible test failure
2021-05-13 11:53:50 +09:00
Andrei Zavatski
13a956f6fc
Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new
2021-05-12 20:08:17 +03:00
Dean Herbert
55e1f97f59
Remove unused using statement
2021-05-12 19:06:40 +09:00
Dean Herbert
0a895fff15
Remove remaining test usage of SkinnableXXX
HUD components
2021-05-12 18:53:25 +09:00
Salman Ahmed
80e231d90a
Add failing test case
2021-05-12 11:42:55 +03:00
Dean Herbert
c6f0a6aed3
Merge pull request #12538 from smoogipoo/multiplayer-spectator-screen
...
Implement the multiplayer spectator screen
2021-05-12 17:24:35 +09:00
smoogipoo
273cd18b8a
Use test streaming client in gameplay leaderboard test
2021-05-12 14:19:36 +09:00
smoogipoo
21fc0ba43b
Combine test spectator streaming client implementations
2021-05-12 13:05:02 +09:00
Naxess
c13b93e6f1
Replace IWorkingBeatmap
arg with BeatmapVerifierContext
in checks
...
This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.
See next commit for example.
2021-05-12 02:29:18 +02:00
Andrei Zavatski
085c3d067f
Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new
2021-05-11 23:41:45 +03:00
Andrei Zavatski
b0297c6324
Fix incorrect no posts handling and add corresponding test
2021-05-11 20:52:11 +03:00
Andrei Zavatski
822d99e69f
Remove pointless test scenes
2021-05-11 20:42:13 +03:00
Dean Herbert
048677846b
Change HealthDisplay
to be a CompositeDrawable
2021-05-11 23:10:30 +09:00
Andrei Zavatski
b79a0237a3
Fix TestSceneNewsYearsPanel error
2021-05-11 16:54:19 +03:00
Andrei Zavatski
c2ba16f977
Use relative sizing for MonthDropdown
2021-05-11 16:51:59 +03:00
Andrei Zavatski
208224cc0d
CI fixes
2021-05-11 16:08:09 +03:00
Andrei Zavatski
705aad262a
Rename MonthPanel to MonthDropdown
2021-05-11 15:42:40 +03:00
Andrei Zavatski
0a9c3c9413
Move metadata change logic to it's own method
2021-05-11 15:39:50 +03:00
Andrei Zavatski
9603712aa1
Cache metadata in NewsSideBar
2021-05-11 15:33:27 +03:00
Andrei Zavatski
82436334b2
Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new
2021-05-11 13:52:51 +03:00
smoogipoo
f5bc389998
Fix flaky tests
2021-05-11 19:31:32 +09:00
smoogipoo
bc4213eea1
Add test for changing back to idle on deletion
2021-05-11 19:26:58 +09:00
smoogipoo
7fe8737d94
Add failing tests
2021-05-11 19:21:44 +09:00
smoogipoo
811282a975
Add failing test
2021-05-11 19:01:41 +09:00
Dean Herbert
61ea3f2e64
Remove unnecessary test step creating needless skins
2021-05-11 18:39:15 +09:00
Dean Herbert
2396ba42a6
Change HealthDisplay
to be a CompositeDrawable
2021-05-11 18:39:14 +09:00
Dean Herbert
004798d61d
Update Legacy components to not require skin in ctor
2021-05-11 18:39:14 +09:00
smoogipoo
10a4a5decb
Merge branch 'master' into multiplayer-spectator-screen
2021-05-11 17:33:09 +09:00
Dan Balasescu
7d9cdd3bc2
Merge branch 'master' into skin-components-list
2021-05-11 17:27:48 +09:00
Salman Ahmed
004ce95f33
Merge branch 'current-star-rating' into player-loader-star-rating
2021-05-11 09:53:10 +03:00
smoogipoo
7c8dd91674
Rename test to better match tested class
2021-05-11 09:29:15 +09:00
Dean Herbert
6bb52ebcf8
Merge pull request #12570 from frenzibyte/corner-rotation-controls
...
Add rotation controls to editor selection box corners
2021-05-10 23:09:44 +09:00
Andrei Zavatski
220eef0351
Remove overcomplicated date logic in MonthPanel
2021-05-10 17:00:18 +03:00
Andrei Zavatski
fbf8b198cd
Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new
2021-05-10 16:47:15 +03:00
Dan Balasescu
e7355da201
Merge branch 'master' into osu-markdown
2021-05-10 20:02:04 +09:00
Dean Herbert
2ecd638f7f
Merge branch 'master' into skin-components-list
2021-05-10 18:13:10 +09:00
Andrei Zavatski
0d243be457
CI fixes
2021-05-10 10:07:43 +03:00
Andrei Zavatski
4b97224932
Implement NewsSideBar component
2021-05-10 09:53:52 +03:00
Dean Herbert
97e72849af
Fix regressed HitErrorDisplay
behaviour (and localise binding to meter implementations)
2021-05-10 15:24:13 +09:00
Salman Ahmed
ca772b60b1
Use regular test steps rather than one-time set up and scheduling
2021-05-10 08:56:30 +03:00
Salman Ahmed
301dab1ce8
Refactor StarRatingDisplay
to be mutable with a current bindable
2021-05-10 08:56:30 +03:00
Andrei Zavatski
7971a2ef48
Implement MonthPanel component
2021-05-10 08:47:00 +03:00
Andrei Zavatski
7ca3e13712
Implement basic years panel
2021-05-10 07:43:01 +03:00
Dean Herbert
52ce16f9f1
Merge branch 'master' into player-loader-star-rating
2021-05-10 12:46:10 +09:00
Dean Herbert
9ba412d27e
Add the osu! logo to the test scene
...
Makes no sense to add a test intended to test visual behaviour with one
of the main elements missing. Not sure how you would be able to test the
flow with the logo's presence.
2021-05-10 12:44:08 +09:00
Dean Herbert
b7acf9de52
Make test work without manually clicking things
2021-05-10 12:36:56 +09:00
Dean Herbert
2b90bc4f1f
Remove unnecessary ruleset switching steps
2021-05-10 12:35:37 +09:00
Dean Herbert
0c973feb53
Tidy up test scene
2021-05-10 12:34:21 +09:00
Dean Herbert
3c3500d070
Merge branch 'skin-components-bind-outwards-health' into remove-hud-overlay-unused-pieces
2021-05-10 12:23:18 +09:00
Dean Herbert
1d38fa29b5
Remove unused using statement
2021-05-10 12:23:04 +09:00
Dean Herbert
1bbbe80420
Fix missing instances of HealthProcessor
caching
2021-05-10 12:22:24 +09:00
Dean Herbert
132bb7832d
Fix some regressions when updating test scenes
2021-05-10 12:06:33 +09:00
Dean Herbert
b274fdf20d
Merge branch 'master' into skin-components-bind-outwards-health
2021-05-10 11:13:44 +09:00
Joseph Madamba
8964d51de9
Add ability to sort by source in song select
2021-05-09 14:10:38 -07:00
Dean Herbert
2bcf1ed306
Merge pull request #12715 from Cublibre/fix-early-exit-crash
...
Fix InvalidOperationException when exiting a map at the end
2021-05-09 23:21:19 +09:00
Bartłomiej Dach
eb716455b7
Merge branch 'master' into skin-components-bind-outwards-accuracy
2021-05-09 12:13:18 +02:00
Andrei Zavatski
879c08e666
Use UntilStep instead of Assert to check button visibility
2021-05-09 10:06:36 +03:00
Andrei Zavatski
f0c1784d05
Use FirstOrDefault instead of First
2021-05-09 09:12:37 +03:00
Swords
1a465c60ca
Rename Tests
2021-05-09 16:07:18 +10:00
Ibby
075350e125
Adding a reset button to individual keybinds
2021-05-09 15:51:17 +10:00
Andrei Zavatski
8868439ce4
Another approach to fix test scene failure
2021-05-09 06:49:12 +03:00
Andrei Zavatski
0818deac17
Fix potential test scene failure due to showMoreButton not being loaded in time
2021-05-09 06:06:34 +03:00
Christine Chen
ae2b5a0806
Actually test that player was exited
2021-05-08 22:42:14 -04:00
Andrei Zavatski
342c5a5938
Add tests to indicate the issue
2021-05-09 04:49:40 +03:00
Salman Ahmed
8fba655d2e
Allow changing ruleset during test
2021-05-08 23:02:38 +03:00
Bartłomiej Dach
efb9164658
Restore previous test scene logic
2021-05-08 21:35:12 +02:00
Bartłomiej Dach
0bc6a026eb
Merge branch 'master' into skin-components-bind-outwards-accuracy
2021-05-08 21:08:53 +02:00
Salman Ahmed
f701c331f2
Add initial fade in to the metadata display
...
Avoids first frame discrepancies from appearing in the test scene, those can be delt with later on, if needed.
2021-05-08 21:19:46 +03:00
Bartłomiej Dach
dec5400c0a
Merge branch 'master' into skin-components-bind-outwards-score-display
2021-05-08 19:58:19 +02:00
Bartłomiej Dach
9e0ea494fd
Merge branch 'master' into skin-components-bind-outwards
2021-05-08 19:04:56 +02:00
Christine Chen
25312b3e88
Don't restart completion delegate on exit, revert exit behavior to lazer
2021-05-08 11:47:44 -04:00
Salman Ahmed
ca55287dd0
Pass empty facade and replace random property with method instead
2021-05-08 18:43:45 +03:00
Salman Ahmed
3575d9847c
Use regular test steps rather than one-time set up and scheduling
2021-05-08 18:21:29 +03:00
Salman Ahmed
d9605e8070
Remove test scene description
2021-05-08 18:18:23 +03:00
Salman Ahmed
26c0010fe6
Fix test not handling 0 beatmap sets
2021-05-08 13:03:50 +03:00
Salman Ahmed
dca5efc59a
Remove no longer necessary ruleset info requirement
2021-05-08 13:00:39 +03:00
Salman Ahmed
0410edecaf
Refactor StarRatingDisplay
to be mutable with a current bindable
2021-05-08 12:55:34 +03:00
Salman Ahmed
b4801faf32
Pass ruleset info to constructor instead
...
Follows the way working beatmap is passed, not sure why mods are passed as a bindable though, don't wanna bother too much with that.
2021-05-08 11:57:13 +03:00
Salman Ahmed
169a283402
Add visual test scene
2021-05-08 11:47:18 +03:00
Christine Chen
8c564a69ed
Fix InvalidOperationException when exiting a map at the end
2021-05-07 21:11:03 -04:00
Dean Herbert
1cb10c2a22
Remove unnecessary binding logic from HUDOverlay
2021-05-07 17:51:46 +09:00
Dean Herbert
a7acecc52b
Merge branch 'skin-components-bind-outwards-health' into remove-hud-overlay-unused-pieces
2021-05-07 17:51:41 +09:00
Dean Herbert
3044b1c432
Add missing cache rules
2021-05-07 17:50:44 +09:00
Dean Herbert
6c255a0572
Fix drain start time being weirdly incorrect
2021-05-07 17:47:33 +09:00
Dean Herbert
8e78cac058
Fix HealthProcessor
cached as derived type in test
2021-05-07 17:31:29 +09:00
Dean Herbert
04d35826a3
Merge branch 'skin-components-bind-outwards-accuracy' into remove-hud-overlay-unused-pieces
2021-05-07 17:25:39 +09:00
Dean Herbert
84a4ff333e
Update skin editor test scene to cache a ScoreProcessor
2021-05-07 17:22:56 +09:00
Dean Herbert
755588258e
Update HealthDisplay
components to use DI to attach data source
2021-05-07 17:22:45 +09:00
Dean Herbert
4ac234bf7f
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-accuracy
2021-05-07 17:15:57 +09:00
Dean Herbert
6dc591fc44
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-score-display
2021-05-07 17:15:37 +09:00
Dean Herbert
9d27b11e49
Update skin editor test scene to cache a ScoreProcessor
2021-05-07 17:10:31 +09:00
Dean Herbert
01eff7f316
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-score-display
2021-05-07 16:30:08 +09:00
Dean Herbert
93f10330e3
Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-accuracy
2021-05-07 16:29:10 +09:00
Dean Herbert
ad398165a2
Update AccuracyCounter
components to use DI to attach data source
2021-05-07 16:27:25 +09:00
Dean Herbert
17b93361d5
Merge branch 'master' into skin-components-bind-outwards
2021-05-07 16:20:24 +09:00
Dean Herbert
a2e4fb5b6b
Update ScoreCounter
components to bind outwards
2021-05-07 16:16:48 +09:00
Dean Herbert
165f443ab5
Merge branch 'master' into add-missing-author-links
2021-05-07 14:32:44 +09:00
Dean Herbert
48b834d12a
Merge branch 'master' into mbd-beatmap-set-cover
2021-05-07 13:19:17 +09:00
Gagah Pangeran Rosfatiputra
67f51959db
Merge branch 'master' into osu-markdown
2021-05-06 16:23:20 +07:00
Gagah Pangeran Rosfatiputra
91283d41ce
add paragraph test
2021-05-06 15:13:43 +07:00
Dean Herbert
aff32b0d19
Merge branch 'master' into skin-components-list
2021-05-06 14:17:33 +09:00
Bartłomiej Dach
3cac837acf
Merge branch 'master' into skin-bindables
2021-05-05 20:16:27 +02:00
Dean Herbert
cb8bda2248
Merge pull request #12503 from Denrage/split-BufferedWedgeInfo
2021-05-06 03:16:16 +09:00
Dean Herbert
fe9ade6754
Rename Container to DisplayedContent
2021-05-06 02:14:04 +09:00
Denrage
b6b9a69601
Removed unnecessary class for wrapping
2021-05-05 18:50:49 +02:00
Dean Herbert
4ef901d08d
Remove unnecessary redirection property to Container.Info
2021-05-05 21:07:49 +09:00
Salman Ahmed
bf6e98345c
Remove and update pre-existing test cases
2021-05-05 14:23:18 +03:00
Dean Herbert
805ef621e9
Merge branch 'master' into play-storyboard-outro
2021-05-05 17:51:16 +09:00
Dean Herbert
3cc9bad979
Actually check for correct state of fade content in rewind test
2021-05-05 17:49:33 +09:00
Dean Herbert
62fa638515
Merge pull request #12665 from frenzibyte/stable-frame-sort
2021-05-05 14:35:25 +09:00
Salman Ahmed
cd6d070b4a
Consider "combo offsets" as legacy logic and separate from combo information
2021-05-05 07:43:08 +03:00
Salman Ahmed
78794935b4
Handle combo colour lookups in other skins
2021-05-05 07:15:11 +03:00
Christine Chen
1d4a8bc0ae
Add visual test for rewinding
2021-05-04 22:23:36 -04:00
Salman Ahmed
12c1ded7a8
Fix test scene broken on master
2021-05-05 00:28:49 +03:00
Bartłomiej Dach
f7d9fb094e
Reword & clarify comments
2021-05-04 22:59:10 +02:00
Salman Ahmed
1ac80d42f9
Merge branch 'master' into corner-rotation-controls
2021-05-04 23:53:23 +03:00
Bartłomiej Dach
9734758237
Simplify test case further
2021-05-04 22:48:57 +02:00
Salman Ahmed
45c0b74151
Use LINQ select for data assigning for simplicity
...
To avoid having to read through all of frames and ensure nothing is failing there
2021-05-04 23:41:50 +03:00
Salman Ahmed
4ceb9b1562
Avoid randomizing and overestimating logic with simple hardcoding
...
Not sure what was in my mind while I was pushing that..
2021-05-04 23:36:50 +03:00
Bartłomiej Dach
2fd596d53c
Merge branch 'master' into mbd-beatmap-set-cover
2021-05-04 21:14:48 +02:00
Bartłomiej Dach
040d393dd4
Add visual test case for crossfade behaviour
2021-05-04 21:12:25 +02:00
ekrctb
39bccc5048
Revert "Adopt HitObjectContainer change in a test"
...
This reverts commit f55aa016
2021-05-04 16:45:24 +09:00
Salman Ahmed
e00af3e71d
Add test coverage
2021-05-04 09:45:59 +03:00
Dean Herbert
bb9fa1a25e
Merge branch 'master' into play-storyboard-outro
2021-05-04 14:01:34 +09:00
Salman Ahmed
8abff4881b
Hide the corresponding rotation handle when holding scale handle
2021-05-04 07:31:55 +03:00
Dean Herbert
4f12ae2711
Merge branch 'master' into split-BufferedWedgeInfo
2021-05-04 13:28:42 +09:00
Gagah Pangeran Rosfatiputra
356b1e9a2d
add emphases test
2021-05-04 05:43:59 +07:00
Bartłomiej Dach
f52375eed2
Merge branch 'master' into mbd-beatmap-set-cover
2021-05-03 15:58:13 +02:00
Bartłomiej Dach
b9220d4dc7
Fix possible multiple enumeration
2021-05-03 15:57:57 +02:00
Dean Herbert
4f8240f19a
Merge branch 'master' into corner-rotation-controls
2021-05-03 18:02:23 +09:00
Dean Herbert
625890381f
Update ComboCounter
components to use DI to attach data source
2021-05-03 17:43:00 +09:00
Dean Herbert
fdd0713988
Merge branch 'fix-selection-handler-visibility' into skin-bindables
2021-05-03 17:40:03 +09:00
Dean Herbert
3268a75f05
Remove intermediate container to fix tests
2021-05-03 17:35:56 +09:00
Dean Herbert
6da4105da6
Remove Sync namespace (feels unnecessary)
2021-05-03 13:38:53 +09:00
Dean Herbert
e0c129ca85
Merge branch 'master' into multiplayer-spectator-screen
2021-05-03 13:08:14 +09:00
Gagah Pangeran Rosfatiputra
b97d3f2af1
add heading test scene
2021-05-03 09:35:26 +07:00
Gagah Pangeran Rosfatiputra
88aaa9b332
add inline code colour
...
Reference : 31579d45aa/resources/assets/less/bem/osu-md.less (L12-L17)
2021-05-02 22:35:30 +07:00
Gagah Pangeran Rosfatiputra
6585dd3a3e
add image test
2021-05-23 16:30:41 +07:00
Gagah Pangeran Rosfatiputra
8f1b48d766
add test for notice box
2021-05-23 17:29:48 +07:00
Gagah Pangeran Rosfatiputra
5c1c43dea3
add link assert
2021-05-25 10:44:22 +07:00
Gagah Pangeran Rosfatiputra
98af998978
add test markdown class
2021-05-25 09:56:26 +07:00
Gagah Pangeran Rosfatiputra
a38c33841a
add test scene wiki container
2021-05-23 16:30:41 +07:00
Salman Ahmed
b145f46a0a
Merge branch 'master' into skin-components-list
2021-04-30 21:10:55 +03:00
Dan Balasescu
e6eea73b8b
Merge branch 'master' into basic-compose-checks
2021-04-30 23:41:46 +09:00
Dean Herbert
a1e64f4e3c
Use the existing toolbox design
2021-04-30 14:41:06 +09:00
Gagah Pangeran Rosfatiputra
3681db491c
add long mixed list test
...
Copied from https://github.com/ppy/osu-wiki/blob/master/wiki/Tournaments/OWC/2020/en.md#tournament-rules
2021-04-30 11:21:20 +07:00
Dean Herbert
ae9d1dc40b
Add component list to main editor interface and enable basic placement
2021-04-30 13:10:42 +09:00
Dean Herbert
6442fb819f
Split out component from test scene and fix SongProgress
2021-04-30 13:10:42 +09:00
Dean Herbert
4770a64709
Add proof of concept components list
2021-04-30 13:10:42 +09:00
Gagah Pangeran Rosfatiputra
1582b0da88
add ordered list test
2021-04-30 10:43:19 +07:00
Dean Herbert
eeb66a955e
Merge branch 'master' into mbd-beatmap-set-cover
2021-04-30 08:14:33 +09:00
Dean Herbert
de73ac7cec
Allow skin editor to be invoked from any context
...
This is kind of how I see things working going forward, where the editor
can be applied to anything in the game which supports it (ie. a results
screen, gameplay screen, etc.) and it will immediately allow changing
the interface.
This adds a test scene which shows this working with gameplay.
2021-04-29 16:12:15 +09:00
Dean Herbert
74c6fdc4b8
Add DrawableRuleset
to the skin editor test to get a hit error meter to display
2021-04-29 16:12:15 +09:00
Dean Herbert
fd587a82ff
Replace abstract class with interface, attached to the actual components (not skinnable wrapper)
2021-04-29 16:12:15 +09:00
Dean Herbert
defa350aa7
Set defaults on SkinnableHUDComponent to cancel out relative size default
...
Specifying locally on each HUD component looks to make more sense.
2021-04-29 16:12:15 +09:00
Dean Herbert
1cb8fc9a24
Extract editor classes out of test namespace and add anchor support
2021-04-29 16:12:15 +09:00
Dean Herbert
74fb7cd180
Extract storable attributes to bindables
2021-04-29 16:12:15 +09:00
Dean Herbert
99b428ee4b
Add very basic skin editor test
2021-04-29 16:12:14 +09:00
Dean Herbert
fca173225a
Refactor editor selection/blueprint components to be generic
2021-04-29 16:12:14 +09:00
Dean Herbert
2d17219c8f
Setup basic test and classes for scale adjustment
2021-04-29 16:12:14 +09:00
Dean Herbert
5b009c21bb
Merge branch 'master' into abstract-blueprint-handling
2021-04-29 16:10:22 +09:00
Gagah Pangeran Rosfatiputra
171e954e89
add unordered list test
2021-04-29 13:48:00 +07:00
ekrctb
5aa522b1c2
Completely delegate DHO lifetime to Entry lifetime
...
A downside is lifetime update is not caught by LifetimeManagementContainer if used.
2021-04-29 14:38:01 +09:00
ekrctb
b88e5a31ea
Add failing test showing lifetime not recomputed with pooled objects
2021-04-29 14:38:01 +09:00
ekrctb
f55aa016be
Adopt HitObjectContainer change in a test
...
Non-pooled objects are attached as children only while alive
2021-04-29 14:38:01 +09:00
dependabot[bot]
1b3b07d6a9
Bump NUnit from 3.13.1 to 3.13.2
...
Bumps [NUnit](https://github.com/nunit/nunit ) from 3.13.1 to 3.13.2.
- [Release notes](https://github.com/nunit/nunit/releases )
- [Changelog](https://github.com/nunit/nunit/blob/v3.13.2/CHANGES.md )
- [Commits](https://github.com/nunit/nunit/compare/v3.13.1...v3.13.2 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-04-29 03:51:12 +00:00
Dean Herbert
6cadbd48dc
Merge pull request #12603 from smoogipoo/fix-score-processor-base-score
...
Fix bonus-only maps having only 700K base score
2021-04-28 17:30:58 +09:00
Dean Herbert
f3c7694eeb
Rename methods to match generally how these find-methods are named elsewhere
2021-04-28 16:57:52 +09:00
Dan Balasescu
53d93fecd1
Merge branch 'master' into fix-download-button-import-cancel-state
2021-04-28 16:51:31 +09:00
Dean Herbert
48d6c9ac4b
Move snap/divisor helper methods to inside ControlPointInfo
2021-04-28 16:47:30 +09:00
Dean Herbert
74bf4323d1
Merge pull request #12602 from smoogipoo/setting-source-custom-control
...
Add support for custom controls to SettingSourceAttribute
2021-04-28 16:39:17 +09:00
Dean Herbert
e71dbfd730
Add inline comment regarding remaining issues with classic scoring
2021-04-28 16:37:48 +09:00
Dean Herbert
8598a0968f
Update calculations in comments to match new logic
...
Mostly look to be errors that existed before this PR.
Co-authored-by: Endrik <enduslittlecomputer@gmail.com>
2021-04-28 16:29:23 +09:00
Dean Herbert
ac1534cda2
Add test covering existing button actually changing to LocallyAvailable
state
2021-04-28 15:54:40 +09:00
Gagah Pangeran Rosfatiputra
4e691ce4b0
add test link with inline text markdown
2021-04-28 11:01:54 +07:00
Gagah Pangeran Rosfatiputra
c09067c3d5
add OsuMarkdownTable
2021-04-28 10:53:12 +07:00
Gagah Pangeran Rosfatiputra
736eace00a
add OsuMarkdownQuoteBlock
...
Reference:
d56352aeef/resources/assets/less/base.less (L7-L10)
2021-04-28 10:11:29 +07:00
Gagah Pangeran Rosfatiputra
6a921af085
add OsuMarkdownSeparator
...
Reference
d56352aeef/resources/assets/less/bem/osu-md.less (L19-L21)
2021-04-28 09:23:05 +07:00
smoogipoo
61b7dc1e06
Fix bonus-only maps having 700K base score
2021-04-28 03:42:29 +09:00
smoogipoo
4e3ee77396
Add support for custom controls to SettingSourceAttribute
2021-04-28 02:51:24 +09:00
Dan Balasescu
5fc731967b
Merge pull request #12592 from ekrctb/fix-entry-lifetime
...
Fix Setting DHO's lifetime doesn't update its entry lifetime
2021-04-28 01:38:19 +09:00
Naxess
b8b6d0e861
Add tests for ClosestBeatDivisor
...
Used https://github.com/ppy/osu/pull/12558/files#diff-5c1f04c5b262ca3abbaf867aa91b62a60b66691323c286ad5aa0b75c153cc6ca as reference.
2021-04-27 16:54:47 +02:00
smoogipoo
baa6e845aa
Change to fluent assertions
2021-04-27 22:43:52 +09:00
smoogipoo
3b04aed491
Add failing test
2021-04-27 22:42:58 +09:00
Naxess
200352b750
Rename unsnap check templates
2021-04-27 13:56:05 +02:00
Dean Herbert
f2e56bd306
Refactor editor selection/blueprint components to be generic
2021-04-27 19:01:29 +09:00
ekrctb
003553aba3
Add test of HitObjectLifetimeEntry.KeepAlive behavior
2021-04-27 18:10:44 +09:00
Gagah Pangeran Rosfatiputra
6959f2a8cc
add OsuMarkdownFencedCodeBlock
...
Reference :
d56352aeef/resources/assets/less/bem/osu-md.less (L41-L45)
2021-04-27 16:01:32 +07:00
Gagah Pangeran Rosfatiputra
65aa01866e
add test scene for OsuMarkdownContainer
2021-04-27 14:38:21 +07:00
ekrctb
7980d16b4c
Add failing test showing the issue of DHO lifetime
2021-04-27 14:26:12 +09:00
Naxess
0f0870c8b8
Sort objects by time in concurrent check test
2021-04-27 00:36:26 +02:00
Naxess
ce258febf6
Rename CheckUnsnaps
-> CheckUnsnappedObjects
...
Will potentially have `CheckUnsnappedKiai` or similar later, so this is worth specifying.
Also consistent with `CheckConcurrentObjects`, which will likely have a `CheckConcurrentLines` later.
2021-04-26 20:32:44 +02:00
Naxess
b8cdcf56c0
Add concurrent object check tests
2021-04-26 20:22:24 +02:00
Naxess
71f880aa94
Fix duplicate code in unsnap test
2021-04-26 17:44:46 +02:00
Dean Herbert
5f6fd9ba13
Remove outdated dependency requirement in test
2021-04-26 19:07:42 +09:00
smoogipoo
94d0b06493
Expose mute adjustment instead
2021-04-26 19:01:30 +09:00
smoogipoo
4c5a5c449a
Merge branch 'multiplayer-spectator-screen' of https://github.com/smoogipoo/osu into multiplayer-spectator-screen
2021-04-26 17:35:37 +09:00
smoogipoo
6626e70c95
Pass in master clock instead of slave clock
2021-04-26 17:30:27 +09:00
Dean Herbert
120fb8974d
Combine more instances of test player IDs
2021-04-26 17:22:16 +09:00
smoogipoo
5b4cb71cc7
Change terminology from "slave" to "player clock"
2021-04-26 17:19:44 +09:00
Dean Herbert
737a15c2d4
Extract out test player IDs to constants
2021-04-26 17:04:39 +09:00
Dean Herbert
55f383c71e
Rename test to match new MultiSpectatorLeaderboard
class name
2021-04-26 16:48:40 +09:00
Dean Herbert
6d30a1a80f
Reference constant for test startup delay
2021-04-26 16:45:20 +09:00
Dean Herbert
2c1422b4f9
Add comment regarding teste edge case
2021-04-26 15:37:19 +09:00
Naxess
9178aa1d7d
Add unsnap check tests
2021-04-26 04:48:56 +02:00
Salman Ahmed
beee318acc
Add more distance between each hit object in editor selection test
...
To avoid potentially hovering over the rotation control instead of wherever the test desired to move the mouse to.
2021-04-26 01:45:52 +03:00
Salman Ahmed
334927ed35
Remove leftover step
2021-04-25 20:13:01 +03:00
Salman Ahmed
7490511ebf
Instantiate selection box on SetUp
2021-04-25 20:03:15 +03:00
Salman Ahmed
11318fd9fc
Add test coverage
2021-04-25 10:17:36 +03:00
Dean Herbert
c0b1c2f39b
Merge branch 'master' into realm-key-binding-store
2021-04-24 02:40:15 +09:00
smoogipoo
b41897fd9b
Rename testscene to match class
2021-04-23 19:23:52 +09:00
smoogipoo
b18635341e
Rename file
2021-04-23 19:12:30 +09:00
smoogipoo
63a9484255
Expose WaitingOnFrames as mutable bindable
2021-04-23 19:11:47 +09:00
smoogipoo
b25340653d
Fix failing tests
2021-04-23 00:49:14 +09:00
smoogipoo
4f0857f946
Xmldocs and general refactorings
2021-04-22 23:52:22 +09:00
smoogipoo
ee25949751
Rename classes
2021-04-22 23:39:02 +09:00
smoogipoo
f8f9cf9412
Merge branch 'fix-initial-playingusers' into multiplayer-spectator-screen
2021-04-22 23:25:25 +09:00
smoogipoo
0ee73b8e53
Add failing test
2021-04-22 23:22:44 +09:00
smoogipoo
64579d50ac
Use only single PlayerInstance for hit sample playback
2021-04-22 22:59:47 +09:00
Dan Balasescu
be8fe47f2c
Merge branch 'master' into editor-add-nudge-shortcuts
2021-04-22 20:38:34 +09:00
smoogipoo
6df23f1301
Merge branch 'master' into multiplayer-spectator-screen
2021-04-22 20:29:24 +09:00
Dan Balasescu
b774f5b72b
Merge pull request #12526 from peppy/fix-system-message-ordering
...
Fix system messages always being displayed above standard messages
2021-04-22 18:51:25 +09:00
Dan Balasescu
0e24f2eb59
Merge pull request #12529 from peppy/editor-placement-right-click-delete
...
Allow shift+right-click deletion when in placement mode
2021-04-22 18:50:20 +09:00
Dean Herbert
a5364b224f
Add simple key based time nudging support to editor
2021-04-22 18:47:04 +09:00
Dean Herbert
daafa41dc1
Merge branch 'master' into fix-initial-spectator-state-callback
2021-04-22 16:22:04 +09:00
Dean Herbert
cf1e3ea988
Add failing test covering quick shift-rightclick deletion in placement mode
2021-04-22 15:44:12 +09:00
Dean Herbert
ea3bb07924
Add test that fails on incorrect system/info message ordering
2021-04-22 14:51:14 +09:00
Dean Herbert
78f274d51a
Merge branch 'master' into realm-key-binding-store
2021-04-22 12:13:23 +09:00
smoogipoo
2bea625613
Fix initial playback states not being correct
2021-04-21 23:22:11 +09:00
Denrage
0dfd0bb59d
Refactored background of BeatmapInfoWedge
2021-04-21 15:46:11 +02:00
Denrage
9fba87f67a
Moved Info and Background into own container
2021-04-21 15:43:29 +02:00
Gagah Pangeran Rosfatiputra
416e08ae7a
add dummy response API in TestSceneWikiOverlay
...
`TestSceneNewsOverlay` is used as example for this test.
2021-04-21 17:25:13 +07:00
smoogipoo
e78ef05fcf
Merge branch 'gcc-abstraction' into multiplayer-spectator-screen
2021-04-21 17:11:14 +09:00
smoogipoo
31c5fb350f
Merge branch 'master' into gcc-abstraction
2021-04-21 16:33:36 +09:00
Bartłomiej Dach
a2afa38a3f
Merge branch 'master' into fix-mod-customisation-input-blocking-padding
2021-04-20 19:41:25 +02:00
Bartłomiej Dach
881043bc5d
Fix failing test after mod settings layout changes
...
The slight hack which was used in the test to ensure that the mod
settings overlay covered the entire width of the mod overlay broke after
adjustments to the layout in the previous commit.
Locally adjust the hack to use the parent of the `ModSettingsContainer`
rather than the container itself.
2021-04-20 19:38:25 +02:00
Dean Herbert
26430e3cb5
Merge pull request #12492 from Naxesss/bg-audio-quality-checks
...
Add background and audio checks
2021-04-21 00:10:32 +09:00
smoogipoo
156a518068
Merge branch 'master' into fix-initial-spectator-state-callback
2021-04-20 21:16:05 +09:00
Naxess
c0318a4d3e
Fix usage of _ in Moq lambdas
2021-04-20 13:29:14 +02:00
Naxess
6a1e4ff99f
Add file hash to file presence test
...
Necessary because we now find the storage path of the file rather than just the file itself.
2021-04-20 13:28:32 +02:00
smoogipoo
c5d6b6ea8d
Fix tests failing intermittently
...
This was due to this code happening in UpdateAfterChildren(), after the
GCC has processed one frame. During this time, the clock could have
advanced an arbitrary amount.
The cause of this is the removal of the Task.Run() to set the clock in
Restart() (now called Reset()) which changed the timing, so it only worked before due to pure
luck.
2021-04-20 18:41:09 +09:00
smoogipoo
f144661c31
Fix storyboard sample test scene
2021-04-20 18:26:30 +09:00
Gagah Pangeran Rosfatiputra
460d656a0e
initial wiki overlay
2021-04-21 16:21:07 +07:00
Denrage
505a117862
splitted updateable part of wedge
2021-04-20 10:37:52 +02:00
smoogipoo
5da18c51a4
Fix compile error
2021-04-20 17:27:37 +09:00
smoogipoo
80473a356e
Merge branch 'fix-pre-seek-sample-lifetime' into gcc-abstraction
2021-04-20 17:27:01 +09:00
smoogipoo
281c2041b2
Add failing test
2021-04-20 16:51:00 +09:00
smoogipoo
88ded95e75
Ensure clock is set in GCC.Start()
2021-04-20 13:56:13 +09:00
Naxess
0e6b66f457
Merge branch 'master' into bg-audio-quality-checks
2021-04-20 02:36:13 +02:00
Naxess
2bb079ea14
Add audio quality check tests
2021-04-20 01:36:15 +02:00
Naxess
be6a02a17e
Simplify background quality test names
2021-04-20 01:32:22 +02:00
Naxess
8656176ab8
Add the playable beatmap as check argument
...
This is different from the working beatmap's `.Beatmap` property in that it is mutated by the ruleset/editor.
So hit objects, for example, are actually of type `Slider` and such instead of the legacy `ConvertSlider`.
This should be preferred over `workingBeatmap.Beatmap`.
2021-04-20 01:31:51 +02:00
Denrage
c73bbf0aa7
Fixed Tests
2021-04-19 19:24:58 +02:00
Bartłomiej Dach
97573fb11d
Merge branch 'master' into combo-colours-display
2021-04-19 18:21:57 +02:00
Dean Herbert
fc41ad65f8
Merge pull request #12447 from smoogipoo/fix-non-60fps-recording
...
Record every 60fps interval
2021-04-19 23:26:58 +09:00
Gagah Pangeran Rosfatiputra
5117c51105
initial wiki header
2021-04-19 16:24:47 +07:00
smoogipoo
c12848ce4d
Apply fixes to tests
2021-04-19 17:02:59 +09:00
smoogipoo
5397f4faba
Merge branch 'master' into fix-initial-spectator-state-callback
2021-04-19 16:49:06 +09:00
jvyden
a854ce429a
add blank line between method
2021-04-18 23:49:13 -04:00
jvyden
999f2d810c
Fix accidentally removed code
2021-04-18 23:30:07 -04:00
Christine Chen
fd1241cc85
Added tests
...
New tests:
- storyboard ending during the failing animation
- showResults = false
- storyboard ending before score processor completion
Co-Authored-By: Marlina José <marlina@umich.edu>
2021-04-18 23:26:50 -04:00
jvyden
e44d11667c
Merge remote-tracking branch 'upstream'
2021-04-18 23:04:35 -04:00
jvyden
c39ab2c692
Add SessionStaticsTest
2021-04-18 23:04:28 -04:00
jvyden
b727faace3
Revert changes to IdleTracker
2021-04-18 23:03:43 -04:00
Christine Chen
98460c8feb
Rename IStoryboardElementHasDuration, remove unnecessary step in tests, add Duration field
2021-04-18 20:20:14 -04:00
Bartłomiej Dach
577755ee19
Add placeholder when no colours are visible
...
Will be removed once combo colours are mutable.
2021-04-18 20:46:42 +02:00
Bartłomiej Dach
0cd1aa8c1c
Add support for custom colour prefixes
2021-04-18 20:44:55 +02:00
Bartłomiej Dach
67c19df000
Add test coverage for adding/removing colours
2021-04-18 19:35:42 +02:00
Bartłomiej Dach
1b2c43b92c
Add basic structure of colour palette
2021-04-18 19:29:04 +02:00
Dean Herbert
2678089e0b
Add test case failing on selection after paste
2021-04-18 20:28:39 +09:00
Salman Ahmed
2847dd7e05
Merge branch 'master' into play-storyboard-outro
2021-04-18 06:40:22 +03:00
Christine Chen
7b1d40db7d
Remove redundant string interpolation
2021-04-17 22:13:28 -04:00
Christine Chen
e9f8fa64b8
Added a test for toggling the storyboard after the map is loaded
2021-04-17 21:49:29 -04:00
Naxess
010720de74
Factor out general file presence checking
...
This allows us to use the same method of checking for other files that should exist, for example the audio file.
By using the same method, they all share test cases too.
2021-04-18 02:07:33 +02:00
Naxess
0502fbb429
Add background quality check tests
2021-04-18 01:21:51 +02:00
Christine Chen
7f5b1e84a1
Update TestSceneStoryboardWithOutro.cs
...
- Construct storyboard in CreateWorkingBeatmap()
- Use GameplayClockContainer.GameplayClock.CurrentTime
- Remove unnecessary lines
2021-04-17 13:57:32 -04:00
Naxess
400f8b3938
Add GetStream
to IWorkingBeatmap
...
This is necessary to obtain the filesize of the audio and background files.
2021-04-17 17:47:13 +02:00
Naxess
448574e7e6
Use WorkingBeatmap
instead of IBeatmap
...
This lets us access things like the background, track, etc. which are necessary for quality and filesize checks.
Also improves the structure of the `CheckBackgroundTest` class in the process.
2021-04-17 17:33:53 +02:00
jvyden
1e56f14f5b
Merge remote-tracking branch 'upstream'
2021-04-17 09:35:24 -04:00
Bartłomiej Dach
f3ea51eeed
Adjust tests to not rely on invalid assumption
2021-04-17 14:23:32 +02:00
smoogipoo
d5b26b0ab5
Fix incorrect test spectator client implementation
2021-04-16 23:01:34 +09:00
smoogipoo
4c5d4752b1
Rename classes to reduce redundant naming
2021-04-16 22:47:52 +09:00
smoogipoo
44e13a91ad
Rename test scene to match class
2021-04-16 20:51:42 +09:00
smoogipoo
a7aa3cb263
Merge branch 'gcc-abstraction' into multiplayer-spectator-screen
2021-04-16 20:16:26 +09:00
smoogipoo
5e82f40d67
Merge branch 'master' into gcc-abstraction
2021-04-16 20:14:53 +09:00
jvyden
8d6c30c73b
Fix lint
2021-04-16 05:57:36 -04:00
jvyden
ec0211809f
Apply peppy's suggestions
2021-04-16 05:53:27 -04:00
smoogipoo
65a6f9f8a4
Merge branch 'fix-initial-spectator-state-callback' into multiplayer-spectator-screen
2021-04-16 18:26:46 +09:00
jvyden
d760e81a91
Fix lint
2021-04-16 05:22:41 -04:00
smoogipoo
46d2181d42
Remove now unnecessary (duplicating) test
2021-04-16 18:21:56 +09:00
smoogipoo
377e5ce6b3
Fix test incorrect sending state too often
2021-04-16 18:21:35 +09:00
jvyden
471b8e3c74
Merge branch 'master' of https://github.com/ppy/osu
2021-04-16 05:02:40 -04:00
jvyden
7d23973ef8
Reset SessionStatics on activity
...
Closes #12424
2021-04-16 05:01:58 -04:00
smoogipoo
ca74f413cd
Change to explicit method instead
2021-04-16 17:31:02 +09:00
smoogipoo
25f0f17766
Attempt to fix match subscreen test failure
2021-04-16 16:16:28 +09:00
smoogipoo
5652490d61
Fix OnUserBeganPlaying not being invoked if already watching
2021-04-16 14:11:55 +09:00
Christine Chen
b15838b220
Move storyboard outro logic to DrawableStoryboard
2021-04-16 00:59:10 -04:00
smoogipoo
5ac0eb02cd
Always add player instances at first, populate later
2021-04-16 12:25:29 +09:00
Christine Chen
45c2b72a25
Merge branch 'master' into play-storyboard-outro
2021-04-15 15:11:35 -04:00
Christine Chen
25b8c2f257
Allow skipping storyboard outro
...
Reuses SkipOverlay by calculating the endtime of the storyboard and using that as a "start point". Upon skipping the outro the score is instantly shown.
When the end of the storyboard is reached the score screen automatically shows up. If the player holds ESC (pause) during the outro, the score is displayed
The storyboard endtime is calculated by getting the latest endtime of the storyboard's elements, or simply returning 0 if there is no storyboard.
Co-Authored-By: Marlina José <marlina@umich.edu>
2021-04-15 13:20:40 -04:00
Dean Herbert
7cf15fe729
Merge pull request #12412 from peppy/timeline-adjustments
...
Update timeline control point display
2021-04-15 22:43:26 +09:00
Dan Balasescu
ac8e462d32
Merge branch 'master' into refactor-framed-replay-input-hander
2021-04-15 21:48:58 +09:00
Dean Herbert
ad671ee07a
Merge branch 'master' into timeline-adjustments
2021-04-15 20:42:38 +09:00
Dan Balasescu
6f17c19a48
Merge branch 'master' into summary-timeline-design-refactors
2021-04-15 20:11:39 +09:00
smoogipoo
82fcabb8f0
More refactorings/renamespacings/xmldocs
2021-04-15 19:32:55 +09:00
Dean Herbert
5b06a68b93
Merge pull request #12330 from Cublibre/master
...
Send a warning notification if device is unplugged and at low battery
2021-04-15 19:21:04 +09:00
smoogipoo
df4fce2c57
Rename classes
2021-04-15 19:16:00 +09:00
smoogipoo
1705d472b5
Reimplement multiplayer syncing using new master/slave clocks
2021-04-15 19:12:52 +09:00
Dean Herbert
18e8682f39
Remove unused using statements
2021-04-15 17:01:25 +09:00
smoogipoo
33ad7850cb
Remove LastFrameTime
2021-04-15 16:45:59 +09:00
Dean Herbert
dd9a142e89
Fix TestSceneEditorSummaryTimeline
not displaying actual beatmap content
2021-04-15 16:39:20 +09:00
Dean Herbert
66bb5766b9
Make Mod.Description
abstract and add missing descriptions
2021-04-15 16:39:20 +09:00
smoogipoo
6fc7488a67
Reimplement syncing logic as a new component
2021-04-15 16:33:59 +09:00
Dan Balasescu
a56391c6ca
Merge pull request #12418 from peppy/abstract-mod-description
...
Make `Mod.Description` abstract and add missing descriptions
2021-04-15 15:42:36 +09:00
Dean Herbert
346e36d32a
Make Mod.Description
abstract and add missing descriptions
2021-04-15 14:36:26 +09:00
Salman Ahmed
92fd34cea9
Revert "Inverse ignore user settings bindable to "apply user settings" instead"
...
This reverts commit 175b8da2b2
.
2021-04-15 08:02:12 +03:00
Salman Ahmed
175b8da2b2
Inverse ignore user settings bindable to "apply user settings" instead
2021-04-15 07:34:20 +03:00
Salman Ahmed
7a9ff2ab38
Use until steps instead
...
Ah..
2021-04-15 00:48:25 +03:00
Salman Ahmed
505dc15e03
Add failing test case
2021-04-14 23:35:42 +03:00
Dean Herbert
9dea0ae935
Update test scene to be able to see a bit more
2021-04-14 21:03:52 +09:00
smoogipoo
54643f53e3
Merge branch 'gcc-abstraction' into multiplayer-spectator-screen
2021-04-14 19:56:58 +09:00
smoogipoo
1aa36818df
Abstractify GameplayClockContainer
2021-04-14 17:47:11 +09:00
Dean Herbert
7654df94f6
Merge pull request #12395 from frenzibyte/fix-cinema-ignore-settings
...
Fix beatmap background displayed if storyboard is hidden on "Cinema" mod
2021-04-14 14:31:03 +09:00
Dean Herbert
1ff4e2076f
Merge branch 'master' into verify-tab
2021-04-13 23:05:48 +09:00
smoogipoo
3039b7b0f9
Make tests a bit more resilient
2021-04-13 22:40:24 +09:00
smoogipoo
20823abb30
Make resyncing a bit more resilient
2021-04-13 22:10:35 +09:00
Dan Balasescu
1505a38164
Merge pull request #12396 from peppy/update-timeline-slider-apperance
...
Update timeline slider/spinner apperance
2021-04-13 20:47:44 +09:00
Dan Balasescu
b2aa46690d
Merge pull request #12389 from peppy/fix-editor-ctrl-drag-deselection
...
Fix ctrl-dragging on an existing selection unexpectedly causing deselection
2021-04-13 20:38:29 +09:00
smoogipoo
5b53a2b211
Merge branch 'master' into multiplayer-spectator-screen
2021-04-13 20:07:56 +09:00
Dean Herbert
00f235760d
Update visual appearance of timeline blueprints to close match new designs
2021-04-13 19:26:20 +09:00
Dean Herbert
fca9c70c1b
Move timeline hit object test to immediately viewable area
2021-04-13 19:26:20 +09:00
Dean Herbert
0cf13dab8d
Merge pull request #12391 from frenzibyte/replays-tooltip-graph
...
Display separate "replays watched" tooltip for replays subsection
2021-04-13 19:25:50 +09:00
Dean Herbert
2884ed3ab9
Merge pull request #12350 from smoogipoo/multiplayer-spectator-player-grid
...
Add the multiplayer spectator player grid
2021-04-13 19:25:32 +09:00
Dan Balasescu
a0513f64f9
Merge branch 'master' into replays-tooltip-graph
2021-04-13 18:21:10 +09:00
Dan Balasescu
fd32c7d7df
Merge pull request #12393 from peppy/update-timeline-design-a-bit
...
Update timeline tick display to differentiate tick type using width
2021-04-13 18:14:58 +09:00
Salman Ahmed
15658eda55
Add failing test case
2021-04-13 12:00:13 +03:00
Salman Ahmed
36510309d1
Merge EnableUserDim
and IgnoreUserSettings
to one bindable
2021-04-13 10:58:56 +03:00
Dean Herbert
a9652b7b25
Start TimelineTestScene in a more visible place
2021-04-13 16:05:12 +09:00
ekrctb
57ba7b7cbb
Partially revert the changes of CurrentFrame
and NextFrame
for compatibility
...
Making those always non-null is postponed as when a replay's frame contains keypress the behavior is changed.
Previously, the key is pressed at the time of the first frame. But using non-null frames means the key is pressed at negative infinity.
However, I think the new way of always using non-null frames makes the client code so I plan to bundle the change to more breaking changes.
2021-04-13 15:55:23 +09:00
Dean Herbert
b45d7de4ec
Update asserts to use better nunit specifications
2021-04-13 15:04:01 +09:00
ekrctb
38d10755cb
Merge branch 'master' into refactor-framed-replay-input-hander
2021-04-13 13:47:22 +09:00
Dean Herbert
516bd138e3
Add (previously failing) test coverage of drag from selection
2021-04-13 13:46:38 +09:00
Dean Herbert
7c975359d9
Add basic select/deselect tests
2021-04-13 13:29:37 +09:00
Dean Herbert
05d7fe289f
Rename test scene in preparation for increasing scope
2021-04-13 13:09:18 +09:00
Dean Herbert
66e74da2b7
Fix regression in quick delete mouse action blocking
2021-04-13 13:03:14 +09:00
Salman Ahmed
17c2c4e885
Fix test case filename not matching
2021-04-13 05:31:56 +03:00
Naxess
6d3f9fa9ce
Use is
class instead of Equals
with template index
...
Ensures ordering of `PossibleTemplates` does not affect tests.
2021-04-13 02:29:25 +02:00
Naxess
0bcc39bd36
Remove redundant space
2021-04-13 02:17:35 +02:00
Naxess
47cf4bcf25
Add CheckBackground
tests
2021-04-13 01:22:24 +02:00
Salman Ahmed
8f84abf348
Display "replays watched" tooltip for replays subsection
2021-04-12 21:51:06 +03:00
Salman Ahmed
9679bdfed2
Merge branch 'master' into mod-using-reference-equality
2021-04-12 20:56:24 +03:00
Salman Ahmed
589e1a2a47
Add mod settings equality test
2021-04-12 20:51:24 +03:00
Dean Herbert
84e1ff79a0
Merge pull request #12352 from smoogipoo/multiplayer-spectator-leaderboard
...
Implement the multiplayer spectator leaderboard
2021-04-13 01:51:14 +09:00
Christine Chen
f66306a81a
Remove IsLowBattery
2021-04-12 11:15:24 -04:00
Christine Chen
43b97fe0ad
Refactor PowerStatus (now called BatteryInfo)
2021-04-12 10:52:52 -04:00
smoogipoo
1e002841cf
Add test for scoring mode changes
2021-04-12 22:03:45 +09:00
smoogipoo
c531e38a36
Rework to create a derived tracked user data instead
2021-04-12 22:00:27 +09:00
smoogipoo
27660265b5
Merge branch 'master' into multiplayer-spectator-leaderboard
2021-04-12 21:02:18 +09:00
smoogipoo
d2d7f77430
Fix mods not being serialised correctly in ScoreInfo
2021-04-12 20:09:01 +09:00
Dean Herbert
b4c75ba3c6
Fix TestQuickDeleteRemovesObject failing on second run
2021-04-12 19:19:25 +09:00
ekrctb
359fae895f
Rename property
2021-04-12 18:50:25 +09:00
ekrctb
3c28c09ab5
Add more FramedReplayInputHandler tests
2021-04-12 16:18:35 +09:00
ekrctb
e19e8ff2a3
Rewrite FramedReplayInputHandler for robustness
...
This commit changes the semantics of `CurrentFrame` and `NextFrame` of the class.
The ordering of `NextFrame.Time` and `CurrentFrame.Time` was dependent on the current direction.
Now, it should always satisfy `CurrentFrame.Time <= CurrentTime <= NextFrame.Time` except at the start/end.
This change, however, doesn't break existing deriving classes if the template code pattern usage of interpolation is used.
The deriving class code can be simplified due to the elimination of nullable types. I didn't include those changes in this commit.
I removed `StreamingFramedReplayInputHandlerTest` for now, as it is almost-duplicate of `FramedReplayInputHandlerTest`. I'll include more tests in later commits.
This commit fixes #6150 .
2021-04-12 16:18:11 +09:00
Dean Herbert
9be3163592
Merge branch 'master' into multiplayer-spectator-player-grid
2021-04-12 14:14:13 +09:00
smoogipoo
4fcddfb44b
Fix multiplayer test failure
2021-04-12 13:42:14 +09:00
ekrctb
d6d8ea5b6b
Throw when getting a frame of an empty replay
2021-04-12 11:17:56 +09:00
Salman Ahmed
cb947a3b27
Add expected output in test case rather than determining internally
2021-04-11 13:18:25 -04:00
Salman Ahmed
1fd4cb8963
Merge branch 'master' into master
2021-04-11 10:19:16 +03:00
Christine Chen
08311abc5e
Remove setters, cache CreatePowerStatus() and use a dummy LocalPowerStatus class in test scene
2021-04-10 00:00:21 -04:00
Dan Balasescu
9aa30fb323
Merge pull request #11688 from Syriiin/diffcalc/dynamic-history
...
Implement dynamic previous hitobject retention for Skill class
2021-04-10 01:25:07 +09:00
smoogipoo
61c400b1a1
Fix filename
2021-04-09 20:18:26 +09:00
smoogipoo
eccd269cce
Implement maximum start delay
2021-04-09 20:17:57 +09:00
smoogipoo
950e4e05ef
Merge branch 'multiplayer-spectator-leaderboard' into multiplayer-spectator-screen
2021-04-09 18:30:21 +09:00
smoogipoo
e73f3f52d7
Add some more asserts
2021-04-09 18:23:41 +09:00
smoogipoo
9ddcd686ac
Fix incorrect assert
2021-04-09 18:23:38 +09:00
smoogipoo
b49997f531
Add test for no frames
2021-04-09 18:18:23 +09:00
smoogipoo
589ce4bdc2
Add test
2021-04-09 18:16:10 +09:00
Christine Chen
59d13b0dd3
Fixed indentation
...
sorry about the style fixes... I'm using JetBrains Rider from now on.
2021-04-08 21:53:42 -04:00
Christine Chen
6b6a71d3c3
trim whitespace
2021-04-08 20:39:17 -04:00
Christine Chen
493c095535
Fixed code style
2021-04-08 20:28:23 -04:00
Christine Chen
6bccb3aab6
Use DI to implement battery detection, add BatteryCutoff property
...
- Removed the Xamarin.Essentials package from osu.Game and added it to osu.iOS and osu.Android only.
- iOS and Android implementations use Xamarin.Essentials.Battery, while the Desktop implementation
only returns 100% battery for now.
- Added a BatteryCutoff property to PowerStatus so it can be different for each platform (default 20%, 25% on iOS)
2021-04-08 19:55:11 -04:00
smoogipoo
7958a257e8
Add tests
2021-04-08 22:14:30 +09:00
smoogipoo
70cd018a98
Fix intermittent test failure
2021-04-08 21:38:58 +09:00
smoogipoo
125358158b
Merge branch 'master' into multiplayer-spectator-screen
2021-04-08 21:13:37 +09:00
Dean Herbert
1e23f671fa
Merge pull request #12321 from smoogipoo/add-spectate-button-and-state
...
Add multiplayer spectating user state and button
2021-04-08 19:48:58 +09:00
smoogipoo
b38d332268
Fix broken test
2021-04-08 16:31:39 +09:00
Dean Herbert
545156d15c
Add regression test coverage
2021-04-08 15:20:53 +09:00
Dean Herbert
8aff53172d
Remove necessity for nested PassThroughInputManger
2021-04-08 15:18:31 +09:00
Christine Chen
0a6baf670e
Send a warning notification if device is unplugged and low battery
...
- Uses Xamarin.Essentials in osu.Game.PlayerLoader to check battery level
- Encapsulated battery checking in the public BatteryManager class so battery level and plugged in status can be accessed and edited in TestPlayerLoader
- When checking battery level, catch NotImplementedException thrown by Xamarin.Essentials.Battery on non-mobile platforms
- Added visual unit tests for battery notification
To mock battery status and level, we had to define a batteryManager object in TestPlayerLoader and add a new function ResetPlayerWithBattery()
Co-Authored-By: Marlina José <marlina@umich.edu>
2021-04-07 15:56:50 -04:00
smoogipoo
72a42ceaf7
Merge branch 'multiplayer-spectator-player-grid' into multiplayer-spectator-screen
2021-04-08 00:19:00 +09:00
smoogipoo
024adb699c
Add test and fix several issues
2021-04-08 00:12:21 +09:00
smoogipoo
214813154b
Fix class name
2021-04-07 22:28:22 +09:00
smoogipoo
99bee73ac1
Merge branch 'master' into add-spectate-button-and-state
2021-04-07 22:07:52 +09:00
Dan Balasescu
6eb809f4c4
Merge pull request #9194 from boswelja/rebind-song-select
...
Allow rebinding Song Select mods/random/options keys
2021-04-07 20:55:45 +09:00
smoogipoo
93c5935ebc
Add match subscreen support + test
2021-04-07 20:46:30 +09:00
Dean Herbert
b4c6894d13
Add test coverage for song select footer area
2021-04-07 18:29:31 +09:00
smoogipoo
abd637ffaa
Add button to footer
2021-04-07 17:35:18 +09:00
smoogipoo
56c13148f1
Fix typo in class name
2021-04-07 16:45:10 +09:00
smoogipoo
c744f77cfa
Add participant panel state
2021-04-07 16:40:24 +09:00
smoogipoo
f5667125a0
Remove unnecessary method
2021-04-07 16:37:43 +09:00
smoogipoo
6be9c9f0f4
Link up ready button to spectate state
2021-04-07 16:35:50 +09:00
smoogipoo
1f57b6884d
Add ready button to test scene
2021-04-07 16:30:40 +09:00
smoogipoo
6de91d7b6b
Add spectate button + test
2021-04-06 21:37:27 +09:00
Leon Gebler
dd902441b0
Add tests for consecutive perfect-curve segments
2021-04-06 13:32:17 +02:00
Dan Balasescu
ba3689b5b9
Merge pull request #12269 from PercyDan54/beatmap-details
...
Use OnlineViewContainer for BeatmapDetails
2021-04-06 17:52:32 +09:00
Dan Balasescu
2321101518
Merge branch 'master' into fix-overzealousmouse-button-blocking
2021-04-06 16:45:25 +09:00
Dean Herbert
53c1bc666c
Make addition of nested GlobalActionContainer in OsuGameTestScene optional
2021-04-06 15:18:00 +09:00
smoogipoo
9c1320e18b
Add test
2021-04-06 14:34:26 +09:00
Dean Herbert
784552022f
Merge pull request #12303 from smoogipoo/fix-last-control-point-segmenting
...
Make last control point not able to make an implicit segment
2021-04-06 13:35:55 +09:00
Samuel Cattini-Schultz
4f614a703e
Merge branch 'master' into diffcalc/dynamic-history
2021-04-06 11:34:33 +10:00
Dean Herbert
e486e521ff
Fix regressed test
2021-04-05 22:46:01 +09:00
Dean Herbert
beebdb0734
Clean up implementation
2021-04-05 22:30:51 +09:00
smoogipoo
a3faf0a28e
Increment start time
2021-04-05 18:07:07 +09:00
smoogipoo
42e816fcae
Add failing tests
2021-04-05 17:48:29 +09:00
smoogipoo
3acc612a67
Adjust scoring values to better fit osu!mania
2021-04-05 13:28:46 +09:00
Bartłomiej Dach
b66ba43bc5
Add failing test scene
2021-04-03 14:02:46 +02:00
Bartłomiej Dach
7d4b0e3f0a
Fix editor clock scene not re-enabling beatmap
...
Could interfere with other tests due to causing crashes on attempts to
change `Beatmap.Value`.
2021-04-03 12:34:48 +02:00
Samuel Cattini-Schultz
fe66b84bed
Implement dynamic previous hitobject retention for Skill class
...
There is no reason we should be limiting skills to knowing only the previous 2 objects. This originally existed as an angle implementation detail of the original pp+ codebase which made its way here, but didn't get used in the same way.
2021-04-03 20:28:51 +11:00
Dean Herbert
67f0c0ceb9
Merge branch 'master' into spectator-refactor
2021-04-03 12:55:11 +09:00
PercyDan54
1ff77754fd
Use OnlineViewContainer
2021-04-02 20:14:31 +08:00
dependabot-preview[bot]
6a286c5e21
Bump Microsoft.NET.Test.Sdk from 16.9.1 to 16.9.4
...
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest ) from 16.9.1 to 16.9.4.
- [Release notes](https://github.com/microsoft/vstest/releases )
- [Commits](https://github.com/microsoft/vstest/compare/v16.9.1...v16.9.4 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-04-01 17:16:02 +00:00
smoogipoo
c3c7c18549
Fix tests
2021-04-01 23:48:26 +09:00
smoogipoo
9e95441aa6
Rename Spectator -> SoloSpectator
2021-04-01 22:08:52 +09:00
Dean Herbert
710599c521
Merge branch 'master' into realm-key-binding-store
2021-03-31 15:00:47 +09:00
Dean Herbert
0c53b4eb93
Fix wrong counting and add test
2021-03-31 14:09:39 +09:00
Dean Herbert
321ad737b6
Merge branch 'master' into realm-migration-operation-blocking
2021-03-30 22:40:08 +09:00
Dean Herbert
491e583819
Merge branch 'master' into realm-migration-operation-blocking
2021-03-30 13:25:40 +09:00
Dean Herbert
8dfff999f9
Add rotation slider
2021-03-30 12:40:50 +09:00
smoogipoo
804ffe9f48
Fix inspections
2021-03-30 09:00:09 +09:00
Bartłomiej Dach
e9289853fc
Merge branch 'master' into fix-accuracy-formatting
2021-03-26 21:24:04 +01:00
Dean Herbert
f8cea5cae3
Merge branch 'master' into realm-migration-operation-blocking
2021-03-26 17:07:31 +09:00
Dean Herbert
4909eaf890
Add the ability to specify format provider (to make tests culture invariant)
2021-03-26 13:10:11 +09:00
Dean Herbert
6a7f926168
Change rounding to use a more general flooring approach
2021-03-26 13:10:11 +09:00
Max Hübner
558f8fa51e
Adjust testscene
2021-03-25 23:20:26 +01:00
Dean Herbert
544117a494
Add test coverage of accuracy formatting function
2021-03-25 17:37:03 +09:00
Dean Herbert
e0b12abcc1
Merge pull request #12173 from frenzibyte/osk-ignore-case
2021-03-25 14:58:09 +09:00
Salman Ahmed
35810bb2fb
Add test coverage
2021-03-24 22:55:15 +03:00
Dean Herbert
6cb14e91c9
Make Player abstract and introduce SoloPlayer
2021-03-23 18:18:49 +09:00
Dean Herbert
aeff9bd853
Add return bool to HandleRequest to better trigger failures
2021-03-23 18:17:29 +09:00
Bartłomiej Dach
a16c0641b2
Revert EF Core to version 2.2
...
This reverts commit f3faad74d5
, reversing
changes made to 712e7bc7bf
.
Several issues arose after migrating to 5.0, including, but possibly not
limited to, performance regressions in song select, as well as failures
when attempting to save beatmaps after metadata changes in the editor.
2021-03-21 11:05:15 +01:00
Dean Herbert
b9b351311a
Merge pull request #11824 from peppy/fix-unsafe-skinnable-sample-play
...
Fix playing skinned samples being unsafe during skin changes
2021-03-20 11:29:34 +09:00
Bartłomiej Dach
8e0536e1e2
Add failing test scene
2021-03-19 22:44:33 +01:00
Dean Herbert
03592fa696
Merge branch 'master' into realm-migration-operation-blocking
2021-03-19 21:33:26 +09:00
Dean Herbert
f59327cc3e
Merge branch 'master' into fix-unsafe-skinnable-sample-play
2021-03-19 20:29:44 +09:00
Dean Herbert
196f95ae54
Update to use new bindables and centered area offset
2021-03-19 19:01:32 +09:00
Dean Herbert
9a6a0f3df5
Add test coverage and better UI handling of no tablet connected scenario
2021-03-19 19:01:32 +09:00
Dean Herbert
a8e319a320
Remove min/max from test scene to fix weirdness when switching test sizings
2021-03-19 19:01:31 +09:00
Dean Herbert
382109c7a2
Make test scene feel more like settings (width-wise)
2021-03-19 19:01:31 +09:00
Dean Herbert
464702182d
Consume device name
2021-03-19 19:01:31 +09:00
Dean Herbert
3b7edf1333
Make tablet display always fit to size of settings area
2021-03-19 19:01:31 +09:00
Dean Herbert
d026c8da85
Initial pass of configuration interface
2021-03-19 19:01:31 +09:00
Dean Herbert
1c865682ae
Add tablet configuration tests
2021-03-19 18:57:49 +09:00
Dean Herbert
711d895a04
Merge pull request #8238 from voidedWarranties/editor-song-end
2021-03-19 16:32:23 +09:00
Bartłomiej Dach
aec859b4d1
Merge branch 'master' into fix-unsafe-skinnable-sample-play
2021-03-18 19:51:46 +01:00
Dan Balasescu
d9ec3c327e
Merge branch 'master' into input-handler-configuration
2021-03-18 22:17:48 +09:00
Dean Herbert
bb3c3f302a
Fix skin parser not stripping whitespace before parsing
2021-03-18 15:36:11 +09:00
voidedWarranties
df6570ebf5
Improve logic and add previously failing test
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-03-17 15:48:55 -07:00
Bartłomiej Dach
21e18c9f6e
Fix test hangs in browser due to changing tracks via music controller
2021-03-17 18:46:22 +01:00
Bartłomiej Dach
3b55eeb416
Fix test failure by setting beatmap
...
Post-merge, it was failing because somewhere along the way
`EditorClockTestScene` started expecting inheritors to set the beatmap
themselves explicitly in BDL.
2021-03-17 18:39:48 +01:00
Bartłomiej Dach
f1e66cc420
Adjust test namespace
2021-03-17 18:37:11 +01:00
Bartłomiej Dach
a691291ae8
Merge branch 'master' into editor-song-end
2021-03-17 18:18:19 +01:00
smoogipoo
e59b8b4ce6
Fix test checking nullable string
2021-03-17 19:07:29 +09:00
smoogipoo
f7ec79c5f4
Fix incorrect generic type
2021-03-17 19:02:25 +09:00
Dean Herbert
4bf57ad860
Remove remaining reference to obsolete value
2021-03-17 18:24:24 +09:00
smoogipoo
7fa5fd5647
Update usages of config with framework changes
2021-03-17 16:10:16 +09:00
Dean Herbert
f3faad74d5
Merge pull request #12003 from UselessToucan/ef_core_5
2021-03-15 15:05:32 +09:00
Dean Herbert
fce21f23d6
Add comments marking workarounds required for EFcore 5
2021-03-15 13:29:26 +09:00
Dean Herbert
1573298e68
Update remaining package references to point to efcore5
2021-03-15 13:12:10 +09:00
Joehu
d0644221ff
Add test showing toolbar behavior change
2021-03-12 15:48:49 -08:00
Roman Kapustin
c6c616f244
Actualize tests
2021-03-11 21:02:40 +03:00
Dean Herbert
a5b3ac7ef8
Add failing test covering alpha commands proceeding non-alpha (but ignored) commands
2021-03-09 15:54:11 +09:00
Dean Herbert
9b5d11f2a5
Merge pull request #11958 from bdach/ruleset-filter-v3
...
Allow rulesets to specify custom song select filtering criteria
2021-03-08 23:23:24 +09:00
Dean Herbert
d2bc48e576
Exclude tests from ConfigureAwait rule
2021-03-08 14:36:35 +09:00
Dean Herbert
2b1ab3576b
Merge branch 'master' into migrate-country-rank
2021-03-08 11:07:25 +09:00
Bartłomiej Dach
f00089846b
Merge branch 'master' into ruleset-filter-v3
2021-03-06 12:14:53 +01:00
Dean Herbert
b241749119
Merge pull request #11928 from smoogipoo/fix-test-multiplayer-beatmap
2021-03-04 23:43:55 +09:00
Dan Balasescu
5b6018295d
Merge branch 'master' into diffcalc/skill-mods
2021-03-04 13:06:26 +09:00
Bartłomiej Dach
f9148eec20
Refactor filter query parsing helper methods
...
In preparation for exposition as public.
2021-03-03 21:34:14 +01:00
smoogipoo
77607c06eb
Fix not being able to enter gameplay in TestSceneMultiplayer
2021-03-03 22:07:39 +09:00
smoogipoo
0f83b66cda
Add separate test for stateful multiplayer client
2021-03-03 22:01:03 +09:00
smoogipoo
1ecb1d122a
Fix up TestSceneMultiplayer
2021-03-03 21:54:34 +09:00
smoogipoo
6affe33fb2
Fix another test scene
2021-03-03 19:40:19 +09:00
Bartłomiej Dach
faf5fbf49b
Add tests for custom matching logic
2021-03-02 20:27:50 +01:00
Bartłomiej Dach
bf72f9ad1e
Add tests for custom parsing logic
2021-03-02 20:22:56 +01:00
Bartłomiej Dach
e46543a4a9
Constrain operator parsing better
2021-03-02 19:56:36 +01:00
Bartłomiej Dach
3b125a26a8
Add test coverage
2021-03-02 19:21:03 +01:00
Dean Herbert
a75537142d
Merge pull request #11939 from ppy/dependabot/nuget/Microsoft.NET.Test.Sdk-16.9.1
...
Bump Microsoft.NET.Test.Sdk from 16.8.3 to 16.9.1
2021-03-02 11:28:00 +09:00
dependabot-preview[bot]
b03efd6940
Bump Microsoft.NET.Test.Sdk from 16.8.3 to 16.9.1
...
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest ) from 16.8.3 to 16.9.1.
- [Release notes](https://github.com/microsoft/vstest/releases )
- [Commits](https://github.com/microsoft/vstest/compare/v16.8.3...v16.9.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-03-02 00:43:45 +00:00
dependabot-preview[bot]
d6925d0960
Bump Moq from 4.16.0 to 4.16.1
...
Bumps [Moq](https://github.com/moq/moq4 ) from 4.16.0 to 4.16.1.
- [Release notes](https://github.com/moq/moq4/releases )
- [Changelog](https://github.com/moq/moq4/blob/main/CHANGELOG.md )
- [Commits](https://github.com/moq/moq4/compare/v4.16.0...v4.16.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-03-02 00:43:44 +00:00
Salman Ahmed
2609b22d53
Replace usage of CurrentModeRank
in line with API change
2021-03-01 23:07:25 +03:00
smoogipoo
5cfaf1de1b
Fix duplicate ongoing operation tracker
2021-03-01 17:43:03 +09:00
Bartłomiej Dach
7b6e53680c
Add coverage for the unordered case
2021-02-27 15:14:25 +01:00
Bartłomiej Dach
dd2f63f313
Add assertions to actually check order
2021-02-27 14:58:05 +01:00
Bartłomiej Dach
87b73da73e
Add failing test case
2021-02-27 14:57:55 +01:00
smoogipoo
01a4815412
Make labels disappear on null beatmap/no hitobjects
2021-02-25 23:36:02 +09:00
Dean Herbert
3802cb29a4
Fix failing tests doing reference comparisons between string and LocalisedString
2021-02-25 17:49:54 +09:00
Dean Herbert
90e8308716
Merge branch 'master' into localisation-refactor-framework
2021-02-25 17:28:55 +09:00
Dean Herbert
a08a3d44c7
Add failing test coverage for using hotkeys from main menu before toolbar displayed
2021-02-25 14:52:16 +09:00
Dean Herbert
67773c42ef
Merge pull request #11888 from H2n9/modtimeramp-new-behaviour
2021-02-25 14:01:57 +09:00
Dan Balasescu
3e2b21a9b4
Merge pull request #11892 from peppy/allow-collection-name-collisions
...
Fix crash on two collections existing with the same name
2021-02-24 23:08:05 +09:00
Dean Herbert
6e6fb31c05
Add test coverage
2021-02-24 18:49:16 +09:00
Dan Balasescu
c0f21c8cbe
Merge branch 'master' into fix-selecting-incompatible-freemods
2021-02-24 15:10:48 +09:00
Dan Balasescu
2e730cdde7
Merge pull request #11867 from peppy/add-quick-run-test-beatmap
...
Fix test failures due to beatmap taking too long to complete autoplay/replay
2021-02-24 13:25:22 +09:00
Dean Herbert
59e6bad0b9
Remove unnecessary interpolated string specification
2021-02-24 12:46:37 +09:00
Dean Herbert
7000132d03
Specify full filename inline for quick beatmap
2021-02-24 12:45:00 +09:00
Ronnie Moir
f6d3cd6413
Change SamplePlaybackWithRateMods to use rate calulated from the sample
...
Replace hardcoded numbers
2021-02-23 21:25:59 +00:00
Ronnie Moir
dbde47fe94
Fix test failure
2021-02-23 19:43:04 +00:00
Dean Herbert
e679a1916f
Merge pull request #11833 from frenzibyte/fix-pofl-on-cooldown
...
Keep pausing gameplay on focus loss if cannot on first attempt
2021-02-24 00:15:58 +09:00
Dean Herbert
996c0897d1
Seek via GameplayClockContainer for better reliability
2021-02-23 13:40:21 +09:00
Bartłomiej Dach
f62120c66b
Remove unused using directive
2021-02-22 22:45:55 +01:00
Dean Herbert
1fd76ea3fb
Apply changes to UI components overriding functions with changing signatures
2021-02-22 19:01:42 +09:00
smoogipoo
ee6a94273d
Merge branch 'master' into fix-unsafe-skinnable-sample-play
2021-02-22 18:31:27 +09:00
Salman Ahmed
6bac83964a
Merge branch 'master' into fix-pofl-on-cooldown
2021-02-22 10:03:27 +03:00
Dean Herbert
adf2dc36c9
Fix PlaylistResults tests performing delays in real-time when headless
2021-02-22 15:43:58 +09:00
Dean Herbert
cdbf8de29d
Update other tests which can benefit from using a shorter beatmap
2021-02-22 14:53:32 +09:00
Dean Herbert
541237ef16
Use a shorter test beatmap for tests which need to run to completion
2021-02-22 14:48:04 +09:00
Dean Herbert
63dd55c92c
Add missing methods from updated audio component interface implementation
2021-02-22 14:18:52 +09:00
smoogipoo
ca92ad715a
Add test
2021-02-22 13:32:54 +09:00
Samuel Cattini-Schultz
66643a97b0
Add a list of mods to Skill class
...
Although this isn't necessary for existing official rulesets and calculators, custom calculators can have use cases for accessing mods in difficulty calculation.
For example, accounting for the effects of visual mods.
2021-02-20 20:37:44 +11:00
Dean Herbert
d2ec151c67
Add failing test for pausing when pause support is disabled
2021-02-20 14:20:13 +09:00
Dan Balasescu
52372fe50d
Merge pull request #11713 from peppy/fix-error-exit-during-results-transition
...
Fix a potential crash when exiting play during the results screen transition
2021-02-19 18:39:21 +09:00
Dan Balasescu
9fc57b2145
Merge pull request #11832 from peppy/leaderboard-compact-mode
...
Show compact leaderboard during gameplay to reduce distractions
2021-02-19 18:17:46 +09:00
Salman Ahmed
f6c279ab00
Add assert ensuring player resumed properly
2021-02-19 11:45:45 +03:00
Salman Ahmed
fe5e45ea81
Move gameplay cursor outside instead and fix potential failure
2021-02-19 11:43:33 +03:00
Dean Herbert
52ebe34347
Update TestScenePause exit from fail test to actually fail
2021-02-19 17:26:26 +09:00
Dean Herbert
4c214b74ce
Merge branch 'master' into fix-error-exit-during-results-transition
2021-02-19 17:13:55 +09:00
Dean Herbert
b8c1e8ed7a
Merge pull request #11708 from frenzibyte/multiplayer-participant-rank
...
Display user global rank for multiplayer room participants
2021-02-19 16:57:30 +09:00
Salman Ahmed
772471a6d8
Add failing test case
2021-02-19 10:46:31 +03:00
Dean Herbert
43c35c5118
Show local user in test scene
2021-02-19 15:15:31 +09:00
Dean Herbert
ee9e6fff40
Add bindable flow for expanded leaderboard state
2021-02-19 15:09:41 +09:00
Dean Herbert
b68dbbceff
Merge branch 'master' into multiplayer-participant-rank
2021-02-19 13:16:44 +09:00
Salman Ahmed
a407bfe73b
Privatize UserRanks
and expose a similar CountryRank
field instead
2021-02-18 15:37:52 +03:00
Dean Herbert
487a39eea9
Update interface implementations with framework changes
2021-02-18 18:52:34 +09:00