4076 Commits

Author	SHA1	Message	Date
Henry Lin	3b822cd5cf	Refactor SeedSettingsControl and related controls	2021-06-26 11:19:14 +08:00
Bartłomiej Dach	50c27d2635	Update usages of IHasTooltip in line with framework localisation changes	2021-06-25 19:10:04 +02:00
Henry Lin	31c786e1c3	Use SettingsNumberBox.NumberBox instead of OsuNumberBox	2021-06-25 09:51:34 +08:00
ekrctb	e1b2c63e09	Add IApplicableToBeatmapProcessor mod interface	2021-06-23 14:46:30 +09:00
Dean Herbert	a1da9c5ee3	Merge pull request #13626 from Henry-YSLin/IHasSeed-interface ... Extract `SeedSettingsControl` to `IHasSeed` interface	2021-06-23 14:10:34 +09:00
Dean Herbert	54084f8a9c	Move SeedSettingsControl to own file	2021-06-23 13:40:05 +09:00
smoogipoo	6fd020d91d	Remove unnecessary public accessibility ... All interface members are implicitly public.	2021-06-23 12:00:57 +09:00
Salman Ahmed	2b1f461d79	Pass empty resource store for FallbackShaderManager base constructor	2021-06-22 12:36:45 +03:00
Dean Herbert	1b0aadcc6f	Merge branch 'master' into transformers-per-skin	2021-06-22 16:03:15 +09:00
Henry Lin	fc224c53f4	Remove extra usings	2021-06-22 14:49:37 +08:00
Henry Lin	3745101f32	Extract seed setting control to IHasSeed	2021-06-22 14:43:41 +08:00
Salman Ahmed	67f0344c0c	Add support for loading shaders from ruleset resources	2021-06-20 23:07:44 +03:00
Dean Herbert	3f336d88ec	Merge pull request #11461 from peppy/realm-key-binding-store ... Add initial realm database implementation with KeyBindingStore migration	2021-06-19 02:49:41 +09:00
Dean Herbert	89c27dcb10	Merge pull request #13517 from ekrctb/initial-entry ... Allow setting `Entry` of `PoolableDrawableWithLifetime` (including `DrawableHitObject`)	2021-06-19 00:03:41 +09:00
Dean Herbert	2dadc9d686	Remove unused using statement	2021-06-18 19:39:01 +09:00
Dean Herbert	78c5ccda60	Fix renaming a ruleset DLL causing a startup crash	2021-06-18 19:32:40 +09:00
smoogipoo	42c5a962fb	Add xmldoc remark	2021-06-18 19:27:10 +09:00
smoogipoo	36d51d5117	Don't set entry immediately	2021-06-18 19:23:37 +09:00
smoogipoo	36d2199a02	Add exception on Apply() while loading	2021-06-18 19:20:57 +09:00
Dean Herbert	c369beeaaa	Merge branch 'master' into realm-key-binding-store	2021-06-18 16:52:35 +09:00
Dan Balasescu	2cd72a92e8	Merge pull request #13499 from ekrctb/fix-mania-editor-crash ... Rewrite mania selection blueprint to use only `HitObject` (no `DrawableHitObject`) for layout	2021-06-18 15:10:28 +09:00
Dan Balasescu	cdc1c60fab	Merge branch 'master' into fix-mania-editor-crash	2021-06-18 13:49:25 +09:00
smoogipoo	97cd1217a4	Move IApplicableToDrawableHitObjects to its own file	2021-06-18 13:06:13 +09:00
Dan Balasescu	6cec1145e3	Merge pull request #13523 from ekrctb/applicable-to-dho ... Reduce boilerplate of `IApplicableToDrawableHitObjects` by taking a single DHO instead of an enumerable	2021-06-17 19:59:06 +09:00
Dean Herbert	9495f87f04	Remove redundant NotNull attributes in nullable classes	2021-06-17 16:07:32 +09:00
ekrctb	e7954ecb60	Use property instead of backing field consistently	2021-06-17 10:31:20 +09:00
ekrctb	9dcd0bf311	Remove IPlayfieldProvider by caching Playfield	2021-06-17 10:15:24 +09:00
Bartłomiej Dach	418dbf3f3e	Merge branch 'master' into fix-mania-editor-crash	2021-06-16 18:26:33 +02:00
ekrctb	b6a9fa9999	Merge branch 'master' into applicable-to-dho	2021-06-16 22:04:10 +09:00
Dan Balasescu	6613301588	Merge branch 'master' into refactor-scrolling-hoc-2	2021-06-16 19:20:11 +09:00
ekrctb	c59a3ce83f	Obsolete plural IApplicableToDrawableHitObjects	2021-06-16 18:52:16 +09:00
ekrctb	af80418ee8	Implement IApplicableToDrawableHitObject for mods ... A breaking change in `ModWithVisibilityAdjustment` if the method was overriden.	2021-06-16 18:52:01 +09:00
ekrctb	67d8e0059f	Use singular IApplicableToDrawableHitObject for consumers	2021-06-16 18:47:04 +09:00
ekrctb	e69bb67afe	Add IApplicableToDrawableHitObject that is taking a single DHO ... Less cumbersome to implement than old version taking an enumerable. The implementation was always using `foreach` for the enumerable. The new interface is not used yet.	2021-06-16 18:42:28 +09:00
Dean Herbert	4b45d8318e	Merge branch 'master' into transformers-per-skin	2021-06-16 16:37:28 +09:00
ekrctb	117e94bc94	Allow setting Entry of PoolableDrawableWithLifetime ... It is more convenient than using the constructor because the only limited kind of expression is allowed in a base constructor call. Also, the object initializer syntax can be used.	2021-06-16 16:00:08 +09:00
Dean Herbert	66efc3c4de	Merge branch 'master' into realm-key-binding-store	2021-06-16 13:23:13 +09:00
emu1337	be68950c30	refactoring	2021-06-16 03:34:46 +02:00
Dean Herbert	acc06ca398	Merge branch 'master' into realm-key-binding-store	2021-06-16 02:14:58 +09:00
Dan Balasescu	e9d4ee3c87	Merge branch 'master' into enhance-mod-settings-text-box-visibility	2021-06-15 16:09:55 +09:00
ekrctb	ef96ceb4ab	Introduce IPlayfieldProvider	2021-06-15 14:43:04 +09:00
ekrctb	bbf0022689	Use natural anchor for TimeAtPosition and PositionAtTime ... The natural anchor is the end of the scrolling direction (e.g. Bottom for Down scrolling).	2021-06-15 13:15:20 +09:00
Bartłomiej Dach	cb1e2e3d97	Improve xmldoc	2021-06-14 21:54:55 +02:00
ekrctb	660bf50dc7	Clarify multiple coordinate systems ... - Fix wrong position is set for DHOs for down/right scrolling direction.	2021-06-14 13:13:27 +09:00
ekrctb	09f1cbde7e	Fix TimeAtPosition doc comment	2021-06-14 13:13:27 +09:00
ekrctb	fdb09ef4d7	Simplify flipPositionIfRequired using scrollLength	2021-06-14 13:13:27 +09:00
ekrctb	8cf4454780	Use Direction enum instead of int ... The property is named `scrollingAxis` to distinguish from `direction`, which is of `ScrollingDirection` type (unfortunate name crash).	2021-06-14 13:13:27 +09:00
Pasi4K5	ef9cb2c958	Rename nested classes	2021-06-12 18:37:31 +02:00
Pasi4K5	b79d57b68c	Move OsuSettingsNumberBox into SettingsNumberBox	2021-06-12 17:57:40 +02:00
Pasi4K5	c728f673d6	Rename classes	2021-06-12 17:37:01 +02:00
Pasi4K5	29f3880415	Move classes into SettingsTextBox	2021-06-12 17:34:02 +02:00
Pasi4K5	fe39a47797	Add OsuModSettingsTextBox and OsuModSettingsNumberBox	2021-06-12 00:34:53 +02:00
Dan Balasescu	3389c4830b	Merge branch 'master' into refactor-scrolling-hoc-1	2021-06-11 20:35:19 +09:00
ekrctb	af3f253b21	Refactor ScrollingHitObjectContainer and expose more useful methods	2021-06-11 18:28:48 +09:00
Bartłomiej Dach	296761ade5	Add missing CurrentSkin null check in DHO disposal	2021-06-11 09:18:58 +02:00
Dean Herbert	562cfe8703	Fix filename not matching type rename	2021-06-11 14:34:18 +09:00
Dean Herbert	bc3b7233ab	Show osu!taiko centre/rim colouring in editor timeline ... Closes #13443.	2021-06-11 14:17:30 +09:00
Salman Ahmed	09a2d008d2	Refrain from attempting to transform null skins	2021-06-10 16:36:45 +03:00
Dan Balasescu	35d5632355	Merge pull request #13378 from Syriiin/diffcalc/refactor/auto-properties ... Refactor DifficultyAttributes to use auto properties over public fields	2021-06-10 18:42:11 +09:00
Salman Ahmed	dde84e5cbd	Merge branch 'master' into transformers-per-skin	2021-06-10 11:58:52 +03:00
Dan Balasescu	a44fd887ee	Merge branch 'master' into no-unranked-display	2021-06-10 17:09:46 +09:00
Dean Herbert	9044a20120	Merge branch 'master' into realm-key-binding-store	2021-06-10 13:58:08 +09:00
Salman Ahmed	cf40282f1f	Convert LegacySkinTransformers to accept raw ISkins rather than a full ISkinSource	2021-06-09 22:49:31 +03:00
PercyDan54	510fc93d76	Merge branch 'master' of https://github.com/ppy/osu into auto-restart	2021-06-09 18:05:47 +08:00
Dean Herbert	b8df3fff9e	Fix incorrect method referenced in xmldco ... Co-authored-by: ekrctb <32995012+ekrctb@users.noreply.github.com>	2021-06-09 14:20:01 +09:00
Dean Herbert	d0e9f8ef90	Replace and obsolete Ranked flag with IsUserPlayable	2021-06-09 14:17:03 +09:00
Dean Herbert	62199a38a8	Add one missing obsoletion removal date	2021-06-09 14:11:50 +09:00
Dean Herbert	f41e34ae2c	Remove more obsoleted members	2021-06-09 14:10:48 +09:00
Dean Herbert	a87226ab10	Remove obsoleted DrawableJudgement methods ... Undated, but change was made on 2020-11-18.	2021-06-09 14:09:23 +09:00
Samuel Cattini-Schultz	f1bef989b7	Refactor DifficultyAttributes to use auto properties over public fields	2021-06-08 19:43:59 +10:00
Dan Balasescu	57a38374db	Merge branch 'master' into fix-spectator-frame-conversion	2021-06-04 21:17:40 +09:00
Dan Balasescu	b283c48abb	Merge branch 'master' into factor-out-hoc	2021-06-04 15:31:35 +09:00
Dean Herbert	23096c58bb	Merge branch 'master' into fix-spectator-frame-conversion	2021-06-04 15:06:15 +09:00
Dan Balasescu	50c60c791f	Merge pull request #13322 from Pasi4K5/seed-for-all-random-mods ... Add seed option for all random mods	2021-06-04 11:26:13 +09:00
Dean Herbert	d444fed46f	Detach gameplay score from replay recorder before importing ... Closes #13320.	2021-06-04 02:00:02 +09:00
Pasi4K5	7a4fc9ffc8	Move seed to base class	2021-06-03 18:16:11 +02:00
smoogipoo	e887807ae7	Apply review fixes	2021-06-03 18:32:05 +09:00
smoogipoo	c3280083a2	Merge branch 'master' into fix-spectator-frame-conversion	2021-06-03 17:42:01 +09:00
Dan Balasescu	15b43beef1	Merge pull request #11857 from Syriiin/diffcalc/refactor/catch-clockrate-effects ... Refactor catch Movement skill to not require explicit clockrate usage	2021-06-03 17:29:27 +09:00
smoogipoo	420df124b5	Add framestable-bypassing seek for spectator	2021-06-03 17:27:21 +09:00
Samuel Cattini-Schultz	f51413ead9	Refactor to pass clockrate in constructor rather than deriving from mods	2021-06-03 16:09:42 +10:00
ekrctb	b321b20e9d	Remove OnAdd/OnRemove of HitObjectContainer ... Instead, override `AddDrawable`/`RemoveDrawable`.	2021-06-03 15:00:16 +09:00
ekrctb	0ce7baa3f3	Make HitObjectContainer.Clear non-virtual ... It just call `Remove` for all entries.	2021-06-03 15:00:16 +09:00
ekrctb	2c9e5b6c7e	Replace EntryCrossedBoundary with more useful RemoveRewoundEntry property ... It can be used for dynamically added entries.	2021-06-03 15:00:16 +09:00
ekrctb	fe2934db1d	Factor out lifetime management logic of HitObjectContainer	2021-06-03 14:57:28 +09:00
Dan Balasescu	44b1102241	Merge branch 'master' into autoplay-pause-support	2021-06-03 13:26:00 +09:00
smoogipoo	d3d8941ec8	Make method internal	2021-06-02 11:11:41 +09:00
smoogipoo	8ee2b3a2d2	Merge branch 'master' into fix-scrolling-lifetime	2021-06-02 11:08:28 +09:00
Dan Balasescu	ac83450791	Merge pull request #13256 from ekrctb/update-lifetime-2 ... Update DHO lifetime on entry lifetime change	2021-06-02 11:07:54 +09:00
Dean Herbert	8a76d97b63	Remove replay logic from DrawableRuleset (and implement in DrawableEditorRulesetWrapper)	2021-06-02 11:06:30 +09:00
Dean Herbert	f14c0eae99	Fix editor no longer creating autoplay frames	2021-06-01 17:28:41 +09:00
ekrctb	40949f6c1b	Simplify lifetime setter ... Setting entry lifetime will cause `LifetimeChanged` event and `base.LifetimeStart`/`End` will be modified in the callback.	2021-06-01 14:46:43 +09:00
ekrctb	0f381f7758	Fix wrong code	2021-06-01 14:38:02 +09:00
ekrctb	86020adf64	Revert invalid code transformation	2021-06-01 14:28:23 +09:00
Dean Herbert	14570b6fb1	Merge branch 'master' into autoplay-pause-support	2021-06-01 14:19:21 +09:00
ekrctb	d5714e63b9	Apply code styling suggestions ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-06-01 13:17:30 +09:00
ekrctb	86d1ba7ef2	Remove unused IScrollingHitObject interface	2021-05-31 23:17:26 +09:00
ekrctb	ff04942295	Change timing of HitObjectContainer.OnAdd/OnRemove ... Now, `OnAdd` is always invoked after the DHO is added to the container. This change is required by `ScrollingHitObjectContainer` to compute origin adjusted lifetime when origin position is relative to the parent drawable size.	2021-05-31 20:56:25 +09:00
ekrctb	948a14a627	Merge branch 'simplify-shoc' into fix-scrolling-lifetime ... # Conflicts: # osu.Game/Rulesets/UI/Scrolling/ScrollingHitObjectContainer.cs	2021-05-31 16:50:47 +09:00
ekrctb	86d1225aad	Reset lifetime to initial lifetime when layout is invalidated	2021-05-31 16:47:10 +09:00
ekrctb	6d96846776	Remove scrollLength caching field ... It was not clear when the field is updated.	2021-05-31 16:28:02 +09:00
ekrctb	742c5b442b	Remove delay of lifetime update ... The scheduling is no longer necessary because `OnAdd` is changed to not invoked immediately for non-pooled DHOs.	2021-05-31 16:24:13 +09:00
ekrctb	3cedc0824d	Don't add nested hit objects to the sets ... Only top-level hit objects are checked for layout computation caching. Also, lifetime of nested hit objects are not managed by the HitObjectContainer.	2021-05-31 16:20:35 +09:00
ekrctb	56a0a24cba	Make SetInitialLifetime public	2021-05-31 15:33:28 +09:00
ekrctb	e25cca6fbe	Update drawable lifetime on entry lifetime change	2021-05-31 14:45:29 +09:00
Dan Balasescu	8c6277f0d8	Merge pull request #13235 from ekrctb/update-lifetime-1 ... Update hit object lifetime on `HitObject.DefaultsApplied`	2021-05-31 14:44:40 +09:00
ekrctb	0c101d2859	Apply comment rewording suggestion ... Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2021-05-31 13:41:49 +09:00
ekrctb	abb77b95b4	Fix comment grammar	2021-05-30 13:06:28 +09:00
ekrctb	265dfe5416	Add test case of DHO setting LifetimeStart in OnApply	2021-05-28 21:51:48 +09:00
ekrctb	43bf734816	Reset lifetime on HitObject.DefaultsApplied	2021-05-28 21:35:26 +09:00
ekrctb	1d5e8f4a91	Fix wrong/misleading comment of InitialLifetimeOffset	2021-05-28 17:19:36 +09:00
Dean Herbert	122bb05aa8	Add a mention that OnApply/OnFree is performed after ApplyDefaults	2021-05-27 15:20:35 +09:00
Dean Herbert	a3c78674a1	Add new interface for autoplay mods	2021-05-25 18:09:24 +09:00
Dean Herbert	a249bb9e69	Merge branch 'master' into realm-key-binding-store	2021-05-25 17:18:33 +09:00
Dan Balasescu	774611f142	Merge pull request #12933 from peppy/fix-scroll-wheel-gameplay-bindings ... Disallow using scroll wheel for gameplay bindings	2021-05-25 16:04:18 +09:00
Dean Herbert	57640810b5	Ignore certain banned InputKeys for gameplay purposes	2021-05-24 18:40:40 +09:00
Dan Balasescu	7a343c1576	Merge pull request #12915 from peppy/regenerate-replay-less ... Ensure `RegenerateAutoplay` is only run once per frame	2021-05-24 17:25:42 +09:00
smoogipoo	7494ddeef4	Fix DHOs not receiving initial skin changed events	2021-05-24 14:07:40 +09:00
Dean Herbert	bbfd7ea23f	Ensure RegenerateAutoplay is only run once per frame	2021-05-23 21:20:08 +09:00
Dan Balasescu	5ad41ded94	Merge branch 'master' into fix-dho-lmc	2021-05-21 19:11:57 +09:00
smoogipoo	6beeb7f7c4	Rename SpectatorStreamingClient -> SpectatorClient	2021-05-20 15:55:07 +09:00
ekrctb	0489ae719d	Don't couple PoolableDrawableWithLifetime lifetime with its entry ... It turns out the incompatibility with `LifetimeManagementContainer` causes more issues than anticipated.	2021-05-20 14:56:15 +09:00
Dean Herbert	6c4709e7b4	Fix PlacementBlueprint using the wrong beatmap when applying defaults ... Closes #12855.	2021-05-19 18:34:07 +09:00
Dan Balasescu	ef81bdf63f	Merge branch 'master' into always-use-lifetime-entry	2021-05-18 20:10:12 +09:00
ekrctb	84a1a86c63	Revert "Use entry to calculate lifetime in ScrollingHOC" ... This reverts commit 632bb70e	2021-05-18 19:55:31 +09:00
ekrctb	2c65b8fa93	Revert "Fix uninitialized scrollLength value is used" ... This reverts commit 73dfb04d	2021-05-18 19:55:25 +09:00
Dean Herbert	a96603f025	Merge pull request #12782 from smoogipoo/rework-hitobject-blueprints ... Rename hitobject blueprints and tie them to HitObjects	2021-05-18 16:30:58 +09:00
smoogipoo	882d54a8f8	Remove now unnecessary Apply() method	2021-05-18 14:26:26 +09:00
smoogipoo	e621cfc4ea	Add Apply() method for applying new DHOs	2021-05-18 14:14:10 +09:00
smoogipoo	f1f3606fd0	Fix unresolved xmldocs	2021-05-18 13:11:58 +09:00
Dan Balasescu	9d423245d8	Fix up xmldocs ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-05-18 13:02:23 +09:00
Dean Herbert	a32f1ef35a	Merge pull request #12811 from PercyDan54/hidden-code-cleanup ... Remove obsolete methods in `ModHidden` and apply few touches	2021-05-16 22:07:45 +09:00
Dean Herbert	bdcb1a624e	Merge pull request #12759 from Naxesss/beatmap-verifier-context ... Encapsulate check arguments in context object	2021-05-15 15:39:12 +09:00
PercyDan54	166974506e	Duplicate implementions	2021-05-15 11:55:50 +08:00
PercyDan54	6e5c4ed7c6	Revert "Remove empty override" ... This reverts commit a86a4bab91.	2021-05-15 11:45:14 +08:00
Bartłomiej Dach	628e7a71ed	Ignore possible nulls in Type.GetType() calls ... They're mostly used in extensibility scenarios, so everything happens in runtime. There is no better resolution than to crash with a null reference exception.	2021-05-15 00:09:34 +02:00
PercyDan54	a86a4bab91	Remove empty override	2021-05-14 21:55:32 +08:00
PercyDan54	67dfeeb1b7	Cleanup code in ModHidden	2021-05-14 21:29:13 +08:00
Dean Herbert	fcb226bd20	Add local variable for regular access to HitObjects	2021-05-14 16:23:45 +09:00
Naxess	a447f20095	Fix formatting of #nullable enable	2021-05-14 03:38:35 +02:00
Naxess	90e0b3374e	Add #nullable enable ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2021-05-14 03:34:50 +02:00
smoogipoo	ffb6135a1b	Rework hitobject blueprints to take in hitobject models	2021-05-13 19:53:32 +09:00
Naxess	19800f5f7f	Move IBeatmap arg into context	2021-05-13 11:24:22 +02:00
Naxess	b37cb3bdbe	Change interpreted difficulty from bindable to regular value ... There's no reason for why checks would need this to be bindable. A 1-directional binding is more appropriate.	2021-05-13 09:00:30 +02:00
Naxess	e7c7786db3	Merge branch 'master' into beatmap-verifier-context	2021-05-13 07:40:33 +02:00
Dean Herbert	5b71d8ca37	Merge pull request #12758 from Naxesss/verify-settings-ui ... Add setting UI components to the verify screen	2021-05-13 14:35:35 +09:00
Bartłomiej Dach	1b579dd838	Extract invariant instantiation info extension method	2021-05-12 23:23:51 +02:00
Naxess	b7bc42e0d3	Rename "playableBeatmap" check arg to "beatmap" ... The working beatmap is now in the context, so it's easier to distinguish beatmap type, hence no need for this prefix.	2021-05-12 02:34:16 +02:00
Naxess	64d96b06a6	Add interpreted difficulty info to BeatmapVerifierContext ... Enables checks to make use of the difficulty level as shown in the settings UI.	2021-05-12 02:30:21 +02:00
Naxess	c13b93e6f1	Replace IWorkingBeatmap arg with BeatmapVerifierContext in checks ... This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes. See next commit for example.	2021-05-12 02:29:18 +02:00
Naxess	75adec57eb	Remove negligible default hidden TODO	2021-05-12 01:31:16 +02:00
Dean Herbert	2ecd638f7f	Merge branch 'master' into skin-components-list	2021-05-10 18:13:10 +09:00
ekrctb	111b501ced	Revert accidental removal of UTF-8 BOM	2021-05-07 18:04:38 +09:00
ekrctb	207f7f1e56	Rename FramedAutoGenerator<T> -> AutoGenerator<T>	2021-05-07 00:31:12 +09:00
ekrctb	ea35b72436	Remove unused IAutoGenerator interface	2021-05-06 22:57:07 +09:00
ekrctb	9be36230f9	Introduce AutoGenerator subclass for frame based replay generation	2021-05-06 21:59:11 +09:00
Dean Herbert	aff32b0d19	Merge branch 'master' into skin-components-list	2021-05-06 14:17:33 +09:00
Salman Ahmed	cd6d070b4a	Consider "combo offsets" as legacy logic and separate from combo information	2021-05-05 07:43:08 +03:00
Salman Ahmed	eeeb001d62	Refactor combo colour retrieval logic to request skin lookups instead	2021-05-05 07:17:27 +03:00
ekrctb	aa42cf2fc0	Fix setting lifetime during KeepAlive is ignored	2021-05-04 16:56:48 +09:00
ekrctb	913fc8c3bc	Revert the change of not adding non-pooled DHO to HOC until alive	2021-05-04 16:44:48 +09:00
ekrctb	36438175a0	Throw an exception if try to modify lifetime of PoolableDrawableWithLifetime without lifetime	2021-05-04 16:04:58 +09:00
Salman Ahmed	943c497397	Return back removed using	2021-05-03 02:02:14 +03:00
Salman Ahmed	b2130fc600	Fix replay frames sort instability	2021-05-03 01:58:44 +03:00
Dean Herbert	a551958eeb	Move caching of IBeatmap to base DrawableRuleset	2021-05-01 21:32:45 +09:00
Justus Franklin Tumacder	fdf8c12947	Replace BeatDivisorFinder with GetClosestBeatDivisor	2021-05-01 11:57:47 +08:00
Justus Franklin Tumacder	ecb053b0de	Merge branch 'master' of https://github.com/ppy/osu into justusft/mania-color-snap	2021-05-01 11:20:28 +08:00
Bartłomiej Dach	9cb55ca245	Merge branch 'master' into barrel-roll	2021-04-30 22:27:27 +02:00
Salman Ahmed	b145f46a0a	Merge branch 'master' into skin-components-list	2021-04-30 21:10:55 +03:00
Dan Balasescu	e6eea73b8b	Merge branch 'master' into basic-compose-checks	2021-04-30 23:41:46 +09:00
Dean Herbert	a1e64f4e3c	Use the existing toolbox design	2021-04-30 14:41:06 +09:00
Dean Herbert	e69ec91c07	Add xmldoc for CurrentRotation	2021-04-30 11:25:39 +09:00
Andrei Zavatski	7bf3498e2a	Calculate playfield scale locally	2021-04-30 02:49:19 +03:00
Andrei Zavatski	25e0fb1cf9	Refactor OsuModBarrelRoll to allow it's usage by other rulesets	2021-04-30 01:59:59 +03:00
Dean Herbert	9c62c90cfc	Refactor SelectionBlueprint and MoveSelectionEvent to work in screen-space coordinates ... Until now, the implementation of the overrides in `SelectionBlueprint` have been confusing to the point where I would just implement by trial-and-error (or copying from an existing implementation). This was due to a combination of using "object" space coordinates (ie. the thing the `Blueprint` is operating on) and screen-space coordinates. This change switches all event related coordinates to screen-space, which is how we already handle rotation/scale operations. With the introduction of other editor types where the related objects are drawables, this also makes a lot more sense.	2021-04-29 16:10:42 +09:00
Dean Herbert	5b009c21bb	Merge branch 'master' into abstract-blueprint-handling	2021-04-29 16:10:22 +09:00
ekrctb	73dfb04df8	Fix uninitialized scrollLength value is used	2021-04-29 15:17:30 +09:00
ekrctb	632bb70e0f	Use entry to calculate lifetime in ScrollingHOC ... DHOs cannot be used to calculate lifetime, it is not created before the entry became alive.	2021-04-29 15:04:32 +09:00
ekrctb	c83c804057	Expose lifetime entries from HOC	2021-04-29 14:42:41 +09:00
ekrctb	5aa522b1c2	Completely delegate DHO lifetime to Entry lifetime ... A downside is lifetime update is not caught by LifetimeManagementContainer if used.	2021-04-29 14:38:01 +09:00
ekrctb	799d2a3300	Replace failed mania test (pooling not accounted) with a more robust test ... Also fix null reference in Playfield	2021-04-29 14:38:01 +09:00
ekrctb	d262956146	Always use LifetimeEntry to manage hit objects in HitObjectContainer ... Previously, non-pooled DHOs were immediately added as children of the HOC when Add is called. Also, non-pooled DHOs were always attached to the HOC as children. New behavior is that non-pooled DHOs are only added after CheckChildLifetime, and only attached to the HOC while the DHOs are alive. - LifetimeManagementContainer inheritance of HOC is removed, as it is now all DHOs are "unmanaged" (previously `AddInternal(false)`). - The signature of `Clear` is changed, and it is now always not disposing the children immediately.	2021-04-29 14:38:01 +09:00
Dean Herbert	f3c7694eeb	Rename methods to match generally how these find-methods are named elsewhere	2021-04-28 16:57:52 +09:00
Dean Herbert	48d6c9ac4b	Move snap/divisor helper methods to inside ControlPointInfo	2021-04-28 16:47:30 +09:00
smoogipoo	61b7dc1e06	Fix bonus-only maps having 700K base score	2021-04-28 03:42:29 +09:00
Dan Balasescu	5fc731967b	Merge pull request #12592 from ekrctb/fix-entry-lifetime ... Fix Setting DHO's lifetime doesn't update its entry lifetime	2021-04-28 01:38:19 +09:00
smoogipoo	1281993f1f	Fix bonus score not calculated from the correct statistics	2021-04-27 22:42:58 +09:00
Naxess	200352b750	Rename unsnap check templates	2021-04-27 13:56:05 +02:00
ekrctb	b87446a577	Simplify HitObjectLifetimeEntry logic a bit	2021-04-27 19:37:01 +09:00
Dean Herbert	2adc751e04	Merge pull request #12585 from LumpBloom7/Reset-DHO-Transforms-method ... Add method to safely refresh DrawableHitObject transforms	2021-04-27 19:15:12 +09:00
Dean Herbert	7ec5ea1eb5	Remove hitobject terminology from base classes	2021-04-27 19:01:29 +09:00
Dean Herbert	dd3d8e5d03	Make SelectionHandler abstract to ensure things get implemented	2021-04-27 19:01:29 +09:00
Dean Herbert	f2e56bd306	Refactor editor selection/blueprint components to be generic	2021-04-27 19:01:29 +09:00
Derrick Timmermans	3ea55314f2	Update osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs ... Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2021-04-27 11:29:16 +02:00
ekrctb	3899e500d3	Adopt framework change of LifetimeEntry ... Override SetLifetimeStart/SetLifetimeEnd separately to track individual assignment. It is necessary to ensure real lifetime is not lost when lifetime is partially updated.	2021-04-27 17:54:18 +09:00
ekrctb	c9e6ca5378	Use now-public Entry.SetLifetime method	2021-04-27 15:25:05 +09:00
ekrctb	a2c0951d94	Use overriding instead of hiding in HitObjectLifetimeEntry ... Hidden properties are used when the type is the base class. It caused issues when `DrawableHitObject` logic is factored out to `PoolableDrawableWithLifetime` because it is using the base `LifetimeEntry`, not `HitObjectLifetimeEntry`.	2021-04-27 15:23:33 +09:00
Dean Herbert	ec1c336b0a	Fix a couple of inspections	2021-04-27 13:23:14 +09:00
Naxess	7a6e9e5070	Change category of unsnap check to timing ... Makes more sense, as this is typically the result of timing changes.	2021-04-27 02:32:57 +02:00
Naxess	9e49ecb573	Remove unused virtual keywords ... Added these in a previous iteration, where I had the mania variant inherit this class. No longer necessary as `IHasColumn` was used to make this check more generic.	2021-04-27 02:23:06 +02:00
Naxess	a3c1b1fd52	Fix accessibility of areConcurrent	2021-04-27 01:24:38 +02:00
Naxess	ce258febf6	Rename CheckUnsnaps -> CheckUnsnappedObjects ... Will potentially have `CheckUnsnappedKiai` or similar later, so this is worth specifying. Also consistent with `CheckConcurrentObjects`, which will likely have a `CheckConcurrentLines` later.	2021-04-26 20:32:44 +02:00
Naxess	b9e4f73f78	Add concurrent objects check to BeatmapVerifier	2021-04-26 20:28:59 +02:00
Naxess	a3570e18dd	Add concurrent objects check ... Here we use `IHasColumn` to support rulesets with columns, and so I moved that interface out into `osu.Game` from `osu.Game.Rulesets.Mania`. We also use the same threshold as the unsnap check to ensure that no problems slip through. Specifically where an object is simultaneously not concurrent and not unsnapped but still on the same tick.	2021-04-26 20:17:18 +02:00
Derrick Timmermans	08a232f7fa	Add method to safely refresh DrawableHitObject transforms	2021-04-26 20:08:40 +02:00
Naxess	9b9c473616	Remove redundant string formatting	2021-04-26 16:17:38 +02:00
Naxess	7b9ed924be	Rename snapping methods ... Further separates them from `IBeatSnapProvider`'s `SnapTime`, and groups them together more, to prevent confusion between the two interfaces. Also changes the xmldoc of the reference time to that of `IBeatSnapProvider` for consistency.	2021-04-26 16:07:30 +02:00
Dan Balasescu	6d2a5b614c	Merge branch 'master' into drawable-object	2021-04-26 18:33:44 +09:00
smoogipoo	fd5fbaf0db	Rename ruleset wrapper class	2021-04-26 15:37:42 +09:00
Naxess	049e42fa85	Move snapping responsibility to IBeatmap ... Seems `EditorBeatmap` already implements a different kind of `SnapTime` from `IBeatSnapProvider`, so method names here aren't great. This is very similar to what https://github.com/ppy/osu/pull/12558 is doing, so may need to do some duplicate resolution later, especially surrounding `ClosestBeatSnapDivisor`. Worth noting that this change makes 1/7, 1/5, etc unsupported for now, as we now rely on `BindableBeatDivisor.VALID_DIVISORS`.	2021-04-26 05:07:24 +02:00
ekrctb	6561a7c7d6	Rename DrawableObject -> PoolableDrawableWithLifetime	2021-04-26 12:06:21 +09:00
ekrctb	20e3cadd30	freeIfInUse -> free, and add comments	2021-04-26 12:04:59 +09:00
ekrctb	e6474e6ff7	Remove redundant statement (lifetime is set in base)	2021-04-26 11:47:38 +09:00
Justus Franklin Tumacder	8bb1fcd39b	Add tests for BeatDivisorFinder	2021-04-26 07:07:32 +08:00
Bartłomiej Dach	33a5c156a1	Use existing snap list from BindableBeatDivisor	2021-04-25 17:52:11 +02:00
Bartłomiej Dach	e14255f395	Rename {Snap -> BeatDivisor}Finder	2021-04-25 17:44:26 +02:00
Naxess	6fd77e536d	Add unsnap check	2021-04-25 05:34:54 +02:00
Justus Franklin Tumacder	211bff6a8f	Fix cake errors	2021-04-25 09:21:25 +08:00
Justus Franklin Tumacder	1f48378ce7	Add xmldoc to SnapFinder	2021-04-25 08:53:45 +08:00
Justus Franklin Tumacder	e0ca44c908	Move SnapFinder from mania ruleset to osu.Game	2021-04-25 07:35:53 +08:00
Dan Balasescu	739d83da2a	Merge pull request #12515 from frenzibyte/legacy-scores-classic-mod ... Apply "classic" mod to all legacy scores	2021-04-22 19:52:09 +09:00
smoogipoo	d4d78f7434	Merge branch 'master' into legacy-scores-classic-mod	2021-04-22 18:44:20 +09:00
Dean Herbert	9a7bf8109f	Allow certain mouse input to pass through PlacementBlueprints to the selection logic	2021-04-22 15:44:12 +09:00
ekrctb	b877a29737	Factor out pooling and lifetime management logic of DHO to a base class	2021-04-21 17:37:42 +09:00
ekrctb	bbf2ec369b	Remove SkinReloadableDrawable inheritance from DHO	2021-04-21 17:34:57 +09:00
Dan Balasescu	cf55383fff	Merge pull request #12486 from ekrctb/unmanaged-hit-object-entry ... Associate DrawableHitObject with HitObjectLifetimeEntry rather than HitObject	2021-04-21 17:08:21 +09:00
Salman Ahmed	e90d791754	Add base "classic" mod	2021-04-21 09:14:19 +03:00
ekrctb	3fbeadf318	Deprecate old overload of Apply	2021-04-21 14:32:37 +09:00
ekrctb	73d3da1687	Fix wrong InitialLifetimeOffset is used for a non-pooled DHO. ... HitObjectLifetimeEntry's InitialLifetimeOffset is different from DrawableHitObject's InitialLifetimeOffset.	2021-04-21 11:32:01 +09:00
ekrctb	44ff08cce4	Revert "Fix wrong InitialLifetimeOffset is used for a non-pooled DHO." ... This reverts commit 67fcfd9d	2021-04-21 10:02:50 +09:00
ekrctb	67fcfd9dbc	Fix wrong InitialLifetimeOffset is used for a non-pooled DHO. ... HitObjectLifetimeEntry's InitialLifetimeOffset is different from DrawableHitObject's InitialLifetimeOffset.	2021-04-21 09:48:16 +09:00
ekrctb	e80c3c317a	Rename UnmanagedHitObjectEntry -> SyntheticHitObjectEntry ... "Unmanaged" was confusing because its lifetime is still managed by the HitObjectContainer.	2021-04-21 09:23:23 +09:00
ekrctb	c6ee4e900e	Ensure a non-null hitobject entry has a non-null Result	2021-04-20 15:18:36 +09:00
ekrctb	8a8b9084ef	Make single-argument overloead of DHO.Apply public	2021-04-20 10:11:36 +09:00
Naxess	0e6b66f457	Merge branch 'master' into bg-audio-quality-checks	2021-04-20 02:36:13 +02:00
ekrctb	1bc63a4c61	Now, DHO.lifetimeEntry can be non-null even it is not fully applied	2021-04-20 09:22:16 +09:00
Naxess	4510e795e1	Fix category of audio quality check	2021-04-20 02:13:26 +02:00
ekrctb	c1b4aaaa03	Add doc comment	2021-04-20 08:38:02 +09:00
Naxess	c633f15565	Add audio quality check	2021-04-20 01:36:03 +02:00
Naxess	40ae856dfc	Show 2 decimals for background filesize	2021-04-20 01:34:05 +02:00
Naxess	14c626ffcb	Use the playable beatmap for file presence checks	2021-04-20 01:33:19 +02:00
Naxess	8656176ab8	Add the playable beatmap as check argument ... This is different from the working beatmap's `.Beatmap` property in that it is mutated by the ruleset/editor. So hit objects, for example, are actually of type `Slider` and such instead of the legacy `ConvertSlider`. This should be preferred over `workingBeatmap.Beatmap`.	2021-04-20 01:31:51 +02:00
Dean Herbert	fc41ad65f8	Merge pull request #12447 from smoogipoo/fix-non-60fps-recording ... Record every 60fps interval	2021-04-19 23:26:58 +09:00
ekrctb	2c487ddb70	Create synthetic LifetimeEntry for a DHO when not supplied ... Now, a DHO is always associated with a HitObjectLifetimeEntry while used. Result is always stored in the entry, and not in the DHO.	2021-04-19 21:54:19 +09:00
ekrctb	5afdc3ff66	Make DHO application logic clearer with Entry/HitObject separation	2021-04-19 19:56:17 +09:00
Naxess	9a69ca34a6	Add audio presence check	2021-04-18 02:07:57 +02:00
Naxess	010720de74	Factor out general file presence checking ... This allows us to use the same method of checking for other files that should exist, for example the audio file. By using the same method, they all share test cases too.	2021-04-18 02:07:33 +02:00
Naxess	56bf49c85c	Take IWorkingBeatmap instead of WorkingBeatmap ... This makes testing much easier, and allows for checking of any class deriving from that interface, including `WorkingBeatmap`.	2021-04-18 01:21:20 +02:00
Naxess	abf512532e	Clean up check logic ... Makes use of the new `BeatmapSet.GetPathForFile` method and removes dependency on `WorkingBeatmap` specifically, allowing us to switch to `IWorkingBeatmap` later.	2021-04-18 01:19:25 +02:00
Naxess	cb41c89935	Don't return low res and too low res at the same time	2021-04-17 20:10:07 +02:00
Naxess	62c54e00cb	Add check for background resolution and filesize	2021-04-17 18:01:04 +02:00
Naxess	448574e7e6	Use WorkingBeatmap instead of IBeatmap ... This lets us access things like the background, track, etc. which are necessary for quality and filesize checks. Also improves the structure of the `CheckBackgroundTest` class in the process.	2021-04-17 17:33:53 +02:00
smoogipoo	d26fa46ef2	Record every 60fps interval	2021-04-16 19:42:44 +09:00
Dean Herbert	f824105075	Merge branch 'master' into fix-slider-zero-length	2021-04-16 18:47:22 +09:00
Dean Herbert	9b95cf227e	Merge branch 'master' into apply-ibindable-interface-change	2021-04-16 17:30:35 +09:00
Dan Balasescu	5ad2d0e759	Merge pull request #12439 from ekrctb/further-refactor-framed-replay ... Further refactor FrameReplayInputHandler, simplify the template code	2021-04-16 17:16:09 +09:00
Dean Herbert	d38e294d96	Centralise length validation function	2021-04-16 15:45:24 +09:00
smoogipoo	8c4804dd7a	Use nameof	2021-04-16 15:40:06 +09:00
smoogipoo	d1c72f5e13	Apply changes resulting from IBindable interface updates	2021-04-16 15:10:53 +09:00
ekrctb	91c7d8d26c	Introduce StartFrame and EndFrame to simplify the replay interpolation code	2021-04-16 14:13:41 +09:00
ekrctb	84bc81a6de	Make FramedReplayInputHandler.CurrentTime non-null	2021-04-16 14:13:41 +09:00
ekrctb	936bde28a3	Remove manual handling of IsActive in RulesetInputManager ... Now it is supported in framework	2021-04-16 14:13:41 +09:00
Dean Herbert	119c9b4294	Fix placement blueprints not being correctly removed after a rolled back placement	2021-04-16 14:11:33 +09:00
Dan Balasescu	ac8e462d32	Merge branch 'master' into refactor-framed-replay-input-hander	2021-04-15 21:48:58 +09:00
Dan Balasescu	98e2245d83	Merge pull request #12422 from ekrctb/no-lazy-list ... Remove usage of Lazy<List<...>> by always allocating an empty list	2021-04-15 20:09:39 +09:00
ekrctb	d8aa436e81	Remove usage of Lazy<List<...>> in NestedPlayfields	2021-04-15 18:26:01 +09:00
ekrctb	50fad47ebc	Remove usage of Lazy<List<...>> for NestedHitObjects	2021-04-15 18:26:01 +09:00
Dean Herbert	346e36d32a	Make Mod.Description abstract and add missing descriptions	2021-04-15 14:36:26 +09:00
Dean Herbert	ba325de595	Merge conditionals for readability	2021-04-15 14:19:59 +09:00
Dean Herbert	5eaf3ea576	Reorganise and reword comments to make time override behaviour a bit clearer	2021-04-15 14:19:06 +09:00
Dean Herbert	7654df94f6	Merge pull request #12395 from frenzibyte/fix-cinema-ignore-settings ... Fix beatmap background displayed if storyboard is hidden on "Cinema" mod	2021-04-14 14:31:03 +09:00
Dean Herbert	cb4f64133e	Add xmldoc to interfaces	2021-04-13 23:30:20 +09:00
Dean Herbert	1ff4e2076f	Merge branch 'master' into verify-tab	2021-04-13 23:05:48 +09:00
Naxess	69da804f81	Add missing period	2021-04-13 13:57:56 +02:00
Dean Herbert	0d6890243f	Fix typo in xmldoc	2021-04-13 20:18:18 +09:00
Dean Herbert	03ba04e8ce	Split out general checks into its own verifier class (and remove static usage)	2021-04-13 19:50:22 +09:00
Naxess	aa5fe2e9fc	Rename BeatmapVerifier -> IBeatmapVerifier	2021-04-13 11:02:01 +02:00
Naxess	60c2494b31	Make BeatmapVerifier an interface	2021-04-13 10:40:56 +02:00
Salman Ahmed	36510309d1	Merge EnableUserDim and IgnoreUserSettings to one bindable	2021-04-13 10:58:56 +03:00
ekrctb	57ba7b7cbb	Partially revert the changes of CurrentFrame and NextFrame for compatibility ... Making those always non-null is postponed as when a replay's frame contains keypress the behavior is changed. Previously, the key is pressed at the time of the first frame. But using non-null frames means the key is pressed at negative infinity. However, I think the new way of always using non-null frames makes the client code so I plan to bundle the change to more breaking changes.	2021-04-13 15:55:23 +09:00
ekrctb	d0f30b7b42	Delay map completion one frame after the last judgment ... This is a workaround of a timing issue. KeyCounter is disabled while break time (`HasCompleted == true`). When the last keypress is exactly at the same time the map ends, the last frame was considered in a break time while forward play but considered not in a break time while rewinding. This inconsistency made the last keypress not decremented in the key counter when a replay is rewound. The situation regularly happens in osu!standard because the map ends right after the player hits the last hit circle. It was caught by `TestSceneGameplayRewinding`. This commit makes the update of the map completion delayed one frame. The problematic keypress frame is now processed strictly before the map completion, and the map completion status is correctly rewound before the keypress frame.	2021-04-13 14:29:47 +09:00
ekrctb	38d10755cb	Merge branch 'master' into refactor-framed-replay-input-hander	2021-04-13 13:47:22 +09:00
Naxess	6d3f9fa9ce	Use is class instead of Equals with template index ... Ensures ordering of `PossibleTemplates` does not affect tests.	2021-04-13 02:29:25 +02:00
Naxess	d8088777ea	Add Equals method to IssueTemplate ... This will be useful in tests.	2021-04-13 01:21:34 +02:00
Salman Ahmed	9679bdfed2	Merge branch 'master' into mod-using-reference-equality	2021-04-12 20:56:24 +03:00
Salman Ahmed	92fab653e1	Take current mod settings value into account on equality comparsion	2021-04-12 20:51:13 +03:00
Naxess	19a154ddf1	Rename checkOrigin -> check ... More consistent with `Issue.ctor`'s "template".	2021-04-12 17:28:12 +02:00
Naxess	bb720c23a0	Remove check ctors and locals	2021-04-12 17:12:37 +02:00
Dean Herbert	62c1812282	Remove redundant parameter naming	2021-04-12 23:37:47 +09:00
Dean Herbert	36bd235021	Move nested classes to bottom of file	2021-04-12 23:36:10 +09:00
Naxess	6d50d01186	Make IssueTemplate.Check readonly	2021-04-12 16:23:05 +02:00
Naxess	caaaba5950	Rename Check -> ICheck	2021-04-12 16:20:53 +02:00
Naxess	008dbc7dd6	Reverse IssueType ordering ... Reversed both in the enum and where it's displayed, so ends up the same in the end.	2021-04-12 15:49:13 +02:00
Naxess	7c4f6d2b62	Rework template usage ... Includes moving the origin check back to templates, constructing nested template classes in each check, and making parameterized template usage.	2021-04-12 15:47:26 +02:00
ekrctb	31d3607105	Add TODO comment	2021-04-12 18:54:36 +09:00
ekrctb	359fae895f	Rename property	2021-04-12 18:50:25 +09:00
ekrctb	6d18b3db00	Avoid empty list allocation	2021-04-12 18:49:38 +09:00
Dean Herbert	b5954a55ad	Remove empty <returns> xmldoc	2021-04-12 17:46:14 +09:00
ekrctb	f1b8171e38	Remove #nullable true for now to suppress inspector	2021-04-12 17:13:48 +09:00
Naxess	a2fc9c398f	Rename CreateChecker -> CreateBeatmapVerifier	2021-04-12 10:08:30 +02:00
Naxess	65ebdd8f7a	Move check origin from IssueTemplate to Issue ... As a result we can also make check an interface, and need to provide the check itself when constructing an issue.	2021-04-12 10:08:08 +02:00
ekrctb	e19e8ff2a3	Rewrite FramedReplayInputHandler for robustness ... This commit changes the semantics of `CurrentFrame` and `NextFrame` of the class. The ordering of `NextFrame.Time` and `CurrentFrame.Time` was dependent on the current direction. Now, it should always satisfy `CurrentFrame.Time <= CurrentTime <= NextFrame.Time` except at the start/end. This change, however, doesn't break existing deriving classes if the template code pattern usage of interpolation is used. The deriving class code can be simplified due to the elimination of nullable types. I didn't include those changes in this commit. I removed `StreamingFramedReplayInputHandlerTest` for now, as it is almost-duplicate of `FramedReplayInputHandlerTest`. I'll include more tests in later commits. This commit fixes #6150.	2021-04-12 16:18:11 +09:00
Dean Herbert	8bf85d737c	Change Metadata into a get property	2021-04-12 15:52:29 +09:00
Dean Herbert	78bbc8f5c8	Tidy some remaining code	2021-04-12 15:52:18 +09:00
Dean Herbert	8c31e96cdf	Change some methods to get properties	2021-04-12 15:52:18 +09:00
Dean Herbert	f78239c7f2	Move enums out of nesting	2021-04-12 15:52:18 +09:00
Dean Herbert	3551322f1d	Fix formatting of colour getter	2021-04-12 15:52:18 +09:00
Dean Herbert	257acf9cd8	Colour constants to private	2021-04-12 15:52:18 +09:00
Dean Herbert	136627b9ac	Wrap xmldoc less and make a few fixes	2021-04-12 15:52:18 +09:00
Dean Herbert	1c553b5d48	Checker -> BeatmapVerifier	2021-04-12 15:29:05 +09:00
Dean Herbert	14bd5bdc77	Merge branch 'master' into verify-tab	2021-04-12 15:14:37 +09:00
ekrctb	d6d8ea5b6b	Throw when getting a frame of an empty replay	2021-04-12 11:17:56 +09:00
Salman Ahmed	18fb9f5ac9	Merge branch 'master' into mod-using-reference-equality	2021-04-11 19:48:55 +03:00
Naxess	3289bb0379	Merge Check and BeatmapCheck ... We're probably not going to need GeneralChecks or BeatmapsetChecks. The verify tab is only available to a single difficulty at a time, and we already have access to the rest of the set through `IBeatmap`.	2021-04-10 14:56:30 +02:00
Naxess	bc4f3351f3	Replace checks with realistic ones	2021-04-10 13:03:16 +02:00
Naxess	b30e41b805	Fix comment; mode -> ruleset	2021-04-10 13:02:36 +02:00
Naxess	d1007ff26a	Move components to more appropriate spot	2021-04-10 13:02:22 +02:00
Dan Balasescu	9aa30fb323	Merge pull request #11688 from Syriiin/diffcalc/dynamic-history ... Implement dynamic previous hitobject retention for Skill class	2021-04-10 01:25:07 +09:00
Samuel Cattini-Schultz	bfd3d0cce9	Implement custom enumerator for ReverseQueue to avoid allocations	2021-04-10 01:16:54 +10:00
smoogipoo	76981f2547	Remove unused using	2021-04-09 13:58:24 +09:00
smoogipoo	8293b06c0a	Remove obsolete code	2021-04-09 13:56:58 +09:00
Dean Herbert	a8839792fd	Merge branch 'master' into circular-arc-freeze	2021-04-08 14:33:03 +09:00
Naxess	0343ef7f14	Add ruleset-specific checker	2021-04-07 14:36:43 +02:00
Naxess	b24ce66a0d	Add check/issue classes	2021-04-07 14:35:33 +02:00
smoogipoo	37e30b00bf	Refactor to keep a consistent API	2021-04-06 16:39:02 +09:00
Dean Herbert	784552022f	Merge pull request #12303 from smoogipoo/fix-last-control-point-segmenting ... Make last control point not able to make an implicit segment	2021-04-06 13:35:55 +09:00
Samuel Cattini-Schultz	5cd43b3a7f	Set default history retention to 0 for Skill and override in StrainSkill ... Some skills might not even require history retention, so why waste the allocations?	2021-04-06 11:53:31 +10:00
Samuel Cattini-Schultz	4f614a703e	Merge branch 'master' into diffcalc/dynamic-history	2021-04-06 11:34:33 +10:00
Samuel Cattini-Schultz	65f93d6f9d	Add more descriptive xmldoc for ReverseQueue	2021-04-06 11:30:58 +10:00
Samuel Cattini-Schultz	ffe7edc16a	Update xmldocs ... Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2021-04-06 11:06:10 +10:00
Dan Balasescu	9d8a26f373	Merge branch 'master' into diffcalc/refactor-strain-skill	2021-04-06 08:21:38 +09:00
Samuel Cattini-Schultz	5bdd15f746	Refactor Skill.Process() to not require calling base.Process()	2021-04-05 22:14:59 +10:00
Samuel Cattini-Schultz	57983ae61f	Fix whitespace	2021-04-05 22:14:59 +10:00
smoogipoo	4b29d0ebe2	Fix last control point starting new segment	2021-04-05 17:49:36 +09:00
Dean Herbert	6bcbef9f25	Merge pull request #12294 from smoogipoo/mania-scoring-adjustments ... Adjust scoring values to better fit osu!mania expectations	2021-04-05 17:19:28 +09:00
smoogipoo	3acc612a67	Adjust scoring values to better fit osu!mania	2021-04-05 13:28:46 +09:00
Samuel Cattini-Schultz	85d2b1232a	Refactor to abstract out strain logic into StrainSkill class ... While it is the case for the existing official Skills, Skill implementations shouldn't be required to conform to a strain based approach. There are other valid approaches to calculating skill difficulty that can be supported by abstracting the strain logic into its own StrainSkill class.	2021-04-03 20:52:39 +11:00
Samuel Cattini-Schultz	5b2dcea8a8	Refactor to encapsulate strain logic into Skill class ... As strains are an implementation detail of the current Skill calculations, it makes sense that strain related logic should be encapsulated within the Skill class.	2021-04-03 20:47:43 +11:00
Samuel Cattini-Schultz	fe66b84bed	Implement dynamic previous hitobject retention for Skill class ... There is no reason we should be limiting skills to knowing only the previous 2 objects. This originally existed as an angle implementation detail of the original pp+ codebase which made its way here, but didn't get used in the same way.	2021-04-03 20:28:51 +11:00
Dan Balasescu	345779b19a	Merge branch 'master' into diffcalc/fix/clockrate-adjusted-decay	2021-04-02 20:58:29 +09:00
Salman Ahmed	5b1dc7d2b4	Remove unused using directive	2021-04-02 02:45:26 +03:00
Salman Ahmed	fcd56dba44	Guard against same ruleset file with loaded assembly filenames instead	2021-04-02 02:12:25 +03:00
Naxess	7e47922fb7	Merge branch 'master' into circular-arc-freeze	2021-04-01 17:09:45 +02:00
Naxess	7b684339ed	Undo public -> internal for PathControlPoint.Changed ... No longer used.	2021-03-31 20:32:49 +02:00
Dean Herbert	690debe507	Merge pull request #12030 from LeNitrous/editor-platform-clipboard-copy	2021-03-29 19:31:16 +09:00
Nathan Alo	9a02f3868c	return a string instead	2021-03-29 17:29:05 +08:00
smoogipoo	ecb66ad2e2	Fix up xmldoc	2021-03-29 15:33:54 +09:00
Samuel Cattini-Schultz	068f00d8a0	Add EndTime to DifficultyHitObject for future convenience	2021-03-27 18:38:43 +11:00
Samuel Cattini-Schultz	010db8968f	Adjust wording of xmldoc	2021-03-27 18:38:23 +11:00
Nathan Alo	b8b7eb4c4b	refactor logic to its own component and handle hit object to string conversion to its ruleset-specific composers	2021-03-26 15:25:20 +08:00
Nathan Alo	2bea69456e	remove implementations	2021-03-26 15:24:33 +08:00
smoogipoo	8438fce764	Merge branch 'master' into diffcalc/fix/clockrate-adjusted-decay	2021-03-26 11:47:38 +09:00
Dean Herbert	701342e036	Remove accuracy rounding at a ScoreProcessor level	2021-03-25 17:43:51 +09:00
Naxess	4ae3eaaac6	Move path type correction ... This is better because `PathControlPointVisualizer` is local to the editor, meaning there is no chance that this could affect gameplay.	2021-03-24 03:02:19 +01:00
Naxess	e922e67c98	Fix inverted return statement ... Forgot to run tests, all passing now.	2021-03-22 19:48:21 +01:00
Naxess	3fa5852e00	Add method documentation	2021-03-22 19:42:27 +01:00
Naxess	b11fd7972a	Separate condition logic from math logic	2021-03-22 19:41:48 +01:00
Naxess	92f713a30e	Improve fallback conditions ... It's possible to create a `PerfectCurve` type path with more than 3 points currently, so this accounts for that.	2021-03-22 19:10:56 +01:00
Naxess	80e7c3aba7	Invert if statement	2021-03-22 19:09:28 +01:00
Naxess	6911a1b415	Fix missing newline	2021-03-22 19:03:55 +01:00
Naxess	a7076c329c	Fix null checks	2021-03-22 17:32:55 +01:00
Naxess	323b875cea	Fix newlines/spaces	2021-03-22 17:32:40 +01:00
Naxess	c82218627f	Add path type update logic ... Only attempts to change points to bezier if points in the slider are modified.	2021-03-22 15:57:57 +01:00
Naxess	7a2cb526e4	Add PointsInSegment method	2021-03-22 15:55:30 +01:00
Naxess	bee2f55d00	Undo subpath limiting	2021-03-22 15:54:33 +01:00
Naxess	fcd1f4930f	Fix freeze due to large circular arc radius ... Seems to stem from the osu!framework's PathApproximator not catching a few edge cases wherein the radius approaches infinity.	2021-03-21 06:34:55 +01:00
Bartłomiej Dach	aec859b4d1	Merge branch 'master' into fix-unsafe-skinnable-sample-play	2021-03-18 19:51:46 +01:00
Nathan Alo	51e0304c54	properly format strings per ruleset	2021-03-17 18:31:09 +08:00
Dean Herbert	9b5d11f2a5	Merge pull request #11958 from bdach/ruleset-filter-v3 ... Allow rulesets to specify custom song select filtering criteria	2021-03-08 23:23:24 +09:00
Bartłomiej Dach	06e42b4b4c	Fix taiko leaving behind empty judgements on legacy skins	2021-03-06 16:02:20 +01:00
Bartłomiej Dach	f00089846b	Merge branch 'master' into ruleset-filter-v3	2021-03-06 12:14:53 +01:00
Dan Balasescu	5b6018295d	Merge branch 'master' into diffcalc/skill-mods	2021-03-04 13:06:26 +09:00
Bartłomiej Dach	f733d1ec1f	Expose and document query parser and helpers	2021-03-03 22:03:01 +01:00
Bartłomiej Dach	14e249a134	Add ruleset interface for extending filter criteria	2021-03-02 20:07:11 +01:00
Dean Herbert	c4ba045df1	Add note about finalizers required for audio store clean-up	2021-03-02 16:07:51 +09:00
smoogipoo	dff1d80f39	Update HasFlag usages to HasFlagFast	2021-02-25 15:38:56 +09:00
Dean Herbert	67773c42ef	Merge pull request #11888 from H2n9/modtimeramp-new-behaviour	2021-02-25 14:01:57 +09:00
Bartłomiej Dach	421b7877d4	Avoid mixing precision across time ramp bindables ... Bears no functional difference, it's just a bit less of an eyesore.	2021-02-24 19:16:10 +01:00
Ronnie Moir	73d6a3687e	Change rate correction logic to be more explicit	2021-02-24 14:40:56 +00:00
smoogipoo	0b44d2483b	Make some properties virtual ... I think they were intended to be this way from the beginning.	2021-02-24 15:03:41 +09:00
smoogipoo	14160b897e	Fix references to ModSuddenDeath	2021-02-24 14:44:53 +09:00
smoogipoo	30a58691f0	Make SD and PF incompatible with each other	2021-02-24 14:34:37 +09:00
Ronnie Moir	f6d3cd6413	Change SamplePlaybackWithRateMods to use rate calulated from the sample ... Replace hardcoded numbers	2021-02-23 21:25:59 +00:00
PercyDan	b55a1acbea	Merge 2babb7ecb0 into e679a1916f	2021-02-23 21:49:03 +01:00
Ronnie Moir	7394c62cc8	Make ModTimeRamp and ModRateAdjust incompatible	2021-02-23 18:10:03 +00:00
Ronnie Moir	a6e840634b	Adjust scrubbing behaviour to allow dragging through rate values	2021-02-23 15:52:53 +00:00
Ronnie Moir	f45cedeb85	Adjust initial and final rate ranges and prevent them from overlapping	2021-02-23 15:38:09 +00:00
Dean Herbert	ec4b770cba	Remove unused using statement	2021-02-23 14:56:03 +09:00
Dean Herbert	672fd3f9d2	When disable mouse buttons during gameplay is selected, disable more globally ... Until now the disable setting would only apply to left/right buttons, and only in gameplay. This change will cause any global actions bound to mouse buttons to also not work during gameplay. Closes #11879.	2021-02-23 14:37:46 +09:00
smoogipoo	ee6a94273d	Merge branch 'master' into fix-unsafe-skinnable-sample-play	2021-02-22 18:31:27 +09:00
Dean Herbert	63dd55c92c	Add missing methods from updated audio component interface implementation	2021-02-22 14:18:52 +09:00
Samuel Cattini-Schultz	66643a97b0	Add a list of mods to Skill class ... Although this isn't necessary for existing official rulesets and calculators, custom calculators can have use cases for accessing mods in difficulty calculation. For example, accounting for the effects of visual mods.	2021-02-20 20:37:44 +11:00
Samuel Cattini-Schultz	442347df8e	Fix clockrate adjusted difficulty calculations bug in strain decay ... When starting a new section, the starting strain value was calculated using the unadjusted timing value, meaning decay curves were essentially being stretched or squashed according to the clockrate. This caused incorrect strain peaks for any section where the peak occurs at the start of the section (none of the objects in the section added enough strain after decay to exceed the starting strain). This bug caused star ratings with clockrates above 1 to be lower than they should and below 1 to be higher than they should.	2021-02-20 20:23:49 +11:00
Dean Herbert	487a39eea9	Update interface implementations with framework changes	2021-02-18 18:52:34 +09:00
Dean Herbert	143e145670	Update implementation of AdjustableAudioComponents	2021-02-18 15:44:23 +09:00
smoogipoo	d3f0c0730d	Merge branch 'master' into non-concurrent-sample-playback	2021-02-12 17:22:15 +09:00
Dan Balasescu	cb4d119f23	Merge pull request #11740 from peppy/editor-fix-slider-samples-new-placement ... Fix newly placed sliders in the editor not playing hitsounds	2021-02-12 13:31:00 +09:00
Dean Herbert	f84ea30637	Expose Mods in DrawableRuleset to avoid using external DI	2021-02-11 17:47:29 +09:00
Dean Herbert	aaa0362b12	Merge branch 'master' into autoplay-rate-independence	2021-02-11 17:39:45 +09:00
Dean Herbert	e9730d4782	Move default sample addition to inside PlacementBlueprint ... This isn't actually required to fix the behaviour but it does feel like a better place to put this logic.	2021-02-11 17:16:18 +09:00
smoogipoo	be9b07a4cf	Merge branch 'master' into difficulty-adjustment-extension	2021-02-10 20:42:08 +09:00
Dean Herbert	4e3bb27cd5	Merge branch 'master' into fix-mod-settings-fuckery	2021-02-09 16:47:39 +09:00
Dean Herbert	1cb51fa8d2	Merge branch 'master' into autoplay-rate-independence	2021-02-09 16:05:34 +09:00
Dean Herbert	8204d360a8	Always reset local user settings when a mod is deselected in ModSelectOverlay	2021-02-09 13:44:42 +09:00
Dean Herbert	be379e0e3c	Change CopyFrom to always overwrite all settings with incoming values	2021-02-09 13:44:11 +09:00
smoogipoo	f4a31287bf	Add/use IHitObjectContainer interface instead of IEnumerables	2021-02-08 20:11:06 +09:00
Bartłomiej Dach	0229851c9c	Apply rounding to ModTimeRamp to improve SPM consistency	2021-02-07 19:02:09 +01:00
Bartłomiej Dach	7daeacaff2	Add and implement IApplicableToRate interface	2021-02-07 18:35:34 +01:00
Bartłomiej Dach	68c20a2a37	Allow autoplay score generation to access mod list	2021-02-07 18:35:34 +01:00
Dean Herbert	06a3a72e43	Merge pull request #11670 from smoogipoo/mania-constant-speed-mod ... Implement mania constant speed mod	2021-02-05 00:26:04 +09:00
smoogipoo	8295fb9081	Implement mania constant speed mod	2021-02-03 16:28:22 +09:00
smoogipoo	921f008217	Fix ModIcon not updating background colour correctly	2021-02-02 21:35:08 +09:00
Bartłomiej Dach	a0de1cbfd0	Handle no-duration single-object edge case	2021-01-31 21:09:41 +01:00
Bartłomiej Dach	547b3d8bed	Fix speed change calculation in time ramp mods	2021-01-31 20:34:56 +01:00
Bartłomiej Dach	81b052b866	Add failing test cases	2021-01-31 20:34:22 +01:00
Bartłomiej Dach	2c08ce05fa	Remove game-local enum [Order] attribute ... In favour of the newly-added framework one.	2021-01-27 22:29:52 +01:00
Dan Balasescu	7d06af916c	Merge branch 'master' into add-messagepack	2021-01-27 13:00:46 +09:00
Dean Herbert	a5f3418e56	Avoid tooltip display	2021-01-26 19:11:19 +09:00
Dean Herbert	9537090d28	Setup all spectator model classes for MessagePack	2021-01-26 16:39:35 +09:00
Dean Herbert	dee0d3c33a	Merge branch 'master' into apply-sv-to-taiko-hr-ez	2021-01-25 14:28:06 +09:00
Dan Balasescu	04095cd5b9	Merge branch 'master' into fix-editor-scroll-interruption	2021-01-21 17:46:18 +09:00
Bartłomiej Dach	1d9aaac2c2	Fix HOC not propagating DHO results applied on kill ... `DrawableHitObject.OnKilled()` calls `UpdateResult()` to clean up a hitobject's state definitively with regards to the judgement result before returning the DHO back to the pool. As it turns out, if a consumer was relying on this code path (as taiko was in the case of nested strong hit objects), it would not work properly with pooling, due to `HitObjectContainer` unsubscribing from `On{New,Revert}Result` *before* calling the DHO's `OnKilled()`. This in turn would lead to users potentially getting stuck in gameplay, due to `ScoreProcessor` not receiving all results via that event path. To resolve, change the call ordering to allow hit result changes applied in `OnKilled()` to propagate normally.	2021-01-21 00:05:37 +01:00
smoogipoo	de9d075f94	Initial sample + samplechannel rework	2021-01-19 17:11:40 +09:00
Dean Herbert	ced7a36788	Update namespaces	2021-01-18 21:24:10 +09:00
Dean Herbert	04fa32bc34	Rename and add xmldoc for smooth seeking method	2021-01-15 16:14:21 +09:00
smoogipoo	d5878db615	Fix default judgement text mispositioned for one frame	2021-01-14 12:33:33 +09:00
Bartłomiej Dach	4b4adc927c	Rename param to match method body	2021-01-10 15:35:53 +01:00
Salman Ahmed	0aad0c7c6c	Target logic at this and adjust variables	2021-01-09 00:31:18 +03:00
Salman Ahmed	375ecf92ed	Merge remote-tracking branch 'upstream/master' into fix-mod-buttons-not-copying-settings	2021-01-09 00:26:18 +03:00
Dean Herbert	05ba5d4c31	Merge pull request #11438 from bdach/difficulty-adjust-defaults ... Fix difficulty adjust mod treating default values as user overrides	2021-01-09 01:18:34 +09:00
Bartłomiej Dach	303cc62ee7	Transfer flags indicating if settings were changed	2021-01-06 22:46:46 +01:00
Bartłomiej Dach	68352782db	Change .StartsWith() to .Equals() ... In line with planned-but-delayed breaking change.	2021-01-06 18:38:24 +01:00
Bartłomiej Dach	9cc63e8dce	Remove obsoleted IHasEndTime	2021-01-06 18:38:24 +01:00
Bartłomiej Dach	539785e422	Remove obsoleted IHasCurve	2021-01-06 18:38:24 +01:00
Bartłomiej Dach	09742998cd	Fix mistaken obsoletion notice ... It was added in c9f38f7bb6, which specified 2021 in another place (and was committed in October of 2020 anyway). Update the year so that it doesn't get culled prematurely.	2021-01-06 18:38:24 +01:00
Dean Herbert	b3f08b29ca	Ensure that all changes to screen backgrounds are on the correct thread	2021-01-05 15:22:50 +09:00
Bartłomiej Dach	9e4a925ab1	Clarify & cleanup comments some	2021-01-03 13:44:29 +01:00
Bartłomiej Dach	a3e29b9154	Rename parameters for readability	2021-01-03 13:25:44 +01:00
Dean Herbert	2501707d7d	Copy values using Bind to also copy defaults	2021-01-03 20:45:03 +09:00
Dean Herbert	29dbb1cc0d	Add internal pathway for ensuring correct application of bindable mods	2021-01-03 15:48:28 +09:00
Dean Herbert	23e216fa0b	Simplify some default value checks (we are sure the return is an IBindable)	2021-01-03 15:47:15 +09:00
Salman Ahmed	c1a1e3acc5	Revert drive-by changes	2021-01-01 15:40:40 +03:00
Salman Ahmed	a031c8e0b6	Apply documentation suggestions ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-01-01 15:34:09 +03:00
Salman Ahmed	b4df2d6d43	Add method for copying properties from another mod	2021-01-01 03:46:09 +03:00
Firmatorenio	013b9b62a1	add SV multipliers to taiko difficulty mods	2020-12-29 20:22:56 +06:00
Salman Ahmed	41b79d938b	Fix wrong checks..	2020-12-28 15:30:52 +03:00
Salman Ahmed	5efcdbd431	Fix IMod now using reference equality as well	2020-12-28 15:19:28 +03:00
Salman Ahmed	43f8f3638a	Fix mod using reference equality unless casted to IMod	2020-12-27 02:42:13 +03:00
Dean Herbert	d66e218318	Source display accuracy from header and remove from ScoreProcessor function	2020-12-24 14:57:23 +09:00
Bartłomiej Dach	64095307de	Merge branch 'master' into realtime-leaderboard	2020-12-23 09:56:47 +01:00
Dean Herbert	be427a4ec0	Fix realtime leaderboard showing accuracy based on final base score, not rolling	2020-12-23 14:20:35 +09:00
Dean Herbert	d229fbba6e	Merge branch 'master' into present-recommended	2020-12-22 13:52:29 +09:00
Bartłomiej Dach	f96d2f4ba4	Merge branch 'master' into fix-texture-loader-usages	2020-12-21 18:35:34 +01:00
Dean Herbert	bc212b2538	Merge branch 'master' into fix-texture-loader-usages	2020-12-21 13:51:55 +09:00
Dean Herbert	a8569fe15c	Fix a couple of simple cases of incorrect TextureLoaderStore initialisation	2020-12-21 13:35:46 +09:00
Bartłomiej Dach	a31e8d137f	Add guard when clearing samples	2020-12-20 15:42:24 +01:00
Bartłomiej Dach	ee33c0be93	Extract combo & accuracy ratio calculation helpers	2020-12-19 19:08:29 +01:00
PercyDan54	2babb7ecb0	Fix CI	2020-12-18 18:33:38 +08:00
PercyDan54	560a0174df	Make auto restart toggleable	2020-12-18 17:54:09 +08:00
Dean Herbert	f13683dc90	Correctly account for max combo of the input, rather than the global	2020-12-17 16:05:41 +09:00
Dean Herbert	41d8b84bd7	Revert MaxBaseScore to being a private field (no longe required to be public)	2020-12-17 15:47:20 +09:00
Dean Herbert	2954218897	Add method to ScoreProcessor to calculate score and accuracy from statistics	2020-12-16 16:20:29 +09:00
Dean Herbert	64a2526678	Add header class and basic flow for propagating data updates	2020-12-14 17:33:23 +09:00
Dean Herbert	1793385e96	Pass a score to the replay recorder to allow reading more general scoring data	2020-12-14 16:52:14 +09:00
Dean Herbert	51e8a05f18	Seal SetRecordTarget method to simplify modification	2020-12-14 16:44:29 +09:00
smoogipoo	ac91f0e270	Add extended limits to difficulty adjustment mod	2020-12-10 00:37:19 +09:00
ekrctb	a548269c34	Fix scrolling hit object displayed in wrong position for one frame	2020-12-07 17:26:12 +09:00
Dean Herbert	a0f92628ac	Merge branch 'master' into fix-sample-expire	2020-12-04 13:49:08 +09:00
Dean Herbert	5ded4b9faa	Merge branch 'master' into dho-remove-onparentreceived	2020-12-04 11:04:56 +09:00
Endrik Tombak	48dad61a46	Apply review suggestions	2020-12-03 19:44:12 +02:00
smoogipoo	0bdf99b97a	Remove OnParentReceived()	2020-12-03 20:08:42 +09:00
smoogipoo	73e99718bc	Change order of OnParentReceived()	2020-12-03 20:06:26 +09:00
ekrctb	6c46046c24	Fix DHO expires while hit sound is playing	2020-12-03 12:32:49 +09:00
smoogipoo	e831c797f3	Merge branch 'master' into hit-sample-pooling	2020-12-02 14:45:24 +09:00
smoogipoo	2150cf1c52	Rename parameters	2020-12-02 10:55:48 +09:00
smoogipoo	e19ef9627a	Fix potentially incorrect override	2020-12-02 10:54:26 +09:00
smoogipoo	2840405112	Volume should be 0 by default	2020-12-01 18:14:14 +09:00
smoogipoo	6b4a6c12c8	Fix bad equality comparer implementations	2020-12-01 18:13:53 +09:00
smoogipoo	17560aeeea	Volume should be 0 by default	2020-12-01 18:09:28 +09:00
smoogipoo	dda4d76d72	Fix bad equality comparer implementations	2020-12-01 18:09:21 +09:00
smoogipoo	4900589af4	Remove unused method	2020-12-01 17:02:45 +09:00
smoogipoo	2bb7484608	Merge branch 'immutable-hit-samples' into hit-sample-pooling	2020-12-01 16:05:28 +09:00
smoogipoo	199710b941	Implement equality comparers for HitSampleInfo	2020-12-01 16:04:08 +09:00
smoogipoo	5760e1c1fc	Make HitSampleInfo immutable	2020-12-01 15:37:51 +09:00
Bartłomiej Dach	5fbe1823a0	Merge branch 'master' into editor-beat-snap-always	2020-11-30 18:39:22 +01:00
Dean Herbert	51741c4791	Merge branch 'master' into hit-sample-pooling	2020-11-30 22:25:28 +09:00
Dean Herbert	7f34e11467	Merge pull request #10962 from smoogipoo/improve-dho-time-offsets ... Fix judgement offsets in non-framestable contexts	2020-11-30 19:13:25 +09:00
Dean Herbert	3ad2eeaff5	Fix outdated xmldoc	2020-11-30 18:35:30 +09:00
Dean Herbert	c17d67bc7d	Merge branch 'master' into editor-beat-snap-always	2020-11-30 18:34:38 +09:00
smoogipoo	4bbeb9ebd4	Merge branch 'master' into hit-sample-pooling	2020-11-30 18:31:58 +09:00
Dan Balasescu	b56e832e83	Merge pull request #10950 from ekrctb/pool-scrolling ... Support hit object pooling in ScrollingPlayfield	2020-11-30 18:29:34 +09:00
smoogipoo	8f48389f89	Merge branch 'master' into improve-dho-time-offsets	2020-11-30 18:01:48 +09:00
smoogipoo	7ac2fba127	More reordering of public vs private methods	2020-11-30 17:44:58 +09:00
Dan Balasescu	11d1450c76	Merge branch 'master' into fruit-bindables	2020-11-30 16:48:22 +09:00
Dean Herbert	2745659986	Reword and xmldoc some comments	2020-11-30 15:54:20 +09:00
Dan Balasescu	69c2a18220	Merge branch 'master' into fix-drawable-judgement-animation-loss	2020-11-30 14:05:03 +09:00
Dan Balasescu	0c36a3c263	Merge branch 'master' into pool-scrolling	2020-11-30 14:04:54 +09:00
Dean Herbert	18bb0cb45b	Remove unnecessary schedule logic from Apply's local updateState call ... There were cases in the editor where rewinding of transforms would leave the `DrawableHitObject` in a non-`IsPresent` state, resulting in this scheduled logic never running. This would in turn cause ghost hitobjects, which disappear under certain circumstances. Reproduction: - Open editor to empty beatmap - Place single hitcircle at current point in time - Drag editor timeline backwards to seek before zero, and wait for return to zero - Select hitcircle in playfield - Drag hitcircle to right in timeline, triggering a start time change	2020-11-27 16:32:05 +09:00
Dean Herbert	bcc197f9fe	Merge branch 'master' into improve-dho-time-offsets	2020-11-27 15:03:56 +09:00
ekrctb	6e40de58e9	Use new OnAdd and OnRemove to invalidate DHO	2020-11-27 13:36:40 +09:00
ekrctb	8f5129323d	Merge branch 'master' into pool-scrolling	2020-11-27 13:12:05 +09:00
ekrctb	e36bb7631d	Fix colour not updated when index changes	2020-11-27 11:41:39 +09:00
ekrctb	57454bbb1c	Remove hitObject argument from OnApply and OnFree	2020-11-27 10:13:05 +09:00
Dean Herbert	94dc61150b	Merge branch 'master' into fix-drawable-judgement-animation-loss	2020-11-27 00:43:47 +09:00
Dean Herbert	b1864670a2	Merge pull request #10961 from smoogipoo/better-dho-rewind ... Rewind pooled DHOs into better states	2020-11-27 00:42:58 +09:00
smoogipoo	aa4da2a5f8	Add xmldoc on State	2020-11-26 23:42:05 +09:00
Dean Herbert	741902f1b3	Merge pull request #10971 from smoogipoo/fix-timeline-combo-colour ... Fix timeline blueprints sometimes not receiving combo colours	2020-11-26 19:47:21 +09:00
Dean Herbert	9811c46e35	Rename application method to better describe what it actually does	2020-11-26 19:16:18 +09:00
ekrctb	05e245d445	Allow non-pooled DHO to be reused	2020-11-26 19:07:09 +09:00
smoogipoo	e53f849aa0	Completely separate combo colours from DHOs	2020-11-26 18:14:25 +09:00
Dan Balasescu	aad6cf4ad3	Merge branch 'master' into editor-multiple-object-positional-snap	2020-11-26 17:06:47 +09:00
ekrctb	eae33fe74a	Fix format	2020-11-26 14:16:33 +09:00
ekrctb	e43f928588	Use DHO.HitObjectApplied to invalidate computation	2020-11-26 14:07:40 +09:00
ekrctb	f6faf95e33	Revert changes to HitObjectUsageBegan, not use it.	2020-11-26 14:01:46 +09:00
ekrctb	1a6e5bdaba	Merge branch 'master' into pool-scrolling	2020-11-26 13:52:52 +09:00
Bartłomiej Dach	8ff1688c4b	Merge branch 'master' into fix-drawable-judgement-animation-loss	2020-11-25 20:11:09 +01:00
smoogipoo	0414e5c550	Add MaximumJudgementOffset to DrawableHitObject, use in more places	2020-11-26 01:12:42 +09:00
smoogipoo	c744db1b57	Rewind pooled DHOs into better states	2020-11-26 00:42:25 +09:00
Dean Herbert	c46d655832	Uncomment incorrectly commented lines	2020-11-25 12:11:44 +09:00
ekrctb	b8a5cd94f7	Invoke HitObjectUsageFinished before removal	2020-11-24 19:46:57 +09:00
ekrctb	e34a205104	Rewrite hit object management, take three	2020-11-24 18:56:05 +09:00
ekrctb	7f6e4d5b21	Delay lifetime computation until loaded	2020-11-24 18:56:05 +09:00
ekrctb	d5f082e5fb	Comment about lifetime assumption	2020-11-24 18:56:05 +09:00
ekrctb	ce57e8ddfb	Separate Lifetime computation and layout update	2020-11-24 18:56:05 +09:00
ekrctb	cabc8aa63b	Revert "Simplify ScrollingHitObjectContainer logic" ... This reverts commit b4cc39149c117e6a0e95ee917a67cec8ba723d06.	2020-11-24 18:56:05 +09:00
ekrctb	8f39b54e58	Simplify ScrollingHitObjectContainer logic	2020-11-24 18:56:05 +09:00
ekrctb	5c743adbae	Support hit object pooling scrolling playfield	2020-11-24 18:56:05 +09:00
Dean Herbert	c9a41f9dae	Make all objects in selection candidates for spatial snapping ... Closes #10898.	2020-11-24 17:35:54 +09:00
Dan Balasescu	87ce8a53ff	Merge branch 'master' into on-drawable-hitobject-added	2020-11-24 16:09:57 +09:00
Dean Herbert	1682260677	Remove left over logging line	2020-11-24 15:28:03 +09:00
Dean Herbert	ee33f62809	Fix DrawableJudgement not always animating correctly on skin change ... If the skin is changed before gameplay has started (at the loading screen) it is possible for a sequence of events to occur which results in the animation not being played: - `SkinReloadableDrawable` runs its BDL load (and calls `OnSkinChanged` once) - User changes skin, triggering `DrawableJudgement`'s skin change handling (binding directly on the `SkinSource` locally) - This will call `PrepareDrawables` and reinitialise the `SkinnableDrawable` child hierarchy, then immediately apply the animations to it. - The new `SkinnableDrawable` will then get the `SkinChanged` event and schedule a handler for it, which will run on its first Update call. - Any added animations will be lost as a result. Fixed by binding directly to the `SkinnableDrawable`'s `OnSkinChanged`. This has the added bonus of not needing to reinitialise the child hierarchy on skin change (which felt a bit weird in the first place).	2020-11-24 15:23:53 +09:00
Dean Herbert	060acb9010	Merge pull request #10935 from bdach/fix-mania-judgement-fade-in ... Rewind judgement transforms before clearing	2020-11-23 17:05:04 +09:00
Dean Herbert	19faa2b9bb	Add comment covering intentional call to ClearTransformsAfter	2020-11-23 15:20:59 +09:00
Bartłomiej Dach	827a089810	Merge branch 'master' into change-taiko-ez	2020-11-22 13:29:02 +01:00
ekrctb	666112cb5a	Address @bdach's minor suggestions	2020-11-22 18:51:16 +09:00
ekrctb	c506b438bf	Remove more code and make some methods private	2020-11-22 18:51:16 +09:00
Bartłomiej Dach	9f997db958	Rewind judgement transforms before clearing	2020-11-21 17:56:49 +01:00
ekrctb	295ca38cda	Merge remote-tracking branch 'origin/master' into on-drawable-hitobject-added	2020-11-21 15:25:16 +09:00
ekrctb	4345d8dcb6	Event -> virtual method	2020-11-21 15:20:33 +09:00
ekrctb	281ed49332	Add HasInitialized to DHO ... As it turned out, `IsLoaded` is not a reliable way.	2020-11-21 11:19:52 +09:00
ekrctb	82aefa3868	Rework and rename to OnNewDrawableHitObject. ... The semantics is changed and hopefully more clear.	2020-11-21 00:27:19 +09:00
ekrctb	772f6df668	Add a remark for DrawableHitObjectAdded	2020-11-20 18:00:00 +09:00
ekrctb	c013cd11c9	Add DrawableHitObjectAdded event	2020-11-20 17:56:47 +09:00
Dean Herbert	53b6d90ab4	Don't show default judgements in front of objects for now	2020-11-20 16:30:58 +09:00
Dean Herbert	a00e0d7279	Move CanBeNull specification to the interface	2020-11-20 16:30:48 +09:00
Dean Herbert	7fe0923fcf	Show main judgement content above hitobjects	2020-11-20 16:25:48 +09:00
smoogipoo	7180bfe4ba	Unlimit number of samples per pool	2020-11-19 21:21:57 +09:00
smoogipoo	f013928fa3	Set maximum pool size	2020-11-19 20:40:01 +09:00
smoogipoo	70cb197957	Cleanups	2020-11-19 20:38:36 +09:00
smoogipoo	8920534a25	Fix pools not being added to hierarchy	2020-11-19 20:24:03 +09:00
smoogipoo	730b14b5bb	Add initial hit sample pooling	2020-11-19 19:51:09 +09:00
Dean Herbert	ba735584fa	Add null check for disposal safety	2020-11-19 14:04:43 +09:00
Bartłomiej Dach	24d7fa03d8	Merge branch 'master' into legacy-jugement-match-stable-transforms	2020-11-18 20:33:58 +01:00
Bartłomiej Dach	5156de3a10	Merge branch 'master' into fix-judgement-transform-logic	2020-11-18 19:20:11 +01:00
smoogipoo	cb5d1d0d77	Remove obsolete method	2020-11-18 21:26:35 +09:00
Dean Herbert	b3bec81b79	Update xmldoc to match new behaviour	2020-11-18 19:38:38 +09:00
Dean Herbert	8522ddc61e	Reduce nesting of skinned component to reduce exposed surface	2020-11-18 19:34:27 +09:00
Dean Herbert	ee8804b50b	Fix animation playback not running on skin change	2020-11-18 19:03:34 +09:00
Dean Herbert	c47e70da9b	Update animations for new/old miss style and add fades	2020-11-18 19:03:34 +09:00
Dean Herbert	9d3de5bca0	Fix hit lighting dictating lifetime even when not present in skin	2020-11-18 19:03:34 +09:00
Dean Herbert	72a15ef2dc	Handle DrawableJudgement lifetime more flexibly	2020-11-18 19:03:34 +09:00
Dean Herbert	94886a09b2	Remove fades from DrawableJudgement itself	2020-11-18 19:03:34 +09:00
Bartłomiej Dach	875d7dec79	Remove redundant this. qualifier	2020-11-17 20:11:13 +01:00
Dean Herbert	8247e6ce91	Move result type to ctor	2020-11-17 15:43:54 +09:00
Dean Herbert	e4f1e52422	Add xmldoc coverage of Apply()	2020-11-17 15:03:26 +09:00
Dean Herbert	f465dd5a5e	Move all extended animation logic out of DrawableJudgement	2020-11-17 14:59:34 +09:00
Dean Herbert	9dfa4249e0	Make Apply non-virtual	2020-11-17 14:05:13 +09:00
Bartłomiej Dach	8da40ce2dc	Reduce duplication by extracting ModEasyWithExtraLives	2020-11-16 19:54:00 +01:00
Bartłomiej Dach	128adce017	Merge branch 'master' into change-taiko-ez	2020-11-16 19:37:47 +01:00
Bartłomiej Dach	72a8734f93	Merge branch 'master' into add-back-initiallifetimeoffset	2020-11-16 18:54:37 +01:00
smoogipoo	e8dbc190f1	Remove ability to pool DHOs in parent playfields	2020-11-16 23:30:24 +09:00
smoogipoo	cead67d512	Add back removed InitialLifetimeOffset removal	2020-11-16 21:49:29 +09:00
PercyDan54	f2ef7bee5d	Fix checks	2020-11-16 18:17:50 +08:00
PercyDan54	d7acfd5413	Remove retires from ModEasy	2020-11-16 18:15:15 +08:00
Dan Balasescu	09298139e1	Merge pull request #10844 from bdach/spinner-rotation-tracker-state ... Fix rotation tracker state not being reset on drawable spinner re-use	2020-11-16 17:10:40 +09:00
Dean Herbert	6706840b54	Merge pull request #10853 from bdach/add-to-legacy-conversion-tests	2020-11-16 15:22:04 +09:00
Bartłomiej Dach	9c0a0031d6	Clear existing transforms on DHO return to pool	2020-11-15 19:50:22 +01:00
Bartłomiej Dach	5d44286d38	Add missing generic mappings to legacy mods	2020-11-15 15:35:06 +01:00
Bartłomiej Dach	5ace7abaa8	Add abstract non-generic ModNightcore to pattern-match over	2020-11-15 15:32:02 +01:00
Bartłomiej Dach	f8cabbdd21	Clear result when freeing pooled hitobject	2020-11-14 21:09:22 +01:00
Bartłomiej Dach	610ed99ae3	Add null checks to unguarded resolved-as-null fields	2020-11-14 14:52:58 +01:00
smoogipoo	21b015d63a	Remove explicit public	2020-11-14 01:06:38 +09:00
smoogipoo	c71b237c4f	Merge all pooling support into Playfield	2020-11-14 00:59:08 +09:00
smoogipoo	36f1833f6e	Move hitobject pooling to Playfield	2020-11-14 00:41:18 +09:00
Dean Herbert	f093acc9d5	Merge pull request #10823 from smoogipoo/pooling-editor-support ... Add pooling support to the editor	2020-11-13 19:58:46 +09:00
smoogipoo	d83b479c81	Internalise lifetime extensions and events too	2020-11-13 19:21:45 +09:00
smoogipoo	4a4219fd11	Add region	2020-11-13 19:21:45 +09:00
smoogipoo	92189e35cc	Make playfield KeepAlive methods internal	2020-11-13 19:21:45 +09:00
smoogipoo	688a442fb3	Add missing dictionary	2020-11-13 17:26:46 +09:00
smoogipoo	942ecde0e1	Merge branch 'master' into pooling-editor-support	2020-11-13 17:23:35 +09:00
smoogipoo	3957697c48	Add pooling support to the editor	2020-11-13 17:08:20 +09:00
smoogipoo	4ef2e9548c	Pass HitObjectComposer to BlueprintContainer via ctor	2020-11-13 16:59:37 +09:00
Dean Herbert	06fd0d08d1	Merge branch 'master' into nested-hitobject-pooling	2020-11-13 16:53:20 +09:00
smoogipoo	4236dd826d	Improve documentation and make abstract again	2020-11-13 14:57:09 +09:00
smoogipoo	a07d4a7915	Remove unnecessary dictionary for now	2020-11-13 14:42:41 +09:00
smoogipoo	35329aa976	Reduce the number of state updates	2020-11-13 14:33:23 +09:00
Dan Balasescu	2840fd0f8f	Merge branch 'master' into hitobject-pooling-base	2020-11-12 23:17:36 +09:00
smoogipoo	261ddd2b4a	Fix samples not being disposed	2020-11-12 18:48:25 +09:00
smoogipoo	8aaa500431	Add lifetime extensions	2020-11-12 18:34:50 +09:00
smoogipoo	243e913e4a	Add hitobject usage events	2020-11-12 18:32:20 +09:00
smoogipoo	fe347c8661	Add playfield support for keeping hitobjects alive	2020-11-12 18:30:32 +09:00
smoogipoo	7548db7ecc	Fix hitobjects sometimes not fading in completely with HD mod	2020-11-12 18:29:22 +09:00
smoogipoo	a8c2b798ad	Add support for nested hitobject pooling	2020-11-12 17:43:51 +09:00
smoogipoo	e44a8b3934	Resort as early as possible	2020-11-12 17:07:20 +09:00
Dean Herbert	41a1730927	Merge pull request #10794 from smoogipoo/fix-osu-hd-mod	2020-11-12 17:06:04 +09:00
smoogipoo	cf91962865	Fix test failures due to on-the-fly starttime changes	2020-11-12 16:58:40 +09:00
smoogipoo	974390bda7	Make Add() + Remove() virtual	2020-11-12 15:36:02 +09:00
smoogipoo	72a6b75626	Add back removed event	2020-11-12 15:34:51 +09:00
smoogipoo	4e43235955	Fix double bind leading to test failures	2020-11-12 15:33:49 +09:00
smoogipoo	653f5bce67	Reword xmldocs	2020-11-12 15:00:58 +09:00
smoogipoo	16e4e8d032	Fix possible nullref	2020-11-12 14:54:33 +09:00
smoogipoo	1f8d376b85	Replace CreatePool() with non-virtual RegisterPool() overload	2020-11-12 14:17:33 +09:00
smoogipoo	5dbbe11fc6	Remove PoolHitObjects, use return value of CreateDrawableRepresentation() instead	2020-11-12 14:04:16 +09:00
smoogipoo	f652eb9982	Remove GetDrawableRepresentation() override, add null hinting	2020-11-12 13:18:44 +09:00
smoogipoo	d7d77460fb	Small refactorings	2020-11-12 12:55:42 +09:00
smoogipoo	a8929b0764	Revert unnecessary change of casting	2020-11-11 19:27:07 +09:00
smoogipoo	7fdaf69903	Add some more xmldocs	2020-11-11 19:12:12 +09:00
smoogipoo	606cfacedf	Fix state update exception in a better way	2020-11-11 19:01:12 +09:00
smoogipoo	7d02018134	Remove some unnecessary implementations for now	2020-11-11 18:54:40 +09:00
smoogipoo	d7bee80d4e	Merge branch 'fix-incorrect-framestability-value' into hitobject-pooling-base	2020-11-11 18:52:51 +09:00
smoogipoo	90499329bd	Fix frame stable playback not being set correctly	2020-11-11 18:50:38 +09:00
smoogipoo	6f7a1dd57d	Merge branch 'master' into hitobject-pooling-base	2020-11-11 17:09:18 +09:00
smoogipoo	5d55af5818	Fix hitobjects sometimes not fading in completely with HD mod	2020-11-11 16:35:48 +09:00
Dean Herbert	8706b51b77	Merge pull request #10717 from smoogipoo/dho-apply	2020-11-11 10:54:24 +09:00
smoogipoo	b725c9cce9	Fix possible nullrefs	2020-11-11 00:24:28 +09:00
smoogipoo	e525784cb2	Clear lifetimeEntry after use	2020-11-11 00:24:14 +09:00
smoogipoo	99e5450af3	Cache DrawableRuleset	2020-11-11 00:22:36 +09:00
smoogipoo	66213f2ed0	Add pooling support to DrawableRuleset + Playfield	2020-11-10 23:56:32 +09:00
smoogipoo	31e4d71852	Rewrite HitObjectContainer with pooling support	2020-11-10 22:49:02 +09:00
smoogipoo	6f3f6dc28b	Add hitobject lifetime support	2020-11-10 20:16:52 +09:00
smoogipoo	45e9f16f6b	Add initial DrawableRuleset interface	2020-11-10 19:27:08 +09:00
smoogipoo	757a4b5c31	Add hitobject lifetime model	2020-11-10 19:26:01 +09:00
smoogipoo	88112801eb	Remove result storage from hitobject	2020-11-10 18:56:16 +09:00
smoogipoo	f5076fe3b8	Revert unnecessary change	2020-11-10 18:15:11 +09:00
Bartłomiej Dach	109abc0e29	Always store standardised score when populating ScoreInfo	2020-11-10 08:41:00 +01:00
smoogipoo	d4d3a6621e	Disable automatic lifetime management	2020-11-10 01:30:25 +09:00
smoogipoo	ac47399e6e	Update state after OnApply()	2020-11-10 00:30:23 +09:00
smoogipoo	ec8b726ea8	Re-privatise start time bindable	2020-11-09 21:51:58 +09:00
Dan Balasescu	33c3b07101	Fix events not being bound correctly ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2020-11-09 19:06:48 +09:00
Dean Herbert	d93cf08570	Merge branch 'master' into dho-apply	2020-11-07 01:18:46 +09:00
smoogipoo	91c627c22d	Revert HOC changes	2020-11-07 00:57:33 +09:00
smoogipoo	b1e039bcec	Prevent overrides from messing with application/freeing	2020-11-07 00:40:26 +09:00
smoogipoo	3a4bd73823	Fix DHOs being freed when not expected	2020-11-07 00:25:26 +09:00
smoogipoo	7eceda242b	Change derived class to use property	2020-11-06 23:04:28 +09:00
smoogipoo	2d892c7407	Allow Apply() to be called multiple times sequentially	2020-11-06 23:03:29 +09:00
smoogipoo	248d342a2f	Initial Apply()/FreeAfterUse() DHO implementation	2020-11-06 23:02:37 +09:00
Dan Balasescu	f230250faf	Merge branch 'master' into editor-slider-control-point-quick-delete	2020-11-06 21:47:37 +09:00
Dan Balasescu	44c6457c85	Merge branch 'master' into add-spinner-spin	2020-11-06 15:40:40 +09:00
Dan Balasescu	71a1165209	Merge branch 'master' into drawable-hit-object-hit-state-fix	2020-11-06 13:19:25 +09:00
Dean Herbert	a0b3379909	Fix judgement offsets being zero when windows are empty	2020-11-05 18:58:37 +09:00
Dean Herbert	2bbdbfda5c	Merge pull request #10696 from smoogipoo/visibility-adjustment-mod	2020-11-05 18:18:57 +09:00
Dean Herbert	2d50a7b616	Fix a few xmldoc typos	2020-11-05 17:38:02 +09:00
Dean Herbert	0cadb31947	Merge branch 'master' into drawable-hit-object-hit-state-fix	2020-11-05 17:07:52 +09:00
smoogipoo	9d5b1ec28c	Add removal dates	2020-11-05 17:04:11 +09:00
smoogipoo	cc518feca7	Make methods abstract	2020-11-05 16:03:10 +09:00
smoogipoo	a219aa7ba2	Add xmldoc	2020-11-05 15:53:35 +09:00
smoogipoo	628b8be15d	Implement ModWithVisibilityAdjustment	2020-11-05 15:40:25 +09:00
smoogipoo	9a7fcadabc	Use BDL for top-level osu! DHOs	2020-11-05 13:51:46 +09:00
Dean Herbert	68b7efe4d5	Change order of execution to be chronological	2020-11-04 17:14:23 +09:00
Dean Herbert	831325978a	Always execute UpdateHitStateTransforms (even for idle)	2020-11-04 17:14:23 +09:00
Dean Herbert	3b6cf95f49	Remove parameter from StartTime method and add obsoleted previous version	2020-11-04 16:39:52 +09:00
Dean Herbert	7f30140b7e	Add new method handling hit state specifically ... Until now UpdateStateTransforms was applying results offsets to StartTime. This didn't cover the case of a HitObject with duration, where the call would be made with `StartTime + hitOffset` rather than `EndTime + hitOffset`. To resolve this, a new method has been added which should be used to handle hit-specific state transforms.	2020-11-04 16:13:14 +09:00
Dean Herbert	9f333ac58a	Add the ability to delete slider control points using shift+right click ... Closes https://github.com/ppy/osu/issues/10672. In two minds about how this should be implemented but went in this direction initially. The other way would be to add local handling of Shift-Right Click inside PathControlPointPiece (which is already doing mouse handling itself).	2020-11-03 20:46:33 +09:00
Dan Balasescu	04178e9458	Merge branch 'master' into spectator-replay-watcher	2020-11-02 14:54:51 +09:00
Dan Balasescu	1b53e6c782	Merge branch 'master' into sample-lookup-improvements	2020-11-02 13:04:35 +09:00
Bartłomiej Dach	2b0bea535e	Resolve CA1805 inspections ... "Member is explicitly initialized to its default value"	2020-11-01 18:47:40 +01:00
Bartłomiej Dach	b7696c85ad	Add more xmldocs	2020-11-01 15:23:03 +01:00
Dean Herbert	b4e5311014	Move initial state set inside updateClock	2020-10-30 20:39:25 +09:00
Dean Herbert	1bd461f229	Move clock logic back to inside updateClock method	2020-10-30 20:21:14 +09:00
Dean Herbert	32e68a6a3c	Fix FramedReplayInputHandler incorrectly blocking in streaming mode when time requested is before the first frame ... Most of this is just tidying up the logic to (hopefully) be better to follow, again (again (again)). The actual fix is that we now allow interpolation/playback when the incoming time is less than the first frame's time, regardless of receiving status.	2020-10-30 16:09:03 +09:00
Dean Herbert	0f997386ae	Fix direction and IsRunning not updating on first frame after becoming valid ... The parent clock will not unpause until WaitingForFrames becomes false, so I've moved the set of that before we start to propagate its values across. Doesn't fix any visible issue but should make propagation one game loop faster.	2020-10-30 15:26:23 +09:00
Dean Herbert	326fd03525	Fix loop not exiting after first valid frame	2020-10-30 15:25:53 +09:00
Dean Herbert	8e6c803900	Avoid running full updateClock loop when waiting on frames	2020-10-30 12:39:11 +09:00
Dean Herbert	2ea4aa0a37	Fix incorrect specification on some sample lookups	2020-10-30 11:59:41 +09:00
Dean Herbert	87be7d162b	Merge branch 'master' into spectator-replay-watcher	2020-10-30 00:25:17 +09:00
Dean Herbert	335d150a13	Fix aim time being mutated inside update loop	2020-10-29 18:11:50 +09:00
Dean Herbert	2671d371da	Move clock retrieval to new correct location	2020-10-29 15:28:39 +09:00
Dean Herbert	3ea27e23e8	Update namespace references	2020-10-29 15:20:10 +09:00
Dean Herbert	db2b00068f	Avoid sourcing parent clock when in a paused state	2020-10-29 14:48:56 +09:00
Dean Herbert	d91456dc29	Move initial validity check out of loop for clarity	2020-10-29 14:25:47 +09:00
Dean Herbert	2e5a8b2287	Fix xmldoc to read better in new context	2020-10-29 13:16:31 +09:00
Dan Balasescu	a022b869eb	Merge branch 'master' into frame-stability-clean-up	2020-10-29 13:02:17 +09:00
Bartłomiej Dach	a1696942f0	Merge branch 'master' into right-click-circle-delete	2020-10-28 22:12:14 +01:00
Bartłomiej Dach	202fe09306	Group selection actions back up in SelectionHandler	2020-10-28 22:06:48 +01:00
Dean Herbert	6eddd76bdc	Simplify FramedReplayInputHandler's SetFrame implementation	2020-10-28 16:03:23 +09:00
Dean Herbert	09da75b143	Merge branch 'frame-stability-clean-up' into spectator-replay-watcher	2020-10-28 15:34:46 +09:00
Dean Herbert	2b1e79a4e8	Simplify state changes further	2020-10-28 15:32:20 +09:00
Dean Herbert	c9515653b3	Restore previous directionality logic to avoid logic differences	2020-10-28 15:31:57 +09:00
Dean Herbert	77d807d0f5	Merge branch 'frame-stability-clean-up' into spectator-replay-watcher	2020-10-28 15:26:02 +09:00
Dean Herbert	59e9c2639a	Remove try-finally	2020-10-28 15:16:56 +09:00
Dean Herbert	a06516c900	Extract out frame stability state into enum for (hopefully) better clarity	2020-10-28 15:15:15 +09:00
Dean Herbert	8c9bda2ded	Split out replay update method	2020-10-28 15:14:06 +09:00
Dean Herbert	9b9a41596f	Split out frame stability calculation to own method	2020-10-28 15:14:06 +09:00
Dean Herbert	3e5322541d	Make direction setting more clear	2020-10-28 14:35:42 +09:00
Dean Herbert	b3d793a505	Fix gameplay proceeding when no frames have been received yet	2020-10-27 18:58:37 +09:00
Dean Herbert	851d45d2eb	Add sane pausing logic	2020-10-27 18:58:37 +09:00
Dean Herbert	9e6b0a42ec	Allow FrameStabilityContainer to handle waiting-for-data state better (and pause outwards)	2020-10-27 18:58:37 +09:00
Dean Herbert	400542bc0b	Ensure frames arrive	2020-10-27 18:58:37 +09:00
Dean Herbert	b8beac27ce	Use previous logic for catching-up mode	2020-10-27 17:14:41 +09:00
Dean Herbert	09087faf3b	Fix non-matching filename	2020-10-27 14:23:24 +09:00
Dean Herbert	9cfb81589e	Use bindable flow instead	2020-10-27 14:10:12 +09:00
Dean Herbert	6853da459d	Move sample pausing logic out of FrameStabilityContainer	2020-10-27 13:54:33 +09:00
Dean Herbert	27c1a4c4d3	Move right-click deletion logic to be handled at a SelectionBlueprint level	2020-10-27 12:53:54 +09:00
Dean Herbert	266596d404	Merge branch 'master' into right-click-circle-delete	2020-10-27 12:02:29 +09:00
Bartłomiej Dach	7392876b5f	Fix mania crashing due to spectator client handling frames with unconverted beatmap	2020-10-27 00:35:25 +01:00
Bartłomiej Dach	3f8c4c57d0	Fix code style issues & restructure	2020-10-26 22:16:28 +01:00
Dean Herbert	05697dfe68	Add spectator state object support	2020-10-22 17:48:15 +09:00
Dean Herbert	96049c39c9	Add begin/end session logic	2020-10-22 17:48:15 +09:00
Dean Herbert	175fd512b0	Send frames to streaming client from replay recorder	2020-10-22 17:48:15 +09:00
Dean Herbert	411ae38605	Remove unused using	2020-10-20 15:06:31 +09:00
Dean Herbert	267b399f9f	Add some simple border styles	2020-10-20 13:59:03 +09:00
Bartłomiej Dach	7c388f1132	Move editor playfield border locally to osu! composer	2020-10-19 21:20:13 +02:00
Bartłomiej Dach	4267d23d59	Move border to more appropriate namespace	2020-10-19 20:56:34 +02:00
Bartłomiej Dach	053c7a69a6	Fix code style issues & compilation failures	2020-10-19 20:22:48 +02:00
Dean Herbert	22bde43106	Merge branch 'master' into visible-playfield-boundary	2020-10-19 18:05:28 +09:00
Dan Balasescu	fe51236c00	Merge branch 'master' into score-test	2020-10-19 15:55:52 +09:00
Bartłomiej Dach	5b96f01564	Fix key counter actions displaying out of order	2020-10-18 19:21:36 +02:00
smoogipoo	6385d5f369	Replace with local tolist	2020-10-16 23:40:44 +09:00
smoogipoo	81cc5e1c42	Silence EF warning due to ordinal being unsupported	2020-10-16 23:31:37 +09:00
Berkan Diler	fe3a23750c	Use char overloads for string methods	2020-10-16 11:52:29 +02:00
Dean Herbert	cc41845f56	Add missing string function ordinal specifications	2020-10-16 12:49:31 +09:00
Dan Balasescu	5640d33d1a	Merge branch 'master' into skin-disabler-refactor	2020-10-15 18:32:50 +09:00
Dean Herbert	ef2e2894a2	Merge branch 'master' into fix-mania-diffcalc	2020-10-14 23:49:14 +09:00
Dean Herbert	1684c4f412	Merge pull request #10503 from smoogipoo/fix-mod-combinations ... Fix MultiMod difficulty calculator combinations not generating correctly	2020-10-14 23:42:59 +09:00
Dean Herbert	8b864c8c22	Merge branch 'master' into fix-multimod-copy	2020-10-14 22:29:38 +09:00
smoogipoo	ed57b1363f	Remove unused usings	2020-10-14 20:08:46 +09:00
smoogipoo	c4fdd35223	Fix same-type incompatibility through multimod	2020-10-14 19:53:37 +09:00
Dean Herbert	e3eaba7b2c	Move ISampleDisabler implementation to Player and FrameStabilityContainer	2020-10-14 19:39:48 +09:00
smoogipoo	e9ebeedbe2	Refactor generation	2020-10-14 19:32:30 +09:00
smoogipoo	d7a52e97ff	Fix multimod difficulty combinations not generating correctly	2020-10-14 19:03:11 +09:00
smoogipoo	f04aec538f	Fix MultiMod throwing exceptions when creating copies	2020-10-14 18:12:19 +09:00
Dean Herbert	207c409792	Merge branch 'master' into fix-mania-diffcalc	2020-10-14 15:26:32 +09:00
Bartłomiej Dach	1af17fbd5e	Merge branch 'master' into fix-early-break-cull	2020-10-13 18:02:08 +02:00
smoogipoo	372761a46f	More/better commenting	2020-10-12 19:22:34 +09:00
smoogipoo	eb4ef157ca	Fix implicit segments not being constructed correctly	2020-10-12 19:16:37 +09:00
smoogipoo	48c0ae40ef	Fix multi-segment sliders not parsing correctly	2020-10-12 18:04:28 +09:00
smoogipoo	8f37d2290a	Expose sorting of hitobjects	2020-10-09 21:43:46 +09:00
smoogipoo	485a951281	Expose current strain and retrieval of peak strain	2020-10-09 21:42:43 +09:00
smoogipoo	d536a1f75e	Fix breaks being culled too early	2020-10-09 21:04:56 +09:00
smoogipoo	696e3d53af	Fix slider samples being overwritten by the last node	2020-10-09 20:50:09 +09:00
Dan Balasescu	93f5ea57a5	Merge pull request #10427 from peppy/fix-hidden-first-object ... Fix first hitobject in osu! hidden mod not getting correct fade applied	2020-10-09 19:23:47 +09:00
Dan Balasescu	62690e4873	Merge pull request #10432 from peppy/editor-reverse-pattern ... Add "reverse pattern" support to editor selection handler	2020-10-09 19:19:24 +09:00
Dan Balasescu	6572ce5f36	Merge pull request #10441 from peppy/editor-selection-blueprint-performance ... Improve performance of slider blueprints	2020-10-09 18:01:25 +09:00
Dean Herbert	beec0e4193	Hide children of SelectionBlueprint when not selected	2020-10-09 14:03:13 +09:00
Dean Herbert	07558b5bc0	Merge branch 'master' into ruleset-result-types	2020-10-09 13:17:05 +09:00
Dean Herbert	6649cb2204	Fix incorrect first object logic	2020-10-09 06:41:53 +09:00
Dean Herbert	eacc7dca9a	Fix SliderPath not handling Clear correctly	2020-10-09 06:31:59 +09:00
Dean Herbert	2d0275ba95	Fix first hitobject in osu! hidden mod not getting correct fade applied	2020-10-09 03:07:01 +09:00
Bartłomiej Dach	7109c3b6cd	Rename variable as suggested	2020-10-07 21:06:24 +02:00
Endrik Tombak	2b6e4e575e	Award max combo portion score if max achievable is 0	2020-10-07 17:04:55 +03:00