h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-11-06 06:57:39 +08:00
Code Issues Releases Wiki Activity

Fix freeze due to large circular arc radius

Browse Source 
Seems to stem from the osu!framework's PathApproximator not catching a few edge cases wherein the radius approaches infinity.
This commit is contained in:
Naxess 2021-03-21 06:34:55 +01:00
parent a294f328fb
commit fcd1f4930f
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
osu.Game/Rulesets/Objects/SliderPath.cs
View File

@ -219,8 +219,10 @@ namespace osu.Game.Rulesets.Objects
List<Vector2> subpath = PathApproximator.ApproximateCircularArc(subControlPoints);
// If for some reason a circular arc could not be fit to the 3 given points, fall back to a numerically stable bezier approximation.
if (subpath.Count == 0)
// If for some reason a circular arc could not be fit to the 3 given points, or the
// resulting radius is too large (e.g. points arranged almost linearly), fall back
// to a numerically stable bezier approximation.
if (subpath.Count == 0 || subpath.Count > 400)
break;
return subpath;