Dean Herbert
662073c472
Fix some incorrect comments / test step descriptions
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-08-21 19:35:04 +09:00
Dean Herbert
db893f3dc7
Merge branch 'master' into fix-score-import-fail-fail-fail
2023-08-21 19:34:12 +09:00
Dean Herbert
e7d61e0002
Fix star fountain directions not matching stable
2023-08-21 17:59:24 +09:00
Bartłomiej Dach
90bef267c8
Merge pull request #24581 from OliBomby/fix-segment-ends
...
Fix `SliderPath.GetSegmentEnds`
2023-08-21 09:29:13 +02:00
Bartłomiej Dach
479c463751
Explain why segment end positions are not recovered in test
2023-08-21 08:29:51 +02:00
Dean Herbert
8120c3f87a
Merge branch 'master' into precise-rotation-2
2023-08-19 23:25:42 +09:00
Bartłomiej Dach
3d52a1267e
Fix test failures via test-local popover containers
2023-08-19 15:08:30 +02:00
Bartłomiej Dach
2b09594823
Use nunit constraints in test for better debug experience
2023-08-19 14:33:26 +02:00
OliBomby
fbf4d3ac81
Add test
2023-08-18 12:36:34 +02:00
Dan Balasescu
a2fd7707a1
Allow toggling SVs in the editor
2023-08-18 18:55:24 +09:00
Dean Herbert
80a143ae85
Tidy up test a bit more
2023-08-18 18:00:33 +09:00
Krzysztof Gutkowski
046cc62db2
Cleanup tests
2023-08-17 01:11:09 +02:00
Krzysztof Gutkowski
59abb59ee8
Set correct date added value when importing stable beatmapsets
2023-08-17 00:49:48 +02:00
Dean Herbert
59a31cc868
Merge pull request #24431 from bdach/slider-with-textbox-instantaneous
...
Add instantaneous mode to `SliderWithTextBoxInput`
2023-08-16 20:10:52 +09:00
Bartłomiej Dach
f9ca7f3e0e
Merge pull request #24564 from peppy/multi-spectator-test-improvements
...
Add various testing improvements to various tournament components
2023-08-16 12:29:36 +02:00
Bartłomiej Dach
bdf87e43db
Merge branch 'master' into slider-with-textbox-instantaneous
2023-08-16 10:48:45 +02:00
Dean Herbert
26d05afadc
Add more test coverage to multi spectator screen
2023-08-16 17:14:42 +09:00
Dean Herbert
56eb44d15b
Change TestSpectatorClient to provide some better fake data for score / acc
2023-08-16 17:14:42 +09:00
Bartłomiej Dach
4f47b196c1
Merge branch 'master' into fix-unsafe-realm-access
2023-08-16 09:59:17 +02:00
Dean Herbert
a8824c8c8a
Remove flaky test documentation for fixed test
2023-08-16 14:30:10 +09:00
cdwcgt
e7b34cd4da
declare BeatmapSet is not null
2023-08-14 03:43:16 +09:00
Bartłomiej Dach
4152b4e523
Remove duplicated test case
2023-08-12 22:46:18 +02:00
QuantumSno
e9bb9434e9
Merge remote-tracking branch 'origin/leaderboard-toggle' into leaderboard-toggle
2023-08-12 00:19:48 -04:00
QuantumSno
562af8b46d
Updated test TestSceneGameplayChatDisplay.cs. Now uses new default bind for toggle chat (enter)
2023-08-12 00:18:10 -04:00
Bartłomiej Dach
d91798271d
Add test case covering exit block
...
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2023-08-08 22:06:49 +02:00
Joseph Madamba
d179fe3d96
Add support for changelog entries with url attached
2023-08-03 23:24:37 -07:00
Bartłomiej Dach
dde03b7d46
Merge branch 'master' into playfield-skin-layer
2023-08-03 20:42:15 +02:00
cdwcgt
eef63b41da
fetch missing beatmap when import score with missing beatmap
2023-08-02 17:58:05 +09:00
Dean Herbert
0e510088f9
Ensure background of gameplay is black when storyboard is overriding background display
2023-08-02 15:50:15 +09:00
Bartłomiej Dach
5b6c3321cf
Merge branch 'master' into multi-spectator-flow-fixes
2023-08-01 19:03:48 +02:00
Bartłomiej Dach
bcfc76b469
Add visual-only test coverage for centred player case
2023-08-01 17:41:07 +02:00
Dean Herbert
ed0c7e8880
Add failing test coverage showing crash on multiple StartGameplay invocations
2023-08-01 19:21:58 +09:00
Bartłomiej Dach
049215f2dc
Add test coverage for invalid input scenarios
2023-08-01 01:02:16 +02:00
Bartłomiej Dach
4fb0ff8800
Implement instantaneous SliderWithTextBoxInput mode
2023-08-01 01:02:16 +02:00
Bartłomiej Dach
0b019f1d45
Add test covering desired instantaneous behaviour
2023-08-01 01:01:37 +02:00
Bartłomiej Dach
ca81f23356
Add test covering non-instantaneous behaviour
2023-08-01 01:01:37 +02:00
Dean Herbert
528298bc39
Update test in line with framework changes
2023-08-01 07:17:12 +09:00
Bartłomiej Dach
ebe5dd2ac9
Interface with SelectionRotationHandler via DI rather than explicit passing
2023-07-30 20:21:41 +02:00
Bartłomiej Dach
262f25dce8
Make SelectionRotationHandler a Component
2023-07-30 20:18:33 +02:00
Bartłomiej Dach
821cd08f34
Merge branch 'master' into selection-operations-refactor
2023-07-30 19:29:06 +02:00
Bartłomiej Dach
898913f32a
Merge pull request #24415 from peppy/multi-spectator-improvements
...
General visual improvements to mutliplayer spectatator screen
2023-07-30 12:43:26 +02:00
Bartłomiej Dach
e208f38bcb
Merge pull request #24361 from peppy/fix-editor-global-music-hotkey-conflicts
...
Disallow interacting with the global track state in `Player` and `Editor`
2023-07-30 12:28:53 +02:00
Dean Herbert
feea412bec
Add test with only one player
2023-07-30 14:40:24 +09:00
Bartłomiej Dach
43a51671ac
Fix wrong test step name
2023-07-29 16:12:02 +02:00
Bartłomiej Dach
aca8310cd1
Fix non-compiling test
...
To be fair, currently the test is a bit pointless (as it has no reason
to be a `SkinnableTestScene`, it gains precisely nothing from it - all
that is shown there is some generic components on song select). But that
is no worse then `master`, so look away for now.
2023-07-28 23:36:57 +02:00
Dean Herbert
269d4d1cd6
Add test coverage of autoplay restore not working
2023-07-28 14:49:06 +09:00
Bartłomiej Dach
22163020c3
Merge pull request #24367 from peppy/fix-replay-export-from-results
...
Fix attempting to export replay from results screen after play not working
2023-07-27 20:47:07 +02:00
Dean Herbert
e702e0a23e
Avoid intercepting temporary files in new test
2023-07-27 17:44:36 +09:00
Bartłomiej Dach
f66093d3cf
Revert failing test to prior assertions too
2023-07-26 21:51:32 +02:00
Bartłomiej Dach
7bc3edb05a
Fix code quality inspection
2023-07-26 20:52:03 +02:00
Dean Herbert
235cb2d73f
Add test coverage of upgrade success for good measure
2023-07-26 16:28:38 +09:00
Dean Herbert
a2f1ced5a2
Add test coverage of failed-to-upgrade flag
2023-07-26 16:22:21 +09:00
Dean Herbert
c1ba8fe175
Rename BackgroundBeatmapProcessor to BackgroundDataStoreProcessor
2023-07-26 16:22:10 +09:00
Dean Herbert
2dace742a3
Add test coverage of score arriving on disk when exporting from results screen after play
2023-07-26 15:21:43 +09:00
Bartłomiej Dach
57ccf82f34
Merge branch 'master' into song-select-drain-length
2023-07-25 22:40:45 +02:00
Bartłomiej Dach
653f01f4ce
Merge pull request #24359 from peppy/fix-unknown-mod-test-failure
...
Fix `TestSceneUnknownMod` failing due to null reference
2023-07-25 22:40:03 +02:00
Bartłomiej Dach
c6099edb88
Rename test to match class
2023-07-25 22:18:31 +02:00
Bartłomiej Dach
3b9f250c1b
Merge branch 'master' into menu-star-fountains
2023-07-25 21:58:13 +02:00
Bartłomiej Dach
d75e6f78d6
Adjust cyclic selection test to hitcircle lifetime adjustments
...
As it turns out, the tightening of hitcircle lifetimes in editor caused
the test to fail, since the objects were too far apart and at the
starting time of the test, the first object was fully faded out and as
such not alive, therefore leading cyclic selection to fail to select it.
To fix, bring all three objects closer together time-wise so that this
does not happen and the test can continue to exercise its original
behaviour.
2023-07-25 18:54:13 +02:00
Dean Herbert
157b1f301b
Rename AllowTrackAdjustments to more understandable ApplyModTrackAdjustments
2023-07-25 20:20:53 +09:00
Dean Herbert
060ad36d60
Add test coverage of music control in editor from external
2023-07-25 20:20:53 +09:00
Dean Herbert
c1d93607e0
Fix TestSceneUnknownMod failing due to null reference
2023-07-25 19:06:13 +09:00
Dean Herbert
9cfe9164fa
Add helper method to get drain length (and rename some usages)
2023-07-25 16:58:41 +09:00
Bartłomiej Dach
21df0e2d60
Migrate test to SelectionRotationHandler
2023-07-23 20:56:22 +02:00
Bartłomiej Dach
d7b674bf2b
Merge branch 'master' into verify-breaks
2023-07-22 17:42:55 +02:00
Bartłomiej Dach
2df6e91176
Add extra test coverage for breaks before first/after last object
2023-07-22 17:12:35 +02:00
Bartłomiej Dach
2ef843261b
Adjust failing test after metrics changes
2023-07-21 19:08:40 +02:00
Dean Herbert
ca3d1538ae
Merge branch 'master' into editor-metrics
2023-07-21 14:26:32 +09:00
Dean Herbert
b29a2081ac
Merge branch 'master' into menu-star-fountains
2023-07-21 14:21:16 +09:00
Bartłomiej Dach
c77d3cd6bd
Merge pull request #24294 from peppy/toggle-all-freemods
...
Add ability to toggle all free mods quickly at multiplayer song select
2023-07-20 22:32:53 +02:00
Bartłomiej Dach
48024cd17f
Add test coverage of double click behaviour
2023-07-20 20:51:17 +02:00
Bartłomiej Dach
f60a6e9893
Fix test step descriptions
2023-07-20 20:47:33 +02:00
Bartłomiej Dach
708dd355cd
Merge branch 'master' into editor-cyclic-selection
2023-07-20 20:19:46 +02:00
Bartłomiej Dach
210e114f7d
Merge branch 'master' into editor-prefer-closest
2023-07-20 19:16:09 +02:00
Dan Balasescu
733ce4c382
Fix incorrect dependency caching
...
These are tested framework-side to throw exceptions, but the
test is ignored for the source generated version because it quietly
allows this scenario.
The source gen project should eventually have an analyser for these
unsupported cases, or we could consider relaxing this particular case.
2023-07-20 22:30:49 +09:00
NiceAesth
ce78bb549f
Add test for multiple too early objects in break
2023-07-20 00:32:54 +03:00
Bartłomiej Dach
f3a95d4c13
Merge branch 'master' into menu-star-fountains
2023-07-19 21:26:41 +02:00
Dean Herbert
eb149942e5
Add ability to toggle all free mods quickly at multiplayer song select
2023-07-19 19:08:32 +09:00
Dean Herbert
94c5b8ed32
Apply NRT to TestSceneComposerSelection
2023-07-19 17:22:25 +09:00
Dean Herbert
d33b174243
Add test coverage of beatmap editor cyclic selection
2023-07-19 17:21:20 +09:00
Dean Herbert
9d46d00294
Update skin editor cyclic test to match expectations better
2023-07-19 16:56:16 +09:00
Dean Herbert
4e4dcc9846
Add test coverage of selection preferring closest objects
2023-07-19 16:56:16 +09:00
Dean Herbert
7f336b8dac
Merge branch 'master' into editor-metrics
2023-07-19 15:00:51 +09:00
Dean Herbert
2e3d1fe950
Fix regression in time jumping behaviour
2023-07-19 13:38:04 +09:00
NiceAesth
b3974b34e7
Test break checks
2023-07-16 23:03:30 +03:00
NiceAesth
3888471148
Add break length and bounds checks
2023-07-16 23:03:21 +03:00
Bartłomiej Dach
a42992d3fd
Remove unused local variable
2023-07-16 17:10:26 +02:00
Bartłomiej Dach
72bf43e297
Add failing test covering exit dialog crash
2023-07-16 16:55:20 +02:00
Dean Herbert
56acc9e3dd
Change BeatDivisorControl to retrive bindable divisor via DI
2023-07-14 14:03:25 +09:00
Bartłomiej Dach
cdbb6f90be
Merge pull request #24199 from peppy/revert-to-default-design-change
...
Update design of "revert to default" button
2023-07-13 23:44:24 +02:00
Bartłomiej Dach
ff56e35093
Merge pull request #24197 from peppy/allow-autoplay-failure
...
Allow autoplay to fail
2023-07-13 23:44:07 +02:00
Bartłomiej Dach
e7dbe3c938
Fix broken test
2023-07-13 22:28:26 +02:00
Bartłomiej Dach
cef0dd1d61
Merge pull request #24190 from novialriptide/emoji-fix
...
Replace emoji unicode with `[emoji]`
2023-07-13 22:05:12 +02:00
Bartłomiej Dach
6b9dabbd3c
Rewrite test scene to show non-themed and themed variants
2023-07-13 21:54:30 +02:00
Bartłomiej Dach
ae7ed697ec
Adjust failing test after permitting autoplay and no fail combo
2023-07-13 21:22:48 +02:00
Bartłomiej Dach
4859b8c994
Add some extra text coverage against potential emoji-to-link misparses
2023-07-13 20:51:52 +02:00
Bartłomiej Dach
9b771ee798
Merge pull request #24202 from peppy/save-preset-on-select
...
Allow saving changes to mod presets using enter key
2023-07-13 19:50:16 +02:00
Bartłomiej Dach
4b06b6f34e
Crudely fix crashes when switching between TestResultsWithPlayer cases
...
In the visual test browser, if two `TestResultsWithPlayer` test cases
are ran consecutively, the second would die on `SoloStatisticsWatcher`
seeing duplicated online score IDs. This surfaced after
6ef39b87fe
2023-07-13 19:06:02 +02:00
Dean Herbert
1698caa078
Add kiai fountains to main menu
2023-07-13 22:13:40 +09:00
Dean Herbert
20e4e2581a
Change IBeatSyncProvider.Clock to always be non-null
2023-07-13 22:13:40 +09:00
Dean Herbert
6ef39b87fe
Reorder tests for testability
2023-07-13 18:12:46 +09:00
Dean Herbert
654a7057fc
Add actual statistics changes to better visualise layout
2023-07-13 18:12:46 +09:00
Dean Herbert
aebbffacf2
Show online stats on TestSceneStatisticsPanel
...
Fix test regression
2023-07-13 18:12:37 +09:00
Dean Herbert
b7ab46d87b
Add full statistics score to TestSceneResultsScreen
2023-07-13 18:12:35 +09:00
Dean Herbert
6529c810fa
Change order and test population in TestSceneStatisticsPanel to give better visible results
2023-07-13 18:12:19 +09:00
Andrew Hong
71351d8982
I forgor to remove these
2023-07-13 05:06:23 -04:00
Dean Herbert
db37de45ac
Allow saving changes to presets in popover using "select" binding
2023-07-13 17:53:26 +09:00
Dean Herbert
f5c472c0fe
Don't hide mod select overlay when pressing select binding with no search
2023-07-13 17:50:07 +09:00
Andrew Hong
403a7aa000
0 links are expected
2023-07-13 04:28:35 -04:00
Andrew Hong
3d17a03dc6
Emojis now represented as "[emoji]"
2023-07-13 03:52:22 -04:00
Dean Herbert
94201579f6
Update design of "revert to default" button
...
I keep getting feedback that the old design looked like anything *but* a
button to revert defaults. Including people clicking it expecting
opposite behaviour.
This is intended to be a temporary design until we get the full new UI
components online (where this is moved to the right-hand-side).
2023-07-13 14:26:03 +09:00
Dean Herbert
1bfe5a18cb
Rename RestoreDefaultValueButton to RevertToDefaultButton
...
Because I can't find it every time I search.
2023-07-13 13:46:50 +09:00
Andrew Hong
f44e6e510d
5 -> 4
2023-07-12 22:42:12 -04:00
Andrew Hong
3d256acfef
Delete emoji test in TestLinkComplex
2023-07-12 21:40:49 -04:00
Andrew Hong
5a43de1ace
Update test cases
2023-07-12 21:13:10 -04:00
Bartłomiej Dach
851e6d111a
Merge branch 'master' into verify-drain-time
2023-07-11 23:29:18 +02:00
Bartłomiej Dach
a1da0b58db
Improve negative test case without breaks too
2023-07-11 23:22:37 +02:00
Bartłomiej Dach
d927cb3f1c
Actually cover cases with breaks in tests
2023-07-11 23:21:03 +02:00
Bartłomiej Dach
9a3cb624a8
Rewrite tests to be less aggressively DRY
...
Four of six helper methods defined in the test were used exactly once;
the remaining two were used two times. Splitting helpers there is just
too much.
2023-07-11 23:18:52 +02:00
NiceAesth
d75887bb3b
Apply feedback to tests
2023-07-11 13:40:27 +03:00
Zyf
82364b4f9f
Use OsuScoreProcessor in the scoring test scene
2023-07-11 02:46:32 +02:00
NiceAesth
c972a4195c
Add tests
2023-07-10 17:29:59 +03:00
Bartłomiej Dach
2af8c7bc24
Add failing test case for chat message length limit enforcement
2023-07-09 21:40:27 +02:00
Bartłomiej Dach
055e4a78f0
Merge branch 'master' into taiko-hitsounding-final-attempt
2023-07-08 18:10:04 +02:00
Bartłomiej Dach
e2aaef6663
Merge branch 'master' into no-dismiss-all-progress-notifications
2023-07-08 14:19:57 +02:00
Bartłomiej Dach
832c1c0009
Merge branch 'master' into fix-gameplay-samepl-trigger-source-rewind
2023-07-08 13:33:04 +02:00
Dean Herbert
ba0ab7383d
Fix broken test nullability
2023-07-07 16:28:49 +09:00
Dean Herbert
d72765b6f8
Merge pull request #24114 from peppy/editor-save-local-score-management
...
Ensure scores always have the correct linked `BeatmapInfo`
2023-07-07 15:40:54 +09:00
Dean Herbert
f8be6d41f7
Play basic notification test first
2023-07-07 13:23:45 +09:00
Dean Herbert
8978f2ddd8
Remove all usage of !something!.something
...
aka don't mix NRT forgiving syntax with not syntax
2023-07-07 10:15:33 +09:00
Bartłomiej Dach
ae2896ba7e
Sprinkle some more null-forgiving operators
2023-07-06 22:08:48 +02:00
Dean Herbert
2e98ab0a48
Expose rewinding state of IGameplayClocks
...
The implementation of this requires a bit of a special case
for 0, so makes sense to implement in a central place.
2023-07-06 19:08:42 +09:00
Dean Herbert
7a3a14e50d
Add sample trigger tests covering rewinding of gameplay
2023-07-06 19:08:42 +09:00
Dean Herbert
af3f9086e5
Expose rewinding state of IGameplayClocks
...
The implementation of this requires a bit of a special case
for 0, so makes sense to implement in a central place.
2023-07-06 14:16:31 +09:00
Dean Herbert
a98a36872e
Bring realm library up-to-date
2023-07-06 13:37:43 +09:00
Dean Herbert
9ff6b3fcd3
Merge branch 'master' into editor-save-local-score-management
2023-07-06 12:28:44 +09:00
Dean Herbert
c5b949154c
Merge branch 'fix-judged-fallback' into taiko-hitsounding-final-attempt
2023-07-05 18:44:27 +09:00
Dean Herbert
51b0d18c04
Fix weird test assertion output
2023-07-05 18:44:27 +09:00
Dean Herbert
7355a6a66b
Add test coverage of Judged state
2023-07-05 18:44:27 +09:00
Dean Herbert
e21dc56fcb
Add test coverage of Judged state
2023-07-05 18:20:25 +09:00
Bartłomiej Dach
b0f6b22fa7
Add assertions covering correctness of judged flags on entry
2023-07-04 23:48:46 +02:00
Bartłomiej Dach
2b098bdf61
Add test coverage for mixed pooled/non-pooled usages
2023-07-04 23:41:06 +02:00
Bartłomiej Dach
e2ddcb2349
Silence a few remaining nullability warnings
2023-07-04 22:39:26 +02:00
Bartłomiej Dach
bcdbdf57ef
Reword comment
2023-07-04 22:22:57 +02:00
Dean Herbert
a0bed0fcec
Add full flow test of UpdateLocalScores
2023-07-04 15:18:51 +09:00
Dean Herbert
64fc5e40e8
Move score attach logic to a helper method and call during editor save
2023-07-04 15:07:40 +09:00
Dean Herbert
f30dc59afe
Update tests to show expected score retention behaviour when saving a beatmap
2023-07-04 15:07:27 +09:00
Dean Herbert
d74b1e148d
Make ScoreInfo.BeatmapInfo nullable
2023-07-04 14:50:34 +09:00
Bartłomiej Dach
21f758947d
Merge branch 'master' into availability-fixes
2023-07-02 20:38:37 +02:00
Bartłomiej Dach
746212be7b
Remove weird .Run(r => r.Write(...)) construction
2023-07-01 20:42:34 +02:00
Bartłomiej Dach
b6e9422aa4
Fix typo in test name
2023-07-01 20:38:00 +02:00
Bartłomiej Dach
1ce60378be
Rewrite comments further
2023-07-01 20:37:33 +02:00
Cootz
8d25e2c3e1
Add importer update test
2023-07-01 09:49:06 +03:00
Cootz
2b1d637292
Add missing ruleset store
2023-07-01 09:48:42 +03:00
Cootz
f5d3a24582
Rename test
2023-06-30 20:15:38 +03:00
Cootz
428383708c
Add test for import
2023-06-30 20:13:14 +03:00
Dean Herbert
537404440d
Set the beatmap locally available for participants list tests
2023-06-29 13:17:42 +09:00
Bartłomiej Dach
0940ab1e11
Add failing tests covering correct flip handling
2023-06-28 20:48:02 +02:00
Dean Herbert
3883c28b15
Add visual display in participants list when availability is still being established
2023-06-28 16:02:46 +09:00
Dean Herbert
1d4380cfd0
Merge pull request #24058 from peppy/full-term-exact-match
...
Add support for matching full terms at song select using suffixed `!`
2023-06-28 12:14:15 +09:00
Dean Herbert
bc26d52dbd
Merge pull request #24067 from bdach/fix-difficulties-not-deleting-from-db
...
Fix delete difficulty flow not actually deleting the difficulty from realm
2023-06-28 12:06:01 +09:00
Dean Herbert
076f41be12
Merge pull request #24059 from peppy/add-editor-rotate-hotkeys
...
Add support for `Ctrl` + `<` / `>` to rotate selection in editor
2023-06-28 12:03:34 +09:00
Bartłomiej Dach
d72a8da295
Add test coverage for deleted difficulties staying in realm
2023-06-27 23:40:12 +02:00
Bartłomiej Dach
444f71541a
Add test coverage for rotate hotkeys
2023-06-27 22:10:53 +02:00
Bartłomiej Dach
eb6bdb5a38
Merge pull request #23926 from ItsShamed/hud/kc-skinnable
...
Make key counter skinnable
2023-06-27 21:57:41 +02:00
Bartłomiej Dach
bca1a91087
Add test cases covering full phrase case insensitivity
2023-06-27 21:50:39 +02:00
Bartłomiej Dach
bf99fc61b8
Trim full phrase filters in a more precise manner
2023-06-27 21:50:36 +02:00
Bartłomiej Dach
aba380b001
Add test case for full phrase match mode trimming chars from inside phrase
2023-06-27 21:45:52 +02:00
Bartłomiej Dach
e3d97b37f1
Rename MatchMode.{None -> Substring}
2023-06-27 21:28:37 +02:00
Bartłomiej Dach
06654dc618
Merge branch 'master' into full-term-exact-match
2023-06-27 21:27:39 +02:00
Bartłomiej Dach
7052f87eb8
Add even more safety against unloaded components
2023-06-27 21:21:14 +02:00
Bartłomiej Dach
11577d1df0
Add test coverage for title query parsing
2023-06-27 20:41:03 +02:00
Bartłomiej Dach
af66ccbfdf
Merge branch 'master' into hud/kc-skinnable
2023-06-27 20:35:47 +02:00
Bartłomiej Dach
9681ee7eeb
Fix broken test step
2023-06-27 20:29:27 +02:00
Bartłomiej Dach
ada9c48bde
Attempt to fix more test failures
2023-06-27 20:17:58 +02:00
Dean Herbert
8bd6f7a46a
Rename ClicksPerSecondCalculator to ClicksPerSecondController
2023-06-27 16:38:46 +09:00
Dean Herbert
e21583ff1b
Refactor InputCountController to not require being added to foreign body via Attach
...
I've made the flow match `ClicksPerSecondCalculator` as close as
possible. Hopefully this reads better.
2023-06-27 16:36:00 +09:00
Dean Herbert
e99de0eb5d
Add safety to tests to ensure loaded
2023-06-27 16:04:34 +09:00
Dean Herbert
19ec6d5455
Add test coverage of new matching mode
2023-06-27 15:44:58 +09:00
Dean Herbert
702266198b
Add missing "title=" search support at song select
2023-06-27 15:21:13 +09:00
Bartłomiej Dach
9c87d42f2b
Attempt to remedy HUD overlay test failure by waiting more
2023-06-26 22:41:31 +02:00
Bartłomiej Dach
e998be0eee
Use == true rather than ?? false
2023-06-26 22:29:20 +02:00
Bartłomiej Dach
4873aaf7ed
Add failing test case for filters potentially crashing due to invalid regex
2023-06-26 22:27:08 +02:00
Bartłomiej Dach
7200855d46
Rename Judgement{Tally -> CountController}
2023-06-26 19:30:04 +02:00
Bartłomiej Dach
8d91580dc1
Rename {KeyCounter -> InputCount}Controller
2023-06-26 19:27:42 +02:00
Dean Herbert
1960cd0839
Add test coverage of exact matching of search terms
2023-06-26 18:26:44 +09:00
Dean Herbert
14c95f4584
Apply NRT to FilterCriteria
2023-06-26 17:54:11 +09:00
Dean Herbert
0c869367e1
Merge branch 'master' into hud/kc-skinnable
2023-06-26 15:53:16 +09:00
Dean Herbert
ac0c988d49
Fix weirdly named test method and add xmldoc
2023-06-26 13:21:29 +09:00
Joseph Madamba
25c9bf4061
Improve and refactor LoginPanel test scene to use LoginOverlay
2023-06-25 11:39:32 -07:00
tsrk
350d722c8d
Merge branch 'master' into hud/kc-skinnable
2023-06-25 15:42:08 +02:00
Dean Herbert
cf43cd2bdc
Rename test scene to match updated class name
2023-06-25 21:26:10 +09:00
Bartłomiej Dach
a7202721ff
Merge branch 'master' into no-confirmation-on-update-restart
2023-06-25 13:35:21 +02:00
Bartłomiej Dach
25842105ce
Merge pull request #23976 from peppy/gameplay-sample-trigger-source-correctness
...
Adjust `GameplaySampleTriggerSource` to only switch samples when close enough to the next hit object
2023-06-25 08:23:55 +02:00
Bartłomiej Dach
f8d2f2f7e1
Fix more issues discovered by CI that can be fixed game-side
2023-06-24 19:04:05 +02:00
Bartłomiej Dach
d7ae430ec2
Merge branch 'master' into framework-update
2023-06-24 18:47:52 +02:00
Bartłomiej Dach
e273c223a8
Fix some more missed CI inspections
2023-06-24 17:11:38 +02:00
Bartłomiej Dach
e3a89a6273
Fix remaining obvious CI inspections
2023-06-24 16:07:01 +02:00
Dean Herbert
2bda63c2c8
Merge branch 'master' into mass-nrt
2023-06-24 09:59:15 +09:00
Dean Herbert
58e6b3782b
Fix a couple of remaining issues
2023-06-24 09:58:36 +09:00
Dean Herbert
3585c3f1d5
Apply required nullability changes
2023-06-24 09:58:36 +09:00
Salman Ahmed
c5771912db
Merge branch 'master' into tournament-chatcolor
2023-06-23 22:23:33 +03:00
Dean Herbert
df5b389629
Manual fixes to reduce warnings to zero
2023-06-24 01:52:53 +09:00
Dean Herbert
0ab0c52ad5
Automated pass
2023-06-24 01:00:03 +09:00
Dean Herbert
1dc7c05c12
Merge branch 'master' into no-confirmation-on-update-restart
2023-06-23 15:33:01 +09:00
Dean Herbert
a76037b643
Add test coverage of confirm-for-operations
2023-06-23 15:30:21 +09:00
Dean Herbert
7fa07805b0
Expose all notifications from INotificationOverlay
...
Also fixes `HasOngoingOperations` not actually working.
2023-06-23 15:19:21 +09:00
Dean Herbert
6df617d536
Rename ExitConfirmOverlay to be more explicit about purpose
2023-06-23 14:46:38 +09:00
Dean Herbert
11a97e1bb8
Move confirmation bypass implementation to MainMenu to allow for more correct logic
2023-06-23 14:42:56 +09:00
Bartłomiej Dach
2c1c20e0a7
Rename test helpers
2023-06-22 23:10:16 +02:00
Bartłomiej Dach
786deec296
Rename and xmldoc members
2023-06-22 23:00:52 +02:00
Liam DeVoe
6de7328fef
add test for comment when logging in and out
2023-06-21 02:17:51 -04:00
Liam DeVoe
dd4f271158
fix cancel test for new button layout
2023-06-21 02:15:02 -04:00
Bartłomiej Dach
2f77675fe7
Fix errors in tests due to mismatching NRT annotations
2023-06-20 21:57:32 +02:00
Dean Herbert
92e89c7df7
Update test expectations
2023-06-20 21:02:34 +09:00
Dean Herbert
04dad6c6e8
Use IGameplayClock to ensure our clock source is correct
2023-06-20 20:47:56 +09:00
Liam DeVoe
343052410b
update CommentEditor test components
2023-06-19 22:08:45 -04:00
Ruki
9c6c6bf1ea
Merge branch 'master' into hud/kc-skinnable
2023-06-18 18:30:44 +02:00
tsrk
886a1e98da
test(SkinDeserialisationTest): use more complete skin
2023-06-18 17:32:49 +02:00
Bartłomiej Dach
75300ca229
Switch search box to initially unfocused
...
Done primarily to keep mod hotkeys working without any behavioural
changes when mod select is opened.
2023-06-18 15:58:50 +02:00
Bartłomiej Dach
9ba4bf5fb7
Merge branch 'master' into add-mod-search-option
2023-06-18 15:06:21 +02:00
Bartłomiej Dach
0b6c0592e4
Add failing test case for mod preset filtering not working after ruleset change
2023-06-18 14:51:16 +02:00
Bartłomiej Dach
b9156b1df3
Reword/rename some stuff in test
2023-06-18 14:24:35 +02:00
Bartłomiej Dach
76f509a1db
Do not use ?? true pattern
...
Universally disliked. `!= false` is preferred.
2023-06-18 14:19:38 +02:00
Bartłomiej Dach
9758e5f840
Fix utterly broken test
...
- Was on wrong ruleset, so the mod/free mod sets did literally nothing
- `assertHasFreeModButton` had a param that did nothing
- Was checking `MatchingFilter` rather than `Visible`
2023-06-18 14:16:38 +02:00
Dean Herbert
eb31fdecee
Apply osu! side changes in line with FocusedOverlayContainer.PopIn abstract change
...
See https://github.com/ppy/osu-framework/pull/5834
2023-06-18 20:57:32 +09:00
Joseph Madamba
9ae864c219
Fix beatmap info length tooltip not showing actual drain length
2023-06-17 15:00:32 -07:00
tsrk
61101335cc
test: fix KeyCounterController not provided as a dependency
2023-06-16 19:00:09 +02:00
tsrk
b9d6ba1934
test: add skin deserialisation test resource
2023-06-16 18:26:30 +02:00
tsrk
f9321a24d9
test: change hideTarget drawable and testing logic
...
Doesn't change what it needs to test conceptually
2023-06-16 17:24:40 +02:00
Ruki
aba8219d06
Merge branch 'master' into hud/kc-skinnable
2023-06-15 15:48:43 +02:00
tsrk
7e70598773
test: move back key counter tests in ctor
2023-06-15 12:02:30 +02:00
Salman Ahmed
b9543f4fdd
Add failing test case
2023-06-15 11:21:52 +03:00
tsrk
42b740a175
Merge branch 'master' into hud/kc-skinnable
2023-06-14 22:19:45 +02:00
tsrk
c637fddf73
refactor: decouple Trigger logic from KeyCounterDisplay
...
This allows to keep a coeherent state regardless of the progress of the play
2023-06-14 21:13:35 +02:00
tsrk
758831b983
test: remove hard usages of KeyCounterDisplay
2023-06-14 13:25:24 +02:00
cdwcgt
51451bd53e
fix test
2023-06-14 01:32:27 +09:00
cdwcgt
430938fbb2
allow custom username color for chatLine
...
user's color (e.g. green for NAT) will be ignore
2023-06-12 22:07:36 +09:00
Cootz
aece548db1
Merge branch 'master' into add-mod-search-option
2023-06-12 13:09:09 +03:00
Dean Herbert
062fd58602
Add test to known time
2023-06-12 16:43:28 +09:00
Dean Herbert
c9f9569e4a
Add ability to change background colour in song progress test scene
2023-06-12 16:22:40 +09:00
Cootz
036479dd9d
Merge branch 'master' into add-mod-search-option
2023-06-09 16:27:18 +03:00
Bartłomiej Dach
58507291b9
Apply NRT in MemoryCachingComponent test-only subclasses
2023-06-09 13:48:42 +02:00
Bartłomiej Dach
4b3b22f046
Merge branch 'master' into beat-divisor-better-defaults
2023-06-08 20:35:03 +02:00
Dean Herbert
0875fc6233
Update tests in line with new behaviour
2023-06-09 02:28:38 +09:00
Bartłomiej Dach
281aae91ec
Merge pull request #23808 from peppy/working-beatmap-get-background
...
Refactor `IWorkingBeatmap.Background` to `GetBackground()`
2023-06-08 12:23:07 +02:00
Bartłomiej Dach
079e687bee
Fix incorrect mock setup after refactor
2023-06-08 10:09:27 +02:00
Dean Herbert
a842f79ad4
Refactor IWorkingBeatmap.Background to GetBackground()
2023-06-08 16:19:32 +09:00
Bartłomiej Dach
b3ce7f7b43
Merge branch 'master' into fix-section-container-scroll-attempt-2
2023-06-08 09:19:26 +02:00
Bartłomiej Dach
35e41d816a
Cover clamping to max beat divisor in test
2023-06-07 23:38:06 +02:00
Bartłomiej Dach
9b665d2e1a
Merge branch 'master' into beat-snap-divisor-hotkeys
2023-06-07 23:38:03 +02:00
Dean Herbert
3a01498789
Use existing next/previous methods (and remove looping behaviour)
2023-06-08 01:01:29 +09:00
Bartłomiej Dach
1f4e79d79d
Merge pull request #23711 from timiimit/add-last-edit-time
...
Store timestamp of beatmap's last edit time in local database
2023-06-07 16:57:24 +02:00
Dean Herbert
757596fffa
Add test coverage of scroll failing
2023-06-07 16:32:29 +09:00
Salman Ahmed
62cb6a98ca
Remove redundant nullable suppression directives
2023-06-07 08:20:41 +03:00
Bartłomiej Dach
f51b8a6a05
Fix code quality inspection
2023-06-06 21:11:24 +02:00
Bartłomiej Dach
7694aa7219
Add test coverage
2023-06-06 20:36:44 +02:00
Bartłomiej Dach
46ec250d34
Fix test failures due to cross-test state pollution
...
`TestSceneEditorTestGameplay` is not isolated from database, and one of
the tests exiting editor when seeked to 60000 milliseconds
(`TestClockTimeTransferIsOneDirectional()`) ended up changing
`EditorTimestamp` to the same value, causing
`TestSaveChangesBeforeGameplayTest()` to fail due to changing initial
state.
To fix, perform a direct deletion of imported beatmaps in realm to avert
this scenario, contrary to the soft-deletion via `BeatmapManager` done
previously.
2023-06-06 20:21:55 +02:00
Cootz
ba7069df34
Fix SelectAllModsButton state doesn’t update when search term changed
2023-06-06 16:12:31 +03:00
Dean Herbert
66b8b5192b
Add test coverage of editor timestamp remembering
2023-06-06 15:25:19 +09:00
Bartłomiej Dach
5c1abdc704
Fix screen navigation test hijacking dummy request handler
...
In an upcoming change, I stumbled upon a test failure mode wherein tests
in `TestSceneScreenNavigation` would die on the following exception:
2023-05-07 17:58:42 [error]: System.ObjectDisposedException: Cannot access a closed Realm.
2023-05-07 17:58:42 [error]: Object name: 'Realms.Realm'.
2023-05-07 17:58:42 [error]: at Realms.Realm.ThrowIfDisposed()
2023-05-07 17:58:42 [error]: at Realms.Realm.All[T]()
2023-05-07 17:58:42 [error]: at osu.Game.Beatmaps.BeatmapManager.<>c__DisplayClass25_0.<QueryBeatmap>b__0(Realm r) in D:\a\osu\osu\osu.Game\Beatmaps\BeatmapManager.cs:line 282
2023-05-07 17:58:42 [error]: at osu.Game.Database.RealmAccess.Run[T](Func`2 action) in D:\a\osu\osu\osu.Game\Database\RealmAccess.cs:line 387
2023-05-07 17:58:42 [error]: at osu.Game.Beatmaps.BeatmapManager.QueryBeatmap(Expression`1 query) in D:\a\osu\osu\osu.Game\Beatmaps\BeatmapManager.cs:line 282
2023-05-07 17:58:42 [error]: at osu.Game.Tests.Visual.OnlinePlay.TestRoomRequestsHandler.<HandleRequest>g__createResponseBeatmaps|6_0(Int32[] beatmapIds, <>c__DisplayClass6_0& ) in D:\a\osu\osu\osu.Game\Tests\Visual\OnlinePlay\TestRoomRequestsHandler.cs:line 174
2023-05-07 17:58:42 [error]: at osu.Game.Tests.Visual.OnlinePlay.TestRoomRequestsHandler.HandleRequest(APIRequest request, APIUser localUser, BeatmapManager beatmapManager) in D:\a\osu\osu\osu.Game\Tests\Visual\OnlinePlay\TestRoomRequestsHandler.cs:line 140
2023-05-07 17:58:42 [error]: at osu.Game.Tests.Visual.TestMultiplayerComponents.<>c__DisplayClass18_0.<load>b__0(APIRequest request) in D:\a\osu\osu\osu.Game.Tests\Visual\TestMultiplayerComponents.cs:line 80
2023-05-07 17:58:42 [error]: at osu.Game.Online.API.DummyAPIAccess.<>c__DisplayClass32_0.<Queue>b__0() in D:\a\osu\osu\osu.Game\Online\API\DummyAPIAccess.cs:line 74
Upon closer inspection, one of the tests in the scene instantiates a
`TestMultiplayerComponents` instance. `TestMultiplayerComponents`
registers a custom request handler onto `DummyAPIAccess`. Normally, this
is not an issue; however, because `TestSceneScreenNavigation` is an
`OsuGameTestScene`, and therefore has its storage recycled after every
test, this leads to the error above in the following scenario:
1. `TestPushMatchSubScreenAndPressBackButtonImmediately()` passes.
2. The test is cleaned up, and the test case's storage is recycled,
including the test case's realm database.
3. In a subsequent test, a web request handled by the dummy API request
handler is fired. The dummy API request handler subsequently attempts
to access a realm that does not exist anymore.
As the usage of `TestMultiplayerComponents` is highly unorthodox in this
particular case, I'm opting for a localised fix which ensures that the
request handler is cleaned up appropriately.
2023-06-05 23:15:16 +02:00
Cootz
71e6f80c40
Add hotkey for switching search bar focus
2023-06-05 15:54:19 +03:00
Cootz
3ebc801484
Move (de)select all mods hotkeys handling to ModSelectOverlay
2023-06-05 13:49:07 +03:00
Bartłomiej Dach
25d0f0f3da
Merge pull request #23741 from peppy/fix-manage-collection-commit-on-focus-loss
...
Fix collection name changes not being reflected if enter is not pressed
2023-06-04 17:19:13 +02:00
Cootz
fd554033db
Update tests
2023-06-04 17:11:04 +03:00
Dean Herbert
3e308e4c27
Add test coverage showing commit failure in manage collections dialog
2023-06-04 12:50:30 +09:00
Bartłomiej Dach
331e90f720
Merge branch 'master' into tidy-results-grid-usage
2023-06-03 19:45:23 +02:00
Bartłomiej Dach
a9d4556647
Merge branch 'master' into update-multiplayer-room-diff-range
2023-06-03 16:50:09 +02:00
Cootz
4c7cca101e
Rename IsValid to Visible
2023-06-02 11:33:38 +03:00
Dean Herbert
bcde2cbc73
Apply NRT to BeatDivisorControl
2023-06-01 16:58:14 +09:00
Dean Herbert
985604fab5
Return StatisticItems rather than StatisticRows from ruleset
...
There were no usages of more than one column being provided per row, so
it seemed like unnecessarily complexity. I'm currently trying to reduce
complexity so we can improve the layout of the results screen, which
currently has up to three levels of nested `GridContainer`s.
Of note, I can't add backwards compatibility because the method
signature has not changed in `Ruleset` (only the return type). If we do
want to keep compatibility with other rulesets, we could designate a new
name for the updated method.
2023-06-01 14:35:15 +09:00
Dean Herbert
14a376c041
Merge branch 'master' into scorev2
2023-05-30 14:34:43 +09:00
Bartłomiej Dach
5604dfb758
Merge branch 'master' into acc-challenge
2023-05-29 22:33:57 +02:00
Bartłomiej Dach
1b57b0d31c
Add testing
2023-05-29 22:33:46 +02:00
Dean Herbert
1558723420
Merge branch 'master' into scorev2
2023-05-29 20:06:32 +09:00
Dean Herbert
a789d1e49c
Add xmldoc and change naming around ScoreProcessorStatistics a bit
2023-05-29 18:38:16 +09:00
Bartłomiej Dach
53c91349fe
Merge branch 'master' into slider-control-point-no-distance-snap
2023-05-26 19:52:54 +02:00
Bartłomiej Dach
96fe7cbe54
Merge branch 'master' into sample-set-controls
2023-05-25 21:58:16 +02:00
Dean Herbert
804671ca74
Split out grid snapping modes into "relative" and "global" types
2023-05-25 21:41:19 +09:00
Dean Herbert
7a5349d747
Remove constructor from MultiplayerPlaylistItem which is only used in tests
2023-05-25 20:09:40 +09:00
Dean Herbert
058edb5d5f
Centralise beatmap playable duration and bounds lookups
2023-05-25 17:32:48 +09:00
Dan Balasescu
6d9ba9248d
Massage tests a bit more
2023-05-25 16:38:22 +09:00
Bartłomiej Dach
578a0e7494
Merge branch 'master' into beat-divisor-visual-improvements
2023-05-24 22:28:26 +02:00
Bartłomiej Dach
07b5874eee
Fix test step name
2023-05-24 20:18:36 +02:00
Dean Herbert
6044327181
Add test coverage for escape deselecting any active selection
2023-05-24 23:59:22 +09:00
Dean Herbert
663cec1ff6
Combine editor navigation test scenes
2023-05-24 23:51:28 +09:00
Dean Herbert
8e5ba2208d
Add test coverage of new hotkeys
2023-05-24 17:33:48 +09:00
Dean Herbert
e68ba6366c
Update new usages of "soft" to use the new constant
2023-05-24 14:04:10 +09:00
Dean Herbert
298989ffd2
Merge branch 'master' into sample-set-controls
2023-05-24 14:03:04 +09:00
Gyoshi
b5f8093941
Use RangePadding to align mouse with slider
2023-05-23 18:16:14 +02:00
Gyoshi
fa00f8b92a
replace manual code with existing method
2023-05-23 18:16:12 +02:00
Gyoshi
921d7e4d89
More fitting tests for new layout
2023-05-23 18:16:10 +02:00
Dan Balasescu
7658536b5a
Fix CI issues
2023-05-23 19:32:19 +09:00
Dan Balasescu
fee3d43596
Merge branch 'master' into scorev2
2023-05-23 19:07:54 +09:00
Dan Balasescu
844c023fb7
Fix tests
2023-05-23 18:18:27 +09:00
Dean Herbert
ff5dde0ebe
Merge pull request #23575 from Joehuu/fix-inverted-video-only-check
...
Fix old widescreen videos with black bars not correctly filling screen (again)
2023-05-23 16:47:52 +09:00
Cootz
c3f06ad2db
Merge branch 'master' into add-mod-search-option
2023-05-23 08:55:57 +03:00
Bartłomiej Dach
2ce150ba2b
Add failing test case for sample undo
2023-05-22 22:23:05 +02:00
Bartłomiej Dach
843d2903d2
Add failing test case for slider velocity undo
2023-05-22 22:18:15 +02:00
Cootz
67bf1b4dfe
Select/deselect first visible mod when GlobalAction.Select is triggered
2023-05-21 11:05:01 +03:00
Dan Balasescu
7cbf48ffcf
Fix TestSceneScoring and incorrect combo calculations
2023-05-19 14:09:19 +09:00
Dan Balasescu
73544231de
Fix TestSceneTopLocalRank
2023-05-19 14:06:56 +09:00
Joseph Madamba
caa79704ac
Add test coverage for failing case
2023-05-17 20:23:37 -07:00
Dean Herbert
ec2b9165d5
Adjust BeatDivisorControl test to show control mmuch larger
2023-05-17 16:33:58 +09:00
Dean Herbert
ebce39cd1c
Add test coverage of failing sample bank transfer
2023-05-16 18:52:52 +09:00
Dean Herbert
8528fcaedc
Rename editor sample adjustment test scene to increase scope of tests
2023-05-16 18:52:52 +09:00
Dean Herbert
83dcd78826
Make HitSampleInfo.Bank non-nullable
2023-05-16 18:12:56 +09:00
Cootz
6647d95ea7
Kill search focus when clicking on ModColumn
2023-05-14 18:32:16 +03:00
Bartłomiej Dach
a99bf0fc5a
Add test coverage
2023-05-14 12:29:24 +02:00
Bartłomiej Dach
9a327d95b8
Add test coverage
2023-05-14 11:24:24 +02:00
Cootz
2467813d81
Block deselect all short key when using the search box
2023-05-09 16:14:42 +03:00
Dean Herbert
9160711470
Change "Show main page" test steps to actually load the main page
2023-05-08 15:32:00 +09:00
Dean Herbert
f002038137
Add test coverage of failing wiki return to page scenario
2023-05-08 15:29:05 +09:00
Bartłomiej Dach
8514b2758a
Fix rapid back button test failure
2023-05-07 21:07:38 +02:00
Cootz
4c3af6ecfe
Add test coverage for deselect all with filtered mods selected
2023-05-07 15:50:21 +03:00
Bartłomiej Dach
65b4b198a4
Merge branch 'master' into export
2023-05-06 20:12:53 +02:00
Bartłomiej Dach
80ac8abaa6
Merge branch 'master' into chat-report
2023-05-06 15:30:44 +02:00
Bartłomiej Dach
fba3c587cf
Add test coverage for info message failing to display
2023-05-06 15:26:29 +02:00
Cootz
5aca3a78da
Add basic tests for external search
2023-05-06 12:21:32 +03:00
Cootz
a226caff56
Fix testing
2023-05-06 11:09:44 +03:00
Cootz
7422b5285c
Fix wrong filtering in testing
2023-05-05 22:41:30 +03:00
cdwcgt
4393e53b43
ExportToStream should be public
2023-05-05 21:28:43 +09:00
Dean Herbert
f2dd457b3d
Remove unnecessary local variable
2023-05-05 16:31:48 +09:00
Dean Herbert
6a4933a31c
Remove need for TestRealmLive nonsense
2023-05-05 16:30:43 +09:00
Dean Herbert
0158102467
Rename class back to original name so I can read the diff
2023-05-05 16:19:10 +09:00
Dean Herbert
8391e2a538
Move reporting code out of DrawableChatUsername into more correct locations
2023-05-05 14:03:42 +09:00
Dean Herbert
698baa78bf
Merge pull request #22711 from Terochi/keep-shared-settings-ruleset-change
...
Keep shared mod settings when changing ruleset
2023-05-05 13:29:55 +09:00
Bartłomiej Dach
dcd2abae6d
Add test coverage for mod equality with multiple settings
2023-05-04 20:46:27 +02:00
Bartłomiej Dach
a1106d0a4e
Be explicit in test
2023-05-04 19:14:20 +02:00
Bartłomiej Dach
99e8b2ce70
Make getMod() method generally better
2023-05-04 19:12:22 +02:00
Bartłomiej Dach
aa7885ab97
Use better test step names
2023-05-04 19:11:51 +02:00
Bartłomiej Dach
bdd96caaa9
Merge branch 'master' into edit-mods-preset
2023-05-04 18:59:47 +02:00
Bartłomiej Dach
e43fc23606
Fix typos in test
2023-05-04 18:50:21 +02:00
Bartłomiej Dach
0d2396c557
Rename method to better indicate directionality
2023-05-04 18:15:12 +02:00
cdwcgt
2cb6642b0d
use AddUntilStep or not wait
2023-05-04 13:18:25 +09:00
Bartłomiej Dach
59ece64d25
Merge branch 'master' into skin-editor-change-handler-improvement
2023-05-03 19:42:42 +02:00
cdwcgt
4549a865d9
Merge branch 'master' into export
2023-05-04 00:18:01 +09:00
cdwcgt
c609e6345c
remove Use Current Mods menu item
2023-05-03 23:02:50 +09:00
cdwcgt
3a15783a3c
remove wait, use AddUntilStep
2023-05-03 22:59:01 +09:00
cdwcgt
25bf4e68ec
remove useless wait
2023-05-03 22:53:13 +09:00
Cootz
f0d35eb12b
Update testing
2023-05-03 13:12:11 +03:00
Dean Herbert
b932e4d986
Rename DrawableUsername to DrawableChatUsername and only pass message ID
2023-05-03 18:53:22 +09:00
Dean Herbert
4f55afb60d
Merge branch 'master' into chat-report
2023-05-03 18:50:38 +09:00
Dean Herbert
384693a431
Fix test failure in MultiplayerMatchSongSelect due to multiple overlays present
...
https://github.com/ppy/osu/actions/runs/4868337922/jobs/8681736995?pr=23308 .
2023-05-03 14:30:58 +09:00
Dean Herbert
6b017ac05f
Merge pull request #23308 from OliBomby/sample-control-points
...
Remove SampleControlPoint and DifficultyControlPoint from HitObject
2023-05-03 14:21:51 +09:00
Dean Herbert
e394b487e0
Merge branch 'master' into edit-mods-preset
2023-05-03 12:06:16 +09:00
Dean Herbert
e42b0cc5b1
Merge pull request #23370 from peppy/fix-editor-playfield-padding
...
Add more padding around playfield in editor to avoid overlap with tool areas
2023-05-03 11:44:55 +09:00
Bartłomiej Dach
95badb9455
Adjust composer tests to new screen layout
...
`TestSceneHitObjectComposer.TestPlacementFailsWhenClickingButton()` was
attempting to cover the case of the user clicking a toolbox button which
was in front of the playfield, and ensure that the click did not result
in a placement. However, since the paddings in
67f83f246b
2023-05-02 18:45:45 +02:00
Cootz
a6ca049739
Manually implement @bdach prototype
2023-05-02 14:15:33 +03:00
Dean Herbert
94ae9d7664
Merge pull request #23357 from OliBomby/fix-reverse-crash
...
Prevent infinite repeat count when adjusting repeats of 0 length slider
2023-05-02 19:53:26 +09:00
Andrei Zavatski
ba5088f71a
Add missing ruleset shader tests
2023-05-02 11:55:05 +03:00
Andrei Zavatski
8160d56264
Update test shaders
2023-05-02 11:51:05 +03:00
Dean Herbert
1e4a628cb1
Merge pull request #23284 from Hy0tic/multiplier-doesnt-update-with-preset-mod
...
Fix issue where multiplier show wrong value when adjusting speed on preset
2023-05-02 14:59:41 +09:00
Dean Herbert
e3c384c6b5
Merge branch 'master' into sample-control-points
2023-05-02 14:38:39 +09:00
Dean Herbert
983a8f7dfe
Merge branch 'master' into fix-reverse-crash
2023-05-02 13:14:34 +09:00
Dean Herbert
87db891143
Adjust test to reliabily fail
2023-05-02 13:12:11 +09:00
Bartłomiej Dach
1fb4c814f4
Remove no longer needed API call mocking
...
The online ID will be reset unconditionally after any local change is
made to any beatmap. That behaviour no longer depends on online lookups
succeeding or failing.
This may change at a later date when beatmap submission is integrated
into lazer - the idea is that online IDs would get re-populated on local
beatmaps once they are submitted to web.
2023-05-01 19:08:41 +02:00
Bartłomiej Dach
8ab3a87b13
Add failing test case covering online ID reset on save
...
This test scene passes at e58e1151f3e72f103c17
2023-05-01 18:17:35 +02:00
OliBomby
dbb2a8980b
add test
2023-05-01 15:56:23 +02:00
Terochi
4d52ce769b
Revert SaveState() calling on initialization
2023-05-01 12:53:58 +02:00
OliBomby
608fa3cc73
Merge remote-tracking branch 'upstream/master' into sample-control-points
2023-04-30 19:47:03 +02:00
Bartłomiej Dach
7cedbca9be
Merge branch 'master' into multiplier-doesnt-update-with-preset-mod
2023-04-30 17:36:00 +02:00
Bartłomiej Dach
d35355970f
Add test case covering failure scenario
2023-04-30 17:23:45 +02:00
Terochi
8f02bd80f9
Addressed changes
2023-04-30 16:11:52 +02:00
Terochi
949dc1c0f9
Improved logic
2023-04-30 12:05:55 +02:00
Terochi
585318400c
Refactor tests
2023-04-30 02:32:20 +02:00
Terochi
9a9e02b110
Added tests
2023-04-30 02:00:35 +02:00
OliBomby
a6e780a1b9
Update CheckMutedObjectsTest.cs
2023-04-29 23:52:30 +02:00
Dean Herbert
2643100644
Add xmldoc to new test mentioning failure rate and general purpose
2023-04-29 11:05:10 +09:00
Dean Herbert
32f8c674f4
Extract beatmap retrieval method for more legibility
2023-04-29 11:01:29 +09:00
Dean Herbert
a6f0186112
Improve legibility and code quality of new test
2023-04-29 10:51:56 +09:00
Dean Herbert
428b5fad3c
Rename test scene to explicitly mention navigation testing
2023-04-29 10:51:56 +09:00
Cootz
d9b3c97179
Fix testing
2023-04-29 10:29:33 +09:00
Cootz
c5357d30ab
Add test
2023-04-29 10:29:33 +09:00
Bartłomiej Dach
07efa7d660
Merge branch 'master' into fix-storyboard-loop-end-time
2023-04-26 21:53:26 +02:00
OliBomby
354cd23874
removed all usage of hitobject's DifficultyControlPoint
2023-04-26 18:17:02 +02:00
OliBomby
c44f71a737
remove all regular usage of DifficultyControlPoint
2023-04-26 17:55:38 +02:00
OliBomby
9f8d7bccba
fix usings
2023-04-26 17:34:02 +02:00
OliBomby
c6fc180659
remove all test usages of SampleControlPoint
2023-04-26 14:21:52 +02:00
Dean Herbert
27f81288ef
Merge branch 'master' into keep-shared-settings-ruleset-change
2023-04-26 15:51:31 +09:00
Dean Herbert
6a3b587374
Merge pull request #23260 from Haspamelodica/master
...
Fix some videos with uppercase file extensions not displaying correctly in-game
2023-04-26 14:29:25 +09:00
Terochi
0841e73a39
Improved readability and sounds
2023-04-25 21:07:17 +02:00
Bartłomiej Dach
196b5b41eb
Also disable counting on argon display in test
...
Mostly for my own peace of mind.
2023-04-25 20:17:57 +02:00
Bartłomiej Dach
753fa09356
Fix test failures due to type mismatch
2023-04-25 20:10:11 +02:00
Daniel Kirschten
54e8aa8fe9
Merge branch 'master' into master
2023-04-25 16:04:02 +02:00
Dean Herbert
0c3a015953
Fix key counter test not testing the full binding of IsCounting
2023-04-25 21:37:19 +09:00
Dean Herbert
d8b4db3a13
Merge branch 'master' into gameplay/argon-key-counter_le-retour
2023-04-25 19:54:31 +09:00
Dean Herbert
e330052852
Add second definition of EndTime for storyboard elements to account for loops in lifetime
2023-04-25 15:22:11 +09:00
Dean Herbert
dce0c5fac8
Add test coverage of expected behaviour for playback of loops with no explicit end time
2023-04-25 15:14:32 +09:00
Haspamelodica
3166f88c17
Removed unneccessary using directive
2023-04-21 10:11:47 +02:00
Haspamelodica
e9fb836e9c
Added tests for video backgrounds
2023-04-21 03:24:11 +02:00
Dean Herbert
01260e5f54
Merge branch 'master' into shader-cache-stages
2023-04-19 20:47:34 +09:00
Dean Herbert
26a2d1fdea
Merge pull request #23000 from Joehuu/fix-beatmap-terminology
...
Fix song select matching label not using right terminology
2023-04-18 13:53:05 +09:00
Joseph Madamba
c80a25328d
Shorten label to just "matches"
2023-04-17 20:59:41 -07:00
Dan Balasescu
c0a25144cf
Apply changes to custom ShaderManager
2023-04-18 11:31:56 +09:00
Bartłomiej Dach
0cc92ce5f9
Add failing test case
...
Covering nested object reverts not firing the parent's `RevertResult`
event in accordance with what the xmldoc of the event states.
2023-04-11 18:24:34 +02:00
Joseph Madamba
d0cbe206a9
Revert back to one number with "matching beatmap difficulties" label
2023-04-10 23:37:29 -07:00
Dean Herbert
52bb7891f7
Merge branch 'master' into fix-count-not-updating-when-deleting
2023-04-11 09:04:02 +09:00
Bartłomiej Dach
1f2c96c8e8
Merge branch 'master' into gd-onlinesetoverlay
2023-04-10 15:35:03 +02:00
Bartłomiej Dach
6e08105e2c
Remove usage of "diff" vernacular
2023-04-10 15:27:10 +02:00
Joseph Madamba
bfb7ead689
Add failing text box beatmap difficulty count test
2023-04-09 22:12:50 -07:00
cdwcgt
dd69089117
code quality
2023-04-09 15:51:31 +09:00
cdwcgt
def6da98fc
fix test in #22653
2023-04-09 15:43:05 +09:00
cdwcgt
52fc6de13f
merge fix
...
wtf?
2023-04-09 15:12:15 +09:00
cdwcgt
ce6a87b4a3
Merge remote-tracking branch 'upstream/master' into export
2023-04-09 15:02:47 +09:00
cdwcgt
de21b4a2f7
use Live<TModel>
...
Use RealmAccess only when needed
2023-04-09 22:21:15 +09:00
Joseph Madamba
ed208ef127
Fix more typos and adjust font size to match web
2023-04-07 21:10:37 -07:00
Dean Herbert
0c71fa1bbd
Merge branch 'master' into gameplay/argon-key-counter_le-retour
2023-04-06 23:39:57 +09:00
Dean Herbert
e6872629f3
Merge pull request #22868 from peppy/no-epilepsy-warning-storyboard-disable
...
Don't show epilepsy warning when storyboards are disabled
2023-04-06 12:32:38 +09:00
tsrk
809b817e8e
Merge branch 'master' into gameplay/argon-key-counter_le-retour
2023-04-05 22:57:36 +02:00
Bartłomiej Dach
ba753a8aac
Merge branch 'master' into update-skinnable-sound-before-playing
2023-04-05 22:56:25 +02:00
Bartłomiej Dach
27055919a3
Merge branch 'master' into fix-old-beatmap-crash-on-load
2023-04-05 21:39:42 +02:00
Bartłomiej Dach
6df7614b9d
Add tests for suppressing epilepsy warning when storyboard disabled
2023-04-05 20:56:50 +02:00
Bartłomiej Dach
02c6126be7
Ensure storyboards are enabled in existing epilepsy warning tests
2023-04-05 20:53:54 +02:00
Bartłomiej Dach
432f698697
Merge branch 'master' into gameplay/key-counter-abstraction
2023-04-05 19:45:14 +02:00
Bartłomiej Dach
8cc425774b
Merge branch 'master' into fix-replay-fail-on-exit
2023-04-03 21:23:23 +02:00
Bartłomiej Dach
b5d9284de2
Merge pull request #23108 from peppy/fix-overlay-toggles-during-disclaimer
...
Fix attempting to show overlay during game intro playing hide sound effects
2023-04-03 20:48:03 +02:00
cdwcgt
9e0277b2fd
useless using
2023-04-04 00:19:14 +09:00
cdwcgt
735b48679e
use LinkFlowContainer directly
2023-04-03 20:09:49 +09:00
Dean Herbert
6239789188
Fix missing using statements in multiple test scenes
2023-04-03 15:37:10 +09:00
Dean Herbert
b0c09df259
Merge branch 'master' into gameplay/key-counter-abstraction
2023-04-03 15:33:35 +09:00
Dean Herbert
43d7386623
Merge pull request #22926 from Joehuu/fix-sort-direction-not-resetting
...
Fix beatmap listing sort direction not resetting when changing criteria
2023-04-03 15:32:10 +09:00
Dean Herbert
a097433cb1
Fix overlay toggle keys working during disabled activation modes
...
Closes #23104 .
2023-04-03 15:03:47 +09:00
cdwcgt
2cf8636366
show guest diff author in BeatmapPicker
2023-04-02 22:25:58 +09:00
Dean Herbert
e66569b394
Update ruleset dependency tests in line with nullable changes
2023-04-02 21:04:44 +09:00
Dean Herbert
9b45591c2f
Add failing test coverage of saving failed replay causing progression to results
2023-03-29 14:00:11 +09:00
cdwcgt
f01247f1ab
test
2023-03-28 21:41:00 +09:00
cdwcgt
899860dd77
Merge branch 'master' into chat-report
2023-03-28 21:14:11 +09:00
Dean Herbert
d31b37e87e
Merge branch 'master' into fix-ubo-not-bound
2023-03-26 16:14:11 +09:00
Joseph Madamba
e1906a90eb
Use image@2x from tournament banner api
2023-03-25 13:08:46 -07:00
cdwcgt
26f2d9047d
code style fix
2023-03-23 01:11:44 +09:00
cdwcgt
8518d15b8d
use endpoint
2023-03-23 01:00:38 +09:00
Dean Herbert
ad5bdf6511
Merge branch 'master' into fix-ubo-not-bound
2023-03-22 16:46:39 +09:00
Dean Herbert
db227b1798
Merge branch 'master' into chat-report
2023-03-22 16:26:28 +09:00
Terochi
1478a26cc0
Addressed changes
2023-03-21 23:15:49 +01:00
Joseph Madamba
df3ccdff9f
Add failing beatmap listing sort direction on criteria change test
2023-03-21 15:08:37 -07:00
Bartłomiej Dach
9ff9cd3b7f
Merge branch 'master' into skin-editor-cyclic-selection
2023-03-21 19:49:55 +01:00
Dean Herbert
fb51221c2b
Add test coverage of cyclic selection triggering when more than one item is selected
2023-03-21 21:31:10 +09:00
Salman Ahmed
678e8ed736
Update UBO usages inline with framework changes
2023-03-16 14:06:35 +03:00
cdwcgt
d025c441ca
delay mod save after click save or not popover hidden
2023-03-16 19:48:45 +09:00
Cootz
556964eae0
Merge branch 'master' into BitmapUpdatesOnScore
2023-03-16 12:16:42 +03:00
Dean Herbert
a81408ca06
Add failing test coverage showing that replay will fail on exiting gameplay
2023-03-16 17:12:46 +09:00
Dean Herbert
159c8833c7
Add test coverage of SkinnableSound not updating in time when not present
2023-03-16 15:41:05 +09:00
Dean Herbert
5378cdff20
Apply NRT to TestSceneSkinnableSound
2023-03-16 15:10:35 +09:00
Dean Herbert
5f9b13a775
Rename Add/AddRange methods as they are no longer conflicting with Container
2023-03-15 18:02:41 +09:00
Dean Herbert
8908648f97
Fix super-dodgy cast of IEnumerable to Drawable
2023-03-15 18:01:22 +09:00
Dean Herbert
0a19b1e9cf
Merge pull request #22860 from rozukke/fix-skin-ini-import
...
Fix import of skins with non-ASCII names that have been previously exported by lazer
2023-03-15 15:36:51 +09:00
Dean Herbert
1cf870d956
Add test coverage and fix fail case where a drag selection ends incorrectly with cyclic selection
2023-03-15 15:16:48 +09:00
Dean Herbert
3c4e2d8700
Add tests covering drag selection
2023-03-14 21:04:51 +09:00
Dean Herbert
6546f5968a
Merge branch 'master' into skin-editor-cyclic-selection
2023-03-14 20:43:56 +09:00
Dean Herbert
b5ea855b6c
Fix failing DrawableRulesetDependencies test
2023-03-14 20:37:50 +09:00
Dean Herbert
969c0e9c9d
Merge branch 'master' into veldrid-renderer
2023-03-14 17:35:38 +09:00
rozukke
4570c0030f
Add test to check for import of exported skin with non-ASCII name
2023-03-13 23:37:45 +11:00
Dean Herbert
c35c81293a
Add test coverage ensuring images specified as videos are used as background image instead
2023-03-13 18:24:16 +09:00
Dean Herbert
3aea058c98
Add test coverage ensuring images are not read as videos
2023-03-13 18:24:16 +09:00
Dean Herbert
12f240e11a
Apply simple NRT changes to touched test scenes
2023-03-13 18:24:16 +09:00
Terochi
8e8dda3ac0
Big simplifying
2023-03-11 23:29:36 +01:00
cdwcgt
15f11bb1e8
scorll container and save mod after popover hidden
...
Requires manual handling of many visual effects
2023-03-11 12:31:33 +09:00
Terochi
b51c41a804
Addressed changes
2023-03-09 20:14:58 +01:00
cdwcgt
f4e2620402
fix test
2023-03-10 00:56:22 +09:00
cdwcgt
d009cd8422
test
2023-03-09 22:49:45 +09:00
tsrk
d806b85a30
revert: make counters an IEnumerable again
...
As suggested by bdach as this would make the last two commits useless
Refs: 5d15426
2023-03-09 10:25:03 +00:00
Bartłomiej Dach
ab87f5e0c9
Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
2023-03-08 22:37:09 +01:00
tsrk
44297a7d0a
refactor: make KCD a CompositeDrawable
2023-03-08 00:47:16 +00:00
Bartłomiej Dach
72695f7c90
Merge branch 'master' into omit-barline-in-timing-control-point
2023-03-07 22:46:24 +01:00
Terochi
9ea93e0a9f
Add more tests
2023-03-07 20:38:33 +01:00
Bartłomiej Dach
cfafa8af8c
Merge branch 'master' into hud/player-components
2023-03-07 19:44:12 +01:00
Terochi
bedf4cc259
Remove extra code
2023-03-07 16:03:11 +01:00
Cootz
5d41d343fd
Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
2023-03-07 15:46:52 +03:00
cdwcgt
54564e0557
new design
2023-03-07 21:13:35 +09:00
Dean Herbert
28520414aa
Move KeyCounter components to HUD namespace
2023-03-07 16:41:39 +09:00
Dean Herbert
15d65059b5
Tidy up Add method logic
2023-03-07 16:21:57 +09:00
Dean Herbert
8f6df5ea0f
Merge branch 'master' into gameplay/key-counter-abstraction
2023-03-07 16:09:45 +09:00
Dean Herbert
d2fcdf6e0e
Add test coverage of cyclic selection in skin editor
2023-03-07 15:11:47 +09:00
tsrk
952814604e
style: fix late night oopsies
2023-03-06 20:06:56 +00:00
cdwcgt
0095fd85ca
remove == true
2023-03-07 02:18:34 +09:00
cdwcgt
4858d3fd42
Added ability to edit mod presets
2023-03-07 02:00:40 +09:00
Bartłomiej Dach
ec15e2b9cc
Merge branch 'master' into dont-filter-results-on-sort-mode
2023-03-06 17:57:47 +01:00
tsrk
ddee6400df
test: add coverage for Player{Avatar,Flag}
2023-03-05 23:46:51 +00:00
Bartłomiej Dach
9d4bb2ecf7
Add failing test coverage for clearing sidebar contents
2023-03-04 14:08:50 +01:00
Bartłomiej Dach
2f25fb4083
Move NonSkinnableScreenPlaceholder to outer scope
2023-03-04 13:22:43 +01:00
Bartłomiej Dach
3dd3b5e77a
Add failing test case
2023-03-04 13:17:54 +01:00
Cootz
322f3e86ba
Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
2023-03-03 20:02:09 +03:00
Dean Herbert
a14dede036
Ensure TestBeatmapCarousel.Items only returns actually visible items (and in correct order)
...
Turns out that items could be in an order that isn't the same as how
things look on the carousel, so this change ensures that for testing
purposes they are sorted by Y position.
Also uses the `CarouselItem.Visible` flag to ensure that we don't have
to wait for drawable fade transitions after a filter operation.
2023-03-03 17:18:34 +09:00
Dean Herbert
7a092ea995
Add better coverage and more comments explaining the structure of test setup
2023-03-03 17:18:14 +09:00
Dean Herbert
82293c0c86
Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes
...
From a user's perspective, changing a sort / order mode shouldn't filter
away results, but we were doing this.
In terms of UX expectations, in stable this kind of scenario would
results in a group being added to the end of son select with "Not
ranked" or "Unknown". I think we should aim to match this eventually.
2023-03-03 16:36:18 +09:00
Dean Herbert
bd11d5d29a
Merge pull request #22743 from Joehuu/scroll-back-to-previous
...
Add ability to scroll back to previous position after scrolling to top via button on overlays
2023-03-01 22:55:47 +09:00
Dean Herbert
1250c1f0c1
Update test assertions to match stable expectations
...
These changes were taken from https://github.com/ppy/osu/pull/22582 .
Minor adjustments were applied to match stable expectations, which is to
say there cannot be an inherited control point with omit barline
specification (in the editor the setting is greyed out when inheritance
is turned on).
2023-02-28 19:28:21 +09:00
Dean Herbert
2615453b31
Rename SettingSource tests to match attribute name
2023-02-28 11:45:32 +09:00
Bartłomiej Dach
92edb0f868
Merge branch 'master' into skin-editor-depth-changing
2023-02-27 19:24:53 +01:00
Joseph Madamba
fa710ae1b0
Rename ScrollToTopButton to ScrollBackButton
2023-02-26 14:39:34 -08:00
Joseph Madamba
d98d330da2
Add expected behavior test for scroll back to previous position
2023-02-26 14:30:46 -08:00
Dan Balasescu
dd9748a25c
Adjust DrawNodes to use UBOs
2023-02-25 01:42:55 +09:00
Terochi
09e7c21b23
Implemented a more complex setting conversion logic + tests
2023-02-24 15:11:22 +01:00
tsrk
6307b3948a
style: use Trigger initialisation
2023-02-22 17:59:39 +00:00
Bartłomiej Dach
d679703fa2
Merge pull request #22659 from peppy/fix-taiko-drum-nested-sample-detection
...
Fix `GameplaySampleTriggerSource` not considering nested objects when determining the best sample to play
2023-02-22 18:56:59 +01:00
tsrk
1beec71037
refactor(KeyCounterDisplay): apply suggestions
...
I also took the freedom to add type checking, as we can't limit the
usage of `Add()` since it's a Container. The exception thrown also
advises of using the suggested `AddTrigger()` instead.
2023-02-22 14:58:27 +00:00
Dean Herbert
a8c692a215
Merge pull request #22635 from peppy/use-overlays-container-more
...
Use `Overlays` container rather than `KeyBindingInputManager` for flashlight
2023-02-22 18:30:21 +09:00
Dean Herbert
32a9c066df
Add test coverage of bring-to-front / send-to-back operations
2023-02-22 18:17:20 +09:00
Dean Herbert
90ca635a17
Fix weird nullability in TestSceneSkinEditor
2023-02-22 18:17:20 +09:00
Dean Herbert
f61fbcf3fc
Update assertion to also check GameplayClockContainer's current time
2023-02-22 15:26:09 +09:00
Dean Herbert
a511e64fa5
Seek using GameplayClockContainer
2023-02-22 14:41:20 +09:00
Bartłomiej Dach
d59d153654
Fix test compile failures from Audio hoisting
2023-02-21 21:03:00 +01:00
Terochi
dd53a70071
Addressed change requests
2023-02-21 21:01:31 +01:00
Bartłomiej Dach
3d2fcb0cca
Merge branch 'master' into fix-taiko-drum-nested-sample-detection
2023-02-21 20:53:06 +01:00
Bartłomiej Dach
ec1bf7b0b2
Merge branch 'master' into skin-editor-clipboard
2023-02-21 19:35:58 +01:00
Terochi
191604340f
Added a way for mod settings to be kept when changing ruleset + test
2023-02-21 19:05:10 +01:00
Cootz
1fa6864500
Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
2023-02-21 18:47:59 +03:00
Cootz
90aa4288d0
Reduce the allowed length by 5 to account for (99) suffix. Move truncating logic to GetFilename. Update tests.
2023-02-21 18:35:53 +03:00
mk56-spn
299023fce0
Improve visibility of wedge shading in test scene and fix an issue with excessive roundness on said shadow.
2023-02-21 16:07:26 +01:00
Dean Herbert
9321ec29dc
Update slider sample source asserts to match expected behaviour
...
As pointed out in review, if the current time is after the end of the
slider, the correct hit object to use for sample retrieval is the object
itself, not any nested object.
2023-02-21 14:04:38 +09:00
Dean Herbert
e686b4393e
Add wait steps to ensure frame-stable clock has caught up before checking state
2023-02-21 14:04:19 +09:00
Dean Herbert
5ba6059911
Merge branch 'master' into fix-taiko-drum-nested-sample-detection
2023-02-21 13:58:15 +09:00
Bartłomiej Dach
c9999bdeb1
Merge branch 'master' into skin-per-ruleset-layouts
2023-02-20 20:14:38 +01:00
Bartłomiej Dach
3183f5cee2
Merge branch 'master' into revert-result-in-playfield
2023-02-19 16:33:10 +01:00
Cootz
5fa75805cc
Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
2023-02-18 15:52:17 +03:00
Bartłomiej Dach
704dddf14b
Merge branch 'master' into skin-editor-clipboard
2023-02-17 22:59:18 +01:00
Bartłomiej Dach
6b9472c367
Merge branch 'master' into skin-per-ruleset-layouts
2023-02-17 22:58:38 +01:00
Bartłomiej Dach
6afa65bd3d
Merge branch 'master' into skinnable-clean-up-documentation
2023-02-17 20:59:18 +01:00
cdwcgt
e84e011d5d
Merge branch 'master' into export
2023-02-17 22:15:19 +09:00
Dean Herbert
9793774377
Update SkinDeserialisationTest to work with new serialisation structure
2023-02-17 16:22:48 +09:00
Dean Herbert
6b3652f567
Change serialisation format of skin layouts to allow more flexibility
...
Also adds per-ruleset storage for each container type.
2023-02-17 14:19:19 +09:00
Dean Herbert
372b6b794c
I don't know what .ots is but let's not use random file extension that make no sense
2023-02-17 13:46:27 +09:00
Dean Herbert
8ef3fb26e0
More constants and assert fixes
2023-02-17 13:46:27 +09:00
Dean Herbert
86d110e893
Simplify test storage by removing nested storage
2023-02-17 13:43:42 +09:00
Dean Herbert
4560ae6b02
Mark test as fixture
2023-02-17 13:39:31 +09:00
Dean Herbert
99236f0ae8
Move long filename to fixture level
2023-02-17 13:39:24 +09:00
Dean Herbert
96b1498932
Rename max length variable to make sense (it's a filename limit, not path)
2023-02-17 13:33:22 +09:00
Dean Herbert
415220a447
Tidy up new test method code quality
2023-02-17 13:30:00 +09:00
Cootz
810712386d
Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
2023-02-17 01:51:24 +03:00
Cootz
f4038a49a1
Fix inspectCode issues
2023-02-17 01:50:24 +03:00
Cootz
1d8b348e4c
Improve naming
2023-02-17 01:46:15 +03:00
Cootz
6cb00cd42f
Add more test cases
2023-02-17 01:44:45 +03:00
tsrk
ddd6c1a1c6
refactor(KeyCounter): address bindables issues
...
`IsCounting` is back being an auto-property.
`countPresses` is now encapsulated and being exposed as an
`IBindable<int>` via `CountPresses`
2023-02-16 22:20:34 +00:00
Bartłomiej Dach
3ee046000e
Merge branch 'master' into revert-result-in-playfield
2023-02-16 21:54:29 +01:00
Bartłomiej Dach
2fdf1fd876
Merge branch 'master' into fix-taiko-drum-nested-sample-detection
2023-02-16 19:43:02 +01:00
Bartłomiej Dach
5bdc5dfadd
Add one more assert to keep coverage from previous implementation
2023-02-16 19:02:51 +01:00
Cootz
6819a45a1b
Improve code slightly
2023-02-16 16:42:07 +03:00
Cootz
f1da213bea
Add tests
2023-02-16 16:26:57 +03:00
Dean Herbert
b59ec551f6
Add test coverage of GameplaySampleTriggerSource not considering nested objects
2023-02-16 18:21:33 +09:00
Dean Herbert
979c079f8b
Refactor GameplaySampleTriggerSource test to not be realtime dependent
2023-02-16 17:58:44 +09:00
Dean Herbert
9d02a2ef0e
Apply NRT to GamepleSampleTriggerSource tests
2023-02-16 17:58:44 +09:00
Dean Herbert
2fbaf88a3c
Add clipboard dependency to SkinEditor specific tests
...
This is usually provided by the `SkinEditorOverlay`, which is not always
present in tests.
2023-02-16 15:24:38 +09:00
tsrk
74e7cc2056
feat: implement new design of key counter
2023-02-15 22:18:02 +00:00
tsrk
076eb81b21
refactor: rename trigger classes
...
Makes it better to understand their purpose
2023-02-15 21:46:13 +00:00
tsrk
157bba7830
refactor: rename Trigger class to InputTrigger
2023-02-15 21:41:36 +00:00
Dean Herbert
a92e42bb84
Rename SkinnableTargetContainer to SkinComponentsContainer
...
Also use full `SkinComponentsContainerLookup` instead of the sub-type.
This will potentially be useful once we bring in per-ruleset targets.
2023-02-15 18:37:41 +09:00
Dean Herbert
b1cf6d83d8
Move extension methods closer to serialisation classes
2023-02-15 18:37:41 +09:00
Dean Herbert
d159d6b970
Rename ISkinnableDrawable to ISerialisableDrawable
2023-02-15 18:37:41 +09:00
Dean Herbert
856efd9fd9
Rename SkinnableDrawableInfo to SerialisedDrawableInfo
2023-02-15 18:23:19 +09:00
