smoogipoo
702bd2b65d
Fix potential nullref in test
2020-06-11 13:41:53 +09:00
Dean Herbert
880a127228
Use async overload
2020-06-10 00:08:48 +09:00
smoogipoo
ab10732a78
Remove usages of null-forgiving operator
2020-06-09 22:13:48 +09:00
smoogipoo
88aed1d504
Merge branch 'master' into update-inspectcode-version
2020-06-09 20:12:39 +09:00
smoogipoo
05b1edb9d8
Fix incorrect beatmap showing
2020-06-09 19:01:02 +09:00
smoogipoo
4fd5ff61eb
Add loading spinner
2020-06-09 18:53:55 +09:00
smoogipoo
7f05c16c9f
Merge branch 'master' into timeshift-results-2
2020-06-09 15:59:13 +09:00
Dean Herbert
9d68a95f3f
Merge branch 'master' into multi-room-load-spinner
2020-06-09 10:56:56 +09:00
smoogipoo
8a021e0beb
Use save method in test
2020-06-08 22:35:01 +09:00
Dean Herbert
b41384dde8
Merge branch 'master' into multiplayer-beatmap-checksum
2020-06-07 18:05:33 +09:00
Dan Balasescu
2ad5b2065f
Merge branch 'master' into better-reimport-support
2020-06-05 20:59:55 +09:00
smoogipoo
bb89114b70
Show a loading spinner on multiplayer lounge loads
2020-06-05 20:52:27 +09:00
smoogipoo
caf94df0d0
Merge branch 'master' into multiplayer-beatmap-checksum
2020-06-05 19:16:05 +09:00
Salman Ahmed
495f89ddae
Expand number text box test scene to one holding all OsuTextBox's types
2020-06-05 06:45:42 +03:00
smoogipoo
9c1542f897
Fix crash when pressing clear button twice
2020-06-04 22:17:00 +09:00
Salman Ahmed
741fa20149
Use CreateRuleset() for editor test scenes as well
2020-06-04 00:47:10 +03:00
Salman Ahmed
84b40ea2c6
Merge remote-tracking branch 'upstream/master' into test-scene-create-ruleset
...
# Conflicts:
# osu.Game.Rulesets.Catch.Tests/TestSceneBananaShower.cs
# osu.Game.Rulesets.Catch.Tests/TestSceneHyperDash.cs
# osu.Game/Tests/Visual/ModTestScene.cs
# osu.Game/Tests/Visual/OsuTestScene.cs
2020-06-03 22:00:02 +03:00
Dean Herbert
66ec2afe5c
Remove broken import test
2020-06-03 23:38:40 +09:00
Dean Herbert
5ed3cd205f
Simplify reuse check using FileInfo IDs
2020-06-03 23:35:56 +09:00
Dean Herbert
25160dc220
Fix test name
2020-06-03 19:15:52 +09:00
Dean Herbert
012933545e
Add test coverage
2020-06-03 18:33:41 +09:00
Dean Herbert
3c7e5a5b42
Fix ChannelManager not being loaded in tests
2020-06-03 18:00:31 +09:00
smoogipoo
8aa8d2c880
Resolve NREs
2020-06-03 16:59:37 +09:00
smoogipoo
f3b5149648
Move some suggestions to warnings, resolve issues
2020-06-03 16:48:44 +09:00
Dan Balasescu
8131137fea
Merge branch 'master' into fix-results-crash
2020-06-03 15:19:30 +09:00
smoogipoo
13622eff1f
Fix response value
2020-06-03 12:54:07 +09:00
Dean Herbert
5740fc2bd0
Merge pull request #9168 from Game4all/fix-ruleset-no-autoplay
...
Fix crash after using Ctrl+Enter when current ruleset doesn't have an autoplay mod
2020-06-03 12:50:57 +09:00
Shane Woolcock
0d5a2cf96d
Add unit tests
2020-06-03 11:36:59 +09:30
Shivam
4ebc1d3721
Add original sprite and visualiser
...
Notes: This is using a modified version of welcome.osz to facilitate the visualiser and the animation of the sprite is not accurate.
2020-06-02 21:06:41 +02:00
smoogipoo
c7c94eb3fd
Initial implementation of timing distribution graph
2020-06-02 23:38:50 +09:00
Dan Balasescu
427dbf7f58
Merge branch 'master' into update-framework
2020-06-02 20:54:50 +09:00
Lucas A
f63c66396f
Apply review suggestions.
2020-06-02 13:32:52 +02:00
Shivam
574e8444b0
Merge branch 'master' into fallback-intro
2020-06-02 13:15:58 +02:00
Shivam
888b90b426
Rename IntroFallback classes to IntroLegacy
...
This commit also renames files accordingly with https://github.com/ppy/osu-resources/pull/103
2020-06-02 13:14:50 +02:00
smoogipoo
dfb9687fb5
Extract update into PreUpdate(), add test
2020-06-02 17:22:09 +09:00
smoogipoo
fac96f6ddd
Fix match beatmap not updating after re-download
2020-06-02 17:02:01 +09:00
Dean Herbert
64550fe87c
Merge branch 'master' into fix-draining-in-between-break-sections
2020-06-02 16:06:08 +09:00
Dean Herbert
70c84811ed
Revert incorrect change
2020-06-02 15:50:36 +09:00
Dean Herbert
800c46f752
Fix test function override
2020-06-02 14:39:15 +09:00
smoogipoo
3c85561cdc
Add tests
2020-06-02 14:31:43 +09:00
Dean Herbert
c59d750420
Merge branch 'replace-use-of-current-directory' into update-framework
2020-06-02 14:31:09 +09:00
Shivam
578c955658
Add fallback intro screen
2020-06-02 03:48:23 +02:00
Salman Ahmed
7a9ed78527
Remove missed leftover usages
2020-06-01 11:57:32 +03:00
Dan Balasescu
64d1b4b11b
Merge branch 'master' into move-setter-to-duration
2020-06-01 15:55:48 +09:00
Salman Ahmed
2c6887e610
Remove unnecessary use of and remove StartupStorage
2020-05-31 19:49:03 +03:00
Dean Herbert
0ef971be28
Merge branch 'master' into i-has-curve-with-repeats
2020-05-31 22:30:18 +09:00
Salman Ahmed
82fe99cf4a
Replace any potential usage of Environment.CurrentDirectory with a new RuntimeInfo.StartupDirectory
...
Using `Environment.CurrentDirectory` for storing / reading files is dangerous as the current directory is mutable and can be changed when performing a certain operation (like opening solutions in roslyn type reference builder for example).
2020-05-31 02:24:49 +03:00
Dean Herbert
d4b7c81f96
Merge branch 'master' into results-screen-condensed-panel
2020-05-30 23:13:52 +09:00
Dean Herbert
e8b43e8e1f
Merge branch 'master' into move-setter-to-duration
2020-05-29 16:04:23 +09:00
smoogipoo
a606f41297
Add button to open results
2020-05-28 22:25:00 +09:00
smoogipoo
0f373acacb
Add test scene
2020-05-28 22:09:11 +09:00
smoogipoo
013461377e
Fix potential nullref
2020-05-28 21:46:02 +09:00
smoogipoo
ad99d85468
Resolve several positioning errors
2020-05-28 21:29:16 +09:00
smoogipoo
666cbd0f40
Allow selected score to be programmatically changed
2020-05-28 21:09:03 +09:00
smoogipoo
a55ce26130
Allow null score
2020-05-28 20:46:17 +09:00
Dean Herbert
f989f1aa00
Change event flow to avoid firing store delete events on update
2020-05-27 16:08:47 +09:00
Dean Herbert
cbd563e80b
Rename to IHasDuration
2020-05-27 12:38:39 +09:00
Dean Herbert
b8e0a6f127
Move sett from EndTime to Duration
2020-05-27 12:37:44 +09:00
Dean Herbert
6b5b215299
Split out IHasPath from IHasCurve to better define hitobjects
2020-05-26 17:44:47 +09:00
smoogipoo
a1ece4f308
Add expansion/contraction test
2020-05-26 16:26:58 +09:00
smoogipoo
aaf5596f9c
Cleanup test
2020-05-26 15:54:07 +09:00
smoogipoo
51e74687f8
Merge branch 'editor-scrolling-playfield-support' of https://github.com/peppy/osu ; branch 'results-screen-condensed-panel' of https://github.com/smoogipoo/osu into results-screen-condensed-panel
2020-05-26 15:39:39 +09:00
Dan Balasescu
2b7f86a1ae
Merge pull request #9111 from peppy/fix-dim-tests
...
Fix test failures on TestSceneUserDimBackgrounds
2020-05-26 14:45:22 +09:00
Dean Herbert
0cc6d6d97c
Merge pull request #9033 from smoogipoo/applydefaults-cancellation
...
Add cancellation token support to CreateNestedHitObjects()
2020-05-26 12:04:06 +09:00
Dean Herbert
2bf066d72c
Rename tests to match convention
2020-05-26 11:30:36 +09:00
Dean Herbert
13bd6be8a3
Convert wait steps into until steps
2020-05-26 11:29:56 +09:00
smoogipoo
bc35bc5efb
Merge branch 'master' into applydefaults-cancellation
2020-05-25 16:45:30 +09:00
smoogipoo
d5ea076427
Merge branch 'master' into results-screen-condensed-panel
2020-05-22 20:45:39 +09:00
smoogipoo
5005986049
Cleanup test
2020-05-22 20:18:47 +09:00
Dean Herbert
8b79e14225
Fix remaining test regressions
2020-05-22 19:49:49 +09:00
Dean Herbert
ffaec9f9f7
Merge branch 'master' into editor-clock-cache
2020-05-22 19:35:05 +09:00
Dean Herbert
866db629d6
Fix remaining test failures
2020-05-22 18:23:24 +09:00
Dean Herbert
f395ef24a4
Merge branch 'master' into editor-position-snap
2020-05-22 16:42:09 +09:00
Dan Balasescu
648fc3af41
Merge branch 'master' into bar-line-floating-point
2020-05-22 16:32:25 +09:00
Bartłomiej Dach
4299bd05b4
Add test cases for sequential scroll algorithm
2020-05-21 21:56:59 +02:00
Bartłomiej Dach
24d898c870
Demonstrate failure case in visual test scene
2020-05-21 21:56:55 +02:00
Bartłomiej Dach
8702a1b5a5
Fix test scene regression
2020-05-21 20:16:02 +02:00
smoogipoo
f5c80ac2d5
Remove vertical line
2020-05-21 22:07:24 +09:00
smoogipoo
45244683de
Fix scrolling (1-frame + maintain scroll position)
2020-05-21 22:07:06 +09:00
smoogipoo
d0f74c2b68
Refactor initial state
2020-05-21 20:48:25 +09:00
smoogipoo
9f868be872
Create common TestScoreInfo type
2020-05-21 18:39:22 +09:00
Dean Herbert
b1fd7da824
Merge branch 'master' into editor-position-snap
2020-05-21 15:47:20 +09:00
smoogipoo
1b8d657ead
Implement score panel list
2020-05-20 23:46:47 +09:00
Dean Herbert
c46bfc2532
Create SnapResult class to hold various snapping results
2020-05-20 21:00:47 +09:00
Dean Herbert
3354d48a38
Change snapping to be screen space coordinate based
2020-05-20 21:00:29 +09:00
smoogipoo
e5de382760
Merge branch 'master' into storyboard-overlay-layer
2020-05-20 15:08:45 +09:00
Bartłomiej Dach
6e27247cdf
Adjust storyboard decoder test in line with changes
2020-05-19 19:47:50 +02:00
Dan Balasescu
a075529f93
Merge branch 'master' into fix-outwards-event-bindings
2020-05-20 00:07:30 +09:00
Dean Herbert
eee8af28f6
Merge pull request #9018 from Game4all/allowgameplayoverlays-hide-skip
...
Allow disabling SkipOverlay through AllowGameplayOverlays.
2020-05-19 19:22:51 +09:00
Dean Herbert
052ad79fc6
Convert dangerous events to IBindables
2020-05-19 16:44:22 +09:00
smoogipoo
6d3ca4ec43
Fix failing tests
2020-05-19 13:16:46 +09:00
smoogipoo
f98ee27185
Fix referencing wrong child
2020-05-18 20:01:00 +09:00
smoogipoo
6d70f4b410
Merge branch 'master' into allowgameplayoverlays-hide-skip
2020-05-18 19:54:38 +09:00
smoogipoo
2fd25f5ee6
Fix tests
2020-05-18 19:54:26 +09:00
Bartłomiej Dach
bc6b64b1d7
Add failing test
2020-05-17 22:10:09 +02:00
smoogipoo
cfa5a81e78
Cleanup testscene
2020-05-16 18:33:21 +09:00
Dean Herbert
0279bcf3c8
Fix missed issues
2020-05-16 18:28:22 +09:00
Dean Herbert
be3a0a3c1d
Merge branch 'master' into remove-requiredtypes
2020-05-16 18:28:14 +09:00
smoogipoo
16cde20db4
Merge branch 'remove-requiredtypes' into results-screen-condensed-panel
2020-05-16 18:23:39 +09:00
smoogipoo
9b7b1ef605
Add cover urls
2020-05-16 18:23:18 +09:00
smoogipoo
3df92925ee
Add score panel test
2020-05-16 18:22:07 +09:00
smoogipoo
2bde4fc3ee
Initial implementation of contracted score panel
2020-05-16 18:20:19 +09:00
smoogipoo
648999a2de
Remove all RequiredTypes usages
2020-05-16 18:17:12 +09:00
Lucas A
ed9d6f2829
Fix CI inspection.
2020-05-15 22:58:15 +02:00
Lucas A
4096463d02
Move SkipOverlay internal alpha manipulation to a nested container and adjust visual tests.
2020-05-15 19:43:01 +02:00
smoogipoo
6cd1753459
Add overload to prevent crashes (bosu)
2020-05-15 18:51:44 +09:00
Dean Herbert
9ed0e8891b
Merge branch 'fix-nested-folder-migration-endless-copy' into migration-ui
2020-05-15 13:04:16 +09:00
Dean Herbert
aea192080a
Fix incorrect storage name
2020-05-15 13:02:46 +09:00
Dean Herbert
7641507c90
Ensure test directories are deleted before subsequent run
2020-05-15 10:45:57 +09:00
Dean Herbert
0690d81bbb
Add protection against migrating to a nested folder
2020-05-15 10:40:26 +09:00
Dean Herbert
19f117ae53
Update test logic for new exception type
2020-05-15 10:28:03 +09:00
Dean Herbert
364aa5aa12
Add protection against migrating to a nested folder
2020-05-14 22:45:03 +09:00
Dean Herbert
f3b1c32a85
Update test logic for new exception type
2020-05-14 20:18:57 +09:00
Dan Balasescu
fe7c5bbc8b
Merge branch 'master' into fix-failure-logic
2020-05-14 20:16:37 +09:00
Dean Herbert
a582611647
Add test coverage
2020-05-14 19:05:35 +09:00
Dan Balasescu
39f8f7ed78
Merge branch 'master' into directory-chooser
2020-05-14 15:23:52 +09:00
Dean Herbert
9de216f1b4
Merge branch 'master' into migration-backend
2020-05-13 20:15:22 +09:00
Dean Herbert
49e4fc6cba
Move to better namespace
2020-05-13 18:54:45 +09:00
Dean Herbert
2c83417c41
Switch to using DirectoryInfo/DriveInfo
2020-05-13 18:54:45 +09:00
Dean Herbert
8500f8fe76
Add basic implementation
2020-05-13 18:54:45 +09:00
Dean Herbert
de50b725d5
Fix mod failure checks executing actual game logic
2020-05-12 20:08:35 +09:00
Dean Herbert
e4a23b3e7d
Fix ignored excluding more than top level
2020-05-12 12:39:04 +09:00
Dean Herbert
bf719f98d5
Fix beatmap skins providing fallback version lookup, preceding user skins
2020-05-12 11:08:30 +09:00
Bartłomiej Dach
e650b10b5e
Add test case for maximal break
2020-05-11 19:03:41 +02:00
Dean Herbert
6c350db097
Add connection flushing support
2020-05-11 21:39:44 +09:00
Dean Herbert
36640f5dda
Merge branch 'master' into migration-backend
2020-05-11 18:52:36 +09:00
smoogipoo
ca6e6f7496
Add required parameter for android build
2020-05-11 17:26:11 +09:00
Dean Herbert
7f7d5e6617
Fix apparently required argument
2020-05-11 16:37:08 +09:00
Dean Herbert
93440874db
Refactor beatmap encoder test to be a bit easier to understand
2020-05-11 16:30:54 +09:00
Bartłomiej Dach
ee2ff77b89
Merge branch 'master' into fix-draining-in-between-break-sections
2020-05-10 17:57:44 +02:00
Dean Herbert
384862d48b
Fix incorrect relative paths when using GetStorageForDirectory
2020-05-10 13:20:13 +09:00
Dean Herbert
5dda94187e
Add more edge case testing
2020-05-09 20:13:44 +09:00
Dean Herbert
1348bdaa15
Merge branch 'custom-data-directory' into migration-backend
2020-05-09 19:32:29 +09:00
Dean Herbert
abb32b3256
Merge branch 'master' into custom-data-directory
2020-05-08 10:05:11 +09:00
Dean Herbert
5e65bda8d8
Add test coverage
2020-05-07 22:12:24 +09:00
Dean Herbert
4ac5ed71f4
Remove redundant string interpolation
2020-05-07 21:48:57 +09:00
Dean Herbert
90e17853a8
Update tests in line with framework changes
2020-05-07 18:12:11 +09:00
Dan Balasescu
0eae8d078b
Merge branch 'master' into master
2020-05-05 13:33:29 +09:00
alex
0e2ccac33b
Add spaces to comments
2020-05-04 18:36:24 -07:00
Dean Herbert
6621d363da
Add basic custom data directory support
2020-05-04 17:01:05 +09:00
Dean Herbert
81889e0034
Fix tests potentially selecting a deleted beatmap
2020-05-04 15:20:43 +09:00
Dean Herbert
02b9f51bdd
Add failing test
2020-05-04 15:20:43 +09:00
Dean Herbert
a1cd007cad
Fix song select tests potentially failing due to difficulty panels not yet displayed
2020-05-04 14:44:53 +09:00
Dan Balasescu
5767bcb8d7
Merge branch 'master' into add-interval-list
2020-05-04 02:00:14 +09:00
Bartłomiej Dach
8118747732
Make PeriodTracker actually immutable
2020-05-02 01:33:33 +02:00
Joehu
700214d249
Truncate beatmap title and artist on score panel
2020-04-30 22:13:38 -07:00
Dean Herbert
d470e092a3
Merge branch 'master' into fix-overlapping-object-undoredo
2020-05-01 10:45:29 +09:00
smoogipoo
c96bc5c51c
Fix undo/redo behaving poorly with simultaneous objects
2020-04-30 20:39:41 +09:00
Dean Herbert
cf4e79cf38
Show loading spinner when carousel is not ready to be displayed
2020-04-30 11:51:06 +09:00
Salman Ahmed
6fa9feb15c
Merge remote-tracking branch 'upstream/master' into add-interval-list
2020-04-29 05:14:40 +03:00
Salman Ahmed
6e76e5900a
Rename is-in-any check method to a more legible name
2020-04-29 05:11:44 +03:00
Salman Ahmed
587f946dc6
Adjust, simplify and make the test code more flexible to some degree
2020-04-29 05:11:43 +03:00
Dean Herbert
31c3fd86b9
Avoid using internal EF methods in tests
2020-04-28 16:22:00 +09:00
Dan Balasescu
e915f22516
Merge branch 'master' into schedule-music-controller-operations
2020-04-28 14:09:56 +09:00
Dean Herbert
19fe15887a
Merge pull request #8860 from Joehuu/fix-mod-sel-score-multi-being-off-screen
...
Fix score multiplier being cut off in mod select at higher ui scales
2020-04-28 13:52:56 +09:00
Dean Herbert
0d752dc7b8
Remove redundant initialisation
2020-04-28 12:55:57 +09:00
Dean Herbert
743a92bbbe
Use a local database for now playing test
2020-04-28 12:42:08 +09:00
Dean Herbert
81e73acb1a
Fix tests failing when not run in certain order
2020-04-28 12:21:27 +09:00
Dan Balasescu
4fff08d241
Remove unused using
2020-04-28 12:19:39 +09:00
Dean Herbert
62be138aa9
Avoid calls on MusicController executing before it may have finished loading
2020-04-28 11:46:08 +09:00
dependabot-preview[bot]
03863d901b
Bump Microsoft.NET.Test.Sdk from 16.5.0 to 16.6.1
...
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest ) from 16.5.0 to 16.6.1.
- [Release notes](https://github.com/microsoft/vstest/releases )
- [Commits](https://github.com/microsoft/vstest/compare/v16.5.0...v16.6.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-27 08:59:09 +00:00
Joehu
7731d45f13
Remove unnecessary usings
2020-04-26 20:30:56 -07:00
Joehu
8a47a615db
Remove unranked label from footer
2020-04-26 19:29:22 -07:00
Salman Ahmed
f0ebbb1807
Rewrite toolbar test scene and add test cases
2020-04-25 09:54:37 +03:00
Dean Herbert
131f011239
Merge branch 'master' into all-ruleset-encoders
2020-04-24 11:32:48 +09:00
Dean Herbert
ff82de69e7
Merge branch 'master' into fix-testbeatmap-rulesetid
2020-04-24 10:58:50 +09:00
Salman Ahmed
227503c0af
Merge remote-tracking branch 'upstream/master' into test-scene-create-ruleset
2020-04-23 16:25:33 +03:00
Salman Ahmed
2fa47992dc
Seal the ruleset creation methods and let abstract method take their place
...
Also makes `CreatePlayerRuleset()` and `CreateRulesetForSkinProvider()` not-null to avoid unwanted behaviour with their derivers
2020-04-23 13:27:12 +03:00
Salman Ahmed
e3a3144236
Rename editor tests namespace from "Editor" to "Editing"
2020-04-23 11:07:55 +03:00
smoogipoo
40f11ed15c
Resolve broken test scene
2020-04-23 10:37:05 +09:00
smoogipoo
7796593b2c
Merge branch 'master' into fix-testbeatmap-rulesetid
2020-04-23 10:35:08 +09:00
Dean Herbert
dd9ceed802
Merge branch 'master' into all-ruleset-encoders
2020-04-22 22:51:42 +09:00
smoogipoo
08982e0e00
Ensure editor tests wait for load to complete
2020-04-22 19:49:21 +09:00
smoogipoo
e1142b424d
Fix test failures
2020-04-22 18:14:21 +09:00
Dean Herbert
223c822e57
Merge branch 'master' into all-ruleset-encoders
2020-04-22 13:04:16 +09:00
Dean Herbert
aaa0f908d5
Merge pull request #8818 from smoogipoo/fix-beatmap-encoder
...
Fix beatmap encoder by enabling untested test cases
2020-04-22 13:03:56 +09:00
Dean Herbert
360c9f8e38
Add test coverage and handle null creator
2020-04-22 09:19:34 +09:00
smoogipoo
ee278a2e1b
Add taiko/catch/mania sample beatmaps
2020-04-22 09:06:04 +09:00
smoogipoo
21949ac499
Add osu! test beatmap
2020-04-22 09:04:44 +09:00
smoogipoo
1e7e7417ed
Fix testing relying on control point order
2020-04-22 09:04:44 +09:00
smoogipoo
8ea76244a2
Fix only single beatmap being tested
2020-04-22 09:04:44 +09:00
smoogipoo
9713d90388
Always apply beatmap converter/processor
2020-04-22 09:04:44 +09:00
smoogipoo
e9a2e92adf
Fix incorrect beatmap comments
2020-04-22 09:04:44 +09:00
Dean Herbert
ed9663985b
Rename panels
2020-04-21 20:55:33 +09:00
Dean Herbert
9b9b710ded
Move and rename remaining direct classes
2020-04-21 16:41:07 +09:00
Dean Herbert
1cec0575b7
Remove unused classes and replace overlay in game
2020-04-21 16:38:47 +09:00
Dean Herbert
c3b36d8f20
Merge pull request #7924 from EVAST9919/beatmap-listing-expanded
...
Implement sorting by genre and language in BeatmapListingOverlay
2020-04-21 16:34:59 +09:00
Dean Herbert
aa153290a9
Merge pull request #8815 from smoogipoo/fix-controlpoint-decode
...
Fix control point overriding working incorrectly
2020-04-21 16:18:50 +09:00
Dean Herbert
c2ed6491a9
Move and shorten enum names
2020-04-21 15:39:15 +09:00
Dean Herbert
89320b510c
Apply class renaming
2020-04-21 15:13:19 +09:00
smoogipoo
72fb34f82c
Fix overriding control points incorrectly
2020-04-21 14:19:05 +09:00
Dean Herbert
3b0099c687
Refactor tests
2020-04-21 12:26:43 +09:00
Dean Herbert
5a2129da7c
Merge branch 'master' into allow-cancelling-completion
2020-04-21 11:22:37 +09:00
Dean Herbert
cf41b90193
Merge branch 'master' into dashboard-overlay-new
2020-04-20 18:25:47 +09:00
Dan Balasescu
477d519df3
Merge branch 'master' into beatmap-listing-expanded
2020-04-20 17:18:18 +09:00
Dan Balasescu
dd7c6a83bd
Merge branch 'master' into fix-song-select-desync
2020-04-20 15:23:19 +09:00
Dean Herbert
f26c080512
Merge branch 'master' into dashboard-overlay-new
2020-04-20 15:19:03 +09:00
Dan Balasescu
ddc5489fc9
Merge pull request #8801 from peppy/add-np-command
...
Add /np (now playing) command support in chat
2020-04-20 14:07:39 +09:00
Dean Herbert
f56b85ce27
Merge branch 'master' into fix-song-select-desync
2020-04-20 12:54:32 +09:00
Salman Ahmed
2c012b9af1
Use AddUntilStep whenever possible
...
Avoid redundant usage
2020-04-20 06:43:18 +03:00
Salman Ahmed
e12e3391fb
Base wait steps duration on the delay used for results display
...
With `* 2` for safety of not potentially going to the next step and the delegate not executed yet.
2020-04-20 06:42:33 +03:00
Dean Herbert
2444dd42d0
Remove not-implemented-exception
2020-04-20 09:57:46 +09:00
Dean Herbert
f3fee73441
Fix DatabasedKeyBindingContainer not using defaults for non-databased ruleset
2020-04-20 09:35:00 +09:00
Dean Herbert
e4d4040afb
Rename test to match other classes
2020-04-19 16:57:47 +09:00
Dean Herbert
1dd471dfcc
Add /np (now playing) command support in chat
2020-04-19 15:13:25 +09:00
Salman Ahmed
65a8860a65
Add test cases to ensure no regression in "cancelling completion"
2020-04-19 06:01:09 +03:00
Dean Herbert
5833a7ac91
Fix presenting new ruleset and beatmap at once causing wedge display desync
2020-04-17 18:56:17 +09:00
Salman Ahmed
92df4e3a9e
Remove PlayerTestScene constructor and use CreateRuleset method instead
2020-04-17 11:17:51 +03:00
Dan Balasescu
4e22e569f5
Merge branch 'master' into timing-equivalence
2020-04-17 17:12:38 +09:00
Andrei Zavatski
894598eb22
Replace SocialOverlay with DashboardOverlay
2020-04-16 12:05:51 +03:00
Andrei Zavatski
29bea4e11c
Implement OverlayView component
2020-04-16 11:42:21 +03:00
Andrei Zavatski
ef0da9e3e8
Basic overlay layout implementation
2020-04-16 11:01:36 +03:00
Dean Herbert
86e8aaa2f4
Merge branch 'master' into beatmap-listing-expanded
2020-04-16 16:15:40 +09:00
Dean Herbert
5ec8d49241
Merge pull request #8764 from smoogipoo/disable-undo-redo
...
Disable undo/redo menu items when they can't be performed
2020-04-16 13:47:23 +09:00
smoogipoo
9e2be6f2f4
Remove bindable to promote one-way access
2020-04-16 13:25:08 +09:00
Dean Herbert
4eefe47ce3
Merge branch 'master' into fix-0-customsampleset
2020-04-16 11:20:31 +09:00
Dean Herbert
06e25091f6
Fix typo
2020-04-16 10:44:08 +09:00
smoogipoo
e8c955ed9b
Add CanUndo/CanRedo bindables
2020-04-15 16:17:17 +09:00
smoogipoo
102c1d9095
Add disabled state to menu items
2020-04-15 16:17:17 +09:00
smoogipoo
72707a9973
Fix OS-dependent substring
2020-04-15 13:54:23 +09:00
Dean Herbert
c0a1aae63a
Merge branch 'master' into beatmap-listing-expanded
2020-04-15 13:26:16 +09:00
smoogipoo
10486a0ad2
Fix potential dependency-related issues
2020-04-14 23:10:14 +09:00
smoogipoo
64d44dedcd
Make testscene headless
2020-04-14 22:39:51 +09:00
smoogipoo
00d564d29c
Add tests
2020-04-14 21:18:28 +09:00
Dean Herbert
ecd40072c4
Merge pull request #8312 from Game4all/low-hp-red-layer
...
Fade playfield to red when player health is low
2020-04-14 18:33:51 +09:00
smoogipoo
59728ffebd
Fix up/improve test scene
2020-04-14 15:24:34 +09:00
smoogipoo
3c5fb79823
Mark dummy api test scene as headless
2020-04-14 14:51:09 +09:00
Dan Balasescu
ac8a3efc46
Merge branch 'master' into low-hp-red-layer
2020-04-14 14:47:01 +09:00
Dan Balasescu
33f7e429a8
Merge pull request #8444 from LittleEndu/select-recommended
...
Make beatmap carousel select recommended difficulties
2020-04-14 14:25:17 +09:00
Dan Balasescu
eb968d2bdb
Merge branch 'master' into timing-equivalence
2020-04-14 14:02:02 +09:00
Dan Balasescu
948e225e12
Merge branch 'master' into select-recommended
2020-04-14 13:59:03 +09:00
Dan Balasescu
d965baa4bd
Merge branch 'master' into dummy-api-request-support
2020-04-14 13:42:42 +09:00
Dean Herbert
68c25c38a7
Merge branch 'master' into no-video-option
2020-04-14 11:36:31 +09:00
Bartłomiej Dach
06407a1081
Merge branch 'master' into fix-classic-scoring
2020-04-14 02:13:45 +02:00
Bartłomiej Dach
3e48c26bc2
Add failing tests
2020-04-14 01:09:58 +02:00
Endrik Tombak
d9c91fb943
Merge branch 'master' of https://github.com/ppy/osu into no-video-option
...
Conflicts:
osu.Game/Overlays/Direct/PanelDownloadButton.cs
2020-04-13 17:40:28 +03:00
Dean Herbert
89d8063588
Add support for Perform/PerformAsync
2020-04-13 21:35:35 +09:00
Dean Herbert
2388799acf
Limit upper number of editor beatmap states saved to 50
2020-04-13 20:37:46 +09:00
Dean Herbert
ef5e88dd82
Merge pull request #8696 from smoogipoo/editor-undo-redo
...
Add undo/redo support to the Editor
2020-04-13 19:12:47 +09:00
Dean Herbert
dd949a3fe0
Fix test writer flush happening too late
2020-04-13 17:52:04 +09:00
Dean Herbert
6aab19413c
Rename differ to patcher, add xmldoc
2020-04-13 17:20:20 +09:00
Dean Herbert
bb53f96c71
Store states as byte[] instead of Streams
2020-04-13 17:18:50 +09:00
Andrei Zavatski
29dd225205
Make button protected
2020-04-13 10:45:15 +03:00
Dean Herbert
0c60dbe796
Merge branch 'master' into editor-undo-redo
2020-04-13 16:03:53 +09:00
Andrei Zavatski
bdce79ed5b
Fix incorrect test step name
2020-04-13 09:57:05 +03:00
Andrei Zavatski
0eaff00787
Fix typo in test
2020-04-13 09:45:49 +03:00
Dean Herbert
39b5c9f396
Merge branch 'master' into overlay-scroll-container
2020-04-13 15:44:20 +09:00
Dean Herbert
72fb466a0b
Merge branch 'master' into present-from-overlay
2020-04-13 15:01:24 +09:00
Andrei Zavatski
99fa145847
Add test for potential failing case
2020-04-13 08:38:34 +03:00
Andrei Zavatski
b4800dd461
Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-scroll-container
2020-04-13 08:09:17 +03:00
Endrik Tombak
633b969017
Apply review suggestions
2020-04-12 21:57:35 +03:00
Endrik Tombak
1cf240b5ff
Test new predicate behaviour
2020-04-12 20:04:25 +03:00
TheWildTree
07dc277321
Remove unused changelog comments class
2020-04-12 14:55:42 +02:00
Dean Herbert
25f36e87a6
Merge branch 'master' into overlay-scroll-container
2020-04-12 12:34:41 +09:00
Dean Herbert
c96df97586
Add support for non-generic requests
2020-04-11 18:02:49 +09:00
Dean Herbert
415adecdf6
Add support for Result fetching
2020-04-11 18:02:43 +09:00
Dean Herbert
832822858c
Add basic request / response support
2020-04-11 17:48:23 +09:00
Dean Herbert
c0c1f2c023
Add test coverage
2020-04-11 17:17:18 +09:00
Salman Ahmed
e10c973aa6
Add test cases for behaviour of ruleset dependencies caching on tests
2020-04-11 04:24:34 +03:00
Salman Ahmed
b7ed17dfbd
Throw if interval with reversed values added
...
May reduce in subtle bugs.
2020-04-10 15:49:06 +03:00
smoogipoo
41caa37856
Add tests
2020-04-10 13:29:49 +09:00
Salman Ahmed
9a29797a5b
Use IntervalList<double> for tracking break periods
2020-04-09 23:00:16 +03:00
Salman Ahmed
38ee5f3103
Add tests covering most cases of interval list checking
2020-04-09 22:57:54 +03:00
Andrei Zavatski
518acf03e9
Remove BeatmapSearchSmallFilterRow component
2020-04-09 19:41:35 +03:00
Andrei Zavatski
474dae368f
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-listing-expanded
2020-04-09 19:30:28 +03:00
Andrei Zavatski
b6d8e487d2
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-listing-expanded
2020-04-09 19:18:59 +03:00
smoogipoo
e208251fc6
Wait for timeline to also load
2020-04-09 23:18:43 +09:00
smoogipoo
2e33d38cd7
Merge branch 'master' into editor-undo-redo
2020-04-09 22:02:28 +09:00
smoogipoo
ed4ce54ac3
Add tests
2020-04-09 21:56:36 +09:00
Dean Herbert
cc0bcea6e5
Merge pull request #8693 from smoogipoo/editorbeatmap-update-cleanup
...
Cleanup handling of hitobject updates
2020-04-09 21:32:58 +09:00
smoogipoo
ecd7ce4b98
Fix test scene
2020-04-09 21:00:23 +09:00
smoogipoo
86243d463f
Add legacy beatmap diffing
2020-04-09 20:48:59 +09:00
smoogipoo
fde5cd34b2
Merge branch 'editorbeatmap-update-cleanup' into editor-undo-redo
2020-04-09 20:36:57 +09:00
smoogipoo
ee6ea08cf8
Cleanup handling of hitobject updates
2020-04-09 20:16:44 +09:00
Andrei Zavatski
134feefa14
Remove bindable
2020-04-09 13:10:09 +03:00
Andrei Zavatski
2d3ea95469
Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-scroll-container
2020-04-09 13:06:22 +03:00
Dean Herbert
e10576325c
Merge branch 'master' into update-overlay-headers
2020-04-09 16:29:34 +09:00
Dean Herbert
53b2f58eda
Merge branch 'master' into overlay-scroll-container
2020-04-09 15:05:49 +09:00
Dean Herbert
1c72afe8c4
Move fading test to top for convenience
2020-04-09 14:52:40 +09:00
Dean Herbert
6db22366e2
Add new tests and tidy up existing tests
2020-04-09 14:47:48 +09:00
Dean Herbert
947745d87e
Change fail effect to be less distracting
2020-04-09 14:34:23 +09:00
Dean Herbert
0e2d5213ce
Merge branch 'master' into low-hp-red-layer
2020-04-09 13:53:57 +09:00
Alchyr
3d975f30a3
Merge branch 'timing-equivalence' of https://github.com/Alchyr/osu into timing-equivalence
2020-04-08 01:45:53 -07:00
Alchyr
65823fb2e1
Use redundancy test
2020-04-08 01:42:35 -07:00
smoogipoo
2ddea018cf
Fix hidden notes due to 0 minimum width
2020-04-08 17:15:59 +09:00
Bartłomiej Dach
65db64e13e
Add failing test cases
2020-04-07 22:41:20 +02:00
Dean Herbert
f0443bca3c
Merge pull request #8643 from smoogipoo/fix-legacy-version
...
Make version-less skins fallback to version 1.0
2020-04-07 21:28:06 +09:00
Dan Balasescu
5758a9fa4d
Merge branch 'master' into fix-results-star-display-alignment
2020-04-07 12:28:33 +09:00
smoogipoo
5dfa2a2bad
Fix step namings
2020-04-07 11:50:40 +09:00
smoogipoo
a4208f35c4
Make versionless skins fallback to version 1.0
2020-04-06 19:36:17 +09:00
smoogipoo
8438ee7e07
Improve testing
2020-04-06 19:35:27 +09:00
Salman Ahmed
c902ba4086
Add test cases for HP draining not applied before a break and after it
2020-04-05 21:46:07 +03:00
Salman Ahmed
0eaea8ef9d
Create a constructor for break period
...
For simple construction of break periods (e.g. filling a method with an array of break periods inside a test case)
2020-04-05 21:29:03 +03:00
Joehu
493b654011
Remove horizontal margin from mod display
...
Can skew center alignment on fill flow containers.
Fixes affected areas. Vector2(5, 0) is similar to MarginPadding { Left = 10 }.
2020-04-03 11:30:02 -07:00
Dan Balasescu
05e2ca0b68
Merge pull request #8590 from peppy/fix-intro-test-scene
...
Fix dynamic recompilation in intro test scenes
2020-04-03 19:40:46 +09:00
Dean Herbert
8cb0eb9b12
Fix dynamic recompilation in intro test scenes
2020-04-03 15:08:06 +09:00
Will Kennedy
877bd7837a
Changed variable names
2020-04-02 22:02:57 -04:00
Will Kennedy
c042e709a5
Fix GetDecoder getting fallback decoder too often
2020-04-02 20:43:54 -04:00
smoogipoo
a77933f5e0
Add support for parsing mania skin colours
2020-04-02 17:56:12 +09:00
Lucas A
1562612f41
Update visual tests and remove unessecary XMLDoc tag
2020-04-01 15:12:31 +02:00
Andrei Zavatski
e26fbd5ed8
Remove overcomplicated stuff
2020-03-31 13:45:59 +03:00
Dean Herbert
db59d0530e
Remove test coverage of scale down
2020-03-31 14:15:25 +09:00
Dean Herbert
1fce7cce01
Remove ScaleDownToFit as it was not implemented without enough safety
2020-03-31 13:50:04 +09:00
Lucas A
ab01111c36
Fix merge conflicts.
2020-03-30 17:39:11 +02:00
Andrei Zavatski
2dc81bbcfa
Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-scroll-container
2020-03-30 13:37:25 +03:00
Dean Herbert
35647d59a6
Add failing test
2020-03-30 19:09:05 +09:00
smoogipoo
1ce4f7c854
Add tests
2020-03-30 17:37:08 +09:00
Dan Balasescu
03cd9aa060
Merge branch 'master' into spun-out
2020-03-30 12:31:53 +09:00
Dan Balasescu
113bbe8c4d
Merge pull request #8488 from peppy/fix-autoplay-results-display
...
Fix auto mod results screen not displaying correctly
2020-03-30 11:01:16 +09:00
Dean Herbert
d99b445720
Move non-headless tests to correct namespace
2020-03-30 10:00:28 +09:00
Dean Herbert
98a700ef3a
Attempt to fix tests by skipping one break at a time
2020-03-30 00:58:06 +09:00
Endrik
f4c8b6d219
Fix copy paste oversight
2020-03-29 18:55:47 +03:00
Dean Herbert
a72f0f57f6
Refactor tests for readability
2020-03-30 00:05:07 +09:00
Dean Herbert
07c7233b3d
Change int div comments
2020-03-29 23:46:28 +09:00
Dean Herbert
653480b2f8
Add regression test
2020-03-29 23:29:46 +09:00
Dean Herbert
b259708915
Merge branch 'master' into spun-out
2020-03-29 13:24:48 +09:00
Endrik Tombak
8cab303611
Cover skipDifficulties = false in tests
2020-03-28 21:02:55 +02:00
Endrik Tombak
63f6269eb0
Test both ways
2020-03-28 13:10:20 +02:00
Endrik Tombak
659865b457
Use understandable set id
2020-03-28 13:08:06 +02:00
Endrik Tombak
0a69647efe
Merge remote-tracking branch 'origin/traversal-is-broken' into rewrite-select-next
2020-03-28 13:06:37 +02:00
Dean Herbert
3cc574e62d
Merge branch 'master' into overlay-scroll-container
2020-03-28 16:46:01 +09:00
Dean Herbert
e9dc545429
Merge branch 'master' into fix-no-break-info
2020-03-28 12:39:37 +09:00
Dean Herbert
a317ef65b8
Remove default for argument
2020-03-28 12:18:28 +09:00
Bartłomiej Dach
15fb1a099e
Modify assert to avoid false failures
...
In headless tests it was possible for TestInstantLoad() to erroneously
fail. There were two scenarios in which LoadingSpinner could be null:
1. If the test runner was quick enough, the assert could end up running
even before Loader.OnEntering() had even had a chance to, meaning
that the spinner was never even actually assigned to or instantiated
at that point in time.
2. Even if Loader.OnEntering() had managed to run, there was also
a possibility that the spinner itself wasn't loaded at the point
of checking the assertion. As the spinner is accessed through
ChildrenOfType(), which only checks InternalChildren and ignores
all currently-loading drawables, it would therefore return null.
As null != 0, both of these cases would actually fail the test (this is
best seen running headless, preferably with a [Repeat] attribute
attached).
To resolve, allow the spinner to be null at the point of asserting and
duplicate the assertion step at the end. This weakens the test, as case
(1) should probably be waited for and case (2) could be solved with
exposition as protected in the base, but when attempting to wait for
the loader itself to be loaded there were also cases where the
appropriate until step would take so much time that the spinner would
actually become visible in line with the delayed display logic, so this
is a best-effort attempt to address both points without radical
changes.
2020-03-28 00:43:57 +01:00
Bartłomiej Dach
46af4bce32
Cover regression in autoplay test
2020-03-27 19:42:45 +01:00
Andrei Zavatski
7b24cc325f
Implement OverlayScrollContainer component
2020-03-27 20:57:57 +03:00
Dean Herbert
6ecfeb8cc3
Merge pull request #8455 from Game4all/handle-novideo-beatmaps
...
Fix NullReferenceException when starting the no-video version of a beatmap with video
2020-03-27 21:12:40 +09:00
Lucas A
6788b7f9cd
Add test for loading storyboards with missing video file.
2020-03-27 12:07:47 +01:00
Endrik Tombak
e707adb773
Increase amount of test sets
2020-03-26 21:16:10 +02:00
Endrik Tombak
902734b75e
Add failing test
2020-03-26 20:32:43 +02:00
TheWildTree
9a30ff5a00
Fix code quality issues
2020-03-26 16:11:58 +01:00
Lucas A
00c1ff993a
Fix merge conflicts.
2020-03-26 15:48:18 +01:00
Lucas A
c1ac57e70f
Add back visual tests and add easing to alpha fade.
2020-03-26 12:14:44 +01:00
Dean Herbert
07462120e4
Split break tracking into its own component
2020-03-26 15:30:23 +09:00
Andrei Zavatski
1e025b7c31
Add tests to cover the issue
2020-03-25 20:58:51 +03:00
Dean Herbert
800e395bc8
Merge branch 'master' into replay-recording
2020-03-25 20:20:59 +09:00
Dean Herbert
880d138a47
Fix intro tests not asserting pass or working at all
2020-03-25 15:12:19 +09:00
Dean Herbert
6d81da5419
Merge branch 'master' into video-offset
2020-03-25 11:28:59 +09:00
Dean Herbert
368bf58521
Rename and make fields readonly
2020-03-25 11:08:08 +09:00
TheWildTree
a5781d7fc5
Replace ScreenTitle with OverlayTitle and update titles to match new design
2020-03-24 22:08:20 +01:00
Dean Herbert
4070b2b75f
Merge branch 'basic-replay-recorder' into replay-recording
2020-03-24 16:31:14 +09:00
Dean Herbert
417ff837ac
Add basic tests
2020-03-24 16:22:54 +09:00
Dean Herbert
8484d201d1
Nest and rename test classes
2020-03-24 15:54:04 +09:00
Dean Herbert
2735a2250c
Move replay recorder to final location
2020-03-24 15:49:52 +09:00
Dean Herbert
388cf5c83a
Fix catch positional data being incorrectly recorded
2020-03-24 15:38:54 +09:00
Dean Herbert
68ebe98fde
Remove unused GetUnderlyingStream method
2020-03-24 14:08:25 +09:00
Dean Herbert
14a85a84bf
Add proper screen space - gamefield mapping
2020-03-23 20:06:18 +09:00
Dean Herbert
6d48068061
Move replay recorder to final location
2020-03-23 20:04:15 +09:00
杜Nate
9ea0137b01
Merge branch 'master' into spun-out
2020-03-23 18:13:53 +08:00
Dean Herbert
d5bc4915e6
Add "important" frames and record rate options
2020-03-23 19:02:45 +09:00
Dean Herbert
467066112f
Initial record/playback implementation
2020-03-23 18:50:16 +09:00
Dean Herbert
232c255986
Basic test scene setup
2020-03-23 17:33:02 +09:00
Dean Herbert
98e6896e93
Rename test class
2020-03-23 15:37:34 +09:00
Dean Herbert
680d058f3f
Merge branch 'master' into friends-layout-split
2020-03-23 15:36:04 +09:00
Dan Balasescu
d0c7b49376
Merge branch 'master' into fix-carousel-root-selects-from-nothing
2020-03-23 11:34:04 +09:00
smoogipoo
448e5c0deb
Merge branch 'master' into fix-carousel-root-selects-from-nothing
2020-03-23 11:15:22 +09:00
smoogipoo
bf70276496
Fix test re-using the same beatmap sets
2020-03-23 11:12:36 +09:00
Dan Balasescu
fb21c7d82d
Merge branch 'master' into fix-carousel-restore-previous-selection
2020-03-23 11:01:18 +09:00
Dean Herbert
bfd643dd16
Rename classes
2020-03-23 10:47:27 +09:00
Dean Herbert
0b728f483f
Rename base test class to help avoid incorrect reference
2020-03-23 10:01:33 +09:00
Andrei Zavatski
2b0c267cb9
Expose Fetch method
2020-03-21 20:37:21 +03:00
Andrei Zavatski
f8169e9712
Merge remote-tracking branch 'refs/remotes/ppy/master' into friends-layout-split
2020-03-21 20:31:38 +03:00
Dean Herbert
febf9adabd
Merge pull request #8329 from Fuewburvpoa/MyBranch
...
Fix beat divisor control selecting invalid divisors on drag end
2020-03-22 02:21:13 +09:00
Dean Herbert
729e006c3a
Merge branch 'master' into video-offset
2020-03-21 20:03:46 +09:00
Dean Herbert
8136ea561e
Fix a couple of broken tests
2020-03-20 15:02:13 +09:00
Dean Herbert
9b60b535e5
Fix selection not occurring when switching from empty ruleset on first load
2020-03-20 15:01:26 +09:00
Dean Herbert
3a50c4bb51
Update tests
2020-03-19 18:58:22 +09:00
Dean Herbert
c50784da93
Show 'D' rank badge on accuracy circle
2020-03-19 11:58:52 +09:00
Bartłomiej Dach
23338a6c82
Adjust test implementation
...
* Use slider bar and slider marker coordinates in manual tests instead
of hard-coded offsets.
* Reword test steps slightly for greater clarity.
2020-03-18 22:23:06 +01:00
Bartłomiej Dach
1d3cac4cdc
Eliminate osuTK.Input namespace qualifications
2020-03-18 21:55:35 +01:00
Bartłomiej Dach
4bda520695
Use [SetUp] instead of reset method
2020-03-18 21:54:17 +01:00
Fuewburvpoa
648e9fa21f
Merge branch 'master' into MyBranch
2020-03-18 21:18:17 +02:00
Fuewburvpoa
d5541dfc65
Codefactor fix
2020-03-18 21:06:14 +02:00
Fuewburvpoa
463dde1fc4
Tests for BeatDivisorControl
2020-03-18 21:04:38 +02:00
Dan Balasescu
9b029fa9e0
Merge pull request #8212 from peppy/update-loader-animation
...
Update loader animation
2020-03-18 12:07:50 +09:00
Dan Balasescu
514e72bffb
Merge branch 'master' into update-loader-animation
2020-03-18 11:36:29 +09:00
Dan Balasescu
04991315f9
Merge branch 'master' into improve-chat-test
2020-03-18 11:30:48 +09:00
Lucas A
6b0c5bc65d
Rename to LowHealthLayer to FaillingLayer.
2020-03-17 22:32:07 +01:00
Lucas A
8c611a981f
Update visual tests
2020-03-17 22:17:28 +01:00
Bartłomiej Dach
944f0b0285
Rewrite tests
...
* Use [Cached] injection instead of modifying beatmaps read from store.
* Add assertion steps verifying the presence of mapper name (or lack
thereof).
2020-03-17 20:45:48 +01:00
Andrei Zavatski
e951979a12
Remove assert from online test
2020-03-17 22:34:46 +03:00
Andrei Zavatski
4d376636c3
Merge remote-tracking branch 'refs/remotes/ppy/master' into friends-layout-split
2020-03-17 22:12:48 +03:00
recapitalverb
7186e3466b
Fix formatting issues
2020-03-18 01:39:19 +07:00
recapitalverb
dc73105a10
Add tests for beatmaps with(out) null mappers
2020-03-18 01:33:01 +07:00
Dean Herbert
2d6dcb3ba9
Merge branch 'master' into results-screen
2020-03-17 22:03:36 +09:00
Dean Herbert
b27bb4aeae
Merge branch 'master' into results-middle-content
2020-03-17 21:37:23 +09:00
Dean Herbert
75695938e2
Merge branch 'master' into results-top-content
2020-03-17 20:42:02 +09:00
Dean Herbert
3b9c64b76f
Merge branch 'master' into results-scorepanel
2020-03-17 20:06:11 +09:00
Dean Herbert
01fd52e9d8
Merge branch 'master' into update-framework
2020-03-17 19:23:42 +09:00
Dean Herbert
370ff70dd4
Fix incorrect host name specification
2020-03-17 18:32:30 +09:00
smoogipoo
6f569d1485
Fix colour conflicts for expert-plus
2020-03-17 18:01:46 +09:00
smoogipoo
1c4296f5e7
Implement the new results screen
2020-03-17 17:43:16 +09:00
smoogipoo
afed01d781
Merge branch 'results-middle-content' into results-screen
2020-03-17 17:35:40 +09:00
smoogipoo
1521f25c96
Implement middle panel contents
2020-03-17 17:25:24 +09:00
smoogipoo
19106daf8b
Merge branch 'results-circle' into results-middle-content
2020-03-17 17:09:15 +09:00
smoogipoo
7cc1a6040f
Implement top panel contents
2020-03-17 17:01:38 +09:00
smoogipoo
05789e6fe4
Implement the score panel
2020-03-17 16:59:34 +09:00
smoogipoo
dca2e1d816
Implement the accuracy circle
2020-03-17 16:37:56 +09:00
Andrei Zavatski
4ac740b12b
Remove APIFriend
2020-03-17 08:51:54 +03:00
Andrei Zavatski
bf9c6f8a3b
Skip online test if user is not logged-in
2020-03-17 02:19:03 +03:00
Andrei Zavatski
6a151b8e75
Add online test
2020-03-17 01:50:19 +03:00
Andrei Zavatski
cc5833db80
Remove string prefixes in the test scene
2020-03-17 01:36:48 +03:00
TheWildTree
4153f8d49d
Fix edge case making test fail
...
Forgot that if a PM channel was the last tab, it hid itself upon selecting due to changing its width, which made the last-visible-selected assert fail. Made this particular test only use non-PM channels.
2020-03-16 21:31:22 +01:00
TheWildTree
0f40671e69
Mix normal channel tabs with PM ones
2020-03-16 19:44:03 +01:00
TheWildTree
50c2e65e3c
Improve TestSceneChatOverlay
2020-03-16 19:10:42 +01:00
Andrei Zavatski
544dfe7dd3
Implement FriendsLayout component
2020-03-16 09:42:21 +03:00
Dan Balasescu
0245bab7c6
Merge branch 'master' into user-cards-update
2020-03-16 14:27:21 +09:00
Dean Herbert
9bb3a6c677
Merge branch 'master' into click-group-difficulty-icons
2020-03-16 12:01:09 +09:00
Dean Herbert
d6be8eec0c
Merge branch 'master' into click-disabled-difficulty-icons
2020-03-16 11:30:57 +09:00
Dan Balasescu
bd05462a7f
Merge branch 'master' into carousel-selection-fallback-improvement
2020-03-16 10:53:10 +09:00
Dan Balasescu
25a35a1370
Merge branch 'master' into always-apply-ruleset-filter
2020-03-16 10:32:36 +09:00
Dan Balasescu
12293bea1d
Merge branch 'master' into fix-chat-tabs
2020-03-16 09:57:01 +09:00
Dean Herbert
1a6056637b
Turn off italics test for now (may come back if we switch chat to content font)
2020-03-15 01:43:48 +09:00
TheWildTree
38d00c7f0a
Revert unnecessary changes and actually trim the whitespace
2020-03-13 21:29:10 +01:00
TheWildTree
8d3cab0e16
Trim whitespace
2020-03-13 18:58:32 +01:00
TheWildTree
0bbae094dd
Add active tab closing behaviour tests
2020-03-13 18:34:51 +01:00
TheWildTree
694e56b0d1
Add non-PM chat tabs to tests
2020-03-13 18:34:51 +01:00
Dean Herbert
de9857ccdc
Fix incorrect id reference in test
2020-03-13 11:02:53 +09:00
Dean Herbert
ba0dec891d
Update test temporarily
2020-03-13 10:58:36 +09:00
Bartłomiej Dach
d24fa18bc2
Merge branch 'master' into video-offset
2020-03-12 19:58:45 +01:00
Dean Herbert
bab197553e
Update carousel test logic to match new carousel selection behaviour
2020-03-12 19:55:25 +09:00
Dean Herbert
250061ddf5
Fix test failure due to off-screen panel
2020-03-12 19:46:21 +09:00
Dean Herbert
1819a15509
Make test ID assigning simpler
2020-03-12 19:27:54 +09:00
Dean Herbert
db5c8043db
Add test covering ruleset change on difficulty icon selection
2020-03-12 18:42:08 +09:00
Dean Herbert
6e11c3014c
Allow grouped difficulty icons to be clicked
2020-03-12 18:42:08 +09:00
Dean Herbert
2bcf079386
Update carousel test logic to match new carousel selection behaviour
2020-03-12 18:42:08 +09:00
Dean Herbert
5537b279de
Fix failing test occasionally getting wrong ruleset beatmap
2020-03-12 18:39:43 +09:00
Dean Herbert
933a8ffc8a
Add test coverage
2020-03-12 17:10:51 +09:00
Dean Herbert
28ac5af91c
Fix beatmap carousel tests loading beatmap manager beatmaps in test browser
2020-03-12 16:53:23 +09:00
Dean Herbert
6546fd3f81
Fix potential null due to async load
2020-03-11 16:07:44 +09:00
Dan Balasescu
35ae8aa29f
Merge pull request #8108 from EVAST9919/friends-update-streams
...
Implement FriendsOnlineStatusControl component
2020-03-11 15:35:23 +09:00
Dan Balasescu
1d556bfc5f
Merge branch 'master' into video-offset
2020-03-11 15:13:18 +09:00
voidedWarranties
6de244389b
Use OffsetClock instead of ManualClock
2020-03-10 22:50:20 -07:00
Dean Herbert
6f7a6a5a59
Merge pull request #8133 from peppy/better-filter-bypass
...
Reapply filters on next change after a forced beatmap display
2020-03-11 14:36:28 +09:00
Dan Balasescu
c3fd8e294a
Merge pull request #8211 from peppy/new-disclaimer
...
Update text on disclaimer screen (and add tips)
2020-03-11 14:24:58 +09:00
Dan Balasescu
d3c0deb381
Merge branch 'master' into friends-update-streams
2020-03-11 14:09:27 +09:00
Dan Balasescu
9119e32f63
Merge branch 'master' into better-filter-bypass
2020-03-11 13:37:55 +09:00
Dean Herbert
ec88f7a712
Update tests and delay push animation until loader is done disappearing
2020-03-11 13:20:31 +09:00
Dean Herbert
b8d3e64416
Rename loader test scene
2020-03-11 13:05:33 +09:00
Dean Herbert
ed837d3115
Use framework extension method for FromHex
2020-03-11 10:18:41 +09:00
Dean Herbert
7b368dca35
Add test coverage
2020-03-11 02:59:24 +09:00
Dean Herbert
998ca05a0c
Fix disclaimer test scene supporter toggle
2020-03-11 02:35:36 +09:00
smoogipoo
7a9c85d69d
Fix now failing test due to parsing ranges
2020-03-10 12:21:40 +09:00
Dean Herbert
c2fbc85e77
Split out test scene for StarCounter
2020-03-09 01:26:34 +09:00
Dean Herbert
979988235d
Increase flexibility of StarCounter component
2020-03-08 15:56:22 +09:00
voidedWarranties
48282dea8b
Remove individual setting to disable videos, fix tests
2020-03-07 22:08:38 -08:00
voidedWarranties
76c832518f
Render video as a part of the storyboard
2020-03-07 21:32:03 -08:00
Andrei Zavatski
9f44a7b2ce
Simplify status assignment in the test scene
2020-03-08 03:07:14 +03:00
Andrei Zavatski
66f40f7f6e
Merge remote-tracking branch 'refs/remotes/ppy/master' into user-cards-update
2020-03-07 04:01:36 +03:00
Dean Herbert
0ccf691c97
Remove unnecessary interpolation
2020-03-06 18:00:07 +09:00
Dean Herbert
3b0e3cd71a
Remove using statements
2020-03-06 17:55:57 +09:00
Dean Herbert
40074f10db
Remove unnecessary override
2020-03-06 17:55:05 +09:00
Dean Herbert
90dbb90470
Merge branch 'master' into disable-keycounter-breaks
2020-03-06 17:53:10 +09:00
Andrei Zavatski
c7384b9717
Implement BeatmapListingSearchHandler component
2020-03-06 03:09:43 +03:00
Andrei Zavatski
1318f242c1
Revert changes to basic implementation and remove redundant stuff
2020-03-06 02:12:30 +03:00
Andrei Zavatski
c08e16d97f
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-listing-expanded
2020-03-06 01:27:51 +03:00
Dan Balasescu
aafdfbca1f
Merge pull request #8129 from peppy/fix-dummy-track-completion-feedback
...
Fix DummyWorkingBeatmap's track completion attempting to change game-wide beatmap
2020-03-05 17:57:57 +09:00
smoogipoo
0c1775b522
Fix incorrect condition and add test
2020-03-05 17:12:14 +09:00
Dan Balasescu
f7777ecb01
Merge pull request #8142 from peppy/add-star-difficulty-max-migration
...
Fix song select max displayable star difficulty getting stuck at wrong maximum
2020-03-05 17:10:10 +09:00
Dean Herbert
646c8fe077
Add note about version override
2020-03-05 15:40:48 +09:00
Dean Herbert
a311ace626
Add migration test
2020-03-05 15:07:00 +09:00
Dean Herbert
5200633f9f
Centralise TestPlayer implementations as much as possible
2020-03-05 11:25:07 +09:00
Andrei Zavatski
bf9e289f3a
Merge master with conflicts resolved
2020-03-05 04:11:12 +03:00
Bartłomiej Dach
b8889318db
Pass rulesets to solo game status
2020-03-04 22:13:31 +01:00
Bartłomiej Dach
afa3ce494d
Set online status in activity test
...
The test would check nothing otherwise.
2020-03-04 22:07:02 +01:00
Bartłomiej Dach
5fa2638e81
Rename tests to adhere to convention
2020-03-04 22:05:48 +01:00
Bartłomiej Dach
1bd49d50c7
Remove unnecessary raw string prefixes
2020-03-04 22:05:08 +01:00
Bartłomiej Dach
5b25b5dfab
Change brace style
2020-03-04 22:04:49 +01:00
Bartłomiej Dach
e3e66991b0
Move initialisation logic to [SetUp]
2020-03-04 22:02:36 +01:00
Andrei Zavatski
bd03dd9b70
Adjust class naming
2020-03-04 23:08:58 +03:00
Andrei Zavatski
6631b07442
Refactor to replace existing panels
2020-03-04 14:58:15 +03:00
Andrei Zavatski
8a437e1b54
Add ability to send pm via context menu
2020-03-04 12:42:21 +03:00
杜Nate
cf88e3ff19
Merge branch 'master' into spun-out
2020-03-04 17:38:35 +08:00
Andrei Zavatski
15e47d8432
Implement layout for UserGridCard
2020-03-04 12:20:49 +03:00
Andrei Zavatski
6ea3af1951
Implement layout for UserListCard
2020-03-04 10:35:43 +03:00
Andrei Zavatski
b7d34b399d
Adjust background presentation for UserListCard
2020-03-04 09:10:51 +03:00
Andrei Zavatski
1b5222f396
Baisc UserListCard implementation
2020-03-04 08:53:14 +03:00
Andrei Zavatski
f425233527
Basic UserCard implementation
2020-03-04 08:41:21 +03:00
Andrei Zavatski
4d5445b5dc
Rename Amount to Count
2020-03-04 00:31:06 +03:00
Andrei Zavatski
06b23b626e
Simplify test scene setup
2020-03-04 00:15:10 +03:00
Andrei Zavatski
83dad93b6d
Make Populate() accept list of users
2020-03-03 18:08:51 +03:00
Andrei Zavatski
160d64eecf
FriendsOnlineStatusControl basic implementation
2020-03-03 17:37:01 +03:00
Andrei Zavatski
937d9da43b
Implement OverlayUpdateStreamControl component
2020-03-03 17:01:58 +03:00
Andrei Zavatski
8dcdd6db6f
Rename UpdateStream components to ChangelogUpdateStream
2020-03-03 16:20:36 +03:00
naoey
3d344a076d
Add test for disabled keycounter, don't discard change event values
2020-03-03 06:17:25 +05:30
naoey
1ce972dd5b
Remove unused variable
2020-02-29 21:53:49 +05:30
naoey
bca58ddb42
Make KeyCounter stop counting during breaks
2020-02-29 21:18:43 +05:30
Andrei Zavatski
54d83eff94
Use OverlayColourProfider for VotePill component
2020-02-26 19:35:20 +03:00
Dan Balasescu
37e9c2a683
Merge branch 'master' into user-list-toolbar
2020-02-26 10:11:21 +09:00
Dan Balasescu
ff063b229b
Merge pull request #7973 from peppy/fix-dho-lifetimes-via-judgements
...
Fix hitobjects with unknown lifetimes by enforcing non-null judgement
2020-02-25 20:38:29 +09:00
Dean Herbert
61af80c1af
Merge pull request #7982 from EVAST9919/comments-crash-fix
...
Fix potential crash when clicking on show more button in comments
2020-02-25 20:14:58 +09:00
Dean Herbert
29e2e17144
Merge branch 'master' into fix-dho-lifetimes-via-judgements
2020-02-25 19:07:57 +09:00
Dean Herbert
a047456354
Revert changes to make HitObject abstract
2020-02-25 19:07:15 +09:00
Andrei Zavatski
c1455be855
Add tests
2020-02-25 10:29:03 +03:00
Andrei Zavatski
7bc9a9b3d8
Implement OverlayPanelDisplayStyleControl and UserListToolbar components
2020-02-24 07:28:33 +03:00
Andrei Zavatski
0cfe1ac823
Implement UserSortTabControl component
2020-02-24 05:47:21 +03:00
Dean Herbert
ffc7eaa3f2
Fix hitobjects with unknown lifetimes by enforcing non-null judgement
...
We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.
This fixes BananaShower and JuiceStreams in osu!catch.
This also makes HitObject abstract and cleans up convert HitObject implementations.
2020-02-23 13:49:06 +09:00
Dean Herbert
e8ebb31517
Expire old judgement lines if too many exist
2020-02-23 03:53:51 +09:00
Bartłomiej Dach
a512226036
Use attribute instead of CreateChildDependencies
2020-02-22 13:47:42 +01:00
Bartłomiej Dach
f248c0a98e
Fix regressed direct panel test scene
...
Due to unnoticed past changes TestSceneDirectPanel has regressed in that
clicking the preview track button would crash due to an unregistered
IPreviewTrackOwner dependency.
Make the test scene itself implement that empty interface and cache
itself as IPreviewTrackOwner so that preview tracks lower down can
resolve the dependency.
As the test is purely visual and has no assertions, and the important
logic in that area (preview track playing logic) is already well-covered
enough elsewhere, no further changes were made.
2020-02-22 00:58:33 +01:00
Dean Herbert
db1e5abad7
Merge pull request #7786 from EVAST9919/subcomments-alter-new
...
Add ability to load long comment trees in CommentsContainer
2020-02-21 21:18:33 +09:00
smoogipoo
41c6d2f2e7
Merge remote-tracking branch 'origin/master' into subcomments-alter-new
2020-02-21 17:02:58 +09:00
Dean Herbert
7d145a7470
Add test for loading spinner with box
2020-02-21 16:21:44 +09:00
Dean Herbert
bbac95958c
Fix incorrect test scene name
2020-02-21 16:20:55 +09:00
Dean Herbert
38d9a46ffb
Add test for relative sizing scenarios
2020-02-21 16:20:17 +09:00
Dean Herbert
92f6f0207c
Rename LoadingAnimation to LoadingSpinner
2020-02-21 15:33:31 +09:00
Dean Herbert
623b78d675
Combine all loading animation implementations
2020-02-21 15:32:46 +09:00
smoogipoo
2cb218c9c4
Merge remote-tracking branch 'origin/master' into comment-editor
2020-02-21 12:27:34 +09:00
Dean Herbert
cd666166d5
Merge pull request #7809 from voidedWarranties/proposal-difficulty-icon-select
...
Allow selecting/playing a specific difficulty using the beatmapset difficulty icons
2020-02-21 10:24:12 +09:00
Andrei Zavatski
3c56118f45
Implement BeatmapSearchParameters and refactor all the components
2020-02-21 02:28:33 +03:00
Andrei Zavatski
063a53017e
Implement Language filter
2020-02-20 17:56:49 +03:00
Andrei Zavatski
6b2ae67eaf
Implement Genre filter
2020-02-20 17:40:45 +03:00
Andrei Zavatski
5a0b93bdb2
Add ShowTag method
2020-02-20 17:02:22 +03:00
Dean Herbert
3380dbbd71
Improve visual appearance of ProcessingOverlay
2020-02-20 19:49:22 +09:00
Dean Herbert
927115a085
Merge branch 'master' into room-inspector-redesign
2020-02-20 17:41:16 +09:00
Dean Herbert
e48166858c
Merge branch 'master' into overlined-display-refactor
2020-02-20 17:38:04 +09:00
Dean Herbert
5c16dbbea9
Merge pull request #7919 from smoogipoo/null-leaderboard-position
...
Support null leaderboard position
2020-02-20 16:27:24 +09:00
smoogipoo
d79ca97fe9
Make beatmap scores also support null position
2020-02-20 15:04:12 +09:00
Dan Balasescu
eb8a56055f
Merge pull request #7910 from EVAST9919/rankings-clickable-countries
...
Make country names in RankingsOverlay clickable
2020-02-20 15:00:01 +09:00
smoogipoo
1a689231c2
Support null leaderboard position
2020-02-20 14:51:25 +09:00
smoogipoo
177935d644
Remove unused using
2020-02-20 14:45:35 +09:00
Dean Herbert
0cf0099fd5
Merge pull request #7917 from smoogipoo/fix-drawableroom-async-test
...
Fix possible test failures due to async loads
2020-02-20 14:37:51 +09:00
smoogipoo
c5fd969568
Fix 0 size in test scene
2020-02-20 14:33:13 +09:00
Dan Balasescu
bf5c34a014
Merge branch 'master' into rankings-clickable-countries
2020-02-20 14:21:44 +09:00
smoogipoo
b2d9004212
Fix possible test failures due to async loads
2020-02-20 08:37:23 +09:00
Andrei Zavatski
8fcfb73d72
Implement BeatmapListingOverlay
2020-02-19 17:40:54 +03:00
Andrei Zavatski
1417c90173
Remove redundant blank line
2020-02-19 17:24:44 +03:00
Andrei Zavatski
a79398ddbd
Fix incorrect caching in TestSceneRankingsOverlay
2020-02-19 17:09:22 +03:00
smoogipoo
ac416ae743
Implement new room inspector redesign
2020-02-19 17:47:59 +09:00
smoogipoo
ec73e8f0c7
Allow different sizing modes for OverlinedParticipants
2020-02-19 17:40:38 +09:00
smoogipoo
e3d37b808d
Move overlined displays to a higher namespace
2020-02-19 17:33:09 +09:00
Andrei Zavatski
37003e11b9
Make fields readonly
2020-02-18 18:04:39 +03:00
Andrei Zavatski
bb22243903
TestScene improvements
2020-02-18 17:47:44 +03:00
Andrei Zavatski
7228900361
Implement BeatmapListingSearchSection component
2020-02-18 17:25:12 +03:00
Andrei Zavatski
3bf3becdd6
Merge remote-tracking branch 'refs/remotes/ppy/master' into subcomments-alter-new
2020-02-18 13:27:08 +03:00
Dean Herbert
b18f9e195e
Merge branch 'master' into bindable-list-events
2020-02-18 18:47:06 +09:00
smoogipoo
ee13632375
Fix ogg beatmap/skin samples not loading
2020-02-18 13:21:55 +09:00
Dan Balasescu
75e0668b4e
Merge branch 'master' into new-direct-sort
2020-02-18 10:17:26 +09:00
Andrei Zavatski
410686c8b9
Use dropdown in BeatmapSearchFilterRow
2020-02-18 01:04:25 +03:00
Andrei Zavatski
c69818925b
Merge remote-tracking branch 'refs/remotes/ppy/master' into new-betmap-search-filter
2020-02-17 23:35:12 +03:00
Andrei Zavatski
19872d9e24
Simplify test scene
2020-02-17 22:05:10 +03:00
Andrei Zavatski
20dc1a7dcd
Merge remote-tracking branch 'refs/remotes/ppy/master' into new-direct-sort
2020-02-17 21:57:19 +03:00
smoogipoo
84ea279c94
Add test
2020-02-17 17:04:58 +09:00
smoogipoo
958c891d15
Update with framework-side bindable list changes
2020-02-17 15:06:14 +09:00
Andrei Zavatski
480e5677ed
Use OverlayColourProvider for CounterPill in profile overlay
2020-02-17 04:29:41 +03:00
Andrei Zavatski
d985a22f77
Add missing blank line
2020-02-17 03:52:26 +03:00
Andrei Zavatski
fe7923b7e8
Add SortDirection Bindable and refactor to make everything work
2020-02-17 03:38:14 +03:00
Andrei Zavatski
2ba0bd872b
Implement basic BeatmapListingSortTabControl
2020-02-17 02:35:46 +03:00
Andrei Zavatski
a9f366fda3
Implement OverlaySortTabControl component
2020-02-17 02:20:53 +03:00
Andrei Zavatski
ea285fd005
Refactor with including headers
2020-02-17 00:44:55 +03:00
Andrei Zavatski
e62fec58c1
Add ability to override text size
2020-02-16 16:38:05 +03:00
Andrei Zavatski
a71e410e5d
Make the filter autosized
2020-02-16 15:04:21 +03:00
Andrei Zavatski
3888911eee
Implement BeatmapSearchFilter component
2020-02-16 14:19:49 +03:00
Dean Herbert
80462014d9
Merge pull request #7848 from smoogipoo/fix-match-subscreen-crashes
...
Replace hashcode override with local equality comparer
2020-02-16 17:01:22 +09:00
Bartłomiej Dach
5a5e3b9410
Merge branch 'master' into align-score-right-content
2020-02-16 06:20:41 +01:00
Bartłomiej Dach
e5a66bdef3
Refactor drawable profile score to match web
2020-02-16 06:16:02 +01:00
voidedWarranties
8c81f1e684
Move CarouselBeatmap access to private, test using indices
2020-02-15 17:51:55 -08:00
Dan Balasescu
268f3333bd
Merge pull request #7841 from peppy/update-inspectcode
...
Update inspectcode version and fix new issues
2020-02-16 00:53:04 +09:00
smoogipoo
17e3470441
Replace hashcode override with local equality comparer
2020-02-16 00:23:52 +09:00
Bartłomiej Dach
01f9966933
Cover case of incorrect display in test scene
2020-02-15 16:05:15 +01:00
Dean Herbert
19d61c1255
Merge branch 'master' into match-subscreen-redesign
2020-02-15 15:29:33 +09:00
Dean Herbert
da68ae5461
Merge branch 'master' into match-songselect-playlist-logic
2020-02-15 12:27:51 +09:00
Dean Herbert
bb541f5ae4
Update inspectcode version and fix new issues
2020-02-15 11:54:29 +09:00
Dean Herbert
a4215106ff
Merge branch 'master' into match-detail-area
2020-02-15 11:46:29 +09:00
Dean Herbert
af8eda2d24
Merge pull request #7829 from smoogipoo/match-playlist
...
Implement a rearrangeable beatmap playlist control
2020-02-15 11:42:26 +09:00
Dean Herbert
0b90e732a9
Merge branch 'master' into match-playlist
2020-02-15 11:09:17 +09:00
voidedWarranties
8e1ecddb1d
Add testing
2020-02-14 17:23:24 -08:00
Andrei Zavatski
7cb11be810
Merge remote-tracking branch 'refs/remotes/ppy/master' into subcomments-alter-new
2020-02-14 20:55:51 +03:00
smoogipoo
61d539dc67
Fix first playlist item not getting selected
2020-02-14 23:39:39 +09:00
smoogipoo
b92f1ad68d
Implement match subscreen re-design
2020-02-14 20:48:09 +09:00
smoogipoo
b762e5e8a5
Implement overlined components
2020-02-14 20:42:14 +09:00
smoogipoo
929eb4f035
Add match footer
2020-02-14 20:35:52 +09:00
smoogipoo
d5496321e2
Implement leaderboard chat display
2020-02-14 20:31:55 +09:00
smoogipoo
c75a774297
Extract participants list from the room inspector
2020-02-14 20:27:37 +09:00
smoogipoo
c0dba63278
Remove match info
2020-02-14 20:14:25 +09:00
Dean Herbert
73621e41fd
Forcefully hide mute notification for navigation tests
2020-02-14 20:12:23 +09:00
smoogipoo
b0793b06ed
Re-implement the match header
2020-02-14 20:10:36 +09:00
smoogipoo
1e80facfe8
Add subscreen test scene
2020-02-14 20:03:37 +09:00
smoogipoo
b5f048ce96
Merge branch 'match-songselect-playlist-logic' into match-subscreen-redesign
2020-02-14 19:59:15 +09:00
smoogipoo
0b86825d71
Merge branch 'match-playlist' into match-songselect-playlist-logic
2020-02-14 19:57:35 +09:00
smoogipoo
f31220c1ee
Fix exception when adding duplicate items
2020-02-14 19:56:43 +09:00
Dean Herbert
14f632b532
Merge branch 'master' into match-detail-area
2020-02-14 19:54:17 +09:00
Dean Herbert
e6676ffa51
Merge branch 'match-playlist' into match-detail-area
2020-02-14 19:53:46 +09:00
Dean Herbert
05c48cd929
Fix volume mute tests regressing
2020-02-14 19:27:32 +09:00
Dean Herbert
47325601f4
Add failing test
2020-02-14 19:16:08 +09:00
smoogipoo
fbc5ffbadb
Remove now unused members
2020-02-14 17:59:47 +09:00
smoogipoo
de646649de
Use test beatmap instead of beatmap manager
2020-02-14 17:59:14 +09:00
smoogipoo
32fd713a9d
Use test beatmap instead of beatmap manager
2020-02-14 17:57:25 +09:00
smoogipoo
f0f739707f
Add playlist support to match song select
2020-02-14 17:51:42 +09:00
smoogipoo
5ec9f454d5
Implement the match beatmap detail area
2020-02-14 17:20:38 +09:00
smoogipoo
aceba8791c
Clean up selection handling
2020-02-14 16:56:44 +09:00
smoogipoo
6a466ea2f5
Improve test cases
2020-02-14 16:48:30 +09:00
smoogipoo
d6768bba62
Make test playlist items unique
2020-02-14 16:09:30 +09:00
smoogipoo
5e871f9838
Make room playlist use the common rearrangeable design
2020-02-14 15:36:47 +09:00
Dean Herbert
b86b5e9adb
Move nested class to bottom of file
2020-02-14 15:27:39 +09:00
Dean Herbert
c34f1f40ea
Fix test text not being centered
2020-02-14 15:27:09 +09:00
Dean Herbert
aa7efe6141
Fix tests potentially failing due to timing issues
2020-02-14 15:26:55 +09:00
Dean Herbert
76cfe1f42c
Merge branch 'master' into online-container
2020-02-14 15:18:27 +09:00
smoogipoo
eb14dbcd77
Initial implementation of rearrangeable playlist
2020-02-14 15:01:45 +09:00
Lucas A
049b0d93d1
Add back default content fade transitions
2020-02-13 21:40:25 +01:00
Bartłomiej Dach
0f25864fae
Textbox -> TextBox rename pass
2020-02-13 21:04:53 +01:00
Bartłomiej Dach
5646083ed9
Adjust code style in test
2020-02-13 21:01:25 +01:00
Bartłomiej Dach
09b2e7beed
Encapsulate test editors
2020-02-13 20:56:34 +01:00
Bartłomiej Dach
cc625e3b89
Move initialisation logic to [SetUp]
2020-02-13 20:44:02 +01:00
Lucas A
dac0148c94
Apply review suggestions.
2020-02-13 20:08:14 +01:00
Dean Herbert
4a04b434a9
Merge branch 'master' into remove-current-item
2020-02-13 21:41:23 +09:00
Dean Herbert
b9a296d3f9
Merge branch 'master' into remove-current-item
2020-02-13 19:34:15 +09:00
Dean Herbert
28ca1a5bcc
Merge branch 'master' into participants-bindable
2020-02-13 19:31:50 +09:00
smoogipoo
bce9c8f3f3
Make room participants into a bindable list
2020-02-13 18:59:15 +09:00
Dean Herbert
e022352812
Merge pull request #7784 from smoogipoo/fix-beatmap-disposal
...
Fix disposal-related errors by making WorkingBeatmap non-disposable
2020-02-13 18:52:47 +09:00
Dean Herbert
49a1725749
Merge pull request #7812 from smoogipoo/playlist-bindables
...
Make playlist beatmap and ruleset into bindables
2020-02-13 18:51:42 +09:00
smoogipoo
75bef15583
Remove "current" multiplayer room item
2020-02-13 18:48:28 +09:00
smoogipoo
91edadfe9d
Make playlist beatmap and ruleset into bindables
2020-02-13 18:12:47 +09:00
smoogipoo
d4f14e552a
Improve extensibility of mod display expansion
2020-02-13 18:05:53 +09:00
Dean Herbert
6a2b3c5c02
Merge pull request #7733 from EVAST9919/rankings-overlay-spotlights
...
Add spotlight selector to RankingsOverlay
2020-02-13 13:14:02 +09:00
Andrei Zavatski
c391a464a5
Add tests
2020-02-13 04:06:34 +03:00
Andrei Zavatski
ec9c01a75f
Merge remote-tracking branch 'refs/remotes/ppy/master' into subcomments-alter-new
2020-02-12 23:32:28 +03:00
Andrei Zavatski
760be29015
Merge remote-tracking branch 'refs/remotes/ppy/master' into comment-editor
2020-02-12 13:23:35 +03:00
Dan Balasescu
9a9349a13a
Merge branch 'master' into adjust-beatmap-overlay
2020-02-12 16:52:42 +09:00
Dan Balasescu
866b6bb058
Merge branch 'master' into fix-song-select-weirdness
2020-02-12 15:01:15 +09:00
Andrei Zavatski
9ac6c271ac
Naming adjustments
2020-02-12 02:05:45 +03:00
Tree
b694b0c90c
Merge branch 'master' into adjust-beatmap-overlay
2020-02-11 21:07:26 +01:00
Andrei Zavatski
c022cf72b5
Implement CancellableCommentEditor
2020-02-11 20:47:51 +03:00
Lucas A
b9e10cb498
Privatize ViewTarget
2020-02-11 18:10:46 +01:00
Andrei Zavatski
829152c8e8
Implement EditorTextbox
2020-02-11 20:08:24 +03:00
Andrei Zavatski
482f622c94
CommentEditor basic implementation
2020-02-11 18:46:49 +03:00
Dean Herbert
333f976580
Fix test finding deleted beatmaps under dotnet-test
2020-02-11 17:47:10 +09:00
Andrei Zavatski
0b6558dc40
Add SpotlightsLayout to RankingsOverlay
2020-02-11 02:35:23 +03:00
Andrei Zavatski
b04a4b5c8a
Implement SpotlightsLayout
2020-02-11 01:44:56 +03:00
Andrei Zavatski
ed6a35cb9f
Merge remote-tracking branch 'refs/remotes/ppy/master' into rankings-overlay-spotlights
2020-02-11 00:18:11 +03:00
Andrei Zavatski
26afe0f31e
Add ability to load long comment trees in CommentsContainer
2020-02-10 15:43:11 +03:00
Dean Herbert
926cde9afc
Fix potential test failures
2020-02-10 18:17:59 +09:00
dependabot-preview[bot]
48781e5685
Bump Microsoft.NET.Test.Sdk from 16.4.0 to 16.5.0
...
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest ) from 16.4.0 to 16.5.0.
- [Release notes](https://github.com/microsoft/vstest/releases )
- [Commits](https://github.com/microsoft/vstest/compare/v16.4.0...v16.5.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-10 08:24:12 +00:00
smoogipoo
cef682aa03
Make WorkingBeatmap non-disposable
2020-02-10 17:02:01 +09:00
Dean Herbert
d61516e10c
Add failing tests
2020-02-10 16:59:54 +09:00
Bartłomiej Dach
7e28f2fe6a
Rename test to better reflect its purpose
2020-02-09 14:41:02 +01:00
Bartłomiej Dach
404cb61342
Open mod select in a more reliable way
2020-02-09 14:39:27 +01:00
ProTheory8
590429b43b
Now TestAutoOpenOnModSelect checks if customisation closes after deselecting mod
2020-02-09 14:15:32 +05:00
Lucas A
30e0a34e50
Wrap Content into a container for animating visibility.
2020-02-08 17:11:31 +01:00
Lucas A
7ca9f4dc20
Apply review suggestions
2020-02-08 17:11:31 +01:00
Lucas A
d3dc0b63ff
Remove string concatenation from ctor
2020-02-08 17:07:26 +01:00
Lucas A
6d51b344ab
Display a loading animation when the user is connecting
2020-02-08 17:07:20 +01:00
杜Nate
8d480c794a
Merge branch 'master' into spun-out
2020-02-08 13:54:39 +08:00
mcendu
a4637a24a6
fix test scene crash
2020-02-08 12:08:44 +08:00
mcendu
2d67215931
make target practice subject of unimplemented mod test
2020-02-08 12:07:21 +08:00
Dan Balasescu
7c715937ca
Merge branch 'master' into skin-animation-frame-rate
2020-02-07 23:52:45 +09:00
Andrei Zavatski
dc8dd24405
Merge remote-tracking branch 'refs/remotes/ppy/master' into rankings-overlay-spotlights
2020-02-07 11:49:31 +03:00
Dan Balasescu
5d6e007929
Merge branch 'master' into overlapping-scroll-origin
2020-02-07 16:44:34 +09:00
Dean Herbert
7460018cd3
Move combo colours to GlobalSkinColours
2020-02-07 14:58:07 +09:00
Bartłomiej Dach
5fde4f2c0c
Fix lifetime calculation in overlapping algorithm
...
Changes to lifetime calculation in scrolling rulesets introduced in
#7367 , which aimed to account for the distance between hit objects'
origin and its edge entering the scrolling area, fixed some issues with
hitobjects appearing abruptly, but also regressed some other scenarios.
Upon investigation, the regression was localised to the overlapping
scroll algorithm. The reason for this was two-fold:
* The previous code used TimeAt() to calculate the time of travel from
the hit object's edge to its origin. For other algorithms, that time
can be accurately reconstructed, because they don't have periods of
time where there are multiple hit objects scrolling at different
velocities.
That invariant does not hold for the overlapping algorithm, therefore
it is possible for different values to be technically correct for
TimeAt(). However, the only value that matters for the adjustment
is the one that's indicated by the control point that applies to the
hit object origin, which can be uniquely identified.
* Additionally, the offset returned (even if correct) was applied
externally to the hit object's start time and passed to
GetDisplayStartTime(). In the overlapping algorithm, the choice of
control point used in GetDisplayStartTime() is important, since
the value of the speed multiplier is read within.
Externally rewinding the hit object's start time meant that in some
cases the speed multiplier of the *previous* control point is applied,
which led to hit objects appearing too late if the scrolling rate
decreased.
Because of the above, modify GetDisplayStartTime() to take the offset
into account in all algorithms, and apply the adjustment correctly
inside of them. The constant and sequential algorithms needed no
adjustment from the previous logic, since:
* the constant algorithm disregarded control points, and
* the sequential algorithm would effectively rewind to time = 0,
calculate the absolute distance from time = 0 to the hit object start,
apply the origin offset *to the absolute distance*, and then convert
back to time, applying all control points in sequence. Due to this
it was impossible for control points to get mixed up while
calculating.
As for the overlapping algorithm, the high-level logic is as follows:
* The distance that the origin has to travel is the length of the scroll
plus the distance from the origin to the object edge.
* The above distance divided by the scroll length gives the relative
scroll lengths that the object has to travel.
* As one relative scroll length takes one time range, the relative
travel length multiplied by the time range gives the absolute travel
time of the object origin.
* Finally, the control point multiplier applicable at origin time is
applied to the whole travel time.
Correctness of the above is demonstrated by visual tests added before
and headless unit tests of the algorithms themselves. The sequential
scroll algorithm was not covered by unit tests, and remains uncovered
due to floating-point inaccuracies that should be addressed separately.
2020-02-06 23:13:28 +01:00
Bartłomiej Dach
12469469ad
Add reproduction test steps for lifetime bug
...
Modify TestSceneScrollingHitObjects to contain a test case that serves
as a reproduction for a visual bug in which using the overlapping scroll
algorithm results in an incorrect origin adjustment for lifetime.
2020-02-06 23:12:22 +01:00
Bartłomiej Dach
ecde641729
Randomise colours in scrolling test scene
...
Switch to using randomised colours in TestSceneScrollingHitObjects to
better distinguish individual hit objects.
2020-02-06 22:47:59 +01:00
Andrei Zavatski
5946ad7d80
Fix possible memory leak and better user change test support
2020-02-06 16:54:02 +03:00
Andrei Zavatski
0840033343
Merge remote-tracking branch 'refs/remotes/ppy/master' into logged-out-comments
2020-02-06 16:38:47 +03:00
Dean Herbert
0c30e802c0
Merge remote-tracking branch 'upstream/master' into rearrangeable-playlist
2020-02-06 17:40:28 +09:00
Dan Balasescu
edf20e2c3e
Merge branch 'master' into lounge-ruleset-filtering
2020-02-06 15:35:26 +09:00
Dan Balasescu
108de6ac56
Merge branch 'master' into editor-slider-repeat
2020-02-06 14:48:45 +09:00
Dean Herbert
d00b61de99
Merge branch 'master' into lounge-ruleset-filtering
2020-02-06 13:38:27 +09:00
Dean Herbert
94b6564b98
Merge branch 'master' into editor-slider-repeat
2020-02-06 13:16:39 +09:00
Dean Herbert
75eb9ca040
Merge pull request #7739 from peppy/fix-rooms-test-scene
...
Fix rooms test scene not displaying anything
2020-02-06 13:12:10 +09:00
Dean Herbert
49ec1d4a99
Fix braces style
2020-02-06 13:04:29 +09:00
Dean Herbert
43b22e3b63
Add a ruleset filtering test
2020-02-06 13:03:15 +09:00
Dean Herbert
d32bb79e5a
Add simple filtering test
2020-02-06 13:03:04 +09:00
Dan Balasescu
38bf14a06c
Merge branch 'master' into editor-beatmap-component
2020-02-06 12:25:33 +09:00
Dean Herbert
7f0a134bc8
Bring test scene structure up-to-date
2020-02-06 12:17:05 +09:00
Andrei Zavatski
00e010a061
Add visibility test for SpotlightSelector
2020-02-05 13:11:02 +03:00
Dean Herbert
09273d1da9
Fix test scene not correctly building a playable beatmap
2020-02-05 18:35:31 +09:00
Dean Herbert
dffc58c5fa
Add blueprint type to timeline test
2020-02-05 17:52:51 +09:00
Dean Herbert
96986bf5fc
Remove beat divisor from ctor and use DI instead
2020-02-05 17:48:21 +09:00
Andrei Zavatski
a3fd952f74
Use new SpotlightSelector in RankingsHeader
2020-02-05 11:21:23 +03:00
Andrei Zavatski
9347c3f535
Add trigger user change test
2020-02-05 11:13:32 +03:00
TheWildTree
ae467538d3
Fix tests
2020-02-04 22:39:51 +01:00
Andrei Zavatski
f8ad9476ef
Adjust test step name
2020-02-04 21:03:17 +03:00
Andrei Zavatski
f889f2435b
Add test step to TestSceneRankingsTable
2020-02-04 16:20:15 +03:00
Andrei Zavatski
5f63ef3bc1
Fix crashing test
2020-02-04 14:52:26 +03:00
Andrei Zavatski
524a8ba6c6
Merge remote-tracking branch 'refs/remotes/ppy/master' into rankings-overlay-update
2020-02-04 11:19:13 +03:00
smoogipoo
e4e0a26b62
Merge remote-tracking branch 'origin/master' into rearrangeable-playlist
2020-02-04 16:55:55 +09:00
Dan Balasescu
b4a90dc4ea
Merge branch 'master' into fix-key-counter-visible-on-reshowing-hud
2020-02-04 14:43:33 +09:00
Dan Balasescu
0e3c1ed0f7
Merge branch 'master' into fix-key-counter-visible-on-reshowing-hud
2020-02-04 14:06:23 +09:00
Dan Balasescu
75f5cb4871
Merge branch 'master' into rankings-overlay-update
2020-02-04 13:52:57 +09:00
Dan Balasescu
2b471be340
Merge branch 'master' into spotlights_api
2020-02-04 13:48:02 +09:00
Dan Balasescu
634364863d
Merge branch 'master' into beatmap-overlay-header
2020-02-04 13:13:57 +09:00
Dan Balasescu
3600b0daf0
Merge branch 'master' into fix-mod-select-overflowing
2020-02-04 11:57:54 +09:00
Salman Ahmed
0ccbffde8d
Use ChildrenOfType instead
2020-02-03 23:43:04 +03:00
Salman Ahmed
26a9d60437
Avoid exposing whenever possible
2020-02-03 23:17:10 +03:00
Andrei Zavatski
ad7f7343d7
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-overlay-header
2020-02-03 21:37:18 +03:00
Andrei Zavatski
824ee8a888
Recolour rankings tables
2020-02-03 21:22:37 +03:00
Andrei Zavatski
2a802307e7
Delete unused components
2020-02-03 20:59:08 +03:00
Andrei Zavatski
3b6ed3fb27
Use new header in the RankingsOverlay
2020-02-03 20:53:30 +03:00
Andrei Zavatski
588a77484b
Add ContryFilter to new header
2020-02-03 20:32:20 +03:00
Andrei Zavatski
b284170437
Basic implementation of new RankingsOverlayHeader
2020-02-03 20:20:35 +03:00
Salman Ahmed
4cd4055e7c
Rename to AlwaysVisible and add XMLDoc
2020-02-03 20:00:43 +03:00
Salman Ahmed
51ed289c59
Revert namings and behaviour changes
2020-02-03 19:59:58 +03:00
Andrei Zavatski
12574111e5
Use ColourProvider colours
2020-02-03 19:44:10 +03:00
Andrei Zavatski
e531570352
Merge remote-tracking branch 'refs/remotes/ppy/master' into spotlights_api
2020-02-03 19:34:35 +03:00
Dean Herbert
a365082a98
Fix potential nullref in UserDimBackgrounds tests
2020-02-03 22:18:07 +09:00
Salman Ahmed
351cb8ac1a
Rename Visible to HasReplayLoaded and change default value
...
Doesn't make sense to be true by default
2020-02-03 15:47:52 +03:00
Salman Ahmed
443063263e
Merge remote-tracking branch 'upstream/master' into fix-key-counter-visible-on-reshowing-hud
2020-02-03 15:18:25 +03:00
Andrei Zavatski
032c2c2afe
Refactor BeatmapRulesetSelector
2020-02-03 14:16:26 +03:00
Dan Balasescu
76ba0b833e
Merge pull request #7716 from EVAST9919/overlay-header-ruleset-selector
...
Add ability to create ruleset selector in OverlayHeader
2020-02-03 19:00:12 +09:00
