Joseph Madamba
8d83c78810
Fix casing on comment actions test
2022-12-18 21:12:38 -08:00
mk56-spn
f3873b73e3
Clean up syntax for readability
2022-12-16 20:56:34 +01:00
cdwcgt
a4d28aff6d
fix typo
2022-12-16 10:48:56 +09:00
cdwcgt
79e27c2d9d
PreviewTimePart will not show if preview time is -1
2022-12-16 10:44:07 +09:00
cdwcgt
984f0b5fa9
Add test for set preview point
2022-12-16 01:35:54 +09:00
mk56-spn
0c177aa7de
Improve tests, simplify "updateDisplay" method
2022-12-15 16:12:34 +01:00
Dean Herbert
57048f0eba
Add test coverage of featured artist filter confirmation process
2022-12-15 18:42:58 +09:00
Bartłomiej Dach
849245b90c
Merge branch 'master' into beginplaying-score-token
2022-12-13 17:15:24 +01:00
Dean Herbert
efe057176e
Make OsuButton abstract
2022-12-13 22:13:48 +09:00
mk56-spn
8efe7528e3
change ruleset source to avoid issues with converted beatmaps
2022-12-12 15:10:10 +01:00
Andrei Zavatski
890dd9cd06
Fix input doesn't take original drawable modifications into account
2022-12-12 15:10:03 +03:00
Andrei Zavatski
37a0756321
Add tests
2022-12-12 14:38:24 +03:00
mk56-spn
4d592184ca
temp cmt
2022-12-12 11:53:07 +01:00
mk56-spn
58bf081096
Fix judgement counter not loading after first attempt in gameplay, Fix typo in Display
2022-12-12 10:52:55 +01:00
Dan Balasescu
caa0b7c290
Move score token to BeginPlaying
2022-12-12 13:59:27 +09:00
mk56-spn
a107fca5d0
Hide "Full" option from counter flow directions
2022-12-12 00:33:28 +01:00
mk56-spn
161894da3b
Add more test checks and fix deserialisation test
2022-12-11 23:58:10 +01:00
mk56-spn
4c17b27273
Add Display, Counter, Tests
2022-12-11 23:47:17 +01:00
Dan Balasescu
e9998f1690
Store maximum statistics to spectator state
2022-12-09 20:15:07 +09:00
Dan Balasescu
4a65f5c864
Add score token to spectator state
2022-12-09 19:09:51 +09:00
OliBomby
10b5900710
made PathControlPointVisualiser generic
2022-12-07 10:13:40 +01:00
Bartłomiej Dach
0bfc46963b
Add failing test case
2022-12-06 23:25:35 +01:00
mk56-spn
c5bad816db
Add button colouring whilst corresponding overlay is present
2022-12-02 18:44:21 +01:00
Dan Balasescu
eea9bd3898
Merge pull request #21463 from peppy/fix-chat-system-message-ordering
...
Fix system messages appearing out of order in chat display
2022-12-02 17:39:20 +09:00
mk56-spn
d7cea51551
Add functionality of Random button
2022-12-01 16:29:52 +01:00
mk56-spn
1530495e7c
Add button "accent" colour, bottom bar, icon, text
2022-12-01 15:34:09 +01:00
mk56-spn
774eb178a1
Add basic button design and footer button addition flow
2022-12-01 13:13:37 +01:00
mk56-spn
18b4317e99
Create Basic V2 footer and test
2022-12-01 11:57:50 +01:00
Dan Balasescu
54c0b2c20c
Merge pull request #21466 from peppy/fix-song-progress-test-flaky
...
Attempt to fix flaky `TestHoldForMenuDoesWorkWhenHidden`
2022-12-01 00:22:46 +09:00
Dan Balasescu
59001205cf
Merge pull request #21465 from peppy/fix-replay-download-button-tests
...
Fix flaky test conditions in `TestSceneReplayDownloadButton`
2022-12-01 00:21:26 +09:00
ansel
1763618488
Fix spinner presense check & field click
2022-11-30 13:58:03 +03:00
ansel
a8422961dc
Rename button spinner prop again
2022-11-30 13:30:57 +03:00
ansel
f0922d34bb
Fix cancel test failure
2022-11-30 13:30:00 +03:00
Dean Herbert
1bb32ec24d
Attempt to fix flaky TestHoldForMenuDoesWorkWhenHidden
...
Seems like the most likely cause.
2022-11-30 17:35:51 +09:00
Dean Herbert
4a747182b4
Merge branch 'master' into comment-editor-1
2022-11-30 17:22:59 +09:00
Dean Herbert
c4b88e4e5a
Fix flaky test conditions in TestSceneReplayDownloadButton
2022-11-30 17:07:57 +09:00
Dean Herbert
6524914dbd
Merge branch 'master' into chat-profile-highlight-v2
2022-11-30 16:00:52 +09:00
Dean Herbert
78f70dae75
Merge pull request #21420 from cdwcgt/NowPlaying
...
Show mods, ruleset and unicode metadata in "now playing" chat command
2022-11-30 15:57:52 +09:00
Dean Herbert
9e34fe360a
Ensure all LocalMessages get a timestamp
2022-11-30 15:46:36 +09:00
Dean Herbert
b0039c9b1b
Add test coverage of incorrect system message ordering
2022-11-30 15:46:14 +09:00
Dean Herbert
b29054d30d
Merge pull request #21434 from jai-x/control-point-scroll-into-view
...
Ensure currently selected control point will scroll into view
2022-11-30 15:14:14 +09:00
Dean Herbert
d5301c75c1
Merge pull request #21460 from EVAST9919/triangles-v2-remove-texture
...
Remove texture usage in TrianglesV2 component
2022-11-30 15:13:08 +09:00
Dean Herbert
b5c514a8f0
Make incoming Channel target non-nullable
2022-11-30 14:30:20 +09:00
Dean Herbert
69bf0df179
Merge branch 'master' into NowPlaying
2022-11-30 14:27:37 +09:00
Dean Herbert
63ba40ff39
Merge branch 'master' into control-point-scroll-into-view
2022-11-30 14:12:19 +09:00
Dan Balasescu
fcd7c27bc2
Merge pull request #21451 from peppy/update-framework
...
Update framework
2022-11-30 13:39:08 +09:00
Andrei Zavatski
fa1000777d
Add box for gradient comparison
2022-11-30 05:12:26 +03:00
Andrei Zavatski
745cb0b13a
Improve test scene
2022-11-30 04:17:37 +03:00
Andrei Zavatski
3b13ca1167
Remove texture from TrianglesV2
2022-11-30 04:09:46 +03:00
Andrei Zavatski
c3b5b19c32
Make TrianglesV2 test scene consistent
2022-11-30 04:02:35 +03:00
ansel
84aaf5fedf
Change ways to access submit button state
2022-11-29 14:37:35 +03:00
ansel
6c126f5223
Remove useless local actions on click
2022-11-29 14:25:51 +03:00
ansel
cfffe5f002
Avoid null string
2022-11-29 14:20:38 +03:00
Dean Herbert
56a694fb04
Add automated test coverage of simple scenarios for RangeSlider
2022-11-29 15:10:21 +09:00
Bartłomiej Dach
24deb5f5f4
Remove all unnecessary usage of IHasFilterableChildren
2022-11-29 14:40:52 +09:00
ansel
d20dc3668e
Enable nullability
2022-11-29 05:17:44 +03:00
ansel
8b033bf9f7
Allow localisable strings
2022-11-29 05:13:54 +03:00
Alden Wu
0cb7c94c21
Merge branch 'master' of https://github.com/ppy/osu into chat-profile-highlight-v2
2022-11-28 17:59:15 -08:00
Alden Wu
c2d8ffc225
Refactor ChatLine username drawable creation
2022-11-28 17:50:12 -08:00
mk56-spn
db7f429e39
Fix partial class issues and adjust test slightly
2022-11-27 10:44:05 +01:00
mk56-spn
0aba119056
Merge remote-tracking branch 'origin/RangeSlider_implementation' into RangeSlider_implementation
...
# Conflicts:
# osu.Game.Tests/Visual/SongSelect/TestSceneDifficultyRangeFilterControl.cs
# osu.Game/Screens/Select/DifficultyRangeFilterControl.cs
2022-11-27 10:40:29 +01:00
Jai Sharma
8dcd1a2067
Add test to verify selected timing point will be scrolled into view
2022-11-27 02:48:15 +00:00
cdwcgt
54681217be
fix test
2022-11-27 10:53:00 +09:00
cdwcgt
e16f8a4410
Merge branch 'master' into NowPlaying
2022-11-27 08:48:49 +08:00
Bartłomiej Dach
212d78865a
Add a few more missing partial specs
2022-11-26 16:30:52 +01:00
Bartłomiej Dach
894ef15e79
Merge branch 'master' into update-framework
2022-11-26 16:19:36 +01:00
Dan Balasescu
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
mk56-spn
1ebaf4963d
Improve tests slightly
2022-11-26 13:59:05 +01:00
mk56-spn
92ed2ed4ef
Refactor star "DifficultyRangeFilterControl" into generic range slider class
2022-11-26 12:19:08 +01:00
Bartłomiej Dach
ca0597b38e
Merge branch 'master' into dont-change-ruleset-convert
2022-11-25 19:23:36 +01:00
Bartłomiej Dach
73176a1315
Merge branch 'master' into triangle-button-v2
2022-11-25 18:35:59 +01:00
cdwcgt
13f86f3e53
Merge branch 'master' into NowPlaying
2022-11-25 23:22:52 +09:00
cdwcgt
a2ea7a3f58
show selected mod and use ILocalisedBindableString in np
2022-11-25 23:20:44 +09:00
Dean Herbert
2425878e67
Add test coverage
2022-11-25 20:06:36 +09:00
Bartłomiej Dach
fca3e7e39f
Merge branch 'master' into editor-seek-control-points
2022-11-24 21:53:47 +01:00
Dean Herbert
ba0990d43e
Update test assumptions
2022-11-25 01:51:41 +09:00
Dean Herbert
53b03df93d
Combine TriangleButton and RoundedButton classes
2022-11-24 16:26:57 +09:00
Dean Herbert
40f706155f
Update RoundedButton to have new triangles design
2022-11-24 16:18:15 +09:00
Dean Herbert
44a71741e4
Merge pull request #21225 from EVAST9919/triangles-v2
...
Implement TrianglesV2 component
2022-11-24 16:15:25 +09:00
Dean Herbert
37f725bfa2
Reverse directionality of up/down traversal keys to match scroll
2022-11-24 13:55:58 +09:00
Bartłomiej Dach
2f67199b1c
Merge branch 'master' into fix-missing-day-separator
2022-11-23 18:40:44 +01:00
Bartłomiej Dach
cf5f5a4de3
Extend tap timing control test coverage in no point selected case
2022-11-23 17:25:34 +01:00
Bartłomiej Dach
06449b62f1
Add test coverage for crash scenario
2022-11-23 16:11:57 +01:00
Andrei Zavatski
2204af04e4
Improve test scene to better show colour gradient
2022-11-23 16:12:13 +03:00
Dean Herbert
9b9b8a5977
Add ability to seek between control points in editor using down/up arrows
...
Matches stable. Addresses #21376 .
2022-11-23 15:59:32 +09:00
Dean Herbert
172e798847
Merge pull request #21228 from Terochi/recent-messages-implementation
...
Add ability to view chat send history in input box
2022-11-23 14:58:42 +09:00
Bartłomiej Dach
39934bccd6
Add back removed test coverage
2022-11-22 19:47:41 +01:00
Bartłomiej Dach
76bb529cfa
Add test for local echo adding day separator
2022-11-22 16:46:21 +01:00
Dan Balasescu
6b75f529c7
Merge pull request #21366 from bdach/broken-rank-graph-test
...
Fix broken rank graph test
2022-11-22 14:35:14 +09:00
Bartłomiej Dach
41039340cf
Fix rank graphs not showing in test due to unset IsRanked
2022-11-21 21:00:06 +01:00
Bartłomiej Dach
1777a60136
Add failing assertions
2022-11-21 20:58:52 +01:00
Bartłomiej Dach
735cac3104
Rewrite rank graph test to use more modern style
2022-11-21 20:56:38 +01:00
Bartłomiej Dach
f36ccab84e
Merge branch 'master' into tablet-settings-test-scene
2022-11-21 20:42:04 +01:00
Bartłomiej Dach
ff5cb116f0
Fix weird scroll container sizing
2022-11-21 19:27:06 +01:00
Bartłomiej Dach
7944d9cefa
Merge pull request #21304 from EVAST9919/beatmap-bar
...
Rework BarGraph to use Quads
2022-11-21 16:24:18 +01:00
Terochi
d81ef541bc
Variant 5: cannot change history, edit resets index
2022-11-21 10:17:28 +01:00
Terochi
7dc7729ac2
Variant 4: cannot change history, empty text/everything selected resets index (current with bug fix)
2022-11-21 10:11:26 +01:00
Terochi
58288275a6
Variant 3: cannot change history, cannot reset index (the "default")
2022-11-21 09:43:36 +01:00
Terochi
672e1cd45b
Variant 2: edit changes history, cannot reset index (similar to stable)
2022-11-21 09:41:29 +01:00
Terochi
8f942f130b
Variant 1: edit changes history, empty text resets index
2022-11-21 09:36:31 +01:00
Andrei Zavatski
14a4de36f4
Expose thickness property
2022-11-21 10:20:35 +03:00
Dean Herbert
9a330c3cdb
Apply nullability and clean up conditionals
2022-11-21 15:02:45 +09:00
Dean Herbert
a07b033d22
Merge branch 'master' into triangles-v2
2022-11-21 14:55:01 +09:00
Dean Herbert
dfa92b3de9
Merge pull request #21326 from bdach/fix-phantom-beatmap-sets
...
Fix phantom beatmap sets appearing on carousel after delete/update
2022-11-21 13:25:14 +09:00
Dean Herbert
d0ff5be7e6
Fix TestSceneTabletSettings falling off the bottom of the screen
2022-11-21 12:15:43 +09:00
Bartłomiej Dach
1269afd0c5
Merge pull request #21307 from frenzibyte/disable-scroll-speed-on-osu
...
Hide scroll speed control from effects section on rulesets which don't support it
2022-11-20 16:17:55 +01:00
Salman Ahmed
793d5b117e
Fix timing screen test scene not creating editor beatmap properly
2022-11-20 15:20:35 +03:00
Bartłomiej Dach
b3667821eb
Add failing test case
2022-11-20 10:07:32 +01:00
Andrei Zavatski
6f449a583e
Handle empty values as a separate case
2022-11-19 23:27:48 +03:00
Terochi
eff6c7be64
Removed unnecessary methods, changed tests, and moved LimitedCapacityQueue.cs to a more generic namespace.
2022-11-19 16:53:35 +01:00
Bartłomiej Dach
c05c1625f2
Merge branch 'master' into editor-test-play-dont-retain-test-time
2022-11-19 12:09:04 +01:00
Salman Ahmed
ca67689a36
Fix intermittent present beatmap test failures
2022-11-19 07:44:43 +03:00
Bartłomiej Dach
d587f29351
Update tests to reflect desired behaviour
2022-11-18 21:03:30 +01:00
Salman Ahmed
8943819ee7
Add test coverage
2022-11-18 17:49:03 +03:00
Dean Herbert
b86b45b6d2
Fix excess string interpolation
2022-11-18 21:13:21 +09:00
Dawid Sośnia
9ad484a0f4
Merge branch 'ppy:master' into gameplay-leaderboard-fix
2022-11-18 12:11:22 +01:00
Dan Balasescu
9d33a6568e
Merge pull request #21292 from peppy/fix-binding-two-keys-single-binding
...
Fix being able to bind two non-modifier keys to the same binding
2022-11-18 16:19:38 +09:00
Dean Herbert
7c08cff297
Make new test more resilient to false passes
2022-11-18 16:10:32 +09:00
Dean Herbert
0a520c979e
Update test to split out per-type tests
2022-11-18 16:03:40 +09:00
Dean Herbert
3faa7f5f74
Merge branch 'master' into gameplay-leaderboard-fix
2022-11-18 15:44:30 +09:00
Dean Herbert
cb8275ee75
Add failing test coverage to TestSceneKeyBindingPanel for multiple non-modifiers being bound
2022-11-18 15:34:41 +09:00
Dean Herbert
45f5849301
Add more test coverage to TestSceneKeyBindingPanel
2022-11-18 15:33:14 +09:00
Dan Balasescu
57b8495c7a
Merge branch 'master' into long-standard
2022-11-18 14:24:04 +09:00
Salman Ahmed
82829867db
Fix beatmap options test failure due to no beatmap being selected
2022-11-18 07:07:56 +03:00
Dean Herbert
1ff1738988
Merge pull request #21244 from nanashi-1/beatmapoptions-disabled
...
Disable certain beatmap option buttons when there are no beatmaps selected
2022-11-18 12:55:07 +09:00
Dawid Sośnia
0dbf491872
Merge branch 'master' into gameplay-leaderboard-fix
2022-11-17 22:06:51 +01:00
Piggey
53769479c7
oh oops
2022-11-17 21:42:15 +01:00
Piggey
eb8f6626ab
revert changes from GameplayLeaderboard tests
2022-11-17 21:38:09 +01:00
Piggey
5e4ade3bee
add tests
2022-11-17 13:28:04 +01:00
Dragon
a25c94d567
Replacing structure to use LimitedCapacityQueue.cs
2022-11-17 13:07:06 +01:00
Dragon
a9747d367c
Cleaning up
2022-11-17 13:07:06 +01:00
Terochi
19dc31c7ae
Changed tests.
2022-11-17 13:07:06 +01:00
Terochi
5253f5309e
Added more tests for new features
2022-11-17 13:07:06 +01:00
Terochi
3d4962e181
Added functioning tests.
2022-11-17 13:07:06 +01:00
Terochi
a79af6671e
Added SetUp for new tests.
2022-11-17 13:07:06 +01:00
Salman Ahmed
039ab83a46
Disable beatmap options button when none selected
2022-11-17 04:00:23 +03:00
Salman Ahmed
0e46614c57
Revert beatmap option button state changes
2022-11-17 03:57:01 +03:00
Andrei Zavatski
13cf3fc40c
Make SpawnRatio public
2022-11-16 15:17:50 +03:00
Andrei Zavatski
bda32d71bf
Change test scene name
2022-11-16 14:53:55 +03:00
Andrei Zavatski
d94c624ee4
Merge branch 'master' into triangles-v2
2022-11-16 14:53:32 +03:00
nanashi-1
46c7451ede
remove redundant code
2022-11-16 09:57:23 +08:00
nanashi-1
9101ad0cbd
fixed naming
2022-11-16 09:42:40 +08:00
nanashi-1
7aec5ca1e8
visual tests
2022-11-15 20:57:42 +08:00
Andrei Zavatski
333165e052
Add test scene for Triangles
2022-11-15 10:54:37 +03:00
Dean Herbert
308ed1abd1
Fix number of judgements shown potentially exceeding upper limit
2022-11-15 12:31:25 +09:00
Andrei Zavatski
81c9ea98e2
Implement TrianglesV2 component
2022-11-13 15:31:48 +03:00
maromalo
1911120afe
Merge branch 'master' into long-standard
2022-11-12 09:52:11 -03:00
Dean Herbert
dde09d409b
Merge branch 'master' into chat-silences
2022-11-12 21:00:56 +09:00
Dean Herbert
8154eaafd8
Merge pull request #20991 from smoogipoo/websocket-chat-2
...
Receive chat messages via notification websocket
2022-11-12 18:18:39 +09:00
Bartłomiej Dach
b0314c67aa
Fix failing gameplay bindings test
2022-11-12 14:16:46 +09:00
Dean Herbert
19876ca0fb
Merge branch 'master' into websocket-chat-2
2022-11-11 23:53:42 +09:00
Bartłomiej Dach
63270c8619
Merge branch 'master' into improve-ui-control-sound-sync
2022-11-11 05:50:28 +01:00
Dean Herbert
3547c04002
Merge branch 'master' into skinnable-things-cleanup
2022-11-10 12:09:32 +09:00
Joseph Madamba
2b81f3048c
Merge branch 'master' into close-side-overlays-when-main-overlay
2022-11-09 12:48:57 -08:00
Salman Ahmed
3909e5730e
Rename test steps
...
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2022-11-09 21:33:28 +03:00
Dean Herbert
e19ba65f91
Remove LookupName from base ISkinComponentLookup
2022-11-09 17:46:43 +09:00
Dean Herbert
1aa0e40f2f
Add "Component" prefix to lookup naming
2022-11-09 17:46:43 +09:00
Dean Herbert
e75c3b3f94
Rename SkinnableTarget to GlobalSkinLookup
2022-11-09 17:46:43 +09:00
Dean Herbert
c908969d9b
Rename ISkinComponent to ISkinLookup
2022-11-09 17:46:43 +09:00
Dawid Sośnia
9549e55ef8
Merge branch 'ppy:master' into gameplay-leaderboard-fix
2022-11-08 20:04:13 +01:00
Piggey
9da57c66a2
add visual tests
2022-11-08 20:03:09 +01:00
Dean Herbert
b166e477c2
Merge branch 'master' into editor-background
2022-11-08 17:18:34 +09:00
Dean Herbert
4c15794694
Add test coverage of overlay interplay
2022-11-08 14:58:57 +09:00
maromalo
b7ef9b176d
Make score type consistent
2022-11-06 19:59:27 -03:00
Dean Herbert
ee68f33e3c
Merge pull request #21109 from frenzibyte/fix-beatmap-duplicating-again
...
Fix beatmap cards still potentially showing twice in listing
2022-11-06 18:46:31 +09:00
Dan Balasescu
fa18b5f701
Construct notifications client inside ChannelManager
2022-11-04 18:51:00 +09:00
Dean Herbert
eb836269e7
Allow testing settings panel with interactivity by default
2022-11-04 18:50:17 +09:00
Dean Herbert
566738494f
Merge pull request #20952 from OliBomby/bezier-convert
...
Add conversion algorithm for lazer slider curves to work with stable
2022-11-04 16:49:51 +09:00
Dean Herbert
dd5a3b2bf3
Add one more complex test
2022-11-04 16:49:21 +09:00
Joseph Madamba
e11d44d14f
Add url clicking support to profile badges
2022-11-03 18:12:32 -07:00
Salman Ahmed
37b5f48911
Adjust test scene to cover failure
2022-11-04 03:23:33 +03:00
Dean Herbert
1edde8f73c
Merge branch 'master' into disabled-button-sfx
2022-11-03 20:27:41 +09:00
Dean Herbert
cdb3494418
Merge pull request #20765 from Feodor0090/comment-report
...
Implement comments reporting
2022-11-03 20:09:00 +09:00
Dean Herbert
486515ed90
Merge pull request #20758 from frenzibyte/maintain-common-mod-selection
...
Maintain selection of common mods when switching rulesets
2022-11-03 20:08:32 +09:00
Jamie Taylor
f1c17129eb
Add support for 'disabled' sample variation to HoverClickSounds
2022-11-03 17:47:49 +09:00
Dean Herbert
c48c9ecb6d
Merge pull request #20743 from frenzibyte/improve-beatmap-card-buttons
...
Improve clickable area of beatmap card icon buttons
2022-11-03 15:47:08 +09:00
Dean Herbert
e6c45b8ab5
Merge branch 'master' into comment-report
2022-11-03 15:35:42 +09:00
Dean Herbert
20dd405c2b
Merge branch 'master' into maintain-common-mod-selection
2022-11-03 15:32:40 +09:00
Dean Herbert
fb0bc597a0
Merge branch 'master' into improve-beatmap-card-buttons
2022-11-03 13:53:29 +09:00
Dean Herbert
5f2f6b84b2
Add failing test coverage of automated skip scenarios
2022-11-03 13:52:27 +09:00
Dean Herbert
aef3c7918c
Add total skip count to SkipOverlay
2022-11-03 13:52:24 +09:00
Dean Herbert
0e502de8b4
Rename field to match usage
2022-11-02 18:04:42 +09:00
Dean Herbert
c3eb0c6330
Merge branch 'master' into editor-background
2022-11-02 17:43:38 +09:00
Dan Balasescu
f688ed12d0
Add test for removing chat messages
2022-11-02 17:00:47 +09:00
Dan Balasescu
695104a666
Fix TestSceneChatOverlay messages not being unique
2022-11-02 16:59:03 +09:00
Dean Herbert
2b04e852be
Merge branch 'master' into websocket-chat-2
2022-11-02 14:56:13 +09:00
Dan Balasescu
5b25ef5f2f
Construct notifications client via IAPIProvider
2022-11-01 21:34:34 +09:00
Dean Herbert
2a88409dfe
Fix time snap of sliders not matching when SV is not 1.0x
...
This regressed with https://github.com/ppy/osu/pull/20850 because the
function was used in other places which expect it to factor slider
velocity into the equation.
Rather than reverting, I've added a new argument, as based on the method
naming alone it was hard to discern whether SV should actually be
considered.
The reason for the change in #20850 was to avoid the SV coming in from a
reference object which may not have a correct SV in the first place. In
such cases, passing `false` to the function will give the expected
behaviour.
2022-11-01 15:12:58 +09:00
Dean Herbert
17f482bfc3
Merge branch 'master' into websocket-chat-2
2022-10-31 16:11:58 +09:00
Dean Herbert
e38ba5e4c6
Apply nullability to new test scene
2022-10-31 15:46:57 +09:00
Dean Herbert
31ba77e378
Merge branch 'master' into bezier-convert
2022-10-31 15:41:08 +09:00
Dean Herbert
8399261c77
Add failing test showing hold for menu not working when HUD is hidden
2022-10-30 21:38:31 +09:00
Dean Herbert
f5e11343c2
Apply nullability to HUD test scene
2022-10-30 21:25:31 +09:00
Dan Balasescu
169bcc2654
Use polling connector in tests
2022-10-28 18:08:08 +09:00
Dean Herbert
f9d2c30c3e
Add user toggle for application of safe areas
2022-10-28 14:05:45 +09:00
Bartłomiej Dach
f787da892b
Merge branch 'master' into grid-momentary-shortcuts
2022-10-26 21:30:24 +02:00
OliBomby
86d5fcc26d
Added tests
2022-10-26 19:30:42 +02:00
cdwcgt
6991195d69
let editor dim different from gameplay dim
2022-10-26 15:22:57 +09:00
Dean Herbert
7249542167
Merge pull request #20912 from LittleEndu/carousel-do-not-select-random
...
Make beatmap carousel select nearest to selection when selection was filtered
2022-10-26 11:40:56 +09:00
Bartłomiej Dach
48057412f5
Merge branch 'master' into grid-momentary-shortcuts
2022-10-25 22:17:08 +02:00
Bartłomiej Dach
bcdf24b972
Merge branch 'master' into add-editor-object-clone
2022-10-25 21:33:52 +02:00
Bartłomiej Dach
3d31c9bbc5
Merge branch 'master' into beat-snap-divisor-hotkey
2022-10-25 20:32:32 +02:00
Dean Herbert
2b850694fa
Merge branch 'allow-distance-grid-snap' into grid-momentary-shortcuts
2022-10-25 14:10:45 +09:00
Dean Herbert
8e4f5381e3
Add top level test coverage of editor shortcuts
2022-10-25 12:03:46 +09:00
Dean Herbert
1b42f5ec6e
Add test coverage of BeatDivisorControl key bindings
2022-10-25 11:51:31 +09:00
Dean Herbert
4d4f6e25ba
Rename to "clone" instead of "duplicate"
2022-10-25 11:43:23 +09:00
Dean Herbert
da74690ec9
Add test coverage of clone operations
2022-10-25 11:38:58 +09:00
Dan Balasescu
f6f30eec0b
Merge pull request #20810 from peppy/scoring-test-scene
...
Add test scene as environment to test changes to score algorithms
2022-10-25 11:19:00 +09:00
Endrik Tombak
b95091fbb0
Move test to improve diff readability
2022-10-24 22:55:09 +03:00
Endrik Tombak
9def12c60b
Write new tests
2022-10-24 22:50:56 +03:00
Dean Herbert
f08270f6b0
Fix incorrect maxBaseScore accounting due to silly oversight
2022-10-24 15:54:09 +09:00
Dean Herbert
247cf589aa
Merge branch 'master' into directoryselector-hidden-toggle
2022-10-24 15:33:10 +09:00
Salman Ahmed
90a9961a69
Add visual test case for report button
...
Makes it much easier to test button/popover design changes
2022-10-22 02:50:59 +03:00
ansel
15aeb4a137
Display text in buttons flow instead of toast
2022-10-21 17:25:41 +03:00
Dan Balasescu
703a8afb11
Merge pull request #20809 from peppy/fix-taiko-broken-drum-roll-ticks
...
Fix taiko drum roll ticks sometimes overflowing outside the drum roll itself
2022-10-21 12:56:14 +09:00
ansel
81bdf716ef
Change test
2022-10-20 19:56:00 +03:00
Dean Herbert
6b26547d03
Merge pull request #20835 from frenzibyte/improve-hide-mouse-on-keyboard
...
Improve automatic cursor hiding logic and limit to gameplay screen
2022-10-20 11:44:20 +09:00
Salman Ahmed
212f15e2d2
Update existing test cases
2022-10-20 04:06:33 +03:00
Dean Herbert
2f8a4fd2d0
Merge branch 'master' into remove-current-item
2022-10-20 10:02:09 +09:00
Dean Herbert
bea136ce50
Adjust test assert ordering to read better
2022-10-19 23:59:40 +09:00
Dean Herbert
579d5b51eb
Add and consume sample bank constants
2022-10-19 20:47:58 +09:00
Dean Herbert
f23bc484dc
Use better method of positioning mouse over visual settings area
2022-10-18 19:15:11 +09:00
Dean Herbert
d5666ca717
Add tooltip display of current values
2022-10-18 19:04:02 +09:00
Dean Herbert
d92aca7c22
Fix scoreV2 being higher than intended
2022-10-18 18:30:18 +09:00
Dean Herbert
74e1b5794b
Add ability to add "OK" or 100s via right click
2022-10-18 18:27:05 +09:00
Dean Herbert
a7b3aa62fb
Move lines to background to better visualise graphs at points of change
2022-10-18 18:13:13 +09:00
Dean Herbert
74986e0c8c
Show final scores and change colouring again
2022-10-18 18:07:42 +09:00
Dean Herbert
4b2fe72a90
Add stable v2 algorithm
2022-10-18 18:02:42 +09:00
Dean Herbert
743ae10df5
Improve colouring
2022-10-18 17:50:59 +09:00
Dean Herbert
7360cca047
Add stable v1 algorithm
2022-10-18 17:50:58 +09:00
Dean Herbert
d694c8b771
Move test scene more correctly into visual folder
2022-10-18 17:10:53 +09:00
Dean Herbert
ec3761ced9
Standardise control point search logic in OverlappingScrollAlgorithm
...
Was using a very local algorithm which I cannot guarantee is correct.
I'd rather it just use the one used everywhere else.
2022-10-18 16:01:05 +09:00
ansel
3258a41ca3
Merge branch 'comment-report' of https://github.com/Feodor0090/osu into comment-report
2022-10-17 20:41:46 +03:00
ansel
18cc3b0bd3
Fix reason not set in test
2022-10-17 20:23:25 +03:00
Feodor0090
6efe7b5334
Merge branch 'master' into comment-report
2022-10-17 16:08:13 +03:00
ansel
3bcc91511f
Update test
2022-10-17 13:46:13 +03:00
Dan Balasescu
28277dd880
Fix tests
2022-10-17 19:34:05 +09:00
ansel
e1785f73a2
Make report's comment not optional
2022-10-16 20:14:05 +03:00
Salman Ahmed
841e20c336
Remove unused usings
2022-10-15 17:16:08 +03:00
Salman Ahmed
7d53d35bf6
Remove duplicate & outdated test case
2022-10-15 16:23:54 +03:00
Salman Ahmed
421b81b6ca
Fix broken test case
2022-10-15 00:41:14 +03:00
Salman Ahmed
45f590ca43
Add test case for hiding cursor on idle
2022-10-15 00:20:22 +03:00
Salman Ahmed
97c4282e55
Add test cases for hiding cursor on keyboard input
2022-10-15 00:20:22 +03:00
Salman Ahmed
ba72f13f54
Merge branch 'master' into hide-mouse-on-keyboard-input
2022-10-14 22:26:30 +03:00
Feodor0090
fb046e31c1
Merge branch 'master' into comment-report
2022-10-14 16:57:23 +03:00
ansel
dc0aa2295a
Add test
2022-10-14 16:51:48 +03:00
ansel
c65a8a83f3
Add basic UI for reporting
2022-10-14 15:52:09 +03:00
Dan Balasescu
10aabfc650
Merge pull request #20739 from peppy/settings-toolbox
...
Adjust visuals of settings toolboxes (gameplay loading screen and editor)
2022-10-14 20:31:05 +09:00
Salman Ahmed
3e5e717fce
Add failing test cases
2022-10-14 02:00:11 +03:00
Bartłomiej Dach
df66a0c2e9
Fix flaky update beatmap set test
...
It is generally not possible to click a button that's not yet there,
and it turns out that when the test in question is ran headless, it may
not necessarily be there immediately.
2022-10-13 21:03:52 +02:00
Salman Ahmed
6c316bcc9e
Make beatmap card icon buttons fill up to the area
2022-10-13 16:09:54 +03:00
Dean Herbert
6608ada925
Fix test failures due to missing colour provider dependency
2022-10-13 17:05:11 +09:00
Dean Herbert
0f4a2a6059
Improve feel of settings toolbox group
2022-10-13 16:36:19 +09:00
Dean Herbert
ebc1088457
Merge pull request #20729 from frenzibyte/update-local-confirmation-dialog
...
Request user confirmation on updating locally-modified beatmaps
2022-10-13 12:36:37 +09:00
Salman Ahmed
7db7bcc283
Add test coverage
2022-10-13 02:40:20 +03:00
Feodor0090
565de23222
Fix CQ (non-readonly field)
2022-10-12 21:26:33 +03:00
Dean Herbert
00d8398056
Update test scene to allow seeing loading spinner
2022-10-12 15:48:42 +09:00
Dean Herbert
47fe4eb0bd
Merge branch 'master' into comment-deletion
2022-10-12 15:48:26 +09:00
Salman Ahmed
9b45a9cf76
Rename various cursor symbols
...
- `IProvideCursor.MenuCursor` -> `IProvideCursor.Cursor`
- `MenuCursor` -> `MenuCursorContainer
2022-10-11 16:21:01 +03:00
Dan Balasescu
88e82d3154
Merge pull request #20681 from peppy/fix-hidden-hud-interaction
...
Fix HUD components being interactive even when the HUD is visually hidden
2022-10-11 17:19:27 +09:00
Dan Balasescu
ccab04d141
Merge pull request #20645 from frenzibyte/flag-markdown
...
Add support for inline country flags in wiki overlay
2022-10-11 14:01:24 +09:00
Dean Herbert
cb21126623
Merge pull request #20586 from ekrctb/time-based-selection
...
Use hit object time for timeline drag selection instead of relying on blueprint
2022-10-11 13:20:15 +09:00
Dean Herbert
d700040a0d
Make country code parsing resilient to invalid cases
2022-10-11 01:39:53 +09:00
Dean Herbert
f6a8cc3f32
Add test showing broken input in HUD overlay when hidden
2022-10-10 16:05:41 +09:00
Salman Ahmed
0309751d55
Add test coverage
2022-10-08 21:50:31 +03:00
Salman Ahmed
13083813bd
Update hardcoded article page
2022-10-08 21:50:25 +03:00
ansel
e7b1f369a3
Revert unwanted changes in other tests
2022-10-08 18:55:58 +03:00
ansel
c384093802
Update main test and add failure scenario test
2022-10-08 18:53:41 +03:00
ansel
6e82ffbc6f
Add check for spinner
2022-10-08 17:41:51 +03:00
ansel
c11258a7e9
Tidy up test reloading
2022-10-08 17:20:25 +03:00
ansel
abf56c27a1
Do not requere dialog overlay
2022-10-08 17:11:09 +03:00
Dean Herbert
4980e53c9c
Merge pull request #20376 from goodtrailer/smoke
...
Add cursor "smoke" trails
2022-10-07 03:41:07 +09:00
ekrctb
0ade049252
Add test for selected hit object blueprint
2022-10-06 14:02:49 +09:00
ekrctb
2a7476cc4a
Add test for timeline drag selection
2022-10-05 23:29:45 +09:00
Dan Balasescu
c52ddb0e50
Merge pull request #20570 from ekrctb/scrolling-lifetime
...
Compute lifetime start from entry for scrolling hit objects
2022-10-05 20:45:43 +09:00
Dean Herbert
365a78d358
Merge branch 'master' into smoke
2022-10-05 18:58:18 +09:00
Dean Herbert
4f084664ac
Merge branch 'master' into comment-deletion
2022-10-05 14:34:50 +09:00
Dean Herbert
c7d645b086
Merge branch 'master' into fix-gameplay-leaderboard-overlap
2022-10-05 14:15:50 +09:00
ekrctb
15d159a97e
Fix tests
2022-10-04 16:10:18 +09:00
ekrctb
781f5420b0
Add test for scrolling hit object lifetime
2022-10-04 15:17:11 +09:00
Dean Herbert
0bac5ef465
Merge branch 'master' into smoke
2022-10-03 21:29:42 +09:00
Dean Herbert
7fbbe88c8e
Add test coverage of song select score presentation failures
2022-10-03 20:29:44 +09:00
Dean Herbert
42aac16b37
Adjust leaderboard score panels sizing based on accuracy/combo width
2022-10-03 18:12:36 +09:00
Dean Herbert
4dbac917fc
Merge pull request #20547 from nanashi-1/solo-gameplay-leaderboard-max-combo
...
Display highest combo rather than current combo for local play on leaderboard
2022-10-03 16:57:05 +09:00
Dean Herbert
492f26c832
Update test step in line with new combo source
2022-10-03 16:56:32 +09:00
Salman Ahmed
b6701dd578
Add failing test case
2022-10-02 15:29:53 +03:00
ansel
85adfc2df7
Fix DI type
2022-09-28 18:26:36 +03:00
ansel
7645fe20f5
Merge branch 'master' into comment-deletion
2022-09-28 17:55:22 +03:00
ansel
965e7bf265
Check local deletion in test
2022-09-28 17:52:12 +03:00
Dan Balasescu
f318452510
Merge pull request #20503 from peppy/change-default-skin
...
Change default skin for new installations to "Argon"
2022-09-28 18:34:40 +09:00
Dean Herbert
baa9e0441f
Merge pull request #20428 from frenzibyte/fix-update-progress-notification
...
Fix update progress notification not closing on completion
2022-09-28 17:43:45 +09:00
Dean Herbert
8edb1cb98a
Add test coverage of current score staying on screen
2022-09-28 15:57:50 +09:00
ansel
4013c96ca5
Fix test failures
2022-09-27 22:40:53 +03:00
ansel
5282c8b8c6
Fix CQ
2022-09-27 19:40:18 +03:00
ansel
2f551be1be
Implement tests
2022-09-27 19:03:02 +03:00
ansel
710f9e8f58
Setup a test scene
2022-09-27 18:11:27 +03:00
Dean Herbert
ed0752a5f1
Update test assumptions
2022-09-27 21:55:54 +09:00
Dean Herbert
87a1e05641
Remove unused using statement
2022-09-27 15:06:05 +09:00
Dean Herbert
4260ace1a6
Fix test coverage
2022-09-27 15:01:21 +09:00
nanashi-1
214a1c2d7f
code factor
2022-09-26 21:26:13 +08:00
nanashi-1
1fab1db145
move test
2022-09-26 21:11:48 +08:00
nanashi-1
4295d9c169
revert
2022-09-26 21:11:14 +08:00
nanashi-1
5c132aadeb
add visual test
2022-09-26 20:15:17 +08:00
Dan Balasescu
836da6a5e6
Merge pull request #20485 from peppy/leaderboard-nrt
...
Apply NRT to leaderboard hierarchy
2022-09-26 18:53:37 +09:00
Dean Herbert
0f18bef3f3
Fix incorrect test assumptions
2022-09-26 17:59:39 +09:00
Dan Balasescu
c969afcb71
Merge branch 'master' into leaderboard-nrt
2022-09-26 17:12:19 +09:00
Dean Herbert
a1297af441
Apply NRT to base Leaderboard classes
2022-09-26 16:12:47 +09:00
Dean Herbert
82d4689716
Add failing test showing progress notifications can be flung and cancelled
2022-09-26 14:33:12 +09:00
o-dasher
ced7212660
Fixes syntax error
2022-09-25 16:33:39 -04:00
o-dasher
a9318e5c04
Fixes small oversight
...
was applying a value when it wasn't supposed to be applied.
2022-09-25 16:32:16 -04:00
o-dasher
feadac1f79
Cleanup all other leftover binding instantiation
2022-09-25 16:02:40 -04:00
Salman Ahmed
4bd92b89bc
Change test scene to ensure progress notification is closed on completion
2022-09-23 16:29:19 +03:00
Dan Balasescu
1d1012e196
Merge pull request #20286 from peppy/gameplay-leaderboards
...
Add basic gameplay leaderboard display
2022-09-22 21:16:12 +09:00
Dan Balasescu
445e026a32
Merge pull request #20389 from peppy/fix-gameplay-leaderboard-layout
...
Fix gameplay leaderboard sometimes not showing up
2022-09-22 20:51:54 +09:00
Dean Herbert
1ed4b9c11c
Add more flexibility to test
2022-09-22 15:45:30 +09:00
Dean Herbert
ae70b2c32f
Fix other weirdness in variable and description naming
2022-09-22 15:21:27 +09:00
Dean Herbert
19db7c5977
Remove "Opacity" setting
...
This should be implemented at a higher level
2022-09-22 15:19:01 +09:00
Dean Herbert
f3898da37a
Rename judgement count to not mention "shape"
2022-09-22 15:18:20 +09:00
Dean Herbert
e48fe3a9e2
Add nullability to test scene
2022-09-22 15:17:37 +09:00
Dean Herbert
7d93fa9f65
Merge branch 'master' into Colour_hit_meter_improved
2022-09-22 15:11:58 +09:00
Dean Herbert
1ef09f2ae1
Fix regression in TestSceneSongProgress
2022-09-21 23:26:25 +09:00
Dean Herbert
0996051271
Order test scores more correctly
2022-09-21 15:03:06 +09:00
Dean Herbert
29c4d06d36
Merge branch 'fix-gameplay-leaderboard-layout' into gameplay-leaderboards
2022-09-21 14:58:58 +09:00
Dean Herbert
5cc2721e9a
Add failing test showing layout failure in gameplay leaderboard
2022-09-21 14:42:02 +09:00
Dan Balasescu
8bf196d561
Merge pull request #20354 from peppy/default-skin-refactor
...
Rename default skin to make way for new version
2022-09-21 11:48:38 +09:00
Salman Ahmed
29fa868fde
Fix test scene not resetting mouse position
...
Also fixes until step flipped.
2022-09-21 03:05:44 +03:00
Salman Ahmed
8b918d29fc
Add failing test case
2022-09-21 00:15:50 +03:00
Dean Herbert
ff56821152
Change SkinnableHUDComponentTestScene to show new HUD twice
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2022-09-21 00:24:29 +09:00
Dean Herbert
8837618ab1
Merge pull request #20342 from smoogipoo/server-shutdown-countdown
...
Implement server shutdown countdown + notification
2022-09-20 20:51:16 +09:00
Dean Herbert
fc6ab9c6a9
Add test coverage of shutdown notifications
2022-09-20 17:42:39 +09:00
Dan Balasescu
2499493347
Merge pull request #20375 from peppy/fix-score-reference-leak
...
Fix mods potentially keeping reference to runtime gameplay elements
2022-09-20 16:26:31 +09:00
Dean Herbert
b5771ece41
Reduce the amount by which clicking the mute notification incraeses volume
2022-09-20 13:00:08 +09:00
Alden Wu
c3b8e1d718
Fix test and spawn smoke immediately
2022-09-19 10:16:05 -07:00
Dean Herbert
41e7d271d7
Remove redundant string interpolation
2022-09-19 21:51:54 +09:00
Dean Herbert
2b1c5b2c4a
Fix test failure due to triangle skin no longer being null intests
2022-09-19 12:34:50 +09:00
Dean Herbert
454125123d
Add failing test coverage showing mod reference leak path
2022-09-19 12:18:35 +09:00
Salman Ahmed
a413c7a3e6
Merge branch 'master' into fix-notification-count
2022-09-19 02:08:20 +03:00
Dean Herbert
d0b8409de5
Apply more renames
2022-09-18 18:19:00 +09:00
Drison64
c075d3de08
Create a test and a check if initial zoom value of ZoomableScrollContainer is in range
2022-09-17 22:43:40 +02:00
Dean Herbert
41e69fbca6
Remove "default" prefix from naming
2022-09-18 00:15:26 +09:00
Dean Herbert
51841988bf
Rename references to DefaultSkin to have Triangles suffix
2022-09-17 23:57:25 +09:00
Dean Herbert
4c4fdfd153
Provide scores directly to Player instance rather than relying on DI
2022-09-16 18:15:17 +09:00
Dean Herbert
0ff4e343f8
Add failing test showing incorrect unread notification count
2022-09-16 16:29:54 +09:00
Dean Herbert
0227eddda1
Merge branch 'master' into gameplay-leaderboards
2022-09-16 15:44:58 +09:00
Dan Balasescu
fcba917419
Merge pull request #20320 from peppy/skin-transformers
...
Allow skin transformers to be created for all skins
2022-09-16 12:58:46 +09:00
Dan Balasescu
f86bbaae30
Merge branch 'master' into mods-effect-displays
2022-09-15 21:17:58 +09:00
Dean Herbert
c7f8f948b9
Rename CreateLegacySkinProvider to CreateSkinTransformer and apply to all skins
2022-09-15 20:18:10 +09:00
Dan Balasescu
96a89f4fca
Merge pull request #20319 from peppy/remove-ef-migration
...
Remove all entity framework code and migrations
2022-09-15 19:15:23 +09:00
Dean Herbert
ea513c539b
Merge pull request #20303 from peppy/hitobject-entry-nesting-stoled
...
Fix editor performance drop over time due to lingering nested object references
2022-09-15 17:15:01 +09:00
Dean Herbert
40a60f7145
Remove all entity framework code and migrations
2022-09-15 16:58:58 +09:00
Dan Balasescu
0329601e84
Fix inspection
2022-09-15 16:09:27 +09:00
Salman Ahmed
9824d09d49
Add test coverage
2022-09-15 04:30:09 +03:00
Dan Balasescu
ef6d60ffe9
Merge pull request #20273 from frenzibyte/duplicate-beatmap-listing-cards
...
Fix beatmap listing potentially showing duplicate beatmap cards
2022-09-14 10:25:24 +09:00
Dan Balasescu
4a49433e2e
Merge branch 'master' into notification-fling-right
2022-09-13 20:01:56 +09:00
Dean Herbert
566a61e770
Merge pull request #20244 from peppy/notification-fling
...
Add ability to "fling" notifications to dismiss them
2022-09-13 19:50:34 +09:00
Dean Herbert
6d167070f8
Add back DI leaderboard retrieval via bindable pathway
2022-09-13 18:45:11 +09:00
Dean Herbert
d2b80645ab
Change Leaderboard to use IUser instead of APIUser
2022-09-13 18:00:21 +09:00
Salman Ahmed
fed9a47866
Add test coverage
2022-09-13 18:00:21 +09:00
Dean Herbert
27a81dfb9f
Merge pull request #20270 from OliBomby/fix-selectionblueprint-order
...
Fixed HitObjectOrderedSelectionContainer being able to become unsorted and causing crashes
2022-09-13 17:18:58 +09:00
Dan Balasescu
53ac9dbc38
Merge branch 'master' into notification-fling
2022-09-13 17:07:16 +09:00
Dean Herbert
608c893b23
Add basic test guarantees
2022-09-13 15:03:13 +09:00
Salman Ahmed
a6f68e4a90
Fix NRT inspections
2022-09-13 03:08:13 +03:00
OliBomby
a1f4724685
moved the location of the tests
2022-09-13 01:38:29 +02:00
Salman Ahmed
a5b962d9a3
Add failing test case
2022-09-13 01:37:23 +03:00
Dean Herbert
88107108ee
Add ability to flick notifications to the right to store for later
2022-09-12 20:20:57 +09:00
Dean Herbert
802c5629c0
Merge branch 'master' into notification-fling
2022-09-12 20:09:21 +09:00
Dean Herbert
cb6d02ec3a
Merge pull request #19066 from andy840119/remove-the-nullable-disable-in-the-ruleset
...
Remove the nullable disable annotation in the ruleset class
2022-09-12 19:07:23 +09:00
Dean Herbert
f56f6545c0
Add test coverage of flinging
2022-09-12 19:06:09 +09:00
Dean Herbert
c064853751
Merge branch 'master' into notification-fling
2022-09-12 18:56:15 +09:00
Dan Balasescu
4b37330316
Merge pull request #20248 from acid-chicken/fix/stats/td
...
Fix new hit distribution graph didn't account for size changes
2022-09-12 18:11:18 +09:00
Dan Balasescu
bcbc867694
Merge branch 'master' into mods-effect-displays
2022-09-12 16:35:28 +09:00
Dean Herbert
931049aec1
Merge branch 'master' into notification-dismiss
2022-09-12 16:27:41 +09:00
Dan Balasescu
31225066a1
Merge pull request #19308 from frenzibyte/top-rank-badge-order
...
Fix best rank badge not handling legacy scores properly
2022-09-12 16:20:21 +09:00
Dean Herbert
8e6b2796eb
Merge branch 'master' into notification-fling
2022-09-12 16:19:36 +09:00
Dean Herbert
92beb6cbe7
Hide notification read light when in a toast state
...
Also adds test coverage of read state and light.
2022-09-12 15:17:45 +09:00
Dean Herbert
9b31aa6d7a
Fix activation not firing with refactors
2022-09-12 15:04:30 +09:00
Dean Herbert
2b79e6b2de
Add test coverage of update notification
2022-09-12 14:52:16 +09:00
Acid Chicken (硫酸鶏)
bb3d5bc9f4
test(osu.Game): add slider steps to change the size in timing distribution graph tests
2022-09-12 04:43:15 +09:00
ansel
064fe832c7
Fix test
2022-09-10 23:18:59 +03:00
MK56
8661dc3c93
Merge branch 'ppy:master' into Colour_hit_meter_improved
2022-09-10 21:16:23 +02:00
Mk-56spn
46d9262a60
test naming oversight
2022-09-10 20:38:34 +02:00
Mk-56spn
f6aef73f9e
fixed shape bindable not working, test creation, removal of Clear(), adjusted settings names
2022-09-10 20:30:43 +02:00
Dean Herbert
a9094c6b03
Add test coverage of clicking close button to dismiss
2022-09-10 15:18:32 +09:00
Dean Herbert
efe3b1aa7b
Allow dismissing notifications without performing action using middle / right click
2022-09-10 15:10:37 +09:00
andy840119
e62999fb16
Merge branch 'master' of https://github.com/ppy/osu into remove-the-nullable-disable-in-the-ruleset
...
# Conflicts:
# osu.Game.Rulesets.Catch/CatchRuleset.cs
# osu.Game.Rulesets.Osu/OsuRuleset.cs
# osu.Game.Rulesets.Taiko/TaikoRuleset.cs
# osu.Game/Rulesets/Ruleset.cs
2022-09-10 10:40:12 +08:00
Salman Ahmed
ae53e27e6c
Adjust test coverage to read better
2022-09-09 19:39:06 +03:00
Salman Ahmed
dd10a06e3d
Merge branch 'master' into top-rank-badge-order
2022-09-09 19:38:44 +03:00
Dean Herbert
8f9df9c7b4
Merge pull request #18642 from Joehuu/fix-play-button-touch
...
Fix beatmap card play button not working with touch inputs when not hovered
2022-09-09 19:41:05 +09:00
Dean Herbert
7d100c5eec
Fix test in line with new expectations
2022-09-09 18:10:10 +09:00
Dean Herbert
e9ce968ae3
Merge branch 'master' into fix-play-button-touch
2022-09-09 18:08:18 +09:00
Dean Herbert
9ec399a25a
Remove NRT overrides in new tests
2022-09-09 17:49:31 +09:00
Dean Herbert
68d1b7d7cf
Reduce test count
2022-09-09 17:48:51 +09:00
Dean Herbert
27f745b980
Merge branch 'master' into fix_progress_bar_info
2022-09-09 17:34:13 +09:00
Mk-56spn
5852a09003
small fix
2022-09-09 08:21:33 +02:00
Dean Herbert
c6c59f050c
Merge pull request #20195 from cdwcgt/SkinEditorShortcut
...
Add arrow shortcuts to skin editor
2022-09-09 14:17:08 +09:00
Dan Balasescu
ba2ef424d4
Turn score ids into ulongs
2022-09-09 11:46:06 +09:00
Dan Balasescu
28477f3b97
Fix inspection
2022-09-09 08:55:35 +09:00
Mk-56spn
38ccd06d5e
Test fix
2022-09-08 20:42:55 +02:00
Dean Herbert
f1fa442287
Merge pull request #19599 from ItsShamed/kps
...
Add clicks/second counter to HUD
2022-09-09 01:50:12 +09:00
cdwcgt
2e775e6886
Add test for object move
2022-09-08 23:47:55 +08:00
Dean Herbert
27aa3552dc
Update in line with TrueGameplayRate changes
2022-09-09 00:00:08 +09:00
Dean Herbert
6945c43e0d
Merge pull request #20178 from smoogipoo/fix-match-creation-beatmap-select
...
Fix several weird scenarios with online play song selection
2022-09-08 23:07:09 +09:00
Dean Herbert
d4afc3629c
Merge branch 'master' into kps
2022-09-08 23:00:36 +09:00
Dan Balasescu
3c8ee1a20a
Merge pull request #20179 from peppy/update-framework
...
Update framework
2022-09-08 22:14:16 +09:00
Dan Balasescu
9aab502adc
Merge pull request #20157 from peppy/true-gameplay-rate
...
Refactor `TrueGameplayRate` to account for only gameplay adjustments, no matter what
2022-09-08 19:54:32 +09:00
Dan Balasescu
a90ca94a18
Remove outdated tests
2022-09-08 19:51:28 +09:00
Dan Balasescu
4fc03998a1
Merge pull request #20189 from peppy/fix-playlist-item-download-button-visibility
...
Fix playlist items showing download button briefly during initial display
2022-09-08 19:47:35 +09:00
Dan Balasescu
c585f08a3b
Fix still inverted condition
2022-09-08 19:42:09 +09:00
Dean Herbert
15a4eb46c4
Rename test scene to match class name
2022-09-08 19:20:26 +09:00
Dean Herbert
096d1c3ff3
Merge pull request #20143 from acid-chicken/feat/stats/colored-td
...
Show judgement colours in hit distribution graph
2022-09-08 19:15:40 +09:00
Dean Herbert
13d9b2188b
Merge pull request #20145 from smoogipoo/multiple-countdowns
...
Implement support for multiple active countdowns in multiplayer
2022-09-08 19:15:30 +09:00
Dean Herbert
ee094e3a85
Rewrite tests
2022-09-08 19:05:13 +09:00
Dean Herbert
ed81297611
Fix playlist items showing download button briefly during initial local presence checks
2022-09-08 17:10:45 +09:00
Dean Herbert
7b079c134e
Update test to actually test what was intended
2022-09-08 15:48:04 +09:00
Dean Herbert
3d9bf25c8a
Apply NRT to TestScenePlaySongSelect
...
Very mess.
2022-09-08 14:49:57 +09:00
Dean Herbert
6aac0bd4e9
Update test to account for the fact that SSDQ is not zero anymore
2022-09-08 13:43:37 +09:00
Dan Balasescu
208bd0f391
Give OnlinePlaySongSelect a reference PlaylistItem
2022-09-07 21:34:29 +09:00
Dean Herbert
6a03b4e0de
Merge branch 'master' into true-gameplay-rate
2022-09-07 20:01:03 +09:00
Dean Herbert
770c1ade2f
Add test coverage of track rate adjusting during multi spectator
2022-09-07 20:00:24 +09:00
Dan Balasescu
f8e37af2e0
Merge pull request #20171 from peppy/beatmap-carousel-nrt
...
Fix missing null checks on `selectedBeatmap` fields in `BeatmapCarousel`
2022-09-07 17:15:00 +09:00
Dan Balasescu
264c9bfaf6
Merge pull request #20173 from peppy/test-scene-storyboard-tidy
...
Tidy up `TestSceneStoryboard`
2022-09-07 17:07:19 +09:00
Dean Herbert
cb1bb99208
Tidy up test logic
2022-09-07 16:43:48 +09:00
Dean Herbert
b50116e9e4
Add missing null check in BeatmapCarousel tests
2022-09-07 16:22:11 +09:00
Dean Herbert
258b8f015c
Add test coverage of storyboard using zero VectorScale
2022-09-07 15:39:19 +09:00
Dean Herbert
866bc553fe
Tidy up TestSceneStoryboard
2022-09-07 15:38:49 +09:00
Dan Balasescu
dc71abdf56
Merge pull request #20144 from peppy/fix-notification-overlay-presence
...
Fix completion toasts sometimes not displaying
2022-09-07 14:55:33 +09:00
Acid Chicken (硫酸鶏)
3003fc1061
refactor(osu.Game): improve code quality
2022-09-07 02:29:15 +09:00
Salman Ahmed
90207b6032
Merge branch 'master' into feature/EditorDeleteDiff
2022-09-06 18:48:06 +03:00
Dean Herbert
c2107bd322
Fix test failures due to notifications being forwarded before player finishes loading
2022-09-06 23:36:27 +09:00
Dean Herbert
bc1212f4e6
Change NonGameplayAdjustments to GameplayAdjustments and convert TrueGameplayRate to extension method
2022-09-06 22:26:46 +09:00
Dean Herbert
579e7e1f17
Fix deleting a difficulty not updating the beatmap set hash
2022-09-06 18:12:47 +09:00
Dean Herbert
9f2ea54e40
Tidy up TestSceneLeadIn constant for loop offset to read better
2022-09-06 17:45:53 +09:00
Mk-56spn
cfa1ebd0cb
Test fix
2022-09-06 03:00:13 +02:00
Dean Herbert
9e3228aa65
Fix completion notification not being posted if completion occurs during NotificationOverlay load
2022-09-06 04:07:49 +09:00
Dean Herbert
0514c96191
Fix incorrect count tracking when notification is manually disposed
2022-09-05 19:26:40 +09:00
Dean Herbert
229e1a8ef7
Fix notification overlay being present when it doesn't need to
2022-09-05 19:13:58 +09:00
Dan Balasescu
2923c10cd8
Rewrite rooms to store multiple active countdowns
...
Update test to the new structure
2022-09-05 19:03:26 +09:00
Dean Herbert
56886fed09
Add test coverage of progress notification completions showing
2022-09-05 18:39:11 +09:00
Acid Chicken (硫酸鶏)
6946015d17
style(osu.Game): fix multiple blank lines
2022-09-05 07:49:29 +00:00
Mk-56spn
aace334fb3
Fix some test issues
2022-09-05 04:49:48 +02:00
Acid Chicken (硫酸鶏)
19ab1433c6
test(osu.Game): add more test cases for HitTimingDistributionGraph
2022-09-05 03:46:23 +09:00
Dean Herbert
bc5340e33a
Merge branch 'master' into fix_progress_bar_info
2022-09-02 18:00:35 +09:00
Dean Herbert
dc02b59a05
Add extra coverage to tests
...
Also fixes a potential failure due to test beatmap having two difficulties with same name.
2022-09-02 17:57:20 +09:00
HiddenNode
7a8fa5c2e4
Fix filenames mismatch
2022-09-02 09:56:00 +01:00
Dean Herbert
65baf73d97
Add test scene
2022-09-02 16:50:28 +09:00
Dean Herbert
6a35b233e5
Merge branch 'master' into remove-dispose-updates
2022-09-01 23:03:19 +09:00
Dean Herbert
148e487c02
Add failing test of date submitted search failing
2022-09-01 19:59:27 +09:00
HiddenNode
921a9ef895
clean up
2022-08-31 22:18:52 +01:00
HiddenNode
a548b28158
Added test scene for SizePreservingSpriteText
2022-08-31 22:05:46 +01:00
Dean Herbert
ba20044af4
Fix missing nullability consideraition
2022-08-31 23:24:39 +09:00
Dan Balasescu
6cadcc206b
Merge pull request #20032 from peppy/toast-notification-tray
...
Add toast notification tray
2022-08-31 16:57:37 +09:00
Dan Balasescu
000412c50f
Merge pull request #20014 from peppy/fix-resume-skip-forward
...
Fix gameplay skipping forward during resume operation
2022-08-31 16:30:37 +09:00
Dan Balasescu
afe2862df4
Merge branch 'master' into toast-notification-tray
2022-08-31 16:07:11 +09:00
Dan Balasescu
e984dc4a19
Merge pull request #20042 from peppy/fix-composer-test-scenes
...
Test editor `ComposeScreen` tests not adding beatmap to hierarchy
2022-08-31 15:59:48 +09:00
Dean Herbert
7337d4c1aa
Merge branch 'master' into kps
2022-08-31 15:41:42 +09:00
Dean Herbert
e9463f3c19
Test editor ComposeScreen tests not adding beatmap to hierarchy
...
Makes it hard to test anything because `EditorBeatmap`'s `Update` method
updates whether a beatmap has timing or not (enabling the placement
controls).
Also adds a basic timing point to allow for better testing.
2022-08-31 14:07:56 +09:00
Dean Herbert
7ce1cf7560
Add test coverage of skip button failure with equal time
2022-08-31 13:22:51 +09:00
Dean Herbert
c573396ab6
Fix IntroTestScene not clearing previous notifications hard enough
2022-08-31 12:46:54 +09:00
Dean Herbert
3d93e0ded1
Merge branch 'master' into fix-resume-skip-forward
2022-08-31 12:16:15 +09:00
Dean Herbert
9eb615f942
Fix remaining test failures by strengthening PlayerLoader tests
...
- Click using `TriggerClick` as notifications move around quite a bit.
- Ensure any notifications from a previous test method are cleaned up.
2022-08-31 01:40:30 +09:00
Dean Herbert
31a9980686
Update remaining test expectations with new behaviour
2022-08-31 00:57:30 +09:00
Dean Herbert
a62ba9e0d9
Remove notification blocking behaviour of first run setup
2022-08-31 00:57:18 +09:00
Dean Herbert
b8fda1a16f
Apply NRT to notification classes
...
and tidy things up a bit.
2022-08-30 15:57:10 +09:00
Dan Balasescu
8b3742188f
Fix test by also clearing out maximum statistics
2022-08-30 15:42:36 +09:00
HiddenNode
43f2ba6596
Added test scene
2022-08-29 22:00:33 +01:00
HiddenNode
d20e7da2d9
Changed epsilon
2022-08-29 21:03:22 +01:00
ansel
545e0bbcef
Adjust inheritors and test
2022-08-29 22:49:25 +03:00
Dean Herbert
062a6fcc18
Fix failing large offset test
...
If we are going to continue to let the underlying clock process frames,
there needs to be a bit of lenience to allow the backwards seek on
resume (to play back over the freq ramp period).
The test is meant to be ensuring we don't skip the full offset amount,
so div10 seems pretty safe.
2022-08-30 01:21:55 +09:00
Dan Balasescu
0491addbbd
Merge pull request #19974 from peppy/no-gameplay-clock-editor-offset
...
Fix editor not applying offsets
2022-08-29 21:10:29 +09:00
Dean Herbert
82b9e1f0eb
Merge pull request #20011 from smoogipoo/scoring-refactor
...
Refactor scoring to remove async methods / simplify
2022-08-29 19:55:27 +09:00
Dean Herbert
ad5ef52922
Add test coverage of resuming after pause not skipping forward in time
2022-08-29 19:02:01 +09:00
Salman Ahmed
f2378d3fde
Merge branch 'master' into carousel-maintain-selection-over-update
2022-08-29 11:23:22 +03:00
Dean Herbert
2dafa041a7
Account for offset being applied to editor clock time in TestSceneEditorClock
2022-08-29 16:42:50 +09:00
Dean Herbert
a215d009fe
Update Remove/RemoveRange/RemoveAll calls in line with framework changes
2022-08-29 15:57:40 +09:00
Dan Balasescu
423f6f90f2
Remove async calls from ScoreManager
2022-08-29 15:34:08 +09:00
Dean Herbert
e8ae6840ea
Add test coverage of selection being retained
2022-08-29 15:23:34 +09:00
HiddenNode
d4a52baa56
Added visual test for UprightAspectMaintainingContainer
2022-08-29 00:07:42 +01:00
ansel
2a12194ff9
Test colours
2022-08-28 02:59:38 +03:00
ansel
90334a2b91
Add test scene
2022-08-27 20:12:45 +03:00
Dan Balasescu
289b6f1a58
Merge pull request #19924 from peppy/fix-playlist-overlay-test-failures
...
Fix intermittent test failures in `TestScenePlaylistOverlay`
2022-08-26 23:36:16 +09:00
Salman Ahmed
1fd1672d89
Merge branch 'master' into mod-validation-tests
2022-08-26 15:00:07 +03:00
Dean Herbert
6dc859973b
Merge branch 'master' into fix-playlist-overlay-test-failures
2022-08-26 20:25:53 +09:00
Dean Herbert
5ef8e26ebe
Fix check not accounting for mods not existing in certain rulesets
...
Also check all instances, rather than first.
2022-08-26 19:59:26 +09:00
Dean Herbert
580754833f
Merge branch 'master' into mod-validation-tests
2022-08-26 19:48:42 +09:00
Dean Herbert
9c9238d6e8
Fix TimelineTestScene's beatmap getting overwritten by EditorClockTestScene
2022-08-26 18:38:52 +09:00
Dean Herbert
4b72e55770
Fix various test scenes not adding EditorClock to the draw hierarchy
2022-08-26 18:08:43 +09:00
Dean Herbert
9050f54681
Split out test assertion methods to read better
2022-08-26 16:56:03 +09:00
Dean Herbert
a8c699610a
Fix lead in tests not waiting for player to start running
...
The tests are only meant to ensure that gameplay eventually starts.
The case where failures can occur is where the master clock is behind
the player clock (due to being in lead-in time). Because the test is
running in real-time, it can take arbitrary amounts of time to catch up.
If it took too long, the test would fail.
2022-08-25 18:00:14 +09:00
Dean Herbert
ddb434f47a
Rename asserts to method names to make it easier to track in logs
2022-08-25 17:30:13 +09:00
Dean Herbert
a5c61d9a52
Improve understandability of TestMostInSyncUserIsAudioSource
2022-08-25 16:47:33 +09:00
Dean Herbert
3a17c6df08
Merge branch 'master' into no-gameplay-clock-gameplay-offset
2022-08-25 16:24:55 +09:00
Dean Herbert
1032b2a68c
Fix some BeatmapCarousel tests not correctly reinitialising local data per run
...
Closes https://github.com/ppy/osu/issues/19949 .
2022-08-25 14:03:26 +09:00
Ryuki
5cddc7ed1f
Code cleanup (CPS)
2022-08-24 17:13:23 +02:00
Dean Herbert
5129716612
Merge branch 'master' into kps
2022-08-24 18:18:45 +09:00
Dean Herbert
ddccf4defe
Remove dollar sign
2022-08-24 17:17:59 +09:00
Dean Herbert
27b57947e4
Rename PlayerArea.GameplayClock to SpectatorPlayerClock for clarity
2022-08-24 17:13:14 +09:00
Dean Herbert
5f01f461b3
Ensure elapsed time is always non-zero when advancing SpectatorPlayerClock
2022-08-24 17:13:14 +09:00
Dean Herbert
5079e0d83d
Merge branch 'master' into no-gameplay-clock-gameplay-offset
2022-08-24 16:52:10 +09:00
Dean Herbert
995e6664b6
Rename spectator clock sync classes
2022-08-24 15:13:08 +09:00
Dean Herbert
ec61a94dc9
Merge branch 'master' into no-gameplay-clock-gameplay-offset
2022-08-23 17:36:06 +09:00
Dean Herbert
9a579871c0
Remove pointless initial import
2022-08-23 17:33:53 +09:00
Dean Herbert
a62deae3cc
Use local realm rather than fetching from dependencies
2022-08-23 17:33:53 +09:00
Dean Herbert
690e048864
Ensure all initial imports are completed before running playlist overlay tests steps
2022-08-23 17:33:53 +09:00
Ryuki
b597049524
Code cleanup for CPS tests
...
- Remove null-forgiving operator usages
- Fix code quality issues mentionned by NVika
2022-08-22 10:47:37 +02:00
Dean Herbert
058d67f8e8
Merge pull request #19695 from naoei/ruleset-localization
...
Change most ruleset-accessible string types to Localisable strings
2022-08-22 16:13:23 +09:00
Dan Balasescu
0815b01b75
Merge pull request #19783 from bdach/mod-select/presets-dont-open-customisation
...
Fix selecting preset containing Difficulty Adjust automatically opening customisation panel
2022-08-22 15:44:00 +09:00
Ryuki
c56390cd7b
Use less custom classes for CPS tests
2022-08-22 00:03:24 +02:00
Nao
189a407cb1
Merge branch 'master' into ruleset-localization
2022-08-20 21:39:10 -04:00
Dean Herbert
da407aa827
Merge branch 'master' into kps
2022-08-20 15:24:58 +09:00
Dean Herbert
15d49b0357
Update TestSceneSpectator to user new assert style
2022-08-19 01:46:19 +09:00
Ryuki
3de35a1518
Update calculator and tests to match changes on clocks
2022-08-18 18:40:02 +02:00
Dean Herbert
cc86909633
Increase lenience on TestSceneLeadIn tests
...
I've gone through these in detail and can't find an issue with the
actual flow of things. For whatever reason, the new structure has a
slightly higher delay, likely due to performing less `Seek` calls
(previously a `Seek` was called after the clock start which may have
been making this more accurate on the first `Player.Update`).
I don't think it really matters that this is slightly off, but we'll see
how this plays out.
2022-08-19 01:39:00 +09:00
Dean Herbert
2eba8650ca
Update TestSceneLeadIn to use new assert style
2022-08-18 19:26:19 +09:00
Dean Herbert
728cd96508
Update TestSceneLeadIn to use new assert style
2022-08-18 18:54:10 +09:00
Dan Balasescu
fa167b1d12
Merge pull request #19779 from peppy/no-gameplay-clock
...
Remove all remaining usage of `GameplayClock`
2022-08-18 18:52:57 +09:00
Dean Herbert
e7ddbc41c8
Merge branch 'master' into no-gameplay-clock
2022-08-17 22:21:10 +09:00
Dean Herbert
553ae4781f
Remove unnecessary local implementation in TestScenePlaybackControl
2022-08-17 19:21:54 +09:00
Dean Herbert
4ef4d66f49
Add some extra initial state checks to TestSceneEditorSeekSnapping
2022-08-17 19:21:46 +09:00
Dan Balasescu
3a0017c87b
Fix flaky quick retry test
2022-08-17 17:09:44 +09:00
Dean Herbert
20256aad11
Merge branch 'master' into no-gameplay-clock
2022-08-17 15:21:20 +09:00
Dan Balasescu
24fd411720
Merge pull request #19594 from BlauFx/improve_retry_behaviour
...
Skip song intro on quick restart
2022-08-16 20:18:12 +09:00
Dean Herbert
9a1a7bae89
Make test actually test things
2022-08-16 14:40:02 +09:00
Dean Herbert
6761f869f9
Modify flow to avoid weird bindable and value resetting
2022-08-16 14:17:35 +09:00
Dean Herbert
a15e6f19aa
Fix running TestScenePlayerLoader interactively leaving volume in a bad state
2022-08-16 13:40:46 +09:00
Dean Herbert
c9baadcf88
Merge branch 'master' into improve_retry_behaviour
2022-08-16 13:06:04 +09:00
Bartłomiej Dach
a494e55d93
Adjust test scene to reflect new behaviour
2022-08-15 20:43:19 +02:00
Bartłomiej Dach
f0ad31b650
Add failing test case
2022-08-15 20:38:22 +02:00
Bartłomiej Dach
5ff2e41a55
Add preset column to mod select test scene
2022-08-15 18:38:37 +02:00
Dean Herbert
704568ae3b
Remove remaining usage of GameplayClock
2022-08-15 20:22:36 +09:00
Dean Herbert
87760bbc06
Fix IsCatchingUp not being in correct state
2022-08-15 20:17:48 +09:00
Dean Herbert
04d88b8216
Use constraint based assertions in TestSceneFrameStabilityContainer
2022-08-15 19:19:19 +09:00
Dean Herbert
27569e2ed5
Remove FrameStableClock (and redirect usages to FrameStabilityContainer)
2022-08-15 19:19:19 +09:00
Dean Herbert
f81c7644b4
Make GameplayClockContainer also an IGameplayClock and expose to remaining tests
2022-08-15 18:30:53 +09:00
Dean Herbert
c8764cb333
Move all usage of GameplayClock to IGameplayClock
2022-08-15 18:30:53 +09:00
Dean Herbert
6d78218142
Update usages of GameplayClockContainer.GameplayClock to access properties directly
2022-08-15 18:08:49 +09:00
Dean Herbert
58146598c8
Update TestSceneEditorClock to use constraint-based assertions
2022-08-15 18:08:05 +09:00
Nao
c940f5abcb
Merge branch 'master' into ruleset-localization
2022-08-14 15:17:44 -04:00
naoei
784ce4d23d
Add test coverage for localisable setting source
2022-08-14 15:06:33 -04:00
Ryuki
2aa3a1b50d
Rename all "KeysPerSecond" usages to "ClicksPerSecond"
2022-08-14 20:12:11 +02:00
Ryuki
9dc806506e
Make ActionListener and KeysPerSecondCalculator not rely on events to add timestamps
2022-08-14 19:31:14 +02:00
Dean Herbert
a90967715c
Add test coverage of new imports not correctly being filtered by collection filter
2022-08-12 15:06:34 +09:00
Dean Herbert
5111bad86c
Refactor TestScenePlaylistOverlay to use realm for testing
...
Removes the dual-purpose flow which existed only for testing.
2022-08-12 15:06:34 +09:00
Ryuki
3c6461b9e4
Remove KPS acronym usage
2022-08-11 10:01:39 +02:00
Ryuki
0e1efbd865
Rename DrawableCookieziRuleset to MockDrawableRuleset
2022-08-11 01:04:06 +02:00
Ryuki
d58d5eebe2
Add basic tests for KPS
...
Created private mock classes to use them in place of `GameplayClock` and
`DrawableRuleset`.
2022-08-11 00:51:13 +02:00
naoei
3e38baca3c
Change ruleset mod description types
2022-08-10 16:09:11 -04:00
Dean Herbert
d59f4720f1
Merge pull request #19664 from peppy/test-assertions
...
Update multiple tests to use new assert output for easier to understand failures
2022-08-09 23:15:16 +09:00
Dan Balasescu
41af03dec5
Merge pull request #19597 from frenzibyte/hotfix-multi-spectator-results-screen
...
Fix multi-spectator potentially getting stuck for passed players (hotfix)
2022-08-09 21:11:10 +09:00
Dan Balasescu
2de9e5f40f
Fix test failure
2022-08-09 20:23:45 +09:00
Dean Herbert
1270ee9624
Update multiple tests to use new assert output for easier to understand failures
2022-08-09 19:19:54 +09:00
Dean Herbert
aa9ced7f04
Add test coverage of ToolbarUserButton
2022-08-09 15:51:10 +09:00
Ryuki
edb8e5e33e
Temporarily emptying TestSceneKeysPerSecondCounter until a good test can be found
2022-08-09 02:43:41 +02:00
BlauFx
e4879aa450
Add test
2022-08-08 21:12:38 +02:00
Bartłomiej Dach
eba070a0f8
Add weak test coverage of broken audio playback after soft-delete
2022-08-08 20:30:37 +02:00
Dean Herbert
e1189da824
Merge branch 'master' into irenderer-glwrapper
2022-08-08 12:31:53 +09:00
Salman Ahmed
f75dced305
Fix possible null assignment inspection in TestScenePreviewTrackManager
2022-08-08 02:00:24 +03:00
Bartłomiej Dach
839409d7ac
Add preset column to solo mod select overlay
2022-08-07 16:20:31 +02:00
Bartłomiej Dach
de64b83532
Add test coverage for desired user selection behaviour
2022-08-07 16:20:16 +02:00
Bartłomiej Dach
25daaa56e2
Add test coverage for desired external selection behaviour
2022-08-07 15:30:20 +02:00
Dean Herbert
4a95638756
Merge branch 'master' into mod-overlay/delete-preset
2022-08-07 12:34:25 +09:00
Dean Herbert
5946124278
Merge pull request #19612 from bdach/mod-overlay/common-delete-dialog
...
Unify implementations of deletion dialogs
2022-08-07 12:18:03 +09:00
Bartłomiej Dach
6f6beddab5
Add test coverage for mod preset deletion flow
2022-08-06 21:58:55 +02:00
Bartłomiej Dach
9b3183b2b4
Implement mod preset deletion flow
2022-08-06 21:58:55 +02:00
Bartłomiej Dach
26b9adbe0c
Adjust collection deletion test to match new expectations
2022-08-06 21:07:21 +02:00
Bartłomiej Dach
cc353b872c
Add test coverage for other approval events
2022-08-06 18:21:57 +02:00
Salman Ahmed
789e8b4d8d
Fix multi-spectator test updating state after removing user
...
Removing user triggers `playingUsers.Remove`, but doing so before
updating the state leads to `EndGameplay` being called with `State ==
Playing` rather than `Quit`.
2022-08-06 05:41:26 +03:00
Ryuki
0c07df2c26
Remove DT from KPS test
2022-08-05 21:02:37 +02:00
Ryuki
b4e0fa7c53
Rewrite tests for KPS
2022-08-05 15:53:06 +02:00
Dan Balasescu
cf362a6b4f
Merge pull request #19529 from peppy/locally-modified-pill
...
Show "locally modified" pill when local modifications have been made
2022-08-05 21:12:13 +09:00
Dan Balasescu
c4b9b2a14b
Merge branch 'master' into irenderer-glwrapper
2022-08-05 20:35:06 +09:00
Dean Herbert
7c952f8069
Add more test coverage of locally-modified state change
2022-08-05 14:25:10 +09:00
Ryuki
42d1bdfc95
Move KPS calculation to a standalone class
2022-08-05 04:17:01 +02:00
Bartłomiej Dach
ac9321204c
Merge branch 'master' into mod-overlay/create-preset
2022-08-03 21:21:52 +02:00
Dean Herbert
7022d9e5f8
Fix test step names being too long
2022-08-03 21:13:49 +09:00
Dean Herbert
bacbf5b7f0
Update existing test expectations
2022-08-03 20:20:06 +09:00
Dean Herbert
24d84890e4
Change all filter control button state test to until steps
...
There's multiple schedules at play which could be adding multi-frame
delays. let's play it safe and try and fix flaky tests.
Example of `Schedule` which could cause an issue:
392cb352cc/osu.Game/Collections/CollectionDropdown.cs (L77-L78)https://github.com/ppy/osu/runs/7648118894?check_suite_focus=true
2022-08-03 20:03:07 +09:00
Bartłomiej Dach
add2971eb4
Implement preset creation flow with test coverage
2022-08-02 22:05:54 +02:00
Bartłomiej Dach
1b3074d098
Implement popover for creating mod presets
2022-08-02 22:03:33 +02:00
Dan Balasescu
5a1c05918f
Fix test failures
2022-08-02 20:18:45 +09:00
Dan Balasescu
b4e55f7309
Apply IRenderer changes
2022-08-02 19:50:57 +09:00
Bartłomiej Dach
923d9a4e5f
Add failing assertions to demonstrate autosize failure
2022-08-01 22:04:14 +02:00
Dean Herbert
c0e5f11c90
Merge pull request #19532 from frenzibyte/fix-new-items-sort-stability
...
Fix newly imported beatmaps not using correct comparer for sorting
2022-08-02 02:20:51 +09:00
Dean Herbert
01cc9bd7ef
Merge pull request #19479 from frenzibyte/carousel-update-on-resume
...
Fix song select not updating selected beatmap card on editor resume
2022-08-02 00:48:18 +09:00
Salman Ahmed
682192dbd7
Add failing test case
2022-08-01 18:43:01 +03:00
Dean Herbert
2519706ad6
Add test coverage of editor crash
2022-08-01 16:53:49 +09:00
Joseph Madamba
320c4abb66
Add failing online play non-current sub screen onexiting test
2022-07-31 20:13:06 -07:00
Bartłomiej Dach
5a34122a85
Fix test breakage after realm migration
2022-07-31 23:53:46 +02:00
Bartłomiej Dach
9d3cdae4bb
Fix test scene to handle restarts properly
2022-07-31 23:53:46 +02:00
Bartłomiej Dach
9dea8e3d12
Add test coverage of preset soft deletion
2022-07-31 23:53:46 +02:00
Bartłomiej Dach
c837848238
Add extended test coverage of preset realm subscription
2022-07-31 23:53:45 +02:00
Bartłomiej Dach
345f103119
Migrate mod preset column to use realm
2022-07-31 23:53:45 +02:00
Salman Ahmed
b95aff3e5f
Add failing test case
2022-07-30 18:50:41 +03:00
Susko3
38a8b9cf0a
Add battery info for desktop platforms
2022-07-30 14:26:19 +02:00
Dean Herbert
43e612f6d4
Merge pull request #19455 from peppy/confirm-playlist-discard
...
Add confirmation dialog when about to discard a playlist
2022-07-30 19:17:49 +09:00
Salman Ahmed
8ca8484f0e
Fix failing tests
2022-07-30 11:49:33 +03:00
Salman Ahmed
ec1a7994cc
Switch method to statement body for better readability
...
Almost thought the method was not wrapped in an `AddStep`.
2022-07-30 10:11:01 +03:00
Salman Ahmed
0c125db197
Fix potential nullref on TestSceneAutoplay check steps
2022-07-30 10:11:01 +03:00
Salman Ahmed
3bc1774c87
Merge branch 'master' into pie-chart-progress
2022-07-29 16:54:59 +03:00
Salman Ahmed
3b1a76b190
Remove redundant/overwritten specifications
2022-07-29 16:45:29 +03:00
Salman Ahmed
905bbdc8ee
Remove caching of GameplayClockContainer in favour of GameplayClock
...
Also fixes `SongProgress` being displayed in skin editor on non-gameplay
screens, due to `GameplayClock` not marked as a required dependency.
2022-07-29 16:45:29 +03:00
Dan Balasescu
6703b8df02
Merge pull request #19454 from peppy/filter-control-tests-realm-refresh
...
Ensure realm is in a good state before asserts in `TestSceneFilterControl`
2022-07-29 17:57:38 +09:00
Dean Herbert
07e3765b34
Ensure collection is added to dropdown before trying to click it
2022-07-29 17:25:30 +09:00
Dean Herbert
0a2265b0e8
Add test coverage of playlist exit confirmation
2022-07-29 17:11:37 +09:00
Dean Herbert
eb92c35335
Merge pull request #19442 from smoogipoo/fix-beginplaying-misordering
...
Move spectator begin/end playing to SubmittingPlayer
2022-07-29 16:09:50 +09:00
Dean Herbert
e07e761c10
Ensure realm is in a good state before asserts in TestSceneFilterControl
2022-07-29 15:59:53 +09:00
Dan Balasescu
aaa6f963bd
Fix potential test failures due to Setup/SetUpSteps ordering
2022-07-29 15:27:39 +09:00
Ryuki
2df24019fd
Merge branch 'master' into kps
2022-07-28 18:38:09 +02:00
Ryuki
079150849a
Add some tests
2022-07-28 18:37:50 +02:00
Ryuki
b2e7da5aa0
Add basic Queue based implementation of KPS
2022-07-28 18:37:12 +02:00
Dean Herbert
45879f7836
Merge pull request #19443 from smoogipoo/fix-intermittent-hud-tests
...
Fix intermittent HUD tests
2022-07-28 23:20:46 +09:00
Dean Herbert
e664690fe2
Remove unnecessary LoadTrack call
2022-07-28 22:19:46 +09:00
Dean Herbert
3005ff1b9f
Merge branch 'master' into pie-chart-progress
2022-07-28 22:19:27 +09:00
Dan Balasescu
aa03df905f
Merge pull request #19441 from peppy/test-working-beatmap-unfuck
...
Reduce calls to `LoadTrack` by implicitly running on test/dummy classes
2022-07-28 22:05:25 +09:00
Dan Balasescu
11e0022fad
Merge branch 'master' into realm-collections
2022-07-28 21:00:08 +09:00
Dan Balasescu
ce694123eb
Move spectator begin/end playing to SubmittingPlayer
2022-07-28 20:44:04 +09:00
Dean Herbert
7108553883
Tidy up various things everywhere
2022-07-28 18:25:14 +09:00
Dean Herbert
a21aee4e9c
Reduce calls to LoadTrack by implicitly running on test/dummy classes
2022-07-28 18:11:40 +09:00
Dan Balasescu
1039338d80
Fix intermittent HUD tests
2022-07-28 17:58:07 +09:00
Dan Balasescu
cd01c5d3ac
Fix assertion
2022-07-28 16:34:31 +09:00
Nitrous
0d36907cad
apply code quality fixes
2022-07-28 15:30:45 +08:00
Nitrous
70ed347b06
simplify helper methods
2022-07-28 15:19:35 +08:00
Dean Herbert
2b9d46d803
Remove unused RulesetStore from BeatmapManager constructor
2022-07-28 16:19:05 +09:00
Nitrous
db62d4be3a
apply suggestions
...
- refactor `SongProgress`
- make`UpdateProgress` more readable
- enable NRT on new classes
- refactor `TestSceneSongProgress` to use `GameplayClockContainer`
2022-07-28 15:15:41 +08:00
Dan Balasescu
6bf293e130
Fix managed object reused between test runs
2022-07-28 15:45:33 +09:00
Dean Herbert
8ac886a247
Update test to account for sort order
2022-07-28 15:20:25 +09:00
Dean Herbert
ad482b8afc
Tidy up naming of collection dropdowns
2022-07-28 13:57:21 +09:00
Dean Herbert
34a2d1a6e1
Fix ManageCollectionsDialog and remove weird placeholder logic
2022-07-28 13:57:21 +09:00
Dean Herbert
67c7f324ee
Simplify CollectionFilterDropdown filter flow weirdness
2022-07-28 13:57:21 +09:00
Dean Herbert
0913cf013c
Split out tests and fix variable conflict
2022-07-28 13:24:14 +09:00
Dean Herbert
aa65b73f19
Merge branch 'master' into add-notif-externalbutton
2022-07-28 12:17:36 +09:00
Dean Herbert
8da499fb0f
Add proper test coverage
2022-07-28 12:16:21 +09:00
Nitrous
9088caa377
move LegacyComboCounter to osu.Game.Skinning
2022-07-28 08:36:26 +08:00
Dean Herbert
438067a18b
Convert realm data propagation to more correctly use Live<T>
...
wip
2022-07-27 19:35:09 +09:00
Dean Herbert
41393616d8
Replace BeatmapCollection with RealmBeatmapCollection
2022-07-27 19:35:09 +09:00
Dean Herbert
9c543fef48
Remove CollectionManager
2022-07-27 18:45:33 +09:00
Nitrous
6af6f03e29
refactor song progress test scene
2022-07-27 15:57:47 +08:00
Nitrous
1e013bd4e9
move song progress graph to its own test scene
2022-07-27 15:57:23 +08:00
Nitrous
37e642b0bd
make SongProgress abstract
...
- move unrelated logic to `DefaultSongProgress`
- make `LegacySongProgress` inherit `SongProgress`
2022-07-27 15:19:21 +08:00
Dean Herbert
6b73f7c7ec
Split out legacy import path from realm manager
2022-07-27 15:04:09 +09:00
Dan Balasescu
8f7dff5c2c
Merge pull request #19378 from peppy/beatmap-update-test
...
Add separate beatmap update flow to handle edge cases better
2022-07-26 18:49:20 +09:00
Dean Herbert
7f75184a01
Merge branch 'master' into beatmap-update-test
2022-07-26 17:27:36 +09:00
Salman Ahmed
91ffa7007f
Improve existing test coverage to cover order changes from other sort modes
2022-07-26 10:24:51 +03:00
Dean Herbert
4efe09e7c2
Merge pull request #19377 from frenzibyte/fix-timeline-tests
...
Fix intermittent timeline zoom test failures
2022-07-26 15:18:35 +09:00
Dean Herbert
ef10145d6f
Rename MenuCursorContainer and clean up code
2022-07-26 14:11:52 +09:00
Salman Ahmed
e5355f314d
Use longer hash string
2022-07-25 15:19:32 +03:00
Dean Herbert
6a3e8e31de
Centralise calls to reset online info of a BeatmapInfo
2022-07-25 19:51:19 +09:00
Salman Ahmed
d04df19c7e
Remove APIScore and replace its final usage
2022-07-25 13:13:46 +03:00
Dan Balasescu
1d48cee230
Merge pull request #19373 from peppy/fix-negative-star-rating-display
...
Fix star ratings which are still being calculated showing as "-1" at song select
2022-07-25 18:20:30 +09:00
Salman Ahmed
bc2b629ee7
Let tests wait until track load before testing zoom
2022-07-25 12:07:50 +03:00
Salman Ahmed
123930306b
Refactor ZoomableScrollContainer to allow setting up zoom range and initial zoom after load
2022-07-25 12:07:50 +03:00
