8926 Commits

Author	SHA1	Message	Date
Dean Herbert	f31deaef7c	Simplify skin bindable flow ... Now, nothing touches the configuration apart from `OsuGame`, making everything else flow better and avoid weird cyclic set bugs. Closes https://github.com/ppy/osu/issues/20234.	2022-09-12 19:51:50 +09:00
Dan Balasescu	5bd0be14ed	Merge pull request #20259 from peppy/fix-changelog-crash ... Fix potential crash when opening changelog overlay if entry has no URL	2022-09-12 19:47:21 +09:00
Dean Herbert	cb6d02ec3a	Merge pull request #19066 from andy840119/remove-the-nullable-disable-in-the-ruleset ... Remove the nullable disable annotation in the ruleset class	2022-09-12 19:07:23 +09:00
Dean Herbert	d92e000fe6	Fix flinging a notification not correctly running Close	2022-09-12 19:00:03 +09:00
Dean Herbert	4ee3e8f087	Don't play fling animation when activating a notification	2022-09-12 18:57:18 +09:00
Dean Herbert	58c1ea0321	Fix potential crash when opening changelog overlay if entry has no URL	2022-09-12 17:51:15 +09:00
Dean Herbert	d561fcb126	Don't trigger fling animation when Close is triggered by non-user action	2022-09-12 16:54:25 +09:00
Dean Herbert	5a02e1e713	Use padding instead of FillFlow.Spacing to avoid artifact during animation	2022-09-12 16:46:45 +09:00
Dean Herbert	a506178571	Make bounding box shrink faster to allow for rapid flinging	2022-09-12 16:39:46 +09:00
Dan Balasescu	bcbc867694	Merge branch 'master' into mods-effect-displays	2022-09-12 16:35:28 +09:00
Dean Herbert	931049aec1	Merge branch 'master' into notification-dismiss	2022-09-12 16:27:41 +09:00
Dean Herbert	bd3673baa9	Fix being able to drag after already closing a notification	2022-09-12 16:25:32 +09:00
Dean Herbert	8e6b2796eb	Merge branch 'master' into notification-fling	2022-09-12 16:19:36 +09:00
Dean Herbert	2476cf8fb3	Adjust movement to look less sudden when snapping back to Y=0	2022-09-12 15:37:48 +09:00
Dean Herbert	e06a0f7300	Fix dragged state not being exposed correctly	2022-09-12 15:21:01 +09:00
Dean Herbert	92beb6cbe7	Hide notification read light when in a toast state ... Also adds test coverage of read state and light.	2022-09-12 15:17:45 +09:00
Dean Herbert	60b0b909a5	Move update icon to background to avoid colour collission with progress spinner	2022-09-12 14:58:46 +09:00
Dean Herbert	9ef23c79ce	Disallow forwarding during a drag operation	2022-09-11 22:05:44 +09:00
Dean Herbert	a56cadcf90	Ensure drag position is reset when transferred to tray	2022-09-11 22:03:29 +09:00
Dean Herbert	b5a2f7003e	Disallow flinging when not in toast state	2022-09-11 21:47:45 +09:00
Dean Herbert	d6f90e3b9f	Add basic fling-to-dismiss support	2022-09-11 21:32:22 +09:00
ansel	324a3723a5	Rewrite DMD	2022-09-10 23:23:04 +03:00
ansel	3f93ec8538	Expose counter to inheritors	2022-09-10 23:20:28 +03:00
ansel	667854b034	Make effect display have a built-in counter	2022-09-10 23:18:48 +03:00
Dean Herbert	a9094c6b03	Add test coverage of clicking close button to dismiss	2022-09-10 15:18:32 +09:00
Dean Herbert	efe3b1aa7b	Allow dismissing notifications without performing action using middle / right click	2022-09-10 15:10:37 +09:00
ansel	b056cac10a	Remove generic and add default implementation for CalculateEffect	2022-09-10 08:34:29 +03:00
andy840119	1398a7e11e	Property should accept the nullable state.	2022-09-10 10:46:40 +08:00
Salman Ahmed	5e4e3dfc2c	Fix markdown container not rendering certain text correctly	2022-09-10 02:55:20 +03:00
Dean Herbert	6e52dbb266	Update IsDisplayingToasts to check the flow count directly	2022-09-06 17:30:24 +09:00
Dean Herbert	9e3228aa65	Fix completion notification not being posted if completion occurs during NotificationOverlay load	2022-09-06 04:07:49 +09:00
Dean Herbert	510972e3ad	Avoid reference counting by using height calculation for IsPresent instead ... The reference counting was to guarantee performance (zero allocations) when the notification overlay was not required, but adds extra complexity. Instead, the toast tray now uses its ongoing height calculation as a metric for presence.	2022-09-05 19:38:09 +09:00
Dean Herbert	0514c96191	Fix incorrect count tracking when notification is manually disposed	2022-09-05 19:26:40 +09:00
Dean Herbert	229e1a8ef7	Fix notification overlay being present when it doesn't need to	2022-09-05 19:13:58 +09:00
Dean Herbert	f754686521	Remove necessity of AlwaysPresent for ProgressUpdate completion posting	2022-09-05 19:13:58 +09:00
Dean Herbert	0d4ee6bd80	Centralise ability to fetch all toast tray notifications (including animating ones)	2022-09-05 18:42:20 +09:00
Dean Herbert	eca7b8f988	Fix completion notifications not always showing as toasts	2022-09-05 18:39:11 +09:00
Dean Herbert	4fa6707bf0	Set all progress notifications to non-important	2022-09-05 18:29:35 +09:00
Dean Herbert	7eaa4c5ccd	Update new usages of Remove / RemoveInternal	2022-09-01 23:05:34 +09:00
Dean Herbert	6a35b233e5	Merge branch 'master' into remove-dispose-updates	2022-09-01 23:03:19 +09:00
Dan Balasescu	afe2862df4	Merge branch 'master' into toast-notification-tray	2022-08-31 16:07:11 +09:00
Dan Balasescu	ccc08b816c	Merge pull request #20030 from peppy/notification-design-update ... Update notification overlay design	2022-08-31 16:06:59 +09:00
Dean Herbert	8b9ccc66b7	Update ProgressNotification font spec to match other notifications	2022-08-31 12:49:28 +09:00
Dean Herbert	85442fe032	Adjust dismiss button background colour to avoid conflict with background	2022-08-31 12:48:30 +09:00
Dean Herbert	7c72c6b43f	Fix unread count potentially missing notifications in a transforming state	2022-08-31 12:46:43 +09:00
Dean Herbert	0558dae917	Mark toasts as read when closing the overlay for added safety ... I'm not sure how the read status will play out going forward so I'm just adding this to keep things conforming for now.	2022-08-31 12:46:04 +09:00
Dean Herbert	9eb615f942	Fix remaining test failures by strengthening PlayerLoader tests ... - Click using `TriggerClick` as notifications move around quite a bit. - Ensure any notifications from a previous test method are cleaned up.	2022-08-31 01:40:30 +09:00
Dean Herbert	31a9980686	Update remaining test expectations with new behaviour	2022-08-31 00:57:30 +09:00
Dean Herbert	a62ba9e0d9	Remove notification blocking behaviour of first run setup	2022-08-31 00:57:18 +09:00
Dean Herbert	ed11b1ba6f	Improve forwarding flow to not use piling delegates	2022-08-31 00:40:53 +09:00
Dean Herbert	224ab29ef4	Don't dismiss toasts while hovered (and adjust timings slightly)	2022-08-30 21:19:51 +09:00
Dean Herbert	403fc18976	Fix notification completion events not being run when overlay not visible	2022-08-30 21:13:43 +09:00
Dean Herbert	a7110666a0	Play notification appear sample immediately	2022-08-30 21:13:43 +09:00
Dean Herbert	95ce78a50c	Reduce notification post delay now that it's less important	2022-08-30 21:13:43 +09:00
Dean Herbert	b8300ae60a	Add toast notification tray	2022-08-30 21:13:43 +09:00
Dean Herbert	7b006f1f22	Add flash when a new notification is displayed to draw attention	2022-08-30 20:34:27 +09:00
Dean Herbert	60413e3e7b	Enable masking for main content to avoid underlap with close button on word wrap failure.	2022-08-30 19:17:41 +09:00
Dean Herbert	6b71b4656d	Remove ProgressNotification vertical movement and delay	2022-08-30 19:16:59 +09:00
Dean Herbert	d600058c98	Assert non-null in ProfileHeader to appease r#	2022-08-30 18:09:10 +09:00
Dean Herbert	c846bf20a7	Add background hover and adjust remaining metrics	2022-08-30 18:06:48 +09:00
Dean Herbert	bea12ab3c2	Rename NotificationContent to MainContent	2022-08-30 18:06:48 +09:00
Dean Herbert	09aa3e065d	Move colouring to full icon content rather than background	2022-08-30 18:06:48 +09:00
Dean Herbert	0f203531d9	Allow customising the "close" button icon	2022-08-30 18:06:48 +09:00
Dean Herbert	1484ae19f0	Initial design update pass	2022-08-30 18:06:48 +09:00
Dean Herbert	b8fda1a16f	Apply NRT to notification classes ... and tidy things up a bit.	2022-08-30 15:57:10 +09:00
ansel	545e0bbcef	Adjust inheritors and test	2022-08-29 22:49:25 +03:00
ansel	5343c26452	Control colour via Current bindable	2022-08-29 22:48:27 +03:00
ansel	7faeed88b0	Add ability to override width of value area	2022-08-29 22:08:43 +03:00
Dean Herbert	a215d009fe	Update Remove/RemoveRange/RemoveAll calls in line with framework changes	2022-08-29 15:57:40 +09:00
Dan Balasescu	423f6f90f2	Remove async calls from ScoreManager	2022-08-29 15:34:08 +09:00
ansel	039f009562	Inherit difficulty multiplier display from ModsEffectDiplay	2022-08-27 20:26:05 +03:00
ansel	3e828c3416	Move base layout from DifficultyMultiplierDisplay to another class	2022-08-27 20:11:38 +03:00
Dean Herbert	6dc859973b	Merge branch 'master' into fix-playlist-overlay-test-failures	2022-08-26 20:25:53 +09:00
Bartłomiej Dach	968f656585	Merge branch 'master' into copyexternalurl-dialog	2022-08-24 21:21:11 +02:00
Dean Herbert	6a0d23cf96	Nest dialog class and apply NRT	2022-08-24 17:39:22 +09:00
Dean Herbert	9f9deef438	Reword slightly	2022-08-24 17:37:41 +09:00
Andrew Hong	9ee26c575d	Made button blue	2022-08-24 04:04:44 -04:00
Andrew Hong	b24513038c	Add popupdialog button to copy url	2022-08-24 03:35:19 -04:00
Andrew Hong	edd50dc05b	Add profile url context menu to user container	2022-08-24 03:07:03 -04:00
Dean Herbert	c840977acb	Fix filtering potentially not running after new items added	2022-08-23 20:42:20 +09:00
Dean Herbert	058d67f8e8	Merge pull request #19695 from naoei/ruleset-localization ... Change most ruleset-accessible string types to Localisable strings	2022-08-22 16:13:23 +09:00
Dan Balasescu	0815b01b75	Merge pull request #19783 from bdach/mod-select/presets-dont-open-customisation ... Fix selecting preset containing Difficulty Adjust automatically opening customisation panel	2022-08-22 15:44:00 +09:00
Dean Herbert	d199b3b100	Update GetVariantName to also support localisation	2022-08-22 14:51:00 +09:00
Dan Balasescu	e1fa959f0b	Fix language change removing mod column bold text	2022-08-22 13:00:47 +09:00
Bartłomiej Dach	aa15e84bea	Adjust rounding in mod select difficulty multiplier to match song select footer ... The 0.01 `Precision` spec on `DifficultyMultiplierDisplay.Current` would cause the difficulty multiplier to use a different midpoint rounding strategy than `double.ToString()`, which is the one that the song select footer relies on. For example, a value of 0.015 would be rounded down to 0.01 by `double.ToString()`, but rounded up to 0.02 by `BindableDouble`. Fix the discrepancy by just deleting the `Precision` spec. Since the value of the bindable would go through `ToLocalisableString(@"N2")` anyway, it was redundant as is. Fixes #19889.	2022-08-21 23:15:49 +02:00
Bartłomiej Dach	3d14b14cfe	Use alternative method for checking panel readiness to eliminate bool flag	2022-08-17 21:56:11 +02:00
Bartłomiej Dach	3109066e34	Rename {Requires -> Pending}Configuration	2022-08-16 22:45:24 +02:00
Bartłomiej Dach	6bfdfeb153	Refactor mod panel selection logic to avoid overwriting	2022-08-16 22:41:35 +02:00
Bartłomiej Dach	10daac6752	Only open mod customisation panel on explicit selection of single mod	2022-08-15 20:38:23 +02:00
Bartłomiej Dach	f860bc11ee	Fix several schedule-related issues arising from new column addition	2022-08-15 20:38:16 +02:00
Bartłomiej Dach	5ff2e41a55	Add preset column to mod select test scene	2022-08-15 18:38:37 +02:00
Nao	c940f5abcb	Merge branch 'master' into ruleset-localization	2022-08-14 15:17:44 -04:00
naoei	45e9eda9e7	Localise hit result name	2022-08-14 14:57:02 -04:00
basseX	383afe04f3	Remove not needed override	2022-08-14 15:15:36 +02:00
basseX	932becc4b2	Remove CommentMarkdownTextFlowContainer and rather use base-class OsuMarkdownTextFlowContainer	2022-08-14 10:11:49 +02:00
basseX	b05acb0073	Make CommentMarkdownTextFlowContainer render images	2022-08-13 21:32:24 +02:00
Dean Herbert	b76e5757e1	Fix InSelectedCollection not being applied to newly imported beatmaps	2022-08-12 15:06:34 +09:00
Dean Herbert	5111bad86c	Refactor TestScenePlaylistOverlay to use realm for testing ... Removes the dual-purpose flow which existed only for testing.	2022-08-12 15:06:34 +09:00
Dan Balasescu	1721a91168	Merge pull request #19661 from peppy/overlay-key-binding-organisation ... Reorganise global bindings and split out overlay bindings to make things easier to find	2022-08-10 21:18:28 +09:00
Dan Balasescu	76fea25668	Merge pull request #19646 from its5Q/settings-localisation ... Add missing localisation for settings enums	2022-08-10 18:51:52 +09:00
Dan Balasescu	888c4c8e08	Merge pull request #19662 from peppy/startup-correct-username ... Use a placeholder user with the correct username during login process	2022-08-10 13:09:37 +09:00
its5Q	abca3d1b2a	Prefix common strings for context	2022-08-10 00:35:19 +10:00
Dean Herbert	beb3d41f0c	Fix unsafe usage of APIAccess.LocalUser in BeatmapListingOverlay	2022-08-09 17:11:44 +09:00
Dean Herbert	a71c2bbe28	Split overlay toggles into own section in key bindings ... Things were getting hard to find..	2022-08-09 17:01:38 +09:00
Dean Herbert	32852e5b21	Fix potentially thread-unsafe LocalUser usage	2022-08-09 16:01:04 +09:00
Dean Herbert	5d8bd1de28	Share localised strings with expanded display message	2022-08-09 15:57:16 +09:00
Dean Herbert	3f8cedff3a	Add tooltips showing current connecting status	2022-08-09 15:51:27 +09:00
Dean Herbert	c35b4ef914	Display connecting / failing states on toolbar user display	2022-08-09 15:51:10 +09:00
Bartłomiej Dach	f74fb3491e	Use alternative implementation of preset panel cleanup	2022-08-08 21:08:54 +02:00
Bartłomiej Dach	a0a6e1faee	Fix spurious sample playbacks from already-removed panels	2022-08-08 20:30:55 +02:00
Bartłomiej Dach	f21a51aa24	Simplify mirror copy of task logic in ModColumn	2022-08-08 19:20:50 +02:00
Bartłomiej Dach	00333fb0d2	Change ?? false test to == true for legibility	2022-08-08 19:19:13 +02:00
its5Q	5080d62e77	Add missing localisation for settings enums	2022-08-08 21:51:23 +10:00
Dean Herbert	070d156e89	Simplify task logic in ModPresetColumn	2022-08-08 16:13:52 +09:00
Bartłomiej Dach	7d6efaebbe	Add maintenance settings section for mod presets	2022-08-07 16:20:31 +02:00
Bartłomiej Dach	839409d7ac	Add preset column to solo mod select overlay	2022-08-07 16:20:31 +02:00
Bartłomiej Dach	b318bbd5e6	Allow non-homogenous column types in mod select overlay	2022-08-07 16:20:31 +02:00
Bartłomiej Dach	0287c49ca8	Implement user selection logic for mod presets	2022-08-07 16:20:20 +02:00
Bartłomiej Dach	b1dcd7821c	Automatically toggle preset panels if selected mods match	2022-08-07 15:30:20 +02:00
Dean Herbert	4a95638756	Merge branch 'master' into mod-overlay/delete-preset	2022-08-07 12:34:25 +09:00
Dean Herbert	5946124278	Merge pull request #19612 from bdach/mod-overlay/common-delete-dialog ... Unify implementations of deletion dialogs	2022-08-07 12:18:03 +09:00
Bartłomiej Dach	9b3183b2b4	Implement mod preset deletion flow	2022-08-06 21:58:55 +02:00
Bartłomiej Dach	a0d093be5c	Extract common implementation of delete dialog	2022-08-06 21:04:12 +02:00
Bartłomiej Dach	ab1b38242f	Reorder enum cases to match web order	2022-08-06 18:34:30 +02:00
Bartłomiej Dach	6a9c30c47a	Fix some more wrong icon colours	2022-08-06 18:34:00 +02:00
Bartłomiej Dach	2ba127b6fc	Fix wrong icon for approval event	2022-08-06 18:30:49 +02:00
Bartłomiej Dach	f1e0dd2da3	Match approval type-dependent icon appearance with web	2022-08-06 18:29:24 +02:00
Bartłomiej Dach	f3ecd73e0b	Add references to web source in recent activity icon	2022-08-06 18:23:15 +02:00
LukynkaCZE	3000d9b9c6	Inline everything in RecentActivityIcon	2022-08-06 07:16:34 +02:00
LukynkaCZE	bd27995c71	Merge branch 'ppy:master' into add-missing-icons-to-recent-profile-section	2022-08-06 05:55:51 +02:00
Dean Herbert	6823282604	Fix PlayButton potentially not disposing an unused PreviewTrack during load	2022-08-05 14:15:27 +09:00
Bartłomiej Dach	ca1b4689cb	Automatically focus name textbox upon add preset popover open	2022-08-03 21:26:35 +02:00
Bartłomiej Dach	159d3b032c	Rename locals for legibility	2022-08-03 21:23:31 +02:00
Bartłomiej Dach	82d3fbd51b	Split AddPresetPopover to separate file	2022-08-03 21:22:55 +02:00
Bartłomiej Dach	add2971eb4	Implement preset creation flow with test coverage	2022-08-02 22:05:54 +02:00
Bartłomiej Dach	7251389e43	Add localisations for add preset button	2022-08-02 22:05:34 +02:00
Bartłomiej Dach	059a465fe8	Add border to popover for better visual contrast	2022-08-02 22:03:33 +02:00
Bartłomiej Dach	1b3074d098	Implement popover for creating mod presets	2022-08-02 22:03:33 +02:00
Bartłomiej Dach	085080576a	Add button for creating new mod presets	2022-08-02 22:03:32 +02:00
Dean Herbert	34ffc51c51	Avoid clearing chat overlay textbox when pressing "back" key binding ... Generally this is expected behaviour for usages of focused text boxes (ie. to clear search content), but not so much here. Addresses https://github.com/ppy/osu/discussions/19403#discussioncomment-3230395.	2022-08-02 13:56:03 +09:00
notmyname	6686b09549	Hide F rank from beatmap overlay	2022-08-01 18:54:00 +02:00
Salman Ahmed	2a127c6ef8	Merge branch 'master' into fix-tags-overflow	2022-08-01 12:40:43 +03:00
Gutyina Gergő	c65747d1b8	Use masking instead of scrollable container to prevent tags overflow	2022-08-01 10:36:53 +02:00
Dean Herbert	2f60f91a0e	Fix editor potentially using a track post-disposal ... This changes the editor to track the current track as it is *loaded* by `MusicController`, rather than haphazardly following the current global `WorkingBeatmap` (with a potentially unloaded track) or relying on local immediate-load behaviour (as implemented in `ResourcesSection`).	2022-08-01 16:53:49 +09:00
Bartłomiej Dach	85f77abee1	Fix code quality inspection about ambiguous equality	2022-07-31 23:53:46 +02:00
Bartłomiej Dach	345f103119	Migrate mod preset column to use realm	2022-07-31 23:53:45 +02:00
Gutyina Gergő	98214beb6c	Prevent overflow on beatmap info using scrollable container	2022-07-31 21:24:41 +02:00
Dan Balasescu	aa03df905f	Merge pull request #19441 from peppy/test-working-beatmap-unfuck ... Reduce calls to `LoadTrack` by implicitly running on test/dummy classes	2022-07-28 22:05:25 +09:00
Dean Herbert	a21aee4e9c	Reduce calls to LoadTrack by implicitly running on test/dummy classes	2022-07-28 18:11:40 +09:00
Dean Herbert	ca68574473	Make NotificationOverlay dependency optional in CollectionSettings	2022-07-28 14:35:27 +09:00
Dean Herbert	ad482b8afc	Tidy up naming of collection dropdowns	2022-07-28 13:57:21 +09:00
Dean Herbert	438067a18b	Convert realm data propagation to more correctly use Live<T> ... wip	2022-07-27 19:35:09 +09:00
Dean Herbert	41393616d8	Replace BeatmapCollection with RealmBeatmapCollection	2022-07-27 19:35:09 +09:00
Dean Herbert	9c543fef48	Remove CollectionManager	2022-07-27 18:45:33 +09:00
Dean Herbert	c30e8047ab	Merge pull request #19375 from novialriptide/contextmenu-external-beatmap ... Add ContextMenu to beatmap external link	2022-07-26 19:06:10 +09:00
Dean Herbert	1539fa704b	Always allow selecting the top-most button using the select binding	2022-07-26 17:46:23 +09:00
Andrew Hong	003aec86ae	Rearrange sizeaxes	2022-07-26 04:27:22 -04:00
Dean Herbert	ee0c67e114	Add ability to make cursor show even during touch input ... I completely disagree with this from a UX perspective, but it's come up so often that I figure we should just let users bone themselves.	2022-07-26 14:08:00 +09:00
Andrew Hong	a8e315abf0	Refactor	2022-07-25 17:16:33 -04:00
LukynkaCZE	a7c92fe5d6	Merge branch 'ppy:master' into add-missing-icons-to-recent-profile-section	2022-07-25 14:56:00 +02:00
Andrew Hong	fcf767e28b	Add contextmenu to beatmap external link	2022-07-25 04:07:33 -04:00
Salman Ahmed	4d90e6bbac	Flip method to read better	2022-07-25 10:03:06 +03:00
Salman Ahmed	e402e919ab	Display placeholder for user profile scores	2022-07-25 09:40:20 +03:00
Salman Ahmed	f54cee0270	Display placeholder for leaderboard top scores	2022-07-25 09:18:04 +03:00
Salman Ahmed	91d1c9686c	Separate unprocessed PP placeholder to own class	2022-07-25 09:07:51 +03:00
Salman Ahmed	54eb2b98a9	Display exclamation triangle on scores with unprocessed PP	2022-07-25 07:30:57 +03:00
Salman Ahmed	3beb1da3de	Merge branch 'master' into beatmap-overlay-null-pp	2022-07-25 07:18:03 +03:00
Bartłomiej Dach	446485f804	Move localisation string to common location	2022-07-24 23:30:52 +02:00
Bartłomiej Dach	8af9cfbe40	Add readonly modifier	2022-07-24 23:29:18 +02:00
Bartłomiej Dach	6a67d76d7c	Add basic mod preset column implementation	2022-07-24 16:39:04 +02:00
Bartłomiej Dach	b2f8934117	Extract base mod select column presentation logic	2022-07-24 16:39:03 +02:00
Salman Ahmed	7c477e6f22	Fix beatmap overlay leaderboard not handling null PP scores properly	2022-07-24 04:20:49 +03:00
LukynkaCZE	1aa0d49d81	Code Quality	2022-07-23 12:27:24 +02:00
LukynkaCZE	9db06fafd0	Fix code formatting	2022-07-23 12:16:11 +02:00
LukynkaCZE	33b442d5d0	Add missing icons to UserProfileRecentSection	2022-07-23 12:06:30 +02:00
Salman Ahmed	2829a7e836	Merge branch 'master' into beatmap-overlay-modded-stats	2022-07-23 10:38:13 +03:00
Salman Ahmed	661c79baf6	Add explanatory comment	2022-07-23 10:16:11 +03:00
Adam Baker	06462c13dd	Overwrite IBindable<ReadOnlyList<Mod>> cache in BeatmapSetOverlay ... Implement fix as suggested	2022-07-22 23:15:24 -05:00
Adam Baker	d451bc8fda	Revert commits ... This reverts commit 28586c704d. This reverts commit d9d35bb847.	2022-07-22 22:25:49 -05:00
Bartłomiej Dach	f3ceabc53f	Rename ModSelect{Overlay -> }Panel	2022-07-22 19:17:22 +02:00
Adam Baker	d9d35bb847	Set BeatmapSetHeaderContent details to not show modded values	2022-07-22 05:43:56 -05:00
Bartłomiej Dach	a3090003de	Add tooltip showing contents of mod preset	2022-07-21 23:29:21 +02:00
Bartłomiej Dach	bdff7f1ef4	Implement basic appearance of mod preset panels	2022-07-21 23:29:21 +02:00
Bartłomiej Dach	6cd18fad99	Fix code inspections after base panel class extraction	2022-07-21 23:29:08 +02:00
Bartłomiej Dach	d796b7d53c	Extract base mod select overlay panel presentation logic	2022-07-21 22:37:00 +02:00
Dan Balasescu	7dfc18a0e3	Merge pull request #19208 from frenzibyte/remove-score-multiplier-on-custom-mod-settings ... Remove score multiplier on difficulty-increasing mods with customised settings	2022-07-20 20:12:59 +09:00
Dean Herbert	62133fa069	Merge pull request #19246 from frenzibyte/fix-wiki-navigation ... Fix wiki overlay not handling path redirection properly	2022-07-20 20:08:11 +09:00
Salman Ahmed	5e933cb466	Improve comment wording ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2022-07-20 09:43:32 +03:00
Salman Ahmed	474c1a8a7a	Fix wiki overlay not handling path redirection properly	2022-07-20 09:06:11 +03:00
Salman Ahmed	6ce6f6f7df	Merge branch 'master' into remove-score-multiplier-on-custom-mod-settings	2022-07-20 08:57:43 +03:00
Salman Ahmed	1270abdf42	Highlight perfect slider tick/end values in beatmap info leaderboards	2022-07-20 00:53:10 +03:00
Salman Ahmed	4210ec6502	Merge branch 'master' into remove-score-multiplier-on-custom-mod-settings	2022-07-19 19:21:26 +03:00
Salman Ahmed	89653b74c7	Only add setting tracker when customisation is permitted	2022-07-19 19:21:16 +03:00
Salman Ahmed	b5c7d07ba8	Merge branch 'master' into fix-user-profile-overlay	2022-07-18 10:27:33 +03:00
Dean Herbert	a7f19cc796	Merge pull request #19137 from frenzibyte/country-enum ... Replace `Country` class with enumeration	2022-07-18 16:12:24 +09:00
Salman Ahmed	e4d11febc5	Remove no longer necessary fallback	2022-07-18 09:47:40 +03:00
Salman Ahmed	84c1c26a7f	Merge branch 'master' into fix-user-profile-overlay	2022-07-18 09:45:25 +03:00
Salman Ahmed	018da74fe8	Replace default with CountryCode.Unknown	2022-07-18 08:54:35 +03:00
Salman Ahmed	100c53f9ef	Country -> CountryCode	2022-07-18 08:40:34 +03:00
Salman Ahmed	eddae7b143	Fix mod overlay and footer not updating multiplayer on settings change	2022-07-18 07:38:56 +03:00
Salman Ahmed	b33f8aa0fc	Fix "Start Chat" on multiplayer/playlist chat not opening overlay	2022-07-18 06:45:00 +03:00
Salman Ahmed	7e4ce89981	Include mod settings in profile score mod icons	2022-07-18 04:03:18 +03:00
tsunyoku	a5d7075ef1	simplify beatmap metadata logic in DrawableProfileScore	2022-07-17 18:10:47 +01:00
Dean Herbert	4e8bf1da52	Don't sent ruleset configuration failures to sentry	2022-07-18 01:23:46 +09:00
tsunyoku	7a6666996f	rename item to model in CreateDrawableItem	2022-07-17 14:50:53 +01:00
tsunyoku	486fbd2531	create instance of BeatmapInfo for use in ScoreBeatmapMetadataContainer	2022-07-17 14:47:04 +01:00
tsunyoku	7135329c8c	remove `PaginatedProfileScoreSubsectio, revert profile score drawables	2022-07-17 14:22:27 +01:00
tsunyoku	3a8b5d48b9	update PaginatedScoreContainer to use new class and format	2022-07-17 14:09:14 +01:00
tsunyoku	ef4237c4ac	create special subsection class for paginated profile scores	2022-07-17 14:08:31 +01:00
tsunyoku	e8d88e29c6	change DrawableProfileScore and DrawableProfileWeightedScore to take SoloScoreInfo and APIBeatmap instead of APIScore	2022-07-17 14:08:04 +01:00
Salman Ahmed	4968859e69	Rename placeholder display flag property to make sense	2022-07-16 06:07:53 +03:00
Salman Ahmed	e62049f4a9	Update various usages of Country inline with new enum	2022-07-16 05:04:24 +03:00
Salman Ahmed	838e9ec12e	Merge branch 'master' into placeholder-fixes	2022-07-15 20:22:25 +03:00
Dean Herbert	cf38b15332	Merge pull request #19124 from frenzibyte/song-select-metadata-search ... Change clicking source/tags on song select to filter instead of searching online	2022-07-15 19:16:31 +09:00
Dean Herbert	437e01427c	Fix beatmap listing not entering correct search mode when arriving before LoadComplete	2022-07-15 17:53:44 +09:00
Dan Balasescu	c1dd1cfead	Merge pull request #19082 from peppy/api-solo-score-model ... Add and consume `SoloScoreInfo`	2022-07-15 15:20:18 +09:00
Salman Ahmed	eafa11555a	Allow specifying custom search action to metadata sections	2022-07-15 06:41:03 +03:00
Dean Herbert	cd085cbd97	Merge pull request #19114 from frenzibyte/fix-potential-dialog-test-failure ... Fix dialog overlay potentially pushing dialog while not loaded	2022-07-15 12:34:19 +09:00
Salman Ahmed	aea786ea0c	Fix minor typo	2022-07-15 05:56:49 +03:00
Dean Herbert	08396ba486	Adjust colouring to avoid weird banding during transition period	2022-07-14 14:47:25 +09:00
Dean Herbert	5dff48a1e0	Fix button selection animation not playing smoothly when new glyphs are loaded	2022-07-14 14:40:25 +09:00
Dean Herbert	5c6b4e498d	Protect against a potential early call to LanguageButton.Selected	2022-07-14 14:31:59 +09:00
Dean Herbert	227871e8df	Refactor hide logic a touch for better readability	2022-07-14 14:00:33 +09:00
Salman Ahmed	dccd81dbc7	Use BindValueChanged to handle changes between push time and schedule execution	2022-07-14 07:07:32 +03:00
Salman Ahmed	b96faedbe6	Fix dialog overlay hiding early-pushed dialog on initial PopOut call	2022-07-14 07:06:57 +03:00
Salman Ahmed	c59784c49f	Always schedule popup dialog push	2022-07-14 07:06:03 +03:00
Salman Ahmed	1222123541	Rename method and parameter	2022-07-14 07:05:19 +03:00
Salman Ahmed	3def8428aa	Make scheduling more legible	2022-07-14 06:06:58 +03:00
Salman Ahmed	f83d413b33	Fix dialog overlay potentially pushing dialog while not loaded	2022-07-14 06:05:03 +03:00
Dean Herbert	3b554140db	Use grid container to avoid layout changes when changing language	2022-07-13 23:22:55 +09:00
Dean Herbert	0db1caf591	Add language selection to first run overlay	2022-07-13 23:22:55 +09:00
Dean Herbert	f956955d4d	Combine ScoreInfo construction helper methods	2022-07-12 18:00:25 +09:00
Dean Herbert	1bef2d7b39	Add and consume SoloScoreInfo	2022-07-12 18:00:25 +09:00
Dan Balasescu	7086779cf4	Merge pull request #19026 from peppy/async-track-operations ... Use fire-and-forget async operations on global track	2022-07-07 19:45:03 +09:00
Dean Herbert	d88fd8a5b0	Allow searching for "skins" to find current skin setting	2022-07-07 18:26:04 +09:00
Dean Herbert	7ef03dd2cb	Use fire-and-forget async operations on global track ... This avoids any blocking overhead caused by a backlogged audio thread. Test seem to pass so might be okay? Note that order is still guaranteed due to the `ensureUpdateThread` queueing system framework-side.	2022-07-07 17:15:45 +09:00
Dean Herbert	6fb00d84f9	Apply NRT to LoginForm and remove nullability of IAPIProvider	2022-07-06 01:29:00 +09:00
Dean Herbert	3a68f386a8	Add forgotten password link to login form	2022-07-06 01:25:04 +09:00
Dan Balasescu	9bf91835b6	Merge pull request #18962 from peppy/slider-range-control ... Move star difficulty filter to song select	2022-07-03 21:58:00 +09:00
Salman Ahmed	9b833524c0	Merge branch 'master' into add-realm-blocking-logging	2022-07-02 12:41:36 +03:00
Dean Herbert	a03abc747b	Tidy up comments and simplify bounding box centre logic	2022-07-02 12:58:34 +09:00
Dean Herbert	4fd47b5fa0	Add more verbose logging to realm blocking process	2022-07-02 12:36:56 +09:00
Jamie Taylor	9d28d5f8ee	Update SFX for mod overlay show/hide	2022-07-01 20:43:12 +09:00
Salman Ahmed	5880b824d0	Simplify description logic for overlay tab items	2022-07-01 11:30:51 +03:00
Salman Ahmed	7f9ef6c23f	Merge branch 'master' into fix-overlay-header-tab-item-localisable-string	2022-07-01 11:27:00 +03:00
Dean Herbert	d54f7fc728	Move slider range control to song select	2022-07-01 14:41:36 +09:00
Salman Ahmed	87e3b44181	Ensure icon is loaded inside try-catch	2022-06-29 13:37:42 +03:00
Dean Herbert	6c64cea057	Catch a second location	2022-06-29 18:56:15 +09:00
Dean Herbert	569fde4b47	Add messages to all InvalidOperationExceptions ... Without this, they can be very non-descript and hard to track down	2022-06-28 01:34:25 +09:00
Dan Balasescu	6c6de9ce53	Fix typo	2022-06-27 20:40:02 +09:00
Dean Herbert	50c1c066de	Add various logging of global WorkingBeatmap state changes	2022-06-27 18:41:31 +09:00
Dean Herbert	31a447fda0	Update parameter discards	2022-06-24 21:26:19 +09:00
Dean Herbert	30eebf3511	Merge branch 'master' into c-sharp-10	2022-06-24 21:22:33 +09:00
Bartłomiej Dach	26c5b59f6d	Replace usages of string.To{Lower,Upper}()	2022-06-24 11:57:45 +02:00
Dean Herbert	f71f6302fd	Remove unnecessary null casts	2022-06-24 14:50:11 +09:00
Dean Herbert	d9c1a9d71f	Use new property to specify no tooltip, rather than passing only ruleset	2022-06-24 14:06:18 +09:00
Dean Herbert	7dec530ca5	Split out simple DifficultyIcon with no calculation overhead and update usages	2022-06-23 19:27:35 +09:00
Dean Herbert	b660119de7	Merge pull request #18796 from bdach/mod-overlay/legacy-key-bindings ... Add setting option to toggle between mod overlay hotkey styles	2022-06-22 20:28:18 +09:00
Dan Balasescu	b81c7c7951	Merge pull request #18804 from Joehuu/online-view-chat-overlay ... Add back online view container to chat overlay	2022-06-22 14:41:06 +09:00
Dan Balasescu	ff440fc1a4	Fix too many buttons inside condition	2022-06-22 13:44:41 +09:00
Dan Balasescu	321920bc85	Remove one more nullable disable	2022-06-22 13:44:41 +09:00
Dan Balasescu	1018c9852d	Cleanup nullability	2022-06-22 13:44:41 +09:00
Dan Balasescu	23254d2ff2	Fix broken files	2022-06-22 13:44:41 +09:00
Joseph Madamba	07e0cd53a4	Add back online view container to chat overlay	2022-06-21 19:23:16 -07:00
Joseph Madamba	50728f3fbc	Fix overlay header tab item not working with localisable string	2022-06-21 18:31:09 -07:00
Supersonicboss1	4aa86b0a80	fixed duplicates and cleaned up code	2022-06-21 23:41:25 +01:00
Supersonicboss1	e4931f977c	improved UI of maintenance section in settings	2022-06-21 23:00:03 +01:00
Bartłomiej Dach	7013909322	Remove unnecessary protected virtual	2022-06-21 16:43:04 +02:00
Bartłomiej Dach	f564ed589f	Alter sequential hotkey style to always use visible index ... Previous behaviour was once mentioned off-hand as unintuitive.	2022-06-21 15:22:18 +02:00
Bartłomiej Dach	9e5cc89edb	Fix classic hotkeys toggling filtered mods	2022-06-21 15:01:33 +02:00
Bartłomiej Dach	da1814e7c3	Restructure everything to fix free mod overlay issue	2022-06-21 14:48:41 +02:00
Bartłomiej Dach	7b7b8c1892	Implement behaviour for classic selection style	2022-06-21 14:24:30 +02:00
Bartłomiej Dach	234120ff43	Forward entire event to IModHotkeyHandler ... Required for shift handling in the classic implementation.	2022-06-21 13:37:17 +02:00
Bartłomiej Dach	658f5341c7	Set up flow for switching between hotkey styles	2022-06-21 13:34:58 +02:00
Bartłomiej Dach	5abd8a07d2	Add setting for changing mod select hotkey style	2022-06-21 13:33:17 +02:00
Bartłomiej Dach	73124d2b1f	Encapsulate mod hotkey selection logic in strategy pattern	2022-06-21 12:49:01 +02:00
Bartłomiej Dach	ee96d84ffa	Merge branch 'master' into input-settings	2022-06-20 22:55:43 +02:00
Dean Herbert	6515b249ec	Change data migration to do an immediate exit, rather than attempted exit	2022-06-19 12:39:58 +09:00
Dean Herbert	50e40756c4	Rename GracefullyExit to AttemptExit	2022-06-19 12:34:44 +09:00
Dan Balasescu	f8830c6850	Automated #nullable processing	2022-06-17 16:37:17 +09:00
Salman Ahmed	e4ddf03ad6	Fix toolbar music button handling keys while not hovered	2022-06-16 20:22:57 +03:00
Bartłomiej Dach	9c4f6d2ce0	Merge branch 'master' into first-run-setup-notification-interruption	2022-06-16 15:14:40 +02:00
Dean Herbert	251923c106	Convert NotificationOverlay to NRT	2022-06-16 17:28:08 +09:00
Dean Herbert	6b30ee0950	Tidy up DI and binding logic	2022-06-16 17:26:43 +09:00
Bartłomiej Dach	f88c568c8d	Update flag sizes after switch to twemoji assets ... The old flags used a size of 150x100, while the new assets based on twemoji use a size of 150x108. Update existing usages to match this new aspect ratio better.	2022-06-15 21:45:47 +02:00
Salman Ahmed	e7dcbddbeb	Fix potential null reference	2022-06-15 18:53:49 +03:00
Salman Ahmed	026bad7fc4	Use notification processing mode logic instead	2022-06-15 18:13:24 +03:00
Dean Herbert	7571ab6c63	Merge branch 'master' into new-dialog-sfx	2022-06-15 19:47:00 +09:00
Dean Herbert	584345a97e	Merge pull request #18693 from frenzibyte/toolbar-volume-control ... Add basic volume control support in toolbar music button	2022-06-15 17:50:10 +09:00
Dean Herbert	b3aa4fcf02	Adjust a channel rather than the overall sample	2022-06-15 17:33:07 +09:00
Dean Herbert	94aa2248ca	Move filter reset to more appropriate location	2022-06-15 17:32:21 +09:00
Dean Herbert	1f1633ddc2	Remove Update method processing of samples in PopupDialogDangerousButton	2022-06-15 16:50:23 +09:00
Salman Ahmed	583619b915	Use GlobalAction.DecreaseVolume instead	2022-06-15 10:21:27 +03:00
Dean Herbert	873806c2ea	Add keyboard adjustment support	2022-06-15 15:58:22 +09:00
Dean Herbert	3df9d7c9e1	Add a bit more animation when adjusting	2022-06-15 15:56:59 +09:00
Dean Herbert	5eb56ab814	Ensure Master volume is updated when scrolling on toolbar button	2022-06-15 15:41:40 +09:00
Jamie Taylor	af87722be8	Add audio feedback for 'Dangerous' dialog buttons	2022-06-15 15:41:27 +09:00
Jamie Taylor	930ec2a197	Add specific samples for dialog 'Ok' and 'Cancel' buttons	2022-06-15 15:41:27 +09:00
Salman Ahmed	ddeee09a51	Fix important notifications interrupting first-run setup	2022-06-15 03:40:05 +03:00
Salman Ahmed	1f31e3fb51	Add volume UI to toolbar music button	2022-06-14 22:15:12 +03:00
Salman Ahmed	7f23677972	Add volume control support via toolbar music button	2022-06-14 22:15:12 +03:00
Dean Herbert	49ec2572b8	Allow scrolling overflow of ruleset buttons in the toolbar	2022-06-15 01:43:10 +09:00
Salman Ahmed	d89c11e49e	Allow Toolbar to block scroll input from passing through	2022-06-14 19:10:13 +03:00
Dean Herbert	77fcf35d1d	Remove unlimited frame limiter warning ... This should not be required now that we have a 1,000 Hz limiter in place.	2022-06-13 15:40:27 +09:00
Dan Balasescu	e5d6dc1ba5	Merge pull request #18606 from peppy/latency-comparer ... Add latency certifier system	2022-06-10 19:41:44 +09:00
Dan Balasescu	c9dfffbc0e	Merge pull request #18619 from peppy/fix-collection-performance ... Fix performance overhead of large collections	2022-06-10 15:01:31 +09:00
Dean Herbert	c625c929e5	Update button text to match new terminology	2022-06-10 14:16:56 +09:00
Dean Herbert	4a5e86e451	Rename Beatmaps to BeatmapHashes for clarity	2022-06-10 14:03:51 +09:00
Dean Herbert	3b229624dd	Simplify contains check to use LINQ the whole way	2022-06-10 14:02:58 +09:00
Dan Balasescu	bc7262a3dd	Merge pull request #18627 from Joehuu/always-show-mod-selector-beatmap-info ... Always show mod selector on beatmap info leaderboards regardless of supporter	2022-06-09 18:18:12 +09:00
Joseph Madamba	f3371e8bc8	Always show mod selector on beatmap info leaderboards regardless of supporter	2022-06-08 13:22:49 -07:00
Jai Sharma	c2ed41d097	Remove CanBeNull specification from DI attributes	2022-06-08 15:10:19 +01:00
Jai Sharma	04b434b8ce	Update ChatLine timestamp and message colours	2022-06-08 14:04:01 +01:00
Jai Sharma	dfa31df2af	Use #nullable enable in ChatLine	2022-06-08 14:04:01 +01:00
Dean Herbert	c22bffaa01	Fix filter failure when no collection is selected	2022-06-08 19:30:18 +09:00
Dean Herbert	187086e4ec	Merge pull request #18609 from ALANVF/settings-delete-skin ... Add button to delete the current skin	2022-06-08 19:18:59 +09:00
Dean Herbert	42cd7d9e6e	Change CollectionManager to only store MD5 hashes instead of full BeatmapInfo	2022-06-08 18:23:09 +09:00
Dan Balasescu	3a90aa0b9b	Fix code styling	2022-06-08 17:57:59 +09:00
Dean Herbert	5157a78ae6	Isolate nested sample screens from main game to avoid toolbar interactions	2022-06-08 16:53:06 +09:00
theangryepicbanana	6c05329144	Close #5820 (Ability to delete a single skin)	2022-06-07 18:01:40 -04:00
Jai Sharma	2f635fa854	Refactor ChatLine and fix DrawableChannel flow padding ... Refactors `ChatLine` component to use more sensible override properties and layout using grid container. Moves creation of username component into its own method to simplify BDL. Updates padding of base `DrawableChannel` flow padding. Removes usage of `ChatOverlayDrawableChannel` since it's overrides are no longer needed. Updates usage of `StandAloneChatDisplay` to use new override properties of `DrawableChannel`.	2022-06-07 22:35:45 +01:00
Dean Herbert	9da99a0ddf	Rename to latency certifier	2022-06-07 23:34:55 +09:00
Dean Herbert	95dea00725	Tidy up code and namespaces	2022-06-07 23:10:08 +09:00
Dean Herbert	20cfa5d83f	Add button to access latency comparer from game	2022-06-07 17:28:31 +09:00
Bartłomiej Dach	4df7711af8	Merge branch 'master' into volume-metre-keyboard-fix	2022-06-06 23:45:42 +02:00
Dean Herbert	b104b7a90d	Rename method to mention "all"	2022-06-06 20:12:20 +09:00
Dean Herbert	cb383d4bdc	Merge branch 'master' into delete-all-beatmap-videos-sbs	2022-06-06 20:08:05 +09:00
Jai Sharma	c0aaeff2b3	Update DaySeparator to use new design throughout ... Moves `DaySeparator` chat component to it's own file and update it to match new chat design. Makes use of several virtual attributes that can be overridden to update spacing and layout in other usage contexts. Remove redundant usage of `ChatOverlayDaySeparator`, since the new design is now part of the base class. Create `StandAloneDaySeparator` to use in `StandAloneChatDisplay` which overrides attributes to match correct spacing and layout for its design. Ensure that `DrawableChannel.CreateDaySeparator` returns type of `DaySeparator` instead of `Drawable`.	2022-06-04 18:02:14 +01:00
Joseph Madamba	58c8562cb0	Fix username placeholder text casing and missing localisation on registration form	2022-06-03 20:09:20 -07:00
Dean Herbert	d0e098fbcd	Allow using arrow keys to navigate volume controls when controls are already visible	2022-06-04 01:04:46 +09:00
Dean Herbert	712253a35b	Make non-localisable strings in VolumeMeter verbatim	2022-06-04 01:04:23 +09:00
Dean Herbert	64616a6d73	Remove completely gimped implementation in VolumeMeter	2022-06-04 00:18:54 +09:00
Jamie Taylor	6115275bc2	Use 'default' sampleset for toolbar and repurpose 'toolbar' select sample temporarily	2022-06-03 22:33:06 +09:00
Jamie Taylor	2878bb592f	Use more appropriate sounds for certain components	2022-06-03 22:32:12 +09:00
Jamie Taylor	365819865e	Remove 'submit' sample usages	2022-06-03 22:31:35 +09:00
Salman Ahmed	cd999cf7ac	Fix back-to-front conditional	2022-06-03 10:51:20 +03:00
Salman Ahmed	1a835f0622	Add warning note when running fullscreen on macOS	2022-06-03 10:32:59 +03:00
Dean Herbert	5bd9d88219	Fix tutorial download state not matching correctly when already available locally ... Closes https://github.com/ppy/osu/issues/18468. This doesn't stop the tutorial from downloading a second time, but at least displays the correct status afterwards. Avoiding the download is a bit more involved and requires a change to the flow. Probably not worth it just yet. To test, recommend switching to production environment, as dev server doesn't have correct metadata for tutorial resulting in weirdness.	2022-06-02 16:34:24 +09:00
Dean Herbert	42598ce22a	Refactor warning to notice in method names and usages	2022-06-01 16:51:58 +09:00
Dean Herbert	f7110116de	Only display exclusive fullscreen hinting on windows	2022-05-31 14:04:56 +09:00
Dean Herbert	53844d3df1	Refactor settings item "warning" text to allow non-warning state	2022-05-31 14:01:42 +09:00
Dan Balasescu	99ee3a7d8d	Merge branch 'master' into detect-exclusive-fullscreen	2022-05-31 09:42:42 +09:00
Dean Herbert	1d5a156c15	Merge pull request #18427 from sw1tchbl4d3r/currently_playing_search ... Add search bar for the `CurrentlyPlayingDisplay`	2022-05-30 23:03:00 +09:00
Dean Herbert	f65d2db77f	Remove "V2" suffix from ChatOverlay components	2022-05-30 17:54:09 +09:00
Dan Balasescu	5f9a69e5c2	Add localisation	2022-05-30 17:19:03 +09:00
Dan Balasescu	dea7a27553	Adjust wording, add text for capable state	2022-05-30 17:18:29 +09:00
Dean Herbert	9e678101cf	Merge pull request #18442 from jai-x/new-chat-announce-channel ... Display Announce type channels separately in new chat overlay	2022-05-30 16:53:15 +09:00
Dean Herbert	5478ac21ea	Merge branch 'master' into currently_playing_search	2022-05-30 16:48:53 +09:00
Jai Sharma	8f596520f3	Remove old chat overlay components	2022-05-29 20:08:43 +01:00
Bartłomiej Dach	e329c160b3	Simplify channel retrieval expression	2022-05-29 18:58:27 +02:00
Bartłomiej Dach	e69f8716cd	Fix incorrect indent size	2022-05-29 18:56:37 +02:00
Bartłomiej Dach	f9f8a32380	Merge branch 'master' into new-chat-announce-channel	2022-05-29 18:55:43 +02:00
Dean Herbert	7c97719db1	Move Schedule to only drawable pieces	2022-05-29 21:28:09 +09:00
Dean Herbert	c7570fbce5	Fix potential ObjectDisposedException on realm notification in SkinSection	2022-05-29 15:15:03 +09:00
sw1tchbl4d3	ede3ab9dc0	Add OnFocus handler to CurrentlyPlayingDisplay	2022-05-28 12:04:44 +02:00
Salman Ahmed	06832a4baf	Fix beatmap badge colours not updated inline with recent changes	2022-05-28 01:05:43 +03:00
sw1tchbl4d3	cd84200ad9	Add HoldFocus and ReleaseFocusOnCommit attributes to searchbar	2022-05-27 21:23:37 +02:00
Jai Sharma	c5845f307a	Code quality	2022-05-27 20:12:00 +01:00
Dean Herbert	254039b8fe	Address remaining code quality concerns	2022-05-28 04:01:51 +09:00
Jai Sharma	e950c8c1d0	Refactor ChannelList to use new ChannelGroup class for each type of channel	2022-05-27 19:46:53 +01:00
Jai Sharma	320b6ca631	Display Announce type channels separately in new chat overlay	2022-05-27 16:18:22 +01:00
Bartłomiej Dach	e511c1dfff	Merge branch 'master' into use-normalised-precise-scrolling	2022-05-27 16:55:13 +02:00
sw1tchbl4d3	e2951d70d1	Address code style issues	2022-05-27 16:38:54 +02:00
sw1tchbl4d3	e1fd37fd44	Use new padding constant where appropriate	2022-05-27 12:40:31 +02:00
sw1tchbl4d3	6a0cf26722	Make text localisable and add padding constant	2022-05-27 12:36:43 +02:00
sw1tchbl4d3	7c459faaf0	Remove unneeded search_bar_width and more	2022-05-27 10:05:59 +02:00
sw1tchbl4d3	4967d03606	Update currently playing search bar to resemble existing UI	2022-05-27 09:58:40 +02:00
Joseph Madamba	105d581f24	Use existing web localisation for chat strings	2022-05-26 22:23:03 -07:00
Joseph Madamba	3554563114	Fix beatmap info scores container not hiding when there's no leaderboard	2022-05-26 19:50:54 -07:00
Joseph Madamba	2b5aa35b56	Fix beatmap info status pill being incorrect on multiple status beatmaps	2022-05-26 17:52:17 -07:00
sw1tchbl4d3	a8e453e660	Remove now unnecessary username filter check	2022-05-27 00:43:29 +02:00
sw1tchbl4d3	de5b60ab66	Move filtering from manual loops to SearchContainer	2022-05-27 00:40:23 +02:00
sw1tchbl4d3	3183621d3d	Add search bar for the CurrentlyPlayingDisplay	2022-05-26 22:57:24 +02:00
Dean Herbert	a98d0cf0d8	Simplify channel filter method	2022-05-26 18:48:11 +09:00
Dean Herbert	b2607196b8	Merge branch 'master' into new-chat-integrate	2022-05-26 18:38:26 +09:00
Dan Balasescu	08935cff86	Detect exclusive fullscreen on Windows	2022-05-26 18:37:04 +09:00
Noah M	b550cbc5a3	Fix failing code quality checks	2022-05-25 17:01:30 -05:00
Bartłomiej Dach	a1b8fa0992	Disable "select all mods" button if all are selected	2022-05-25 23:06:12 +02:00
Bartłomiej Dach	071e158a29	Expose available mod state outwardly as a bindable	2022-05-25 23:06:12 +02:00
Bartłomiej Dach	f0303d76e8	Split off "select all mods" button to separate class	2022-05-25 22:18:30 +02:00
Bartłomiej Dach	a3f2962558	Disable "deselect all mods" button if none are selected	2022-05-25 22:15:02 +02:00
Bartłomiej Dach	a4bd399b0c	Split off "deselect all mods" button to separate class	2022-05-25 22:14:45 +02:00
Jai Sharma	f94afa5f8c	Code quality	2022-05-25 18:28:18 +01:00
Jai Sharma	997fc716e8	Split out the channel list labels from the channel list item flow	2022-05-25 15:15:46 +01:00
Jai Sharma	c0da05dda0	Use an array of channels to exclude from the overlay	2022-05-25 15:15:26 +01:00
Jai Sharma	cd90d29315	Ensure channel traversal shortcut scrolls channel list item into view	2022-05-25 12:37:28 +01:00
Jai Sharma	4a36f3aa4c	Ensure channel traversal shortcut is using visual order	2022-05-25 12:29:04 +01:00
Dean Herbert	49ab031e75	Allow traversing in both directions using ctrl-tab shortcuts	2022-05-25 18:42:49 +09:00
Dean Herbert	a92089c443	Change filter method to consider all non-system channels as joinable	2022-05-25 18:42:33 +09:00
Dan Balasescu	79c8752bb4	Merge pull request #18408 from peppy/first-run-ui-scale-first ... Move UI scale setup to the beginning of the first run setup	2022-05-25 12:56:03 +09:00
Dean Herbert	de5d2df100	Move UI scale setup to the beginning of the first run setup	2022-05-25 12:19:26 +09:00
Dan Balasescu	f468d1eb16	Merge branch 'master' into editor-tidy-up	2022-05-25 11:58:34 +09:00
Jai Sharma	f6810d3f59	Add keyboard shortcuts to ChatOverlayV2 with tests	2022-05-24 23:05:25 +01:00
Bartłomiej Dach	61c093c109	Merge branch 'master' into rounded-button-colour-default	2022-05-24 22:47:47 +02:00
Jai Sharma	fce527b0df	Schedule channel manager bindable events to ensure they happen after the first poll	2022-05-24 21:25:27 +01:00
Bartłomiej Dach	2dd0b3f8d9	Merge branch 'master' into fix-mod-panel-click-area	2022-05-24 21:52:37 +02:00
Dean Herbert	0bcf8c846c	Change editor colour scheme to aquamarine	2022-05-24 18:43:22 +09:00
Dean Herbert	f00dd27fcd	Move OverlayColourProvider provisioning of RoundedButton to SettingsButton for now	2022-05-24 18:11:54 +09:00
Joseph Madamba	1f935cacf4	Add spotlighted beatmaps filter to beatmap listing	2022-05-23 18:47:04 -07:00
Joseph Madamba	ed0b841df0	Fix incorrect left/right clicking area of mod panels	2022-05-23 18:29:26 -07:00
apollo-dw	eae2378466	Add WIP to search filters	2022-05-24 01:49:07 +01:00
Jai Sharma	58d39734d0	Integrate ChatOverlayV2 into main game	2022-05-23 21:02:47 +01:00
Susko3	88217e0c98	Adjust ScrollDelta usages to account for normalised IsPrecise values	2022-05-23 20:22:27 +02:00
Dean Herbert	7d93778355	Merge pull request #18290 from jai-x/new-chat-remove-selector-item ... Use dummy channel to show selector and remove `ChannelListSelector`	2022-05-23 15:49:00 +09:00
Dean Herbert	d84119ac06	Merge pull request #18343 from frenzibyte/waveform-test-beatmap-failure ... Fix `WaveformTestBeatmap`s potentially providing disposed track	2022-05-22 21:21:28 +09:00
Jai Sharma	fb06b7658b	Merge branch 'master' into new-chat-remove-selector-item	2022-05-21 17:30:06 +01:00
Dean Herbert	4633eed78c	Merge branch 'master' into localisable-filter-items	2022-05-20 23:55:16 +09:00
Salman Ahmed	abf9039109	Use == instead of ??	2022-05-20 16:08:31 +03:00
Salman Ahmed	c78d90ccbd	Refactor track transferring logic for ability to override and disallow	2022-05-20 14:43:07 +03:00
Jai Sharma	c37d1e4fae	Ensure current channel is set to the ChannelListingChannel when it becomes null	2022-05-19 11:45:39 +01:00
Dean Herbert	136ecb45e2	Rename dummy channel and move to a nested class inside the ChannelListing itself	2022-05-19 19:26:14 +09:00
Dean Herbert	63c9776365	Fix oversight in bindable logic in new overlay class	2022-05-19 19:24:18 +09:00
Dean Herbert	363e7a6f53	Simplify toolbar hiding logic in FirstRunSetupOverlay ... Rather than fiddling around with the activation modes, this seems like a much cleaner way to make things work. Closes https://github.com/ppy/osu/issues/18277.	2022-05-19 16:42:48 +09:00
Dean Herbert	d187ca2d8c	Merge pull request #18246 from jai-x/new-chat-cache-loaded-channels ... Add drawable channel caching to new chat overlay	2022-05-19 15:15:47 +09:00
Dean Herbert	a443200d0d	Make dependency nullable to allow for safer disposal unbinding	2022-05-19 13:49:52 +09:00
Noah M	0ef9406787	Fix deleteBeatmapVideosButton not being reenabled ... My bad	2022-05-18 16:35:14 -05:00
Noah M	617382a56f	Split off MassVideoDeleteConfirmationDialog into its own file	2022-05-18 15:20:57 -05:00
Salman Ahmed	5d3878a737	Add test coverage for slow-loading channels	2022-05-18 22:58:39 +03:00
Jai Sharma	371738b047	Check against the loaded drawable channel	2022-05-18 20:00:42 +01:00
Dean Herbert	0cee90e156	Add common strings for missing localisable content	2022-05-18 21:32:57 +09:00
Dean Herbert	d54e1503c7	Rename interaction toggle method	2022-05-18 21:32:57 +09:00
Dean Herbert	fa09270e62	Remove left-over todo	2022-05-18 21:32:57 +09:00
Noah M	69351d2cdf	Implement button to delete all beatmap videos	2022-05-18 01:20:57 -05:00
Jai Sharma	4015042e36	Ensure close button component is not stored as a Drawable	2022-05-18 01:35:39 +01:00
Bartłomiej Dach	c2555a91c7	Merge branch 'master' into first-run-screen-import-from-stable	2022-05-17 22:52:01 +02:00
Bartłomiej Dach	10b881dbf7	Merge branch 'master' into first-run-screen-button-ux	2022-05-17 22:27:49 +02:00
Jai Sharma	932442e242	Use null for empty grid cells in ChannelListItem	2022-05-17 18:52:19 +01:00
Dean Herbert	062ffe64ac	Remove delay on pop in	2022-05-17 18:21:19 +09:00
Dean Herbert	bf00b062ad	Add full localisation of import beatmaps screen	2022-05-17 17:58:24 +09:00
Dean Herbert	f4e0ad8c4c	Fix drag drop of osu! folder not working as expected	2022-05-17 17:51:28 +09:00
Dean Herbert	c0de1f96ff	Tidy up interaction toggling and add progress message	2022-05-17 17:33:54 +09:00
Dean Herbert	03d3900a02	Fix incorrect default state of checkboxes	2022-05-17 17:33:54 +09:00
Dean Herbert	adc7b61240	Switch directory selector to use a semi-shared popover implementation	2022-05-17 17:33:54 +09:00
Dean Herbert	e2ea98693f	Tidy up buttons and text	2022-05-17 17:33:54 +09:00
Dean Herbert	4af1a788d1	Add locate stable button / screen	2022-05-17 15:55:53 +09:00
Dean Herbert	1593f05ff3	Tidy up checkbox implementation	2022-05-17 15:55:53 +09:00
Dean Herbert	13e70eab51	Allow cancellation of count operations and bypassing interactive location logic	2022-05-17 15:55:53 +09:00
Dean Herbert	1666d13d26	Add item counts to import screen	2022-05-17 15:55:53 +09:00
Dean Herbert	4412fec41a	Add import from stable screen	2022-05-17 15:55:52 +09:00
Dean Herbert	ef5b2233d7	Improve the first run progress button to show loading and completion status	2022-05-17 15:23:13 +09:00
Dan Balasescu	a633501687	Change FilterTerms to use LocalisableString	2022-05-16 14:09:37 +09:00
Jai Sharma	ae5b6c3e10	Use dummy channel to show selector and remove ChannelListSelector ... Add dummy channel `DummySelectorChannel` which should be set as the current channel in the channel manager when the selector in the chat overlay should be shown. Refactors the `ChannelListItem` to not show mention pill and close button when the channel is the dummy selector channel. Ensure that the `ChannelList` selects the dummy channel on clicking the selector item. Removes `ChannelListSelector` as it is no longer needed. Removes the `setCurrent` parameter from `ChannelManager.JoinChannel` method as it is no longer needed.	2022-05-15 20:24:49 +01:00
Bartłomiej Dach	170df01b46	Adjust difficulty multiplier scale transition on mod overlay ... The previous transition was supposed to be a center-anchored elastic scale-in, but this didn't work as intended - because the multiplier ended up inside of an auto-sized right-aligned container, the animation itself would end up being anchored right. Attempts to remove the scale transition resulted in a rather jarring-looking result, so swap out the elastic scale-in for a sweep-in effect from the top, to match the header and avoid introducing too many directions of movement. Delay values tweaked "to taste" - can be adjusted further if there is an alternative set of values that feels better.	2022-05-15 20:44:50 +02:00
Dean Herbert	328561f5c8	Merge pull request #18263 from frenzibyte/spotlight-beatmap-badge ... Add support for "spotlight" label in beatmap overlay/listing	2022-05-15 12:32:20 +09:00
Salman Ahmed	4bb06873d5	Move badge hierarchy declaration to constructor for safer access	2022-05-14 21:54:56 +03:00
Dean Herbert	8a01050168	Refactor mod select button initialisation to allow shared usage of deselect button	2022-05-15 03:16:43 +09:00
Salman Ahmed	1878578196	Move todo comment to subclasses	2022-05-14 21:05:34 +03:00
Salman Ahmed	441957e18e	Convert get-only virtual properties to avoid DI order dependency	2022-05-14 21:05:34 +03:00
Salman Ahmed	88ba84ac9c	Replace Pill with Badge everywhere	2022-05-14 20:52:38 +03:00
Dean Herbert	a759cf2dab	Add key binding to deselect all mods ... Defaults to `Backspace`.	2022-05-15 02:51:58 +09:00
Salman Ahmed	2878a6dcbe	Integrate spotlight beatmap badge in info overlay	2022-05-14 19:47:10 +03:00
Salman Ahmed	56d6cb5764	Add "spotlight" beatmap badge	2022-05-14 19:46:50 +03:00
Salman Ahmed	c8bea6273b	Abstractify beatmap badge logic to own class	2022-05-14 19:46:37 +03:00
Jai Sharma	bd68ffa805	Fix textbox focus test in ChatOverlayV2	2022-05-14 12:16:00 +01:00
Jai Sharma	2163a78b7f	Ensure drawable channels removed from the cache are disposed	2022-05-14 00:15:09 +01:00
Jai Sharma	f88e416d1a	Ensure the wrong drawable channel isn't shown after load	2022-05-13 23:39:09 +01:00
Jai Sharma	9f5351e5a1	Add drawable channel caching to new chat overlay	2022-05-12 23:58:41 +01:00
Dean Herbert	8760e5d884	Merge branch 'master' into new-chat-drawable-channel	2022-05-12 22:36:19 +09:00
Dan Balasescu	5f2d9bf04c	Merge pull request #18211 from frenzibyte/audio-adjustment-breakage-alt ... Fix mods potentially adjusting track while not selected	2022-05-12 15:44:19 +09:00
Salman Ahmed	82c4a5fe9f	Merge branch 'master' into new-chat-visibility-behaviour	2022-05-12 09:04:24 +03:00
Dean Herbert	3d64dc53a6	Merge branch 'master' into audio-adjustment-breakage-alt	2022-05-12 14:18:28 +09:00
Dean Herbert	6ba0760b17	Merge branch 'master' into new-chat-visibility-behaviour	2022-05-12 13:59:35 +09:00
Dean Herbert	1d38e5bd33	Add notes about weird local handling in ChannelListSelector	2022-05-12 13:58:10 +09:00
Dean Herbert	2dfed6eda1	Remove selectorActive bindable completely	2022-05-12 13:53:57 +09:00
Jai Sharma	db371ab068	Use CurrentChannel == null to show the channel selector	2022-05-11 22:52:15 +01:00
Bartłomiej Dach	981ead68bf	Ensure local mods are constructed in time for Pop{In,Out}()	2022-05-11 22:31:27 +02:00
Bartłomiej Dach	93539160ad	Remove no-longer-necessary guard	2022-05-11 22:31:26 +02:00
Bartłomiej Dach	2266a5c9a0	Remove no-longer-necessary ModColumn.Filter	2022-05-11 22:31:26 +02:00
Bartłomiej Dach	1c0166367d	Fix remaining column operations being coupled to drawables	2022-05-11 22:31:26 +02:00
Bartłomiej Dach	b5a9f1310a	Fix select/deselect all toggle not working correctly after changes	2022-05-11 22:31:26 +02:00
Bartłomiej Dach	52bbce12f1	Fix not being able to set AvailableMods before loaded	2022-05-11 22:31:26 +02:00
Bartłomiej Dach	fc24a56478	Add protection from recursive updates from external selection	2022-05-11 22:31:25 +02:00
Bartłomiej Dach	83ba06e7af	Extract helper property for accessing all mods	2022-05-11 22:31:25 +02:00
Bartłomiej Dach	11ae1da65a	Hoist reference replacement logic to overlay level	2022-05-11 22:26:47 +02:00
Bartłomiej Dach	05a21fbbe0	Hoist ModState to overlay level	2022-05-11 22:26:21 +02:00
Bartłomiej Dach	e86444c4bf	Hoist ModState to column level	2022-05-11 22:03:49 +02:00
Bartłomiej Dach	74599c9c62	Use ModState in mod panels	2022-05-11 22:03:48 +02:00
Bartłomiej Dach	478cfc0b87	Split model class for mod state	2022-05-11 22:03:48 +02:00
Bartłomiej Dach	ddb2d4eef5	Rename FreeModSelect{Screen -> Overlay} reference in inline comment	2022-05-11 18:06:09 +02:00
Bartłomiej Dach	a104277e7f	Rename ModSelect{Screen -> Overlay}Strings	2022-05-11 18:01:33 +02:00
Bartłomiej Dach	76c63f1d0a	Rename ModSelect{Screen -> Overlay} in place of removed old design	2022-05-10 22:56:50 +02:00
Bartłomiej Dach	33634cba1e	Remove old mod buttons	2022-05-10 21:58:22 +02:00
Bartłomiej Dach	8b0ece1c09	Remove old mod section	2022-05-10 21:55:54 +02:00
Bartłomiej Dach	dfd97701d7	Remove old mod settings container & related controls	2022-05-10 21:53:42 +02:00
Bartłomiej Dach	128468e13d	Remove old base mod select overlay	2022-05-10 21:52:30 +02:00
Bartłomiej Dach	24c59e2f2f	Remove old user mod select overlay	2022-05-10 21:52:17 +02:00
Salman Ahmed	9446be2511	Remove unnecessary UnbindAdjustments call ... It is not necessary given that `CurrentTrack` already removes all adjustments first.	2022-05-10 20:49:44 +03:00
Salman Ahmed	36a7644164	Reinstantiate mod adjustments layer for safety against previous mods	2022-05-10 20:46:33 +03:00
Salman Ahmed	725ff93f34	Define local adjustments component for mods in MusicController ... Isolates `CurrentTrack` from being directly adjusted by the mod, which could lead to issues depending on how the mod adds adjustments (i.e. `ModTimeRamp`, which adds adjustments based on changes to a setting bindable).	2022-05-10 18:24:29 +03:00
Dan Balasescu	42fe708225	Fix inspection	2022-05-10 19:56:21 +09:00
Dean Herbert	a578f7a406	Force nested screens to load synchronously	2022-05-10 18:21:35 +09:00
Dean Herbert	a93c63b2b5	Add loading spinner when loading first run screens	2022-05-10 18:21:35 +09:00
Dean Herbert	25c6226ca9	Adjust transition length for a more seamless screen change	2022-05-10 18:21:35 +09:00
Dean Herbert	493798ae5e	Fix nested ui scale example screens no longer fitting	2022-05-10 18:21:35 +09:00
Dean Herbert	63b9e01d38	Fix behaviour screen using old style buttons	2022-05-10 18:21:35 +09:00
Dean Herbert	61313b69ec	Standardise font sizes in first run overlay screens	2022-05-10 18:21:35 +09:00
Dean Herbert	e5204e565d	Move horizontal padding to content level to better align scrollbar	2022-05-10 18:21:35 +09:00
Dean Herbert	bcce9c5e67	Limit the width of first run overlay content	2022-05-10 18:21:35 +09:00
Dean Herbert	9aadc274bf	Show first run dialog on first run of the game	2022-05-10 18:21:35 +09:00
Dan Balasescu	8ccf2ee075	Add inline comment	2022-05-10 15:07:08 +09:00
Dan Balasescu	2b7eeadac0	Workaround bad performance when selecting all freemods	2022-05-10 14:48:41 +09:00
Dan Balasescu	886a4815fa	Merge pull request #18180 from frenzibyte/fix-toolbox-double-tap ... Fix `SettingsToolboxGroup` not clearing transforms before updating autosize	2022-05-10 13:48:02 +09:00
Jai Sharma	2481201a73	Fix selector dismissal behaviour during user actions	2022-05-09 22:58:46 +01:00
Salman Ahmed	96ea4ee7b3	Add explanatory comment	2022-05-09 23:49:05 +03:00
Bartłomiej Dach	626fcd5d35	Merge branch 'master' into column-flow-cq	2022-05-09 19:22:29 +02:00
Jai Sharma	d4cc2bd7dd	Ensure channel selector is dismissed when the current channel is changed	2022-05-09 12:11:25 +01:00
Salman Ahmed	702c6ae658	Fix SettingsToolboxGroup not clearing transforms before updating autosize	2022-05-09 13:49:31 +03:00
Dean Herbert	1c63c27fdf	Merge branch 'master' into new-chat-drawable-channel	2022-05-09 18:23:00 +09:00
Dan Balasescu	e9cc3ab54a	Merge pull request #18164 from Joehuu/fix-exit-dialog-bad-state ... Fix popup dialog potentially not clicking last button when dismissed	2022-05-09 17:22:03 +09:00
Jai Sharma	623e2c94ae	Adjust padding	2022-05-09 00:32:22 +01:00
Jai Sharma	aeb2984989	Move ChatOverlayDrawableChannel to it's own file	2022-05-09 00:31:22 +01:00
Jai Sharma	5f80e344c3	Update day separator date text to right align against username	2022-05-09 00:15:08 +01:00
Joseph Madamba	21e1f4546a	Fix popup dialog potentially not clicking last button when dismissed	2022-05-08 14:40:30 -07:00
Joseph Madamba	172d14bcc6	Improve code quality of mod column flow container	2022-05-08 11:40:14 -07:00
Bartłomiej Dach	d964b4f23c	Fix uneven spacing when some mod columns are hidden	2022-05-08 15:40:21 +02:00
Bartłomiej Dach	6bdcf893b7	Move alpha management closer to screen level ... Felt bad messing with alpha at the column level.	2022-05-08 15:40:10 +02:00
Bartłomiej Dach	92ccec20d7	Hide mod columns if all mods within are filtered out	2022-05-08 14:53:59 +02:00
Dean Herbert	b8cb2c1b82	Increase scroll amount slightly	2022-05-08 19:57:03 +09:00
Dean Herbert	778497b9e2	Scroll mod select slightly into view on first display	2022-05-08 18:58:54 +09:00
Bartłomiej Dach	b92d95a17a	Fix mod panels playing samples when hidden at a higher level	2022-05-08 10:39:49 +02:00
Bartłomiej Dach	81ca534f87	Implement ISamplePlaybackDisabler in mod select	2022-05-08 10:39:49 +02:00
Dean Herbert	230c4e27b8	Simplify and centralise hiding logic for mod overlay ... Behaviourally, this also always toggles via button triggering to add the button flash animation.	2022-05-08 13:03:28 +09:00
Jai Sharma	8da7bbd322	Code quality	2022-05-07 23:30:46 +01:00
Jai Sharma	c0643cae75	Create ChatOverlayDaySeparator and use in ChatOverlayDrawableChannel	2022-05-07 23:24:34 +01:00
Jai Sharma	f4acfbd0df	Change return type of CreateDaySeparator to Drawable	2022-05-07 22:23:46 +01:00
Jai Sharma	bec28c5b28	Remove virtual ColourInfo properties from DaySeparator	2022-05-07 22:16:11 +01:00
Bartłomiej Dach	46d3220c07	Isolate sample screens from global mods bindable ... Fixes scenario wherein entering the first run setup overlay, exiting at the "UI scale" step (which shows a song select), then moving to actua song select and trying to select a mod would lead to a crash. The crash was caused by two active mod screen instances attempting to swap the global mod bindable's mod instances for ones they owned. This logic - while generally problematic and hard to maintain - was fixing several issues with mod reference management and setting copying, so I'm letting it live another day. This change will mean that the song select preview on the "UI scale" step will not receive the same mods that the actual game has enabled. That said, it already doesn't use the same beatmap or ruleset, so this looks fine to break.	2022-05-07 21:44:58 +02:00
Dean Herbert	2278da563e	Add various xmldoc for nested classes	2022-05-08 02:03:28 +09:00
Dean Herbert	03c80d9197	Reorder methods / properties in ModSelectScreen for legibility	2022-05-08 01:58:37 +09:00
Dean Herbert	1d27ef18dc	Add xmldoc for IsValidMod	2022-05-08 01:49:29 +09:00
Dean Herbert	0d32bf91eb	Hardcode hide key handling in ModSelectScreen	2022-05-08 01:35:11 +09:00
Bartłomiej Dach	0c2b4a6c0b	Fix invalid IsLoaded check ... Would fail when `availableMods` would be changed from a different thread while the columns aren't loaded.	2022-05-07 15:44:22 +02:00
Bartłomiej Dach	528342411e	Merge branch 'master' into mod-overlay/integration	2022-05-07 13:52:19 +02:00
Bartłomiej Dach	fe69bd7ed9	Merge branch 'master' into change-mod-scroll-behaviour	2022-05-07 13:29:02 +02:00
Bartłomiej Dach	9a56f6db44	Merge branch 'mod-overlay/back-button' into mod-overlay/integration	2022-05-07 13:15:13 +02:00
Bartłomiej Dach	a716f62a6a	Flash back button when keyboard back binding is pressed	2022-05-07 13:01:36 +02:00
Salman Ahmed	d4c9de8596	Move button width in mod select to constant	2022-05-07 13:23:48 +03:00
Salman Ahmed	8ee3fdd0aa	Change mod scrolling behaviour to not scroll horizontally on columns/settings	2022-05-07 12:15:11 +03:00
Bartłomiej Dach	fd75963ca2	Dismiss mod select if select binding is pressed	2022-05-07 11:01:05 +02:00
Bartłomiej Dach	e7e7486a8e	Merge branch 'mod-overlay/back-button' into mod-overlay/integration	2022-05-07 10:59:30 +02:00
Bartłomiej Dach	b72cf4cd5d	Merge branch 'mod-overlay/localisation-strings' into mod-overlay/back-button	2022-05-07 10:58:09 +02:00
Bartłomiej Dach	f761d4d4d4	Reuse "select/deselect all" localisable string on column toggle	2022-05-07 10:56:03 +02:00
Bartłomiej Dach	fa0a256f48	Add localisable string for difficulty multiplier display	2022-05-07 10:48:15 +02:00
Bartłomiej Dach	271d64fd54	Add back button to mod select overlays	2022-05-07 10:17:32 +02:00
Bartłomiej Dach	6ad990dfc3	Add basic localisation strings for new mod select	2022-05-07 10:17:24 +02:00
Bartłomiej Dach	4ff96f82be	Dim other buttons if customisation panel is open	2022-05-07 09:50:09 +02:00
Bartłomiej Dach	18e4c3ed0f	Update mod columns even if they're not present/offscreen ... Important to make "select/deselect all" operations work on all columns simultaneously, even if they're offscreen. Unfortunately by the nature of how the existing selection animation works, it is hard-tied to the update loop, so we need to compensate.	2022-05-07 09:50:09 +02:00
Bartłomiej Dach	9514a5cef7	Only load panels asynchronously outside of BDL	2022-05-07 09:50:09 +02:00
Bartłomiej Dach	9f96dd47d1	Remove schedule in panel load ... It was causing selection/deselection of all mods to work improperly if a select/deselect all operation was requested before the panel was scrolled into view. In general the schedule was an over-optimisation - the game-global set of available mods shouldn't be changing so often as to warrant such an aggressive debounce.	2022-05-07 09:50:09 +02:00
Bartłomiej Dach	852e4a9766	Add select/deselect all buttons to free mod select screen	2022-05-07 09:29:33 +02:00
Bartłomiej Dach	0b95594f60	Add some more padding between footer and column scroll	2022-05-07 09:29:33 +02:00
Bartłomiej Dach	0c6de331f3	Move footer button padding to a higher level	2022-05-07 09:29:32 +02:00
Dean Herbert	dd63657dfb	Merge pull request #18065 from huoyaoyuan/code-style ... Enforce code style analysis shipped with .NET SDK	2022-05-07 14:58:19 +09:00
Jai Sharma	6fc808be22	Code quality	2022-05-06 23:17:59 +01:00
Jai Sharma	9d62206176	Update new chat overlay day separator colours and spacing ... Updates the `DaySeparator` component to have separately settable colours for the text and the lines. Updates existing overrides of the `DaySeparator` to use the new colour setter. Create new `ChatOverlayDrawableChannel` with adjusted spacing and new `DaySeparator` colours.	2022-05-06 23:06:18 +01:00
Bartłomiej Dach	8c73ed7207	Fix sequence equality check not using reference comparison	2022-05-06 21:47:04 +02:00
Bartłomiej Dach	621f746789	Do not modify selected mods through panel state change during external update	2022-05-06 21:47:04 +02:00
Bartłomiej Dach	c199b8fcb6	Simplify state management in ModColumn ... Bad sign when you can't follow your own code. All of the various state changing methods were flattened into one because it was too hard to follow what was calling what and why.	2022-05-06 21:46:16 +02:00
Salman Ahmed	1409f8ca96	Merge branch 'master' into fix-toolbox-expansion	2022-05-06 18:00:01 +03:00
Bartłomiej Dach	c533c93ffd	Remove leftover border thickness spec in mod settings area ... Was never supposed to be there, it was a vestige of a previous design iteration that went by unnoticed.	2022-05-06 15:34:49 +02:00
Bartłomiej Dach	e527574ede	Merge branch 'master' into fix-toolbox-expansion	2022-05-06 13:47:36 +02:00
Dean Herbert	98eab9668d	Merge pull request #18119 from bdach/mod-overlay/broken-hover ... Fix mod panels not hovering correctly after closing customisation area via mouse on new mod select	2022-05-06 20:42:33 +09:00
Bartłomiej Dach	e9d52aa954	Remove not-accessed field	2022-05-06 13:09:37 +02:00
Bartłomiej Dach	a915b7333c	Remove unused using directive	2022-05-06 13:08:54 +02:00
Dean Herbert	88c190f3e3	Change colour denoting expanded state to be gray rather than yellow ... I always found the yellow colour very non-descript in this case. Gray seems to work better?	2022-05-06 19:45:17 +09:00
Dean Herbert	b432885e5f	Tidy up ordering of SettingsToolboxGroup	2022-05-06 19:39:09 +09:00
Dean Herbert	59add66632	Remove unnecessary autosize workaround (was fixed long ago)	2022-05-06 19:39:00 +09:00
Dean Herbert	949e30c4b4	Remove auto-expansion of individual toolbox groups when parent expanding container expands	2022-05-06 19:36:41 +09:00
Bartłomiej Dach	08fd0ea086	Fix click-to-return container still handling hover when inactive	2022-05-06 12:28:53 +02:00
Dean Herbert	be960eb092	Move dangerous hold specification to base class	2022-05-06 14:34:31 +09:00
Dean Herbert	0d8e42b941	Merge branch 'master' into exit-multiplayer-is-dangerous	2022-05-06 14:25:18 +09:00
Jai Sharma	0974de8fb0	Use BindableFloat for chat height	2022-05-05 23:13:32 +01:00
Jai Sharma	16a6c11bc8	Clamp maximum and minimum height the chat overlay can be resized to	2022-05-05 21:40:37 +01:00
Bartłomiej Dach	34cf4c6a38	Fix mod overlay not closing on toggle hotkey	2022-05-05 22:16:56 +02:00
Bartłomiej Dach	a56eab2c47	Extract interface for overlay management	2022-05-05 22:16:55 +02:00
Bartłomiej Dach	ac08498f35	Use plum colour scheme in multiplayer to match rest of multiplayer screens	2022-05-05 22:16:54 +02:00
Bartłomiej Dach	79e1b93b30	Close customisation area on escape press before exiting	2022-05-05 19:17:36 +02:00
Bartłomiej Dach	2cc56a4b19	Fix hidden issue with automatic customisation panel show logic ... Doesn't cause tests to fail headless, but they do fail in the test browser.	2022-05-05 19:17:36 +02:00
Dean Herbert	9d48bb41c9	Merge branch 'master' into new-chat-overlay	2022-05-05 23:12:31 +09:00
Jai Sharma	5ea6f62951	Ensure RelativePositionAxes is set in BDL for animations to work	2022-05-05 14:20:33 +01:00
Dan Balasescu	e46f99bdba	Merge branch 'master' into dialog-overlay-thread-woes	2022-05-05 20:57:51 +09:00
Dean Herbert	97221d2ef1	Tidy up initialisation	2022-05-05 19:24:18 +09:00
Dean Herbert	e54f5e2d92	Adjust value change variables to avoid e usage	2022-05-05 19:22:20 +09:00
Dean Herbert	74505ba166	Remove ! usage (also seems to fix height saving/loading)	2022-05-05 19:22:12 +09:00
Dean Herbert	25ea660b0b	Replace HandlePositionalInput override with simple hover effect	2022-05-05 19:13:48 +09:00
Dean Herbert	4efaa41670	Merge branch 'master' into new-chat-overlay	2022-05-05 18:57:00 +09:00
Dean Herbert	f6a6a11391	Remove DialogOverlay local fades (is already managed by PopupDialogs themselves)	2022-05-05 15:02:23 +09:00
Dean Herbert	326ff3b6e9	Fix CurrentDialog being updated twice, unsafe variable access	2022-05-05 14:55:05 +09:00
Dean Herbert	a27fcda9f1	Fix failing tests due to CurrentDialog being unexpectedly not set after Push	2022-05-05 01:52:39 +09:00
Salman Ahmed	e294069e2f	Merge branch 'master' into beatmap-selection-keybinding	2022-05-04 16:48:49 +03:00
Salman Ahmed	9416346c94	Globalise beatmap selection key bindings as "group" selection	2022-05-04 16:46:32 +03:00
Jai Sharma	1a85e1267b	Ensure focus is directed to ChatTextBox from ChatOverlay and add tests	2022-05-04 14:43:40 +01:00
Dean Herbert	ddab3c6d80	Tidy up state variables	2022-05-04 21:00:11 +09:00
Dean Herbert	383245f43a	Fix dialoged pushed to DialogOverlay too early potentially doing cross-thread transforms ... As seen at https://github.com/ppy/osu/runs/6287700705?check_suite_focus=true.	2022-05-04 20:23:36 +09:00
Dean Herbert	3eead5a6a3	Rename FlushAnimation to FlushPendingSelections to better match purpose	2022-05-04 19:40:08 +09:00
Jai Sharma	60999e83e0	Ensure ChatTextBox takes/leaves focus on chat overlay pop in/out	2022-05-03 22:33:36 +01:00
Jai Sharma	c17edb2848	Add padding to text in ChatTextBar to separate it from the textbox	2022-05-03 22:32:51 +01:00
Jai Sharma	50aee8b665	Ensure ChannelListSelector text also turns white when selected	2022-05-03 22:32:01 +01:00
Bartłomiej Dach	f5fa41356e	Rewrite mod instance management again to pass tests	2022-05-03 22:31:34 +02:00
Bartłomiej Dach	970361676b	Fix setting items not creating if mods initially not empty	2022-05-03 21:45:40 +02:00
Bartłomiej Dach	e3641213e1	Always hide unimplemented mods on mod select screen	2022-05-03 21:45:40 +02:00
Bartłomiej Dach	f91ee4b042	Reset panel mod instance settings to defaults on deselect	2022-05-03 21:45:40 +02:00
Bartłomiej Dach	7c04bf5c53	Refactor mod reference management to meet test expectations	2022-05-03 21:45:40 +02:00
Bartłomiej Dach	fe59f4ae58	Fix multiselection operation not flushing on close	2022-05-03 21:45:39 +02:00
Bartłomiej Dach	746a4a7403	Fix mod column using wrong equality type	2022-05-03 21:45:39 +02:00
Dean Herbert	2896612c5c	Make exiting multiplayer a dangerous operation, requiring hold	2022-05-03 16:06:04 +09:00
Dean Herbert	04fb0f5e63	Merge pull request #18063 from GSculerlor/split-searchbox ... Split `SearchTextBox` implementation for reusability	2022-05-03 14:12:44 +09:00
Huo Yaoyuan	7cf4dabe29	Fix IDE0005 and IDE0034	2022-05-03 13:09:19 +08:00
Dean Herbert	faeefc5e18	Merge pull request #16576 from frenzibyte/osu-distance-spacing ... Add "distance spacing" support in editor for osu! ruleset	2022-05-03 12:15:18 +09:00
Ganendra Afrasya	81be69e72e	Update search textbox implementation to use BasicSearchTextBox instead	2022-05-03 06:18:42 +07:00
Jai Sharma	a931b1ecc3	Show selected channel text as white in ChannelListItem	2022-05-02 22:32:25 +01:00
Jai Sharma	7f8e00c1e3	Change "Add more channels" to sentence case in "ChannelList"	2022-05-02 21:22:47 +01:00
Jai Sharma	1473762e25	Don't wrap "chatting in.." text in ChatTextBar	2022-05-02 20:57:39 +01:00
Jai Sharma	e6f1ac6bec	Ensure "chatting in..." text is aligned with chat message	2022-05-02 20:45:38 +01:00
Bartłomiej Dach	2b4a49e17f	Merge branch 'master' into move-difficulty-graph-toggle	2022-05-02 16:38:25 +02:00
Dean Herbert	c3e0ba5c8d	Fix clicking anywhere in the beatmap overlay dismissing it	2022-05-02 20:27:00 +09:00
Salman Ahmed	337ee8f4c7	Merge branch 'master' into fix-first-run-ui-scale-applying-rate-adjust	2022-05-02 12:14:24 +03:00
Dean Herbert	53d65e8215	Merge pull request #18021 from frenzibyte/overlay-ruleset-selector-redesign ... Update overlay ruleset selector inline with osu-web design	2022-05-02 17:53:01 +09:00
Dean Herbert	4b30d0e59b	Fix first-run overlay's song select applying track adjustments ... Closes https://github.com/ppy/osu/issues/18041.	2022-05-02 17:42:57 +09:00
Jai Sharma	4bd1d09148	Remove blank line	2022-05-01 12:20:11 +01:00
Jai Sharma	de393f735f	Implement basic layout and behaviour of new chat overlay ... Provides initial implementation of new chat overlay in component `ChatOverlayV2`. Contains only the basic functionality required for a functioning chat overlay according to the new design with the intent of added the rest of the functionality in subsequent PRs. Backports existing tests for the current chat overlay except for ones testing keyboard shortcuts (since they haven't been added) and tab closing behaviour (since no tabs).	2022-04-30 23:59:47 +01:00
Salman Ahmed	ba5da8a52a	Fix tooltips not shown on selected tab	2022-04-30 15:37:44 +03:00
Salman Ahmed	c7ab9a8928	Add ruleset tab item tooltips	2022-04-30 15:37:44 +03:00
Salman Ahmed	3996972867	Remove unnecessary f suffix	2022-04-30 12:23:08 +03:00
Dean Herbert	27ee990359	Update first-run overlay footer buttons to use new sheared design	2022-04-29 23:45:17 +09:00
Salman Ahmed	9ea3e244e7	Adjust ruleset tab item content spacing to match web ... Not too noticeable, but better match web in any case.	2022-04-29 12:48:09 +03:00
Salman Ahmed	4016fe1e19	Adjust profile ruleset selector to new design ... Looks weird with `AlwaysPresent`.	2022-04-29 12:19:55 +03:00
Salman Ahmed	3829d27845	Update overlay ruleset selector design	2022-04-29 12:19:22 +03:00
Salman Ahmed	fef94d49f4	Revert "Convert data type of DistanceSpacing to float" ... This reverts commit 7aaa88cac2.	2022-04-29 08:02:07 +03:00
Salman Ahmed	ef56dc07b5	Hide "modding" tab in user profile until it's implemented	2022-04-29 07:47:10 +03:00
Dean Herbert	c4495dafb6	Merge branch 'master' into move-difficulty-graph-toggle	2022-04-29 13:44:47 +09:00
Dan Balasescu	fc21de8138	Merge pull request #18008 from peppy/add-tutorial ... Add first run "beatmaps" screen	2022-04-29 13:10:45 +09:00
Dean Herbert	652e022fd6	Merge pull request #17973 from bdach/mod-overlay/dim-columns-offscreen ... Dim offscreen columns on new mod select overlay	2022-04-29 11:55:27 +09:00
Dean Herbert	845e7dba95	Reduce padding slightly to restore usability of UI scale screen	2022-04-29 11:27:14 +09:00
Dean Herbert	a75051cd00	Merge branch 'master' into add-tutorial	2022-04-29 11:25:17 +09:00
Bartłomiej Dach	96f6c918a8	Merge branch 'master' into first-run-behaviour-screen	2022-04-29 00:55:30 +02:00
Bartłomiej Dach	a748ad6426	Merge branch 'master' into first-run-header	2022-04-28 22:19:35 +02:00
Dean Herbert	a50dd2ae93	Fix rider failures in nullable	2022-04-28 20:15:40 +09:00
Dean Herbert	f300b62877	Add ScrollIntoView method which accepts an offset to allow usage in mod select	2022-04-28 20:03:54 +09:00
Dean Herbert	34457078eb	Merge pull request #18005 from nekodex/fix-missing-sfx ... Fix some missing/incorrect UI SFX	2022-04-28 19:45:59 +09:00
Dean Herbert	694f33b827	Add localisation of beatmaps screen	2022-04-28 19:33:16 +09:00
Dean Herbert	b6896376e7	Better signal when no beatmaps are loaded	2022-04-28 19:08:16 +09:00
Dean Herbert	88bfd5dece	Show current beatmap count on beatmap screen	2022-04-28 19:01:21 +09:00
Dean Herbert	4e0d70cbf4	Internalise bindable and progress handling to ensure transforms don't go backwards	2022-04-28 19:01:21 +09:00
Dean Herbert	9f6597695c	Only mark stable import complete if it actually completes	2022-04-28 19:01:21 +09:00
Dean Herbert	c860eb46b0	Split out button implementation into its own class	2022-04-28 19:01:21 +09:00
Dean Herbert	081275e0b9	Adjust text and layout	2022-04-28 19:01:21 +09:00
Dean Herbert	3c0bdcaf38	Rename screen, add tests and add stable import step	2022-04-28 19:01:21 +09:00
Dean Herbert	58399a5113	Add tutorial download support and improve the visuals "slightly"	2022-04-28 19:01:21 +09:00
Dean Herbert	973dd4bfa9	Add initial flow for download button / progress display	2022-04-28 19:01:21 +09:00
Dean Herbert	b042f1cad5	Add screen to perform bundled beatmap downloads	2022-04-28 19:01:21 +09:00
Dean Herbert	94a393c9d7	Merge branch 'master' into first-run-header	2022-04-28 19:00:12 +09:00
Salman Ahmed	691bec6f16	Use LocalisableString.Interpolate instead of invalid TranslatableStrings	2022-04-28 11:38:40 +03:00
Jamie Taylor	92cac0b74e	Fix TabControls using the wrong sample	2022-04-28 17:30:24 +09:00
Salman Ahmed	be2d616e34	Fix localisation use cases not falling back to default(LocalisableString) ... Previously such use cases have been returning `null` values just fine since `GetLocalisableString` was returning `LocalisableFormattableString`, and these null values were wrapped in `LocalisableString`s implicitly, therefore not requiring an explicit fallback string and `null` doesn't break anything.	2022-04-28 11:21:00 +03:00
Salman Ahmed	7aaa88cac2	Convert data type of DistanceSpacing to float	2022-04-28 10:24:36 +03:00
Dean Herbert	f3a0e2ed55	Increase fade duration	2022-04-28 14:59:39 +09:00
Dean Herbert	d0ccd6f895	Merge branch 'master' into first-run-header	2022-04-27 19:26:02 +09:00
Dean Herbert	e6bb5e84ec	Merge branch 'master' into move-difficulty-graph-toggle	2022-04-27 17:22:25 +09:00
Dean Herbert	1a345c06c6	Fix regression in nested scroll behaviour due to the top level scroll container's type changing	2022-04-27 17:10:27 +09:00
Dean Herbert	b29af28028	Fix mod panels not ignoring super key presses ... Most other usages have this included. Noticed that the panel was changing state when exiting the game using cmd-w. Would probably be nice to have an exposed `HasAnyModifierPressed` helper property.	2022-04-27 16:55:17 +09:00
Dean Herbert	18e6629161	Merge branch 'master' into first-run-behaviour-screen	2022-04-27 16:02:57 +09:00
Dean Herbert	0354dd5ce6	Add comment regarding section initialisation in ScreenBehaviour	2022-04-27 16:02:39 +09:00
Dean Herbert	0343687b85	Make apply default methods more explicit in behaviour	2022-04-27 15:59:39 +09:00
Bartłomiej Dach	a849bfcf60	Rewrite dim test to pass headless ... Unfortunately neuters the test a touch, but alas.	2022-04-26 23:11:41 +02:00
Bartłomiej Dach	921e8af3b0	Use more lenient column bounds for checking active state	2022-04-26 22:54:54 +02:00
Bartłomiej Dach	21377d2a4d	Fix inactive columns flickering on and off mid-scroll	2022-04-26 22:43:58 +02:00
Bartłomiej Dach	94d07e147f	Move dimming logic to custom scroll container	2022-04-26 22:37:40 +02:00
Bartłomiej Dach	e9c9c764ca	Fix column dim state changing when scrolling past extent	2022-04-26 22:26:58 +02:00
Bartłomiej Dach	13a36f2e51	Scroll to column when mouse is released rather than pressed	2022-04-26 22:01:24 +02:00
Bartłomiej Dach	b0d6e16658	Invert data flow in column dim implementation	2022-04-26 21:57:19 +02:00
Dean Herbert	280cd048f6	Fix joystick settings changing enabled state of config level bindables ... Just copied what we had in place for the mouse sensitivity setting. For tablet settings I believe I avoided this by just hiding the settings when not enabled. Might be a better way forward, but this is simplest for now. Run `TestSceneSettingsPanel` twice to get a crash without this change.	2022-04-26 17:31:28 +09:00
Dean Herbert	01fdb771ee	Add header text to first run setup screens	2022-04-26 16:22:41 +09:00
Dean Herbert	942f4e8ac2	Merge branch 'first-run-show-get-started' into first-run-behaviour-screen	2022-04-26 16:10:16 +09:00
Dean Herbert	a078440012	Show last step on back button as well	2022-04-26 16:03:17 +09:00
Dean Herbert	2c836e2d63	Fix scrollbar overlapping content	2022-04-26 15:55:32 +09:00
Dean Herbert	37ae39f5fe	Move "Next" localisation to common strings	2022-04-26 15:48:40 +09:00
Dean Herbert	71aa7c813e	Fix regressed logic for applying classic defaults	2022-04-26 15:33:39 +09:00
Dean Herbert	b41e273086	Convert function weirdness to property + bool	2022-04-26 15:06:27 +09:00
Bartłomiej Dach	e13d0d02ae	Use better way of calculating whether columns are fully on screen	2022-04-25 23:08:05 +02:00
Bartłomiej Dach	e384e074fb	Fix asymmetric margin of column scroll	2022-04-25 23:08:05 +02:00
Bartłomiej Dach	09c08248c4	Fix bounce when scrolling to first/last column	2022-04-25 23:08:05 +02:00
Bartłomiej Dach	ebc8429495	Dim offscreen columns & scroll to them if clicked	2022-04-25 23:08:04 +02:00
Dean Herbert	5e48b37569	Show "Get Started" text on first run button	2022-04-25 23:59:07 +09:00
Dean Herbert	07462384e8	Merge pull request #17930 from peppy/fix-song-select-music-control ... Fix nested song select in first-run dialog fiddling with global audio	2022-04-24 19:18:27 +09:00
Dean Herbert	d92c905600	Actually use exposed property	2022-04-24 18:15:35 +09:00
Dean Herbert	83970f009c	Merge branch 'master' into settings-filter-regression-fix-2	2022-04-24 17:40:25 +09:00
Dean Herbert	176d263252	Merge pull request #17942 from maromalo/master ... Add joystick/gamepad deadzone setting	2022-04-24 17:39:48 +09:00
Dean Herbert	c5e8f1d4ab	Merge pull request #17958 from peppy/fix-hide-case ... Remove localisation of "hide" string to fix incorrect case	2022-04-24 17:38:49 +09:00
Dean Herbert	66b47d22d7	Also fix case of login form username/password	2022-04-24 17:11:25 +09:00
Dean Herbert	1b2467d3ed	Disable first run screen from appearing on startup until it is more complete	2022-04-24 16:35:41 +09:00
Dean Herbert	2200067c52	Display deadzone as percentage and simplify surrounding code	2022-04-24 16:31:20 +09:00
Salman Ahmed	8ed39009fd	Encapsulate distance spacing control handling to a "distance toolbox composite" ... Encapsulated in a way which can allow further extensibility for the right-side area of toolboxes.	2022-04-24 08:33:03 +03:00
Salman Ahmed	4f8f27a58b	Merge branch 'master' into osu-distance-spacing	2022-04-24 05:23:30 +03:00
maromalo	5addcbf460	Changed KeyboardStep to 0.01	2022-04-23 13:16:20 -03:00
Dean Herbert	5d0842ac44	Add a few more classic defaults to missed settings	2022-04-23 21:53:47 +09:00
maromalo	6a87dfdabb	More Code Quality ... Double whoops.	2022-04-23 02:14:41 -03:00
maromalo	23ef1e194d	Code Quality ... Whoops.	2022-04-23 01:52:59 -03:00
maromalo	85c47e1ba7	Merge branch 'ppy:master' into master	2022-04-23 00:17:40 -03:00
maromalo	27f3499330	Add joystick/gamepad deadzone setting ... Also splits joystick/gamepad into a new sub-section.	2022-04-23 00:17:00 -03:00
Bartłomiej Dach	98b7b156c7	Merge branch 'master' into first-run-setup-sheared-overlay	2022-04-23 00:32:07 +02:00
Salman Ahmed	7be2596312	Fix MatchingFilter being false by default	2022-04-22 23:50:58 +03:00
Bartłomiej Dach	e246357b36	Merge branch 'master' into sheared-overlay-container-click-away	2022-04-22 22:26:35 +02:00
Salman Ahmed	5120faa830	Merge branch 'master' into mod-overlay/incompatibility-panels-clickable	2022-04-22 22:19:42 +03:00
Salman Ahmed	4c7c611218	Fix settings overlay not invalidating presence on filter change	2022-04-22 20:34:00 +03:00
Dean Herbert	1caee38768	Add first-run "behaviour" screen to allow users a choice of more familiar UX	2022-04-22 18:06:56 +09:00
Dean Herbert	e0b9ab022d	Add classic default values against setting controls	2022-04-22 18:05:24 +09:00
Dean Herbert	2a043aa6de	Add a method of finding and applying settings with classic default value	2022-04-22 18:04:43 +09:00
Dean Herbert	7258a09748	Allow SettingsSections to exit without a parent SettingsPanel	2022-04-22 18:04:07 +09:00
Dan Balasescu	b1cf917b49	Merge pull request #17823 from peppy/settings-filter-fixes ... Fix incorrect settings state if searching too quickly (during load process)	2022-04-22 16:38:41 +09:00
Dean Herbert	f735d381a7	Merge branch 'master' into mod-overlay/incompatibility-panels-clickable	2022-04-22 16:26:46 +09:00
Salman Ahmed	33d516eecb	Move guest participation beatmap up to below loved	2022-04-22 09:28:29 +03:00
Dean Herbert	82a1d1cc2e	Fix multiplier display not blocking input	2022-04-22 15:22:58 +09:00
Salman Ahmed	40d823bf69	Use localised string for guest participation beatmaps header	2022-04-22 09:18:46 +03:00
Salman Ahmed	2c21bd89e7	Display beatmap guest participations in user profile	2022-04-22 07:56:01 +03:00
Salman Ahmed	a9ea0ab91b	Add support for fetching user guest participations	2022-04-22 07:55:39 +03:00
Bartłomiej Dach	b7c11cdb8e	Deselect old incompatible mods if any on user mod select screen	2022-04-21 23:49:30 +02:00
Bartłomiej Dach	32722adba9	Allow mod panels to be clicked in incompatible state	2022-04-21 23:37:01 +02:00
Bartłomiej Dach	8fe4443029	Update screen method signatures to match framework API changes	2022-04-21 22:29:23 +02:00
Bartłomiej Dach	8c6864727e	Merge branch 'master' into first-run-setup	2022-04-21 22:14:57 +02:00
Dean Herbert	749b86f0f4	Use new framework exposed event instead of schedule	2022-04-22 00:55:17 +09:00
Dean Herbert	119a81849c	Merge branch 'update-framework' into settings-filter-fixes	2022-04-22 00:55:15 +09:00
Dean Herbert	832d37b2c2	Update screen transition events to use new event args	2022-04-22 00:52:44 +09:00
Dean Herbert	ed6481f708	Also rename Welcome to WelcomeTitle to match other usages	2022-04-21 19:55:51 +09:00
Dean Herbert	1f967ecba3	Update string keys and change "setup" to "set up" to fix grammar	2022-04-21 19:52:28 +09:00
Dean Herbert	d17c16d904	Merge branch 'master' into first-run-setup	2022-04-21 19:50:26 +09:00
Dean Herbert	55270df6fc	Merge pull request #17833 from jai-x/new-chat-channel-list ... Implement `ChannelList` for new chat design	2022-04-21 16:34:35 +09:00
Dean Herbert	0b81ae9de2	Convert to using sheared overlay container ... Add better click-to-dismiss logic for sheader overlays	2022-04-21 16:28:44 +09:00
Dean Herbert	5c21a55e00	Merge branch 'sheared-overlay-container-click-away' into first-run-setup-sheared-overlay	2022-04-21 16:28:33 +09:00
Dean Herbert	0f4b40ab15	Add better click-to-dismiss logic for sheared overlays	2022-04-21 16:27:27 +09:00
Dean Herbert	7d8cf1bbb6	Merge branch 'master' into first-run-setup	2022-04-21 15:49:39 +09:00
Dan Balasescu	54ca4b9d36	Remove unused using	2022-04-21 15:34:14 +09:00
Dean Herbert	5c0e5eb6f4	Merge pull request #17899 from Joehuu/localise-most-strings ... Use existing web localisation for most hardcoded strings	2022-04-21 14:48:12 +09:00
Dean Herbert	9f525ee267	Revert localisation of spectate/watch button	2022-04-21 14:09:51 +09:00
Dean Herbert	56d8de23e2	Replace horse with "more suitable" icon ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2022-04-21 12:18:54 +09:00
Joseph Madamba	5e5c8e78a6	Use existing web localisation for most hardcoded strings	2022-04-20 16:31:11 -07:00
Jai Sharma	5319bce772	Revert DI usage of ChannelSelectorState in favour of directly binding BindableBool SelectorActive	2022-04-20 21:05:33 +01:00
Jai Sharma	e596c9d171	Use Bindable<ChannelSelectorState> to control selector active visibility	2022-04-20 19:12:43 +01:00
Dean Herbert	4466e15bfc	Rename AllowConfiguration to AllowCustomisation and simplify drawable addition	2022-04-20 23:17:29 +09:00
Dean Herbert	b722ff8dc5	Merge branch 'master' into mod-overlay/extension-points	2022-04-20 23:17:04 +09:00
Dean Herbert	8c2d70e93f	Disable forward button when already at end	2022-04-20 17:50:31 +09:00
Dean Herbert	65b2db5e71	Move shear constant to overlay (this is going to likely be used everywhere ever)	2022-04-20 16:30:58 +09:00
Dean Herbert	e17f224793	Fix padding mismatches	2022-04-20 16:28:52 +09:00
Dean Herbert	5c7ff363ce	Move title/description to correct class	2022-04-20 16:08:00 +09:00
Dean Herbert	2ee37aeceb	Reduce nesting and usage of GridContainer	2022-04-20 16:01:15 +09:00
Dean Herbert	1032dc235d	Rename PopupScreenTitle to ShearedOverlayHeader	2022-04-20 16:01:15 +09:00
Dean Herbert	8d31b0bc01	Split out the base design of sheared overlay into its own abstract class ... This will allow for reuse with the first-run overlay.	2022-04-20 15:50:16 +09:00
Dean Herbert	66373bf038	Move back button enable handling to shared method	2022-04-20 14:50:41 +09:00
Dean Herbert	9797e2d887	Rename showLastStep method to avoid ambiguity	2022-04-20 14:49:17 +09:00
Dean Herbert	488fc9db67	Reverse content colours to match design spec	2022-04-20 14:48:51 +09:00
Bartłomiej Dach	f82d58fa6a	Merge branch 'master' into update-paginated-profile-items-count	2022-04-19 22:17:26 +02:00
Jai Sharma	44c822f34d	Use normal OsuScrollContainer for ChannelList	2022-04-19 16:56:55 +01:00
Dean Herbert	ce70c10afa	Tidy up unused dependencies	2022-04-19 18:00:39 +09:00
Dean Herbert	17eaa44af1	Ensure notifications don't interrupt the first run setup process	2022-04-19 17:40:35 +09:00
Dean Herbert	e2da1d76ca	Only show first run setup once per install	2022-04-19 16:59:25 +09:00
Dean Herbert	3378c91901	Fix double applied padding	2022-04-19 16:59:04 +09:00
Dean Herbert	1490502d4c	Improve overall usability of scale adjust screen	2022-04-19 16:59:04 +09:00
Dean Herbert	c27831145c	Add scroll and flow at the FirstRunSetupScreen level	2022-04-19 16:37:29 +09:00
Dean Herbert	6d534046ff	Add keyboard traversal support for first run dialog (and tidy up step traversal logic)	2022-04-19 14:57:15 +09:00
Dean Herbert	e67cc293b8	Add localisation support for all new strings	2022-04-19 14:53:01 +09:00
Dean Herbert	5dc3805005	Fix stack nullability	2022-04-19 14:53:01 +09:00
Dean Herbert	02f8367d66	Improve animation when showing/hiding first run overlay	2022-04-19 14:53:01 +09:00
Dean Herbert	2682373bf2	Use existing blocking / exit logic provided by OsuFocusedOverlayContainer	2022-04-19 14:53:01 +09:00
Dean Herbert	9074eb283d	Show a notification instead of blocking exit of wizard	2022-04-19 14:53:01 +09:00
Dean Herbert	3ea4eabdb6	Ensure button text is updated on going backwards	2022-04-19 14:53:01 +09:00
Dean Herbert	fb7dc89503	Ensure wizard returns to initial screen after completion	2022-04-19 14:53:01 +09:00
Dean Herbert	6716621444	Re-fix clicking inside display also dismissing	2022-04-19 14:53:01 +09:00
Dean Herbert	11395c40b7	Add button to access first run setup on demand	2022-04-19 14:53:01 +09:00
Dean Herbert	ea52fab5b1	Tidy up dependencies and test naming	2022-04-19 14:53:01 +09:00
Dean Herbert	56c4283764	Only exit dialog from click if outside the dialog content	2022-04-19 14:53:01 +09:00
Dean Herbert	288f759bb4	Add test coverage of navigation	2022-04-19 14:53:01 +09:00
Dean Herbert	07da1cd731	Move buttons to top level and add backwards navigation	2022-04-19 14:53:01 +09:00
Dean Herbert	3b94e01fe6	Improve layout of ui scale step	2022-04-19 14:53:01 +09:00
Dean Herbert	e064f2f23e	Improve general layout and allow overlay to be displayed without dependencies for now	2022-04-19 14:53:01 +09:00
Dean Herbert	c2df3465b2	Add ui scaling setup screen, kind of	2022-04-19 14:53:01 +09:00
Dean Herbert	ae07b2b512	Initial setup	2022-04-19 14:53:01 +09:00
Dean Herbert	83e89b3e80	Add unread count to INotificationOverlay and fix toolbar button DI logic	2022-04-19 11:16:45 +09:00
Salman Ahmed	c858ec2483	Pagination -> `PaginationParameters	2022-04-19 02:48:34 +03:00
Salman Ahmed	96d4369cc8	Introduce Pagination and simplify paginated API requests	2022-04-19 02:04:23 +03:00
Dan Balasescu	bb8b94f8ad	Merge branch 'master' into i-notification-overlay	2022-04-19 06:03:56 +09:00
Dan Balasescu	94e892df1c	Merge pull request #17862 from peppy/i-dialog-overlay ... Split out `IDialogOverlay` to allow for easier testing	2022-04-19 05:24:05 +09:00
Salman Ahmed	f08449e432	Update paginated profile subsections to display items inline with web	2022-04-18 23:04:21 +03:00
Salman Ahmed	1fc28552b5	Minor reword inline comment	2022-04-18 21:07:20 +03:00
Salman Ahmed	16a0efc562	Cache IDialogOverlay as its type in interface	2022-04-18 21:06:27 +03:00
Dean Herbert	5d5e46ede7	Fix rider incompetency	2022-04-18 23:10:07 +09:00
Dean Herbert	aaf5577e6a	Remove unnecessary canBeNull specification	2022-04-18 21:48:46 +09:00
Dean Herbert	d29312e070	Fix rider incompetency	2022-04-18 21:47:47 +09:00
Dean Herbert	043599081b	Split out INotificationOverlay to allow for easier testing	2022-04-18 20:14:01 +09:00
Dean Herbert	e315313266	Split out IDialogOverlay to allow for easier testing	2022-04-18 18:36:26 +09:00
Dean Herbert	2202863e1a	Split out IPerformFromScreenRunner to allow for easier testing	2022-04-18 17:49:28 +09:00
Bartłomiej Dach	0d5ce336f4	Hide mod customisation toggle if customisation not permitted	2022-04-17 23:28:53 +02:00
Bartłomiej Dach	881df7663d	Fix filter not taking effect if applied before panel load completion	2022-04-17 23:28:53 +02:00
Bartłomiej Dach	8af865a1c5	Fix incompatibility panel using reference equality	2022-04-17 23:28:53 +02:00
Bartłomiej Dach	ffb5c1e86c	Tweak colours on incompatibility displaying mod panel	2022-04-17 23:28:52 +02:00
Bartłomiej Dach	20c17b8c98	Make base mod select screen abstract	2022-04-17 23:28:51 +02:00
Bartłomiej Dach	7eebc20124	Add replacements for mod overlays used by game	2022-04-17 23:28:51 +02:00
Bartłomiej Dach	67c44db8d5	Add extension points required for replacing old mod overlay	2022-04-17 23:28:51 +02:00
Jai Sharma	47c8b8010f	Use semibold font weight for ChannelListItemFlow label	2022-04-16 23:03:03 +01:00
Jai Sharma	2f41cddb00	Remove redundant Expire call	2022-04-16 23:03:03 +01:00
Jai Sharma	36aea9009e	Move ChannelList scrollbar to the right	2022-04-16 23:03:03 +01:00