31115 Commits

Author	SHA1	Message	Date
Bartłomiej Dach	f5742d3d2a	Merge branch 'master' into editor-toolbox-expand	2022-01-06 19:01:02 +01:00
Dean Herbert	e02863f780	Avoid accessing DrawWidth from invalidation	2022-01-07 01:24:30 +09:00
Dean Herbert	f703c5f038	Add comment and reduce how often ChildrenOfType is invoked in ExpandingButtonContainer	2022-01-06 23:38:54 +09:00
Dean Herbert	5aca2dd4ce	Hide header text when it won't fit in the toolbox group	2022-01-06 23:08:50 +09:00
Dean Herbert	690b425380	Move enum local to usage	2022-01-06 22:56:56 +09:00
Dean Herbert	00177a3ae1	Update usages to new naming	2022-01-06 22:54:43 +09:00
Dean Herbert	3ea7588a91	Update continuation usages to use GetCompletedResult	2022-01-06 22:53:07 +09:00
파링	74b15ec30c	Merge branch 'master' into master	2022-01-06 21:12:45 +09:00
Dean Herbert	cea9cab4dc	Use ExpandingButtonContainer in editor composer	2022-01-06 21:10:45 +09:00
Dean Herbert	5baaf356aa	Split out SettingsToolboxGroup from PlayerSettingsGroup	2022-01-06 21:05:00 +09:00
Dean Herbert	77980196c5	Split out expanding container logic from settings sidebar	2022-01-06 21:02:29 +09:00
Bartłomiej Dach	84765b99b3	Handle score submission request in submission test scene ... Was previously not handled at all, therefore displaying request failures in the test log output. While that was mostly a red herring and shouldn't have caused any actual *test* failures, it is still better to handle this explicitly in a realistic manner.	2022-01-06 12:57:26 +01:00
Bartłomiej Dach	f0797d4066	Merge branch 'master' into editor-flip-over-origin	2022-01-06 09:59:18 +01:00
Dan Balasescu	1d69eb629c	Merge pull request #16327 from peppy/fix-editor-playfield-centering ... Fix editor playfield not being centered correctly	2022-01-06 16:11:12 +09:00
Dean Herbert	243a1a3cf7	Fix incorrect origin specification for SkinSelectionHandler flips	2022-01-06 14:47:44 +09:00
Bartłomiej Dach	7d195c4344	Merge branch 'master' into page-selector	2022-01-05 22:23:10 +01:00
Dean Herbert	88602ec1b4	Fix mouse button disable not disabling touch input mappings	2022-01-05 18:29:32 +09:00
Dean Herbert	df6a755c36	Update player loader screen mouse disable text to use localised version	2022-01-05 18:29:09 +09:00
Dean Herbert	6779503e57	Refactor logic to avoid TimelineSelectionHandler having to block base calls	2022-01-05 16:56:54 +09:00
Dean Herbert	866ae3472b	Add global flip hotkeys	2022-01-05 16:48:07 +09:00
Dean Herbert	13cce50fa7	Remove existing handling of flip hotkeys	2022-01-05 16:30:42 +09:00
Dean Herbert	ef2a4aed9a	Fix editor playfield not being centered correctly ... This has come up multiple times, with mappers citing that they have muscle memory for mapping based on the centre of the playfield being in the centre of the window. The original plan was to have a second toolbar on the right hand side of the screen to balance the padding, but we're not at that point yet. Easiest solution is to do what stable does and allow the left-hand toolbar items to overlap the playfield underneath it. In edge cases where the user is running at an aspect ratio that causes overlaps, they can choose to collapse the toolbars down. We can probably work on this UI/UX a bit more as we update designs to be more friendly to such cases.	2022-01-05 16:05:18 +09:00
Dean Herbert	2bf6b55b19	Fix failing test due to changed reset page logic	2022-01-05 14:53:32 +09:00
Dean Herbert	5ed69338a6	Add omission of pages when there are too many	2022-01-04 19:05:14 +09:00
Dean Herbert	86f72b71b1	Prepare tests and general structure to support omission of pages	2022-01-04 18:46:44 +09:00
Dean Herbert	e75c9519f3	Adjust font weighting on selection	2022-01-04 18:19:23 +09:00
Dean Herbert	5a11ee7810	Use OverlayColourProvider and fix font weight	2022-01-04 18:14:42 +09:00
Dean Herbert	ee4f5c0e79	Rename button classes to make more sense	2022-01-04 17:52:40 +09:00
Dean Herbert	db58f5de8e	Clean up unnecessary complexity	2022-01-04 17:51:37 +09:00
Dean Herbert	5736b7d978	Fix cursors sent to osu-web being potentially string formatted in incorrect culture ... Fixed as per solution at https://github.com/JamesNK/Newtonsoft.Json/issues/874. Note that due to the use of `JsonExtensionDataAttribute` it's not feasible to change the actual specification to `JValue` in the `Dictionary`. In discussion with the osu-web team, it may be worthwhile to change the cursor to a string format where parsing is not required at our end. We could already do this in fact, but there are tests that rely on it being a `JToken` so the switch to `JValue` seems like the easier path right now.	2022-01-04 17:20:46 +09:00
Dean Herbert	1c899e4402	Fix post-merge issues	2022-01-04 16:46:42 +09:00
Dean Herbert	69e7ee0f48	Merge branch 'master' into page-selector	2022-01-04 16:44:22 +09:00
Dean Herbert	39650ce7e9	Merge pull request #16307 from peppy/beatmap-listing-bottom-padding ... Add padding to the bottom of the beatmap listing overlay to avoid hovered panels exceeding visible bounds	2022-01-04 14:14:42 +09:00
Dean Herbert	374dac57f2	Change expanded card content height to 200	2022-01-04 13:22:00 +09:00
Dean Herbert	f9713b8895	Replace usage of TimeoutAttribute to fix beatmap conversion test failures	2022-01-04 11:51:41 +09:00
Dean Herbert	73b40e6833	Replace usage of .Result with .WaitSafelyForResult	2022-01-04 11:51:41 +09:00
Dean Herbert	031a40af6a	Replace usages of Wait with WaitSafely	2022-01-04 11:51:41 +09:00
Dean Herbert	f6b1405fa0	Merge branch 'master' into fix-listing-terminal-breakage	2022-01-04 11:49:02 +09:00
Bartłomiej Dach	87fbac15fd	Merge branch 'master' into fix-skin-editor-overlay-show-thread-safetyu	2022-01-03 20:12:18 +01:00
Bartłomiej Dach	de33b420ab	Add safety against performing operation on non-alive foundContent	2022-01-03 20:02:46 +01:00
Bartłomiej Dach	586f158920	Remove initial foundContent value ... It always is replaced on the first search anyway, and just remains forever in the overlay otherwise.	2022-01-03 19:52:42 +01:00
Bartłomiej Dach	6650a468e0	Fix and simplify very broken beatmap listing content swap-out logic ... The beatmap listing content swap-out logic was already a source of several problems, and several attempts of fixing it were made. But as it turns out it was terminally broken in several aspects. * The `BypassAutoSizeAxes` juggling was finicky and ugly, and didn't really look much different than an instant fade. Therefore, all fade durations and manipulations of `BypassAutoSizeAxes` are removed. * The transform sequence juggling the `BypassAutoSizeAxes` manipulations was enqueued on the content which is being in the process of fading out. That was partially fixed in 25e38560, but as it turns out, that only works if `lastContent` is one of the two placeholder drawables (results not found / supporter required to use filter). It would not work if `lastContent` is a `ReverseChildIDFillFlowContainer` with cards from a previous search in it.	2022-01-03 19:51:46 +01:00
Bartłomiej Dach	ef9f56e585	Fix bad check if content is placeholder ... The `lastContent == foundContent` check, last touched in a49a4329, is terminally broken, as it would always be false. `foundContent` is mutated when a new card load task is started in `onSearchFinished()`, which is *before* the aforementioned check. The code prior to a49a4329 was checking against the two static reused placeholder drawables which was the correct check to apply, and this commit reverts to using a variant of that check.	2022-01-03 19:51:20 +01:00
Bartłomiej Dach	97439c3df1	Rename method to reflect what it actually does	2022-01-03 19:30:17 +01:00
Bartłomiej Dach	7c246670b4	Add padding to bottom of spotlights ranking view to avoid hovered panels exceeding visible bounds	2022-01-03 18:43:20 +01:00
Bartłomiej Dach	0ad555e9f7	Remove surplus blank line	2022-01-03 18:33:32 +01:00
Dean Herbert	b9851b278d	Add padding to the bottom of the beatmap listing overlay to avoid hovered panels exceeding visible bounds ... Closes https://github.com/ppy/osu/issues/16120.	2022-01-03 13:18:28 +09:00
Dean Herbert	6356180b6a	Remove unnecessary code and fix double nesting causing filtering to not work	2022-01-03 12:53:58 +09:00
Dean Herbert	623d6d6d2d	Add migration of positional hitsounds setting to new level based setting	2022-01-03 12:46:20 +09:00
Dean Herbert	5dd024aab7	Remove outdated settings migration	2022-01-03 12:46:02 +09:00
Dean Herbert	bb54f438aa	Merge branch 'master' into positional-sounds-strength-adjustment	2022-01-03 12:40:56 +09:00
Bartłomiej Dach	e7d7587ea5	Merge branch 'master' into reduce-chat-overhead	2022-01-01 15:02:55 +01:00
Dean Herbert	675bdd3213	Fix MultiplayerMatchSubScreen mutating mods outside of bindable lease ... As seen at https://github.com/peppy/osu/runs/4674501626?check_suite_focus=true.	2022-01-01 12:13:59 +09:00
Dean Herbert	1262e76a58	Fix test failure due to missing DI cached IdleTracker	2021-12-31 23:18:03 +09:00
Dean Herbert	670a30b64b	Remove usage of .Result in ArchiveReader	2021-12-31 01:52:01 +09:00
Dean Herbert	089b756f93	Invert logic to make reading easier	2021-12-30 16:03:16 +09:00
Dean Herbert	ef49f2ed0e	Add extra extra safety against attempting to load a previously expired editor	2021-12-30 16:02:31 +09:00
Joseph Madamba	cdc148f78e	Increase scope of identifier typo disables on special cases	2021-12-29 14:07:36 -08:00
Dean Herbert	b1a444180f	Fix Show then Reset potentially resulting in incorrect load target	2021-12-29 21:46:34 +09:00
Dean Herbert	471eea750a	Fix calling SkinEditorOverlay.Show before the overlay is loaded causing an exception ... As seen at https://github.com/ppy/osu/runs/4652969942?check_suite_focus=true.	2021-12-29 21:18:17 +09:00
Joseph Madamba	c22a07d9fc	Bump identifier typo inspection and fix remaining identifier names	2021-12-28 11:26:42 -08:00
pikokr	dec1f31749	Make KeyBindingContainer public	2021-12-28 22:43:07 +09:00
Bartłomiej Dach	63e0492725	Mark ShouldSerialize() methods as implicitly used	2021-12-28 09:02:03 +01:00
Bartłomiej Dach	bc39c2a877	Revert incorrect property rename	2021-12-28 08:31:27 +01:00
Dean Herbert	73dca0c7e3	Merge pull request #16266 from Joehuu/fix-identifier-typos ... Fix and normalise most identifier names in code	2021-12-28 15:21:42 +09:00
Joseph Madamba	0bd928b5cd	Fix incorrect naming / apply review	2021-12-27 21:44:19 -08:00
Joseph Madamba	5082b0e63f	Fix some identifiers using shortened naming	2021-12-27 20:26:28 -08:00
Joseph Madamba	7de43e3aba	Fix most open compound words in identifiers being closed	2021-12-27 20:26:28 -08:00
Joseph Madamba	98524d60a4	Fix clear identifier typos	2021-12-27 20:26:28 -08:00
Bartłomiej Dach	568cab6808	Add clarification comment about explicit ProcessFrame() call	2021-12-27 21:13:04 +01:00
Dean Herbert	eb04cc9213	Update framework	2021-12-27 23:04:10 +09:00
Bartłomiej Dach	9f8ad9f833	Fix menu background storyboard stopping after track reload	2021-12-27 12:30:53 +01:00
Dean Herbert	8d927920cb	Add comment explainng why to block idle updates when host is not active	2021-12-27 13:31:07 +09:00
Bartłomiej Dach	5a591713ae	Fix legacy combo counter not fully hiding for rulesets that implement their own	2021-12-26 16:49:20 +01:00
Bartłomiej Dach	724b601d2a	Rename AllowSampleLookup argument to something saner	2021-12-26 14:29:07 +01:00
Bartłomiej Dach	dc21c8901e	Always allow looking up storyboard samples from beatmap skin	2021-12-26 14:25:28 +01:00
Dean Herbert	7c25ce81e1	Further reduce chat poll rate when idle or not visible	2021-12-26 16:26:47 +09:00
Dean Herbert	e448c28cad	Change IdleHandler to not consider mouse movement as active unless focused	2021-12-26 16:26:33 +09:00
Dean Herbert	8ad53138a6	Merge pull request #16234 from smoogipoo/fix-initial-button-colour ... Fix OsuAnimatedButton animating when initially disabled	2021-12-25 15:34:40 +09:00
Dean Herbert	957a1648c7	Merge pull request #16237 from smoogipoo/fix-finished-play-exception-2 ... Improve reliability of exiting gameplay in multiplayer	2021-12-25 15:32:14 +09:00
Dean Herbert	ac1a452e20	Merge pull request #16239 from peppy/sanitise-test-directory-usage ... Fix some more test directory usage weirdness	2021-12-25 12:09:18 +09:00
Dean Herbert	7088471cad	Protect against test failures due to logger being set too early (and beginning logging)	2021-12-25 02:21:49 +09:00
Dean Herbert	a9a7a33974	Update framework	2021-12-25 02:04:47 +09:00
Dan Balasescu	a43cc20ae2	Apply changes to GameplayCompleted from reviews	2021-12-24 21:58:20 +09:00
Dan Balasescu	c6854b37c8	Unbind event on disposal	2021-12-24 21:58:09 +09:00
Dan Balasescu	d36fe3af09	Merge pull request #16238 from peppy/fix-incorrect-delegate-capture ... Fix incorrect delegate capture leading to slow leak of audio tracks	2021-12-24 21:34:04 +09:00
Dean Herbert	1c0dc204c4	Fix some regressing behaviour due to CleanRunHeadlessGameHost's naming structure changing	2021-12-24 20:24:37 +09:00
Dean Herbert	8cdad5f4d9	Remove incorrectly used gameSuffix from CleanRunHeadlessGameHost	2021-12-24 20:15:10 +09:00
Dean Herbert	2ee3e61983	Merge branch 'master' into beatmap-card/extra-on-listing	2021-12-24 19:02:51 +09:00
Dean Herbert	cc7089c3f4	Cancel more liberally	2021-12-24 19:00:09 +09:00
Dean Herbert	d602aebebb	Add missing cancellation token and rename load task variable to match purpose	2021-12-24 18:58:31 +09:00
Dean Herbert	842d508aee	Fix incorrect delgate capture leading to slow leak of audio tracks ... During profile, it was found that the `Completed` delegate was incorrectly also capturing `lastTrack`, leading to an unexpected reference chain that led to a memory leak over a long period of time. This solves the issue by moving the delegate construction to its own method, where it won't capture the other variables.	2021-12-24 18:39:29 +09:00
Dean Herbert	83a1d39f80	Merge pull request #16231 from bdach/ruleset-config-cache-overwriting-3 ... Fix ruleset config cache potentially not working correctly in test contexts	2021-12-24 17:18:42 +09:00
Bartłomiej Dach	3ca238825b	Unify width of normal and extra card sizes	2021-12-24 09:17:07 +01:00
Dan Balasescu	18c144395a	Rename to dimColour	2021-12-24 17:03:29 +09:00
Dan Balasescu	f44af1ad69	Move bind to LoadComplete	2021-12-24 17:00:59 +09:00
Dan Balasescu	727335dcad	Improve reliability of exiting gameplay	2021-12-24 14:23:09 +09:00
Dan Balasescu	c973739b08	Fix OsuButton event binding + inital-enablement colour	2021-12-24 11:56:12 +09:00
Dan Balasescu	c8073000c5	Fix initally-disabled OsuAnimatedButton colour fading	2021-12-24 11:56:12 +09:00
Dean Herbert	ce4389576f	Merge branch 'master' into fix-incorrect-reference	2021-12-24 10:03:11 +09:00
Bartłomiej Dach	c429c74d89	Expose and use test ruleset config cache in test scenes	2021-12-23 19:42:26 +01:00
Bartłomiej Dach	8094b502cb	Remove test-specific logic from RulesetConfigCache	2021-12-23 19:42:26 +01:00
Bartłomiej Dach	77da1e12d5	Add test implementation of the ruleset config cache	2021-12-23 19:40:55 +01:00
Bartłomiej Dach	5cbaa028eb	Use extracted ruleset config cache implementation in DI	2021-12-23 19:02:10 +01:00
Bartłomiej Dach	0f65c4e960	Extract interface for ruleset config cache	2021-12-23 18:59:02 +01:00
Bartłomiej Dach	a49a4329ee	Add capability to switch between card sizes	2021-12-23 15:55:37 +01:00
Bartłomiej Dach	d0427ec85f	Add support card size tab control to beatmap listing	2021-12-23 15:55:37 +01:00
Bartłomiej Dach	1876617d8e	Implement beatmap card size tab control	2021-12-23 15:55:36 +01:00
Bartłomiej Dach	cd4c1bc678	Add factory method for various card sizes	2021-12-23 15:55:36 +01:00
Dan Balasescu	998b07db90	Fix TestMultiplayerClient referencing the wrong room	2021-12-23 19:14:09 +09:00
Bartłomiej Dach	1040590844	Add cancellation support to game-side IResourceStores	2021-12-23 10:33:17 +01:00
Dean Herbert	0732a9e6da	Update framework	2021-12-23 18:08:44 +09:00
Dean Herbert	d69552fbcf	Fix potential crash from cross-thread drawable mutation in collection management ... As seen at https://github.com/peppy/osu/runs/4613800663?check_suite_focus=true.	2021-12-23 13:21:17 +09:00
Dan Balasescu	e1b539fa9e	Merge pull request #16213 from peppy/working-beatmap-live ... Tidy up `WorkingBeatmap`	2021-12-23 13:02:37 +09:00
Bartłomiej Dach	25e38560ce	Fix placeholder drawables on beatmap listing not always hiding correctly ... `BeatmapListingOverlay.addContentToPlaceholder()`, in order to make transitions between different beatmap listing content (whether it is actual cards, or placeholders for no beatmaps found/supporter-specific filters chosen), would set `BypassAutoSizeAxes = Y` on content as it is fading out, to make the transition smoother. The property in question was supposed to be getting restored to `None` on the next show. In testing scenarios, it sometimes turned out that this wasn't the case, therefore making the placeholders effectively not show - while they were present and fully opaque, they would be the only child of an auto-sized container with `BypassAutoSizeAxes = Y`, so the parent auto-sized to a zero height, which logically follows from the premise, but is not what was desired. This in turn was caused by the fact that the `BypassAutoSizeAxes = Y` set was scheduled, and sometimes it would be scheduled in such a way that the drawable would cease to be present on the next frame due to its alpha being past the cutoff point of 0.0001. Therefore the scheduled set would not execute until the *next* time the placeholder was shown, therefore causing the bug. Fix by ensuring that the placeholder drawables are always present if their schedulers have any tasks enqueued, on top of the usual checks of alpha and scale performed via the base implementation.	2021-12-22 15:05:23 +01:00
Dean Herbert	f179ff33c9	Remove all NRT changes ... This reverts commit bb9877adab.	2021-12-22 21:02:06 +09:00
Dean Herbert	bb9877adab	Reapply IWorkingBeatmap nullability fixed	2021-12-22 20:48:48 +09:00
Dan Balasescu	67e6b50c12	Merge pull request #16135 from stanriders/refactor-diffcalc ... Slightly refactor difficulty and pp calculators	2021-12-22 19:44:02 +09:00
Dan Balasescu	fa5ee5f72c	Merge pull request #16212 from peppy/fix-beatmap-leaderboard-global-reference ... Fix potential errors thrown during beatmap leaderboard display due to incorrect beatmap reference	2021-12-22 19:26:32 +09:00
Dean Herbert	bc47801cbb	Revert "Apply NRT to WorkingBeatmap" ... This reverts commit 9e17d7d4e3.	2021-12-22 19:14:18 +09:00
Dean Herbert	9e17d7d4e3	Apply NRT to WorkingBeatmap	2021-12-22 18:41:45 +09:00
Dean Herbert	53c0a6708f	Move public accessor properties to top of file	2021-12-22 18:25:09 +09:00
Dean Herbert	a5f77a86ef	Move load methods and rename loadedTrack to match other private fields	2021-12-22 18:24:51 +09:00
Dean Herbert	7344c87b16	Remove RecyclableLazy	2021-12-22 18:18:12 +09:00
Dean Herbert	f3f491374b	Remove unused load checks	2021-12-22 18:17:00 +09:00
Dean Herbert	3c95497ed7	Reorder methods to hopefully make more sense	2021-12-22 18:17:00 +09:00
Dean Herbert	e38e4c0adc	Enable NRT on IWorkingBeatmap	2021-12-22 18:17:00 +09:00
Dean Herbert	967419c9ac	Remove BeatmapSetInfo and Metadata from interface ... There were very few accesses to this, and after realm they should all be done via the `BeatmapInfo`, so let's remove this.	2021-12-22 18:17:00 +09:00
Dean Herbert	1b0af78831	Simplify WorkingBeatmap in multiple ways ... Just a clean-up pass.	2021-12-22 18:17:00 +09:00
Dean Herbert	b38b300159	Convert BeatmapMetadata access to be via a computed property	2021-12-22 18:17:00 +09:00
Dean Herbert	5b3a154431	Fix potential errors thrown during beatmap leaderboard display due to incorrect beatmap reference ... Specifically, the global `BeatmapInfo` is referenced inside the web request's success callback, and used to attempt population via methods which expect non-null beatmap inputs. Closes #16211.	2021-12-22 17:24:48 +09:00
Dean Herbert	f81e32149b	Fix ImportCollectionsTest.TestSaveAndReload not cleaning up before/after run	2021-12-22 13:38:20 +09:00
Dean Herbert	a88800c99a	Merge pull request #16198 from smoogipoo/fix-current-item-before-population ... Fix delete button showing on current item before beatmap retrieval	2021-12-22 13:15:07 +09:00
Dan Balasescu	98f044881e	Merge branch 'master' into refactor-diffcalc	2021-12-22 12:31:28 +09:00
Dan Balasescu	7bc5079485	Merge pull request #16201 from bdach/timeline-blueprint-contrast-improvement ... Improve contrast of timeline blueprint foreground content for pastel combo colours	2021-12-22 11:33:29 +09:00
Bartłomiej Dach	7ab1c0c99d	Improve contrast of timeline blueprint foreground content for pastel combo colours	2021-12-21 12:54:17 +01:00
StanR	88436d51ae	Remove using	2021-12-21 13:44:20 +03:00
Bartłomiej Dach	ca7303a50a	Fix online lookup cache not clearing completed task on early return ... The task not being cleared in the early return path would cause `pendingRequestTask` to become stuck as a completed task, and `queryValue()` would not recreate it due to the null check there, therefore stalling all lookups forevermore until a game restart.	2021-12-21 11:13:41 +01:00
Bartłomiej Dach	ee89d8643e	Extract abstract implementation of online lookup cache	2021-12-21 11:12:51 +01:00
StanR	cca02a8016	Create PerformanceAttributes	2021-12-21 13:08:31 +03:00
Dean Herbert	df975fb29e	Merge pull request #16181 from dekrain/statics-reset-no-sb ... Split session statics reset method to prevent unloading seasonal backgrounds	2021-12-21 18:52:04 +09:00
Dean Herbert	0bda7892f7	Merge pull request #16197 from bdach/beatmap-card/renames ... Rename beatmap card-related classes	2021-12-21 18:51:34 +09:00
Dan Balasescu	4ce61d4260	Directly bind to room updates ... Currently doesn't really cause any difference, however it may in the future if we decide the queueing algorithm shouldn't update PlaylistOrder when an item has been played.	2021-12-21 18:40:29 +09:00
Dan Balasescu	a34d24fb20	Disallow expired items from showing delete button ... This isn't possible in practice since expired items are removed from the queue list, but this helps out in tests.	2021-12-21 18:37:42 +09:00
Dan Balasescu	d7136d6b48	Merge pull request #16196 from peppy/update-framework ... Update framework	2021-12-21 18:23:02 +09:00
Dan Balasescu	4ba5a939db	Merge pull request #16178 from bdach/lounge-background-screen-correct ... Fix lounge screen showing information sourced from wrong playlist item	2021-12-21 17:36:23 +09:00
Dan Balasescu	51b7e920c0	Fix delete button being able to show on current item	2021-12-21 16:57:58 +09:00
Bartłomiej Dach	979624160f	Do not reset last hover sound playback time on inactivity	2021-12-21 08:47:41 +01:00
Bartłomiej Dach	cd10af633c	Remove unused private method	2021-12-21 08:47:26 +01:00
Dean Herbert	0198d49a3a	Update framework	2021-12-21 16:38:03 +09:00
Dan Balasescu	32fbaf47c0	Merge pull request #16192 from peppy/add-room-lost-logging ... Add logging of `MultiplayerMatchSubScreen` exiting from room loss	2021-12-21 16:37:08 +09:00
Bartłomiej Dach	c7b9b176c6	Rename BeatmapCard{Base => }	2021-12-21 08:26:25 +01:00
Bartłomiej Dach	88d4e95ad8	Rename BeatmapCard{ => Normal}	2021-12-21 08:26:21 +01:00
Bartłomiej Dach	bd1fb33ad6	Add and use separate extensions for historical and upcoming playlist items	2021-12-21 08:01:04 +01:00
Dean Herbert	2707b2fbda	Merge pull request #16012 from bdach/beatmap-card/extra ... Implement "extra" beatmap card size	2021-12-21 15:40:33 +09:00
Dean Herbert	981158ed88	Rename method and simplify SetDefault calling code	2021-12-21 15:34:32 +09:00
Dan Balasescu	5cea8da80f	Merge pull request #16188 from peppy/multiplayer-button-enabled ... Centralise all multiplayer button clicking test logic	2021-12-21 15:10:26 +09:00
Dean Herbert	d08b66a5ff	Also add logging to OnlinePlayScreen	2021-12-21 15:07:06 +09:00
Dean Herbert	ddadf3c4b5	Add logging of MultiplayerMatchSubScreen exiting from room loss	2021-12-21 14:53:24 +09:00
Dean Herbert	9aff646ff4	Centralise all multiplayer button clicking test logic ... This adds the "wait for enabled" check in a way that can be easily reused, as it keeps getting missed in test implementations. This particular commit hopefully fixes https://github.com/ppy/osu/runs/4583845033?check_suite_focus=true.	2021-12-21 13:49:51 +09:00
Dean Herbert	edcbd4de6d	Fix incorrect event unbind logic	2021-12-21 13:05:26 +09:00
Dean Herbert	52db7b36fc	Move Schedule call to base implementation of error meter for extra safety	2021-12-21 12:55:21 +09:00
Dean Herbert	28d6ff5d9c	Fix potential wrong thread mutation in ColourHitErrorMeter	2021-12-21 12:36:04 +09:00
dekrain	9344897542	Split session statics reset method to prevent unloading seasonal backgrounds while idle	2021-12-20 16:51:51 +01:00
Bartłomiej Dach	f1a03aced5	Merge branch 'master' into beatmap-card/extra	2021-12-20 15:49:00 +01:00
Bartłomiej Dach	0975f570ba	Return last playlist item if all expired	2021-12-20 13:49:05 +01:00
Bartłomiej Dach	a5a9922f81	Fix lounge screen content not matching current room playlist item	2021-12-20 13:32:42 +01:00
Bartłomiej Dach	a59583ee09	Add extension method for returning next playlist item	2021-12-20 13:18:02 +01:00
Dean Herbert	6907a9a3cc	Name some screen stacks for better logging context	2021-12-20 18:24:14 +09:00
Dean Herbert	1533aefce5	Update framework	2021-12-20 18:22:19 +09:00
Dan Balasescu	9316abc278	Better fix for intermittent multiplayer tests	2021-12-20 13:10:13 +09:00
Bartłomiej Dach	a6ccbafc77	Fix rank graph showing for unranked users	2021-12-19 13:40:22 +01:00
Bartłomiej Dach	097402677d	Add test for ranked/unranked user display	2021-12-19 13:40:22 +01:00
Dean Herbert	04cfae9bde	Fix "Random Skin" text not showing up correctly	2021-12-18 16:26:15 +09:00
StanR	2f2006715e	Slightly refactor difficulty and pp calculators	2021-12-17 23:40:23 +03:00
Bartłomiej Dach	33e930f477	Move scale-on-expand logic to BeatmapCardContent	2021-12-17 13:29:20 +01:00
Bartłomiej Dach	d6f6039934	Extract base class for beatmap cards	2021-12-17 13:27:11 +01:00
mk-56	fd5af1fbe7	Code refactor and name changes ... cleaned code up with Jetbrains i hope it suffices	2021-12-17 13:16:06 +01:00
Bartłomiej Dach	f052b47d87	Extract collapsible button container for card usage	2021-12-17 12:58:05 +01:00
Bartłomiej Dach	7aab12d4b0	Share extra row dropdown show/cancel show logic	2021-12-17 11:45:05 +01:00
Bartłomiej Dach	3fa45479b0	Share hype/nomination statistic show logic	2021-12-17 11:45:05 +01:00
Dean Herbert	81603a0645	Update framework	2021-12-17 19:32:58 +09:00
Bartłomiej Dach	c6d0b5d200	Merge branch 'master' into beatmap-card/extra-wip	2021-12-17 11:11:36 +01:00
Dean Herbert	1067e2dc00	Merge branch 'master' into update-framework	2021-12-17 16:41:47 +09:00
Dean Herbert	6bfe973fe5	Update framework	2021-12-17 13:44:52 +09:00
Bartłomiej Dach	54790bb758	Merge branch 'master' into fix-realm-post-storage-migration-failure	2021-12-17 00:19:46 +01:00
Salman Ahmed	9a22a082ca	Merge branch 'master' into master	2021-12-16 16:58:24 +03:00
Dean Herbert	eecb1ce9f5	Avoid applying mouse down effects to menu cursor when it isn't visible ... Closes #16114.	2021-12-16 20:20:06 +09:00
Dean Herbert	434aa0367f	Add back .ToLocalTime() call to DrawableDate ... This is required because the class is used in many other places that don't locally call it.	2021-12-16 18:25:29 +09:00
Dean Herbert	0eac655cff	Remove local screen change logging	2021-12-16 18:21:48 +09:00
Dean Herbert	aa0813ff05	Merge pull request #16109 from smoogipoo/chat-overlay-multiplayer-removal ... Don't show multiplayer channels in chat overlay	2021-12-16 17:39:45 +09:00
Dan Balasescu	3f1d747b7a	Merge pull request #16090 from peppy/fix-scroll-speed-toast-sample-spam ... Fix toast popups spamming samples when adjusting osu!mania scroll speed during gameplay	2021-12-16 17:31:36 +09:00
Dan Balasescu	488374b4a2	Don't show multiplayer channels in chat overlay	2021-12-16 16:41:47 +09:00
Dean Herbert	a9dbcd92a1	Split out unmanaged implementation of RealmLive into its own class	2021-12-16 15:23:55 +09:00
Imad Dodin	b3e83a47a4	Convert to Local Time in Date Tooltip	2021-12-15 21:36:35 -08:00
Dean Herbert	e6e1366c28	Merge pull request #16094 from peppy/beatmap-card-expanded-state-fix ... Fix beatmap card potentially collapsing when it shouldn't	2021-12-16 14:13:47 +09:00
Dean Herbert	0ec1e1e2d5	Merge pull request #16091 from MyDogsEd/fix-issue-#15869 ... Fix the taiko scroller bar appearing during cinema mod	2021-12-16 12:05:00 +09:00
Bartłomiej Dach	cbb65e1e07	Merge branch 'master' into beatmap-card-expanded-state-fix	2021-12-15 22:20:30 +01:00
Dean Herbert	cd8dfac625	Merge pull request #16097 from smoogipoo/forego-resetting-spectate-state ... Don't reset spectating state if spectator exited after gameplay finishes	2021-12-15 22:30:41 +09:00
Dean Herbert	33cf4ba7f6	Merge pull request #16075 from smoogipoo/prevent-idle-transition-during-load ... Add AbortGameplay() to fix state transition race conditions during multiplayer load	2021-12-15 19:59:19 +09:00
Dan Balasescu	4c53ec12e9	Merge branch 'master' into forego-resetting-spectate-state	2021-12-15 18:47:47 +09:00
Dean Herbert	2025183f5a	Merge pull request #15990 from Susko3/number-textbox-only-numbers ... Fix `SettingsNumberBox` accepting non-number characters	2021-12-15 18:39:54 +09:00
Dean Herbert	9e82a3e79a	Merge branch 'master' into forego-resetting-spectate-state	2021-12-15 18:05:06 +09:00
Dan Balasescu	18d7b79207	Don't reset spectating state if gameplay is finished	2021-12-15 17:40:30 +09:00
Susko3	643cee4f83	Merge branch 'master' into number-textbox-only-numbers	2021-12-15 09:13:19 +01:00
Dean Herbert	694ee68725	Update resources	2021-12-15 16:59:33 +09:00
Dan Balasescu	740a6f16c7	Fix exception when updating the room's visual playlist	2021-12-15 16:53:25 +09:00
Dean Herbert	42f14667a3	Update framework	2021-12-15 16:50:55 +09:00
Dean Herbert	ad430a6277	Centralise hover state handling (and fix back-to-front conditionals)	2021-12-15 16:44:58 +09:00
Dean Herbert	6a1f535257	Refactor cancellation of expand to be more explicit	2021-12-15 16:38:19 +09:00
Dean Herbert	94d1a2aaca	Remove unnecessary collapse call from BeatmapCard ... This is already handled at the `BeatmapCardContent` level. This call actually causes the buggy behaviour reported in https://github.com/ppy/osu/discussions/16085.	2021-12-15 16:37:47 +09:00
Dean Herbert	7a9db22c52	Tidy up method naming and structure for expanded state changes	2021-12-15 16:29:12 +09:00
Dean Herbert	ef4ab74565	Also only expose Expanded state of BeatmapCard as read-only	2021-12-15 16:26:19 +09:00
Dean Herbert	41e6c24dad	Expose Expanded state of BeatmapCardContent as read-only bindable ... This is just to reduce complexity of these interactions by ensuring that the expanded state can only be changed by the class itself.	2021-12-15 16:26:19 +09:00
Susko3	b326ccc196	Move logic to framework and update all usages	2021-12-15 07:13:24 +01:00
JamesTheGeek	828072bcea	Fix issue #15869 ... The taiko-slider is not included in `Playfield`, so it doesn't get hidden when calling `drawableRuleSet.Playfield.Hide()`. Calling `drawableRuleSet.Hide()` hides the taiko-slider, in addition to the rest of the `Playfield`.	2021-12-14 23:23:11 -05:00
Dean Herbert	0c11fe7413	Fix toast popups spamming samples when adjusting osu!mania scroll speed during gameplay ... Not the most robust of fixes, but as per the reasoning described in the issue thread, a proper fix will take considerably more effort. This intends to fix the issue first and foremost, as it sounds so bad I'd want to mute my sound before adjusting currently. Closes #15718.	2021-12-15 12:45:23 +09:00
Dean Herbert	9d85beddbe	Fix null reference in some tests due to missing realm context factory	2021-12-15 11:16:37 +09:00
Dan Balasescu	2cea39a92a	Merge pull request #16083 from peppy/fix-online-availability-after-reimport ... Fix `OnlinePlayBeatmapAvailabilityTracker` failng after modified reimport of existing beatmap	2021-12-15 08:31:02 +09:00
Dan Balasescu	ee6f125948	Merge pull request #15967 from tbrose/chat-mention-fix ... Check word boundaries during username mention matching	2021-12-15 08:04:39 +09:00
Dan Balasescu	9ade8069a1	Rename to AbortGameplay() and handle additional states	2021-12-15 06:40:28 +09:00
Dan Balasescu	4c81fd8b7c	Merge pull request #16068 from peppy/fix-fail-animation-background-dim ... Improve appearance of player-wide background after failing with low background dim	2021-12-15 06:32:02 +09:00
Bartłomiej Dach	00154fe86d	Merge branch 'master' into fix-menu-background-desync	2021-12-14 21:31:10 +01:00
tbrose	a831744f05	Merge remote-tracking branch 'origin/chat-mention-fix' into chat-mention-fix	2021-12-14 16:24:05 +01:00
tbrose	8e79fac389	Fixes code quality check failed	2021-12-14 16:23:51 +01:00
Dean Herbert	453ecd21b3	Fix OnlinePlayBeatmapAvailabilityTracker potentially in incorrect state ... Adter an import of a modified version of a beatmap (that was already present in the local database), it's feasible that one of these trackers would not see the state change due to the nuances of the import process.	2021-12-14 19:16:11 +09:00
Dean Herbert	04551ea61e	Merge pull request #16080 from smoogipoo/fix-storyboard-start-time ... Fix incorrect storyboard life time start with looping commands	2021-12-14 18:33:56 +09:00
Dean Herbert	cebfeb5220	Merge pull request #16045 from smoogipoo/multiplayer-local-beatmap-query ... Rework multiplayer's current item tracking	2021-12-14 18:33:30 +09:00
Dean Herbert	79dd9674fc	Use longer form to read better ... Using `l.StartTime` reads like a coding issue, even though if you go down the call chain looks to be correct.	2021-12-14 17:41:09 +09:00
Dean Herbert	8c6f50ddb1	Fix BackgroundScreenDefault incorrectly updating current background after being inactive ... If the beatmap was changed but then reverted to the previously displayed map, the background may have displayed incorrectly on resuming. Closes #15804.	2021-12-14 16:40:50 +09:00
Dean Herbert	b6a272e31a	Add failing test coverage of BackgroundScreeNDefault's beatmap background tracking when active/non-active	2021-12-14 16:40:34 +09:00
Dean Herbert	441b7baa93	Provide a realm factory to usages of ToLive/RealmLive	2021-12-14 14:26:34 +09:00
Dean Herbert	f9a2db5ec6	Add accessibility to realm factory via IStorageResourceProvider ... We might need to rename this class..	2021-12-14 14:19:49 +09:00
Dean Herbert	7e576ae9d3	Add note about how the background colour is restored	2021-12-14 13:25:19 +09:00
Dan Balasescu	357a661379	Fix storyboard sprites sometimes starting too early	2021-12-14 13:13:12 +09:00
Dan Balasescu	51b6b9d857	Merge branch 'master' into chat-mention-fix	2021-12-14 11:49:57 +09:00
Dan Balasescu	750bfae909	Fix TestMultiplayerClient not handling all users bailing from gameplay	2021-12-14 11:35:56 +09:00
Dan Balasescu	2f1dc91211	Add AbortLoad() method to abort gameplay loads	2021-12-14 11:30:42 +09:00
Dean Herbert	a076eda834	Merge pull request #16062 from smoogipoo/retry-score-submission-timeout ... Increase score submission timeout	2021-12-14 11:03:20 +09:00
Dan Balasescu	419a34e7b4	Merge branch 'master' into test-score-refactoring	2021-12-14 07:30:06 +09:00
Dan Balasescu	7564658b5e	Reduce to 30s	2021-12-14 06:40:45 +09:00
Dean Herbert	b0d14526ea	Move test ScoreInfo creation to TestResources ... The main goal here is to remove the inheritance, since realm doesn't like that. Unfortunate that we can't use object initialisers in a few of these places, but no real way around that.	2021-12-13 16:34:50 +09:00
Dan Balasescu	70045494ba	Re-simplify code by removing BeatmapManager event instead	2021-12-13 16:09:54 +09:00
Dean Herbert	7318ff3f98	Refactor KeyBindingStore to clean up any excess bindings for individual actions ... While this isn't strictly required (outside of rulesets, potentially), I think it's best that we keep these counts in a sane state. Right now, it will remove any excess. Arguably, in the case an entry is found with too many, we should wipe all entries and re-populate the defaults. Interested in opinions on that before merging. See https://github.com/ppy/osu/discussions/15925 for an example where wiping may be the more appropriate behaviour.	2021-12-13 15:26:51 +09:00
Dean Herbert	cac684c044	Improve appearance of player-wide background after failing with low background dim	2021-12-13 14:53:11 +09:00
Dean Herbert	c097dc8048	Add note about reasoning behind MultiplayerClient.GetAPIBeatmap call	2021-12-13 13:39:32 +09:00
Dean Herbert	3ea07b426b	Merge branch 'master' into multiplayer-local-beatmap-query	2021-12-13 13:27:34 +09:00
Dean Herbert	c375c87094	Merge pull request #16065 from frenzibyte/reorder-version-overlay ... Display game version overlay behind the overlays layer	2021-12-13 13:25:30 +09:00
Salman Ahmed	d0fbbf110b	Expose ScreenContainer for access in OsuGameDesktop	2021-12-13 06:52:36 +03:00
Dan Balasescu	fd979a52fe	Increase score submission request timeout to 60s	2021-12-13 07:15:21 +09:00
Dan Balasescu	2cd2b10ce1	Fix results sometimes showing incorrect score position	2021-12-13 06:54:57 +09:00
Dan Balasescu	bf3abb2455	Merge branch 'master' into multiplayer-local-beatmap-query	2021-12-12 16:37:41 +09:00
Dan Balasescu	a6e77f172d	Add some comments	2021-12-12 16:30:37 +09:00
Dan Balasescu	d6c08fae48	Fix incorrect global beatmap with availability changes	2021-12-11 23:08:21 +09:00
Dan Balasescu	ece2cddb7f	Fix DrawableRoomPlaylistItem lookup interfering with tests	2021-12-11 22:51:20 +09:00
Dan Balasescu	25b274c323	Fix starting gameplay too early after import	2021-12-11 22:47:50 +09:00
Dan Balasescu	1aac978a7b	Merge pull request #16029 from peppy/editor-mod-reset ... Fix editor not resetting mods when entering	2021-12-11 20:20:11 +09:00
Dan Balasescu	63a017bc8e	Use Array.Empty instead	2021-12-11 19:33:37 +09:00
Dan Balasescu	cdb8237a4b	Merge branch 'master' into pre-realm-score-tidy	2021-12-11 19:25:39 +09:00
Salman Ahmed	3a4266bd5e	Merge branch 'master' into update-framework	2021-12-10 17:50:33 +03:00
Dan Balasescu	6057037e35	Move playlist item beatmap population to MatchSubScreen	2021-12-10 20:08:59 +09:00
Dean Herbert	c1b3ee6bb2	Fix editor not resetting mods when entering ... Would leave the user potentially in a test mode that is in a weird state (ie. if cinema mod was enabled). Eventually we'll add the ability to choose mods for test play, but that will be done in a saner way. Closes #15870.	2021-12-10 18:57:45 +09:00
Dean Herbert	3b899af061	Update libraries	2021-12-10 18:46:47 +09:00
Dean Herbert	f7c5a3f506	Use similar method of consuming OnlineID as done in beatmap classes	2021-12-10 18:34:31 +09:00
Dean Herbert	c9f6c5c673	Add MatchesOnlineID implementation for IScoreInfo	2021-12-10 18:34:31 +09:00
Dean Herbert	5f6e887be7	Remove OnlineID comparison from ScoreInfo.Equals ... This matches the implementation we have for `BeatmapInfo` and `BeatmapSetInfo`. All comparisons of `OnlineID` should be done directly using them (ie. how it's done in `ScoreModelDownloader`).	2021-12-10 18:17:43 +09:00
Dan Balasescu	e98060ac37	Remove unused using	2021-12-10 17:55:18 +09:00
Dean Herbert	73227c084e	Update framework	2021-12-10 17:42:40 +09:00
Dean Herbert	970a9ae074	Add update thread asserts to RoomManager methods	2021-12-10 17:22:24 +09:00
Dean Herbert	3633494509	Merge pull request #16020 from smoogipoo/host-enqueue-2 ... Add support for enqueueing items in host-only mode, and changing arbitrary playlist items	2021-12-10 16:23:48 +09:00
Dean Herbert	c6d0d6451d	Change IScoreInfo.User to an interface type	2021-12-10 16:11:49 +09:00
Dean Herbert	bff02bedbf	Rename APIScoreInfo to APIScore	2021-12-10 16:11:49 +09:00
Dean Herbert	dbb08f7d46	Use OnlineID for set operations	2021-12-10 16:11:48 +09:00
Dean Herbert	7ac63485ef	Add setter for ScoreInfo.OnlineID	2021-12-10 16:11:48 +09:00
Dean Herbert	bf1418bafc	Use OnlineID instead of legacy IDs for equality and lookups	2021-12-10 16:11:48 +09:00
Dan Balasescu	4e6286920c	Merge pull request #16017 from peppy/fix-child-set-after-disposal ... Fix potential crash due to children being mutated after disposal	2021-12-10 15:38:34 +09:00
Dan Balasescu	de0f37b08d	Separate editing and adding playlist items	2021-12-10 15:26:48 +09:00
Dean Herbert	88670c3b01	Document OpenSongSelection and mark null param	2021-12-10 14:14:22 +09:00
Dean Herbert	50bf2f368d	Merge branch 'master' into host-enqueue-2	2021-12-10 14:09:19 +09:00
Dean Herbert	9ac8e6c81c	Add missing null check before attempting to populate bpm info	2021-12-10 13:53:48 +09:00
Dean Herbert	612f47bb9f	Add the ability to create playlists of 2 weeks ~ 3 months in duration	2021-12-10 13:45:29 +09:00
Dean Herbert	1952819db2	Merge pull request #16019 from smoogipoo/cleanup-playlist-item-buttons ... Cleanup duplicated classes in DrawableRoomPlaylistItem	2021-12-10 12:01:26 +09:00
Dan Balasescu	35a208a478	Merge pull request #15999 from peppy/restore-user-volume-muted-notification ... Fix the unmute notification potentially overwriting user's volume levels unnecessarily	2021-12-10 02:58:59 +09:00
Dan Balasescu	671582a925	Allow host to enqeue items and items to be edited	2021-12-10 01:15:19 +09:00
Dan Balasescu	048a495115	Add edit button to DrawableRoomPlaylistItem	2021-12-10 01:08:54 +09:00
Dan Balasescu	4d1c06c061	Add support for host enqueueing in TestMultiplayerClient	2021-12-10 01:03:36 +09:00
Dan Balasescu	05aa9635a8	Privatise button again	2021-12-10 00:38:18 +09:00
Dan Balasescu	f9af239ed9	Cleanup duplicated classes in DrawableRoomPlaylistItem	2021-12-09 23:56:49 +09:00
Dean Herbert	538a822760	Merge branch 'master' into multiplayer-playlist-deletion	2021-12-09 19:04:06 +09:00
Dean Herbert	a3b53ac2f6	Change comparison to match in all locations	2021-12-09 18:58:47 +09:00
Dean Herbert	b393f83028	Merge pull request #16009 from smoogipoo/cleanup-drawable-playlist ... Cleanup DrawableRoomPlaylist and DrawableRoomPlaylistItem	2021-12-09 18:54:16 +09:00
Dean Herbert	e7e61cd9ab	Fix potential crash due to children being mutated after disposal ... This is a bit of an unfortunate edge case where the unbind-on-disposal doesn't help, since the binding is happening in BDL, and the usage is in a nested `LoadComponentAsync` call. Combine those and you have a recipe for disaster.	2021-12-09 18:52:00 +09:00
Dean Herbert	dfe19f3509	Minor code reformatting	2021-12-09 17:53:40 +09:00
Dan Balasescu	0963b00453	Disallow item selection in playlists song select	2021-12-09 17:33:59 +09:00
Dan Balasescu	17d676200b	Xmldoc fixes from code review ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-12-09 17:33:36 +09:00
Dan Balasescu	1a0945daba	Siplify condition, allow host to always remove items	2021-12-09 14:33:50 +09:00
Bartłomiej Dach	083ee92dee	Adjust button vertical padding	2021-12-08 22:56:28 +01:00
Bartłomiej Dach	2d739c95ea	Lay out extra card statistics in grid as per design	2021-12-08 22:56:28 +01:00
Bartłomiej Dach	3ecfaa532c	Add source field to extra beatmap card	2021-12-08 22:56:28 +01:00
Bartłomiej Dach	419fee1380	Move mapper link to bottom content	2021-12-08 22:54:11 +01:00
Bartłomiej Dach	61e04f75cc	Resize extra card to design size	2021-12-08 22:54:10 +01:00
Bartłomiej Dach	a32492cdd5	Duplicate BeatmapCard{-> Extra} as blueprint for extra card size	2021-12-08 22:53:51 +01:00
Dan Balasescu	80b2768a5f	Mirror recent server-side changes	2021-12-09 04:18:54 +09:00
Dan Balasescu	4df2047a58	Prevent removal of expired items in TestMultiplayerClient	2021-12-09 04:12:24 +09:00
Dan Balasescu	8398f86440	Don't consider expired items in visibility check	2021-12-09 04:02:16 +09:00
Dan Balasescu	c34c580ad4	Add client-side + interface implementation	2021-12-09 03:08:59 +09:00
Dan Balasescu	ce081c4acc	Fix missing propagation of OwnerId in tests	2021-12-09 02:01:17 +09:00
Dan Balasescu	23332995d1	Invert naming of exposed actions	2021-12-09 01:52:59 +09:00
Dan Balasescu	273042aa16	Add virtual method for creating different DrawablePlaylistItem types	2021-12-09 01:49:34 +09:00
Dan Balasescu	3b4833ca8e	A bit of cleanup + xmldocs on classes/members	2021-12-09 01:40:16 +09:00
Dan Balasescu	be2dbf42c3	Flatten DrawableRoomPlaylistWithResults into base class	2021-12-09 01:40:16 +09:00
Dan Balasescu	26f6c5e5a5	Remove ctor params from PlaylistsRoomPlaylist	2021-12-09 01:16:37 +09:00
Dan Balasescu	3be4d8b68d	Remove ctor params from DrawableRoomPlaylist/DrawablePlaylistItem	2021-12-09 01:04:56 +09:00
Dean Herbert	8d9c37a825	Merge branch 'master' into primary-key-consistency	2021-12-08 21:34:38 +09:00
Dan Balasescu	beb5d61a42	Separate playlist item deletion to Playlists-specific class	2021-12-08 20:50:25 +09:00
Dean Herbert	8fa73fcbf6	Move helper method to end of class	2021-12-08 18:30:08 +09:00
Susko3	de89e321c8	Add sounds for IME composition	2021-12-08 09:57:53 +01:00
Susko3	af1e97b7c7	Move playing text added samples to private helper and fix it never playing the last sample ... `RNG.Next` is exclusive of the upper bound, meaning that the last sample would never be played.	2021-12-08 09:49:36 +01:00
Dan Balasescu	65a09692da	Merge pull request #16001 from peppy/fix-own-rank-results-panel-in-multiplayer ... Fix the local user's rank not showing on multiplayer/playlist results screen	2021-12-08 16:34:36 +09:00
Dean Herbert	872e0884c0	Fix the local user's rank not showing on multiplayer/playlist results screen ... Applying the simple solution for now. Not sure how this will evolve over time, but seems sane enough.	2021-12-08 15:22:10 +09:00
Dean Herbert	6ec3f41839	Fix LegacyComboCounter not handling non-default anchor/origin specifications correctly	2021-12-08 15:07:15 +09:00
Dean Herbert	0775053a18	Fix the unmute notification potentially overwriting user's volume levels unnecessarily ... I've also changed the cutoffs to 5% rather than zero, as this seems like a saner method of showing this dialog. With levels 5% or less, the game is basically inaudible. Arguably, the cutoff can be increased to 10%.	2021-12-08 13:38:43 +09:00
Dean Herbert	2e640ff2ad	Merge pull request #15989 from bdach/fix-editor-clipboard-test-failure ... Fix editor crashing if paste is performed while composer is loading	2021-12-08 11:18:59 +09:00
Bartłomiej Dach	10dd64e07c	Fix being able to paste objects while composer is loading ... Would lead to exceptions due to modification of `Beatmap.HitObjects` during its enumeration by `DrawableRuleset`, which was happening as an async load via `EditorScreenWithTimeline.CreateMainContent()`.	2021-12-07 21:00:25 +01:00
Susko3	0b0ff36154	Allow only number characters parseable by int.TryParse ... char.IsNumber() is too broad, allowing full width and other numbers.	2021-12-07 20:06:22 +01:00
Bartłomiej Dach	8b7ed759e3	Merge branch 'master' into beatmap-card/scale-on-hover	2021-12-07 19:11:01 +01:00
Dan Balasescu	86eacfdbd8	Merge pull request #15879 from peppy/multiplayer-delayed-playlist-load-broken ... Load playlist panels on demand to reduce initial load time when joining a room	2021-12-08 00:42:20 +09:00
Dean Herbert	25a0505c97	Scale card when expanding to better distinguish hovered card from other cards in listing	2021-12-07 23:48:14 +09:00
Dean Herbert	d6e68feadc	Merge pull request #15948 from bdach/beatmap-card/difficulty-dropdown ... Add difficulty dropdown to beatmap card	2021-12-07 23:40:06 +09:00
Dan Balasescu	7e236c3a41	Remove unused dependency	2021-12-07 23:36:48 +09:00
Dan Balasescu	52230a6f00	Merge branch 'master' into multiplayer-delayed-playlist-load-broken	2021-12-07 22:45:05 +09:00
Dean Herbert	a8c20368c0	Merge pull request #15976 from smoogipoo/add-modes-to-room-panels ... Add match type and queue mode to multiplayer room panels	2021-12-07 22:08:30 +09:00
Dan Balasescu	4683193f09	Move implementation to base class	2021-12-07 20:36:39 +09:00
Dan Balasescu	5ffe702dd6	Add match type and queue mode to multiplayer room panels	2021-12-07 18:57:13 +09:00
Dean Herbert	9978caab12	Update framework	2021-12-07 18:37:30 +09:00
Dean Herbert	dea7f2308c	Fix participant panels potentially keeping a reference to an old user ... If a user leave and then rejoins a multiplayer match while another user is not at the lobby screen, there is a potential the `ParticipantPanel` tracking the user will not correctly be recreated to reference the new instance of the `MultiplayerUser`. This happens because the `OnRoomUpdated` call is scheduled, which means it is not running in the background, coupled with the local logic that relies on `IEquatable(MultiplayerRoomUser)` (which in turn falls back to a UserID comparison). Changing this to a reference comparison is the easiest way to resolve this. Whether we change the `IEquatable` implementation is up for discussion. Closes https://github.com/ppy/osu/issues/15970.	2021-12-07 17:24:04 +09:00
Dean Herbert	cfa712473d	Use default timeout in GetPlayableBeatmap when provided CancellationToken is default	2021-12-07 13:33:41 +09:00
Dean Herbert	f3e9fb76fc	Add the ability to pass a CancellationToken through DifficultyCalculator.CalculateAll ... Was weirdly missing from this one method.	2021-12-07 13:32:47 +09:00
tbrose	882223b27f	Using static call and verbatim symbol and optimizes regex pattern for username check	2021-12-07 02:38:10 +01:00
tbrose	b6d47a41f4	Adjusted RegEx pattern to also take special characters into account	2021-12-07 02:14:40 +01:00
Salman Ahmed	974987550f	Move API request response size log to correct logging target	2021-12-07 04:01:56 +03:00
tbrose	7a0d4fca17	Fixes using Matches+Count instead of IsMatch negatively affecting performance	2021-12-07 01:41:21 +01:00
tbrose	f02e44d552	Fixes not matching coding style	2021-12-07 01:38:48 +01:00
tbrose	39594b7362	Fixes detection of mentioning of user falsely detects messages where the username is coincidentally contained in words of a message.	2021-12-06 23:32:21 +01:00
tbrose	0a6c221de4	Adds tests for checkContainsUsername function of MessageNotifier component	2021-12-06 22:07:47 +01:00
Bartłomiej Dach	999bba439f	Clarify usages of reverse child ID flow with inline comments	2021-12-06 21:02:40 +01:00
Bartłomiej Dach	82ed8eae6b	Ensure hover handling container always calls base on hover events	2021-12-06 21:02:40 +01:00
Bartłomiej Dach	ccfc361626	Apply naming suggestions	2021-12-06 21:02:38 +01:00
Bartłomiej Dach	4278a320e4	Fix skin setting resetting every launch ... The reason this was happening was an unfortunate oversight in the migration logic. The code that was attempting to parse the skin settings as `int` was firing regardless of whether a skin migration from EF to realm had already occurred. If it had occurred, the skin setting would contain a GUID rather than an integer, and therefore fail to parse, and therefore implicitly fallback to a EF skin ID of 0 which would be the default skin. Fix by not running the setting migrating logic at all when there are no EF skins to migrate.	2021-12-06 20:12:02 +01:00
Dan Balasescu	d5cdb1bb87	Update test multiplayer client implementation	2021-12-07 00:01:07 +09:00
Dean Herbert	3e27859e4f	Update framework	2021-12-06 22:47:07 +09:00
Dan Balasescu	7ef960839b	Merge pull request #15898 from peppy/skin-export-instntiation-info ... Serialise and deserialise `SkinInfo.InstantiationInfo` to allow for more correct imports	2021-12-06 22:08:20 +09:00
Dean Herbert	9033169177	Merge pull request #15951 from peppy/fix-failing-recorder-tests-w ... Fix intermittent test failures in scenes using `SpectatorClient`	2021-12-06 18:40:27 +09:00
Dean Herbert	07abcf04b4	Merge branch 'master' into realm-integration/skins-filename-lookup-performance	2021-12-06 17:13:33 +09:00
Dean Herbert	68b482fc48	Merge branch 'master' into skin-export-instntiation-info	2021-12-06 17:12:42 +09:00
Dean Herbert	cf34b3f70e	Merge pull request #15859 from peppy/realm-integration/skins-rebase ... Use realm for skins	2021-12-06 17:12:23 +09:00
Dean Herbert	7a333ffdcc	Add a paired schedule in SpectatorClient.BeginPlaying ... Optimally, I would like to remove the `Schedule` in `EndPlaying`, but it turns out quite a few test are relying on this at very least. Adding a paired schedule ensure that order of operations is correct, at least.	2021-12-06 17:07:19 +09:00
Dan Balasescu	310e503b85	Merge pull request #15950 from peppy/fix-incorrect-match-current-beatmap ... Ensure user is returned to the `RoomSubScreen` before gameplay is started	2021-12-06 16:34:46 +09:00
Dan Balasescu	991becdfa7	Merge branch 'master' into realm-integration/skins-rebase	2021-12-06 16:34:31 +09:00
Dean Herbert	a13067eaa4	Merge pull request #15929 from smoogipoo/update-test-multiplayer-client ... Update test multiplayer client to match server implementation	2021-12-06 15:57:08 +09:00
Dean Herbert	452fa93444	Merge branch 'master' into realm-integration/skins-rebase	2021-12-06 15:21:02 +09:00
Dan Balasescu	fae41b2182	Remove one more piece of code	2021-12-06 15:17:33 +09:00
Dan Balasescu	5be74af8fe	Update addItem() implementation	2021-12-06 15:09:06 +09:00
Dean Herbert	0ea7a69084	Ensure user is returned to the RoomSubScreen before gameplay is started ... This covers the scenario where a user may be at the song select screen while another user (the room host) starts the match. This was only made possible with the new queue modes, so is quite a recent regression.	2021-12-06 14:03:52 +09:00
Dean Herbert	a76cfbea21	Add test coverage of incorrect beatmap being used in multiplayer when match started from song select	2021-12-06 14:03:33 +09:00
Dean Herbert	ca1f96d2c2	Reword xmldoc of MultiplayerPlaylistItem.PlaylistOrder to better match actual behaviour	2021-12-06 13:03:14 +09:00
Dean Herbert	5ff452cc9a	Update success bool to access Exception to stop exceptions from firing outwards	2021-12-06 12:29:11 +09:00
Dean Herbert	91aa38c4f6	Change playlist lookup to fail hard when failing	2021-12-06 12:28:48 +09:00
Bartłomiej Dach	0f74389389	Add scrolling for long difficulty lists in beatmap card	2021-12-05 20:17:59 +01:00
Bartłomiej Dach	af35652b8b	Disable beatmap card expansion on solo spectator screen	2021-12-05 20:07:58 +01:00
Bartłomiej Dach	af10223ac4	Add reverse fill flows & depth specs at usage sites for correct Z-ordering	2021-12-05 20:07:46 +01:00
Bartłomiej Dach	e451e43b90	Implement input handling behaviour of beatmap card dropdown	2021-12-05 16:31:45 +01:00
Bartłomiej Dach	250e5b47b7	Move "extra info" beatmap card row to separate component	2021-12-05 15:52:19 +01:00
Bartłomiej Dach	3fea8d5e62	Implement visual behaviour of expanded card state	2021-12-05 15:48:02 +01:00
Bartłomiej Dach	a07f8c74dc	Add basic structure for composable card dropdown	2021-12-05 15:26:37 +01:00
ColdVolcano	81215b9f0e	Use correct effect points when EarlyActivationMilliseconds is not zero	2021-12-04 22:31:55 -06:00
Bartłomiej Dach	504210a6cd	Merge branch 'master' into multiplayer-room-composite-event-debounce-fix	2021-12-04 17:50:32 +01:00
Dean Herbert	e1897f9998	Don't debounce MultiplayerRoomComposite events ... This avoids accidental usage which could result in data being lost or ignored (as only the last `user` in a single frame would arrive). This was added specifically to debounce sample playback, but given that it's only debouncing on a single frame (hardly noticeable) I'm not going to add back support for that yet. It should be handled by sample playback concurrency or something more local to the usage.	2021-12-05 01:38:39 +09:00
Bartłomiej Dach	f051720fa1	Fix score encoder being dependent on current culture ... As it turns out, on some cultures, the "negative integer" sign is not encoded using the U+002D HYPHEN-MINUS codepoint. For instance, Swedish uses U+2212 MINUS SIGN instead. This was confusing the legacy decoder, since it is correctly depending on the serialisation being culture-independent. To fix, ensure that the special "end replay" frame, as well as the replay MD5 hash, are generated in a culture-invariant manner. Thankfully the replay MD5 hash is currently being discarded in `LegacyScoreDecoder`, so it changing in future scores should not have any negative effect on lazer operation.	2021-12-04 17:13:43 +01:00
Bartłomiej Dach	38702beabf	Merge branch 'master' into i-ruleset-store	2021-12-04 15:05:39 +01:00
Bartłomiej Dach	53a6ef22ce	Add null check to resolve inspection	2021-12-04 14:55:35 +01:00
Dan Balasescu	85d3b70d8c	Update test multiplayer client to match server-side	2021-12-04 22:34:38 +09:00
Bartłomiej Dach	b3b239c9a1	Fix test failures due to beatmap lookup logic being active even when model is populated	2021-12-04 13:59:01 +01:00
Dean Herbert	517a344bcc	Merge branch 'master' into new-multiplayer-playlist	2021-12-04 13:16:09 +09:00
Dan Balasescu	f4e07f1483	Merge branch 'master' into diffcalc-cli-arg	2021-12-03 20:34:59 +09:00
Dan Balasescu	d5803e541b	Give playlist items a PlayedAt date	2021-12-03 20:25:51 +09:00
Dan Balasescu	4145a16d5b	Merge pull request #15920 from peppy/clean-up-unused-resolves ... Clean up unused resolved properties	2021-12-03 20:08:48 +09:00
Dan Balasescu	e350c68b5f	Merge pull request #15918 from peppy/volume-adjust-during-gameplay-alt-exception ... Fix alt-scroll not adjusting volume in gameplay when scroll wheel is disabled	2021-12-03 19:09:20 +09:00
Dean Herbert	1eed2436e6	Clean up unused resolved properties	2021-12-03 18:49:49 +09:00
Dean Herbert	2acf46154a	Remove many unused resolutions of RulesetStore	2021-12-03 18:16:29 +09:00
Dean Herbert	e75e209053	Cache and consume IRulesetStore where feasible	2021-12-03 18:16:01 +09:00
Dean Herbert	15db1372aa	Add missing equality implementations on IRulesetInfo	2021-12-03 18:01:45 +09:00
Dean Herbert	675ecb603f	Add IRulesetStore to allow for transitional usage in upcoming manager classes	2021-12-03 17:57:40 +09:00
Dean Herbert	6b73672403	Stop Player from blocking volume adjust when Alt it held ... Similar case to what we already have in `OsuScrollContainer`, so there is precedent for handling this locally in this fashion.	2021-12-03 17:18:07 +09:00
Dean Herbert	aaa46960b3	Reword mouse wheel disable setting to better explain its purpose	2021-12-03 17:18:07 +09:00
Dan Balasescu	9d6fe558c2	Update TestMultiplayerClient with expired item ordering	2021-12-03 17:01:33 +09:00
Dan Balasescu	487a71312e	Split out code so base methods aren't called	2021-12-03 16:40:20 +09:00
Dean Herbert	e4b296e16e	Use OptIn serialisation on SkinInfo to avoid writing unnecessary information	2021-12-03 16:36:27 +09:00
Dean Herbert	dad5b06e84	Avoid sending empty parameters in GetBeatmapRequest	2021-12-03 16:23:39 +09:00
Dan Balasescu	0a1304b92a	Remove gameplay_order, use existing playlist_order	2021-12-03 15:45:13 +09:00
Dean Herbert	9c717ce7ec	Merge branch 'master' into diffcalc-cli-arg	2021-12-03 15:10:55 +09:00
Dan Balasescu	b75a5b778e	Update history list to also sort by gameplay order	2021-12-03 15:05:56 +09:00
Dan Balasescu	1d2d1bfcf3	Add UpdatedAt to MultiplayerPlaylistItem	2021-12-03 15:05:56 +09:00
Dean Herbert	9803e63e6f	Update IPC usage to return null	2021-12-03 14:30:15 +09:00
Dean Herbert	6142566974	Update resources	2021-12-03 14:26:53 +09:00
Dean Herbert	abf7735b84	Update framework	2021-12-03 14:18:03 +09:00
Dan Balasescu	806ca5d4de	Update TestMultiplayerClient implementation to match server	2021-12-02 22:58:12 +09:00
Dan Balasescu	933fd49cff	Fix missed callbacks due to AddOnce() schedules	2021-12-02 22:33:14 +09:00
Dan Balasescu	9760a2b087	Update MultiplayerQueueList to take advantage of GameplayOrder	2021-12-02 22:33:14 +09:00
Dan Balasescu	ba8af303cc	Add GameplayOrder to MultiplayerPlaylistItem	2021-12-02 22:33:14 +09:00
Dean Herbert	cdf2fa9930	Serialise and deserialise SkinInfo.InstantiationInfo to allow for more correct imports ... Until now, skins were always imported using the `LegacySkin` instantiation type. For cases where a user has edited the lazer or classic default (via the new skin editor), which would result in incorrect fallback paths after exporting and importing the edited skin.	2021-12-02 18:05:16 +09:00
Dean Herbert	0e82e9355b	Ensure skin is saved immediately after becoming mutable ... Without doing this, the JSON content is not written to the file. A user assumption is that as soon as a skin shows up in the skin list as exportable, it should export correctly, so it makes sense that it should be in a sane state even if the user has not made any changes in the skin editor yet. Going forward, we might move more of the json serialisation logic out, and run for consistency as part of the import process. This seems like the simplest way to guarantee things for now, though.	2021-12-02 17:42:17 +09:00
Dean Herbert	fe99d4e984	Standardise parameter naming across all file IO methods	2021-12-02 17:19:53 +09:00
Dean Herbert	ae3038ead4	Overwrite existing files if AddFile is called with an existing filename	2021-12-02 17:18:06 +09:00
Dean Herbert	512818648f	Add some more breathing room between tab control and queue content	2021-12-02 16:56:30 +09:00
Dean Herbert	5976982b12	Add missing xmldoc for MultiplayerClient events	2021-12-02 16:45:26 +09:00
Dan Balasescu	c00684a2f7	Merge branch 'master' into new-multiplayer-playlist	2021-12-02 16:19:34 +09:00
Dean Herbert	bdddaba352	Remove unnecessary test request handling	2021-12-02 14:33:56 +09:00
Dean Herbert	624ec4580a	Ensure updateLocalRoomSettings is only called after full population	2021-12-02 14:32:39 +09:00
Dean Herbert	505608ab12	Merge branch 'realm-integration/skins-rebase' into realm-integration/skins-filename-lookup-performance	2021-12-02 14:01:39 +09:00
Dean Herbert	e855a49833	Add test coverage of default skin edit and export	2021-12-02 14:01:18 +09:00
Dean Herbert	0a14acfd83	Fix incorrect conditional on export/mutate feasability of skin	2021-12-02 13:41:58 +09:00
Dean Herbert	65f0a80c97	Merge branch 'master' into realm-integration/skins-rebase	2021-12-02 13:37:20 +09:00
Dean Herbert	c82195390f	Update usage of SubscribeForNotifications	2021-12-02 13:24:16 +09:00
Dean Herbert	9483a3013c	Merge branch 'master' into realm-integration/skins-filename-lookup-performance	2021-12-02 13:20:56 +09:00
Dean Herbert	4f826589e5	Remove subscription logic for the time being	2021-12-02 12:20:07 +09:00
Bartłomiej Dach	8bef50cbba	Revert "Refactor migration precondition to read better" ... Realm cannot translate `.All()` LINQ queries. This reverts commit 0e0e8c25e8.	2021-12-01 19:39:44 +01:00
Dean Herbert	caa88950da	Merge pull request #15889 from smoogipoo/fix-multi-test-ids ... Fix testable online IDs starting at 0	2021-12-01 22:51:24 +09:00
Dean Herbert	a8e17cb3a5	Add relative size specs so partially on-screen panels still start loading ... Without this, panels at the top of the list but not fully on-screen wouldn't begin their metadata loading process.	2021-12-01 22:46:38 +09:00
Dean Herbert	d262baefad	Only query for the owner user metadata in the case it is actually required	2021-12-01 22:43:32 +09:00
Dean Herbert	a0ff86f5e8	Ensure all read and write operations on APIRoom are done on the update thread	2021-12-01 22:43:03 +09:00
Dan Balasescu	e5e2ae8ab4	Fix dangling line post-rebase	2021-12-01 21:36:25 +09:00
Dan Balasescu	89c47708a1	Merge branch 'master' into new-multiplayer-playlist	2021-12-01 21:35:23 +09:00
Dan Balasescu	e87b0003fb	Fix queue mode not being bound to in all cases	2021-12-01 21:35:23 +09:00
Dan Balasescu	ad35f3434b	Fix queue list not considering expired items	2021-12-01 21:35:23 +09:00
Dan Balasescu	e2f289eeff	Xmldocs	2021-12-01 21:35:23 +09:00
Dan Balasescu	93a7726f4a	Remove now-unused parameter	2021-12-01 21:35:23 +09:00
Dan Balasescu	d70355237d	Fix selected item not bound	2021-12-01 21:35:23 +09:00
Dan Balasescu	c3dfe10a8a	Add new list to match subscreen	2021-12-01 21:35:22 +09:00
Dan Balasescu	1152c4e8e9	Fix tests	2021-12-01 21:35:22 +09:00
Dan Balasescu	7847ce6253	Redesign with tab control	2021-12-01 21:35:22 +09:00
Dan Balasescu	95050d6597	Extract class to file	2021-12-01 21:35:22 +09:00
Dan Balasescu	fc8c8685b8	Add playlist queue tests	2021-12-01 21:35:22 +09:00
Dan Balasescu	e0ca1af9b8	Remove ctor params	2021-12-01 21:35:22 +09:00
Dan Balasescu	bfd2dc28c8	Rename QueueList -> MultiplayerQueueList	2021-12-01 21:35:22 +09:00
Dan Balasescu	6b198ce112	Document simulation	2021-12-01 21:35:22 +09:00
Dan Balasescu	ef170471f0	Merge branch 'master' into new-multiplayer-playlist	2021-12-01 21:35:22 +09:00
Dan Balasescu	9806c75743	Implement better round robin algorithm	2021-12-01 21:35:12 +09:00
Dan Balasescu	68bb49fc1e	Add QueueList tests	2021-12-01 21:33:48 +09:00
Dan Balasescu	0cb35e8b18	Separate out QueueList	2021-12-01 21:33:48 +09:00
Dan Balasescu	17bc0b51aa	Merge branch 'playlist-item-add-owner' into new-multiplayer-playlist	2021-12-01 21:33:48 +09:00
Dan Balasescu	942e48ffbd	Merge branch 'master' into new-multiplayer-playlist	2021-12-01 21:33:11 +09:00
Dan Balasescu	c38537a51a	Initial implementation of MultiplayerPlaylist	2021-12-01 21:32:56 +09:00
Dan Balasescu	42ad726154	Merge branch 'master' into multiplayer-delayed-playlist-load-broken	2021-12-01 20:28:29 +09:00
Dan Balasescu	685bdd522e	Replace 'skin' in comments with 'instance'	2021-12-01 20:17:38 +09:00
Dan Balasescu	c225f8f84c	Merge branch 'master' into realm-subscribe-helper-methods	2021-12-01 20:15:21 +09:00
Dan Balasescu	af704dfe5b	Merge pull request #15878 from peppy/beatmap-lookup-cache ... Cache beatmap metadata lookups used by multiplayer	2021-12-01 20:13:21 +09:00
Dan Balasescu	7224f6bac5	Fix testable online IDs starting at 0	2021-12-01 20:00:31 +09:00
Dean Herbert	bf5a186a2b	Add early abort to avoid sending empty lookup requests	2021-12-01 17:47:16 +09:00
Dean Herbert	81f82c24c3	Use new API endpoint to do batch lookups	2021-12-01 17:45:41 +09:00
Dean Herbert	09817ff161	Add missing returns additional documentation to main method call	2021-12-01 15:27:10 +09:00
Dean Herbert	4306420922	Add extension methods to add extra safety to realm subscriptions ... Also adjusts the naming and documentation to make it (hopefully) easier to understand what this method/process implies.	2021-12-01 15:09:53 +09:00
Dean Herbert	1cf1543866	Fix test failures due to attempting to subscribe to non-managed instances	2021-12-01 13:50:19 +09:00
Dean Herbert	ea66cd6c5e	Add xmldoc and make realm ongoing transaction file op methods protected instead of public	2021-12-01 12:55:21 +09:00
Dean Herbert	8ce7467e97	Fix ordering of skins in dropdown being reverse of expected	2021-12-01 12:50:47 +09:00
Dean Herbert	0e0e8c25e8	Refactor migration precondition to read better	2021-12-01 12:48:49 +09:00
Dean Herbert	370135d484	Remove outdated TODO	2021-12-01 12:47:32 +09:00
Dean Herbert	fb2310f826	Specify config file default as DEFAULT_SKIN's guid	2021-12-01 12:45:47 +09:00
Dan Balasescu	7d0135063e	Merge pull request #15875 from peppy/fix-match-type-propagation ... Fix match type not being propagated correctly to other users' settings	2021-12-01 11:23:28 +09:00
Dean Herbert	9411b42d0a	Cache skin filename to path mapping to reduce realm lookups during gameplay skin changes	2021-12-01 02:27:41 +09:00
Dean Herbert	03e1305b3f	Fix toast display potentially causing a child mutation before load complete	2021-12-01 01:55:17 +09:00
Dean Herbert	bba985e0e5	Merge branch 'beatmap-lookup-cache' into multiplayer-delayed-playlist-load-broken	2021-11-30 20:09:52 +09:00
Dean Herbert	0fae10500a	Fix failing tests	2021-11-30 20:09:45 +09:00
Dean Herbert	ef3d0ee0db	Merge branch 'master' into realm-integration/skins-rebase	2021-11-30 19:59:59 +09:00
Dan Balasescu	857e559f87	Merge pull request #15877 from peppy/log-response-sizes ... Log output API request response sizes	2021-11-30 19:58:29 +09:00
Dean Herbert	e4ba66877d	Improve transitions when loading new data into a playlist panel	2021-11-30 19:54:26 +09:00
Dean Herbert	fe119da044	Add fetching of beatmap and user data when playlist panels come on screen	2021-11-30 19:52:36 +09:00
Bartłomiej Dach	95373649a4	Skip null items in star rating range display	2021-11-30 19:44:50 +09:00
Bartłomiej Dach	695167a749	Add support for null item display in DrawableRoomPlaylistItem	2021-11-30 19:44:50 +09:00
Bartłomiej Dach	23dd21339d	Delay online fetch of non-current playlist item on room join	2021-11-30 19:44:50 +09:00
Dean Herbert	01bc330d1c	Rename method to match new purpose	2021-11-30 19:42:46 +09:00
Dean Herbert	f58c5cd9c0	Update MultiplayerClient to use BeatmapLookupCache	2021-11-30 19:36:25 +09:00
Dean Herbert	87883f1fe4	Add BeatmapLookupCache	2021-11-30 19:28:45 +09:00
Dean Herbert	23e297d414	Log output response sizes ... Visibility is the first step towards action. Or something.	2021-11-30 19:09:13 +09:00
Dan Balasescu	8fdb9ab4e5	Merge branch 'master' into realm-integration/live-queryable-fix	2021-11-30 18:54:14 +09:00
Dan Balasescu	daa7135381	Merge branch 'master' into realm-nested-context-creation-deadlock-fix	2021-11-30 18:01:00 +09:00
Dean Herbert	25b9575de0	Fix missing transfer of match type to settings	2021-11-30 17:09:40 +09:00
Dean Herbert	e83ada40f9	Merge branch 'realm-nested-context-creation-deadlock-fix' into realm-integration/skins-rebase	2021-11-30 15:56:34 +09:00
Dean Herbert	1ff0326f8e	Merge branch 'master' into realm-integration/skins-rebase	2021-11-30 15:50:10 +09:00
Dean Herbert	6f66ecd77b	Move migrations to own file and add user skin choice config migration	2021-11-30 15:41:18 +09:00
Dean Herbert	0efd565c8b	Remove forgotten using statement	2021-11-30 15:41:07 +09:00
Dean Herbert	a943089be2	Add support for migration of skins from EF to Realm	2021-11-30 15:17:26 +09:00
Dean Herbert	6bf9327228	Add linking property on SkinFileInfo to allow EF to understand the link post-rename	2021-11-30 15:17:16 +09:00
Dean Herbert	6e4cd91b7b	Fix update thread realm context never being Refresh()ed	2021-11-30 14:12:36 +09:00
Dean Herbert	384a0664c2	Remove unused migration method	2021-11-30 14:05:44 +09:00
Dean Herbert	f921acc681	Fix chat tab dropdown not being reachable at default sizing ... Would have liked to fix this in a more local way, but the structure of the dropdowns is just a pain in the ass to work with, so this will do for now.	2021-11-30 13:01:46 +09:00
Dean Herbert	6b0999052f	Merge branch 'master' into realm-integration/live-queryable-fix	2021-11-30 12:02:37 +09:00
Dean Herbert	f3f77fa053	Update missed xmldoc/comments	2021-11-30 11:56:53 +09:00
Dean Herbert	35d68d6ab0	Remove all optimisations from RealmLive	2021-11-30 11:47:29 +09:00
Bartłomiej Dach	45656c3599	Fix difficulty spectrum display not ordering ruleset groups by ID	2021-11-29 22:06:11 +01:00
Bartłomiej Dach	0fc4d6dc2a	Implement beatmap card difficulty list	2021-11-29 22:04:09 +01:00
Dan Balasescu	823552a5e8	Merge pull request #15856 from peppy/simplify-replace-file ... Remove the ability to specify a filename in `ReplaceFile`	2021-11-29 20:49:38 +09:00
Dan Balasescu	0ee524a72f	Merge pull request #15857 from peppy/realm-importer-remove-pointless-fast-hash ... Remove `computeHashFast` usage in `RealmArchiveModelImporter.ComputeHash`	2021-11-29 18:58:40 +09:00
Dan Balasescu	8a188b74b1	Merge pull request #15850 from peppy/realm-integration/misc-qol ... Apply a couple of realm related documentation/interface changes	2021-11-29 18:58:15 +09:00
Dean Herbert	0bcfb8e199	Fix regression in implementation of fix	2021-11-29 18:52:29 +09:00
Dean Herbert	6877867467	Make default fallback logic more robust	2021-11-29 18:28:25 +09:00
Dean Herbert	0d18c83d75	Simplify deletion by adding always present conditionals to Delete method	2021-11-29 18:28:25 +09:00
Dean Herbert	f6a3709060	Store default skins to database	2021-11-29 18:28:25 +09:00
Dean Herbert	c629a7a36f	Fix random selection and avoid using legacy events for handling skin import/deletion	2021-11-29 18:28:25 +09:00
Dean Herbert	29d074bdb8	Implement missing behaviours required for skin file operations via RealmArchiveModelManager	2021-11-29 18:28:25 +09:00
Dean Herbert	e2d9a685d7	Update skin implementations to match new structures	2021-11-29 18:28:25 +09:00
Dean Herbert	744a5b33f5	Rewrite SkinSection to use realm subscriptions and databased defaults	2021-11-29 18:28:25 +09:00
Dean Herbert	6b55de2845	Use ILive for Skin.SkinInfo	2021-11-29 18:28:25 +09:00
Dean Herbert	cd0c811ab1	Add the ability to call ToString on a RealmLive to get the underlying object's implementation	2021-11-29 18:28:25 +09:00
Dean Herbert	5db7cf23d3	Add pending deletion skin cleanup	2021-11-29 18:28:25 +09:00
Dean Herbert	23146d59d1	Use ILive for current skin	2021-11-29 18:28:25 +09:00
Dean Herbert	2a9c7c00c8	Update tests and file access code	2021-11-29 18:28:25 +09:00
Dean Herbert	3db5646fa8	Create Guid constants for system skins (and store skin choice to configuration as guid)	2021-11-29 18:28:25 +09:00
Dean Herbert	e283379f0e	Replace EF SkinInfo with realm implementation	2021-11-29 18:28:25 +09:00
Dean Herbert	5f067172b4	Add model class for realm skin	2021-11-29 18:28:25 +09:00
Dean Herbert	0a961fd9d8	Replace usages of IHasFiles with IHasRealmFiles	2021-11-29 18:28:25 +09:00
Dean Herbert	348d1d0be9	Don't dispose fetched realm instance when using RealmLive.Value ... See https://github.com/realm/realm-dotnet/discussions/2734#discussioncomment-1705038 for reasoning.	2021-11-29 18:28:25 +09:00
Dean Herbert	1dd5e1ca89	Remove RealmLive context re-fetch optimisation for now	2021-11-29 18:28:25 +09:00
Dean Herbert	c411a755c7	Merge branch 'realm-nested-context-creation-deadlock-fix' into realm-integration/compiled	2021-11-29 18:28:07 +09:00
Dean Herbert	0f1712a272	Merge branch 'realm-importer-remove-pointless-fast-hash' into realm-integration/compiled	2021-11-29 18:28:05 +09:00
Dean Herbert	29f1ad10ba	Merge branch 'realm-integration/misc-qol' into realm-integration/compiled	2021-11-29 18:28:03 +09:00
Dean Herbert	1cfcd33b07	Merge branch 'simplify-replace-file' into realm-integration/compiled	2021-11-29 18:28:02 +09:00
Dean Herbert	23fded4a3a	Fix potential oversight in semaphore release logic	2021-11-29 18:26:37 +09:00
Dean Herbert	94b10492be	Update legacy SkinManager to match new interface	2021-11-29 18:20:07 +09:00
Dean Herbert	6aad90674e	Remove computeHashFast usage in RealmArchiveModelImporter.ComputeHash	2021-11-29 18:13:27 +09:00
Dean Herbert	a7e4e7be3a	Remove the ability to specify a filename in ReplaceFile	2021-11-29 18:11:51 +09:00
Dean Herbert	f19cfcc82e	Make readonly	2021-11-29 17:38:54 +09:00
Dean Herbert	673481ebc5	Use ThreadLocal to avoid potential threading issues	2021-11-29 17:38:42 +09:00
Dean Herbert	6dcc244e21	Fix RealmLive not working is data is attached to realm post-ToLive call	2021-11-29 17:34:58 +09:00
Dean Herbert	c98451a7bf	Fix potential deadlock on nested context creation requests	2021-11-29 16:29:53 +09:00
Dean Herbert	2ee08b5f4c	Fix undelete on existing not committing transaction	2021-11-29 14:48:31 +09:00
Dean Herbert	cb8fa80352	Don't dispose fetched realm instance when using RealmLive.Value ... See https://github.com/realm/realm-dotnet/discussions/2734#discussioncomment-1705038 for reasoning.	2021-11-29 14:25:43 +09:00
Dean Herbert	e40e5096ea	Remove RealmLive context re-fetch optimisation for now	2021-11-29 14:25:43 +09:00
Dean Herbert	3bd4872520	Add note about indexing support for RealmNamedFileUsage.Filename	2021-11-29 14:12:22 +09:00
Dean Herbert	21e8ab8357	Return ILive from ToLive calls instead of realm-typed instance	2021-11-29 14:12:22 +09:00
MK56	d2e11ea622	Merge branch 'ppy:master' into positional-sounds-strength-adjustment	2021-11-28 16:19:49 +01:00
Bartłomiej Dach	93b5aec23e	Fix realm migration failures when upgrading from old versions ... * `RealmRulesetSetting` was added in 2021.916.0. * `RealmKeyBinding` was added in 2021.703.0. Attempting to upgrade from older releases than the above would cause migrations up to schema versions 10 and 11 to fail.	2021-11-28 15:00:40 +01:00
Dan Balasescu	0d147b4ad9	Return null IPC response for archive imports	2021-11-28 22:59:53 +09:00
mk-56	cd095b5f7d	Merge remote-tracking branch 'origin/positional-sounds-strength-adjustment' into positional-sounds-strength-adjustment	2021-11-28 14:21:26 +01:00
mk-56	9c42cc0c05	Fix	2021-11-28 14:12:39 +01:00
mk-56	9065179c52	Fix	2021-11-28 14:09:30 +01:00
mk-56	c3fb793762	Fixed the problems that were brought up and deleted the old bind logic	2021-11-28 14:06:53 +01:00
Dan Balasescu	e5dcfc3113	Use console IPC	2021-11-28 14:03:21 +09:00
mk-56	ff9c68dd6a	cleanup	2021-11-28 03:28:35 +01:00
mk-56	74a16f233f	Merge remote-tracking branch 'origin/positional-sounds-strength-adjustment' into positional-sounds-strength-adjustment	2021-11-28 03:25:58 +01:00
mk-56	e83115ad5e	Binding logic fix, nullification of unnecessary path	2021-11-28 03:25:11 +01:00
MK56	753c1c7fea	Merge branch 'ppy:master' into positional-sounds-strength-adjustment	2021-11-28 02:59:36 +01:00
mk-56	eaa464e548	Initial implementation of adjustable positional hitobject audio strength	2021-11-28 02:58:08 +01:00
Dean Herbert	51a7c60eec	Merge pull request #15835 from bdach/off-thread-transforms-unbind ... Fix instances of components adding off-thread transforms on unbind	2021-11-28 09:27:43 +09:00
Bartłomiej Dach	db49d99cc0	Ensure correct disabled ruleset callback scheduling in ruleset selector	2021-11-27 15:28:23 +01:00
Bartłomiej Dach	05f7ea6b6d	Remove mentions of "panel" and "direct" from names of old download buttons	2021-11-27 15:08:03 +01:00
Bartłomiej Dach	a043d1e427	Move old beatmap download button to more general namespace	2021-11-27 15:06:57 +01:00
Bartłomiej Dach	251ab183a0	Move beatmap play button nearer its only remaining usage	2021-11-27 15:04:05 +01:00
Bartłomiej Dach	7419682334	Move icon pill to beatmap card-specific namespace	2021-11-27 15:01:48 +01:00
Bartłomiej Dach	6773877a40	Remove no-longer-used beatmap panels	2021-11-27 15:00:06 +01:00
Bartłomiej Dach	f4b7db5a7b	Ensure correct disabled beatmap callback scheduling in now playing overlay	2021-11-27 14:36:34 +01:00
Dean Herbert	0a75067ee5	Update framework	2021-11-27 12:13:39 +09:00
Dean Herbert	d570054b8c	Merge pull request #15801 from smoogipoo/playlist-item-add-owner ... Add owner avatar to multiplayer playlist items	2021-11-27 00:30:35 +09:00
Dan Balasescu	2cc06a6ae1	Merge pull request #15820 from peppy/fix-track-owner-log ... Fix incorrect logging of preview tracks without track owner	2021-11-27 00:25:54 +09:00
Dean Herbert	b8a47755fa	Don't show loading tooltip for now ... Should probably be replaced with a loading spinner in the future, don't really like "loading" tooltips.	2021-11-26 22:54:11 +09:00
Dean Herbert	d5d1a4c0b5	Merge branch 'master' into playlist-item-add-owner	2021-11-26 22:43:08 +09:00
Dean Herbert	f16ef1ee69	Reapply schedule workaround for PreviewTrack	2021-11-26 22:34:05 +09:00
Dean Herbert	7f9cc4d5ff	Fix incorrect logging of preview tracks without track owner	2021-11-26 21:37:43 +09:00
Dean Herbert	89b4e5cffb	Rename mass deletion confirmation dialog	2021-11-26 18:18:45 +09:00
Dan Balasescu	e1445dcb05	Only show owner in match subscreen	2021-11-26 17:40:45 +09:00
Dan Balasescu	e9a19aacd7	Fix tests by requiring host	2021-11-26 17:23:50 +09:00
Dan Balasescu	8be2defd09	Right-align avatar	2021-11-26 17:17:06 +09:00
Dan Balasescu	8541db1e85	Merge branch 'master' into playlist-item-add-owner	2021-11-26 17:13:23 +09:00
Dan Balasescu	c7f905f8da	Merge pull request #15813 from peppy/beatmap-card/download-spinner ... Show a spinner instead of the download button on the new card during beatmap download	2021-11-26 16:35:58 +09:00
Dan Balasescu	5e53f51c99	Merge pull request #15812 from peppy/realm-live-unmanaged-fetch-fix ... Avoid attempting to fetch a non-managed `RealmLive` instance from the realm backing	2021-11-26 15:37:58 +09:00
Dean Herbert	bf443a5a7a	Switch unnecessary return to break instead	2021-11-26 15:36:16 +09:00
Dean Herbert	5de2f6211d	Show a spinner instead of the download button on the new card during beatmap download	2021-11-26 15:32:33 +09:00
Dean Herbert	8e16ff7f72	Merge pull request #15807 from bdach/beatmap-card/integration ... Replace existing usages of beatmap panel with new beatmap card	2021-11-26 15:31:55 +09:00
Dean Herbert	40d1b97af1	Avoid attempting to fetch a non-managed RealmLive instance from the realm backing ... For compatibility reasons, we quite often convert completely unmanaged instances to `ILive`s so they fit the required parameters of a property or method call. This ensures such cases will not cause any issues when trying to interact with the underlying data. Originally I had this allowing write operations, but that seems a bit unsafe (when performing a write one would assume that the underlying data is being persisted, whereas in this case it is not). We can change this if the requirements change in the future, but I think throwing is the safest bet for now.	2021-11-26 15:06:14 +09:00
Dean Herbert	13612c0d02	Add equality support to ILive types	2021-11-26 14:56:16 +09:00
Dean Herbert	1d96542a2a	Fix incorrect ConfigureAwait specification causing stalled test ... This only occurs on upcoming changes I have (occurred when switching existing skin import tests across to realm). Unsure why it was set to `true`, seems like a weird oversight.	2021-11-26 12:47:43 +09:00
Bartłomiej Dach	a188d6662f	Use beatmap card in solo spectator screen	2021-11-25 22:31:02 +01:00
Bartłomiej Dach	ec2265d5bb	Use beatmap cards in spotlights layout	2021-11-25 22:30:47 +01:00
Bartłomiej Dach	42b09fd1ec	Use beatmap cards in user profile overlay	2021-11-25 22:30:47 +01:00
Bartłomiej Dach	0f9ebe3d5d	Use beatmap cards in beatmap listing overlay	2021-11-25 22:30:46 +01:00
Bartłomiej Dach	84a36ab4a9	Add integration with beatmap set overlay	2021-11-25 22:30:46 +01:00
Dan Balasescu	1f5d95666e	Add owner avatar to multiplayer items	2021-11-25 23:15:29 +09:00
Dean Herbert	7a3c69544b	Merge pull request #15799 from smoogipoo/fix-songselect-test-failures-2 ... Fix SongSelect-related test failures	2021-11-25 23:01:06 +09:00
Dan Balasescu	7c91cd674e	Update test classes to set owner ids	2021-11-25 22:17:18 +09:00
Dan Balasescu	8a941fa422	Add owner id to PlaylistItem	2021-11-25 21:41:03 +09:00
Dan Balasescu	09dd054283	Fix SongSelect-related test failures	2021-11-25 21:11:13 +09:00
Dan Balasescu	f712aeee01	Merge pull request #15795 from peppy/realm-integration/separate-download-flow ... Split out download logic from main manager classes	2021-11-25 20:59:23 +09:00
Dan Balasescu	d7a960212f	Merge pull request #15794 from peppy/realm-integration/stable-export-flow ... Split out legacy model export logic into `LegacyModelExporter` classes	2021-11-25 20:20:18 +09:00
Dan Balasescu	8baf00c023	Remove unused using	2021-11-25 19:36:06 +09:00
Dan Balasescu	2b85738384	Merge pull request #15797 from peppy/remove-pointless-i-beatmap-model-manager ... Remove pointless interface class for `IBeatmapModelManager`	2021-11-25 19:07:19 +09:00
Dan Balasescu	d3a4890c31	Merge branch 'master' into realm-integration/stable-export-flow	2021-11-25 19:06:18 +09:00
Dean Herbert	e2ebcf7a26	Remove unnecessary manager parameter ... Confused why I added this in the first place..	2021-11-25 18:36:03 +09:00
Dean Herbert	a6ee0eec0d	Remove pointless interface class for IBeatmapModelManager ... Was originally going to be used but serves no purpose any more.	2021-11-25 18:15:10 +09:00
Dean Herbert	eeccf836ec	Remove unnecessary GameHost parameter	2021-11-25 17:42:41 +09:00
Dean Herbert	a2ab9f457d	Move score download logic out of ScoreManager	2021-11-25 17:33:04 +09:00
Dean Herbert	716543b5b3	Move beatmap download logic out of BeatmapManager	2021-11-25 17:29:41 +09:00
Dean Herbert	79459c1aeb	Fix typo in class and variable names	2021-11-25 17:12:15 +09:00
Dean Herbert	ec9a09d5a4	Add missing licence headers	2021-11-25 16:56:19 +09:00
Dean Herbert	cc1b91e4bd	Split out legacy model export logic into LegacyModelExporter classes	2021-11-25 16:41:12 +09:00
Dean Herbert	7488ccd5fe	Update all models to implement IHasNamedFiles	2021-11-25 16:41:12 +09:00
Dan Balasescu	6d60725b31	Merge branch 'master' into realm-integration/stable-import-flow	2021-11-25 16:36:02 +09:00
Dean Herbert	416ee2447a	Move archive filename helper method to extension method	2021-11-25 16:35:54 +09:00
Dan Balasescu	d8a23aad4d	Merge pull request #15791 from peppy/realm-integration/skin-model-manager ... Split out `SkinModelManager` from `SkinManager`	2021-11-25 16:35:05 +09:00
Dean Herbert	a0fa030f55	Rename base class to LegacyModelImporter	2021-11-25 16:33:04 +09:00
Dean Herbert	210dfab392	Merge pull request #15790 from peppy/realm-integration/score-manager-interface-reduction ... Reduce interface exposure of `ScoreManager`	2021-11-25 15:46:38 +09:00
Dean Herbert	2df793ca22	Inline individual importers to avoid unnecessary construction for singular import types	2021-11-25 15:44:04 +09:00
Dean Herbert	9dcb20a821	Rename Stable to Legacy and add xmldoc	2021-11-25 15:39:05 +09:00
Dean Herbert	6cab7b877d	Move stable import handling into its own class	2021-11-25 15:36:58 +09:00
Dean Herbert	2bfc473689	Split out SkinModelManager from SkinManager	2021-11-25 15:14:43 +09:00
Dean Herbert	60b207f20a	Reduce interface exposure of ScoreManager	2021-11-25 14:34:13 +09:00
Dean Herbert	bcdb73e1e8	Clean up files last	2021-11-25 14:28:27 +09:00
Dean Herbert	315e126497	Add automatic clean-up call for RealmFileStore	2021-11-25 14:17:44 +09:00
Dean Herbert	204bd2b604	Ensure Cleanup can run from non-update thread and add basic log output	2021-11-25 14:17:44 +09:00
Dean Herbert	fd321109da	Remove unnecessary virtual specification on Refresh	2021-11-25 14:06:12 +09:00
Dean Herbert	306e13fa7b	Remove all usages of FileStore.QueryFiles	2021-11-25 14:06:02 +09:00
Dean Herbert	1533e245de	Merge pull request #15767 from bdach/beatmap-card/track-preview ... Add preview track playback function to beatmap card	2021-11-25 12:08:03 +09:00
Bartłomiej Dach	20f71da2c4	Merge branch 'master' into fix-mp-resuming	2021-11-24 20:17:58 +01:00
Dan Balasescu	1865227e08	Merge pull request #15773 from peppy/remove-model-file-list-inits ... Initialise `IHasFiles<TFile>.Files` lists at construction time	2021-11-24 21:05:36 +09:00
Dan Balasescu	016684b52d	Remove unreachable code	2021-11-24 20:29:47 +09:00
Dan Balasescu	132bb59203	Update working beatmap when returning to match	2021-11-24 19:56:02 +09:00
Dan Balasescu	ce8500a732	Merge branch 'master' into remove-model-file-list-inits	2021-11-24 19:46:42 +09:00
Dean Herbert	b739b6a725	Merge branch 'master' into beatmap-card/track-preview	2021-11-24 18:54:25 +09:00
Dean Herbert	61009013cc	Give a more correct default value to beatmap and set statuses	2021-11-24 18:48:12 +09:00
Dean Herbert	052ed8f930	Add online status to RealmBeatmapSet	2021-11-24 18:48:02 +09:00
Dean Herbert	183b95cbc2	Rename BeatmapSetOnlineStatus to BeatmapOnlineStatus ... This variable is used at more than just a set level.	2021-11-24 18:42:49 +09:00
Dean Herbert	ddbd4f9473	Merge branch 'master' into remove-model-file-list-inits	2021-11-24 18:39:01 +09:00
Dan Balasescu	5ff62a8e04	Merge pull request #15779 from peppy/remaining-misc-fixes ... Apply some various code quality fixes that don't fit elsewhere	2021-11-24 16:59:49 +09:00
Dan Balasescu	74b6c33fab	Merge pull request #15778 from peppy/ruleset-info-id-usage ... Update usages of `RulesetInfo.ID` to use `OnlineID` instead	2021-11-24 16:55:28 +09:00
Dan Balasescu	834bdd8e5c	Merge pull request #15776 from peppy/non-null-beatmapset-metadata ... Make `BeatmapSet.Metadata` non-null	2021-11-24 16:48:28 +09:00
Dan Balasescu	8ce5324c8b	Merge pull request #15772 from peppy/remove-model-list-inits ... Initialise `BeatmapSet.Beatmaps` list at construction time	2021-11-24 16:41:19 +09:00
Dean Herbert	2dabedebff	Remove unnecessary user assign in HitObjectSampleTest	2021-11-24 16:30:00 +09:00
Dean Herbert	3e0e01abdb	Move bookmark parsing logic into LegacyBeatmapDecoder	2021-11-24 16:29:51 +09:00
Dean Herbert	9c61ec217b	Remove unnecessary mainTrackMixer parameter from BeatmapManager	2021-11-24 16:27:17 +09:00
Dan Balasescu	2ec3fb2e9e	Merge pull request #15760 from peppy/realm-move-data-migration-to-context-factory ... Move realm data migrations inside the `RealmContextFactory`	2021-11-24 16:23:56 +09:00
Dean Herbert	bbd3ea5b77	Update all actual usages of RulesetInfo.ID to use OnlineID instead	2021-11-24 15:50:26 +09:00
Dean Herbert	f283770f34	Update mock RulesetInfo usage to set OnlineID instead of ID	2021-11-24 15:50:26 +09:00
Dean Herbert	e57c343531	Add helper setter to EF RulesetInfo.OnlineID to allow updating usages	2021-11-24 15:50:26 +09:00
Dan Balasescu	33d95fbb9c	Merge pull request #15771 from peppy/ruleset-config-cache-shortname ... Update `RulesetConfigCache` to cache via `ShortName` instead of `ID`	2021-11-24 15:24:57 +09:00
Dan Balasescu	73e50af9cc	Merge pull request #15775 from peppy/update-framework ... Update framework	2021-11-24 15:24:43 +09:00
Dean Herbert	cb093e1e01	Remove reundant self-sets of metadata	2021-11-24 15:08:04 +09:00
Dean Herbert	3946a39b65	Make BeatmapSet.Metadata non-null	2021-11-24 15:03:34 +09:00
Dan Balasescu	c4b5a07f4b	Merge branch 'master' into realm-move-data-migration-to-context-factory	2021-11-24 14:40:26 +09:00
Dean Herbert	a7853fc9cc	Fix cases of known-non-null	2021-11-24 14:26:25 +09:00
Dean Herbert	ec89dfa043	Update framework	2021-11-24 14:09:25 +09:00
Dean Herbert	0aedbbe165	Fix incorrect fallback logic causing test failure	2021-11-24 14:04:55 +09:00
Dean Herbert	c2f8d9f677	Update tests which set Files lists directly	2021-11-24 14:00:14 +09:00
Dean Herbert	99a139dc98	Initialise all file lists at construction time (and remove setter)	2021-11-24 13:56:21 +09:00
Dan Balasescu	5a0a95f9d4	Trim whitespace	2021-11-24 13:48:59 +09:00
Dan Balasescu	84268c3d85	Merge branch 'master' into realm-ruleset-keybinding-short-name	2021-11-24 13:48:48 +09:00
Dan Balasescu	6183d1cd46	Merge pull request #15769 from peppy/model-equality-consistency ... Update cases where equality can be used instead of primary key equality	2021-11-24 13:45:57 +09:00
Dan Balasescu	6ffba8a546	Merge pull request #15768 from peppy/standardise-ruleset-create-instance ... Remove nullability of `Ruleset.CreateInstance`	2021-11-24 13:43:23 +09:00
Dean Herbert	a3fdab34d5	Avoid json serialisation of aggregate helper properties ... Also avoids `throw`ing when there are no beatmaps available. Until now this wasn't an issue due to the `Beatmaps` list being null instead of empty.	2021-11-24 13:36:34 +09:00
Dean Herbert	8c60f37508	Fix cases of dynamically assigning Beatmaps to BeatmapSetInfo using list assignment	2021-11-24 13:27:37 +09:00
Dean Herbert	49c2cb9125	Initialise BeatmapSet.Beatmaps list to line up with realm expectations	2021-11-24 13:25:55 +09:00
Dean Herbert	ee22c24370	Update RulesetConfigCache to cache via ShortName instead of ID	2021-11-24 13:10:18 +09:00
Dean Herbert	729f681938	Update cases where equality can be used instead of primary key equality	2021-11-24 12:49:57 +09:00
Dean Herbert	6aed41eacc	Merge branch 'master' into realm-move-data-migration-to-context-factory	2021-11-24 12:38:44 +09:00
Dean Herbert	63b09b356f	Rewrite commments to read better	2021-11-24 12:37:09 +09:00
Dean Herbert	6cd1bfd94f	Remove outdated comment	2021-11-24 12:35:05 +09:00
Dean Herbert	0eea026afb	Remove null checks on CreateInstance() calls	2021-11-24 12:23:09 +09:00
Dean Herbert	8d69ebd7db	Remove nullability of Ruleset.CreateInstance	2021-11-24 12:23:06 +09:00
Dean Herbert	049f25a133	Merge pull request #15757 from smoogipoo/fix-multiplayer-tests ... Fix several intermittent multiplayer test failures	2021-11-24 09:32:01 +09:00
Bartłomiej Dach	1a1603f0db	Implement preview track playback	2021-11-23 23:17:30 +01:00
Bartłomiej Dach	9164f006aa	Implement basic behaviour of play button	2021-11-23 22:44:09 +01:00
Bartłomiej Dach	5d13686cdf	Add play button for card preview	2021-11-23 22:44:08 +01:00
Bartłomiej Dach	4011da033b	Split off thumbnail to separate component	2021-11-23 22:44:07 +01:00
Bartłomiej Dach	0d409fa33e	Merge branch 'master' into realm-ruleset-keybinding-short-name	2021-11-23 20:18:58 +01:00
Bartłomiej Dach	fa96b29d6b	Merge branch 'master' into realm-ruleset-setting-short-name	2021-11-23 19:44:41 +01:00
Dean Herbert	6b134359c9	Handle the case where the ruleset isn't found in the EF database any more	2021-11-23 19:15:52 +09:00
Dean Herbert	4149d458f0	Move realm data migrations inside the RealmContextFactory	2021-11-23 18:14:15 +09:00
Dean Herbert	d9917ee6c7	Merge branch 'realm-ruleset-setting-short-name' into realm-ruleset-keybinding-short-name	2021-11-23 18:13:26 +09:00
Dean Herbert	40cd998f99	Fix incorrect disposal	2021-11-23 18:13:05 +09:00
Dan Balasescu	79a8e60468	Resolve inspection	2021-11-23 17:55:04 +09:00
Dean Herbert	782191c410	Merge branch 'realm-ruleset-setting-short-name' into realm-ruleset-keybinding-short-name	2021-11-23 17:48:48 +09:00
Dean Herbert	b1b6723826	Add xmldoc and verbatim string markers	2021-11-23 17:47:43 +09:00
Dean Herbert	505fede44d	Pass the full EF context rather than a legacy RulesetStore	2021-11-23 17:40:20 +09:00
Dan Balasescu	fd4d5e98a7	Merge pull request #15745 from bdach/settings-number-box-stack-overflow ... Fix crashes on trying to play back replays of seeded mods with seed value over 1 billion	2021-11-23 16:36:05 +09:00
Dan Balasescu	b7510697c8	Merge pull request #15753 from peppy/osu-test-scene-isolation-clean-up ... Restructure how the headless storage is used / documented to hopefully make more sense	2021-11-23 16:29:39 +09:00
Dan Balasescu	6363833fb3	Revert unnecessary changes	2021-11-23 16:17:09 +09:00
Dan Balasescu	1f13669636	Don't poll while in room ... Fixes timeout in `TestJoinRoomWithoutPassword`, because the 'server' returns out-of-date data while the `MatchSubScreen` has possible not been entered yet (and thus hasn't disabled polling itself yet). Can be tested by adding a `Task.Delay(3000);` at the end of the `MultiplayerClient.JoinRoom()` task.	2021-11-23 16:14:01 +09:00
Dan Balasescu	69a9fc9732	Fix a few more multiplayer test timeouts ... These can be tested by adding a `Task.Delay(3000);` at the end of the `MultiplayerClient.JoinRoom` task. The reason is typically that `Client.Room` becomes not-null but the join task still hasn't completed yet, so e.g. the ready button is still disabled.	2021-11-23 16:07:03 +09:00
Dan Balasescu	7906ae2b1d	Update room immediately on join	2021-11-23 16:03:37 +09:00
Dean Herbert	6fb2757739	Remove usage of Nuget.Packaging extension methods for IList.AddRange	2021-11-23 15:02:02 +09:00
Dean Herbert	0989d6a92e	Merge branch 'realm-ruleset-setting-short-name' into realm-ruleset-keybinding-short-name	2021-11-23 14:55:40 +09:00
Dean Herbert	f264b128c2	Merge branch 'master' into realm-ruleset-setting-short-name	2021-11-23 14:55:36 +09:00
Dean Herbert	473f6b0347	Add more xmldoc	2021-11-23 14:17:24 +09:00
Dean Herbert	55f7d120e6	Rename and reorder fields in OsuTestScene	2021-11-23 14:13:14 +09:00
Dean Herbert	5631e75f16	Restructure how the headless storage is used / documented to hopefully make more sense	2021-11-23 14:11:27 +09:00
Dean Herbert	49e2a8afa3	Don't directly reset the database when running tests ... The containing storage is destroyed anyway, so this is redundant.	2021-11-23 14:08:04 +09:00
Dean Herbert	feb983d5bd	Rename Debug namespace to avoid collisions	2021-11-23 13:09:41 +09:00
Dean Herbert	53d6b3c402	Merge branch 'realm-ruleset-setting-short-name' into realm-ruleset-keybinding-short-name	2021-11-23 11:49:13 +09:00
Dean Herbert	1f321e2910	Run EF migrations earlier to ensure it is complete before usage	2021-11-23 11:48:58 +09:00
Dean Herbert	119ac19f86	Merge branch 'master' into realm-beatmap-file-relation	2021-11-23 10:20:22 +09:00
Dean Herbert	e580fc5abc	Merge pull request #15735 from peppy/remove-ruleset-info-inheritance ... Remove subclassing of `RulesetInfo`	2021-11-23 10:18:32 +09:00
Bartłomiej Dach	1ec5dd2cdf	Merge branch 'master' into realm-beatmap-file-relation	2021-11-22 21:53:08 +01:00
Bartłomiej Dach	4a9f080f3c	Accept full range of int in SettingsNumberBox ... This fixes stack overflow exceptions that would arise when a `Current.Value` of 1 billion or more was set on a `SettingsNumberBox`. The stack overflow was caused by the "maximum 9 digits" spec. If a value technically within `int` bounds, but larger than 1 billion (in the range [1,000,000,000; 2,147,483,647], to be more precise), a feedback loop between the setting control's `Current` and its inner text box's `Current` would occur, wherein the last digit would be trimmed and then re-appended again forevermore. To resolve, remove the offending spec and rely on `int.TryParse` entirely to be able to discern overflow range. Additionally, UX of the text box is slightly changed to notify when the `int` range is exceeded with a red flash. This behaviour would not have been possible to implement without recent framework-side fixes to text box (removal of text set scheduling).	2021-11-22 20:49:14 +01:00
Dan Balasescu	fba9e360a1	Merge branch 'master' into ruleset-use-short-name	2021-11-22 23:56:34 +09:00
Dan Balasescu	7ce5cb6162	Merge pull request #15739 from peppy/realm-migration-ordering ... Fix realm applying migrations from one version too early	2021-11-22 23:52:50 +09:00
Dean Herbert	6c36770eb3	Add back allowance for tests scenes using empty ShortName	2021-11-22 21:41:09 +09:00
Dean Herbert	d94b27a8a2	Switch realm ruleset key bindings to use ruleset's ShortName as key	2021-11-22 18:52:30 +09:00
Dean Herbert	329bae50b0	Switch realm ruleset configuration to use ruleset's ShortName as key	2021-11-22 18:52:00 +09:00
Dean Herbert	ca26b6c540	Provide RealmContextFactory with the EF RulesetStore for migration purposes	2021-11-22 18:51:44 +09:00
Dean Herbert	d2062ff97f	Reformat realm migrations list for legibility	2021-11-22 18:47:18 +09:00
Dean Herbert	361cb78880	Fix realm applying migrations from one version too early	2021-11-22 18:46:46 +09:00
Dean Herbert	f1926c6d27	Store preferred ruleset to configuration using ShortName instead of ID	2021-11-22 17:45:31 +09:00
Dean Herbert	377ba2673a	Use Ruleset's ShortName for mod caching purposes	2021-11-22 16:52:54 +09:00
Dean Herbert	a8bc1ab052	Attempt to fix fody issues by ignoring new property	2021-11-22 16:45:55 +09:00
Dean Herbert	cb5b6911e6	Seal RulesetInfo and remove virtual methods	2021-11-22 16:39:26 +09:00
Dean Herbert	b9923e5396	Remove subclassing of RulesetInfo	2021-11-22 16:39:17 +09:00
Dan Balasescu	0633f3bcfe	Add owner id to playlist items	2021-11-22 16:35:58 +09:00
Dean Herbert	1cdfa6d9a0	Add helper property to access a realm beatmap's beatmap file	2021-11-22 15:30:11 +09:00
Dean Herbert	ff13a98077	Reformat realm migrations list for legibility	2021-11-22 15:23:16 +09:00
Dan Balasescu	f64d20ed71	Fix APIRoom queue mode not updated on change	2021-11-22 13:46:01 +09:00
Dean Herbert	bbb3abbc61	Merge branch 'master' into multi-queueing-modes	2021-11-22 12:32:47 +09:00
Dan Balasescu	f3ba62d2c2	Add xmldoc to serverSidePlaylist	2021-11-22 11:26:41 +09:00
Dan Balasescu	10dc08a855	Store server-side playlist instead of mutating client-side version	2021-11-22 11:18:21 +09:00
Dan Balasescu	6420971660	Adjust test client with new queue-changing logic	2021-11-22 11:10:10 +09:00
Dan Balasescu	4b498c7bd6	Merge branch 'master' into multi-queueing-modes	2021-11-22 07:46:45 +09:00
Bartłomiej Dach	975744d26c	Remove no longer used [Cached] attribute	2021-11-21 13:19:16 +01:00
Dean Herbert	c0962b1c4f	Merge branch 'master' into beatmap-card/download-button	2021-11-21 20:04:26 +09:00
Bartłomiej Dach	aaf3f3854e	Merge branch 'master' into fix-working-beatmap-wrong-exception-type	2021-11-21 11:32:29 +01:00
Bartłomiej Dach	bb8e8bc4f0	Use consistent type for mod collection in all overloads	2021-11-21 11:30:45 +01:00
Dean Herbert	8c72f4843d	Merge pull request #15684 from frenzibyte/fix-ios-online ... Fix MessagePack workaround formatter potentially initializing on iOS	2021-11-21 16:02:08 +09:00
Dean Herbert	63642450a4	Merge branch 'master' into fix-working-beatmap-wrong-exception-type	2021-11-21 15:50:07 +09:00
Dan Balasescu	49de22ebba	Merge pull request #15711 from peppy/fix-skill-memory-leak ... Stop persisting `Skill`s in `DifficultyAttributes`	2021-11-21 15:47:49 +09:00
Dan Balasescu	a06b361fe2	Merge pull request #15705 from bdach/fix-difficulty-cache-caching-zeroes ... Fix zero star difficulty values being cached when diffcalc was interrupted	2021-11-21 15:45:29 +09:00
Salman Ahmed	af01b0ed48	BASE_DERIVED -> BASE_TYPE_MAPPING	2021-11-21 06:30:14 +03:00
Dean Herbert	fd3e5d333e	Add xmldoc note about Skill potentially being memory expensive	2021-11-21 12:15:32 +09:00
Dean Herbert	9f688f6291	Stop persisting Skills in DifficultyAttributes	2021-11-21 12:15:32 +09:00
Salman Ahmed	915bde6f96	Remove unnecessary MatchServerEvent mapping	2021-11-21 06:09:45 +03:00
Bartłomiej Dach	65cb011bac	Merge branch 'master' into beatmap-card/download-button	2021-11-20 18:49:11 +01:00
Bartłomiej Dach	297de27a6a	Use BindTarget from card rather than caching & resolving download tracker	2021-11-20 18:48:26 +01:00
Bartłomiej Dach	b3606f4a21	Rename {Play -> GoToBeatmap}Button	2021-11-20 18:36:39 +01:00
Bartłomiej Dach	78ee213573	Merge branch 'master' into storage-path-extension-method	2021-11-20 18:21:46 +01:00
Bartłomiej Dach	a7e45a9098	Log all non-cancellation errors in difficulty cache	2021-11-20 17:32:40 +01:00
Bartłomiej Dach	6100bf66a6	Clean up cancellation handling in WorkingBeatmap ... After the recent changes introducing cancellation support to `WorkingBeatmap`, it turned out that if the cancellation support was used, `GetPlayableBeatmap()` would raise timeout exceptions rather than the expected `OperationCanceledException`. To that end, split off a separate overload for the typical usage, that catches `OperationCanceledException` and converts them to beatmap load timeout exceptions, and use normal `OperationCanceledException`s in the overload that requires a cancellation token to work.	2021-11-20 17:23:55 +01:00
Bartłomiej Dach	15feb17da8	Change difficulty cache storage type to nullable ... The recent changes related to adding support for working beatmap load cancellation exposed a flaw in the beatmap difficulty cache. With the way the difficulty computation logic was written, any error in the calculation process (including beatmap load timeout, or cancellation) would result in a 0.00 star rating being permanently cached in memory for the given beatmap. To resolve, change the difficulty cache's return type to nullable. In failure scenarios, `null` is returned, rather than `default(StarDifficulty)` as done previously.	2021-11-20 17:00:50 +01:00
Salman Ahmed	8b28bf31f6	Separate SignalR workaround types away from resolver	2021-11-20 15:11:02 +03:00
Dean Herbert	e0629ba81c	Update all dependencies	2021-11-20 13:31:10 +09:00
Salman Ahmed	0342923408	Fix SignalR messagepack formatter potentially initializing on iOS	2021-11-19 20:04:31 +03:00
Dean Herbert	83b4625bd5	Replace existing cases with new helper method	2021-11-19 22:15:41 +09:00
Dean Herbert	eecf6ad558	Add IsManaged helper method to EF classes to match realm implementation	2021-11-19 21:56:06 +09:00
Dan Balasescu	d397524878	Merge pull request #15676 from peppy/multiplayer-incorrect-beatmap-error ... Show better error message when selecting an unavailable beatmap during multiplayer room creation	2021-11-19 18:59:46 +09:00
Dan Balasescu	de0e8ad822	Merge branch 'master' into multi-queueing-modes	2021-11-19 18:58:15 +09:00
Dan Balasescu	4c8c34b43f	Use full name for round robin	2021-11-19 18:42:34 +09:00
Dan Balasescu	4e625b78e2	Update queue mode names	2021-11-19 18:28:43 +09:00
Dan Balasescu	f3f8ac2c43	Use single	2021-11-19 16:36:32 +09:00
Dan Balasescu	abb8b0de47	Also mutate multiplayer room playlist on callbacks	2021-11-19 16:35:45 +09:00
Dean Herbert	59e763467f	Move StoragePath implementation to an extension method	2021-11-19 16:08:38 +09:00
Dan Balasescu	12e1142b07	Rename settings section	2021-11-19 15:47:40 +09:00
Dan Balasescu	a922ce2fd9	Remove unnecessary nameofs	2021-11-19 15:45:45 +09:00
Dean Herbert	6e5918a100	Add slight scale to icon buttons	2021-11-19 15:28:03 +09:00
Dean Herbert	741c27c1f2	Always populate action to make button behave better in testing scenarios	2021-11-19 15:27:38 +09:00
Dean Herbert	5034cb1025	Merge branch 'master' into beatmap-card/download-button	2021-11-19 14:59:42 +09:00
Dean Herbert	0c289bf8e5	Remove pointless namespace	2021-11-19 14:46:53 +09:00
Dean Herbert	284e554cbf	Only show user displayable portion of server errors when seleting a song in multiplayer	2021-11-19 13:58:03 +09:00
Dean Herbert	c901a4fd7e	Show better error message when selecting an unavailable beatmap during multiplayer room creation	2021-11-19 13:28:42 +09:00
Dean Herbert	77c0b8dfa9	Fix stray typo	2021-11-19 13:27:06 +09:00
Dean Herbert	cb2547a6be	Merge branch 'master' into multi-queueing-modes	2021-11-19 13:20:57 +09:00
Dan Balasescu	6ebe54b183	Merge pull request #15494 from Tollii/beatmap-cancellation-token ... Add support for cancellation tokens for beatmap difficulty calculation	2021-11-19 10:54:32 +09:00
Bartłomiej Dach	0eaf450204	Make field readonly	2021-11-18 22:50:41 +01:00
Bartłomiej Dach	8a1d6757af	Merge branch 'master' into beatmap-card/download-button	2021-11-18 22:37:35 +01:00
Bartłomiej Dach	412abf30d9	Refactor buttons again to work with latest design guidelines	2021-11-18 22:34:40 +01:00
Bartłomiej Dach	761d1e45f2	Use lime background on right side of card to signify downloaded sets	2021-11-18 21:36:41 +01:00
Dean Herbert	bf8507c7b9	Only apply default timeout when debugger not attached	2021-11-18 23:26:45 +09:00
Joseph Madamba	a09589f833	Fix score panels sometimes jumping when toggling statistics fast	2021-11-17 23:15:51 -08:00
Dan Balasescu	698b6c4242	Merge pull request #15668 from peppy/key-repeat ... Update `KeyBindingContainer` usage to block key repeat where applicable	2021-11-18 15:21:35 +09:00
Dan Balasescu	1dacc50ecb	Merge branch 'master' into multi-queueing-modes	2021-11-18 15:16:27 +09:00
Dean Herbert	9ec6ecd3f6	Update framework	2021-11-18 13:39:25 +09:00
Dean Herbert	1fdf0e9770	Merge branch 'master' into supporter-icon-link	2021-11-18 13:36:14 +09:00
Dean Herbert	db4e4c982c	Add hover effect to supporter button	2021-11-18 13:35:42 +09:00
Dean Herbert	cdb2a92f86	Disable key repeat for all ruleset handling cases	2021-11-18 13:13:36 +09:00
Dean Herbert	66c307e0ee	Remove usage of key repeat helper method	2021-11-18 13:13:36 +09:00
Dean Herbert	7599efac30	Update editor cases where repeat should not be handled	2021-11-18 13:13:36 +09:00
Dean Herbert	3de8125eac	Update UI cases where repeat should not be handled	2021-11-18 13:13:36 +09:00
Dean Herbert	5fb5e0035c	Merge pull request #15657 from smoogipoo/expose-calculate-accuracy ... Expose LegacyScoreDecoder.PopulateAccuracy()	2021-11-18 11:33:25 +09:00
Joseph Madamba	cd5e379c48	Link osu!supporter icon to its web page	2021-11-17 14:43:34 -08:00
Bartłomiej Dach	1c13b39104	Revert incorrect ordering change	2021-11-17 22:10:46 +01:00
Bartłomiej Dach	8b134914cf	Merge branch 'master' into beatmap-cancellation-token	2021-11-17 21:52:30 +01:00
Dan Balasescu	e4aec3f519	Merge pull request #15648 from peppy/playlist-show-invalid-beatmaps ... Highlight invalid playlist items during room creation	2021-11-17 22:24:22 +09:00
Dan Balasescu	860546bf63	Merge pull request #15634 from peppy/i-working-beatmap/simple-cases ... Update all simple cases of switching to `IWorkingBeatmap`	2021-11-17 22:08:27 +09:00
Dean Herbert	214705f1e5	Adjust error message, take 2	2021-11-17 21:11:37 +09:00
Dan Balasescu	5fb5baa4c9	Adjust error message	2021-11-17 21:06:33 +09:00
Dean Herbert	7c2e79f911	Update all simple cases of switching to IWorkingBeatmap	2021-11-17 20:56:57 +09:00
Dean Herbert	fd0cae2bfb	Merge branch 'master' into difficulty-attribute-helpers	2021-11-17 20:49:31 +09:00
Dean Herbert	0a7498014f	Move consts to top of file	2021-11-17 20:47:52 +09:00
Dan Balasescu	9182eab486	Rename method + xmldoc	2021-11-17 20:45:48 +09:00
Dan Balasescu	815179f713	Use consts for attribute IDs	2021-11-17 20:31:18 +09:00
Dan Balasescu	abb333299b	Document base class	2021-11-17 20:20:54 +09:00
Dan Balasescu	08f129b4c8	Expose LegacyScoreDecoder.CalculateAccuracy()	2021-11-17 20:09:30 +09:00
Dean Herbert	96e983bbad	Disallow playlist item selection at playlist room creation screen ... Wasn't being used for anything, confusing that it's even possible.	2021-11-17 14:40:07 +09:00
Dan Balasescu	97bc67245d	Fix xmldoc reference	2021-11-17 11:46:06 +09:00
Dan Balasescu	f5b95c9e6d	Add ModUtils helper to instantiate mods from ruleset	2021-11-17 11:30:47 +09:00
Dean Herbert	8e9b55ef6d	Disallow selection of invalid items	2021-11-17 11:28:43 +09:00
Dean Herbert	0715d40ea0	Merge branch 'master' into beatmap-cancellation-token	2021-11-17 11:16:10 +09:00
Dean Herbert	13f3e2eea9	Add back default timeout to GetPlayableBeatmap	2021-11-17 11:06:31 +09:00
Dan Balasescu	0146987eba	Merge pull request #15650 from peppy/fix-stand-alone-chat-textbox-corners ... Fix `StandAloneChatDisplay`'s `TextBox` having different corner radius	2021-11-16 20:45:08 +09:00
Dan Balasescu	843b0f9641	Merge pull request #15649 from peppy/fix-leaderboard-cancellation-failure ... Fix song select leaderboard potentially displaying outdated or incorrect content	2021-11-16 19:10:48 +09:00
Dean Herbert	f74afb48fd	Fix StandAloneChatDisplay's TextBox having different corner radius	2021-11-16 17:50:57 +09:00
Dan Balasescu	f9e3d9bb92	Merge branch 'master' into i-working-beatmap/difficulty-calculator	2021-11-16 17:46:38 +09:00
Dean Herbert	2dd721f760	Fix incorrect CancellationToken being used for inner check during leaderboard updates	2021-11-16 17:41:16 +09:00
Dean Herbert	6dd684588a	Merge branch 'master' into playlist-show-invalid-beatmaps	2021-11-16 17:25:33 +09:00
Dean Herbert	2d125893fc	Add tests and disable selection on invalid items	2021-11-16 17:23:52 +09:00
Dan Balasescu	96dddc8a0b	Merge pull request #15627 from peppy/playlist-item-iruleset ... Update `PlaylistItem` to use `IRulesetInfo`	2021-11-16 17:15:09 +09:00
Dean Herbert	6f82e6351f	Parse osu-web error text to present invalid items to the user in a more approachable format	2021-11-16 17:14:15 +09:00
Dean Herbert	e78c5d0858	Show loadingLayer before calling CreateRoom ... This fixes `TestScenePlaylistsMatchSettingsOverlay` incorrectly leaving the loading layer visible.	2021-11-16 17:14:15 +09:00
Dean Herbert	aa188d5a52	Add ability for playlist items to be marked as invalid	2021-11-16 17:01:24 +09:00
Dan Balasescu	f6ae0ec715	Merge pull request #15642 from peppy/external-update-provider ... Add update manager which performs no update action	2021-11-16 16:59:33 +09:00
Dean Herbert	49cdcffa30	Simplify schedule logic in DrawableRoomPlaylistItem	2021-11-16 16:58:44 +09:00
Dean Herbert	f5c52755c9	Merge branch 'master' into i-working-beatmap/difficulty-calculator	2021-11-16 16:19:22 +09:00
Dan Balasescu	ddf2fade1a	Merge branch 'master' into playlist-item-iruleset	2021-11-16 16:19:10 +09:00
Dan Balasescu	c8038df509	Fix CI inspections	2021-11-16 16:06:30 +09:00
Dan Balasescu	00f0321f25	Add nullable equality comparers	2021-11-16 15:44:47 +09:00
Dean Herbert	726a0cc091	Merge branch 'master' into beatmap-collection-inteface-types	2021-11-16 15:31:10 +09:00
Dan Balasescu	29d0d5badf	Rename QueueModes -> QueueMode	2021-11-16 14:53:10 +09:00
Dan Balasescu	5c3141d16a	Fix ready button tooltip showing when locally available	2021-11-16 14:48:52 +09:00
Dean Herbert	d2a7670494	Remove no longer used helper method	2021-11-16 14:48:02 +09:00
Dean Herbert	6cca657a2d	Standardise naming of CancellationToken parameters	2021-11-16 14:45:51 +09:00
Dan Balasescu	01f3649d75	Rename variables for readability	2021-11-16 14:44:47 +09:00
Dean Herbert	53c0682a08	Merge branch 'master' into beatmap-cancellation-token	2021-11-16 14:43:13 +09:00
Dan Balasescu	f414877d00	Rename UserID -> OwnerID	2021-11-16 14:37:54 +09:00
Dan Balasescu	41e46f158f	Fix tests following playlist changes ... Also more closely follows the server implementation.	2021-11-16 14:37:33 +09:00
Dean Herbert	71fef241df	Fix recursive equality call on APIBeatmap and APIBeatmapSet	2021-11-16 14:13:47 +09:00
Dan Balasescu	9076519710	Give MultiplayerRoom a playlist, remove RequestAllPlaylistItems()	2021-11-16 14:13:43 +09:00
Dean Herbert	2cbdac91ad	Add missing APIUser comparison method	2021-11-16 12:44:20 +09:00
Dean Herbert	fbc46941fa	Add type safety to MatchesOnlineID extension methods	2021-11-16 12:37:47 +09:00
Dean Herbert	68e2699043	Fix oversight in playlist matching logic	2021-11-16 12:35:18 +09:00
Dean Herbert	9207b87b76	Add back interface equality but limit to only matching types	2021-11-16 12:35:18 +09:00
Dean Herbert	3fe89293af	Add update manager which performs no update action ... This is to be used in cases where updates are handled by an external means. See https://github.com/flathub/flathub/pull/2619#issuecomment-969731305 for initial usage.	2021-11-16 12:11:13 +09:00
Dan Balasescu	f0593115b2	Remove RemovePlaylistItem() server method for the time being	2021-11-16 12:08:53 +09:00
Dan Balasescu	459e819a5d	Update todo	2021-11-16 00:50:23 +09:00
Dan Balasescu	d27edb3a25	Fix another potential crash from async load	2021-11-16 00:31:46 +09:00
Dan Balasescu	b9e38269e3	Prevent playlist mangling selection if not allowed	2021-11-16 00:31:46 +09:00
Dan Balasescu	8e014ca17a	Reverse in-match playlist	2021-11-16 00:31:46 +09:00
Dan Balasescu	eb983ed548	Fix potential crash from playlist updating during async load	2021-11-16 00:02:38 +09:00
Dan Balasescu	f743a3647f	Rename APIPlaylistItem -> MultiplayerPlaylistItem	2021-11-15 23:14:27 +09:00
Dan Balasescu	5a1036a96a	Merge branch 'master' into multi-queueing-modes	2021-11-15 22:46:40 +09:00
Dan Balasescu	2c45a327bb	Remove JsonIgnores, require opt-in properties	2021-11-15 19:54:35 +09:00
Dan Balasescu	1d87b47fec	Remove now-unnecessary R# disables	2021-11-15 19:40:31 +09:00
Dean Herbert	a90cfb4a2f	Implement remaining properties via implicit implementation rather than interface methods	2021-11-15 19:30:46 +09:00
Dean Herbert	fabf253381	Update difficulty calculator tests to also use IWorkingBeatmap	2021-11-15 19:16:49 +09:00
Dean Herbert	369b4ba789	Update DifficultyCalculator to take an IRulesetInfo	2021-11-15 19:16:48 +09:00
Dean Herbert	62d670a3ca	Update DifficultyCalculator to take an IWorkingBeatmap	2021-11-15 19:16:48 +09:00
Dean Herbert	960cecf3db	Merge branch 'beatmap-collection-inteface-types' into i-working-beatmap/difficulty-calculator	2021-11-15 19:16:47 +09:00
Dean Herbert	a0e25d18cd	Expose more of WorkingBeatmap via interface	2021-11-15 18:25:48 +09:00
Dan Balasescu	c8a01c35f7	Remove extra members from FromDatabaseAttributes	2021-11-15 18:11:07 +09:00
Dan Balasescu	45382a8127	Ignore some properties	2021-11-15 16:32:25 +09:00
Dean Herbert	5489b19c57	Update PlaylistItem to use IRulesetInfo	2021-11-15 16:13:03 +09:00
Dan Balasescu	0cfd6fdf04	Add to/from database mapping functions to difficulty attributes	2021-11-15 16:06:50 +09:00
Dan Balasescu	907499f73a	Add json properties to difficulty attributes	2021-11-15 16:06:29 +09:00
Dean Herbert	1988b263c6	One more missed usage..	2021-11-15 16:02:08 +09:00
Dean Herbert	73cb80d8a4	Update one more missed usage	2021-11-15 16:00:45 +09:00
Dan Balasescu	5e2ccd5c85	Merge branch 'master' into multi-queueing-modes	2021-11-15 15:26:34 +09:00
Dean Herbert	611b9fe942	Remove now unused implementations of interface equality	2021-11-15 14:50:09 +09:00
Dean Herbert	285b161da7	Update other usages of online ID comparisons to use new extension method	2021-11-15 14:44:08 +09:00
Dean Herbert	18f73b985b	Make ModelExtensions nullable enabled	2021-11-15 14:38:01 +09:00
Dean Herbert	0b4822b552	Remove newly added equality	2021-11-15 14:35:01 +09:00
Dean Herbert	a4c11e8813	Use extension method to compare online IDs	2021-11-15 14:34:50 +09:00
Dean Herbert	5471994450	Merge branch 'master' into sample-point-multiple	2021-11-15 14:13:58 +09:00
Dean Herbert	fdbb59fd1d	Merge branch 'master' into gameplay-test/share-clock-state	2021-11-15 13:49:17 +09:00
Dean Herbert	a4aa008793	Fix frequency ramping a second time incorrectly after fail	2021-11-14 14:41:17 +09:00
Bartłomiej Dach	6b4b6de554	Fix test gameplay starting in a hidden state	2021-11-13 22:11:00 +01:00
Bartłomiej Dach	2562412125	Propagate clock state from gameplay test back to editor	2021-11-13 22:11:00 +01:00
Bartłomiej Dach	d2ddc25ab3	Propagate clock state from editor to gameplay test	2021-11-13 22:10:59 +01:00
Bartłomiej Dach	9a19a516f9	Adjust spacings on sample point piece popover	2021-11-13 21:59:45 +01:00
Bartłomiej Dach	73ca1d39a2	Improve sample bank text box UX in case of multiple selection	2021-11-13 21:59:44 +01:00
Bartłomiej Dach	3fee6b0938	Add support for setting sample bank & volume for multiple objects at once	2021-11-13 21:24:59 +01:00
Bartłomiej Dach	9800cd4903	Add test coverage for sample control point piece operation	2021-11-13 18:14:50 +01:00
Dean Herbert	983d5a6cb8	Merge branch 'master' into difficulty-point-multiple	2021-11-13 23:47:12 +09:00
Bartłomiej Dach	b58fe2d80a	Restructure card to use single tracker at the top level	2021-11-13 15:39:03 +01:00
Bartłomiej Dach	c38c95b373	Merge branch 'master' into beatmap-card/download-button	2021-11-13 14:59:59 +01:00
Bartłomiej Dach	5f2a789a6d	Ensure editor clock is stopped before testing gameplay	2021-11-13 14:01:00 +01:00
Bartłomiej Dach	eb8c5292d5	Ensure editor background is dimmed after return from gameplay test	2021-11-13 13:50:57 +01:00
Bartłomiej Dach	b47c0b63f4	Tweak loader transition when testing gameplay in editor	2021-11-13 13:39:18 +01:00
Bartłomiej Dach	a5ba3bd012	Move gameplay test pieces to own namespace	2021-11-13 13:39:17 +01:00
Bartłomiej Dach	e1c28ddd76	Adjust difficulty point popover content spacing	2021-11-12 23:32:12 +01:00
Bartłomiej Dach	d567d2be97	Fix multiple issues with textbox content display ... - Sometimes would display too many decimal digits due to floating point representation errors. - Placeholder would also look wrong if text was removed during a multiple (but determinate) selection.	2021-11-12 23:32:12 +01:00
Bartłomiej Dach	e55e2a1697	Allow to adjust slider velocity on multiple objects simultaneously	2021-11-12 23:32:11 +01:00
Bartłomiej Dach	7ba93aac27	Add test coverage for difficulty point piece operation	2021-11-12 22:16:09 +01:00
Dan Balasescu	ce47f456ec	Change API for retrieving playlist items on join	2021-11-13 04:42:14 +09:00
Bartłomiej Dach	58bad0ab25	Merge branch 'master' into fix-setting-header-text-overflow	2021-11-12 20:34:07 +01:00
Bartłomiej Dach	cb2d1f3f04	Use horizontally symmetrical padding rather than margin	2021-11-12 20:28:42 +01:00
Dan Balasescu	4aaf412ac9	Ensure one non-expired item when switching to host-only	2021-11-13 03:35:41 +09:00
Dan Balasescu	dbc23e224f	Fix further test failures	2021-11-13 03:34:45 +09:00
Dan Balasescu	e31d7e8ad7	Fix new failing test	2021-11-13 02:32:20 +09:00
Dan Balasescu	867403d947	Update TestMultiplayerClient to be more in line with server	2021-11-13 01:42:54 +09:00
Dan Balasescu	25202316cc	Add user id to APIPlaylistItem	2021-11-13 00:23:35 +09:00
Leon Gebler	9000d19c9e	Update difficulty colour spectrum	2021-11-12 14:58:18 +01:00
Dan Balasescu	3b24ec3643	Merge branch 'master' into multi-queueing-modes	2021-11-12 22:16:04 +09:00
Dean Herbert	936ec5fe8f	Merge pull request #15591 from peppy/fix-android-score-imports ... Fix android score imports not working	2021-11-12 21:11:27 +09:00
Dean Herbert	9f7e2750a5	Merge branch 'master' into beatmap-collection-inteface-types	2021-11-12 19:41:29 +09:00
Bartłomiej Dach	e66b637587	Merge branch 'master' into fix-android-score-imports	2021-11-12 11:40:15 +01:00
Dean Herbert	d2d66766d4	Merge branch 'master' into songselect-audio-improvements	2021-11-12 19:40:04 +09:00
Dean Herbert	d2c1bc1072	Update resources	2021-11-12 19:33:35 +09:00
Dean Herbert	338e5a78b8	Adjust easing of logo to better match the sound ... I'm sure we can come up with something better, but giving it a bit more speed definitely feels closer to what the sound is portraying.	2021-11-12 19:30:35 +09:00