h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 19:22:54 +08:00
Code Issues Releases Wiki Activity

Fix test failures due to attempting to subscribe to non-managed instances

Browse Source
This commit is contained in:
Dean Herbert 2021-12-01 13:50:19 +09:00
parent 9411b42d0a
commit 1cf1543866
1 changed files with 18 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
osu.Game/Skinning/LegacyDatabasedSkinResourceStore.cs
View File

@ -3,6 +3,8 @@
using System;
using System.Collections.Generic;
using System.Diagnostics;
using osu.Framework.Development;
using osu.Framework.Extensions;
using osu.Framework.IO.Stores;
using osu.Game.Extensions;
@ -19,15 +21,24 @@ namespace osu.Game.Skinning
public LegacyDatabasedSkinResourceStore(SkinInfo source, IResourceStore<byte[]> underlyingStore)
: base(underlyingStore)
{
subscription = source.Files.SubscribeForNotifications((sender, changes, error) =>
// Subscribing to non-managed instances doesn't work.
// In this usage, the skin may be non-managed in tests.
if (source.IsManaged)
{
if (changes == null)
return;
// Subscriptions can only work on the main thread.
Debug.Assert(ThreadSafety.IsUpdateThread);
// If a large number of changes are made on skin files, this may be better suited to being cleared here
// and reinitialised on next usage.
initialiseFileCache(source);
});
subscription = source.Files
.AsRealmCollection().SubscribeForNotifications((sender, changes, error) =>
{
if (changes == null)
return;
// If a large number of changes are made on skin files, this may be better suited to being cleared here
// and reinitialised on next usage.
initialiseFileCache(source);
});
}
initialiseFileCache(source);
}