1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-12 10:17:32 +08:00
osu-lazer/osu.Game
Bartłomiej Dach 4a9f080f3c
Accept full range of int in SettingsNumberBox
This fixes stack overflow exceptions that would arise when a
`Current.Value` of 1 billion or more was set on a `SettingsNumberBox`.
The stack overflow was caused by the "maximum 9 digits" spec. If a value
technically within `int` bounds, but larger than 1 billion (in the range
[1,000,000,000; 2,147,483,647], to be more precise), a feedback loop
between the setting control's `Current` and its inner text box's
`Current` would occur, wherein the last digit would be trimmed and then
re-appended again forevermore.

To resolve, remove the offending spec and rely on `int.TryParse`
entirely to be able to discern overflow range. Additionally, UX of the
text box is slightly changed to notify when the `int` range is exceeded
with a red flash.

This behaviour would not have been possible to implement without recent
framework-side fixes to text box (removal of text set scheduling).
2021-11-22 20:49:14 +01:00
..
Audio Rewrite PreviewTrackManager to avoid constructing TrackBass locally 2021-11-09 17:38:12 +09:00
Beatmaps Remove no longer used [Cached] attribute 2021-11-21 13:19:16 +01:00
Collections Update BeatmapCollection to use IBeatmapInfo 2021-11-12 18:16:36 +09:00
Configuration Store preferred ruleset to configuration using ShortName instead of ID 2021-11-22 17:45:31 +09:00
Database Fix realm applying migrations from one version too early 2021-11-22 18:46:46 +09:00
Extensions Move StoragePath implementation to an extension method 2021-11-19 16:08:38 +09:00
Graphics Update UI cases where repeat should not be handled 2021-11-18 13:13:36 +09:00
Input Add keyboard shortcut to start test mode in editor 2021-11-12 14:13:11 +09:00
IO Move StoragePath implementation to an extension method 2021-11-19 16:08:38 +09:00
IPC Apply ConfigureAwait changes to game side 2021-03-08 14:36:35 +09:00
Localisation Add keyboard shortcut to start test mode in editor 2021-11-12 14:13:11 +09:00
Migrations Fix stray typo 2021-11-19 13:27:06 +09:00
Models Move StoragePath implementation to an extension method 2021-11-19 16:08:38 +09:00
Online Fix APIRoom queue mode not updated on change 2021-11-22 13:46:01 +09:00
Overlays Accept full range of int in SettingsNumberBox 2021-11-22 20:49:14 +01:00
Performance Add LocalUserPlayInfo interface to convey common information about player status 2021-08-17 16:15:47 +09:00
Properties Merge remote-tracking branch 'upstream/master' into android 2019-01-29 18:13:43 -06:00
Replays Add deep cloning support to Score/ScoreInfo/Replay 2021-07-19 14:14:28 +09:00
Rulesets Add xmldoc note about Skill potentially being memory expensive 2021-11-21 12:15:32 +09:00
Scoring Merge pull request #15705 from bdach/fix-difficulty-cache-caching-zeroes 2021-11-21 15:45:29 +09:00
Screens Merge branch 'master' into multi-queueing-modes 2021-11-22 07:46:45 +09:00
Skinning Move StoragePath implementation to an extension method 2021-11-19 16:08:38 +09:00
Stores Move StoragePath implementation to an extension method 2021-11-19 16:08:38 +09:00
Storyboards Move StoragePath implementation to an extension method 2021-11-19 16:08:38 +09:00
Tests Add xmldoc to serverSidePlaylist 2021-11-22 11:26:41 +09:00
Updater Add update manager which performs no update action 2021-11-16 12:11:13 +09:00
Users Update all simple cases of switching to IWorkingBeatmap 2021-11-17 20:56:57 +09:00
Utils Fix xmldoc reference 2021-11-17 11:46:06 +09:00
.editorconfig Add localisation license header to editorconfig 2021-08-02 11:44:10 +09:00
osu!.res And then everything became one 2017-09-19 16:06:58 +09:00
osu.Game.csproj Update all dependencies 2021-11-20 13:31:10 +09:00
OsuGame.cs Store preferred ruleset to configuration using ShortName instead of ID 2021-11-22 17:45:31 +09:00
OsuGameBase_Importing.cs Move import logic out to partial class 2021-05-28 02:44:44 +09:00
OsuGameBase.cs Rewrite PreviewTrackManager to avoid constructing TrackBass locally 2021-11-09 17:38:12 +09:00
PerformFromMenuRunner.cs Add flow to allow MatchSubScreen to handle beatmap presentation locally 2021-03-03 14:13:51 +09:00