1
0
mirror of https://github.com/ppy/osu.git synced 2025-01-13 13:32:54 +08:00

Merge branch 'master' into supporter-icon-link

This commit is contained in:
Dean Herbert 2021-11-18 13:36:14 +09:00 committed by GitHub
commit 1fdf0e9770
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -115,7 +115,7 @@ namespace osu.Game.Scoring.Legacy
}
}
CalculateAccuracy(score.ScoreInfo);
PopulateAccuracy(score.ScoreInfo);
// before returning for database import, we must restore the database-sourced BeatmapInfo.
// if not, the clone operation in GetPlayableBeatmap will cause a dereference and subsequent database exception.
@ -124,7 +124,14 @@ namespace osu.Game.Scoring.Legacy
return score;
}
protected void CalculateAccuracy(ScoreInfo score)
/// <summary>
/// Populates the accuracy of a given <see cref="ScoreInfo"/> from its contained statistics.
/// </summary>
/// <remarks>
/// Legacy use only.
/// </remarks>
/// <param name="score">The <see cref="ScoreInfo"/> to populate.</param>
public static void PopulateAccuracy(ScoreInfo score)
{
int countMiss = score.GetCountMiss() ?? 0;
int count50 = score.GetCount50() ?? 0;