Bartłomiej Dach
dfb8f4fdd9
Merge branch 'master' into buttons-fix
2022-12-13 16:35:03 +01:00
Dean Herbert
3d65984a89
Update framework
2022-12-13 22:34:01 +09:00
Dean Herbert
bf56f5f8c0
Show error message on attempting to open a URL with an unsupported protocol
2022-12-13 22:33:56 +09:00
Dean Herbert
efe057176e
Make OsuButton
abstract
2022-12-13 22:13:48 +09:00
Dean Herbert
edc78205d5
Add comments about why both positional input checks are required in OsuClickableContainer
2022-12-13 22:12:52 +09:00
Dean Herbert
b8904fe747
Move ImportParameters
to better home
2022-12-13 21:41:26 +09:00
Dean Herbert
cb16d62700
Hook up ImportParameter
flow with IModelImporter
caller methods
2022-12-13 21:29:32 +09:00
Dean Herbert
6bb612ce69
Move hard link availability check to helper class
2022-12-13 20:20:42 +09:00
Dean Herbert
bbf931c746
Move hard link helper functions to their own class
2022-12-13 19:55:18 +09:00
Dean Herbert
1d4230993d
Hook up parameter with RealmFileStore
to complete the chain
2022-12-13 19:55:18 +09:00
Dean Herbert
cf2719d4c0
Convert batchImport
parameter to parameters class to allow further import configuration
2022-12-13 19:55:18 +09:00
Dan Balasescu
ad7554cc7d
Allow keeping stream open after encoding scores
2022-12-13 16:15:14 +09:00
Andrei Zavatski
15bd82add8
Fix DrawableUsername being affected
2022-12-12 18:24:49 +03:00
mk56-spn
edb46e422c
Fix "using" name in HUD overlay
2022-12-12 15:15:30 +01:00
mk56-spn
99d83315c1
change settings order
2022-12-12 15:10:45 +01:00
mk56-spn
8efe7528e3
change ruleset source to avoid issues with converted beatmaps
2022-12-12 15:10:10 +01:00
Andrei Zavatski
890dd9cd06
Fix input doesn't take original drawable modifications into account
2022-12-12 15:10:03 +03:00
Andrei Zavatski
b0d475cd8b
CI fix
2022-12-12 14:57:07 +03:00
Andrei Zavatski
d2b3533356
Fix OsuClickableContainer input receiving
2022-12-12 14:42:54 +03:00
Andrei Zavatski
7e39f171fb
Fix OsuButton input receiving
2022-12-12 14:42:54 +03:00
Dean Herbert
5800734589
Merge pull request #21587 from smoogipoo/spectatorstate-maximum-statistics
...
Store maximum statistics to spectator state
2022-12-12 20:00:52 +09:00
mk56-spn
4d592184ca
temp cmt
2022-12-12 11:53:07 +01:00
Dean Herbert
df94af4495
Inline ScoringValues
and make some more methods private
inside ScoreProcessor
2022-12-12 19:22:09 +09:00
Dan Balasescu
7b48c91fe2
Only show local results in multi-spectator results screen
2022-12-12 18:56:43 +09:00
mk56-spn
58bf081096
Fix judgement counter not loading after first attempt in gameplay, Fix typo in Display
2022-12-12 10:52:55 +01:00
Dean Herbert
02b3bbf0d3
Merge pull request #21616 from Joehuu/changelog-build-masking
...
Fix changelog single build dates disappearing before being off screen
2022-12-12 18:28:48 +09:00
Dean Herbert
05b5949810
Use explicit casts
2022-12-12 17:38:39 +09:00
Dan Balasescu
caa0b7c290
Move score token to BeginPlaying
2022-12-12 13:59:27 +09:00
Dean Herbert
e2d8909e73
Add link to change folder location if it isn't on the same drive as import path
2022-12-12 13:44:09 +09:00
Dean Herbert
726943cb14
Add information attempting to explain hard links to the end user
2022-12-12 13:44:09 +09:00
Dean Herbert
d8de99bbe4
Check for hard link support in first run overlay
2022-12-12 13:44:09 +09:00
Dean Herbert
902dff15e3
Add todo regarding validity check
2022-12-12 13:44:09 +09:00
Dean Herbert
3b1920c060
Add code to check whether a file is a hard link
2022-12-12 13:44:09 +09:00
Dean Herbert
f27603dd6d
Use hard links instead of file copy when available
2022-12-12 13:44:09 +09:00
Dean Herbert
731184eb39
Revert "Merge pull request #21614 from EVAST9919/button-fix"
...
This reverts commit 4bd196684f
, reversing
changes made to a1d22ef77a
.
2022-12-12 13:43:01 +09:00
Joseph Madamba
e76c56b03b
Fix changelog single build dates disappearing before being off screen
2022-12-11 20:10:06 -08:00
Dan Balasescu
7a54bcac57
Remove unused using
2022-12-12 11:41:07 +09:00
Dan Balasescu
6e41efede8
Simplify dictionary construction
2022-12-12 11:40:47 +09:00
Dan Balasescu
5e8d75bbbf
Remove unused overload
2022-12-12 11:39:03 +09:00
Andrei Zavatski
1332568796
Fix SettingsButton receiving input at padded area
2022-12-12 03:10:13 +03:00
mk56-spn
f0c780f1f6
Fix tally header
2022-12-12 00:48:35 +01:00
mk56-spn
a107fca5d0
Hide "Full" option from counter flow directions
2022-12-12 00:33:28 +01:00
mk56-spn
161894da3b
Add more test checks and fix deserialisation test
2022-12-11 23:58:10 +01:00
mk56-spn
4c17b27273
Add Display, Counter, Tests
2022-12-11 23:47:17 +01:00
mk56-spn
f798951f09
Create Judgement Info struct
2022-12-11 22:09:14 +01:00
mk56-spn
ffbe68bd26
Add judgementTally to HUD overlay
2022-12-11 22:08:48 +01:00
Dean Herbert
85039209f8
Fix parsing of ruleset configuration values being incorrect on some locales
...
Closes #21611 .
2022-12-12 01:56:36 +09:00
Dean Herbert
0372e38f57
Add nullability assertion to appease CI
2022-12-11 13:00:12 +09:00
Dean Herbert
061f7d4857
Merge branch 'master' into osr-scoreinfo-data
2022-12-11 12:24:03 +09:00
Dan Balasescu
e9998f1690
Store maximum statistics to spectator state
2022-12-09 20:15:07 +09:00
Dan Balasescu
4a65f5c864
Add score token to spectator state
2022-12-09 19:09:51 +09:00
Dan Balasescu
3570fa8d93
Fix hub clients not reconnecting after connection error
2022-12-09 17:12:20 +09:00
dependabot[bot]
cdf76077b2
Bump Newtonsoft.Json from 13.0.1 to 13.0.2 in /osu.Game
...
Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json ) from 13.0.1 to 13.0.2.
- [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases )
- [Commits](https://github.com/JamesNK/Newtonsoft.Json/compare/13.0.1...13.0.2 )
---
updated-dependencies:
- dependency-name: Newtonsoft.Json
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-12-08 05:38:06 +00:00
Dean Herbert
f21e903a94
Update framework
2022-12-08 14:06:38 +09:00
Dan Balasescu
313f6e2f10
Merge pull request #21558 from peppy/fix-wrong-di
...
Fix incorrect resolution of `GameHost` in `LegacyImportManager`
2022-12-08 12:59:31 +09:00
Dan Balasescu
2406b8dfc8
Merge pull request #21557 from Joehuu/nominated-ranked-beatmaps
...
Display nominated ranked beatmaps in user profile
2022-12-08 11:40:24 +09:00
Dan Balasescu
e00c075482
Fix incorrectly modified first lazer version
2022-12-08 11:30:18 +09:00
Dean Herbert
f6e0aba53d
Merge pull request #21564 from Loreos7/master
...
Fix stale keybinding in "today's tip"
2022-12-08 11:23:09 +09:00
Bartłomiej Dach
5857471915
Merge branch 'master' into nominated-ranked-beatmaps
2022-12-07 23:54:25 +01:00
Bartłomiej Dach
3f4cab9ad1
Merge branch 'master' into fix-profile-beatmap-expand
2022-12-07 21:10:07 +01:00
Loreos7
0aeee8d6ab
fix typo in today's tip
2022-12-07 17:47:37 +03:00
Dean Herbert
819fd5f950
Fix incorrect resolution of GameHost
in LegacyImportManager
2022-12-07 17:53:14 +09:00
OliBomby
98a312ca96
Fix segmentEnds incorrect on shortened paths
2022-12-07 09:52:09 +01:00
OliBomby
cd46ca31f9
Add segmend end completions to SliderPath
2022-12-07 09:51:22 +01:00
Dean Herbert
62b0436bcf
Reverse depth of profile sections to allow for overflowing expanded beatmap cards
...
Closes #21554 .
2022-12-07 16:38:17 +09:00
Joseph Madamba
56e94e49a3
Display nominated ranked beatmaps in user profile
2022-12-06 23:36:11 -08:00
Dean Herbert
0497e433b1
Change SectionsContainer
to use flowing children for section update logic
2022-12-07 16:30:15 +09:00
Dean Herbert
c5e461e734
Update framework
2022-12-07 16:28:51 +09:00
Dean Herbert
e8766570c5
Update resources
2022-12-07 16:06:53 +09:00
Dean Herbert
d8d25c704f
Merge pull request #21551 from peppy/fix-latency-certifier-butons
...
Remove triangle effect from latency certifier buttons
2022-12-07 15:55:39 +09:00
Dean Herbert
70e0a04af8
Merge pull request #21541 from bdach/difficulty-bindable-regression
...
Fix extended values in difficulty adjust being truncated to 10 on beatmap change
2022-12-07 15:05:07 +09:00
Dean Herbert
eea7984ba9
Remove triangle effect from latency certifier buttons
2022-12-07 14:53:56 +09:00
Dan Balasescu
8709b1f2ea
Immediately send ack request when joining new channels
2022-12-07 14:24:20 +09:00
Dan Balasescu
df181acffe
Append lazer score data to .osr files
2022-12-07 12:12:32 +09:00
Bartłomiej Dach
81a42dc05d
Fix extended values in difficulty adjust being truncated to 10 on beatmap change
2022-12-06 23:25:48 +01:00
mk56-spn
fc630165fd
Adjust formatting of BPM text
2022-12-06 15:08:21 +01:00
Dan Balasescu
e47f933cdc
Merge pull request #21520 from frenzibyte/fix-preview-track-disposal
...
Fix preview track disposal potentially leaving game track muted
2022-12-06 14:19:21 +09:00
Dan Balasescu
9ddc2f4804
Merge pull request #21523 from Feodor0090/rewind-click-fix
...
Perform rewind with right click only if cursor didn't leave the button
2022-12-06 13:38:20 +09:00
ansel
b66409bd37
Perform rewind with right click only if cursor didn't leave the button
2022-12-05 23:38:45 +03:00
mk56-spn
f69c084969
Add roll duration
2022-12-05 17:08:00 +01:00
Salman Ahmed
a457a2fbbf
Fix disposal of playing preview track not unmuting game track
2022-12-05 14:45:32 +03:00
mk56-spn
b6a6db1160
Add dynamic BPM counter to SkinEditor
2022-12-05 12:29:23 +01:00
Dan Balasescu
9e64f8dab1
Fix loss of precision when computing accuracy
2022-12-05 19:08:50 +09:00
Dean Herbert
c288873365
Merge pull request #21502 from EVAST9919/smooth-progress-remove
...
Remove SmoothCircularProgress component as being replaced
2022-12-05 14:49:32 +09:00
Salman Ahmed
af000c6e92
Fix RangeSlider
potentially throwing exception on mobile platforms
2022-12-04 21:58:00 +03:00
ansel
7d7b824f56
Add description for torus alt
2022-12-03 23:42:16 +03:00
ansel
b240d15731
Fix numeric font
2022-12-03 23:38:50 +03:00
ansel
8174f6be64
Get rid of dublicated enum
2022-12-03 23:32:17 +03:00
Bartłomiej Dach
cb64919947
Merge branch 'master' into fix-exported-replay-overwrite
2022-12-03 21:09:19 +01:00
ansel
b41f30c868
Allow changing font of text elements
2022-12-03 22:44:54 +03:00
ansel
0db6c2ada1
Add enum with font types
2022-12-03 22:38:11 +03:00
Dean Herbert
36ab6bc64e
Update framework
...
Update framework
2022-12-04 01:30:27 +09:00
Bartłomiej Dach
7f0d366d01
Extract common part of regex to separate method
2022-12-03 16:59:43 +01:00
Andrei Zavatski
41f7dad8e9
Delete SmoothCircularProgress.cs
2022-12-03 16:40:41 +03:00
Andrei Zavatski
97b6d88f00
Remove SmoothCircularProgress usage in AccuracyCircle
2022-12-03 16:39:44 +03:00
Andrei Zavatski
94cfcdb338
Remove SmoothCircularProgress usage in BeatmapCardThumbnail
2022-12-03 16:16:21 +03:00
Dean Herbert
49f5ac57b8
Fix first run beatmap screen button colours looking incorrect with new triangle effect
...
Addresses #21500 .
2022-12-03 18:48:54 +09:00
Dean Herbert
5a69656764
Merge pull request #21496 from peppy/fix-zero-length-spinners
...
Fix being able to place zero-length spinners
2022-12-02 19:25:00 +09:00
Dan Balasescu
850931120d
Merge pull request #21479 from peppy/fix-wrong-last-hit-object-time
...
Fix some components not accounting for final hold notes in osu!mania beatmaps
2022-12-02 18:12:00 +09:00
Dean Herbert
d1296a22ce
Update timeline blueprint's end time logic to better match new blueprint implementation
2022-12-02 17:57:15 +09:00
Dean Herbert
ba99f1288c
Update IBeatSnapProvider
documentation to mention the pre-divided BeatSnap
2022-12-02 17:57:15 +09:00
Dan Balasescu
eea9bd3898
Merge pull request #21463 from peppy/fix-chat-system-message-ordering
...
Fix system messages appearing out of order in chat display
2022-12-02 17:39:20 +09:00
Dan Balasescu
a39bd634c4
Merge pull request #21405 from LumpBloom7/Editor-DrawableRuleset-Dependencies
...
Provide DrawableRulesetDependencies from HitObjectComposer
2022-12-02 17:31:31 +09:00
Dan Balasescu
d684aa75b8
Merge pull request #21477 from peppy/fix-mania-timeline-blueprint-colour
...
Fix osu!mania editor timeline showing bright-white blueprints
2022-12-02 16:55:29 +09:00
Dean Herbert
25120060aa
Use new helper method in ModTimeRamp
2022-12-02 16:09:46 +09:00
Dean Herbert
a2db0afe19
Avoid querying GetLastObjectTime
twice in editor seek flow
2022-12-02 16:07:24 +09:00
Dean Herbert
809d02cda0
Fix two implementation oversights
2022-12-02 16:05:14 +09:00
Dean Herbert
8cf89fcb81
Use Highlight1
instead of dull grey
2022-12-02 15:30:47 +09:00
Piggey
75cf7bd1d2
change GetNextBestFilename()
's parameters
2022-12-01 18:44:02 +01:00
Piggey
5de01686a9
extract findBestNumber()
from GetNextBestName()
into private method
2022-12-01 18:42:52 +01:00
Dean Herbert
d8dd7e7e0f
Fix test failures when no hitobjects are present in a scrolling ruleset
2022-12-01 21:42:03 +09:00
Dean Herbert
896f2d8f74
Fix multiple instances of last hitobject time being calculated incorrectly
2022-12-01 18:04:06 +09:00
Dean Herbert
f34a79b1a9
Set a better default colour for timeline blueprints when no colour information is available
2022-12-01 17:03:53 +09:00
Dean Herbert
bbf023cf68
Fix incorrect culture used when parsing timeline popup textbox content
2022-12-01 16:12:29 +09:00
Dean Herbert
c5bc071c4b
Merge pull request #21439 from LumpBloom7/Fix-DHO-load-state
...
Update DrawableHitObject state based on entry result during LoadComplete
2022-12-01 15:36:36 +09:00
Bartłomiej Dach
2e19e93036
Rename method
2022-11-30 22:54:14 +01:00
Bartłomiej Dach
6ebde9a747
Annotate Playfield.Mods
as maybe-null
2022-11-30 20:00:25 +01:00
Piggey
8f59aad91c
unnecessary includes
2022-11-30 18:37:50 +01:00
Piggey
8b856f1c89
make LegacyExporter
use NamingUtils.GetNextBestFilename()
2022-11-30 18:32:53 +01:00
Piggey
8412a44179
create NamingUtils.GetNextBestFilename()
2022-11-30 18:32:14 +01:00
Piggey
b99ddc2acf
use .Select()
to trim the file extension from filename
2022-11-30 15:36:08 +01:00
Derrick Timmermans
5c8fce1c08
Remove extra blank line
2022-11-30 13:05:14 +01:00
Derrick Timmermans
6a61e70766
Expose Ruleset from HitObjectComposer instead
2022-11-30 12:17:58 +01:00
ansel
1763618488
Fix spinner presense check & field click
2022-11-30 13:58:03 +03:00
ansel
43628903a7
Make spinner bigger
2022-11-30 13:57:09 +03:00
ansel
1cc7ffce39
Keep button's text
2022-11-30 13:40:47 +03:00
ansel
bedc771e99
Remove useless check
2022-11-30 13:32:01 +03:00
ansel
a8422961dc
Rename button spinner prop again
2022-11-30 13:30:57 +03:00
ansel
5ea824534b
Use default button
2022-11-30 13:25:59 +03:00
ansel
642e0ac718
Increase footer height to look better with default buttons
2022-11-30 13:25:18 +03:00
ansel
f4a8ac60a8
Revert autosizing in OsuButton
2022-11-30 13:12:10 +03:00
ansel
956acbc86f
Use fixed width
2022-11-30 13:11:54 +03:00
Piggey
660ad913ec
oh wait this affects all of the legacy exporters
2022-11-30 11:06:44 +01:00
Dawid Sośnia
f0b8b53e81
Merge branch 'ppy:master' into fix-exported-replay-overwrite
2022-11-30 10:54:12 +01:00
Piggey
5e74c4e3b7
override LegacyScoreExporter.Export()
to not overwrite files
2022-11-30 10:52:41 +01:00
Piggey
f5d85f5774
make ExportStorage
protected
2022-11-30 10:51:42 +01:00
Dean Herbert
5ce2d6f54a
Hide the game mouse cursor when playing osu!catch with relax mod
2022-11-30 18:13:53 +09:00
Dean Herbert
bb0237d4a9
Fix nullability inspection on disposal path
2022-11-30 17:49:08 +09:00
Dean Herbert
4215f4f5d7
Merge branch 'master' into Editor-DrawableRuleset-Dependencies
2022-11-30 17:42:46 +09:00
Dean Herbert
4a747182b4
Merge branch 'master' into comment-editor-1
2022-11-30 17:22:59 +09:00
Dean Herbert
b1ce93e7bf
Add fallback stable sort to avoid any change of misordered local messages
2022-11-30 16:55:39 +09:00
Dean Herbert
f7b7b58718
Adjust colour and tween to feel better
2022-11-30 16:20:01 +09:00
Dean Herbert
24ee363563
Only hover when hovering actual text
2022-11-30 16:18:36 +09:00
Dean Herbert
80b0e4a99d
Rename Colour
to avoid conflict with Drawable.Colour
2022-11-30 16:15:50 +09:00
Dean Herbert
7fca5ee28d
Move DrawableUsername
into own file
...
It's too large at this point to be a nested class.
2022-11-30 16:15:50 +09:00
Dean Herbert
9ab4664fcc
Merge branch 'master' into chat-profile-highlight-v2
2022-11-30 16:15:48 +09:00
Dean Herbert
b7f0310070
Merge pull request #21353 from peppy/no-initial-presence
...
Stop requesting messages as part of initial chat presence
2022-11-30 16:15:23 +09:00
Dean Herbert
6524914dbd
Merge branch 'master' into chat-profile-highlight-v2
2022-11-30 16:00:52 +09:00
Dean Herbert
78f70dae75
Merge pull request #21420 from cdwcgt/NowPlaying
...
Show mods, ruleset and unicode metadata in "now playing" chat command
2022-11-30 15:57:52 +09:00
Dean Herbert
2d8854cbac
Change message comparator to always use timestamp comparison if either message has a missing Id
2022-11-30 15:46:58 +09:00
Dean Herbert
9e34fe360a
Ensure all LocalMessage
s get a timestamp
2022-11-30 15:46:36 +09:00
Dean Herbert
c84f011bb7
Improve ToString
output of Message
2022-11-30 15:46:14 +09:00
Dean Herbert
b29054d30d
Merge pull request #21434 from jai-x/control-point-scroll-into-view
...
Ensure currently selected control point will scroll into view
2022-11-30 15:14:14 +09:00
Dean Herbert
d5301c75c1
Merge pull request #21460 from EVAST9919/triangles-v2-remove-texture
...
Remove texture usage in TrianglesV2 component
2022-11-30 15:13:08 +09:00
Dean Herbert
8bf5d6884d
Add ruleset to now playing string
2022-11-30 14:47:16 +09:00
Dean Herbert
b453eecebe
Ensure empty pieces do not result in whitespace between elements
2022-11-30 14:43:21 +09:00
Dean Herbert
2df6ccf33e
Tidy up code
2022-11-30 14:31:54 +09:00
Dean Herbert
b5c514a8f0
Make incoming Channel
target non-nullable
2022-11-30 14:30:20 +09:00
Dean Herbert
69bf0df179
Merge branch 'master' into NowPlaying
2022-11-30 14:27:37 +09:00
Dean Herbert
2a3b24d058
Avoid need for implicit null casting
2022-11-30 14:21:04 +09:00
Dean Herbert
0659c84341
Rename method to be more in line with project naming
2022-11-30 14:17:49 +09:00
Dean Herbert
63ba40ff39
Merge branch 'master' into control-point-scroll-into-view
2022-11-30 14:12:19 +09:00
Dan Balasescu
fcd7c27bc2
Merge pull request #21451 from peppy/update-framework
...
Update framework
2022-11-30 13:39:08 +09:00
Dan Balasescu
3f4d8b39ca
Update package again
2022-11-30 12:55:45 +09:00
Andrei Zavatski
2eaefcad30
Remove unused renderer
2022-11-30 04:56:07 +03:00
Andrei Zavatski
3b13ca1167
Remove texture from TrianglesV2
2022-11-30 04:09:46 +03:00
Jai Sharma
7dbf379351
Don't use verbatim string literals
2022-11-29 18:22:07 +00:00
ansel
e30d97c94e
Comments
2022-11-29 14:39:59 +03:00
ansel
84aaf5fedf
Change ways to access submit button state
2022-11-29 14:37:35 +03:00
ansel
6c126f5223
Remove useless local actions on click
2022-11-29 14:25:51 +03:00
Dean Herbert
08a403cb33
Merge pull request #21428 from mk56-spn/RangeSlider_implementation
...
Refactor star "DifficultyRangeFilterControl" into generic range slider
2022-11-29 16:08:13 +09:00
Dean Herbert
56a694fb04
Add automated test coverage of simple scenarios for RangeSlider
2022-11-29 15:10:21 +09:00
Dean Herbert
61c702c02e
Add new IDependencyInjectionCandidate
interface to non-drawable cached classes
2022-11-29 14:45:26 +09:00
Dean Herbert
b5b79e09e4
Remove unnecessary CQ disable
2022-11-29 14:45:08 +09:00
Bartłomiej Dach
8f78d6179b
Fix multiple issues with settings items unhiding on search
2022-11-29 14:41:49 +09:00
Bartłomiej Dach
24deb5f5f4
Remove all unnecessary usage of IHasFilterableChildren
2022-11-29 14:40:52 +09:00
Dean Herbert
96e19d4d84
Update framework
2022-11-29 14:36:23 +09:00
Dan Balasescu
198303513b
Merge pull request #21450 from Feodor0090/comments-btns-loc
...
Add missing localization in `DrawableComment`
2022-11-29 13:47:46 +09:00
ansel
16962d9a57
Localize deleted string
2022-11-29 07:02:02 +03:00
ansel
a4819e5c9c
Localize actions
2022-11-29 07:01:52 +03:00
ansel
472d9274b6
Reorder members
2022-11-29 06:23:25 +03:00
ansel
af0ee9dbd6
Make spinner a little bigger
2022-11-29 06:19:54 +03:00
ansel
894fb98fa2
Rebase CommitButton to RoundedButton
2022-11-29 06:17:02 +03:00
ansel
a874345da0
Rebase CancelButton to RoundedButton
2022-11-29 05:46:30 +03:00
ansel
25ddd20b2e
Allow OsuButton be auto-sized
2022-11-29 05:44:40 +03:00
ansel
d20dc3668e
Enable nullability
2022-11-29 05:17:44 +03:00
ansel
8b033bf9f7
Allow localisable strings
2022-11-29 05:13:54 +03:00
Alden Wu
8ec4dd046e
Fix InspectCode errors
2022-11-28 18:06:44 -08:00
Alden Wu
0cb7c94c21
Merge branch 'master' of https://github.com/ppy/osu into chat-profile-highlight-v2
2022-11-28 17:59:15 -08:00
Alden Wu
c2d8ffc225
Refactor ChatLine
username drawable creation
2022-11-28 17:50:12 -08:00
Andrei Zavatski
3e277a92e9
Fix incorrect texel size calculation
2022-11-29 03:21:59 +03:00
Andrei Zavatski
ba1717c2ca
Don't draw 0 thickness triangles
2022-11-29 02:36:27 +03:00
Derrick Timmermans
93ba84e5ff
Fix code style
2022-11-27 21:48:44 +01:00
Derrick Timmermans
70c320b2e8
Provide ruleset dependencies only to Compose Placement Blueprints
2022-11-27 21:43:33 +01:00
Derrick Timmermans
cff3e06ad6
Update state based on result during LoadComplete
2022-11-27 20:57:00 +01:00
mk56-spn
db7f429e39
Fix partial class issues and adjust test slightly
2022-11-27 10:44:05 +01:00
mk56-spn
0aba119056
Merge remote-tracking branch 'origin/RangeSlider_implementation' into RangeSlider_implementation
...
# Conflicts:
# osu.Game.Tests/Visual/SongSelect/TestSceneDifficultyRangeFilterControl.cs
# osu.Game/Screens/Select/DifficultyRangeFilterControl.cs
2022-11-27 10:40:29 +01:00
Jai Sharma
218c04c174
Code quality
2022-11-27 03:23:08 +00:00
Jai Sharma
6000e14668
Correctly select issue row
2022-11-27 03:08:54 +00:00
Jai Sharma
3c56b9c93a
Add OnRowSelected
event to EditorTable
2022-11-27 02:47:54 +00:00
Jai Sharma
792334a190
Move Control Group timing data into it's own component
2022-11-27 02:47:02 +00:00
Jai Sharma
b6d7bec240
Remove #nullable disabled
from EditorTable
and it's derived classes
2022-11-27 02:45:56 +00:00
Jai Sharma
1a914d0df7
Remove #nullable disable
from TimingScreen
2022-11-27 02:43:22 +00:00
cdwcgt
e16f8a4410
Merge branch 'master' into NowPlaying
2022-11-27 08:48:49 +08:00
cdwcgt
02e3ebe1a0
DifficultyIncrease use +
and other all -
...
mod.Name to mod.Acronym
2022-11-27 09:44:09 +09:00
cdwcgt
653875bbb4
only post mod when ingame
2022-11-27 09:41:41 +09:00
cdwcgt
8ecb4aa30b
better method name
2022-11-27 09:41:08 +09:00
Bartłomiej Dach
fd16e5992b
Merge branch 'master' into triangles-fix
2022-11-26 19:28:55 +01:00
Dean Herbert
d1eedd081c
Update resources
2022-11-27 02:46:11 +09:00
Andrei Zavatski
7ab5136e12
Compute texel size in the DrawNode
2022-11-26 20:05:34 +03:00
Bartłomiej Dach
c42720acd4
Temporarily disable "partial class with one part" inspection
2022-11-26 18:05:08 +01:00
Bartłomiej Dach
212d78865a
Add a few more missing partial specs
2022-11-26 16:30:52 +01:00
Bartłomiej Dach
894ef15e79
Merge branch 'master' into update-framework
2022-11-26 16:19:36 +01:00
Dan Balasescu
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
Dean Herbert
a1c559ae05
Update framework
2022-11-27 00:00:12 +09:00
mk56-spn
92ed2ed4ef
Refactor star "DifficultyRangeFilterControl" into generic range slider class
2022-11-26 12:19:08 +01:00
Bartłomiej Dach
ca0597b38e
Merge branch 'master' into dont-change-ruleset-convert
2022-11-25 19:23:36 +01:00
Bartłomiej Dach
73176a1315
Merge branch 'master' into triangle-button-v2
2022-11-25 18:35:59 +01:00
Bartłomiej Dach
bbbc1d0428
Darken colour of playlists create button
...
To match d0c4637683
.
2022-11-25 18:23:28 +01:00
cdwcgt
13f86f3e53
Merge branch 'master' into NowPlaying
2022-11-25 23:22:52 +09:00
cdwcgt
a2ea7a3f58
show selected mod and use ILocalisedBindableString in np
2022-11-25 23:20:44 +09:00
Dean Herbert
5ada9efa60
Update outdated comment regarding colour choices
2022-11-25 22:10:20 +09:00
Dean Herbert
76e9382e0b
Fix triangles showing on ExpandableButton
s when in contracted state
2022-11-25 20:18:35 +09:00
Dean Herbert
d0c4637683
Lighten colour of multiplayer create game button
2022-11-25 20:18:21 +09:00
Dean Herbert
b0f14d4963
Clamp AimCount
to ensure at least one triangle is spawned
2022-11-25 20:14:21 +09:00
Dean Herbert
4cb068ceb9
Change AimCount
to not consider height
2022-11-25 20:10:04 +09:00
Dean Herbert
25410c9962
Avoid changing ruleset when presenting a beatmap if it can be converted
...
Closes #21415 .
2022-11-25 19:48:01 +09:00
Derrick Timmermans
65e5c9a3ae
Dispose DrawableRulesetDependencies in HitObjectComposer
2022-11-25 08:27:22 +01:00
Bartłomiej Dach
fca3e7e39f
Merge branch 'master' into editor-seek-control-points
2022-11-24 21:53:47 +01:00
Dean Herbert
f6e229c24d
"Fix" mod copy failure
2022-11-25 01:15:11 +09:00
Dean Herbert
2b2beadd06
Merge branch 'master' into update-framework
2022-11-25 01:00:08 +09:00
Derrick Timmermans
7b620392fe
Provide DrawableRulesetDependencies from HitObjectComposer
2022-11-24 13:13:45 +01:00
Dean Herbert
6ad432b311
Use RoundedButton
in more places
2022-11-24 16:33:01 +09:00
Dean Herbert
53b03df93d
Combine TriangleButton
and RoundedButton
classes
2022-11-24 16:26:57 +09:00
Dean Herbert
bea2acc60e
Remove local specifications of triangle colouring
2022-11-24 16:18:15 +09:00
Dean Herbert
4fbca4037c
Update existing triangle buttons to use RoundedButton
2022-11-24 16:18:15 +09:00
Dean Herbert
40f706155f
Update RoundedButton
to have new triangles design
2022-11-24 16:18:15 +09:00
Dean Herbert
44a71741e4
Merge pull request #21225 from EVAST9919/triangles-v2
...
Implement TrianglesV2 component
2022-11-24 16:15:25 +09:00
Dean Herbert
8914a871c1
Merge pull request #21065 from C0D3-M4513R/beatmap-info
...
Add Beatmap Information elements
2022-11-24 15:22:04 +09:00
Dean Herbert
2e277ef40a
Update resources
2022-11-24 15:18:49 +09:00
Dean Herbert
a2438428a2
Move base call to end
2022-11-24 13:57:43 +09:00
Dean Herbert
37f725bfa2
Reverse directionality of up/down traversal keys to match scroll
2022-11-24 13:55:58 +09:00
C0D3 M4513R
4b44f31b5e
Use LocaliseableStings in BeatmapAttributeText
2022-11-23 21:02:43 +01:00
Bartłomiej Dach
2f67199b1c
Merge branch 'master' into fix-missing-day-separator
2022-11-23 18:40:44 +01:00
Bartłomiej Dach
60422be9af
Merge branch 'master' into fix-editor-tap-timing-crash
2022-11-23 17:51:50 +01:00
Dean Herbert
b381b4fd2d
Merge branch 'master' into update-framework
2022-11-24 01:27:58 +09:00
Dean Herbert
3acf15c7b8
Update framework
2022-11-24 01:26:49 +09:00
Bartłomiej Dach
30f9cc46a7
Protect offset and bpm adjustments from null selection too
2022-11-23 17:25:43 +01:00
Bartłomiej Dach
508f1f488c
Merge branch 'master' into limit-barline-generation-sanity
2022-11-23 17:12:36 +01:00
Dean Herbert
5467097387
Fix adjacent day separators potentially being left behind after pending message resolution
2022-11-23 18:49:51 +09:00
Dean Herbert
f9d952220f
Fix barlines being misaligned if generation start time is clamped
2022-11-23 18:12:03 +09:00
Dean Herbert
774f70e380
Simplify class structure
2022-11-23 16:56:40 +09:00
Dean Herbert
0749a7bb07
Simplify attribute assignment
2022-11-23 16:53:36 +09:00
Dean Herbert
0f034606fd
Use LocalisableDescription
from BeatmapOnlineStatus
enum instead of locally defined
2022-11-23 16:49:51 +09:00
Dean Herbert
a8af83e62a
Move label initialisation out of ctor
2022-11-23 16:49:39 +09:00
Dean Herbert
27473262af
Rename attributes in enum to match better with user expectations
2022-11-23 16:45:46 +09:00
Dean Herbert
b89689a34a
Rename class and reword settings text/tooltips to avoid clashing with other naming
2022-11-23 16:31:50 +09:00
Dean Herbert
a9192c32ea
Merge branch 'master' into beatmap-info
2022-11-23 16:10:12 +09:00
Dean Herbert
9b9b8a5977
Add ability to seek between control points in editor using down/up arrows
...
Matches stable. Addresses #21376 .
2022-11-23 15:59:32 +09:00
Dean Herbert
d146f86511
Fix crash when hitting 'T' to tap timing while no timing point is selected
2022-11-23 15:39:56 +09:00
Dean Herbert
172e798847
Merge pull request #21228 from Terochi/recent-messages-implementation
...
Add ability to view chat send history in input box
2022-11-23 14:58:42 +09:00
Bartłomiej Dach
8dbc38e17a
Remove unused setter
2022-11-22 20:14:22 +01:00
Bartłomiej Dach
76bb529cfa
Add test for local echo adding day separator
2022-11-22 16:46:21 +01:00
Dean Herbert
de163b2bb5
Change song select to only allow volume adjusting if alt is held while scrolling
2022-11-22 19:48:55 +09:00
Alden Wu
a2b505f4c0
Use a direct Lighten
instead of >1f Color4 values
2022-11-22 00:31:22 -08:00
Dean Herbert
1632df1f4d
Update DifficultyBindable
to match new bindable spec
2022-11-22 14:51:19 +09:00
Dan Balasescu
985781bc3b
Merge pull request #21356 from peppy/standardise-broken-storyboard-paths
...
Add support for storyboards with incorrect path specifications (`\\` instead of `\`)
2022-11-22 14:33:51 +09:00
Alden Wu
4084a2b066
Highlight ChatLine
username on hover
2022-11-21 18:57:59 -08:00
Bartłomiej Dach
8dbe31a172
Merge branch 'master' into higher-aspect-ratio-max
2022-11-21 19:51:39 +01:00
Bartłomiej Dach
c0f65d83b3
Merge branch 'master' into hide-no-spin-bonus
2022-11-21 19:14:54 +01:00
Bartłomiej Dach
206aece77b
Merge branch 'master' into avoid-null-audio-device-name-crahs
2022-11-21 16:37:13 +01:00
Bartłomiej Dach
7944d9cefa
Merge pull request #21304 from EVAST9919/beatmap-bar
...
Rework BarGraph to use Quads
2022-11-21 16:24:18 +01:00
Terochi
d81ef541bc
Variant 5: cannot change history, edit resets index
2022-11-21 10:17:28 +01:00
Terochi
7dc7729ac2
Variant 4: cannot change history, empty text/everything selected resets index (current with bug fix)
2022-11-21 10:11:26 +01:00
C0D3 M4513R
93ab1c9432
Merge branch 'master' into beatmap-info
2022-11-21 09:01:24 +00:00
Terochi
58288275a6
Variant 3: cannot change history, cannot reset index (the "default")
2022-11-21 09:43:36 +01:00
Terochi
672e1cd45b
Variant 2: edit changes history, cannot reset index (similar to stable)
2022-11-21 09:41:29 +01:00
Terochi
8f942f130b
Variant 1: edit changes history, empty text resets index
2022-11-21 09:36:31 +01:00
Andrei Zavatski
ec8532951c
Make Thickness property auto
2022-11-21 10:32:19 +03:00
Dean Herbert
2774c1ea49
Merge pull request #21215 from jai-x/triangles-bundled-beatmap
...
Add winner of Triangles mapping competition as a bundled beatmap
2022-11-21 16:22:23 +09:00
Andrei Zavatski
14a4de36f4
Expose thickness property
2022-11-21 10:20:35 +03:00
Dean Herbert
3da21e596a
Add support for storyboards with incorrect path specifications (\\
instead of \
)
...
Closes https://github.com/ppy/osu/issues/21204 .
2022-11-21 16:12:01 +09:00
Dean Herbert
462a213ffc
Add TODO note about handling initial silences
2022-11-21 15:23:04 +09:00
Dean Herbert
efd73ea9da
Rename method to suit better
2022-11-21 15:22:57 +09:00
Dean Herbert
5c640d15a0
Stop requesting messages as part of initial chat presence
2022-11-21 15:17:54 +09:00
Dean Herbert
9a330c3cdb
Apply nullability and clean up conditionals
2022-11-21 15:02:45 +09:00
Dean Herbert
a07b033d22
Merge branch 'master' into triangles-v2
2022-11-21 14:55:01 +09:00
Dean Herbert
981264b011
Avoid crashing when a system audio device provides a null
name
2022-11-21 14:51:41 +09:00
Dean Herbert
40f2da364c
Limit how far before the first hitobject that barlines can be generated
2022-11-21 14:40:25 +09:00
Dean Herbert
93a189603a
Hide spinner ticks / bonus from results screen when not applicable to score
2022-11-21 14:20:36 +09:00
Dean Herbert
4a79141824
Merge pull request #21338 from RATCM/fix-leaderboard-filter
...
Match leaderboard filter behaviour to web
2022-11-21 14:01:55 +09:00
Dean Herbert
e53b4321ff
Ensure two day separators are not added in a row
2022-11-21 14:01:10 +09:00
Dean Herbert
fa7b45dfb1
Fix chat day separator not being added on pending message resolution
...
Closes #21316 .
2022-11-21 13:52:14 +09:00
Dean Herbert
dfa92b3de9
Merge pull request #21326 from bdach/fix-phantom-beatmap-sets
...
Fix phantom beatmap sets appearing on carousel after delete/update
2022-11-21 13:25:14 +09:00
Dean Herbert
c7ae837687
Increase maximum aspect ratio for tablet settings to 23:9 / 2.55
2022-11-21 12:45:54 +09:00
Dean Herbert
92aea22cd3
Merge pull request #21340 from vegguid/MetadataLanguage-FirstSetup
...
Added PreferOriginalMetadataLanguage to FirstRunSetup
2022-11-21 12:16:56 +09:00
vegguid
a431b793b9
Added PreferOriginalMetadataLanguage to FirstRunSetup
2022-11-20 23:18:19 +01:00
Andrei Zavatski
18c79dfda3
Move all the logic into BarsInfo class
2022-11-20 23:00:13 +03:00
RATCM
f5fbb7c8de
Changed comments
2022-11-20 19:27:40 +01:00
RATCM
d20a357c0e
Fixed ordering bug
2022-11-20 19:24:51 +01:00
RATCM
9040dfbd4e
Match leaderboard filter behaviour to web
2022-11-20 17:39:46 +01:00
Bartłomiej Dach
1269afd0c5
Merge pull request #21307 from frenzibyte/disable-scroll-speed-on-osu
...
Hide scroll speed control from effects section on rulesets which don't support it
2022-11-20 16:17:55 +01:00
Bartłomiej Dach
0f382590e6
Remove unnecessary #nullable disable
2022-11-20 15:31:51 +01:00
Bartłomiej Dach
33b2fe46d9
Add xmldoc to HistoryTextBox
2022-11-20 12:29:47 +01:00
Bartłomiej Dach
7b274083d3
Fix phantom beatmap sets appearing on carousel after delete/update
...
Regressed in c40c70509e
.
As it turns out, `item.Item.Filtered.Value` is not the only condition
that should be checked to determine if a carousel item should be hidden
or not - `item.Item.State.Value != CarouselItemState.Collapsed` should
also be true. This was even available as the `item.Item.Visible`
convenience property, which is used in this commit.
Failing to check `item.Item.State.Value` led to setting non-zero alpha
on collapsed carousel items, leading to phantom beatmap sets appearing,
as the alpha was set in the entire carousel's `Update()` method, thus
firing every frame.
2022-11-20 10:08:34 +01:00
Andrei Zavatski
36141cb2a4
Make BarsInfo a class
2022-11-20 05:14:07 +03:00
Salman Ahmed
4b0ba86bd0
Identify scrolling rulesets using temporary DrawableRuleset
instances
2022-11-20 04:12:52 +03:00
Salman Ahmed
58296bd4f0
Introduce IDrawableScrollingRuleset
for editor consumption
2022-11-20 04:11:10 +03:00
Andrei Zavatski
fcb52ee237
Make BarsInfo a readonly struct
2022-11-20 02:28:07 +03:00
Andrei Zavatski
fbfcf49ea6
Remove readonly modifier from struct fields
2022-11-20 02:13:54 +03:00
Andrei Zavatski
2cb966b47c
Rework BarsInfo struct
2022-11-20 01:48:54 +03:00
Andrei Zavatski
6c62cfb830
Store barBreadth as a separate float
2022-11-19 23:40:02 +03:00
Andrei Zavatski
67ee9f3915
Naming adjustments
2022-11-19 23:34:55 +03:00
Andrei Zavatski
f1201454b7
Use value tuples
2022-11-19 23:29:50 +03:00
Andrei Zavatski
6f449a583e
Handle empty values as a separate case
2022-11-19 23:27:48 +03:00
Terochi
eff6c7be64
Removed unnecessary methods, changed tests, and moved LimitedCapacityQueue.cs to a more generic namespace.
2022-11-19 16:53:35 +01:00
Bartłomiej Dach
0c671a2a82
Merge branch 'master' into fix-tablet-aspect-ratio-values
2022-11-19 14:32:24 +01:00
Bartłomiej Dach
c05c1625f2
Merge branch 'master' into editor-test-play-dont-retain-test-time
2022-11-19 12:09:04 +01:00
Salman Ahmed
60c424837b
Merge branch 'master' into disable-scroll-speed-on-osu
2022-11-19 12:13:45 +03:00
Salman Ahmed
2e3af97892
Remove unused using
2022-11-19 12:13:36 +03:00
Andrei Zavatski
0239103b6b
Fix BeatmapOverlay crashing test scene
2022-11-19 11:33:14 +03:00
Andrei Zavatski
05992d3aa8
CI fix
2022-11-19 10:23:37 +03:00
Andrei Zavatski
9b8f98735c
Use struct for bars description
2022-11-19 10:16:58 +03:00
Andrei Zavatski
7d02cbafed
Merge branch 'master' into beatmap-bar
2022-11-19 09:58:10 +03:00
Andrei Zavatski
11f5fddc1f
Remove redundant returns
2022-11-19 09:57:52 +03:00
Dean Herbert
130f776427
Merge pull request #21267 from peppy/catch-file-enumeration-errors
...
Catch and gracefully handle file/directory enumeration failures during stable import
2022-11-19 15:38:40 +09:00
Salman Ahmed
290369db47
Hide scroll speed slider on rulesets which don't support it
2022-11-19 06:42:27 +03:00
Salman Ahmed
016de2f5a0
Fix editor not always playing hitsounds with clock offsets applied
2022-11-19 05:15:22 +03:00
Andrei Zavatski
e8ca9f5dc5
Rework BarGraph to use Quads
2022-11-19 00:22:57 +03:00
Salman Ahmed
1be8c6bd9c
Fix "perform from screen" not considering screen load state
2022-11-18 17:23:10 +03:00
Dawid Sośnia
9ad484a0f4
Merge branch 'ppy:master' into gameplay-leaderboard-fix
2022-11-18 12:11:22 +01:00
Dean Herbert
06ce8130c2
Apply changes in line with framework NRT updates
2022-11-18 18:13:15 +09:00
Dean Herbert
95908ec023
Update framework
2022-11-18 18:13:00 +09:00
Dan Balasescu
e4fc14faee
Merge pull request #21270 from peppy/auto-advance-bindings
...
Auto-advance binding for ruleset key bindings
2022-11-18 16:19:54 +09:00
Dan Balasescu
9d33a6568e
Merge pull request #21292 from peppy/fix-binding-two-keys-single-binding
...
Fix being able to bind two non-modifier keys to the same binding
2022-11-18 16:19:38 +09:00
Dan Balasescu
d8e99d811d
Merge pull request #21293 from frenzibyte/fix-timeline-extent-scrolling
...
Fix timeline potentially scrolling at extents while not dragging
2022-11-18 16:19:30 +09:00
Dean Herbert
d59befc9d3
Fix initial visual state of positions before sort
runs
2022-11-18 16:08:27 +09:00
Dean Herbert
aff218dfd5
Redirect through validity function rather than overriding Sort
2022-11-18 16:03:40 +09:00
Dean Herbert
20af8217f4
Tidy up bindable flow
2022-11-18 15:50:41 +09:00
Dean Herbert
e4f522aad1
Fix inspections / typos
2022-11-18 15:47:37 +09:00
Dean Herbert
d17c091d63
Move constant to a better location
2022-11-18 15:47:31 +09:00
Dean Herbert
3faa7f5f74
Merge branch 'master' into gameplay-leaderboard-fix
2022-11-18 15:44:30 +09:00
Salman Ahmed
90cd386323
Fix timeline potentially scrolling at extents while not dragging
2022-11-18 09:43:16 +03:00
Dean Herbert
bab5be8dee
Merge pull request #21290 from smoogipoo/multiplayer-test-debug
...
Add some debugging for multiplayer test failures
2022-11-18 15:39:33 +09:00
Dean Herbert
e658efbefa
Fix being able to bind two non-modifier keys to the same binding
2022-11-18 15:34:41 +09:00
Dan Balasescu
c2a127dc68
Merge pull request #21289 from peppy/fix-triangle-button-flash
...
Fix triangle button flash effect looking incorrect
2022-11-18 15:26:43 +09:00
Dan Balasescu
219d049edf
Merge pull request #21140 from maromalo/long-standard
...
Standardise scores to `long` type
2022-11-18 15:26:33 +09:00
Dan Balasescu
cc434c9113
Merge pull request #21288 from peppy/fix-no-network-slow-gameplay-load
...
Fix entering gameplay while network connection is in a bad state taking too long
2022-11-18 15:24:31 +09:00
Dan Balasescu
7e9d2ecaf5
Merge pull request #21287 from peppy/fix-null-ref-persistent-endpoint-connector
...
Fix potential incorrect connection state resulting in null reference
2022-11-18 15:08:33 +09:00
Dan Balasescu
b0faa009c1
Add some debugging for multiplayer test failures
2022-11-18 14:52:11 +09:00
Dean Herbert
5fc0d45675
Fix triangle button flash effect looking incorrect
2022-11-18 14:30:59 +09:00
Dan Balasescu
57b8495c7a
Merge branch 'master' into long-standard
2022-11-18 14:24:04 +09:00
Dan Balasescu
d47c46d144
Compute raw score in-line
...
Saves on an allocation (though it seems to only be a ValueType so it
shouldn't be a big deal) and a tail-call.
2022-11-18 14:22:28 +09:00
Dean Herbert
964ceddf83
Fix API queue only being flushed once while in a failing state
2022-11-18 14:21:37 +09:00
Dean Herbert
e4d134a820
Reduce time waited on a score submission token from 60 to 30s
2022-11-18 14:07:40 +09:00
Dan Balasescu
1b1fed723d
Merge pull request #21269 from peppy/fix-key-bindings-keyword
...
Move "keybindings" keyword to correct section
2022-11-18 14:05:08 +09:00
Dan Balasescu
551192b413
Refactor a bit for readability
2022-11-18 13:55:37 +09:00
Dean Herbert
a5d22195f2
Fix potential incorrect connection state resulting in null reference
2022-11-18 13:45:46 +09:00
Dean Herbert
1ff1738988
Merge pull request #21244 from nanashi-1/beatmapoptions-disabled
...
Disable certain beatmap option buttons when there are no beatmaps selected
2022-11-18 12:55:07 +09:00
Dan Balasescu
a776622ce0
Merge pull request #21284 from peppy/now-playing-overlay-texture-reduction
...
Fix `NowPlayingOverlay` loading background texture too early (and permanently)
2022-11-18 12:09:16 +09:00
Dan Balasescu
c34dd27674
Merge pull request #21276 from peppy/eager-triangles-disposal
...
Eagerly dispose of triangles intro textures to avoid holding for full length of game session
2022-11-18 11:58:39 +09:00
Dan Balasescu
baa4fd56e2
Merge pull request #21279 from peppy/news-load-unload
...
Fix news post images never unloading from memory after first display
2022-11-18 11:56:13 +09:00
Dan Balasescu
13fe0d3491
Merge pull request #21278 from peppy/overlay-header-texture-reduction
...
Avoid loading overlay headers until first open
2022-11-18 11:53:46 +09:00
Dean Herbert
b53f9baf6a
Fix NowPlayingOverlay
loading background texture too early (and permanently)
2022-11-18 11:21:12 +09:00
Dean Herbert
93c2280754
Fix supporter filters text not being set correctly
2022-11-18 10:35:05 +09:00
Dawid Sośnia
0dbf491872
Merge branch 'master' into gameplay-leaderboard-fix
2022-11-17 22:06:51 +01:00
Piggey
eb691266c1
cleanup
2022-11-17 21:50:39 +01:00
Dean Herbert
b37e9c0266
Fix news post images never unloading from memory after first display
2022-11-18 00:01:53 +09:00
Dean Herbert
73e4827d36
Avoid loading overlay headers until first open
...
Also switches them to use non-atlased target as they won't benefit much
from atlasing.
2022-11-17 23:55:43 +09:00
Dean Herbert
63c1855511
Avoid loading beatmap listing placeholders until required
2022-11-17 23:42:21 +09:00
Dean Herbert
a3e8cc1663
Mark beatmap listing placeholder textures as large
2022-11-17 23:41:35 +09:00
Dean Herbert
20d87fbed4
Eagerly dispose of triangles intro textures to avoid holding for full length of game session
2022-11-17 23:05:34 +09:00
Piggey
fa00fc5c6d
change scoresType to be a bindable
2022-11-17 13:27:56 +01:00
Dragon
a25c94d567
Replacing structure to use LimitedCapacityQueue.cs
2022-11-17 13:07:06 +01:00
Dragon
a9747d367c
Cleaning up
2022-11-17 13:07:06 +01:00
Terochi
0100c01b82
Implemented finite limit of stored history.
2022-11-17 13:07:06 +01:00
Terochi
5253f5309e
Added more tests for new features
2022-11-17 13:07:06 +01:00
Terochi
44c3e71746
Reversed indexing
2022-11-17 13:07:06 +01:00
Terochi
3d4962e181
Added functioning tests.
2022-11-17 13:07:06 +01:00
Terochi
6d83af01e2
Moved and renamed MessageHistoryTextBox.cs for better fit.
2022-11-17 13:07:06 +01:00
Dragon
b9590320b7
Moved implementation to ChatRecentTextBox.cs and derived ChatTextBox.cs and StandAloneChatDisplay.cs from it.
2022-11-17 13:07:06 +01:00
Dragon
a1af663682
Implemented previous messages lookup in the ChatTextBox.cs
2022-11-17 13:07:06 +01:00
Piggey
dea2a6ed8d
override sort()
function in SoloGameplayLeaderboard
2022-11-17 12:12:36 +01:00
nanashi-1
4773979e52
add condition
2022-11-17 16:15:34 +08:00
Dean Herbert
d1b2116400
Auto-advance binding for ruleset key bindings
2022-11-17 15:23:20 +09:00
Dean Herbert
bd2e0dc82b
Move "keybindings" keyword to correct section
...
Without this, things like tablet settings would show when searching for
bindings, even though these settings have nothing to do with key
bindings.
2022-11-17 15:09:42 +09:00
Dan Balasescu
5ceb7ecc41
Remove unused using
2022-11-17 13:56:27 +09:00
Dean Herbert
1050d7da34
Use more generic exception type (issue reported AggegateException
)
2022-11-17 13:36:16 +09:00
Dean Herbert
adab9f0e48
Catch and gracefully handle file/directory enumeration failures during stable import
...
Closes https://github.com/ppy/osu/issues/21214 .
2022-11-17 13:34:42 +09:00
Dean Herbert
a4e713a61f
When returning to the editor after test play, use the original editor time rather than the point of exit
2022-11-17 12:36:24 +09:00
Dean Herbert
bfcd9e0f45
Don't seek to current editor location when location is close to (or before) the first object
2022-11-17 12:32:35 +09:00
Dan Balasescu
bdfc317a8e
Merge pull request #21255 from peppy/fix-full-area-reset
...
Fix "reset to full area" button not always working correctly
2022-11-17 11:13:06 +09:00
Dan Balasescu
b23b5ebce9
Merge pull request #21257 from peppy/fix-test-mode
...
Fix combo colour normalisation setting not applying to editor test play
2022-11-17 10:44:44 +09:00
Salman Ahmed
87b4fee10f
Remove leftover constant
2022-11-17 04:05:21 +03:00
Salman Ahmed
55beaf5d93
Revert buttons order change
2022-11-17 04:05:15 +03:00
Salman Ahmed
039ab83a46
Disable beatmap options button when none selected
2022-11-17 04:00:23 +03:00
Salman Ahmed
0e46614c57
Revert beatmap option button state changes
2022-11-17 03:57:01 +03:00
Salman Ahmed
c1673771eb
Merge branch 'master' into fix-full-area-reset
2022-11-17 01:57:56 +03:00
Salman Ahmed
7a28a7f2a0
Move IGameplaySettings
override to compose screen to keep test mode unaffected
2022-11-17 01:45:16 +03:00
Andrei Zavatski
13cf3fc40c
Make SpawnRatio public
2022-11-16 15:17:50 +03:00
Andrei Zavatski
cc4f05f3d3
Replace Scale with SpeedMultiplier
2022-11-16 15:12:57 +03:00
Andrei Zavatski
109aa37dd8
Apply fixes from original Triangles
2022-11-16 15:02:09 +03:00
Andrei Zavatski
d94c624ee4
Merge branch 'master' into triangles-v2
2022-11-16 14:53:32 +03:00
Dean Herbert
ee6fffec5f
Fix combo colour normalisation setting not applying to editor test play
2022-11-16 17:54:49 +09:00
Dean Herbert
bb762d8131
Fix "reset to full area" button not always working correctly
2022-11-16 15:45:26 +09:00
nanashi-1
5d8d8ffce5
fix naming
2022-11-16 10:09:51 +08:00
nanashi-1
55edd6c907
add space
2022-11-16 09:58:49 +08:00
nanashi-1
1fb8357e93
change disabledAlpha
from readonly
to const
2022-11-16 09:58:32 +08:00
nanashi-1
9101ad0cbd
fixed naming
2022-11-16 09:42:40 +08:00
Dean Herbert
52ecd894db
Move equilateral triangle ratio to constant
2022-11-15 22:20:08 +09:00
nanashi-1
5973bb1956
AddButton now returns the button
2022-11-15 20:57:31 +08:00
nanashi-1
1186ed3e32
add disable
2022-11-15 20:56:18 +08:00
nanashi-1
e8d170e772
disable certain options when no beatmap is selected
2022-11-15 20:55:55 +08:00
Andrei Zavatski
f27a5f977d
Improve triangles distribution
2022-11-15 11:49:53 +03:00
Andrei Zavatski
c7dc6db124
Fix incorrect number of added triangles
2022-11-15 11:32:05 +03:00
Andrei Zavatski
ebff844334
Reset triangles on scale change
2022-11-15 11:06:28 +03:00
Dean Herbert
489dca79a1
Remove upper limit for pooling
2022-11-15 12:31:25 +09:00
Dean Herbert
308ed1abd1
Fix number of judgements shown potentially exceeding upper limit
2022-11-15 12:31:25 +09:00
Dean Herbert
59a8603728
Ensure flowing animation starts correctly from zero
2022-11-15 12:04:40 +09:00
Dean Herbert
aef6ee23eb
Apply pooling support to ColourHitErrorMeter
2022-11-15 12:04:40 +09:00
Dean Herbert
a86b50d62a
Apply nullability to BarHitErrorMeter
2022-11-15 11:33:27 +09:00
Dean Herbert
576f462f59
Add pooling support to BarHitErrorMeter
2022-11-15 11:33:27 +09:00
Dan Balasescu
e43593a164
Merge pull request #21227 from Susko3/fix-FallbackSampleStore-async-fallback-logic
...
Fix `FallbackSampleStore.GetAsync` fallback logic
2022-11-14 10:17:42 +09:00
Susko3
56fd1f95b1
Fix FallbackSampleStore.GetAsync
fallback logic
2022-11-13 18:47:28 +01:00
Joseph Madamba
4578a96813
Fix beatmap card expanded content not blocking clicks from behind
2022-11-13 08:18:44 -08:00
Andrei Zavatski
81c9ea98e2
Implement TrianglesV2 component
2022-11-13 15:31:48 +03:00
Dean Herbert
efe42f701a
Merge branch 'master' into only-rounded-shader
2022-11-13 16:34:48 +09:00
Dean Herbert
236cc0bdaf
Update resources
2022-11-13 16:21:28 +09:00
Dean Herbert
887b6832c9
Update framework
2022-11-13 16:15:30 +09:00
Dean Herbert
eae8530722
Fix SkinnableSprite
lookups broken in lazer-first skins
...
Regressed with removal of local `GetTexture` calls in e19ba65f91
2022-11-13 12:46:21 +09:00
Jai Sharma
c5cb4e4e7d
Add winner of Triangles mapping competition as a bundled beatmap
...
https://osu.ppy.sh/home/news/2022-10-06-results-triangles
2022-11-12 17:48:40 +00:00
Dean Herbert
f343ba6111
Add xmldoc for chat ack request
2022-11-13 00:10:06 +09:00
Dean Herbert
22d8a1160e
Fix last silence ID being updated too often, causing most silences to be missed
2022-11-13 00:10:06 +09:00
Dean Herbert
143c946128
Simplify ack re-perform flow
2022-11-12 23:02:37 +09:00
Dean Herbert
bfb939cbd0
Expand on why call needs to be made every 10 minutes
2022-11-12 22:24:27 +09:00
Dean Herbert
6a3665a6fd
Remove excess logging on WebSocketNotificaitonsClient
2022-11-12 22:09:27 +09:00
maromalo
1911120afe
Merge branch 'master' into long-standard
2022-11-12 09:52:11 -03:00
Dean Herbert
ace4099079
Update ack code after incorrect merge
2022-11-12 21:41:10 +09:00
Thomas Müller-Höhne
9ef43ebd83
Fix compilation after framework-side PR updates
2022-11-12 21:24:12 +09:00
Dean Herbert
dde09d409b
Merge branch 'master' into chat-silences
2022-11-12 21:00:56 +09:00
Thomas Müller-Höhne
fa8e38d9d6
Target rounded fragment shader
...
Compatibility with osu-framework change https://github.com/ppy/osu-framework/pull/5512
2022-11-12 17:18:23 +09:00
Samaoo
4ff17cb4bd
remove unused using directive
2022-11-12 08:52:33 +01:00
Samaoo
7a860fb460
address reviews
2022-11-12 08:49:03 +01:00
Samaoo
268011be9e
use MathF
2022-11-11 17:56:50 +01:00
Samaoo
173f557376
fix tablet aspect ratio values
2022-11-11 17:14:34 +01:00
Dean Herbert
19876ca0fb
Merge branch 'master' into websocket-chat-2
2022-11-11 23:53:42 +09:00
Dean Herbert
151dd7c62f
Fix one more reverted change
2022-11-11 22:21:38 +09:00
Dean Herbert
0af4bdaf5c
Add back removed configuration elements
2022-11-11 18:29:15 +09:00
Dean Herbert
106f1cf90b
Merge branch 'master' into combo-colour-brightness-limit
2022-11-11 18:24:39 +09:00
Dean Herbert
392d4e778e
Change default beatmap listing key binding to Ctrl
+B
2022-11-11 17:10:46 +09:00
Dan Balasescu
fe58329478
Merge pull request #21151 from peppy/taiko-judgement-fixes
...
Fix various issues surrounding hit judgements
2022-11-11 16:41:46 +09:00
Dan Balasescu
5bdbf56f43
Merge branch 'master' into taiko-judgement-fixes
2022-11-11 15:48:33 +09:00
Dan Balasescu
1a1a186d22
Merge branch 'master' into taiko-barline-separation
2022-11-11 15:47:06 +09:00
Dan Balasescu
db25e9e9c8
Merge branch 'master' into combo-colour-brightness-limit
2022-11-11 15:31:28 +09:00
Bartłomiej Dach
88195d3984
Merge branch 'master' into improve-ui-control-sound-sync
2022-11-11 07:29:37 +01:00
Dan Balasescu
6ac19615fa
Fix test failure
2022-11-11 14:55:41 +09:00
Bartłomiej Dach
63270c8619
Merge branch 'master' into improve-ui-control-sound-sync
2022-11-11 05:50:28 +01:00
Susko3
5b1e39abd5
Fix parsing of Language
when using default system locale
2022-11-10 22:56:24 +01:00
maromalo
83a3f1b82e
Add computeRawScore()
2022-11-10 14:15:20 -03:00
Dean Herbert
86862b1f29
Merge pull request #21164 from Susko3/fix-default-24h-time-format
...
Fix `Prefer24HourTime` default value being wrong
2022-11-11 00:16:47 +09:00
Dan Balasescu
94772a9cda
Merge pull request #21147 from peppy/fix-timeline-editor-crash
...
Fix editor hard crash when beatmap file specified out-of-range timeline zoom value
2022-11-10 22:59:55 +09:00
Dan Balasescu
fd88c92d5a
Merge pull request #21144 from peppy/fix-storyboard-end-start-time
...
Fix incorrect handling of storyboard events with `end_time` before `start_time`
2022-11-10 22:53:45 +09:00
Dean Herbert
1f8824a754
Update framework
2022-11-10 16:14:40 +09:00
Dean Herbert
bc6da2bbaf
Merge branch 'master' into fix-default-24h-time-format
2022-11-10 16:14:37 +09:00
Dean Herbert
4c6ab27ae4
Merge pull request #21192 from Samaoo/fix-tablet-area-dimensions
...
Fix inaccurate tablet area dimensions when applying aspect ratio
2022-11-10 14:14:11 +09:00
Dan Balasescu
606d42c679
Merge pull request #21184 from peppy/skinnable-things-cleanup
...
Skinnable class naming pass
2022-11-10 12:52:08 +09:00
Dan Balasescu
46d4fc0279
Merge pull request #21167 from peppy/fix-storyboard-variables
...
Fix some issues with storyboard variables
2022-11-10 12:46:52 +09:00
Dan Balasescu
dddbc7496a
Merge pull request #21168 from peppy/fix-storyboard-extension-lookup
...
Fix sprites not displaying in storyboard if filename extension is missing in script
2022-11-10 12:31:00 +09:00
Dan Balasescu
051f7f4c68
Merge pull request #21173 from peppy/toggle-hit-markers
...
Add the ability to toggle off hit marker displays in the editor
2022-11-10 12:23:53 +09:00
Dean Herbert
3547c04002
Merge branch 'master' into skinnable-things-cleanup
2022-11-10 12:09:32 +09:00
Dan Balasescu
f90010628c
Merge pull request #21185 from peppy/fix-editor-sample-spam
...
Fix editor playing too many sounds when user performs a manual seek during playback
2022-11-10 12:05:16 +09:00
Dan Balasescu
040d7ee247
Merge pull request #21183 from peppy/skinnable-nullability
...
Apply nullability considerations to all skin related classes
2022-11-10 11:50:41 +09:00
Joseph Madamba
2b81f3048c
Merge branch 'master' into close-side-overlays-when-main-overlay
2022-11-09 12:48:57 -08:00
Samaoo
be81c658af
move tablet area calculations to functions
2022-11-09 20:14:01 +01:00
Piggey
0011f4e7be
fix comment lol
2022-11-09 19:59:04 +01:00
Piggey
4fbc240aa1
Merge remote-tracking branch 'origin/gameplay-leaderboard-fix' into gameplay-leaderboard-fix
2022-11-09 19:53:56 +01:00
Piggey
ab53fb17d3
change displayed text from #?
to -
2022-11-09 19:53:36 +01:00
Samaoo
533a2db5ea
fix inaccurate tablet area dimensions when applying aspect ratio
2022-11-09 18:48:47 +01:00
C0D3 M4513R
a57c824092
Merge branch 'master' into beatmap-info
2022-11-09 14:47:08 +00:00
Dean Herbert
e19ba65f91
Remove LookupName
from base ISkinComponentLookup
2022-11-09 17:46:43 +09:00
Dean Herbert
1aa0e40f2f
Add "Component" prefix to lookup naming
2022-11-09 17:46:43 +09:00
Dean Herbert
e75c3b3f94
Rename SkinnableTarget
to GlobalSkinLookup
2022-11-09 17:46:43 +09:00
Dean Herbert
c908969d9b
Rename ISkinComponent
to ISkinLookup
2022-11-09 17:46:43 +09:00
Dean Herbert
ab458320c4
Fix some lingering inspections
2022-11-09 17:46:24 +09:00
Dean Herbert
4457648b1c
Fix editor playing too many sounds when user performs a manual seek during playback
2022-11-09 17:42:33 +09:00
Dean Herbert
d4251271d8
Apply nullability to SkinnableDrawable
2022-11-09 13:59:13 +09:00
Dean Herbert
bf26dbffc2
Apply nullability to skinning support classes
2022-11-09 13:59:13 +09:00
Dawid Sośnia
9549e55ef8
Merge branch 'ppy:master' into gameplay-leaderboard-fix
2022-11-08 20:04:13 +01:00
Piggey
d48c56818f
change positionText
to display "#?" if tracked score is being 51st on the leaderboard
2022-11-08 20:02:21 +01:00
Dean Herbert
4448fcb3c8
Override combo colour brightness normalisation setting only in editor
2022-11-08 18:29:10 +09:00
Dean Herbert
dd4cd3cf8e
Move gameplay configuration to interface to allow editor overriding
2022-11-08 18:25:24 +09:00
Dean Herbert
ada039151b
Add the ability to toggle off hit marker displays in the editor
2022-11-08 18:07:06 +09:00
Dean Herbert
9650ae1329
Limit editor background dim to 75% maximum
2022-11-08 17:20:37 +09:00
Dean Herbert
349d262c18
Remove commented unbind
2022-11-08 17:19:48 +09:00
Dean Herbert
b166e477c2
Merge branch 'master' into editor-background
2022-11-08 17:18:34 +09:00
Dean Herbert
b9374cae55
Hide settings/notifications regardless of IsPresent
state of new overlay
2022-11-08 14:38:02 +09:00
Dean Herbert
0b34340447
Fix sprites not displaying in storyboard if filename extension is missing in script
2022-11-08 14:34:28 +09:00
Dean Herbert
064a245c50
Don't trim whitespace from variable keys / values
2022-11-08 13:30:11 +09:00
Dean Herbert
b764d1bd04
Decode variables earlier in flow in case they include indent logic
...
Without this change, the `depth` calculation could be incorrect.
2022-11-08 13:29:42 +09:00
maromalo
64e6276397
Fix score rounding issue
2022-11-08 01:10:21 -03:00
Dean Herbert
49f530910c
Merge pull request #21163 from frenzibyte/always-show-cursor-on-focus-loss
...
Always display menu cursor when game is not focused
2022-11-08 12:37:19 +09:00
Dean Herbert
2163cd212b
Automatically close settings and notification overlays when opening main overlay
...
Closes #21162 .
2022-11-08 12:04:07 +09:00
Salman Ahmed
1465d043f4
Merge branch 'master' into song-select-transition-improvement
2022-11-08 03:36:19 +03:00
Susko3
8568520c33
Fix Prefer24HourTime
default value
...
Will use the system culture so it always matches the rest of the OS.
2022-11-08 01:34:06 +01:00
Salman Ahmed
7ee9018a94
Always display menu cursor when game is not focused
2022-11-08 03:18:12 +03:00
C0D3 M4513R
ab650d8a1b
Use AutoSizeAxes
2022-11-07 15:22:20 +01:00
Dean Herbert
2b72c3833b
Remove unnecessary centering logic in DrawableJudgement
2022-11-07 17:19:32 +09:00
C0D3 M4513R
28ab092b6f
Simplify the whole Templating process
2022-11-07 07:55:42 +01:00
Dan Balasescu
fdca3c2d1c
Rename method for consistency
2022-11-07 14:35:42 +09:00
Dan Balasescu
67e99b5344
Lookup channels before calling HandleJoinedChannel()
2022-11-07 14:34:55 +09:00
Dean Herbert
c69a4f9333
Move major barline portion to default implementation to allow for further customisation
...
Of note, this removes the "major" barline triangles from legacy skins. I
think this is more correct, as they did not display in stable.
2022-11-07 14:29:58 +09:00
Dean Herbert
f6d93fcd5a
Fix editor hard crash when beatmap file specified out-of-range timeline zoom value
2022-11-07 12:54:02 +09:00
Joseph Madamba
76df61504f
Remove unnecessary timestamp update
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2022-11-06 19:45:59 -08:00
Joseph Madamba
61ec0ba566
Make chat line timestamp adjust to 24-hour time setting
2022-11-06 19:28:01 -08:00
Joseph Madamba
b977fc8181
Use autosize instead of max width on fixed width timestamps
2022-11-06 19:28:01 -08:00
Dean Herbert
6085120dc5
Fix incorrect handling of storyboard events with end_time
before start_time
2022-11-07 12:25:36 +09:00
Dan Balasescu
f931bdc5ff
Fix channel lookup not considering missing ids
2022-11-07 12:25:23 +09:00
Dan Balasescu
cd8402df72
Print event type to logs
2022-11-07 12:11:50 +09:00
Dean Herbert
391840404d
Play exiting transition in both directions
2022-11-07 11:59:43 +09:00
Dan Balasescu
cf03001c83
Better handling for joining channels with only ID
2022-11-07 11:52:07 +09:00
Dan Balasescu
e3adf5a985
Handle channel parts
2022-11-07 11:36:55 +09:00
Dan Balasescu
93f84ece0d
Merge pull request #21118 from peppy/increase-main-menu-background-change-delay
...
Adjust transition effect for main menu backgrounds
2022-11-07 11:33:09 +09:00
maromalo
8eef2ba8de
quality shenanigans
2022-11-06 20:12:26 -03:00
maromalo
b7ef9b176d
Make score type consistent
2022-11-06 19:59:27 -03:00
C0D3 M4513R
0c17571c58
Merge branch 'master' into beatmap-info
2022-11-06 18:53:14 +00:00
Dean Herbert
e7b543de2f
Move disabled check to apply to all calls to updateGlow()
2022-11-07 02:19:13 +09:00
Dean Herbert
700f8b0469
Remove pointless nested if conditional
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-11-07 02:13:04 +09:00
Dean Herbert
14a4fdfbe3
Merge pull request #21135 from CenTdemeern1/master
...
Fix preposition for exclusive fullscreen prompt
2022-11-07 00:00:19 +09:00
Dean Herbert
75bf023f14
Fix HSPAColour.ToColour
not being pure
2022-11-06 23:35:51 +09:00
CenTdemeern1
e8603ede15
Fix second prompt
2022-11-06 15:35:26 +01:00
Dean Herbert
51078bddf9
Remove unused bindable
2022-11-06 23:34:04 +09:00
Dean Herbert
ee68f33e3c
Merge pull request #21109 from frenzibyte/fix-beatmap-duplicating-again
...
Fix beatmap cards still potentially showing twice in listing
2022-11-06 18:46:31 +09:00
Dean Herbert
e02c477008
Merge pull request #21017 from andy840119/remove-nullable-disable-in-the-checks
...
Remove nullable disable in the checks.
2022-11-06 18:39:03 +09:00
CenTdemeern1
887a3f3e28
Fix preposition for exclusive fullscreen prompt
2022-11-05 19:44:25 +01:00
Bartłomiej Dach
84179fb087
Merge branch 'master' into combo-colour-brightness-limit
2022-11-05 16:48:56 +01:00
Salman Ahmed
c27f7fa421
Merge branch 'master' into song-select-transition-improvement
2022-11-04 20:16:02 +03:00
Salman Ahmed
ee6f036c44
Add note about using ExceptBy
once it's available
2022-11-04 19:35:24 +03:00
Salman Ahmed
ce5aacb760
Filter out duplicated cards using custom equality comparer instead
2022-11-04 19:27:35 +03:00
Salman Ahmed
bd512c4937
Remove equality comparison implementation from BeatmapCard
...
This turned out to be a hurdle instead as it disallows adding two
beatmap cards of equal beatmap, which, while being a good behaviour in
client, makes tests more complicated to work.
2022-11-04 19:27:20 +03:00
Dan Balasescu
d426977f03
Handle channel joins
2022-11-04 20:11:42 +09:00
Dan Balasescu
f12ada9d92
Fix chat connecting too early
2022-11-04 19:36:24 +09:00
Dean Herbert
78bb940e6c
Don't play hover sounds on disabled elements
2022-11-04 19:06:08 +09:00
Dean Herbert
0e350f52f5
Fix SliderBar
disabled value potentially not transferring to hover sounds
2022-11-04 19:06:08 +09:00
Dean Herbert
a2fdad4afc
Fix slider updating glow when disabled
2022-11-04 19:06:08 +09:00
Dean Herbert
a16540dc6d
Update Nub
hover animation to better suit immediacy of sound effects
2022-11-04 19:06:08 +09:00
Dan Balasescu
1d2818dc70
Reschedule ack request on completion
2022-11-04 19:02:26 +09:00
Dan Balasescu
66bbe34116
Move polling clients to osu.Game.Tests namespace
2022-11-04 18:52:57 +09:00
Dean Herbert
8b58475ee0
Update OsuButton
hover animation to better suit immediacy of sound effects
2022-11-04 18:51:09 +09:00
Dan Balasescu
fa18b5f701
Construct notifications client inside ChannelManager
2022-11-04 18:51:00 +09:00
Dan Balasescu
72745656e7
Remove StartChat()/chat enablement
2022-11-04 18:48:34 +09:00
Dan Balasescu
58396d49dc
Fix handling of local echo deduplication
2022-11-04 18:44:22 +09:00
Dean Herbert
4f14ae4e34
Adjust transition effect for main menu backgrounds
2022-11-04 17:45:14 +09:00
Dean Herbert
4bbff99f31
Remove unnecessary fade in SeasonalBackground
2022-11-04 17:45:14 +09:00
Dean Herbert
2b934e0bea
Increase delay for changing background on returning to main menu
2022-11-04 17:45:13 +09:00
Dean Herbert
923d44a769
Update dependencies
2022-11-04 17:00:58 +09:00
Dean Herbert
566738494f
Merge pull request #20952 from OliBomby/bezier-convert
...
Add conversion algorithm for lazer slider curves to work with stable
2022-11-04 16:49:51 +09:00
Dean Herbert
c40c70509e
Improve song select transition to gameplay
2022-11-04 15:24:37 +09:00
Joseph Madamba
e11d44d14f
Add url clicking support to profile badges
2022-11-03 18:12:32 -07:00
Salman Ahmed
ac8fb4f9b2
Fix beatmap cards still potentially showing twice in listing
2022-11-04 03:23:34 +03:00
C0D3 M4513R
21effc5f54
Merge remote-tracking branch 'origin/beatmap-info' into beatmap-info
2022-11-03 18:55:06 +01:00
C0D3 M4513R
a435e365ea
Allow for the Value of BeatmapInfoDrawable to be formatted
2022-11-03 18:54:55 +01:00
Dean Herbert
f6c376c090
Minor refactoring
2022-11-03 20:29:27 +09:00
Dean Herbert
f75c4ba95f
Update resources
2022-11-03 20:27:44 +09:00
Dean Herbert
1edde8f73c
Merge branch 'master' into disabled-button-sfx
2022-11-03 20:27:41 +09:00
Dean Herbert
cdb3494418
Merge pull request #20765 from Feodor0090/comment-report
...
Implement comments reporting
2022-11-03 20:09:00 +09:00
Dean Herbert
486515ed90
Merge pull request #20758 from frenzibyte/maintain-common-mod-selection
...
Maintain selection of common mods when switching rulesets
2022-11-03 20:08:32 +09:00
Jamie Taylor
59bbd9c460
Fix some components using wrong sample set
2022-11-03 17:47:49 +09:00
Jamie Taylor
f1c17129eb
Add support for 'disabled' sample variation to HoverClickSounds
2022-11-03 17:47:49 +09:00
C0D3 M4513R
2ec29c0f26
Merge branch 'master' into beatmap-info
2022-11-03 07:09:02 +00:00
C0D3 M4513R
502bfa950e
Fix potential resource leak
2022-11-03 08:05:26 +01:00
Dean Herbert
c48c9ecb6d
Merge pull request #20743 from frenzibyte/improve-beatmap-card-buttons
...
Improve clickable area of beatmap card icon buttons
2022-11-03 15:47:08 +09:00
Dean Herbert
e336d486a6
Merge pull request #21093 from peppy/auto-skip-multiple-times
...
Fix automated skip not skipping more than once when required
2022-11-03 15:46:56 +09:00
Dean Herbert
56ef519cc2
Move PopoverContainer
into OnlineOverlay
to ensure correct colours
2022-11-03 15:43:06 +09:00
Dean Herbert
e6c45b8ab5
Merge branch 'master' into comment-report
2022-11-03 15:35:42 +09:00
Dean Herbert
20dd405c2b
Merge branch 'master' into maintain-common-mod-selection
2022-11-03 15:32:40 +09:00
Dean Herbert
07bfac40fa
Adjust padding to avoid overlap with card border when expanded
2022-11-03 14:03:28 +09:00
Dean Herbert
66a6084d3f
Scale in the background fill alongside the icon
2022-11-03 14:03:19 +09:00
Dan Balasescu
fc191807c6
Fix velocity test failing with no audio device
2022-11-03 13:59:22 +09:00
Dean Herbert
df9f49eef2
Move hover layer behind icon
...
Looked bad on the "already downloaded" state where the icon becomes
black.
2022-11-03 13:56:07 +09:00
Dean Herbert
fb0bc597a0
Merge branch 'master' into improve-beatmap-card-buttons
2022-11-03 13:53:29 +09:00
Dean Herbert
4154be6cda
Adjust auto-skip to skip multiple times if necessary
2022-11-03 13:52:29 +09:00
Dean Herbert
aef3c7918c
Add total skip count to SkipOverlay
2022-11-03 13:52:24 +09:00
C0D3 M4513R
49427fe8b7
Merge branch 'master' into beatmap-info
2022-11-02 15:38:15 +00:00
C0D3 M4513R
95e2521ca4
Use more Localisations
2022-11-02 13:56:55 +01:00
C0D3 M4513R
2e5db5e259
Remove nullable disable from TextElement
2022-11-02 13:24:05 +01:00
C0D3 M4513R
ed7e3a29e2
Add Localisation
...
Also add Labels for what is displayed, and prefix/suffix for Labels
Add a Prefix and Suffix for Values
2022-11-02 13:00:45 +01:00
cdwcgt
7073d8dd8e
range and precision for EditorDim
2022-11-02 19:57:01 +09:00
cdwcgt
a44c7c7514
range and precision for EditorWaveformOpacity
2022-11-02 19:56:35 +09:00
Dean Herbert
3ec9686e58
Fix test failures and rename configuration value to match better
2022-11-02 18:15:18 +09:00
Dean Herbert
0e502de8b4
Rename field to match usage
2022-11-02 18:04:42 +09:00
Dean Herbert
4f8e912f06
Fix APINotification
parsing failing
2022-11-02 17:53:19 +09:00
Dean Herbert
c3eb0c6330
Merge branch 'master' into editor-background
2022-11-02 17:43:38 +09:00
Dan Balasescu
063a8bdf9e
Remove messages from silenced users
2022-11-02 17:13:14 +09:00
Dan Balasescu
f688ed12d0
Add test for removing chat messages
2022-11-02 17:00:47 +09:00
Dan Balasescu
cb51fc7384
Merge pull request #21071 from peppy/fix-multiple-import-notifications
...
Fix multiple notifications arriving for imports in edge cases
2022-11-02 16:54:56 +09:00
Dan Balasescu
db34f238c0
Fix inverted condition
2022-11-02 15:47:30 +09:00
Dan Balasescu
e5f53b1ad8
Use Interlocked.Exhange() instead
...
Increment isn't correct since it returns the post-incremented value. It
also always increments.
2022-11-02 15:18:48 +09:00
cdwcgt
9884618290
rename editorDim
to editorBackgroundDim
2022-11-02 15:12:15 +09:00
cdwcgt
d6b8439121
add xmldoc for DimAmount
2022-11-02 15:11:49 +09:00
cdwcgt
df1f7e2b13
remove #nullable disable
2022-11-02 15:09:40 +09:00
Dean Herbert
2b04e852be
Merge branch 'master' into websocket-chat-2
2022-11-02 14:56:13 +09:00
Dan Balasescu
22f662a076
Merge pull request #21070 from peppy/standardise-visual-settings-ui-components
...
Standardise "Visual Settings" components to fix mismatched paddings and labels
2022-11-02 14:53:00 +09:00
Dean Herbert
e761c0395d
Fix multiple notifications arriving for imports in edge cases
2022-11-02 14:47:56 +09:00
Dean Herbert
4dabb1aa9c
Merge pull request #20990 from smoogipoo/socket-client
...
Generalise `HubClientConnector` into `SocketClientConnector`
2022-11-02 14:17:36 +09:00
Dean Herbert
37300ba9e2
Standardise "Visual Settings" components to fix mismatched paddings and labels
2022-11-02 14:01:57 +09:00
Dean Herbert
50b6fe4acb
Localise new label
2022-11-02 14:01:03 +09:00
Dean Herbert
61fc3c8cc0
Add setting to visual settings toolbox
2022-11-02 13:58:34 +09:00
Dean Herbert
5b8699872f
Merge branch 'standardise-visual-settings-ui-components' into combo-colour-brightness-limit
2022-11-02 13:58:33 +09:00
Dean Herbert
d8aa06ea92
Standardise "Visual Settings" components to fix mismatched paddings and labels
2022-11-02 13:55:56 +09:00
Dean Herbert
99ba7c29dd
Change range to 0-100% and rename to "normalisation"
2022-11-02 13:47:11 +09:00
Dan Balasescu
30800c9252
Add/adjust xmldocs
2022-11-02 13:16:34 +09:00
Dean Herbert
2f3c80f884
Remove toggle and change method of application to blend with original colour
2022-11-02 13:08:29 +09:00
Dean Herbert
a01602e63c
Merge branch 'master' into combo-colour-brightness-limit
2022-11-02 12:09:27 +09:00
Dan Balasescu
3816152c9d
Merge branch 'socket-client' into websocket-chat-2
2022-11-02 11:49:57 +09:00
Dan Balasescu
e59c8b7d24
Use IDisposable instead
2022-11-02 11:49:04 +09:00
Dan Balasescu
c9108ce41b
Rename StartAsync -> ConnectAsync
2022-11-02 11:44:16 +09:00
Dan Balasescu
46d1713e28
Rename Socket* -> PersistentEndpoint*
2022-11-02 11:43:22 +09:00
Dan Balasescu
8ac2075c61
Fix possible threading issues
...
Not really sure of the best way to handle this in general. It could be
argued that this should be a `Component` type and the bindable bound in
`LoadComplete()`...
2022-11-02 10:04:25 +09:00
C0D3 M4513R
975eed964e
Don't make Beatmap in OsuGameBase public
...
Signed-off-by: C0D3 M4513R <28912031+C0D3-M4513R@users.noreply.github.com>
2022-11-01 21:19:01 +01:00
C0D3 M4513R
c231a20cbb
Add a generic text Element
...
Signed-off-by: C0D3 M4513R <28912031+C0D3-M4513R@users.noreply.github.com>
2022-11-01 20:54:52 +01:00
C0D3 M4513R
905ebc3c1f
Initial implementation of a Beatmap Information Skinning Element
...
Signed-off-by: C0D3 M4513R <28912031+C0D3-M4513R@users.noreply.github.com>
2022-11-01 20:46:32 +01:00
Dean Herbert
9f031b55a1
Merge branch 'master' into fix-directory-selector-breadcrumb
2022-11-01 22:28:13 +09:00
Dean Herbert
e104242864
Update framework
2022-11-01 22:28:06 +09:00
Dan Balasescu
5b25ef5f2f
Construct notifications client via IAPIProvider
2022-11-01 21:34:34 +09:00
Bartłomiej Dach
ac554c644d
Merge branch 'master' into fix-slider-sv-snap
2022-11-01 13:19:46 +01:00
Dan Balasescu
5621db8a2e
Merge pull request #21052 from peppy/fix-control-point-info
...
Fix control points not being cloned when running beatmap conversion
2022-11-01 21:04:49 +09:00
Dean Herbert
f014acfc8d
Fix DrawableHitObject.AccentColour
not being updated if object entry is not attached
2022-11-01 19:34:53 +09:00
Dean Herbert
27af91003b
Merge branch 'master' into combo-colour-brightness-limit
2022-11-01 17:50:26 +09:00
Dean Herbert
978d15955c
Fix control points not being cloned when running beatmap conversion
...
Closes #20994 .
I haven't considered how this affects performance of difficulty
calculation or otherwise. Seems like a sane initial fix which we can
iterate on going forward.
I've tested using the scenario in the linked issue.
I'm not going to add test coverage because
[BeatmapConversionTest](https://github.com/ppy/osu/blob/master/osu.Game/Tests/Beatmaps/BeatmapConversionTest.cs )
should correctly cover this scenario once we are serialising control
points as well.
2022-11-01 17:42:09 +09:00
Dean Herbert
29bc653d24
Remove incorrect double multiplication and add missing test coverage
2022-11-01 17:17:54 +09:00
Dean Herbert
d15585153d
Fix breadcrumb display in directory selector overlapping new "show hidden" button
...
Closes #21034 .
2022-11-01 17:07:59 +09:00
Dean Herbert
8280605e92
Fix notch toggle not applying correctly after restart
2022-11-01 16:31:09 +09:00
Dean Herbert
2a88409dfe
Fix time snap of sliders not matching when SV is not 1.0x
...
This regressed with https://github.com/ppy/osu/pull/20850 because the
function was used in other places which expect it to factor slider
velocity into the equation.
Rather than reverting, I've added a new argument, as based on the method
naming alone it was hard to discern whether SV should actually be
considered.
The reason for the change in #20850 was to avoid the SV coming in from a
reference object which may not have a correct SV in the first place. In
such cases, passing `false` to the function will give the expected
behaviour.
2022-11-01 15:12:58 +09:00
Dean Herbert
706adfb28c
Improve messaging when ruleset load fails
2022-11-01 13:57:34 +09:00
OliBomby
0461303895
Change return type to List
2022-10-31 11:39:41 +01:00
OliBomby
414e21c657
Added xmldoc to public methods
2022-10-31 11:39:14 +01:00
Dean Herbert
17f482bfc3
Merge branch 'master' into websocket-chat-2
2022-10-31 16:11:58 +09:00
Dean Herbert
8a37649097
Merge branch 'master' into socket-client
2022-10-31 16:00:14 +09:00
Dean Herbert
94dd4045f1
Remove borrowed framework code
2022-10-31 15:42:17 +09:00
Dean Herbert
31ba77e378
Merge branch 'master' into bezier-convert
2022-10-31 15:41:08 +09:00
Dean Herbert
9ea2bd84bd
Merge pull request #21018 from andy840119/reuse-the-function-in-timeline-class
...
Reuse function in the timeline class
2022-10-30 23:49:02 +09:00
Dean Herbert
1035b5fb19
Fix hold to pause button not working when HUD is hidden
2022-10-30 21:38:45 +09:00
andy840119
a753369d3e
Reuse function TimeAtPosition()
and PositionAtTime()
.
2022-10-30 17:21:50 +08:00
andy840119
4c9c65856c
Remove the nullable disable annotation in the testing beatmap and mark some of the properties as nullable.
...
This class will be used in some check test cases.
2022-10-30 17:03:54 +08:00
andy840119
a1a9238bd1
Use empty string instead of null because issue template not accept null.
2022-10-30 16:31:07 +08:00
andy840119
505ec800da
File name should be nullable.
2022-10-30 16:29:54 +08:00
andy840119
db48a57fa7
Remove nullable disable annotation in some checks class.
2022-10-30 16:28:49 +08:00
andy840119
24c27e62f6
Remove nullable disable annotation in the issue and issue template-related class.
2022-10-30 16:25:15 +08:00
Joseph Madamba
d56786b5ff
Fix toolbar visual bug when toggling clock displays
2022-10-29 15:25:16 -07:00
Bartłomiej Dach
71d87489ab
Merge branch 'master' into safe-area-toggle
2022-10-29 13:19:44 +02:00
Bartłomiej Dach
f775741d65
Merge branch 'master' into fix-filename-char-filtering
2022-10-29 12:42:10 +02:00
Bartłomiej Dach
87fc5be562
Merge branch 'master' into improve-argon-bananas
2022-10-29 12:09:24 +02:00
ansel
9df96aab38
Remove local popover containers
2022-10-28 22:17:45 +03:00
ansel
295c40581b
Add a global popover container
2022-10-28 20:18:11 +03:00
D.Headley
21d68bfb84
Delete unused button
2022-10-28 16:40:21 +02:00
Dean Herbert
0c25658805
Update framework
2022-10-28 21:58:38 +09:00
Dan Balasescu
d3173ab1bd
Remove weird cast
2022-10-28 18:54:34 +09:00
Dan Balasescu
ab78cde2d4
Fix crossthread mutations
2022-10-28 18:37:43 +09:00
Dan Balasescu
169bcc2654
Use polling connector in tests
2022-10-28 18:08:08 +09:00
Dean Herbert
f46a9d683a
Fix null reference in headless tests
2022-10-28 18:07:25 +09:00
Dean Herbert
66ed77ac91
Rename and add documentation to function
2022-10-28 18:04:28 +09:00
Dan Balasescu
527b1d9db1
Generalise + add polling-style for usage in tests
2022-10-28 17:53:28 +09:00
Dean Herbert
92167afaab
Merge pull request #20842 from frenzibyte/fix-input-sections-in-tests
...
Fix input settings not displaying in visual test browser
2022-10-28 17:27:15 +09:00
Dean Herbert
8c057b3af7
Add comment explaining why handlers are added in OsuGameBase
2022-10-28 17:26:53 +09:00
Dean Herbert
a826f778bf
Merge pull request #20984 from smoogipoo/fix-missing-beatmap-ruleset
...
Populate beatmap ruleset in `SoloScoreInfo.ToScoreInfo()`
2022-10-28 17:19:14 +09:00
Dan Balasescu
efa8256911
Use more verbatim strings
2022-10-28 16:32:17 +09:00
Dan Balasescu
2f731f86ba
Adjust ChannelManager to use notifications client
2022-10-28 16:28:58 +09:00
Dan Balasescu
33bb1212d1
Add notifications websocket + chat implementation
2022-10-28 16:28:58 +09:00
Joseph Madamba
87328dd1f5
Fix bar hit error meter labels not clearing when setting to none
2022-10-27 23:59:01 -07:00
Dan Balasescu
eeee928f73
Merge pull request #20946 from peppy/argon-catch
...
Add first pass osu!catch "argon" skin
2022-10-28 15:45:46 +09:00
nullium21
6901ed997d
One more little change
...
Damn, i forgor. Sorry, CI runners.
2022-10-28 09:22:08 +03:00
nullium21
c1e9398c19
Fix regex by allowing file extensions + typed new
...
Apparently, the _whole_ filename was checked with GetValidArchiveContentFilename,
not just the stem.
2022-10-28 09:19:34 +03:00
Dan Balasescu
b3219526a5
Populate beatmap ruleset in SoloScoreInfo.ToScoreInfo()
2022-10-28 14:42:45 +09:00
Dan Balasescu
51d8392e7f
Merge pull request #20982 from peppy/remove-obsoleted-simple
...
Clean up various obsoleted code
2022-10-28 14:36:04 +09:00
Dean Herbert
f9d2c30c3e
Add user toggle for application of safe areas
2022-10-28 14:05:45 +09:00
Dean Herbert
42eafe318c
Remove various simple obsoletions
2022-10-28 13:20:58 +09:00
Dean Herbert
21f8a91efb
Remove obsoleted int
parsing logic of configuration ruleset
2022-10-28 13:12:21 +09:00
Dean Herbert
08832ae593
Remove obsoleted PositionalHitsounds
global setting
2022-10-28 13:09:39 +09:00
Dean Herbert
71970d83cf
Remove obsoleted ShowProgressGraph
global setting
...
This was moved to the component itself.
2022-10-28 12:47:45 +09:00
Dean Herbert
dcff8a193c
Use better method of forcing serialisation
2022-10-28 01:26:10 +09:00
Dean Herbert
3c4ba6e9fc
Fix SoloScoreInfo.Rank
not being serialised if rank is D
2022-10-27 19:02:32 +09:00
Dean Herbert
6fe8298152
Update framework
2022-10-27 19:02:01 +09:00
nullium21
68d1febe6e
Use a regex for matching invalid characters instead
...
What the regex does is it matches everything except alphanumeric and [_()[] -], excluding EOL since regex101 seems to also match it, and we probably don't want that to happen.
2022-10-27 10:33:50 +03:00
Dan Balasescu
6cca3a3dc8
Add new API requests
2022-10-27 14:55:24 +09:00
Dan Balasescu
4127aaa988
Extract general elements from HubClientConnector into SocketClientConnector
2022-10-27 14:37:10 +09:00
Dean Herbert
14c7cbde38
Fix toggle mute (and volume meter traversal) handling repeat key presses
...
Closes #20953 .
2022-10-27 11:41:00 +09:00
Dean Herbert
1b2ee44131
Merge pull request #20658 from sw1tchbl4d3r/fix-17143
...
Fix legacy BpmMultiplier clamp value
2022-10-27 11:27:59 +09:00
Joseph Madamba
0efbae6e70
Fix osu! logo drag area being a square
2022-10-26 18:33:07 -07:00
Bartłomiej Dach
71425ba937
Merge branch 'master' into read-current-distance-snap
2022-10-26 22:46:42 +02:00
Bartłomiej Dach
f787da892b
Merge branch 'master' into grid-momentary-shortcuts
2022-10-26 21:30:24 +02:00
OliBomby
86d5fcc26d
Added tests
2022-10-26 19:30:42 +02:00
OliBomby
77dcd0fae2
Create BezierConverter.cs
2022-10-26 17:21:20 +02:00
nullium21
dffebdf7ed
Only use 0-9A-Za-z-_()[] characters in filenames
2022-10-26 13:31:32 +03:00
cdwcgt
6991195d69
let editor dim different from gameplay dim
2022-10-26 15:22:57 +09:00
Dean Herbert
6b53ea3400
Enable distance snapping when DS value is changed via user interaction
2022-10-26 13:37:01 +09:00
Dean Herbert
7d59bc6e2f
Merge branch 'grid-momentary-shortcuts' into read-current-distance-snap
2022-10-26 13:28:04 +09:00
Dean Herbert
54ae16badc
Move distance snap toggle button implementation to DistancedHitObjectComposer
2022-10-26 13:27:23 +09:00
Dean Herbert
8d9a85e9e5
Fix typos in xmldoc
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-10-26 13:14:12 +09:00
Dean Herbert
2016d33055
Offset start of distance snap grid drawing if reference object's start time doesn't align
...
Closes #20938 .
2022-10-26 13:11:26 +09:00
Dean Herbert
7249542167
Merge pull request #20912 from LittleEndu/carousel-do-not-select-random
...
Make beatmap carousel select nearest to selection when selection was filtered
2022-10-26 11:40:56 +09:00
Dean Herbert
d9d083752a
Clamp backwards index to total current items to fix edge case of item removal
2022-10-26 11:03:11 +09:00
Joseph Madamba
8505848b1a
Scroll beatmap listing to top when searching via tags/source
2022-10-25 18:06:49 -07:00
Bartłomiej Dach
48057412f5
Merge branch 'master' into grid-momentary-shortcuts
2022-10-25 22:17:08 +02:00
Bartłomiej Dach
f5ca447b8e
Rename one more "{duplicate -> clone}" reference
2022-10-25 21:34:41 +02:00
Bartłomiej Dach
bcdf24b972
Merge branch 'master' into add-editor-object-clone
2022-10-25 21:33:52 +02:00
Bartłomiej Dach
3d31c9bbc5
Merge branch 'master' into beat-snap-divisor-hotkey
2022-10-25 20:32:32 +02:00
Dean Herbert
cf3bf41b49
Harden and simplify logic to avoid weird issues
2022-10-25 18:57:15 +09:00
Dean Herbert
da93849b80
Rename some pieces and better document SampleBankInfo
2022-10-25 14:55:33 +09:00
Dean Herbert
2b850694fa
Merge branch 'allow-distance-grid-snap' into grid-momentary-shortcuts
2022-10-25 14:10:45 +09:00
Dan Balasescu
6177df2a24
Merge branch 'master' into fix-17143
2022-10-25 13:44:58 +09:00
Dean Herbert
22ea9a8ab4
Add early return of carousel group has no items
2022-10-25 13:34:22 +09:00
cdwcgt
f9c6190426
Add DimAmount for UserDimContainer
2022-10-25 13:00:53 +09:00
Dean Herbert
2456a18bc1
Rewrite implementation to avoid duplicated LINQ returns
2022-10-25 12:48:17 +09:00
Dean Herbert
4d4f6e25ba
Rename to "clone" instead of "duplicate"
2022-10-25 11:43:23 +09:00
Dean Herbert
1e579e06f8
Fix duplicate working incorrectly if there is no selection currently made
2022-10-25 11:42:12 +09:00
Dean Herbert
da74690ec9
Add test coverage of clone operations
2022-10-25 11:38:58 +09:00
Endrik Tombak
5a118cfdc3
Merge branch 'master' of https://github.com/ppy/osu into carousel-perform-selection
...
Conflicts:
osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapCarousel.cs
2022-10-24 21:40:48 +03:00
cdwcgt
a2682b3ce3
background dim settings for editor
...
View -> Background Dim
follow `DimLevel` and `BlurLevel`
Co-Authored-By: Dead_Bush_Sanpai <DeadBushSanpai@yandex.com>
2022-10-24 23:55:33 +09:00
cdwcgt
de881cc5cb
useless #nullable disable
2022-10-24 23:17:28 +09:00
Dean Herbert
247cf589aa
Merge branch 'master' into directoryselector-hidden-toggle
2022-10-24 15:33:10 +09:00
Dean Herbert
995216cced
Merge pull request #20819 from Joppe27/taiko-kiai-flashing
...
Implement taiko hitobject kiai flashing
2022-10-24 15:31:13 +09:00
Dean Herbert
1d5df15027
Add ability to use Shift
+Number
to set current beat divisor in editor
2022-10-24 15:20:15 +09:00
Dean Herbert
d0e6bda9ef
Stop HitObjectComposer
from handling Shift
+Number
keys
2022-10-24 15:19:36 +09:00
Dean Herbert
e72a71a28e
Add simple editor "duplicate objects" key binding
2022-10-24 14:01:34 +09:00
Dean Herbert
e9b3048a8b
Change the order of global bindings to give overlays lowest priority
2022-10-24 13:58:00 +09:00
Bartłomiej Dach
a55f91f54b
Merge branch 'master' into read-current-distance-snap
2022-10-24 00:15:15 +02:00
Bartłomiej Dach
3a6a87db0f
Merge branch 'master' into fix-editor-distanct-snap-sv-accounting
2022-10-23 18:42:08 +02:00
Susko3
a35026d537
Downgrade AutoMapper to fix Android startup crash
2022-10-22 23:29:44 +02:00
Dean Herbert
9155fcf3cb
Update framework
2022-10-22 23:25:08 +09:00
Dean Herbert
3d37a67590
Update framework
2022-10-22 14:15:17 +09:00
Salman Ahmed
b0a4cd4f30
Inline content creation in base add method
2022-10-22 03:43:14 +03:00
Salman Ahmed
6c82bc36ed
Encapsulate report logic inside button implementation
...
Avoids complicating the `DrawableComment` class, and allows for isolated
testability.
2022-10-22 02:48:27 +03:00
Salman Ahmed
9b5e35d599
Remove dependency on DrawableComment
from report popover and simplify logic
...
Allows for testing the button and popover in isolation.
2022-10-22 02:47:33 +03:00
Salman Ahmed
081cf1cc47
Adjust comment report popover design
2022-10-22 02:45:31 +03:00
Salman Ahmed
0491b1fd18
Merge branch 'master' into update-framework
2022-10-21 22:39:56 +03:00
Dean Herbert
c1ed775deb
Update framework
2022-10-21 23:36:16 +09:00
Dean Herbert
f516e32949
Improve UI a bit
2022-10-21 23:35:53 +09:00
Dean Herbert
bb921ff9a7
Fix incorrect current DS value when inside a slider
2022-10-21 23:35:47 +09:00
ansel
15aeb4a137
Display text in buttons flow instead of toast
2022-10-21 17:25:41 +03:00
Dean Herbert
f6de366766
Combine display and button into one control
2022-10-21 23:21:07 +09:00
Dean Herbert
645a84b1d6
Display current distance snap and add button to update to use it
2022-10-21 22:58:36 +09:00
Dean Herbert
7dc03097ff
Change distance snap to never account for slider velocity
...
This is a nuanced detail that was implemented incorrectly from the
outset. When mapping, generally a mapper chooses the distance spacing
with no regard to the SV. It has always been common to have a lower
or higher distance spacing than SV, but with the way the lazer editor
has worked, the SV was multiplied into the distance snap grid display,
incorectly changing its spacing depending on the "reference object"
(which is usually the previous hitobject chronologically).
2022-10-21 21:51:24 +09:00
Dean Herbert
447d420c99
Fix adjusting volume via settings playing tick samples twice
2022-10-21 21:03:39 +09:00
Dean Herbert
4803f606c2
Merge pull request #20845 from nekodex/settings-sidebar-sfx
...
Add unique hover/select samples to settings sidebar buttons
2022-10-21 20:56:58 +09:00
Dean Herbert
8b74b5807f
Update resources
2022-10-21 20:53:37 +09:00
Dean Herbert
af84f708b7
Avoid serialising some more properties of SoloScoreInfo
unless present
2022-10-21 19:30:35 +09:00
Jamie Taylor
7b1edff2b3
Add unique hover/select samples to settings sidebar buttons
2022-10-21 18:06:38 +09:00
Dean Herbert
6cdfddea62
Always enable distance spacing when adusting distance space multiplier
2022-10-21 16:10:55 +09:00
Dan Balasescu
703a8afb11
Merge pull request #20809 from peppy/fix-taiko-broken-drum-roll-ticks
...
Fix taiko drum roll ticks sometimes overflowing outside the drum roll itself
2022-10-21 12:56:14 +09:00
Dean Herbert
7dbd6e2469
Merge branch 'master' into taiko-kiai-flashing
2022-10-21 12:48:35 +09:00
Salman Ahmed
27ce3d8342
Fix input settings not displaying in visual test browser
2022-10-21 01:52:19 +03:00
Joseph Madamba
bf4a91f1f0
Fix skin toolbox component button not playing hover/click sounds
2022-10-20 13:16:03 -07:00
ansel
81bdf716ef
Change test
2022-10-20 19:56:00 +03:00
ansel
0ef903230c
Make report button a separate component
2022-10-20 18:47:42 +03:00
ansel
da4f04ace7
Make dropdown not resize
2022-10-20 18:22:55 +03:00
ansel
635900085c
Disable button when there is no text
2022-10-20 18:12:20 +03:00
ansel
ed39481932
Use another string for title
2022-10-20 18:11:35 +03:00
Dean Herbert
5c13c443ff
Fix incorrect fallback logic
...
Regressed when attempting to share implementation of binary search.
2022-10-20 23:08:44 +09:00
Dean Herbert
26860a903e
Refactor implementation to support hitobjects nested multiple levels deep
2022-10-20 22:30:30 +09:00
Dean Herbert
a754dc6d3b
Expose binary search methods publicly
...
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2022-10-20 14:34:07 +09:00
Dan Balasescu
fd7274095f
Merge pull request #20826 from peppy/fix-missing-beatmap-backgrounds
...
Fix some older beatmaps having missing backgrounds
2022-10-20 12:46:24 +09:00
Dean Herbert
cc311eef2a
Merge pull request #20834 from frenzibyte/fix-slider-ball-tint
...
Enable slider ball tint on "classic" skin
2022-10-20 12:34:45 +09:00
Dean Herbert
6b26547d03
Merge pull request #20835 from frenzibyte/improve-hide-mouse-on-keyboard
...
Improve automatic cursor hiding logic and limit to gameplay screen
2022-10-20 11:44:20 +09:00
Dean Herbert
2f8a4fd2d0
Merge branch 'master' into remove-current-item
2022-10-20 10:02:09 +09:00
Dean Herbert
77b25c4a5c
Merge pull request #20788 from frenzibyte/handle-submitting-player-request-timeout
...
Fix potential exception in `SubmittingPlayer` token retrieval on request timeout
2022-10-20 09:51:57 +09:00
Salman Ahmed
39650717ea
Improve input detection to not make cursor flicker on combined input
2022-10-20 03:45:25 +03:00
Salman Ahmed
4bf4938b72
Keep cursor hiding feature to gameplay screens for now
2022-10-20 03:44:58 +03:00
Salman Ahmed
eb386d4bd5
Enable slider ball tint in default legacy skin
2022-10-20 03:29:25 +03:00
Dean Herbert
a7d4a74ed6
Update osu.Game/Tests/Visual/ScrollingTestContainer.cs
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-10-20 08:07:56 +09:00
Dean Herbert
78943a21d8
Update osu.Game/Beatmaps/ControlPoints/IControlPoint.cs
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-10-20 08:06:05 +09:00
ansel
57320074a0
Fix accidental breakage of changelog layout
2022-10-20 01:24:36 +03:00
Dean Herbert
59e2478b0e
Fix some older beatmaps having missing backgrounds
...
Closes https://github.com/ppy/osu/issues/20824 .
Note that this will require a reimport of beatmaps as it is baked into the database. Probably not worth making a migration for at this point in time.
2022-10-19 16:01:10 +09:00
Joppe27
9b123e7365
Adjust flash intensity and fade values to feel better
2022-10-19 00:51:44 +02:00
Joppe27
a76a039722
Rename KiaiFlashingDrawable and move to osu.Game
2022-10-18 23:40:43 +02:00
Dean Herbert
d237c818f6
Fix nested objects in overlapping scrolling hit object container ruleset not using correct reference time
2022-10-18 16:15:21 +09:00
Dean Herbert
ec3761ced9
Standardise control point search logic in OverlappingScrollAlgorithm
...
Was using a very local algorithm which I cannot guarantee is correct.
I'd rather it just use the one used everywhere else.
2022-10-18 16:01:05 +09:00
Dean Herbert
fbad33bef7
Adjust durations and make start off screen
2022-10-18 15:01:53 +09:00
Dean Herbert
6b42f1931a
Remove autosize easing in SettingsToolboxGroup
...
It just feels like unnecessary motion.
2022-10-18 15:01:26 +09:00
Dean Herbert
84688b53a1
Merge branch 'fix-editor-padding' into player-loader-improvements
2022-10-18 14:52:59 +09:00
Dean Herbert
860214c22a
Adjust paddings to feel better now that backgrounds are visible of toolboxes
2022-10-18 14:38:45 +09:00
Dean Herbert
6a7f6c76ff
Fix osu! editor padding being applied to toolboxes
...
The result of https://github.com/ppy/osu/pull/20739 and https://github.com/ppy/osu/pull/20738 having unintended side effects when applied together.
2022-10-18 14:32:00 +09:00
Dean Herbert
0f809dcaa7
Merge branch 'master' into player-loader-improvements
2022-10-18 14:22:55 +09:00
Dean Herbert
72be4940fd
Merge branch 'master' into comment-report
2022-10-18 13:52:33 +09:00
Dean Herbert
ccbac08985
Merge pull request #20593 from ekrctb/catch-editor-height
...
Allow arbitrary height catch editor
2022-10-18 12:10:49 +09:00
ansel
3258a41ca3
Merge branch 'comment-report' of https://github.com/Feodor0090/osu into comment-report
2022-10-17 20:41:46 +03:00
ansel
cd77ae062e
Localize the button
2022-10-17 20:41:23 +03:00
ansel
797acf334f
Show username in popup
2022-10-17 20:41:13 +03:00
Feodor0090
6efe7b5334
Merge branch 'master' into comment-report
2022-10-17 16:08:13 +03:00
ansel
ceb4d624b5
Delete wip form
2022-10-17 13:43:35 +03:00
ansel
ffa22d8a68
Update popover not to use labelled drawables
2022-10-17 13:42:17 +03:00
ansel
d7e5bcbd3c
Add popover containers to overlays
2022-10-17 13:41:46 +03:00
Dean Herbert
516320edd9
Merge branch 'master' into handle-submitting-player-request-timeout
2022-10-17 18:51:13 +09:00
Dan Balasescu
4220d6b3fc
Merge pull request #20780 from outfoxxed/fix-hiterror-icons
...
Fix hit error bar icon orientation
2022-10-17 18:48:31 +09:00
ansel
7ed26369a3
Make a new report form, closer to web
2022-10-17 12:41:57 +03:00
Dean Herbert
1e7b8cd227
Fix formatting issues
2022-10-17 13:22:06 +09:00
Salman Ahmed
ae05f374a2
Fix potential invalid operation exception in SubmittingPlayer
token retrieval
2022-10-17 03:26:29 +03:00
outfoxxed
85de802793
Only create hit error bar icon containers once
...
Move icon container creation to BDL, and only recreate the contained
icon when `recreateLabels` is called
2022-10-16 11:47:21 -07:00
Bartłomiej Dach
d0a495717e
Merge branch 'master' into comment-copy-link
2022-10-16 19:56:06 +02:00
ansel
4a8d976cb4
Use api's endpoint
2022-10-16 20:20:34 +03:00
ansel
e1785f73a2
Make report's comment not optional
2022-10-16 20:14:05 +03:00
outfoxxed
d6030891a2
Reuse existing code in hit error bar fix
...
Use `UprightAspectMaintainingContainer` instead of a local fix for
hit error bar orientation
2022-10-16 10:06:38 -07:00
ansel
ba595ab8fa
Display toast instead of notification
2022-10-16 19:57:21 +03:00
ansel
9822a092c4
Add localization for enum
2022-10-16 19:50:55 +03:00
outfoxxed
cd1885a17b
Fix hit error bar icon orientation
...
Icons now keep their original orientation when the hit error bar is
flipped
2022-10-16 02:55:10 -07:00
Salman Ahmed
1824b1deee
Merge branch 'master' into tablet-button-binding
2022-10-16 04:10:04 +03:00
Aki
91358f4a6a
Implement tablet button bindings
2022-10-15 15:16:14 +08:00
Salman Ahmed
324c749383
Merge branch 'master' into player-loader-improvements
2022-10-15 03:07:15 +03:00
Salman Ahmed
241ecb63a1
Hide manual input manager cursor in OsuGameTestScene
s
...
Allows checking that the cursor is actually hidden in
`TestSceneOsuGame.TestCursorHidesWhenIdle`.
2022-10-15 00:20:22 +03:00
Salman Ahmed
06e6713237
Move mouse input detection inside MenuCursorContainer
to allow testing
2022-10-15 00:20:22 +03:00
Salman Ahmed
ba72f13f54
Merge branch 'master' into hide-mouse-on-keyboard-input
2022-10-14 22:26:30 +03:00
Feodor0090
fb046e31c1
Merge branch 'master' into comment-report
2022-10-14 16:57:23 +03:00
ansel
dc0aa2295a
Add test
2022-10-14 16:51:48 +03:00
ansel
3e9fd4c08c
Implement reporting flow
2022-10-14 16:26:25 +03:00
ansel
7251d41deb
Add request class
2022-10-14 16:15:28 +03:00
ansel
c65a8a83f3
Add basic UI for reporting
2022-10-14 15:52:09 +03:00
Dan Balasescu
10aabfc650
Merge pull request #20739 from peppy/settings-toolbox
...
Adjust visuals of settings toolboxes (gameplay loading screen and editor)
2022-10-14 20:31:05 +09:00
Dan Balasescu
dcb6357964
Add ability to remove the current item in multiplayer
2022-10-14 20:23:55 +09:00
Dean Herbert
32c3e35762
Change background colour to a lighter tint to avoid clash with slider bars
2022-10-14 19:38:27 +09:00
Dean Herbert
2404bb42b9
Use 10% alpha rather than 0% when toolbox is not hovered
2022-10-14 19:33:49 +09:00
Dan Balasescu
525f98c158
Fix max combo missing from playlists results screen
2022-10-14 18:01:54 +09:00
Dan Balasescu
8a88339e78
Allow combo colour normalisation to be disabled
2022-10-14 14:37:24 +09:00
Dan Balasescu
15db65c037
Extract to struct, add dictionary term
2022-10-14 14:12:53 +09:00
Dan Balasescu
b43bae122c
Fix incorrect porting of code
2022-10-14 13:46:25 +09:00
Salman Ahmed
01c65d3cc1
Remove seemingly unnecessary/leftover code
2022-10-14 02:16:36 +03:00
Salman Ahmed
739b21ab3b
Maintain mod selection on ruleset change for common mods
2022-10-14 02:15:58 +03:00
ansel
8a47628fe1
Use spacer drawable instead of spacing on links container
2022-10-14 00:04:13 +03:00
ansel
295e6f5a68
Move toast to it's namespace
2022-10-13 23:57:25 +03:00
ansel
34ff072a9b
Change text
2022-10-13 22:47:48 +03:00
ansel
a0cca391f6
Add copy link button to comments
2022-10-13 22:18:26 +03:00
ansel
e97dbf3dbc
Move copy toast to its own file
2022-10-13 22:12:32 +03:00
Salman Ahmed
ef72b66dad
Remove beatmap card background workaround to fix broken corners
2022-10-13 16:09:54 +03:00
Salman Ahmed
6c316bcc9e
Make beatmap card icon buttons fill up to the area
2022-10-13 16:09:54 +03:00
Salman Ahmed
aa8040d696
Add hover box to beatmap card icon button
2022-10-13 16:09:54 +03:00
Dean Herbert
3645269108
Improve logo transition and reduce delay of exiting player loader in optimal conditions
2022-10-13 17:29:47 +09:00
Dean Herbert
b33935e392
Fix player loading screen settings scaling in
...
This always looked weird, and from the looks of the structure was
probably unintentional from the start (it is in the logo tracking
container for whatever reason).
2022-10-13 17:12:36 +09:00
Dean Herbert
a93c350ca8
Start settings panels without background visible
2022-10-13 17:11:56 +09:00
Dean Herbert
6608ada925
Fix test failures due to missing colour provider dependency
2022-10-13 17:05:11 +09:00
Dean Herbert
15f9697c9f
Roughly update design of editor buttons
2022-10-13 16:57:25 +09:00
Dean Herbert
4d99c7002b
Add background behind editor toolbox groups
2022-10-13 16:36:19 +09:00
Dean Herbert
0f4a2a6059
Improve feel of settings toolbox group
2022-10-13 16:36:19 +09:00
Dean Herbert
c3902728f6
Reorganise beatmap snap control to work better in compact mode
2022-10-13 15:47:54 +09:00
Dean Herbert
a525b3f9f8
Reorder and rename toggle checkboxes to fit better
2022-10-13 15:44:33 +09:00
Dean Herbert
f6f5d33f53
Add slight padding to playfield (roughly matches stable)
2022-10-13 15:44:23 +09:00
Dan Balasescu
338115ff6a
Move check to LegacyDifficultyControlPoint
2022-10-13 15:05:15 +09:00
Dan Balasescu
4149235e63
Limit minimum brightness of combo colours
2022-10-13 14:05:33 +09:00
Dean Herbert
ebc1088457
Merge pull request #20729 from frenzibyte/update-local-confirmation-dialog
...
Request user confirmation on updating locally-modified beatmaps
2022-10-13 12:36:37 +09:00
Dean Herbert
c9b4cacc20
Merge pull request #20724 from mk56-spn/Highest_Combo_Counter
...
Add "longest combo" counter to HUD components.
2022-10-13 12:26:49 +09:00
Dean Herbert
f573ee4521
Merge pull request #20512 from Feodor0090/comment-deletion
...
Add ability to delete own comments
2022-10-13 12:13:08 +09:00
Dean Herbert
e240f659c2
Refactor visibility states to read better
2022-10-13 11:22:40 +09:00
Dan Balasescu
565e5586fd
Merge pull request #20725 from peppy/fix-beatmap-skin-fallbakcs
...
Fix legacy fallbacks not working correctly for beatmap skins
2022-10-13 10:08:40 +09:00
Salman Ahmed
964ed01abb
Add confirmation dialog for updating locally modified beatmaps
2022-10-13 02:40:15 +03:00
Salman Ahmed
4fb156ef4e
Update xmlodc and add nullability attributes
2022-10-13 00:16:42 +03:00
Salman Ahmed
6199db11a2
Make OsuUserInputManager
dependency nullable for tournament client
2022-10-12 17:55:32 +03:00
Salman Ahmed
7a6ecaff0d
Remove default invisible cursor container from rulesets
2022-10-12 17:50:47 +03:00
Salman Ahmed
a44cfe2901
Hide menu cursor when user is idle
2022-10-12 17:50:31 +03:00
Salman Ahmed
8305d886e6
Refactor internal visibility logic to route back to PopIn
/PopOut
2022-10-12 17:50:04 +03:00
Dean Herbert
19f3810020
Revert namespace change
...
Let's not
2022-10-12 18:50:47 +09:00
Dean Herbert
3da54814f8
Merge pull request #20641 from pfgithub/patch-fix-save-collections
...
Preserve collections when saving a beatmap
2022-10-12 18:36:45 +09:00
sw1tchbl4d3
df0501235d
Introduce BpmMultiplierMania
, remove after the fact clamps
2022-10-12 11:14:01 +02:00
Dean Herbert
8bf4ca4b53
Add legacy skin fallback when beatmap skin is providing resources
2022-10-12 17:47:20 +09:00
Dean Herbert
fd20515a6d
Don't throw if LegacySkin
doesn't have a transformer encapsulating it
...
This allows for more flexibility in lookups.
2022-10-12 17:29:17 +09:00
Dean Herbert
1c93551590
Remove completely incorrect check before applying ruleset transformer
2022-10-12 17:07:13 +09:00
Dan Balasescu
9473c350b5
Merge pull request #20266 from cdwcgt/catch-combo-hide
...
Fade out CatchComboDisplay when hide HUD
2022-10-12 16:59:07 +09:00
Dan Balasescu
3ac3c33cc3
Merge pull request #20712 from peppy/reduce-import-transaction-scope
...
Reduce the scope of realm transactions during import operations
2022-10-12 16:56:21 +09:00
Dario Headley
b72c8970eb
Max Combo Counter added
2022-10-12 09:50:01 +02:00
Dan Balasescu
300888b423
Merge pull request #20720 from peppy/fix-welcome-intro-delay
...
Fix incorrect delay for non-theme music on "welcome" intro
2022-10-12 16:15:54 +09:00
Dean Herbert
e43c8e84b0
Use Show
instead of Alpha=1
2022-10-12 15:48:42 +09:00
Dean Herbert
47fe4eb0bd
Merge branch 'master' into comment-deletion
2022-10-12 15:48:26 +09:00
Dean Herbert
5ce890cdb5
Merge pull request #20568 from Susko3/update-displays-in-setting
...
Sync displays dropdown in settings with OS displays
2022-10-12 15:35:31 +09:00
Dean Herbert
d2d589a156
Expose HUD state via Player
2022-10-12 15:11:52 +09:00
Dean Herbert
1d6d047a69
Merge branch 'master' into master
2022-10-12 14:52:07 +09:00
Dean Herbert
d6998c810c
Fix incorrect delay for non-theme music on "welcome" intro
2022-10-12 14:51:14 +09:00
Dean Herbert
db148d145b
Fix incorrect offset logic for beatmaps without a preview point specified
2022-10-12 14:47:37 +09:00
Dean Herbert
721bfb5369
Rename parameter to read better
2022-10-12 14:46:35 +09:00
Dean Herbert
195ece02c6
Merge branch 'master' into update-displays-in-setting
2022-10-12 14:37:49 +09:00
Dean Herbert
ab24e87013
Merge branch 'master' into improve-drag-selection
2022-10-12 13:20:17 +09:00
Dean Herbert
b444f0fd0b
Merge pull request #20714 from frenzibyte/improve-flashlight-on-break
...
Improve flashlight display on break periods
2022-10-12 13:10:12 +09:00
Dean Herbert
a5948e7680
Merge pull request #20704 from ekrctb/scrolling-drag-box
...
Anchor editor drag box on time (catch, mania)
2022-10-12 11:48:05 +09:00
Salman Ahmed
84fdd2e107
Improve flashlight display on break periods
2022-10-11 17:16:57 +03:00
ekrctb
fcb9e2cc00
Refactor blueprint container drag code
2022-10-11 22:39:53 +09:00
Salman Ahmed
0a97ee71a9
Hide menu cursor when non-mouse input is applied
2022-10-11 16:23:51 +03:00
Salman Ahmed
60c92c8744
Enable NRT on MenuCursorContainer
2022-10-11 16:23:51 +03:00
Salman Ahmed
894127a948
Expose bindable for identifying last input source
2022-10-11 16:21:54 +03:00
Salman Ahmed
9b45a9cf76
Rename various cursor symbols
...
- `IProvideCursor.MenuCursor` -> `IProvideCursor.Cursor`
- `MenuCursor` -> `MenuCursorContainer
2022-10-11 16:21:01 +03:00
Dean Herbert
390ff8b9da
Reduce the scope of realm transactions during import operations
2022-10-11 21:58:28 +09:00
Dan Balasescu
cc0ca470f1
Merge pull request #20702 from peppy/update-prefer-no-video
...
Fix beatmap update button not respecting user "prefer no video" setting
2022-10-11 19:36:14 +09:00
Daniel Källberg
63e651130a
Grouped localisation strings
2022-10-11 10:59:07 +02:00
Dan Balasescu
2ae41521eb
Merge pull request #20708 from peppy/mania-holding-sounds
...
Implement hold "sliding" samples in osu!mania
2022-10-11 17:31:44 +09:00
Dan Balasescu
88e82d3154
Merge pull request #20681 from peppy/fix-hidden-hud-interaction
...
Fix HUD components being interactive even when the HUD is visually hidden
2022-10-11 17:19:27 +09:00
NotGumballer91
d18466d740
Fix delay inconsistency in IntroCircles.cs
2022-10-11 16:16:57 +08:00
Dan Balasescu
6cdc9b2662
Merge pull request #20682 from peppy/fix-show-score-from-song-select
...
Fix clicking a leaderboard score at song select transtiioning briefly to main menu
2022-10-11 17:16:16 +09:00
NotGumballer91
5baad52a9e
Fix unintended delay on osu!theme
2022-10-11 16:15:56 +08:00
Dan Balasescu
045eb884b5
Merge pull request #20683 from peppy/storyboard-handle-backwards-events
...
Add support for weird storyboards which have backwards events
2022-10-11 17:12:22 +09:00
Dean Herbert
f41b79688f
Avoid casting by accepting all Playfield
s but throwing on a bad choice
2022-10-11 16:54:41 +09:00
Dean Herbert
f060e6a780
Implement hold "sliding" samples in osu!mania
2022-10-11 16:31:37 +09:00
Daniel Källberg
9c611019b3
Toolbar localisation
2022-10-11 09:30:32 +02:00
Dean Herbert
9bab02fab4
Remove unused using statement
2022-10-11 16:23:05 +09:00
Dean Herbert
eba3d37a11
Add xmldoc and simplify calling
2022-10-11 15:50:02 +09:00
Dean Herbert
6f6290a21a
Use async flow for storing key binding changes to realm
2022-10-11 15:37:22 +09:00
Dean Herbert
a44ba579c5
Fix beatmap update button not respecting user "prefer no video" setting
...
Closes #20701 .
2022-10-11 14:27:40 +09:00
ekrctb
6ab29a62d0
Anchor drag box on time (catch, mania)
...
Not done for taiko because I cannot figure out how it should work with the overlapping scroll algorithm.
2022-10-11 14:23:17 +09:00
ekrctb
1a24762f9b
Improve drag box selection logic
...
`AllowDeselectionDuringDrag` is remove.
Instead, selected hit objects are not automatically deselected
when clock is seeked to a later time (the hit object is dead).
Update drag box selection even if mouse is not moved
(in case clock is running or scroll wheel is used).
2022-10-11 14:11:45 +09:00
Dan Balasescu
ccab04d141
Merge pull request #20645 from frenzibyte/flag-markdown
...
Add support for inline country flags in wiki overlay
2022-10-11 14:01:24 +09:00
Dean Herbert
cb21126623
Merge pull request #20586 from ekrctb/time-based-selection
...
Use hit object time for timeline drag selection instead of relying on blueprint
2022-10-11 13:20:15 +09:00
pfg
e619c9c1e6
fix style
2022-10-10 21:48:41 -04:00
pfg
de8d485305
Move 'transferCollections' to a shared location
2022-10-10 21:45:33 -04:00
NotGumballer91
a883f44ea2
Merge branch 'master' into master
2022-10-11 02:11:21 +08:00
NotGumballer91
ef840e98cf
Update IntroCircles.cs
2022-10-11 01:49:53 +08:00
NotGumballer91
8a4f2efa14
Update IntroScreen.cs
2022-10-11 01:49:49 +08:00
NotGumballer91
3cd6ce8e3f
Update WorkingBeatmap.cs
2022-10-11 01:48:55 +08:00
Dean Herbert
3d58df2b61
Merge branch 'master' into flag-markdown
2022-10-11 01:58:43 +09:00
Dean Herbert
d700040a0d
Make country code parsing resilient to invalid cases
2022-10-11 01:39:53 +09:00
Dean Herbert
be5a413753
Update framework
2022-10-11 01:35:35 +09:00
Dean Herbert
5a43cb6bb2
Merge pull request #20606 from sw1tchbl4d3r/barline_generator_improvements
...
Barline generator improvements
2022-10-11 01:31:30 +09:00
sw1tchbl4d3
5a4196fd51
Make currentEffectPoint
non-nullable
2022-10-10 15:34:29 +02:00
NotGumballer91
9a3689b6e9
Update IntroCircles.cs
2022-10-10 21:04:14 +08:00
NotGumballer91
749dc40062
Update WorkingBeatmap.cs
2022-10-10 21:03:11 +08:00
NotGumballer91
e3b405cc23
Update IWorkingBeatmap.cs
2022-10-10 21:02:23 +08:00
sw1tchbl4d3
d389808427
Make effect point search more efficient
2022-10-10 14:00:26 +02:00
Dean Herbert
28185178d6
Add support for weird storyboards which have backwards events
...
Closes https://github.com/ppy/osu/issues/20632 .
Not adding test coverage because this is just weird.
2022-10-10 16:51:55 +09:00
sw1tchbl4d3
eae32ca483
Switch DefinitelyBigger
to AlmostBigger
to account for fp errors
2022-10-10 09:39:40 +02:00
sw1tchbl4d3
f8036658c7
Move clamps directly to the usages in the conversion algorithm
2022-10-10 09:36:18 +02:00
Dean Herbert
e57819d687
Merge pull request #20665 from frenzibyte/fix-smoke-blocked-on-relax
...
Fix smoke being blocked with "Relax" mod enabled
2022-10-10 16:36:03 +09:00
Dean Herbert
b783fdf667
Fix clicking a leaderboard score at song select transtiioning briefly to main menu
...
- Regressed in #20567 .
- Closes #20651 .
2022-10-10 16:20:18 +09:00
Dean Herbert
20adc522b9
Fix HUD components being interactive even when the HUD is visually hidden
2022-10-10 16:05:41 +09:00
Dean Herbert
26a473e85e
Update resources (fixes osu!mania flashlight crash)
2022-10-10 14:24:36 +09:00
D.Headley
5d2e3dcf4a
Remove leftover Enum
2022-10-09 22:52:54 +02:00
Salman Ahmed
2d4f390372
Remove non-smoke key bindings on "Relax" mod instead
2022-10-09 17:14:16 +03:00
sw1tchbl4d3
e0904e263f
Fix legacy BpmMultiplier clamp value
2022-10-09 11:25:47 +02:00
Salman Ahmed
a9aba74351
Add markdown country flag support
2022-10-08 21:50:25 +03:00
Salman Ahmed
098a56a784
Add custom container extension support
2022-10-08 21:25:11 +03:00
pfg
edec613724
Remove unnecessary '?'
2022-10-08 13:58:42 -04:00
pfg
ff14453c2b
Preserve collections when saving a beatmap
2022-10-08 12:42:29 -04:00
ansel
c384093802
Update main test and add failure scenario test
2022-10-08 18:53:41 +03:00
ansel
b697200460
Properly modify comment visual state on deletion
2022-10-08 18:41:08 +03:00
ansel
4e7c30504f
Schedule action buttons visibility changes
2022-10-08 17:15:10 +03:00
ansel
abf56c27a1
Do not requere dialog overlay
2022-10-08 17:11:09 +03:00
sw1tchbl4d3
63ffaa6929
Respect OmitFirstBarLine effect
2022-10-07 20:38:32 +02:00
sw1tchbl4d3
903c8612c8
Move endTime to next timing point
2022-10-07 20:34:31 +02:00
Dean Herbert
072b64b8d4
Update all dependencies
2022-10-07 21:16:11 +09:00
Dan Balasescu
c18d4afdcc
Merge branch 'master' into fix-leaderboard-first-place-fade
2022-10-07 19:55:16 +09:00
Dan Balasescu
0fb4ac4733
Merge pull request #20603 from peppy/bg-dim-reduce
...
Adjust out-of-the-box background dim back down to 70%
2022-10-07 19:40:13 +09:00
Dan Balasescu
57e4d6cc4a
Merge pull request #20562 from peppy/fix-score-submission-crash
...
Fix potential crash when score submission token retrival fails
2022-10-07 19:24:35 +09:00
Dean Herbert
a8742f0cc3
Adjust out-of-the-box background dim back down to 70%
...
It was previously bumped from 60% to 80%, but I've recently
felt that this is too high as a default, and takes away from storyboards
and video backgrounds.
2022-10-07 18:47:32 +09:00
Dean Herbert
a543222a2b
Add ability to pad stage vertically
2022-10-07 15:45:35 +09:00
Dean Herbert
eea3d5adb8
Standardise column index naming and xmldoc
2022-10-07 15:24:36 +09:00
Dean Herbert
13e0a59f70
Add note about why LegacyManiaSkinConfigurationLookup
exist
2022-10-07 15:24:36 +09:00
Dean Herbert
3947011baf
Fix regression in legacy dual stage handling logic
2022-10-07 15:24:36 +09:00
Dan Balasescu
bce20e0a59
Merge branch 'master' into adjust-flashlight
2022-10-07 14:45:30 +09:00
Dan Balasescu
7385ef3e1b
Extract combo scale to virtual function
2022-10-07 14:26:19 +09:00