29968 Commits

Author	SHA1	Message	Date
Susko3	cc286f165d	Change font to default ... Non-english letters look tiny with size 10 and don't fit into the look.	2021-11-08 06:56:57 +01:00
Susko3	c3069ad002	Change to use ReadableKeyCombinationProvider ... Changes all usages of `KeyCombination.ReadableString()` to `ReadableKeyCombinationProvider.GetReadableString()`. Subscribing to `KeymapChanged` is only required in `KeyButton`. All other places query `GetReadableString()` every time.	2021-11-08 06:55:26 +01:00
Dean Herbert	a2dfb5fd8c	Merge pull request #15513 from bdach/beatmap-card/statistics ... Add statistics display to beatmap card	2021-11-08 14:45:56 +09:00
Dean Herbert	c58f21a115	Handle mods with overloaded method signature instead	2021-11-08 14:43:46 +09:00
Dan Balasescu	1c40d5bc08	Merge branch 'master' into remove-stupid-weak-reference-bindable-events	2021-11-08 14:41:32 +09:00
Dean Herbert	97345ac9e6	Remove unnecessary TimeSpan timeout parameter (CancellationToken can now be used)	2021-11-08 14:33:32 +09:00
Dean Herbert	5b5e3dc4a2	Revert incorrect mod nullable parameter specification	2021-11-08 14:33:15 +09:00
Dean Herbert	e338340c6a	Merge branch 'master' into beatmap-cancellation-token	2021-11-08 14:32:56 +09:00
Dean Herbert	6b6dd93e9e	Fix LinkFlowContainer not creating user links supporting full IUser specification	2021-11-08 14:17:47 +09:00
Dean Herbert	dede0e56ce	Merge branch 'master' into user-lookup-by-username-cleanup	2021-11-08 13:38:26 +09:00
Dean Herbert	78aef9ce86	Merge branch 'master' into remove-stupid-weak-reference-bindable-events	2021-11-08 13:35:49 +09:00
Dean Herbert	1589b50d6e	Merge branch 'master' into beatmap-card/statistics	2021-11-08 13:28:31 +09:00
Dan Balasescu	da0d9726f5	Merge pull request #15466 from peppy/user-class-cleanup ... Clean up `User` class	2021-11-08 13:27:26 +09:00
Dean Herbert	fb495d77ce	Implement TooltipText directly	2021-11-08 13:22:57 +09:00
Dean Herbert	8dbe69dec5	Merge pull request #15515 from Joehuu/fix-statistics-loading-spinner ... Fix loading spinner potentially showing on statistics unavailable message	2021-11-08 13:02:39 +09:00
Dean Herbert	62600b47b1	Merge branch 'master' into user-class-cleanup	2021-11-08 12:51:12 +09:00
Joseph Madamba	9e13c20bd4	Move spinner hiding before newScore null check	2021-11-07 19:35:30 -08:00
Joseph Madamba	ac5d9853d3	Fix loading spinner potentially showing on statistics unavailable message	2021-11-07 17:25:33 -08:00
Chinmay Patil	a8c9ad73c1	Make UR Counter isValid into a bindable boolean	2021-11-07 18:06:13 -07:00
Chinmay Patil	cc0bcf6b2c	Clean up judgement checks and clean up setter/getter for UR counter Text	2021-11-07 17:44:50 -07:00
Bartłomiej Dach	0e09edfce2	Do not show nomination info if hype info not present to match web	2021-11-07 21:33:42 +01:00
Bartłomiej Dach	1f405a7e71	Display extended statistics on card hover	2021-11-07 21:33:41 +01:00
Bartłomiej Dach	c0b5b0e909	Add new statistic types to online info	2021-11-07 21:33:41 +01:00
Bartłomiej Dach	04c2a9cd59	Display basic statistics on card hover	2021-11-07 21:03:06 +01:00
Bartłomiej Dach	6d30248cef	Merge branch 'master' into use-class-rename	2021-11-07 15:41:00 +01:00
Salman Ahmed	eb5e7402c3	Remove obsolete method in ModAutoplay	2021-11-07 16:15:57 +03:00
Tollii	d5f5d74a89	Rename CancellationToken variable	2021-11-07 13:41:54 +01:00
Dean Herbert	f0809801c5	Update remaining actions to events	2021-11-07 11:34:37 +09:00
Dean Herbert	0ecf5f201c	Rename User to APIUser and move to correct namespace	2021-11-07 11:26:01 +09:00
Dean Herbert	69aa620ab7	Remove unused team class	2021-11-07 11:25:50 +09:00
Tollii	cf0b757b16	Fix PR comments. ... Nitpick, more cancellation token checks.	2021-11-06 16:03:53 +01:00
Bartłomiej Dach	6a1c27d67a	Merge branch 'master' into fix-more-null	2021-11-06 15:36:15 +01:00
Bartłomiej Dach	c40f887492	Remove unnecessary local variable	2021-11-06 15:20:29 +01:00
Dean Herbert	89cc2523ef	Fix incorrectly specified events	2021-11-06 22:31:49 +09:00
Dean Herbert	96ef210a4d	Fix backward state set	2021-11-06 16:45:55 +09:00
Salman Ahmed	34c8e53e94	Merge branch 'master' into update-cached-buffered-container-usage	2021-11-06 09:38:55 +03:00
Dean Herbert	bc17446055	Merge branch 'master' into user-lookup-by-username-cleanup	2021-11-06 14:38:30 +09:00
Dean Herbert	2b3907db4b	Update framework	2021-11-06 14:33:45 +09:00
Dean Herbert	2881ce0f5a	Merge branch 'master' into remove-stupid-weak-reference-bindable-events	2021-11-06 14:08:39 +09:00
Tollii	eb7d04bc77	Add cancellation token support for beatmap difficulty calculation.	2021-11-06 00:21:29 +01:00
Tollii	f0caa10066	Add support for a provided cancellation token for GetPlayableBeatmap()	2021-11-05 23:53:48 +01:00
Chinmay Patil	77e853ce25	Optimized UR Counter and removed redundant code	2021-11-05 12:16:58 -06:00
Salman Ahmed	51e7b9950e	Define local current bindable to bind value change instead	2021-11-05 18:07:14 +03:00
Dean Herbert	9a7c75508e	Merge branch 'master' into user-class-cleanup	2021-11-05 19:56:18 +09:00
Dean Herbert	54f72d68ca	Revert weird event flow in model manager/importers	2021-11-05 19:12:49 +09:00
Salman Ahmed	771bcbf868	Rename one more clashing variable	2021-11-05 12:24:07 +03:00
Salman Ahmed	608958b186	Remove unused setter in interface type	2021-11-05 12:10:05 +03:00
Dean Herbert	6c385ccd29	Move second generic to abstract model downloader rather than interface type	2021-11-05 17:37:05 +09:00
Dean Herbert	99df37f32d	Add input generic type to IModelDownloader	2021-11-05 17:02:45 +09:00
Dean Herbert	846c80f12c	Rename remaining clashing variables to appease CI somewhere	2021-11-05 17:02:24 +09:00
Dean Herbert	7772a97cf7	Add helper function to get realm class names rather than hard-coding each time	2021-11-05 17:01:00 +09:00
Dean Herbert	1fe9bca819	Change ModelDownloader's requirement to an IModelImporter rather than IModelManager	2021-11-05 16:47:18 +09:00
Dean Herbert	b90f44493c	Remove importer inheritance from IModelManager ... Now only exists in legacy implementations, to reduce inheritance complexity of interfaces which are going to be used going forwards.	2021-11-05 16:45:38 +09:00
Salman Ahmed	c2c567f5f5	Merge branch 'master' into user-class-cleanup	2021-11-05 10:28:25 +03:00
Salman Ahmed	f013a1e37f	Move CreateContent() to BDL	2021-11-05 10:13:42 +03:00
smoogipoo	aee0f39c80	Merge branch 'master' into multi-queueing-modes	2021-11-05 16:06:41 +09:00
smoogipoo	7bbb2a7a67	Fix post-merge issues	2021-11-05 15:57:32 +09:00
smoogipoo	e6deb0c873	Merge branch 'master' into multi-queueing-modes	2021-11-05 15:57:25 +09:00
Dean Herbert	6399c695e8	Update usages of BufferedContainer in line with framework changes	2021-11-05 15:54:49 +09:00
Salman Ahmed	3a3ec1436b	Re-enable possible null refernece exception inspections and move code	2021-11-05 09:14:50 +03:00
Dean Herbert	9f9ef570ee	Also propagate Status in temporary BeatmapInfo usage	2021-11-05 14:44:58 +09:00
Dean Herbert	b1f1cc0bf3	Perform all user profile displays using an IUser interface	2021-11-05 13:55:34 +09:00
Dean Herbert	ba74dd93b2	Remove weird fetchOnline logic	2021-11-05 13:55:34 +09:00
Dean Herbert	1f5ca122b0	Merge branch 'master' into user-class-cleanup	2021-11-05 13:55:22 +09:00
Dean Herbert	f2700b0a6d	Expose bot state via interface	2021-11-05 13:40:44 +09:00
Dean Herbert	ead64282dd	Split out a couple more nested classes	2021-11-05 13:40:44 +09:00
Dan Balasescu	9e2c33d908	Merge branch 'master' into beatmap-refactor/to-model-removal-2	2021-11-05 13:16:32 +09:00
Dan Balasescu	9b5ed791b5	Merge pull request #15459 from peppy/beatmap-refactor/remove-online-info ... Remove `IOnlineInfo` implementations from database models	2021-11-05 13:16:21 +09:00
Dean Herbert	5721f1b2f3	Merge pull request #15479 from jaswon/skinnable-diagonal-scale ... Fix scaling of skin components being too sensitive after rotation	2021-11-05 13:11:11 +09:00
Dan Balasescu	acb06d4a99	Merge branch 'master' into beatmap-refactor/remove-online-info	2021-11-05 12:46:02 +09:00
Chinmay Patil	8bfcb89221	Fixed issue where UR counter was always invalid	2021-11-04 21:24:25 -06:00
Salman Ahmed	f528488aa2	Mark as non-null and move current bind to BDL instead	2021-11-05 05:42:19 +03:00
Salman Ahmed	2764ad90ea	Merge branch 'master' into fix-more-null	2021-11-05 05:14:22 +03:00
Salman Ahmed	4245af28e1	Disable other false-positive null inspections with comment	2021-11-05 04:50:58 +03:00
Salman Ahmed	36d99a2e34	Move action to private named method to avoid null inspection	2021-11-05 03:51:08 +03:00
Jason Won	9e7d559f55	fix aspect locked scaling of skin components	2021-11-04 17:10:41 -04:00
Bartłomiej Dach	4c8d6a77be	Fix labelled drawable descriptions not showing	2021-11-04 21:44:08 +01:00
Chinmay Patil	0ffd41bb70	Slight logical error in the setValid method	2021-11-04 14:32:28 -06:00
Chinmay Patil	8923561b05	Removed Unnessicary class in the Test file, and optimized UR counter	2021-11-04 14:27:48 -06:00
Dean Herbert	630d63101d	Merge branch 'master' into beatmap-refactor/to-model-removal-2	2021-11-05 01:16:42 +09:00
Dean Herbert	7049d0de66	Merge branch 'master' into beatmap-refactor/remove-online-info	2021-11-05 01:16:11 +09:00
Chinmay Patil	a76878e053	A bit more formatting	2021-11-04 09:52:16 -06:00
Chinmay Patil	c568888500	Edited to remove unessicary blank lines	2021-11-04 09:47:52 -06:00
Salman Ahmed	aa2711e6ec	Merge branch 'master' into update-framework	2021-11-04 13:51:57 +03:00
Dean Herbert	28e9b9a25f	Update framework	2021-11-04 19:01:39 +09:00
Dean Herbert	ed07ee8c61	Update all existing usages of AuthorString/AuthorId ... Unfortunately the getters need to be left in place else EF breaks.	2021-11-04 18:59:37 +09:00
Dan Balasescu	45dcf187b9	Merge branch 'master' into beatmap-refactor/playlist-use-api-beatmap-extended	2021-11-04 18:59:04 +09:00
Dean Herbert	7acc4a4708	Refactor realm migrations to be a touch more legible	2021-11-04 18:57:54 +09:00
Dean Herbert	777b2cbcc4	Add realm migration for new author storage	2021-11-04 18:57:54 +09:00
Dean Herbert	86540d1fb6	Update existing usages of Author as string to access Username directly	2021-11-04 18:57:54 +09:00
Dean Herbert	7547810979	Change IBeatmapMetadataInfo.Author to be an IUser	2021-11-04 18:32:42 +09:00
Dean Herbert	b9983add15	Rename User to APIUser and move to correct namespace	2021-11-04 18:21:31 +09:00
Dean Herbert	df3c3a32ce	Fix unintentionally broken background update logic	2021-11-04 18:07:39 +09:00
Dean Herbert	25b0bccfd5	Remove unused team class	2021-11-04 17:39:42 +09:00
Dean Herbert	b80c02b757	Fix crash on gameplay startup if beatmap has no background	2021-11-04 17:24:40 +09:00
Dean Herbert	eb17d897a3	Finally, remove the To* methods as they have no usages	2021-11-04 17:09:53 +09:00
Dean Herbert	08d94f864f	Update ScoresContainer to not use ToBeatmapInfo	2021-11-04 17:09:53 +09:00
Dean Herbert	7bab487621	Remove usage of ToBeatmapInfo in APIScoreInfo.CreateScoreInfo	2021-11-04 17:09:53 +09:00
Dean Herbert	d2831b1152	Merge branch 'beatmap-refactor/remove-online-info' into beatmap-refactor/to-model-removal-2	2021-11-04 17:09:50 +09:00
Dean Herbert	5a078da4d9	Fix APIBeatmapSet.Beatmaps being IEnumerable, causing stupid issues	2021-11-04 16:50:14 +09:00
Dean Herbert	c820d445ad	Merge pull request #15461 from peppy/fix-more-computationally-expensive ... Fix a few more "maybe null" inspections	2021-11-04 16:49:38 +09:00
Dean Herbert	8f459e6ce8	Fix APIBeatmapSet.Beatmaps being IEnumerable, causing stupid issues	2021-11-04 16:44:17 +09:00
Dean Herbert	317506d4d7	Fix a few more "maybe null" inspections	2021-11-04 16:11:23 +09:00
Dean Herbert	09701d0af1	Use explicit primitive type specification	2021-11-04 16:02:37 +09:00
Dean Herbert	0f4f1349db	Merge branch 'master' into editor-context-menu-on-select	2021-11-04 15:59:06 +09:00
Dean Herbert	a5a7181915	Fix unintentionally broken background update logic	2021-11-04 15:35:32 +09:00
Dean Herbert	4b1b92cde6	Stop BeatmapInfo from implementing IBeatmapOnlineInfo and remove all usages	2021-11-04 15:23:04 +09:00
Dean Herbert	9c926e5514	Remove BeatmapSetInfo.OnlineInfo and all usages	2021-11-04 15:23:04 +09:00
Dean Herbert	66f4516eee	Allow creating sample API models without specifying a ruleset	2021-11-04 15:23:04 +09:00
Dean Herbert	e3a9fbecfe	Add method to create sample APIBeatmap (with BeatmapSet populated)	2021-11-04 15:23:04 +09:00
Dean Herbert	0d0eab90bc	Merge branch 'beatmap-refactor/playlist-use-api-beatmap-extended' into beatmap-refactor/remove-online-info	2021-11-04 15:23:02 +09:00
Dean Herbert	84d36cbae7	Add fallback for cases where BeatmapSet may be null ... Seems to only happen in tests, but better safe than sorry.	2021-11-04 15:22:33 +09:00
Dean Herbert	e43d91ad5d	Fix another case of incorrect null checking in editor verification processing	2021-11-04 15:18:10 +09:00
Dean Herbert	d1e6d1cb98	Update some other missed incorrect null/empty usages	2021-11-04 14:50:43 +09:00
Dean Herbert	a49366ff84	Remove nullability from IBeatmapInfo.Metadata	2021-11-04 14:28:39 +09:00
Dean Herbert	1e73b09e57	Fix another couple of cases of incorrect string null/empty checking	2021-11-04 14:22:28 +09:00
Dean Herbert	41854f2e16	Fix incorrect check on AudioFile presence	2021-11-04 14:02:09 +09:00
Dean Herbert	67d9590a79	Fix new inspections	2021-11-04 14:02:09 +09:00
Dean Herbert	0df339d0b8	Fix incorrect invocation of download method in SoloSpectator	2021-11-04 13:50:04 +09:00
Dean Herbert	0ab50f1cc9	Add inline comment explaining why we are manually populating beatmap.BeatmapSet	2021-11-04 13:45:59 +09:00
Dean Herbert	9f9c960fe3	Revert PlaylistItem.APIBeatmap to be private	2021-11-04 13:36:32 +09:00
Dean Herbert	05f1fd4bc9	Remove unnecessary properties and parameters	2021-11-04 13:33:54 +09:00
Chinmay Patil	9aa3021bbc	Added Unstable Rate Counter as a skinable element	2021-11-03 22:22:44 -06:00
Dean Herbert	3453160a8b	Change PlaylistItem.Beatmap to be an IBeatmapInfo	2021-11-04 13:16:56 +09:00
Dean Herbert	772b6c6dcd	Enable nullable support on BeatmapMetadata	2021-11-04 12:11:42 +09:00
Dean Herbert	6fdeb66dc1	Use APIBeatmap instead of BeatmapInfo in playlist display classes where feasible	2021-11-04 11:55:50 +09:00
Dean Herbert	1d8e253112	Expose PlaylistItem.APIBeatmap for now	2021-11-04 11:53:26 +09:00
Dan Balasescu	dd948e5ada	Merge pull request #15447 from peppy/fix-invalid-characters-zip-export ... Fix beatmaps being exported with malformed filenames inside `.osz` zip files	2021-11-04 09:03:51 +09:00
Bartłomiej Dach	098fa181b4	Fix text flow wrapping incorrectly in multiplayer usages	2021-11-03 18:36:43 +01:00
Dean Herbert	8d40d55d93	Update framework	2021-11-03 17:09:49 +09:00
Dean Herbert	d85224d7ad	Merge branch 'master' into localisable-text-flow	2021-11-03 17:09:46 +09:00
Dean Herbert	ca438a102d	Fix beatmap paths including invalid slash/backslash characters	2021-11-03 16:46:05 +09:00
Dean Herbert	900549a771	Merge pull request #15398 from bdach/beatmap-card-basics ... Add basic elements of new beatmap cards	2021-11-03 15:35:29 +09:00
Bartłomiej Dach	cf7545e36c	Merge branch 'master' into beatmap-card-basics	2021-11-03 00:11:03 +01:00
Bartłomiej Dach	1813681fac	Move private method below protected	2021-11-03 00:10:50 +01:00
Bartłomiej Dach	75e89f17ad	Rewrite BeatmapCardContentBackground	2021-11-03 00:07:03 +01:00
Bartłomiej Dach	494d582830	Fix PlaylistItem attempting to read from OsuColour dependency too early	2021-11-02 23:19:45 +01:00
Bartłomiej Dach	195a141625	Fix score tracker not tracking non-online scores correctly	2021-11-02 22:51:25 +01:00
Bartłomiej Dach	e4e8390a8a	Update ScreenEntry colour usage to update correctly on language change	2021-11-02 21:42:03 +01:00
Bartłomiej Dach	d218e7d935	Remove manual romanisation handling in PlaylistItem	2021-11-02 21:42:02 +01:00
Bartłomiej Dach	ed00cd9fc5	Remove simple localisable .ToString() calls	2021-11-02 21:42:02 +01:00
Bartłomiej Dach	11de924704	Use LocalisableStrings where possible to leverage localisable text flow	2021-11-02 21:42:02 +01:00
Bartłomiej Dach	ad98ab0a26	Fix drawable room playlist item assuming single sprite text	2021-11-02 21:42:02 +01:00
Bartłomiej Dach	b95c95527e	Accept LocalisableStrings in LinkFlowContainer	2021-11-02 21:42:01 +01:00
Bartłomiej Dach	98367fc482	Update usages of GetLocalised{-> Bindable}String	2021-11-02 21:42:01 +01:00
Dean Herbert	47914c49ba	Fix missed null consideration	2021-11-03 04:54:36 +09:00
Dean Herbert	fe9b8f3274	Merge pull request #15432 from peppy/fix-beatmap-availability-potentially-wrong ... Fix multiplayer potentially getting incorrect beatmap availability state after changing beatmaps	2021-11-03 04:54:22 +09:00
Dean Herbert	5ea901da2e	Merge pull request #15429 from peppy/fix-beatmap-download-notifications ... Fix beatmap download notifications not showing beatmap name correctly	2021-11-03 04:36:59 +09:00
Dean Herbert	a97e5fbd89	Merge pull request #15431 from peppy/fix-unauth-api-requests ... Fix unauthenticated API requests no longer working	2021-11-03 04:35:48 +09:00
Dean Herbert	85037dfb70	Fix multiplayer potentially getting incorrect beatmap availability state after changing beatmaps	2021-11-03 04:32:21 +09:00
Dean Herbert	cb5c6e1924	Merge pull request #15427 from peppy/fix-multiplayer-panel-star-rating-display ... Fix multiplayer panels not correctly showing star rating	2021-11-03 04:21:01 +09:00
Dean Herbert	f67f42dc5b	Merge pull request #15430 from bdach/fix-multi-submission ... Fix multiplayer score submission not working	2021-11-03 04:10:23 +09:00
Dean Herbert	51e92e1b2d	Check for null/empty instead	2021-11-03 04:09:31 +09:00
Dean Herbert	8d0b32981f	Fix unauthenticated API requests no longer working	2021-11-03 03:30:15 +09:00
Dean Herbert	392559ae3e	Fix beatmap download notifications not showing beatmap name correctly	2021-11-03 03:23:41 +09:00
Bartłomiej Dach	c028275d6c	Fix multiplayer score submission not working	2021-11-02 19:16:44 +01:00
Dean Herbert	6efd3d3115	Don't perform background difficulty calculation for multiplayer panels ... There are cases these are shown in a long list. They shouldn't be running calculations.	2021-11-03 03:12:52 +09:00
Dean Herbert	08b0ffad50	Fix incorrect check for local beatmap in BeatmapDifficultyCache ... This was correct in the WIP branch I have, but pulled out alone (where usages of `ToBeatmapInfo` still exist) it was not enough.	2021-11-03 03:12:52 +09:00
Dean Herbert	c85a4dca28	Fix crash when attempting to view global leaderboards	2021-11-03 02:47:33 +09:00
Dean Herbert	73b09f3b3d	Merge pull request #15409 from smoogipoo/fix-pp-counter-rate-adjust ... Fix PP counter showing incorrect values with rate adjustment mods	2021-11-03 00:06:13 +09:00
smoogipoo	81aaef719f	Add xmldoc to CalculateTimed()	2021-11-02 17:55:00 +09:00
smoogipoo	168a7a588b	Add xmldoc to ctor also	2021-11-02 17:19:14 +09:00
smoogipoo	efba7a9c4d	Missed hyphen	2021-11-02 17:18:02 +09:00
smoogipoo	0cdd2898fe	Expose non-adjusted time from CalculateTimed()	2021-11-02 17:17:14 +09:00
Dean Herbert	135df0e190	Avoid adding null users to RecentParticipants	2021-11-02 17:13:37 +09:00
Dean Herbert	1bfa1365a0	Rename "null user" tests to better explain purpose	2021-11-02 17:13:37 +09:00
Dean Herbert	b0bd39fc49	Fix multiplayer room participants display not updating as new users join/leave ... Can add tests on request, but not sure the code around this area is here to stay permanently. Should be pretty low risk. - Closes https://github.com/ppy/osu/issues/14788.	2021-11-02 17:13:37 +09:00
smoogipoo	eaeee80a26	Fix PP counter showing incorrect values with rate adjustment mods	2021-11-02 16:55:20 +09:00
Dan Balasescu	6f941a8916	Merge pull request #15405 from peppy/legacy-decoder-default-section ... Default legacy decoder to `General` section, rather than none	2021-11-02 15:42:25 +09:00
smoogipoo	1e9211c00b	Use explicit type	2021-11-02 15:41:25 +09:00
Dean Herbert	5d784b2ef8	Perform a consistency check by decoding the newly written skin.ini during ComputeHash ... As this has regressed twice now, let's play it safe and bail rather than stack overflowing. Note that as all the underlying issues that could trigger this have been fixed, no additional tests have been added. To test, comment out `SkinManager.cs` line 228-229 to cause a failure. The new logic will kick in and show a log output message, but all tests will still (correctly) pass.	2021-11-02 14:11:25 +09:00
Dean Herbert	2e66ab453d	Always write automated changes to skin metadata at the end of the file ... Apart from being cleaner (and allowing removal at the point of export, if that is ever requires), this also gives us a better guarantee that the metadata is going to take effect. By writing the `[General]` section ourselves, we avoid any issues that may be present from a user constructing the file (incorrectly) themselves, such as multiple `Title:` entries or a malformed `[General]` marker. The main goal is to ensure that the name is updated to what we expect it to be.	2021-11-02 14:11:25 +09:00
Dean Herbert	15c770e155	Remove no longer used Section.None	2021-11-02 14:01:41 +09:00
Dean Herbert	ab28948744	Default legacy decoder to General section, rather than none ... This is mainly to reach parity with how stable handles such cases for skins specifically. It was brought to our attention after finding a skin with a malformed `\[General]` tag which did not break further parsing of the file on stable, but did on lazer. Note that stable defaults to an "unknown" section for beatmaps, but functionally I can't think of a regression case from changing this to a "general" default.	2021-11-02 13:59:13 +09:00
Bartłomiej Dach	90fb536a25	Merge branch 'dependabot/nuget/Microsoft.AspNetCore.SignalR.Client-5.0.11' into update-dependencies	2021-11-01 20:53:43 +01:00
Bartłomiej Dach	d05d0f2b88	Merge branch 'dependabot/nuget/Sentry-3.10.0' into update-dependencies	2021-11-01 20:53:19 +01:00
Bartłomiej Dach	bfcd7948fe	Merge branch 'dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.MessagePack-5.0.11' into update-dependencies	2021-11-01 20:52:56 +01:00
Bartłomiej Dach	e4672981d8	Merge branch 'dependabot/nuget/SharpCompress-0.30.0' into update-dependencies	2021-11-01 20:52:44 +01:00
Bartłomiej Dach	f671ee28c5	Use buffered container to eliminate gaps near foreground border	2021-11-01 20:17:27 +01:00
Bartłomiej Dach	a59f2d7b83	Implement basic hover card state	2021-11-01 19:41:11 +01:00
Bartłomiej Dach	5962f16b1c	Implement basic card appearance	2021-11-01 19:41:11 +01:00
dependabot[bot]	3b7379b777	Bump Microsoft.AspNetCore.SignalR.Client from 5.0.10 to 5.0.11 ... Bumps [Microsoft.AspNetCore.SignalR.Client](https://github.com/dotnet/aspnetcore) from 5.0.10 to 5.0.11. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.10...v5.0.11) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.SignalR.Client dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-11-01 17:02:20 +00:00
dependabot[bot]	e0a940be1d	Bump Sentry from 3.9.4 to 3.10.0 ... Bumps [Sentry](https://github.com/getsentry/sentry-dotnet) from 3.9.4 to 3.10.0. - [Release notes](https://github.com/getsentry/sentry-dotnet/releases) - [Changelog](https://github.com/getsentry/sentry-dotnet/blob/main/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-dotnet/compare/3.9.4...3.10.0) --- updated-dependencies: - dependency-name: Sentry dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	2021-11-01 17:02:14 +00:00
dependabot[bot]	f215439b4f	Bump Microsoft.AspNetCore.SignalR.Protocols.MessagePack ... Bumps [Microsoft.AspNetCore.SignalR.Protocols.MessagePack](https://github.com/dotnet/aspnetcore) from 5.0.10 to 5.0.11. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.10...v5.0.11) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.SignalR.Protocols.MessagePack dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-11-01 17:02:10 +00:00
dependabot[bot]	f8f4b9d3d3	Bump SharpCompress from 0.29.0 to 0.30.0 ... Bumps [SharpCompress](https://github.com/adamhathcock/sharpcompress) from 0.29.0 to 0.30.0. - [Release notes](https://github.com/adamhathcock/sharpcompress/releases) - [Commits](https://github.com/adamhathcock/sharpcompress/compare/0.29...0.30) --- updated-dependencies: - dependency-name: SharpCompress dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	2021-11-01 17:02:04 +00:00
dependabot[bot]	f893556b80	Bump Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson ... Bumps [Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson](https://github.com/dotnet/aspnetcore) from 5.0.10 to 5.0.11. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.10...v5.0.11) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-11-01 17:02:00 +00:00
Dean Herbert	3a5aed1182	Ensure APIScoreInfo.Mods is non-null	2021-11-01 22:59:12 +09:00
Dean Herbert	caa9d8997b	Merge branch 'master' into score-refactor/less-create-score-info	2021-11-01 22:59:11 +09:00
Bartłomiej Dach	793c384ecd	Remove unnecessary null-conditional access	2021-11-01 12:02:37 +01:00
Bartłomiej Dach	5dcff7d8b7	Merge branch 'master' into score-refactor/less-create-score-info	2021-11-01 11:41:20 +01:00
Dan Balasescu	95b1f5830d	Merge branch 'master' into beatmap-refactor/beatmap-overlays	2021-11-01 19:32:07 +09:00
Dan Balasescu	8c38698506	Merge pull request #15363 from peppy/beatmap-refactor/get-and-present ... Update `GetScoreRequest` and `PresentBeatmap` to accept interface types	2021-11-01 19:28:28 +09:00
smoogipoo	3db199292f	Fix queue mode not passed from room to settings overlay	2021-11-01 18:52:57 +09:00
smoogipoo	65b920e4c1	Merge branch 'master' into multi-queueing-modes	2021-11-01 18:37:16 +09:00
Dan Balasescu	65d2b54ef6	Merge pull request #15387 from bdach/fix-score-download-tracker ... Fix incorrect state transition in score download tracker	2021-11-01 18:36:35 +09:00
Dean Herbert	b21e0e7efb	Merge branch 'beatmap-refactor/get-and-present' into beatmap-refactor/beatmap-overlays	2021-11-01 18:07:51 +09:00
Dean Herbert	602fe372c2	Merge branch 'score-refactor/isolated-serialisation' into beatmap-refactor/get-and-present	2021-11-01 18:06:53 +09:00
Dean Herbert	5dcc940864	Merge branch 'master' into fix-score-download-tracker	2021-11-01 17:50:34 +09:00
Bartłomiej Dach	f5feed138d	Merge branch 'master' into score-refactor/isolated-serialisation	2021-11-01 09:43:51 +01:00
Bartłomiej Dach	cd4681496a	Fix incorrect state transition in score download tracker	2021-11-01 09:35:02 +01:00
Dean Herbert	63c9512ab1	Update dashboard components to use APIBeatmapSet	2021-11-01 16:04:01 +09:00
Dean Herbert	722e0d50bb	Fix BeatmapInfo not being correctly populated in CreateScoreInfo call	2021-11-01 15:54:39 +09:00
Dan Balasescu	c51349de57	Merge pull request #15358 from peppy/online-id-potentially-zero ... Add a note about `OnlineID` potentially being zero in non-autoincrement cases	2021-11-01 15:54:08 +09:00
Dean Herbert	b98faf6159	Merge branch 'master' into score-refactor/isolated-serialisation	2021-11-01 15:49:25 +09:00
Dan Balasescu	9e633a1b17	Merge pull request #15321 from peppy/beatmap-refactor/download-tracker ... Replace `DownloadTrackingComposite` with instantiable `DownloadTracker` components	2021-11-01 15:48:12 +09:00
smoogipoo	94dce3f92a	Remove whitespace	2021-11-01 15:43:19 +09:00
Dan Balasescu	cd9ee7723a	Merge pull request #15384 from peppy/fix-tourney-map-pool-creator-shows-twice ... Fix beatmap creator showing twice in tournament map pool panels	2021-11-01 15:24:54 +09:00
Dean Herbert	227963047a	Fix hash validity check function returning incorrect results after soft deleting a beatmap ... The soft-deleted one would potentially match before the newly imported copy, resulting in a false-positive hash mismatch.	2021-11-01 15:15:45 +09:00
Dean Herbert	123b10f647	Fix playlist item download button being clickable when it shouldn't	2021-11-01 15:10:32 +09:00
Dean Herbert	21e0074d3b	Add missing AddInternal call for BeatmapSetHeaderContent's download tracker	2021-11-01 14:43:32 +09:00
Dean Herbert	10a9266956	Fix beatmap creator showing twice in tournament map pool panels	2021-11-01 14:33:24 +09:00
Dean Herbert	6b250955d7	Add missing verbatim string markers	2021-11-01 14:24:38 +09:00
Dean Herbert	5bfb16efe2	Ignore case when searching for existing skin.ini	2021-11-01 14:24:38 +09:00
Dean Herbert	708b57348d	Change loose api ordering requirement to throw instead	2021-11-01 13:22:16 +09:00
Dean Herbert	269a8df0ec	Fix HasReplay not being corrrectly implemented by APIScoreInfo	2021-11-01 13:20:37 +09:00
Dean Herbert	19feae4a8e	Merge branch 'master' into beatmap-refactor/download-tracker	2021-11-01 13:15:36 +09:00
Dean Herbert	02e69626e3	Reduce fail animation tint slightly	2021-11-01 13:06:26 +09:00
Bartłomiej Dach	914e5c0f9d	Fix star rating not updating for some mods on details tab in song select ... `AdvancedStats` was locally assuming that the only changes in mods that are relevant to it are if the mods are `IApplicableToDifficulty`. This is not true, as other mods (such as `IApplicableToRate` mods, or more recently, Flashlight) can also affect star difficulty, which is shown on one of the bars in `AdvancedStats`.	2021-10-31 18:58:17 +01:00
Dean Herbert	b63a90966b	Remove misplaced access modifier in interface specification ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-10-31 23:49:26 +09:00
Bartłomiej Dach	9e05e7af74	Merge branch 'master' into add-hw-accel-setting	2021-10-30 15:19:01 +02:00
Bartłomiej Dach	e9ba1ea198	Mark IScoreInfo implementation with region	2021-10-30 15:08:45 +02:00
Bartłomiej Dach	8053b2c320	Merge branch 'master' into score-refactor/isolated-serialisation	2021-10-30 15:07:34 +02:00
Bartłomiej Dach	b0c4fa662d	Merge branch 'master' into long-online-id-score-info	2021-10-30 14:35:30 +02:00
Bartłomiej Dach	6e4f7af8d3	Mark IHasOnlineID implementation with region	2021-10-30 14:15:20 +02:00
Bartłomiej Dach	5a8dff0e4e	Merge branch 'master' into beatmap-refactor/difficulty-icons	2021-10-30 14:06:15 +02:00
Dean Herbert	e9473db77c	Reorder to have video settings next to renderer ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2021-10-30 20:37:55 +09:00
Opelkuh	4d988340eb	Add hardware acceleration toggle	2021-10-30 01:02:53 +02:00
Dean Herbert	5311fe2d02	Merge branch 'master' into beatmap-refactor/beatmap-overlays	2021-10-29 22:37:29 +09:00
Dean Herbert	f8aa4c2851	Merge pull request #15352 from bdach/text-flow-parts ... Update text flow usages to use `ITextPart`	2021-10-29 22:32:46 +09:00
Dean Herbert	1fd05ab78a	Update framework	2021-10-29 18:56:13 +09:00
Dean Herbert	a16c8f1ebc	Update all beatmap overlay views to use APIBeatmap/APIBeatmapSet	2021-10-29 18:50:55 +09:00
Dean Herbert	b8ee7e05f4	Expose more pieces of APIBeatmap for testing purposes	2021-10-29 18:35:27 +09:00
Dean Herbert	993a28b37e	Merge branch 'beatmap-refactor/difficulty-icons' into beatmap-refactor/beatmap-overlays	2021-10-29 18:35:26 +09:00
Dean Herbert	07e3ced315	Fix test scene and remove "impossible" nullable coalesce	2021-10-29 18:22:23 +09:00
Dean Herbert	7db8bdfb7c	Fix fallback logic not considering case where ruleset is not available ... Occurs only in tests.	2021-10-29 18:16:54 +09:00
Dean Herbert	8ad33d43d0	Merge branch 'beatmap-refactor/get-and-present' into beatmap-refactor/beatmap-overlays	2021-10-29 18:01:17 +09:00
Dean Herbert	3be9c487f8	Merge branch 'beatmap-refactor/download-tracker' into beatmap-refactor/beatmap-overlays	2021-10-29 18:01:12 +09:00
Dean Herbert	90503f72ca	Update PresentBeatmap to support interface types	2021-10-29 17:43:39 +09:00
Dean Herbert	b5834044e0	Update GetScoreRequest to support requests with interface types	2021-10-29 17:43:39 +09:00
Dean Herbert	be0564f732	Update DifficultyIcon classes to use IBeatmapInfo	2021-10-29 17:05:06 +09:00
Dean Herbert	aff216840f	Add a note about OnlineID potentially being zero in non-autoincrement cases	2021-10-29 16:54:03 +09:00
Dean Herbert	7583435901	Refactor BeatmapDifficultyCache to work with IBeatmapInfo	2021-10-29 16:45:10 +09:00
smoogipoo	2408011c81	Don't replace identical playlist items	2021-10-29 16:44:51 +09:00
smoogipoo	f732c44265	Fix broken equality comparer	2021-10-29 16:23:10 +09:00
smoogipoo	e667ef4eea	Add basic tests	2021-10-29 15:44:48 +09:00
smoogipoo	42dfb341da	Fix PlaylistItemChanged() not updating current item	2021-10-29 15:44:42 +09:00
Dean Herbert	31403daa20	Change DrawableProfileScore to use APIScoreInfo	2021-10-29 15:14:52 +09:00
Dean Herbert	17a83f701a	Store mods as APIMods for the time being	2021-10-29 15:13:49 +09:00
Dean Herbert	06b6bcfd29	Add xmldoc for CreateScoreInfo function for now ... I don't actually know how temporary this one is going to be. The usages are quite deep - ie. converting to a `ScoreInfo` to get a calculated total score for ordering purposes.	2021-10-29 14:51:07 +09:00
Dean Herbert	f68d6dbc8f	Update score submission serialisation tests to use SubmittableScore	2021-10-29 14:32:31 +09:00
Dean Herbert	cd7bd935f6	Remove Statistics from interface until we figure how to properly deserialise	2021-10-29 14:18:10 +09:00
Dean Herbert	3f030cebf4	Remove local score copying in GetScoresRequest to allow APIScoreInfo.Beatmap to be APIBeatmap	2021-10-29 14:14:25 +09:00
Dean Herbert	54073d8a1e	Isolate score submissions model and remove serialisation from ScoreInfo	2021-10-29 14:13:43 +09:00
Dean Herbert	1944c255a7	Implement score interfaces	2021-10-29 13:49:30 +09:00
Dean Herbert	49b5de64be	Extract interface	2021-10-29 13:41:21 +09:00
Dean Herbert	817369903a	Rename API score classes	2021-10-29 13:40:56 +09:00
Bartłomiej Dach	61f0339c1d	Avoid double-adding chunks in link flow container	2021-10-29 06:34:08 +02:00
Bartłomiej Dach	6f863ca204	Adjust game-side text flow containers to part-based model	2021-10-29 06:34:08 +02:00
Dean Herbert	414d920ca2	Revert to previous exposure of RoomSubScreen.BeatmapAvailability	2021-10-29 12:02:10 +09:00
Dean Herbert	b252b176d4	Seal implementation and add comment about LoadComplete execution order	2021-10-29 11:59:07 +09:00
Dean Herbert	f3811edb0b	Add inline comment explaining usage of RequiresChildrenUpdate override	2021-10-29 11:57:54 +09:00
Dean Herbert	dc44734db2	Simplify null check in ScoreDownloadTracker and remove unnecessary ID check	2021-10-29 11:56:17 +09:00
Dean Herbert	75a088d4f4	Fix variable name mismatch	2021-10-29 11:54:42 +09:00
Dean Herbert	748003b016	Simplify Manager null check to a single pre-check	2021-10-29 11:54:19 +09:00
Dean Herbert	3b095e1626	Merge branch 'master' into beatmap-refactor/download-tracker	2021-10-29 11:50:54 +09:00
Dean Herbert	34d4715220	Allow for long online IDs and implement in ScoreInfo	2021-10-29 11:48:36 +09:00
Dean Herbert	3838fe5c6a	Fix typo in variable name	2021-10-29 11:39:15 +09:00
Dean Herbert	8d21f0b04b	Add migration to reset conflicting scroll speed key bindings	2021-10-29 11:14:22 +09:00
Dean Herbert	ce29d6fd81	Change scroll speed adjust defaults to F3/F4 ... Not the most obvious keys, but does match stable expectations so let's go with it for now. Rationale for not using +/- is that local audio offset was bound to those, and people will expect it to be when we get to implementing eventually. Also, adjust the scroll speed is a pretty rare thing to do since it's been constant across beatmaps for years now.	2021-10-29 11:13:07 +09:00
smoogipoo	f076b72fbe	Merge branch 'master' into multi-queueing-modes	2021-10-29 10:48:16 +09:00
Bartłomiej Dach	9199f2b337	Merge branch 'master' into ui-scaling-keybind	2021-10-28 18:20:34 +02:00
smoogipoo	2b3e63470d	Merge branch 'master' into always-unique-test-online-ids	2021-10-28 18:23:45 +09:00
Dean Herbert	d8d4839e43	Merge pull request #15339 from smoogipoo/fix-test-crash ... Fix playlists room creation test crash	2021-10-28 17:28:46 +09:00
Dean Herbert	4f4f2503aa	Merge pull request #15335 from smoogipoo/cleanup-multiplayer-screen-tests ... Clean up multiplayer-screen tests by removing intermediate screen	2021-10-28 17:28:26 +09:00
Dan Balasescu	e5a7589859	Merge pull request #15317 from peppy/beatmap-refactor/uncontested ... Update `UpdateableBeatmapBackgroundSprite` to accept `IBeatmapInfo`	2021-10-28 17:24:49 +09:00
Dean Herbert	b096bf6cd1	Ensure all test beatmaps have unique OnlineIDs to avoid import conflicts ... The order of operation of imports means that the already-imported instances are considered most correct (they have usually been populated using an online source, although that is skipped in tests), so on two consecutive test imports in a test scene, the second will lose its online IDs completely. This aims to ensure that all test beatmaps will have online IDs, which is the general expected behaviour.	2021-10-28 16:56:31 +09:00
smoogipoo	bacaa9d201	Fix playlists test crash	2021-10-28 16:48:17 +09:00
Dean Herbert	6f5040722a	Merge branch 'master' into beatmap-refactor/uncontested	2021-10-28 16:37:26 +09:00
Dean Herbert	1e1f8c472a	Add icons to various progress notification states	2021-10-28 16:34:12 +09:00
Dan Balasescu	44ba4419a2	Merge branch 'master' into beatmap-refactor/tournament	2021-10-28 15:25:34 +09:00
smoogipoo	0e293471c2	Clean up multiplayer-screen tests by removing intermediate screen	2021-10-28 14:29:49 +09:00
Dean Herbert	5c7623e68e	Merge pull request #15255 from goodtrailer/node-samples-ilist ... Change IHasRepeats.NodeSamples to IList from List	2021-10-28 14:24:26 +09:00
Dean Herbert	aaabaaa5dd	Merge pull request #15320 from smoogipoo/fix-online-play-request-handling ... Fix online play request handling in tests	2021-10-28 14:24:00 +09:00
Dean Herbert	3905ecd18b	Use retrieval of bindable and tidy up code slightly	2021-10-28 13:09:03 +09:00
Dean Herbert	ad1bd4e48e	Merge branch 'master' into ui-scaling-keybind	2021-10-28 13:03:21 +09:00
Dean Herbert	add39fbd4f	Merge branch 'master' into fix-skin-layout-editor-crash	2021-10-28 06:24:24 +09:00
Dean Herbert	65a7b6776e	Add note regarding OnlineInfo being temporary	2021-10-28 05:50:22 +09:00
Dean Herbert	a9208838a9	Merge pull request #15307 from peppy/playlist-remaining-attempt-display ... Show remaining attempts again on playlist screen	2021-10-28 05:28:20 +09:00
Dean Herbert	290f583ae0	Fix incorrect initial state	2021-10-28 00:59:48 +09:00
Dean Herbert	7245baba69	Remove IBeatmapSetOnlineInfo implementation from BeatmapSetInfo to avoid null cases	2021-10-28 00:50:45 +09:00
Dean Herbert	746d6a4c16	Fix some oversights and test failures	2021-10-27 23:42:27 +09:00
Dean Herbert	f014ceaead	Update remaining usages of download tracking	2021-10-27 21:00:46 +09:00
Dean Herbert	dd06c617b1	Update OnlinePlayBeatmapAvailabilityTracker in line with new download tracker ... The structure here has changed a bit - rather than deriving from the donwload tracker I moved the additional logic into the callbacks. I think this feels better?	2021-10-27 21:00:46 +09:00
Dean Herbert	6339064dbd	Remove old versions of DownloadTrackingComposite	2021-10-27 21:00:46 +09:00
Dean Herbert	692db9a9ec	Remove unnecessary verification flow from score download tracking	2021-10-27 21:00:46 +09:00
Dean Herbert	617e6febb6	Refactor ModelDownloader to allow for different OnlineID matching	2021-10-27 21:00:46 +09:00
Dean Herbert	9015ac6ba8	Implement new version of download tracker	2021-10-27 21:00:46 +09:00
smoogipoo	f3dba49aae	Rename room managers	2021-10-27 19:36:32 +09:00
Dean Herbert	db6343c44c	Correctly redirect BPM from API to interface	2021-10-27 17:09:51 +09:00
Dean Herbert	40d963fc8a	Allow setting of APIBeatmap.Length (and don't serialise twice)	2021-10-27 16:44:21 +09:00
Dean Herbert	f268363924	Update UpdateableBeatmapBackgroundSprite to accept IBeatmapInfo	2021-10-27 16:38:48 +09:00
smoogipoo	85b21174dd	Fix online play test request handling	2021-10-27 14:49:50 +09:00
Dean Herbert	95837990f3	Apply some second-pass inspections that appeared after previous changes	2021-10-27 13:09:30 +09:00
Dean Herbert	6944151486	Apply batch fixing of built-in types using var	2021-10-27 13:04:41 +09:00
Bartłomiej Dach	3de994449d	Add support for changing dimensions of difficulty spectrum display	2021-10-26 23:06:52 +02:00
Bartłomiej Dach	1a77e98537	Implement difficulty spectrum display	2021-10-26 23:06:52 +02:00
Jason Won	c633e2e952	only propagate unmodified right click	2021-10-26 16:24:53 -04:00
Jason Won	f64fa65fd5	right click on unselected object shows context menu	2021-10-26 14:52:15 -04:00
Dean Herbert	70f432805e	Merge branch 'master' into ui-scaling-keybind	2021-10-27 01:06:14 +09:00
Dean Herbert	411586bac3	Update resources	2021-10-26 22:12:56 +09:00
Dean Herbert	c15bfb2cf4	Handle bindable changes to fix new playlist creation not showing correct details	2021-10-26 18:19:05 +09:00
Dean Herbert	42d8d4fd38	Add tooltips to start button to explain why it's not clickable	2021-10-26 18:06:08 +09:00
Dean Herbert	1c578f285a	Disable playlist start button when attempts have been exhausted	2021-10-26 18:06:08 +09:00
Dean Herbert	bffd9162ba	Tint attempt count red when no attempts remain	2021-10-26 18:06:08 +09:00
Dean Herbert	708d40931b	Add back remaining attempt display on playlist room screen	2021-10-26 18:06:08 +09:00
Dean Herbert	d5b4c68d3a	Merge branch 'master' into fix-slider-path-extension-incorrectness	2021-10-26 17:36:50 +09:00
Dean Herbert	e92def0ba2	Fix LegacyBeatmapEncoder using incorrect path length value	2021-10-26 17:34:52 +09:00
Dan Balasescu	6a6d3a5e8a	Merge pull request #15304 from peppy/fix-editor-new-beatmap-sample-change-crash ... Fix editor crash when attempting to change sample/velocity from timeline on new beatmap	2021-10-26 17:13:56 +09:00
Dean Herbert	4cef86dd12	Merge pull request #15301 from jaswon/reverse-slider-symmetric ... Fix slider shape not always being maintained when reversing	2021-10-26 16:17:29 +09:00
Dean Herbert	ea55ba7ba9	Remove unused using statement	2021-10-26 16:08:21 +09:00
Dean Herbert	dae7cdc4c5	Ensure HitObject-local control points are non-default after ApplyDefaults ... We will probably want to make this whole flow more efficient in the future, but this should suffice for now.	2021-10-26 16:06:03 +09:00
Dean Herbert	5e5b86a1f4	Merge pull request #15156 from Susko3/use-ShowFileInNativeExplorer ... Update usages of `OpenInNativeExplorer` to use `PresentFileExternally` / `PresentExternally`	2021-10-26 15:53:03 +09:00
Dean Herbert	81fee02c2b	Fix slider paths being extended even when the last two points are equal	2021-10-26 15:47:59 +09:00
Dan Balasescu	f687ed8599	Merge pull request #15283 from peppy/test-api-beatmap-set ... Add ability to make test `APIBeatmapSet`s from test scenes	2021-10-26 15:34:19 +09:00
Dan Balasescu	7b8982c87c	Merge pull request #15302 from peppy/fix-multiplayer-chat-escape-focus ... Fix gameplay chat display not losing focus on escape key press	2021-10-26 15:34:05 +09:00
Dan Balasescu	efe6763226	Merge branch 'master' into move-online-beatmap-metrics	2021-10-26 14:24:40 +09:00
Dean Herbert	370775af68	Fix some surrounding code formatting	2021-10-26 14:05:07 +09:00
Dean Herbert	53ff0802cb	Merge branch 'master' into use-ShowFileInNativeExplorer	2021-10-26 13:58:30 +09:00
Dean Herbert	26fb9af021	Update framework	2021-10-26 13:58:07 +09:00
Dean Herbert	6c38028d06	Fix gameplay chat display not losing focus on escape key press ... Closes #15293.	2021-10-26 13:55:08 +09:00
Dan Balasescu	1e3c84b34b	Merge branch 'master' into use-beatmap-interfaces-more-uncontested	2021-10-26 13:51:55 +09:00
Dan Balasescu	676e7ff2a6	Merge pull request #15287 from peppy/get-beatmap-request-via-interface ... Allow API beatmap requests using interface type	2021-10-26 13:50:46 +09:00
Jason Won	a582976851	reversing slider maintains shape	2021-10-26 00:05:46 -04:00
Dean Herbert	d7ac94038a	Update GetBeatmapRequest to use AddParameter	2021-10-26 12:05:31 +09:00
Dean Herbert	5d1170aaf4	Remove unnecessary null check	2021-10-26 11:57:51 +09:00
Bartłomiej Dach	a49a1f41cb	Merge branch 'master' into move-online-beatmap-metrics	2021-10-25 20:33:49 +02:00
Bartłomiej Dach	5a03e1736e	Merge branch 'master' into update-beatmap-set-status-pill-appearance	2021-10-25 20:26:49 +02:00
Bartłomiej Dach	6802e9ec10	Remove FixedWidth and add AutoSizeAxes specs to all usages	2021-10-25 20:24:48 +02:00
Dean Herbert	b65d199f6a	Fix incorrect length when calling APIBeatmap.ToBeatmapInfo	2021-10-25 17:01:47 +09:00
Dean Herbert	6adb0f068b	Fix multiple issues with json serialisation of online info (causing tournament failures)	2021-10-25 16:52:50 +09:00
Dean Herbert	67ef1c40e6	Allow API beatmap requests using interface type	2021-10-25 15:59:40 +09:00
Dean Herbert	2c308f3008	Rename BeatmapMetrics to APIFailTimes	2021-10-25 15:34:41 +09:00
Dean Herbert	4969ab0599	Add forgotten JsonIgnore rules on interface types ... Just to avoid them getting serialised as part of the "new" .osu serialisation format.	2021-10-25 15:32:18 +09:00
Dean Herbert	20baae9094	Move online metrics out of BeatmapInfo model	2021-10-25 15:32:18 +09:00
Dean Herbert	045dd94a6e	Move online metrics out of BeatmapSetInfo model	2021-10-25 15:12:39 +09:00
Dean Herbert	94175bfb4a	Update PreviewTrackManager to use IBeatmapSetInfo	2021-10-25 14:25:01 +09:00
Dean Herbert	19312435d0	Add ability to make test APIBeatmaps from test scenes ... Allow tests to create a sample `APIBeatmapSet` One step towards removing calls to `ToBeatmap` / `ToBeatmapSet`.	2021-10-25 14:18:13 +09:00
Dean Herbert	78edc7554e	Fix BeatmapSetInfo's Status value being marked as non-databased	2021-10-25 12:05:34 +09:00
Bartłomiej Dach	feedd53a53	Add support for setting fixed size of status pill	2021-10-24 21:37:00 +02:00
Bartłomiej Dach	5ab3337a10	Update beatmap set status pill appearance	2021-10-24 20:40:34 +02:00
Dean Herbert	26cf5370c3	Remove unused reader parameter	2021-10-24 23:48:46 +09:00
Dean Herbert	5303cae044	Add mention of stream close logic	2021-10-24 23:43:37 +09:00
Susko3	51c5d0aec7	Update to be in line with framework changes	2021-10-24 13:21:41 +02:00
Bartłomiej Dach	d24fbc6ade	Merge branch 'master' into fix-skin-layout-editor-crash	2021-10-24 12:58:56 +02:00
Bartłomiej Dach	051cc2cd92	Update reference to configuration population process in comment	2021-10-24 12:47:17 +02:00
goodtrailer	0affe7b79d	Remove unnecessary using	2021-10-23 02:25:20 -07:00
goodtrailer	4440b9ca11	Change IHasRepeats.NodeSamples to IList from List	2021-10-23 01:59:07 -07:00
Susko3	4a425b5c3e	Merge remote-tracking branch 'upstream/master' into use-ShowFileInNativeExplorer	2021-10-23 10:01:24 +02:00
Joseph Madamba	1ae6621c85	Fix a missed toast shortcut string not localising correctly	2021-10-22 15:45:48 -07:00
Dan Balasescu	c6ca0e5895	Merge branch 'master' into fix-password-popover-focus	2021-10-22 22:52:46 +09:00
Dan Balasescu	9bb0d32fda	Merge pull request #15247 from peppy/beatmap-metadata-container-interface ... Refactor `BeatmapMetadataContainer` and usages to use interface types	2021-10-22 22:42:23 +09:00
smoogipoo	7d910ebb57	Add SignalR binding for PlaylistItemChanged	2021-10-22 22:37:08 +09:00
Dan Balasescu	e8fbb19c63	Merge branch 'master' into remove-unused-classes	2021-10-22 22:25:22 +09:00
smoogipoo	04b0529a7f	Fix list overflowing subscreen background	2021-10-22 22:17:26 +09:00
smoogipoo	a4397ee68c	Add playlist continuation flow	2021-10-22 22:07:41 +09:00
smoogipoo	76eff7f6b1	Fix incorrect indexing	2021-10-22 21:57:29 +09:00
Dean Herbert	c701579c69	Refactor BeatmapMetadataContainer and usages to use interface types	2021-10-22 21:38:50 +09:00
smoogipoo	6775151c30	Add Expired bool to APIPlaylistItem	2021-10-22 21:36:36 +09:00
smoogipoo	1b4be61ed1	Fix finished-play state not handled correctly	2021-10-22 21:16:10 +09:00
Dean Herbert	28d8820976	Merge pull request #15224 from peppy/no-more-beatmap-metadata-base ... Remove `BeatmapMetadata` base class from API classes	2021-10-22 21:07:29 +09:00
smoogipoo	d7a98097a1	Make DrawableRoomPlaylist handle expired items	2021-10-22 21:04:52 +09:00
smoogipoo	ec02e16c81	Add playlist item change event	2021-10-22 20:53:45 +09:00
smoogipoo	4e6a02bde9	Fix missing QueueMode copies	2021-10-22 20:14:04 +09:00
smoogipoo	95ab82fb58	Remove BeatmapSelectionControl and inline at usage sites	2021-10-22 19:41:36 +09:00
Dean Herbert	90477e3788	Remove unused BeatmapTypeInfo class ... Helps reduce the scope of upcoming changes.	2021-10-22 19:13:50 +09:00
Dan Balasescu	14a7b00f58	Merge pull request #15242 from peppy/fix-low-pass-sticking-after-fail ... Fix low-pass filter continuing to take effect after fail animation has already ended	2021-10-22 19:04:03 +09:00
Dean Herbert	cc1d759290	Remove unnecessary setters from IBeatmapSetOnlineInfo interface	2021-10-22 17:48:09 +09:00
Dean Herbert	91cc77407d	Fix low-pass filter continuing to take effect after fail animation has already ended	2021-10-22 17:02:02 +09:00
smoogipoo	db87e42d47	Remove beatmap/ruleset/etc from MultiplayerRoomSettings	2021-10-22 16:48:28 +09:00
Dean Herbert	ea473428e8	Fix incorrect length mapping in APIBeatmap	2021-10-22 15:54:40 +09:00
Dean Herbert	de33b2f45a	Return set metadata if available before falling back to empty object	2021-10-22 15:00:31 +09:00
Dean Herbert	eef9949a0a	Remove unnecessary branching around EF logic	2021-10-22 14:48:20 +09:00
Dean Herbert	93482414d6	Remove SkinConfiguration subclasses and allow configuration parsing for all skin types	2021-10-22 14:42:23 +09:00
Dean Herbert	82d0a6515f	Fix incorrect conditional for checking whether import (would fail for default skin)	2021-10-22 14:08:12 +09:00
Dean Herbert	9cdc1ba592	Fix default legacy skin not being able to read from stored skin.ini	2021-10-22 13:43:45 +09:00
Dean Herbert	e5b73f25cd	Ensure newly created skin.ini files are set to latest version	2021-10-22 12:56:05 +09:00
smoogipoo	a1c9b56083	Rename modes	2021-10-22 12:55:37 +09:00
Dean Herbert	fb7cf35481	Remove BeatmapMetadata base class from APIBeatmap	2021-10-21 21:48:14 +09:00
Dean Herbert	6dd54a417f	Remove BeatmapMetadata base class from APIBeatmapSet	2021-10-21 21:32:07 +09:00
Dean Herbert	9e0d839ef3	Merge branch 'master' into fix-skin-layout-editor-crash	2021-10-21 20:33:47 +09:00
Dean Herbert	c580ec865f	APIBeatmapSet.Covers is never null	2021-10-21 19:34:01 +09:00
Dean Herbert	0fe0b5dc09	APIBeatmap implements IBeatmapInfo	2021-10-21 19:14:31 +09:00
Dean Herbert	40a176e86e	APIBeatmapSet implements IBeatmapSetInfo	2021-10-21 19:14:19 +09:00
Dean Herbert	69e7810dad	Enable nullable and switch classes to structs	2021-10-21 18:54:36 +09:00
Dan Balasescu	8ae05ee8f7	Merge branch 'master' into online-info-as-interface	2021-10-21 17:14:57 +09:00
Dean Herbert	0335ed6f27	Add missing licence header	2021-10-21 17:14:29 +09:00
smoogipoo	f41cf822b0	Rename request	2021-10-21 17:02:11 +09:00
Dean Herbert	ff674ca913	Remove unnecessary access modifiers from interface	2021-10-21 17:01:57 +09:00
Dean Herbert	b73bd54ab2	Split out individual pieces into own files	2021-10-21 16:58:42 +09:00
Dean Herbert	32d01f022f	Rename usages which rely on online backing	2021-10-21 16:58:42 +09:00
Dean Herbert	0706ad70fb	Move BeatmapSetOnlineInfo to an interface type	2021-10-21 16:58:42 +09:00
Dean Herbert	a5c155bc87	Remove APIPlaylistBeatmap subclass	2021-10-21 16:43:46 +09:00
Dean Herbert	a5088cac27	Fix default metadata propagation when no files are present	2021-10-21 13:43:42 +09:00
Dean Herbert	59b7210efa	Revert disallowing imports with no files ... While it is logical that we want this, from a testing perspective this is a bit of a nightmare to fix. Let's revisit at a later point in time.	2021-10-21 13:43:42 +09:00
Dean Herbert	7bc8f5cd5c	Change selection colour to also match the colour provider scheme	2021-10-21 13:01:13 +09:00
Bartłomiej Dach	9ad9465020	Remove online-screen-local textbox recolours	2021-10-20 22:49:25 +02:00
Bartłomiej Dach	1ec881ce1d	Recolour focused text box variant	2021-10-20 22:49:25 +02:00
Bartłomiej Dach	addcef4f5d	Recolour text box using OverlayColourProvider	2021-10-20 22:49:25 +02:00
smoogipoo	691e414acb	Add request to add a new playlist item	2021-10-20 21:08:58 +09:00
smoogipoo	67090fc598	Re-namespace enum	2021-10-20 20:52:16 +09:00
smoogipoo	599867a3b1	Add implementation to settings overlay	2021-10-20 20:29:06 +09:00
Dean Herbert	68c01fc204	Fix infinite loop on default skin (it can't have a skin.ini)	2021-10-20 17:56:45 +09:00
Dean Herbert	9e6e41d7c0	Add migration to reset and repopulate existing skin hashes	2021-10-20 17:56:45 +09:00
Dean Herbert	602303e947	Add test coverage for skin.ini contents	2021-10-20 17:56:45 +09:00
Dean Herbert	a95c754fd3	Fix multiple issues and make metadata fallback process more logical	2021-10-20 17:56:45 +09:00
smoogipoo	0e446105fb	Rename to "picking mode" as simpler english	2021-10-20 17:52:51 +09:00
smoogipoo	bc57190fb4	Make dropdown not move the selection control	2021-10-20 17:52:05 +09:00
smoogipoo	0b8edb0812	Add english descriptions	2021-10-20 17:50:02 +09:00
Dean Herbert	439e90fce3	Disallow archive imports with no hashable files	2021-10-20 17:45:06 +09:00
Dean Herbert	fa542f2547	Include json files in skin hashing ... This covers the new layout storage we are doing.	2021-10-20 17:45:06 +09:00
Dean Herbert	789c715f13	Add skin.ini write support to allow for more correct hashing	2021-10-20 17:45:06 +09:00
smoogipoo	116ce09e49	Merge branch 'master' into multi-queueing-modes	2021-10-20 17:27:25 +09:00
Dan Balasescu	08f3bc3f44	Merge pull request #15120 from peppy/realm-importer ... Implement realm beatmap importer	2021-10-20 16:44:16 +09:00
Dean Herbert	da750a74fc	Add xmldoc mention of valid OnlineID values	2021-10-20 15:24:27 +09:00
smoogipoo	c8cdc38efd	Always compare OnlineIds by >0	2021-10-20 15:20:34 +09:00
smoogipoo	2c979d6420	Merge branch 'master' into localise-toasts	2021-10-20 15:04:07 +09:00
smoogipoo	a06f624a4a	Fix possible exception with "invalid" key ... Triggered by toggling Shift+Tab during gameplay.	2021-10-20 15:03:16 +09:00
smoogipoo	ea9c070e59	Add setting for queue mode	2021-10-20 14:51:59 +09:00
Dean Herbert	4b2eb7736c	Move helper method to bottom of file	2021-10-20 12:52:38 +09:00
Dean Herbert	37841ca3aa	Remove incorrect ToString calls causing localisation to not actually apply	2021-10-20 10:41:34 +09:00
Bartłomiej Dach	f29eb08d93	Improve contrast in default OverlayColourProvider-themed appearance	2021-10-19 22:55:49 +02:00
Bartłomiej Dach	80da153697	Recolour a few other existing dropdowns with same hover & selection colours	2021-10-19 22:47:18 +02:00
Bartłomiej Dach	61127a389c	Fix tab dropdown receiving accent colour too early	2021-10-19 22:09:51 +02:00
Bartłomiej Dach	ef03787fe0	Split dropdown accent colour into hover and selection colours	2021-10-19 22:09:51 +02:00
Dean Herbert	8672b3325a	Fix a couple more weird variable names	2021-10-19 17:22:50 +09:00
Dean Herbert	61670a70b6	Tidy up tracked settings code syntax and fix remaining issue	2021-10-19 17:21:07 +09:00
Dean Herbert	192cfe8717	Replace unnecessary ToString call ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-10-19 16:42:07 +09:00
Dean Herbert	c97cfdd978	Merge branch 'master' into localise-toasts	2021-10-19 16:37:14 +09:00
Dean Herbert	7cf4395875	Merge branch 'master' into default-value-indicator	2021-10-19 16:23:02 +09:00
Dean Herbert	480dc57102	Schedule joinFailed callback for added safety	2021-10-19 15:54:12 +09:00
Dean Herbert	da524261c0	Fix focus potentially being transferred too far up when password is being verified	2021-10-19 15:53:29 +09:00
Dean Herbert	a589964dc7	Centralise join logic	2021-10-19 15:53:29 +09:00
Dean Herbert	8944b1dd78	Add basic test coverage of DrawableLoungeRoom	2021-10-19 15:36:27 +09:00
Dean Herbert	473459d191	Add layout duration to PasswordEntryPopover to make error text look a bit smoother	2021-10-19 15:36:27 +09:00
Dean Herbert	d35fe5493a	Change default value of DrawableLoungeRoom.matchingFilter so they display by default	2021-10-19 15:36:27 +09:00
Dean Herbert	d3ab45084d	Fix realm migration potentially failing from older releases	2021-10-19 14:19:58 +09:00
sh0ckR6	e7b280fc81	Comment out RankDisplay ... Commented out as it may be revisited at a later time. Also currently unused.	2021-10-18 23:12:33 -04:00
Dean Herbert	ff2eae4597	Rename confusing variable	2021-10-19 11:37:46 +09:00
Dan Balasescu	30af27e561	Merge branch 'master' into realm-importer	2021-10-19 11:06:11 +09:00
Dan Balasescu	4fcdeffbd9	Merge pull request #15176 from peppy/realm-indexed-online-id ... Change `OnlineID` to non-nullable to allow for indexing in Realm	2021-10-19 11:05:34 +09:00
Bartłomiej Dach	8db2fc439d	Change ruleset ID assert in player to null-check	2021-10-18 23:45:06 +02:00
Bartłomiej Dach	6d9d85685f	Fix settings item having zero height	2021-10-18 23:30:38 +02:00
Bartłomiej Dach	cc9727ec11	Merge branch 'master' into default-value-indicator	2021-10-18 22:07:58 +02:00
Bartłomiej Dach	88a1b31fae	Remove grid usage in SettingsItem	2021-10-18 22:07:32 +02:00
Bartłomiej Dach	6c3637a62a	Remove grid usage in KeyBindingRow	2021-10-18 22:07:30 +02:00
Bartłomiej Dach	830f49bca6	Remove doubled-up opacity specification	2021-10-18 19:43:48 +02:00
Dean Herbert	b3219bb592	Update usages of OnlineID	2021-10-18 16:16:36 +09:00
Dean Herbert	6904938dc1	Merge branch 'realm-indexed-online-id' into realm-importer	2021-10-18 16:14:37 +09:00
Dean Herbert	88a575462c	Work around weird null inspection	2021-10-18 16:11:55 +09:00
Dean Herbert	2c5ba1d8e2	Change OnlineID to non-nullable to allow for indexing in Realm	2021-10-18 15:53:40 +09:00
Dan Balasescu	8643c725cc	Merge pull request #15175 from peppy/fail-animation-flash-controlled-by-setting ... Don't flash screen red on fail if the user has disabled red tinting	2021-10-18 15:27:10 +09:00
Dan Balasescu	f2f9872718	Merge pull request #15173 from peppy/fix-epilepsy-warning-fade-out ... Fix epilepsy warning not being faded out on an early exit during gameplay load	2021-10-18 15:18:38 +09:00
Dean Herbert	b2f9f8b8da	Update logic surrounding removal of previous OnlineIDs when running a new import	2021-10-18 15:14:13 +09:00
Dean Herbert	264fa703f2	Remove some forgotten temporary code from BeatmapImporter ... And make the online queue not `dynamic`, at very least.	2021-10-18 14:43:50 +09:00
Dean Herbert	75bfa705cf	Remove unused method for now	2021-10-18 14:32:38 +09:00
Dean Herbert	ad112cbbc5	Fix intendation in a way it doesn't regress with older inspectcode	2021-10-18 14:28:29 +09:00
Dean Herbert	3c4c9ab7a7	Move ICanAcceptFiles specification to IModelImporter<TModel>	2021-10-18 14:25:51 +09:00
Dean Herbert	762949f49f	Don't flash screen red on fail if the user has disabled red tinting	2021-10-18 14:20:38 +09:00
Dean Herbert	6d6eed61aa	Fix new indentation inspections	2021-10-18 14:00:35 +09:00
Dean Herbert	59dc04017e	Fix epilepsy warning not being faded out on an early exit from PlayerLoader	2021-10-18 13:30:37 +09:00
Bartłomiej Dach	2a41e8bd1f	Remove unneeded extra padding from settings number box	2021-10-17 21:50:04 +02:00
Bartłomiej Dach	552fc1dc8a	Adjust key binding rows to accommodate new default value indicator	2021-10-17 21:50:04 +02:00
Bartłomiej Dach	f422ebb281	Adjust SettingsItem to accommodate new default value indicator	2021-10-17 21:50:03 +02:00
Bartłomiej Dach	818f35c35f	Restyle default value indicator	2021-10-17 21:50:03 +02:00
5ln	3529f34c98	Multi: Hide mods when spectating or Beatmap isn't Locally Available. ... Signed-off-by: 5ln <xnafumie@gmail.com>	2021-10-18 02:01:50 +08:00
Susko3	25f172fae8	Update usages of OpenInNativeExplorer to use ShowFileInNativeExplorer ... Also updates WrappedStorage to override ShowFileInNativeExplorer.	2021-10-17 12:56:29 +02:00
Bartłomiej Dach	874decb3cd	Replace spectator-local fix for wrong ruleset ID with player-global consistency check	2021-10-16 16:10:42 +02:00
Bartłomiej Dach	e57d6e930e	Source spectator state sent to server from gameplay state	2021-10-16 13:48:49 +02:00
Dean Herbert	7a5a612896	Move retry and exit hotkey overlays to same depth / container	2021-10-16 02:29:45 +09:00
Dean Herbert	e9f50179ab	Merge branch 'master' into fail-animation-update	2021-10-15 23:32:10 +09:00
Dean Herbert	91754450b2	Remove dispose method completely	2021-10-15 21:27:44 +09:00
Dean Herbert	6f947cacbd	Fix test failures	2021-10-15 21:22:38 +09:00
smoogipoo	2fd101ad50	Reorder elements to follow designs	2021-10-15 20:25:32 +09:00
smoogipoo	a70d7e4feb	Remove unnecessary extra GridContainer	2021-10-15 20:18:25 +09:00
smoogipoo	6f89e30f56	Add QueueingMode to MultiplayerRoomSettings	2021-10-15 20:17:19 +09:00
Dean Herbert	c47497923a	Schedule drag events for now	2021-10-15 19:52:44 +09:00
Dean Herbert	30c3fcb4ea	Merge branch 'master' into slider-timeline-velcotiy-adjust-v2	2021-10-15 19:45:04 +09:00
Dean Herbert	3909fd8caa	Fix wonkiness when dragging slider end at high input refresh rates	2021-10-15 19:43:57 +09:00
Dean Herbert	b9fd1f52df	Tweak animation slightly	2021-10-15 19:37:22 +09:00
Dean Herbert	b08743342b	Fix incorrect nesting	2021-10-15 19:35:08 +09:00
Dean Herbert	66f3370a19	Add new fail animation to better match new sound effects	2021-10-15 19:14:59 +09:00
Dean Herbert	a59ee9ec1f	Merge pull request #15121 from nekodex/fail-highpass ... Add high-pass filter to gameplay fail sequence	2021-10-15 19:14:44 +09:00
Dean Herbert	ae33b7b87f	Update resources	2021-10-15 18:27:01 +09:00
Dan Balasescu	8d11f4ce48	Merge pull request #15075 from peppy/fix-editor-difficulty-name-update ... Use actual `BeatmapInfo` rather than `PlayableBeatmap.BeatmapInfo` for editor writes	2021-10-15 18:12:12 +09:00
Dan Balasescu	3d314dad9f	Merge pull request #15115 from peppy/fix-realm-config-save-overhead ... Fix changing osu!mania scroll speed causing game-wide lag	2021-10-15 17:33:42 +09:00
Dean Herbert	0e1f144bf4	Rename ArchiveModelImporter with Realm prefix to avoid confusion	2021-10-15 17:08:43 +09:00
Dean Herbert	cd64faa4f9	Tidy up importer difficulty creation code	2021-10-15 17:07:34 +09:00
Dean Herbert	49969ac328	Add beatmap import and file store tests	2021-10-15 17:07:34 +09:00
Jamie Taylor	8d6d7fcdbe	Add high-pass filter to gameplay fail sequence	2021-10-15 17:03:37 +09:00
Dean Herbert	d95a62fa56	Add models and stores for beatmap manager requirements	2021-10-15 16:58:41 +09:00
Dan Balasescu	3604a762d0	Merge branch 'master' into fix-editor-difficulty-name-update	2021-10-15 16:58:01 +09:00
Dan Balasescu	05150b34e5	Merge pull request #15117 from peppy/update-present-import-post-import ... Update one missed instance of `PresentImport`	2021-10-15 16:57:47 +09:00
Dan Balasescu	56758435ee	Merge pull request #15043 from peppy/realm-ruleset-store ... Add realm `RulesetStore`	2021-10-15 16:49:48 +09:00
Dean Herbert	8fb9aec730	Fix threaded realm usage not disposing context fast enough	2021-10-15 16:39:53 +09:00
Dan Balasescu	34d60b9e10	Merge branch 'master' into fix-realm-config-save-overhead	2021-10-15 16:30:39 +09:00
Dean Herbert	e9c3d09e0e	Remove redundant specs	2021-10-15 16:27:16 +09:00
Dean Herbert	fdb734ac91	Also add spec directly to IModelImporter	2021-10-15 16:24:40 +09:00
Dean Herbert	2eb1170c0c	Use AsNonNull instead	2021-10-15 16:15:34 +09:00
Dean Herbert	efaed4cba4	Revert "Attempt bumping inspectcode to fix remaining inspection" ... This reverts commit e018a6d6a5.	2021-10-15 16:14:57 +09:00
Dean Herbert	a90f40e831	Update one missed instance of PresentImport	2021-10-15 16:00:09 +09:00
Dan Balasescu	745f319c7d	Merge branch 'master' into fix-realm-disposal-order	2021-10-15 15:44:14 +09:00
Dean Herbert	e018a6d6a5	Attempt bumping inspectcode to fix remaining inspection	2021-10-15 14:08:25 +09:00
Dan Balasescu	48a9ab9e89	Merge branch 'master' into fix-multiplayer-tests	2021-10-15 14:04:27 +09:00
Dean Herbert	e38eb31fd4	Merge branch 'fix-realm-disposal-order' into fix-realm-config-save-overhead	2021-10-15 14:00:31 +09:00
Dean Herbert	818fac6ac8	Make realm a non-drawable component to better order disposal ... Until now, the `RealmContextFactory` would be disposed as part of the drawable hierarchy. This is too early, as it may be being used by higher level components (like `ConfigManager`s, see #15115) that perform final operations after the drawables have been disposed. Seems to make sense moving this out of the drawable hierarchy and in line with how we were doing things with EF.	2021-10-15 13:58:16 +09:00
Dan Balasescu	1e15b5a5a0	Merge pull request #15113 from peppy/rounded-button-colour-provider ... Change `RoundedButton` to source from overlay colour provider	2021-10-15 13:52:52 +09:00
Dean Herbert	e47ccbd08a	Fix realm transactional overhead when rapidly changing RulesetConfigManager values	2021-10-15 13:50:26 +09:00
smoogipoo	80dfd11c90	Remove unnecessary extra task ... Further testing shows continuations also run before the .Wait() returns.	2021-10-15 13:28:02 +09:00
Dean Herbert	7ab028576e	Change RoundedButton to source from overlay colour provider	2021-10-15 12:54:19 +09:00
Dean Herbert	f73e505ee6	Further adjustments to glow to be less bright on settings overlay	2021-10-15 12:35:19 +09:00
Dean Herbert	e1ac5fbed9	Remove externally exposed Expanded state and change behaviour and visuals surrounding it	2021-10-15 12:13:42 +09:00
Dean Herbert	35d776078c	Ensure sliderbar nub stays glowing while dragging an adjustment	2021-10-15 11:51:08 +09:00
Dean Herbert	be3b88a5c3	Adjust glow to look good	2021-10-15 11:48:19 +09:00
Dean Herbert	3a25bdaf3d	Merge branch 'master' into slider-timeline-velcotiy-adjust-v2	2021-10-15 11:18:37 +09:00
Dean Herbert	874d722820	Merge branch 'master' into fix-editor-difficulty-name-update	2021-10-15 11:14:45 +09:00
Bartłomiej Dach	ed2f9dd443	Adjust settings slider spacings	2021-10-15 00:31:06 +02:00
Bartłomiej Dach	a10a7e7903	Refresh nub/slider appearance and use overlay theming	2021-10-15 00:31:05 +02:00
smoogipoo	eed8fa8d69	Expand comment a bit	2021-10-15 00:20:45 +09:00
smoogipoo	e6ee360511	Fix intermittent multiplayer tests	2021-10-15 00:10:39 +09:00
Dean Herbert	ad0732484f	Just wait for metadata section to be loaded	2021-10-14 22:12:38 +09:00
Dean Herbert	9d54285b2e	Merge branch 'master' into fix-multiplayer-sounds-during-gameplay	2021-10-14 21:34:04 +09:00
Dean Herbert	a31f5ca326	Update framework	2021-10-14 20:13:55 +09:00
Dean Herbert	06249c4ab2	Fix incorrect usages of Scheduler.AddOnce	2021-10-14 17:52:19 +09:00
Dean Herbert	0d86dab80a	Fix multiplayer components updating when not alive ... Should close https://github.com/ppy/osu/issues/15092. - [ ] Depends on https://github.com/ppy/osu-framework/pull/4826.	2021-10-14 17:37:10 +09:00
smoogipoo	901f107b2e	Merge branch 'master' into slider-timeline-velcotiy-adjust-v2	2021-10-14 17:25:51 +09:00
Dan Balasescu	fb9c3fe72e	Merge pull request #14619 from peppy/no-more-difficulty-control-points-info ... Move `DifficultyControlPoint`s to be specified at a per-`HitObject` level	2021-10-14 17:24:32 +09:00
Dean Herbert	1212b08672	Fix gameplay audio ramping down in frequency a second time at the end of the fail sequence	2021-10-14 16:45:34 +09:00
smoogipoo	2784ba1423	Add queueing modes	2021-10-14 16:34:23 +09:00
Dean Herbert	8a4c0c0ac8	Lock one more case of usage	2021-10-14 16:22:43 +09:00
Dean Herbert	060bb1afbd	Add locking around async beatmap (task) retrieval	2021-10-14 15:39:53 +09:00
Dean Herbert	4ed794e434	Throw and log instead of silently failing on type/instance creation failure	2021-10-14 14:24:36 +09:00
Dean Herbert	364fa068b3	Add non-null check to appease inspection	2021-10-14 14:20:34 +09:00
Dean Herbert	ccc8012fd4	Mark non-localisable strings	2021-10-14 14:16:39 +09:00
Dean Herbert	e0babe4b79	Add global logging of WorkingBeatmap changes	2021-10-14 14:07:43 +09:00
Dean Herbert	09536cd733	Add logging of WorkingBeatmapCache.Invalidate calls	2021-10-14 14:05:33 +09:00
Dean Herbert	b1fc870130	Adjust item selection and chevron animation slightly	2021-10-14 13:34:08 +09:00
Dean Herbert	bf1000000e	Merge branch 'master' into dropdown-refresh	2021-10-14 12:48:56 +09:00
smoogipoo	aa380a11c1	Merge branch 'master' into no-more-difficulty-control-points-info	2021-10-14 12:02:10 +09:00
Dean Herbert	8d479bbe56	Merge branch 'master' into fix-editor-difficulty-name-update	2021-10-14 10:17:01 +09:00
Bartłomiej Dach	c7db286b94	Merge branch 'master' into file-sanity-checks	2021-10-14 00:17:29 +02:00
Bartłomiej Dach	d2115824fa	Merge branch 'master' into dropdown-refresh	2021-10-13 23:53:14 +02:00
Bartłomiej Dach	d8450a7375	Recolour "slim dropdown" in online lounge screens	2021-10-13 22:57:37 +02:00
Bartłomiej Dach	f3647eb94e	Recolour room settings screens to match dropdown theming	2021-10-13 22:50:19 +02:00
Bartłomiej Dach	d067159435	Recolour elements of editor setup screen to match dropdown theming	2021-10-13 22:32:54 +02:00
Bartłomiej Dach	a6c2848460	Fix hovered dropdown item chevron not using OverlayColourProvider	2021-10-13 22:08:23 +02:00
Bartłomiej Dach	7e7b747755	Always use OverlayColourProvider in scroll containers if available	2021-10-13 22:05:48 +02:00
Bartłomiej Dach	d4e3460912	Always use OverlayColourProvider in dropdowns if available	2021-10-13 22:04:48 +02:00
Bartłomiej Dach	d205483a36	Revert ThemedDropdown-related changes	2021-10-13 21:57:50 +02:00
Dean Herbert	f7a5879fa6	Merge pull request #15056 from smoogipoo/fix-gamehost-tests ... Fix GameHosts being run on TPL threads	2021-10-13 23:06:26 +09:00
smoogipoo	fdf7142711	Remove Room.Position	2021-10-13 21:24:54 +09:00
Dan Balasescu	e49f1f6e6b	Merge branch 'master' into no-more-difficulty-control-points-info	2021-10-13 20:17:57 +09:00
Dean Herbert	2af1e6acc7	Update framework	2021-10-13 18:02:22 +09:00
Dan Balasescu	d88daf0cc2	Merge pull request #15073 from peppy/fix-player-loader-low-pass ... Improve `PlayerLoader` audio and visual transitions	2021-10-13 17:01:49 +09:00
Dean Herbert	93d7cdc509	Don't check whether the source realm was closed or not ... Based on what we now know, this is not required, as long as there is another realm context open on the same thread.	2021-10-13 15:50:06 +09:00
Dean Herbert	2fb5c85377	Merge branch 'master' into realm-ruleset-store	2021-10-13 15:25:18 +09:00
Dean Herbert	f5f0486e18	Merge branch 'master' into realm-live	2021-10-13 15:24:34 +09:00
Dean Herbert	29dfe33465	Rewrite AudioFilter to be easier to follow (and fix tests)	2021-10-13 15:17:20 +09:00
Dean Herbert	02689a1b60	Use actual BeatmapInfo rather than PlayableBeatmap.BeatmapInfo for editor writes	2021-10-13 14:50:12 +09:00
Dan Balasescu	3445d915b9	Merge pull request #15074 from peppy/fix-storyboard-fail-test-fails ... Fix storyboard outro during fail test not being lenient enough	2021-10-13 14:16:26 +09:00
Dan Balasescu	df5a76ad9d	Merge pull request #15041 from peppy/realm-file-store ... Add realm `FileStore`	2021-10-13 13:54:56 +09:00
Dean Herbert	26a1e40d24	Fix storyboard outro during fail test not being lenient enough	2021-10-13 13:48:57 +09:00
Dean Herbert	ae4dcbd829	Improve PlayerLoader audio and visual transitions	2021-10-13 13:26:20 +09:00
Dean Herbert	b37096f440	Avoid using bindable for AudioFilter cutoff ... It doesn't play nicely with screen exiting, as it is automatically unbound during the exit process. Easiest to just avoid using this for now.	2021-10-13 13:25:55 +09:00
smoogipoo	cf10239e70	Add a few nullabilities and DCC excludes	2021-10-13 12:51:46 +09:00
Dean Herbert	f69a56a26a	Add test coverage of startup import sequence	2021-10-13 12:19:10 +09:00
Dean Herbert	94de24075e	Ensure startup imports trigger notifications	2021-10-13 12:18:56 +09:00
Bartłomiej Dach	7c5bd2db7b	Allow using ThemedDropdown even if OverlayColourProvider not available ... This is to accommodate `SettingsDropdown` usages without an available `OverlayColourProvider`, such as mod settings controls and tournament client usages.	2021-10-12 23:12:16 +02:00
Bartłomiej Dach	7139c832b0	Add support for changing scrollbar accent colour & use in themed dropdown	2021-10-12 22:20:07 +02:00
Bartłomiej Dach	a2f3a7cba8	Add "themed" dropdown variant and use in settings sidebar	2021-10-12 21:58:43 +02:00
Bartłomiej Dach	1fba932e84	Adjust settings dropdown spacings	2021-10-12 21:41:33 +02:00
Bartłomiej Dach	5ddb7f74e2	Adjust default dropdown dimensions & spacings	2021-10-12 21:41:29 +02:00
Bartłomiej Dach	3ceee176e6	Merge branch 'master' into frame-stability-container-direction-flip	2021-10-12 18:34:04 +02:00
Dean Herbert	e468bfb31c	Merge branch 'master' into realm-file-store	2021-10-12 23:11:02 +09:00
Dan Balasescu	cabbb1697a	Merge pull request #15054 from peppy/settings-ordering ... Initial settings usability pass	2021-10-12 22:00:30 +09:00
Dan Balasescu	60ba1987ba	Merge pull request #15050 from peppy/fix-cross-thread-list-manipulation-skin-source-provider ... Fix cross-thread list manipulation in `SkinProvidingContainer`	2021-10-12 21:59:49 +09:00
Dan Balasescu	7bb401b974	Merge pull request #15040 from peppy/realm-test-game-host ... Update realm tests to run inside a `GameHost` to allow running on update thread	2021-10-12 21:16:06 +09:00
Dan Balasescu	f76b58e843	Merge pull request #15055 from peppy/fix-taiko-convert-woes ... Fix `BeatmapConverter` not cloning deeply enough	2021-10-12 21:07:39 +09:00
Dan Balasescu	f01e995cd9	Merge branch 'master' into fix-cross-thread-list-manipulation-skin-source-provider	2021-10-12 20:59:17 +09:00
Dean Herbert	427bf4ef0a	Merge branch 'master' into fix-audio-filter-test-failures	2021-10-12 19:42:18 +09:00
Dean Herbert	e6cd0a8371	Remove unused using statements	2021-10-12 17:17:40 +09:00
Dean Herbert	1373cc02d7	Shallow clone BeatmapInfo during conversion process to avoid overwriting fields	2021-10-12 16:43:56 +09:00
Bartłomiej Dach	b79cf0b58b	Add failing coverage for conversion not altering original beatmap	2021-10-12 16:43:56 +09:00
Dean Herbert	6fec821a17	Update framework	2021-10-12 16:20:13 +09:00
Dean Herbert	c66e50ac55	Remove temporary logging	2021-10-12 16:19:58 +09:00
Dean Herbert	76c64751de	Remove RealmBeatmap.Clone for the time being (incorrectly implemented)	2021-10-12 16:18:12 +09:00
Dean Herbert	0df9ab3eec	Fix migration blocking code running on the wrong thread	2021-10-12 16:04:09 +09:00
Dean Herbert	ce128476ae	Remove public setter of RealmFileStore.Storage	2021-10-12 15:46:32 +09:00
Dean Herbert	129416835f	Remove stray string.Empty specification ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-10-12 15:40:12 +09:00
Dean Herbert	24b87cf655	Change some icons to be more descriptive (still placeholder)	2021-10-12 15:09:59 +09:00
Dean Herbert	59202d27c7	Add some missing labels	2021-10-12 15:09:59 +09:00
Dean Herbert	5ca1d1d12c	Reorder graphics settings and move gameplay related pieces out	2021-10-12 15:09:59 +09:00
Dean Herbert	c4347de57e	Move ruleset settings to own section	2021-10-12 14:58:43 +09:00
Dean Herbert	8285f065c2	Reorganise gameplay settings into more sections	2021-10-12 14:58:43 +09:00
Dan Balasescu	8291d74b68	Merge pull request #15053 from peppy/remove-button-drop-shadow ... Remove drop shadow from `RoundedButton`	2021-10-12 14:04:41 +09:00
Dean Herbert	1d3d67c5f1	Move gameplay cursor settings to gameplay section	2021-10-12 13:56:10 +09:00
Dean Herbert	a986870a99	Reorder sections to be more in line with how often they are adjusted	2021-10-12 13:41:35 +09:00
Dean Herbert	e982f485c7	Remove drop shadow from RoundedButton ... As per @arflyte's spec, this should not have been there in the first place.	2021-10-12 13:17:49 +09:00
Dean Herbert	d7cbacc5a0	Rename OnSourceChanged and expand on xmldoc to mention that it doesn't fire SourceChanged	2021-10-12 13:04:48 +09:00
Dean Herbert	a849e7343e	Add lock to ensure no threading shenanigans	2021-10-12 13:04:24 +09:00
Dean Herbert	077dcf5cd9	Add missing documentation for SourceChanged	2021-10-12 12:50:28 +09:00
Dean Herbert	e058214346	Merge branch 'master' into fix-audio-filter-test-failures	2021-10-12 12:06:12 +09:00
Gagah Pangeran Rosfatiputra	81246a110c	add OpenChangelog in OsuGame.HandleLink	2021-10-12 09:57:47 +07:00
Gagah Pangeran Rosfatiputra	6c84cf6658	add ShowChangelogListing and ShowChangelogBuild	2021-10-12 09:57:47 +07:00
Gagah Pangeran Rosfatiputra	80722c7dc7	change changelogOverlay to field in OsuGame	2021-10-12 09:57:47 +07:00
Gagah Pangeran Rosfatiputra	47c7701e47	handle changelog link in message formatter	2021-10-12 09:57:47 +07:00
Dean Herbert	39a3482458	Replace Add/Reset methods with single Set method	2021-10-12 11:55:07 +09:00
Gagah Pangeran Rosfatiputra	e0c54e3207	add OpenChangelog link action	2021-10-12 09:37:11 +07:00
Dean Herbert	df83f0db08	Fix cross-thread list manipulation in SkinProvidingContainer	2021-10-12 11:28:11 +09:00
Dean Herbert	1550a3b470	Rethrow exception after logging to make tracking on CI easier	2021-10-12 11:11:55 +09:00
Dean Herbert	82f7f99f37	Refactor to use scoped using (and also correctly dispose TagLib portion)	2021-10-12 10:46:26 +09:00
Dan Balasescu	696193198a	Merge pull request #15049 from bdach/settings-panel-rounded-buttons ... Update appearance of buttons in settings sidebar	2021-10-12 09:32:52 +09:00
Naxesss	f2f97602f2	Dispose of video resource later ... We need the Stream to stay open here because `StreamFileAbstraction` uses it later in the block.	2021-10-12 00:40:39 +02:00
Naxesss	d4779f06cf	Rework CloseStream	2021-10-12 00:30:00 +02:00
Naxesss	47b4d03145	Dispose of Streams when used	2021-10-12 00:13:38 +02:00
Naxesss	ce69dd3588	Use Prescan flag for audio length check	2021-10-11 23:57:23 +02:00
Bartłomiej Dach	ff382259ca	Use rounded buttons in tablet rotation preset settings	2021-10-11 23:17:09 +02:00
Bartłomiej Dach	56eae703fe	Avoid changing frame stable clock direction if time hasn't changed between frames	2021-10-11 21:39:48 +02:00
Naxesss	8f093b9a11	Use TagLib instead of ManagedBass	2021-10-11 13:56:26 +02:00
Naxesss	f0cd18a721	Only check each video file once	2021-10-11 13:55:50 +02:00
Naxesss	6aa054b5fa	Change to non-BASS error template	2021-10-11 13:53:23 +02:00
Dean Herbert	22e90076fb	Add temporary logging	2021-10-11 18:05:45 +09:00
Joseph Madamba	e0557e849b	Join combinations with "/" instead	2021-10-11 01:11:41 -07:00
Joseph Madamba	4fc84e71cd	Localise more toast related strings	2021-10-11 01:02:26 -07:00
Dan Balasescu	7c21190b35	Merge branch 'master' into fix-audio-filter-test-failures	2021-10-11 16:43:17 +09:00
Dan Balasescu	c251a3016e	Merge pull request #15039 from peppy/manager-code-quality ... Fix a couple of code quality issues with new manager interface usage	2021-10-11 16:42:04 +09:00
Dean Herbert	484a95229e	Update toast implementations temporarily to expedite getting tests back in line	2021-10-11 16:36:04 +09:00
Dean Herbert	b4092549c0	Update framework	2021-10-11 16:35:36 +09:00
Dean Herbert	bae404f742	Update framework	2021-10-11 16:17:15 +09:00
Dean Herbert	68078bd5bd	Merge branch 'master' into localise-toasts	2021-10-11 16:17:10 +09:00
Dean Herbert	43aacb3831	Fix two different skins displaying at the same time when rapidly switching	2021-10-11 16:11:15 +09:00
Dean Herbert	0daa836ecc	Add realm RulesetStore ... Not yet used in game.	2021-10-11 15:57:33 +09:00
Dean Herbert	b01d82b3fd	Add RealmLive implementation	2021-10-11 15:36:41 +09:00
Dean Herbert	03bf88ae81	Add realm FileStore and test coverage	2021-10-11 15:26:16 +09:00
Dean Herbert	6ca415da9f	Add basic realm models ... Only the file related ones are really required outside of tests, but seems like as good an opportunity as ever to get the rest of the models into the game project.	2021-10-11 15:25:04 +09:00
Dean Herbert	f43badabf4	Add back update thread verification in RealmContextFactory	2021-10-11 15:20:12 +09:00
Dean Herbert	c7675be3ef	Fix typo in IModelImporter's xmldoc	2021-10-11 15:12:51 +09:00
Dean Herbert	6b35ccae95	Fix some cases where interface specifications can be used but weren't	2021-10-11 15:06:24 +09:00
Dean Herbert	3d6602b8df	Ensure FailAnimation is disposed synchronously to avoid test failures	2021-10-11 14:05:31 +09:00
Joseph Madamba	4b01c23c11	Track ui scale setting	2021-10-10 19:55:02 -07:00
Joseph Madamba	af9bb6f277	Fix padding of shortcut in toast when widest	2021-10-10 19:37:46 -07:00
Joseph Madamba	7b37b15976	Localise some music action toasts	2021-10-10 19:36:50 -07:00
Joseph Madamba	545cfc7bf1	Localise tracked setting toasts	2021-10-10 19:35:25 -07:00
Joseph Madamba	cce4a41c5d	Add "disabled" common string	2021-10-10 19:33:45 -07:00
Dean Herbert	a16ffd2976	Merge pull request #14999 from smoogipoo/fix-score-async ... Fix intermittent playlist results screen test failures	2021-10-11 10:44:04 +09:00
Dean Herbert	2eb29ed0de	Merge pull request #15021 from peppy/tournament-comma-separators ... Use comma separator for tournament score displays	2021-10-11 10:43:34 +09:00
Joehu	ce864011f2	Add ability to change ui scaling via keyboard	2021-10-10 13:13:26 -07:00
Bartłomiej Dach	b30dd2d4ed	Use rounded button in settings sidebar	2021-10-10 21:45:41 +02:00
Bartłomiej Dach	21ee24ea6d	Add rounded button variant	2021-10-10 21:45:41 +02:00
Dean Herbert	794b4c46cf	Split score counter class into two distinct classes to simplify usages	2021-10-10 17:56:32 +09:00
Dean Herbert	06cce0119c	Use localisable format string for comma separator mode	2021-10-10 17:41:16 +09:00
Dean Herbert	6d6de5b677	Remove redundant tuple naming	2021-10-10 16:50:55 +09:00
Dean Herbert	446f091d32	Use comma separator for tournament score displays	2021-10-10 16:06:12 +09:00
Dean Herbert	49a878dc20	Fix comma separator support not actually working	2021-10-10 16:06:05 +09:00
Dan Balasescu	8884091422	Merge pull request #15014 from joseph-ireland/remove-initial-strain ... Change initial strain value in skills from 1 to 0	2021-10-10 15:56:20 +09:00
smoogipoo	4475697a9c	Add score id key	2021-10-10 15:47:39 +09:00
smoogipoo	c49d0a5013	Rewrite query to be easier to understand	2021-10-10 15:43:24 +09:00
Dean Herbert	49b341daff	Remove HoverTarget shared state update path ... Felt quite convoluted to follow. Have just duplicated the single shared line instead.	2021-10-10 11:55:47 +09:00
Dean Herbert	ccc6d8ff40	Improve the animation of the active indicator	2021-10-10 11:34:01 +09:00
Bartłomiej Dach	fe26d8e8df	Share sidebar colouring logic by splitting out SidebarIconButton	2021-10-10 00:34:12 +02:00
Bartłomiej Dach	b8616bf910	Adjust appearance of keybinding subpanel	2021-10-10 00:34:12 +02:00
Bartłomiej Dach	855a74b8a0	Adjust vertical spacings in individual subsections	2021-10-10 00:34:11 +02:00
Bartłomiej Dach	e23a54f1e6	Adjust setting section appearance & spacings	2021-10-10 00:31:01 +02:00
Bartłomiej Dach	4c293b637f	Restyle settings panel header	2021-10-09 23:40:15 +02:00
Bartłomiej Dach	315581f4c8	Adjust horizontal spacing in settings panel	2021-10-09 23:40:15 +02:00
Bartłomiej Dach	f6df93f013	Introduce basic parts of colour scheme to settings sidebar	2021-10-09 23:40:14 +02:00
smoogipoo	bc37cb6f43	Merge branch 'master' into no-more-difficulty-control-points-info	2021-10-08 18:41:17 +09:00
Dan Balasescu	9be56829c9	Merge pull request #14935 from Susko3/fix-SettingsTextBox-using-null-as-default ... Fix usages of `SettingsTextBox` having `null` as the default	2021-10-08 18:36:02 +09:00
Dan Balasescu	67cfe3412e	Merge branch 'master' into random-seed-max-input-length	2021-10-08 15:38:42 +09:00
smoogipoo	b82ed3f167	Fix potential blocking operation on OrderByTotalScoreAsync() ... In reality this wouldn't be a long process, but the blocking is really noticeable if you add a Task.Delay(1000) in GetTotalScoreAsync().	2021-10-08 14:23:54 +09:00
Dean Herbert	9dc035757f	Fix weird textbox behaviour when entering a random mod seed overflowing int backing	2021-10-08 14:01:36 +09:00
Dean Herbert	2856aef4eb	Add exception to catch any incorrect defaults of Bindable<string>	2021-10-08 13:52:38 +09:00
Dean Herbert	436ead421a	Move low pass fail effect to FailAnimation	2021-10-08 12:27:04 +09:00
Dean Herbert	da96cc73d8	Fix dual specification of SuspensionHandler and move fields around slightly	2021-10-07 23:40:47 +09:00
Dean Herbert	9bf29503fb	Rename remaining usage	2021-10-07 20:57:14 +09:00
Dean Herbert	310d7965b6	Merge branch 'master' into more-filter-effects	2021-10-07 20:52:38 +09:00
Dan Balasescu	f8e50731b7	Merge pull request #14991 from peppy/intro-tests-no-menu-load ... Allow intro screens to be created without loading a `MainMenu`	2021-10-07 20:48:54 +09:00
Dean Herbert	ef64c64f0b	Merge branch 'master' into popup-filter-effect	2021-10-07 18:56:07 +09:00
Dean Herbert	e578046b20	Rename Filter -> AudioFilter	2021-10-07 18:50:08 +09:00
Dean Herbert	0348c6c7e5	Apply some renaming and code quality fixes	2021-10-07 18:49:22 +09:00
Dan Balasescu	bece807857	Merge pull request #14980 from peppy/difficulty-move-to-beatmap ... Copy `BaseDifficulty` to `Beatmap<T>` and move the majority of write operations across	2021-10-07 18:43:44 +09:00
Dean Herbert	f98dd1b811	Merge branch 'master' into popup-filter-effect	2021-10-07 18:40:21 +09:00
Jamie Taylor	f6458aa26d	Add filter effect to collection management dialog	2021-10-07 17:56:11 +09:00
Jamie Taylor	cc209f0f2d	Add filter effect to fail sequence	2021-10-07 17:55:30 +09:00
Jamie Taylor	5c48340520	Add filter effect to beatmap loading	2021-10-07 17:55:21 +09:00
Dean Herbert	ee66414e4f	Move difficulty copy inside context retrieval	2021-10-07 17:49:13 +09:00
Dan Balasescu	0e0779e45b	Merge pull request #14988 from peppy/remove-gameplay-mod-bindable-storage ... Remove local overridden storage of `Mods` in `Player`	2021-10-07 17:36:23 +09:00
Joseph Ireland	185bb9c122	change initial strain from 1 to 0 to allow simpler implementations	2021-10-07 09:30:18 +01:00
Dean Herbert	d3efec3c04	Remove unnecessary clone operations	2021-10-07 17:22:10 +09:00
Dean Herbert	7dd7d35fc8	Remove unnecessary difficulty copy operation	2021-10-07 17:19:34 +09:00
Dean Herbert	0df409c050	Move difficulty copy to BeatmapModelManager.Save	2021-10-07 17:16:45 +09:00
Dan Balasescu	d50443fdf2	Merge branch 'master' into difficulty-move-to-beatmap	2021-10-07 16:50:10 +09:00
Dean Herbert	d0001f760d	Group applicable comment above new addition	2021-10-07 16:50:05 +09:00
Dean Herbert	f88d898960	Allow intro screens to be created without loading a MainMenu	2021-10-07 16:38:22 +09:00
Dean Herbert	290c9755e2	Always use circles intro for OsuGame tests ... The triangles intro tracks video time, which is not adjusted based on the game's playback rate (ie. it runs in realtime even for headless tests). Maybe we want to make the triangles video adjust its rate along with tests?	2021-10-07 15:55:29 +09:00
Dean Herbert	a57b080f10	Avoid showing the disclaimer in game tests ... No real performance gain, but this is handy to bypass when actually using one of these tests to test something.	2021-10-07 15:55:15 +09:00
Dean Herbert	5f129ae33c	Remove local overridden storage of Mods in Player ... Not required and only causing headaches. Accessing mods should now be done via `GameplayState`. Closes #14912.	2021-10-07 14:53:39 +09:00
Dean Herbert	9705c7b546	Use cloned mods in one more place	2021-10-06 21:30:30 +09:00
Dean Herbert	433e7cd403	Fix rate mods not working if pp counter is displayed	2021-10-06 21:26:30 +09:00
Jamie Taylor	99fb86878e	Only detach filter on disposal if attached	2021-10-06 18:31:56 +09:00
Jamie Taylor	bd0c986144	Add asserts to ensure correct state when attaching/detaching the filter	2021-10-06 17:34:24 +09:00
Dean Herbert	4ca97bc60a	Merge branch 'master' into difficulty-move-to-beatmap	2021-10-06 16:14:21 +09:00
Dean Herbert	3803f2f462	Fix leaderboard potentially displaying the wrong scores ... Closes #14762. This class is ugly. I think the whole process should be clened up once we have correctly-scheduled `SynchronizationContext`s. There's not much saving it as long as all these interdispersed `Schedule`s around required.	2021-10-06 16:07:29 +09:00
Dean Herbert	222997f2b9	Copy difficulty settings back out to BeatmapInfo on editor changes	2021-10-06 15:19:26 +09:00
Dean Herbert	0ab8dcc2a0	Fix taiko weird difficulty multiplier failing on double convert	2021-10-06 15:18:06 +09:00
Dean Herbert	b339c149d8	Copy BaseDifficulty to Beatmap<T> and move all write operations across	2021-10-06 15:10:45 +09:00
Dan Balasescu	e6aa05a4a4	Merge pull request #14978 from peppy/fix-editor-file-selector-textbox-drags ... Fix dragging on an editor file selection text box causing repeated popover display	2021-10-06 13:52:08 +09:00
Dan Balasescu	80c8612630	Merge pull request #14977 from peppy/fix-working-beatmap-cache-invalidation ... Fix changes not being reflected immediately after exiting the editor	2021-10-06 13:51:21 +09:00
Dean Herbert	d9849bcf49	Fix dragging on an editor file selection text box causing repeated popover display ... Local fix and no tests as this is a pretty weird usage of `TextBox`. We'll probably want to change it to not use a textbox eventually. Closes #14969.	2021-10-06 13:15:05 +09:00
Dean Herbert	90fdaf18c0	Fix PushAndConfirm potentially failing if new screen quickly pushes a child screen	2021-10-06 12:55:04 +09:00
Dean Herbert	8ffaa491e7	Fix BeatmapModelManager not receiving WorkingBeatmapCache	2021-10-06 12:55:04 +09:00
Dean Herbert	007b33cd88	Add missing methods to interfaces	2021-10-06 12:55:04 +09:00
Dean Herbert	ffbb7a9b1a	Remove incorrect csproj change ... Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2021-10-06 12:22:32 +09:00
Dan Balasescu	e837a3511d	Merge branch 'master' into beatmap-difficulty-more-interface-usage	2021-10-06 12:18:51 +09:00
Jamie Taylor	266e62794e	Tweak cutoff effect for new Q value	2021-10-06 11:52:05 +09:00
Dan Balasescu	4bbff2ebf7	Merge branch 'master' into new-interfaces	2021-10-06 11:38:17 +09:00
Jamie Taylor	df182ba92b	Set fQ to recommended value from BASS developer to prevent filter calculations from overflowing when approaching nyquist	2021-10-06 11:29:03 +09:00
Dan Balasescu	9491e5a547	Merge pull request #14954 from peppy/rename-result-response ... Rename `APIRequest.Result` to `Response`	2021-10-06 10:52:33 +09:00
Dan Balasescu	007e5f174c	Merge pull request #14959 from peppy/add-screen-test-debug ... Add various logging output in an atttempt to figure multiplayer test failure	2021-10-06 10:11:50 +09:00
Dean Herbert	4f59fc15a5	Mark BeatmapSet as nullable for the time being	2021-10-06 05:54:37 +09:00
Dean Herbert	4d5696959b	Remove unnecessary access modifier in interface ... Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2021-10-06 05:52:28 +09:00
Dean Herbert	1f6a31355c	Remove unused using statement ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-10-06 05:30:49 +09:00
Dean Herbert	5a4474e1b2	Fix incorrect DI retrieval in ReplayDownloadButton	2021-10-06 05:29:00 +09:00
Dean Herbert	c23acb8f05	Merge pull request #14967 from bdach/fix-accidental-json-property-rename ... Fix "most played beatmap" request breakage after property rename	2021-10-06 05:00:12 +09:00
Bartłomiej Dach	baa8baaa1e	Fix "most played beatmap" request breakage after property rename	2021-10-05 21:17:19 +02:00
Bartłomiej Dach	a5b07ce4fe	Fix backwards containment check in chat channel load callback	2021-10-05 20:53:06 +02:00
Bartłomiej Dach	12da27cde7	Add test coverage for loading process on channel join	2021-10-05 20:52:40 +02:00
Dean Herbert	6f7b8293af	Merge pull request #14919 from smoogipoo/realtime-pp-display ... Implement real-time PP counter	2021-10-05 20:50:03 +09:00
Dean Herbert	98fef6ece2	Handle judgement reverts with actual display updates	2021-10-05 19:08:30 +09:00
Dean Herbert	5c62d3b6cb	Merge pull request #14907 from peppy/remove-local-realm-thread-switch-handling ... Remove local handling of realm when switching thread modes	2021-10-05 19:00:19 +09:00
Dean Herbert	e6efdae7c9	Add various logging output in an atttempt to figure multiplayer test failure	2021-10-05 18:53:20 +09:00
Dean Herbert	bd84a8b749	Merge branch 'new-interfaces' into beatmap-difficulty-more-interface-usage	2021-10-05 18:21:21 +09:00
Dean Herbert	2be44188ef	Add missing null checks	2021-10-05 17:59:38 +09:00
Dean Herbert	0859c336de	Also dim counter during initial calculation phase	2021-10-05 17:24:36 +09:00
Dean Herbert	1e4da81120	Fix import notifications not showing correct text	2021-10-05 17:14:09 +09:00
Dean Herbert	f64226ded6	Fix display not displaying correctly after initial load	2021-10-05 17:10:32 +09:00
Dean Herbert	599d82e383	Avoid returning a live IEnumerable	2021-10-05 17:01:07 +09:00
Dean Herbert	fa7f11d906	Add easing to rolling counter value	2021-10-05 16:51:49 +09:00
Dean Herbert	565e888f58	Tidy up attribute retrieval code	2021-10-05 16:40:07 +09:00
smoogipoo	45b63cbad9	Remove unnecessary dependency	2021-10-05 16:03:25 +09:00
Dean Herbert	676df55a0e	Fade display out during rewind (as the value displayed is no longer valid)	2021-10-05 15:39:29 +09:00
Dean Herbert	81a13566bc	Adjust default location slightly, fix alignment of "pp" subtext	2021-10-05 15:28:03 +09:00
Dean Herbert	b6af93d434	Apply some code quality refactoring	2021-10-05 15:14:49 +09:00
Dean Herbert	7176dc95e5	Revert Player.Score to protected	2021-10-05 14:55:40 +09:00
Dean Herbert	e19be8ebe4	Make GameplayState.Score immutable	2021-10-05 14:55:40 +09:00
Dean Herbert	a5aa32811a	Remove null check suppression and add non-null fallback	2021-10-05 14:49:59 +09:00
Dean Herbert	d3b9660148	Move common interface implementations to extension methods	2021-10-05 14:41:14 +09:00
Dean Herbert	b41fa41c85	Rename APIRequest.Result to Response	2021-10-05 14:28:56 +09:00
smoogipoo	5624dd9af6	Fix incorrect CancellationToken usage ... Apparently I wrote the BDL system and don't know how this works. I believe you need `CancellationToken?` or CanBeNull=true, however that doesn't actually play well when actually using the token in code...	2021-10-05 12:07:41 +09:00
smoogipoo	593da79bbc	Further asyncify load process	2021-10-05 11:26:13 +09:00
smoogipoo	d120678e30	Fix redundant default value	2021-10-04 21:13:14 +09:00
smoogipoo	d1e7191f94	Pass score into GameplayState	2021-10-04 20:59:51 +09:00
smoogipoo	0b0316e27e	Fix missing CanBeNull	2021-10-04 20:59:31 +09:00
Dean Herbert	57c5be39d3	Merge branch 'master' into remove-local-realm-thread-switch-handling	2021-10-04 20:52:44 +09:00
Dean Herbert	1d99bc280f	Merge branch 'master' into new-interfaces	2021-10-04 20:42:40 +09:00
smoogipoo	1837e1bf3c	Share rounding with PerformanceStatistic	2021-10-04 20:35:53 +09:00
smoogipoo	fb63e5ed87	Add todo	2021-10-04 20:35:26 +09:00
smoogipoo	221cc1747c	Drop "default" prefix	2021-10-04 20:34:28 +09:00
smoogipoo	5aae673240	Use GameplayState	2021-10-04 20:33:54 +09:00
smoogipoo	2e3450b3f5	Make Mods readonly	2021-10-04 20:20:24 +09:00
smoogipoo	031c5a441e	Merge branch 'master' into realtime-pp-display	2021-10-04 20:19:37 +09:00
Dan Balasescu	4bd1083388	Merge pull request #14903 from peppy/importer-returns-live ... Add `ILive<T>` and use as return type of `Import` methods	2021-10-04 20:16:32 +09:00
smoogipoo	4871db2f86	Merge branch 'master' into importer-returns-live	2021-10-04 19:42:36 +09:00
Dean Herbert	853cf6feaa	Rename last remaining BeatmapInfo Beatmap usage	2021-10-04 17:35:53 +09:00
Dan Balasescu	5937a93e2d	Merge pull request #14949 from peppy/login-error-display ... Show login failure messages on login form	2021-10-04 17:23:11 +09:00
Dan Balasescu	c1540c137a	Merge pull request #14932 from peppy/rename-beatmap-info-beatmap-fields ... Rename `BeatmapInfo` variables which were named `beatmap` for clarity	2021-10-04 17:22:06 +09:00
Dean Herbert	6ac0601d2c	Fix incorrect csproj merge	2021-10-04 17:18:08 +09:00
Dean Herbert	ae5d1e8ac0	Merge branch 'master' into remove-local-realm-thread-switch-handling	2021-10-04 17:17:10 +09:00
Dean Herbert	95f1cc85d4	Update framework	2021-10-04 17:12:40 +09:00
Dean Herbert	f293e008d9	Move BeatmapInfo's SearchableTerms implementation to interface	2021-10-04 17:01:02 +09:00
Dean Herbert	51b7dce16f	Remove reference to osu-web-10	2021-10-04 16:55:51 +09:00
Dean Herbert	fd6b10656c	Add TODO reminder about ruleset reference transfer quirk	2021-10-04 16:55:16 +09:00
Dean Herbert	4df5f93152	Inline single usage of StoryboardFile to avoid interface default method woes	2021-10-04 16:55:02 +09:00
Dean Herbert	8bfdfe3672	Add literal string marker ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-10-04 16:54:00 +09:00
Dean Herbert	63f0b0c932	Rename out of place interface name	2021-10-04 16:35:55 +09:00
Dean Herbert	e631653f4b	Remove incorrectly committed FodyWeavers file	2021-10-04 16:30:12 +09:00
Dean Herbert	857000b756	Mark IPresentImports as covariant	2021-10-04 16:29:46 +09:00
Dean Herbert	3c15ef720f	Remove setter from IHasGuidPrimaryKey interface	2021-10-04 16:26:28 +09:00
Dean Herbert	916342c837	Merge branch 'master' into importer-returns-live	2021-10-04 16:24:26 +09:00
Dan Balasescu	aca2f0c12d	Merge pull request #14901 from peppy/model-importer-split ... Split importer interface out of `IModelManager`	2021-10-04 16:22:29 +09:00
Dean Herbert	3a0b7ba8ff	Add fallback to use Message when Hint is not available	2021-10-04 16:18:55 +09:00
smoogipoo	69c2b7dc59	Merge branch 'master' into rename-beatmap-info-beatmap-fields	2021-10-04 16:03:22 +09:00
Dan Balasescu	fd002da469	Merge pull request #14948 from peppy/fix-drawable-channel-ci-failures ... Ensure a `DrawableChannel` is not attempted to be added after disposal	2021-10-04 16:03:13 +09:00
smoogipoo	4e1322effa	Fix typo	2021-10-04 16:02:45 +09:00
Dan Balasescu	aa1bfc16d2	Merge pull request #14929 from peppy/gameplay-state ... Replace `GameplayBeatmap` with `GameplayState`	2021-10-04 15:56:44 +09:00
Dan Balasescu	d82829fad3	Merge pull request #14909 from peppy/realm-context-factory-safer-blocking ... Ensure realm blocks until all threaded usages are completed	2021-10-04 15:52:45 +09:00
Dean Herbert	266b4c7124	Expose login errors from IAPIProvider and show on the login form	2021-10-04 15:40:24 +09:00
Dean Herbert	5aaafce597	Make AuthenticateWithLogin throw instead of return a bool success status	2021-10-04 15:40:00 +09:00
smoogipoo	bc984dff4f	Fix typo	2021-10-04 15:35:28 +09:00
Dean Herbert	c19c2335ec	Remove added schedule due to changing flow	2021-10-04 14:58:54 +09:00
Dean Herbert	c6aba3e78b	Ensure a DrawableChannel is not attempted to be added after disposal	2021-10-04 14:44:16 +09:00