39360 Commits

Author	SHA1	Message	Date
Bartłomiej Dach	b3ce7f7b43	Merge branch 'master' into fix-section-container-scroll-attempt-2	2023-06-08 09:19:26 +02:00
Salman Ahmed	d523785bfc	Fix LanguageSettings requiring OsuGame as dependency	2023-06-08 03:27:23 +03:00
Salman Ahmed	251f23b2c2	Handle culture code differences of Traditional Chinese	2023-06-08 03:27:05 +03:00
Salman Ahmed	9f842ccdc0	Supply Accept-Language header in API requests	2023-06-08 02:59:34 +03:00
Salman Ahmed	ab790ec96a	Expose currently selected language from IAPIProvider	2023-06-08 02:59:34 +03:00
Salman Ahmed	1a90f71540	Centralise game language update logic	2023-06-08 02:59:34 +03:00
Bartłomiej Dach	f416b3a226	Fix new localisations using lookup keys of existing ones	2023-06-07 23:43:21 +02:00
Bartłomiej Dach	3c8f387a6c	Remove unused method	2023-06-07 23:38:06 +02:00
Bartłomiej Dach	d9281ac8c7	Remove unused virtual spec	2023-06-07 23:38:06 +02:00
Bartłomiej Dach	9b665d2e1a	Merge branch 'master' into beat-snap-divisor-hotkeys	2023-06-07 23:38:03 +02:00
Dean Herbert	3a01498789	Use existing next/previous methods (and remove looping behaviour)	2023-06-08 01:01:29 +09:00
Bartłomiej Dach	1f4e79d79d	Merge pull request #23711 from timiimit/add-last-edit-time ... Store timestamp of beatmap's last edit time in local database	2023-06-07 16:57:24 +02:00
Dean Herbert	15725fb186	Change default bindings to account for mouse wheel rotation	2023-06-07 18:07:56 +09:00
Dean Herbert	2c89af608a	Add ability to cycle beat snap divisor using hotkeys ... Defaults to Ctrl+Shift+Wheel (as per stable). Closes #23785.	2023-06-07 17:15:15 +09:00
Dean Herbert	67e952150f	Fix scroll operations in SectionsContainer failing if target moves due to loaded content	2023-06-07 16:32:29 +09:00
Dean Herbert	7d49f5d7c6	Apply NRT to SectionsContainer	2023-06-07 16:32:29 +09:00
Salman Ahmed	f23ada1a3f	Merge branch 'master' into disable-in-game-chat-reports	2023-06-07 09:52:46 +03:00
Salman Ahmed	62cb6a98ca	Remove redundant nullable suppression directives	2023-06-07 08:20:41 +03:00
Dean Herbert	30f17d5869	Disabling reporting users from in-game chat ... Addresses #23684. Safer alternative to #23698.	2023-06-07 14:03:06 +09:00
Dean Herbert	247ac3a5fd	Merge pull request #23781 from bdach/fix-progress-bar-blink ... Fix triangles song progress bar blinking during gameplay	2023-06-07 13:44:43 +09:00
Bartłomiej Dach	92c2320689	Merge pull request #23776 from peppy/fix-scroll-time-decimal ... Fix osu!mania scroll speed milliseconds having too much precision	2023-06-06 22:34:08 +02:00
Bartłomiej Dach	244e6cc008	Merge pull request #23767 from peppy/fix-playfield-border-animation-in-editor ... Fix gameplay playfield border being affected by beatmap track time	2023-06-06 22:10:18 +02:00
Bartłomiej Dach	be59eb1116	Fix triangles song progress bar blinking during gameplay ... Closes #23760.	2023-06-06 18:36:25 +02:00
Dean Herbert	247fa088db	Add IHasNoTimedInputs interface to scope change further	2023-06-06 22:22:42 +09:00
Dean Herbert	d1300f75c0	Merge branch 'master' into no-offset-calibration-with-relax	2023-06-06 22:22:08 +09:00
Dean Herbert	e0e013cca1	Fix incorrect realm schema comment ... Co-authored-by: timiimit <32331609+timiimit@users.noreply.github.com>	2023-06-06 22:17:05 +09:00
Cootz	ba7069df34	Fix SelectAllModsButton state doesn’t update when search term changed	2023-06-06 16:12:31 +03:00
Dean Herbert	6b18f2f2bb	Fix osu!mania scroll speed milliseconds having too much precision ... Closes #23750.	2023-06-06 21:43:56 +09:00
Dan Balasescu	77c745cc94	"TotalScoreV1" -> "LegacyTotalScore"	2023-06-06 17:25:28 +09:00
Dean Herbert	c0016fa5d2	Fix gameplay playfield border being affected by beatmap track time ... Closes https://github.com/ppy/osu/issues/23470.	2023-06-06 16:08:24 +09:00
Dean Herbert	b8d9c9ff93	Move ApplyGameWideClock to extension method ... I don't see an issue with applying this workaround to more places, even though it is a workaround, because it marks each usage very clearly. If we design a better solution in the future it should be easy to replace the usages.	2023-06-06 16:07:50 +09:00
Dean Herbert	878cdb2ed3	Bump schema version	2023-06-06 15:11:37 +09:00
Dean Herbert	22f7fe1d79	Rename variable and ensure timestamp is updated even when not saving	2023-06-06 15:11:31 +09:00
Dean Herbert	3a50e0fb2f	Merge branch 'master' into add-last-edit-time	2023-06-06 15:07:20 +09:00
Dean Herbert	0c7ab8f971	Merge branch 'master' into hud/argon-kc-animations-poc	2023-06-06 14:43:08 +09:00
Dean Herbert	2f11bd5473	Adjust animations slightly	2023-06-06 14:42:42 +09:00
Dean Herbert	a0b3fd27a7	Merge pull request #23729 from jtbiddle/language-list-update ... Update languages to match osu-web	2023-06-06 14:31:38 +09:00
Dean Herbert	c54670aee1	Add comment explaining implementation	2023-06-06 13:30:56 +09:00
tsrk	6fc6729677	feat: integrate attachment flow in SkinComponentsContainer	2023-06-06 00:27:43 +02:00
tsrk	4c397085c5	refactor: improve attachement flow ... This removes the hard reliance on individual classes and makes its usage easiser to ingreate anywhere else.	2023-06-06 00:12:53 +02:00
tsrk	41b7eacc72	Merge branch 'master' into hud/argon-kc-animations-poc	2023-06-05 15:22:20 +02:00
Cootz	71e6f80c40	Add hotkey for switching search bar focus	2023-06-05 15:54:19 +03:00
Cootz	3ebc801484	Move (de)select all mods hotkeys handling to ModSelectOverlay	2023-06-05 13:49:07 +03:00
Joseph Madamba	4eb0f0261c	Fix song select beatmap panels not displaying correct background shown in web	2023-06-04 22:54:15 -07:00
Bartłomiej Dach	25d0f0f3da	Merge pull request #23741 from peppy/fix-manage-collection-commit-on-focus-loss ... Fix collection name changes not being reflected if enter is not pressed	2023-06-04 17:19:13 +02:00
Cootz	a46f5b90d4	Move focus handling into PopIn	2023-06-04 18:11:44 +03:00
Cootz	32b9e6ec8f	Make search bar active by default	2023-06-04 17:02:46 +03:00
Dean Herbert	eb7586b517	Ensure collection edit textbox commits on focus loss ... As discussed in https://github.com/ppy/osu/discussions/23739	2023-06-04 12:51:03 +09:00
Bartłomiej Dach	4f5dfecbb8	Comment out Filipino due to satellite assembly copy failure	2023-06-03 23:55:05 +02:00
Bartłomiej Dach	14309ba951	Comment out Tajik due to lack of support on Windows ^<10	2023-06-03 23:42:08 +02:00
Bartłomiej Dach	a8a4c02bb3	Comment out languages with no glyph support	2023-06-03 21:48:03 +02:00
Bartłomiej Dach	a8b102ef72	Remove duplicated zh_tw language ... `zh_hant` already covers it.	2023-06-03 21:32:12 +02:00
Bartłomiej Dach	331e90f720	Merge branch 'master' into tidy-results-grid-usage	2023-06-03 19:45:23 +02:00
Bartłomiej Dach	602d5db3bb	Simplify column dimensions code ... `dimensions` would always receive exactly one item, so might as well inline it. And yes, at this point the grid container is mostly a glorified `FillFlowContainer { Direction = FlowDirection.Vertical }`, but I am not touching that in this pull pending further decisions with respect to direction.	2023-06-03 19:40:01 +02:00
Bartłomiej Dach	474f7c2bc0	Fix code quality inspection	2023-06-03 16:50:58 +02:00
Bartłomiej Dach	a9d4556647	Merge branch 'master' into update-multiplayer-room-diff-range	2023-06-03 16:50:09 +02:00
Bartłomiej Dach	0b841eda71	Merge pull request #23719 from peppy/disable-tablet-support-on-error ... Automatically disable tablet support on error	2023-06-03 12:25:06 +02:00
Cootz	69b640a185	Remove hotkeys handling from DeselectAllModsButton	2023-06-03 10:47:48 +03:00
Dean Herbert	8063d50369	Merge pull request #23730 from smoogipoo/reduce-legacy-diffcalc-mod-init ... Fix legacy mod difficulty calculation creating all mods unnecessarily	2023-06-02 22:22:19 +09:00
Dan Balasescu	e402c6d2b4	Write max combo attribute from base class	2023-06-02 21:53:25 +09:00
Cootz	9d4ba5d64a	Remove unnecessary null checks	2023-06-02 12:00:03 +03:00
Dan Balasescu	bfe80fe143	Fix legacy diffcalc creating all mods unnecessarily	2023-06-02 17:37:43 +09:00
Dan Balasescu	02111e3854	Implement ScoreV1 calculation for OsuRuleset	2023-06-02 17:36:45 +09:00
Cootz	4c7cca101e	Rename IsValid to Visible	2023-06-02 11:33:38 +03:00
Cootz	d400387329	Replace IConditionalFilterable with IFilterable	2023-06-02 10:51:33 +03:00
Cootz	325c114c1c	Remove redundant xmldocs	2023-06-02 10:39:27 +03:00
John Biddle	a44b208323	Updated languages in Language.cs to match what is in osu-web/resources/lang/. Added Catalan, Persian, Filipino, Hebrew, Croatian, Lithuanian, Latvian, Malay, Slovenian, Serbian, Tajik, and Sinhala.	2023-06-01 21:25:49 -07:00
Dean Herbert	c33ddedca0	Disable all tablet handlers to guard against a grim future	2023-06-02 08:48:47 +09:00
Bartłomiej Dach	f8289927d2	Merge pull request #23720 from peppy/fix-mouse-disappear-screenshot-fail ... Fix mouse cursor potentially disappearing for good if screenshot capture fails	2023-06-01 23:09:23 +02:00
Bartłomiej Dach	8433813677	Merge branch 'master' into editor-timeline-fix	2023-06-01 21:18:08 +02:00
Bartłomiej Dach	c2d89a32a9	Adjust inline comment	2023-06-01 21:18:00 +02:00
Andrei Zavatski	03eb7c7830	Fix nullability	2023-06-01 21:21:01 +03:00
Andrei Zavatski	949fe32740	Use combined area of children as a mask instead	2023-06-01 15:32:17 +03:00
Cootz	39489358fa	Apply appearance animation to aboveColumnsContent	2023-06-01 14:07:05 +03:00
Dean Herbert	00bf79d51f	Merge pull request #23691 from smoogipoo/mania-scroll-speed ... Replace mania scroll "time" with scroll "speed"	2023-06-01 17:23:27 +09:00
Dean Herbert	32207d4112	Remember the last used custom divisor when cycling divisor types	2023-06-01 17:11:49 +09:00
Dean Herbert	bcde2cbc73	Apply NRT to BeatDivisorControl	2023-06-01 16:58:14 +09:00
Dean Herbert	f52ed41f10	Use better defaults of 1/4 and 1/6 when cycling types	2023-06-01 16:28:03 +09:00
Dean Herbert	289f0e9862	Use FireAndForget to avoid unobserved exception	2023-06-01 15:50:37 +09:00
Dean Herbert	0a7d5a51d4	Fix mouse cursor potentially disappearing for good if screenshot capture fails	2023-06-01 15:50:13 +09:00
Dean Herbert	9f8a13480b	Automatically disable tablet support on error ... Closes #23710.	2023-06-01 15:16:48 +09:00
Dean Herbert	985604fab5	Return StatisticItems rather than StatisticRows from ruleset ... There were no usages of more than one column being provided per row, so it seemed like unnecessarily complexity. I'm currently trying to reduce complexity so we can improve the layout of the results screen, which currently has up to three levels of nested `GridContainer`s. Of note, I can't add backwards compatibility because the method signature has not changed in `Ruleset` (only the return type). If we do want to keep compatibility with other rulesets, we could designate a new name for the updated method.	2023-06-01 14:35:15 +09:00
Dean Herbert	dc595b83f1	Remove unused Dimension specification from StatisticItem	2023-06-01 14:25:18 +09:00
Dean Herbert	55a3847036	Merge pull request #23708 from peppy/labelled-slider-visibility ... Adjust background colour used in `LabelledDrawable`s to allow visibility of some elements	2023-06-01 13:08:17 +09:00
Bartłomiej Dach	d78df0b084	Merge pull request #23695 from peppy/realm-startup-error-handling ... Adjust realm startup for added reliability	2023-05-31 22:46:58 +02:00
timiimit	a58426dab6	Use LastEditTime in Editor	2023-05-31 19:07:04 +02:00
timiimit	659fb80c16	Add BeatmapInfo.LastEditTime property	2023-05-31 19:06:41 +02:00
Cootz	5a1c3aeb7e	Fix SearchTerm set causing infinite loop	2023-05-31 19:36:42 +03:00
Cootz	6e00b21a32	Update framework version	2023-05-31 19:16:16 +03:00
Dean Herbert	7bc3b2072c	Update framework	2023-06-01 00:44:13 +09:00
Dean Herbert	20439e80f6	Adjust background colour used in LabelledDrawables to allow visibility of sliders	2023-05-31 23:24:21 +09:00
Dean Herbert	812def124f	Merge pull request #23661 from peppy/fix-multiplayer-present-crash ... Fix `OnResume` / `OnSuspending` potentially getting called before `OnEntering` on a sub screen	2023-05-31 19:43:30 +09:00
Dean Herbert	18eb15bfa5	Gracefully handle failures in cleaning up pending file deletions	2023-05-31 19:39:43 +09:00
Bartłomiej Dach	2e81cae201	Move comment to more correct place	2023-05-30 23:18:34 +02:00
Bartłomiej Dach	62d1774407	Apply same comment & reworded condition to suspend too	2023-05-30 21:54:56 +02:00
Andrei Zavatski	d119447a10	Fix editor timeline hitobjects popping in	2023-05-30 16:41:42 +03:00
Dean Herbert	741ee84ed6	Add comment and use full conditional similar to extension method ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-05-30 18:38:28 +09:00
John	ed850196d9	Reverted to applying the color change in OnUpdate, removed EnableComboColour flag from DrawableHitObject.cs	2023-05-30 01:43:08 -07:00
Dean Herbert	14a376c041	Merge branch 'master' into scorev2	2023-05-30 14:34:43 +09:00
Dean Herbert	4e0f40bee5	Split out multiplier retrieval into a function and use a default multiplier for all rulesets	2023-05-30 14:20:26 +09:00
Dean Herbert	e35623df22	Update to use new Filter method and remove silly ForcedSearchTerm	2023-05-30 13:40:59 +09:00
Dean Herbert	fd919879c3	Merge branch 'master' into acc-challenge	2023-05-30 13:24:34 +09:00
Dean Herbert	a0be526266	Adjust realm backup procedure to hard fail if running out of attempts ... Previously, if the backup procedure failed, startup would continue and the user's realm database may be deleted. I think in such a fail case I'd rather the game didn't startup so the user gets in touch (or reads the log files themselves) rather than potentially losing data.	2023-05-30 13:04:34 +09:00
Dean Herbert	79694897be	Ensure a potential exception from cleanupPendingDeletions doesn't mark realm corrupt ... The whole restructure here is to move the nested call out of the `try-catch`. I noticed this while looking at a corrupt database issue a user reported (https://github.com/ppy/osu/discussions/23694). It's not the first time we've seen a corrupt database error where the "corrupt" version works just fine on a second attempt. Maybe this isn't the issue and it's just a transitive file access violation but it definitely feels like this should be fixed regardless.	2023-05-30 13:00:17 +09:00
Dean Herbert	61d9b50993	Merge pull request #23640 from 17steen/make_pause_menu_translatable ... Make GameplayMenuOverlay translatable	2023-05-30 09:36:19 +09:00
Bartłomiej Dach	5604dfb758	Merge branch 'master' into acc-challenge	2023-05-29 22:33:57 +02:00
Bartłomiej Dach	314a0f80f3	Reword setting name & description	2023-05-29 22:12:37 +02:00
Bartłomiej Dach	36f60def6d	Merge pull request #23679 from cdwcgt/percentage-format-slider ... Format percentage based on significant decimal digits	2023-05-29 21:18:23 +02:00
Dan Balasescu	1c199b83e3	Replace mania scroll "time" with scroll "speed"	2023-05-29 21:22:23 +09:00
Cootz	22c6d6c526	Prevent checkbox from toggle on when column have no valid panels	2023-05-29 14:22:40 +03:00
Dean Herbert	b3ca409339	Rename a few remaining CountAccuracyJudgement variable	2023-05-29 20:08:22 +09:00
Dean Herbert	1558723420	Merge branch 'master' into scorev2	2023-05-29 20:06:32 +09:00
Dean Herbert	df662afbd5	Pass ScoreProcessorStatistics to FrameHeader, rather than the full processor	2023-05-29 20:00:42 +09:00
Dean Herbert	1a6d9e9ff0	Apply NRT to GameplayLeaderboardScore and change GetDisplayedScore handling ... I don't feel too confident with the default scoring function being assigned in the constructor to a publicly settable delegate. This just feels a bit more elegant, and handles the (likely-never-used) case where we need to restore the default function. An alternative would be to provide the function as a `ctor` argument, but I believe that wasn't done here to allow using the `ILeaderboardScore` interface.	2023-05-29 20:00:29 +09:00
Dean Herbert	fcd7a1d51a	Move GetDisplayScore xmldoc to interface and remove getter	2023-05-29 19:41:53 +09:00
Dean Herbert	9a886125ad	Ensure GameplayScoreCounter's display score is updated on ScoringMode change ... This isn't strictly required, but only because of a kind of hacky behaviour where `HUDOverlay` will recreate all components on a scoring mode change currently (see 8f6df5ea0f/osu.Game/Screens/Play/HUDOverlay.cs (L410-L418)). Best we do this just in case that happens to go away in the future.	2023-05-29 19:00:02 +09:00
Dean Herbert	22be045de3	Apply NRT to GameplayScoreCounter	2023-05-29 18:48:17 +09:00
Dean Herbert	a789d1e49c	Add xmldoc and change naming around ScoreProcessorStatistics a bit	2023-05-29 18:38:16 +09:00
Dean Herbert	b0501c4e5c	Actually use paused header	2023-05-29 10:24:59 +09:00
Dean Herbert	f5b258a044	Merge branch 'master' into make_pause_menu_translatable	2023-05-29 01:16:52 +09:00
Cootz	e43c233b48	Reword ForcedSearchTerm xmldoc	2023-05-28 13:21:41 +03:00
Cootz	0e5c99b760	Fix search bar showing incorrectly	2023-05-28 13:12:57 +03:00
Cootz	5ff023113f	Update xmldoc for ForcedSearchTerm	2023-05-28 10:04:26 +03:00
cdwcgt	333e785f8b	Revert "Provides higher precision settings" ... This reverts commit ec61840e7d. 😐	2023-05-28 09:50:11 +09:00
Bartłomiej Dach	ba5f76fcc8	Merge pull request #23667 from peppy/fix-taiko-editor-placement-before-first-control-poiunt ... Fix placing objects before the first control point in the osu!taiko editor failing	2023-05-27 17:58:28 +02:00
cdwcgt	a05312c9a2	simplify format method ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-05-27 23:44:50 +09:00
cdwcgt	89c8ef3c9b	Format percentage based on significant decimal digits	2023-05-27 23:35:59 +09:00
cdwcgt	ec61840e7d	Provides higher precision settings	2023-05-27 23:25:01 +09:00
cdwcgt	318431a1b7	make MaximumAchievable to default	2023-05-27 21:27:32 +09:00
Robin Oger	cfa1280028	GameplayMenuOverlay.cs: add translatable strings for Retry count: and Song progress: ... This makes the assumption that languages will prefer having the number on the right	2023-05-27 12:47:05 +02:00
Robin Oger	a01577cba5	Adapt changes to fit master	2023-05-27 12:29:14 +02:00
Robin Oger	d5bfbe2b89	Merge branch 'master' into make_pause_menu_translatable ... # Conflicts: # osu.Game/Screens/Play/FailOverlay.cs # osu.Game/Screens/Play/GameplayMenuOverlay.cs # osu.Game/Screens/Play/PauseOverlay.cs	2023-05-27 12:22:50 +02:00
Bartłomiej Dach	53c91349fe	Merge branch 'master' into slider-control-point-no-distance-snap	2023-05-26 19:52:54 +02:00
Bartłomiej Dach	574ecf939c	Merge pull request #23647 from peppy/pause-screen-progress ... Show current progress on pause screen	2023-05-26 19:36:30 +02:00
Dean Herbert	725734bc03	Merge pull request #23649 from peppy/keep-selection-buttons-on-screen ... Ensure editor selection buttons remain on screen when selection is near edge	2023-05-26 20:51:45 +09:00
Dean Herbert	6b0e215246	Add (int) flooring and handle potential NaN value	2023-05-26 20:44:13 +09:00
Dean Herbert	cb468fa4ec	Fix OverlappingScrollAlgorithm returning incorrect results for TimeAt before first control point	2023-05-26 19:59:19 +09:00
Bartłomiej Dach	96fe7cbe54	Merge branch 'master' into sample-set-controls	2023-05-25 21:58:16 +02:00
Bartłomiej Dach	7d8f08c0ea	Fix ComposeBlueprintContainer briefly assigning auto bank ... Seems to have had no consequence due to the way `AutomaticBankAssignment` works (that flag is checked in `PlacementBlueprint.UpdateTimeAndPosition()`, which runs essentially every frame), but let's avoid putting it there at all ever.	2023-05-25 21:49:29 +02:00
Bartłomiej Dach	adee624a8f	Change PlacementBlueprint.AutomaticBankAssignment to property ... Mostly for consistency.	2023-05-25 21:32:21 +02:00
Bartłomiej Dach	b9be886ae1	Merge branch 'master' into pause-screen-progress	2023-05-25 20:34:11 +02:00
Bartłomiej Dach	6425a33b45	Merge branch 'master' into beatmap-length-calcualtions	2023-05-25 17:44:15 +02:00
Bartłomiej Dach	78f41f7109	Fix spelling	2023-05-25 17:33:41 +02:00
Bartłomiej Dach	b59f4aee99	Merge pull request #23660 from peppy/simplify-deselect ... Fix crash when deleting dragged object in skin editor	2023-05-25 17:27:41 +02:00
Bartłomiej Dach	3ad5f8b9c9	Polish a few extreme edge cases	2023-05-25 16:39:54 +02:00
Dean Herbert	949de35664	Ensure selection is reset after immediately deleting objects ... Closes https://github.com/ppy/osu/issues/23518.	2023-05-25 23:20:32 +09:00
Bartłomiej Dach	beeca5a8dd	Use alternative layouting implementation	2023-05-25 16:17:44 +02:00
Dean Herbert	804671ca74	Split out grid snapping modes into "relative" and "global" types	2023-05-25 21:41:19 +09:00
Dean Herbert	b3c2d120bf	Fix OnResume / OnSuspending potentially getting called before OnEntering on a sub screen	2023-05-25 20:39:11 +09:00
Dean Herbert	7a5349d747	Remove constructor from MultiplayerPlaylistItem which is only used in tests	2023-05-25 20:09:40 +09:00
Dean Herbert	a6a380dd41	Merge branch 'master' into organize-room-pills	2023-05-25 19:57:28 +09:00
Dean Herbert	609c7227ee	Fix changes to font weight in a couple of combined implementations	2023-05-25 19:55:11 +09:00
Dean Herbert	57c63dbb29	Add xmldoc for GetDisplayScore	2023-05-25 19:24:15 +09:00
Dean Herbert	1049257b56	Simplify SelectionHandler's DeselectAll implementation ... We are already doing other operations in this class directly on `SelectedItems`, so might as well change this one to match	2023-05-25 18:46:31 +09:00
Dean Herbert	1e14b02493	Fix bindable feedback loop	2023-05-25 17:58:38 +09:00
Dean Herbert	37c6e632d0	Switch to using new extension method for length calculations	2023-05-25 17:38:35 +09:00
Dean Herbert	cf9fda0cf2	Merge branch 'beatmap-length-calcualtions' into pause-screen-progress	2023-05-25 17:34:08 +09:00
Dean Herbert	058edb5d5f	Centralise beatmap playable duration and bounds lookups	2023-05-25 17:32:48 +09:00
Bartłomiej Dach	578a0e7494	Merge branch 'master' into beat-divisor-visual-improvements	2023-05-24 22:28:26 +02:00
Bartłomiej Dach	6ec4ecfdd7	Mention fallback default in GetDivisorForBeatIndex()	2023-05-24 22:17:51 +02:00
Bartłomiej Dach	133c954c93	Merge branch 'master' into pause-screen-progress	2023-05-24 21:57:26 +02:00
Bartłomiej Dach	6392c2007c	Merge pull request #23637 from peppy/add-shadow-settings-notifications ... Add shadow to notifications and settings overlays to better distinguish from other overlays	2023-05-24 21:34:14 +02:00
Bartłomiej Dach	8b6cd1310a	Merge branch 'master' into editor-escape-deselects	2023-05-24 20:18:44 +02:00
Bartłomiej Dach	cd3602406b	Remove unused using directive	2023-05-24 18:54:48 +02:00
Dean Herbert	b14b1072c2	Allow deselecting any selection in the editor using the Back binding (escape key)	2023-05-24 19:24:14 +09:00
Dean Herbert	3b9e1e8a94	Ensure editor selection buttons remain on screen when selection is near edge ... Addresses https://github.com/ppy/osu/discussions/23599.	2023-05-24 19:16:53 +09:00
Stéén	dcfc99a092	Merge branch 'master' into make_pause_menu_translatable	2023-05-24 12:13:34 +02:00
Dean Herbert	79c9a48ff7	Show song progress at pause/fail screen	2023-05-24 18:36:37 +09:00
Dean Herbert	456f3005d6	Apply nullability to GameplayMenuOverlay and use TextFlowContainer for text	2023-05-24 18:28:04 +09:00
Dean Herbert	8ada8b1c8c	Remove description line from pause/fail screen ... These were in the designs but read pretty bad / evil. I can't think of any text to go in their place that makes sense, so let's just nuke it.	2023-05-24 17:48:35 +09:00
Dean Herbert	3a05dffa50	Add "auto" bank selection during placement	2023-05-24 17:11:12 +09:00
Dean Herbert	fc22c75464	Don't use switch for single case statement	2023-05-24 16:14:05 +09:00
Dean Herbert	a22ad98cb7	Fix hotkeys not actually working	2023-05-24 14:56:11 +09:00
Dean Herbert	a9ba16a2be	Update to support non-control-point sample changes	2023-05-24 14:20:38 +09:00
Dean Herbert	298989ffd2	Merge branch 'master' into sample-set-controls	2023-05-24 14:03:04 +09:00
Dean Herbert	561b759bf9	Tidy up implementation and ensure non-solid ticks start at zero alpha	2023-05-24 13:49:29 +09:00
Dean Herbert	8f1f1955df	Merge pull request #66 from Gyoshi/beat-divisor-visual-improvements ... Add ghost ticks to exhibit current divisor on `BeatDivisorControl`	2023-05-24 13:41:48 +09:00
Dean Herbert	e5451d1d79	Centralise definition of overlay shadow opacity and reduce slightly	2023-05-24 12:40:35 +09:00
Joseph Madamba	067328233c	Remove OsuScreen.ApplyLogoArrivingDefaults()	2023-05-23 13:17:43 -07:00
Robin Oger	d852883421	Merge remote-tracking branch 'origin/make_pause_menu_translatable' into make_pause_menu_translatable	2023-05-23 21:37:20 +02:00
Robin Oger	a24da89908	Change to sentence casing ... See: https://github.com/ppy/osu/pull/23640#discussion_r1202879352	2023-05-23 21:37:12 +02:00
Stéén	b9b97069b3	Merge branch 'master' into make_pause_menu_translatable	2023-05-23 21:28:00 +02:00
Robin Oger	0ea3eea8d6	Make GameplayMenuOverlay translatable ... This allows translator to translate the pause and failed in game menus	2023-05-23 19:21:44 +02:00
Gyoshi	7fe19d1992	Last instead of Max divisor to match code elsewhere	2023-05-23 18:45:49 +02:00
Gyoshi	c5ef3ae181	Code styling	2023-05-23 18:44:20 +02:00
Gyoshi	b5f8093941	Use RangePadding to align mouse with slider	2023-05-23 18:16:14 +02:00
Gyoshi	7b1e8ede54	Small format	2023-05-23 15:11:27 +02:00
Gyoshi	1b32370c6a	Remove duplicate code by making GetDivisorForBeatIndex method more general	2023-05-23 15:05:38 +02:00
Gyoshi	37a796306d	Small format & comment	2023-05-23 14:30:35 +02:00
Johannes vd Berg	ebda35c3c9	Add ghost ticks to exhibit current divisor on BeatDivisorControl	2023-05-23 12:57:25 +02:00
Dan Balasescu	7658536b5a	Fix CI issues	2023-05-23 19:32:19 +09:00
Dan Balasescu	fee3d43596	Merge branch 'master' into scorev2	2023-05-23 19:07:54 +09:00
Dean Herbert	02d8e3a11e	Mark FullscreenOverlay's shadow effect as Hollow to save on shader overhead	2023-05-23 18:50:14 +09:00
Dean Herbert	6f4e2b37ed	Add shadow to notifications and settings overlays to better distinguish from other overlays	2023-05-23 18:50:14 +09:00
Dan Balasescu	d45b54399b	Add back minimum/maximum accuracy	2023-05-23 18:15:32 +09:00
Dan Balasescu	3598ca9125	Adjust xmldoc	2023-05-23 18:05:10 +09:00
Dean Herbert	adf9a596b5	Fix weird state when attempting to enter gameplay skin editor scene from multiplayer ... Closes https://github.com/ppy/osu/issues/23626.	2023-05-23 17:58:44 +09:00
Dan Balasescu	8570f825ed	Consider all accuracy judgements in accuracy progress	2023-05-23 17:47:35 +09:00
Dan Balasescu	f8101fbbc7	Rename variables	2023-05-23 17:44:17 +09:00
Dean Herbert	ff5dde0ebe	Merge pull request #23575 from Joehuu/fix-inverted-video-only-check ... Fix old widescreen videos with black bars not correctly filling screen (again)	2023-05-23 16:47:52 +09:00
Dean Herbert	7c039b0b67	Merge pull request #23618 from bdach/fix-taiko-swells-drumrolls-silent ... Fix hitsounds not playing before and during taiko drum rolls and swells	2023-05-23 16:44:04 +09:00
Dan Balasescu	62d504af92	Fix base implementation of ComputeTotalScore	2023-05-23 15:59:24 +09:00
Dan Balasescu	e1feeded12	Change statistics type, remove overridability	2023-05-23 15:36:34 +09:00
Cootz	c3f06ad2db	Merge branch 'master' into add-mod-search-option	2023-05-23 08:55:57 +03:00
Bartłomiej Dach	38b4bd8aef	Fix undo not behaving as expected sometimes	2023-05-22 22:45:39 +02:00
Bartłomiej Dach	e0b7539c2a	Fix sample changes not being applied in patcher	2023-05-22 22:45:23 +02:00
Bartłomiej Dach	f253d17a7f	Fix slider velocity changes not being applied in patcher	2023-05-22 22:19:10 +02:00
Dean Herbert	7742904d2a	Merge pull request #23593 from Dimmitsaras/unfocused-notifications ... Always show chat message notifications if window is unfocused	2023-05-22 14:17:20 +09:00
Dean Herbert	09c66bea8f	Merge pull request #23606 from Joehuu/fix-news-sidebar-link-clicking-area ... Fix clicking area of news sidebar post links	2023-05-22 14:17:08 +09:00
Joseph Madamba	7392109bce	Apply same behavioral changes to NewsCard	2023-05-21 19:28:12 -07:00
Joseph Madamba	2279aad360	Apply NRT to NewsCard	2023-05-21 19:27:20 -07:00
Dean Herbert	b3527b92b6	Handle case in tests where current display becomes null	2023-05-22 09:25:44 +09:00
Bartłomiej Dach	19816ae013	Update framework	2023-05-21 20:38:27 +02:00
Bartłomiej Dach	6df1d29862	Merge branch 'master' into use-atomic-ReplaceRange	2023-05-21 20:32:59 +02:00
Joseph Madamba	88c112612f	Remove hardcoded website url ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-05-21 10:35:22 -07:00
Bartłomiej Dach	5229cf7343	Add failing test cases for drum roll/swell sample playback	2023-05-21 18:57:01 +02:00
timiimit	9d14ea9d27	Merge branch 'ppy:master' into update-multiplayer-room-diff-range	2023-05-21 16:37:00 +02:00
timiimit	4441718437	Merge branch 'ppy:master' into organize-room-pills	2023-05-21 16:36:53 +02:00
Cootz	67bf1b4dfe	Select/deselect first visible mod when GlobalAction.Select is triggered	2023-05-21 11:05:01 +03:00
Joseph Madamba	8aefb62532	Rename PostButton to PostLink	2023-05-20 16:38:56 -07:00
Joseph Madamba	ec5f0bbf42	Fix clicking area of news sidebar post links ... Side effect is that the hover color is yellow and pressing it opens an external dialog, but those are temporary (pending implementation of link underline to make `Light1` hover more readable and set at a higher level and news pages).	2023-05-20 16:32:04 -07:00
Bartłomiej Dach	de5917b645	Merge branch 'master' into unfocused-notifications	2023-05-20 19:32:52 +02:00
Bartłomiej Dach	a677d87d39	Touch up inline comments	2023-05-20 19:29:59 +02:00
Bartłomiej Dach	8e0a97ca49	Remove usage of HasSubmenu ... Property has been removed in the appropriate framework-side PR and instead folded into `IsActionable`. See: https://github.com/ppy/osu-framework/pull/5658#discussion_r1114834647	2023-05-20 18:02:12 +02:00
Bartłomiej Dach	67c044773b	Merge branch 'master' into fix-menu-state-display	2023-05-20 17:57:00 +02:00
Bartłomiej Dach	afdddb0195	Merge pull request #23582 from peppy/placement-blueprint-timeline-combo-fixes ... Fix timeline blueprint display not showing correct combo number / colour during placement	2023-05-20 15:02:55 +02:00
Bartłomiej Dach	0e11adaaac	Merge pull request #23564 from peppy/fix-missing-sample-additions ... Fix sample banks not transferring when adjusting via editor	2023-05-20 14:36:45 +02:00
Dan Balasescu	25d72d370e	Always add non-bonus change to combo portion	2023-05-20 00:24:43 +09:00
Dan Balasescu	30a296bd09	Rename parameters	2023-05-19 17:27:02 +09:00
Dan Balasescu	6c6f8621c1	Add score processor statistics to replay header	2023-05-19 16:29:24 +09:00
Dan Balasescu	d74bf2a096	Refactor for safety	2023-05-19 14:37:26 +09:00
Dan Balasescu	2ae34530f7	Avoid NaN values during ApplyBeatmap processing()	2023-05-19 14:14:34 +09:00
Dan Balasescu	7cbf48ffcf	Fix TestSceneScoring and incorrect combo calculations	2023-05-19 14:09:19 +09:00
Dan Balasescu	035d0d5c9c	Fix multiplayer leaderboard not working	2023-05-19 13:16:57 +09:00
Dan Balasescu	8b56a3f87d	Remove ClassicScoreMultiplier and DefaultScoreProcessor	2023-05-19 12:24:52 +09:00
Dan Balasescu	00e0411369	Fix/rework ModAccuracyChallenge calculation	2023-05-18 20:45:02 +09:00
Dan Balasescu	ef86be6d21	Fix base score added for non-accuracy-affecting objects	2023-05-18 20:32:50 +09:00
Dan Balasescu	c33e4fe75e	Remove unnecessary override	2023-05-18 20:10:28 +09:00
Dan Balasescu	808818768b	Add TotalScore to replay frame headers	2023-05-18 20:08:49 +09:00
Dan Balasescu	f3591f83a2	Remove ScoreManager.GetTotalScore()	2023-05-18 20:08:49 +09:00
Dan Balasescu	510b8e4c78	Remove ScoreManager.Mode, handle per-use	2023-05-18 20:08:49 +09:00
Dan Balasescu	829e47d30b	Add MaxTotalScore for performance breakdown calculator	2023-05-18 17:47:25 +09:00
Dan Balasescu	f2483a1cf8	Add some helper methods, fix precision differences ... Introduces some error at all times, but if we're to store scores everywhere as `long`, then the same precision should be applied to the "during gameplay" path as well.	2023-05-18 17:44:31 +09:00
Dean Herbert	ee522253cb	Remove a couple of unnecessary volume declarations	2023-05-18 14:12:57 +09:00
Bartłomiej Dach	9ca1c7f7b7	Merge pull request #23580 from peppy/fix-profile-button-depth ... Ensure scroll-to-top button is displayed above all overlay content	2023-05-17 21:23:46 +02:00
Dimmitsaras	7ac6688a0f	Chat message notifications always play on unfocused window	2023-05-17 18:34:39 +03:00
Dean Herbert	b58ab28765	Make EditorClock non-nullable in PlacementBlueprint	2023-05-17 21:40:52 +09:00
Dean Herbert	214d7e07fa	Add TODO regarding failing stack display code	2023-05-17 17:52:17 +09:00
Dean Herbert	0b25818bd2	Update combo information on placement blueprint	2023-05-17 17:26:19 +09:00
Dean Herbert	9563d4f730	Fix weird purple tint on placement object in timeline	2023-05-17 17:26:19 +09:00
Dean Herbert	8d925c8a8a	Move combo information updating to an interface level helper method	2023-05-17 17:26:19 +09:00
Dean Herbert	e43f2c2c43	Improve previous hitobject lookup efficient and correctness	2023-05-17 17:19:29 +09:00
Dean Herbert	7d7d402d4e	Apply NRT to PlacementBlueprint	2023-05-17 17:19:29 +09:00
Dean Herbert	87ff28b022	Update beat divisor control to show ticks in more visually correct locations ... As proposed in https://github.com/ppy/osu/discussions/23527.	2023-05-17 16:34:12 +09:00
Dean Herbert	730bc3a961	Apply NRT and simplify some remaining code	2023-05-17 16:18:13 +09:00
Dean Herbert	e97d027230	Make OnlinePlayPill class abstract	2023-05-17 16:13:03 +09:00
Dean Herbert	79e1d978e7	Ensure scroll-to-top button is displayed above all overlay content	2023-05-17 15:42:38 +09:00
Dean Herbert	764f0323f4	Show "rewind" text on random button when beginning a right mouse press	2023-05-17 14:51:40 +09:00
Dean Herbert	94b184712d	Fix random button hover state not correctly being reset on right click	2023-05-17 14:51:40 +09:00
Dean Herbert	dc421bd2af	Revert "Merge pull request #23570 from huoyaoyuan/inspect-code-cs11" ... This reverts commit ab2bd123e7, reversing changes made to 267e63320f.	2023-05-17 14:49:47 +09:00
Dean Herbert	510ebe1f23	Fix weird optional usage in HitSampleInfo.With	2023-05-17 14:11:52 +09:00
Dean Herbert	dc51d5ecf3	Rename GetSampleInfo to better describe what method does ... Also add full xmldoc	2023-05-17 14:07:48 +09:00
Dean Herbert	a8bc337006	Change default volume when constructing a HitSampleInfo to non-zero	2023-05-17 14:06:02 +09:00
Susko3	fec47fa690	Merge branch 'master' into use-atomic-ReplaceRange ... This reverts 0dcf1b540e	2023-05-17 06:56:54 +02:00
Joseph Madamba	d6fa44240d	Fix storyboard video-only check being inverted	2023-05-16 21:51:32 -07:00
John	e2633ae993	Removed unnecessary [Resolved] attribute (thanks bdach) ... Moved accent color assignment from OnUpdate to ApplyCustomUpdateState. In order to get this to work, a flag needed to be added to DrawableHitObject.cs to disable combo color updates also being applied.	2023-05-16 21:08:56 -07:00
Dean Herbert	0d3c64dc32	Merge pull request #23572 from bdach/avoid-display-settings-feedback ... Work around issues with bindable/event feedback in layout settings	2023-05-17 12:03:45 +09:00
Susko3	2d7fe68311	Prevent feedback by using atomic .ReplaceRange() ... `display.NewValue` will never be null, checked on SDL + osuTK/Android. On Android it's a 0x0 display, importantly not null.	2023-05-16 21:57:31 +02:00
Bartłomiej Dach	0dcf1b540e	Attempt to preserve old resolution when switching displays	2023-05-16 21:14:09 +02:00
Bartłomiej Dach	88ce627c8e	Avoid bindable/event feedback when changing resolution	2023-05-16 21:02:23 +02:00
Huo Yaoyuan	ddfdd712bd	Update InspectCode to 2022.3.3 and enable C# 11	2023-05-17 00:07:06 +08:00
Dean Herbert	d9ae822966	Fix bank not correctly being assigned when adding sample additions in editor	2023-05-16 18:52:52 +09:00
Dean Herbert	83dcd78826	Make HitSampleInfo.Bank non-nullable	2023-05-16 18:12:56 +09:00
timiimit	cc6e4df93e	Remove wrongly added back namepspace	2023-05-16 10:27:46 +02:00
timiimit	4ef74eb3f9	Fix RoomStatusPill text colour	2023-05-16 10:22:52 +02:00
timiimit	81b7737660	Fix text colour of RoomSpecialCategoryPill	2023-05-16 10:20:16 +02:00
timiimit	a9991d9dd4	Remove another unused namespace	2023-05-16 10:14:14 +02:00
timiimit	40daa41a52	Fix naming & namespaces	2023-05-16 10:06:48 +02:00
timiimit	04893064f0	Make used pills inherit from a common one	2023-05-16 09:53:11 +02:00
timiimit	10d6f9ea5a	Create common online play pill	2023-05-16 09:52:26 +02:00
timiimit	0fd718478a	Merge branch 'master' into update-multiplayer-room-diff-range	2023-05-15 07:36:43 +02:00
timiimit	83ceb3457f	Add xmldoc comment	2023-05-15 07:36:15 +02:00
timiimit	cb8d5f459f	Remove bad comment	2023-05-15 07:36:15 +02:00
Bartłomiej Dach	592fcafcd4	Merge pull request #23451 from timiimit/fix-default-progress-graph-flipping ... Fix default progress graph not updating after flip	2023-05-14 19:19:10 +02:00
Cootz	6647d95ea7	Kill search focus when clicking on ModColumn	2023-05-14 18:32:16 +03:00
timiimit	f7a2321175	Merge branch 'master' into update-multiplayer-room-diff-range	2023-05-14 12:28:58 +02:00
Bartłomiej Dach	cc2dfc8371	Merge branch 'master' into editor-slider-placement-tool-change	2023-05-14 12:26:37 +02:00
timiimit	86a834fb56	Fix TODO comment	2023-05-14 12:20:16 +02:00
timiimit	fd80ffd52b	Fix display update condition	2023-05-14 12:09:15 +02:00
timiimit	5d68701321	Copy StarRange when creating PlaylistItem	2023-05-14 12:08:37 +02:00
timiimit	f1f30b94a6	Add StarRating Property	2023-05-14 11:05:47 +02:00
Bartłomiej Dach	e6786e0244	Merge branch 'master' into editor-slider-placement-input	2023-05-14 10:52:22 +02:00
Bartłomiej Dach	325de2dc22	Merge pull request #23507 from peppy/editor-blueprint-end-placement ... Move blueprint validity conditions to allow more correct external usage of `EndPlacement`	2023-05-14 10:24:04 +02:00
Bartłomiej Dach	58410c6fc0	Merge pull request #23506 from peppy/tablet-settings-keywords ... Fix some tablet settings being hidden when searching using "area" keyword	2023-05-14 09:44:55 +02:00
Bartłomiej Dach	732bd7812b	Merge pull request #23529 from peppy/no-hold-during-gameplay ... Fix hold-for-right-click showing during gameplay	2023-05-13 15:33:13 +02:00
Dean Herbert	8c542c6c51	Fix hold-for-right-click showing during gameplay	2023-05-13 21:32:30 +09:00
Dean Herbert	2e6fd4b321	Update framework	2023-05-13 20:54:22 +09:00
timiimit	18efdb0e4c	Make layout readonly	2023-05-13 11:37:56 +02:00
timiimit	d81cdacb0d	Undo stupid changes	2023-05-13 11:28:05 +02:00
timiimit	4b544903cb	Optimize recalculateValues	2023-05-13 10:13:09 +02:00
timiimit	2cfc4eb515	Fix unconsidered height change	2023-05-13 10:12:46 +02:00
John	7a907f7207	Code quality improvements (thanks to ItsShamed): Removed #nullable disable, fixed incorrect LocalisableString, removed incorrect dependency injection for OsuColour, fixed nullable dependency for IBeatmap ... Removed unnecessary usage of "this." caught by the CI code quality check	2023-05-12 22:13:39 -07:00
John	e5884016ab	Initial commit for the snap colour mod. Implements basic functionality.	2023-05-12 19:07:25 -07:00
timiimit	80b6e014f1	More code style	2023-05-13 01:47:44 +02:00
timiimit	8cc0c5ad1c	Fix code style	2023-05-13 01:39:01 +02:00
timiimit	04f7def798	Remove useless comment	2023-05-13 01:31:12 +02:00
timiimit	21d7c62f30	Add optimized UpdateGraph	2023-05-13 01:29:11 +02:00
timiimit	159cacf9c7	Fix logic in recalculateValues()	2023-05-13 01:27:28 +02:00
timiimit	6180d0d620	Remove cached frame buffer	2023-05-12 15:00:46 +02:00
Dean Herbert	0c1959ef2f	Allow commiting / undoing placement of blueprints using back / select bindings	2023-05-12 16:06:20 +09:00
Dean Herbert	70e248b927	Force placement of in-progress object when changing tools in the editor	2023-05-12 16:06:01 +09:00
Dean Herbert	f443cfb93e	Move blueprint validity conditions to allow more correct external usage of EndPlacement ... Until now, these were haphazardly enforce inline in blueprint implementations. The only thing stopping complete breakage is that `EndPlacement` wasn't called (too much) from outside the blueprint, leaving them responsible for their own placement. By moving this conditional out of the provided paramters to `EndPlacement`, it allows more flexible usage of that method externally. Coming in a future PR.	2023-05-12 16:02:22 +09:00
Dean Herbert	c0f869e685	Fix some tablet settings being hidden when searching using "area" keyword ... As discussed in https://github.com/ppy/osu/discussions/23504.	2023-05-12 14:57:56 +09:00
tsrk	2d45d602a5	feat(settings): more keyword for first run setup	2023-05-11 15:03:42 +01:00
tsrk	c1a85658b7	feat(settings): add "import" as keywords for first run setup	2023-05-11 14:58:17 +01:00
Cootz	ca68850730	fix formatting	2023-05-10 19:43:58 +03:00
Dean Herbert	3fc19553b4	Update resources	2023-05-10 15:19:46 +09:00
Dean Herbert	4aa241daea	Update framework	2023-05-10 15:19:43 +09:00
Cootz	2467813d81	Block deselect all short key when using the search box	2023-05-09 16:14:42 +03:00
Dean Herbert	bdf8a78b42	Add the ability to adjust the beatmap tick rate in the editor	2023-05-09 20:53:20 +09:00
Dean Herbert	ca5e8b290f	Add clamping to SliderMultiplier and SliderTickRate at parsing time	2023-05-09 20:53:20 +09:00
Dean Herbert	d10dd6d5ae	Merge branch 'master' into base-s-v	2023-05-09 20:52:11 +09:00
Dan Balasescu	a7b623f52a	Reimplement classic scoring mode	2023-05-09 20:21:38 +09:00
Dan Balasescu	3c3c812ed6	Initial implementation of ScoreV2	2023-05-09 19:33:33 +09:00
Dean Herbert	2085833a84	Fix missing delegate unsubscribe	2023-05-09 17:08:03 +09:00
Dean Herbert	944da06c10	Rename slider multiplier variable back for now	2023-05-09 16:58:19 +09:00
Bartłomiej Dach	1d162d1d15	Merge pull request #23440 from peppy/drawable-hit-object-sync-animations ... Fix hit object animations not being played back in sync	2023-05-08 23:44:37 +02:00
Bartłomiej Dach	30ce86a582	Merge pull request #23437 from peppy/fix-hold-note-input-test ... Fix `TestSceneHoldNoteInput` not displaying correctly	2023-05-08 22:22:33 +02:00
Bartłomiej Dach	2177dbf42a	Merge pull request #23436 from peppy/fix-wiki-error-return-to-main ... Fix "Return to main page" link not working on wiki after error	2023-05-08 21:56:29 +02:00
Dean Herbert	64498e95a4	Add an IAnimationTimeReference to DrawableHitObject to synchronise all animations	2023-05-08 18:56:29 +09:00
Dan Balasescu	d2380bd840	Remove usages of [ExcludeFromDynamicCompile]	2023-05-08 18:12:56 +09:00
Dean Herbert	d6ce56e6b1	Fix GetMostCommonBeatLength returning zero in case of not timing points	2023-05-08 17:09:08 +09:00
Dean Herbert	1b7dd32eb1	Apply nullability in related classes and remove unused variable	2023-05-08 17:09:08 +09:00
Dean Herbert	715b735131	Fix "Return to main page" link not working on wiki after error	2023-05-08 15:29:05 +09:00
Dean Herbert	8c44d528e9	Use min/max values from stable	2023-05-08 13:52:16 +09:00
Dean Herbert	a6cb1f90e4	Change difficulty popover inspector display (yet again) ... I think this makes the most sense of the iterations I've tested so far, albeit maybe being a touch too verbose.	2023-05-08 13:43:23 +09:00
Dean Herbert	a91edd68d9	Show post-multiplied velocity in main hit object inspector	2023-05-08 13:42:25 +09:00
Dean Herbert	451af9d1b5	Fix beatmap values not being updated due to a varying data type	2023-05-08 13:23:13 +09:00
Dean Herbert	d9dd35c020	Show base velocity in slider adjustment popover	2023-05-08 13:13:09 +09:00
Dean Herbert	31de4de720	Remove median/mode slider velocity display ... The intention was to give an idea of what the most common velocity of the beatmap is, but in hindsight, because the "base" velocity is being set elsewhere this doesn't make sense. It will/should be 1.0x. Showing this range is still valuable, though.	2023-05-08 13:13:09 +09:00
Dean Herbert	b109ee74a6	Add "base velocity" adjustment to difficulty setup screen	2023-05-08 13:13:09 +09:00
Dean Herbert	f7d44c3013	Rename SliderMultiplier to BaseSliderVelocity	2023-05-08 13:13:09 +09:00
Cootz	60bad35145	Remove weird update usage when 'deselect all' pressed	2023-05-07 15:34:01 +03:00
Cootz	4d235105d1	Convert ModSearchContainer to block-scoped namespace	2023-05-07 15:14:49 +03:00
Bartłomiej Dach	65b4b198a4	Merge branch 'master' into export	2023-05-06 20:12:53 +02:00
tsrk	e9d7cd7a79	feat(ArgonKeyCounter): flash key name	2023-05-06 19:08:30 +01:00
Bartłomiej Dach	510484011c	Mark exporter extensions as untranslatable	2023-05-06 19:42:28 +02:00
Bartłomiej Dach	3f63fd7f4d	Reorder increment to make progress update less weird	2023-05-06 19:39:52 +02:00
Bartłomiej Dach	bb17b684b0	Rename flag	2023-05-06 19:38:41 +02:00
Bartłomiej Dach	a56a5d563c	Unify error message wording	2023-05-06 19:38:05 +02:00
Bartłomiej Dach	3afe198d1d	Remove weird single-use private method	2023-05-06 19:34:22 +02:00
Bartłomiej Dach	e0823ffd03	Move lower and xmldoc GetFilename(TModel)	2023-05-06 19:29:08 +02:00
Bartłomiej Dach	5e64d25b2a	Make UserFileStorage readonly again	2023-05-06 19:26:51 +02:00
Dean Herbert	64d7e0d896	Rename outputStream variable to match base class	2023-05-07 00:24:30 +09:00
Dean Herbert	d2591368a6	More xmldoc fixes	2023-05-06 23:53:35 +09:00
Bartłomiej Dach	e2410c00e2	Merge branch 'master' into update-framework	2023-05-06 16:25:44 +02:00
Bartłomiej Dach	38ebce8ee9	Update framework again	2023-05-06 16:21:48 +02:00
Dean Herbert	0d095c4bb7	Remove non-Live pathway	2023-05-06 23:10:18 +09:00
Dean Herbert	e75ff33d62	Remove redundant xmldoc and reword some remaining	2023-05-06 23:10:09 +09:00
Bartłomiej Dach	3942281d13	Fix back-to-front logic	2023-05-06 15:34:55 +02:00
Bartłomiej Dach	80ac8abaa6	Merge branch 'master' into chat-report	2023-05-06 15:30:44 +02:00
Bartłomiej Dach	1da5e69d5a	Fix API success callback scheduling to dead drawable	2023-05-06 15:27:27 +02:00
Bartłomiej Dach	6b4050ea52	Remove invalid report reason (and add osu-web references)	2023-05-06 15:01:57 +02:00
Bartłomiej Dach	52e5835be6	Document and retouch ReportPopover	2023-05-06 14:52:38 +02:00
Cootz	cbb9f0100e	Update PopIn and PopOut filtering. Expose SearchTerm	2023-05-06 11:27:06 +03:00
Cootz	a226caff56	Fix testing	2023-05-06 11:09:44 +03:00
Cootz	7422b5285c	Fix wrong filtering in testing	2023-05-05 22:41:30 +03:00
Bartłomiej Dach	e808a47811	Fix delegate leak	2023-05-05 20:33:27 +02:00
Bartłomiej Dach	f536238554	Use shorter copy	2023-05-05 20:30:50 +02:00
Bartłomiej Dach	34b19dd6f4	Merge branch 'master' into slider-velocity-inspector	2023-05-05 20:20:16 +02:00
Bartłomiej Dach	4ca80cf6be	Merge pull request #23404 from peppy/show-sv-in-inspector ... Show slider velocity in hit object inspector	2023-05-05 20:19:50 +02:00
Bartłomiej Dach	3b37a421e6	Merge pull request #23401 from peppy/fix-break-overlay-glow-cutoff ... Fix break overlay arrows' glow getting cut off at lower resolutions	2023-05-05 20:12:34 +02:00
cdwcgt	71864fbb93	remove meanless comment	2023-05-05 21:29:06 +09:00
cdwcgt	4393e53b43	ExportToStream should be public	2023-05-05 21:28:43 +09:00
Dean Herbert	490df8073c	Fix one incorrect namespace syntax file	2023-05-05 21:15:26 +09:00
Dean Herbert	747f912af5	Fix incorrect cancellation logic	2023-05-05 21:08:01 +09:00
Dean Herbert	5d78561aa3	Remove weird catch logic	2023-05-05 21:05:57 +09:00
Dean Herbert	2a3e03695c	Simplify ExportAsync, remove weird dedupe logic and unnecessary return success code	2023-05-05 21:05:52 +09:00
Dean Herbert	4ccfebc02b	Simplify ExportToStreamAsync implementation	2023-05-05 21:01:10 +09:00
Dean Herbert	fc2d2de34c	Fix notification text not including export filename	2023-05-05 16:53:27 +09:00
Dean Herbert	9cafb20fcb	Move file missing logging to a better location, and log actual filenames to logs	2023-05-05 16:53:16 +09:00
Dean Herbert	4ec98b0578	Improve xmldoc and fix silly progress text in LegacyArchiveExporter	2023-05-05 16:45:45 +09:00
Dean Herbert	0158102467	Rename class back to original name so I can read the diff	2023-05-05 16:19:10 +09:00
Dean Herbert	b7a287869a	Add display of beatmap slider velocity when adjusting	2023-05-05 15:57:38 +09:00
Dean Herbert	cc70d89bf9	Move editor inspector classes out of ruleset namespace	2023-05-05 15:57:38 +09:00
Dean Herbert	4663057060	Split out EditorInspector implementation for reuse	2023-05-05 15:54:15 +09:00
Cootz	ab94b4dce1	Update ModPresetPanel.FilterTerms to account mod names and acronyms	2023-05-05 09:52:09 +03:00
Cootz	54757df51f	Fix mod deselect button not working properly when search applied	2023-05-05 09:31:27 +03:00
Dean Herbert	76b2f0e6dd	Show slider velocity in hit object inspector	2023-05-05 15:15:18 +09:00
Dean Herbert	560f71ef53	Adjust BlurredIcon expansion ratio to fix glow getting cut off at lower resolutions ... Closes https://github.com/ppy/osu/issues/23210. Ballparked the fix to work down to the lowest resolution we support. The previous number (`2.5f`) was also likely ballparked so the fix seems in line with expectations. I don't want to put too much thought into this because the design of this screen is likely going to change in the mean time anyway.	2023-05-05 14:29:04 +09:00
Dean Herbert	8391e2a538	Move reporting code out of DrawableChatUsername into more correct locations	2023-05-05 14:03:42 +09:00
tsrk	74e7a958bb	feat(ArgonKeyCounter): make animation ... Currently WIP. Do not consider this final.	2023-05-05 05:31:06 +01:00
Dean Herbert	698baa78bf	Merge pull request #22711 from Terochi/keep-shared-settings-ruleset-change ... Keep shared mod settings when changing ruleset	2023-05-05 13:29:55 +09:00
Bartłomiej Dach	485b7282dc	Clarify type check	2023-05-04 19:06:07 +02:00
Bartłomiej Dach	bdd96caaa9	Merge branch 'master' into edit-mods-preset	2023-05-04 18:59:47 +02:00
Bartłomiej Dach	1f1342b099	Reword xmldoc	2023-05-04 18:33:49 +02:00
Bartłomiej Dach	88e77ad390	Rename Settings{-> Map}	2023-05-04 18:30:41 +02:00
Bartłomiej Dach	26337dbcd8	Do not rely on unspecified Dictionary.Values ordering	2023-05-04 18:29:01 +02:00
Cootz	1ac9d900e1	Clear search on ModSelectOverlay.Hide	2023-05-04 19:24:37 +03:00
Bartłomiej Dach	0d2396c557	Rename method to better indicate directionality	2023-05-04 18:15:12 +02:00
Dean Herbert	95b541ab39	Update framework	2023-05-04 11:27:18 +09:00
Dean Herbert	0034124d79	Remove unnecessary content clear	2023-05-04 11:25:10 +09:00
Dean Herbert	26b8c5b852	Fix mod list display not updating after clicking "use current" ... This is not a regression from my changes. It was broken before them.	2023-05-04 11:23:51 +09:00
Dean Herbert	49fb5da1a2	Stop passing preset panel to popover	2023-05-04 11:19:09 +09:00
Dean Herbert	b12d139317	Remove dead code	2023-05-04 11:16:52 +09:00
Dean Herbert	99d2616c34	Move drawable construction to load for simplicity	2023-05-04 11:14:51 +09:00
Dean Herbert	be995f1359	Add localisation support for new button string	2023-05-04 11:11:19 +09:00
Dean Herbert	b7abab6d8a	More variable improvements	2023-05-04 11:10:05 +09:00
Dean Herbert	0a584f0652	Simplify check logic and improve variable naming	2023-05-04 11:07:09 +09:00
Bartłomiej Dach	59ece64d25	Merge branch 'master' into skin-editor-change-handler-improvement	2023-05-03 19:42:42 +02:00
Bartłomiej Dach	1d4d31e35c	Trim comments ... Leaving only the ones that add anything useful and do not restate the code verbatim.	2023-05-03 19:22:52 +02:00
Bartłomiej Dach	27fabd99fb	Rename variables for legibility ... Having `typedComponents` and `typeComponents` next to each other is asking for trouble.	2023-05-03 19:21:16 +02:00
Terochi	d1d4b54c64	Simplified	2023-05-03 18:31:35 +02:00
Bartłomiej Dach	fa3f42ba75	Merge pull request #23386 from peppy/fix-osu-logo-input-handling ... Extend input handling of osu! logo to full border area	2023-05-03 17:48:51 +02:00
cdwcgt	4549a865d9	Merge branch 'master' into export	2023-05-04 00:18:01 +09:00
cdwcgt	967e801f9c	code inspect	2023-05-03 23:26:58 +09:00
cdwcgt	debbd376bd	move scrollContent update logic to updateActiveState()	2023-05-03 23:24:14 +09:00
cdwcgt	f4b1264cc9	use button Enable status to ensure preset name is not null	2023-05-03 23:22:46 +09:00
cdwcgt	aa5a026c67	remove local button handle	2023-05-03 23:14:24 +09:00
cdwcgt	c609e6345c	remove Use Current Mods menu item	2023-05-03 23:02:50 +09:00
Cootz	152d2678d5	Fix ModSelectColumn completely disappear from ModSelectOverlay	2023-05-03 14:00:46 +03:00
Dean Herbert	be15d07b17	Tidy up various implementation details	2023-05-03 18:59:39 +09:00
Dean Herbert	b932e4d986	Rename DrawableUsername to DrawableChatUsername and only pass message ID	2023-05-03 18:53:22 +09:00
Dean Herbert	b28d7b1a92	Fix non-block namespace	2023-05-03 18:51:02 +09:00
Dean Herbert	4f55afb60d	Merge branch 'master' into chat-report	2023-05-03 18:50:38 +09:00
Dean Herbert	444f66b0ee	Move to base class for added safety	2023-05-03 18:46:30 +09:00
Dean Herbert	cd31cff8cd	Fix event subscriptions not being cleaned up in DrawableCarouselBeatmap ... The handling of cleanup is performed only the `Item_Set` method. This was already correctly called for `DrawableCarouselBeatmapSet`, but not for the class in question here. This would cause runaway memory usage at song select when opening many beatmaps to show their difficulties. For simplicity, we don't yet pool these (and generate the drawables each time a set is opened) which isn't great but likely will be improved upon when we update the visual / filtering of the carousel. But this simplicity caused the memory usage to blow out until exiting back to the main menu when cleanup would finally occur.	2023-05-03 18:41:30 +09:00
Dean Herbert	5757eb7529	Update a few more instances of 0.96f scale constants	2023-05-03 18:20:12 +09:00
Bartłomiej Dach	88135a3be8	Merge pull request #23384 from peppy/fix-incorrect-transform-thread ... Fix potentially incorrect thread access in `OsuTabControlCheckbox`	2023-05-03 10:37:27 +02:00
Dean Herbert	ff28d941b3	Merge pull request #23385 from Joehuu/scroll-back-button-block-hover ... Fix overlay scroll back button not absorbing hover from behind	2023-05-03 16:28:05 +09:00
Bartłomiej Dach	de1b28bcb2	Fix incorrect initial state of checkbox ... This only ever barely used to work without the `(..., true)` in `master` because of haphazard operation ordering.	2023-05-03 09:27:23 +02:00
Bartłomiej Dach	5f781bd6de	Move callback to LoadComplete() ... Is the more correct place for `BindValueChanged()` callbacks.	2023-05-03 09:26:54 +02:00
Dean Herbert	453143813f	Extend input handling of osu! logo to full border area ... This is the easiest way to make this happen. It does mean the pink area is being drawn behind the white border, but I haven't found a scenario where this is noticeable. Closes #4217.	2023-05-03 14:57:57 +09:00
Joseph Madamba	1c74f6e8ea	Fix regressed button hover fade in	2023-05-02 22:54:42 -07:00
Joseph Madamba	bede1292de	Fix overlay scroll back button not absorbing hover from behind	2023-05-02 22:40:37 -07:00
Dean Herbert	a3efae3690	Fix potentially incorrect thread access in OsuTabControlCheckbox ... https://github.com/ppy/osu/actions/runs/4868337922/jobs/8681736829.	2023-05-03 14:33:32 +09:00
Dean Herbert	6b017ac05f	Merge pull request #23308 from OliBomby/sample-control-points ... Remove SampleControlPoint and DifficultyControlPoint from HitObject	2023-05-03 14:21:51 +09:00
Dean Herbert	f930c4bd0a	Move struct to bottom of file	2023-05-03 13:33:31 +09:00
Dean Herbert	48fd99818e	Split out default and sample application	2023-05-03 13:30:45 +09:00
Dean Herbert	cca15f930c	Refactor applyLegacyInfoAndDefaults for legibility	2023-05-03 13:26:50 +09:00
Dean Herbert	588a4e6196	Move pragma disable to top of LegacyBeatmapDecoder ... Makes more sense as it's used multiple times in the class.	2023-05-03 13:19:14 +09:00
Dean Herbert	e394b487e0	Merge branch 'master' into edit-mods-preset	2023-05-03 12:06:16 +09:00
Dean Herbert	e42b0cc5b1	Merge pull request #23370 from peppy/fix-editor-playfield-padding ... Add more padding around playfield in editor to avoid overlap with tool areas	2023-05-03 11:44:55 +09:00
Bartłomiej Dach	ec8362c6fc	Merge pull request #23367 from peppy/fix-uo-tooltip ... Fix slider bar tooltips potentially showing negative zero	2023-05-02 18:03:09 +02:00
Bartłomiej Dach	48dd42407b	Merge pull request #23369 from peppy/beatmap-attribute-text-unicode-preference ... Fix `BeatmapAttributeText` not supporting unicode artist/title	2023-05-02 17:32:55 +02:00
Cootz	a6ca049739	Manually implement @bdach prototype	2023-05-02 14:15:33 +03:00
Dean Herbert	94ae9d7664	Merge pull request #23357 from OliBomby/fix-reverse-crash ... Prevent infinite repeat count when adjusting repeats of 0 length slider	2023-05-02 19:53:26 +09:00
Dean Herbert	414b80d44e	Change flashlight depth in a more standard way	2023-05-02 17:00:54 +09:00
Dean Herbert	b2b9f2a036	Merge branch 'master' into bubble_mod_implementation_clean	2023-05-02 16:59:55 +09:00
OliBomby	2e018c8b06	Fix comment 2 osu.Game/Rulesets/Objects/Types/IHasGenerateTicks.cs ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2023-05-02 08:41:47 +02:00
OliBomby	c2ad8c2320	Fix comment 1 osu.Game/Rulesets/Objects/Types/IHasGenerateTicks.cs ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2023-05-02 08:41:30 +02:00
Dean Herbert	67f83f246b	Add more padding around playfield in editor to avoid overlap with tool areas ... Closes #23130.	2023-05-02 15:37:02 +09:00
Dean Herbert	4a97c2c105	Merge pull request #23038 from cdwcgt/scale-background-dim ... Add feature to adjust `ScalingContainer` background dim	2023-05-02 15:36:52 +09:00
Dean Herbert	ce4a6c38a0	Merge pull request #22950 from Joehuu/fix-initial-playlist-highlight ... Fix now playing playlist not highlighting selected item on initial open	2023-05-02 15:36:34 +09:00
Dean Herbert	8a536c1cdb	Fix non-block namespace usage	2023-05-02 15:09:24 +09:00
Dean Herbert	1e4a628cb1	Merge pull request #23284 from Hy0tic/multiplier-doesnt-update-with-preset-mod ... Fix issue where multiplier show wrong value when adjusting speed on preset	2023-05-02 14:59:41 +09:00
Dean Herbert	e3c384c6b5	Merge branch 'master' into sample-control-points	2023-05-02 14:38:39 +09:00
Dean Herbert	57f48e0703	Start colour black to ensure initial appear transition doesn't look silly	2023-05-02 14:33:57 +09:00
Dean Herbert	ab4f66fad3	Minor readability refactors	2023-05-02 14:31:39 +09:00
Dean Herbert	7a840e1d82	Remove unnecessary TransferValue spec	2023-05-02 14:29:26 +09:00
Dean Herbert	7efaa299bd	Merge branch 'master' into scale-background-dim	2023-05-02 14:24:54 +09:00
Dean Herbert	736be6a73b	Refactor slightly for readability	2023-05-02 14:11:16 +09:00
Dean Herbert	ad40099e32	Ensure negative sign is only applied when the post-rounded result is negative	2023-05-02 14:00:52 +09:00
Dean Herbert	37a5dde859	Fix BeatmapAttributeText not supporting unicode artist/title	2023-05-02 13:47:49 +09:00
Dean Herbert	e808e7316b	Mark delegate value unused and add comment to avoid future regression	2023-05-02 13:29:30 +09:00
Dean Herbert	63890ef6fe	Fix audio offset tooltip potentially showing "-0 ms" ... Closes https://github.com/ppy/osu/issues/23339.	2023-05-02 13:24:22 +09:00
Dean Herbert	983a8f7dfe	Merge branch 'master' into fix-reverse-crash	2023-05-02 13:14:34 +09:00
Dean Herbert	5da78098ad	Merge pull request #23362 from bdach/fix-saving-online-beatmap-not-resetting-id ... Reset online ID on locally modifying beatmap	2023-05-02 12:41:23 +09:00
Bartłomiej Dach	436ebdcfcb	Fix beatmap leaderboard test failure ... Because the online info reset (which includes online ID reset) was happening after encoding, `TestSceneBeatmapLeaderboard.TestLocalScoresDisplayOnBeatmapEdit()` started failing, as the hash no longer matched expectations after the first save of the map.	2023-05-01 19:44:15 +02:00
OliBomby	cf5211aec9	Enable current distance snap when exactly on a hit object	2023-05-01 19:22:52 +02:00
Bartłomiej Dach	f470b2c9cc	Always reset online info when saving local beatmap	2023-05-01 18:17:45 +02:00
Bartłomiej Dach	8ab3a87b13	Add failing test case covering online ID reset on save ... This test scene passes at e58e1151f3 and fails at current master, due to an inadvertent regression caused by e72f103c17. As it turns out, the online lookup flow that was causing UI thread freezes when saving beatmaps in the editor, was also responsible for resetting the online ID of locally-modified beatmaps if online lookup failed.	2023-05-01 18:17:35 +02:00
OliBomby	8c21fddb5e	remove all redundancies from encoded control points	2023-05-01 16:53:38 +02:00
OliBomby	1dc34ee25d	fix infinite repeat count when adjusting length of 0 length slider	2023-05-01 15:48:54 +02:00
OliBomby	8302bb1f37	dont encode custom sample bank for objects without legacy samples	2023-05-01 14:56:29 +02:00
OliBomby	27cfadca16	add sample info to Banana and SpinnerBonusTick	2023-05-01 14:54:06 +02:00
Terochi	4d52ce769b	Revert SaveState() calling on initialization	2023-05-01 12:53:58 +02:00
OliBomby	cef9f73d34	dont assign custom sample bank and volume to hitobjects in non-mania gamemodes ... this makes it easier to edit hitsounds in the stable editor after export because the sample control point effects wont get overwritten by the properties of the hitobject	2023-05-01 12:31:27 +02:00
Bartłomiej Dach	d98aa60efc	Merge branch 'master' into cursor-ripples	2023-05-01 09:37:50 +02:00
OliBomby	2a94757154	Make sure the first object you place has bank and volume	2023-05-01 00:49:01 +02:00
OliBomby	608fa3cc73	Merge remote-tracking branch 'upstream/master' into sample-control-points	2023-04-30 19:47:03 +02:00
OliBomby	139a1d7e6d	fix legacy encoder writing sample info while not writing node samples	2023-04-30 17:46:47 +02:00
Bartłomiej Dach	7cedbca9be	Merge branch 'master' into multiplier-doesnt-update-with-preset-mod	2023-04-30 17:36:00 +02:00
Bartłomiej Dach	2e3daf0a54	Fix leak of ModSettingChangeTracker instances ... The `SelectedMods.BindValueChanged()` callback in `ModSelectOverlay` can in some instances run recursively. This is most heavily leaned on in scenarios where `SelectedMods` is updated by an external component. In such cases, the mod select overlay needs to replace the mod instances received externally with mod instances which it owns, so that the changes made on the overlay can propagate outwards. This in particular means that prior to this commit, it was possible to encounter the following scenario: modSettingChangeTracker?.Dispose(); updateFromExternalSelection(); // mutates SelectedMods to perform the replacement // therefore causing a recursive call modSettingChangeTracker?.Dispose(); // inner call continues modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value); // outer call continues modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value); This leaks one `modSettingChangeTracker` instance from the inner call, which is never disposed. To avoid this, move the disposal to the same side of the recursion that the creation happens on, changing the call pattern to: updateFromExternalSelection(); // mutates SelectedMods to perform the replacement // therefore causing a recursive call modSettingChangeTracker?.Dispose(); // inner call continues modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value); modSettingChangeTracker?.Dispose(); // outer call continues modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value); which, while slightly wasteful, does not cause any leaks. The solution is definitely suboptimal, but addressing this properly would entail a major rewrite of the mod instance management in the mods overlay, which is probably not the wisest move to make right now.	2023-04-30 17:31:41 +02:00
Terochi	fb4b681cc5	Use Queue instead of Stack	2023-04-30 16:36:01 +02:00
Terochi	8f02bd80f9	Addressed changes	2023-04-30 16:11:52 +02:00
Terochi	949dc1c0f9	Improved logic	2023-04-30 12:05:55 +02:00
Dean Herbert	b39a9d816e	Add basic structural requirements for cursor ripples	2023-04-30 14:48:03 +09:00
Terochi	8ec2154965	Fixed ApplyStateChange to happen in correct order	2023-04-30 02:01:18 +02:00
OliBomby	83111223e0	fix null sample	2023-04-30 01:08:52 +02:00
OliBomby	92efd04f31	fix sample of drumroll ticks being bankless	2023-04-29 23:52:24 +02:00
OliBomby	ffcc8e91b2	fix legacy parser incorrectly assigning sample info for sliders	2023-04-29 23:51:49 +02:00
Terochi	17e4b75dfd	Save first state when editing	2023-04-29 20:54:19 +02:00
Terochi	3b0ba4b38b	Improved logic for ApplyStateChange for skin editor	2023-04-29 19:52:22 +02:00
Bartłomiej Dach	646d4965b9	Merge branch 'master' into fix-exclusive-fullscreen-detection	2023-04-29 14:39:34 +02:00
Dean Herbert	119687cf6e	Merge pull request #23329 from rltn/clickable-country-name-in-profile ... Clickable country name in profile	2023-04-29 14:19:13 +09:00
Cootz	607a04ae73	Fix the issue	2023-04-29 10:29:33 +09:00
_ltn	2d6c0d2900	use of Child instead of Children	2023-04-28 19:24:07 +03:00
OliBomby	f7c84030ac	remove bank default value	2023-04-28 17:22:34 +02:00
Dean Herbert	6929be49b7	Change condition for exclusive fullscreen notice to only show when using the correct renderer ... This avoids the notice showing when running on windows, but using the newer renderers (where the underlying logic hasn't been tested properly and can result in false-positives). Supersedes https://github.com/ppy/osu-framework/pull/5759 as a more correct implementation.	2023-04-28 22:36:30 +09:00
Ethan	ae85e2a3ff	Update LoginForm.cs	2023-04-28 19:51:10 +08:00
_ltn	4b0ee392f6	add OsuHoverContainer	2023-04-28 05:48:54 +03:00
_ltn	17730f05bc	remove UpdateableCountryText	2023-04-28 05:47:05 +03:00
_ltn	4d144cd5b5	clearing the code	2023-04-28 02:06:13 +03:00
_ltn	092377fdaa	moving UpdateableCountryText	2023-04-28 01:47:14 +03:00
_ltn	e9843f2066	replace country text object	2023-04-28 01:16:50 +03:00
_ltn	b13201fb79	UpdateableCountryText rewrite	2023-04-28 01:14:42 +03:00
_ltn	f5c652325a	Create UpdateableCountryText.cs	2023-04-27 23:44:18 +03:00
Cootz	b795e8ac5a	Use ModSearch in ModeSelectOverlay	2023-04-27 17:26:35 +03:00
Cootz	3c6141f233	Add ModSearch	2023-04-27 17:08:29 +03:00
Bartłomiej Dach	07efa7d660	Merge branch 'master' into fix-storyboard-loop-end-time	2023-04-26 21:53:26 +02:00
OliBomby	354cd23874	removed all usage of hitobject's DifficultyControlPoint	2023-04-26 18:17:02 +02:00
OliBomby	c44f71a737	remove all regular usage of DifficultyControlPoint	2023-04-26 17:55:38 +02:00
OliBomby	1b4f4372d5	fixed sample control point applying	2023-04-26 14:32:12 +02:00
OliBomby	5accb05f45	fix invalidoperation exception	2023-04-26 14:28:48 +02:00
OliBomby	c6fc180659	remove all test usages of SampleControlPoint	2023-04-26 14:21:52 +02:00
OliBomby	87ca0f5335	Update SamplePointPiece.cs	2023-04-26 13:45:58 +02:00
OliBomby	6c70948681	Remove IContext & add IHasGenerateTicks	2023-04-26 13:10:57 +02:00
OliBomby	e27c4dfa10	Invoke ApplyDefaultsToSelf	2023-04-26 11:46:05 +02:00
Terochi	332c199dc2	further simplification	2023-04-26 10:46:29 +02:00
cdwcgt	bfd81b77fa	provide more Accuracy Mode for ModAccuracyChallenge	2023-04-26 17:40:25 +09:00
Dean Herbert	61b62b35f5	Merge pull request #18626 from ggliv/decouple-mod-fails ... Allow ModFailCondition to arbitrarily trigger failures	2023-04-26 16:19:42 +09:00
Dean Herbert	27f81288ef	Merge branch 'master' into keep-shared-settings-ruleset-change	2023-04-26 15:51:31 +09:00
Dean Herbert	cb7b246e33	Fix naming and update in line with nullability	2023-04-26 15:27:58 +09:00
Dean Herbert	210c5e7c53	Merge branch 'master' into decouple-mod-fails	2023-04-26 15:26:20 +09:00
Dean Herbert	6a3b587374	Merge pull request #23260 from Haspamelodica/master ... Fix some videos with uppercase file extensions not displaying correctly in-game	2023-04-26 14:29:25 +09:00
Dean Herbert	1efc78c0f8	Actually use new end time property when setting lifetimes	2023-04-26 13:28:51 +09:00
Terochi	8e297dc60a	Added safety measures for invalid mod combinations	2023-04-25 21:28:03 +02:00
Bartłomiej Dach	5ec8ecb11b	Merge pull request #23309 from peppy/key-counters-fix ... Fix key counters counting during break time	2023-04-25 21:15:12 +02:00
Terochi	0841e73a39	Improved readability and sounds	2023-04-25 21:07:17 +02:00
OliBomby	e4b64bdc3e	clean up code stuff	2023-04-25 19:06:29 +02:00
OliBomby	755ad25dbe	clean code	2023-04-25 18:27:20 +02:00
OliBomby	66eda40cdf	fix implementations of IHasSliderVelocity	2023-04-25 18:22:22 +02:00
OliBomby	c23a7b014e	add missing }	2023-04-25 18:17:07 +02:00
OliBomby	065464d90c	Fixed DifficultyPointPiece	2023-04-25 18:12:53 +02:00
Daniel Kirschten	54e8aa8fe9	Merge branch 'master' into master	2023-04-25 16:04:02 +02:00
OliBomby	ebe1d852f5	remove other usages of hitobject SampleControlPoint	2023-04-25 16:01:43 +02:00
OliBomby	a634617157	Fix file header notice	2023-04-25 16:01:06 +02:00
OliBomby	c37875bee8	remove hitobject SampleControlPoint usage from LegacyBeatmapEncoder	2023-04-25 16:00:40 +02:00
Dean Herbert	14af2063e5	Merge pull request #23247 from peppy/round-editor-rotation ... Always round editor rotation to integer values	2023-04-25 21:43:44 +09:00
Dean Herbert	e08d7daffd	Don't show decimal point in tooltip	2023-04-25 21:43:14 +09:00
Dean Herbert	6b4032e34b	Add missing binding of IsCounting with contained counters	2023-04-25 21:37:19 +09:00
Dean Herbert	0a861ffcee	Restructure key counters to use a common flow	2023-04-25 21:37:19 +09:00
Dean Herbert	7630958633	Stop using Drawable.Name to convey actual UI information	2023-04-25 20:24:36 +09:00
Dean Herbert	dd2c289ce9	Remove pointless default value	2023-04-25 20:22:12 +09:00
OliBomby	97910d6be6	remove unused directives	2023-04-25 13:06:37 +02:00
OliBomby	bf1951fc38	Fix incorrect xmldoc	2023-04-25 12:54:45 +02:00
Dean Herbert	d8b4db3a13	Merge branch 'master' into gameplay/argon-key-counter_le-retour	2023-04-25 19:54:31 +09:00
OliBomby	891b87a5ff	remove ApplyLegacyInfo method	2023-04-25 12:52:21 +02:00
OliBomby	ea1e6e9798	Add LegacyContext	2023-04-25 12:12:46 +02:00
OliBomby	a4c6850ab2	made the SampleControlPoint and DifficultyControlPoint obsolete	2023-04-25 11:34:09 +02:00
Dean Herbert	e330052852	Add second definition of EndTime for storyboard elements to account for loops in lifetime	2023-04-25 15:22:11 +09:00
Dean Herbert	3919400be2	Apply NRT to some storyboard classes	2023-04-25 14:30:01 +09:00
Renzo Poggio	0991c56e1c	Add extra check in 'SelectPreviousRandom' ... Check if the poped beatmap exists within the beatmapSets	2023-04-25 00:05:15 -03:00
Hy0tic	80301f0fc9	Merge https://github.com/Hy0tic/osu	2023-04-22 13:32:41 -04:00
Hy0tic	56ab029a58	fix issue where multipler does not update when adjusting speed for preset mod	2023-04-22 13:30:08 -04:00
Daniel Kirschten	6c9a90d1ec	Merge branch 'master' into master	2023-04-22 19:23:52 +02:00
Haspamelodica	e90660c1a4	Switched to lowercase	2023-04-21 02:35:28 +02:00
Haspamelodica	b62de5514c	Fixed video importing bug #23259	2023-04-21 02:10:24 +02:00
Dean Herbert	1066dfcbf6	Change default beat divisor to 4 ... This matches stable, and is a much saner default value. Will apply to new beatmaps and also beatmaps which don't specify a snap value in the `.osu` file.	2023-04-20 14:35:13 +09:00
Dean Herbert	9f4b1f0f24	Always round editor rotation to integer values	2023-04-20 14:30:01 +09:00
Joseph Madamba	776c4cfaad	Ensure selected field is correct in updateSelectionState() ... Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-04-19 18:34:35 -07:00
Dean Herbert	01260e5f54	Merge branch 'master' into shader-cache-stages	2023-04-19 20:47:34 +09:00
Dean Herbert	760ef10145	Update framework	2023-04-19 00:04:21 +09:00
Dean Herbert	ee5658c15a	Merge pull request #23222 from peppy/update-framework-resources ... Update framework and resources	2023-04-18 14:10:42 +09:00
Dean Herbert	26a2d1fdea	Merge pull request #23000 from Joehuu/fix-beatmap-terminology ... Fix song select matching label not using right terminology	2023-04-18 13:53:05 +09:00
Joseph Madamba	c80a25328d	Shorten label to just "matches"	2023-04-17 20:59:41 -07:00
Joseph Madamba	16df92f405	Fix sets not being plural	2023-04-17 20:59:02 -07:00
Dan Balasescu	c0a25144cf	Apply changes to custom ShaderManager	2023-04-18 11:31:56 +09:00
Dean Herbert	c3f3b8db7c	Update resources	2023-04-17 23:09:46 +09:00
Dean Herbert	fbb15fff26	Update framework	2023-04-17 23:03:16 +09:00
Dean Herbert	7aeab174eb	Merge pull request #23185 from bdach/nested-result-revert ... Invoke `RevertResult` on parent DHO when nested DHO is reverted	2023-04-12 23:08:10 +09:00
Bartłomiej Dach	e72f103c17	Do not look up metadata for locally-modified beatmaps on save	2023-04-11 23:14:35 +02:00
Bartłomiej Dach	db86ced4b4	Invoke RevertResult on parent DHO when nested DHO is reverted ... The behaviour described above was removed in 812a4b412a, thus henceforth contradicting `RevertResult`'s xmldoc. As it is relied on by some external rulesets, bring it back to unbreak them.	2023-04-11 18:29:08 +02:00
Joseph Madamba	d0cbe206a9	Revert back to one number with "matching beatmap difficulties" label	2023-04-10 23:37:29 -07:00
Joseph Madamba	f0c8a3202b	Merge remote-tracking branch 'upstream/master' into fix-beatmap-terminology	2023-04-10 23:22:15 -07:00
Dean Herbert	52bb7891f7	Merge branch 'master' into fix-count-not-updating-when-deleting	2023-04-11 09:04:02 +09:00
Joseph Madamba	f80de08f24	Adjust BeatmapSetsChanged xmldoc ... Co-Authored-By: Dean Herbert <pe@ppy.sh>	2023-04-10 11:28:23 -07:00
Joseph Madamba	c7dea71793	Use existing BeatmapSetsChanged action	2023-04-10 11:26:18 -07:00
Dean Herbert	8757276c37	Merge pull request #23156 from Micha-ohne-el/editor-selection-rotation-snapping ... Add rotation snapping to editor selection	2023-04-11 00:45:44 +09:00
Dean Herbert	52c4703261	Merge pull request #23103 from Joehuu/normalise-overlay-padding ... Normalise horizontal padding on overlays	2023-04-10 23:48:59 +09:00
Bartłomiej Dach	1f2c96c8e8	Merge branch 'master' into gd-onlinesetoverlay	2023-04-10 15:35:03 +02:00
Bartłomiej Dach	11fd93a2ba	Inline disturbing getGuestMapper() method ... Disturbing because name suggests pure method, but it is in fact `void` and also performs side effects by about the most confusing means possible.	2023-04-10 15:20:43 +02:00
Bartłomiej Dach	73bd0feef5	Fix incorrectly implemented localisation	2023-04-10 15:03:33 +02:00
Bartłomiej Dach	6fec476147	Simplify snap implementation	2023-04-10 14:55:30 +02:00
Bartłomiej Dach	ead5e9f027	Merge branch 'master' into editor-inspector	2023-04-10 14:29:05 +02:00
Bartłomiej Dach	60358c7203	Perform first inspector text update immediately ... Provides better and more consistent initial state for the inspector.	2023-04-10 14:13:53 +02:00
Bartłomiej Dach	641415ca32	Unify displayed duration format for single/multiple selection	2023-04-10 14:05:32 +02:00
Joseph Madamba	7f5b99c91b	Fix song select beatmap difficulty count not updating when deleting	2023-04-09 22:12:51 -07:00
Dan Balasescu	15f6bc155e	Add progressive score multiplier for HT	2023-04-10 13:35:48 +09:00
Dan Balasescu	c923482976	Add progressive score multiplier for DT	2023-04-10 13:31:48 +09:00
cdwcgt	dd69089117	code quality	2023-04-09 15:51:31 +09:00
cdwcgt	5d64c1b7bf	exception handling	2023-04-09 15:09:18 +09:00
cdwcgt	ce6a87b4a3	Merge remote-tracking branch 'upstream/master' into export	2023-04-09 15:02:47 +09:00
cdwcgt	fc55b96e77	remove CompletionText in Constructor ... this will never used Co-Authored-By: Dean Herbert <pe@ppy.sh>	2023-04-09 14:27:42 +09:00
cdwcgt	49193a2bdd	CompletionText ... Co-Authored-By: Dean Herbert <pe@ppy.sh>	2023-04-09 22:25:47 +09:00
cdwcgt	de21b4a2f7	use Live<TModel> ... Use RealmAccess only when needed	2023-04-09 22:21:15 +09:00
cdwcgt	1f4da35c8d	notification nullable fix	2023-04-09 22:13:53 +09:00
cdwcgt	13b522e825	repair usage of CancellationToken ... Co-Authored-By: n0099 <n@n0099.net>	2023-04-09 22:09:53 +09:00
Dean Herbert	8d2e852ffd	Fix overbearing key down handling	2023-04-08 22:30:36 +09:00
Dean Herbert	a1fc4def1d	Remove redundant method override	2023-04-08 22:18:07 +09:00
Micha Lehmann	3c4a25e53f	Fix tooltip text not resetting when ending an editor rotation	2023-04-08 14:28:52 +02:00
Micha Lehmann	580d5745c0	Add "(snapped)" to the tooltip when snap-rotating in the editor	2023-04-08 14:15:49 +02:00
Joseph Madamba	a86a968fac	Use public BeatmapSet to match other usages	2023-04-07 21:16:36 -07:00
Joseph Madamba	ed208ef127	Fix more typos and adjust font size to match web	2023-04-07 21:10:37 -07:00
Dean Herbert	f72dd86b42	Fix code quality issues and avoid updating bindable twice per operation	2023-04-08 10:40:36 +09:00
Micha Lehmann	c827c2810b	Improve editor selection rotation value wrapping ... This fixes two issues the previous algorithm had: 1. A half-turn rotation used to show up as -180°. 2. Rotating more than 180° in one drag event would overwhelm it and cause the value to go outside its range. This comes at the cost of a negligible performance hit, since a division (modulo) is performed instead of just addition/subtraction.	2023-04-08 01:30:29 +02:00
Micha Lehmann	f1de560d57	Snap editor selection rotation when holding shift	2023-04-08 01:30:29 +02:00
Dean Herbert	0c71fa1bbd	Merge branch 'master' into gameplay/argon-key-counter_le-retour	2023-04-06 23:39:57 +09:00
Dean Herbert	ad717d2368	Fix scheduled calls piling up during transactions	2023-04-06 23:39:36 +09:00
Andrei Zavatski	ed565b1e59	Fix SampleStore isn't being disposed	2023-04-06 11:40:04 +03:00
Dean Herbert	e6872629f3	Merge pull request #22868 from peppy/no-epilepsy-warning-storyboard-disable ... Don't show epilepsy warning when storyboards are disabled	2023-04-06 12:32:38 +09:00
tsrk	809b817e8e	Merge branch 'master' into gameplay/argon-key-counter_le-retour	2023-04-05 22:57:36 +02:00
Bartłomiej Dach	ba753a8aac	Merge branch 'master' into update-skinnable-sound-before-playing	2023-04-05 22:56:25 +02:00
Bartłomiej Dach	27055919a3	Merge branch 'master' into fix-old-beatmap-crash-on-load	2023-04-05 21:39:42 +02:00
Bartłomiej Dach	6df7614b9d	Add tests for suppressing epilepsy warning when storyboard disabled	2023-04-05 20:56:50 +02:00
Bartłomiej Dach	e5d57a65c9	Fix incorrect indent	2023-04-05 19:47:25 +02:00
Bartłomiej Dach	432f698697	Merge branch 'master' into gameplay/key-counter-abstraction	2023-04-05 19:45:14 +02:00
Dean Herbert	9c8b25e034	Fix display not always updating when expected by updating on a schedule	2023-04-05 13:45:24 +09:00
Dean Herbert	f07d859532	Optimise how often we update the display	2023-04-04 19:31:33 +09:00
Dean Herbert	3209b09270	Move inspector into own file	2023-04-04 19:17:34 +09:00
Dean Herbert	4aed483005	Tidy up dependency resolution	2023-04-04 19:14:30 +09:00
Dean Herbert	195b5fc3f1	Add view for selections of size != 1	2023-04-04 19:11:48 +09:00
Dean Herbert	b0d5761667	Add object type	2023-04-04 19:05:50 +09:00
Dean Herbert	c356c163fa	Add hit object inspector view	2023-04-04 19:03:45 +09:00
Dean Herbert	f9ebdadfe8	Move right-side editor toolbox to base HitObjectComposer ... Move right-side editor toolbox to base `HitObjectComposer`	2023-04-04 19:00:56 +09:00
Bartłomiej Dach	1a5707b65f	Merge pull request #22878 from peppy/fix-replay-fail-on-exit ... Ensure replays don't enter a failed state when exiting gameplay	2023-04-03 22:38:32 +02:00
Bartłomiej Dach	8cc425774b	Merge branch 'master' into fix-replay-fail-on-exit	2023-04-03 21:23:23 +02:00
Bartłomiej Dach	7dfd903b76	Merge branch 'master' into fix-debug-perf-drd	2023-04-03 21:04:18 +02:00
Bartłomiej Dach	b5d9284de2	Merge pull request #23108 from peppy/fix-overlay-toggles-during-disclaimer ... Fix attempting to show overlay during game intro playing hide sound effects	2023-04-03 20:48:03 +02:00
cdwcgt	9dd30e4b4c	condition fix	2023-04-03 20:24:38 +09:00
cdwcgt	735b48679e	use LinkFlowContainer directly	2023-04-03 20:09:49 +09:00
cdwcgt	41c01d3929	nullable condition	2023-04-03 20:07:21 +09:00
cdwcgt	51240ed46b	typo	2023-04-03 19:51:22 +09:00
Dean Herbert	7011928d86	Fix abysmal debug performance due to try-catch logic in DrawableRulesetDependencies	2023-04-03 18:04:33 +09:00
Dean Herbert	b0c09df259	Merge branch 'master' into gameplay/key-counter-abstraction	2023-04-03 15:33:35 +09:00
Dean Herbert	43d7386623	Merge pull request #22926 from Joehuu/fix-sort-direction-not-resetting ... Fix beatmap listing sort direction not resetting when changing criteria	2023-04-03 15:32:10 +09:00
Dean Herbert	e4eb736622	Merge pull request #22929 from Joehuu/fix-loading-blocking-overlay-headers ... Fix beatmap listing filter control being blocked by loading layer	2023-04-03 15:29:38 +09:00
Dean Herbert	a097433cb1	Fix overlay toggle keys working during disabled activation modes ... Closes #23104.	2023-04-03 15:03:47 +09:00
Joseph Madamba	247d426c8a	Add horizontal padding to currently playing search textbox	2023-04-02 20:50:18 -07:00
Joseph Madamba	436f1e4ae4	Replace other hardcoded horizontal padding with const ... - Also add overlay stream item padding const and account for it	2023-04-02 20:50:18 -07:00
Joseph Madamba	af389b1107	Replace all hardcoded 50 horizontal padding with const	2023-04-02 20:50:18 -07:00
Joseph Madamba	7a0edabd5d	Normalise overlay horizontal padding const	2023-04-02 20:24:13 -07:00
Dean Herbert	daf9f19b29	Merge pull request #23098 from Joehuu/update-vote-pill-hover ... Update comment vote pill in line with web	2023-04-03 12:01:46 +09:00
Dean Herbert	8932668f77	Update framework	2023-04-03 10:31:47 +09:00
Joseph Madamba	63ea17f10e	Update comment vote pill in line with web	2023-04-02 18:17:40 -07:00
Susko3	c3a6a58169	Fix window mode dropdown not showing	2023-04-02 19:23:18 +02:00
Dean Herbert	1e0b64c9e8	Update framework (again)	2023-04-02 23:07:40 +09:00
cdwcgt	d949ef3ca4	make guestMapperContainer private ... tests don't use it	2023-04-02 22:53:15 +09:00
cdwcgt	2cf8636366	show guest diff author in BeatmapPicker	2023-04-02 22:25:58 +09:00
Dean Herbert	4c2b7e7788	Fix random inspection showing up only in CI	2023-04-02 21:05:20 +09:00
Dean Herbert	cf5acbf66e	Update usage of SupportedWindowModes	2023-04-02 20:16:14 +09:00
Dean Herbert	0f0dd9f2dc	Update resources	2023-04-02 20:07:33 +09:00
Dean Herbert	7f9bf09e03	Update framework	2023-04-02 20:07:31 +09:00
Dean Herbert	4b294278d6	Merge branch 'master' into fix-ruleset-shader-caching	2023-03-31 20:04:55 +09:00
Dean Herbert	1277c8eb5a	Merge branch 'master' into debug-use-en-localisation-fallbacks	2023-03-31 17:26:56 +09:00
Dan Balasescu	4b7d44c329	Remove unused using	2023-03-31 16:23:56 +09:00
Dan Balasescu	28f31ef379	Adjust comment slightly	2023-03-31 16:23:37 +09:00
Dan Balasescu	d5b8a45541	Always use fallback strings for English ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-03-31 16:20:16 +09:00
Bartłomiej Dach	bfbb5ab96b	Merge branch 'master' into fix-fail-progression-to-results	2023-03-30 21:40:49 +02:00
Dean Herbert	796cd9c916	Rewrite comment explaining early return on checkScoreCompleted given new usages	2023-03-31 02:36:17 +09:00
Dean Herbert	b25a59fd14	Rename scoreCompleted -> checkScoreCompleted to reflect the fact it doesn't always succeed	2023-03-31 02:30:04 +09:00
cdwcgt	5d395e6d37	move to ctor	2023-03-29 22:59:54 +09:00
cdwcgt	19b7036b95	use same same duration ... negligence in migrating code	2023-03-29 22:56:35 +09:00
cdwcgt	e85c28031e	change weird name	2023-03-29 22:55:25 +09:00
Dean Herbert	72c5c9848f	Always use LocalisableString fallbacks when deploying debug and viewing english ... This allows changes to `xxxStrings.cs` files to immediately reflect in the UI, which is (at least for me) an expectation.	2023-03-29 14:44:43 +09:00
Dean Herbert	c7003434b2	Fix localisation for audio device error containing incorrect newline escaping	2023-03-29 14:33:10 +09:00
Dean Herbert	4dd0c2c7a5	Add assert ensuring we don't ever get to the results screen with an F rank ... Intentionally an assertion as I want tests to fail, but I don't want this to cause crashes for an end user if it does happen to occur.	2023-03-29 14:11:58 +09:00
Dean Herbert	a8bb2e33ac	Ensure all preconditions are checked before progressing to results screen after storyboard ends	2023-03-29 14:00:11 +09:00
Dean Herbert	aad540629f	Remove duplicate load rule from ShaderPrecompiler	2023-03-29 12:36:56 +09:00
cdwcgt	46ede27869	add feature to adjust ScalingContainer background dim	2023-03-28 22:41:24 +09:00
cdwcgt	31df626f0e	disable button when select other reason	2023-03-28 21:32:28 +09:00
cdwcgt	899860dd77	Merge branch 'master' into chat-report	2023-03-28 21:14:11 +09:00
Dean Herbert	8c1df3c8d9	Fix web account registration not bypassing the URL warning	2023-03-28 15:38:19 +09:00
Dean Herbert	0d77ec013a	Fix ruleset-local shader manager not correctly falling back to existing cached shaders	2023-03-28 15:00:49 +09:00
Dean Herbert	5dfac02b11	Preload triangle shader on startup	2023-03-28 14:15:38 +09:00
Dean Herbert	c742b3f0a8	Update DrawableRulesetDependencies xmldoc to read more correctly	2023-03-28 14:15:19 +09:00
cdwcgt	b065689cf8	Limit the area of popover to DrawableChannel ... popover may be blocked by textBar	2023-03-27 23:04:45 +09:00
Joseph Madamba	8b30c67580	Fix incorrect song select matching label by showing both beatmap and difficulty count for less ambiguity	2023-03-26 18:08:28 -07:00
Joseph Madamba	76a6f97fbb	Fix wrong definition of a beatmap in first run setup	2023-03-26 17:32:03 -07:00
Joseph Madamba	3e0bbb2432	Fix select beatmap button not highlighting when creating a multiplayer room using keyboard	2023-03-26 16:03:21 -07:00
Dean Herbert	6924dc5c50	Update framework	2023-03-27 02:16:33 +09:00
Dean Herbert	898717231b	Hide vulkan renderer option for now ... We'll bring it back when it's more stable.	2023-03-27 02:00:10 +09:00
Bartłomiej Dach	292486c25a	Use more resilient restore method	2023-03-26 14:35:00 +02:00
Bartłomiej Dach	f3c174a7f2	Fix test errors due to missing dependencies	2023-03-26 13:52:26 +02:00
Dean Herbert	bab93bed17	Fix string interpolation and use GetDescription on renderer value	2023-03-26 20:43:28 +09:00
Dean Herbert	ba078e8357	Show "automatic" resolved renderer inline in dropdown instead	2023-03-26 20:29:30 +09:00
Dean Herbert	764361b3d3	Add special case to hide definitely non-working renderers on android	2023-03-26 20:14:33 +09:00
Dean Herbert	e346b02ebf	Add display of current renderer	2023-03-26 20:09:35 +09:00
Dean Herbert	91da546ba2	Merge branch 'master' into add-renderer-selection	2023-03-26 19:33:15 +09:00
Dean Herbert	c803eb8e04	Update framework	2023-03-26 16:14:15 +09:00
Dean Herbert	d31b37e87e	Merge branch 'master' into fix-ubo-not-bound	2023-03-26 16:14:11 +09:00
Joseph Madamba	eaef5ff2a3	Fix now playing playlist not highlighting selected item on initial open	2023-03-25 22:13:51 -07:00
Joseph Madamba	e1906a90eb	Use image@2x from tournament banner api	2023-03-25 13:08:46 -07:00
Joseph Madamba	450c5cef07	Add comment explaining loading container padding	2023-03-24 18:42:34 -07:00
Terochi	e6f1ec57a9	Bring back and make use of clearPreviousSamples()	2023-03-23 18:46:48 +01:00
Dean Herbert	ab6cfea5c7	Revert old value instead of always using default ... Co-authored-by: cdwcgt <loginchen@outlook.com>	2023-03-23 11:27:05 +09:00
cdwcgt	26f2d9047d	code style fix	2023-03-23 01:11:44 +09:00
cdwcgt	85a924f078	why ... merge problem?	2023-03-23 01:02:17 +09:00
cdwcgt	8518d15b8d	use endpoint	2023-03-23 01:00:38 +09:00