2598 Commits

Author	SHA1	Message	Date
Dean Herbert	f3b24b9bb5	Avoid performing eager selection constantly on adding ranges of new children	2020-10-13 17:37:33 +09:00
Dean Herbert	0a978c6131	Add basic pooling setup	2020-10-13 17:37:33 +09:00
Dean Herbert	f17d661c1a	Add basic range-based invalidation	2020-10-13 17:37:33 +09:00
Dean Herbert	3143224e5b	Refactor how drawable carousel items are constructed	2020-10-13 17:37:33 +09:00
Dean Herbert	9193f5b0ba	Expose panel height from non-drawable models	2020-10-13 17:37:33 +09:00
Dean Herbert	a393bbe8f7	Remove direct drawable storage from carousel models	2020-10-13 17:37:33 +09:00
Dean Herbert	73c238fae3	Add the ability to search for local beatmaps via online IDs ... Closes #10470.	2020-10-10 21:34:11 +09:00
Joehu	c6386ea605	Remember leaderboard mods filter selection in song select	2020-09-15 21:53:35 -07:00
Dean Herbert	3c70b3127c	Fix potential nullref in FilterControl during asynchronous load	2020-09-15 23:19:31 +09:00
Dan Balasescu	6cbff98295	Merge branch 'master' into add-collections-to-beatmap-options	2020-09-15 15:23:33 +09:00
Dean Herbert	2c7492d717	Add null check in SongSelect disposal for safety	2020-09-15 14:34:58 +09:00
Joehu	43daabc982	Remove unused using and move dialog to BDL	2020-09-14 12:10:00 -07:00
Joehu	c833f5fcc4	Reorder buttons to match stable	2020-09-14 11:23:41 -07:00
Joehu	57610ddad5	Fix beatmap options absorbing input from toolbar ruleset selector	2020-09-14 11:22:16 -07:00
Joehu	c30174cea3	Add manage collections button to beatmap options	2020-09-14 11:21:23 -07:00
Joehu	1a8a7ae7f8	Remove hardcoded key param from AddButton	2020-09-14 11:19:18 -07:00
Joehu	368aca015a	Move override methods to bottom	2020-09-14 11:18:00 -07:00
Bartłomiej Dach	a377cccb4d	Unsubscribe from track changed event on disposal	2020-09-14 17:10:35 +02:00
Bartłomiej Dach	f17b2f1359	Ensure track is looping in song select immediately	2020-09-12 20:43:17 +02:00
smoogipoo	5b80a7db5f	Re-namespace collections dropdown	2020-09-11 16:01:01 +09:00
Dean Herbert	033bd82953	Merge branch 'master' into fix-filtercontrol-order	2020-09-11 13:07:41 +09:00
Dean Herbert	b594a2a507	Import collections on initial import-from-stable step	2020-09-11 11:16:00 +09:00
smoogipoo	314cd13b74	Fix song select filter ordering	2020-09-10 23:36:22 +09:00
Dean Herbert	18d96738a1	Fix hard crash on deleting a collection with no collection selected	2020-09-10 19:52:34 +09:00
smoogipoo	6b56c6e83f	Rename to CollectionMenuItem	2020-09-09 23:11:19 +09:00
smoogipoo	43525614ad	Store raw BeatmapCollection in filter control	2020-09-09 23:10:21 +09:00
smoogipoo	1a023d2c88	Fix a few more tests	2020-09-09 16:33:48 +09:00
smoogipoo	0360f7d845	Move CollectionManager to OsuGame	2020-09-09 15:39:15 +09:00
smoogipoo	4ddf5f054b	Rename BeatmapCollectionManager -> CollectionManager	2020-09-09 15:31:08 +09:00
smoogipoo	a5e1e8d043	Rename More... to Manage...	2020-09-08 18:57:18 +09:00
smoogipoo	ae022d7559	Show all items in dropdown, set global max height	2020-09-08 18:55:53 +09:00
smoogipoo	4962213cc4	Rename manage collections filter/text	2020-09-08 18:42:55 +09:00
smoogipoo	f581df47c8	Add "New collection..." item to dropdown	2020-09-08 18:25:09 +09:00
smoogipoo	c2da3d9c84	Fix button input and tests	2020-09-08 14:36:38 +09:00
smoogipoo	8a3c8a6185	Show button when selected or preselected	2020-09-08 14:03:49 +09:00
smoogipoo	32e3f5d091	Adjust button styling	2020-09-08 13:45:26 +09:00
Dean Herbert	8b770626fa	Add missing '...' from some popup menu items	2020-09-08 12:18:08 +09:00
Dean Herbert	b15bbc882a	Move items up in menu	2020-09-08 12:04:35 +09:00
Dean Herbert	3e5ea6c42f	Change "Add to" to "Collections" ... Doesn't make send to be 'add to' when it can also remove	2020-09-08 12:00:00 +09:00
smoogipoo	ca4423af74	Fix tests	2020-09-08 00:07:12 +09:00
smoogipoo	e37c04cb6d	Change back to solid icon	2020-09-08 00:04:03 +09:00
smoogipoo	a1214512bc	Add filter control tests	2020-09-07 23:57:49 +09:00
smoogipoo	98e9c4dc25	General refactorings	2020-09-07 21:08:48 +09:00
smoogipoo	c1d255a04c	Split filter control into separate class	2020-09-07 20:44:39 +09:00
smoogipoo	120dfd50a6	Fix collection names not updating in dropdown	2020-09-07 20:29:28 +09:00
smoogipoo	b91a376f0a	Split dropdown into separate file	2020-09-07 20:06:38 +09:00
smoogipoo	6cc4517600	Merge branch 'master' into collection-database	2020-09-07 20:03:11 +09:00
smoogipoo	4b4dd02942	Make collection name a bindable	2020-09-05 04:43:59 +09:00
smoogipoo	345fb9d8e0	Rename classes	2020-09-05 03:55:43 +09:00
smoogipoo	ebd11ae0b7	Add a collection management dialog	2020-09-05 03:52:07 +09:00
Dan Balasescu	743c888986	Merge branch 'master' into expose-wedge-icons	2020-09-04 16:22:14 +09:00
Dan Balasescu	b631430a5b	Merge pull request #10045 from peppy/add-info-wedge-icons ... Update and add missing beatmap statistic icons to info wedge	2020-09-04 16:22:01 +09:00
smoogipoo	4399f5976c	Fix global mods being retained by rooms	2020-09-04 15:20:55 +09:00
Dean Herbert	25e142965d	Strongly type and expose default beatmap information icon implementations for other rulesets	2020-09-04 15:01:32 +09:00
Dean Herbert	cd253ab055	Further tweaks to get closer to design originals	2020-09-04 13:05:39 +09:00
Dean Herbert	d6b46936a0	Adjust sizing to match updated textures with less padding	2020-09-04 12:55:28 +09:00
Dean Herbert	a99e7a1dc2	Merge branch 'master' into add-info-wedge-icons	2020-09-03 21:57:58 +09:00
Dean Herbert	7a0c1411b6	Merge branch 'master' into timeshift-leaderboard-topscore	2020-09-03 18:11:04 +09:00
Dean Herbert	72cb65c22f	Update and add missing beatmap statistic icons to info wedge	2020-09-03 17:52:22 +09:00
smoogipoo	fca0324264	Disallow being able to add dummy beatmap	2020-09-02 23:34:38 +09:00
smoogipoo	d83264f538	Add max height	2020-09-02 22:56:13 +09:00
smoogipoo	7fcbc3a814	Respond to changes in beatmap	2020-09-02 22:06:17 +09:00
smoogipoo	661eac8f1d	Add add/remove button to dropdown items	2020-09-02 22:03:38 +09:00
smoogipoo	02a908752f	Fix stackoverflow	2020-09-02 21:52:56 +09:00
smoogipoo	5ebead2bfd	Prevent ValueChanged binds to external bindable	2020-09-02 21:44:07 +09:00
smoogipoo	d363a5d164	Add basic ordering	2020-09-02 21:19:15 +09:00
smoogipoo	094ddecc95	Add dropdowns to carousel items	2020-09-02 21:08:31 +09:00
smoogipoo	6d5e155106	Change to BindableList to notify of changes	2020-09-02 20:44:26 +09:00
smoogipoo	9dde37fe40	Hook up collection filter	2020-09-02 20:25:42 +09:00
smoogipoo	bb090a55e0	Add dropdown to filter control	2020-09-02 20:25:25 +09:00
Dan Balasescu	f08e7828da	Merge branch 'master' into beatmap-track-rework	2020-09-01 16:06:38 +09:00
Bartłomiej Dach	876fd21230	Apply shear to right-anchored items	2020-08-31 19:31:47 +02:00
Bartłomiej Dach	2e2f26449d	Change anchoring to TopRight	2020-08-31 19:23:19 +02:00
smoogipoo	8cf26979fb	Allow null user score	2020-08-31 20:16:28 +09:00
smoogipoo	ed74c39b55	Move UserTopScoreContainer into base leaderboard	2020-08-31 19:54:22 +09:00
Bartłomiej Dach	7d273d631b	Do not show star difficulty on wedge if zero	2020-08-31 11:05:42 +02:00
Bartłomiej Dach	4736845318	Add spacing between star rating and beatmap status	2020-08-31 10:56:06 +02:00
smoogipoo	c3bfce6ccf	Add star rating to beatmap wedge	2020-08-31 15:03:41 +09:00
Dean Herbert	b51db90147	Merge branch 'master' into beatmap-track-rework	2020-08-26 23:20:56 +09:00
Bartłomiej Dach	29b4d98aac	Show retry/fail graph when either list is present	2020-08-24 20:41:50 +02:00
Bartłomiej Dach	cc6ae8e3bd	Fix crash if only one count list is received from API	2020-08-24 20:41:31 +02:00
Keijia	b5b2e523ad	change switch cases	2020-08-22 12:10:31 +03:00
Keijia	0b6185cd14	add "hp" filter keyword	2020-08-22 01:09:35 +03:00
Dean Herbert	e465afa280	Merge branch 'master' into beatmap-track-rework	2020-08-14 20:02:43 +09:00
smoogipoo	0500d82b5b	Fix playlist items sharing mod instances	2020-08-13 19:48:41 +09:00
smoogipoo	7d35893ecd	Make MusicController non-nullable	2020-08-11 12:40:58 +09:00
smoogipoo	f058f5e977	Fix incorrect value being set	2020-08-06 16:24:14 +09:00
smoogipoo	5c05fe3988	Expose track from MusicController	2020-08-06 16:24:14 +09:00
smoogipoo	6e42b8219c	Move track to MusicController, compiles	2020-08-06 16:24:14 +09:00
smoogipoo	877b985e90	Remove local cancellation token	2020-07-24 16:11:28 +09:00
smoogipoo	b10b99a670	Change method signatures to remove tracked/untracked	2020-07-24 13:52:43 +09:00
smoogipoo	76284a0f01	Move cancellation out of condition	2020-07-23 23:18:51 +09:00
smoogipoo	107b5ca4f2	Add support for bindable retrieval	2020-07-21 23:13:04 +09:00
smoogipoo	9a52058a7a	Update carousel beatmap SR on mod/ruleset changes	2020-07-16 21:08:24 +09:00
smoogipoo	24f14751ce	Update beatmap details SR on ruleset/mod changes	2020-07-16 21:08:08 +09:00
Joehu	73e1bf0d89	Check sub screen's OnBackButton instead	2020-07-14 13:19:48 -07:00
Joehu	36041fc245	Fix back button not working correctly with multi song select's mod select	2020-07-14 00:29:57 -07:00
Joehu	4caf4d31d4	Fix mod select blocking home and alt f4 in song select	2020-07-14 00:00:10 -07:00
Dean Herbert	0718e9e4b6	Update outdated comment	2020-07-13 13:08:41 +09:00
Dean Herbert	ab11a112b7	Fix correct filter criteria not being applied to beatmap carousel if beatmaps take too long to load	2020-07-12 22:33:41 +09:00
Dean Herbert	f231b5925f	Add "show converted" checkbox to song select for convenience	2020-07-09 13:47:23 +09:00
Dean Herbert	bbbe8d6f68	Remove group selector for now, tidy up code somewhat	2020-07-09 13:47:11 +09:00
smoogipoo	af7494b232	Improve quality of song select beatmap wedge	2020-06-29 13:58:35 +09:00
smoogipoo	099416b4c3	Move check inside next difficulty selection	2020-06-26 21:03:34 +09:00
smoogipoo	8f6d52550f	Fix potential exception if button is pressed before selection	2020-06-26 20:32:13 +09:00
smoogipoo	1b4c31a84f	Remove double schedule	2020-06-26 20:14:08 +09:00
smoogipoo	e3d654d33f	Cleanup	2020-06-26 20:14:02 +09:00
Dean Herbert	d704a4597d	Use existing helper function for key repeat	2020-06-25 21:33:02 +09:00
Dean Herbert	d7742766d0	Add key/press repeat support to carousel	2020-06-25 19:47:23 +09:00
Viktor Rosvall	9e1bf71233	Added text explaining a second copy will be made	2020-06-24 11:29:38 +02:00
Jack Boswell	eb3eb70a65	Merge branch 'master' into rebind-song-select	2020-06-10 22:03:26 +12:00
Jack Boswell (boswelja)	9dc1eab6ae	Improve code readability of FooterButtonRandom OnPressed	2020-06-10 13:05:11 +12:00
Jack Boswell (boswelja)	ea9207e0ad	Clean up FooterButtonRandom ... Removed unnecessary using statements Removed unnecessary constructor	2020-06-08 17:31:31 +12:00
Jack Boswell (boswelja)	bddd2b72ba	Remove secondaryText and related code from FooterButtonRandom	2020-06-08 15:05:53 +12:00
Jack Boswell (boswelja)	8b7718116d	Add missing blank lines	2020-06-07 16:06:18 +12:00
Jack Boswell (boswelja)	0e155c8eb9	Don't switch FooterButtonRandon Action on pressed. ... Instead, create a new Action that invokes either NextRandom or PreviousRandom, depending on rewindSearch	2020-06-07 15:34:19 +12:00
Jack Boswell (boswelja)	a40475e6aa	Remove triggerNextRandom from SongSelect	2020-06-04 21:09:47 +12:00
Jack Boswell (boswelja)	cb6e473910	Remove triggerPreviousRandom from SongSelect	2020-06-04 21:08:07 +12:00
Jack Boswell (boswelja)	cab132673a	Break FooterButtonRandom creation into multiple lines	2020-06-04 21:03:10 +12:00
Jack Boswell (boswelja)	8533d7573d	Rename FooterButtonRandom actions to better describe what they are used for	2020-06-04 21:00:29 +12:00
Jack Boswell (boswelja)	62984cb7f5	Remove unused Hotkey assignment	2020-06-04 20:58:53 +12:00
Jack Boswell (boswelja)	df148cf9d1	Rename secondaryAction to rewindSearch	2020-06-04 20:58:19 +12:00
Jack Boswell (boswelja)	bd3e40a8cf	Move default return out of switch/case	2020-06-04 20:57:24 +12:00
Jack Boswell (boswelja)	a78a8c0d0d	Add missing blank lines	2020-06-04 16:59:04 +12:00
Jack Boswell (boswelja)	7141bed78d	Remove redundant directive from FooterButton	2020-06-04 16:40:16 +12:00
Jack Boswell (boswelja)	eb242085c6	Remove redundant interface from FooterButtonMods	2020-06-04 16:24:32 +12:00
Jack Boswell (boswelja)	aeb736e9d2	Fix CodeFactor code style issues	2020-06-04 16:13:50 +12:00
Jack Boswell (boswelja)	aa08847bc9	Set FooterButtonRandom actions properly when creating the button	2020-06-04 16:08:16 +12:00
Jack Boswell (boswelja)	568503ef99	Update FooterButtonRandom to comply with the changes in FooterButton ... FooterButtonRandom now has 2 Action variables, one for both primary and secondary	2020-06-04 16:07:50 +12:00
Jack Boswell (boswelja)	05e4499bc1	Update FooterButtonOptions to comply with the changes in FooterButton	2020-06-04 15:25:18 +12:00
Jack Boswell (boswelja)	18db31b504	Update FooterButtonMods to comply with the changes in FooterButton	2020-06-04 15:25:05 +12:00
Jack Boswell (boswelja)	782fddb6f1	Modify FooterButton to implement IKeyBindingHandler for responding to hotkeys	2020-06-04 15:21:13 +12:00
smoogipoo	f3b5149648	Move some suggestions to warnings, resolve issues	2020-06-03 16:48:44 +09:00
Dean Herbert	93572fc17d	Merge branch 'master' into present-recommended	2020-06-03 12:31:23 +09:00
Lucas A	275d95082a	Fix crash in testing environment.	2020-06-02 16:01:01 +02:00
Lucas A	f63c66396f	Apply review suggestions.	2020-06-02 13:32:52 +02:00
Lucas A	e9b09373e7	Fix crashing if selected ruleset doesn't have an autoplay mod.	2020-06-01 17:41:04 +02:00
Dean Herbert	d4b7c81f96	Merge branch 'master' into results-screen-condensed-panel	2020-05-30 23:13:52 +09:00
Dean Herbert	f989f1aa00	Change event flow to avoid firing store delete events on update	2020-05-27 16:08:47 +09:00
smoogipoo	de0b6ec9f1	Create abstract implementation	2020-05-26 17:00:41 +09:00
Dean Herbert	052ad79fc6	Convert dangerous events to IBindables	2020-05-19 16:44:22 +09:00
Dean Herbert	a5c1b461f6	Fix null reference in difficulty recommender	2020-05-12 11:14:51 +09:00
smoogipoo	401c516503	Expose searchable terms from beatmap info instead	2020-05-07 13:04:08 +09:00
smoogipoo	5186da8412	Fix potential song select nullref	2020-05-07 11:37:04 +09:00
Dan Balasescu	0eae8d078b	Merge branch 'master' into master	2020-05-05 13:33:29 +09:00
alex	0e2ccac33b	Add spaces to comments	2020-05-04 18:36:24 -07:00
Dean Herbert	06f58dd3e3	Ensure correct beatmap and ruleset when presenting a score from song select	2020-05-04 15:20:43 +09:00
Endrik Tombak	1c04d58d6e	Fix recommender's incorrect usage of current ruleset	2020-05-01 19:44:35 +03:00
Bartłomiej Dach	623611d9dc	Simplify ruleset ordering	2020-05-01 17:15:35 +02:00
Bartłomiej Dach	9f091f3a56	Do not query API for custom rulesets	2020-05-01 17:02:28 +02:00
Endrik Tombak	33a608fd15	Merge branch 'master' of https://github.com/ppy/osu into present-recommended ... Conflicts: osu.Game/Screens/Select/SongSelect.cs	2020-05-01 11:06:20 +03:00
Dean Herbert	000c34dc26	Move recommender to field construction	2020-04-30 21:01:53 +09:00
Dean Herbert	cf4e79cf38	Show loading spinner when carousel is not ready to be displayed	2020-04-30 11:51:06 +09:00
Dean Herbert	119000f1ab	Reduce database includes where possible	2020-04-28 21:43:35 +09:00
Endrik Tombak	657bf5ad86	Merge branch 'master' of https://github.com/ppy/osu into present-recommended	2020-04-25 10:13:57 +03:00
smoogipoo	fcfb2b9026	Merge branch 'master' into fix-select-new-from-sub-screen	2020-04-21 14:36:53 +09:00
Dan Balasescu	3b3a7bdd85	Merge branch 'master' into scroll-to-center	2020-04-21 10:21:08 +09:00
Bartłomiej Dach	e3cd3cf1da	Convert to auto-properties	2020-04-20 21:43:07 +02:00
Bartłomiej Dach	9b6e26583b	Add xmldocs	2020-04-20 21:42:43 +02:00
Dean Herbert	ee1ccb8bcb	Fix in a slightly different and hopefully more understandable way	2020-04-20 14:03:55 +09:00
Endrik Tombak	b57d709d15	Don't use Parent	2020-04-19 18:29:06 +03:00
Endrik Tombak	a8bfd21f3f	Merge branch 'master' of https://github.com/ppy/osu into scroll-to-center	2020-04-19 18:21:34 +03:00
Endrik Tombak	4aaa00e321	Fix CI complaints	2020-04-17 20:33:12 +03:00
Endrik Tombak	1ac9ee5990	Optimize recommender (for custom rulesets)	2020-04-17 18:15:11 +03:00
Dean Herbert	5833a7ac91	Fix presenting new ruleset and beatmap at once causing wedge display desync	2020-04-17 18:56:17 +09:00
Dean Herbert	d62094cd4b	Fix carousel not correctly updating when selection changes to a new beatmap from a child screen	2020-04-16 18:10:35 +09:00
Dean Herbert	03a74a4320	Apply same conditional check changes to DrawableCarouselBeatmapSet	2020-04-16 12:13:26 +09:00
Dean Herbert	91b13f91ea	Add exception disallowing potential edit when disabled at a property level	2020-04-16 12:11:12 +09:00
Dean Herbert	c4caf38feb	Simplify menu item checks (and add for other items)	2020-04-16 12:10:20 +09:00
Joehu	e2b28bfe88	Hide edit context menu item in multiplayer song select	2020-04-15 18:17:12 -07:00
Endrik Tombak	b5c1752f0a	Calculate best ruleset order only once	2020-04-15 18:14:51 +03:00
Endrik Tombak	bbef94b4df	Reset best order on ruleset change	2020-04-14 18:56:20 +03:00
Endrik Tombak	00d1cf1ce2	Recommend from all rulesets	2020-04-14 18:42:18 +03:00
Endrik Tombak	dd6c9173da	Move DifficultyRecommender to OsuGameBase	2020-04-14 18:42:00 +03:00
Endrik Tombak	b475316a4e	Simplify and comment	2020-04-12 20:40:08 +03:00
Endrik Tombak	63a1686dfb	Scroll to screen middle	2020-04-12 12:42:52 +03:00
Dean Herbert	73a3f1fe65	Remove unnecessary DI	2020-04-11 17:30:34 +09:00
Dean Herbert	7aac0e59a8	Reduce dictionary lookups	2020-04-11 17:13:35 +09:00
Dean Herbert	310cf830d4	Simplify api request logic	2020-04-11 17:13:35 +09:00
Dean Herbert	abea7b5299	Tidy up function passing, naming, ordering etc.	2020-04-11 17:13:35 +09:00
Dean Herbert	7f753f6b4d	Remove current ruleset from function call	2020-04-11 16:43:09 +09:00
Dean Herbert	a843793957	Un-nest class	2020-04-11 16:41:11 +09:00
Endrik Tombak	deaf24f141	Fix oversight on null	2020-04-09 19:30:40 +03:00
Endrik Tombak	35f97dfc75	Style changes	2020-04-09 18:59:18 +03:00
Endrik Tombak	f40bdcd34e	Initial rewrite, moving API logic to SongSelect	2020-04-09 18:47:28 +03:00
Dean Herbert	260de77304	Merge branch 'master' into select-recommended	2020-04-09 15:30:35 +09:00
Dean Herbert	4bfc738f5b	Merge pull request #7639 from santerinogelainen/master ... Add top rank to the beatmap carousel	2020-04-08 23:36:47 +09:00
smoogipoo	ed3e0a01e1	Re-namespace into song select	2020-04-07 15:31:22 +09:00
Joehu	57b6a91449	Remove unnecessary input override on footer button mods ... Was used when it expanded on hover, but doesn't anymore.	2020-04-05 14:57:44 -07:00
Santeri Nogelainen	163de36777	Merge remote-tracking branch 'upstream/master'	2020-04-04 22:29:15 +03:00
Santeri Nogelainen	1e8badb14a	Move all logic to TopLocalRank and remove CarouselBeatmapRank	2020-04-04 22:28:36 +03:00
Joehu	493b654011	Remove horizontal margin from mod display ... Can skew center alignment on fill flow containers. Fixes affected areas. Vector2(5, 0) is similar to MarginPadding { Left = 10 }.	2020-04-03 11:30:02 -07:00
Dean Herbert	b47a532df3	Adjust code formatting slightly	2020-03-30 00:07:48 +09:00
Endrik Tombak	b4f0500706	Invert logic	2020-03-28 20:21:21 +02:00
Endrik	2c27894527	Use All instead of ToList Any ... Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2020-03-28 19:58:33 +02:00
Santeri Nogelainen	6bde102207	Merge remote-tracking branch 'upstream/master'	2020-03-28 18:14:17 +02:00
Santeri Nogelainen	faa2b49be4	Fix namespace for CarouselBeatmapRank, make UpdateableRank in TopLocalRank readonly	2020-03-28 18:13:39 +02:00
Santeri Nogelainen	1c711147f3	Move all carousel rank logic into separate classes (TopLocalRank and CarouselBeatmapRank)	2020-03-28 17:22:01 +02:00
Endrik Tombak	87854fc4fa	Rename variable	2020-03-28 13:23:31 +02:00
Endrik Tombak	6a0c5c87aa	Use already existing variable	2020-03-28 13:06:03 +02:00
Endrik Tombak	fc3f9ff6fa	Don't use drawables for select next	2020-03-28 12:54:48 +02:00
Endrik Tombak	bbbaaae3ee	Write tests	2020-03-26 19:18:16 +02:00
Endrik Tombak	ee112c6f50	Move and change logic	2020-03-26 18:42:08 +02:00
Endrik Tombak	2f5dc93d61	Select recommended difficulty	2020-03-26 00:19:54 +02:00
Dean Herbert	b1d4261402	Fix track looping state not being reset when entering editor from song select ... Closes #8432.	2020-03-25 15:50:19 +09:00
Dean Herbert	2a1e7a7ff0	Merge branch 'master' into fix-select-filter-not-absorbing-input	2020-03-24 14:03:58 +09:00
Dan Balasescu	6279c78e3c	Merge branch 'master' into fix-keypad-autoplay-shortcut	2020-03-24 13:34:31 +09:00
Joehu	5bc5119389	Handle OnHover on song select filter and footer	2020-03-23 16:03:33 -07:00
Joehu	96d962ab30	Fix autoplay keyboard shortcut not working with keypad enter key	2020-03-23 11:25:40 -07:00
Joehu	96848405fd	Fix song select filter not absorbing input from carousel	2020-03-23 10:54:45 -07:00
Dean Herbert	47c7673c9e	Fix crash when holding a key down while entering player	2020-03-23 17:04:54 +09:00
Dan Balasescu	d0c7b49376	Merge branch 'master' into fix-carousel-root-selects-from-nothing	2020-03-23 11:34:04 +09:00
Dean Herbert	29009c85c0	Fix typo in comment ... Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2020-03-22 00:32:53 +09:00
Dean Herbert	9b60b535e5	Fix selection not occurring when switching from empty ruleset on first load	2020-03-20 15:01:26 +09:00
Dean Herbert	be4a97c289	Correctly bypass last selected when it is filtered	2020-03-20 13:01:24 +09:00
Dean Herbert	8f9e97b4cc	Fix carousel not remembering last selection correctly	2020-03-19 18:07:39 +09:00
unknown	2340142dc1	Merge branch 'master' of https://github.com/ppy/osu into linkify-metadata	2020-03-18 14:18:53 +08:00
smoogipoo	1c4296f5e7	Implement the new results screen	2020-03-17 17:43:16 +09:00
Dean Herbert	5e3668b2ea	Merge pull request #8260 from smoogipoo/add-workingbeatmap-timeout ... Add beatmap loading timeout to prevent runaway loading scenarios	2020-03-17 11:17:35 +09:00
Dan Balasescu	e835f88c0c	Merge pull request #8255 from peppy/fix-carousel-scroll-while-import ... Fix carousel scrolling being inoperable during beatmap import	2020-03-16 12:50:45 +09:00
Dan Balasescu	3e65f13c67	Merge branch 'master' into fix-carousel-scroll-while-import	2020-03-16 12:06:50 +09:00
Dean Herbert	9bb3a6c677	Merge branch 'master' into click-group-difficulty-icons	2020-03-16 12:01:09 +09:00
Dean Herbert	d6be8eec0c	Merge branch 'master' into click-disabled-difficulty-icons	2020-03-16 11:30:57 +09:00
Dan Balasescu	f390c1995d	Apply comment suggestions ... Co-Authored-By: Dean Herbert <pe@ppy.sh> Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2020-03-16 11:29:28 +09:00
Dan Balasescu	bd05462a7f	Merge branch 'master' into carousel-selection-fallback-improvement	2020-03-16 10:53:10 +09:00
Dan Balasescu	25a35a1370	Merge branch 'master' into always-apply-ruleset-filter	2020-03-16 10:32:36 +09:00
Dean Herbert	340d362d69	Appease inspectcode	2020-03-15 03:51:30 +09:00
smoogipoo	c33ca6e99c	Decorate usages with exception management	2020-03-13 14:28:11 +09:00
Dean Herbert	ac70fcc544	Change logic to be more resilient by identifying user scroll events	2020-03-13 12:30:27 +09:00
Dean Herbert	5f8d180b5e	Fix carousel scrolling being inoperable during beatmap import	2020-03-13 11:51:26 +09:00
Dean Herbert	04f1da04db	Remove incorrect xmldoc from SelectBeatmap function	2020-03-13 10:52:08 +09:00
Dean Herbert	3f8b454ff4	Reword comment to match new filtering behaviour ... Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2020-03-13 10:01:28 +09:00
Dean Herbert	ca9cfbe51d	Move selection fallback logic out of BeatmapCarousel to SongSelect	2020-03-12 18:42:08 +09:00
Dean Herbert	6e11c3014c	Allow grouped difficulty icons to be clicked	2020-03-12 18:42:08 +09:00
Dean Herbert	ce5d01ed19	Allow filtered difficulty icons to be clicked	2020-03-12 18:42:08 +09:00
Dean Herbert	fc058f8896	Remove unnecessary this. prefix	2020-03-12 18:03:18 +09:00
Dean Herbert	933a8ffc8a	Add test coverage	2020-03-12 17:10:51 +09:00
Dean Herbert	28ac5af91c	Fix beatmap carousel tests loading beatmap manager beatmaps in test browser	2020-03-12 16:53:23 +09:00
Dean Herbert	63edcddaf1	Apply ruleset filter in all cases (even when bypassing filter for selection purposes)	2020-03-12 15:06:26 +09:00
Dan Balasescu	e6685c88fc	Merge pull request #8205 from peppy/always-scroll-to-selection ... Fix changing ruleset at song select not scrolling the current selection back into view	2020-03-11 14:38:57 +09:00
Dan Balasescu	f8f8e3628f	Merge branch 'master' into always-scroll-to-selection	2020-03-11 13:38:28 +09:00
Dan Balasescu	9119e32f63	Merge branch 'master' into better-filter-bypass	2020-03-11 13:37:55 +09:00
Dean Herbert	ed837d3115	Use framework extension method for FromHex	2020-03-11 10:18:41 +09:00
Dean Herbert	a2d3f20409	Merge branch 'master' into better-filter-bypass	2020-03-11 02:55:14 +09:00
Dean Herbert	8294dd0b71	Fix changing ruleset at song selectnot scrolling the current selection back into view	2020-03-10 19:59:49 +09:00
Dean Herbert	979988235d	Increase flexibility of StarCounter component	2020-03-08 15:56:22 +09:00
Dean Herbert	0477ef6c13	Force a selection after filtering to ensure correct difficulty is selected	2020-03-05 21:45:19 +09:00
Dean Herbert	332f56a7f8	Fix nullref in tests	2020-03-05 20:34:24 +09:00
Dean Herbert	f8776a0be4	Display all difficulties from overriding selection	2020-03-04 22:59:49 +09:00
Dean Herbert	a62550b323	Reapply filters on next change after a forced beatmap display	2020-03-04 20:14:18 +09:00
Dean Herbert	e890e45420	Fix Ctrl+Enter behaviour regression	2020-03-02 19:44:25 +09:00
Dean Herbert	48f2f615cd	Merge branch 'master' into fix-volume-bninding-handling	2020-03-02 19:28:36 +09:00
Dean Herbert	489bf16bea	Add SelectNext and SelectPrevious global actions	2020-03-02 18:55:28 +09:00
smoogipoo	7ad6ad0bb0	Remove hacks that bypassed layout shortcomings	2020-02-27 13:32:23 +09:00
Dean Herbert	623b78d675	Combine all loading animation implementations	2020-02-21 15:32:46 +09:00
Dean Herbert	cd666166d5	Merge pull request #7809 from voidedWarranties/proposal-difficulty-icon-select ... Allow selecting/playing a specific difficulty using the beatmapset difficulty icons	2020-02-21 10:24:12 +09:00
Dean Herbert	db4fe4f728	Merge branch 'master' into adjust-beatmap-overlay	2020-02-21 09:52:44 +09:00
smoogipoo	f9145ce5b4	Fix playlist items added with the wrong IDs	2020-02-17 17:02:19 +09:00
TheWildTree	64a9b9c6fb	Remove redundant using directives	2020-02-16 21:52:08 +01:00
TheWildTree	4d180a685a	Adjust font sizes and spacing in BeatmapSetOverlay	2020-02-16 21:43:33 +01:00
voidedWarranties	8c81f1e684	Move CarouselBeatmap access to private, test using indices	2020-02-15 17:51:55 -08:00
recapitalverb	2778c6617c	Merge branch 'master' into remove-duplicated-load	2020-02-15 15:13:35 +07:00
Dean Herbert	637c1dc840	In the case of only one playlist item, update with current selection on select	2020-02-15 14:41:16 +09:00
recapitalverb	7c9569c9a3	Merge branch 'master' into remove-duplicated-load	2020-02-15 12:10:34 +07:00
Dean Herbert	da68ae5461	Merge branch 'master' into match-songselect-playlist-logic	2020-02-15 12:27:51 +09:00
voidedWarranties	8e1ecddb1d	Add testing	2020-02-14 17:23:24 -08:00
recapitalverb	c46d828716	Preserve permitNulls	2020-02-14 20:59:51 +07:00
recapitalverb	10798aeab3	Fix code formatting	2020-02-14 20:30:27 +07:00
recapitalverb	c753cb46c5	Use [Resolved] wherever possible	2020-02-14 20:14:00 +07:00
smoogipoo	f31220c1ee	Fix exception when adding duplicate items	2020-02-14 19:56:43 +09:00
Dean Herbert	14f632b532	Merge branch 'master' into match-detail-area	2020-02-14 19:54:17 +09:00
smoogipoo	f0f739707f	Add playlist support to match song select	2020-02-14 17:51:42 +09:00
Dean Herbert	66910f1ee3	Remove unnecessary bindable setter	2020-02-14 17:50:53 +09:00
Dean Herbert	48dcb91118	Merge branch 'master' into custom-detail-area	2020-02-14 17:40:12 +09:00
smoogipoo	5ec9f454d5	Implement the match beatmap detail area	2020-02-14 17:20:38 +09:00
smoogipoo	25e399f11b	Merge branch 'match-playlist' into match-detail-area	2020-02-14 17:04:22 +09:00
voidedWarranties	368e6f9579	Use CarouselBeatmap.State to select	2020-02-13 17:47:16 -08:00
voidedWarranties	c871f07d2e	Use CarouselBeatmap action to select beatmap	2020-02-13 17:14:46 -08:00
Dean Herbert	b9a296d3f9	Merge branch 'master' into remove-current-item	2020-02-13 19:34:15 +09:00
Dean Herbert	49a1725749	Merge pull request #7812 from smoogipoo/playlist-bindables ... Make playlist beatmap and ruleset into bindables	2020-02-13 18:51:42 +09:00
smoogipoo	75bef15583	Remove "current" multiplayer room item	2020-02-13 18:48:28 +09:00
smoogipoo	91edadfe9d	Make playlist beatmap and ruleset into bindables	2020-02-13 18:12:47 +09:00
smoogipoo	d4f14e552a	Improve extensibility of mod display expansion	2020-02-13 18:05:53 +09:00
voidedWarranties	ad0de27964	Safer dependency injection and accessibility levels	2020-02-12 22:11:26 -08:00
smoogipoo	6f7196b0b8	Make beatmap detail area abstractable	2020-02-13 13:46:23 +09:00
voidedWarranties	f8b69fe632	Remove unnecessary carousel variable, fix code formatting	2020-02-12 20:11:39 -08:00
voidedWarranties	b126c00292	Use dependency loader to get SongSelect instance	2020-02-12 19:05:08 -08:00
voidedWarranties	2901ec9f26	Select specific difficulties using their icons	2020-02-11 20:05:26 -08:00
Dean Herbert	8186f72507	Remove unused using	2020-02-10 17:12:45 +09:00
Dean Herbert	66fb72cd8a	Fix song select not showing active beatmap if it is filtered by local criteria	2020-02-10 16:59:54 +09:00
Dean Herbert	81cadb7875	Simplify the way multiple subscreens handle their disable states via a custom stack	2020-02-06 14:22:01 +09:00
recapitalverb	79bb476f4c	Merge branch 'master' into display-accuracy	2020-02-04 11:39:47 +07:00
Dan Balasescu	3600b0daf0	Merge branch 'master' into fix-mod-select-overflowing	2020-02-04 11:57:54 +09:00
Joehu	22e3150f68	Fix comment and remove magic numbers	2020-02-03 17:21:06 -08:00
recapitalverb	9898a926b2	Use ScoreInfo.DisplayAccuracy everywhere	2020-02-03 22:11:36 +07:00
Dan Balasescu	c6e7603e5e	Merge branch 'master' into safe-screen-lease	2020-02-03 18:18:13 +09:00
Dan Balasescu	93952d438f	Merge pull request #7677 from peppy/decouple-mod-select-bindable ... Decouple ModSelectOverlay from global SelectedMods	2020-02-03 16:27:47 +09:00
Dean Herbert	9183c78319	Fix crash on exiting song select with ctrl-enter autoplay	2020-02-03 16:04:32 +09:00
Dean Herbert	aa1daa0ad5	Merge pull request #7703 from bdach/beatmap-stats-precision ... Apply precision when determining bar colour in difficulty statistics	2020-02-02 22:31:52 +09:00
Bartłomiej Dach	e894acf53c	Make star filter range bindables BindableDoubles ... Due to using Bindable<double>s previously, song select's filter control would not apply tolerance when checking IsDefault, therefore wrongly hiding maps with star ratings above 10.1.	2020-02-01 22:48:46 +01:00
Joehu	609ee26030	Fix mod select overlay not showing up in test	2020-02-01 11:41:41 -08:00
Joehu	2d42a83bb9	Fix mod select overlay overflowing toolbar at max ui scale	2020-02-01 11:24:29 -08:00
Bartłomiej Dach	0bfadfbbf1	Apply precision when comparing adjusted values ... In some cases, applying the Difficulty Adjust mod without actually changing any of the settings previously caused the bar in song select beatmap details to appear red/blue instead of staying white. This was caused by not accounting for floating-point imprecisions when determining bar colour in AdvancedStats. To resolve, first check equality with tolerance, and only then apply blue/red colours if that equality check does not hold.	2020-02-01 16:16:15 +01:00
Bartłomiej Dach	a74d22d9e5	Extract beatmap stats test to separate scene	2020-02-01 15:50:33 +01:00
Dean Herbert	ed368e44ea	Merge branch 'master' into safe-screen-lease	2020-02-01 02:11:18 +09:00
Dean Herbert	c5422743e2	Merge branch 'master' into decouple-mod-select-bindable	2020-02-01 02:06:23 +09:00
Dean Herbert	19f516e710	Ensure OsuScreen level leases are taken out synchronously	2020-01-31 19:10:44 +09:00
Dean Herbert	2f61d3f5ad	Fix song select remaining issue locally	2020-01-31 17:35:53 +09:00
unknown	2952fc8cc4	remove unused using	2020-01-31 09:05:13 +08:00
unknown	b916366536	fix formatting	2020-01-31 08:17:39 +08:00
unknown	2274d70dac	apply suggestions	2020-01-31 06:41:50 +08:00
Dean Herbert	7bf2e9b369	Decouple ModSelectOverlay from global SelectedMods	2020-01-30 17:38:15 +09:00
Dan Balasescu	09f6c57b0f	Merge branch 'master' into fix-import-different-ruleset	2020-01-30 15:08:25 +09:00
Dan Balasescu	c18b1b302c	Merge branch 'master' into editor-match-accessibility	2020-01-30 13:49:56 +09:00
unknown	0d3ccae1c2	Merge branch 'master' of https://github.com/ppy/osu into linkify-metadata	2020-01-30 12:31:17 +08:00
unknown	c5995acfff	linkify metadata	2020-01-30 12:30:25 +08:00
Dean Herbert	c158570249	Fix typo in comment ... Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2020-01-30 11:31:34 +09:00
Dean Herbert	f72de235cc	Remove unnecessary length specifications	2020-01-30 11:00:14 +09:00
Dean Herbert	37ecf8a060	Remove commented line	2020-01-30 10:50:48 +09:00
Dean Herbert	bea20efb64	Merge branch 'master' into mod_content_centering	2020-01-30 10:34:46 +09:00
Bartłomiej Dach	f130e48c9e	Remove leftover negative margin	2020-01-29 19:17:07 +01:00
Bartłomiej Dach	c9dda78ded	Refactor drawable hierarchy to center properly ... * Use FillFlowContainer.Spacing instead of manually applying margins. * Use Update() for calculating button padding to preserve it after mod button expansion and adjust FooterButtonRandom to use this method while avoiding flickering. * Expose mod display margin to clear it in the footer button.	2020-01-29 18:59:51 +01:00
Dean Herbert	da6952407e	Allow null DI	2020-01-29 23:01:57 +09:00
Dean Herbert	13eb32fea2	Fix editor being accessible for multiplayer song select	2020-01-29 22:20:34 +09:00
smoogipoo	76af8bea5d	Fix percentage-formatted displays containing a space	2020-01-29 19:51:24 +09:00
Dean Herbert	7588c574a2	Fix presenting a beatmap from a different ruleset not working	2020-01-29 19:37:54 +09:00
Dean Herbert	77c06b1c6e	Fix beatmap carousel potentially missing beatmap imports	2020-01-29 17:09:12 +09:00
Dean Herbert	12ff51f686	Fix key count being incorrectly adjusted by hard/easy mods	2020-01-28 17:21:50 +09:00
Dean Herbert	7aa5e8c23e	Limit input propagation correctly	2020-01-27 14:55:47 +09:00
Dean Herbert	1c64b70b06	Revert "Fix crash due to misordered selection events" ... This reverts commit 2d74609f50.	2020-01-27 14:53:24 +09:00
Dean Herbert	2d74609f50	Fix crash due to misordered selection events	2020-01-26 19:06:50 +09:00
Dean Herbert	92a5fbe948	Merge branch 'master' into star-filtering	2020-01-24 23:28:36 +09:00
smoogipoo	45a25214ab	Make upper and lower bounds inclusive	2020-01-24 19:39:21 +09:00
smoogipoo	9e0e7be8d0	Modernise filter implementation	2020-01-24 18:57:17 +09:00
smoogipoo	12cc97ca31	Merge remote-tracking branch 'origin/master' into star-filtering ... # Conflicts: # osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapCarousel.cs # osu.Game/Screens/Select/Carousel/CarouselBeatmap.cs # osu.Game/Screens/Select/FilterControl.cs # osu.Game/Screens/Select/FilterCriteria.cs	2020-01-24 18:30:52 +09:00
Dean Herbert	fdde4a6858	Tidy up song select hierarchy to be more readable	2020-01-24 15:44:31 +09:00
Dean Herbert	c0a233e8bb	Align background wedge with carousel	2020-01-24 15:00:10 +09:00
Dean Herbert	f8cb898516	Improve song select display on ultrawide displays (or when UI scale is set low)	2020-01-23 20:03:52 +09:00
Dean Herbert	8a7f7c5e46	Merge remote-tracking branch 'smoogipoo/void-key-up-returns' into update-framework	2020-01-22 22:57:56 +09:00
Dean Herbert	7c62cc3ac3	Merge remote-tracking branch 'smoogipoo/void-mouse-up-returns' into update-framework	2020-01-22 22:57:52 +09:00
Dean Herbert	5f8ffd9346	Merge remote-tracking branch 'smoogipoo/void-release-returns' into update-framework	2020-01-22 22:57:40 +09:00
smoogipoo	7b2f58eb30	Apply OnRelease method signature refactorings	2020-01-22 13:22:34 +09:00
smoogipoo	40f502c6d1	Apply input method signature refactorings	2020-01-20 19:35:37 +09:00
smoogipoo	bfb056c612	Apply input method signature refactorings	2020-01-20 18:17:21 +09:00
Dean Herbert	cd5290b030	Enforce using get-only auto property where possible	2020-01-20 13:50:27 +09:00
Dean Herbert	e88e40eec4	Expand on comment	2020-01-15 15:11:36 +09:00
Joehu	b42b23d65b	Add comment for alt pressed ... Taken from OsuScrollContainer	2020-01-14 20:52:15 -08:00
Joehu	2060be345d	Move alt pressed condition to top of method	2020-01-14 20:44:55 -08:00
Joehu	c196e83e75	Allow changing volume in song select with arrow keys when pressing alt	2020-01-13 20:48:39 -08:00
TheWildTree	b5ac707c6c	Remove unnecessary directive	2020-01-12 21:09:48 +01:00
TheWildTree	aa2645502c	Fix adjusted value always being 0	2020-01-12 20:43:48 +01:00
Dean Herbert	56724d2580	Merge branch 'master' into #7146	2020-01-10 01:08:20 +08:00
smoogipoo	91735ff367	Update MathUtils namespace usages	2020-01-09 13:43:44 +09:00
smoogipoo	28510674ac	Shorten body text	2020-01-06 17:48:29 +09:00
smoogipoo	61c269b17b	Leaderboard should not change the model	2020-01-06 17:32:24 +09:00
smoogipoo	4a7f5f98df	Cleanup methods/events	2020-01-06 17:20:09 +09:00
Willy Tu	e23c71be80	Update Resolved and Cached attribute issues	2020-01-03 11:34:26 -08:00
Willy Tu	0a4e180ce7	Merge branch 'master' of github.com:ppy/osu into #7146	2020-01-03 11:32:06 -08:00
Viktor Rosvall	ddec59ec91	Further refactoring. I think this may have polluted the FooterButton too much. Not sure what to do about the centering.	2020-01-01 12:22:19 +01:00
Viktor Rosvall	8695e57f62	Hides mod display when no mods are active to fix issue of invisible margin	2019-12-31 12:21:55 +01:00
Viktor Rosvall	f40ebc83ca	Begun refractorization process of wrapping Button text in a FillFlowContainer	2019-12-30 23:58:49 +01:00
Viktor Rosvall	b0bcbf8b93	Adjusted margin to fix the 1 px increase	2019-12-30 21:55:09 +01:00
Viktor Rosvall	875a25c529	adjusted the margin values	2019-12-29 09:00:59 +01:00
Viktor Rosvall	b3d32710df	Centered button mods by adding padding to FillFlowContainer	2019-12-29 00:19:51 +01:00
Dean Herbert	41d99df73c	Merge branch 'master' into allow-ctrl-tabbing-on-more-tab-controls	2019-12-25 20:49:45 +09:00
Joehu	b038c192d1	Rename property to IsSwitchable	2019-12-22 19:47:47 -08:00
Joehu	1342556894	Allow ctrl tabbing navigation to chat and song select leaderboards	2019-12-21 10:48:11 -08:00
Willy Tu	8e60ae7039	Removed directive is not required	2019-12-20 15:45:20 -08:00
Willy Tu	8353c893c0	Update BodyText of LocalScoreDeleteDialog	2019-12-20 12:00:10 -08:00
Dean Herbert	a6bdf04f6b	Remove unused using	2019-12-20 18:36:39 +09:00
Dean Herbert	822903d5db	Update song select statistics when mod changes settings	2019-12-20 18:01:35 +09:00
Willy Tu	ed07b779b1	Update to use score.ID identify local scores	2019-12-18 21:54:02 -08:00
Willy Tu	27163a5133	Removed unnecessary code for deleting individual local score.	2019-12-18 21:04:10 -08:00
Willy Tu	b67f986058	Fix CodeFactor issues	2019-12-18 19:26:35 -08:00
Willy Tu	531ac16743	Update Scoreboard Refresh Method for deleting individual scores	2019-12-18 19:22:42 -08:00
Willy Tu	d1fcadc700	Merge branch 'master' of github.com:ppy/osu into #7146	2019-12-18 19:16:54 -08:00
smoogipoo	2905a4418d	Fix potential nullref	2019-12-18 21:30:57 +09:00
smoogipoo	cb5a35f8f9	Fix incorrect bindable valuechanged usage	2019-12-18 21:08:49 +09:00
smoogipoo	4e11fb0fd7	Merge remote-tracking branch 'refs/remotes/origin/master' into multiplier-text	2019-12-18 19:36:16 +09:00
Dan Balasescu	6683460240	Merge branch 'master' into update-beatmap-settings	2019-12-18 17:59:27 +09:00
smoogipoo	8e651962c7	Fix incorrectly binding inside BDL load()	2019-12-18 17:41:30 +09:00
Dean Herbert	ada2ae2b2c	Use tuple to avoid potential for incorrect display	2019-12-18 17:12:41 +09:00
Dean Herbert	e87aa281bf	Don't clone beatmap unnecessarily	2019-12-18 17:00:35 +09:00
wltu	4646524bf9	Remove unnecessary library	2019-12-17 13:18:20 -08:00
wltu	8aeef3f59a	Added refresh scoreboard upon deleting local score and formatted the code	2019-12-17 12:56:30 -08:00
wltu	bb2b1475cd	Merge branch 'master' of https://github.com/ppy/osu into #7146	2019-12-17 12:54:47 -08:00
Huo Yaoyuan	caf3f774ba	CA1309: compare strings correctly.	2019-12-17 13:00:15 +08:00
Huo Yaoyuan	ecfc6dfa3d	CA1825: use Array.Empty.	2019-12-17 12:59:48 +08:00
Willy Tu	bef9637fdf	Implemented delete local score individually. Currently does not refresh the score screen after the delete is compelete.	2019-12-16 19:25:28 -08:00
Huo Yaoyuan	ab70abe8bd	Turn off unexpected new warnings.	2019-12-15 20:07:56 +08:00
unknown	3945e7403a	improve tests and refactor AdvancedStats	2019-12-13 09:39:54 +08:00
unknown	ec5b506960	apply mod difficulty settings during song select	2019-12-12 23:41:46 +08:00
Dean Herbert	cdde5d1d69	Fix song select filters not reapplied if in a child screen ... Closes https://github.com/ppy/osu/issues/6980.	2019-12-10 02:30:23 +09:00
Huo Yaoyuan	ad1fb3bda2	Remove IComparable in constraint.	2019-12-09 17:48:41 +08:00
Dean Herbert	48287459a0	Optimise filters to avoid property retrieval ... Also reduces number of instantiations of SearchableTerms array in the case of multiple criteria terms.	2019-12-05 01:52:22 +09:00
Dan Balasescu	19c5848e73	Merge branch 'master' into decouple-legacy-score-info	2019-12-04 11:47:27 +09:00
Huo Yaoyuan	a42f9447e6	Don't use Equals(object) on T?.	2019-12-03 20:07:22 +08:00
Dean Herbert	f0d49d0cdf	Decouple APILegacyScoreInfo from ScoreInfo	2019-12-03 15:31:11 +09:00
Ganendra Afrasya	ada8dabf7e	Add right margin on score multiplier text	2019-11-28 18:48:43 +07:00
Ganendra Afrasya	944835da23	Add multiplier score text on mods footer button	2019-11-28 12:01:40 +07:00
Huo Yaoyuan	c0fe91a84c	Merge branch 'master' into sharpen	2019-11-26 18:21:50 +08:00
Berkan Diler	fccdbffa93	Use MathF instead of Math- functions when possible ... MathF-functions are faster than the Math-counterpart and it looks cleaner, so use MathF when we cast to float or int anyway.	2019-11-25 00:45:42 +01:00
Dean Herbert	d8260f4a65	Reduce carousel scroll motion on initial display	2019-11-22 10:51:49 +09:00
Huo Yaoyuan	818553027b	Merge branch 'master' into sharpen	2019-11-21 23:42:46 +08:00
Dan Balasescu	a7c074ff37	Merge branch 'master' into math_clamp	2019-11-21 11:08:56 +09:00
Berkan Diler	6cab517b2d	.NET Standard 2.1 implements Math.Clamp , use it instead of MathHelper.Clamp from osuTK.	2019-11-20 13:37:47 +01:00
Dean Herbert	3ba9f840fd	Fix song select not always scrolling to the correct location	2019-11-20 19:39:13 +09:00
Huo Yaoyuan	374ef6ff83	Merge branch 'master' into sharpen	2019-11-20 17:30:58 +08:00
Dean Herbert	8c9ed99b1b	Merge remote-tracking branch 'upstream/master' into fix-carousel-double-filter	2019-11-20 17:24:54 +09:00
Dean Herbert	5b416eb7ba	Move initial filter to run on entering	2019-11-20 17:24:43 +09:00
Dean Herbert	e0f59d8e24	Move method	2019-11-20 15:43:00 +09:00
Huo Yaoyuan	b04bca7db6	Reference elements in origin definition.	2019-11-17 20:55:40 +08:00
Dean Herbert	e9e37fc821	Add private setter for FilterControl	2019-11-15 18:23:35 +09:00
Dean Herbert	296fff9243	Merge remote-tracking branch 'upstream/master' into fix-carousel-double-filter	2019-11-15 18:20:36 +09:00
Dean Herbert	2c3109980a	Fix broken merge	2019-11-15 13:51:39 +09:00
Dean Herbert	b8bb97607b	Merge remote-tracking branch 'upstream/master' into fix-mod-retention	2019-11-15 13:46:44 +09:00
Huo Yaoyuan	677717875e	Change a case to EqualityComparer.Default to handle null properly.	2019-11-14 17:35:02 +08:00
Huo Yaoyuan	f25b1ba06f	Merge branch 'master' into equals	2019-11-14 17:33:44 +08:00
Dean Herbert	c15f909d83	Remove local bindable at song select, along with misplaced reset logic	2019-11-14 13:29:06 +09:00
Dean Herbert	d8a5750e5d	Fix typo ... Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2019-11-14 08:38:01 +09:00
Dean Herbert	a580b9079a	Reword comment	2019-11-14 08:28:41 +09:00
Huo Yaoyuan	87d40cf8d0	Resolve equals usages.	2019-11-13 22:35:50 +08:00
Dean Herbert	110c155fa0	Fix background loading twice when entering song select	2019-11-13 19:42:05 +09:00
Dean Herbert	280c1a0eb4	Fix carousel filtering twice on startup due to unpopulated ruleset	2019-11-13 19:04:52 +09:00
Dean Herbert	bca1be0bfa	Add failing test	2019-11-13 18:54:33 +09:00
Huo Yaoyuan	42a98c5d87	Use constants.	2019-11-12 20:07:01 +08:00
Huo Yaoyuan	d60493a961	Use discards.	2019-11-12 20:03:21 +08:00
Huo Yaoyuan	e9b8cbb516	Apply other styles.	2019-11-11 20:27:04 +08:00
Huo Yaoyuan	ccc8aa6fa4	Apply brace style.	2019-11-11 20:13:13 +08:00
Ganendra Afrasya	8da15f6897	Fix all score are highlighted on local scope	2019-11-01 23:19:15 +07:00
Ganendra Afrasya	ce3b34a768	Fix UserTopScoreContainer is also tinted	2019-11-01 23:00:55 +07:00
Bartłomiej Dach	c181edaedf	Replace manual comparer implementation ... Replace manually-implemented CriteriaComparer with a call to Comparer<T>.Create() to decrease verbosity.	2019-10-28 15:07:36 +01:00
Bartłomiej Dach	c8d3dd0e5a	Make carousel item sorting stable ... Migrate beatmap carousel item sorting from List<T>.Sort() to IEnumerable<T>.OrderBy(), as the second variant is documented to be a stable sorting algorithm. This allows for eliminating unnecessary movement of carousel items occurring whenever any set of items is tied when changing sorting criteria.	2019-10-27 23:14:14 +01:00
Joehu	f7924d3bad	Rename "FixedSearchTextBox" to "SeekLimitedSearchTextBox"	2019-10-21 16:00:09 -07:00
Joehu	e5b50b5e1f	Fix slider bar regression when using arrows	2019-10-17 13:54:36 -07:00
Joehu	649951198e	Make most textbox carets movable	2019-10-15 14:47:48 -07:00
Joehu	ccc753a315	Make OverlayContainers with no blocking input VisibilityContainers	2019-10-14 16:27:59 -07:00
Dan Balasescu	26a33bfa4e	Merge branch 'master' into fix-resume-from-player-audio	2019-10-11 19:21:14 +09:00
Dan Balasescu	d4282473c6	Merge branch 'master' into fix-background-disposal	2019-10-11 17:15:30 +09:00
Dean Herbert	5eba33e876	Simplify logic and add test coverage for remaining case	2019-10-10 20:12:47 +09:00
Dean Herbert	e66f9adb86	Fix user pause not being cancelled when playing audio	2019-10-10 16:53:03 +09:00
Dean Herbert	f74c79c2b8	Fix audio playback position being reset after resuming to song select	2019-10-10 11:58:43 +09:00
Dan Balasescu	69b9e359bf	Merge branch 'master' into fix-ss-track-playback	2019-10-09 12:26:07 +09:00
Dean Herbert	4e026b163c	Don't resume playback when user has paused and track hasn't changed	2019-10-08 15:04:38 +09:00
Dean Herbert	e7fc5e556c	Fix song select not correctly playing tracks in some cases	2019-10-08 11:06:07 +09:00
Dean Herbert	bb161222ef	Merge branch 'master' into fix-tab-controls-overflowing	2019-10-08 10:12:03 +09:00
Joehu	9fdbe58326	Fix dropdown header padding when selected mod filter is hidden	2019-10-07 16:17:58 -07:00
Joehu	8e6e90eaec	Use fixed numbers for padding instead	2019-10-07 16:11:40 -07:00
Dean Herbert	f15953d65c	Fix carousel including filtered difficulties in sort comparisons	2019-10-07 15:17:03 +09:00
Joehu	11d937beab	Fix beatmap detail area tab dropdown being blocked by content	2019-10-06 10:24:33 -07:00
Joehu	38c1cee5fd	Fix tab controls overflowing	2019-10-06 10:22:55 -07:00
Joehu	e257f4ca04	Resume music to same position when exiting gameplay	2019-10-05 10:31:44 -07:00
Joehu	a71db11ea5	Remove depth parameter description	2019-10-04 18:38:44 -07:00
Joehu	5d460eaf6b	Remove depth specification and button order regression	2019-10-04 17:14:19 -07:00
Joehu	e7ba6ef5c4	Fix keybinding order of beatmap options	2019-10-04 14:32:43 -07:00
Dean Herbert	d2c9a29c0d	Remove unnecessary local assign	2019-10-04 10:45:18 +08:00
smoogipoo	a5e1cb8feb	Merge remote-tracking branch 'Game4all/master' into truncate-metadata-on-wedge	2019-10-04 11:21:33 +09:00
Joehu	5f700f2ae9	Simplify exit logic of screens with textboxes using back button receptor	2019-10-01 08:26:34 -07:00
iiSaLMaN	fb9f21237e	Reset track adjustments on resuming from another screen	2019-09-28 04:18:16 +03:00
Joehu	102dbd85bd	Fix CI errors	2019-09-24 16:48:22 -07:00
Joehu	9861b21440	Remove unnecessary padding/margin	2019-09-24 16:28:40 -07:00
Joehu	7fab1a4337	Truncate long metadata on beatmap info wedge	2019-09-24 16:06:33 -07:00
Dean Herbert	4a59e3351e	Update beatmap carousel tests code style ... Also fixes one issue I spotted in BeatmapCarousel related to incorrectly holding a selection after new sets are loaded.	2019-09-25 02:42:12 +09:00
Bartłomiej Dach	96c0c80dc5	Factor out methods in FilterQueryParser ... Factor FilterQueryParser.ApplyQueries into shorter methods to reduce method complexity.	2019-09-22 21:20:50 +02:00
Bartłomiej Dach	70842f71f4	Fix floating point handling in filter intervals ... Due to floating-point rounding and representation errors, filters could wrongly display results incongruous with the wedge display text (ie. a beatmap with the BPM of 139.99999 would be displayed as having 140 BPM and also pass the bpm<140 filter). Apply tolerance when parsing floating-point constraints. The tolerance chosen is half of what the UI displays for the particular values (so for example half of 0.1 for AR/DR/CS, 0.01 for stars, etc.) Tests updated accordingly.	2019-09-22 00:20:55 +02:00
Bartłomiej Dach	b262ba13cd	Add creator= and artist= filters ... To match stable, add creator= and artist= filters to the beatmap carousel on song select screen. Contrary to stable, this implementation supports phrase queries with spaces within using double quotes. The quote handling is not entirely correct (can't nest), but quotes should rarely happen within names, and it is an edge case of an edge case - leaving best-effort as is. Test coverage also included.	2019-09-22 00:20:55 +02:00
Bartłomiej Dach	f5f5094611	Take culture into account when parsing filters ... Culture was not taken into account when parsing filters, which meant that in cultures that use the comma (,) as a decimal delimiter, it would conflict with the comma used to delimit search criteria. To remove any ambiguity, introduce local helper functions that allow the decimal point to be utilised, using the invariant culture. This also matches stable behaviour. The decision to not reuse osu.Game.Beatmaps.Formats.Parsing was deliberate due to differing semantics (it's not really sane to throw exceptions on receiving user-facing input).	2019-09-22 00:18:53 +02:00
Bartłomiej Dach	dddd94684b	Split out lower and upper interval inclusivity ... A single IsInclusive field causes unexpected issues when trying to formulate a half-open interval query. Split out IsInclusive into two fields, Is{Lower,Upper}Inclusive and update usages accordingly.	2019-09-22 00:18:28 +02:00
Bartłomiej Dach	33c51d5178	Extract parsing filter queries to class ... For the sake of testability without having to spin up visual tests, extract methods related to parsing filter queries from FilterControl to a static FilterQueryParser class.	2019-09-22 00:18:28 +02:00
Revel	f7f9c0f7e0	Update BeatmapDetailAreaTabControl.cs	2019-09-19 15:47:32 -04:00
Dean Herbert	0a67d1db1b	Merge pull request #5355 from EVAST9919/songselect-best-user-score ... Show personal best on song select	2019-09-19 21:17:23 +09:00
smoogipoo	94d3bcc612	Fix top score not being selectable	2019-09-19 20:47:33 +09:00
smoogipoo	5120d82ef8	Fix crash with multiple range criterias	2019-09-19 17:36:44 +09:00
smoogipoo	96ea507320	Reorder comparison for readability	2019-09-19 17:21:22 +09:00
smoogipoo	e075dd7ea8	Fix equals operator not working	2019-09-19 17:16:34 +09:00
smoogipoo	7683f7ff23	Make OnlineStatus use OptionalRange	2019-09-19 17:12:07 +09:00
smoogipoo	d7831d8f5d	Use non-generic IComparable interface	2019-09-19 17:11:43 +09:00
smoogipoo	167bb9fcc1	Fix ugly casts	2019-09-19 17:11:28 +09:00
smoogipoo	0915a94470	Make BeatDivisor use OptionalRange	2019-09-19 16:53:27 +09:00
smoogipoo	3c21b68b73	Make OptionalRange generic	2019-09-19 16:51:57 +09:00
Dean Herbert	48ee95955b	Remove unnecessary redirection	2019-09-19 15:45:08 +09:00
smoogipoo	c1daa187fe	Reduce default tolerance	2019-09-19 15:44:14 +09:00
Dean Herbert	36d0695e5c	Add spacing	2019-09-19 15:44:05 +09:00
Dean Herbert	033c68a428	Fade in score, not container	2019-09-19 15:44:00 +09:00
Dean Herbert	2b6c9aeb26	Move top score container to more local namespace	2019-09-19 15:38:40 +09:00
Dean Herbert	e0fd8609d1	Fix margins and clean up implementation	2019-09-19 15:34:46 +09:00
smoogipoo	80f46e02d8	Add equals (=) query operator variants	2019-09-19 15:33:54 +09:00
Dean Herbert	098e89cb66	Improve state reset flow	2019-09-19 15:23:33 +09:00
Dean Herbert	4967ffd8e5	Move inside leaderboard	2019-09-19 14:52:31 +09:00
Dean Herbert	a7b6895d4c	Revert changes to BeatmapDetailArea	2019-09-19 14:26:15 +09:00
Dean Herbert	2e0a85c2f6	Merge remote-tracking branch 'upstream/master' into songselect-best-user-score	2019-09-19 12:57:30 +09:00
Dean Herbert	92556db9cd	Add query-based filter modes to song select search field	2019-09-19 02:48:28 +09:00
Dan Balasescu	4910c23482	Merge branch 'master' into show-beatmap-not-selected-in-leaderboards	2019-09-10 17:43:42 +09:00
iiSaLMaN	b77550625c	Check if DummyWorkingBeatmap is selected instead	2019-09-09 20:04:04 +03:00
iiSaLMaN	1b0123a60c	Set beatmap of leaderboard to null if NoBeatmapsAvailable is selected	2019-09-05 05:56:52 +03:00
iiSaLMaN	a1c580f27e	Create "none selected" placeholder state	2019-09-05 05:56:21 +03:00
smoogipoo	a87a1e6031	Don't redraw certain buffered containers on scale change	2019-09-04 19:38:12 +09:00
iiSaLMaN	aff4dab9aa	Ensure playing track of beatmap selected only if a track change occurred	2019-09-01 03:17:55 +03:00
Dean Herbert	7885c79467	Make bindables private	2019-08-27 14:31:34 +09:00
Dean Herbert	69145eb83a	Merge branch 'master' into select-filters-persistence	2019-08-27 14:12:59 +09:00
smoogipoo	6368189d46	Refactor	2019-08-27 11:59:25 +09:00
Andrei Zavatski	9321f20884	Move arrow to the first line	2019-08-26 14:32:27 +03:00
Andrei Zavatski	fd0f42eee4	Fix filtered grouped difficulty items in DrawableCarouselBeatmapSet aren't hidden on first load	2019-08-26 14:11:24 +03:00
Dean Herbert	9881d3677d	Simplify icon creation	2019-08-25 12:05:46 +09:00
Dean Herbert	ef397434f6	use GroupBy instead of Distinct+FindAll	2019-08-25 12:00:06 +09:00
Dean Herbert	a19a9b90ed	Simplify group filter display	2019-08-25 11:39:26 +09:00
Lucas A	b204e4419a	Rename SelectSortingMode & SelectGroupingMode -> SongSelectSortingMode & SongSelectGroupingMode	2019-08-24 10:34:54 +02:00
iiSaLMaN	8ccbe84f67	Loop on distinct rulesets of beatmap instead of all	2019-08-24 01:30:33 +03:00
iiSaLMaN	87340061e1	Add logic to create grouped difficulty icons in carousel beatmap set	2019-08-24 00:06:28 +03:00
Lucas A	ce5ee095b9	Fetch config bindables in BDL.	2019-08-23 14:03:56 +02:00
Lucas A	6bf31e8f91	Make song select grouping & sorting filters persistent	2019-08-23 13:15:38 +02:00
Dean Herbert	7bf430afd5	Add padding back to difficulty icons on carousel	2019-08-21 21:16:06 +09:00
Dean Herbert	48716f8f2b	Update framework	2019-08-21 13:29:50 +09:00
Dean Herbert	9ea4921e2b	Merge pull request #5036 from GSculerlor/difficulty-icon-tooltip ... Add tooltips to difficulty icons with extra details	2019-08-19 17:23:13 +09:00
Dan Balasescu	9c069f6f22	Merge branch 'master' into unpause-on-selection-change	2019-08-19 13:15:46 +09:00
Dean Herbert	1f00793891	Unpause music when changing selection at song select	2019-08-19 11:30:04 +09:00
Dean Herbert	3dc81bdad5	Merge branch 'refactor-difficulty-colours' into difficulty-icon-tooltip	2019-08-17 15:19:46 +09:00
Dean Herbert	4fa9abeece	Replace DifficultyColouredContainer with a more scalable solution	2019-08-17 15:16:24 +09:00
Dean Herbert	f552de6ebc	Merge branch 'master' into difficulty-icon-tooltip	2019-08-17 13:45:20 +09:00
Dean Herbert	b57298406f	Fix right click blocking not resetting correctly	2019-08-15 19:25:33 +09:00
Dean Herbert	0f4bada21e	Fix right click absolute scrolling interfering with context menus	2019-08-15 18:27:45 +09:00
Dean Herbert	e73a9c2748	Fix song select context menus displaying off-screen	2019-08-15 14:06:29 +09:00
Dean Herbert	f355cff8bc	Apply reviews	2019-08-15 12:11:54 +09:00
Dean Herbert	7e74953784	Merge remote-tracking branch 'upstream/master' into difficulty-icon-tooltip	2019-08-15 11:54:59 +09:00
Dean Herbert	75cb0d093b	Use description correctly ... Required for localisation	2019-08-12 16:10:48 +09:00
Dean Herbert	90b1fe81f3	Update cached usage in line with framework changes	2019-08-09 19:12:29 +09:00
Dean Herbert	616de1830a	Less sheep	2019-08-07 12:20:49 +09:00
Joehu	1fc7ddf621	Fix text depth regression	2019-08-05 18:14:41 -07:00
Joehu	a7ac411c25	Fix footer button hover sounds playing in unclickable area	2019-08-05 17:57:04 -07:00
Andrei Zavatski	fd44ca3233	Rename Animation to Layer	2019-08-04 13:54:23 +03:00
Andrei Zavatski	a30d7912b1	Move DimmedLoadingAnimation to it's own file	2019-08-04 11:09:12 +03:00
Dean Herbert	4c6cccb3a3	Update settings in line with framework changes	2019-07-30 23:31:21 +09:00
Dean Herbert	088c04a20f	Revert "Fix BackButton handling escape before all other elements (#5440)" ... This reverts commit 17a6563f4c.	2019-07-28 23:38:55 +09:00
Dean Herbert	872822035a	Merge branch 'master' into back-button-priority	2019-07-28 12:50:18 +09:00
Dean Herbert	3571cb96b0	Fix broken merge	2019-07-27 12:56:55 +09:00
David Zhao	57e6c388a1	Merge branch 'master' into carousel-sizing	2019-07-27 11:40:07 +09:00
Dean Herbert	392e1cbafb	Merge pull request #5456 from peppy/fix-import-select ... Fix beatmap present failing directly after an import	2019-07-26 18:48:49 +09:00
Dean Herbert	4d49aad153	Start not visible	2019-07-26 15:51:51 +09:00
Dean Herbert	7fa419a38b	Fix file layout order	2019-07-26 15:49:21 +09:00
David Zhao	0f6c6c7de0	consolidate halfheight as well	2019-07-26 15:22:29 +09:00
Joehu	0b6cfec21c	Hide leaderboard mod filter when on details tab	2019-07-25 23:20:56 -07:00
David Zhao	6765e9f7fa	Combine into properties and update for framework changes	2019-07-26 15:13:10 +09:00
David Zhao	c89830f3d8	move constants, combine local vars into properties	2019-07-26 13:07:28 +09:00
David Zhao	a9f0dda9d7	Confine positional input	2019-07-25 17:36:13 +09:00
David Zhao	97eb5293a8	Don't depend on parent sizing	2019-07-25 17:32:21 +09:00
David Zhao	c4bed0e6d2	Resize BeatmapCarousel, update carouselitem logic	2019-07-25 15:31:21 +09:00
Dean Herbert	69844e6c24	Fix beatmap present failing directly after an import	2019-07-25 12:18:18 +09:00
David Zhao	6ef3c71e22	remove unused using	2019-07-25 11:31:46 +09:00
David Zhao	e63c97b306	remove unnecessary overrides	2019-07-25 11:20:24 +09:00
David Zhao	bbcc8f0721	Add new container level and unblock footer	2019-07-25 11:11:20 +09:00
Andrei Zavatski	76b79f3554	Transform adjustments	2019-07-23 01:14:45 +03:00
Andrei Zavatski	94ed03548d	Hide top score at every leaderboard change	2019-07-22 18:34:31 +03:00
Dean Herbert	5a6c8bfec9	Adjust transition to now show janky resize	2019-07-22 23:28:17 +09:00
Dean Herbert	95241165cc	Fix text alignment	2019-07-22 23:26:11 +09:00
Dean Herbert	d83d93ee66	Use asynchronous loading	2019-07-22 23:21:07 +09:00
Dean Herbert	764513feea	Fix code quality	2019-07-22 23:13:48 +09:00
Dean Herbert	8c54708582	Merge branch 'master' into songselect-best-user-score	2019-07-22 22:34:11 +09:00
Dean Herbert	a05a6bbb77	Set "Title" as the default grouping/sorting modes in song select (#5396) ... Set "Title" as the default grouping/sorting modes in song select	2019-07-22 18:06:23 +09:00
Dean Herbert	e76b3e2b40	User property instead of method	2019-07-21 10:42:40 +09:00
iiSaLMaN	842417cf42	Check if selected scope requires API	2019-07-21 03:07:27 +03:00
smoogipoo	1ce2b2eace	Set title as default grouping/sorting modes	2019-07-18 13:18:06 +09:00
smoogipoo	7c5a227fc5	Fix crashes when presenting replays	2019-07-17 14:46:25 +09:00
Dean Herbert	7634e3cc81	Fix song select iterating over all beatmaps in database unnnecessarily	2019-07-16 14:57:11 +09:00
Andrei Zavatski	7e367dc397	Push results screen when clicking on top score	2019-07-15 12:30:42 +03:00
Andrei Zavatski	9c13ede5a8	Merge remote-tracking branch 'refs/remotes/ppy/master' into songselect-best-user-score	2019-07-15 12:11:28 +03:00
Dean Herbert	d4c1005c7e	Fix incorrect comparison in line updating logic	2019-07-15 15:53:19 +09:00
Andrei Zavatski	19680c8df8	Minor adjustments	2019-07-14 16:37:05 +03:00
Andrei Zavatski	ecf0e62484	CI fixes	2019-07-14 16:16:21 +03:00
Andrei Zavatski	963e025bb8	Make it works and some layout adjustments	2019-07-14 14:03:14 +03:00
Andrei Zavatski	d1409d4610	Add top score section into beatmap detail area	2019-07-14 13:33:47 +03:00
Andrei Zavatski	d30ae24f58	Use Bindable for setting score	2019-07-14 12:40:54 +03:00
Andrei Zavatski	0584ee9ce5	Basic implementation	2019-07-14 12:34:12 +03:00
Dean Herbert	19e8198bff	Merge branch 'master' into flow_container_insert	2019-07-11 22:53:57 +09:00
Dean Herbert	3b448b0086	Merge remote-tracking branch 'upstream/master' into Desconocidosmh-master	2019-07-11 00:25:35 +09:00
Dean Herbert	6819c528db	Use canBeNull instead of needlessly caching MusicController for tests	2019-07-11 00:20:01 +09:00
Dean Herbert	b225b2eb39	Rename to IsUserPaused	2019-07-11 00:18:19 +09:00
iiSaLMaN	38bc652bf2	Remove sorting by length for beatmaps	2019-07-09 17:02:51 +03:00
iiSaLMaN	e0c1fb7818	Compare by milliseconds for length	2019-07-09 14:47:54 +03:00
Desconocidosmh	2546f647be	Completely change the way we fix the bug	2019-07-09 11:32:49 +02:00
Desconocidosmh	338371c3fc	Fix music playing while exiting from editor	2019-07-09 00:08:18 +02:00
iiSaLMaN	5f3f59629e	Use the length field instead of recalculating	2019-07-08 11:55:07 +03:00
iiSaLMaN	129899f419	Add a BPM property in BeatmapInfo	2019-07-08 10:43:35 +03:00
iiSaLMaN	90d5484818	Return BPM back to OnlineInfo ... Revert commit of "Move BPM out of OnlineInfo"	2019-07-08 09:10:41 +03:00
iiSaLMaN	729f0901f7	Move Length out of OnlineInfo	2019-07-07 20:25:36 +03:00
iiSaLMaN	3ea9629daf	Move BPM out of OnlineInfo	2019-07-07 20:11:44 +03:00
iiSaLMaN	6ee10640e3	Remove unnecessary migration + Fix CI issues	2019-07-07 19:26:41 +03:00
iiSaLMaN	b4ef64fa61	Add sorting by Length	2019-07-07 18:26:56 +03:00
iiSaLMaN	65c8249c94	Add beatmap extension for calculating length	2019-07-07 18:25:52 +03:00
iiSaLMaN	188c80374e	Add sorting by BPM	2019-07-07 18:14:23 +03:00
Dean Herbert	ebc0e50295	Simplify conditions	2019-07-07 13:21:41 +09:00
Joseph Madamba	7c0e3a50b6	Merge branch 'master' into fix-unranked-map-lb-placeholder	2019-07-06 12:09:28 -07:00
Dean Herbert	2149d639de	Merge branch 'master' into leaderboard-mod-filter	2019-07-06 13:27:49 +09:00
Dean Herbert	adf6d6c942	Update initial run import process to include scores	2019-07-05 14:25:52 +09:00
Joehu	1534b75d27	Fix ci errors	2019-07-04 21:39:21 -07:00
Joehu	e8168037f9	Fix unranked beatmap leaderboards showing "no records" placeholder	2019-07-04 21:19:51 -07:00
naoey	1dab363be3	Require supporter for filtering mods on online leaderboards	2019-07-05 08:42:44 +05:30
naoey	98a242cc37	Merge remote-tracking branch 'ppy/master' into leaderboard-mod-filter	2019-07-05 08:38:33 +05:30
Dean Herbert	91d461eba7	Merge pull request #5251 from Joehuu/remove-edit-song-select-file ... Remove unused EditSongSelect file	2019-07-05 10:30:37 +09:00
Joehu	5f6544eebf	Fix beatmap leaderboards requiring supporter when signed out	2019-07-04 12:05:07 -07:00
naoey	f04adb7192	Apply mods filter to local scores too	2019-07-04 22:38:33 +05:30
Joehu	9b2ebed669	Remove unused EditSongSelect file	2019-07-04 08:36:34 -07:00
naoey	99606a018b	Merge remote-tracking branch 'upstream/master' into leaderboard-mod-filter	2019-07-03 19:35:08 +05:30
naoey	4ba60ed089	Apply currently selected mods to filter leaderboard scores ... Modifies GetScoresRequest to build query string locally instead of using WebRequest.AddParameter since it doesn't support array parameters	2019-07-03 17:04:20 +05:30
naoey	ccae4ce95e	Fix local beatmap leaderboard displaying scores from all game modes	2019-07-03 14:39:11 +05:30
Roman Kapustin	9037fb59de	Make BeatmapOptionsButton insertion cleaner	2019-07-01 18:42:18 +03:00
Dean Herbert	8703f0ad40	Change song select initialisation to promote db context sharing	2019-06-30 22:23:48 +09:00
Dean Herbert	9e1cb90dd8	Remove existing argument for ItemAdded event ... For all usages, it looks like this was unnecessary.	2019-06-26 11:40:41 +09:00
smoogipoo	1a26608ba9	Close mod select before exiting song selection	2019-06-25 18:33:21 +09:00
smoogipoo	d9927204f8	Relieve OsuScreen of back button input duties	2019-06-25 18:33:18 +09:00
smoogipoo	8c96e4c1fa	Move back button to OsuGame	2019-06-25 18:33:08 +09:00
Ganendra Afrasya	d540565197	Merge branch 'master' into difficulty-icon-tooltip	2019-06-22 11:54:00 +07:00
Dan Balasescu	8ab7a8641b	Add comment for why it's not a fill flow	2019-06-21 12:42:35 +09:00
David Zhao	65c84428cc	Fix position of gradient in beatmap carousel	2019-06-20 15:05:15 +09:00
Dean Herbert	d0a452cdf9	Show tooltips for beatmap set panels	2019-06-20 01:10:03 +09:00
Dean Herbert	2b48f5d3e0	Tidy up updateMetrics flow	2019-06-15 14:45:51 +09:00
Dean Herbert	587edcb716	Merge branch 'master' into fix-beatmapoverlay-graphs	2019-06-15 13:42:13 +09:00
Dean Herbert	bc574520bf	Update ScrollContainer usages in line with framework changes	2019-06-14 15:55:32 +09:00
smoogipoo	f54f6e552b	Fix beatmap details potentially using the incorrect metrics	2019-06-13 18:04:42 +09:00
smoogipoo	583bb53f53	Remove GetBeatmapDetailsRequest	2019-06-13 16:57:19 +09:00
smoogipoo	0a79b444d9	Move metrics to beatmap set	2019-06-13 16:52:49 +09:00
Dean Herbert	021d0273f9	Split out user activity from user status (#4619) ... Split out user activity from user status Co-authored-by: Dean Herbert <pe@ppy.sh>	2019-06-12 20:14:03 +09:00
smoogipoo	243cd517ad	Merge remote-tracking branch 'origin/master' into backgrounded-beatmap-status-lookups ... # Conflicts: # osu.Game.Tests/Visual/SongSelect/TestScenePlaySongSelect.cs	2019-06-12 17:24:16 +09:00
Dean Herbert	20b43c20c8	Rename variables to remove redundant "screen" terminology	2019-06-12 16:33:15 +09:00
smoogipoo	13234fb4a4	Adjust comments a bit	2019-06-12 16:07:35 +09:00
Dean Herbert	a9c229b1ec	Merge remote-tracking branch 'upstream/master' into user-status-wiring	2019-06-12 16:00:35 +09:00
smoogipoo	5d3fa51360	Merge remote-tracking branch 'origin/master' into selection-update	2019-06-12 15:10:57 +09:00
Lucas A	15893bbb75	Drop UserActivity prefix for subclasses nested in UserActivity + Change status messages.	2019-06-11 19:41:48 +02:00
Dean Herbert	606be3d7ce	Merge branch 'master' into backgrounded-beatmap-status-lookups	2019-06-12 00:22:47 +09:00
Dean Herbert	609a82bc94	Update VisibilityContainer usage in line with framework	2019-06-11 15:13:58 +09:00
Lucas A	141775d98c	Merge remote-tracking branch 'upstream/master' into user-status-wiring	2019-06-10 21:41:00 +02:00
Dean Herbert	d7cb932606	Merge branch 'master' into selection-update	2019-06-10 17:51:40 +09:00
Dean Herbert	600503ec8e	Use Task.Run/Wait to avoid warnings	2019-06-10 13:42:29 +09:00
Lucas A	a2bc5b538e	Merge remote-tracking branch 'upstream/master' into user-status-wiring	2019-06-05 16:59:38 +02:00
smoogipoo	a6dc5606bc	Allow beatmapsets to be sorted by date added	2019-06-05 18:17:43 +09:00
David Zhao	4f09141718	remove extra bool	2019-05-29 12:22:34 +09:00
Dean Herbert	a20eda7b5f	Fix remaining cases to work without things	2019-05-28 23:54:42 +09:00
David Zhao	1a871af552	Fix hide selection, add test	2019-05-28 19:15:29 +09:00
Dean Herbert	4ca34bd5e8	Update osu! in line with audio subsystem refactor	2019-05-28 17:06:01 +09:00
David Zhao	e59a00ac6e	Remove excessive selection updating	2019-05-28 14:04:33 +09:00
Lucas A	55663b3576	Nest all UserActivities into UserActivity	2019-05-12 17:38:02 +02:00
Lucas A	5ac6bd8204	Merge remote-tracking branch 'upstream/master' into user-status-wiring	2019-05-12 11:53:30 +02:00
Dean Herbert	9add2562f9	Close beatmap options when suspending (#4761) ... Close beatmap options when suspending	2019-05-12 15:50:10 +09:00
Dean Herbert	790700d8bf	Use more correct calculation	2019-05-12 15:40:58 +09:00
Joehu	175daac16a	Close beatmap options when suspending	2019-05-11 21:26:42 -07:00
Joehu	29cec54b3c	Fix beatmap carousel overlapping beatmap info wedge	2019-05-11 20:08:45 -07:00
Dean Herbert	4f697e2bd5	Add licence header	2019-05-08 19:35:20 +09:00
Dean Herbert	6dea16f365	Move action and hotkey specification local	2019-05-08 19:29:43 +09:00
Dean Herbert	c91b9c6032	Add missing button	2019-05-08 19:27:53 +09:00
Dean Herbert	772eb460fb	Move button definitions to their respective classes	2019-05-08 19:03:26 +09:00
Dean Herbert	0693290ad4	Merge remote-tracking branch 'upstream/master' into refactor-select-footer	2019-05-08 18:43:21 +09:00
Dean Herbert	b33372ca62	Don't expand mods in button on hover	2019-05-08 18:43:15 +09:00
Dean Herbert	8906eb874a	Fix CI issues	2019-05-08 18:43:06 +09:00
Dean Herbert	9a9ac05cd9	Fix post-merge issues	2019-05-08 18:42:54 +09:00
Lucas A	a5f758b977	Merge remote-tracking branch 'upstream/master' into user-status-wiring	2019-05-07 18:27:14 +02:00
smoogipoo	d7c09e7dbd	Merge remote-tracking branch 'origin/master' into fix-new-inspections ... # Conflicts: # osu.Game.Rulesets.Catch/Judgements/CatchDropletJudgement.cs # osu.Game.Rulesets.Catch/Judgements/CatchJudgement.cs # osu.Game.Rulesets.Mania/Scoring/ManiaScoreProcessor.cs # osu.Game.Rulesets.Osu/Replays/OsuAutoGenerator.cs # osu.Game.Rulesets.Osu/UI/Cursor/CursorTrail.cs # osu.Game.Tests/Visual/SongSelect/TestCaseBeatmapScoresContainer.cs # osu.Game/Graphics/OsuFont.cs # osu.Game/Online/API/Requests/Responses/APILegacyScoreInfo.cs # osu.Game/Overlays/Profile/Header/BadgeContainer.cs # osu.Game/Overlays/Profile/ProfileHeader.cs # osu.Game/Screens/Select/PlaySongSelect.cs # osu.Game/Skinning/LegacySkinDecoder.cs	2019-05-07 13:20:17 +09:00
Lucas A	d5d31282e5	Rename InitialScreenStatus to InitialScreenActivity in Editor / Player classes	2019-05-05 20:55:42 +02:00
Dean Herbert	41ab82cdc3	Merge branch 'master' into refactor-select-footer	2019-05-03 21:46:41 +09:00
LeNitrous	31341bfeb1	use SongSelect's SelectedMods property to ensure it exists	2019-05-03 16:51:33 +08:00
LeNitrous	009eaa647a	fixes to FooterButtonRandom	2019-05-03 16:38:15 +08:00
Lucas A	5d4aa5a12e	Add ScreenStatus property to change the OsuScreen's status + Renamed old ScreenStatus property to InitialScreenStatus	2019-05-02 20:51:19 +02:00
Lucas A	7e42068a14	Merge remote-tracking branch 'upstream/master' into user-status-wiring	2019-04-28 19:48:35 +02:00
Dean Herbert	d40177f97c	Merge branch 'master' into drawnode-composability	2019-04-27 18:41:19 +09:00
smoogipoo	0bd35ab7bb	Turn on warnings, resolve issues	2019-04-25 17:36:17 +09:00
Lucas A	5887008fb3	Merge branch 'master' into user-status-wiring	2019-04-15 11:43:53 +02:00
LeNitrous	2d227d25cc	fix appveyor warnings	2019-04-14 07:55:15 +08:00
LeNitrous	91c327a90f	use ModDisplay	2019-04-14 07:22:31 +08:00
Lucas A	da5d6cb1d4	Add Beatmap fields to UserStatusSoloGame & UserStatusEditing so they can carry metadata about the played / edited beatmap	2019-04-12 22:54:35 +02:00
LeNitrous	01cc78108c	add random button	2019-04-11 05:47:32 +08:00
LeNitrous	b4d0755818	please appveyor	2019-04-10 22:10:09 +08:00
LeNitrous	22f9339b01	let mods button have selected mod icons	2019-04-10 21:53:13 +08:00
smoogipoo	0222424aef	Make mods IReadOnlyList<Mod> gamewide ... Prevents potential multiple evaluations of enumerable.	2019-04-10 17:20:36 +09:00
smoogipoo	4310f07a5c	Rename SelectedMods -> Mods	2019-04-10 12:03:57 +09:00
smoogipoo	cbb3fdaca8	Fix various crashes due to bindable being disabled	2019-04-09 12:59:32 +09:00
smoogipoo	ad124bfeec	Reimplement select mod track adjustments	2019-04-09 12:59:32 +09:00
smoogipoo	c584967eb1	Remove mods from workingbeatmap	2019-04-09 12:59:32 +09:00
smoogipoo	772bef91fa	Merge remote-tracking branch 'Joehuu/master' into drawnode-composability ... # Conflicts: # osu.Game.Rulesets.Osu/UI/Cursor/OsuCursorContainer.cs	2019-04-08 23:01:12 +09:00
Ferdinand Bachmann	d431ca4efc	BeatmapLeaderboard: use OrderByDescending instead of negation ... (suggested by peppy)	2019-04-07 13:26:35 +02:00
theFerdi265	cb3532e7d4	BeatmapLeaderboard: fix local scores not being sorted	2019-04-06 00:53:02 +02:00
Samuel Van Allen	bb516da5b6	Removed redundant empty argument list	2019-04-03 22:57:05 +08:00
Samuel Van Allen	3660924441	Trimmed whitespace	2019-04-03 22:40:20 +08:00
Samuel Van Allen	4d60f6fb6a	Use collection initializer and added missing blank line	2019-04-03 22:37:50 +08:00
Samuel Van Allen	73c7c6c316	Hides "Details" button when OnlineBeatmapID is null	2019-04-03 21:44:36 +08:00
Dean Herbert	f1952c0816	Update font awesome usage	2019-04-02 19:55:24 +09:00
smoogipoo	a56e29347f	Adjust namespaces	2019-04-02 14:51:28 +09:00
Dean Herbert	c39c37a18d	Apply more missed cases	2019-04-01 12:44:46 +09:00
Dean Herbert	612db31c38	Apply newline additions	2019-04-01 12:16:32 +09:00
Dean Herbert	d6f8dbfd5c	Merge branch 'master' into wedge-fix	2019-03-29 12:23:42 +09:00
Dean Herbert	26a73b4a65	Merge branch 'master' into correct-preview-loop	2019-03-29 12:00:58 +09:00
Dean Herbert	759c5b3db9	Restore previous resume behaviour for the time being	2019-03-29 10:52:26 +09:00
Dean Herbert	3b1f83da1d	Merge remote-tracking branch 'upstream/master' into correct-preview-loop	2019-03-29 10:31:15 +09:00
Dean Herbert	de80fc0eac	Update icon usage to match framework changes	2019-03-27 19:29:27 +09:00
Unknown	fea6adbf54	fix wedge bleeding into other elements (and being misaligned)	2019-03-27 10:12:09 +01:00
Dan Balasescu	5de99f3f5b	Merge branch 'master' into fix-random-select-crash	2019-03-22 14:11:06 +09:00
Dean Herbert	37010f97d7	Fix random select crashing ... Closes #3383.	2019-03-21 21:02:54 +09:00
Dean Herbert	a10e43410a	Fix song select potentially starting play before the carousel (and bindables) have been initialised	2019-03-21 20:52:34 +09:00
Dean Herbert	4789aa81cb	Add an explicit flag for tracking song select's bindable binding ... Not required (this change does not affect logic) but improves clarity.	2019-03-21 20:52:15 +09:00
Dean Herbert	96dba6a20d	Move nested method to bottom of class	2019-03-21 20:51:21 +09:00
Dean Herbert	e2503888a4	Expose carousel's loaded flag	2019-03-21 20:51:06 +09:00
David Zhao	2646126d86	Merge remote-tracking branch 'upstream/master' into visual-settings-container	2019-03-20 14:29:20 +09:00
David Zhao	15637f9c4a	Rework instant blur logic such that updateVisuals doesn't need to be public	2019-03-20 14:17:35 +09:00