h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-11-19 03:03:21 +08:00
Code Issues Releases Wiki Activity
44,659 Commits 3 Branches 657 Tags 364 MiB
59bd13c154
Commit Graph

6468 Commits

Author SHA1 Message Date
PercyDan54
44d540eb53
Add test 2021-07-04 22:09:23 +08:00
Bartłomiej Dach
c143a50b73
Merge branch 'master' into fix-zero-hit-score-submit 2021-07-04 15:31:38 +02:00
Bartłomiej Dach
19f02dc3d9 Ensure tests with no token have at least one hit 
Because submission can be prevented by both not having been issued a
correct submission token, and by not actually registering any hits in
gameplay, ensure that tests that don't receive a token register at least
one hit, to avoid potentially having test cases that test the "no token"
flow pass erroneously because they never had any hits in the first
place.
 2021-07-04 14:34:52 +02:00
Dean Herbert
3ec7dc3bb9 Update tests in line with thread safety check 2021-07-04 17:59:39 +09:00
Dean Herbert
2a74b1c539 Add test coverage of new scenarios 2021-07-04 17:27:02 +09:00
Dean Herbert
ec71deec51 Remove some mentions of "lazer" 
I am aware there are more throughout the codebase but intentionally left
the remaining mentioned for one reason or another. The intention here is
to mainly change user-facing versioning to change the positioning of the
"lazer" term (to be where we would expect "cuttingedge" or "beta" to
be).
 2021-07-04 12:41:27 +09:00
Dean Herbert
b0f257fa04
Merge pull request #13685 from gagahpangeran/wiki-image-block 
Fix image overflow in wiki overlay
 2021-07-02 20:21:20 +09:00
Dan Balasescu
9eb6ae4d45
Merge pull request #13721 from peppy/submit-on-player-exit 
Submit scores on player exit
 2021-07-02 18:25:26 +09:00
Dean Herbert
4e52aee5a0
Merge branch 'master' into wiki-image-block 2021-07-02 18:19:46 +09:00
Dan Balasescu
211c248692
Merge pull request #13744 from peppy/fix-async-void-calls 
Fix some incorrectly invoked `async` calls
 2021-07-02 18:10:30 +09:00
Dean Herbert
d67fc87dcb Add some basic testability of external colour setting 2021-07-02 17:24:15 +09:00
Dean Herbert
7b0f970e7d Fix ongoing operation being begun in an async context 2021-07-02 16:09:02 +09:00
Dean Herbert
f2d9d78455 Fix some incorrectly invoked async calls 2021-07-02 14:43:48 +09:00
Dean Herbert
30467191b2 Remove local handling of NoFail addition 2021-07-02 14:21:48 +09:00
Bartłomiej Dach
434c048d87 Merge branch 'master' into colour-picker 2021-07-02 01:03:00 +02:00
dependabot[bot]
0d3de488de
Bump NUnit3TestAdapter from 3.17.0 to 4.0.0 
Bumps [NUnit3TestAdapter](https://github.com/nunit/nunit3-vs-adapter) from 3.17.0 to 4.0.0.
- [Release notes](https://github.com/nunit/nunit3-vs-adapter/releases)
- [Commits](https://github.com/nunit/nunit3-vs-adapter/compare/V3.17...V4.0.0)

---
updated-dependencies:
- dependency-name: NUnit3TestAdapter
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:17 +00:00
smoogipoo
4c95af4b16 Add star rating range display 2021-07-01 20:35:31 +09:00
Dean Herbert
a6323b7d87 Use APIException 2021-07-01 17:54:59 +09:00
Dean Herbert
74c63e15be Mark score failed on fail and exit 2021-07-01 17:48:09 +09:00
Dean Herbert
6e8d4e382e Add test coverage of token failure scenarios 2021-07-01 17:20:40 +09:00
Dean Herbert
397d2491b3 Update test scenes to actually cover submission logic 2021-07-01 16:55:44 +09:00
Dean Herbert
719852435f Fix intermittent PerformFromScreen test failures due to incorrect screen sequence 
These tests were manually pushing the `PlayerLoader` / `Player`
instances to `SongSelect`, which bypasses safeties in place which avoid
the exact issue that came up in https://github.com/ppy/osu/runs/2951759236
(see `AllowSelection` flag specifically).
 2021-07-01 15:10:29 +09:00
Bartłomiej Dach
583242d96d Add osu!-styled colour picker control 2021-06-30 23:25:50 +02:00
Dean Herbert
4a54e7cdb8 Add tests covering score preparation flow 2021-06-30 20:23:24 +09:00
smoogipoo
aa7405afa1 Increase number of sent frames to prevent timing issues 2021-06-30 20:16:57 +09:00
Dean Herbert
4a71a4bb21
Merge pull request #13450 from smoogipoo/spectator-start-at-end-2 
Start spectator at the end of gameplay
 2021-06-30 16:09:35 +09:00
Dean Herbert
094cd31361
Merge pull request #13441 from frenzibyte/ruleset-resources-skin 
Provide access to ruleset resources during `ISkinSource` lookups
 2021-06-30 15:26:37 +09:00
Dean Herbert
741ecbb2df Merge branch 'master' into spectator-start-at-end-2 2021-06-30 15:06:30 +09:00
Dean Herbert
4337577448 Remove unused private methods 2021-06-30 14:31:27 +09:00
Dean Herbert
a019f2cc5c
Merge branch 'master' into rework-multiplayer-test-scenes 2021-06-30 13:49:05 +09:00
Dean Herbert
825181121d
Merge branch 'master' into spectator-start-at-end-2 2021-06-30 01:50:14 +09:00
Dean Herbert
5031707048
Merge pull request #13690 from smoogipoo/fix-action-posting 
Fix commands posted to the wrong channel
 2021-06-30 00:39:02 +09:00
smoogipoo
331b7237ab Attempt to fix one more intermittent test failure 2021-06-29 23:02:20 +09:00
smoogipoo
6dd3c6fe93 Make MultiSpectatorScreen and tests more resillient to timing 2021-06-29 22:45:51 +09:00
smoogipoo
1b2d00f796 Trigger successes 2021-06-29 20:13:39 +09:00
Dean Herbert
8bcb4d13fb Fix multiple tests eating host exceptions 2021-06-29 17:21:09 +09:00
smoogipoo
8e04d73b67 Merge branch 'rework-multiplayer-test-scenes' into spectator-start-at-end-2 2021-06-29 17:06:57 +09:00
smoogipoo
ca0eaab8e2 Add test 2021-06-29 16:30:46 +09:00
smoogipoo
bcdf36e77b Merge branch 'master' into spectator-start-at-end-2 2021-06-29 15:53:58 +09:00
smoogipoo
92fa99700e Merge branch 'master' into rework-multiplayer-test-scenes 2021-06-29 15:39:59 +09:00
smoogipoo
06beeee4d8 Cleanup match header test 2021-06-29 15:39:01 +09:00
Gagah Pangeran Rosfatiputra
a1fe9df378
add test to check sprite image width 2021-06-29 10:14:51 +07:00
Dan Balasescu
697b07acb1
Merge branch 'master' into fix-beatmap-import-fk-failure 2021-06-29 11:36:31 +09:00
Gagah Pangeran Rosfatiputra
0e29ae037b
add wide image test 2021-06-28 20:50:29 +07:00
Gagah Pangeran Rosfatiputra
ab977d91f0
fix image test not load 
looks like forgot to change this after `CurrentPath` shenanigan
 2021-06-28 20:40:22 +07:00
Dan Balasescu
92fcf90768
Merge branch 'master' into import-early-checksum-abort 2021-06-28 19:29:08 +09:00
Salman Ahmed
035fe2ad49 Mark ruleset skin provider test scene as headless 2021-06-28 11:29:43 +03:00
Salman Ahmed
177bfe1234 Merge branch 'master' into ruleset-resources-skin 2021-06-28 11:16:37 +03:00
Dean Herbert
a8597b6213
Merge pull request #13658 from frenzibyte/fix-initial-ruleset-skin-loading 
Fix `RulesetSkinProvidingContainer` being potentially late in setting up skin sources
 2021-06-28 17:03:56 +09:00
Dean Herbert
f939e2603a Merge branch 'master' into localisable-tooltips 2021-06-28 15:29:42 +09:00
Dean Herbert
73bd88cb31 Simplify caching in test 2021-06-28 14:44:52 +09:00
Dean Herbert
fdd6778f36
Merge branch 'master' into fix-initial-ruleset-skin-loading 2021-06-28 14:35:34 +09:00
Dean Herbert
128f08ccba Fix test oversights 2021-06-28 10:42:28 +09:00
Dan Balasescu
9c0840268a
Merge pull request #13598 from JimmyC7834/supporter-only-filter-content 
Add supporter required placeholder in beatmap listing overlay
 2021-06-28 10:27:56 +09:00
Dean Herbert
90b87cbb9e Add back unidirectional online id check 2021-06-28 10:11:27 +09:00
Dean Herbert
9a96cd4a1d Revert "Remove comparison of online beatmap IDs during dedupe checks" 
This reverts commit 15af28d2a0.
 2021-06-28 09:54:18 +09:00
Dean Herbert
a1e8cc5444
Merge pull request #13669 from Naxesss/hitsound-checks 
Add hitsound checks
 2021-06-28 03:13:43 +09:00
Naxess
b58644106c Add nested hitobject tests for few hitsounds check 2021-06-27 15:58:00 +02:00
Naxess
1dbac76da5 Use local variables for common sample lists 2021-06-27 15:57:41 +02:00
Naxess
1d5bff1660 Add concurrent hitobjects test for few hitsounds check 
See https://github.com/ppy/osu/pull/13669#discussion_r659314980
 2021-06-27 15:26:52 +02:00
Naxess
c2ceb83bbb Move MockNestedHitObject to own class 2021-06-27 15:16:40 +02:00
Dean Herbert
cd9aa38d3d Add back ignore cases for intentionally broken tests 2021-06-27 20:24:16 +09:00
Dean Herbert
15af28d2a0 Remove comparison of online beatmap IDs during dedupe checks 2021-06-27 14:48:57 +09:00
Naxess
5642d321b7 Fix comments in few hitsounds check tests 2021-06-26 23:43:08 +02:00
Bartłomiej Dach
709e555566 Rename test steps for legibility 2021-06-26 20:27:15 +02:00
Bartłomiej Dach
b7c4fe2052 Rewrite test helpers to also handle clearing filters 2021-06-26 20:25:43 +02:00
Bartłomiej Dach
51888d0d5a Rename test methods 2021-06-26 20:24:42 +02:00
Naxess
82b64f5589 Add hitsounded with break test 2021-06-26 19:57:12 +02:00
Naxess
a5abc664f3 Add few hitsounds check tests 2021-06-26 19:21:15 +02:00
Naxess
7b9569a117 Add muted object check tests 2021-06-26 19:21:01 +02:00
Gagah Pangeran Rosfatiputra
4df4afe533
add test for overall difficulty filter query 2021-06-26 21:02:57 +07:00
Bartłomiej Dach
50c27d2635 Update usages of IHasTooltip in line with framework localisation changes 2021-06-25 19:10:04 +02:00
smoogipoo
d035633f95 Load participants list after joining room 2021-06-25 20:56:13 +09:00
smoogipoo
3e5ae7ea58 Don't join room in participants test 2021-06-25 20:44:00 +09:00
smoogipoo
1ed61b9b98 Fix up dependencies class names 2021-06-25 20:11:38 +09:00
smoogipoo
57f2b4f812 Fix incorrect parent class 2021-06-25 20:09:03 +09:00
Salman Ahmed
84c9ede966 Fix incorrect pushed changes 
This should've been in the original commit, but for some reason got
deleted out.
 2021-06-25 13:17:15 +03:00
smoogipoo
04cc390c41 Fix TestSceneMultiplayer resolving the wrong client 2021-06-25 19:16:54 +09:00
Salman Ahmed
8387acfe15
Merge branch 'master' into fix-initial-ruleset-skin-loading 2021-06-25 12:22:51 +03:00
Salman Ahmed
ff5e590d32 Add local source for testing 2021-06-25 12:09:07 +03:00
smoogipoo
a27a647ae7 Rename RoomDependencies -> OnlinePlayDependencies 2021-06-25 18:07:47 +09:00
smoogipoo
c0d2b41d4c Move SpectatorClient into multiplayer dependencies 2021-06-25 17:55:16 +09:00
Dean Herbert
51dd7fc238
Merge pull request #13622 from aitani9/mod-settings-dropdown-height 
Decrease the max dropdown height in mod settings
 2021-06-25 17:42:47 +09:00
smoogipoo
7aefbe3da1 Move UserLookupCache inside dependencies 2021-06-25 17:37:02 +09:00
Salman Ahmed
13ed52a990 Fix weird license misindent 
No idea how the hell that happened... R# silent about it, of course.
 2021-06-25 11:16:29 +03:00
Salman Ahmed
8d7705dc92 Test using a simple GetTexture lookup instead 
Presumes that `RulesetSkinProvidingContainer` doesn't allow falling back
to parent skins, whatsoever.
 2021-06-25 10:55:24 +03:00
Salman Ahmed
06e357647a OnBdl -> OnLoadAsync 2021-06-25 10:40:42 +03:00
Dean Herbert
5883922177 Remove mod multiplier completely 2021-06-25 16:36:31 +09:00
Salman Ahmed
8241fee4a8 Add failing test case 2021-06-25 10:05:50 +03:00
smoogipoo
d6ab08c958 Remove manual dependencies in TestSceneMultiplayerGameplayLeaderboard 2021-06-25 15:30:28 +09:00
smoogipoo
81a812e216 Rework MultiplayerTestScene to make use of OnlinePlayTestScene 2021-06-25 15:00:10 +09:00
smoogipoo
aa5d22d04a Remove "test container", make everything go through OnlinePlayTestScene 2021-06-25 13:02:19 +09:00
smoogipoo
8fba7d2423 Remove MultiplayerTestScene inheritance from simple test scenes 2021-06-24 21:02:29 +09:00
smoogipoo
a21cf87b5f Split room manager and allow overrides 2021-06-24 19:14:05 +09:00
smoogipoo
5115299e9a Merge RoomManagerTestScene into OnlinePlaySubScreenTestScene 2021-06-24 19:09:31 +09:00
smoogipoo
a7b5c3bed1 Add OnlinePlaySubScreenTestScene 2021-06-24 17:01:28 +09:00
smoogipoo
4af119a407 Re-namespace 2021-06-24 16:29:06 +09:00
smoogipoo
c9ec4b9da4 Remove RoomTestScene inheritance from simple test scenes 2021-06-24 16:02:20 +09:00
Dean Herbert
cd6f175375 Ensure beatmap is reloaded before each playlist room test run 2021-06-24 13:29:06 +09:00
Dean Herbert
1bbfbb0d8e Fix test that never should have worked 
This was only working by luck until now. It was "correctly" matching on
null online ID (see logic at
abc96057b2/osu.Game/Screens/OnlinePlay/Match/RoomSubScreen.cs (L199-L207)).

Now it works by actually matching on the online ID.
 2021-06-23 19:30:11 +09:00
Dean Herbert
f6180b7e6a Mark static methods as such 2021-06-23 17:37:26 +09:00
Dean Herbert
ed0552a9e8 Add failing test for FK constraint conflict on reimporting modified beatmap with scores present 2021-06-23 17:34:56 +09:00
Dean Herbert
151dfdfb79
Merge pull request #13627 from Joehuu/fix-multiplayer-exit-logic 
Fix multiplayer leave dialog not working on all exit operations
 2021-06-23 14:56:57 +09:00
Joseph Madamba
dc428da06c Fix test regression 2021-06-22 19:30:52 -07:00
Joseph Madamba
49000b9501 Add multiplayer leave navigation tests 2021-06-22 19:30:40 -07:00
Salman Ahmed
896c1dc202 Merge branch 'master' into ruleset-resources-skin 2021-06-22 20:36:49 +03:00
Dean Herbert
4cb9c6a842
Merge pull request #13423 from frenzibyte/transformers-per-skin 
Refactor ruleset skin transforming logic to be per-`ISkin` rather than one `ISkinSource`
 2021-06-22 21:24:56 +09:00
Salman Ahmed
bea828a364 Also pass empty resource in TestSceneDrawableRulesetDependencies 2021-06-22 13:17:34 +03:00
Salman Ahmed
37f7486fb1 Fix potential null reference in LINQ method 2021-06-22 12:25:29 +03:00
Salman Ahmed
31cbb36a64 Implement FindProvider and AllSources properly on all test ISkinSources 2021-06-22 12:03:14 +03:00
Dean Herbert
d1aac743ad Merge branch 'master' into ruleset-shaders 2021-06-22 17:59:51 +09:00
Dean Herbert
6e0801b852 Fix incorrect existing test case 2021-06-22 17:41:27 +09:00
Dean Herbert
c4fde635c6 Ensure duplicate mods cannot be defined 2021-06-22 17:41:20 +09:00
Dean Herbert
0ad189e357 Expose skin sources via ISkinSource and revert to consuming based on hierarchy 2021-06-22 16:19:55 +09:00
Dean Herbert
1b0aadcc6f Merge branch 'master' into transformers-per-skin 2021-06-22 16:03:15 +09:00
JimmyC7834
0d17fb4259 fixed code 2021-06-22 13:53:21 +08:00
JimmyC7834
b42aedeb81 fixed code style 2021-06-21 14:43:54 +08:00
JimmyC7834
044c2aa99d Merge branch 'master' of https://github.com/JimmyC7834/osu into supporter-only-filter-content 2021-06-21 14:27:54 +08:00
Joseph Madamba
8b2110c048 Add failing discussion links test 2021-06-20 21:36:08 -07:00
Salman Ahmed
c933cbe89d Add sample shaders and test case for ruleset-specific shaders 2021-06-21 00:10:29 +03:00
Salman Ahmed
eabcbd1d42 Consider shader manager for ruleset dependencies disposal testing 2021-06-21 00:10:29 +03:00
JimmyC7834
996503eb2d fixed filter text display, added visual tests 2021-06-20 21:23:54 +08:00
JimmyC7834
e7aeba8d03 added more visual tests 2021-06-20 18:28:43 +08:00
JimmyC7834
42fdfbb9a1 added visual tests 2021-06-20 17:17:07 +08:00
Dean Herbert
3f336d88ec
Merge pull request #11461 from peppy/realm-key-binding-store 
Add initial realm database implementation with KeyBindingStore migration
 2021-06-19 02:49:41 +09:00
Dean Herbert
89c27dcb10
Merge pull request #13517 from ekrctb/initial-entry 
Allow setting `Entry` of `PoolableDrawableWithLifetime` (including `DrawableHitObject`)
 2021-06-19 00:03:41 +09:00
Dean Herbert
c369beeaaa Merge branch 'master' into realm-key-binding-store 2021-06-18 16:52:35 +09:00
Dean Herbert
5933e0d2d9 Change CheckCompatibleSet to never deselect the current candidat when checking incompatibility 2021-06-18 13:17:32 +09:00
Dean Herbert
246ab41cc6 Remove special casing for user exit during storyboard outro 2021-06-17 18:11:15 +09:00
Dean Herbert
4b45d8318e
Merge branch 'master' into transformers-per-skin 2021-06-16 16:37:28 +09:00
ekrctb
55859938b1 Use object initializer syntax for hit object application in tests 2021-06-16 16:07:22 +09:00
Dean Herbert
66efc3c4de
Merge branch 'master' into realm-key-binding-store 2021-06-16 13:23:13 +09:00
Bartłomiej Dach
30703d518c Add failing assert for seasonal background equality 2021-06-15 23:19:33 +02:00
Dean Herbert
acc06ca398 Merge branch 'master' into realm-key-binding-store 2021-06-16 02:14:58 +09:00
smoogipoo
e79e1bbcc0 Fix malformed database test failing in single-threaded mode 2021-06-15 22:53:43 +09:00
Dean Herbert
fcb0b8d825 Add test coverage 2021-06-14 15:06:33 +09:00
Dean Herbert
b06477a1f5 Split out tests into individual test methods 2021-06-14 14:35:24 +09:00
Bartłomiej Dach
d3a255fd81 Add animated assets for legacy health display test 2021-06-11 14:27:58 +02:00
Dean Herbert
26312bf60a
Merge branch 'master' into chat-mention 2021-06-11 20:03:44 +09:00
smoogipoo
0a8daab4f7 Pause master clock when too far ahead 2021-06-11 19:15:53 +09:00
smoogipoo
e9ebbd298d Add a few more tests 2021-06-11 18:13:54 +09:00
smoogipoo
9eaaac6bb7 Remove master clock state assertions 2021-06-11 17:59:31 +09:00
Dean Herbert
16e3a19738 Fix notification overlay not being in correct place in test scene 2021-06-11 16:18:51 +09:00
Dean Herbert
f00967388a Refactor tests a bit 2021-06-11 16:17:42 +09:00
Dean Herbert
33aec57238 Replace 1.0 version in old skin test assets with none 2021-06-11 15:45:34 +09:00
Bartłomiej Dach
7fd26ff3b0 Merge branch 'master' into more-metadata-fields 2021-06-11 06:35:51 +02:00
Salman Ahmed
fe48ce4bd5 Remove unaccessed field 
It was a warning...
 2021-06-11 00:58:06 +03:00
Salman Ahmed
ca3c45363a Add test coverage 2021-06-11 00:25:22 +03:00
Bartłomiej Dach
24c249b17e Add test coverage 2021-06-10 22:40:49 +02:00
Bartłomiej Dach
417aaacc53 Add test coverage for romanised data transfer 2021-06-10 22:18:39 +02:00
smoogipoo
58d71e4aea Remove local "next frame" storage 2021-06-10 22:41:38 +09:00
Salman Ahmed
dde84e5cbd Merge branch 'master' into transformers-per-skin 2021-06-10 11:58:52 +03:00
Dean Herbert
5e80f454ce
Merge branch 'master' into results-screen-sfx 2021-06-10 17:25:35 +09:00
Dan Balasescu
479d6d3fc5
Merge branch 'master' into fix-beatmap-skin-disables 2021-06-10 16:37:58 +09:00
Dean Herbert
9a3ca09501
Merge pull request #13384 from bdach/fixed-label-width 
Align label widths of editor setup screen controls
 2021-06-10 14:55:49 +09:00
Dean Herbert
9044a20120 Merge branch 'master' into realm-key-binding-store 2021-06-10 13:58:08 +09:00
Gagah Pangeran Rosfatiputra
39e1f77d53
add image table with image content test 2021-06-10 09:37:33 +07:00
Dean Herbert
3d508f9266 Merge branch 'master' into results-screen-sfx 2021-06-10 11:28:35 +09:00
Salman Ahmed
6538d44708 Make SkinProvidingContainer able to perform lookup on multiple skins 
Currently `protected` functionality for use in custom `SkinProvidingContainer`s, can be exposed to public constructors if it need to later on, but I'm not sure about doing that opposed to just nesting multiple `SkinProvidingContainer`.
 2021-06-09 22:49:31 +03:00
Salman Ahmed
cf40282f1f Convert LegacySkinTransformers to accept raw ISkins rather than a full ISkinSource 2021-06-09 22:49:31 +03:00
Bartłomiej Dach
266c1e2e25
Merge branch 'master' into fix-beatmap-skin-disables 2021-06-09 18:43:15 +02:00
Bartłomiej Dach
7fe878299f
Merge branch 'master' into wiki-article 2021-06-09 16:24:45 +02:00
Dean Herbert
b02b8ae2bc
Merge pull request #13381 from smoogipoo/improve-hit-error-judgements 
Improve hit error judgement displays
 2021-06-09 19:40:17 +09:00
Dean Herbert
8fda04c2d9 Merge branch 'master' into results-screen-sfx 2021-06-09 18:00:11 +09:00
Dean Herbert
47eeab34e1 Remove redundant string interpolation 2021-06-09 17:34:47 +09:00
Dean Herbert
38fc9347be Add failing test coverage for beatmap skin disable 2021-06-09 16:19:04 +09:00
Bartłomiej Dach
5487012060 Add test coverage for default skin background cycling 2021-06-09 07:48:16 +02:00
Bartłomiej Dach
f628ec25ef Add test coverage for keeping same background instance 2021-06-08 22:31:09 +02:00
Bartłomiej Dach
d86ace4d11 Add test coverage for skin background source 2021-06-08 22:03:59 +02:00
Bartłomiej Dach
88266eac63 Add option to fix label width of a LabelledDrawable 2021-06-08 16:57:32 +02:00
smoogipoo
c8e14d7710 Ignore non-scorable and bonus judgements 2021-06-08 23:09:23 +09:00
Dean Herbert
25af4dfa8a
Merge pull request #13375 from smoogipoo/fix-multi-nullref 
Fix possible nullref when exiting song select too fast
 2021-06-08 20:47:40 +09:00
smoogipoo
ab9290772b Fix a similar case with online play sub-screens 2021-06-08 17:54:54 +09:00
Dean Herbert
6017ef3825
Merge branch 'master' into fix-skin-sample-lookup 2021-06-08 17:37:36 +09:00
smoogipoo
490ab9e96a Fix typo 2021-06-08 17:09:03 +09:00
smoogipoo
7fa0ac6ed7 Fix possible nullref when exiting song select too fast 2021-06-08 17:03:50 +09:00
Dan Balasescu
791855dfa0
Merge branch 'master' into legacy-skin-default-fallback 2021-06-08 16:54:26 +09:00
Dean Herbert
95852ccdf8 Merge branch 'master' into results-screen-sfx 2021-06-08 15:14:31 +09:00
Bartłomiej Dach
1b4771655a Adjust test scene to avoid cross-test interference 
* Move steps from ctor to a separate basic test.
* Wait for barrage to complete in basic test, as not doing so polluted
  state of other tests.
* Reset score processor after every test.
 2021-06-07 13:16:07 +02:00
Bartłomiej Dach
37d062c7cd Add failing assertions to hit error meter test 2021-06-07 13:16:07 +02:00
Bartłomiej Dach
122a624b7f Remove bogus CatchHitWindows 
`CatchHitWindows` were a vestige from the past, and were not actually
used anywhere except for the hit error meter test, giving off an
appearance that the hit error meter was working properly.
`CatchHitObject` actually specifies empty hit windows.
 2021-06-07 13:16:07 +02:00
Bartłomiej Dach
b192c46316 Merge branch 'master' into wiki-article 2021-06-07 11:19:20 +02:00
Dean Herbert
729e05241f Add more test coverage 2021-06-07 17:32:10 +09:00
Dean Herbert
f677f9b5f4 Stop BackgroundScreenDefault from reloading beatmap background when already correct 2021-06-07 17:22:36 +09:00
Dean Herbert
d26c9a66c2 Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup 2021-06-07 12:01:19 +09:00
Craftplacer
248e90df6d
Add more request handling code 2021-06-05 15:55:58 +02:00
Craftplacer
5e44329e0b
Add DummyAPIAccess request handler 
Make CreateChannelRequest.channel public
 2021-06-05 14:43:26 +02:00
Craftplacer
39c3b08fc7
Merge remote-tracking branch 'upstream/master' into chat-mention 2021-06-05 11:18:06 +02:00
Craftplacer
6e40af756b
Add request handler for dummy API 2021-06-05 11:10:16 +02:00
Gagah Pangeran Rosfatiputra
5febbe4530
rename method add entry 2021-06-04 23:32:42 +07:00
Gagah Pangeran Rosfatiputra
a82eeb6daf
tidy up sidebar test 2021-06-04 16:00:26 +07:00
Gagah Pangeran Rosfatiputra
3bf70dea60
fix test to using heading block 2021-06-04 15:51:23 +07:00
Dean Herbert
06275a6a7d Merge branch 'master' into legacy-skin-default-fallback 2021-06-04 16:00:30 +09:00
Gagah Pangeran Rosfatiputra
6c1fede18e
add wiki sidebar test scene 2021-06-04 13:11:37 +07:00
Dean Herbert
23096c58bb
Merge branch 'master' into fix-spectator-frame-conversion 2021-06-04 15:06:15 +09:00
Jamie Taylor
49fbd35e91
remove sound design tool 2021-06-04 14:21:40 +09:00
Dan Balasescu
0ba493d598
Merge pull request #13318 from gagahpangeran/error-page-placeholder 
Add error page placeholder for wiki overlay
 2021-06-04 12:20:21 +09:00
Gagah Pangeran Rosfatiputra
34379b953a
change test scene response 2021-06-04 09:36:21 +07:00
Gagah Pangeran Rosfatiputra
b36c406a83
add test scene for error page 2021-06-03 19:48:04 +07:00
Bartłomiej Dach
e117f98bfa Rename test steps 2021-06-03 14:31:13 +02:00
Bartłomiej Dach
acb4873157 Merge branch 'master' into keyboard_shortcuts 2021-06-03 14:09:48 +02:00
Jamie Taylor
8dc595d201
move result screen samples to DefaultSkin 2021-06-03 18:35:27 +09:00
Jamie Taylor
9ad87ee5dc
add sfx for results screen + sound design tool 2021-06-03 18:34:22 +09:00
smoogipoo
c3280083a2 Merge branch 'master' into fix-spectator-frame-conversion 2021-06-03 17:42:01 +09:00
Dan Balasescu
15b43beef1
Merge pull request #11857 from Syriiin/diffcalc/refactor/catch-clockrate-effects 
Refactor catch Movement skill to not require explicit clockrate usage
 2021-06-03 17:29:27 +09:00
smoogipoo
3bc81fbb06 Fix spectator tests 2021-06-03 17:27:24 +09:00
smoogipoo
420df124b5 Add framestable-bypassing seek for spectator 2021-06-03 17:27:21 +09:00
Dean Herbert
b917d6d80c Update tests to check for correct platform action keys 2021-06-03 15:34:06 +09:00
Samuel Cattini-Schultz
f51413ead9 Refactor to pass clockrate in constructor rather than deriving from mods 2021-06-03 16:09:42 +10:00
Dean Herbert
4a5d8215f3
Merge branch 'master' into keyboard_shortcuts 2021-06-03 14:47:40 +09:00
Dean Herbert
66dd7b7705 Update test logic to allow gameplay to properly continue 2021-06-03 14:38:50 +09:00
Dan Balasescu
44b1102241
Merge branch 'master' into autoplay-pause-support 2021-06-03 13:26:00 +09:00
Dan Balasescu
c065f761c7
Merge branch 'master' into legacy-skin-default-fallback 2021-06-02 19:08:52 +09:00
Dean Herbert
5366e7f61e
Merge branch 'master' into remove-hud-component-lookup 2021-06-02 16:10:06 +09:00
Dean Herbert
f8ae70e562 Update existing function type rather than adding an override 2021-06-02 16:04:53 +09:00
Dan Balasescu
47019196f6
Merge branch 'master' into fix-relative-link-resolution 2021-06-02 14:55:38 +09:00
Dean Herbert
e9d37bc892
Merge pull request #13285 from ppy/dependabot/nuget/Microsoft.NET.Test.Sdk-16.10.0 
Bump Microsoft.NET.Test.Sdk from 16.9.4 to 16.10.0
 2021-06-02 14:34:12 +09:00
Dean Herbert
45984f035b Make autoplay tests test via the ReplayPlayer code path 2021-06-02 11:49:06 +09:00
smoogipoo
8ee2b3a2d2 Merge branch 'master' into fix-scrolling-lifetime 2021-06-02 11:08:28 +09:00
Dan Balasescu
ac83450791
Merge pull request #13256 from ekrctb/update-lifetime-2 
Update DHO lifetime on entry lifetime change
 2021-06-02 11:07:54 +09:00
dependabot[bot]
967a7c3db5
Bump Microsoft.NET.Test.Sdk from 16.9.4 to 16.10.0 
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.9.4 to 16.10.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.9.4...v16.10.0)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-06-01 19:59:27 +00:00
Dean Herbert
e8aa5c4ecf Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup 2021-06-01 18:05:00 +09:00
Dean Herbert
cd139660ab Merge branch 'master' into legacy-skin-default-fallback 2021-06-01 18:04:54 +09:00
Dean Herbert
7a71cc1e82 Fix actually incorrect navigation test (can no longer retry from autoplay results) 2021-06-01 16:54:29 +09:00
Dean Herbert
1f8abcdf6c Merge branch 'master' into fix-relative-link-resolution 2021-06-01 16:49:02 +09:00
Salman Ahmed
7c6400735f Merge branch 'master' into remove-hud-component-lookup 2021-06-01 10:17:52 +03:00
Salman Ahmed
cb38abab35 Add local logic for creating default/legacy implementation based on cell skin 2021-06-01 10:17:01 +03:00
Salman Ahmed
cd8e3f3a04 Revert "Group all skinnable test scenes to one TestSceneSkinnableHUDComponents" 
This reverts commit d1272d5e13.
 2021-06-01 09:57:43 +03:00
Dean Herbert
dce24e3d4d
Merge pull request #12950 from gagahpangeran/osu-wiki-overlay 
Initial implementation of Wiki Overlay
 2021-06-01 15:20:56 +09:00
Dean Herbert
00ffea5e2c Update tests to specify full absolute path 2021-06-01 14:38:30 +09:00
ekrctb
0f381f7758 Fix wrong code 2021-06-01 14:38:02 +09:00
Dean Herbert
6ef9b346e1 Fix newly found inspections from 2021.1EAP1 2021-06-01 14:33:21 +09:00
ekrctb
977d44df87 Add test catching lifetime change while KeepAlive is true 2021-06-01 14:28:23 +09:00
Dean Herbert
a9f4bc6285 Never return a null argument 
Enable nullable
 2021-06-01 14:11:17 +09:00
Dean Herbert
1a05a5d2f0 Add test covering failure to resolve relative URLs 2021-06-01 13:50:04 +09:00
Dean Herbert
00b3eea840 Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup 2021-05-31 21:39:04 +09:00
Dean Herbert
3ff9f9c89d Make FindProvider non-default 2021-05-31 21:29:47 +09:00
smoogipoo
c787c008a5 Fix test potentially not waiting for player to load 2021-05-31 20:21:26 +09:00
Dean Herbert
17fa2426d4 Merge branch 'master' into legacy-skin-resource-improvements 2021-05-31 19:36:09 +09:00
Dean Herbert
ebfc24a499 Rename conflicting resources 2021-05-31 19:14:49 +09:00
Dean Herbert
b16d10bd95 Provide game-wide resources via IStorageResourceProvider 2021-05-31 18:57:47 +09:00
Dean Herbert
d4cb70735d Merge branch 'master' into non-nullable-beatmapset-files 2021-05-31 18:19:57 +09:00
Dan Balasescu
d8768a8c01
Merge pull request #13254 from peppy/fix-editor-beatmap-creation-test-failure-again 
Fix bindable lease failure in editor beatmap creation tests
 2021-05-31 17:38:19 +09:00
Dean Herbert
de0e51a81d Merge branch 'master' into fix-skin-sample-lookup 2021-05-31 15:27:39 +09:00
Salman Ahmed
02d18c7a49 Merge branch 'master' into remove-hud-component-lookup 2021-05-31 09:23:04 +03:00
ekrctb
771f3c48c0 Add failing test showing lifetime not recomputed with pooled objects 2021-05-31 14:48:52 +09:00
ekrctb
b7afea37c4 Test drawable lifetime change on entry lifetime change 2021-05-31 14:45:29 +09:00
Dan Balasescu
8c6277f0d8
Merge pull request #13235 from ekrctb/update-lifetime-1 
Update hit object lifetime on `HitObject.DefaultsApplied`
 2021-05-31 14:44:40 +09:00
Dean Herbert
5925beaf21 Fix bindable lease failure in editor beatmap creation tests 2021-05-31 14:24:46 +09:00
Bartłomiej Dach
ab077c6656
Merge branch 'master' into non-nullable-beatmapset-files 2021-05-31 00:10:03 +02:00
Bartłomiej Dach
78213e09d4
Merge branch 'master' into editor-exit-stability 2021-05-30 23:03:50 +02:00
Gagah Pangeran Rosfatiputra
3c7f1ae996
Merge branch 'master' into osu-wiki-overlay 2021-05-30 20:27:12 +07:00
Dean Herbert
f35cf2d846
Merge branch 'master' into main-page-wiki 2021-05-30 21:01:05 +09:00
Dean Herbert
dac1a98d8a Merge branch 'master' into fix-skin-sample-lookup 2021-05-30 15:19:47 +09:00
Salman Ahmed
200fecc774 Fix missing using directive 2021-05-29 21:22:39 +03:00
Salman Ahmed
42618c713f
Merge branch 'master' into legacy-beatmap-skin-hud-fallback 2021-05-29 20:56:05 +03:00
Dean Herbert
951fc5ef6e Remove misleading comment and misplaced bug fix 
This shouldn't be fixed in a test scene; the underlying issue should be
fixed in actual game code.
 2021-05-29 15:39:13 +09:00
Dean Herbert
9b239e308b Merge branch 'master' into beatmap-skin 2021-05-29 15:36:43 +09:00
ekrctb
265dfe5416 Add test case of DHO setting LifetimeStart in OnApply 2021-05-28 21:51:48 +09:00
ekrctb
68c5f4813e Add test of lifetime update on DefaultsApplied 2021-05-28 21:35:26 +09:00
Dean Herbert
8652ac05db Merge branch 'editor-exit-stability' into non-nullable-beatmapset-files 2021-05-28 18:58:35 +09:00
Dean Herbert
ba80361c4c Fix tests that were previously doing reference comparisons 2021-05-28 18:38:50 +09:00
Dean Herbert
6268bbea85 Merge branch 'master' into fix-skin-sample-lookup 2021-05-28 14:47:35 +09:00
Dean Herbert
581a86b91a Revert "Revert "Fix editor tests failing due to empty files being specified"" 
This reverts commit 1af684c4b2.
 2021-05-28 14:33:06 +09:00
Dean Herbert
f1b5aced6f Merge branch 'master' into editor-exit-stability 2021-05-28 14:32:32 +09:00
Dean Herbert
1af684c4b2 Revert "Fix editor tests failing due to empty files being specified" 
This reverts commit fdbd421040.
 2021-05-28 14:15:28 +09:00
Dan Balasescu
1ffafdd854
Merge branch 'master' into single-bind-reset-button 2021-05-27 23:55:28 +09:00
Dan Balasescu
1a0ace8d58
Merge branch 'master' into fix-slow-load-test-failure 2021-05-27 23:15:42 +09:00
Dan Balasescu
0a3d3bc006
Merge pull request #12958 from peppy/fix-invalid-ssdq-access 
Fix `BeatmapCarousel` accessing `ScreenSpaceDrawQuad` of non-loaded children
 2021-05-27 23:15:06 +09:00
Dan Balasescu
6ddb2062cf
Merge pull request #13214 from peppy/fix-multiplayer-leaderboard-test-failure 
Fix test failure in `TestSceneMultiplayerGameplayLeaderboard`
 2021-05-27 22:44:05 +09:00
Dan Balasescu
f45c934dd5
Merge pull request #13213 from peppy/fix-storyboard-outro-test-failure 
Fix test failures in `TestSceneStoryboardWithOutro`
 2021-05-27 21:51:13 +09:00
Dean Herbert
121dd175e6 Fix test failure in TestSceneMultiplayerGameplayLeaderboard 
The transfer of users was not accounting for the fact that the
`StartPlay` calls are now scheduled and not necessarily run in time.
 2021-05-27 19:57:21 +09:00
Dean Herbert
bcf1e3db1e Fix test failures in TestSceneStoryboardWithOutro 
Test was not accounting for the fact that the results may not have
loaded in time.
 2021-05-27 19:45:55 +09:00
Dean Herbert
a2ed85bf46 Fix broken formatting 2021-05-27 19:34:39 +09:00
Dean Herbert
0c4d4ee0d2 Fix collection import tests deadlocking due to TaskCompletionSource continuation triggering host disposal 2021-05-27 19:16:22 +09:00
Gagah Pangeran Rosfatiputra
0b600db814
revert back main page test 2021-05-27 16:24:05 +07:00
Gagah Pangeran Rosfatiputra
820310543d
fix spacing style 2021-05-27 14:53:22 +07:00
Dean Herbert
aa23c4a4b9
Merge branch 'master' into keyboard_shortcuts 2021-05-27 16:30:34 +09:00
Gagah Pangeran Rosfatiputra
b55ac413e7
add many scenario of main page layout 2021-05-27 14:20:36 +07:00
Dean Herbert
5c44083856 Fix test potentially not waiting for drawable beatmaps to be loaded 2021-05-27 16:12:49 +09:00
Dean Herbert
c39ea85701 Fix TestSceneSkinnableSound not doing DI correctly 2021-05-27 15:42:25 +09:00
Dean Herbert
70a844ac10 Remove allowFallback parameters completely 2021-05-27 14:50:42 +09:00
Craftplacer
2166ab87c6
Change base type of tests 
Fixes missing API property
 2021-05-27 01:47:00 +02:00
Gagah Pangeran Rosfatiputra
649163e13b
Merge branch 'master' into main-page-wiki 2021-05-26 23:51:49 +07:00
Dean Herbert
74fc0a17d5 Remove unused using statement 2021-05-27 00:55:06 +09:00
Dean Herbert
c0a8382175 Remove local API construction 2021-05-27 00:12:22 +09:00
Gagah Pangeran Rosfatiputra
22a5af750e
fix test link external 2021-05-26 20:25:48 +07:00
Dean Herbert
8e923a5d8f Instantiate immediately, rather than waiting for instantiation 2021-05-26 22:24:51 +09:00
Gagah Pangeran Rosfatiputra
fbfbd99223
change document url test to dev server 2021-05-26 19:20:39 +07:00
Dean Herbert
878079d3d7 Fix correct beatmap not being set if running test alone 2021-05-26 19:08:00 +09:00
Dean Herbert
a77de24746 Fix SlowLoadPlayer potentially not being instantiated in time for test 2021-05-26 18:58:18 +09:00
Dean Herbert
14a4095140 Merge branch 'master' into beatmap-skin 2021-05-26 18:39:47 +09:00
Dean Herbert
7c9383b586 Combine RestorableKeyBindingRow back into KeyBindingRow 2021-05-26 18:17:28 +09:00
Gagah Pangeran Rosfatiputra
71f77eb902
fix image test 2021-05-26 15:04:04 +07:00
Dean Herbert
98fa5b67d6
Merge branch 'master' into single-bind-reset-button 2021-05-26 17:01:16 +09:00
Dean Herbert
52ca2f4797 Merge branch 'master' into chat-mention 2021-05-26 16:00:26 +09:00
Swords
d5feb8353d Formatting, renaming 2021-05-25 21:37:08 +10:00
Swords
d9f5b578bf Restore class names 2021-05-25 21:08:40 +10:00
Dean Herbert
a249bb9e69 Merge branch 'master' into realm-key-binding-store 2021-05-25 17:18:33 +09:00
Dean Herbert
df703b68ec Merge branch 'master' into realm-key-binding-store 2021-05-25 13:41:48 +09:00
Gagah Pangeran Rosfatiputra
2e6d463901
add test link with title 2021-05-24 20:45:47 +07:00
Dean Herbert
37f6ceef79 Add test coverage 2021-05-24 21:57:04 +09:00
Swords
518999ffab Renaming files 2021-05-24 22:49:40 +10:00
Dean Herbert
29e1737f0d
Merge branch 'master' into mbd-beatmap-set-cover 2021-05-24 15:51:03 +09:00
Gagah Pangeran Rosfatiputra
0448f6fdb3
add main page markdown 2021-05-25 13:21:08 +07:00
Gagah Pangeran Rosfatiputra
b8a5b5aaf8
add test for image block and inline image 2021-05-23 17:22:31 +07:00
Salman Ahmed
afb33f1641 Remove no longer necessary test case 2021-05-21 20:21:50 +03:00
Salman Ahmed
4f6de6fdc6 Implement GetSkin() for other working beatmaps 2021-05-21 20:21:29 +03:00
Dan Balasescu
5ad41ded94
Merge branch 'master' into fix-dho-lmc 2021-05-21 19:11:57 +09:00
Dean Herbert
f335337e5d
Merge pull request #12851 from vininew921/applause-stops-on-score-switch 
Fix applause sound stopping after switching scores
 2021-05-21 18:49:59 +09:00
Dean Herbert
2958b9adf4 Merge branch 'master' into import-from-stable-select-location 2021-05-21 17:37:34 +09:00
Dean Herbert
1ca563e831 Merge branch 'master' into applause-stops-on-score-switch 2021-05-21 17:28:28 +09:00
Dean Herbert
8085a54205 Add test coverage of different grade types to TestSceneResultsScreen 2021-05-21 17:28:25 +09:00
Gagah Pangeran Rosfatiputra
49aa0f3a18
initial main page 2021-05-21 10:04:45 +07:00
Bartłomiej Dach
f35a07fee7 Rename method for better comprehension 2021-05-20 20:47:50 +02:00
Bartłomiej Dach
b521405ec8 Trim redundant string interpolation 2021-05-20 20:46:18 +02:00
Gagah Pangeran Rosfatiputra
092d0f9b76
add breadcrumb header test scene 2021-05-21 01:21:31 +07:00
Salman Ahmed
c0dfe37965 Remove unused using directive 2021-05-20 21:08:36 +03:00
Salman Ahmed
eaae9a1b67 Remove unrequired null conditional 2021-05-20 21:08:31 +03:00
Salman Ahmed
262a27610c Improve components assertion logic 2021-05-20 20:47:40 +03:00
Dan Balasescu
527847596e
Merge pull request #12884 from peppy/ternary-menu-item-refactor 
Create base implementations of the two most common `TernaryStateMenuItem`s
 2021-05-20 21:02:15 +09:00
Gagah Pangeran Rosfatiputra
1ad3aee126
add article page test wiki overlay 2021-05-20 17:49:20 +07:00
Dean Herbert
df5970fab4 Create base implementations of the two most common TernaryStateMenuItems 2021-05-20 19:34:53 +09:00
smoogipoo
a74405d0ed Merge branch 'master' into restructure-spectator-client 2021-05-20 18:53:42 +09:00
smoogipoo
9d07749959 Improve implementation of TestSpectatorClient 
There was a lot of weirdness here, such as storing the playing users,
clearing the playing users from test scenes (!!), and storing the users
being wathed.
This was all a thing because the previous implementation overrode the
base method implementations, which is no longer a thing.
 2021-05-20 17:41:46 +09:00
Dean Herbert
fdbd421040 Fix editor tests failing due to empty files being specified 2021-05-20 17:09:55 +09:00
Gagah Pangeran Rosfatiputra
1109970278
add more test for Wiki Header 2021-05-20 14:24:28 +07:00
ekrctb
3018a41ab5 Remove redundant string interpolation 2021-05-20 16:00:49 +09:00
smoogipoo
6beeb7f7c4 Rename SpectatorStreamingClient -> SpectatorClient 2021-05-20 15:55:07 +09:00
smoogipoo
d197a7f6f5 Rename multiplayer client classes 2021-05-20 15:39:45 +09:00
ekrctb
abf96db545 Add regression test for the pattern of using DHO proxy in LifetimeManagementContainer 2021-05-20 15:27:08 +09:00
Dean Herbert
80a714a9c4
Merge pull request #12857 from Joehuu/dev-register-no-warning 
Don't show warning screen when registering on dev server
 2021-05-20 14:05:53 +09:00
Dean Herbert
f1fd40dcca Fix test not working for various reasons 2021-05-20 13:19:00 +09:00
Joseph Madamba
85a3027f1b Add failing test 2021-05-19 13:58:41 -07:00
Salman Ahmed
97c8499884 Add test coverage 2021-05-19 23:01:41 +03:00
Salman Ahmed
71da960000 Extract assert step addition out of assertion method 2021-05-19 22:53:22 +03:00
Salman Ahmed
21ca9c8431 Merge branch 'master' into beatmap-skin 2021-05-19 22:39:32 +03:00
Salman Ahmed
6fc06a10a1 Add extensible test scene for beatmap skins fallback instead 2021-05-19 21:52:29 +03:00
Dean Herbert
363aec8179 Merge branch 'master' into hit-error-skinnable 2021-05-20 01:51:45 +09:00
Dean Herbert
b33d5e7a7a Add new test and assertions to existing DialogOverlay test 2021-05-19 17:04:45 +09:00
Vinicius Barbosa
4f397ae7f5
Merge branch 'master' into applause-stops-on-score-switch 2021-05-19 09:52:31 +02:00
Dean Herbert
87833bfb61
Merge pull request #12736 from EVAST9919/news-sidebar-new 
Implement NewsSideBar component
 2021-05-19 16:29:52 +09:00
smoogipoo
e8bc2cac5b Fix test not being marked as headless 2021-05-19 13:36:39 +09:00
Dan Balasescu
6717355fbe
Merge pull request #12627 from ekrctb/always-use-lifetime-entry 
Always use lifetime entry to manage hit objects in HitObjectContainer
 2021-05-19 13:12:01 +09:00
Andrei Zavatski
24af86689f Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new 2021-05-18 22:18:52 +03:00
Vinicius Barbosa
d05ffdf120 Added constants for delay value 2021-05-18 20:19:18 +02:00
Dan Balasescu
ef81bdf63f
Merge branch 'master' into always-use-lifetime-entry 2021-05-18 20:10:12 +09:00
ekrctb
ee9fe3c4be Revert "Add failing test showing lifetime not recomputed with pooled objects" 
This reverts commit b88e5a31
 2021-05-18 19:55:44 +09:00
smoogipoo
ab6a79f84c Simplify 2021-05-18 19:15:46 +09:00
smoogipoo
97f4f7bbd1 Remove Component inheritance 2021-05-18 18:59:45 +09:00
smoogipoo
633f841a0f Rename to HitObjectUsageEventBuffer 2021-05-18 18:57:02 +09:00
smoogipoo
a31a6947bb Add test 2021-05-18 18:49:05 +09:00
Salman Ahmed
d1272d5e13 Group all skinnable test scenes to one TestSceneSkinnableHUDComponents 2021-05-18 12:38:06 +03:00
Dean Herbert
c885ad87d5 Update HitErrorDisplay tests 2021-05-18 15:12:29 +09:00
Dean Herbert
06389c08dc Add basic test to show data how one would expect it to be displayed 2021-05-18 13:11:22 +09:00
Bartłomiej Dach
400984457c Fix weird behaviour in test scene 
Due to a callback set up in another place, clicking away from the 2022
year after launching the test scene would remove the 2022 button
(because the callback was returning metadata without it). For simplicity
just trim the 2022 year to make sure both test scenes use the same
consistent set of years.
 2021-05-17 19:16:30 +02:00
Lucas A
ed4c025c7e Fix other tests and move TestPlaySongSelect class declaration. 2021-05-17 12:55:59 +02:00
Lucas A
fe11426238 Disable appearance of the stable import prompt waiting for user interaction in tests, which caused them to fail. 2021-05-17 12:55:59 +02:00
Dean Herbert
da0913ca2d Make SongProgress a skinnable component 2021-05-17 18:52:56 +09:00
Andrei Zavatski
fc6e65b7db
Delete TestSceneNewsSideBar.cs 2021-05-17 12:02:06 +03:00
Andrei Zavatski
01090de1fd Fix filenames does not match contained type 2021-05-17 11:55:55 +03:00
Andrei Zavatski
586c5c7365 Emulate year changes in the test scene 2021-05-17 11:36:53 +03:00
Dean Herbert
ae1e62288d Reorder tests to not have the first test show nothing 2021-05-17 16:16:50 +09:00
Dean Herbert
22561cda19 MonthDropdown -> MonthSection 2021-05-17 16:02:21 +09:00
Dean Herbert
50e2b5a327 SideBar -> Sidebar 2021-05-17 16:00:36 +09:00
Swords
264d8b9b86 Finishing requested changes, and tidy up 2021-05-16 14:48:00 +10:00
Andrei Zavatski
881d82ccb6 Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new 2021-05-15 19:08:48 +03:00
Swords
b5e1f78c06
Merge branch 'master' into single-bind-reset-button 2021-05-15 20:29:56 +10:00
Swords
c282f0e603 Fixing tests 
For some reason moving the mouse and clicking doesn't work with "dotnet test", but works when you run the osu.Game.Tests project.
 2021-05-15 19:42:33 +10:00
Dean Herbert
dc56250a3c
Merge branch 'master' into player-loader-star-rating 2021-05-15 15:39:57 +09:00
Dean Herbert
94b7e89ac0
Merge pull request #12747 from frenzibyte/current-star-rating 
Allow changing current star difficulty of a `StarRatingDisplay`
 2021-05-15 15:39:39 +09:00
Dean Herbert
bdcb1a624e
Merge pull request #12759 from Naxesss/beatmap-verifier-context 
Encapsulate check arguments in context object
 2021-05-15 15:39:12 +09:00
Swords
ecc260030a
Merge branch 'master' into single-bind-reset-button 2021-05-15 12:05:42 +10:00
Swords
304caf8bdf Adding Requested changed 2021-05-15 11:24:08 +10:00
Bartłomiej Dach
7665bdfbbb Merge branch 'master' into null-assignment-warning-enable 2021-05-15 01:08:34 +02:00
Bartłomiej Dach
d581e0a252 Ignore possible nulls in NotifyCollectionChangedArgs 
Safe to access by the virtue of the preceding case labels on
`args.Action`.  And they're in test code anyways.
 2021-05-15 00:09:34 +02:00
Bartłomiej Dach
e62e473bb2 Ignore possible null in multiplayer test 
A null value will fail the test anyhow.
 2021-05-15 00:09:34 +02:00
Bartłomiej Dach
b51d038088 Ignore possible path-related nulls 
They're all in test code anyway, so any issue there will cause a test to
fail.
 2021-05-15 00:09:34 +02:00
Bartłomiej Dach
f2d0f7db99 Remove list null-checks in LogoTrackingContainer test 
If the null-checks were tripped, the test would crash anyway. It is not
possible to call `.Any()` and get a valid result instead of an exception
on a null reference.
 2021-05-15 00:09:34 +02:00
Bartłomiej Dach
c9facf70f9 Use conditional nullability attribute 
As it turns out, C# 8 provides an attribute that allows annotating that
an `out` parameter's nullability depends on the method's return value,
which is exactly what is desired here.
 2021-05-15 00:09:34 +02:00
Bartłomiej Dach
1c92b3a8f5 De-duplicate star rating display creation in test 2021-05-14 22:03:44 +02:00
Swords
843da30f9d Reformatting 2021-05-15 01:52:16 +10:00
Swords
6a52622b3f Merge branch 'single-bind-reset-button' of https://github.com/holaswords/osu into single-bind-reset-button 2021-05-15 01:31:40 +10:00
Swords
1603b92211 Reformatting 2021-05-15 01:30:54 +10:00
Swords
85174793b1
Merge branch 'master' into single-bind-reset-button 2021-05-15 01:07:32 +10:00
Swords
0725088fde Well it works, just pretty ugly looking. 2021-05-15 01:01:17 +10:00
Salman Ahmed
93007c1635 Merge branch 'current-star-rating' into player-loader-star-rating 2021-05-14 16:06:00 +03:00
Salman Ahmed
6cc678f497 Remove nullability and transition support from star rating display 2021-05-14 16:05:40 +03:00
Salman Ahmed
db361efecf Add test beatmap difficulty cache with calc. blocking support 2021-05-14 15:53:56 +03:00
Salman Ahmed
34aab11ff3 Add null star rating display test case 2021-05-14 14:25:46 +03:00
Salman Ahmed
0655825057 Separate changing star rating display to own test 2021-05-14 14:25:13 +03:00
Dean Herbert
9069db0743 Fix case of hitObjects variables 2021-05-14 16:22:19 +09:00
Dean Herbert
48672f8afd Add very basic test logic to ensure PlayerLoader is present for playlists 2021-05-14 15:02:36 +09:00
Naxess
9860e482af Use TestWorkingBeatmap instead of null in tests 
Fixes the warning that #12801 will give.
 2021-05-14 05:32:52 +02:00
Andrei Zavatski
94543bf000 Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new 2021-05-13 16:00:46 +03:00
Dan Balasescu
d5b14b6b99
Merge branch 'master' into remove-skinnable-hud-classes 2021-05-13 21:06:48 +09:00
Dan Balasescu
746862dcb1
Merge pull request #12750 from peppy/skin-serialisation 
Add skin editor saving / loading support
 2021-05-13 20:58:03 +09:00
Naxess
94538b3842 Remove accidental whitespace 2021-05-13 12:56:36 +02:00
Dan Balasescu
a3869c02f4
Merge branch 'master' into fix-two-hovered-handles 2021-05-13 19:24:42 +09:00
Dean Herbert
c8b7cfc753 Merge branch 'skin-serialisation' into remove-skinnable-hud-classes 2021-05-13 19:05:08 +09:00
Naxess
19800f5f7f Move IBeatmap arg into context 2021-05-13 11:24:22 +02:00
Dean Herbert
e0e9106921 Enable autoplay in skin editor tests 2021-05-13 14:55:11 +09:00
Naxess
e7c7786db3
Merge branch 'master' into beatmap-verifier-context 2021-05-13 07:40:33 +02:00
Dean Herbert
8b9ac86d4b Merge branch 'master' into skin-serialisation 2021-05-13 12:35:06 +09:00
smoogipoo
5b03092968 Fix possible test failure 2021-05-13 11:53:50 +09:00
Andrei Zavatski
13a956f6fc Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new 2021-05-12 20:08:17 +03:00
Dean Herbert
55e1f97f59 Remove unused using statement 2021-05-12 19:06:40 +09:00
Dean Herbert
0a895fff15 Remove remaining test usage of SkinnableXXX HUD components 2021-05-12 18:53:25 +09:00
Salman Ahmed
80e231d90a Add failing test case 2021-05-12 11:42:55 +03:00
Dean Herbert
c6f0a6aed3
Merge pull request #12538 from smoogipoo/multiplayer-spectator-screen 
Implement the multiplayer spectator screen
 2021-05-12 17:24:35 +09:00
smoogipoo
273cd18b8a Use test streaming client in gameplay leaderboard test 2021-05-12 14:19:36 +09:00
smoogipoo
21fc0ba43b Combine test spectator streaming client implementations 2021-05-12 13:05:02 +09:00
Naxess
c13b93e6f1 Replace IWorkingBeatmap arg with BeatmapVerifierContext in checks 
This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.

See next commit for example.
 2021-05-12 02:29:18 +02:00
Andrei Zavatski
085c3d067f Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new 2021-05-11 23:41:45 +03:00
Andrei Zavatski
b0297c6324 Fix incorrect no posts handling and add corresponding test 2021-05-11 20:52:11 +03:00
Andrei Zavatski
822d99e69f Remove pointless test scenes 2021-05-11 20:42:13 +03:00
Dean Herbert
048677846b Change HealthDisplay to be a CompositeDrawable 2021-05-11 23:10:30 +09:00
Andrei Zavatski
b79a0237a3 Fix TestSceneNewsYearsPanel error 2021-05-11 16:54:19 +03:00
Andrei Zavatski
c2ba16f977 Use relative sizing for MonthDropdown 2021-05-11 16:51:59 +03:00
Andrei Zavatski
208224cc0d CI fixes 2021-05-11 16:08:09 +03:00
Andrei Zavatski
705aad262a Rename MonthPanel to MonthDropdown 2021-05-11 15:42:40 +03:00
Andrei Zavatski
0a9c3c9413 Move metadata change logic to it's own method 2021-05-11 15:39:50 +03:00
Andrei Zavatski
9603712aa1 Cache metadata in NewsSideBar 2021-05-11 15:33:27 +03:00
Andrei Zavatski
82436334b2 Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new 2021-05-11 13:52:51 +03:00
smoogipoo
f5bc389998 Fix flaky tests 2021-05-11 19:31:32 +09:00
smoogipoo
bc4213eea1 Add test for changing back to idle on deletion 2021-05-11 19:26:58 +09:00
smoogipoo
7fe8737d94 Add failing tests 2021-05-11 19:21:44 +09:00
smoogipoo
811282a975 Add failing test 2021-05-11 19:01:41 +09:00
Dean Herbert
61ea3f2e64 Remove unnecessary test step creating needless skins 2021-05-11 18:39:15 +09:00
Dean Herbert
2396ba42a6 Change HealthDisplay to be a CompositeDrawable 2021-05-11 18:39:14 +09:00
Dean Herbert
004798d61d Update Legacy components to not require skin in ctor 2021-05-11 18:39:14 +09:00
smoogipoo
10a4a5decb Merge branch 'master' into multiplayer-spectator-screen 2021-05-11 17:33:09 +09:00
Dan Balasescu
7d9cdd3bc2
Merge branch 'master' into skin-components-list 2021-05-11 17:27:48 +09:00
Salman Ahmed
004ce95f33 Merge branch 'current-star-rating' into player-loader-star-rating 2021-05-11 09:53:10 +03:00
smoogipoo
7c8dd91674 Rename test to better match tested class 2021-05-11 09:29:15 +09:00
Dean Herbert
6bb52ebcf8
Merge pull request #12570 from frenzibyte/corner-rotation-controls 
Add rotation controls to editor selection box corners
 2021-05-10 23:09:44 +09:00
Andrei Zavatski
220eef0351 Remove overcomplicated date logic in MonthPanel 2021-05-10 17:00:18 +03:00
Andrei Zavatski
fbf8b198cd Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new 2021-05-10 16:47:15 +03:00
Dan Balasescu
e7355da201
Merge branch 'master' into osu-markdown 2021-05-10 20:02:04 +09:00
Dean Herbert
2ecd638f7f Merge branch 'master' into skin-components-list 2021-05-10 18:13:10 +09:00
Andrei Zavatski
0d243be457 CI fixes 2021-05-10 10:07:43 +03:00
Andrei Zavatski
4b97224932 Implement NewsSideBar component 2021-05-10 09:53:52 +03:00
Dean Herbert
97e72849af Fix regressed HitErrorDisplay behaviour (and localise binding to meter implementations) 2021-05-10 15:24:13 +09:00
Salman Ahmed
ca772b60b1 Use regular test steps rather than one-time set up and scheduling 2021-05-10 08:56:30 +03:00
Salman Ahmed
301dab1ce8 Refactor StarRatingDisplay to be mutable with a current bindable 2021-05-10 08:56:30 +03:00
Andrei Zavatski
7971a2ef48 Implement MonthPanel component 2021-05-10 08:47:00 +03:00
Andrei Zavatski
7ca3e13712 Implement basic years panel 2021-05-10 07:43:01 +03:00
Dean Herbert
52ce16f9f1
Merge branch 'master' into player-loader-star-rating 2021-05-10 12:46:10 +09:00
Dean Herbert
9ba412d27e Add the osu! logo to the test scene 
Makes no sense to add a test intended to test visual behaviour with one
of the main elements missing. Not sure how you would be able to test the
flow with the logo's presence.
 2021-05-10 12:44:08 +09:00
Dean Herbert
b7acf9de52 Make test work without manually clicking things 2021-05-10 12:36:56 +09:00
Dean Herbert
2b90bc4f1f Remove unnecessary ruleset switching steps 2021-05-10 12:35:37 +09:00
Dean Herbert
0c973feb53 Tidy up test scene 2021-05-10 12:34:21 +09:00
Dean Herbert
3c3500d070 Merge branch 'skin-components-bind-outwards-health' into remove-hud-overlay-unused-pieces 2021-05-10 12:23:18 +09:00
Dean Herbert
1d38fa29b5 Remove unused using statement 2021-05-10 12:23:04 +09:00
Dean Herbert
1bbbe80420 Fix missing instances of HealthProcessor caching 2021-05-10 12:22:24 +09:00
Dean Herbert
132bb7832d Fix some regressions when updating test scenes 2021-05-10 12:06:33 +09:00
Dean Herbert
b274fdf20d Merge branch 'master' into skin-components-bind-outwards-health 2021-05-10 11:13:44 +09:00
Joseph Madamba
8964d51de9 Add ability to sort by source in song select 2021-05-09 14:10:38 -07:00
Dean Herbert
2bcf1ed306
Merge pull request #12715 from Cublibre/fix-early-exit-crash 
Fix InvalidOperationException when exiting a map at the end
 2021-05-09 23:21:19 +09:00
Bartłomiej Dach
eb716455b7
Merge branch 'master' into skin-components-bind-outwards-accuracy 2021-05-09 12:13:18 +02:00
Andrei Zavatski
879c08e666 Use UntilStep instead of Assert to check button visibility 2021-05-09 10:06:36 +03:00
Andrei Zavatski
f0c1784d05 Use FirstOrDefault instead of First 2021-05-09 09:12:37 +03:00
Swords
1a465c60ca Rename Tests 2021-05-09 16:07:18 +10:00
Ibby
075350e125 Adding a reset button to individual keybinds 2021-05-09 15:51:17 +10:00
Andrei Zavatski
8868439ce4 Another approach to fix test scene failure 2021-05-09 06:49:12 +03:00
Andrei Zavatski
0818deac17 Fix potential test scene failure due to showMoreButton not being loaded in time 2021-05-09 06:06:34 +03:00
Christine Chen
ae2b5a0806 Actually test that player was exited 2021-05-08 22:42:14 -04:00
Andrei Zavatski
342c5a5938 Add tests to indicate the issue 2021-05-09 04:49:40 +03:00
Salman Ahmed
8fba655d2e Allow changing ruleset during test 2021-05-08 23:02:38 +03:00
Bartłomiej Dach
efb9164658 Restore previous test scene logic 2021-05-08 21:35:12 +02:00
Bartłomiej Dach
0bc6a026eb
Merge branch 'master' into skin-components-bind-outwards-accuracy 2021-05-08 21:08:53 +02:00
Salman Ahmed
f701c331f2 Add initial fade in to the metadata display 
Avoids first frame discrepancies from appearing in the test scene, those can be delt with later on, if needed.
 2021-05-08 21:19:46 +03:00
Bartłomiej Dach
dec5400c0a
Merge branch 'master' into skin-components-bind-outwards-score-display 2021-05-08 19:58:19 +02:00
Bartłomiej Dach
9e0ea494fd
Merge branch 'master' into skin-components-bind-outwards 2021-05-08 19:04:56 +02:00
Christine Chen
25312b3e88 Don't restart completion delegate on exit, revert exit behavior to lazer 2021-05-08 11:47:44 -04:00
Salman Ahmed
ca55287dd0 Pass empty facade and replace random property with method instead 2021-05-08 18:43:45 +03:00
Salman Ahmed
3575d9847c Use regular test steps rather than one-time set up and scheduling 2021-05-08 18:21:29 +03:00
Salman Ahmed
d9605e8070 Remove test scene description 2021-05-08 18:18:23 +03:00
Salman Ahmed
26c0010fe6 Fix test not handling 0 beatmap sets 2021-05-08 13:03:50 +03:00
Salman Ahmed
dca5efc59a Remove no longer necessary ruleset info requirement 2021-05-08 13:00:39 +03:00
Salman Ahmed
0410edecaf Refactor StarRatingDisplay to be mutable with a current bindable 2021-05-08 12:55:34 +03:00
Salman Ahmed
b4801faf32 Pass ruleset info to constructor instead 
Follows the way working beatmap is passed, not sure why mods are passed as a bindable though, don't wanna bother too much with that.
 2021-05-08 11:57:13 +03:00
Salman Ahmed
169a283402 Add visual test scene 2021-05-08 11:47:18 +03:00
Christine Chen
8c564a69ed Fix InvalidOperationException when exiting a map at the end 2021-05-07 21:11:03 -04:00
Dean Herbert
1cb10c2a22 Remove unnecessary binding logic from HUDOverlay 2021-05-07 17:51:46 +09:00
Dean Herbert
a7acecc52b Merge branch 'skin-components-bind-outwards-health' into remove-hud-overlay-unused-pieces 2021-05-07 17:51:41 +09:00
Dean Herbert
3044b1c432 Add missing cache rules 2021-05-07 17:50:44 +09:00
Dean Herbert
6c255a0572 Fix drain start time being weirdly incorrect 2021-05-07 17:47:33 +09:00
Dean Herbert
8e78cac058 Fix HealthProcessor cached as derived type in test 2021-05-07 17:31:29 +09:00
Dean Herbert
04d35826a3 Merge branch 'skin-components-bind-outwards-accuracy' into remove-hud-overlay-unused-pieces 2021-05-07 17:25:39 +09:00
Dean Herbert
84a4ff333e Update skin editor test scene to cache a ScoreProcessor 2021-05-07 17:22:56 +09:00
Dean Herbert
755588258e Update HealthDisplay components to use DI to attach data source 2021-05-07 17:22:45 +09:00
Dean Herbert
4ac234bf7f Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-accuracy 2021-05-07 17:15:57 +09:00
Dean Herbert
6dc591fc44 Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-score-display 2021-05-07 17:15:37 +09:00
Dean Herbert
9d27b11e49 Update skin editor test scene to cache a ScoreProcessor 2021-05-07 17:10:31 +09:00
Dean Herbert
01eff7f316 Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-score-display 2021-05-07 16:30:08 +09:00
Dean Herbert
93f10330e3 Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-accuracy 2021-05-07 16:29:10 +09:00
Dean Herbert
ad398165a2 Update AccuracyCounter components to use DI to attach data source 2021-05-07 16:27:25 +09:00
Dean Herbert
17b93361d5
Merge branch 'master' into skin-components-bind-outwards 2021-05-07 16:20:24 +09:00
Dean Herbert
a2e4fb5b6b Update ScoreCounter components to bind outwards 2021-05-07 16:16:48 +09:00
Dean Herbert
165f443ab5 Merge branch 'master' into add-missing-author-links 2021-05-07 14:32:44 +09:00
Dean Herbert
48b834d12a Merge branch 'master' into mbd-beatmap-set-cover 2021-05-07 13:19:17 +09:00
Gagah Pangeran Rosfatiputra
67f51959db
Merge branch 'master' into osu-markdown 2021-05-06 16:23:20 +07:00
Gagah Pangeran Rosfatiputra
91283d41ce
add paragraph test 2021-05-06 15:13:43 +07:00
Dean Herbert
aff32b0d19 Merge branch 'master' into skin-components-list 2021-05-06 14:17:33 +09:00
Bartłomiej Dach
3cac837acf
Merge branch 'master' into skin-bindables 2021-05-05 20:16:27 +02:00
Dean Herbert
cb8bda2248
Merge pull request #12503 from Denrage/split-BufferedWedgeInfo 2021-05-06 03:16:16 +09:00
Dean Herbert
fe9ade6754 Rename Container to DisplayedContent 2021-05-06 02:14:04 +09:00
Denrage
b6b9a69601 Removed unnecessary class for wrapping 2021-05-05 18:50:49 +02:00
Dean Herbert
4ef901d08d Remove unnecessary redirection property to Container.Info 2021-05-05 21:07:49 +09:00
Salman Ahmed
bf6e98345c Remove and update pre-existing test cases 2021-05-05 14:23:18 +03:00
Dean Herbert
805ef621e9
Merge branch 'master' into play-storyboard-outro 2021-05-05 17:51:16 +09:00
Dean Herbert
3cc9bad979 Actually check for correct state of fade content in rewind test 2021-05-05 17:49:33 +09:00
Dean Herbert
62fa638515
Merge pull request #12665 from frenzibyte/stable-frame-sort 2021-05-05 14:35:25 +09:00
Salman Ahmed
cd6d070b4a Consider "combo offsets" as legacy logic and separate from combo information 2021-05-05 07:43:08 +03:00
Salman Ahmed
78794935b4 Handle combo colour lookups in other skins 2021-05-05 07:15:11 +03:00
Christine Chen
1d4a8bc0ae Add visual test for rewinding 2021-05-04 22:23:36 -04:00
Salman Ahmed
12c1ded7a8 Fix test scene broken on master 2021-05-05 00:28:49 +03:00
Bartłomiej Dach
f7d9fb094e Reword & clarify comments 2021-05-04 22:59:10 +02:00
Salman Ahmed
1ac80d42f9
Merge branch 'master' into corner-rotation-controls 2021-05-04 23:53:23 +03:00
Bartłomiej Dach
9734758237 Simplify test case further 2021-05-04 22:48:57 +02:00
Salman Ahmed
45c0b74151 Use LINQ select for data assigning for simplicity 
To avoid having to read through all of frames and ensure nothing is failing there
 2021-05-04 23:41:50 +03:00
Salman Ahmed
4ceb9b1562 Avoid randomizing and overestimating logic with simple hardcoding 
Not sure what was in my mind while I was pushing that..
 2021-05-04 23:36:50 +03:00
Bartłomiej Dach
2fd596d53c Merge branch 'master' into mbd-beatmap-set-cover 2021-05-04 21:14:48 +02:00
Bartłomiej Dach
040d393dd4 Add visual test case for crossfade behaviour 2021-05-04 21:12:25 +02:00
ekrctb
39bccc5048 Revert "Adopt HitObjectContainer change in a test" 
This reverts commit f55aa016
 2021-05-04 16:45:24 +09:00
Salman Ahmed
e00af3e71d Add test coverage 2021-05-04 09:45:59 +03:00
Dean Herbert
bb9fa1a25e
Merge branch 'master' into play-storyboard-outro 2021-05-04 14:01:34 +09:00
Salman Ahmed
8abff4881b Hide the corresponding rotation handle when holding scale handle 2021-05-04 07:31:55 +03:00
Dean Herbert
4f12ae2711 Merge branch 'master' into split-BufferedWedgeInfo 2021-05-04 13:28:42 +09:00
Gagah Pangeran Rosfatiputra
356b1e9a2d
add emphases test 2021-05-04 05:43:59 +07:00
Bartłomiej Dach
f52375eed2 Merge branch 'master' into mbd-beatmap-set-cover 2021-05-03 15:58:13 +02:00
Bartłomiej Dach
b9220d4dc7 Fix possible multiple enumeration 2021-05-03 15:57:57 +02:00
Dean Herbert
4f8240f19a
Merge branch 'master' into corner-rotation-controls 2021-05-03 18:02:23 +09:00
Dean Herbert
625890381f Update ComboCounter components to use DI to attach data source 2021-05-03 17:43:00 +09:00
Dean Herbert
fdd0713988 Merge branch 'fix-selection-handler-visibility' into skin-bindables 2021-05-03 17:40:03 +09:00
Dean Herbert
3268a75f05 Remove intermediate container to fix tests 2021-05-03 17:35:56 +09:00
Dean Herbert
6da4105da6 Remove Sync namespace (feels unnecessary) 2021-05-03 13:38:53 +09:00
Dean Herbert
e0c129ca85 Merge branch 'master' into multiplayer-spectator-screen 2021-05-03 13:08:14 +09:00
Gagah Pangeran Rosfatiputra
b97d3f2af1
add heading test scene 2021-05-03 09:35:26 +07:00
Gagah Pangeran Rosfatiputra
88aaa9b332
add inline code colour 
Reference : 31579d45aa/resources/assets/less/bem/osu-md.less (L12-L17)
 2021-05-02 22:35:30 +07:00
Gagah Pangeran Rosfatiputra
6585dd3a3e
add image test 2021-05-23 16:30:41 +07:00
Gagah Pangeran Rosfatiputra
8f1b48d766
add test for notice box 2021-05-23 17:29:48 +07:00
Gagah Pangeran Rosfatiputra
5c1c43dea3
add link assert 2021-05-25 10:44:22 +07:00
Gagah Pangeran Rosfatiputra
98af998978
add test markdown class 2021-05-25 09:56:26 +07:00
Gagah Pangeran Rosfatiputra
a38c33841a
add test scene wiki container 2021-05-23 16:30:41 +07:00
Salman Ahmed
b145f46a0a
Merge branch 'master' into skin-components-list 2021-04-30 21:10:55 +03:00
Dan Balasescu
e6eea73b8b
Merge branch 'master' into basic-compose-checks 2021-04-30 23:41:46 +09:00
Dean Herbert
a1e64f4e3c Use the existing toolbox design 2021-04-30 14:41:06 +09:00
Gagah Pangeran Rosfatiputra
3681db491c
add long mixed list test 
Copied from https://github.com/ppy/osu-wiki/blob/master/wiki/Tournaments/OWC/2020/en.md#tournament-rules
 2021-04-30 11:21:20 +07:00
Dean Herbert
ae9d1dc40b Add component list to main editor interface and enable basic placement 2021-04-30 13:10:42 +09:00
Dean Herbert
6442fb819f Split out component from test scene and fix SongProgress 2021-04-30 13:10:42 +09:00
Dean Herbert
4770a64709 Add proof of concept components list 2021-04-30 13:10:42 +09:00
Gagah Pangeran Rosfatiputra
1582b0da88
add ordered list test 2021-04-30 10:43:19 +07:00
Dean Herbert
eeb66a955e
Merge branch 'master' into mbd-beatmap-set-cover 2021-04-30 08:14:33 +09:00
Dean Herbert
de73ac7cec Allow skin editor to be invoked from any context 
This is kind of how I see things working going forward, where the editor
can be applied to anything in the game which supports it (ie. a results
screen, gameplay screen, etc.) and it will immediately allow changing
the interface.

This adds a test scene which shows this working with gameplay.
 2021-04-29 16:12:15 +09:00
Dean Herbert
74c6fdc4b8 Add DrawableRuleset to the skin editor test to get a hit error meter to display 2021-04-29 16:12:15 +09:00
Dean Herbert
fd587a82ff Replace abstract class with interface, attached to the actual components (not skinnable wrapper) 2021-04-29 16:12:15 +09:00
Dean Herbert
defa350aa7 Set defaults on SkinnableHUDComponent to cancel out relative size default 
Specifying locally on each HUD component looks to make more sense.
 2021-04-29 16:12:15 +09:00
Dean Herbert
1cb8fc9a24 Extract editor classes out of test namespace and add anchor support 2021-04-29 16:12:15 +09:00
Dean Herbert
74fb7cd180 Extract storable attributes to bindables 2021-04-29 16:12:15 +09:00
Dean Herbert
99b428ee4b Add very basic skin editor test 2021-04-29 16:12:14 +09:00
Dean Herbert
fca173225a Refactor editor selection/blueprint components to be generic 2021-04-29 16:12:14 +09:00
Dean Herbert
2d17219c8f Setup basic test and classes for scale adjustment 2021-04-29 16:12:14 +09:00
Dean Herbert
5b009c21bb Merge branch 'master' into abstract-blueprint-handling 2021-04-29 16:10:22 +09:00
Gagah Pangeran Rosfatiputra
171e954e89
add unordered list test 2021-04-29 13:48:00 +07:00
ekrctb
5aa522b1c2 Completely delegate DHO lifetime to Entry lifetime 
A downside is lifetime update is not caught by LifetimeManagementContainer if used.
 2021-04-29 14:38:01 +09:00
ekrctb
b88e5a31ea Add failing test showing lifetime not recomputed with pooled objects 2021-04-29 14:38:01 +09:00
ekrctb
f55aa016be Adopt HitObjectContainer change in a test 
Non-pooled objects are attached as children only while alive
 2021-04-29 14:38:01 +09:00
dependabot[bot]
1b3b07d6a9
Bump NUnit from 3.13.1 to 3.13.2 
Bumps [NUnit](https://github.com/nunit/nunit) from 3.13.1 to 3.13.2.
- [Release notes](https://github.com/nunit/nunit/releases)
- [Changelog](https://github.com/nunit/nunit/blob/v3.13.2/CHANGES.md)
- [Commits](https://github.com/nunit/nunit/compare/v3.13.1...v3.13.2)

Signed-off-by: dependabot[bot] <support@github.com>
 2021-04-29 03:51:12 +00:00
Dean Herbert
6cadbd48dc
Merge pull request #12603 from smoogipoo/fix-score-processor-base-score 
Fix bonus-only maps having only 700K base score
 2021-04-28 17:30:58 +09:00
Dean Herbert
f3c7694eeb Rename methods to match generally how these find-methods are named elsewhere 2021-04-28 16:57:52 +09:00
Dan Balasescu
53d93fecd1
Merge branch 'master' into fix-download-button-import-cancel-state 2021-04-28 16:51:31 +09:00
Dean Herbert
48d6c9ac4b Move snap/divisor helper methods to inside ControlPointInfo 2021-04-28 16:47:30 +09:00
Dean Herbert
74bf4323d1
Merge pull request #12602 from smoogipoo/setting-source-custom-control 
Add support for custom controls to SettingSourceAttribute
 2021-04-28 16:39:17 +09:00
Dean Herbert
e71dbfd730 Add inline comment regarding remaining issues with classic scoring 2021-04-28 16:37:48 +09:00
Dean Herbert
8598a0968f
Update calculations in comments to match new logic 
Mostly look to be errors that existed before this PR.

Co-authored-by: Endrik <enduslittlecomputer@gmail.com>
 2021-04-28 16:29:23 +09:00
Dean Herbert
ac1534cda2 Add test covering existing button actually changing to LocallyAvailable state 2021-04-28 15:54:40 +09:00
Gagah Pangeran Rosfatiputra
4e691ce4b0
add test link with inline text markdown 2021-04-28 11:01:54 +07:00
Gagah Pangeran Rosfatiputra
c09067c3d5
add OsuMarkdownTable 2021-04-28 10:53:12 +07:00
Gagah Pangeran Rosfatiputra
736eace00a
add OsuMarkdownQuoteBlock 
Reference:
d56352aeef/resources/assets/less/base.less (L7-L10)
 2021-04-28 10:11:29 +07:00
Gagah Pangeran Rosfatiputra
6a921af085
add OsuMarkdownSeparator 
Reference
d56352aeef/resources/assets/less/bem/osu-md.less (L19-L21)
 2021-04-28 09:23:05 +07:00
smoogipoo
61b7dc1e06 Fix bonus-only maps having 700K base score 2021-04-28 03:42:29 +09:00
smoogipoo
4e3ee77396 Add support for custom controls to SettingSourceAttribute 2021-04-28 02:51:24 +09:00
Dan Balasescu
5fc731967b
Merge pull request #12592 from ekrctb/fix-entry-lifetime 
Fix Setting DHO's lifetime doesn't update its entry lifetime
 2021-04-28 01:38:19 +09:00
Naxess
b8b6d0e861 Add tests for ClosestBeatDivisor 
Used https://github.com/ppy/osu/pull/12558/files#diff-5c1f04c5b262ca3abbaf867aa91b62a60b66691323c286ad5aa0b75c153cc6ca as reference.
 2021-04-27 16:54:47 +02:00
smoogipoo
baa6e845aa Change to fluent assertions 2021-04-27 22:43:52 +09:00
smoogipoo
3b04aed491 Add failing test 2021-04-27 22:42:58 +09:00
Naxess
200352b750 Rename unsnap check templates 2021-04-27 13:56:05 +02:00
Dean Herbert
f2e56bd306 Refactor editor selection/blueprint components to be generic 2021-04-27 19:01:29 +09:00
ekrctb
003553aba3 Add test of HitObjectLifetimeEntry.KeepAlive behavior 2021-04-27 18:10:44 +09:00
Gagah Pangeran Rosfatiputra
6959f2a8cc
add OsuMarkdownFencedCodeBlock 
Reference :
d56352aeef/resources/assets/less/bem/osu-md.less (L41-L45)
 2021-04-27 16:01:32 +07:00
Gagah Pangeran Rosfatiputra
65aa01866e
add test scene for OsuMarkdownContainer 2021-04-27 14:38:21 +07:00
ekrctb
7980d16b4c Add failing test showing the issue of DHO lifetime 2021-04-27 14:26:12 +09:00
Naxess
0f0870c8b8 Sort objects by time in concurrent check test 2021-04-27 00:36:26 +02:00
Naxess
ce258febf6 Rename CheckUnsnaps -> CheckUnsnappedObjects 
Will potentially have `CheckUnsnappedKiai` or similar later, so this is worth specifying.

Also consistent with `CheckConcurrentObjects`, which will likely have a `CheckConcurrentLines` later.
 2021-04-26 20:32:44 +02:00
Naxess
b8cdcf56c0 Add concurrent object check tests 2021-04-26 20:22:24 +02:00
Naxess
71f880aa94 Fix duplicate code in unsnap test 2021-04-26 17:44:46 +02:00
Dean Herbert
5f6fd9ba13 Remove outdated dependency requirement in test 2021-04-26 19:07:42 +09:00
smoogipoo
94d0b06493 Expose mute adjustment instead 2021-04-26 19:01:30 +09:00
smoogipoo
4c5a5c449a Merge branch 'multiplayer-spectator-screen' of https://github.com/smoogipoo/osu into multiplayer-spectator-screen 2021-04-26 17:35:37 +09:00
smoogipoo
6626e70c95 Pass in master clock instead of slave clock 2021-04-26 17:30:27 +09:00
Dean Herbert
120fb8974d Combine more instances of test player IDs 2021-04-26 17:22:16 +09:00
smoogipoo
5b4cb71cc7 Change terminology from "slave" to "player clock" 2021-04-26 17:19:44 +09:00
Dean Herbert
737a15c2d4 Extract out test player IDs to constants 2021-04-26 17:04:39 +09:00
Dean Herbert
55f383c71e Rename test to match new MultiSpectatorLeaderboard class name 2021-04-26 16:48:40 +09:00
Dean Herbert
6d30a1a80f Reference constant for test startup delay 2021-04-26 16:45:20 +09:00
Dean Herbert
2c1422b4f9 Add comment regarding teste edge case 2021-04-26 15:37:19 +09:00
Naxess
9178aa1d7d Add unsnap check tests 2021-04-26 04:48:56 +02:00
Salman Ahmed
beee318acc Add more distance between each hit object in editor selection test 
To avoid potentially hovering over the rotation control instead of wherever the test desired to move the mouse to.
 2021-04-26 01:45:52 +03:00
Salman Ahmed
334927ed35 Remove leftover step 2021-04-25 20:13:01 +03:00
Salman Ahmed
7490511ebf Instantiate selection box on SetUp 2021-04-25 20:03:15 +03:00
Salman Ahmed
11318fd9fc Add test coverage 2021-04-25 10:17:36 +03:00
Dean Herbert
c0b1c2f39b
Merge branch 'master' into realm-key-binding-store 2021-04-24 02:40:15 +09:00
smoogipoo
b41897fd9b Rename testscene to match class 2021-04-23 19:23:52 +09:00
smoogipoo
b18635341e Rename file 2021-04-23 19:12:30 +09:00
smoogipoo
63a9484255 Expose WaitingOnFrames as mutable bindable 2021-04-23 19:11:47 +09:00
smoogipoo
b25340653d Fix failing tests 2021-04-23 00:49:14 +09:00
smoogipoo
4f0857f946 Xmldocs and general refactorings 2021-04-22 23:52:22 +09:00
smoogipoo
ee25949751 Rename classes 2021-04-22 23:39:02 +09:00
smoogipoo
f8f9cf9412 Merge branch 'fix-initial-playingusers' into multiplayer-spectator-screen 2021-04-22 23:25:25 +09:00
smoogipoo
0ee73b8e53 Add failing test 2021-04-22 23:22:44 +09:00
smoogipoo
64579d50ac Use only single PlayerInstance for hit sample playback 2021-04-22 22:59:47 +09:00
Dan Balasescu
be8fe47f2c
Merge branch 'master' into editor-add-nudge-shortcuts 2021-04-22 20:38:34 +09:00
smoogipoo
6df23f1301 Merge branch 'master' into multiplayer-spectator-screen 2021-04-22 20:29:24 +09:00
Dan Balasescu
b774f5b72b
Merge pull request #12526 from peppy/fix-system-message-ordering 
Fix system messages always being displayed above standard messages
 2021-04-22 18:51:25 +09:00
Dan Balasescu
0e24f2eb59
Merge pull request #12529 from peppy/editor-placement-right-click-delete 
Allow shift+right-click deletion when in placement mode
 2021-04-22 18:50:20 +09:00
Dean Herbert
a5364b224f Add simple key based time nudging support to editor 2021-04-22 18:47:04 +09:00
Dean Herbert
daafa41dc1
Merge branch 'master' into fix-initial-spectator-state-callback 2021-04-22 16:22:04 +09:00
Dean Herbert
cf1e3ea988 Add failing test covering quick shift-rightclick deletion in placement mode 2021-04-22 15:44:12 +09:00
Dean Herbert
ea3bb07924 Add test that fails on incorrect system/info message ordering 2021-04-22 14:51:14 +09:00
Dean Herbert
78f274d51a Merge branch 'master' into realm-key-binding-store 2021-04-22 12:13:23 +09:00
smoogipoo
2bea625613 Fix initial playback states not being correct 2021-04-21 23:22:11 +09:00
Denrage
0dfd0bb59d Refactored background of BeatmapInfoWedge 2021-04-21 15:46:11 +02:00
Denrage
9fba87f67a Moved Info and Background into own container 2021-04-21 15:43:29 +02:00
Gagah Pangeran Rosfatiputra
416e08ae7a
add dummy response API in TestSceneWikiOverlay 
`TestSceneNewsOverlay` is used as example for this test.
 2021-04-21 17:25:13 +07:00
smoogipoo
e78ef05fcf Merge branch 'gcc-abstraction' into multiplayer-spectator-screen 2021-04-21 17:11:14 +09:00
smoogipoo
31c5fb350f Merge branch 'master' into gcc-abstraction 2021-04-21 16:33:36 +09:00
Bartłomiej Dach
a2afa38a3f Merge branch 'master' into fix-mod-customisation-input-blocking-padding 2021-04-20 19:41:25 +02:00
Bartłomiej Dach
881043bc5d Fix failing test after mod settings layout changes 
The slight hack which was used in the test to ensure that the mod
settings overlay covered the entire width of the mod overlay broke after
adjustments to the layout in the previous commit.

Locally adjust the hack to use the parent of the `ModSettingsContainer`
rather than the container itself.
 2021-04-20 19:38:25 +02:00
Dean Herbert
26430e3cb5
Merge pull request #12492 from Naxesss/bg-audio-quality-checks 
Add background and audio checks
 2021-04-21 00:10:32 +09:00
smoogipoo
156a518068 Merge branch 'master' into fix-initial-spectator-state-callback 2021-04-20 21:16:05 +09:00
Naxess
c0318a4d3e Fix usage of _ in Moq lambdas 2021-04-20 13:29:14 +02:00
Naxess
6a1e4ff99f Add file hash to file presence test 
Necessary because we now find the storage path of the file rather than just the file itself.
 2021-04-20 13:28:32 +02:00
smoogipoo
c5d6b6ea8d Fix tests failing intermittently 
This was due to this code happening in UpdateAfterChildren(), after the
GCC has processed one frame. During this time, the clock could have
advanced an arbitrary amount.

The cause of this is the removal of the Task.Run() to set the clock in
Restart() (now called Reset()) which changed the timing, so it only worked before due to pure
luck.
 2021-04-20 18:41:09 +09:00
smoogipoo
f144661c31 Fix storyboard sample test scene 2021-04-20 18:26:30 +09:00
Gagah Pangeran Rosfatiputra
460d656a0e
initial wiki overlay 2021-04-21 16:21:07 +07:00
Denrage
505a117862 splitted updateable part of wedge 2021-04-20 10:37:52 +02:00
smoogipoo
5da18c51a4 Fix compile error 2021-04-20 17:27:37 +09:00
smoogipoo
80473a356e Merge branch 'fix-pre-seek-sample-lifetime' into gcc-abstraction 2021-04-20 17:27:01 +09:00