28861 Commits

Author	SHA1	Message	Date
smoogipoo	3df4cbca2c	Reduce precision of difficulty calculator tests	2021-09-14 13:45:10 +09:00
Opelkuh	9fd616c578	Tiny refactor	2021-09-14 00:16:42 +02:00
Opelkuh	224244801f	Remove Particles namespace	2021-09-13 21:44:27 +02:00
Opelkuh	cfcb46034c	Remove ParticleJet	2021-09-13 21:44:23 +02:00
Opelkuh	99eff4f41f	Move cursor particles under OsuCursorContainer	2021-09-13 21:44:22 +02:00
Opelkuh	c2f7b01ca4	Change particle AngularVelocity into StartAngle and EndAngle	2021-09-13 21:44:21 +02:00
Opelkuh	6d68da8ff0	Remove StartScale from ParticleSpewer particles	2021-09-13 21:44:20 +02:00
Opelkuh	db662f8c5c	Add ParticleParent option to ParticleSpewer	2021-09-13 21:44:20 +02:00
Opelkuh	328c9a5dd0	Change ParticleSpewer.Active to a Bindable	2021-09-13 21:44:18 +02:00
Opelkuh	4c753420d3	Fix ParticleSpewer gravity calculation	2021-09-13 21:44:17 +02:00
Opelkuh	714cf33aac	Change ParticleSpewer to use screen space	2021-09-13 21:44:17 +02:00
Opelkuh	1a60ce164e	Add ParticleJet	2021-09-13 21:44:16 +02:00
Bartłomiej Dach	35ee889e5b	Restore clipboard content after difficulty switch	2021-09-13 21:04:27 +02:00
Bartłomiej Dach	79d0f4835e	Add failing tests for preserving clipboard content	2021-09-13 21:03:30 +02:00
Bartłomiej Dach	3fc72271f1	Restore editor clock time after difficulty switch	2021-09-13 20:59:31 +02:00
AbstractQbit	3c75094f43	Move BarHitErrorMeter's icon reorintation to Update()	2021-09-13 19:41:55 +03:00
AbstractQbit	7267602b95	Fix icon orientation for horizontal bar hit error meter	2021-09-13 17:14:39 +03:00
Dean Herbert	1e09f558d1	Merge pull request #14687 from Emil8250/master ... Make "Reset bindings" button wider to accommodate to localisations better	2021-09-13 22:46:06 +09:00
AbstractQbit	9c1fc2ec65	Tweak filled nub border width value	2021-09-13 14:19:33 +03:00
Dean Herbert	4d2373ffb9	Combine similar value changed calls	2021-09-13 20:08:46 +09:00
Dean Herbert	d999c29d3a	Remove unused GameHost DI in OsuGameTestScene	2021-09-13 19:38:43 +09:00
AbstractQbit	0f5ed81a7a	Fix dimmed checked nub artifact ... This adds transition that extends nub's border to fill it. Fill fade can be removed, but combined effect looks nicer imo, and the fill is still needed because if removed, border becomes invisible for some reason.	2021-09-13 13:31:13 +03:00
Dean Herbert	aa71e3f3d4	Update nested game tests in line with framework changes	2021-09-13 19:04:13 +09:00
Dan Balasescu	f6c4bbe2c9	Merge pull request #14730 from peppy/add-missing-track-adjustment-defaults ... Add missing screen level mod application settings for some screens	2021-09-13 15:22:22 +09:00
Dean Herbert	0c646f6dbd	Merge pull request #14694 from nekodex/no-avatar-click-sound ... Don't play hover/select sounds for UpdatableAvatar unless it's clickable	2021-09-13 15:14:43 +09:00
Dean Herbert	f9c82a9098	Merge pull request #14676 from nekodex/lobby-team-swap ... Add sound for multiplayer team swaps	2021-09-13 15:01:58 +09:00
Dean Herbert	caf7ef6519	Add missing screen level mod application settings for some screens ... Closes #7480. But based on discussion in there this solution may change.	2021-09-13 15:00:34 +09:00
Dean Herbert	52c69d2f22	Adjust value to not be full width (but allow for more accommodations with localised versions)	2021-09-13 14:17:45 +09:00
Dean Herbert	684c39dad0	Update resources	2021-09-13 14:12:37 +09:00
Dean Herbert	7fe0eefb78	Add inline comment regarding team switch sample logic ... Feels a bit convoluted without this. Don't really have a better suggestion for now so a comment will do.	2021-09-13 14:12:19 +09:00
Dean Herbert	65fdceee79	Merge branch 'master' into editor-test-scenes-through-loader	2021-09-13 14:02:55 +09:00
Dan Balasescu	d9b4fae4e5	Merge branch 'master' into chat-command	2021-09-13 13:32:44 +09:00
Bartłomiej Dach	5969e2b852	Add TODO comment about lack of in-gameplay support	2021-09-13 00:13:07 +02:00
sh0ckR6	447001931c	Resolve LoungeSubScreen from PasswordEntryPopover ... This is preferred over passing down the already-resolved LoungeSubScreen	2021-09-12 14:36:11 -04:00
Bartłomiej Dach	1be8cb452f	Make new beatmaps' samples match playback rate by default	2021-09-12 16:57:21 +02:00
Bartłomiej Dach	345cde251d	Add "samples match playback rate" to editor setup screen	2021-09-12 16:54:17 +02:00
Bartłomiej Dach	af7c2b93e6	Add encoding support for SamplesMatchPlaybackRate	2021-09-12 16:47:38 +02:00
Bartłomiej Dach	cd181452be	Add decoding support for SamplesMatchPlaybackRate	2021-09-12 16:45:27 +02:00
Bartłomiej Dach	925b455330	Add "samples match playback rate" setting to beatmap info	2021-09-12 16:40:52 +02:00
Bartłomiej Dach	22fa9a303e	Expose test helper for switching between difficulties	2021-09-12 13:55:48 +02:00
Bartłomiej Dach	f8a681d810	Delegate Editor{Beatmap,Clock} to Editor directly	2021-09-12 13:40:06 +02:00
Bartłomiej Dach	8357efc74f	Make EditorTestScene go through EditorLoader	2021-09-12 13:26:04 +02:00
Bartłomiej Dach	c4627bed6d	Print username in case of generic network failure too	2021-09-12 12:56:36 +02:00
rednir	e511c2ef2b	add comment	2021-09-12 08:50:53 +01:00
sh0ckR6	e018071be4	Remove OnShakeFinish event	2021-09-11 19:50:41 -04:00
sh0ckR6	6cdc842452	Remove placeholder text response ... Weird UX, doesn't feel right compared to the rest of lazer	2021-09-11 17:42:49 -04:00
sh0ckR6	b8a6925175	Use already-resolved LoungeSubScreen instead of nested delegates	2021-09-11 17:41:07 -04:00
Bartłomiej Dach	b9c127c07e	Improve content transitions in beatmap listing	2021-09-11 22:37:36 +02:00
Davran Dilshat	1b264a2dd0	make user lookup string public	2021-09-11 16:22:29 +01:00
Davran Dilshat	c166f1a06a	change error message based on exception message	2021-09-11 14:18:09 +01:00
Bartłomiej Dach	addba43e7d	Merge branch 'master' into fix-password-popover-back-button	2021-09-11 14:18:25 +02:00
Bartłomiej Dach	0e5659acb2	Remove leftover exception throw	2021-09-11 14:10:29 +02:00
Dean Herbert	94702ee7e3	Fix triangles intro attempting to restart track after it is disposed	2021-09-10 18:23:00 +09:00
Dean Herbert	943e0d49f7	Handle control point flattening of nested hit objects	2021-09-10 17:29:09 +09:00
Dan Balasescu	f4b1d8b9d1	Merge pull request #14704 from peppy/modicon-imod-support ... Update `LeaderboardModSelector` to avoid creating mod instances	2021-09-10 16:43:32 +09:00
Davran Dilshat	acb181ff2b	rename alreadyJoinedChannel -> privateChannel	2021-09-10 08:15:43 +01:00
rednir	5ec615c783	display user in error message ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2021-09-10 08:02:15 +01:00
rednir	84c152e7b6	break when already found user ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2021-09-10 08:01:38 +01:00
Dean Herbert	cd227213e6	Ensure time of HitObject related ControlPoints are kept in sync with the hitobject	2021-09-10 15:59:30 +09:00
Dean Herbert	714f55b6bc	Clone control points when copying to HitObjects	2021-09-10 14:36:39 +09:00
Dean Herbert	34f875187c	Copy time between ControlPoints	2021-09-10 14:36:38 +09:00
Dean Herbert	309460e505	Merge pull request #14675 from ekrctb/featured-artist-markers ... Add featured artist markers to beatmap listing and overlay	2021-09-10 14:30:33 +09:00
Jamie Taylor	8d1e43423e	Update calls to use new variable name	2021-09-10 14:18:40 +09:00
Dean Herbert	63116a8889	Merge pull request #14703 from gagahpangeran/supporter-bg ... Fix supporter promo background colour	2021-09-10 14:11:01 +09:00
Dan Balasescu	2d2c63dde7	Merge branch 'master' into modicon-imod-support	2021-09-10 13:30:05 +09:00
Dan Balasescu	78a83e0903	Merge pull request #14698 from peppy/fix-beatmap-overlay-hide ... Fix beatmap listing overlay not hiding via keyboard control when scrolled	2021-09-10 13:18:37 +09:00
Dan Balasescu	1d9ad9478e	Merge pull request #14683 from peppy/use-decoupled-clock-triangles-intro ... Use a decoupled clock for triangles intro to avoid startup freezes on broken audio device	2021-09-10 13:15:58 +09:00
Gagah Pangeran Rosfatiputra	110f495345	move internal children to bdl	2021-09-10 11:11:55 +07:00
Jamie Taylor	85b699182e	Rename variable to be more descriptive	2021-09-10 13:01:54 +09:00
Gagah Pangeran Rosfatiputra	e636692596	change background to background 5	2021-09-10 11:00:55 +07:00
Dean Herbert	212c3c699c	Reword xmldoc slightly	2021-09-10 12:58:12 +09:00
Dan Balasescu	80f49ec5fd	Merge branch 'master' into cached-all-mods	2021-09-10 12:47:22 +09:00
Dean Herbert	28e9329136	Update LeaderboardModSelector to avoid creating mod instances	2021-09-10 12:43:21 +09:00
Dean Herbert	464797fecf	Allow ModIcon to be constructed using an IMod	2021-09-10 12:43:12 +09:00
Dean Herbert	c3531e1361	Move more specification from Mod to IMod	2021-09-10 12:42:53 +09:00
Jamie Taylor	2838a3a961	Rewrite conditional to be more 'balanced'	2021-09-10 12:25:41 +09:00
Gagah Pangeran Rosfatiputra	8acf82944f	use hex colour directly instead of transparency	2021-09-10 10:17:10 +07:00
Dean Herbert	719392de39	Change CreateInstance to use Activator.CreateInstance instead of clone	2021-09-10 12:05:10 +09:00
Gagah Pangeran Rosfatiputra	f329973798	fix supporter promo background colour	2021-09-10 09:37:27 +07:00
Dean Herbert	76e877f160	Disable APIMod/Mod cross equality support	2021-09-10 11:24:56 +09:00
Dean Herbert	cf633973a9	Refactor exposed mod retrieval methods for better safety	2021-09-10 11:09:13 +09:00
Dean Herbert	ce6b022a90	Remove unused IMod specification from APIMod	2021-09-10 10:59:30 +09:00
sh0ckR6	bde092f816	Clear UR bar display on seek with mouse	2021-09-09 20:08:16 -04:00
sh0ckR6	bf0150bab4	Clear UR bar display on keyboard input	2021-09-09 16:21:51 -04:00
Dean Herbert	344bf2ab7c	Allow popovers to be closed via back button press ... Closes https://github.com/ppy/osu/issues/14669.	2021-09-10 02:15:37 +09:00
Dean Herbert	46599540b6	Merge pull request #14666 from bdach/fix-score-panel-list-keyboard-nav ... Fix incorrect keyboard navigation order in score panel list	2021-09-10 02:07:06 +09:00
Dean Herbert	c101d1f205	Fix beatmap listing overlay not hiding via keyboard control when scrolled ... Closes https://github.com/ppy/osu/issues/14684.	2021-09-10 01:57:57 +09:00
Dean Herbert	1c3c32b724	Add test ensuring converter doesn't modify original beatmap	2021-09-10 00:00:12 +09:00
Dean Herbert	6c18df24ec	Change how UsingThemedIntro is set to improve clarity	2021-09-09 22:04:16 +09:00
Dean Herbert	99b6f0352c	Always start decoupled clock regardless of track source	2021-09-09 22:04:00 +09:00
ekrctb	29f947fa07	Revert ExplicitContentBeatmapPill, don't try to reuse common code	2021-09-09 19:25:30 +09:00
Dean Herbert	9b34ffc302	Undo big oopsie	2021-09-09 17:12:38 +09:00
Dean Herbert	2edb851008	Add ability to lookup mod from a type specification	2021-09-09 16:50:59 +09:00
Dean Herbert	4d0530ca9d	Add new methods to ruleset for quicker mod lookups	2021-09-09 16:46:14 +09:00
Dean Herbert	e66d76d26e	Avoid settings copy if there are no settings	2021-09-09 15:43:55 +09:00
Jamie Taylor	b01cf5c937	Don't play hover/select sounds for UpdatableAvatar unless it's interactable	2021-09-09 15:33:47 +09:00
Dean Herbert	38f4b0ced2	Merge branch 'master' into cache-setting-source	2021-09-09 15:15:21 +09:00
Dean Herbert	41a2e6eeeb	Fix cache not actually caching anything	2021-09-09 14:56:39 +09:00
Dan Balasescu	f36bebd1a4	Merge branch 'master' into custom-style-link-flow-container	2021-09-09 13:31:55 +09:00
ekrctb	52bb02baed	Prefer composite over inheritance for drawable parts	2021-09-09 12:53:39 +09:00
Dan Balasescu	88dd83f6ca	Merge pull request #14686 from Joehuu/volume-meter-select-on-hover ... Fix volume meter not being highlighted when hovering before show	2021-09-09 12:13:13 +09:00
Dean Herbert	199f5235a3	Merge branch 'master' into fix-score-panel-list-keyboard-nav	2021-09-09 12:12:16 +09:00
Emil Olesen	2888623bdb	Extended the width of the ResetSectionButton to be equal to Content.Width. Fixes #14685	2021-09-08 22:02:24 +02:00
Joseph Madamba	9b05bf3a2c	Fix volume meter not being highlighted when hovering before show	2021-09-08 11:43:59 -07:00
Dean Herbert	ba99a808af	Use a decoupled clock for triangles intro to avoid startup freezes on broken audio device	2021-09-09 01:21:19 +09:00
Dean Herbert	6fc46792d3	Fix test regressions	2021-09-09 00:39:54 +09:00
Dean Herbert	a622a0b660	Use a more traditional method of caching	2021-09-08 23:18:17 +09:00
Dean Herbert	136573982c	Add fade in and fix incorrect wrapper bounds	2021-09-08 20:52:14 +09:00
Dean Herbert	7941240a00	Revert "Load DrawableLoungRooms asynchronously" ... This reverts commit 0b55bb6913fbf05ebb8ecadfe711084d6797efe0.	2021-09-08 20:52:14 +09:00
Dean Herbert	3e41d8b32e	Reduce initial fade transforms	2021-09-08 20:52:14 +09:00
Dean Herbert	bebb9d7e67	Wrap main content of DrawableRoom	2021-09-08 20:52:14 +09:00
Dean Herbert	037b9cfb59	Load DrawableLoungRooms asynchronously	2021-09-08 20:52:14 +09:00
ekrctb	d417f03a39	Simplify link style customization code	2021-09-08 15:52:54 +09:00
ekrctb	9637326f0c	Allow customizing link style by override in LinkFlowContainer	2021-09-08 15:52:54 +09:00
Jamie Taylor	217ca754ae	Add sound for team swaps	2021-09-08 13:45:05 +09:00
ekrctb	f96be2cab8	Add featured artist marker to beatmap set listing and overlay	2021-09-08 13:27:20 +09:00
Dean Herbert	81c9d831f4	Cache reflection portion of SettingSource lookups ... Fixes the mod-related overhead portion of https://github.com/ppy/osu/issues/14638. There's still a significant performance issue that will be addressed separately.	2021-09-08 13:26:11 +09:00
ekrctb	7543f9dfb0	Add featured artist track ID online info	2021-09-08 12:21:24 +09:00
sh0ckR6	b1f91596a7	Give user feedback on password attempt fail ... Shake the popover Set the input box's color to red and set the placeholder text to "incorrect password"	2021-09-07 20:05:24 -04:00
sh0ckR6	b8a1ebb786	Hide Popover after failed password attempt ... Instead of throwing an error, just close the popover and let the user continue	2021-09-07 16:54:21 -04:00
Ethan Ng	d8fe98fe12	Fixed grammatical error in ChangelogSupporterPromo	2021-09-07 14:06:23 -06:00
Bartłomiej Dach	8cc444df5f	Fix incorrect keyboard navigation order in score panel list	2021-09-07 21:14:38 +02:00
Davran Dilshat	255f8a9769	add alias "/msg" (also a command in stable)	2021-09-07 17:25:47 +01:00
Davran Dilshat	b1c89f7618	ignore case when search for already joined channel	2021-09-07 17:22:59 +01:00
Davran Dilshat	be9540e535	fix "key" having wrong url parameter name	2021-09-07 17:17:10 +01:00
rednir	f209222812	Merge branch 'master' into chat-command	2021-09-07 17:09:46 +01:00
Davran Dilshat	f54d5675db	check if user joined requested channel already	2021-09-07 17:06:12 +01:00
Dan Balasescu	87434333d2	Merge pull request #14659 from peppy/update-framework ... Update framework	2021-09-07 21:03:37 +09:00
Dean Herbert	c43ac8c946	Merge pull request #14660 from ekrctb/search-featured-artists ... Add "featured artists" filter to beatmap listing	2021-09-07 20:58:13 +09:00
Dean Herbert	fa62c846c5	Merge pull request #14603 from smoogipoo/score-ordering ... Fix scores not being ordered correctly on leaderboards	2021-09-07 19:18:37 +09:00
Dean Herbert	3d8faea4b0	Simplify nesting of OrderByTotalScoreAsync	2021-09-07 18:52:25 +09:00
Dean Herbert	92f59c10f5	Remove redundant this. in assignment	2021-09-07 17:45:39 +09:00
Dean Herbert	1aa95de530	Merge branch 'master' into score-ordering	2021-09-07 17:45:38 +09:00
ekrctb	5ab2f4b386	Give an orange colour to "featured artists" filter to match web	2021-09-07 17:32:12 +09:00
Dean Herbert	ff87ad6efc	Merge branch 'master' into editor-new-change-diff	2021-09-07 17:13:14 +09:00
Dean Herbert	a42527b8f5	Update framework	2021-09-07 16:46:40 +09:00
Dean Herbert	d922210d2f	Fix TestSceneDeleteLocalScore not properly comparing post-delete scores	2021-09-07 16:46:27 +09:00
Dan Balasescu	49b0998132	Merge branch 'master' into improve-background-screen-ownership-code-quality	2021-09-07 16:46:20 +09:00
ekrctb	b6c80f04b0	Add "featured artists" filter to beatmap search	2021-09-07 16:44:45 +09:00
Dan Balasescu	79fd2d46f6	Merge branch 'master' into test-efficiency	2021-09-07 16:14:12 +09:00
Dan Balasescu	2e0839d880	Merge branch 'master' into update-resources	2021-09-07 15:49:32 +09:00
Dean Herbert	44b1af5ae4	Update resources	2021-09-07 15:28:52 +09:00
Dean Herbert	5b13b566b5	Reduce startup overhead during default key binding handling	2021-09-07 15:19:23 +09:00
smoogipoo	4658577b1d	Factor in total score calculation time in results screen load	2021-09-07 15:19:09 +09:00
Dean Herbert	93da531d13	Improve code around background screen handling to read better	2021-09-07 14:35:33 +09:00
Dean Herbert	9edd010b1d	Fix unnecessary background screen transition	2021-09-07 14:34:54 +09:00
Dean Herbert	7921ad4516	Add loading spinner in case load takes longer than expected	2021-09-07 14:34:47 +09:00
Dean Herbert	ddaa95a1ca	Fix pushEditor function running twice on returning to loader	2021-09-07 14:34:18 +09:00
Dean Herbert	59aa4dabfd	Improve code around background screen handling to read better	2021-09-07 14:33:58 +09:00
smoogipoo	c9325cc419	Fix results screen test scene	2021-09-07 14:15:23 +09:00
Bartłomiej Dach	d13e00ed42	Merge branch 'master' into editor-new-change-diff	2021-09-06 21:42:32 +02:00
Bartłomiej Dach	5b9f37702b	Remove unnecessary delay before pushing editor from loader	2021-09-06 21:32:23 +02:00
Bartłomiej Dach	2d59008f52	Move screen management logic to EditorLoader	2021-09-06 21:30:50 +02:00
Bartłomiej Dach	bd7d6dd35d	Rename method	2021-09-06 21:27:17 +02:00
Bartłomiej Dach	73f742509a	Merge branch 'master' into tablet-area-validity-fix	2021-09-06 21:15:17 +02:00
Dean Herbert	2a5b857f10	Avoid loading unnecessary fonts in headless testing	2021-09-07 00:45:53 +09:00
Dean Herbert	eabca016d4	Throw rather than ignore on invalid control point addition	2021-09-06 22:04:37 +09:00
Dean Herbert	ce197b6322	Fix missing attribute text (and give slightly more space for "10.00x" cases	2021-09-06 21:40:30 +09:00
Dean Herbert	693ecdf62a	Refactor some incorrect/outdated terminology	2021-09-06 21:32:43 +09:00
Dean Herbert	3c7a34bdbd	Move mania-specific conversion to converter	2021-09-06 21:06:13 +09:00
Dean Herbert	52b6b05883	Update terminology in timing screen for now	2021-09-06 21:06:13 +09:00
Dean Herbert	766d789845	Rename ApproachRate to ScrollSpeed for now (to reduce complexity/confusion)	2021-09-06 21:06:13 +09:00
Dean Herbert	0500cd578a	Merge branch 'master' into no-more-difficulty-control-points-info	2021-09-06 21:06:12 +09:00
smoogipoo	20100b8894	Fix a few test failures	2021-09-06 20:20:52 +09:00
smoogipoo	401d38fc05	Fix possible nullref	2021-09-06 19:07:37 +09:00
Dean Herbert	1c4a3c584a	Use correct lookup type to ensure username based lookups always prefer username	2021-09-06 15:04:27 +09:00
Dean Herbert	458cde832d	Avoid using SSDQ for validity computation	2021-09-06 14:11:13 +09:00
Davran Dilshat	5c385e84ea	wrong command name in query message	2021-09-05 21:20:19 +01:00
Davran Dilshat	cb6cee9aea	add /query as alias of /chat	2021-09-05 21:10:08 +01:00
Bartłomiej Dach	d6a47fd99c	Sort difficulties by ruleset and star rating in menu	2021-09-05 21:48:11 +02:00
Bartłomiej Dach	7012a1d934	Fix issues with main menu -> editor loader transition	2021-09-05 21:48:11 +02:00
Bartłomiej Dach	382269b362	Test staying on same difficulty due to unsaved changes	2021-09-05 21:48:10 +02:00
Bartłomiej Dach	c72523bc14	Add basic test for difficulty switching	2021-09-05 21:48:10 +02:00
Bartłomiej Dach	a9403b65b3	Eliminate dependency on OsuGame	2021-09-05 21:48:10 +02:00
Bartłomiej Dach	c397cc2027	Restructure proof of concept	2021-09-05 21:48:09 +02:00
Bartłomiej Dach	fe2520c599	Add intermediary screen to avoid going back to menus	2021-09-05 21:48:09 +02:00
Bartłomiej Dach	7befd030df	Minimal working example of switching difficulties	2021-09-05 21:48:09 +02:00
Bartłomiej Dach	90f0b6874f	Highlight current difficulty in switcher	2021-09-05 21:48:08 +02:00
Bartłomiej Dach	e8fb5d2e66	Add non-functional difficulty switcher to menu	2021-09-05 21:48:08 +02:00
Davran Dilshat	59ca69e41f	add /chat command	2021-09-05 18:16:57 +01:00
Dean Herbert	7c60c6a733	Merge pull request #14571 from rednir/get-user-from-username ... Add ability to open user profile links with username instead of user ID	2021-09-06 00:15:09 +09:00
Dean Herbert	0e48ae76cb	Merge pull request #14630 from bdach/mode-specific-settings ... Add ruleset-specific sections to setup screen	2021-09-05 23:58:24 +09:00
Davran Dilshat	b1a995e0bb	revert changes	2021-09-05 15:49:48 +01:00
Davran Dilshat	e78dc1bb4c	more code quality :/	2021-09-05 15:27:28 +01:00
Davran Dilshat	f7369e0d68	create UserIdLookupCache ... to get user ID when importing scores	2021-09-05 14:47:46 +01:00
Davran Dilshat	e5f886a315	revert unnecessary change	2021-09-05 10:45:38 +01:00
Davran Dilshat	e409f2dc6d	add xmldoc	2021-09-05 10:42:38 +01:00
Davran Dilshat	9aa1564e0d	revert ChannelManager changes	2021-09-05 10:19:04 +01:00
Dean Herbert	e0ee2a5533	Change section title to read better	2021-09-05 13:34:57 +09:00
Dean Herbert	25420af078	Rename method to drop redundant ruleset suffix	2021-09-05 13:34:23 +09:00
Dean Herbert	ab1c64591f	Move sample playback debounce time to central const	2021-09-05 13:25:10 +09:00
Dean Herbert	473e15e8f3	Add debounce to notification sample playback logic	2021-09-05 13:22:37 +09:00
Dean Herbert	1d23ac0f2d	Initial clean up pass on notification logic	2021-09-05 12:54:21 +09:00
Davran Dilshat	ea3be927d7	convert to method group	2021-09-04 20:02:10 +01:00
Davran Dilshat	4c006333e0	add /chat command	2021-09-04 19:42:14 +01:00
Bartłomiej Dach	1a90fb1ef3	Fix cached property being assigned twice	2021-09-04 19:52:42 +02:00
Dean Herbert	4fb3a1d641	Update check to inflate in the correct direct ... Also handles previously unhandled edge cases by comparing all four corners, instead of only two.	2021-09-05 00:46:29 +09:00
Dean Herbert	66daa553de	Fix bounds check running too early causing tablet area to show incorrect validity	2021-09-04 19:34:55 +09:00
Dean Herbert	16beb2c90c	Expose more pieces of TabletSettings	2021-09-04 15:35:46 +09:00
Dean Herbert	f42131ff89	Add back editor functionality for now	2021-09-03 19:08:23 +09:00
Dean Herbert	0e6660da30	Replace todo with permanent comment	2021-09-03 17:11:12 +09:00
Dean Herbert	6894ed3426	Fix new ordering of retrieval meaning EndTime is not available in time	2021-09-03 17:11:12 +09:00
Dean Herbert	8f24ea54ee	Change SamplePoints to be SortedList for conformity	2021-09-03 17:11:12 +09:00
Dean Herbert	74f385bad8	Assign default control points earlier in HitObject construction	2021-09-03 17:11:12 +09:00
Dean Herbert	2b9157987e	Fix regression in SampleControlPoint add logic	2021-09-03 17:11:12 +09:00
Dean Herbert	1aff4c2238	Ensure all hitobject level control points are populated before calling virtual defaults application	2021-09-03 17:11:12 +09:00
Dean Herbert	d587dc6203	Populate new approach rate where required	2021-09-03 17:11:12 +09:00
Dean Herbert	d4e5a612ea	Update IPositionalSnapProvider to take a HitObject as reference, rather than raw time ... This allows fetching the correct `DifficultyControlPoint` from the hitobject. Nothing more.	2021-09-03 17:11:12 +09:00
Dean Herbert	a3d9ab1e2e	Move approach rate to EffectControlPoint	2021-09-03 16:58:16 +09:00
Dean Herbert	4eb09ea1a9	Update decoder to also extract DifficultyControlPoints from HitObjects	2021-09-03 16:58:16 +09:00
Dean Herbert	071c56e90b	Update usages of DifficultyPointAt	2021-09-03 16:58:16 +09:00
Dean Herbert	db3fc1d4af	Move DifficultyControlPoints list to LegacyControlPointInfo	2021-09-03 16:58:16 +09:00
Dean Herbert	b41b1e2394	Write out DifficultyControlPoints into HitObjects	2021-09-03 16:58:16 +09:00
Bartłomiej Dach	ce1912781e	Add extension point for ruleset-specific beatmap setup sections	2021-09-02 23:29:14 +02:00
Dean Herbert	7688ea7057	Merge branch 'master' into score-ordering	2021-09-02 19:19:52 +09:00
Dean Herbert	cdd0262ca1	Merge pull request #14598 from smoogipoo/adjust-classic-scoring ... Make classic scoring a constant multiple of standardised scoring	2021-09-02 19:18:03 +09:00
Dan Balasescu	6c649b7bbe	Merge branch 'master' into no-more-sample-control-points-info	2021-09-02 18:09:05 +09:00
smoogipoo	e2f7aaeb71	Fix 0 score with bonus-only maps	2021-09-02 17:00:13 +09:00
Dean Herbert	b907c2f4f6	Fix osu! judgements getting scaled twice over different durations	2021-09-02 16:31:43 +09:00
smoogipoo	31433c4b89	Apply @spaceman_atlas' quadratic factor	2021-09-02 16:26:17 +09:00
Dean Herbert	f223be0760	Merge branch 'master' into score-ordering	2021-09-02 14:45:59 +09:00
Dan Balasescu	aadef41182	Merge pull request #14601 from peppy/fix-editor-setup-screen-pixel-leakage ... Fix pixels poking out of the top edge of editor setup screen	2021-09-02 14:03:37 +09:00
Dean Herbert	315bbbea4f	Merge pull request #14612 from ppy/dependabot/nuget/Microsoft.AspNetCore.SignalR.Client-5.0.9 ... Bump Microsoft.AspNetCore.SignalR.Client from 5.0.8 to 5.0.9	2021-09-02 13:10:50 +09:00
Dean Herbert	d1e5602a79	Merge pull request #14608 from ppy/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson-5.0.9 ... Bump Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson from 5.0.8 to 5.0.9	2021-09-02 13:10:46 +09:00
dependabot[bot]	e176babb25	Bump Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson ... Bumps [Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson](https://github.com/dotnet/aspnetcore) from 5.0.8 to 5.0.9. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.8...v5.0.9) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-09-02 02:34:24 +00:00
dependabot[bot]	be379051f2	Bump Microsoft.AspNetCore.SignalR.Client from 5.0.8 to 5.0.9 ... Bumps [Microsoft.AspNetCore.SignalR.Client](https://github.com/dotnet/aspnetcore) from 5.0.8 to 5.0.9. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.8...v5.0.9) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.SignalR.Client dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-09-02 02:34:19 +00:00
dependabot[bot]	8ba00f6737	Bump HtmlAgilityPack from 1.11.34 to 1.11.36 ... Bumps [HtmlAgilityPack](https://github.com/zzzprojects/html-agility-pack) from 1.11.34 to 1.11.36. - [Release notes](https://github.com/zzzprojects/html-agility-pack/releases) - [Commits](https://github.com/zzzprojects/html-agility-pack/compare/v1.11.34...v1.11.36) --- updated-dependencies: - dependency-name: HtmlAgilityPack dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-09-02 02:33:56 +00:00
smoogipoo	f14d66aafc	Commit missed line	2021-09-02 10:35:00 +09:00
Dean Herbert	9f13e11c7a	Merge pull request #14607 from ppy/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.MessagePack-5.0.9 ... Bump Microsoft.AspNetCore.SignalR.Protocols.MessagePack from 5.0.8 to 5.0.9	2021-09-02 03:16:34 +09:00
dependabot[bot]	6f0d1b394d	Bump Microsoft.AspNetCore.SignalR.Protocols.MessagePack ... Bumps [Microsoft.AspNetCore.SignalR.Protocols.MessagePack](https://github.com/dotnet/aspnetcore) from 5.0.8 to 5.0.9. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.8...v5.0.9) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.SignalR.Protocols.MessagePack dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-09-01 17:01:53 +00:00
dependabot[bot]	492209fe13	Bump Sentry from 3.8.3 to 3.9.0 ... Bumps [Sentry](https://github.com/getsentry/sentry-dotnet) from 3.8.3 to 3.9.0. - [Release notes](https://github.com/getsentry/sentry-dotnet/releases) - [Changelog](https://github.com/getsentry/sentry-dotnet/blob/main/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-dotnet/compare/3.8.3...3.9.0) --- updated-dependencies: - dependency-name: Sentry dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	2021-09-01 17:01:49 +00:00
smoogipoo	df7480e68c	Fix bindable implementation being synchronous	2021-09-01 20:56:23 +09:00
smoogipoo	f7c1177cc9	Fix ScorePanelList nullref when scores are added too soon	2021-09-01 20:35:06 +09:00
smoogipoo	ab538dc3dd	Fix param not passed through	2021-09-01 20:30:26 +09:00
Dean Herbert	ef64c05af8	Merge pull request #14533 from frenzibyte/move-incompatibility-icon ... Move mod incompatibility logic to "local player" mod select overlays	2021-09-01 18:12:27 +09:00
Dean Herbert	9e21f5a59c	Rename LocalPlayer to User in mod select prefixes	2021-09-01 17:22:52 +09:00
Dean Herbert	fb5f3fb9af	Rename button to be more descriptive of its purpose	2021-09-01 17:19:38 +09:00
Dean Herbert	2251bf3bcb	Use lambda spec for method	2021-09-01 17:08:20 +09:00
Dean Herbert	cb66ecdbeb	Merge branch 'master' into simplify-user-graph-tooltips	2021-09-01 17:04:21 +09:00
Dean Herbert	f0b128b6ec	Merge pull request #14592 from frenzibyte/cleanup-tooltips ... Update remaining tooltip implementations to use generics	2021-09-01 17:03:59 +09:00
Dean Herbert	0319177c5c	Fix pixels poking out of the top edge of editor setup screen	2021-09-01 16:46:19 +09:00
smoogipoo	88fc53200e	Refactor	2021-09-01 15:41:52 +09:00
Dean Herbert	edf29e405b	Merge pull request #14581 from bdach/setup-screen-countdown-settings ... Add countdown settings to setup screen	2021-09-01 15:35:46 +09:00
smoogipoo	2de076a74b	Merge branch 'adjust-classic-scoring' into score-ordering	2021-09-01 15:06:55 +09:00
Dean Herbert	c70ac5e5c2	Merge branch 'master' into privatise-toolbar-offset	2021-09-01 14:54:15 +09:00
smoogipoo	bd0f385cdb	Make classic scoring a constant multiple of standardised scoring	2021-09-01 14:53:11 +09:00
Dan Balasescu	e715b21ca7	Merge pull request #14586 from peppy/remove-ijsonserializable ... Remove IJsonSerializable interface	2021-09-01 14:17:32 +09:00
Joseph Madamba	a773a22726	Fix toolbar hiding when clicking home button	2021-08-31 14:29:16 -07:00
Bartłomiej Dach	1e4fa87648	Merge branch 'master' into setup-screen-countdown-settings	2021-08-31 22:43:18 +02:00
Bartłomiej Dach	5dc938cc9f	Update tests to match expectations	2021-08-31 22:41:47 +02:00
Bartłomiej Dach	04773b51bb	Remove countdown toggle transition for now ... Tricky to get right and the design isn't final as is anyway, so leaving *something* functioning as a best-effort for now.	2021-08-31 22:41:40 +02:00
Joseph Madamba	7e4ad7d7cf	Fix toolbar blocking scroll input	2021-08-31 13:40:13 -07:00
Joseph Madamba	da3fa9304a	Make toolbar inherit overlay container	2021-08-31 12:39:18 -07:00
Bartłomiej Dach	c246ff141e	Merge branch 'master' into avoid-exception-on-failed-lookup	2021-08-31 21:14:34 +02:00
Bartłomiej Dach	b969398e2d	Merge branch 'master' into adjust-triangle-speed	2021-08-31 20:44:09 +02:00
Salman Ahmed	505824d8ea	Constrain difficulty icon tooltip to internal accessibility" ... This reverts the reverted commit cd356b8eae. Sorry for the revert-unrevert, rushly pushed without realizing it doesn't even build.	2021-08-31 21:16:17 +03:00
Salman Ahmed	b0d7104650	Convert to class to allow not displaying tooltips ... With `struct` content, it is never possible to not show a tooltip.	2021-08-31 21:13:24 +03:00
Salman Ahmed	cd356b8eae	Revert "Constrain difficulty icon tooltip to internal accessibility" ... This reverts commit 4a590a041c.	2021-08-31 20:57:47 +03:00
Salman Ahmed	4a590a041c	Constrain difficulty icon tooltip to internal accessibility	2021-08-31 20:57:36 +03:00
Salman Ahmed	3969350c9a	Convert to readonly struct and replace with constructor temporarily	2021-08-31 20:45:32 +03:00
Salman Ahmed	69c23a2371	Explicitly implement tooltips on date drawables to avoid "convert to auto-property" inspections	2021-08-31 20:06:34 +03:00
Salman Ahmed	da7ff4b160	Update remaining tooltip implementations to use generics	2021-08-31 20:01:13 +03:00
Salman Ahmed	208f66cc76	Simplify user graph tooltips logic ... The same tooltip can be used for the rank graph, the play history graph, and the replay history graph. The only difference between those three is the displayed label, which has now been included as part of the `TooltipContent`, rather than unnecessarily recreating tooltips just for different sprite texts.	2021-08-31 19:59:38 +03:00
Salman Ahmed	a190801291	Revert no longer required tooltip content changes	2021-08-31 19:36:27 +03:00
Salman Ahmed	9afc482598	Merge branch 'master' into move-incompatibility-icon	2021-08-31 19:27:43 +03:00
Davran Dilshat	9288ca1191	handle api is null	2021-08-31 14:34:45 +01:00
Davran Dilshat	0a87b461d7	fix code quality issues	2021-08-31 14:11:37 +01:00
Davran Dilshat	79f71e5181	get user id when importing scores	2021-08-31 13:56:44 +01:00
smoogipoo	999386da29	Cleanup	2021-08-31 21:47:49 +09:00
smoogipoo	fee94236de	Fix update-thread pauses	2021-08-31 21:36:31 +09:00
smoogipoo	cfcf3d7507	Use synchronous total score retrieval for bindable	2021-08-31 20:43:50 +09:00
smoogipoo	bfcadcc4ac	Revert some changes	2021-08-31 19:18:01 +09:00
smoogipoo	90768a86a6	Adjust classic scoring as a constant multiple over standardised scoring	2021-08-31 18:54:16 +09:00
Dean Herbert	a254624373	Avoid performing beatmap metadata lookups when entering the editor ... If none of the lookup parameters are available, skip the lookup completely.	2021-08-31 17:18:05 +09:00
Dean Herbert	d988aa1680	Actually serialise SampleControlPoints along with HitObjects	2021-08-31 15:14:03 +09:00
Dean Herbert	448c58c35d	Remove unnecessary variable discard ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-08-31 15:08:07 +09:00
Dean Herbert	9fa8bee094	Remove outdated TODO	2021-08-31 14:51:19 +09:00
Dean Herbert	ce0d7cce2d	Merge branch 'remove-ijsonserializable' into no-more-sample-control-points-info	2021-08-31 14:40:54 +09:00
Dean Herbert	c25ab6835c	Remove IJsonSerializable interface ... Was pretty pointless and made it hard to use the custom serialisation terms arbitrarily in tests.	2021-08-31 14:39:20 +09:00
Dean Herbert	529a9a6ff8	Adjust minimum triangle movement speed to avoid "static" triangles in logo ... Closes #14584.	2021-08-31 14:08:23 +09:00
Joseph Madamba	570d36fde7	Make toolbar handle mouse events instead	2021-08-30 20:53:43 -07:00
Bartłomiej Dach	ddf9d2aa6c	Add test coverage	2021-08-30 22:55:58 +02:00
Bartłomiej Dach	b43ee2d61c	Add descriptions to enum members	2021-08-30 22:51:42 +02:00
Bartłomiej Dach	eec9f6d191	Add countdown settings to design section	2021-08-30 22:51:41 +02:00
Bartłomiej Dach	48e56adcfe	Add labelled number box control	2021-08-30 21:52:24 +02:00
Bartłomiej Dach	a6d09b0bb0	Add labelled enum dropdown variant	2021-08-30 21:37:14 +02:00
Bartłomiej Dach	acf38c723a	Move labelled dropdown from tournament to main game	2021-08-30 21:37:08 +02:00
Dean Herbert	a2cff75fc0	Fix editor not cloning control points as expected	2021-08-30 21:55:08 +09:00
Salman Ahmed	6154642075	Merge branch 'master' into local-popover-containers	2021-08-30 15:44:29 +03:00
rednir	8104b15874	remove braces ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2021-08-30 13:23:33 +01:00
rednir	c789163d01	use user ID overload when its supposed to be used ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2021-08-30 13:22:12 +01:00
Dan Balasescu	b95da3ca27	Merge pull request #14576 from peppy/update-framework ... Update framework	2021-08-30 21:09:58 +09:00
Dan Balasescu	c1f77cfa1e	Merge pull request #14577 from Henry-YSLin/status-criteria-parsing ... Parse partially typed status names in song select filter query	2021-08-30 19:59:41 +09:00
smoogipoo	caa797cbf4	Attempt to reorder score panel list	2021-08-30 19:58:35 +09:00
smoogipoo	e19d81c88c	Fix potential incorrect ordering	2021-08-30 19:41:44 +09:00
smoogipoo	4ebb11472d	Update Leaderboard to reorder scores based on scoring mode	2021-08-30 19:34:34 +09:00
smoogipoo	458ce250f0	Use new ScoreManager method in ScoreTable	2021-08-30 19:34:12 +09:00
smoogipoo	d03950fb37	Move score calculation to ScoreManager	2021-08-30 19:33:09 +09:00
Henry Lin	8137eee527	Reuse value to save enum name ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2021-08-30 18:05:47 +08:00
smoogipoo	b217dd1a65	Order scores by score	2021-08-30 19:03:16 +09:00
smoogipoo	47061c0210	Trigger refresh on scoring mode change	2021-08-30 18:57:30 +09:00
Henry Lin	04bf667d0d	Parse partially typed enum names in filter query	2021-08-30 17:49:18 +08:00
Dan Balasescu	c4da966ad9	Merge pull request #14575 from peppy/add-legacy-convert-encode-stability-tests ... Fix multiple conversions of a beatmap to taiko ruleset applying speed multiplier multiple times	2021-08-30 18:47:09 +09:00
Dean Herbert	1aaea7011a	Fix early return causing event loss in case of multiple control points in group	2021-08-30 18:33:05 +09:00
Dean Herbert	015df282fe	Simplify copy operations	2021-08-30 18:32:55 +09:00
Davran Dilshat	1aeae2b8c8	reverse ternary operator	2021-08-30 10:11:41 +01:00
Dean Herbert	4da2dca339	Apply the default SampleControlPoint if not externally provided ... This is mostly to handle tests for now, as generally this should be provided by an external source in all other cases.	2021-08-30 17:21:07 +09:00
Dean Herbert	d35c4da906	Add new control point to legacy regeneration logic	2021-08-30 17:14:53 +09:00
Dean Herbert	6ee4a6526c	Don't block sample points from still being added to ControlPointInfo	2021-08-30 17:14:53 +09:00
Dean Herbert	6fd24a5d92	Remove redundant null coalesce	2021-08-30 17:14:53 +09:00
Dean Herbert	ccacf56dd8	Move to legacy namespace	2021-08-30 17:14:53 +09:00
Dean Herbert	7257aae7f2	Move samples to LegacyControlPointInfo	2021-08-30 17:14:53 +09:00
Dean Herbert	da7a871afa	Update inline comment to point to new variable location ... Co-authored-by: PercyDan <50285552+PercyDan54@users.noreply.github.com>	2021-08-30 16:27:24 +09:00
Dean Herbert	678386f5c4	Fix missed null coalesce	2021-08-30 16:05:56 +09:00
Dean Herbert	fa2bf42188	Update tooltip implementations	2021-08-30 16:05:00 +09:00
Dean Herbert	f64efdc4a9	Merge branch 'update-extension-usages' into update-framework	2021-08-30 16:00:09 +09:00
Dean Herbert	58a052ea1f	Update framework	2021-08-30 16:00:07 +09:00
Dean Herbert	6a6dac609c	Fix instability of taiko double conversion ... Until now, the taiko speed multiplier was potentially applied more than once if conversion was run multiple times.	2021-08-30 15:30:18 +09:00
Dean Herbert	ee49305cad	Move taiko legacy speed multiplier to osu.Game project ... Allows it to be used in local case in `LegacyBeatmapEncoder`.	2021-08-30 15:13:31 +09:00
Dean Herbert	4dd60e3299	Merge branch 'master' into taiko-drum-refacor	2021-08-30 14:12:52 +09:00
Dan Balasescu	7be825f470	Merge pull request #14488 from frenzibyte/multi-spectator-player-leaving ... Gray out and stop player instances who quit during multi-spectator sessions	2021-08-30 12:04:19 +09:00
Davran Dilshat	90c313e2ad	add methods to get a user from their username	2021-08-29 19:19:55 +01:00
Salman Ahmed	6dc11543ad	Handle (null?) PP in PerformanceTable	2021-08-29 17:20:33 +03:00
Salman Ahmed	6aaef7b0be	Handle null PP during score set in TopScoreStatisticsSection ... Supersedes #14562 Closes #14541	2021-08-29 17:19:17 +03:00
Salman Ahmed	8f3416d853	Assert PP not null when showPerformancePoints is true	2021-08-29 16:03:39 +03:00
Salman Ahmed	e374ef163d	Update localisable formattable extensions usages inline with framework change	2021-08-29 15:00:28 +03:00
Joseph Madamba	9a5445bded	Fix overlays closing when clicking any empty area of the toolbar instead	2021-08-28 22:25:13 -07:00
Joseph Madamba	38912bfc16	Fix floating overlays not closing when clicking some empty area of the toolbar	2021-08-28 20:38:35 -07:00
Bartłomiej Dach	2efe82a18d	Remove popover container from manual input manager test scene	2021-08-28 20:20:42 +02:00
Bartłomiej Dach	d9db1ecee9	Remove game-global popover container	2021-08-28 20:05:59 +02:00
Bartłomiej Dach	fcc3e57d5d	Move overlay colour provider up to editor screen	2021-08-28 20:05:58 +02:00
Bartłomiej Dach	e94d96f250	Add local popover container to editor screens	2021-08-28 20:05:58 +02:00
Bartłomiej Dach	7457480b50	Add local popover container to lounge subscreen	2021-08-28 20:05:58 +02:00
Salman Ahmed	589f2863ca	Move incompatibility tooltip logic to local player mod select overlays ... This one turned out to be a bit more involved, due to tooltips being shared and having the potential of being used somewhere where it shouldn't be, due to the same content type matching. That's the reason I've defined a protected `TargetContentType`, to be able to separate "local player mod tooltips" and regular mod tooltips apart. Definitely unsure about the solution, but that's as far as I can think of right now.	2021-08-28 02:38:46 +03:00
Salman Ahmed	e527bfd4bf	Move incompatibility icon logic to local player mod select overlays	2021-08-28 02:37:46 +03:00
Dean Herbert	681a87d4ec	Update framework	2021-08-28 07:08:06 +09:00
Dean Herbert	804ca88d63	Update framework	2021-08-27 19:52:45 +09:00
Salman Ahmed	378734a7f8	Separate solo spectator player and "exit on restart" logic to own class	2021-08-27 13:24:37 +03:00
Dean Herbert	2b06dacd0e	Change debounce back to using scheduler ... Should better allow for adjusting in the future, as well.	2021-08-27 18:57:19 +09:00
Dean Herbert	33aa48bcf6	Merge branch 'master' into lobby-sounds	2021-08-27 18:46:12 +09:00
Dean Herbert	7d9bae4507	Update resources	2021-08-27 18:29:49 +09:00
Dan Balasescu	a28bc9f6b2	Merge branch 'master' into path-control-point-bindable-removal	2021-08-27 09:37:37 +09:00
Bartłomiej Dach	2ef2af17eb	Merge branch 'master' into alternative-difficulty-bindable	2021-08-26 23:07:52 +02:00
Bartłomiej Dach	d71dff4340	Merge branch 'master' into skip-overlay-optimisations	2021-08-26 22:38:17 +02:00
Bartłomiej Dach	875ef3e68f	Merge branch 'master' into fix-mania-editor	2021-08-26 21:00:20 +02:00
Dean Herbert	15aa0458bc	Use PausableSkinnableSound instead	2021-08-26 17:15:36 +09:00
Dean Herbert	ec85d7f356	Remove unused helper method	2021-08-26 17:15:23 +09:00
Dean Herbert	982c4eff14	Merge branch 'master' into taiko-drum-refacor	2021-08-26 17:13:14 +09:00
Salman Ahmed	2f26d270a3	Merge branch 'master' into score-processor-enum-getvalue-overhead-reduction	2021-08-26 09:55:09 +03:00
Salman Ahmed	15812520bd	Replace global editor test case with mania compose screen test scene	2021-08-26 09:45:01 +03:00
Jamie Taylor	56baecdde4	Add missing interaction sfx to MatchTypePicker	2021-08-26 15:30:20 +09:00
Jamie Taylor	e341f471b0	Add lobby sfx for join/leave/kick/ready/unready events	2021-08-26 15:29:22 +09:00
Dean Herbert	e633b2716d	Fix regression in outro skip handling logic	2021-08-26 13:58:45 +09:00
Dean Herbert	e32933eb54	Avoid Enum.GetValues in each score population pass	2021-08-26 13:37:53 +09:00
Dean Herbert	f4199958d9	Avoid unnecessary array/LINQ operations when replay frames have no action changes	2021-08-26 13:03:50 +09:00
Dean Herbert	6dcd9427ac	Remove bindable usage in PathControlPoint ... This is quite a breaking change, but I think it is beneficial due to the large amount of usage of this class. I originally intended just to remove the allocations of the two delegates handling the `Changed` flow internally, but as nothing was really using the bindables for anything more than a general "point has changed" case, this felt like a better direction.	2021-08-26 12:33:53 +09:00
Dean Herbert	b1a261c902	Avoid using scheduled delegates at all for skip overload input handling	2021-08-26 12:25:37 +09:00
Dean Herbert	956e3c554b	Avoid skip overlay attempting to show when it is already invalid	2021-08-26 12:25:37 +09:00
Salman Ahmed	b4d6495f99	Fix editor skin providing container not providing playable beatmap	2021-08-25 17:52:36 +03:00
Salman Ahmed	f9b25a0159	Add test case for switching to each screen in editor test scenes	2021-08-25 17:52:35 +03:00
Salman Ahmed	3ad0b529fb	Make EditorScreen inherit from VisibilityContainer rather than unsafe transforms	2021-08-25 17:14:52 +03:00
Salman Ahmed	196c74fce8	Gray out and remove player clock when users stop playing	2021-08-25 11:31:02 +03:00
Salman Ahmed	599145b46a	Stop clocks when removing them from sync manager	2021-08-25 11:31:02 +03:00
Dean Herbert	fd78d0440b	Update missed conditional	2021-08-25 17:00:32 +09:00
Dean Herbert	ccfff50c6f	Apply fixes in line with issues found during testing ... I was trying to be too smart with caching, but if the `Play` method was not called often enough it would have a recent reference. Unfortunately this requires a separate query to `Entries`, but is also a special case (no future hitobjects). This also removes the time-based checks (result status alone should be all we care about).	2021-08-25 16:56:44 +09:00
Dean Herbert	ef2b5e1c51	Tidy up variable names and unused resolved properties	2021-08-25 16:56:44 +09:00
Dean Herbert	a1936b141b	Refactor base class to allow correct usage in taiko drum	2021-08-25 16:56:44 +09:00
Dean Herbert	681215e5b5	Rewrite object lookup to use previous entry regardless ... This changes the fallback logic to always prefer the previous resolved lifetime entry rather than fallback to the first entry ever. I think this is more correct in all cases. Also rewrites the inline comments to hopefully be easier to parse.	2021-08-25 16:56:44 +09:00
Dean Herbert	4a294d4de4	Optimise fallback logic to reduce lookups to bare minimum	2021-08-25 16:56:44 +09:00
Dean Herbert	6aa894e55e	Split out separate component	2021-08-25 16:56:44 +09:00
Dan Balasescu	351015357c	Merge branch 'master' into user-events-in-participant-list	2021-08-25 14:39:26 +09:00
Dean Herbert	e1ab3434ed	Add ability to handle user join/leave/kick events in MultiplayerComposites	2021-08-25 14:37:14 +09:00
Salman Ahmed	ca527262e3	Merge branch 'master' into countdown-beatmap-info	2021-08-25 08:30:27 +03:00
Salman Ahmed	84637b59ef	Define DifficultyBindableWithCurrent and use in SliderControl	2021-08-25 07:40:41 +03:00
Dean Herbert	414457ba57	Add basic xmldoc explaining CountdownOffset	2021-08-25 13:24:52 +09:00
Bartłomiej Dach	a6c2cbd2e5	Add countdown settings to beatmap info model	2021-08-24 21:55:10 +02:00
Bartłomiej Dach	e503182a8d	Merge branch 'master' into activity-on-multiplayer-screens	2021-08-24 18:50:55 +02:00
Dean Herbert	568a8ee97e	Merge branch 'master' into fix-hud-test-failure-2	2021-08-24 16:54:48 +09:00
Dean Herbert	3f0f820653	Add comment explaining reasoning for override	2021-08-24 16:54:19 +09:00
Dean Herbert	08f757a584	Merge pull request #14474 from smoogipoo/fix-multi-crash ... Fix crash when entering multiplayer gameplay	2021-08-24 16:20:18 +09:00
Dan Balasescu	6a916a264f	Merge pull request #14441 from Henry-YSLin/mod-incompatibility-ui ... Show mods that are incompatible with the current selection	2021-08-24 16:16:35 +09:00
Dan Balasescu	ea98ce1b39	Merge pull request #14465 from peppy/improve-stable-skin-import ... Improve skin stable import behaviour to better handle similar skins	2021-08-24 16:08:15 +09:00
smoogipoo	9f17c38e36	Fix hud overlay components being blocked from load	2021-08-24 15:18:27 +09:00
Dean Herbert	a5f6c287ea	Split out pinned comment content to only be constructed when required	2021-08-24 14:43:28 +09:00
Dean Herbert	8cd972a9fe	Merge branch 'master' into pinned-comment	2021-08-24 14:37:31 +09:00
smoogipoo	16ddbcd208	Don't bind to RoomId where it's expected to be constant	2021-08-24 14:25:40 +09:00
Dean Herbert	c3b7ce0b05	Remove stray newline	2021-08-24 14:02:50 +09:00
Dean Herbert	afd01d22d6	Adjust visuals of incompatible icon and move to own class	2021-08-24 14:01:49 +09:00
Salman Ahmed	847726547a	Move mod value change callback inside wedge info text component	2021-08-24 07:53:49 +03:00
Dean Herbert	bf0a1167ec	Improve update flow and ensure selected mods is read from local context	2021-08-24 13:35:39 +09:00
smoogipoo	de0de451fe	Refactor to remove resolved dependency	2021-08-24 13:29:19 +09:00
smoogipoo	df170afbc4	Fix multiplayer crashing when entering gameplay	2021-08-24 13:22:06 +09:00
smoogipoo	956c1cc216	Merge branch 'master' into activity-on-multiplayer-screens	2021-08-24 12:33:34 +09:00
Dan Balasescu	dfd61e413a	Merge branch 'master' into difficulty-cache-difficulty-adjust	2021-08-24 12:08:52 +09:00
Dean Herbert	3c9718339c	Merge pull request #14444 from frenzibyte/decouple-ruleset-bindables ... Decouple rankings overlay's ruleset selector from the game-wide ruleset bindable	2021-08-24 11:58:13 +09:00
Henry Lin	b8fe03b77f	Use Mod.Equals for comparison	2021-08-24 09:50:09 +08:00
Henry Lin	6e3d05c7ce	Display an icon to signify incompatibility instead of a red tint	2021-08-24 09:42:53 +08:00
Salman Ahmed	13a24ed36f	Merge branch 'master' into update-section-selection-childcount	2021-08-23 20:43:46 +03:00
Bartłomiej Dach	ccf337bdc2	Merge branch 'master' into editor-setup-file-selector-popovers	2021-08-23 18:28:44 +02:00
Davran Dilshat	6bea744e34	invalidate scroll position	2021-08-23 17:13:25 +01:00
Davran Dilshat	20222f09c4	oops redundant default value	2021-08-23 16:55:31 +01:00
Davran Dilshat	9a507ed273	update selected section on children count change	2021-08-23 16:27:29 +01:00
Salman Ahmed	bd42d7aada	Hide popover on file selection	2021-08-23 18:01:01 +03:00
Dean Herbert	a2484692b3	Change brackets to square	2021-08-23 20:37:19 +09:00
Dean Herbert	7b3f7cc7c1	Change skin import to also include directory names in the skin name where appropriate	2021-08-23 20:24:00 +09:00
Dean Herbert	fed0e15cea	Fix typo in ArchiveModelManager	2021-08-23 20:23:46 +09:00
Salman Ahmed	f8a7e0bdb6	Update rankings overlay ruleset bindable with parent on initial display	2021-08-23 13:50:39 +03:00
Salman Ahmed	d3958eb3fb	Revert initial ruleset value logic	2021-08-23 13:28:21 +03:00
Salman Ahmed	f4b69ceb8a	Remove unused using embedded in reverted changes	2021-08-23 12:40:20 +03:00
Salman Ahmed	257934a144	Revert "Revert ruleset when not applied filters (includes scope change)" ... This reverts commit 9fa39cd34e.	2021-08-23 12:38:30 +03:00
Salman Ahmed	eeeaefbd7d	Revert "Store default ruleset value for ability to revert" ... This reverts commit cb7c2f713b.	2021-08-23 12:38:24 +03:00
Dean Herbert	34b51100ff	Merge pull request #14448 from bdach/basic-design-settings ... Add basic design settings to editor setup screen	2021-08-23 18:19:58 +09:00
Dean Herbert	c2c9a93e2c	Show editor file choosers in a popover rather than inline ... Supersedes and closes #14370. Closes #14367.	2021-08-23 18:12:36 +09:00
Dean Herbert	2f6b95da39	Add descriptions for the remaining settings	2021-08-23 17:41:03 +09:00
Dean Herbert	d17f7b5c8b	Side WidescreenStoryboard to on by default for new beatmaps	2021-08-23 17:40:41 +09:00
Dean Herbert	1de84e1c98	Change description to include mention of video ... Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>	2021-08-23 17:34:19 +09:00
Dean Herbert	eaa4d479ac	Merge pull request #14408 from smoogipoo/remove-current-room ... Remove the global "selected room" from online screens	2021-08-23 17:29:31 +09:00
Salman Ahmed	9fa39cd34e	Revert ruleset when not applied filters (includes scope change)	2021-08-23 11:11:06 +03:00
Salman Ahmed	cb7c2f713b	Store default ruleset value for ability to revert	2021-08-23 11:09:26 +03:00
Salman Ahmed	1d89d757af	Fix beatmap ruleset selector selecting initial ruleset	2021-08-23 09:57:05 +03:00
Dean Herbert	99bb3032a5	Move gradient to be part of the background for now	2021-08-23 15:27:32 +09:00
Salman Ahmed	2ba88923b6	Select user preferred ruleset on overlay ruleset selectors initially	2021-08-23 08:58:54 +03:00
Dean Herbert	58fb0c042b	Remove background scale altogether ... I'm not sure why this is required. Seems like something which was meant to exist to handle parallax, but that is already handled elsewhere now.	2021-08-23 14:34:27 +09:00
smoogipoo	4f3a5fbad5	Fix test failure	2021-08-23 14:29:15 +09:00
Dan Balasescu	ead1b47e0e	Merge branch 'master' into localise-beatmap-set-overlay	2021-08-23 13:22:52 +09:00
Dan Balasescu	2ad5914fec	Merge branch 'master' into decouple-ruleset-bindables	2021-08-23 12:40:57 +09:00
Bartłomiej Dach	2e80e2be51	Reword epilepsy warning description text	2021-08-22 21:47:37 +02:00
Bartłomiej Dach	9538a32b5e	Explicitly update beatmap info wedge on mod change ... This used to already be the case prior to b419ea7, but in a very roundabout way. Changes to the value of the star difficulty bindable - including indirect changes via the set of active mods changing - would trigger the wedge display to regenerate and load asynchronously. b419ea7 accidentally broke this by moving down the bindable retrieval to a lower level, at which point `WedgeInfoText` would only receive the set of mods selected at the time at which a given beatmap was selected, and not receive any further updates, breaking the BPM display updating in real time (as `WedgeInfoText` could not be aware that rate-changing mods were even in effect). To resolve, explicitly reload the wedge's contents on mod changes.	2021-08-22 19:16:46 +02:00
Bartłomiej Dach	e4a8f72167	Add failing test case	2021-08-22 19:16:43 +02:00
Bartłomiej Dach	d602dc9d90	Enable epilepsy warning setting persistence in encoder	2021-08-22 17:43:20 +02:00
Bartłomiej Dach	9816af688e	Add basic design settings to setup screen	2021-08-22 17:43:20 +02:00
Salman Ahmed	45b8bd175c	Decouple rankings overlay's ruleset bindable from game-wide bindable	2021-08-22 16:25:35 +03:00
Salman Ahmed	d164529be8	Fix ruleset selector not updating to the first ruleset item until after LoadComplete() ... This fixes the whole issue behind `Ruleset.Value` being null, by updating `Current` on BDL rather than waiting for the base logic which executes at `LoadComplete`. This seems like something that should happen at the base `TabControl` class itself, by switching `Current` right after the first added tab item, rather than doing it on `LoadComplete`, but I'm not sure about changing framework logic outright, so fixing this locally until it occurs on other places.	2021-08-22 16:25:34 +03:00
Dean Herbert	81e3c9d40f	Update resources	2021-08-22 19:13:21 +09:00
Salman Ahmed	956112eb10	Reword comment and remove brackets	2021-08-22 12:40:41 +03:00
Salman Ahmed	9b1720bd6c	Merge branch 'master' into localise-beatmap-set-overlay	2021-08-22 10:53:31 +03:00
Michael Malloy	9cd0a182f6	Add null check for Android ruleset loading	2021-08-22 00:38:48 -05:00
Henry Lin	3795030ebb	Merge branch 'master' into mod-incompatibility-ui	2021-08-22 11:14:24 +08:00
Henry Lin	0bbddd297c	Remove unused code	2021-08-22 11:05:53 +08:00
Henry Lin	e213562b2a	Add a red tint on mods incompatible with the current selection	2021-08-22 11:01:17 +08:00
Henry Lin	ef6faf04be	Use FirstOrDefault in TooltipContent	2021-08-22 10:22:18 +08:00
Henry Lin	3d402d9e78	List incompatible mods in tooltip of mod button	2021-08-22 10:13:34 +08:00
Nathan Alo	2877b43824	split multiplayer and playlist activity	2021-08-22 09:54:07 +08:00
Bartłomiej Dach	7ab12959a0	Merge branch 'master' into editor-regex	2021-08-21 19:57:26 +02:00
Dean Herbert	77f3668751	Merge branch 'master' into fix-screen-offsetting-on-scaling	2021-08-22 02:28:06 +09:00
Bartłomiej Dach	995338029c	Fix difficulty cache lookups sharing underlying mod instances ... `DifficultyCacheLookup`s were storing raw `Mod` instances into their `OrderedMods` field. This could cause the cache lookups to wrongly succeed in cases of mods with settings. The particular case that triggered this fix was Difficulty Adjust. Because the difficulty cache is backed by a dictionary, there are two stages to the lookup; first `GetHashCode()` is used to find the appropriate hash bucket to look in, and then items from that hash bucket are compared against the key being searched for via the implementation of `Equals()`. As it turns out, the first hashing step ended up being the saving grace in most cases, as the hash computation included the values of the mod settings. But the Difficulty Adjust failure case was triggered by the quirk that `GetHashCode(0) == GetHashCode(null) == 0`. In such a case, the `Equals()` fallback was used. But as it turns out, because the `Mod` instance stored to lookups was not cloned and therefore potentially externally mutable, it could be polluted after being stored to the dictionary, and therefore breaking the equality check. Even though all of the setting values were compared, the hash bucket didn't match the actual contents of the lookup anymore (because they were mutated externally, e.g. by the user changing the mod setting values in the mod settings overlay). To resolve, clone out the mod structure before creating all difficulty lookups.	2021-08-21 15:50:33 +02:00
Salman Ahmed	9a6ff29951	Reword comment ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-08-21 15:39:57 +03:00
Salman Ahmed	1729d43cec	Add explanatory comment	2021-08-21 15:18:03 +03:00
Salman Ahmed	df5354eba6	Merge branch 'master' into fix-setting-section-clickability	2021-08-21 14:25:28 +03:00
Salman Ahmed	216ff07497	Merge branch 'master' into fix-setting-section-clickability	2021-08-21 14:11:55 +03:00
Salman Ahmed	76e1d88028	Merge branch 'master' into gameplay-chat-mouse-cursor	2021-08-21 14:01:30 +03:00
Dean Herbert	ae47c5cdb3	Fix bottom area of a settings section not being clickable	2021-08-21 15:08:42 +09:00
Dean Herbert	15d443f6b7	Use the UI mouse cursor when hovering gameplay chat in an interactive state	2021-08-21 14:44:54 +09:00
Dean Herbert	36352d1de4	Improve highlighted chat username shadow effect	2021-08-21 14:34:35 +09:00
Salman Ahmed	20f193c1c2	Fix screen offsetting not handling scaled game instances ... By using `Content` instead, now the logic will get the X of the settings overlay at the `Content` space, which can be scaled in the `ScalingMode.Everything` mode. And in the case of `ScalingMode.ExcludeOverlays`, a subcontainer somewhere inside `Content` that's holding the screen stack would be scaled, but `Content` won't be affected which is what we want in that case.	2021-08-21 04:16:12 +03:00
Endrik Tombak	058d2d2a49	Use nekodex's regex from osu-web	2021-08-20 23:01:06 +03:00
Endrik Tombak	8745fe9e34	Change editor timestamp regex to not match non-editor ones	2021-08-20 22:32:04 +03:00
Dean Herbert	d3dba296d6	Update resources	2021-08-20 23:47:35 +09:00
Dan Balasescu	0c936aec4b	Merge branch 'master' into temporary-directory-test-storage	2021-08-20 22:09:42 +09:00
smoogipoo	f85d3665d8	Cleanups	2021-08-20 21:45:24 +09:00
smoogipoo	5192ee3b57	Fix initial display in room background	2021-08-20 21:40:35 +09:00
smoogipoo	5c8ca32ea4	Simplify lounge implementation	2021-08-20 21:33:21 +09:00
smoogipoo	b1a732b9b7	Remove selectedRoom from OnlinePlayScreen	2021-08-20 21:28:48 +09:00
smoogipoo	ceb07826d7	Merge branch 'master' into remove-current-room	2021-08-20 21:10:41 +09:00
smoogipoo	9458cd5a31	Make DrawableMatchRoom background load instantly	2021-08-20 21:07:51 +09:00
smoogipoo	b190020c4b	Block lounge background screen from exiting	2021-08-20 21:02:25 +09:00
Dan Balasescu	0aea39f5f1	Merge branch 'master' into temporary-directory-test-storage	2021-08-20 20:41:54 +09:00
Dan Balasescu	0a6b678059	Merge branch 'master' into settings-dim-other-sections	2021-08-20 20:22:22 +09:00
Dean Herbert	77149044a5	Allow intro screen to retrieve beatmap even if rulesets is not loaded	2021-08-20 19:43:48 +09:00
smoogipoo	d304e283e4	Don't deselect online room when joined	2021-08-20 18:14:59 +09:00
smoogipoo	c22c6f3a49	Initial room background implementation	2021-08-20 18:14:12 +09:00
Dean Herbert	591ba8cb09	Ensure the final scroll target is used when checking for whether too far down	2021-08-20 17:56:35 +09:00
smoogipoo	258ba4674c	Fix background overflows	2021-08-20 17:50:49 +09:00
Dean Herbert	03e6ca5ba9	Adjust scroll behaviour to feel better	2021-08-20 17:40:56 +09:00
Dean Herbert	2d19f37dc6	Add missing new method in UserTrackingScrollContainer for scrolling into view	2021-08-20 17:40:41 +09:00
Dean Herbert	139ff2d6e2	Only fade header in when hovering a section ... Feels less like the controls are interactive when hovering this way.	2021-08-20 17:40:05 +09:00
smoogipoo	3d96da84e6	Set a default background	2021-08-20 17:05:46 +09:00
smoogipoo	8524937c82	Move screenstack up a level	2021-08-20 17:02:55 +09:00
Dean Herbert	c7266c74a0	Always prefer clicked section when present	2021-08-20 17:00:20 +09:00
Dean Herbert	cff7b1e98f	Ensure the correct fade level is applied over all state changes	2021-08-20 17:00:08 +09:00
Lucas A	9b4c806855	Apply review suggestions.	2021-08-20 09:47:23 +02:00
Lucas A	0a1c9a6c05	Move DownloadButtonStrings -> CommonStrings	2021-08-20 09:26:38 +02:00
smoogipoo	610a162271	Merge branch 'master' into remove-current-room	2021-08-20 16:23:36 +09:00
Lucas A	19cc4a14a3	Localise top score mods statistics	2021-08-20 09:22:15 +02:00
Dan Balasescu	54bc532f0d	Merge branch 'master' into fix-messagepack-union	2021-08-20 16:01:04 +09:00
Dean Herbert	659ec0c1b8	Merge pull request #14403 from Joehuu/fix-nub-glow ... Fix nub glow color not having 0 alpha when being set	2021-08-20 15:07:30 +09:00
Dan Balasescu	dcff30ed6e	Merge branch 'master' into fix-login-as-guest	2021-08-20 14:06:28 +09:00
Dean Herbert	98357d51da	Merge pull request #14323 from minetoblend/editor-seek ... Prevent seeking before mp3 start time while editor is playing	2021-08-20 13:28:20 +09:00
Joseph Madamba	284c871e39	Fix glow color potentially being set incorrectly when glowing ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2021-08-19 20:33:19 -07:00
Dean Herbert	da8eba9996	Return early to avoid updating state and failure count in fail cases	2021-08-20 12:11:41 +09:00
Joseph Madamba	1e02d61b85	Fix nub glow color not having 0 alpha when being set	2021-08-19 20:06:49 -07:00
Dan Balasescu	c95bf735fe	Merge branch 'master' into multiplayer-chat	2021-08-20 11:54:42 +09:00
Dean Herbert	2825e15fd4	Update framework	2021-08-20 11:54:37 +09:00
Dean Herbert	7021133029	Merge branch 'master' into temporary-directory-test-storage	2021-08-20 11:54:33 +09:00
Dan Balasescu	580136a5e9	Merge branch 'master' into fix-lounge-loading	2021-08-20 10:51:30 +09:00
Bartłomiej Dach	143b8df1b2	Fix backwards warning text presence check	2021-08-19 22:40:35 +02:00
Lucas A	bf7f0a5d30	Remove double whitespace	2021-08-19 19:02:04 +02:00
Dean Herbert	e25592f325	Merge branch 'master' into fix-lounge-loading	2021-08-19 20:01:47 +09:00
Dean Herbert	2b0f2a6db9	Merge pull request #14355 from frenzibyte/mod-settings-difficulty-cache ... Update star difficulty bindables on mod settings change	2021-08-19 20:00:48 +09:00
Dean Herbert	a6b7ca1a4c	Ensure all request failures are correctly handled during login	2021-08-19 19:55:14 +09:00
Dean Herbert	b09105e5a7	Merge pull request #14381 from smoogipoo/match-subscreen-redesign ... Update layout of multiplayer room screens	2021-08-19 19:36:21 +09:00
Dean Herbert	a65cd36a5f	Move some constants to consts	2021-08-19 19:19:46 +09:00
Dean Herbert	fcf7394d3c	Merge pull request #14385 from rednir/limit-match-settings-textbox ... Limit length of multiplayer match settings textboxes	2021-08-19 19:13:32 +09:00
smoogipoo	44e157447c	Initial rework of backgrounds	2021-08-19 19:10:54 +09:00
Dean Herbert	8fce5911a9	Adjust spacing and padding of footer buttons	2021-08-19 19:08:46 +09:00
Dean Herbert	16aecfe934	Start free mod selection area hidden on screen display	2021-08-19 19:02:54 +09:00
Dean Herbert	be77498044	Move chat to right column in multiplayer match screen	2021-08-19 19:02:31 +09:00
Dean Herbert	675e2e34ba	Add padding between beatmap panel and edit button	2021-08-19 19:02:05 +09:00
Dean Herbert	4afc808ffc	Remove horizontal transitions for now ... They look bad with the current toolbar implementation. We can probably add them back once the toolbar is moved to the lounge.	2021-08-19 18:29:59 +09:00
smoogipoo	023f3fb70e	Use BackgroundScreen for multiplayer backgrounds	2021-08-19 18:19:31 +09:00
smoogipoo	493f47787b	Disable condition for the time being	2021-08-19 18:18:42 +09:00
Dean Herbert	4d1582d721	Play settings hide animation if visible when exiting RoomSubScreen	2021-08-19 18:14:45 +09:00
Dean Herbert	bc025efce5	Add commenting regarding workaround to avoid potential omission in the future	2021-08-19 17:42:44 +09:00
Dean Herbert	2b5a42e063	Add missing union specification for MatchUserRequest	2021-08-19 17:42:26 +09:00
Dean Herbert	f95c6f0de5	Switch multiplayer back to messagepack	2021-08-19 17:42:13 +09:00
Dean Herbert	fa01e4fad2	Add workaround for SignalR union serialisation	2021-08-19 17:41:50 +09:00
smoogipoo	6b6d52c23b	Add dependency container to RoomSubScreen	2021-08-19 16:53:07 +09:00
smoogipoo	4d1897c6b4	Remove unnecessary resolve into ListingPollingComponent	2021-08-19 16:52:54 +09:00
smoogipoo	00be7f4cca	Make RoomsContainer/DrawableRoom not resolve via DI	2021-08-19 16:52:54 +09:00
smoogipoo	3a1154c00e	Pass room into SelectionPollingComponent	2021-08-19 16:41:21 +09:00
smoogipoo	c31af96f1d	Pass room into RoomSettingsOverlay	2021-08-19 16:41:21 +09:00
smoogipoo	1fd746524d	Remove realtime room category, fix end-date showing for realtime	2021-08-19 16:09:28 +09:00
smoogipoo	6469eaa427	Fix background not updated in room	2021-08-19 15:52:51 +09:00
Salman Ahmed	6bfae25cda	Apply 5px vertical spacing on fill flow ... Regressed, was margin { bottom = 5f } from the star rating display creation method, which I've partly inlined.	2021-08-19 08:30:29 +03:00
Dean Herbert	6d00ea3375	Allow toggling focus via binding	2021-08-19 14:19:59 +09:00
Salman Ahmed	25e6317e7f	Use animated star display in beatmap info wedge and synchronise bar	2021-08-19 07:18:02 +03:00
Salman Ahmed	6d57a240ac	Add animation support for the star rating display	2021-08-19 07:17:43 +03:00
Salman Ahmed	072560ba3e	Remove leftover unused using	2021-08-19 07:17:43 +03:00
Salman Ahmed	102320f8ae	Merge branch 'master' into mod-settings-difficulty-cache	2021-08-19 06:35:13 +03:00
Salman Ahmed	5fc29328cf	Remove unused using ... Uh.....	2021-08-19 06:30:23 +03:00
Salman Ahmed	b984780d6a	Merge branch 'master' into fix-lounge-loading	2021-08-19 06:26:15 +03:00
Salman Ahmed	49bc3a8250	Refactor playlists room manager to handle dummy API requests	2021-08-19 06:25:47 +03:00
Salman Ahmed	f4ae587a33	Extract room request handling logic to its own class	2021-08-19 06:24:06 +03:00
Salman Ahmed	0e2f3dff4d	Fix rooms scroll container not masking properly due to padding	2021-08-19 05:09:49 +03:00
Salman Ahmed	ffbe8ddfa4	Refactor lounge sub screen layout for better loading screen appearance	2021-08-19 04:23:12 +03:00
Bartłomiej Dach	2e1df7bee4	Merge branch 'master' into settings-dim-other-sections	2021-08-18 23:32:30 +02:00
Bartłomiej Dach	2e43f38d8a	Merge branch 'master' into settings-delayed-load	2021-08-18 22:53:34 +02:00
Bartłomiej Dach	07951fe18c	Merge branch 'master' into limit-match-settings-textbox	2021-08-18 21:17:16 +02:00
Davran Dilshat	43cbd10a38	change limit to be on actual usage site	2021-08-18 18:30:50 +01:00
Lucas A	ea08d48d27	Remove unecessary localised string due to online view container handling visibility when user is not logged in.	2021-08-18 18:53:35 +02:00
Davran Dilshat	61675eefe0	Add length limit to match settings textboxes	2021-08-18 17:36:57 +01:00
Dean Herbert	6637c64501	Dim all but the current section	2021-08-19 01:27:14 +09:00
Dean Herbert	e87accafc8	Fix current section logic not accounting for hidden sections	2021-08-19 01:26:33 +09:00
Dean Herbert	a0374d4a67	Adjust centre point slightly to make dim feel better	2021-08-19 01:26:11 +09:00
Dean Herbert	af0c7ed108	Fix searching in settings not correctly invalidating the scroll position	2021-08-19 01:25:57 +09:00
smoogipoo	d40023bcc1	Hide border by default	2021-08-18 21:09:34 +09:00
smoogipoo	e9221f0126	Cleanup unnecessary implementation	2021-08-18 21:00:11 +09:00
smoogipoo	eadf02933a	Split lounge-specific implementation from DrawableRoom	2021-08-18 20:56:44 +09:00
smoogipoo	63af67f61b	Cleanup around footers	2021-08-18 20:25:48 +09:00
Salman Ahmed	8172ffc401	Fix lounge sub screen loading layer displaying in the background	2021-08-18 13:12:58 +03:00
Dean Herbert	fc3fa4f241	Merge branch 'master' into settings-delayed-load	2021-08-18 18:51:25 +09:00
Dean Herbert	1faf789f0e	Allow expanding chat using key binding even when it is hidden	2021-08-18 18:25:21 +09:00
Dean Herbert	365c1bccc6	Fix multiplayer channel being unintentionally left after gameplay session	2021-08-18 18:24:20 +09:00
Salman Ahmed	d2df09432f	Center the star rating display text rather than left	2021-08-18 11:49:33 +03:00
Salman Ahmed	5e91ec73e3	Handle star rating range display sizing	2021-08-18 11:36:27 +03:00
Dean Herbert	2099298444	Disallow clicking on chat textbox during gameplay	2021-08-18 17:30:50 +09:00
smoogipoo	9220d17202	Adjust paddings/spacings	2021-08-18 17:28:20 +09:00
Dean Herbert	9d2664cbb1	Merge branch 'master' into star-rating-display-v2	2021-08-18 17:22:33 +09:00
Salman Ahmed	74d6c26520	Refactor star rating display layout with flexibility in mind	2021-08-18 11:03:35 +03:00
smoogipoo	6dc96fdb83	Disable edit button in playlists	2021-08-18 16:56:42 +09:00
Dean Herbert	4725b802b0	Share OsuGameTestScene with implementations across template projects	2021-08-18 16:53:32 +09:00
Dean Herbert	2758a83d55	Fix TestSettingsMigration's usage of RecycleLocalStorage	2021-08-18 16:39:10 +09:00
smoogipoo	87a5922f0e	Remove participants from playlists screen	2021-08-18 16:26:45 +09:00
smoogipoo	66e11fe75e	Initial integration of playlists with the new structure	2021-08-18 16:09:15 +09:00
smoogipoo	568f1fd345	Fix initial RoomId state not being handled correctly	2021-08-18 16:09:00 +09:00
Dean Herbert	dc44cc0eb3	Update scenarios to use new TestRunHeadlessGameHost where feasible	2021-08-18 16:01:56 +09:00
smoogipoo	90a1be2e61	Move paddings up one level	2021-08-18 15:54:33 +09:00
smoogipoo	744b6749d1	Resolve room settings layout issues	2021-08-18 15:29:01 +09:00
smoogipoo	228ad98b39	Remove extra corner radius on DrawableRoom	2021-08-18 15:27:23 +09:00
smoogipoo	f3bc9c3e45	Merge branch 'master' into match-subscreen-redesign	2021-08-18 15:19:29 +09:00
smoogipoo	c5268c9a99	Simplify by reusing same room panel	2021-08-18 15:19:24 +09:00
Salman Ahmed	1ae4a1910a	Cache mod settings rather than fetching everytime	2021-08-18 09:17:42 +03:00
smoogipoo	704af94d39	Add edit button to room panel	2021-08-18 15:13:10 +09:00
smoogipoo	0853554c24	Fix settings overlay not being initially visible	2021-08-18 15:11:52 +09:00
smoogipoo	c66abf85f7	Remove match header	2021-08-18 14:04:44 +09:00
Dean Herbert	5441fab692	Avoid scheduling focus operation when not required	2021-08-18 12:45:14 +09:00
Dean Herbert	1fdaefef99	Revert unnecessary changes	2021-08-18 12:45:08 +09:00
Dean Herbert	5671820d92	Update framework	2021-08-18 10:35:34 +09:00
Salman Ahmed	8c5d99ab21	Override CreateInstance() in osu! bindable subclasses ... Three bindables are left which don't have this overriden due to them already not having a value-only constructor and not supporting `GetBoundCopy()` properly: - `BeatmapDifficultyCache.BindableStarDifficulty`. - `TotalScoreBindable` - `TotalScoreStringBindable` I could add support for them by passing the required data to them, as they seem to be able to have that shared, but I'm hesitant to support something which was already broken and never used, not sure.	2021-08-18 04:19:58 +03:00
Nathan Alo	eaca331170	apply suggestions	2021-08-18 08:13:53 +08:00
Bartłomiej Dach	e3b00c6c7a	Merge branch 'master' into reduce-skin-lookup-overhead	2021-08-17 23:08:52 +02:00
Bartłomiej Dach	58ecee543a	Trim redundant default argument value	2021-08-17 23:00:10 +02:00
Dan Balasescu	eaf7bd72fc	Merge branch 'master' into multiplayer-chat	2021-08-17 20:08:01 +09:00
Dan Balasescu	d8e9845d00	Merge pull request #14360 from peppy/improve-timeline-tick-visibility ... Improve visibility of repeat ticks / drag areas on timeline	2021-08-17 20:06:49 +09:00
smoogipoo	47d4a2e97f	Make SettingsOverlay protected	2021-08-17 20:05:26 +09:00
Dean Herbert	d66f7cb6b5	Fix tests by allowing retrieval with files where required	2021-08-17 19:21:22 +09:00
Dean Herbert	5c59818b03	Merge branch 'master' into reduce-skin-lookup-overhead	2021-08-17 19:05:14 +09:00
smoogipoo	590d814881	Move RoomSettingsOverlay to RoomSubScreen	2021-08-17 18:24:04 +09:00
Dean Herbert	f16468b706	Improve visibility of repeat ticks / drag areas on timeline	2021-08-17 18:17:55 +09:00
smoogipoo	6840ec6716	Actually show the room in the sub screen	2021-08-17 17:58:24 +09:00
Dean Herbert	c0b388cd74	Fix regression in ModSettingsChangeTracker	2021-08-17 17:50:30 +09:00
Dean Herbert	1b49e92e99	Merge branch 'master' into settings-delayed-load	2021-08-17 17:42:23 +09:00
Dean Herbert	4a65888cfc	Merge branch 'master' into multiplayer-chat	2021-08-17 17:34:23 +09:00
Dean Herbert	ef9bfece13	Merge branch 'master' into multi-polling-request-refactor	2021-08-17 17:31:25 +09:00
Dean Herbert	3b5fc6d10f	Ensure updateLoadingLayer is run at least once	2021-08-17 17:18:23 +09:00
Dean Herbert	9eb16fa61d	Move poll allowance logic based on signalr connection inside polling component	2021-08-17 17:16:21 +09:00
smoogipoo	5d72c5911a	Rename MatchSettingsOverlay and related classes ... Because "match" is a multiplayer-only concept.	2021-08-17 17:14:28 +09:00
smoogipoo	6416e64e06	Adjust sizings and paddings	2021-08-17 17:13:25 +09:00
smoogipoo	4b198d14eb	Initial refactor of RoomSubScreen	2021-08-17 17:05:20 +09:00
Dean Herbert	8a1651e830	Reorganise methods in PollingComponent	2021-08-17 17:04:32 +09:00
Dean Herbert	a901fca54a	Merge branch 'master' into multi-polling-request-refactor	2021-08-17 16:23:46 +09:00
Dan Balasescu	b1efc6d763	Merge branch 'master' into local-user-play-info	2021-08-17 16:23:44 +09:00
Dean Herbert	6ee6a46894	Remove unnecessary public prefix in interface specification	2021-08-17 16:22:14 +09:00
Dean Herbert	124f149cb5	Add key binding to focus chat input	2021-08-17 16:17:31 +09:00
Dean Herbert	30eee363dc	Add chat display during multiplayer gameplay	2021-08-17 16:17:31 +09:00
Dean Herbert	b82f92d7b8	Adjust background colours of textbox in chat display	2021-08-17 16:16:49 +09:00
Dean Herbert	35b9f84c00	Expose StandAloneChatDisplay.Textbox	2021-08-17 16:16:49 +09:00
Dean Herbert	0d283aa6a3	Expose LocalUserPlaying from Player	2021-08-17 16:16:49 +09:00
Dean Herbert	82eddeffef	Add LocalUserPlayInfo interface to convey common information about player status	2021-08-17 16:15:47 +09:00
Salman Ahmed	3a7b9bf096	Fix MatchSettingsOverlay not resetting focus on hide properly	2021-08-17 08:56:49 +03:00
Dan Balasescu	66e33b3704	Merge pull request #14263 from frenzibyte/hide-player-settings-overlay ... Hide non-interactive elements on multi-spectator players	2021-08-17 14:07:19 +09:00
smoogipoo	f4b7ee5c7f	Merge branch 'master' into hide-player-settings-overlay	2021-08-17 13:44:33 +09:00
smoogipoo	081524b6c8	Privatise setters	2021-08-17 13:44:21 +09:00
smoogipoo	1e2c0031d7	Remove unused usings	2021-08-17 13:34:44 +09:00
Dean Herbert	bc86bafc08	Fix RestoreDefaultValueButton's colour weirdness	2021-08-17 12:48:30 +09:00
Dean Herbert	212842c537	Fix initial LayoutSettings animation in a more reliable way	2021-08-17 12:38:44 +09:00
Dean Herbert	adb4fd5a2b	Load only sections content asynchronously, showing the header initially	2021-08-17 12:31:33 +09:00
Salman Ahmed	b419ea716b	Refactor beatmap info wedge to not fully refresh on star difficulty change ... Makes it look awkward when changing difficulty via mod settings for example. Now the changes should instead only affect the displayed components which consume it directly.	2021-08-17 05:46:06 +03:00
Salman Ahmed	32ba525555	Track changes to mod settings in beatmap difficulty cache with 100ms debouncing	2021-08-17 05:46:05 +03:00
Salman Ahmed	0291cd5ae2	Consider mod equality in difficulty cache lookup rather than acronym	2021-08-17 04:27:43 +03:00
Salman Ahmed	060ba0692d	Add hash code support for Mod	2021-08-17 04:27:04 +03:00
smoogipoo	f2340c6dac	Privatise mutable list	2021-08-17 09:48:33 +09:00
smoogipoo	b672d4b936	Refactor RequestHandlingMultiplayerRoomManager to avoid confusion	2021-08-17 09:43:37 +09:00
smoogipoo	1e282432c9	Fix password in a better way	2021-08-17 09:40:25 +09:00
smoogipoo	c4a42c4db0	Fix BasicTestRoomManager overriding rooms	2021-08-17 09:36:59 +09:00
smoogipoo	352949069a	Move filter to LoungeSubScreen	2021-08-17 09:36:43 +09:00
smoogipoo	97d5b80834	Fix joining with incorrect password	2021-08-17 09:18:21 +09:00
smoogipoo	6320768a67	Merge branch 'master' into multi-polling-request-refactor	2021-08-17 08:44:56 +09:00
Xexxar	61045bd087	adjusted code comments	2021-08-16 22:36:14 +00:00
Xexxar	ae076c9a4e	merged latest ppy/master	2021-08-16 22:20:12 +00:00
Xexxar	176b3e7533	changed decay system to allow for customizing the currentStrain	2021-08-16 22:14:29 +00:00
Marvin Schürz	78f9f4a230	Move time clamp to Seek/transformSeekTo methods	2021-08-16 20:39:09 +02:00
Dean Herbert	4bf22db4ff	Attempt to reduce skin lookup overhead where file access is not required	2021-08-17 00:23:30 +09:00
Dean Herbert	8cba1f197b	Merge branch 'master' into add-supporter-glow-changelog	2021-08-16 23:41:46 +09:00
Dean Herbert	c3a8676932	Simplify size specifications	2021-08-16 23:38:13 +09:00
Dean Herbert	cb122eaf25	Merge pull request #14342 from frenzibyte/fix-difficulty-adjust-controls ... Fix difficuly adjust settings controls not raising `SettingsChanged` events	2021-08-16 23:34:30 +09:00
Dean Herbert	139e69ed3b	Merge pull request #14343 from frenzibyte/hide-tablet-not-detected-when-disabled ... Hide tablet settings content when disabled	2021-08-16 23:31:16 +09:00
Dean Herbert	7b74301fa1	Merge pull request #14341 from smoogipoo/fix-preview-track-crash ... Fix crashes from preview tracks	2021-08-16 22:21:52 +09:00
Dean Herbert	5f006bd6e8	Merge pull request #14247 from kj415j45/localisation-settings ... Add localisation support for most of Settings	2021-08-16 22:20:35 +09:00
Dean Herbert	c978e68742	Merge branch 'master' into add-supporter-glow-changelog	2021-08-16 22:09:52 +09:00
Dean Herbert	7e1086d901	Merge branch 'master' into hide-tablet-not-detected-when-disabled	2021-08-16 22:07:45 +09:00
Dean Herbert	568d027013	Simplify weird conditionals	2021-08-16 22:07:41 +09:00
Lucas A	3325b0cc95	Fix merge conflicts.	2021-08-16 14:50:08 +02:00
Lucas A	a0a9777109	Fix merge conflicts.	2021-08-16 14:50:00 +02:00
Lucas A	1f942d15f8	Localise scoreboard	2021-08-16 13:38:57 +02:00
Dean Herbert	8c3eb91059	Merge branch 'master' into localisation-settings	2021-08-16 20:03:06 +09:00
Dean Herbert	de61cb8e6a	Adjust delay slightly	2021-08-16 19:56:20 +09:00
Dean Herbert	e485728109	Add keywords to make finding audio offset adjustments easier in settings	2021-08-16 19:54:45 +09:00
Dean Herbert	230c4eb247	Fade in sidebar buttons after the load has completed	2021-08-16 19:47:41 +09:00
Dean Herbert	c6bd8520a7	Add basic asynchronous loading pattern to SettingsPanel	2021-08-16 19:47:41 +09:00
Dean Herbert	b541550ea9	Avoid initial synchronous dropdown population overhead in AudioDevicesSettings	2021-08-16 19:47:41 +09:00
Dean Herbert	8d051d9fa0	Avoid multiple synchronous overheads in SettingsItem	2021-08-16 19:47:41 +09:00
Dean Herbert	237d3e656b	Remove initial transform overhead of Nub	2021-08-16 19:47:41 +09:00
Dean Herbert	92ad66c86c	Remove transform overhead from OsuDropdown on initial display	2021-08-16 19:47:41 +09:00
Dean Herbert	c0130da235	Avoid running initial layout transform in LayoutSettings	2021-08-16 19:47:41 +09:00
Lucas A	7bebbf9f74	Mark format strings as verbatim.	2021-08-16 12:46:41 +02:00
Salman Ahmed	e39a295c5c	Hide tablet settings content when input handler is disabled	2021-08-16 13:45:50 +03:00
Dean Herbert	3ad7688eaf	Merge pull request #14339 from peppy/revert-breaking-config-rename ... Revert "Rename element in OsuSettings enum"	2021-08-16 19:18:22 +09:00
Dean Herbert	cecb312e77	Ensure TakeFocus does not crash when not yet loaded	2021-08-16 18:55:50 +09:00
Dean Herbert	c191b38125	Reduce transform overhead of RestoreDefaultValueButton	2021-08-16 18:55:50 +09:00
Salman Ahmed	855fff1486	Fix DifficultyAdjustSettingsControl.SliderControl not following up with the current pattern ... This was causing any `ValueChanged` event bind (such as the one in `SettingsItem` to invoke `SettingsChanged`) to be overwritten when `Current` is set afterwards.	2021-08-16 12:47:58 +03:00
smoogipoo	db1a0ebb55	Fix preview track crashes	2021-08-16 18:46:44 +09:00
Dean Herbert	1c7cbc8621	Add missing readonly keyword to new bindable	2021-08-16 17:14:13 +09:00
Dean Herbert	8555a465ac	Merge pull request #14318 from bdach/editor-colours-save ... Add support for saving edited combo colours and displaying them in composer	2021-08-16 17:07:53 +09:00
Dean Herbert	71fab416d8	Add a note against OsuSetting	2021-08-16 16:59:59 +09:00
Dean Herbert	fc89f2bac4	Revert "Rename element in OsuSettings enum" ... This reverts commit c2bbe17562.	2021-08-16 16:56:48 +09:00
Dean Herbert	8d45f86bd3	Rename variable to better reflect its purpose	2021-08-16 16:48:40 +09:00
Dean Herbert	ae8a1adae8	Allow seeking via Player.Seek even if disabled	2021-08-16 16:47:57 +09:00
kj415j45	887d622c28	Merge branch 'master' into localisation-settings	2021-08-16 15:41:50 +08:00
Dean Herbert	d0faa91bb1	Merge pull request #14338 from frenzibyte/fix-participant-panel-assuming-not-null ... Fix few cases where `MultiplayerRoomUser.User` is assumed to not be null	2021-08-16 16:31:24 +09:00
Dean Herbert	838bcc51b2	Avoid new bindable requirement	2021-08-16 16:27:19 +09:00
Dean Herbert	81480ac4fc	Use PlayerConfiguration to convey no-seek state	2021-08-16 16:16:02 +09:00
Salman Ahmed	7fe6f6dd14	Fix kick button action asserting and using User.User.ID rather than User.UserID	2021-08-16 09:47:23 +03:00
Salman Ahmed	79cd062784	Let TeamDisplay take the full MultiplayerRoomUser rather than the underlying User	2021-08-16 09:47:23 +03:00
Salman Ahmed	f82ed64aa7	Fix participant panel null user test no longer functioning properly ... I guess the changes that involved `MultiplayerTestScene` having a test user lookup cache caused this test case to false-pass silently. Added an explicit assert which ensures the added user indeed has a null `User` value.	2021-08-16 09:07:00 +03:00
Dan Balasescu	4d31d07c51	Merge branch 'master' into open-tablet-driver-faq	2021-08-16 13:46:43 +09:00
smoogipoo	08d347f10b	Merge branch 'master' into multi-polling-request-refactor	2021-08-16 13:12:08 +09:00
smoogipoo	b6a2020c59	General refactorings from PR review	2021-08-16 13:09:04 +09:00
smoogipoo	81f9442471	Inline update/addRoom in usage sites	2021-08-16 13:04:06 +09:00
Salman Ahmed	554b09ac1b	Fix SkinnableTargetsContainer blocked from processing scheduled tasks	2021-08-16 06:57:45 +03:00
smoogipoo	76a8d4329f	Make TestRoomManager update existing room	2021-08-16 12:43:09 +09:00
Dan Balasescu	989d337532	Merge branch 'master' into auto-restart	2021-08-16 12:34:04 +09:00
Dan Balasescu	bc8e9d9ea8	Merge pull request #14329 from peppy/fix-new-lounge-performance ... Cache buffered background to fix multiplayer lounge performance	2021-08-16 12:04:45 +09:00
Dan Balasescu	444453c9e2	Merge branch 'master' into fix-mark-read-local-message	2021-08-16 11:28:57 +09:00
Dean Herbert	f0fe79b568	Remove buffered container workarounds for now	2021-08-16 11:04:21 +09:00
Dean Herbert	d35886ef19	Reduce frame buffer render scale for blurred background	2021-08-16 11:03:49 +09:00
Nathan Alo	c56b34d2da	apply code inspection fixes	2021-08-16 07:06:23 +08:00
Dean Herbert	e8e387b549	Cache buffered background to fix multiplayer lounge performance ... Consider this a request for comment. It's the cleanest solution I can come up with without dropping either the blur, or use of `ModelBackedDrawable`. Intended to resolve https://github.com/ppy/osu/issues/14276.	2021-08-16 08:04:54 +09:00
Bartłomiej Dach	e744629a41	Fix broken obsoletion message	2021-08-16 01:01:56 +02:00
Nathan Alo	cc3468b4ab	apply suggestions ... - make `UserActivity.InGame` and derive that to `InSoloGame` and `InMultiplayerGame` - rename `SoloGame` to `InSoloGame` - rename `MultiplayerGame` to `InMultiplayerGame`	2021-08-16 06:32:33 +08:00
Daniel Kariv	38828b6b82	Updating beatmap details icons ... changes the sizing and add yellow circle so the UI will fit more with osu-web style.	2021-08-16 00:40:31 +03:00
Daniel Kariv	f6773522d1	Correct icons in beatmap details ... In relation to #13968. Replacing incorrect icons in beatmap details panel to correct ones from BeatmapStatisticsIcon class.	2021-08-16 00:12:27 +03:00
Bartłomiej Dach	6108451449	Retrieve separated skin instance from working beatmap for editing	2021-08-15 21:18:09 +02:00
Bartłomiej Dach	81280dfd25	Use editable skin structure in combo colour picker	2021-08-15 21:18:08 +02:00
Bartłomiej Dach	0d64da8c63	Add skin providing container responding to beatmap skin edits	2021-08-15 21:18:08 +02:00
Bartłomiej Dach	df43e758ee	Add editable beatmap skin	2021-08-15 21:18:07 +02:00
emu1337	29a22bd11f	added rhythm multiplier for strain sections	2021-08-15 20:48:00 +02:00
Bartłomiej Dach	7c88a1c6de	Add a way to change custom combo colours via IHasComboColours ... `IHasComboColours` was already mutable (via a strange `AddComboColours()` method) and exposing a straight list is easier to work with. `IHasCustomColours` is also similarly externally mutable (in a way which is not easily removable).	2021-08-15 20:06:06 +02:00
Opelkuh	7d7c5c06f0	Fix code formatting	2021-08-15 16:02:25 +02:00
Opelkuh	2f9f1ba862	Add test for ChannelManager.MarkChannelAsRead	2021-08-15 15:44:23 +02:00
Bartłomiej Dach	3648e0ca26	Merge branch 'master' into auto-restart	2021-08-15 15:04:50 +02:00
Marvin Schürz	d287db7961	Clamping seekTime to beatmap length	2021-08-15 14:48:56 +02:00
Nathan Alo	2cc096101e	trim whitespace	2021-08-15 18:56:24 +08:00
Dan Balasescu	f49c9673cc	Merge pull request #14286 from kj415j45/readability-settings-rename ... Rename element in OsuSettings enum	2021-08-15 18:13:10 +09:00
Jacob Van Meter	6472d85aae	Added heart_size constant and adjusted the glow radius value ... Added heart_size constant and adjusted the glow radius value to be more in line with the website	2021-08-14 21:48:57 -04:00
Opelkuh	7d6f7ac75e	Fix mark channel as read error	2021-08-15 02:57:11 +02:00
Jacob Van Meter	71ccd38bb3	Corrected pippi background and promo positioning	2021-08-14 20:36:43 -04:00
Jacob Van Meter	772860232c	Removed empty offset and corrected colour	2021-08-14 20:32:38 -04:00
Jacob Van Meter	95943fdb25	Add glow to supporter promo on changelog ... Added glow to the supporter promo at the end of the changelog, as it is on the website.	2021-08-14 20:00:26 -04:00
Salman Ahmed	c8fb796660	Fix settings notice text class tinting everything with yellow	2021-08-14 20:14:28 +03:00
Salman Ahmed	2ddf28346a	PlayerSettingsGroups -> PlayerSettings	2021-08-14 19:58:20 +03:00
LiangXiang Shen	246a8882ce	Update translation key	2021-08-15 00:23:14 +08:00
Bartłomiej Dach	498462dfd0	Fix room null-check racing against async schedule	2021-08-14 17:44:41 +02:00
Nathan Alo	4ed06a1021	apply suggestions	2021-08-14 22:39:12 +08:00
kj415j45	c2bbe17562	Rename element in OsuSettings enum ... `ShowProgressGraph` -> `ShowDifficultyGraph`	2021-08-14 22:35:15 +08:00
kj415j45	f87f86e671	Apply suggestions from code review ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-08-14 22:24:57 +08:00
Nathan Alo	a553942a7f	update InitialActivity on multiplayer Player and SongSelect	2021-08-14 13:20:36 +08:00
Dean Herbert	b8c63eb1cb	Merge branch 'master' into multiplayer-kick-support-events	2021-08-14 14:08:34 +09:00
Dean Herbert	e6b3aba6e1	Fix incorrectly directed call in TestMultiplayerClient	2021-08-14 14:08:29 +09:00
Dean Herbert	a10ba17b64	Merge pull request #14250 from peppy/leaderboard-limit-player-count ... Add ability for gameplay leaderboard scroll when too many users are displayed	2021-08-14 14:08:18 +09:00
kj415j45	e26ccf786e	code style format	2021-08-14 11:04:38 +08:00
kj415j45	5cfb89f18a	Apply suggestions from code review ... Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>	2021-08-14 10:56:52 +08:00
Bartłomiej Dach	e2cc96097f	Unify match score display formatting ... Commas are already applied on the multiplayer leaderboard, as well as the results screen.	2021-08-13 23:57:51 +02:00
Bartłomiej Dach	00317c0e30	Round when totalling up team scores instead of truncating ... Matches score handling in `ScoreManager`.	2021-08-13 23:44:07 +02:00
Bartłomiej Dach	8f3fedade3	Merge branch 'master' into multiplayer-team-vs-results	2021-08-13 21:30:44 +02:00
Gagah Pangeran Rosfatiputra	9233f396aa	centered thumbtack icon and text	2021-08-14 00:22:01 +07:00
Gagah Pangeran Rosfatiputra	a710bbf6ae	remove background colour for no comment placeholder	2021-08-14 00:03:05 +07:00
Gagah Pangeran Rosfatiputra	6d726bf046	Change spacing ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2021-08-13 22:54:41 +07:00
smoogipoo	0e66a05963	Hide left border of beatmap wedge	2021-08-13 22:29:22 +09:00
smoogipoo	1c0ffd4621	Merge branch 'master' into multi-polling-request-refactor	2021-08-13 22:24:01 +09:00
smoogipoo	155e9e16a5	Refactorings	2021-08-13 22:09:47 +09:00
smoogipoo	d57508853e	Merge branch 'master' into multi-polling-request-refactor	2021-08-13 22:04:31 +09:00
smoogipoo	1fcb1cdb10	Add todo	2021-08-13 22:01:47 +09:00
smoogipoo	44b3e3bfac	Merge branch 'master' into fix-playlists-cross-ruleset-entry	2021-08-13 21:58:15 +09:00
Gagah Pangeran Rosfatiputra	cf0e9a1eec	add pinned content section	2021-08-13 19:40:37 +07:00
Gagah Pangeran Rosfatiputra	480d5ffa5d	add pinned comment to users setter in comment bundle	2021-08-13 19:40:37 +07:00
smoogipoo	c71a581106	Fix exception when leaving match	2021-08-13 18:24:19 +09:00
smoogipoo	1f992e67f3	Fix listing polling rate when entering room	2021-08-13 18:17:25 +09:00
kj415j45	d527eb3d8b	Apply suggestions from code review ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2021-08-13 17:15:18 +08:00
smoogipoo	1bae7173d3	Fix initial multiplayer poll	2021-08-13 18:14:02 +09:00
smoogipoo	6a46105b5e	Fix incorrect dependency	2021-08-13 18:12:32 +09:00
smoogipoo	83935540ca	Add selection polling component to PlaylistsRoomSubScreen	2021-08-13 18:11:52 +09:00
Dan Balasescu	62970108df	Merge pull request #14269 from peppy/remove-unnecessary-delimiters ... Fix searches at song select with '!' or ',' not matching as expected	2021-08-13 18:00:11 +09:00
Dean Herbert	72268d3e8a	Merge pull request #14150 from frenzibyte/improve-screen-offsetting ... Improve overlay screen offsetting logic to be position-based	2021-08-13 17:59:41 +09:00
smoogipoo	7cbf4c48ed	Fix multiplayer polling when not connected	2021-08-13 17:59:18 +09:00
smoogipoo	8910781bcd	Move listing polling component to LoungeSubScreen	2021-08-13 17:39:09 +09:00
Salman Ahmed	f43ab323ff	Add shared class for notice text in settings	2021-08-13 11:12:44 +03:00
Dean Herbert	5a60b39643	Remove unnecessary delimiters from song select filter splitting	2021-08-13 16:42:58 +09:00
Dean Herbert	93b97e5110	Adjust ratio to match previous behaviour	2021-08-13 16:35:22 +09:00
Dean Herbert	da18c399e2	Remove unnecessary IsPresent override	2021-08-13 16:33:00 +09:00