h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-11-06 06:57:39 +08:00
Code Issues Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Dean Herbert <pe@ppy.sh>
This commit is contained in:
kj415j45 2021-08-13 17:15:18 +08:00
parent cbeecff347
commit d527eb3d8b
No known key found for this signature in database
GPG Key ID: 54226D868052F383
4 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
osu.Game/Localisation/GameplaySettingsStrings.cs
View File

@ -22,12 +22,12 @@ namespace osu.Game.Localisation
/// <summary>
/// "Background dim"
/// </summary>
public static LocalisableString Dim => new TranslatableString(getKey(@"dim"), @"Background dim");
public static LocalisableString BackgroundDim => new TranslatableString(getKey(@"dim"), @"Background dim");
/// <summary>
/// "Background blur"
/// </summary>
public static LocalisableString Blur => new TranslatableString(getKey(@"blur"), @"Background blur");
public static LocalisableString BackgroundBlur => new TranslatableString(getKey(@"blur"), @"Background blur");
/// <summary>
/// "Lighten playfield during breaks"
@ -57,7 +57,7 @@ namespace osu.Game.Localisation
/// <summary>
/// "Always show key overlay"
/// </summary>
public static LocalisableString KeyOverlay => new TranslatableString(getKey(@"key_overlay"), @"Always show key overlay");
public static LocalisableString AlwaysShowKeyOverlay => new TranslatableString(getKey(@"key_overlay"), @"Always show key overlay");
/// <summary>
/// "Positional hitsounds"

2
osu.Game/Localisation/GeneralSettingsStrings.cs
View File

@ -27,7 +27,7 @@ namespace osu.Game.Localisation
/// <summary>
/// "Prefer metadata in original language"
/// </summary>
public static LocalisableString PreferOriginal => new TranslatableString(getKey(@"prefer_original"), @"Prefer metadata in original language");
public static LocalisableString PreferOriginalMetadataLanguage => new TranslatableString(getKey(@"prefer_original"), @"Prefer metadata in original language");
/// <summary>
/// "Updates"

6
osu.Game/Overlays/Settings/Sections/Gameplay/GeneralSettings.cs
View File

@ -22,14 +22,14 @@ namespace osu.Game.Overlays.Settings.Sections.Gameplay
{
new SettingsSlider<double>
{
LabelText = GameplaySettingsStrings.Dim,
LabelText = GameplaySettingsStrings.BackgroundDim,
Current = config.GetBindable<double>(OsuSetting.DimLevel),
KeyboardStep = 0.01f,
DisplayAsPercentage = true
},
new SettingsSlider<double>
{
LabelText = GameplaySettingsStrings.Blur,
LabelText = GameplaySettingsStrings.BackgroundBlur,
Current = config.GetBindable<double>(OsuSetting.BlurLevel),
KeyboardStep = 0.01f,
DisplayAsPercentage = true
@ -62,7 +62,7 @@ namespace osu.Game.Overlays.Settings.Sections.Gameplay
},
new SettingsCheckbox
{
LabelText = GameplaySettingsStrings.KeyOverlay,
LabelText = GameplaySettingsStrings.AlwaysShowKeyOverlay,
Current = config.GetBindable<bool>(OsuSetting.KeyOverlay)
},
new SettingsCheckbox

2
osu.Game/Overlays/Settings/Sections/General/LanguageSettings.cs
View File

@ -31,7 +31,7 @@ namespace osu.Game.Overlays.Settings.Sections.General
},
new SettingsCheckbox
{
LabelText = GeneralSettingsStrings.PreferOriginal,
LabelText = GeneralSettingsStrings.PreferOriginalMetadataLanguage,
Current = frameworkConfig.GetBindable<bool>(FrameworkSetting.ShowUnicode)
},
};