1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-22 12:52:55 +08:00
Commit Graph

11805 Commits

Author SHA1 Message Date
Salman Ahmed
8f97f0503f Move away from Solo namespace 2024-02-29 01:21:17 +03:00
Salman Ahmed
de48c51715 Apply renaming in remaining usages 2024-02-29 01:11:08 +03:00
Salman Ahmed
92eb206b49
Merge branch 'master' into spectator-remove-back-button 2024-02-29 00:12:24 +03:00
Salman Ahmed
232ca5778f Improve spectator fail test 2024-02-29 00:09:58 +03:00
Bartłomiej Dach
a5948d38ac
Merge pull request from frenzibyte/fix-advanced-stats-display
Fix advanced stats in beatmap info overlay showing "key count" on non-mania beatmaps
2024-02-28 18:02:48 +01:00
Joseph Madamba
8e462fbb38 Apply NRT to touched files 2024-02-27 23:58:28 -08:00
Joseph Madamba
e8a1061777 Add test for spectator player exit 2024-02-27 23:24:16 -08:00
Joseph Madamba
dee57c7e72 Refactor test to only allow init of actions 2024-02-27 23:24:16 -08:00
Dean Herbert
31f667224f
Merge branch 'master' into medals 2024-02-28 13:48:57 +08:00
Salman Ahmed
2151e0a294 Improve test coverage 2024-02-26 22:30:09 +03:00
Dean Herbert
fe59a3b9be
Merge branch 'master' into medals 2024-02-26 22:49:55 +08:00
Dean Herbert
d6622c1756
Add test coverage of fast menu keypresses failing to register 2024-02-26 22:24:39 +08:00
Bartłomiej Dach
8966ea2fa3
Add test coverage 2024-02-26 11:59:57 +01:00
Salman Ahmed
b30a6d5224 Adjust existing test coverage 2024-02-25 21:23:14 +03:00
Salman Ahmed
618819ba9f Merge branch 'master' into freemod_mapinfo_fix 2024-02-23 18:34:41 +03:00
Salman Ahmed
771cdf9cd6 Fix TestSceneModEffectPreviewPanel 2024-02-23 18:30:14 +03:00
Salman Ahmed
c1db9d7819 Add test coverage 2024-02-23 18:16:44 +03:00
Bartłomiej Dach
eac4c5f69d
Rename {Solo -> User}StatisticsWatcher et al.
The "solo" prefix is a bit unbecoming now. The updates are not only
for solo.
2024-02-22 20:36:24 +01:00
Bartłomiej Dach
1e53503608
Show user statistics after completing a playlists / multiplayer score 2024-02-22 20:35:50 +01:00
Bartłomiej Dach
0074bdc5a1
Change ResultsScreen constructor boolean params to init-only properties 2024-02-22 20:15:03 +01:00
Bartłomiej Dach
82b2edd4b7
Merge pull request from EVAST9919/results-clean
Rework `AccuracyCircle` to not use `BufferedContainer`s
2024-02-22 13:46:28 +01:00
Bartłomiej Dach
49b7f0e3a7
Merge pull request from smallketchup82/multiplayer-difficulty-tooltip
Implement difficulty tooltips for multiplayer lobbies
2024-02-22 12:57:35 +01:00
Bartłomiej Dach
46c8560ca5
Merge branch 'master' into multiplayer-difficulty-tooltip 2024-02-22 12:08:29 +01:00
Bartłomiej Dach
3740064360
Fix test scene not properly setting tooltip type on all icons 2024-02-22 12:05:52 +01:00
Bartłomiej Dach
d06c67ad8f
Substitute two jank interdependent bool flags for single tri-state enums 2024-02-22 12:05:50 +01:00
Bartłomiej Dach
47db317df8
Enable NRT in TestSceneDifficultyIcon 2024-02-22 11:45:57 +01:00
Bartłomiej Dach
6770b73e4e
Merge pull request from smoogipoo/mod-search-ignore-whitespace
Adjust search terms for mods
2024-02-22 11:41:31 +01:00
Bartłomiej Dach
b08fcbd4e9
Adjust tests to new behaviour 2024-02-22 11:02:49 +01:00
Dean Herbert
8b24c6a905
Merge pull request from BoudewijnPopkema/27272-clear-remembered-username
Clear stored username/token from config when relevant checkboxes are unticked on login panel
2024-02-22 17:29:36 +08:00
Bartłomiej Dach
2831ff60e1
Add test coverage 2024-02-22 09:39:49 +01:00
Bartłomiej Dach
57bb0b85a1
Merge pull request from Joehuu/rank-highest-tooltip
Add highest rank tooltip to global rank display
2024-02-22 09:08:22 +01:00
Dean Herbert
fc30abc7b0
Merge branch 'indented-code-block' into update-framework 2024-02-21 21:44:25 +08:00
Bartłomiej Dach
259be976e8
Adjust test to fail 2024-02-21 11:42:34 +01:00
Bartłomiej Dach
e5be8838e6
Fix yet another failure 2024-02-20 18:42:01 +01:00
Bartłomiej Dach
8abcc70b93
Add medal overlay to game 2024-02-20 16:31:31 +01:00
Bartłomiej Dach
b334b78b63
Make medal overlay respect overlay disable via activation mode 2024-02-20 16:31:31 +01:00
Bartłomiej Dach
e4971ae121
Add display queueing when multiple medals are granted in quick succession 2024-02-20 16:31:31 +01:00
Bartłomiej Dach
2e5b61302a
Implement basic medal display flow 2024-02-20 16:31:31 +01:00
Bartłomiej Dach
4911f5208b
Demote medal "overlay" to animation
I need the actual overlay to be doing way more things (receiving the
actual websocket events, queueing the medals for display, handling
activation mode), so the pre-existing API design of the overlay just
will not fly.
2024-02-20 16:31:31 +01:00
Dean Herbert
398eaee5d0
Merge pull request from bdach/disable-nested-managers-when-skin-editor-open
Disable nested input managers on edited screen when skin editor is open
2024-02-19 19:27:26 +08:00
Bartłomiej Dach
f5666185ab
Merge pull request from peppy/fix-cached-beatmap
Fix `WorkingBeatmapCache` caching beatmap in wrong state leading to crash
2024-02-19 12:06:45 +01:00
Bartłomiej Dach
444ac5ed4d
Add failing test coverage 2024-02-19 09:59:25 +01:00
Dean Herbert
6b6a6aea54
Apply NRT to LogoTrackingContainer 2024-02-18 23:35:26 +08:00
Dean Herbert
415a65bf59
Add failing tests for beatmap inconsistencies 2024-02-18 19:32:21 +08:00
Dean Herbert
4d4d69521f
Merge pull request from EVAST9919/judgements-rework
Cache created judgement in `HitObject`
2024-02-18 18:07:58 +08:00
Salman Ahmed
414e55c90e Add visual test case 2024-02-18 01:38:51 +03:00
Joseph Madamba
8169d1ac80 Add twenty star counter in visual test 2024-02-16 22:47:38 -08:00
Andrei Zavatski
060b01eee8 Make CreateJudgement public again and add remarks 2024-02-16 20:24:02 +03:00
Andrei Zavatski
dd32c0a226 Merge branch 'master' into judgements-rework 2024-02-16 20:08:57 +03:00
Salman Ahmed
583e71634f Always bring master/music volume to 50% 2024-02-16 11:20:07 +03:00
Salman Ahmed
6a1d118b21 Adjust tests again 2024-02-16 10:52:27 +03:00
Mike Will
22dafd8e9c fix typo 2024-02-15 18:56:09 -05:00
Salman Ahmed
df40f55c07
Merge branch 'master' into mute_detection 2024-02-16 01:35:02 +03:00
Salman Ahmed
6751f95eb6 Adjust test cases and approximate equality 2024-02-16 01:28:53 +03:00
Dan Balasescu
a037dbf8de
Update test to set Child in more canonical manner 2024-02-15 18:33:48 +09:00
Dean Herbert
409dfd33e7
Merge pull request from Joehuu/truncate-osu-dropdown-items
Truncate long dropdown menu item text and show tooltip
2024-02-15 16:11:36 +08:00
Joseph Madamba
401bd91dc4 Add visual test showing overflow on dropdown menu items 2024-02-14 22:57:38 -08:00
Dean Herbert
59efd22ba2
Merge branch 'master' into score-statistics-updates-working-2 2024-02-15 02:55:12 +08:00
Bartłomiej Dach
c588b81cee
Merge pull request from frenzibyte/ignore-soft-deleted-beatmaps-in-notification
Ignore soft-deleted beatmaps when trying to present from notification
2024-02-14 18:07:59 +01:00
Bartłomiej Dach
f7bea00564
Improve test coverage 2024-02-14 16:19:32 +01:00
Bartłomiej Dach
f1d69abdc8
Rename test 2024-02-14 15:59:07 +01:00
Dean Herbert
3da1d05d98
Merge branch 'master' into ignore-soft-deleted-beatmaps-in-notification 2024-02-14 22:56:47 +08:00
Bartłomiej Dach
d7dfc8b88a
Add failing test coverage for empty date filter not parsing 2024-02-14 15:55:57 +01:00
Bartłomiej Dach
1113355753
Merge branch 'master' into add-last-played-filter 2024-02-14 15:36:19 +01:00
Bartłomiej Dach
3f46e1afc3
Merge branch 'master' into comment-mapper-pill 2024-02-14 13:22:36 +01:00
Bartłomiej Dach
d189fa0f69
Rename flag 2024-02-14 11:53:41 +01:00
Dan Balasescu
2981ebe3d5
Fix inspection 2024-02-14 17:13:44 +09:00
Salman Ahmed
c24af5bfeb Add test coverage 2024-02-14 04:17:55 +03:00
Salman Ahmed
a96a66bc9e Add failing test case 2024-02-14 02:04:20 +03:00
Bartłomiej Dach
14052ae1cc
Implement transient stats display on user toolbar button 2024-02-13 14:28:24 +01:00
Bartłomiej Dach
da4ebd0681
Refactor SoloStatisticsWatcher to no longer require explicit subscription callbacks 2024-02-13 13:49:01 +01:00
Dean Herbert
f7a223f328
Merge pull request from frenzibyte/unranked-pp-placeholder
Add support for displaying "unranked PP" placeholder
2024-02-13 18:59:55 +08:00
Dan Balasescu
833997bf1d
Merge pull request from bdach/more-stringent-metadata-checks
Use more stringent checks when applying online metadata
2024-02-13 17:10:52 +09:00
Salman Ahmed
5bebe9fe0d Add test case for profile scores made on loved beatmaps 2024-02-12 21:33:18 +03:00
Bartłomiej Dach
5d81d83fb2
Merge branch 'master' into alias-author-creator 2024-02-12 18:02:42 +01:00
Bartłomiej Dach
96711eb185
Add test coverage 2024-02-12 18:02:34 +01:00
Bartłomiej Dach
e5e0b0e385
Add test coverage for correct setting of beatmap set status 2024-02-12 12:08:51 +01:00
Bartłomiej Dach
133e61a1b2
Add another test for even more failure 2024-02-12 12:08:51 +01:00
Bartłomiej Dach
834db989f7
Add more test coverage for more failure 2024-02-12 11:43:41 +01:00
Bartłomiej Dach
80b14f1aae
Add test coverage for beatmap confusion scenarios 2024-02-12 11:43:15 +01:00
Dean Herbert
1df38b54a1
Merge branch 'master' into refactor-metadata-lookup-sources 2024-02-11 20:10:41 +08:00
Bartłomiej Dach
ae5f108f01
Add visual test coverage of user profile info section 2024-02-10 13:08:26 +01:00
Andrei Zavatski
5fa54c8c63 Fix remaining use cases 2024-02-10 14:16:45 +03:00
Dean Herbert
01501f3b82
Merge branch 'master' into refactor-metadata-lookup-sources 2024-02-10 14:43:51 +08:00
Joseph Madamba
c9c39ecb2f Add RankHighest to APIUser 2024-02-09 16:06:16 -08:00
Andrei Zavatski
f03c4a0961 Merge branch 'master' into results-clean 2024-02-06 21:09:23 +03:00
Dan Balasescu
c18cd65081
Merge pull request from chandler14362/hit-object-result-allocations
Avoid closure allocations when applying hit object results
2024-02-06 17:49:26 +09:00
Andrei Zavatski
fc4234214e Merge branch 'master' into results-clean 2024-02-06 08:03:10 +03:00
Salman Ahmed
b0da0859d8 Add visual test cases 2024-02-05 23:29:24 +03:00
Bartłomiej Dach
c1feccb4cf
Add test coverage for selection behaviour 2024-02-05 19:53:19 +01:00
Bartłomiej Dach
1582536f04
Merge pull request from EVAST9919/user-card-containers
Rework `UserPanel`s to reduce container nesting
2024-02-05 18:46:42 +01:00
Bartłomiej Dach
3e29a9c334
Merge pull request from smoogipoo/adjust-default-minresult
Adjust default min result of `SliderTailHit`, remove override
2024-02-05 14:15:38 +01:00
Dean Herbert
cc5e1e0af3
Merge pull request from smoogipoo/net8
Update to .NET 8 + C# 12
2024-02-05 20:59:31 +08:00
Bartłomiej Dach
39fe078984
Merge branch 'master' into hit-object-result-allocations 2024-02-05 13:24:10 +01:00
Bartłomiej Dach
efe6bb25b1
Refactor result application around again to remove requirement for fields
Co-authored-by: Dean Herbert <pe@ppy.sh>
2024-02-05 13:21:01 +01:00
Bartłomiej Dach
ad69259eb8
Merge branch 'master' into fix-results-f-rank 2024-02-05 13:05:37 +01:00
Bartłomiej Dach
989e46c791
Use better test step name 2024-02-05 13:05:28 +01:00
Dean Herbert
c64d414d1b
Merge pull request from bdach/which-mods-for-pp
Display which mods grant pp
2024-02-04 19:15:11 +08:00
Andrei Zavatski
397def9ceb Move layout specification outside the GradedCircles class 2024-02-04 02:58:15 +03:00
Andrei Zavatski
7b2adc857a Merge branch 'master' into results-clean 2024-02-04 02:41:12 +03:00
Dan Balasescu
8e8ba9e77f
Fix more CI inspections 2024-02-02 21:36:41 +09:00
Bartłomiej Dach
dbd4397bef
Attempt to salvage test by using until step 2024-02-02 13:32:16 +01:00
Dan Balasescu
6e4d52863c
Upgrade to .NET 8 SDK 2024-02-02 21:28:51 +09:00
Bartłomiej Dach
fe0433e6ec
Remove redundant default value assignments 2024-02-02 13:24:59 +01:00
Dan Balasescu
b44f77cee1
Update R# + fix inspections 2024-02-02 21:00:28 +09:00
Mike Will
e4ec8c111b give better volume names to addVolumeSteps 2024-02-02 05:48:57 -05:00
Mike Will
906560f66d Fix mute button test
Lowering the master volume in the previous test meant that the
volume levels would end up being modified.
2024-02-02 04:06:22 -05:00
Mike Will
5d9200b4fe Update tests to reflect new restore target volume 2024-02-02 02:59:02 -05:00
Bartłomiej Dach
091618db1a
Add test coverage of full account creation flow 2024-02-02 07:25:07 +01:00
Mike Will
dfd966e039 Improve silence detection in MutedNotification
Instead of checking the master and music volumes separately to
see if they're <= 1%, check the aggregate of the two volumes to
see if it's <= -60 dB.

When muted notification is activated, restore the aggregate volume
level to -30 dB.
2024-02-02 00:48:42 -05:00
Salman Ahmed
5a1b0004db Add failing test case 2024-02-02 01:26:03 +03:00
Bartłomiej Dach
865f4d76ff
Add unranked indicator to song select footer too 2024-02-01 21:51:41 +01:00
Bartłomiej Dach
966093f7ce
Transform score multiplier display to also show ranked state 2024-02-01 21:32:37 +01:00
Andrei Zavatski
b0f6a87a2b Add stress test in TestSceneDashboardOverlay 2024-02-01 16:22:07 +03:00
Salman Ahmed
6ab8960fdc Add step for toggling skins in results screen test scene 2024-02-01 16:08:48 +03:00
Salman Ahmed
35c3f5e250 Merge branch 'master' into fix-results-f-rank 2024-02-01 15:29:07 +03:00
Dan Balasescu
66aa41e001
Fix tests 2024-01-31 18:04:32 +09:00
Dean Herbert
a1fe5eedd5
Merge pull request from frenzibyte/fix-multiplayer-fail-freezing-score
Fix score processor no longer applying results when failing in multiplayer match
2024-01-29 19:51:31 +09:00
Dean Herbert
cbbe2f9dc0
Merge pull request from peppy/2fa
Add two factor authentication flow
2024-01-29 19:14:55 +09:00
Bartłomiej Dach
4c5dacd559
Merge pull request from peppy/fucking-hitobject-references
Fix `OsuPlayfield` being retained indefinitely after gameplay
2024-01-29 09:40:56 +01:00
Dean Herbert
4a2602a775
Merge branch 'master' into 2fa 2024-01-29 16:57:29 +09:00
Dean Herbert
48fc0545c2
Merge pull request from bdach/decouple-notification-websocket-from-chat
Decouple notifications websocket handling from chat operations
2024-01-29 16:57:13 +09:00
Bartłomiej Dach
a41ba7c381
Fix more nullable inspections 2024-01-29 08:44:27 +01:00
Dean Herbert
fb24c66342
Mark ResultsScreen.Score as nullable
Is nullable in playlist results at very least.
2024-01-29 16:43:26 +09:00
Dean Herbert
9c55498058
r# says hi 2024-01-29 15:28:14 +09:00
Andrei Zavatski
809ca81b9c Add TestSceneGradedCircles 2024-01-29 05:29:29 +03:00
Salman Ahmed
64b61108ad Move solution to multiplayer flow instead 2024-01-28 00:42:04 +03:00
Salman Ahmed
5f68999893 Fix TestSceneFailJudgement asserts no longer being correct 2024-01-27 23:23:32 +03:00
Salman Ahmed
ea641bb8d2 Rename GameplayState.HasFailed to properly clarify its meaning 2024-01-27 23:23:10 +03:00
Salman Ahmed
d38779f962 Add failing test case 2024-01-27 23:22:56 +03:00
Salman Ahmed
2ccd0e3692 Add visual and failing test cases 2024-01-27 01:45:39 +03:00
Bartłomiej Dach
a2e69d37e8
Add basic testing of failure flow 2024-01-26 11:17:32 +01:00
Dean Herbert
e54502eef1
Add full editor save test coverage 2024-01-26 13:59:32 +09:00
Dean Herbert
a77db5d837
Add failing test coverage of editor metadata not saving 2024-01-26 13:59:32 +09:00
Chandler Stowell
93bd3ce5ae update DrawableHitCircle.ApplyResult to pass this to its callback 2024-01-25 11:25:41 -05:00
Bartłomiej Dach
3d3506b906
Merge branch 'decouple-notification-websocket-from-chat' into 2fa 2024-01-25 14:51:42 +01:00
Bartłomiej Dach
de52f0a80c
Decouple notifications websocket handling from chat operations
This is a prerequisite for https://github.com/ppy/osu/pull/25480.

The `WebSocketNotificationsClient` was tightly coupled to chat specifics
making it difficult to use in the second factor verification flow.
This commit's goal is to separate the websocket connection and message
handling concerns from specific chat logic concerns.
2024-01-25 14:47:29 +01:00
Dean Herbert
d66a2c452f
Merge branch 'master' into multiplayer-difficulty-tooltip 2024-01-25 21:18:16 +09:00
Dean Herbert
baaf33d995
Merge pull request from myQwil/divisor_cycle
Prevent custom divisor ranges from halting divisor preset cycling
2024-01-25 20:46:16 +09:00
OliBomby
c2d57dc77c Merge remote-tracking branch 'upstream/master' into edit-nodesample 2024-01-25 11:33:29 +01:00
Dean Herbert
f22bfa350a
Add test coverage of hidden scores on accuracy circle 2024-01-25 15:02:44 +09:00
Nguyên Minh Hồ
e1f8bc9692 Rename CanRotate property of SelectionRotationHandler to a more descriptive name 2024-01-25 12:10:50 +07:00
Mike Will
9e1c242713 Prevent custom divisor ranges from halting preset cycling
A custom divisor like 24 or 32 will result in a range containing
many divisors that are already in the `Common` and `Triplets` presets.
When this happens, it can become impossible to cycle between presets,
because the preset can only be changed if the new divisor isn't already
contained within the current preset's range.
2024-01-24 18:31:39 -05:00
Bartłomiej Dach
2f8747776e
Fix nullability inspection 2024-01-24 22:01:59 +01:00
Dean Herbert
b272d34960
Merge pull request from peppy/s-rank-change
Change S rank to require no miss
2024-01-24 13:27:40 +09:00
Bartłomiej Dach
0d7834af5f
Ensure all remaining test usages of IAPIAccess.Login() also authenticate with second factor 2024-01-23 18:04:41 +01:00
Bartłomiej Dach
d7e957087e
Fix account creation overlay test not clearing second auth factor 2024-01-23 17:00:16 +01:00
Bartłomiej Dach
d0d09a8657
Fix login overlay test not clearing second auth factor 2024-01-23 17:00:14 +01:00
Bartłomiej Dach
2cfaa1c103
Merge branch 'master' into 2fa 2024-01-23 16:51:23 +01:00
Bartłomiej Dach
0b5be3c40c
Remove outdated test
Non-legacy scores *are* subject to upgrades again - albeit it is *rank*
upgrades that they are subject to.
2024-01-23 12:53:16 +01:00
Andrei Zavatski
da992ccc55 Implement per-axis triangles clamping 2024-01-23 04:54:27 +03:00
Bartłomiej Dach
d53fb5a165
Update assertions to match expected behaviour 2024-01-22 20:52:54 +01:00
Bartłomiej Dach
3f31593a19
Add another failing tests covering recomputation of ranks 2024-01-22 20:01:18 +01:00
Bartłomiej Dach
81a02665b6
Adjust existing test to fail 2024-01-22 20:00:00 +01:00
Dean Herbert
83f9118b22
Adjust results screen to handle S->A rank adjustment when misses are present 2024-01-22 21:43:32 +09:00
Dean Herbert
4eba3b5d70
Move BackgroundDataStoreProcessor to better namespace 2024-01-22 21:43:32 +09:00
Dean Herbert
bb1eab5844
Update test in line with new rank definitions always being applied 2024-01-22 21:43:32 +09:00
Dean Herbert
c8521b49cd
Change S rank to require no miss 2024-01-22 21:43:32 +09:00
Dean Herbert
2ab0be7606
Merge pull request from bdach/fix-score-submission-test-failures-again-aaaaaaaaAAAAAA
Fix score submission test failures due to checking audio playback validity (again)
2024-01-22 20:07:51 +09:00
Bartłomiej Dach
9b2740f8a4
Fix score submission test failures due to checking audio playback validity (again)
As seen in https://github.com/ppy/osu/actions/runs/7607899979/job/20716013982?pr=26662#step:5:75

In https://github.com/ppy/osu/pull/26484, I went "well if I'm moving the
enabling of validation of playback rate to `SubmittingPlayer` context,
then surely I can remove the local override in the test scene, right?"

Reader: Apparently I did not notice that `FakeImportingPlayer :
TestPlayer : SoloPlayer : SubmittingPlayer`. So no, I could not remove
the local override in the test scene.

You could probably attempt to conjure up some excuse about deep
inheritance hierarchies here but nah. Really just a failure to read
on my behalf as usual.
2024-01-22 11:15:42 +01:00
Bartłomiej Dach
77ef12ebb0
Merge branch 'master' into frame-stable-catchup-zoom 2024-01-22 10:37:06 +01:00
Dean Herbert
993e733fce
Merge pull request from frenzibyte/fix-storyboard-sprites-2
Remove handling for non-legacy texture lookup paths in `LegacySkin`
2024-01-22 17:50:55 +09:00
Dean Herbert
f12be60d8d
Make test actually test multiple icons 2024-01-22 17:18:22 +09:00
Bartłomiej Dach
493d495992
Merge pull request from peppy/simplify-gameplay-pause
Simplify gameplay pause sequence
2024-01-22 08:49:08 +01:00
Dean Herbert
3b7a47aded
Merge branch 'master' into update-framework 2024-01-21 13:49:44 +09:00
Andrei Zavatski
1393f52b2b Rename Masking to ClampToDrawable 2024-01-21 05:20:42 +03:00
Dean Herbert
a69fd8198d
Update framework and other nuget packages
- Moq held back because dicks
- NUnit held back because large API changes (trivial but effort)
- SignalR held back due to api deprecations
2024-01-21 11:00:53 +09:00
OliBomby
9459c66981 fix test 2024-01-20 15:53:08 +01:00
OliBomby
bc0e6baba7 fix test 2024-01-20 01:13:05 +01:00
smallketchup82
87369f8a80 Conform to code style & remove unused imports 2024-01-18 11:16:03 -05:00
Salman Ahmed
22cfc86050 Add failing test case 2024-01-18 14:24:49 +03:00
Dean Herbert
c4e9bcd140
Remove test guarantee of audio time not advancing 2024-01-18 20:06:53 +09:00
Dean Herbert
82e7643df5
Update IPC usages
Of note, I've disabled IPC on visual test runners as we generally don't
use IPC in these cases. Having it set means that the game will not open
while visual tests are open, which has been a complaint from devs in the
past.
2024-01-18 19:45:36 +09:00
smallketchup82
d80a5d44ee Add tests for DifficultyIcon 2024-01-18 03:17:37 -05:00
Dean Herbert
799c74cfe5
Simplify gameplay pause sequence 2024-01-18 14:17:19 +09:00
Dean Herbert
fb4efd992d
Add a fake load to visual test to restore previous testing behaviour 2024-01-18 14:01:37 +09:00
Dean Herbert
c362a93a36
Change frame stable catch-up method to allow for much faster sync 2024-01-18 14:01:37 +09:00
Salman Ahmed
06da7f74de
Merge branch 'master' into fix-storyboard-sprites-2 2024-01-17 18:43:25 +03:00
Dean Herbert
e260e75fac
Merge pull request from frenzibyte/fix-storyboard-sprites-1
Change legacy beatmap skins to not handle `@2x` textures (to match stable)
2024-01-18 00:40:29 +09:00
Salman Ahmed
ede0a22693 Remove existing test coverage 2024-01-17 16:58:47 +03:00
Salman Ahmed
bcc7dd6af5 Add extended test coverage 2024-01-17 15:58:27 +03:00
Dean Herbert
6a8a45bb13
Merge pull request from frenzibyte/fix-editor-ux
Fix timing point changes not applying after selecting another one
2024-01-17 19:53:35 +09:00
Dean Herbert
1af5d1434c
Rename test method slightly 2024-01-17 19:53:23 +09:00
Bartłomiej Dach
5cb17bcacf
Merge pull request from frenzibyte/prevent-submission-with-invalid-mods
Add guard against submitting score with invalid mod instances
2024-01-17 11:39:32 +01:00
Dean Herbert
0ddd89a5b8
Merge pull request from bdach/accuracy-rank-lazer-score-reimport
Fix incorrect accuracy and rank population when decoding lazer replays
2024-01-17 19:33:26 +09:00
Salman Ahmed
5ad2918a75 Allow disabling high resolution texture lookups in LegacySkin 2024-01-17 12:56:29 +03:00
Dean Herbert
ee18123fc2
Merge pull request from stanriders/user-rank-card
Add user card with global/country ranks to login overlay
2024-01-17 17:22:33 +09:00
Salman Ahmed
05729706eb Fix android build CI failing
No idea why this is only in android, but okay.
2024-01-17 08:53:28 +03:00
Salman Ahmed
23e5167cb5
Merge branch 'master' into drag-volume-controls 2024-01-17 08:37:34 +03:00
Salman Ahmed
a34d2a3424 Add small volume meter to test feel 2024-01-17 08:28:47 +03:00
Salman Ahmed
f11682d44f Add failing test case 2024-01-17 08:15:01 +03:00
Bartłomiej Dach
1075b87fb8
Add failing test coverage 2024-01-16 22:38:52 +01:00
Salman Ahmed
485195d4c2 Fix submission test not asserting properly 2024-01-16 14:27:40 +03:00
Salman Ahmed
2935bd4809 Add test cases for helper method 2024-01-16 14:27:24 +03:00
Bartłomiej Dach
a3b7943e7d
Merge pull request from peppy/fix-skin-loss
Fix skin potentially being lost when opening and closing skin editor rapidly
2024-01-16 10:16:30 +01:00
Dean Herbert
0e41d0c9cf
Add failing test coverage of skin getting nuked
This doesn't fail in headless unfortunately.

Run a few times manually to confirm.
2024-01-16 15:22:38 +09:00
Dean Herbert
09e5b2fb46
Add test coverage of incorrect default state for Rank when hidden is applied 2024-01-16 13:21:15 +09:00
Bartłomiej Dach
40f612435d
Merge pull request from felipemarins/mod-search-text-box-select-all
Make mod search box text be selected when a new mod is selected/deselected
2024-01-15 20:08:02 +01:00
Bartłomiej Dach
a41108057f
Merge pull request from wooster0/no-scores-yet
Don't leave scores screen empty if no scores are present yet
2024-01-15 19:49:20 +01:00
Bartłomiej Dach
4d39c91972
Merge pull request from peppy/playlist-room-buttons
Allow interacting with playlist item buttons when not selected
2024-01-15 19:12:01 +01:00
Bartłomiej Dach
c0d4ed4789
Add test coverage of select-all-text-in-search when nothing matched 2024-01-15 19:07:52 +01:00
Bartłomiej Dach
e8394e6f74
Add test coverage 2024-01-15 19:05:33 +01:00
Bartłomiej Dach
988794cf90
Improve test coverage for empty results 2024-01-15 18:49:41 +01:00
Bartłomiej Dach
8a839f64ed
Add failing test coverage for placeholder shown when it shouldn't be 2024-01-15 18:47:46 +01:00
Bartłomiej Dach
d8d1d9264c
Fix test failure 2024-01-15 18:29:51 +01:00
Bartłomiej Dach
91f8144f98
Add test coverage 2024-01-15 14:58:46 +01:00
Bartłomiej Dach
d206acac63
Merge pull request from peppy/fix-double-counters
De-dupe displayed hits in judgement counter
2024-01-15 14:02:11 +01:00
Bartłomiej Dach
fe8540b441
Merge pull request from peppy/fix-collection-dropdown-crash
Fix collection dropdown crashing when all collections are deleted at once
2024-01-15 13:28:00 +01:00
Salman Ahmed
d346dd0650 Fix TestModReinstantiation failing due to custom mod being used 2024-01-15 15:01:13 +03:00
Bartłomiej Dach
96c472b870
Remove unused using directive 2024-01-15 12:33:25 +01:00
Bartłomiej Dach
6dee2860d2
Merge branch 'master' into fix-multiplayer-mods-cheesing 2024-01-15 12:19:29 +01:00
Bartłomiej Dach
0a02050a85
Fix test crashing at the end in visual test browser 2024-01-15 12:12:27 +01:00
StanR
b86c883a5d Merge branch 'master' into user-rank-card 2024-01-15 16:37:48 +06:00
Salman Ahmed
494c1be655 Fix blatant error in TestSceneModAccuracyChallenge 2024-01-15 13:30:34 +03:00
Bartłomiej Dach
9da3aeb28b
Merge pull request from frenzibyte/fix-system-mods-selected-on-free-mods-overlay
Fix touch device mod getting selected as a free mod in playlists
2024-01-15 11:29:37 +01:00
Dean Herbert
a3b63391fa
Merge pull request from stanriders/global-user-statistics
Add `Statistics` bindable to `IAPIProvider` and update it from `SoloStatisticsWatcher`
2024-01-15 18:43:35 +09:00
Dean Herbert
2b45a9b7c6
Add failing test coverage showing collection dropdown crash 2024-01-15 17:10:16 +09:00
Dean Herbert
e6453853c2
De-dupe displayed hits in judgement counter 2024-01-15 16:02:59 +09:00
Dean Herbert
2d5a39b234
Add failing test coverage of duplicates in judgement counter display 2024-01-15 16:02:58 +09:00
Salman Ahmed
b1fae2bc6a Add failing test case 2024-01-13 16:24:49 +03:00
Salman Ahmed
4cde8685d3 Add failing test case 2024-01-13 11:16:22 +03:00
Salman Ahmed
5303023e57 Add failing test case and fix selection assertion 2024-01-13 09:42:23 +03:00
Bartłomiej Dach
6572fa4378
Only validate playback rate when in submission context
Temporary workaround for https://github.com/ppy/osu/issues/26404.

It appears that some audio files do not behave well with BASS, leading
BASS to report a contradictory state of affairs (i.e. a track that is
in playing state but also not progressing). This appears to be related
to seeking specifically, therefore only enable the validation of
playback rate in the most sensitive contexts, namely when any sort of
score submission is involved.
2024-01-12 14:59:15 +01:00
Bartłomiej Dach
593ca9f84f
Merge pull request from frenzibyte/fix-skin-parsing
Fix mania skin array decoder not handling malformed entries rigorously
2024-01-12 12:52:02 +01:00
Bartłomiej Dach
600e4b6ef3
Adjust skinnable health display test scene for usability 2024-01-11 10:17:32 +01:00
Bartłomiej Dach
861080d3ae
Move simulated drain to separate test case
Having it on at all times was causing other tests to fail.
2024-01-11 10:04:37 +01:00
Dean Herbert
c2706ca91b
Also show drain on argon health display test 2024-01-11 00:31:31 +09:00
Salman Ahmed
7b848e1458 Assert column line width length for extra safety 2024-01-10 17:51:27 +03:00
Salman Ahmed
84f704a6c2 Add failing test case 2024-01-10 17:41:46 +03:00
Dean Herbert
49d13cda6b
Fix failing test by setting health on source of truth 2024-01-10 23:09:43 +09:00
Dean Herbert
f912a1ba31
Merge branch 'master' into health-less-value-changed 2024-01-10 18:03:34 +09:00
Nitrous
aa83ac1896
add test case 2024-01-10 15:53:54 +08:00
wooster0
d5fdd0c0f9 make each test bind the handler only once, depending on its need 2024-01-09 21:44:05 +09:00
wooster0
ea37c70e0b apply suggestion 2024-01-09 21:34:40 +09:00
wooster0
8ad697ff4c apply some suggestions/corrections 2024-01-09 21:28:46 +09:00
Dean Herbert
8324b75fa4
Merge pull request from bdach/song-select-logo-crash
Fix crash when clicking osu! logo in song select immediately after exiting
2024-01-09 19:40:19 +09:00
Dean Herbert
f1b4c305b0
Change skinnable health test scene to drain 2024-01-09 17:09:19 +09:00
Dean Herbert
79ff767eba
Remove unused using 2024-01-09 14:51:30 +09:00
Dean Herbert
3cdc3b5786
Merge branch 'master' into fix-wiki-main-page-layout 2024-01-09 13:14:36 +09:00
Dean Herbert
7d57a668ab
Use main page constant in more places 2024-01-09 13:12:54 +09:00
Joseph Madamba
b03813d3b4 Update casing of hardcoded "Main_page" string in tests 2024-01-08 14:37:50 -08:00
Bartłomiej Dach
388f6599e0
Add failing test for not attempting to upgrade non-legacy scores
This was a source of confusion for users previously, wondering why their
non-legacy (non-stable) scores weren't being converted in line with new
scoring changes, when it was never actually our intention to support
anything of the sort.
2024-01-08 22:10:09 +01:00
Bartłomiej Dach
67df7b33fb
Add failing test coverage for not attempting to upgrade custom ruleset scores 2024-01-08 22:10:08 +01:00
Bartłomiej Dach
8a87301c55
Add test for crashing scenario 2024-01-08 21:34:54 +01:00
Bartłomiej Dach
5337d999b5
Merge branch 'master' into disable-intro-track-pause 2024-01-08 12:54:37 +01:00
Bartłomiej Dach
b869be2f46
Fix typo 2024-01-08 12:52:23 +01:00
Bartłomiej Dach
50eba9ebdb
Reduce code duplication in test 2024-01-08 12:52:14 +01:00
Zachary
e2769dbda1 Attempt at creating a test. 2024-01-06 19:29:41 +10:00
Dean Herbert
fbc40ffc65
Merge pull request from Joehuu/flash-ongoing-operations-dialog
Flash blocking ongoing operations dialog when trying to force quit
2024-01-05 18:34:06 +09:00
Joseph Madamba
b190333c17 Use repeat step for more delay between the two exits 2024-01-04 09:00:24 -08:00
Dean Herbert
35b9940c4e
Merge pull request from CaffeeLake/multiplier1x
Fix mod score multiplier rounding to 1.00x with specific mod combinations
2024-01-04 19:26:49 +09:00
Dean Herbert
085f5acd1a
Fix another rider inspection (why do these keep coming up at random) 2024-01-04 19:26:28 +09:00
Dean Herbert
fc1a2c594c
Add a bit more test coverage 2024-01-04 18:02:37 +09:00
Dean Herbert
44d35020d1
Add test coverage of failed multiplayer score 2024-01-04 17:54:52 +09:00
Dean Herbert
b1813b17a2
Few new rider inspection 2024-01-04 16:39:50 +09:00
Dean Herbert
0f11743fff
Merge pull request from wooster0/chat
Make chat command names case-insensitive
2024-01-04 16:17:42 +09:00
wooster0
cf5f0a2bdc Make chat commands case-insensitive
Would be nice if I accidentally have caps lock enabled and write "/HELP" it still works.
2024-01-04 15:06:10 +09:00
wooster0
92c4566287 Fix typo 2024-01-04 12:20:05 +09:00
CaffeeLake
c7b0a7ff69
Merge branch 'master' into multiplier1x 2024-01-04 05:04:23 +09:00
StanR
e240443c46 Update LocalUser statistics, add test 2024-01-03 18:15:32 +06:00
CaffeeLake
4312e9e9a9 Add Test: floating point errors 2024-01-03 20:17:05 +09:00
StanR
3df7430d2e Bind UserRankPanel values to Statistics bindable in APIAccess 2024-01-03 14:32:32 +06:00
Bartłomiej Dach
e686a6a1dd
Fix player submission test intermittent failures due to audio playback discrepancy logic kicking in
See https://github.com/ppy/osu/actions/runs/7384457927/job/20087439457#step:5:133.
2024-01-03 09:17:01 +01:00
CaffeeLake
79ef032182
Merge branch 'master' into multiplier1x 2024-01-03 07:40:02 +09:00
StanR
c4be6fa974 Fix code quality, add new cards to the test scene 2024-01-03 00:37:24 +06:00
Dean Herbert
05d9aeefbc
Merge pull request from smoogipoo/slider-tail-judgement
Increase slider tails' worth to 150 points (up from 30)
2024-01-02 20:50:34 +09:00
OliBomby
6bb72a9fcc Revert "Remove other grid types"
This reverts commit de14da95fa.
2024-01-01 15:46:07 +01:00
OliBomby
de14da95fa Remove other grid types 2024-01-01 15:44:20 +01:00
OliBomby
9796fcff52 Merge position snap grid tests into single file 2024-01-01 15:24:54 +01:00
OliBomby
31d1799480 Create TestSceneCircularPositionSnapGrid.cs 2024-01-01 15:24:54 +01:00
OliBomby
8425c7226c fix rectangular and triangular grid tests 2024-01-01 15:24:54 +01:00
OliBomby
f223487e1c improve code 2024-01-01 15:13:10 +01:00
OliBomby
92c3b142a4 Added Triangular snap grid 2024-01-01 15:11:50 +01:00
OliBomby
f3b88c318b Add rotation to snap grid visual 2024-01-01 15:11:49 +01:00
CaffeeLake
ca0f09733a Remove unnecessary using directives
Signed-off-by: CaffeeLake <PascalCoffeeLake@gmail.com>
2023-12-31 23:35:42 +09:00
Salman Ahmed
34acb435b8
Merge branch 'master' into multiplier1x 2023-12-31 16:48:00 +03:00
Salman Ahmed
4a94cfd35d Fix failing test case 2023-12-31 16:47:12 +03:00
wooster0
0c85fd496f Don't leave scores screen empty if no scores are present yet
Addresses https://github.com/ppy/osu/discussions/23787

I originally wanted to set `allowShowingResults` to false if there are
no results but because this involves an API request to fetch the scores
that would mean all the scores would have to be fetched all at once so
that it knows whether to hide or show the "View results" button on a
beatmap.
Because that would slow things down and be very inefficient, this still
allows the user to view the scores screen but if there aren't any
scores, it shows a text, which I think is at least for now better than
nothing.

As for the testing of this, I wasn't sure how to not generate scores
only for one specific test so I opted into not using `SetUpSteps` and
doing it that way.
2023-12-31 22:42:32 +09:00
Salman Ahmed
cd9250d08c Add test coverage 2023-12-31 05:18:10 +03:00
Salman Ahmed
68dd103c89 Add failing test cases 2023-12-30 21:33:22 +03:00
Salman Ahmed
78cb6b6851 Abstractify LegacyComboCounter to re-use for mania 2023-12-30 05:29:22 +03:00
Dan Balasescu
807443b648
Add HitResult.SliderTailHit 2023-12-30 10:38:47 +09:00
Salman Ahmed
e469e06271 Refactor CatchLegacySkinTransformer logic and remove HiddenByRulesetImplementation entirely 2023-12-30 03:55:45 +03:00
Dean Herbert
2b81f4f557
Merge pull request from bdach/system-title-only-on-top-level-menu
Do not display system title in inital menu state
2023-12-29 21:13:40 +09:00
Bartłomiej Dach
db78d73fa5
Do not display system title in inital menu state
Addresses https://github.com/ppy/osu/discussions/26199.
2023-12-29 11:50:30 +01:00
Bartłomiej Dach
9bb0663b3b
Add test coverage of failure case 2023-12-29 10:36:53 +01:00
Bartłomiej Dach
68402bfd11
Add test coverage of failure scenario 2023-12-28 20:39:11 +01:00
Dean Herbert
8e3fe090f3
Merge pull request from bdach/universal-offset-from-session-plays
Implement automatic suggestion of global audio offset based on last plays
2023-12-28 22:57:30 +09:00
Bartłomiej Dach
24a80da83f
Merge branch 'master' into universal-offset-from-session-plays 2023-12-28 14:07:46 +01:00
Bartłomiej Dach
bb0737837b
Fix test failing due to querying button position during transform 2023-12-28 13:58:00 +01:00
Dean Herbert
6bc0f02e2d
Fix test initialising dialogs without cleaning up 2023-12-28 20:40:51 +09:00
Dean Herbert
f8347288c1
Add padding around text in dialogs 2023-12-28 20:29:56 +09:00
Dean Herbert
28e220ca50
Update popup dialog design
Had to be done. I hated the old ones so much.

As usual, disclaimer that this is an iterative design and will probably
be replaced in the future.
2023-12-28 19:04:35 +09:00
Dean Herbert
bd0e2b4dde
Remove disclaimer screen completely 2023-12-28 17:21:29 +09:00
Dean Herbert
1f2339244e
Add supporter display to main menu 2023-12-28 17:20:01 +09:00
Bartłomiej Dach
d9299a8a55
Implement visual appearance of "system title" message in main menu 2023-12-27 23:07:17 +01:00
Bartłomiej Dach
160342ceed
Implement automatic suggestion of audio offset based on last plays 2023-12-27 21:14:37 +01:00
Bartłomiej Dach
1b7af989ec
Migrate BeatmapOffsetControl to use session static directly 2023-12-27 19:19:27 +01:00
Bartłomiej Dach
53766285ce
Remove remaining hexacons usages 2023-12-27 17:42:18 +01:00
Dean Herbert
901674a130
Move back button inside sidebar to fix weird animation 2023-12-27 13:39:13 +09:00
Bartłomiej Dach
6f672b8cb3
Fix TestSceneKeyBindingPanel failures 2023-12-26 20:36:12 +01:00
Bartłomiej Dach
9ac79782d2
Add visibility toggle step to settings panel test scene 2023-12-26 20:21:15 +01:00
Dean Herbert
03e2463b06
Add test coverage and refactor to better handle equality edge case 2023-12-26 21:21:08 +09:00
Bartłomiej Dach
30b5b36f1d
Fix code quality inspection 2023-12-26 12:20:17 +01:00
Nathan Tran
4e3bdb2b56 Add test coverage 2023-12-26 00:57:06 -08:00
Bartłomiej Dach
32d8ee2d0c
Add test coverage 2023-12-23 13:42:19 +01:00
Dean Herbert
9f34dfa2ba
Add missing using statement 2023-12-23 16:25:52 +09:00
Simon G
01cf4ee15a
add test for length updates 2023-12-22 18:11:37 +01:00
Bartłomiej Dach
fbf19ea598
Merge branch 'master' into add-score-version 2023-12-21 13:06:53 +01:00
Bartłomiej Dach
5ff95db02c
Add test coverage of ClientVersion serialisation 2023-12-21 13:06:42 +01:00
Bartłomiej Dach
81bbdccee7
Rename ScoreInfo.{ -> Client}Version 2023-12-21 12:56:43 +01:00
Bartłomiej Dach
7e9d12e1d2
Merge pull request from smoogipoo/fix-total-score-conversion
Relocate numeric HitResult values, add accuracy conversion
2023-12-21 12:10:54 +01:00
Dean Herbert
a4baa0a716
Add versioning of local scores
For any potential future usage
2023-12-21 18:37:15 +09:00
Dean Herbert
0648201844
Cancel test more 2023-12-21 18:17:03 +09:00
Dan Balasescu
6b4b2a57fc
Expose only as one method 2023-12-21 14:58:23 +09:00
Dan Balasescu
4e3b994142
Relocate HitResult numeric score to ScoreProcessor 2023-12-21 14:52:31 +09:00
Dean Herbert
c5fb4d0f5c
Mark flaky test temporarily 2023-12-21 01:52:40 +09:00
Bartłomiej Dach
322cfaae1d
Merge branch 'master' into fix-standardised-score-conversion 2023-12-19 17:41:38 +01:00
Bartłomiej Dach
64b0534fb8
Merge pull request from peppy/fix-mod-settings-keyboard-adjust
Fix mod search textbox having focus while settings are visible
2023-12-19 15:44:17 +01:00
Bartłomiej Dach
d793d1cea1
Add test coverage of desired input handling behaviour 2023-12-19 14:52:16 +01:00
Bartłomiej Dach
e306cc35ba
Merge branch 'master' into fix-song-select-realm-refresh-performance 2023-12-19 14:14:46 +01:00
Dean Herbert
8f5d21dc70
Actually fix realm selection retention regression 2023-12-19 18:10:55 +09:00
Bartłomiej Dach
9c8df4e6d1
Run score conversion for previously-imported scores 2023-12-18 22:27:51 +01:00
Bartłomiej Dach
bf668174ec
Use nunit constraints in test for transparency 2023-12-18 19:02:23 +01:00
Dean Herbert
41485c19cf
Add realm refresh steps in an attempt to stabilise failing test
I think this is required because there is a higher chance of batched
updates with the new structure (and less calls to `BeatmapSetsChanged`
which causes re-selection).
2023-12-19 02:08:29 +09:00
Bartłomiej Dach
be16e0e538
Add failing test for adding collection w/ name colliding w/\ default items 2023-12-18 12:47:42 +01:00
Bartłomiej Dach
67a5e01c49
Update assertions in test 2023-12-14 15:19:29 +01:00
Dean Herbert
76653e61cb
Merge pull request from frenzibyte/collection-dropdown-improve-ux
Improve handling of beatmap collection changes in `CollectionDropdown`
2023-12-14 18:39:36 +09:00
Bartłomiej Dach
839a080247
Add test coverage for desired mod overlay search box behaviour 2023-12-14 09:52:38 +01:00
Salman Ahmed
31c9489cb9 Fix failing tests 2023-12-13 23:38:19 +03:00
Dean Herbert
c6b1a5f1ee
Merge pull request from bdach/fix-skin-editor-crash-again
Fix skin editor crashing in some circumstances when opened in main menu
2023-12-13 22:15:42 +09:00
Dan Balasescu
8c7570525a
Merge pull request from peppy/adjust-mod-multipliers
Adjust some mod multipliers for initial leaderboard sanity
2023-12-13 17:56:13 +09:00
Bartłomiej Dach
e865de7a6b
Update test assertions in line with half time mod multiplier changes 2023-12-13 09:25:56 +01:00
Dean Herbert
fdcf87569c
Merge pull request from smoogipoo/mania-convert-song-select-keycount
Display osu!mania keycount in song select carousel panels and details
2023-12-13 16:31:25 +09:00
Dean Herbert
ec6200b4ad
Merge pull request from peppy/merge-everything-at-once
Merge everything at once
2023-12-13 16:17:06 +09:00
Dean Herbert
eff81be6fd
Fix failing test and add coverage of conversion case 2023-12-13 16:01:52 +09:00
Dean Herbert
c2d3dcdd9c
Fix slider tests and incorrect nullability handling around freehandToolboxGroup 2023-12-13 15:15:49 +09:00
Dean Herbert
5e10f9f899
Fix failing tests due to more textboxes being present with searchable dropdowns 2023-12-13 15:11:47 +09:00
Dean Herbert
aa4faf5e8e
Merge pull request from smoogipoo/fix-ignoremiss-accuracy-update
Fix IgnoreMiss judgements not updating accuracy
2023-12-13 15:03:07 +09:00
Dan Balasescu
41ba1dcfce
Merge branch 'master' into editor/checks/delayed-hitsounds 2023-12-13 14:01:06 +09:00
Dean Herbert
343ecc469f
Merge branch 'master' into dropdown-search 2023-12-13 13:58:23 +09:00
Dan Balasescu
8977e74171
Fix editor test not waiting for editor to load 2023-12-13 13:15:49 +09:00
Dan Balasescu
daaadf3fc3
Fix IgnoreMiss judgements not updating accuracy 2023-12-13 11:51:45 +09:00
Salman Ahmed
10e8edff67 Merge branch 'master' into dropdown-search 2023-12-12 21:14:01 +03:00
Dan Balasescu
987fe9322e
Merge pull request from Zyfarok/scorev3
Modify osu! standardised scoring to introduce a combo exponent
2023-12-12 17:38:44 +09:00
Bartłomiej Dach
9a83d7be81
Ensure that SoloScoreInfo serialisation result does not contain interface members 2023-12-08 09:27:12 +01:00
Dean Herbert
ea0ad2a0ef
Merge branch 'master' into online-presence 2023-12-07 17:42:46 +09:00
Dean Herbert
3c29e9162c
Merge pull request from bdach/online-presence-structure-serialisation
Simplify user presence structures for serialisability
2023-12-07 17:39:21 +09:00
Dean Herbert
a500f55ec6
Merge pull request from peppy/match-default-sv
Change default slider velocity for new beatmaps to match osu!stable
2023-12-07 11:52:16 +09:00
Bartłomiej Dach
86e003aec1
Update currently online display tests 2023-12-06 19:37:35 +01:00
Bartłomiej Dach
602550b9c2
Fix test failures 2023-12-06 19:37:28 +01:00
Bartłomiej Dach
d66fa09320
Simplify UserStatus to be an enumeration type
There were absolutely no gains from having it be a reference type /
class, only complications, especially when coming from the serialisation
angle.
2023-12-06 18:52:27 +01:00
Bartłomiej Dach
faf60cec91
Extend test coverage of skin editor open to fail better 2023-12-06 10:11:41 +01:00
Bartłomiej Dach
4585a169b1
Merge pull request from peppy/fix-song-select-match
Fix searching at song select matching incorrect ruleset
2023-12-06 09:25:47 +01:00
Dean Herbert
43dc908257
Fix test value getting clobbered due to stupid stuff
Don't even ask. Just smile and nod.
2023-12-06 15:59:29 +09:00
Dean Herbert
79826dee58
Fix tests which were relying on SliderMultiplier==1 2023-12-06 13:50:10 +09:00
Dean Herbert
4da6d53c72
Merge pull request from frenzibyte/fix-argon-health-display-2
Fix `ArgonHealthDisplay` sometimes behaving weirdly on miss judgements (alternative)
2023-12-06 12:24:39 +09:00
Dean Herbert
8286d3896f
Fix searching at song select matching incorrect ruleset
Regressed with https://github.com/ppy/osu/pull/25679.
2023-12-06 11:32:26 +09:00
Salman Ahmed
a67df76654 Add test coverage 2023-12-05 22:53:48 +03:00
Salman Ahmed
c55bfc03ee Move private method 2023-12-05 22:06:53 +03:00
Salman Ahmed
20fd458fac Perserve miss animation when followed by a hit at same frame 2023-12-05 21:59:28 +03:00
Salman Ahmed
986f4fa407 Add test scenarios for same-frame judgements 2023-12-05 21:59:28 +03:00
Dean Herbert
5a2240838b
Merge branch 'master' into multiplayer-abort 2023-12-05 17:01:54 +09:00
Salman Ahmed
17577a6606 Add visual test case for late miss in argon health display 2023-12-04 23:01:11 +03:00
Bartłomiej Dach
063694f544
Do not attempt to load gameplay scene if current beatmap is dummy 2023-12-04 14:42:51 +01:00
Bartłomiej Dach
43312619e3
Add test coverage for crashing on wrong ruleset 2023-12-04 14:42:51 +01:00
Bartłomiej Dach
7c041df0f1
Add test coverage for crashing on dummy beatmap 2023-12-04 14:42:42 +01:00
Bartłomiej Dach
d3e94cd5bf
Add test coverage for crashing on empty beatmap 2023-12-04 14:42:40 +01:00
Bartłomiej Dach
7deff70b4a
Extract beatmap import steps from gameplay scene switch helper 2023-12-04 13:34:36 +01:00
Dan Balasescu
8587652869
Fix countdown button being enabled 2023-12-04 11:00:11 +09:00
Dan Balasescu
9ccd33a1ec
Add comments to test 2023-12-04 10:20:53 +09:00
Dan Balasescu
c2644a5d5e
Correctly implement button enabled state 2023-12-04 10:18:37 +09:00
Bartłomiej Dach
30a4e77097
Merge branch 'master' into fix-overlapping-chat-links 2023-12-01 14:30:55 +01:00
Dan Balasescu
f3530a79b1
Add test 2023-12-01 21:34:20 +09:00
Bartłomiej Dach
d97ae8df6a
Remove commented out italic code
It's a holdover from the Exo days (anyone remember those?) and hasn't
been relevant for years, so why keep it.
2023-12-01 13:31:11 +01:00
Susko3
c395ae2460 Add failing tests
They throws `ArgumentOutOfRangeException` on the first drawable Update()
2023-12-01 00:51:20 +01:00
Susko3
7f9ae55f5e Add passing tests 2023-12-01 00:48:55 +01:00
Susko3
1a33bfbb3a Enable NRT 2023-12-01 00:37:16 +01:00
Susko3
fba6349c65 Remove unused properties 2023-12-01 00:36:40 +01:00
Susko3
21fedff54f Check number of links shown 2023-12-01 00:29:37 +01:00
Susko3
7b1ccb38cb Remove redundant string interpolation 2023-11-30 23:35:10 +01:00
Susko3
0520ac265f Move to TestCase-based test 2023-11-30 23:34:43 +01:00
Susko3
52ffbcc6db Move special cases to TestCase'd test 2023-11-30 23:29:22 +01:00
Susko3
3ca3f25492 Extract local method 2023-11-30 23:26:52 +01:00
Susko3
9a32c0368e Remove redundant linkAmount parameter 2023-11-30 14:38:58 +01:00
Susko3
831fe5b9f2 Use collection assert to ease debugging 2023-11-30 14:36:23 +01:00
Dean Herbert
b2e1a63cd7
Merge pull request from smoogipoo/fix-bad-slider-lengths
Fix taiko and mania using the incorrect slider length when converting beatmaps
2023-11-30 16:59:48 +09:00
Dan Balasescu
295a1b01d6
Adjust catch score grade cutoffs 2023-11-29 19:05:31 +09:00
Dan Balasescu
26855a2c04
Add failing test 2023-11-28 21:14:34 +09:00
Bartłomiej Dach
98ab9853ce
Merge branch 'master' into show-spectator-fail-2 2023-11-27 12:24:59 +09:00
Bartłomiej Dach
19639de299
Merge branch 'master' into fix-spectator-quit-2 2023-11-27 11:36:10 +09:00
Bartłomiej Dach
1388e492b1
Merge branch 'master' into chat-drag-improvements 2023-11-27 10:46:55 +09:00
Dean Herbert
9015615336
Update test to work with new drag bar location 2023-11-24 19:45:04 +09:00
Dean Herbert
de1d921383
Merge branch 'master' into menu-skin-editor-button 2023-11-24 17:39:54 +09:00
Dean Herbert
55df8e81b9
Merge pull request from peppy/hexacons-sprite-icon
Replace all hexacon lookups with strongly typed properties
2023-11-24 17:38:58 +09:00
Dean Herbert
e3217bc82e
Merge branch 'master' into hp-drain-fix-breaks 2023-11-24 15:15:48 +09:00
Dan Balasescu
289cda71b2
Fix inspections 2023-11-24 15:06:51 +09:00
Dean Herbert
7ceb49fbc0
Add extra test coverage and handle case where still at loading screen 2023-11-24 15:05:39 +09:00
Dean Herbert
ef5dd24589
Update failing test coverage and fix onFail being called too often 2023-11-24 14:44:57 +09:00
Dean Herbert
51e2ce500d
Add test coverage of remote user failing immediately failing locally 2023-11-24 14:38:02 +09:00
Dean Herbert
73ad92189b
Add test coverage of remote player quitting immediately quitting locally 2023-11-24 14:26:09 +09:00
Dean Herbert
e06d79281d
Update tests to work with nested screen 2023-11-24 14:26:09 +09:00
Dean Herbert
dabbdf674b
Rename SoloSpectator to SoloSpectatorScreen 2023-11-24 14:26:08 +09:00
Dean Herbert
a02b6a5bcb
Update menu key shortcut test coverage 2023-11-24 13:18:17 +09:00
Dean Herbert
7e59a1d0be
Apply NRT to ButtonSystem 2023-11-24 13:18:17 +09:00
Dean Herbert
5905ca6492
Add second level menu for skin editors 2023-11-24 13:18:17 +09:00
Dean Herbert
340227a06d
Replace all hexacon lookups with strongly typed properties 2023-11-24 13:17:39 +09:00
Bartłomiej Dach
2a6885164c
Update tests to match new scoring expectations 2023-11-24 10:46:21 +09:00
Dean Herbert
686afa9697
Merge branch 'master' into fix-combo-handling 2023-11-24 10:30:52 +09:00
Dan Balasescu
10e16e4b04
Fix handling of combo offset without new combo, and incorrect lazer tests 2023-11-24 09:46:06 +09:00
Dan Balasescu
7bc2d6e6cd
Merge branch 'master' into fix-combo-handling 2023-11-23 16:22:01 +09:00
Dean Herbert
5d367c247c
Merge pull request from bdach/skin-editor-paste-catching-fire
Fix skin editor crashing when pasting with nothing in clipboard
2023-11-23 16:15:11 +09:00
Dan Balasescu
7998204cfe
Fix combo/combo colouring issues around spinners 2023-11-23 13:54:05 +09:00
Bartłomiej Dach
d4519f74ab
Merge branch 'master' into hp-drain-fix-breaks 2023-11-23 10:31:42 +09:00
Bartłomiej Dach
4edaaa3083
Add test coverage of skin editor copy-paste 2023-11-23 09:55:16 +09:00
Dan Balasescu
30309cdf11
Merge pull request from Poyo-SSB-forks/unify-ur
Change unstable rate calculation to account for rate-change mods
2023-11-23 09:53:28 +09:00
Bartłomiej Dach
81816e303c
Merge pull request from peppy/editor-test-failures
Attempt to fix intermittent failures on new tests
2023-11-23 09:42:34 +09:00
Bartłomiej Dach
3441a9a5b5
Add test coverage for classic scoring overflowing in osu! ruleset 2023-11-23 08:12:34 +09:00
Dean Herbert
aa8dc6bd80
Attempt to fix intermittent failures on new tests
See https://github.com/ppy/osu/pull/25418/checks?check_run_id=18886372597.
2023-11-22 21:46:35 +09:00
Dan Balasescu
cb4568c4a1
Fix first object after break not starting a new combo 2023-11-22 17:22:48 +09:00
Dean Herbert
d86e743745
Merge branch 'master' into login-state-changes-user-profile-overlay 2023-11-22 12:13:49 +09:00
Dean Herbert
21bf288277
Merge pull request from peppy/context-menu-spacers
Allow context menus to have visible spacers
2023-11-21 16:56:36 +09:00
Bartłomiej Dach
bf972a04ee
Merge pull request from Tom94/bspline-sliders
Add free-hand drawing of sliders to the editor
2023-11-21 16:28:14 +09:00
Bartłomiej Dach
d83b2e24e7
Merge pull request from RatinFX/open-editor-timestamp
Implement opening editor timestamp links
2023-11-21 15:48:36 +09:00
Dean Herbert
9c3f9db318
Add failing test coverage of BSpline encoding parse failure 2023-11-21 15:38:12 +09:00
Dean Herbert
917a68eac3
Adjust localisablel strings and keys 2023-11-21 15:08:15 +09:00
Dean Herbert
3afaafb1d9
Reorder and simplify private helper methods 2023-11-21 15:05:51 +09:00
Dean Herbert
405ab499e9
Allow context menus to have visible spacers 2023-11-21 14:24:10 +09:00
Stedoss
826c82de47 Add unit test for handling login state in UserProfileOverlay 2023-11-21 01:56:37 +00:00
Bartłomiej Dach
c16afeb347
Fix tests 2023-11-20 21:57:14 +09:00
Bartłomiej Dach
b6e3e42445
Merge branch 'master' into bspline-sliders 2023-11-20 12:03:29 +09:00
Dean Herbert
b88e3cd26f
Change ResourceStore provided to Skin to be a fallback, not replacement 2023-11-16 20:19:01 +09:00
Dean Herbert
f7fa9c90d6
Add test coverage of 2FA flow 2023-11-16 18:18:40 +09:00
Dean Herbert
e9d4cf2e24
Setup basic form flow 2023-11-16 18:18:15 +09:00
Dean Herbert
87a76b9ee8
Merge pull request from Joehuu/fix-comment-markdown
Fix `CommentMarkdownTextFlowContainer` not inheriting osu! class
2023-11-16 17:39:35 +09:00
Bartłomiej Dach
1e2f1b3ef2
Merge branch 'master' into unload-main-menu-storyboard 2023-11-16 15:46:44 +09:00
Dean Herbert
4642b916b0
Merge pull request from peppy/argon-skin-coverage
Add test coverage of accessing skin layout after importing customised default skins
2023-11-16 13:44:39 +09:00
Joseph Madamba
dc2d574965 Fix comment markdown image not showing tooltips 2023-11-15 19:50:32 -08:00
Joseph Madamba
2b19cf6ce4 Fix comment markdown style regression 2023-11-15 19:50:32 -08:00
Dean Herbert
7f90db7603
Merge pull request from bdach/argon-health-folding-in-on-self
Fix argon health bar folding in on itself when too narrow
2023-11-15 19:02:30 +09:00
Bartłomiej Dach
0c0093e641
Merge branch 'master' into argon-skin-coverage 2023-11-15 18:30:03 +09:00
Bartłomiej Dach
b118999120
Remove unused using directive 2023-11-15 18:27:08 +09:00
Dean Herbert
189fca2eb6
Merge pull request from joshika39/change-clickable-avatars-tooltip-for-usergrid
Add `UserGridPanel` as the `ClickableAvatar` tooltip
2023-11-15 18:01:24 +09:00
Dean Herbert
aac1854d83
Add test coverage of layout retrievable after importing modified skins 2023-11-15 14:08:05 +09:00
Dean Herbert
a5e1dd8107
Add test coverage of deserialising a modified Argon skin 2023-11-15 14:07:51 +09:00
Bartłomiej Dach
71714f8f6e
Add back test step for testing out argon health bar width 2023-11-15 13:33:14 +09:00
Dan Balasescu
e3137d575b
Fix osu! and base HP processor break time implementation 2023-11-14 01:11:17 +09:00
cs
fa976a5aa0 Fix code style/quality issues 2023-11-13 08:25:27 +01:00
Poyo
8c36604e58 Add rate-change UR tests 2023-11-12 11:16:06 -08:00
Poyo
d123ba5bce Fix broken tests 2023-11-12 11:13:38 -08:00
Dean Herbert
31feeb5ddc
Disable new rider EAP inspection in test class 2023-11-12 17:21:17 +09:00
Bartłomiej Dach
3e8c89e282
Fix one more reference to removed setting 2023-11-12 07:42:41 +09:00
cs
54b8244a18 CI Fixup 2023-11-11 15:02:06 +01:00
Thomas Müller-Höhne
926636cc03 Generalize Bezier curves to BSplines of Nth degree 2023-11-11 13:32:53 +01:00
Bartłomiej Dach
ea556abad8
Merge branch 'skin-size-editing' into gameplay-hud-redesign/counters 2023-11-11 21:28:29 +09:00
Bartłomiej Dach
ee56b4d205
Use barely better assertion fail message in test 2023-11-11 20:56:05 +09:00
Bartłomiej Dach
b7972e3c84
Merge branch 'skin-size-editing' into gameplay-hud-redesign/counters 2023-11-11 20:16:14 +09:00
Bartłomiej Dach
b247b94ecb
Revert test changes
They were broken because `SerialisedDrawableInfo` is a reference type
and as such equality checks will use reference equality rather than
member equality.
2023-11-11 19:32:46 +09:00
Bartłomiej Dach
21e1d68b15
Remove unused using directive 2023-11-11 15:52:24 +09:00
Dean Herbert
2e48569982
Improve test comparison logic
Doesn't really help that much with nunit output,
but at least you can breakpoint and see the json kinda.
2023-11-10 20:00:51 +09:00
Bartłomiej Dach
b6dcd7d55f
Fix tests so that they actually assert something 2023-11-10 18:48:45 +09:00
Bartłomiej Dach
ec2200d54f
Remove another reference to bar length 2023-11-10 18:26:08 +09:00
Bartłomiej Dach
c522a703eb
Merge branch 'master' into skin-size-editing 2023-11-10 18:19:27 +09:00
Dean Herbert
1c63f1f89d
Merge pull request from bdach/less-basic-touchscreen-detection
Implement basic touchscreen detection
2023-11-10 18:01:40 +09:00
Dean Herbert
35e11c7c63
Rename diagonal scale variable and update xmldoc 2023-11-10 17:55:02 +09:00
Bartłomiej Dach
d0f1326a63
Fix formatting 2023-11-10 17:54:48 +09:00
Dean Herbert
fa5921862f
Update deserialising test 2023-11-10 16:53:15 +09:00
Bartłomiej Dach
8690b08769
Fix compose select box test failures 2023-11-10 16:08:45 +09:00
Dean Herbert
f13648418b
Update HitResultTest to be more conformant to original expectations 2023-11-10 12:10:54 +09:00
Dean Herbert
7fc2050f72
Rename variables and mak seconary tooltip type work again 2023-11-10 11:52:34 +09:00
Salman Ahmed
d3af3c615f Merge branch 'master' into gameplay-hud-redesign/counters 2023-11-10 01:04:03 +03:00
Salman Ahmed
cc9aeb5307 Add test coverage 2023-11-09 22:57:20 +03:00
Salman Ahmed
d4722a3988 Add failing test case 2023-11-09 17:20:10 +03:00
Dean Herbert
1ae3265f92
Update tests in line with new behaviour 2023-11-09 22:03:22 +09:00
Joshua Hegedus
4900a91c60
fixed static analysis problems and finished the implementation 2023-11-09 13:27:09 +01:00
Joshua Hegedus
ccb9ff826a
fixed tests 2023-11-09 13:09:59 +01:00
Dean Herbert
02966bc02f
Merge branch 'master' into change-clickable-avatars-tooltip-for-usergrid 2023-11-09 18:19:23 +09:00
Bartłomiej Dach
13b599b9b6
Merge branch 'master' into less-basic-touchscreen-detection 2023-11-09 17:36:48 +09:00
Dean Herbert
5ac285ed2f
Merge pull request from frenzibyte/fix-create-difficulty-crash
Fix editor crash when creating a new difficulty in a non-existent beatmap
2023-11-08 18:56:00 +09:00
Dean Herbert
38847c3ac5
Change test to move only on a toggle step 2023-11-08 17:23:01 +09:00
Salman Ahmed
d0fea381b1 Update skin deserialisation archives 2023-11-08 02:13:16 +03:00
Salman Ahmed
18c71c95cc Merge branch 'master' into gameplay-hud-redesign/counters 2023-11-08 02:12:37 +03:00
ratinfx
81caa854e6 Separate Test cases by relevant rulesets 2023-11-07 13:02:46 +01:00
ratinfx
aa87e0a44d HitObject Selection logic and separation for gamemodes
+ moved time_regex into EditorTimestampParser
2023-11-07 01:36:58 +01:00
ratinfx
8e8a88cfaf Removed nullable line from Test 2023-11-07 00:54:15 +01:00
Salman Ahmed
38d16f620c Alter test case to comply with new behaviour 2023-11-06 21:55:00 +03:00
Salman Ahmed
944fee56f8 Add failing test case 2023-11-06 21:54:40 +03:00
Andrei Zavatski
9d10d93085 Adjust test scene to see graph flickering 2023-11-06 20:45:52 +03:00
Joshua Hegedus
a01f6187f4
testing the tooltip 2023-11-06 14:52:06 +01:00
Joshua Hegedus
718492a0b7
fixed DRY 2023-11-06 11:29:15 +01:00
Bartłomiej Dach
41cd9a4db6
Merge pull request from peppy/add-skinnable-player-name
Add player name skin component
2023-11-06 09:34:11 +01:00
Bartłomiej Dach
69d6feb5a8
Add test coverage for player name skin component 2023-11-06 08:51:31 +01:00
Joshua Hegedus
b45d8c785c
fixed review findings 2023-11-06 08:38:34 +01:00
Bartłomiej Dach
adb9ca5a13
Add failing test coverage for incorrect treatment of TD in mod presets 2023-11-06 07:56:09 +01:00
Salman Ahmed
634795e45f Adjust failing test scenes 2023-11-05 02:50:14 +03:00
Salman Ahmed
1d4f4cf4c3 Merge branch 'master' into gameplay-hud-redesign/counters 2023-11-05 02:02:36 +03:00
Salman Ahmed
77f5a4cdf5 Update skin deserialisation archive 2023-11-05 02:01:26 +03:00
Salman Ahmed
58a830fc5b Revert "Add "Argon" performance points counter"
This reverts commit 56eeb117ce.
2023-11-05 01:55:54 +03:00
ratinfx
7492d953ae Moved error checks into Editor
- Invoke Action on error to Notify user
- added some comments
2023-11-04 21:17:58 +01:00
Joshua Hegedus
ec290ae953
added tests 2023-11-04 19:03:23 +01:00
ratinfx
19cdf99df8 Fixed up tests 2023-11-04 12:04:58 +01:00
ratinfx
f867cff8c7 Added OpenEditorTimestamp Tests 2023-11-04 03:42:08 +01:00
Joseph Madamba
3f8baf913b
Add 100 and 1000 key press step to test overflow 2023-11-02 20:49:01 -07:00
Joseph Madamba
e3b3ce6c84
Fix test overflowing on widescreen + add default (triangles) key counter testing 2023-11-02 20:42:28 -07:00
Joseph Madamba
090601b485
Apply peppy's upright key counter attempt diff
Co-Authored-By: Dean Herbert <pe@ppy.sh>
2023-11-02 20:42:23 -07:00
Bartłomiej Dach
d25b54c06d
Split test into two
They would fail on CI when written as one, and I don't care why.
2023-11-02 22:14:38 +01:00
Bartłomiej Dach
ef555ed0cf
Fix test failures 2023-11-02 21:24:58 +01:00
Bartłomiej Dach
21a4da463b
Add failing test covering crash scenario 2023-11-02 21:24:58 +01:00
Bartłomiej Dach
29d4d81eaa
Add test scene for basic touchscreen detection scenarios 2023-11-02 21:24:58 +01:00
Bartłomiej Dach
2f6ff893b5
Automatically activate and deactivate touch device mod in song select 2023-11-02 19:45:48 +01:00
Bartłomiej Dach
980c900f43
Add component for game-wide touch detection 2023-11-02 19:32:56 +01:00
Dean Herbert
8c067dc584
Fix mod tests not waiting for presets to finish loading
See https://github.com/ppy/osu/actions/runs/6692350567/job/18181352850.
2023-10-31 14:53:07 +09:00
Dean Herbert
7ceced7012
Scope TestPauseWithLargeOffset to focus on what matters
See https://github.com/ppy/osu/actions/runs/6693917410/job/18186111009

This test is to make sure we don't seek before the original
pause time, so I've exposed that value precisely to avoid
CI woes.
2023-10-31 14:47:04 +09:00
Dean Herbert
d379e553da
Fix back-to-front logging 2023-10-31 14:31:26 +09:00
Dean Herbert
bdd3f2847b
Add an extra storyboard sample to avoid intermittent failures in TestStoryboardSamplesStopOnSkip
Probably CI running slow timing balls.

The point of failure is `waitUntilStoryboardSamplesPlay()`
after already testing the important part of the test (that
the samples stop on skip) so let's give it another possible
point to recover.

See https://github.com/ppy/osu/actions/runs/6698399814/job/18201753701.
2023-10-31 14:28:40 +09:00
Dean Herbert
66b84d02cb
Add note about TestGameplayExitFlow failure, and ignore for now
See:
https://github.com/ppy/osu/actions/runs/6695995685/job/18194110641
https://github.com/ppy/osu/actions/runs/6700910613/job/18208272419
2023-10-31 14:27:55 +09:00
Dean Herbert
89444d5544
Fix export test still occasionally failing due to file write in progress
https://github.com/ppy/osu/actions/runs/6701591401/job/18209826074

Basically, `File.Move` may not be an atomic operation.
2023-10-31 14:00:49 +09:00
Dean Herbert
37ec10d4f5
Fix TestSongSelectScrollHandling not waiting for VolumeOverlay to load
See https://github.com/ppy/osu/actions/runs/6701786492/job/18210372721.
2023-10-31 13:49:53 +09:00
Dean Herbert
fa220d34de
Merge pull request from frenzibyte/use-scale-adjust-for-player-max-dimensions-test-scene
Fix `TestScenePlayerMaxDimensions` texture loading process bottlenecking CI
2023-10-31 13:36:30 +09:00
Dean Herbert
a3dc9a73b1
Revert behaviour changes of MaxDimensions test and ignore instead 2023-10-31 13:36:10 +09:00
Dean Herbert
3060cf1438
Merge pull request from frenzibyte/search-text-box-select-all
Automatically select existing search text when opening settings
2023-10-31 12:14:00 +09:00
Bartłomiej Dach
06508d08fe
Delete outdated test 2023-10-30 20:22:41 +01:00
Bartłomiej Dach
b2d3aa982d
Merge branch 'master' into fix-click-through-timeline 2023-10-30 12:52:00 +01:00
Dean Herbert
8828562512
Merge pull request from Susko3/fix-cut-in-filter-textbox
Fix cut and copy not working in song select search filter textbox
2023-10-30 18:18:46 +09:00
Bartłomiej Dach
2dc2469507
Merge pull request from peppy/last-played-import-score-update
Update the last played date of a beatmap when importing a replay by the local user
2023-10-30 10:12:27 +01:00
Dean Herbert
63e6eaf538
Fix failing tests 2023-10-30 18:06:11 +09:00
Dean Herbert
6be02966b9
Add test coverage of failing context menu display 2023-10-30 18:06:11 +09:00
Bartłomiej Dach
0dfb41b796
Add test coverage for not updating LastPlayed due to newer plays 2023-10-30 09:28:37 +01:00
Dean Herbert
caddbacfe8
Merge branch 'master' into gameplay-hud-redesign/counters 2023-10-30 16:35:10 +09:00
Dean Herbert
96dd7b3333
Update the last played date of a beatmap when importing a replay by the local user 2023-10-30 15:44:16 +09:00
Salman Ahmed
c7bc8e6865 Move behaviour to settings search text box only 2023-10-30 06:41:01 +03:00
Salman Ahmed
af10dbb76c Add test case with many tournament banners 2023-10-30 06:20:01 +03:00
Salman Ahmed
ec9ae12bbd Update API response model to accept array of tournament banners 2023-10-29 01:43:49 +03:00
Salman Ahmed
31c6973bb6 Add test coverage 2023-10-29 01:03:45 +03:00
Susko3
cfc0520481 Add failing test 2023-10-28 12:13:13 +02:00
Salman Ahmed
a53c0adae0 Remove unused using directive 2023-10-28 06:56:12 +03:00
Salman Ahmed
51b7c97cab Fix TestScenePlayerMaxDimensions bottlenecking CI 2023-10-28 06:07:49 +03:00
Bartłomiej Dach
2f9b50172e
Add failing test coverage for video events affecting storyboard time bounds 2023-10-27 22:09:33 +02:00
Dean Herbert
5a9d4170e8
Merge pull request from bdach/score-encoding-cleanup
Correctly handle multiple online score ID types
2023-10-28 02:29:56 +09:00
Dean Herbert
4ed30342db
Merge pull request from bdach/quick-retry-f-rank
Fix quick retry immediately after completion marking score as failed
2023-10-28 02:29:21 +09:00
Bartłomiej Dach
b5cb538004
Add failing test case for skin editor freeze 2023-10-27 14:23:41 +02:00
Bartłomiej Dach
6789a522d6
Rename test to distinguish it from test-to-come 2023-10-27 14:15:30 +02:00
Bartłomiej Dach
32fc19ea0d
Fix results screen test failure 2023-10-27 13:22:17 +02:00
Bartłomiej Dach
96d784e06b
Delete ScoreInfo.HasReplay as no longer needed 2023-10-27 12:39:54 +02:00
Bartłomiej Dach
3944b045ed
Add extra test coverage for marking score as failed 2023-10-27 12:17:03 +02:00
Bartłomiej Dach
7140eee870
Add failing test coverage for quick retry after completion not changing rank 2023-10-27 12:17:03 +02:00
Dean Herbert
fc25e24397
Merge branch 'master' into score-encoding-cleanup 2023-10-27 18:03:38 +09:00
Bartłomiej Dach
0482c05d7c
Add failing test case 2023-10-26 19:38:52 +02:00
Dean Herbert
a463c37320
Merge pull request from bdach/song-select-volume-scroll-blocked
Fix left side of carousel blocking volume adjust hotkeys
2023-10-27 00:23:47 +09:00
Bartłomiej Dach
5d6a58d443
Add failing test scene for scroll handling in song select 2023-10-26 16:24:16 +02:00
Bartłomiej Dach
dbb69419e6
Add test coverage for parsing new online ID 2023-10-26 12:39:07 +02:00
Bartłomiej Dach
89fec95b01
Fix cross-test data dependency by recreating slider every time 2023-10-26 12:11:26 +02:00
Bartłomiej Dach
96437c4518
Fix tests specifying float precision for double bindable
Would cause assignments to `.Value` to become imprecise even if the
underlying bindable could represent the value 100% accurately.
2023-10-26 12:06:03 +02:00
Bartłomiej Dach
910d74fdda
Add failing test coverage for double-click on disabled sliders 2023-10-26 11:59:38 +02:00
Salman Ahmed
841c5bb4bd Add modified skin for serialisation test coverage 2023-10-26 11:05:00 +03:00
Bartłomiej Dach
2ba02416c2
Revert test changes fully to clean up diff 2023-10-26 09:14:59 +02:00
Bartłomiej Dach
ca4b09f8ef
Merge branch 'master' into score-encoding-cleanup 2023-10-26 09:04:05 +02:00
Salman Ahmed
df80b4dcab Update "Argon" health display specifications to match design
Also adds a little white bar next to the display to match with the
components below it (score/accuracy/combo counters).
2023-10-26 09:12:05 +03:00
Salman Ahmed
56eeb117ce Add "Argon" performance points counter 2023-10-26 09:10:10 +03:00
Salman Ahmed
0aa0562dc0 Add "Argon" combo counter 2023-10-26 09:09:55 +03:00
Salman Ahmed
1f36acca1a Add "Argon" accuracy counter 2023-10-26 09:09:52 +03:00
Salman Ahmed
9ca672d689 Add "Argon" total score counter 2023-10-26 08:58:25 +03:00
Dean Herbert
6934e045df
Fix editor not prompting before saving beatmap for export 2023-10-25 14:39:46 +09:00
Bartłomiej Dach
19be0055d5
Merge pull request from Pasi4K5/diff-name-search
Add ability to search for difficulty names using square brackets
2023-10-24 12:07:02 +02:00
Bartłomiej Dach
966decb008
Remove redundant explicit array type specification 2023-10-24 11:25:37 +02:00
Bartłomiej Dach
b4cc12ab5a
Fix formatting 2023-10-24 10:00:58 +02:00
Dean Herbert
fcb366af4d
Add diff= support for more advanced usages 2023-10-24 16:09:05 +09:00
Dean Herbert
6865d8894d
Simplify implementation and remove unsupported test coverage 2023-10-24 16:01:32 +09:00
Dean Herbert
794c3a2473
Add a couple more tests for sanity 2023-10-24 15:22:27 +09:00
Dean Herbert
b16ece32f4
Put tests in more correct place 2023-10-24 15:14:30 +09:00
Dean Herbert
383d715378
Fix incorrectly named test 2023-10-24 14:59:21 +09:00
Andrei Zavatski
1dbdbd6de6 Merge branch 'master' into comments-image-size 2023-10-23 13:22:31 +03:00
Dean Herbert
a26e0bda35
Merge pull request from bdach/insufficient-sample-point-query-leniency
Fix insufficient leniency when querying sample points
2023-10-20 20:07:32 +09:00
Bartłomiej Dach
59a1915451
Add failing test case for insufficient sample query leniency 2023-10-20 10:25:28 +02:00
Dean Herbert
686c45e21b
Merge branch 'master' into legacy-tick-test-coverage 2023-10-20 16:41:32 +09:00
Dean Herbert
f36a671eb4
Fix a couple of silly inspections 2023-10-20 15:38:00 +09:00
Bartłomiej Dach
dcfd6a0a8a
Remove DistancedHitObjectComposer inheritance from osu! composer 2023-10-19 11:46:30 +02:00
Dan Balasescu
939b55020c
Merge branch 'master' into legacy-tick-test-coverage 2023-10-18 15:21:31 +09:00
Joseph Madamba
1a3a81c33b Add slider nub double click revert to default test 2023-10-17 21:41:03 -07:00
Bartłomiej Dach
e927267c4d
Merge pull request from peppy/fix-new-inspections
Fix various new rider EAP inspections
2023-10-17 17:04:39 +02:00
Dean Herbert
e081fa48a2
Fix various other inspections 2023-10-17 17:48:51 +09:00
Dean Herbert
5341a335a6
Bypass Parent nullability checks for now 2023-10-17 17:48:45 +09:00
Dean Herbert
4885c55ef0
Merge branch 'master' into key-binding-deduplication 2023-10-17 17:17:44 +09:00
Dan Balasescu
d2a3f14d5b
Merge branch 'master' into mania-bonus-refactor 2023-10-17 13:28:04 +09:00
Bartłomiej Dach
3aae07d1ca
Add failing case for two bindings of single action bound to same key 2023-10-16 22:20:26 +02:00
Bartłomiej Dach
9c6166ec3d
Add migration to remove duplicate bindings 2023-10-16 22:20:26 +02:00
Bartłomiej Dach
90c44cee54
Implement method to deduplicate keybindings 2023-10-16 20:51:57 +02:00
Bartłomiej Dach
79273b88f6
Add stub of method to deduplicate bindings (and failing test) 2023-10-16 20:48:52 +02:00
Bartłomiej Dach
e2192806e4
Use ID rather than SoloScoreID
The latter is apparently not going to be a thing anymore.
2023-10-16 12:02:55 +02:00
Bartłomiej Dach
d5a733d244
Use solo score ID as OnlineID when converting from MultiplayerScore 2023-10-16 11:20:02 +02:00
Bartłomiej Dach
bfcb4f4f2d
Add failing test for legacy online ID decoding 2023-10-16 11:20:02 +02:00
Dean Herbert
7c49843411
Fix various tests 2023-10-16 14:21:33 +09:00
Bartłomiej Dach
9b474b656d
Fix key binding panel test failures from introducing placeholder text
Whoops.
2023-10-13 15:03:41 +02:00
Dean Herbert
6358a5e210
Merge pull request from bdach/multiple-keys-one-binding
Disallow binding multiple bindings in a single section to one key
2023-10-13 20:01:33 +09:00
Bartłomiej Dach
5f51b8a7c9
Merge pull request from peppy/results-screen-progress-fast
Show results immediately if user hits "back" key after finishing gameplay
2023-10-13 11:54:34 +02:00
Dean Herbert
17b6ebbfbf
Avoid using a bindable in KeyBindingConflictPopover where data is never mutated 2023-10-13 18:40:21 +09:00
Bartłomiej Dach
d5557bbbfb
Merge pull request from minetoblend/multiplayer-invites
Add ability to invite players to multiplayer rooms
2023-10-13 11:09:28 +02:00
Dean Herbert
37411f923e
Merge branch 'master' into multiple-keys-one-binding 2023-10-13 15:07:12 +09:00
Dean Herbert
549a6581b0
Merge branch 'master' into make-realm-key-binding-action-suck-less 2023-10-13 13:53:24 +09:00
Dean Herbert
aabed8b6e5
Merge pull request from Joehuu/mod-switch-tiny-extended-info
Add extended info support to tiny mod switches
2023-10-13 13:40:24 +09:00
Bartłomiej Dach
f083309e64
Move type back next to exposing class 2023-10-12 20:26:01 +02:00
Bartłomiej Dach
5d637520e7
Add test coverage for key binding conflict resolution 2023-10-12 16:04:46 +02:00
Bartłomiej Dach
f5a6781e5a
Integrate key binding conflict popover into keybindings panel 2023-10-12 16:04:46 +02:00
Bartłomiej Dach
7b6563116a
Implement visual appearance of key binding conflict popover 2023-10-12 16:01:51 +02:00
Bartłomiej Dach
5f0b1d69a5
Prepare KeyBindingRow for accepting external changes 2023-10-12 16:00:20 +02:00
Bartłomiej Dach
2a0e4c364d
Add method to unmap RealmKeyBinding.Action to actual enum-typed value 2023-10-12 14:17:26 +02:00
Dean Herbert
fa47309eef
Fix exit key during storyboard outro not progressing to results 2023-10-12 19:31:54 +09:00
Bartłomiej Dach
34bab38e80
Fix judgement counter test failure due to exploiting mania ruleset
Large ticks are not a thing in mania anymore, so the judgement counter
tests began to fail as `LargeTickHit` is no longer a valid hit result
in that ruleset.
2023-10-12 11:34:59 +02:00
Dean Herbert
56e27f1c27
Merge branch 'master' into multiplayer-invites 2023-10-12 18:17:15 +09:00
Dean Herbert
e6103fea95
Fix async usage in TestSceneNotificationOverlay 2023-10-12 16:00:36 +09:00
Dean Herbert
3023e44196
Remove unused using statements 2023-10-12 15:52:48 +09:00
Dean Herbert
73b8146729
Update tests in line with new behaviour 2023-10-12 15:42:54 +09:00
Dean Herbert
256c95f045
Add (failing) test coverage of exit/retry during progress to results 2023-10-12 15:42:20 +09:00
Dean Herbert
f26e3afd29
Merge pull request from smoogipoo/remove-hold-note-ticks
Remove osu!mania hold note ticks
2023-10-12 13:55:50 +09:00
Joseph Madamba
418549b48d Modify some half time mods on test
For use after support of extended info on `ModSwitchTiny`.
2023-10-11 13:00:39 -07:00
Joseph Madamba
764f641bc9 Add extended info support to tiny mod switches 2023-10-11 12:47:12 -07:00
Bartłomiej Dach
712564ea4f
Enable NRT in KeyBindingsSubsection 2023-10-11 20:03:31 +02:00
Bartłomiej Dach
063623b4e6
Merge branch 'master' into remove-hold-note-ticks 2023-10-11 19:47:51 +02:00
Joseph Madamba
6a9f17d97c Merge remote-tracking branch 'upstream/master' into pr/22237 2023-10-11 09:53:26 -07:00
Joseph Madamba
e32be36d92 Move invalidation issue todo to tests 2023-10-10 22:29:43 -07:00
Joseph Madamba
ba62498478 Add set up steps to reinit drawables with a different relative width 2023-10-10 20:47:15 -07:00
Joseph Madamba
e049a072f8 Update right content to latest design
- Add more scenarios to test
- Future-proof mods display to not overflow
2023-10-10 20:24:25 -07:00
Joseph Madamba
bb3f426b93 Truncate name label and clean up positioning code
Also adds a test score with a long username.
2023-10-10 18:26:00 -07:00
Joseph Madamba
43c8d51d02 Add draw width statistic to test 2023-10-10 16:47:33 -07:00
Joseph Madamba
39b008b070 Move test scores to a method and add TestResources.CreateTestScoreInfo() 2023-10-10 16:47:33 -07:00
Joseph Madamba
dad03778b7 Fix leaderboard score caching colour provider 2023-10-10 16:47:33 -07:00
Joseph Madamba
c0b8b3509f Populate dates and add show animation on test 2023-10-10 16:47:33 -07:00
Bartłomiej Dach
66c12e5269
Merge pull request from peppy/fix-preview-point-incorrect
Fix default preview point being incorrect on old beatmaps
2023-10-10 19:54:14 +02:00
Dean Herbert
7220ca34f7
Add failing test coverage of incorrect default preview time 2023-10-10 19:13:16 +09:00
Dean Herbert
4319b22db8
Add failing test coverage of player not pausing track correctly 2023-10-10 17:55:35 +09:00
Dan Balasescu
94192644be
Fix tests 2023-10-10 16:54:24 +09:00
Bartłomiej Dach
ea400a9db7
Fix cross-test interference
`TestLastPlayedUpdated` was implicitly relying on running first.
`TestGuestScoreIsStoredAsGuest` showing up changed test ordering,
causing the former test to fail if it didn't get to run first.
2023-10-10 09:30:51 +02:00
Bartłomiej Dach
08b1a3cbe2
Add failing test case for guest user being looked up in API 2023-10-10 09:18:57 +02:00
Dan Balasescu
89a3be11cb
Add validation test 2023-10-10 09:56:35 +09:00
Bartłomiej Dach
71c4b138fb
Merge branch 'master' into fix-legacy-score-multipliers-2 2023-10-09 10:53:14 +02:00
Dan Balasescu
b65c70018f
Add test for the result 2023-10-09 12:11:29 +09:00
Dean Herbert
7c7771afca
Merge pull request from peppy/health-animates-in-intro
Add initial animation for health bars
2023-10-07 10:31:34 +09:00
Bartłomiej Dach
cfcdbe1c30
Merge pull request from peppy/bindable-fixes
Fix some incorrect bindable-related code
2023-10-06 22:31:30 +02:00
Bartłomiej Dach
a099cc0f36
Merge pull request from peppy/adjustable-health-bar
Adjust argon health bar to fit with existing layout
2023-10-06 21:51:18 +02:00
Bartłomiej Dach
5ea45e3e96
Rename local variable 2023-10-06 19:43:00 +02:00
Dean Herbert
1a60e6d76e
Merge branch 'master' into health-animates-in-intro 2023-10-07 00:32:19 +09:00
Dean Herbert
71be3c8f8b
Add ability to adjust health bar settings in test scene 2023-10-06 19:34:27 +09:00
Dean Herbert
db5178e453
Change ArgonHealthDisplay to be relative sized for now 2023-10-06 18:56:39 +09:00
Dean Herbert
7227f5c881
Fix a couple of compilation errors 2023-10-06 18:13:02 +09:00
Dean Herbert
f2e56bbb65
Fix publicly-settable bindables 2023-10-06 16:51:24 +09:00
Dean Herbert
f9021bf551
Remove pointless test class in TestSceneStoryboardSamples 2023-10-06 16:43:28 +09:00
Dean Herbert
1005b7ac85
Fix incorrect test assumption in TestSceneEditorClock
I don't know what this test was trying to do, but it was wrong. Any
offset which is applied should be invisible to the clock's final
`CurrentTime` (and to the user).
2023-10-06 16:43:28 +09:00
Dean Herbert
354193c53a
Merge branch 'master' into clock-fix-attempt-2 2023-10-06 16:43:27 +09:00
Bartłomiej Dach
c195fbe76f
Merge branch 'master' into crop-gameplay-textures 2023-10-05 09:35:58 +02:00
Dean Herbert
5a0faaa0b1
Fix TestReplayExport intermittent failure
The previous fix was not working as it was checking the path for the
prefix `_`, not the filename.

See https://github.com/ppy/osu/runs/17415814653#r0s2 which clearly shows
this.
2023-10-05 14:30:06 +09:00
Bartłomiej Dach
bd71403309
Merge branch 'master' into health-animates-in-intro 2023-10-04 13:53:42 +02:00
Dean Herbert
5a17a86d1d Merge branch 'master' into clock-fix-attempt-2 2023-10-04 16:57:49 +09:00
Dan Balasescu
854b797ab5
Merge branch 'master' into legacy-tick-not-so-legacy-after-all 2023-10-04 10:52:13 +09:00
Marvin Schürz
5678d90461 Reduce silliness of notification test case 2023-10-04 00:20:38 +02:00
Dan Balasescu
a120ea8464
Merge branch 'master' into fix-legacy-score-multipliers-2 2023-10-04 01:19:33 +09:00
Dean Herbert
69ae370e82 Merge branch 'master' into legacy-tick-test-coverage 2023-10-03 19:37:32 +09:00
Bartłomiej Dach
844a3b6c1b
Merge pull request from frenzibyte/gameplay-hud-redesign/health-display
Implement redesigned health bar display for "Argon" skin
2023-10-03 11:26:21 +02:00
Dean Herbert
e1445fcc65 Adjust health display test scene's background colour to better visualise background fill 2023-10-03 17:17:42 +09:00
Dean Herbert
b234a453da Fix legacy beatmap importer not always handling nested paths correctly
Addresses https://github.com/ppy/osu/discussions/24989.
2023-10-03 16:01:17 +09:00
Marvin Schürz
e81695bcac Display avatar in invitation notification 2023-10-02 23:10:51 +02:00
Dan Balasescu
b9ab4a2b7c Update score conversion to consider legacy multiplier 2023-10-02 16:56:15 +09:00
Dean Herbert
622cbc3af7 Adjust test scene to actually make HP bars fit 2023-10-02 16:07:45 +09:00
Salman Ahmed
8d389accf8 Cover "Argon" helath display in skin deserialisation tests 2023-10-01 15:12:24 +03:00
Salman Ahmed
9e2b8254d9 Add argon-specific health display test scene 2023-10-01 13:26:47 +03:00
Salman Ahmed
776536e816 Add "Argon" health display implementation 2023-10-01 00:56:16 +03:00
Salman Ahmed
869f8e5e1b Adjust test scene to apply miss judgements as well 2023-10-01 00:21:24 +03:00
Salman Ahmed
314ecec65b Refactor player max dimensions test scene to actually upscale textures 2023-09-30 01:34:49 +03:00
Pasi4K5
c927f90a48 Replace regex with a custom algorithm and update test scene. 2023-09-29 13:46:33 +02:00
Dean Herbert
62bcb62842 Document remaining pieces of LastTick and add back legacy prefix for generation flow 2023-09-29 16:58:17 +09:00
Dean Herbert
81485c548c Move LegacyLastTickOffset specification to generation code and stop passing everywhere 2023-09-29 14:32:29 +09:00
Bartłomiej Dach
7638ea36a0
Merge branch 'master' into mod-icon-extended 2023-09-28 16:57:17 +02:00
Dan Balasescu
db9113b38e
Merge pull request from bdach/update-classic-scoring
Update classic scoring formula to closer match stable score V1
2023-09-28 20:19:23 +09:00
Dean Herbert
b8953e8ce1 Code quality pass 2023-09-28 19:03:34 +09:00
Bartłomiej Dach
afa1815d13
Merge pull request from peppy/reduce-song-select-debounce
Reduce delay before loading beatmap after selection change at song select
2023-09-28 10:45:43 +02:00
Dean Herbert
4d5b2477dc Fix failing song select tack transfer test by using a real track 2023-09-28 15:59:06 +09:00
Bartłomiej Dach
0b9d01075a
Merge branch 'master' into fix-missing-skin-ini-version 2023-09-27 19:33:43 +02:00
Dean Herbert
16e752e07d Add basic structure and test coverage for extended info on mod icon 2023-09-27 19:29:03 +09:00
Dean Herbert
a7237e48aa Merge branch 'master' into fix-storyboard-skin-textures-lookup 2023-09-27 17:17:51 +09:00
Dean Herbert
84682b4227 Add test coverage of incorrect version on missing skin.ini 2023-09-27 16:50:01 +09:00
Bartłomiej Dach
12585c9f27
Fix flaky editor beatmap creation test
Came up as a failure when locally running tests for
 - but the test is actually a previously-known
flaky that I couldn't reproduce the failure of until the aforementioned
PR.

This appears to be a simple race; the test scene queries the track
length from update thread, but the length is actually set on the audio
thread. So it's not unreasonable that given unlucky timing, the length
will not be set by `TrackBass` before it is queried.

To fix, switch assert to until step. I'm generally not really willing
to give this more time of day until this change is proven insufficient.
2023-09-26 16:42:59 +02:00
Dean Herbert
40a548d372 Adjust new test scene to not be super broken 2023-09-26 17:30:49 +09:00
Dean Herbert
990c54519b
Merge branch 'master' into limit-gameplay-sprite-dimensions 2023-09-26 16:40:32 +09:00
Dean Herbert
b1561b650f Rename test scene, add xmldoc and increase scale factor to something absurdly high 2023-09-26 16:39:36 +09:00
Dean Herbert
2ca1c684bb
Merge branch 'master' into fix-storyboard-skin-textures-lookup 2023-09-26 14:05:27 +09:00
Bartłomiej Dach
72c61c3a6a
Update osu! scoring tests to match updated formulae 2023-09-25 19:16:31 +02:00
Pasi4K5
ab57cbf6f5 Add TestSceneDifficultySearch 2023-09-25 12:53:17 +02:00
Andrei Zavatski
292273edbe Add test scene 2023-09-23 06:31:26 +03:00
Joseph Madamba
f7f390195a Add user covers to centre content 2023-09-22 19:59:40 -07:00
Joseph Madamba
228731493e Add relative width slider to test 2023-09-22 19:59:40 -07:00
Dean Herbert
c40bd74138 Update usages of GameplayClockContainer not using an adjustable source 2023-09-22 16:22:36 +09:00
Dean Herbert
a3e4d19933 Update tests which were not using an IAdjustableClock as GameplayClockContainer source 2023-09-22 16:22:36 +09:00
Dean Herbert
8367bb6bee Don't apply decoupling to SpectatorPlayerClocks
See inline comment for reasoning. It's a bit complicated.
2023-09-22 16:22:35 +09:00
Dean Herbert
3cb928fe6f Add note about test not calling ProcessFrame 2023-09-22 16:22:35 +09:00
Dean Herbert
59d6e67512 Add missing TestManualClock.Reset implementation for safe measure 2023-09-22 16:22:35 +09:00
Joseph Madamba
70b16d7246 Merge remote-tracking branch 'upstream/master' into pr/22237 2023-09-21 22:51:23 -07:00
Dean Herbert
3f27be1f33 Replace most usages of DecoupleableInterpolatingFramedClock
Except `FramedBeatmapClock`, which is the high-effort one.
2023-09-22 12:49:25 +09:00
Bartłomiej Dach
e45d456324
Fix TestFriendScore intermittently failing due to randomness
If `createRandomScore()` happened to randomly pick the highest total
score when called with `friend` as the sole argument, that particular
score would not be pink.

`GetScoreByUsername()` would arbitrarily pick the first score for the
user, so in this particular case where a friend had the number 1 score,
the test would wrongly fail.

Fix by checking whether any of the 3 added friend scores have received
the pink colour. Because there is more than 1 friend score in the test,
doing so ensures that at least one of those should eventually become
pink (because, obviously, you can't have two scores at number 1).
2023-09-21 21:12:44 +02:00
Bartłomiej Dach
9301a1907a
Rewrite TestFriendScore assertions to constraint model
Allows to clearly see what the failure is:

	TearDown : System.TimeoutException : "friend score is pink" timed out: Expected: some item equal to "#FF549A"
	  But was:  < "#FFFFFF", "#7FCC33", "" >

The #7FCC33 colour is used for the first score on the leaderboard.
2023-09-21 21:05:41 +02:00
Bartłomiej Dach
d73f06fc89
Add test coverage for delete hotkey 2023-09-21 20:01:59 +02:00
Bartłomiej Dach
69ed99dfd5
Merge branch 'master' into mania-edit-disable-sv 2023-09-21 09:13:27 +02:00