Make CreateJudgement public again and add remarks

Templates/Rulesets/ruleset-empty/osu.Game.Rulesets.EmptyFreeform/Objects/EmptyFreeformHitObject.cs

@@ -10,7 +10,7 @@ namespace osu.Game.Rulesets.EmptyFreeform.Objects
 {
     public class EmptyFreeformHitObject : HitObject, IHasPosition
     {
-        protected override Judgement CreateJudgement() => new Judgement();
+        public override Judgement CreateJudgement() => new Judgement();
 
         public Vector2 Position { get; set; }
 

Templates/Rulesets/ruleset-example/osu.Game.Rulesets.Pippidon/Objects/PippidonHitObject.cs

@@ -10,7 +10,7 @@ namespace osu.Game.Rulesets.Pippidon.Objects
 {
     public class PippidonHitObject : HitObject, IHasPosition
     {
-        protected override Judgement CreateJudgement() => new Judgement();
+        public override Judgement CreateJudgement() => new Judgement();
 
         public Vector2 Position { get; set; }
 

Templates/Rulesets/ruleset-scrolling-empty/osu.Game.Rulesets.EmptyScrolling/Objects/EmptyScrollingHitObject.cs

@@ -8,6 +8,6 @@ namespace osu.Game.Rulesets.EmptyScrolling.Objects
 {
     public class EmptyScrollingHitObject : HitObject
     {
-        protected override Judgement CreateJudgement() => new Judgement();
+        public override Judgement CreateJudgement() => new Judgement();
     }
 }

Templates/Rulesets/ruleset-scrolling-example/osu.Game.Rulesets.Pippidon/Objects/PippidonHitObject.cs

@@ -13,6 +13,6 @@ namespace osu.Game.Rulesets.Pippidon.Objects
         /// </summary>
         public int Lane;
 
-        protected override Judgement CreateJudgement() => new Judgement();
+        public override Judgement CreateJudgement() => new Judgement();
     }
 }

osu.Game.Rulesets.Catch/Objects/Banana.cs

@@ -20,7 +20,7 @@ namespace osu.Game.Rulesets.Catch.Objects
         /// </summary>
         public int BananaIndex;
 
-        protected override Judgement CreateJudgement() => new CatchBananaJudgement();
+        public override Judgement CreateJudgement() => new CatchBananaJudgement();
 
         private static readonly IList<HitSampleInfo> default_banana_samples = new List<HitSampleInfo> { new BananaHitSampleInfo() }.AsReadOnly();
 

osu.Game.Rulesets.Catch/Objects/BananaShower.cs

@@ -13,7 +13,7 @@ namespace osu.Game.Rulesets.Catch.Objects
     {
         public override bool LastInCombo => true;
 
-        protected override Judgement CreateJudgement() => new IgnoreJudgement();
+        public override Judgement CreateJudgement() => new IgnoreJudgement();
 
         protected override void CreateNestedHitObjects(CancellationToken cancellationToken)
         {

osu.Game.Rulesets.Catch/Objects/Droplet.cs

@@ -8,6 +8,6 @@ namespace osu.Game.Rulesets.Catch.Objects
 {
     public class Droplet : PalpableCatchHitObject
     {
-        protected override Judgement CreateJudgement() => new CatchDropletJudgement();
+        public override Judgement CreateJudgement() => new CatchDropletJudgement();
     }
 }

osu.Game.Rulesets.Catch/Objects/Fruit.cs

@@ -8,7 +8,7 @@ namespace osu.Game.Rulesets.Catch.Objects
 {
     public class Fruit : PalpableCatchHitObject
     {
-        protected override Judgement CreateJudgement() => new CatchJudgement();
+        public override Judgement CreateJudgement() => new CatchJudgement();
 
         public static FruitVisualRepresentation GetVisualRepresentation(int indexInBeatmap) => (FruitVisualRepresentation)(indexInBeatmap % 4);
     }

osu.Game.Rulesets.Catch/Objects/JuiceStream.cs

@@ -23,7 +23,7 @@ namespace osu.Game.Rulesets.Catch.Objects
         /// </summary>
         private const float base_scoring_distance = 100;
 
-        protected override Judgement CreateJudgement() => new IgnoreJudgement();
+        public override Judgement CreateJudgement() => new IgnoreJudgement();
 
         public int RepeatCount { get; set; }
 

osu.Game.Rulesets.Catch/Objects/TinyDroplet.cs

@@ -8,6 +8,6 @@ namespace osu.Game.Rulesets.Catch.Objects
 {
     public class TinyDroplet : Droplet
     {
-        protected override Judgement CreateJudgement() => new CatchTinyDropletJudgement();
+        public override Judgement CreateJudgement() => new CatchTinyDropletJudgement();
     }
 }

osu.Game.Rulesets.Mania/Objects/BarLine.cs

@@ -19,6 +19,6 @@ namespace osu.Game.Rulesets.Mania.Objects
             set => major.Value = value;
         }
 
-        protected override Judgement CreateJudgement() => new IgnoreJudgement();
+        public override Judgement CreateJudgement() => new IgnoreJudgement();
     }
 }

osu.Game.Rulesets.Mania/Objects/HoldNote.cs

@@ -112,7 +112,7 @@ namespace osu.Game.Rulesets.Mania.Objects
             });
         }
 
-        protected override Judgement CreateJudgement() => new IgnoreJudgement();
+        public override Judgement CreateJudgement() => new IgnoreJudgement();
 
         protected override HitWindows CreateHitWindows() => HitWindows.Empty;
 

osu.Game.Rulesets.Mania/Objects/HoldNoteBody.cs

@@ -15,7 +15,7 @@ namespace osu.Game.Rulesets.Mania.Objects
     /// </summary>
     public class HoldNoteBody : ManiaHitObject
     {
-        protected override Judgement CreateJudgement() => new HoldNoteBodyJudgement();
+        public override Judgement CreateJudgement() => new HoldNoteBodyJudgement();
         protected override HitWindows CreateHitWindows() => HitWindows.Empty;
     }
 }

osu.Game.Rulesets.Mania/Objects/Note.cs

@@ -11,6 +11,6 @@ namespace osu.Game.Rulesets.Mania.Objects
     /// </summary>
     public class Note : ManiaHitObject
     {
-        protected override Judgement CreateJudgement() => new ManiaJudgement();
+        public override Judgement CreateJudgement() => new ManiaJudgement();
     }
 }

osu.Game.Rulesets.Mania/Objects/TailNote.cs

@@ -18,7 +18,7 @@ namespace osu.Game.Rulesets.Mania.Objects
         /// </summary>
         public const double RELEASE_WINDOW_LENIENCE = 1.5;
 
-        protected override Judgement CreateJudgement() => new ManiaJudgement();
+        public override Judgement CreateJudgement() => new ManiaJudgement();
 
         public override double MaximumJudgementOffset => base.MaximumJudgementOffset * RELEASE_WINDOW_LENIENCE;
     }

osu.Game.Rulesets.Osu/Mods/OsuModStrictTracking.cs

@@ -79,7 +79,7 @@ namespace osu.Game.Rulesets.Osu.Mods
             {
             }
 
-            protected override Judgement CreateJudgement() => new OsuJudgement();
+            public override Judgement CreateJudgement() => new OsuJudgement();
         }
 
         private partial class StrictTrackingDrawableSliderTail : DrawableSliderTail

osu.Game.Rulesets.Osu/Objects/HitCircle.cs

@@ -8,6 +8,6 @@ namespace osu.Game.Rulesets.Osu.Objects
 {
     public class HitCircle : OsuHitObject
     {
-        protected override Judgement CreateJudgement() => new OsuJudgement();
+        public override Judgement CreateJudgement() => new OsuJudgement();
     }
 }

osu.Game.Rulesets.Osu/Objects/Slider.cs

@@ -275,7 +275,7 @@ namespace osu.Game.Rulesets.Osu.Objects
             TailSamples = this.GetNodeSamples(repeatCount + 1);
         }
 
-        protected override Judgement CreateJudgement() => ClassicSliderBehaviour
+        public override Judgement CreateJudgement() => ClassicSliderBehaviour
             // Final combo is provided by the slider itself - see logic in `DrawableSlider.CheckForResult()`
             ? new OsuJudgement()
             // Final combo is provided by the tail circle - see `SliderTailCircle`

osu.Game.Rulesets.Osu/Objects/SliderEndCircle.cs

@@ -46,7 +46,7 @@ namespace osu.Game.Rulesets.Osu.Objects
 
         protected override HitWindows CreateHitWindows() => HitWindows.Empty;
 
-        protected override Judgement CreateJudgement() => new SliderEndJudgement();
+        public override Judgement CreateJudgement() => new SliderEndJudgement();
 
         public class SliderEndJudgement : OsuJudgement
         {

osu.Game.Rulesets.Osu/Objects/SliderHeadCircle.cs

@@ -14,6 +14,6 @@ namespace osu.Game.Rulesets.Osu.Objects
         /// </summary>
         public bool ClassicSliderBehaviour;
 
-        protected override Judgement CreateJudgement() => ClassicSliderBehaviour ? new SliderTickJudgement() : base.CreateJudgement();
+        public override Judgement CreateJudgement() => ClassicSliderBehaviour ? new SliderTickJudgement() : base.CreateJudgement();
     }
 }

osu.Game.Rulesets.Osu/Objects/SliderTailCircle.cs

@@ -20,7 +20,7 @@ namespace osu.Game.Rulesets.Osu.Objects
         {
         }
 
-        protected override Judgement CreateJudgement() => ClassicSliderBehaviour ? new LegacyTailJudgement() : new TailJudgement();
+        public override Judgement CreateJudgement() => ClassicSliderBehaviour ? new LegacyTailJudgement() : new TailJudgement();
 
         public class LegacyTailJudgement : OsuJudgement
         {

osu.Game.Rulesets.Osu/Objects/SliderTick.cs

@@ -32,6 +32,6 @@ namespace osu.Game.Rulesets.Osu.Objects
 
         protected override HitWindows CreateHitWindows() => HitWindows.Empty;
 
-        protected override Judgement CreateJudgement() => new SliderTickJudgement();
+        public override Judgement CreateJudgement() => new SliderTickJudgement();
     }
 }

osu.Game.Rulesets.Osu/Objects/Spinner.cs

@@ -95,7 +95,7 @@ namespace osu.Game.Rulesets.Osu.Objects
             }
         }
 
-        protected override Judgement CreateJudgement() => new OsuJudgement();
+        public override Judgement CreateJudgement() => new OsuJudgement();
 
         protected override HitWindows CreateHitWindows() => HitWindows.Empty;
 

osu.Game.Rulesets.Osu/Objects/SpinnerBonusTick.cs

@@ -8,7 +8,7 @@ namespace osu.Game.Rulesets.Osu.Objects
 {
     public class SpinnerBonusTick : SpinnerTick
     {
-        protected override Judgement CreateJudgement() => new OsuSpinnerBonusTickJudgement();
+        public override Judgement CreateJudgement() => new OsuSpinnerBonusTickJudgement();
 
         public class OsuSpinnerBonusTickJudgement : OsuSpinnerTickJudgement
         {

osu.Game.Rulesets.Osu/Objects/SpinnerTick.cs

@@ -14,7 +14,7 @@ namespace osu.Game.Rulesets.Osu.Objects
         /// </summary>
         public double SpinnerDuration { get; set; }
 
-        protected override Judgement CreateJudgement() => new OsuSpinnerTickJudgement();
+        public override Judgement CreateJudgement() => new OsuSpinnerTickJudgement();
 
         protected override HitWindows CreateHitWindows() => HitWindows.Empty;
 

osu.Game.Rulesets.Taiko/Objects/BarLine.cs

@@ -19,6 +19,6 @@ namespace osu.Game.Rulesets.Taiko.Objects
             set => major.Value = value;
         }
 
-        protected override Judgement CreateJudgement() => new IgnoreJudgement();
+        public override Judgement CreateJudgement() => new IgnoreJudgement();
     }
 }

osu.Game.Rulesets.Taiko/Objects/DrumRoll.cs

@@ -90,7 +90,7 @@ namespace osu.Game.Rulesets.Taiko.Objects
             }
         }
 
-        protected override Judgement CreateJudgement() => new IgnoreJudgement();
+        public override Judgement CreateJudgement() => new IgnoreJudgement();
 
         protected override HitWindows CreateHitWindows() => HitWindows.Empty;
 
@@ -103,7 +103,7 @@ namespace osu.Game.Rulesets.Taiko.Objects
         public class StrongNestedHit : StrongNestedHitObject
         {
             // The strong hit of the drum roll doesn't actually provide any score.
-            protected override Judgement CreateJudgement() => new IgnoreJudgement();
+            public override Judgement CreateJudgement() => new IgnoreJudgement();
 
             public StrongNestedHit(TaikoHitObject parent)
                 : base(parent)

osu.Game.Rulesets.Taiko/Objects/DrumRollTick.cs

@@ -32,7 +32,7 @@ namespace osu.Game.Rulesets.Taiko.Objects
             Parent = parent;
         }
 
-        protected override Judgement CreateJudgement() => new TaikoDrumRollTickJudgement();
+        public override Judgement CreateJudgement() => new TaikoDrumRollTickJudgement();
 
         protected override HitWindows CreateHitWindows() => HitWindows.Empty;
 

osu.Game.Rulesets.Taiko/Objects/IgnoreHit.cs

@@ -7,6 +7,6 @@ namespace osu.Game.Rulesets.Taiko.Objects
 {
     public class IgnoreHit : Hit
     {
-        protected override Judgement CreateJudgement() => new IgnoreJudgement();
+        public override Judgement CreateJudgement() => new IgnoreJudgement();
     }
 }

osu.Game.Rulesets.Taiko/Objects/StrongNestedHitObject.cs

@@ -20,7 +20,7 @@ namespace osu.Game.Rulesets.Taiko.Objects
             Parent = parent;
         }
 
-        protected override Judgement CreateJudgement() => new TaikoStrongJudgement();
+        public override Judgement CreateJudgement() => new TaikoStrongJudgement();
 
         protected override HitWindows CreateHitWindows() => HitWindows.Empty;
     }

osu.Game.Rulesets.Taiko/Objects/Swell.cs

@@ -38,7 +38,7 @@ namespace osu.Game.Rulesets.Taiko.Objects
             }
         }
 
-        protected override Judgement CreateJudgement() => new TaikoSwellJudgement();
+        public override Judgement CreateJudgement() => new TaikoSwellJudgement();
 
         protected override HitWindows CreateHitWindows() => HitWindows.Empty;
     }

osu.Game.Rulesets.Taiko/Objects/SwellTick.cs

@@ -8,7 +8,7 @@ namespace osu.Game.Rulesets.Taiko.Objects
 {
     public class SwellTick : TaikoHitObject
     {
-        protected override Judgement CreateJudgement() => new IgnoreJudgement();
+        public override Judgement CreateJudgement() => new IgnoreJudgement();
 
         protected override HitWindows CreateHitWindows() => HitWindows.Empty;
     }

osu.Game.Rulesets.Taiko/Objects/TaikoHitObject.cs

@@ -16,7 +16,7 @@ namespace osu.Game.Rulesets.Taiko.Objects
         /// </summary>
         public const float DEFAULT_SIZE = 0.475f;
 
-        protected override Judgement CreateJudgement() => new TaikoJudgement();
+        public override Judgement CreateJudgement() => new TaikoJudgement();
 
         protected override HitWindows CreateHitWindows() => new TaikoHitWindows();
     }

osu.Game.Tests/Gameplay/TestSceneDrainingHealthProcessor.cs

@@ -358,7 +358,7 @@ namespace osu.Game.Tests.Gameplay
                 this.maxResult = maxResult;
             }
 
-            protected override Judgement CreateJudgement() => new TestJudgement(maxResult);
+            public override Judgement CreateJudgement() => new TestJudgement(maxResult);
             protected override HitWindows CreateHitWindows() => new HitWindows();
 
             private class TestJudgement : Judgement

osu.Game.Tests/Gameplay/TestSceneScoreProcessor.cs

@@ -196,7 +196,7 @@ namespace osu.Game.Tests.Gameplay
                 this.maxResult = maxResult;
             }
 
-            protected override Judgement CreateJudgement() => new TestJudgement(maxResult);
+            public override Judgement CreateJudgement() => new TestJudgement(maxResult);
         }
     }
 }

osu.Game.Tests/Rulesets/Scoring/ScoreProcessorTest.cs

@@ -441,7 +441,7 @@ namespace osu.Game.Tests.Rulesets.Scoring
             private readonly HitResult maxResult;
             private readonly HitResult? minResult;
 
-            protected override Judgement CreateJudgement() => new TestJudgement(maxResult, minResult);
+            public override Judgement CreateJudgement() => new TestJudgement(maxResult, minResult);
 
             public TestHitObject(HitResult maxResult, HitResult? minResult = null)
             {

osu.Game/Database/StandardisedScoreMigrationTools.cs

@@ -655,7 +655,7 @@ namespace osu.Game.Database
         {
             private readonly Judgement judgement;
 
-            protected override Judgement CreateJudgement() => judgement;
+            public override Judgement CreateJudgement() => judgement;
 
             public FakeHit(Judgement judgement)
             {

osu.Game/Rulesets/Objects/HitObject.cs

@@ -173,8 +173,12 @@ namespace osu.Game.Rulesets.Objects
         /// <summary>
         /// Creates the <see cref="Judgement"/> that represents the scoring information for this <see cref="HitObject"/>.
         /// </summary>
+        /// <remarks>
+        /// Use <see cref="Judgement"/> to avoid unnecessary allocations.
+        /// This method has been left public for compatibility reasons and eventually will be made protected.
+        /// </remarks>
         [NotNull]
-        protected virtual Judgement CreateJudgement() => new Judgement();
+        public virtual Judgement CreateJudgement() => new Judgement();
 
         /// <summary>
         /// Creates the <see cref="HitWindows"/> for this <see cref="HitObject"/>.

osu.Game/Rulesets/Objects/Legacy/ConvertHitObject.cs

@@ -16,7 +16,7 @@ namespace osu.Game.Rulesets.Objects.Legacy
 
         public int ComboOffset { get; set; }
 
-        protected override Judgement CreateJudgement() => new IgnoreJudgement();
+        public override Judgement CreateJudgement() => new IgnoreJudgement();
 
         protected override HitWindows CreateHitWindows() => HitWindows.Empty;
     }