Andrei Zavatski
de10e50278
Add test scene to test local comment bundles
2020-02-26 18:31:01 +03:00
Andrei Zavatski
56c41a614a
Remove CommentsPage component
2020-02-26 17:38:50 +03:00
Dan Balasescu
37e9c2a683
Merge branch 'master' into user-list-toolbar
2020-02-26 10:11:21 +09:00
Dan Balasescu
ff063b229b
Merge pull request #7973 from peppy/fix-dho-lifetimes-via-judgements
...
Fix hitobjects with unknown lifetimes by enforcing non-null judgement
2020-02-25 20:38:29 +09:00
Dean Herbert
61af80c1af
Merge pull request #7982 from EVAST9919/comments-crash-fix
...
Fix potential crash when clicking on show more button in comments
2020-02-25 20:14:58 +09:00
Dean Herbert
29e2e17144
Merge branch 'master' into fix-dho-lifetimes-via-judgements
2020-02-25 19:07:57 +09:00
Dean Herbert
a047456354
Revert changes to make HitObject abstract
2020-02-25 19:07:15 +09:00
Andrei Zavatski
c1455be855
Add tests
2020-02-25 10:29:03 +03:00
Andrei Zavatski
7bc9a9b3d8
Implement OverlayPanelDisplayStyleControl and UserListToolbar components
2020-02-24 07:28:33 +03:00
Andrei Zavatski
0cfe1ac823
Implement UserSortTabControl component
2020-02-24 05:47:21 +03:00
Dean Herbert
ffc7eaa3f2
Fix hitobjects with unknown lifetimes by enforcing non-null judgement
...
We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.
This fixes BananaShower and JuiceStreams in osu!catch.
This also makes HitObject abstract and cleans up convert HitObject implementations.
2020-02-23 13:49:06 +09:00
Dean Herbert
e8ebb31517
Expire old judgement lines if too many exist
2020-02-23 03:53:51 +09:00
Bartłomiej Dach
a512226036
Use attribute instead of CreateChildDependencies
2020-02-22 13:47:42 +01:00
Bartłomiej Dach
f248c0a98e
Fix regressed direct panel test scene
...
Due to unnoticed past changes TestSceneDirectPanel has regressed in that
clicking the preview track button would crash due to an unregistered
IPreviewTrackOwner dependency.
Make the test scene itself implement that empty interface and cache
itself as IPreviewTrackOwner so that preview tracks lower down can
resolve the dependency.
As the test is purely visual and has no assertions, and the important
logic in that area (preview track playing logic) is already well-covered
enough elsewhere, no further changes were made.
2020-02-22 00:58:33 +01:00
Dean Herbert
db1e5abad7
Merge pull request #7786 from EVAST9919/subcomments-alter-new
...
Add ability to load long comment trees in CommentsContainer
2020-02-21 21:18:33 +09:00
smoogipoo
41c6d2f2e7
Merge remote-tracking branch 'origin/master' into subcomments-alter-new
2020-02-21 17:02:58 +09:00
Dean Herbert
7d145a7470
Add test for loading spinner with box
2020-02-21 16:21:44 +09:00
Dean Herbert
bbac95958c
Fix incorrect test scene name
2020-02-21 16:20:55 +09:00
Dean Herbert
38d9a46ffb
Add test for relative sizing scenarios
2020-02-21 16:20:17 +09:00
Dean Herbert
92f6f0207c
Rename LoadingAnimation to LoadingSpinner
2020-02-21 15:33:31 +09:00
Dean Herbert
623b78d675
Combine all loading animation implementations
2020-02-21 15:32:46 +09:00
smoogipoo
2cb218c9c4
Merge remote-tracking branch 'origin/master' into comment-editor
2020-02-21 12:27:34 +09:00
Dean Herbert
cd666166d5
Merge pull request #7809 from voidedWarranties/proposal-difficulty-icon-select
...
Allow selecting/playing a specific difficulty using the beatmapset difficulty icons
2020-02-21 10:24:12 +09:00
Andrei Zavatski
3c56118f45
Implement BeatmapSearchParameters and refactor all the components
2020-02-21 02:28:33 +03:00
Andrei Zavatski
063a53017e
Implement Language filter
2020-02-20 17:56:49 +03:00
Andrei Zavatski
6b2ae67eaf
Implement Genre filter
2020-02-20 17:40:45 +03:00
Andrei Zavatski
5a0b93bdb2
Add ShowTag method
2020-02-20 17:02:22 +03:00
Dean Herbert
3380dbbd71
Improve visual appearance of ProcessingOverlay
2020-02-20 19:49:22 +09:00
Dean Herbert
927115a085
Merge branch 'master' into room-inspector-redesign
2020-02-20 17:41:16 +09:00
Dean Herbert
e48166858c
Merge branch 'master' into overlined-display-refactor
2020-02-20 17:38:04 +09:00
Dean Herbert
5c16dbbea9
Merge pull request #7919 from smoogipoo/null-leaderboard-position
...
Support null leaderboard position
2020-02-20 16:27:24 +09:00
smoogipoo
d79ca97fe9
Make beatmap scores also support null position
2020-02-20 15:04:12 +09:00
Dan Balasescu
eb8a56055f
Merge pull request #7910 from EVAST9919/rankings-clickable-countries
...
Make country names in RankingsOverlay clickable
2020-02-20 15:00:01 +09:00
smoogipoo
1a689231c2
Support null leaderboard position
2020-02-20 14:51:25 +09:00
smoogipoo
177935d644
Remove unused using
2020-02-20 14:45:35 +09:00
Dean Herbert
0cf0099fd5
Merge pull request #7917 from smoogipoo/fix-drawableroom-async-test
...
Fix possible test failures due to async loads
2020-02-20 14:37:51 +09:00
smoogipoo
c5fd969568
Fix 0 size in test scene
2020-02-20 14:33:13 +09:00
Dan Balasescu
bf5c34a014
Merge branch 'master' into rankings-clickable-countries
2020-02-20 14:21:44 +09:00
smoogipoo
b2d9004212
Fix possible test failures due to async loads
2020-02-20 08:37:23 +09:00
Andrei Zavatski
8fcfb73d72
Implement BeatmapListingOverlay
2020-02-19 17:40:54 +03:00
Andrei Zavatski
1417c90173
Remove redundant blank line
2020-02-19 17:24:44 +03:00
Andrei Zavatski
a79398ddbd
Fix incorrect caching in TestSceneRankingsOverlay
2020-02-19 17:09:22 +03:00
smoogipoo
ac416ae743
Implement new room inspector redesign
2020-02-19 17:47:59 +09:00
smoogipoo
ec73e8f0c7
Allow different sizing modes for OverlinedParticipants
2020-02-19 17:40:38 +09:00
smoogipoo
e3d37b808d
Move overlined displays to a higher namespace
2020-02-19 17:33:09 +09:00
Andrei Zavatski
37003e11b9
Make fields readonly
2020-02-18 18:04:39 +03:00
Andrei Zavatski
bb22243903
TestScene improvements
2020-02-18 17:47:44 +03:00
Andrei Zavatski
7228900361
Implement BeatmapListingSearchSection component
2020-02-18 17:25:12 +03:00
Andrei Zavatski
3bf3becdd6
Merge remote-tracking branch 'refs/remotes/ppy/master' into subcomments-alter-new
2020-02-18 13:27:08 +03:00
Dean Herbert
b18f9e195e
Merge branch 'master' into bindable-list-events
2020-02-18 18:47:06 +09:00
smoogipoo
ee13632375
Fix ogg beatmap/skin samples not loading
2020-02-18 13:21:55 +09:00
Dan Balasescu
75e0668b4e
Merge branch 'master' into new-direct-sort
2020-02-18 10:17:26 +09:00
Andrei Zavatski
410686c8b9
Use dropdown in BeatmapSearchFilterRow
2020-02-18 01:04:25 +03:00
Andrei Zavatski
c69818925b
Merge remote-tracking branch 'refs/remotes/ppy/master' into new-betmap-search-filter
2020-02-17 23:35:12 +03:00
Andrei Zavatski
19872d9e24
Simplify test scene
2020-02-17 22:05:10 +03:00
Andrei Zavatski
20dc1a7dcd
Merge remote-tracking branch 'refs/remotes/ppy/master' into new-direct-sort
2020-02-17 21:57:19 +03:00
smoogipoo
84ea279c94
Add test
2020-02-17 17:04:58 +09:00
smoogipoo
958c891d15
Update with framework-side bindable list changes
2020-02-17 15:06:14 +09:00
Andrei Zavatski
480e5677ed
Use OverlayColourProvider for CounterPill in profile overlay
2020-02-17 04:29:41 +03:00
Andrei Zavatski
d985a22f77
Add missing blank line
2020-02-17 03:52:26 +03:00
Andrei Zavatski
fe7923b7e8
Add SortDirection Bindable and refactor to make everything work
2020-02-17 03:38:14 +03:00
Andrei Zavatski
2ba0bd872b
Implement basic BeatmapListingSortTabControl
2020-02-17 02:35:46 +03:00
Andrei Zavatski
a9f366fda3
Implement OverlaySortTabControl component
2020-02-17 02:20:53 +03:00
Andrei Zavatski
ea285fd005
Refactor with including headers
2020-02-17 00:44:55 +03:00
Andrei Zavatski
e62fec58c1
Add ability to override text size
2020-02-16 16:38:05 +03:00
Andrei Zavatski
a71e410e5d
Make the filter autosized
2020-02-16 15:04:21 +03:00
Andrei Zavatski
3888911eee
Implement BeatmapSearchFilter component
2020-02-16 14:19:49 +03:00
Dean Herbert
80462014d9
Merge pull request #7848 from smoogipoo/fix-match-subscreen-crashes
...
Replace hashcode override with local equality comparer
2020-02-16 17:01:22 +09:00
Bartłomiej Dach
5a5e3b9410
Merge branch 'master' into align-score-right-content
2020-02-16 06:20:41 +01:00
Bartłomiej Dach
e5a66bdef3
Refactor drawable profile score to match web
2020-02-16 06:16:02 +01:00
voidedWarranties
8c81f1e684
Move CarouselBeatmap access to private, test using indices
2020-02-15 17:51:55 -08:00
Dan Balasescu
268f3333bd
Merge pull request #7841 from peppy/update-inspectcode
...
Update inspectcode version and fix new issues
2020-02-16 00:53:04 +09:00
smoogipoo
17e3470441
Replace hashcode override with local equality comparer
2020-02-16 00:23:52 +09:00
Bartłomiej Dach
01f9966933
Cover case of incorrect display in test scene
2020-02-15 16:05:15 +01:00
Dean Herbert
19d61c1255
Merge branch 'master' into match-subscreen-redesign
2020-02-15 15:29:33 +09:00
Dean Herbert
da68ae5461
Merge branch 'master' into match-songselect-playlist-logic
2020-02-15 12:27:51 +09:00
Dean Herbert
bb541f5ae4
Update inspectcode version and fix new issues
2020-02-15 11:54:29 +09:00
Dean Herbert
a4215106ff
Merge branch 'master' into match-detail-area
2020-02-15 11:46:29 +09:00
Dean Herbert
af8eda2d24
Merge pull request #7829 from smoogipoo/match-playlist
...
Implement a rearrangeable beatmap playlist control
2020-02-15 11:42:26 +09:00
Dean Herbert
0b90e732a9
Merge branch 'master' into match-playlist
2020-02-15 11:09:17 +09:00
voidedWarranties
8e1ecddb1d
Add testing
2020-02-14 17:23:24 -08:00
Andrei Zavatski
7cb11be810
Merge remote-tracking branch 'refs/remotes/ppy/master' into subcomments-alter-new
2020-02-14 20:55:51 +03:00
smoogipoo
61d539dc67
Fix first playlist item not getting selected
2020-02-14 23:39:39 +09:00
smoogipoo
b92f1ad68d
Implement match subscreen re-design
2020-02-14 20:48:09 +09:00
smoogipoo
b762e5e8a5
Implement overlined components
2020-02-14 20:42:14 +09:00
smoogipoo
929eb4f035
Add match footer
2020-02-14 20:35:52 +09:00
smoogipoo
d5496321e2
Implement leaderboard chat display
2020-02-14 20:31:55 +09:00
smoogipoo
c75a774297
Extract participants list from the room inspector
2020-02-14 20:27:37 +09:00
smoogipoo
c0dba63278
Remove match info
2020-02-14 20:14:25 +09:00
Dean Herbert
73621e41fd
Forcefully hide mute notification for navigation tests
2020-02-14 20:12:23 +09:00
smoogipoo
b0793b06ed
Re-implement the match header
2020-02-14 20:10:36 +09:00
smoogipoo
1e80facfe8
Add subscreen test scene
2020-02-14 20:03:37 +09:00
smoogipoo
b5f048ce96
Merge branch 'match-songselect-playlist-logic' into match-subscreen-redesign
2020-02-14 19:59:15 +09:00
smoogipoo
0b86825d71
Merge branch 'match-playlist' into match-songselect-playlist-logic
2020-02-14 19:57:35 +09:00
smoogipoo
f31220c1ee
Fix exception when adding duplicate items
2020-02-14 19:56:43 +09:00
Dean Herbert
14f632b532
Merge branch 'master' into match-detail-area
2020-02-14 19:54:17 +09:00
Dean Herbert
e6676ffa51
Merge branch 'match-playlist' into match-detail-area
2020-02-14 19:53:46 +09:00
Dean Herbert
05c48cd929
Fix volume mute tests regressing
2020-02-14 19:27:32 +09:00
Dean Herbert
47325601f4
Add failing test
2020-02-14 19:16:08 +09:00
smoogipoo
fbc5ffbadb
Remove now unused members
2020-02-14 17:59:47 +09:00
smoogipoo
de646649de
Use test beatmap instead of beatmap manager
2020-02-14 17:59:14 +09:00
smoogipoo
32fd713a9d
Use test beatmap instead of beatmap manager
2020-02-14 17:57:25 +09:00
smoogipoo
f0f739707f
Add playlist support to match song select
2020-02-14 17:51:42 +09:00
smoogipoo
5ec9f454d5
Implement the match beatmap detail area
2020-02-14 17:20:38 +09:00
smoogipoo
aceba8791c
Clean up selection handling
2020-02-14 16:56:44 +09:00
smoogipoo
6a466ea2f5
Improve test cases
2020-02-14 16:48:30 +09:00
smoogipoo
d6768bba62
Make test playlist items unique
2020-02-14 16:09:30 +09:00
smoogipoo
5e871f9838
Make room playlist use the common rearrangeable design
2020-02-14 15:36:47 +09:00
Dean Herbert
b86b5e9adb
Move nested class to bottom of file
2020-02-14 15:27:39 +09:00
Dean Herbert
c34f1f40ea
Fix test text not being centered
2020-02-14 15:27:09 +09:00
Dean Herbert
aa7efe6141
Fix tests potentially failing due to timing issues
2020-02-14 15:26:55 +09:00
Dean Herbert
76cfe1f42c
Merge branch 'master' into online-container
2020-02-14 15:18:27 +09:00
smoogipoo
eb14dbcd77
Initial implementation of rearrangeable playlist
2020-02-14 15:01:45 +09:00
Lucas A
049b0d93d1
Add back default content fade transitions
2020-02-13 21:40:25 +01:00
Bartłomiej Dach
0f25864fae
Textbox -> TextBox rename pass
2020-02-13 21:04:53 +01:00
Bartłomiej Dach
5646083ed9
Adjust code style in test
2020-02-13 21:01:25 +01:00
Bartłomiej Dach
09b2e7beed
Encapsulate test editors
2020-02-13 20:56:34 +01:00
Bartłomiej Dach
cc625e3b89
Move initialisation logic to [SetUp]
2020-02-13 20:44:02 +01:00
Lucas A
dac0148c94
Apply review suggestions.
2020-02-13 20:08:14 +01:00
Dean Herbert
4a04b434a9
Merge branch 'master' into remove-current-item
2020-02-13 21:41:23 +09:00
Dean Herbert
b9a296d3f9
Merge branch 'master' into remove-current-item
2020-02-13 19:34:15 +09:00
Dean Herbert
28ca1a5bcc
Merge branch 'master' into participants-bindable
2020-02-13 19:31:50 +09:00
smoogipoo
bce9c8f3f3
Make room participants into a bindable list
2020-02-13 18:59:15 +09:00
Dean Herbert
e022352812
Merge pull request #7784 from smoogipoo/fix-beatmap-disposal
...
Fix disposal-related errors by making WorkingBeatmap non-disposable
2020-02-13 18:52:47 +09:00
Dean Herbert
49a1725749
Merge pull request #7812 from smoogipoo/playlist-bindables
...
Make playlist beatmap and ruleset into bindables
2020-02-13 18:51:42 +09:00
smoogipoo
75bef15583
Remove "current" multiplayer room item
2020-02-13 18:48:28 +09:00
smoogipoo
91edadfe9d
Make playlist beatmap and ruleset into bindables
2020-02-13 18:12:47 +09:00
smoogipoo
d4f14e552a
Improve extensibility of mod display expansion
2020-02-13 18:05:53 +09:00
Dean Herbert
6a2b3c5c02
Merge pull request #7733 from EVAST9919/rankings-overlay-spotlights
...
Add spotlight selector to RankingsOverlay
2020-02-13 13:14:02 +09:00
Andrei Zavatski
c391a464a5
Add tests
2020-02-13 04:06:34 +03:00
Andrei Zavatski
ec9c01a75f
Merge remote-tracking branch 'refs/remotes/ppy/master' into subcomments-alter-new
2020-02-12 23:32:28 +03:00
Andrei Zavatski
760be29015
Merge remote-tracking branch 'refs/remotes/ppy/master' into comment-editor
2020-02-12 13:23:35 +03:00
Dan Balasescu
9a9349a13a
Merge branch 'master' into adjust-beatmap-overlay
2020-02-12 16:52:42 +09:00
Dan Balasescu
866b6bb058
Merge branch 'master' into fix-song-select-weirdness
2020-02-12 15:01:15 +09:00
Andrei Zavatski
9ac6c271ac
Naming adjustments
2020-02-12 02:05:45 +03:00
Tree
b694b0c90c
Merge branch 'master' into adjust-beatmap-overlay
2020-02-11 21:07:26 +01:00
Andrei Zavatski
c022cf72b5
Implement CancellableCommentEditor
2020-02-11 20:47:51 +03:00
Lucas A
b9e10cb498
Privatize ViewTarget
2020-02-11 18:10:46 +01:00
Andrei Zavatski
829152c8e8
Implement EditorTextbox
2020-02-11 20:08:24 +03:00
Andrei Zavatski
482f622c94
CommentEditor basic implementation
2020-02-11 18:46:49 +03:00
Dean Herbert
333f976580
Fix test finding deleted beatmaps under dotnet-test
2020-02-11 17:47:10 +09:00
Andrei Zavatski
0b6558dc40
Add SpotlightsLayout to RankingsOverlay
2020-02-11 02:35:23 +03:00
Andrei Zavatski
b04a4b5c8a
Implement SpotlightsLayout
2020-02-11 01:44:56 +03:00
Andrei Zavatski
ed6a35cb9f
Merge remote-tracking branch 'refs/remotes/ppy/master' into rankings-overlay-spotlights
2020-02-11 00:18:11 +03:00
Andrei Zavatski
26afe0f31e
Add ability to load long comment trees in CommentsContainer
2020-02-10 15:43:11 +03:00
Dean Herbert
926cde9afc
Fix potential test failures
2020-02-10 18:17:59 +09:00
dependabot-preview[bot]
48781e5685
Bump Microsoft.NET.Test.Sdk from 16.4.0 to 16.5.0
...
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest ) from 16.4.0 to 16.5.0.
- [Release notes](https://github.com/microsoft/vstest/releases )
- [Commits](https://github.com/microsoft/vstest/compare/v16.4.0...v16.5.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-10 08:24:12 +00:00
smoogipoo
cef682aa03
Make WorkingBeatmap non-disposable
2020-02-10 17:02:01 +09:00
Dean Herbert
d61516e10c
Add failing tests
2020-02-10 16:59:54 +09:00
Bartłomiej Dach
7e28f2fe6a
Rename test to better reflect its purpose
2020-02-09 14:41:02 +01:00
Bartłomiej Dach
404cb61342
Open mod select in a more reliable way
2020-02-09 14:39:27 +01:00
ProTheory8
590429b43b
Now TestAutoOpenOnModSelect checks if customisation closes after deselecting mod
2020-02-09 14:15:32 +05:00
Lucas A
30e0a34e50
Wrap Content into a container for animating visibility.
2020-02-08 17:11:31 +01:00
Lucas A
7ca9f4dc20
Apply review suggestions
2020-02-08 17:11:31 +01:00
Lucas A
d3dc0b63ff
Remove string concatenation from ctor
2020-02-08 17:07:26 +01:00
Lucas A
6d51b344ab
Display a loading animation when the user is connecting
2020-02-08 17:07:20 +01:00
杜Nate
8d480c794a
Merge branch 'master' into spun-out
2020-02-08 13:54:39 +08:00
mcendu
a4637a24a6
fix test scene crash
2020-02-08 12:08:44 +08:00
mcendu
2d67215931
make target practice subject of unimplemented mod test
2020-02-08 12:07:21 +08:00
Dan Balasescu
7c715937ca
Merge branch 'master' into skin-animation-frame-rate
2020-02-07 23:52:45 +09:00
Andrei Zavatski
dc8dd24405
Merge remote-tracking branch 'refs/remotes/ppy/master' into rankings-overlay-spotlights
2020-02-07 11:49:31 +03:00
Dan Balasescu
5d6e007929
Merge branch 'master' into overlapping-scroll-origin
2020-02-07 16:44:34 +09:00
Dean Herbert
7460018cd3
Move combo colours to GlobalSkinColours
2020-02-07 14:58:07 +09:00
Bartłomiej Dach
5fde4f2c0c
Fix lifetime calculation in overlapping algorithm
...
Changes to lifetime calculation in scrolling rulesets introduced in
#7367 , which aimed to account for the distance between hit objects'
origin and its edge entering the scrolling area, fixed some issues with
hitobjects appearing abruptly, but also regressed some other scenarios.
Upon investigation, the regression was localised to the overlapping
scroll algorithm. The reason for this was two-fold:
* The previous code used TimeAt() to calculate the time of travel from
the hit object's edge to its origin. For other algorithms, that time
can be accurately reconstructed, because they don't have periods of
time where there are multiple hit objects scrolling at different
velocities.
That invariant does not hold for the overlapping algorithm, therefore
it is possible for different values to be technically correct for
TimeAt(). However, the only value that matters for the adjustment
is the one that's indicated by the control point that applies to the
hit object origin, which can be uniquely identified.
* Additionally, the offset returned (even if correct) was applied
externally to the hit object's start time and passed to
GetDisplayStartTime(). In the overlapping algorithm, the choice of
control point used in GetDisplayStartTime() is important, since
the value of the speed multiplier is read within.
Externally rewinding the hit object's start time meant that in some
cases the speed multiplier of the *previous* control point is applied,
which led to hit objects appearing too late if the scrolling rate
decreased.
Because of the above, modify GetDisplayStartTime() to take the offset
into account in all algorithms, and apply the adjustment correctly
inside of them. The constant and sequential algorithms needed no
adjustment from the previous logic, since:
* the constant algorithm disregarded control points, and
* the sequential algorithm would effectively rewind to time = 0,
calculate the absolute distance from time = 0 to the hit object start,
apply the origin offset *to the absolute distance*, and then convert
back to time, applying all control points in sequence. Due to this
it was impossible for control points to get mixed up while
calculating.
As for the overlapping algorithm, the high-level logic is as follows:
* The distance that the origin has to travel is the length of the scroll
plus the distance from the origin to the object edge.
* The above distance divided by the scroll length gives the relative
scroll lengths that the object has to travel.
* As one relative scroll length takes one time range, the relative
travel length multiplied by the time range gives the absolute travel
time of the object origin.
* Finally, the control point multiplier applicable at origin time is
applied to the whole travel time.
Correctness of the above is demonstrated by visual tests added before
and headless unit tests of the algorithms themselves. The sequential
scroll algorithm was not covered by unit tests, and remains uncovered
due to floating-point inaccuracies that should be addressed separately.
2020-02-06 23:13:28 +01:00
Bartłomiej Dach
12469469ad
Add reproduction test steps for lifetime bug
...
Modify TestSceneScrollingHitObjects to contain a test case that serves
as a reproduction for a visual bug in which using the overlapping scroll
algorithm results in an incorrect origin adjustment for lifetime.
2020-02-06 23:12:22 +01:00
Bartłomiej Dach
ecde641729
Randomise colours in scrolling test scene
...
Switch to using randomised colours in TestSceneScrollingHitObjects to
better distinguish individual hit objects.
2020-02-06 22:47:59 +01:00
Andrei Zavatski
5946ad7d80
Fix possible memory leak and better user change test support
2020-02-06 16:54:02 +03:00
Andrei Zavatski
0840033343
Merge remote-tracking branch 'refs/remotes/ppy/master' into logged-out-comments
2020-02-06 16:38:47 +03:00
Dean Herbert
0c30e802c0
Merge remote-tracking branch 'upstream/master' into rearrangeable-playlist
2020-02-06 17:40:28 +09:00
Dan Balasescu
edf20e2c3e
Merge branch 'master' into lounge-ruleset-filtering
2020-02-06 15:35:26 +09:00
Dan Balasescu
108de6ac56
Merge branch 'master' into editor-slider-repeat
2020-02-06 14:48:45 +09:00
Dean Herbert
d00b61de99
Merge branch 'master' into lounge-ruleset-filtering
2020-02-06 13:38:27 +09:00
Dean Herbert
94b6564b98
Merge branch 'master' into editor-slider-repeat
2020-02-06 13:16:39 +09:00
Dean Herbert
75eb9ca040
Merge pull request #7739 from peppy/fix-rooms-test-scene
...
Fix rooms test scene not displaying anything
2020-02-06 13:12:10 +09:00
Dean Herbert
49ec1d4a99
Fix braces style
2020-02-06 13:04:29 +09:00
Dean Herbert
43b22e3b63
Add a ruleset filtering test
2020-02-06 13:03:15 +09:00
Dean Herbert
d32bb79e5a
Add simple filtering test
2020-02-06 13:03:04 +09:00
Dan Balasescu
38bf14a06c
Merge branch 'master' into editor-beatmap-component
2020-02-06 12:25:33 +09:00
Dean Herbert
7f0a134bc8
Bring test scene structure up-to-date
2020-02-06 12:17:05 +09:00
Andrei Zavatski
00e010a061
Add visibility test for SpotlightSelector
2020-02-05 13:11:02 +03:00
Dean Herbert
09273d1da9
Fix test scene not correctly building a playable beatmap
2020-02-05 18:35:31 +09:00
Dean Herbert
dffc58c5fa
Add blueprint type to timeline test
2020-02-05 17:52:51 +09:00
Dean Herbert
96986bf5fc
Remove beat divisor from ctor and use DI instead
2020-02-05 17:48:21 +09:00
Andrei Zavatski
a3fd952f74
Use new SpotlightSelector in RankingsHeader
2020-02-05 11:21:23 +03:00
Andrei Zavatski
9347c3f535
Add trigger user change test
2020-02-05 11:13:32 +03:00
TheWildTree
ae467538d3
Fix tests
2020-02-04 22:39:51 +01:00
Andrei Zavatski
f8ad9476ef
Adjust test step name
2020-02-04 21:03:17 +03:00
Andrei Zavatski
f889f2435b
Add test step to TestSceneRankingsTable
2020-02-04 16:20:15 +03:00
Andrei Zavatski
5f63ef3bc1
Fix crashing test
2020-02-04 14:52:26 +03:00
Andrei Zavatski
524a8ba6c6
Merge remote-tracking branch 'refs/remotes/ppy/master' into rankings-overlay-update
2020-02-04 11:19:13 +03:00
smoogipoo
e4e0a26b62
Merge remote-tracking branch 'origin/master' into rearrangeable-playlist
2020-02-04 16:55:55 +09:00
Dan Balasescu
b4a90dc4ea
Merge branch 'master' into fix-key-counter-visible-on-reshowing-hud
2020-02-04 14:43:33 +09:00
Dan Balasescu
0e3c1ed0f7
Merge branch 'master' into fix-key-counter-visible-on-reshowing-hud
2020-02-04 14:06:23 +09:00
Dan Balasescu
75f5cb4871
Merge branch 'master' into rankings-overlay-update
2020-02-04 13:52:57 +09:00
Dan Balasescu
2b471be340
Merge branch 'master' into spotlights_api
2020-02-04 13:48:02 +09:00
Dan Balasescu
634364863d
Merge branch 'master' into beatmap-overlay-header
2020-02-04 13:13:57 +09:00
Dan Balasescu
3600b0daf0
Merge branch 'master' into fix-mod-select-overflowing
2020-02-04 11:57:54 +09:00
Salman Ahmed
0ccbffde8d
Use ChildrenOfType instead
2020-02-03 23:43:04 +03:00
Salman Ahmed
26a9d60437
Avoid exposing whenever possible
2020-02-03 23:17:10 +03:00
Andrei Zavatski
ad7f7343d7
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-overlay-header
2020-02-03 21:37:18 +03:00
Andrei Zavatski
824ee8a888
Recolour rankings tables
2020-02-03 21:22:37 +03:00
Andrei Zavatski
2a802307e7
Delete unused components
2020-02-03 20:59:08 +03:00
Andrei Zavatski
3b6ed3fb27
Use new header in the RankingsOverlay
2020-02-03 20:53:30 +03:00
Andrei Zavatski
588a77484b
Add ContryFilter to new header
2020-02-03 20:32:20 +03:00
Andrei Zavatski
b284170437
Basic implementation of new RankingsOverlayHeader
2020-02-03 20:20:35 +03:00
Salman Ahmed
4cd4055e7c
Rename to AlwaysVisible and add XMLDoc
2020-02-03 20:00:43 +03:00
Salman Ahmed
51ed289c59
Revert namings and behaviour changes
2020-02-03 19:59:58 +03:00
Andrei Zavatski
12574111e5
Use ColourProvider colours
2020-02-03 19:44:10 +03:00
Andrei Zavatski
e531570352
Merge remote-tracking branch 'refs/remotes/ppy/master' into spotlights_api
2020-02-03 19:34:35 +03:00
Dean Herbert
a365082a98
Fix potential nullref in UserDimBackgrounds tests
2020-02-03 22:18:07 +09:00
Salman Ahmed
351cb8ac1a
Rename Visible to HasReplayLoaded and change default value
...
Doesn't make sense to be true by default
2020-02-03 15:47:52 +03:00
Salman Ahmed
443063263e
Merge remote-tracking branch 'upstream/master' into fix-key-counter-visible-on-reshowing-hud
2020-02-03 15:18:25 +03:00
Andrei Zavatski
032c2c2afe
Refactor BeatmapRulesetSelector
2020-02-03 14:16:26 +03:00
Dan Balasescu
76ba0b833e
Merge pull request #7716 from EVAST9919/overlay-header-ruleset-selector
...
Add ability to create ruleset selector in OverlayHeader
2020-02-03 19:00:12 +09:00
Dan Balasescu
c6e7603e5e
Merge branch 'master' into safe-screen-lease
2020-02-03 18:18:13 +09:00
Andrei Zavatski
81ab6d43b6
Add ability to create ruleset selector in OverlayHeader
2020-02-03 11:09:46 +03:00
Dan Balasescu
1d1a5b26ab
Merge pull request #7678 from peppy/perform-from-screen
...
Refactor performFromMenu to work with multiple screen targets
2020-02-03 16:28:01 +09:00
Dan Balasescu
93952d438f
Merge pull request #7677 from peppy/decouple-mod-select-bindable
...
Decouple ModSelectOverlay from global SelectedMods
2020-02-03 16:27:47 +09:00
Dean Herbert
9183c78319
Fix crash on exiting song select with ctrl-enter autoplay
2020-02-03 16:04:32 +09:00
Dan Balasescu
7676185bb6
Merge branch 'master' into perform-from-screen
2020-02-03 15:55:45 +09:00
Dean Herbert
fae5bf0f18
Merge branch 'master' into overlay-ruleset-selector
2020-02-03 13:48:28 +09:00
Dan Balasescu
c20b14868b
Merge branch 'master' into profile-page-corrections
2020-02-03 13:29:37 +09:00
Dean Herbert
c9143275be
Merge branch 'master' into profile-recent-info
2020-02-03 12:03:00 +09:00
Dean Herbert
98ccfe612b
Merge branch 'master' into no-comments-placeholder
2020-02-03 11:10:06 +09:00
TheWildTree
7e162d9798
Fix failing test
2020-02-02 17:03:41 +01:00
Salman Ahmed
0f449d1b99
Set config value instead
2020-02-02 18:46:59 +03:00
Salman Ahmed
28e340c486
Inherit Container and fade the key flow instead of individual children
2020-02-02 18:46:27 +03:00
Dean Herbert
aa1daa0ad5
Merge pull request #7703 from bdach/beatmap-stats-precision
...
Apply precision when determining bar colour in difficulty statistics
2020-02-02 22:31:52 +09:00
Salman Ahmed
6103674b54
Add tests for changing HUD visibility on hidden key counter configuration
2020-02-02 14:50:05 +03:00
Andrei Zavatski
36116f8c45
Refactor ruleset presentation
2020-02-02 12:03:51 +03:00
Andrei Zavatski
8786d6264f
Merge remote-tracking branch 'refs/remotes/ppy/master' into profile-recent-info
2020-02-02 12:03:33 +03:00
Bartłomiej Dach
434c0d92e4
Use Bindable{Float,Double}s everywhere
...
To avoid further floating-point comparison bugs, remove all usages of
Bindable<{float,double}>, replacing them with their
Bindable<Float,Double> counterparts.
2020-02-01 22:50:29 +01:00
Joehu
583fee074f
Fix mod select not showing up in mod settings test
2020-02-01 11:50:24 -08:00
Joehu
609ee26030
Fix mod select overlay not showing up in test
2020-02-01 11:41:41 -08:00
Bartłomiej Dach
e90ae667b7
Add failing tests
2020-02-01 16:08:24 +01:00
Bartłomiej Dach
a74d22d9e5
Extract beatmap stats test to separate scene
2020-02-01 15:50:33 +01:00
Dean Herbert
ed368e44ea
Merge branch 'master' into safe-screen-lease
2020-02-01 02:11:18 +09:00
Dean Herbert
c5422743e2
Merge branch 'master' into decouple-mod-select-bindable
2020-02-01 02:06:23 +09:00
Dean Herbert
8db1a8ddb9
Merge branch 'master' into perform-from-screen
2020-02-01 02:04:30 +09:00
Dean Herbert
b3e63d8869
Merge branch 'master' into fix-chat-tab-shortcuts
2020-02-01 02:03:43 +09:00
Dean Herbert
19f516e710
Ensure OsuScreen level leases are taken out synchronously
2020-01-31 19:10:44 +09:00
Dean Herbert
ab7bbf38a8
Set default beatmap later in test initialisation
2020-01-31 16:14:55 +09:00
Andrei Zavatski
91f7bc6d45
Merge remote-tracking branch 'refs/remotes/ppy/master' into no-comments-placeholder
2020-01-31 09:43:23 +03:00
Dean Herbert
5f48affcba
Centralise screen exit logic to ScreenTestScene
2020-01-31 14:19:29 +09:00
Bartłomiej Dach
fcd05b5a3c
Add failing test
2020-01-30 21:31:25 +01:00
Dean Herbert
40a4435792
Fix chat test intermittently failing
...
Was throwing exception instead of returning false due to LINQ Single() call.
2020-01-31 00:33:24 +09:00
Dean Herbert
6b24b7687f
Add test coverage
2020-01-30 23:45:15 +09:00
Dean Herbert
8e966624e0
Fix regressing tests
2020-01-30 19:55:25 +09:00
smoogipoo
00a7adcdca
Further refactorings
2020-01-30 19:21:24 +09:00
Andrei Zavatski
9fc886abc3
Merge remote-tracking branch 'refs/remotes/ppy/master' into profile-recent-info
2020-01-30 12:28:39 +03:00
Dean Herbert
8193991445
Merge pull request #7675 from smoogipoo/fix-possible-chat-crash
...
Fix possible crash when searching with no channel topic
2020-01-30 18:22:23 +09:00
Andrei Zavatski
1c4650c02c
Merge master with conflicts resolved
2020-01-30 10:39:23 +03:00
Andrei Zavatski
10e8361e7c
Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-ruleset-selector
2020-01-30 10:08:39 +03:00
Andrei Zavatski
a8578c1526
Merge master with conflicts resolved
2020-01-30 10:08:02 +03:00
Dan Balasescu
09f6c57b0f
Merge branch 'master' into fix-import-different-ruleset
2020-01-30 15:08:25 +09:00
smoogipoo
2fb640f57f
Change to until step + fix CI error
2020-01-30 15:00:39 +09:00
smoogipoo
ce36e5458f
Fix possible crash with no channel topic
2020-01-30 14:35:03 +09:00
Dan Balasescu
3d814e7714
Merge branch 'master' into rename-deleted-count
2020-01-30 13:49:54 +09:00
Dan Balasescu
1239dd93dc
Merge branch 'master' into recolor-profile-sections
2020-01-30 13:30:35 +09:00
smoogipoo
4ca3f216b8
Fix test scene
2020-01-30 13:11:35 +09:00
Dean Herbert
ebdb425c50
Rename and tidy up DeletedCommentsCounter
2020-01-30 11:17:26 +09:00
Dean Herbert
bea20efb64
Merge branch 'master' into mod_content_centering
2020-01-30 10:34:46 +09:00
Andrei Zavatski
d1ead83c6c
Merge remote-tracking branch 'refs/remotes/ppy/master' into no-comments-placeholder
2020-01-30 00:48:43 +03:00
Andrei Zavatski
786ed03868
Update profile recent activities in line with the web design
2020-01-29 21:01:40 +03:00
Andrei Zavatski
3d6e00095e
Remove useless test
2020-01-29 14:08:10 +03:00
Andrei Zavatski
de6a71ffb7
Merge remote-tracking branch 'refs/remotes/ppy/master' into no-comments-placeholder
2020-01-29 14:06:52 +03:00
Dan Balasescu
30da9981d6
Merge branch 'master' into profile-scores-update-new
2020-01-29 19:40:44 +09:00
Dean Herbert
7588c574a2
Fix presenting a beatmap from a different ruleset not working
2020-01-29 19:37:54 +09:00
Dean Herbert
c003ae63d5
Ignore failing test for now
2020-01-29 17:17:10 +09:00
Dean Herbert
1db353558b
Add present beatmap tests
2020-01-29 17:09:12 +09:00
Dean Herbert
6e8bd35373
Move navigation / game test scenes to new namespace
2020-01-29 17:06:05 +09:00
Dan Balasescu
73f94c0be3
Merge pull request #7643 from peppy/distance-snap-grid-correct-colouring
...
Distance snap grid correct colouring
2020-01-29 16:52:34 +09:00
Dan Balasescu
e553a9b9e0
Merge branch 'master' into distance-snap-grid-correct-colouring
2020-01-29 16:09:35 +09:00
Dan Balasescu
9954b67bda
Merge branch 'master' into reset-test-storage
2020-01-29 15:52:52 +09:00
Dean Herbert
849e453c35
Merge remote-tracking branch 'upstream/master' into reset-test-storage
2020-01-29 15:49:05 +09:00
Dan Balasescu
018c005c71
Merge branch 'master' into distance-snap-grid-correct-colouring
2020-01-29 15:33:07 +09:00
Dan Balasescu
65ac412ff8
Merge branch 'master' into fix-beat-snap
2020-01-29 15:32:27 +09:00
Dan Balasescu
ea2ee53ee3
Merge branch 'master' into timline-beat-lines
2020-01-29 14:44:07 +09:00
Dan Balasescu
4d43833db4
Merge branch 'master' into timline-beat-lines
2020-01-29 14:12:00 +09:00
Dan Balasescu
c35c84882f
Merge branch 'master' into fix-navigation-test-crash
2020-01-29 14:11:41 +09:00
smoogipoo
f457ecaf83
Fix random test failures
2020-01-29 13:54:12 +09:00
Andrei Zavatski
5fcda01346
Cleanup pass
2020-01-29 06:58:53 +03:00
Andrei Zavatski
dc10e58b4f
Add tests for CommentsPage
2020-01-29 06:44:39 +03:00
smoogipoo
ebf15c6a1c
General work towards completion + framework updates
2020-01-29 12:17:03 +09:00
Andrei Zavatski
c5e0c77bca
Refactor NoCommentsPlaceholder
2020-01-29 06:08:11 +03:00
Andrei Zavatski
b947e89a6b
Add placeholder for no comments case in CommentsContainer
2020-01-28 16:53:22 +03:00
Dean Herbert
2498709d06
Fix navigation test crashing when raw input is disabled
2020-01-28 19:47:40 +09:00
Dean Herbert
0e0c730095
Add a method to recycle test storage between runs
2020-01-28 19:44:32 +09:00
smoogipoo
2b2cfd91a6
Initial re-implementation using rearrangeable list
2020-01-28 17:59:14 +09:00
Andrei Zavatski
4e884fc6f4
Merge remote-tracking branch 'refs/remotes/ppy/master' into comments-recolour
2020-01-28 10:15:10 +03:00
Dean Herbert
dbb89cfde7
Merge remote-tracking branch 'upstream/master' into timline-beat-lines
2020-01-28 16:03:50 +09:00
Dean Herbert
596a01661c
Remove 1ms offset and update tests
2020-01-28 13:42:22 +09:00
Dean Herbert
29daabb40a
Fix distance snap grid showing incorrect colouring
...
Now matches timeline colours (based on timing point).
2020-01-28 11:59:21 +09:00
Andrei Zavatski
97fb7a5593
Add test scene
2020-01-27 15:42:46 +03:00
Andrei Zavatski
e6fa793d56
Refactor background creation in OverlayHeader
2020-01-27 15:36:19 +03:00
Andrei Zavatski
100532845b
Recolour CommentsContainer
2020-01-27 15:07:24 +03:00
Andrei Zavatski
12ca28ea6d
Recolour CommentsHeader
2020-01-27 14:58:27 +03:00
Andrei Zavatski
ed2737e027
Recolour TotalCommentCounter
2020-01-27 14:47:47 +03:00
Dean Herbert
a5a0eaba0d
Merge branch 'master' into fix-ss-click-crash
2020-01-27 19:35:31 +09:00
Andrei Zavatski
79cdfc6dc2
Use OverlayColourProvider
2020-01-27 12:55:19 +03:00
Andrei Zavatski
20268ba45b
Merge remote-tracking branch 'refs/remotes/ppy/master' into profile-scores-update-new
2020-01-27 12:37:44 +03:00
Dean Herbert
e37ae589ad
Merge branch 'master' into no-control-overlay-headers
2020-01-27 18:35:33 +09:00
Dean Herbert
fd7f07433d
Ensure selection has occurred before storing value
2020-01-27 18:26:44 +09:00
Dean Herbert
9a2867d3d9
Rename test class
2020-01-27 18:10:42 +09:00
Dean Herbert
493390b750
Rename class to TimelineTickDisplay
2020-01-27 18:08:01 +09:00
Dean Herbert
084fa2f04a
Add timeline beat display
2020-01-27 17:38:50 +09:00
Dean Herbert
03b7c6cfa7
Add base test scene for timeline
2020-01-27 17:34:40 +09:00
Dan Balasescu
d7b32940bd
Merge branch 'master' into fix-ss-click-crash
2020-01-27 15:40:45 +09:00
Dean Herbert
834e82d543
Add comprehensive tests for changelog overlay
...
Includes failing case
2020-01-27 14:50:41 +09:00
Dan Balasescu
d0ef5a8a8c
Merge branch 'master' into breadcrumb-fix
2020-01-27 13:18:23 +09:00
smoogipoo
431b1489b9
Add test
2020-01-27 13:16:36 +09:00
Dean Herbert
1f0aaabf7b
Add tests
2020-01-27 12:21:17 +09:00
Andrei Zavatski
7cd60e3193
Make OverlayRulesetSelector use colour provider
2020-01-26 17:07:17 +03:00
Andrei Zavatski
a72250acc6
Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-ruleset-selector
2020-01-26 16:52:56 +03:00
Andrei Zavatski
cd0fcfabd9
Merge master with conflicts resolved
2020-01-26 16:35:07 +03:00
Andrei Zavatski
6c1fa05804
Merge remote-tracking branch 'refs/remotes/ppy/master' into no-control-overlay-headers
2020-01-26 12:48:01 +03:00
Andrei Zavatski
448663ae9a
Merge remote-tracking branch 'refs/remotes/ppy/master' into colour-provider-implementation
2020-01-25 06:41:49 +03:00
Dean Herbert
92a5fbe948
Merge branch 'master' into star-filtering
2020-01-24 23:28:36 +09:00
smoogipoo
bb390b4470
Add test
2020-01-24 19:40:20 +09:00
Andrei Zavatski
619c2d6d9c
Merge remote-tracking branch 'refs/remotes/ppy/master' into colour-provider-implementation
2020-01-24 12:44:13 +03:00
Andrei Zavatski
59ff3aa800
Fix tests
2020-01-24 12:42:48 +03:00
Dan Balasescu
368587fc06
Merge branch 'master' into timeline-maybe
2020-01-24 18:08:29 +09:00
smoogipoo
811ddb02a4
General refactoring
2020-01-24 17:50:36 +09:00
Dean Herbert
7495cfa0a9
Add a test scene
...
You have to have a test scene You have to have a test scene You have to have a test scene You have to have a test scene You have to have a test scene You have to have a test scene You have to have a test scene You have to have a test scene You have to have a test scene You have to have a test scene You have to have a test scene You have to have a test scene You have to have a test scene
2020-01-24 16:32:31 +09:00
Andrei Zavatski
2b941a0d52
Merge remote-tracking branch 'refs/remotes/ppy/master' into no-control-overlay-headers
2020-01-24 10:18:45 +03:00
Dean Herbert
2187dbd0c2
Rename steps in test for clarity
2020-01-24 14:37:37 +09:00
Dean Herbert
997b49f6dc
Change display to always show progress bar, only hiding seeking handle instead
2020-01-24 14:21:22 +09:00
Dean Herbert
da65fff48e
Merge remote-tracking branch 'upstream/master' into collapse-graph-option
2020-01-24 13:55:42 +09:00
Dean Herbert
ea2271c905
Merge branch 'master' into timeline-maybe
2020-01-24 13:39:51 +09:00
Dean Herbert
0e9ab8c76b
Rename test scene to match
2020-01-24 13:39:47 +09:00
Dean Herbert
c390348eab
Merge remote-tracking branch 'upstream/master' into colour-score-meter
2020-01-24 11:45:33 +09:00
Dean Herbert
ca94850ce4
Merge branch 'master' into view-comments-via-propery
2020-01-23 17:47:40 +09:00
Dean Herbert
a6d97f8ee6
Merge pull request #7577 from ProTheory8/mod-autoopen
...
Make Difficulty Adjust mod customisation menu open automatically
2020-01-23 17:03:04 +09:00
Dean Herbert
143d47ec93
Merge pull request #7538 from peppy/decouple-blueprint-container
...
Decouple blueprint container to allow usage in timeline
2020-01-23 16:13:51 +09:00
Dan Balasescu
0df9703c46
Merge branch 'master' into mod-autoopen
2020-01-23 16:04:43 +09:00
Dean Herbert
02ae92418f
Merge remote-tracking branch 'upstream/master' into decouple-blueprint-container
2020-01-23 15:54:46 +09:00
Dean Herbert
d3262a5667
Cache EditorBeatmap in test
2020-01-23 15:51:00 +09:00
Dean Herbert
289be7a17b
Merge branch 'i-beat-snapping' into timeline-maybe
2020-01-23 15:45:33 +09:00
Dan Balasescu
e988976012
Merge branch 'master' into mod-autoopen
2020-01-23 15:34:19 +09:00
Dean Herbert
098d643955
Move beat snapping to its own interface
2020-01-23 14:39:56 +09:00
Dean Herbert
56c044c44a
Move beat snapping to its own interface
2020-01-23 14:30:25 +09:00
Dean Herbert
477e1b7d27
Rename TimelineHitObjectDisplay to TimelineBlueprintContainer
2020-01-23 14:30:25 +09:00
Dean Herbert
cbba708931
Merge branch 'master' into online-mod-settings
2020-01-22 22:15:41 +09:00
ProTheory8
9de4424aec
Removed TestModCustomisable3
2020-01-21 19:32:53 +05:00
ProTheory8
b8d2012fc3
Added test
2020-01-21 15:26:51 +05:00
Dean Herbert
195068ba9a
Cache EditorBeatmap in test
2020-01-21 17:35:36 +09:00
Andrei Zavatski
30edd80c8c
Refactor OverlayHeader hierarchy
2020-01-21 06:00:12 +03:00
Dean Herbert
1becbb072e
Remove broken test
2020-01-20 23:26:21 +09:00
Andrei Zavatski
4a5e855953
Rename test scene
2020-01-20 12:21:21 +03:00
Dean Herbert
25aff5d96e
Merge remote-tracking branch 'upstream/master' into decouple-blueprint-container
2020-01-20 17:08:59 +09:00
Andrei Zavatski
17a7a75707
Merge master with conflicts resolved
2020-01-20 08:52:03 +03:00
Andrei Zavatski
11e7c8be3f
Use colour schemes for OverlayRulesetSelector
2020-01-20 08:34:46 +03:00
Andrei Zavatski
6552097866
Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-ruleset-selector
2020-01-20 08:22:30 +03:00
Andrei Zavatski
8906416294
ProfileItemBackground -> ProfileItemContainer
2020-01-19 22:48:11 +03:00
Andrei Zavatski
22118b7b22
Merge remote-tracking branch 'refs/remotes/ppy/master' into profile-scores-update-new
2020-01-19 22:44:40 +03:00
Dean Herbert
3f2512295c
Merge pull request #7555 from peppy/update-framework
...
Update framework
2020-01-18 15:57:16 +09:00
Dean Herbert
e8e6897603
Remove unnecessary linq count usage
2020-01-18 15:27:21 +09:00
Andrei Zavatski
16cfb9310b
Naming adjustments
2020-01-18 03:40:31 +03:00
Andrei Zavatski
d5a3d8dbaa
Remove no longer used components
2020-01-18 03:35:47 +03:00
Andrei Zavatski
4964505c3e
Implement ProfileWeightedScore component
2020-01-18 03:19:28 +03:00
Andrei Zavatski
4cdaebb42b
Implement ProfileScore component
2020-01-18 02:58:10 +03:00
Lucas A
e1f172e3f8
Fix CI issues
2020-01-17 19:29:42 +01:00
Lucas A
f00938971e
Apply review suggestions
2020-01-17 18:54:00 +01:00
Lucas A
0422b326ad
Add visual tests
2020-01-17 18:54:00 +01:00
smoogipoo
4fa2c5c8c1
Resolve unassigned properties
2020-01-17 18:52:13 +09:00
smoogipoo
2bc7458abf
Add mod setting (de)serialization support
2020-01-17 13:27:47 +09:00
McEndu
6579aa144d
Merge branch 'master' into mod-text
2020-01-16 20:11:51 +08:00
mcendu
e096688ac8
simplify some stuff
2020-01-16 17:58:47 +08:00
smoogipoo
d01cc37968
Fix channel tab control test scene
2020-01-16 18:36:27 +09:00
mcendu
4c18a67268
add test step
2020-01-15 18:24:43 +08:00
mcendu
052772cce7
add test case
2020-01-15 18:15:56 +08:00
Dean Herbert
d57f55f053
Apply remaining changes required to restore previous functionality
2020-01-15 19:09:49 +09:00
mcendu
62615fb8c1
format
2020-01-15 18:00:14 +08:00
mcendu
a0b6cadab5
add test scene
2020-01-15 17:36:27 +08:00
Dean Herbert
990f5b5f78
Implement editor beatmap saving ( #7532 )
...
Implement editor beatmap saving
2020-01-15 15:35:26 +09:00
smoogipoo
363d7d724a
Use old ctor params
2020-01-15 14:02:29 +09:00
smoogipoo
0e844b3039
Cleanup / re-protect file store
2020-01-14 19:24:53 +09:00
smoogipoo
4b8d628000
Remove file addition test
2020-01-14 19:24:53 +09:00
smoogipoo
524ff41931
Add more assertions
2020-01-14 19:24:53 +09:00
smoogipoo
b592b6d80d
Improve robustness by always creating a new file
2020-01-14 19:24:53 +09:00
smoogipoo
000fc836b2
Remove unused class
2020-01-14 19:24:53 +09:00
smoogipoo
dce93dfe7c
Split test
2020-01-14 19:24:53 +09:00
smoogipoo
609102bea3
Initial file updating implementation
2020-01-14 19:24:53 +09:00
smoogipoo
681a43a318
Refactor to support beatmap updates
2020-01-14 19:24:53 +09:00
smoogipoo
1367c18d3f
General refactorings
2020-01-14 15:07:25 +09:00
smoogipoo
45dad5a9c7
Merge remote-tracking branch 'origin/master' into rankings-country-filter
2020-01-14 15:00:48 +09:00
smoogipoo
33993837b7
Remove participant count (not returned by API)
2020-01-14 14:41:38 +09:00
smoogipoo
cb1984a3c3
Improve test scene data
2020-01-14 14:37:14 +09:00
smoogipoo
7349c023d1
Cleanup spotlight selection
2020-01-14 14:01:51 +09:00
Andrei Zavatski
18ebd30978
CI fix
2020-01-14 07:20:03 +03:00
Andrei Zavatski
90e4def4bd
Remove online stuff out of the selector
2020-01-14 07:07:21 +03:00
Andrei Zavatski
d48b161662
Implement basic SpotlightSelector component
2020-01-10 16:33:00 +03:00
Dean Herbert
14829837c4
Update namespace specifications
2020-01-10 01:38:03 +08:00
Dean Herbert
56724d2580
Merge branch 'master' into #7146
2020-01-10 01:08:20 +08:00
Dan Balasescu
03c778df75
Merge branch 'master' into update-framework
2020-01-09 19:02:26 +09:00
Dean Herbert
26c80e35fb
Fix missing namespace
2020-01-09 17:17:08 +08:00
Dean Herbert
ab9603b06a
Merge remote-tracking branch 'upstream/master' into #7146
2020-01-09 17:08:12 +08:00
smoogipoo
91735ff367
Update MathUtils namespace usages
2020-01-09 13:43:44 +09:00
Andrei Zavatski
0d9fb065da
Move CountryPill to it's own class
2020-01-09 00:27:22 +03:00
Andrei Zavatski
29c4ae68d9
Add some content to test scene for better visual representation
2020-01-09 00:14:29 +03:00
Bartłomiej Dach
f0fe3bc804
Pass bindable to BeatmapMetadataDisplay
...
It was reported that mods selected in song select would show up during
loading of replays which were recorded under a different set of mods.
This was caused by BeatmapMetadataDisplay accepting a plain read-only
value of the Mods bindable in PlayerLoader.load(), therefore making the
mod value assignment in ReplayPlayerLoader.OnEntering() have no effect
on that component.
To resolve this issue, make BeatmapMetadataDisplay accept the
higher-level bindable, bind to it locally and pass it down the hierarchy
to ModDisplay.
2020-01-08 20:10:43 +01:00
Bartłomiej Dach
a3f7d3c445
Add failing test
...
Add test case demonstrating the lack of update of the metadata display's
mods upon setting the Mods property in PlayerLoader.
2020-01-08 19:55:35 +01:00
Andrei Zavatski
dc64ba8ed8
Remove unused variable
2020-01-08 19:22:07 +03:00
Andrei Zavatski
1428952377
Implement CountryFilter component for RankingsOverlay
2020-01-08 18:59:13 +03:00
Dean Herbert
d33a507d96
Implement a login placeholder ( #7438 )
...
Implement a login placeholder
2020-01-08 16:55:41 +08:00
smoogipoo
2688a855a0
Downgrade NUnit to fix discovery issues
2020-01-08 14:14:46 +09:00
Andrei Zavatski
351aaf41d9
Fix parameter naming
2020-01-08 00:54:02 +03:00
Andrei Zavatski
eb828154ee
Allow any type to be used to create TabControl
2020-01-08 00:41:52 +03:00
Andrei Zavatski
6d8f457161
Merge remote-tracking branch 'refs/remotes/ppy/master' into no-control-overlay-headers
2020-01-08 00:21:36 +03:00
Bartłomiej Dach
e0cfc2f405
Merge branch 'master' into prev-button-revamp
2020-01-07 21:49:53 +01:00
Andrei Zavatski
fa0d9f8e9d
Merge remote-tracking branch 'refs/remotes/ppy/master' into view-comments-via-propery
2020-01-07 12:20:56 +03:00
smoogipoo
4a68c79137
Make tests safer against async loads / transforms
2020-01-07 13:21:25 +09:00
Dean Herbert
3ca4d1a28c
Split out tests
2020-01-07 11:47:00 +09:00
Dean Herbert
b3a7b02e3b
Merge remote-tracking branch 'upstream/master' into fix-cancelling-request-not-correct
2020-01-07 11:43:01 +09:00
Andrei Zavatski
e0f66928e6
Allow CommentsContainer refetch comments using a method
2020-01-07 01:07:50 +03:00
Dan Balasescu
7fa3b95286
Merge pull request #7454 from ppy/dependabot/nuget/NUnit3TestAdapter-3.16.0
...
Bump NUnit3TestAdapter from 3.15.1 to 3.16.0
2020-01-06 17:27:04 +09:00
smoogipoo
ee15967c4a
Rewrite test scene to be automated
2020-01-06 17:15:59 +09:00
dependabot-preview[bot]
f91637e7b6
Bump NUnit3TestAdapter from 3.15.1 to 3.16.0
...
Bumps [NUnit3TestAdapter](https://github.com/nunit/nunit3-vs-adapter ) from 3.15.1 to 3.16.0.
- [Release notes](https://github.com/nunit/nunit3-vs-adapter/releases )
- [Commits](https://github.com/nunit/nunit3-vs-adapter/compare/V3.15.1...V3.16 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-06 07:41:37 +00:00
Bartłomiej Dach
49c252ec78
Mark storyboard sample retrieval test headless
2020-01-06 07:33:59 +01:00
Lucas A
3bd3ebad49
Move placeholders to a dedicated namespace
2020-01-04 19:56:34 +01:00
Andrei Zavatski
53c8592cb9
Add test scene
2020-01-03 23:54:56 +03:00
Willy Tu
e23c71be80
Update Resolved and Cached attribute issues
2020-01-03 11:34:26 -08:00
Willy Tu
0a4e180ce7
Merge branch 'master' of github.com:ppy/osu into #7146
2020-01-03 11:32:06 -08:00
Andrei Zavatski
55777c24ce
Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-ruleset-selector
2020-01-03 20:25:28 +03:00
Dan Balasescu
77fb632d44
Remove now unnecessary using
2020-01-03 17:57:01 +09:00
Dan Balasescu
c07cfce3b3
Merge branch 'master' into resource-assembly
2020-01-03 17:56:25 +09:00
Dean Herbert
e8567414c6
Refactor into some kind of sanity
2020-01-03 15:01:42 +09:00
Andrei Zavatski
7cab181c12
Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-ruleset-selector
2020-01-02 13:17:22 +03:00
Dean Herbert
ee332e0d42
Split out BlueprintContainer functionality further
2020-01-02 18:21:16 +09:00
Andrei Zavatski
35fad4c262
Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-headers-update-three
2020-01-02 11:09:07 +03:00
Andrei Zavatski
0f331e81f6
Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-headers-update-three
2020-01-02 10:59:31 +03:00
Dean Herbert
467fb0c3be
Add archive resources for testing ( #7421 )
...
Add archive resources for testing
2020-01-02 16:59:25 +09:00
smoogipoo
911816c282
Add archive test resources
2020-01-02 16:43:32 +09:00
smoogipoo
878e9f182e
Add storyboard sample test scene
2020-01-02 15:23:41 +09:00
Dean Herbert
43903b2fea
Make test scene usable
2020-01-02 14:24:58 +09:00
Andrei Zavatski
2d6a07e970
Fix OverlayRulesetSelector don't have default colour
2020-01-01 23:14:26 +03:00
Andrei Zavatski
b016238c16
Make ProfileRulesetSelector inherit from OverlayRulesetSelector
2020-01-01 22:55:28 +03:00
Andrei Zavatski
af248457b0
Implement OverlayRulesetSelector
2020-01-01 22:49:04 +03:00
Dean Herbert
aeb432d7ba
Merge remote-tracking branch 'upstream/master' into decouple-blueprint-container
2020-01-02 02:49:26 +09:00
Dean Herbert
2d6482f586
Fix remaining tests
2020-01-02 01:43:37 +09:00
Dean Herbert
e4bbdb1956
Fix regressing test
2020-01-02 00:41:06 +09:00
Dean Herbert
f09f9eb07d
Merge branch 'master' into general-editor-beatmap
2020-01-01 23:27:08 +09:00
Dean Herbert
ca90f708f1
Merge remote-tracking branch 'upstream/master' into remove-editor-beatmap-generics
2020-01-01 21:03:31 +09:00
Viktor Rosvall
f40ebc83ca
Begun refractorization process of wrapping Button text in a FillFlowContainer
2019-12-30 23:58:49 +01:00
smoogipoo
8c378dc625
Move EditorBeatmap construction/conversion to Editor
2019-12-30 14:51:14 +09:00
Viktor Rosvall
e85910c4e4
removed unnecessary test code
2019-12-29 09:18:27 +01:00
Viktor Rosvall
bf463fe5e0
adjusted the margin values
2019-12-29 08:57:14 +01:00
Huo Yaoyuan
1b33581667
Construct DllResourceStore with assemblies
2019-12-28 21:13:18 +08:00
Bartłomiej Dach
d828b31ae4
Schedule child mutation in test setup
2019-12-27 17:16:43 +01:00
Bartłomiej Dach
3621362a48
Merge branch 'master' into scrolling-container-origin-adjust
2019-12-27 16:52:21 +01:00
Bartłomiej Dach
e2a55b79ca
Refactor scrolling hit object scene
...
To better demonstrate the desired effect of the fix introduced in
193e41f
, refactor TestSceneScrollingHitObjects to contain two tests,
one of which contains the pre-existing controls to test scroll
algorithms, and the other aims to showcase the fix by setting scroll
parameters appropriately.
2019-12-27 16:52:07 +01:00
smoogipoo
6069d98ced
Remove generic editor beatmap
2019-12-27 19:39:30 +09:00
smoogipoo
7507fee9f9
Add test for HP rewind
2019-12-27 16:55:46 +09:00
Dean Herbert
aa97487f8e
Merge branch 'master' into hp-drain
2019-12-27 14:58:22 +09:00
Salman Ahmed
f03f310bde
Match file name
2019-12-27 06:43:43 +03:00
Salman Ahmed
e030266e95
Fix test name
2019-12-27 06:40:01 +03:00
Salman Ahmed
099b044f04
Add headless test ensuring correct cancelling download behaviour
2019-12-27 06:37:36 +03:00
Dean Herbert
acef2b50e6
Merge branch 'master' into scrolling-container-origin-adjust
2019-12-27 09:29:06 +09:00
Bartłomiej Dach
fd8c5d7706
Improve notification overlay test robustness
...
Stress testing one of the notification overlay tests by running it 10000
times on repeat has shown that it is susceptible to intermittent
failures due to races between delays and asserts checking the number of
currently progressing notifications and the actual progress update,
which contains a random generation factor.
Replace step sequences checking for notification completion by waiting
and asserting with explicit until steps that don't terminate unless
there are zero progressing notifications.
2019-12-26 23:01:31 +01:00
Bartłomiej Dach
005ec4b373
Demonstrate bug in scrolling container scene
...
Modify TestSceneScrollingHitObjects to showcase the effect of origin
choice on object lifetime for all four scrolling directions.
2019-12-26 20:37:06 +01:00
Dean Herbert
cac011edc1
Merge branch 'master' into hp-drain
2019-12-26 23:51:12 +09:00
Dean Herbert
2c1a65d90a
Add simple test
2019-12-26 19:37:55 +09:00
smoogipoo
00a36c388c
Fix tests
2019-12-26 19:18:39 +09:00
smoogipoo
7ee0370d23
Add some tests
2019-12-26 17:48:46 +09:00
smoogipoo
7414a6aadd
Merge remote-tracking branch 'huoyaoyuan/master' into health-processor
...
# Conflicts:
# osu.Game.Rulesets.Catch/CatchRuleset.cs
# osu.Game.Rulesets.Mania/ManiaRuleset.cs
# osu.Game.Rulesets.Taiko/TaikoRuleset.cs
2019-12-26 14:56:54 +09:00
Dan Balasescu
9702cc9809
Merge branch 'master' into remove-legacy-id
2019-12-25 21:01:12 +09:00
Dean Herbert
504a55e803
Merge branch 'master' into better-beatmap-conversion
2019-12-25 19:52:06 +09:00
Dan Balasescu
a265a0c7c5
Merge branch 'master' into settings-source-value-changed
2019-12-25 17:23:08 +09:00
Dean Herbert
0677f746aa
Provide the ruleset to converter classes
2019-12-24 16:02:16 +09:00
smoogipoo
6e7426a098
Simplify/improve beatmap conversion precheck
2019-12-23 17:44:18 +09:00
Dean Herbert
69227d6179
Add asserts
2019-12-22 06:37:18 +09:00
Dean Herbert
725008286f
Move test and remove pointless duplicate tests
2019-12-22 06:09:16 +09:00
Andrei Zavatski
5af1260094
Improve testing
2019-12-21 14:30:49 +03:00
Dean Herbert
02d3f0f241
Merge branch 'master' into settings-source-value-changed
2019-12-21 19:40:07 +09:00
Salman Ahmed
55be4478aa
Merge remote-tracking branch 'upstream/master' into fallback-to-skin-combo-colours
2019-12-21 12:36:09 +03:00
Willy Tu
8353c893c0
Update BodyText of LocalScoreDeleteDialog
2019-12-20 12:00:10 -08:00
Willy Tu
a55e5c5c43
Removed unnecessary code
2019-12-20 11:16:54 -08:00
Dean Herbert
df14f473c2
Split tests out
2019-12-20 19:52:54 +09:00
Willy Tu
ad41a5cc57
Merge branch 'master' of github.com:ppy/osu into #7146
2019-12-20 02:14:01 -08:00
Willy Tu
ba2cff60ca
Removed Automation Testing steps for delete local scores. Only manual testing now.
2019-12-20 02:13:49 -08:00
Dan Balasescu
e2c7f15ed8
Merge branch 'master' into netcoreapp3.1
2019-12-20 18:41:29 +09:00
Dan Balasescu
f386f88bed
Merge branch 'master' into fix-waveform-cross-thread-access
2019-12-20 18:07:51 +09:00
smoogipoo
0ebdf90dfa
Move methods below ctor
2019-12-20 18:07:39 +09:00
Huo Yaoyuan
351e826120
Upgrade project targets to netcoreapp3.1
2019-12-20 17:03:54 +08:00
smoogipoo
705cdde148
Fix incorrect test
2019-12-20 16:42:45 +09:00
Willy Tu
afc11aa547
Fixed issues caused by renaming variables
2019-12-19 22:37:09 -08:00
Willy Tu
6672cf6059
Update variable name
2019-12-19 22:22:46 -08:00
Willy Tu
6abbd33b51
Fixed CI issues
2019-12-19 21:57:14 -08:00
Willy Tu
e42894cfcf
Fixed error for CodeFactor
2019-12-19 21:32:54 -08:00
Willy Tu
8ab26e8889
Update Tests with dependencies on LeaderboardScore. Added its dependency on DialogOverlay for the tests. Added test for deleting individual local score
2019-12-19 21:29:54 -08:00
smoogipoo
76f2fb378f
Separate score and health parts of ScoreProcessor
2019-12-19 20:03:14 +09:00
Dean Herbert
81e842f6b4
Fix waveform test beatmap accessing zip archive across multiple threads
2019-12-19 19:48:48 +09:00
smoogipoo
4e11fb0fd7
Merge remote-tracking branch 'refs/remotes/origin/master' into multiplier-text
2019-12-18 19:36:16 +09:00
smoogipoo
39489e2901
Merge remote-tracking branch 'refs/remotes/origin/master' into fix-editor-movement-crash
2019-12-18 18:51:56 +09:00
smoogipoo
5664ce3109
Add hitobject container regression test
2019-12-18 18:51:12 +09:00
Dean Herbert
36172cf2bd
Merge pull request #7175 from LeNitrous/update-beatmap-settings
...
Display current difficulty statistics with mods applied
2019-12-18 18:43:49 +09:00
Dean Herbert
5cdc7d3b18
Merge pull request #7183 from smoogipoo/legacy-beatmap-saving
...
Add initial implementation of a legacy beatmap encoder
2019-12-18 18:43:14 +09:00
Dean Herbert
51a01c7006
Merge pull request #7256 from peppy/remove-ruleset-ctor-param
...
Remove RulesetInfo parameter from Ruleset constructor
2019-12-18 18:42:42 +09:00
Dan Balasescu
6683460240
Merge branch 'master' into update-beatmap-settings
2019-12-18 17:59:27 +09:00
smoogipoo
2a128340d0
Merge remote-tracking branch 'refs/remotes/origin/master' into nightcore-beats
2019-12-18 17:58:37 +09:00
Dean Herbert
fa067b8799
Merge branch 'master' into legacy-beatmap-saving
2019-12-18 17:17:03 +09:00
Dean Herbert
54572b6de9
Update selected mdos references
2019-12-18 16:42:18 +09:00
Dean Herbert
7831e6ed33
Implement NewsArticleCover class ( #7192 )
...
Implement NewsArticleCover class
2019-12-18 16:15:23 +09:00
Dean Herbert
6e0802e50c
Remove RulesetInfo parameter from Ruleset constructor
2019-12-18 14:49:09 +09:00
Lucas A
ad7923f9b9
Fix test methods not being renamed.
2019-12-17 19:25:17 +01:00
Lucas A
0a278ef943
Apply review suggestions
2019-12-17 19:23:30 +01:00
Dean Herbert
036efb9947
Merge branch 'master' into fix-effect-points
2019-12-18 01:43:15 +09:00
Dean Herbert
886db8eb22
Merge branch 'master' into fix-local-score-availability
2019-12-18 01:15:20 +09:00
smoogipoo
69da6ed9a1
Fix test re-using the same storage
2019-12-17 23:53:18 +09:00
Dan Balasescu
3d13fe485d
Merge pull request #7238 from huoyaoyuan/fxcop
...
Apply FxCop at game side
2019-12-17 21:29:52 +09:00
Dan Balasescu
fd2785bab3
Merge branch 'master' into fxcop
2019-12-17 20:14:45 +09:00
Andrei Zavatski
8cd96acffc
CounterPill implementation
2019-12-17 12:05:35 +03:00
Huo Yaoyuan
927ba4c113
Update expected exception in test.
2019-12-17 15:20:05 +08:00
smoogipoo
59c3b39ed8
Add test
2019-12-17 15:47:13 +09:00
Dean Herbert
5079feaad1
Remove unnecessary string interpolation
2019-12-17 14:04:03 +09:00
Huo Yaoyuan
d7b3578cc6
CA2201: throw correct exception type.
2019-12-17 13:00:02 +08:00
Huo Yaoyuan
ecfc6dfa3d
CA1825: use Array.Empty.
2019-12-17 12:59:48 +08:00
Dean Herbert
f8ffa67693
Add test and isolate ignore bindable from EnableUserDim
2019-12-17 13:21:23 +09:00
Dean Herbert
272d7d0ca9
Merge branch 'master' into fallback-to-skin-combo-colours
2019-12-17 12:36:20 +09:00
Dean Herbert
eed2984bef
Update sdk and InspectCode version ( #7208 )
...
Update sdk and InspectCode version
2019-12-16 19:46:12 +09:00
Dean Herbert
7d979e1264
Add finalised test scene
2019-12-16 19:41:04 +09:00
smoogipoo
6cf318c34b
Merge remote-tracking branch 'refs/remotes/origin/master' into improve-hud-hiding
2019-12-16 18:41:21 +09:00
smoogipoo
8beb6b534f
Merge remote-tracking branch 'refs/remotes/origin/master' into legacy-beatmap-saving
2019-12-16 17:09:03 +09:00
Dean Herbert
d7eb4f73f4
Merge branch 'master' into update-beatmap-settings
2019-12-16 14:57:57 +09:00
Ganendra Afrasya
0e658790c1
Add function to assert multiplier value instead of hardcoded string
2019-12-15 22:42:44 +07:00
Huo Yaoyuan
c457571da6
Use index and range expressions
2019-12-15 20:17:35 +08:00
Huo Yaoyuan
cea3a66d4a
Use static local method fixed for roslyn 3.4
2019-12-15 20:07:56 +08:00
Dean Herbert
244eb56455
Fix test ruleset availability
2019-12-15 03:01:37 +09:00
Lucas A
43720fbf45
Fix CI issues
2019-12-13 18:59:40 +01:00
Lucas A
e05c9426ed
Initial implementation of NewsArticleCover class
2019-12-13 18:50:49 +01:00
Dean Herbert
bc31146560
Mods -> SelectedMods
2019-12-13 21:45:38 +09:00
Dean Herbert
76aa4f9fb2
Fix code style issues
2019-12-13 21:36:50 +09:00
Dean Herbert
7fdaf338f3
Fix test logic and add regression test
2019-12-13 21:36:50 +09:00
smoogipoo
0d49bc244e
Fix test beatmap not being retrievable anymore
2019-12-13 21:30:28 +09:00
Dean Herbert
f349e7ff78
Fix non-null ?? usage
2019-12-13 20:35:34 +09:00
Dean Herbert
0bbaf9b7fb
Fix mod select overlay tests not running individually
2019-12-13 20:21:35 +09:00
Dean Herbert
7033974733
Fix test regressions (incorrect from the start)
2019-12-13 20:13:32 +09:00
smoogipoo
abf3f341b7
Merge remote-tracking branch 'refs/remotes/origin/master' into legacy-beatmap-saving
2019-12-13 19:01:25 +09:00
smoogipoo
c976427206
Refactor test to be more complete
2019-12-13 19:00:28 +09:00
smoogipoo
36f541d8e5
Fix incorrect asserts
2019-12-13 18:14:06 +09:00
smoogipoo
87a7f340e3
Fix first sample point being treated as redundant
2019-12-13 18:14:01 +09:00
unknown
3945e7403a
improve tests and refactor AdvancedStats
2019-12-13 09:39:54 +08:00
unknown
ec5b506960
apply mod difficulty settings during song select
2019-12-12 23:41:46 +08:00
Dean Herbert
ecc7fdc561
Ensure a clean run on each test method
2019-12-12 21:04:56 +09:00
Dean Herbert
5e634c1183
Move test values to constants
2019-12-12 20:51:58 +09:00
Salman Ahmed
7e1d21fa16
Simplify combo colours lookup tests
2019-12-12 14:08:35 +03:00
Salman Ahmed
4406172eb4
Add missing test attributes
2019-12-12 14:05:37 +03:00
Dean Herbert
7559012fb7
Merge remote-tracking branch 'upstream/master' into lighten-playfield-during-breaks
2019-12-12 19:55:09 +09:00
Salman Ahmed
ebd778da2d
More test splitting
2019-12-12 12:48:07 +03:00
Salman Ahmed
a9125f6544
Merge remote-tracking branch 'upstream/master' into fallback-to-skin-combo-colours
2019-12-12 12:37:51 +03:00
smoogipoo
be000e13e4
Implement initial legacy beatmap encoding support
2019-12-12 18:34:40 +09:00
Salman Ahmed
81c8493038
Split combo colour decoding to small test cases
2019-12-12 12:16:19 +03:00
smoogipoo
1807fc9b61
Fix testcase not converting beatmap
2019-12-12 16:48:33 +09:00
Dean Herbert
3ccfee64f6
Add HUDOverlay tests
2019-12-12 16:09:42 +09:00
smoogipoo
5861eca80d
Make DrawableRuleset take a converted beatmap
2019-12-12 15:58:11 +09:00
Salman Ahmed
6a539e307a
Split into small tests and add more cases
2019-12-12 09:22:35 +03:00
Dean Herbert
a93d57b77e
Merge branch 'master' into lighten-playfield-during-breaks
2019-12-12 11:57:21 +09:00
Salman Ahmed
035a53cb9e
Schedule SetUp()
2019-12-12 01:10:43 +03:00
Salman Ahmed
61265ed452
Increase the waiting steps
2019-12-12 00:52:33 +03:00
Salman Ahmed
4f6b85e5ea
Add test ensuring correct break lightening behaviour
2019-12-12 00:32:39 +03:00
Salman Ahmed
bc02cfc2e2
TestSceneUserDimContainer -> TestSceneUserDimBackgrounds
2019-12-12 00:30:16 +03:00
Lucas A
e7a06aeadc
Update NewsOverlay visual tests to expose LoadAndShowChild() for testing purposes
2019-12-11 14:32:43 +01:00
Dan Balasescu
e288706802
Merge branch 'master' into rankings-overlay-refactor
2019-12-11 19:09:29 +09:00
Dan Balasescu
166e957104
Merge pull request #6432 from LeNitrous/customized-mods
...
Add per-mod settings
2019-12-11 19:07:29 +09:00
Dean Herbert
a106e2a53f
Refactor distance snap grid to not require hitobjects ( #7138 )
...
Refactor distance snap grid to not require hitobjects
2019-12-11 19:02:29 +09:00
Dean Herbert
274958669c
Add early assert as sanity check
2019-12-11 15:47:41 +09:00
Dean Herbert
6c8f325063
Add failing test
2019-12-11 15:46:07 +09:00
Salman Ahmed
63f66aa5fa
Check by UserDimContainer.DimLevel instead
2019-12-10 15:25:03 +03:00
Dean Herbert
138b83c9ea
Merge branch 'master' into customized-mods
2019-12-10 19:13:32 +09:00
Dean Herbert
f6c0b5c44a
Merge branch 'master' into settings-source
2019-12-10 18:49:41 +09:00
Dan Balasescu
bd6a08a21b
Merge branch 'master' into apply-to-track
2019-12-10 16:15:24 +09:00
smoogipoo
94a298a82d
Refactor distance snap grid to not require hitobjects
2019-12-10 16:00:09 +09:00
Dean Herbert
5f3d163772
Merge branch 'master' into segmented-slider-paths-3
2019-12-10 14:28:20 +09:00
Dean Herbert
cdde5d1d69
Fix song select filters not reapplied if in a child screen
...
Closes https://github.com/ppy/osu/issues/6980 .
2019-12-10 02:30:23 +09:00
smoogipoo
cd61893814
Merge remote-tracking branch 'refs/remotes/origin/master' into segmented-slider-paths-3
2019-12-09 18:25:27 +09:00
Dean Herbert
eb074b7058
Allow mods to apply to track, not clock
2019-12-09 17:44:45 +09:00
smoogipoo
53f7c753fb
General cleanups
2019-12-09 16:44:19 +09:00
smoogipoo
c18f2e6436
Merge remote-tracking branch 'refs/remotes/origin/master' into segmented-slider-paths-3
2019-12-09 15:34:49 +09:00
Dan Balasescu
0c9f7a64f1
Merge branch 'master' into improve-dialog-button-visuals
2019-12-09 15:31:48 +09:00
Dan Balasescu
5738ef5fab
Merge branch 'master' into editor-timeline-hitobject-display
2019-12-09 14:34:55 +09:00
Dean Herbert
58db745121
Merge remote-tracking branch 'upstream/master' into improve-dialog-button-visuals
2019-12-09 14:11:52 +09:00
Dean Herbert
4fbe5b7002
Merge branch 'master' into rankings-overlay-refactor
2019-12-09 11:34:32 +09:00
Dean Herbert
f65866648e
Use Array.Empty
2019-12-06 20:14:56 +09:00
Dean Herbert
347373a3ba
Fix test failures
2019-12-06 19:04:55 +09:00
Dean Herbert
46d055604a
Customize -> Customise
2019-12-06 18:59:45 +09:00
Dean Herbert
680b2653ae
Improve animation of popup dialog buttons
2019-12-06 18:51:30 +09:00
Dean Herbert
cf0413663d
Merge branch 'settings-source' into customized-mods
2019-12-06 18:05:39 +09:00
Dean Herbert
f84705ab96
Add tests
2019-12-06 18:04:46 +09:00
Dean Herbert
a5d5099868
Use SettingsSource for mod cusomisation
2019-12-06 17:09:48 +09:00
Dean Herbert
af35df4077
Add multiple mod testing and update test code style
2019-12-06 15:42:11 +09:00
smoogipoo
2654710d91
Add tests and fix negative expected distances
2019-12-06 15:37:06 +09:00
Dean Herbert
170954bc6e
Merge remote-tracking branch 'upstream/master' into customized-mods
2019-12-06 15:31:20 +09:00
Dean Herbert
12f1c9e088
Fix test failure
2019-12-06 15:29:02 +09:00
Dean Herbert
de23364608
Add failing test
2019-12-06 13:47:34 +09:00
Dean Herbert
28400aa865
Update test scene
2019-12-06 11:27:24 +09:00
Dean Herbert
e76f8bdd64
Fix warnings
2019-12-05 23:31:21 +09:00
Dean Herbert
e225b0032a
Add basic hitobject display to timeline
2019-12-05 19:31:40 +09:00
smoogipoo
2702edfa55
Rename new path, replace existing one
2019-12-05 17:49:32 +09:00
smoogipoo
5e9b739b67
Re-implement slider paths to support multiple segments
2019-12-05 16:45:02 +09:00
Andrei Zavatski
bf7c309d4c
Make field readonly
2019-12-05 10:05:04 +03:00
Andrei Zavatski
33737d3d89
Move tests to TestSceneRankingsOverlay due to refactoring
2019-12-05 09:53:25 +03:00
Andrei Zavatski
22863da360
Merge remote-tracking branch 'refs/remotes/ppy/master' into rankings-overlay-refactor
2019-12-05 09:29:37 +03:00
Dan Balasescu
36c734c4c2
Merge branch 'master' into decouple-api-room-scoreinfo
2019-12-05 12:43:43 +09:00
Andrei Zavatski
0560a6637c
Merge remote-tracking branch 'refs/remotes/ppy/master' into rankings-overlay-refactor
2019-12-05 04:11:45 +03:00
Dean Herbert
36224dca13
Fix multiplayer aggregate score inheriting from ScoreInfo
2019-12-05 01:45:28 +09:00
Dean Herbert
5b8ca8f84a
Remove test ignore rules
2019-12-05 01:17:11 +09:00
Dean Herbert
9ac0ac0944
Merge branch 'master' into fix-pause-testcase
2019-12-05 01:00:27 +09:00
Dean Herbert
ca1f3417a3
Merge pull request #7046 from smoogipoo/fix-replay-button
...
Fix replay download button not working
2019-12-04 23:00:40 +09:00
Dan Balasescu
19c5848e73
Merge branch 'master' into decouple-legacy-score-info
2019-12-04 11:47:27 +09:00
Dan Balasescu
242e1b0b2e
Merge branch 'master' into add-missing-long-running
2019-12-04 11:29:25 +09:00
Dean Herbert
a225a35f91
Fix failing tests
2019-12-03 16:18:36 +09:00
Dean Herbert
f0d49d0cdf
Decouple APILegacyScoreInfo from ScoreInfo
2019-12-03 15:31:11 +09:00
smoogipoo
aadbbb1af3
Fix replay download button not working
2019-12-03 13:33:42 +09:00
Andrei Zavatski
c451542915
Rankings overlay basic implementation
2019-11-30 03:01:07 +03:00
Dean Herbert
3fc2afeb26
Fix UserDimContainer test failing on subsequent runs
2019-11-29 15:51:00 +09:00
Andrei Zavatski
36d694ad2d
Merge remote-tracking branch 'refs/remotes/ppy/master' into rankings-tables
2019-11-28 20:43:17 +03:00
Andrei Zavatski
83e3ad9e69
Make Rankings a ctor variable
2019-11-28 20:09:05 +03:00
Dean Herbert
e7ef919b0b
Ignore another failing test
2019-11-29 01:47:52 +09:00
Dean Herbert
1c4063677d
Ignore test temporarily
2019-11-29 00:45:35 +09:00
Ganendra Afrasya
af5c5a3000
Apply reviews
...
Also rename the class name to match with the others
2019-11-28 20:06:15 +07:00
smoogipoo
f504370867
Make player block exit if pausable
2019-11-28 15:58:26 +09:00
Ganendra Afrasya
6149482b5d
Add test
2019-11-28 12:03:11 +07:00
Andrei Zavatski
44cfe98278
Simplify test scene
2019-11-27 23:40:52 +03:00
Andrei Zavatski
800bda7e81
Refactor tables to avoid code duplication
2019-11-27 23:35:02 +03:00
Dean Herbert
724fcecbc5
Fix test scene not actually covering the class it's testing
2019-11-28 00:32:31 +09:00
Dean Herbert
4221a0126c
Merge branch 'master' into rankings-tables
2019-11-27 23:26:54 +09:00
Dean Herbert
01a37771bc
Merge branch 'master' into customized-mods
2019-11-27 19:44:32 +09:00
Dan Balasescu
c6a85a11bd
Merge branch 'master' into sharpen
2019-11-27 17:09:11 +09:00
Huo Yaoyuan
c0fe91a84c
Merge branch 'master' into sharpen
2019-11-26 18:21:50 +08:00
Dean Herbert
77ce9642ba
Add test coverage and simplify break time updating
2019-11-26 15:32:48 +09:00
Dan Balasescu
51eff3d49c
Merge branch 'master' into add-access-to-skin-legacy-version
2019-11-25 12:40:01 +09:00
Dan Balasescu
9f93727a80
Merge branch 'master' into fix-spritetext-usage
2019-11-25 12:15:05 +09:00
Dean Herbert
45514ff660
Apply fixes
2019-11-25 11:30:55 +09:00
iiSaLMaN
2437cfd28c
Add test ensuring correct version lookup
2019-11-24 04:36:16 +03:00
iiSaLMaN
5bf6e57eb0
Remove unnecessary usage
2019-11-24 02:16:43 +03:00
Andrei Zavatski
d6c9387beb
Implement NotSupporterPlaceholder
2019-11-22 21:55:21 +03:00
Dan Balasescu
5d2a608be0
Merge branch 'master' into lead-in-fixes
2019-11-22 13:48:55 +09:00
Dan Balasescu
7c19f7cd7b
Merge branch 'master' into improve-skip-button-feel
2019-11-22 13:36:27 +09:00
Dan Balasescu
ba0ac93f70
Merge branch 'master' into skip-multiple-times
2019-11-22 13:23:50 +09:00
Dean Herbert
5da5abdb05
Merge branch 'master' into prev-button-revamp
2019-11-22 02:57:22 +09:00
Andrei Zavatski
984ec11a78
Make Ruleset a bindable
2019-11-21 18:56:48 +03:00
Andrei Zavatski
458496206c
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-mod-selector
2019-11-21 18:49:37 +03:00
Huo Yaoyuan
818553027b
Merge branch 'master' into sharpen
2019-11-21 23:42:46 +08:00
Dean Herbert
0d4854ac09
Add News Overlay skeleton and header ( #5726 )
...
Add News Overlay skeleton and header
Co-authored-by: Dean Herbert <pe@ppy.sh>
2019-11-22 00:14:31 +09:00
Dean Herbert
1a6b5e8714
Implement TotalCommentsCounter component for CommentsContainer ( #6867 )
...
Implement TotalCommentsCounter component for CommentsContainer
2019-11-21 23:45:23 +09:00
Dean Herbert
ac2dfffb23
Merge remote-tracking branch 'upstream/master' into sharpraven-deprecation
2019-11-21 22:52:45 +09:00
Dean Herbert
71a64da566
Fix test regressions
2019-11-21 22:07:37 +09:00
Dean Herbert
bd6831624a
Decouple skip button animations from gameplay clock
2019-11-21 19:51:22 +09:00
Dean Herbert
46a94821d4
Add support for consecutive skips
2019-11-21 18:59:55 +09:00
Dean Herbert
8d1b11d4bd
Add storyboard lead-in tests
2019-11-21 18:50:54 +09:00