8636 Commits

Author	SHA1	Message	Date
Dean Herbert	a03abc747b	Tidy up comments and simplify bounding box centre logic	2022-07-02 12:58:34 +09:00
Dean Herbert	4fd47b5fa0	Add more verbose logging to realm blocking process	2022-07-02 12:36:56 +09:00
Jamie Taylor	9d28d5f8ee	Update SFX for mod overlay show/hide	2022-07-01 20:43:12 +09:00
Salman Ahmed	5880b824d0	Simplify description logic for overlay tab items	2022-07-01 11:30:51 +03:00
Salman Ahmed	7f9ef6c23f	Merge branch 'master' into fix-overlay-header-tab-item-localisable-string	2022-07-01 11:27:00 +03:00
Dean Herbert	d54f7fc728	Move slider range control to song select	2022-07-01 14:41:36 +09:00
Salman Ahmed	87e3b44181	Ensure icon is loaded inside try-catch	2022-06-29 13:37:42 +03:00
Dean Herbert	6c64cea057	Catch a second location	2022-06-29 18:56:15 +09:00
Dean Herbert	569fde4b47	Add messages to all InvalidOperationExceptions ... Without this, they can be very non-descript and hard to track down	2022-06-28 01:34:25 +09:00
Dan Balasescu	6c6de9ce53	Fix typo	2022-06-27 20:40:02 +09:00
Dean Herbert	50c1c066de	Add various logging of global WorkingBeatmap state changes	2022-06-27 18:41:31 +09:00
Dean Herbert	31a447fda0	Update parameter discards	2022-06-24 21:26:19 +09:00
Dean Herbert	30eebf3511	Merge branch 'master' into c-sharp-10	2022-06-24 21:22:33 +09:00
Bartłomiej Dach	26c5b59f6d	Replace usages of string.To{Lower,Upper}()	2022-06-24 11:57:45 +02:00
Dean Herbert	f71f6302fd	Remove unnecessary null casts	2022-06-24 14:50:11 +09:00
Dean Herbert	d9c1a9d71f	Use new property to specify no tooltip, rather than passing only ruleset	2022-06-24 14:06:18 +09:00
Dean Herbert	7dec530ca5	Split out simple DifficultyIcon with no calculation overhead and update usages	2022-06-23 19:27:35 +09:00
Dean Herbert	b660119de7	Merge pull request #18796 from bdach/mod-overlay/legacy-key-bindings ... Add setting option to toggle between mod overlay hotkey styles	2022-06-22 20:28:18 +09:00
Dan Balasescu	b81c7c7951	Merge pull request #18804 from Joehuu/online-view-chat-overlay ... Add back online view container to chat overlay	2022-06-22 14:41:06 +09:00
Dan Balasescu	ff440fc1a4	Fix too many buttons inside condition	2022-06-22 13:44:41 +09:00
Dan Balasescu	321920bc85	Remove one more nullable disable	2022-06-22 13:44:41 +09:00
Dan Balasescu	1018c9852d	Cleanup nullability	2022-06-22 13:44:41 +09:00
Dan Balasescu	23254d2ff2	Fix broken files	2022-06-22 13:44:41 +09:00
Joseph Madamba	07e0cd53a4	Add back online view container to chat overlay	2022-06-21 19:23:16 -07:00
Joseph Madamba	50728f3fbc	Fix overlay header tab item not working with localisable string	2022-06-21 18:31:09 -07:00
Supersonicboss1	4aa86b0a80	fixed duplicates and cleaned up code	2022-06-21 23:41:25 +01:00
Supersonicboss1	e4931f977c	improved UI of maintenance section in settings	2022-06-21 23:00:03 +01:00
Bartłomiej Dach	7013909322	Remove unnecessary protected virtual	2022-06-21 16:43:04 +02:00
Bartłomiej Dach	f564ed589f	Alter sequential hotkey style to always use visible index ... Previous behaviour was once mentioned off-hand as unintuitive.	2022-06-21 15:22:18 +02:00
Bartłomiej Dach	9e5cc89edb	Fix classic hotkeys toggling filtered mods	2022-06-21 15:01:33 +02:00
Bartłomiej Dach	da1814e7c3	Restructure everything to fix free mod overlay issue	2022-06-21 14:48:41 +02:00
Bartłomiej Dach	7b7b8c1892	Implement behaviour for classic selection style	2022-06-21 14:24:30 +02:00
Bartłomiej Dach	234120ff43	Forward entire event to IModHotkeyHandler ... Required for shift handling in the classic implementation.	2022-06-21 13:37:17 +02:00
Bartłomiej Dach	658f5341c7	Set up flow for switching between hotkey styles	2022-06-21 13:34:58 +02:00
Bartłomiej Dach	5abd8a07d2	Add setting for changing mod select hotkey style	2022-06-21 13:33:17 +02:00
Bartłomiej Dach	73124d2b1f	Encapsulate mod hotkey selection logic in strategy pattern	2022-06-21 12:49:01 +02:00
Bartłomiej Dach	ee96d84ffa	Merge branch 'master' into input-settings	2022-06-20 22:55:43 +02:00
Dean Herbert	6515b249ec	Change data migration to do an immediate exit, rather than attempted exit	2022-06-19 12:39:58 +09:00
Dean Herbert	50e40756c4	Rename GracefullyExit to AttemptExit	2022-06-19 12:34:44 +09:00
Dan Balasescu	f8830c6850	Automated #nullable processing	2022-06-17 16:37:17 +09:00
Salman Ahmed	e4ddf03ad6	Fix toolbar music button handling keys while not hovered	2022-06-16 20:22:57 +03:00
Bartłomiej Dach	9c4f6d2ce0	Merge branch 'master' into first-run-setup-notification-interruption	2022-06-16 15:14:40 +02:00
Dean Herbert	251923c106	Convert NotificationOverlay to NRT	2022-06-16 17:28:08 +09:00
Dean Herbert	6b30ee0950	Tidy up DI and binding logic	2022-06-16 17:26:43 +09:00
Bartłomiej Dach	f88c568c8d	Update flag sizes after switch to twemoji assets ... The old flags used a size of 150x100, while the new assets based on twemoji use a size of 150x108. Update existing usages to match this new aspect ratio better.	2022-06-15 21:45:47 +02:00
Salman Ahmed	e7dcbddbeb	Fix potential null reference	2022-06-15 18:53:49 +03:00
Salman Ahmed	026bad7fc4	Use notification processing mode logic instead	2022-06-15 18:13:24 +03:00
Dean Herbert	7571ab6c63	Merge branch 'master' into new-dialog-sfx	2022-06-15 19:47:00 +09:00
Dean Herbert	584345a97e	Merge pull request #18693 from frenzibyte/toolbar-volume-control ... Add basic volume control support in toolbar music button	2022-06-15 17:50:10 +09:00
Dean Herbert	b3aa4fcf02	Adjust a channel rather than the overall sample	2022-06-15 17:33:07 +09:00
Dean Herbert	94aa2248ca	Move filter reset to more appropriate location	2022-06-15 17:32:21 +09:00
Dean Herbert	1f1633ddc2	Remove Update method processing of samples in PopupDialogDangerousButton	2022-06-15 16:50:23 +09:00
Salman Ahmed	583619b915	Use GlobalAction.DecreaseVolume instead	2022-06-15 10:21:27 +03:00
Dean Herbert	873806c2ea	Add keyboard adjustment support	2022-06-15 15:58:22 +09:00
Dean Herbert	3df9d7c9e1	Add a bit more animation when adjusting	2022-06-15 15:56:59 +09:00
Dean Herbert	5eb56ab814	Ensure Master volume is updated when scrolling on toolbar button	2022-06-15 15:41:40 +09:00
Jamie Taylor	af87722be8	Add audio feedback for 'Dangerous' dialog buttons	2022-06-15 15:41:27 +09:00
Jamie Taylor	930ec2a197	Add specific samples for dialog 'Ok' and 'Cancel' buttons	2022-06-15 15:41:27 +09:00
Salman Ahmed	ddeee09a51	Fix important notifications interrupting first-run setup	2022-06-15 03:40:05 +03:00
Salman Ahmed	1f31e3fb51	Add volume UI to toolbar music button	2022-06-14 22:15:12 +03:00
Salman Ahmed	7f23677972	Add volume control support via toolbar music button	2022-06-14 22:15:12 +03:00
Dean Herbert	49ec2572b8	Allow scrolling overflow of ruleset buttons in the toolbar	2022-06-15 01:43:10 +09:00
Salman Ahmed	d89c11e49e	Allow Toolbar to block scroll input from passing through	2022-06-14 19:10:13 +03:00
Dean Herbert	77fcf35d1d	Remove unlimited frame limiter warning ... This should not be required now that we have a 1,000 Hz limiter in place.	2022-06-13 15:40:27 +09:00
Dan Balasescu	e5d6dc1ba5	Merge pull request #18606 from peppy/latency-comparer ... Add latency certifier system	2022-06-10 19:41:44 +09:00
Dan Balasescu	c9dfffbc0e	Merge pull request #18619 from peppy/fix-collection-performance ... Fix performance overhead of large collections	2022-06-10 15:01:31 +09:00
Dean Herbert	c625c929e5	Update button text to match new terminology	2022-06-10 14:16:56 +09:00
Dean Herbert	4a5e86e451	Rename Beatmaps to BeatmapHashes for clarity	2022-06-10 14:03:51 +09:00
Dean Herbert	3b229624dd	Simplify contains check to use LINQ the whole way	2022-06-10 14:02:58 +09:00
Dan Balasescu	bc7262a3dd	Merge pull request #18627 from Joehuu/always-show-mod-selector-beatmap-info ... Always show mod selector on beatmap info leaderboards regardless of supporter	2022-06-09 18:18:12 +09:00
Joseph Madamba	f3371e8bc8	Always show mod selector on beatmap info leaderboards regardless of supporter	2022-06-08 13:22:49 -07:00
Jai Sharma	c2ed41d097	Remove CanBeNull specification from DI attributes	2022-06-08 15:10:19 +01:00
Jai Sharma	04b434b8ce	Update ChatLine timestamp and message colours	2022-06-08 14:04:01 +01:00
Jai Sharma	dfa31df2af	Use #nullable enable in ChatLine	2022-06-08 14:04:01 +01:00
Dean Herbert	c22bffaa01	Fix filter failure when no collection is selected	2022-06-08 19:30:18 +09:00
Dean Herbert	187086e4ec	Merge pull request #18609 from ALANVF/settings-delete-skin ... Add button to delete the current skin	2022-06-08 19:18:59 +09:00
Dean Herbert	42cd7d9e6e	Change CollectionManager to only store MD5 hashes instead of full BeatmapInfo	2022-06-08 18:23:09 +09:00
Dan Balasescu	3a90aa0b9b	Fix code styling	2022-06-08 17:57:59 +09:00
Dean Herbert	5157a78ae6	Isolate nested sample screens from main game to avoid toolbar interactions	2022-06-08 16:53:06 +09:00
theangryepicbanana	6c05329144	Close #5820 (Ability to delete a single skin)	2022-06-07 18:01:40 -04:00
Jai Sharma	2f635fa854	Refactor ChatLine and fix DrawableChannel flow padding ... Refactors `ChatLine` component to use more sensible override properties and layout using grid container. Moves creation of username component into its own method to simplify BDL. Updates padding of base `DrawableChannel` flow padding. Removes usage of `ChatOverlayDrawableChannel` since it's overrides are no longer needed. Updates usage of `StandAloneChatDisplay` to use new override properties of `DrawableChannel`.	2022-06-07 22:35:45 +01:00
Dean Herbert	9da99a0ddf	Rename to latency certifier	2022-06-07 23:34:55 +09:00
Dean Herbert	95dea00725	Tidy up code and namespaces	2022-06-07 23:10:08 +09:00
Dean Herbert	20cfa5d83f	Add button to access latency comparer from game	2022-06-07 17:28:31 +09:00
Bartłomiej Dach	4df7711af8	Merge branch 'master' into volume-metre-keyboard-fix	2022-06-06 23:45:42 +02:00
Dean Herbert	b104b7a90d	Rename method to mention "all"	2022-06-06 20:12:20 +09:00
Dean Herbert	cb383d4bdc	Merge branch 'master' into delete-all-beatmap-videos-sbs	2022-06-06 20:08:05 +09:00
Jai Sharma	c0aaeff2b3	Update DaySeparator to use new design throughout ... Moves `DaySeparator` chat component to it's own file and update it to match new chat design. Makes use of several virtual attributes that can be overridden to update spacing and layout in other usage contexts. Remove redundant usage of `ChatOverlayDaySeparator`, since the new design is now part of the base class. Create `StandAloneDaySeparator` to use in `StandAloneChatDisplay` which overrides attributes to match correct spacing and layout for its design. Ensure that `DrawableChannel.CreateDaySeparator` returns type of `DaySeparator` instead of `Drawable`.	2022-06-04 18:02:14 +01:00
Joseph Madamba	58c8562cb0	Fix username placeholder text casing and missing localisation on registration form	2022-06-03 20:09:20 -07:00
Dean Herbert	d0e098fbcd	Allow using arrow keys to navigate volume controls when controls are already visible	2022-06-04 01:04:46 +09:00
Dean Herbert	712253a35b	Make non-localisable strings in VolumeMeter verbatim	2022-06-04 01:04:23 +09:00
Dean Herbert	64616a6d73	Remove completely gimped implementation in VolumeMeter	2022-06-04 00:18:54 +09:00
Jamie Taylor	6115275bc2	Use 'default' sampleset for toolbar and repurpose 'toolbar' select sample temporarily	2022-06-03 22:33:06 +09:00
Jamie Taylor	2878bb592f	Use more appropriate sounds for certain components	2022-06-03 22:32:12 +09:00
Jamie Taylor	365819865e	Remove 'submit' sample usages	2022-06-03 22:31:35 +09:00
Salman Ahmed	cd999cf7ac	Fix back-to-front conditional	2022-06-03 10:51:20 +03:00
Salman Ahmed	1a835f0622	Add warning note when running fullscreen on macOS	2022-06-03 10:32:59 +03:00
Dean Herbert	5bd9d88219	Fix tutorial download state not matching correctly when already available locally ... Closes https://github.com/ppy/osu/issues/18468. This doesn't stop the tutorial from downloading a second time, but at least displays the correct status afterwards. Avoiding the download is a bit more involved and requires a change to the flow. Probably not worth it just yet. To test, recommend switching to production environment, as dev server doesn't have correct metadata for tutorial resulting in weirdness.	2022-06-02 16:34:24 +09:00
Dean Herbert	42598ce22a	Refactor warning to notice in method names and usages	2022-06-01 16:51:58 +09:00
Dean Herbert	f7110116de	Only display exclusive fullscreen hinting on windows	2022-05-31 14:04:56 +09:00
Dean Herbert	53844d3df1	Refactor settings item "warning" text to allow non-warning state	2022-05-31 14:01:42 +09:00
Dan Balasescu	99ee3a7d8d	Merge branch 'master' into detect-exclusive-fullscreen	2022-05-31 09:42:42 +09:00
Dean Herbert	1d5a156c15	Merge pull request #18427 from sw1tchbl4d3r/currently_playing_search ... Add search bar for the `CurrentlyPlayingDisplay`	2022-05-30 23:03:00 +09:00
Dean Herbert	f65d2db77f	Remove "V2" suffix from ChatOverlay components	2022-05-30 17:54:09 +09:00
Dan Balasescu	5f9a69e5c2	Add localisation	2022-05-30 17:19:03 +09:00
Dan Balasescu	dea7a27553	Adjust wording, add text for capable state	2022-05-30 17:18:29 +09:00
Dean Herbert	9e678101cf	Merge pull request #18442 from jai-x/new-chat-announce-channel ... Display Announce type channels separately in new chat overlay	2022-05-30 16:53:15 +09:00
Dean Herbert	5478ac21ea	Merge branch 'master' into currently_playing_search	2022-05-30 16:48:53 +09:00
Jai Sharma	8f596520f3	Remove old chat overlay components	2022-05-29 20:08:43 +01:00
Bartłomiej Dach	e329c160b3	Simplify channel retrieval expression	2022-05-29 18:58:27 +02:00
Bartłomiej Dach	e69f8716cd	Fix incorrect indent size	2022-05-29 18:56:37 +02:00
Bartłomiej Dach	f9f8a32380	Merge branch 'master' into new-chat-announce-channel	2022-05-29 18:55:43 +02:00
Dean Herbert	7c97719db1	Move Schedule to only drawable pieces	2022-05-29 21:28:09 +09:00
Dean Herbert	c7570fbce5	Fix potential ObjectDisposedException on realm notification in SkinSection	2022-05-29 15:15:03 +09:00
sw1tchbl4d3	ede3ab9dc0	Add OnFocus handler to CurrentlyPlayingDisplay	2022-05-28 12:04:44 +02:00
Salman Ahmed	06832a4baf	Fix beatmap badge colours not updated inline with recent changes	2022-05-28 01:05:43 +03:00
sw1tchbl4d3	cd84200ad9	Add HoldFocus and ReleaseFocusOnCommit attributes to searchbar	2022-05-27 21:23:37 +02:00
Jai Sharma	c5845f307a	Code quality	2022-05-27 20:12:00 +01:00
Dean Herbert	254039b8fe	Address remaining code quality concerns	2022-05-28 04:01:51 +09:00
Jai Sharma	e950c8c1d0	Refactor ChannelList to use new ChannelGroup class for each type of channel	2022-05-27 19:46:53 +01:00
Jai Sharma	320b6ca631	Display Announce type channels separately in new chat overlay	2022-05-27 16:18:22 +01:00
Bartłomiej Dach	e511c1dfff	Merge branch 'master' into use-normalised-precise-scrolling	2022-05-27 16:55:13 +02:00
sw1tchbl4d3	e2951d70d1	Address code style issues	2022-05-27 16:38:54 +02:00
sw1tchbl4d3	e1fd37fd44	Use new padding constant where appropriate	2022-05-27 12:40:31 +02:00
sw1tchbl4d3	6a0cf26722	Make text localisable and add padding constant	2022-05-27 12:36:43 +02:00
sw1tchbl4d3	7c459faaf0	Remove unneeded search_bar_width and more	2022-05-27 10:05:59 +02:00
sw1tchbl4d3	4967d03606	Update currently playing search bar to resemble existing UI	2022-05-27 09:58:40 +02:00
Joseph Madamba	105d581f24	Use existing web localisation for chat strings	2022-05-26 22:23:03 -07:00
Joseph Madamba	3554563114	Fix beatmap info scores container not hiding when there's no leaderboard	2022-05-26 19:50:54 -07:00
Joseph Madamba	2b5aa35b56	Fix beatmap info status pill being incorrect on multiple status beatmaps	2022-05-26 17:52:17 -07:00
sw1tchbl4d3	a8e453e660	Remove now unnecessary username filter check	2022-05-27 00:43:29 +02:00
sw1tchbl4d3	de5b60ab66	Move filtering from manual loops to SearchContainer	2022-05-27 00:40:23 +02:00
sw1tchbl4d3	3183621d3d	Add search bar for the CurrentlyPlayingDisplay	2022-05-26 22:57:24 +02:00
Dean Herbert	a98d0cf0d8	Simplify channel filter method	2022-05-26 18:48:11 +09:00
Dean Herbert	b2607196b8	Merge branch 'master' into new-chat-integrate	2022-05-26 18:38:26 +09:00
Dan Balasescu	08935cff86	Detect exclusive fullscreen on Windows	2022-05-26 18:37:04 +09:00
Noah M	b550cbc5a3	Fix failing code quality checks	2022-05-25 17:01:30 -05:00
Bartłomiej Dach	a1b8fa0992	Disable "select all mods" button if all are selected	2022-05-25 23:06:12 +02:00
Bartłomiej Dach	071e158a29	Expose available mod state outwardly as a bindable	2022-05-25 23:06:12 +02:00
Bartłomiej Dach	f0303d76e8	Split off "select all mods" button to separate class	2022-05-25 22:18:30 +02:00
Bartłomiej Dach	a3f2962558	Disable "deselect all mods" button if none are selected	2022-05-25 22:15:02 +02:00
Bartłomiej Dach	a4bd399b0c	Split off "deselect all mods" button to separate class	2022-05-25 22:14:45 +02:00
Jai Sharma	f94afa5f8c	Code quality	2022-05-25 18:28:18 +01:00
Jai Sharma	997fc716e8	Split out the channel list labels from the channel list item flow	2022-05-25 15:15:46 +01:00
Jai Sharma	c0da05dda0	Use an array of channels to exclude from the overlay	2022-05-25 15:15:26 +01:00
Jai Sharma	cd90d29315	Ensure channel traversal shortcut scrolls channel list item into view	2022-05-25 12:37:28 +01:00
Jai Sharma	4a36f3aa4c	Ensure channel traversal shortcut is using visual order	2022-05-25 12:29:04 +01:00
Dean Herbert	49ab031e75	Allow traversing in both directions using ctrl-tab shortcuts	2022-05-25 18:42:49 +09:00
Dean Herbert	a92089c443	Change filter method to consider all non-system channels as joinable	2022-05-25 18:42:33 +09:00
Dan Balasescu	79c8752bb4	Merge pull request #18408 from peppy/first-run-ui-scale-first ... Move UI scale setup to the beginning of the first run setup	2022-05-25 12:56:03 +09:00
Dean Herbert	de5d2df100	Move UI scale setup to the beginning of the first run setup	2022-05-25 12:19:26 +09:00
Dan Balasescu	f468d1eb16	Merge branch 'master' into editor-tidy-up	2022-05-25 11:58:34 +09:00
Jai Sharma	f6810d3f59	Add keyboard shortcuts to ChatOverlayV2 with tests	2022-05-24 23:05:25 +01:00
Bartłomiej Dach	61c093c109	Merge branch 'master' into rounded-button-colour-default	2022-05-24 22:47:47 +02:00
Jai Sharma	fce527b0df	Schedule channel manager bindable events to ensure they happen after the first poll	2022-05-24 21:25:27 +01:00
Bartłomiej Dach	2dd0b3f8d9	Merge branch 'master' into fix-mod-panel-click-area	2022-05-24 21:52:37 +02:00
Dean Herbert	0bcf8c846c	Change editor colour scheme to aquamarine	2022-05-24 18:43:22 +09:00
Dean Herbert	f00dd27fcd	Move OverlayColourProvider provisioning of RoundedButton to SettingsButton for now	2022-05-24 18:11:54 +09:00
Joseph Madamba	1f935cacf4	Add spotlighted beatmaps filter to beatmap listing	2022-05-23 18:47:04 -07:00
Joseph Madamba	ed0b841df0	Fix incorrect left/right clicking area of mod panels	2022-05-23 18:29:26 -07:00
apollo-dw	eae2378466	Add WIP to search filters	2022-05-24 01:49:07 +01:00
Jai Sharma	58d39734d0	Integrate ChatOverlayV2 into main game	2022-05-23 21:02:47 +01:00
Susko3	88217e0c98	Adjust ScrollDelta usages to account for normalised IsPrecise values	2022-05-23 20:22:27 +02:00
Dean Herbert	7d93778355	Merge pull request #18290 from jai-x/new-chat-remove-selector-item ... Use dummy channel to show selector and remove `ChannelListSelector`	2022-05-23 15:49:00 +09:00
Dean Herbert	d84119ac06	Merge pull request #18343 from frenzibyte/waveform-test-beatmap-failure ... Fix `WaveformTestBeatmap`s potentially providing disposed track	2022-05-22 21:21:28 +09:00
Jai Sharma	fb06b7658b	Merge branch 'master' into new-chat-remove-selector-item	2022-05-21 17:30:06 +01:00
Dean Herbert	4633eed78c	Merge branch 'master' into localisable-filter-items	2022-05-20 23:55:16 +09:00
Salman Ahmed	abf9039109	Use == instead of ??	2022-05-20 16:08:31 +03:00
Salman Ahmed	c78d90ccbd	Refactor track transferring logic for ability to override and disallow	2022-05-20 14:43:07 +03:00
Jai Sharma	c37d1e4fae	Ensure current channel is set to the ChannelListingChannel when it becomes null	2022-05-19 11:45:39 +01:00
Dean Herbert	136ecb45e2	Rename dummy channel and move to a nested class inside the ChannelListing itself	2022-05-19 19:26:14 +09:00
Dean Herbert	63c9776365	Fix oversight in bindable logic in new overlay class	2022-05-19 19:24:18 +09:00
Dean Herbert	363e7a6f53	Simplify toolbar hiding logic in FirstRunSetupOverlay ... Rather than fiddling around with the activation modes, this seems like a much cleaner way to make things work. Closes https://github.com/ppy/osu/issues/18277.	2022-05-19 16:42:48 +09:00
Dean Herbert	d187ca2d8c	Merge pull request #18246 from jai-x/new-chat-cache-loaded-channels ... Add drawable channel caching to new chat overlay	2022-05-19 15:15:47 +09:00
Dean Herbert	a443200d0d	Make dependency nullable to allow for safer disposal unbinding	2022-05-19 13:49:52 +09:00
Noah M	0ef9406787	Fix deleteBeatmapVideosButton not being reenabled ... My bad	2022-05-18 16:35:14 -05:00
Noah M	617382a56f	Split off MassVideoDeleteConfirmationDialog into its own file	2022-05-18 15:20:57 -05:00
Salman Ahmed	5d3878a737	Add test coverage for slow-loading channels	2022-05-18 22:58:39 +03:00
Jai Sharma	371738b047	Check against the loaded drawable channel	2022-05-18 20:00:42 +01:00
Dean Herbert	0cee90e156	Add common strings for missing localisable content	2022-05-18 21:32:57 +09:00
Dean Herbert	d54e1503c7	Rename interaction toggle method	2022-05-18 21:32:57 +09:00
Dean Herbert	fa09270e62	Remove left-over todo	2022-05-18 21:32:57 +09:00
Noah M	69351d2cdf	Implement button to delete all beatmap videos	2022-05-18 01:20:57 -05:00
Jai Sharma	4015042e36	Ensure close button component is not stored as a Drawable	2022-05-18 01:35:39 +01:00
Bartłomiej Dach	c2555a91c7	Merge branch 'master' into first-run-screen-import-from-stable	2022-05-17 22:52:01 +02:00
Bartłomiej Dach	10b881dbf7	Merge branch 'master' into first-run-screen-button-ux	2022-05-17 22:27:49 +02:00
Jai Sharma	932442e242	Use null for empty grid cells in ChannelListItem	2022-05-17 18:52:19 +01:00
Dean Herbert	062ffe64ac	Remove delay on pop in	2022-05-17 18:21:19 +09:00
Dean Herbert	bf00b062ad	Add full localisation of import beatmaps screen	2022-05-17 17:58:24 +09:00
Dean Herbert	f4e0ad8c4c	Fix drag drop of osu! folder not working as expected	2022-05-17 17:51:28 +09:00
Dean Herbert	c0de1f96ff	Tidy up interaction toggling and add progress message	2022-05-17 17:33:54 +09:00
Dean Herbert	03d3900a02	Fix incorrect default state of checkboxes	2022-05-17 17:33:54 +09:00
Dean Herbert	adc7b61240	Switch directory selector to use a semi-shared popover implementation	2022-05-17 17:33:54 +09:00
Dean Herbert	e2ea98693f	Tidy up buttons and text	2022-05-17 17:33:54 +09:00
Dean Herbert	4af1a788d1	Add locate stable button / screen	2022-05-17 15:55:53 +09:00
Dean Herbert	1593f05ff3	Tidy up checkbox implementation	2022-05-17 15:55:53 +09:00
Dean Herbert	13e70eab51	Allow cancellation of count operations and bypassing interactive location logic	2022-05-17 15:55:53 +09:00
Dean Herbert	1666d13d26	Add item counts to import screen	2022-05-17 15:55:53 +09:00
Dean Herbert	4412fec41a	Add import from stable screen	2022-05-17 15:55:52 +09:00
Dean Herbert	ef5b2233d7	Improve the first run progress button to show loading and completion status	2022-05-17 15:23:13 +09:00
Dan Balasescu	a633501687	Change FilterTerms to use LocalisableString	2022-05-16 14:09:37 +09:00
Jai Sharma	ae5b6c3e10	Use dummy channel to show selector and remove ChannelListSelector ... Add dummy channel `DummySelectorChannel` which should be set as the current channel in the channel manager when the selector in the chat overlay should be shown. Refactors the `ChannelListItem` to not show mention pill and close button when the channel is the dummy selector channel. Ensure that the `ChannelList` selects the dummy channel on clicking the selector item. Removes `ChannelListSelector` as it is no longer needed. Removes the `setCurrent` parameter from `ChannelManager.JoinChannel` method as it is no longer needed.	2022-05-15 20:24:49 +01:00
Bartłomiej Dach	170df01b46	Adjust difficulty multiplier scale transition on mod overlay ... The previous transition was supposed to be a center-anchored elastic scale-in, but this didn't work as intended - because the multiplier ended up inside of an auto-sized right-aligned container, the animation itself would end up being anchored right. Attempts to remove the scale transition resulted in a rather jarring-looking result, so swap out the elastic scale-in for a sweep-in effect from the top, to match the header and avoid introducing too many directions of movement. Delay values tweaked "to taste" - can be adjusted further if there is an alternative set of values that feels better.	2022-05-15 20:44:50 +02:00
Dean Herbert	328561f5c8	Merge pull request #18263 from frenzibyte/spotlight-beatmap-badge ... Add support for "spotlight" label in beatmap overlay/listing	2022-05-15 12:32:20 +09:00
Salman Ahmed	4bb06873d5	Move badge hierarchy declaration to constructor for safer access	2022-05-14 21:54:56 +03:00
Dean Herbert	8a01050168	Refactor mod select button initialisation to allow shared usage of deselect button	2022-05-15 03:16:43 +09:00
Salman Ahmed	1878578196	Move todo comment to subclasses	2022-05-14 21:05:34 +03:00
Salman Ahmed	441957e18e	Convert get-only virtual properties to avoid DI order dependency	2022-05-14 21:05:34 +03:00
Salman Ahmed	88ba84ac9c	Replace Pill with Badge everywhere	2022-05-14 20:52:38 +03:00
Dean Herbert	a759cf2dab	Add key binding to deselect all mods ... Defaults to `Backspace`.	2022-05-15 02:51:58 +09:00
Salman Ahmed	2878a6dcbe	Integrate spotlight beatmap badge in info overlay	2022-05-14 19:47:10 +03:00
Salman Ahmed	56d6cb5764	Add "spotlight" beatmap badge	2022-05-14 19:46:50 +03:00
Salman Ahmed	c8bea6273b	Abstractify beatmap badge logic to own class	2022-05-14 19:46:37 +03:00
Jai Sharma	bd68ffa805	Fix textbox focus test in ChatOverlayV2	2022-05-14 12:16:00 +01:00
Jai Sharma	2163a78b7f	Ensure drawable channels removed from the cache are disposed	2022-05-14 00:15:09 +01:00
Jai Sharma	f88e416d1a	Ensure the wrong drawable channel isn't shown after load	2022-05-13 23:39:09 +01:00
Jai Sharma	9f5351e5a1	Add drawable channel caching to new chat overlay	2022-05-12 23:58:41 +01:00
Dean Herbert	8760e5d884	Merge branch 'master' into new-chat-drawable-channel	2022-05-12 22:36:19 +09:00
Dan Balasescu	5f2d9bf04c	Merge pull request #18211 from frenzibyte/audio-adjustment-breakage-alt ... Fix mods potentially adjusting track while not selected	2022-05-12 15:44:19 +09:00
Salman Ahmed	82c4a5fe9f	Merge branch 'master' into new-chat-visibility-behaviour	2022-05-12 09:04:24 +03:00
Dean Herbert	3d64dc53a6	Merge branch 'master' into audio-adjustment-breakage-alt	2022-05-12 14:18:28 +09:00
Dean Herbert	6ba0760b17	Merge branch 'master' into new-chat-visibility-behaviour	2022-05-12 13:59:35 +09:00
Dean Herbert	1d38e5bd33	Add notes about weird local handling in ChannelListSelector	2022-05-12 13:58:10 +09:00
Dean Herbert	2dfed6eda1	Remove selectorActive bindable completely	2022-05-12 13:53:57 +09:00
Jai Sharma	db371ab068	Use CurrentChannel == null to show the channel selector	2022-05-11 22:52:15 +01:00
Bartłomiej Dach	981ead68bf	Ensure local mods are constructed in time for Pop{In,Out}()	2022-05-11 22:31:27 +02:00
Bartłomiej Dach	93539160ad	Remove no-longer-necessary guard	2022-05-11 22:31:26 +02:00
Bartłomiej Dach	2266a5c9a0	Remove no-longer-necessary ModColumn.Filter	2022-05-11 22:31:26 +02:00
Bartłomiej Dach	1c0166367d	Fix remaining column operations being coupled to drawables	2022-05-11 22:31:26 +02:00
Bartłomiej Dach	b5a9f1310a	Fix select/deselect all toggle not working correctly after changes	2022-05-11 22:31:26 +02:00
Bartłomiej Dach	52bbce12f1	Fix not being able to set AvailableMods before loaded	2022-05-11 22:31:26 +02:00
Bartłomiej Dach	fc24a56478	Add protection from recursive updates from external selection	2022-05-11 22:31:25 +02:00
Bartłomiej Dach	83ba06e7af	Extract helper property for accessing all mods	2022-05-11 22:31:25 +02:00
Bartłomiej Dach	11ae1da65a	Hoist reference replacement logic to overlay level	2022-05-11 22:26:47 +02:00
Bartłomiej Dach	05a21fbbe0	Hoist ModState to overlay level	2022-05-11 22:26:21 +02:00
Bartłomiej Dach	e86444c4bf	Hoist ModState to column level	2022-05-11 22:03:49 +02:00
Bartłomiej Dach	74599c9c62	Use ModState in mod panels	2022-05-11 22:03:48 +02:00
Bartłomiej Dach	478cfc0b87	Split model class for mod state	2022-05-11 22:03:48 +02:00
Bartłomiej Dach	ddb2d4eef5	Rename FreeModSelect{Screen -> Overlay} reference in inline comment	2022-05-11 18:06:09 +02:00
Bartłomiej Dach	a104277e7f	Rename ModSelect{Screen -> Overlay}Strings	2022-05-11 18:01:33 +02:00
Bartłomiej Dach	76c63f1d0a	Rename ModSelect{Screen -> Overlay} in place of removed old design	2022-05-10 22:56:50 +02:00
Bartłomiej Dach	33634cba1e	Remove old mod buttons	2022-05-10 21:58:22 +02:00
Bartłomiej Dach	8b0ece1c09	Remove old mod section	2022-05-10 21:55:54 +02:00
Bartłomiej Dach	dfd97701d7	Remove old mod settings container & related controls	2022-05-10 21:53:42 +02:00
Bartłomiej Dach	128468e13d	Remove old base mod select overlay	2022-05-10 21:52:30 +02:00
Bartłomiej Dach	24c59e2f2f	Remove old user mod select overlay	2022-05-10 21:52:17 +02:00
Salman Ahmed	9446be2511	Remove unnecessary UnbindAdjustments call ... It is not necessary given that `CurrentTrack` already removes all adjustments first.	2022-05-10 20:49:44 +03:00
Salman Ahmed	36a7644164	Reinstantiate mod adjustments layer for safety against previous mods	2022-05-10 20:46:33 +03:00
Salman Ahmed	725ff93f34	Define local adjustments component for mods in MusicController ... Isolates `CurrentTrack` from being directly adjusted by the mod, which could lead to issues depending on how the mod adds adjustments (i.e. `ModTimeRamp`, which adds adjustments based on changes to a setting bindable).	2022-05-10 18:24:29 +03:00
Dan Balasescu	42fe708225	Fix inspection	2022-05-10 19:56:21 +09:00
Dean Herbert	a578f7a406	Force nested screens to load synchronously	2022-05-10 18:21:35 +09:00
Dean Herbert	a93c63b2b5	Add loading spinner when loading first run screens	2022-05-10 18:21:35 +09:00
Dean Herbert	25c6226ca9	Adjust transition length for a more seamless screen change	2022-05-10 18:21:35 +09:00
Dean Herbert	493798ae5e	Fix nested ui scale example screens no longer fitting	2022-05-10 18:21:35 +09:00
Dean Herbert	63b9e01d38	Fix behaviour screen using old style buttons	2022-05-10 18:21:35 +09:00
Dean Herbert	61313b69ec	Standardise font sizes in first run overlay screens	2022-05-10 18:21:35 +09:00
Dean Herbert	e5204e565d	Move horizontal padding to content level to better align scrollbar	2022-05-10 18:21:35 +09:00
Dean Herbert	bcce9c5e67	Limit the width of first run overlay content	2022-05-10 18:21:35 +09:00
Dean Herbert	9aadc274bf	Show first run dialog on first run of the game	2022-05-10 18:21:35 +09:00
Dan Balasescu	8ccf2ee075	Add inline comment	2022-05-10 15:07:08 +09:00
Dan Balasescu	2b7eeadac0	Workaround bad performance when selecting all freemods	2022-05-10 14:48:41 +09:00
Dan Balasescu	886a4815fa	Merge pull request #18180 from frenzibyte/fix-toolbox-double-tap ... Fix `SettingsToolboxGroup` not clearing transforms before updating autosize	2022-05-10 13:48:02 +09:00
Jai Sharma	2481201a73	Fix selector dismissal behaviour during user actions	2022-05-09 22:58:46 +01:00
Salman Ahmed	96ea4ee7b3	Add explanatory comment	2022-05-09 23:49:05 +03:00
Bartłomiej Dach	626fcd5d35	Merge branch 'master' into column-flow-cq	2022-05-09 19:22:29 +02:00
Jai Sharma	d4cc2bd7dd	Ensure channel selector is dismissed when the current channel is changed	2022-05-09 12:11:25 +01:00
Salman Ahmed	702c6ae658	Fix SettingsToolboxGroup not clearing transforms before updating autosize	2022-05-09 13:49:31 +03:00
Dean Herbert	1c63c27fdf	Merge branch 'master' into new-chat-drawable-channel	2022-05-09 18:23:00 +09:00
Dan Balasescu	e9cc3ab54a	Merge pull request #18164 from Joehuu/fix-exit-dialog-bad-state ... Fix popup dialog potentially not clicking last button when dismissed	2022-05-09 17:22:03 +09:00
Jai Sharma	623e2c94ae	Adjust padding	2022-05-09 00:32:22 +01:00
Jai Sharma	aeb2984989	Move ChatOverlayDrawableChannel to it's own file	2022-05-09 00:31:22 +01:00
Jai Sharma	5f80e344c3	Update day separator date text to right align against username	2022-05-09 00:15:08 +01:00
Joseph Madamba	21e1f4546a	Fix popup dialog potentially not clicking last button when dismissed	2022-05-08 14:40:30 -07:00
Joseph Madamba	172d14bcc6	Improve code quality of mod column flow container	2022-05-08 11:40:14 -07:00
Bartłomiej Dach	d964b4f23c	Fix uneven spacing when some mod columns are hidden	2022-05-08 15:40:21 +02:00
Bartłomiej Dach	6bdcf893b7	Move alpha management closer to screen level ... Felt bad messing with alpha at the column level.	2022-05-08 15:40:10 +02:00
Bartłomiej Dach	92ccec20d7	Hide mod columns if all mods within are filtered out	2022-05-08 14:53:59 +02:00
Dean Herbert	b8cb2c1b82	Increase scroll amount slightly	2022-05-08 19:57:03 +09:00
Dean Herbert	778497b9e2	Scroll mod select slightly into view on first display	2022-05-08 18:58:54 +09:00
Bartłomiej Dach	b92d95a17a	Fix mod panels playing samples when hidden at a higher level	2022-05-08 10:39:49 +02:00
Bartłomiej Dach	81ca534f87	Implement ISamplePlaybackDisabler in mod select	2022-05-08 10:39:49 +02:00
Dean Herbert	230c4e27b8	Simplify and centralise hiding logic for mod overlay ... Behaviourally, this also always toggles via button triggering to add the button flash animation.	2022-05-08 13:03:28 +09:00
Jai Sharma	8da7bbd322	Code quality	2022-05-07 23:30:46 +01:00
Jai Sharma	c0643cae75	Create ChatOverlayDaySeparator and use in ChatOverlayDrawableChannel	2022-05-07 23:24:34 +01:00
Jai Sharma	f4acfbd0df	Change return type of CreateDaySeparator to Drawable	2022-05-07 22:23:46 +01:00
Jai Sharma	bec28c5b28	Remove virtual ColourInfo properties from DaySeparator	2022-05-07 22:16:11 +01:00
Bartłomiej Dach	46d3220c07	Isolate sample screens from global mods bindable ... Fixes scenario wherein entering the first run setup overlay, exiting at the "UI scale" step (which shows a song select), then moving to actua song select and trying to select a mod would lead to a crash. The crash was caused by two active mod screen instances attempting to swap the global mod bindable's mod instances for ones they owned. This logic - while generally problematic and hard to maintain - was fixing several issues with mod reference management and setting copying, so I'm letting it live another day. This change will mean that the song select preview on the "UI scale" step will not receive the same mods that the actual game has enabled. That said, it already doesn't use the same beatmap or ruleset, so this looks fine to break.	2022-05-07 21:44:58 +02:00
Dean Herbert	2278da563e	Add various xmldoc for nested classes	2022-05-08 02:03:28 +09:00
Dean Herbert	03c80d9197	Reorder methods / properties in ModSelectScreen for legibility	2022-05-08 01:58:37 +09:00
Dean Herbert	1d27ef18dc	Add xmldoc for IsValidMod	2022-05-08 01:49:29 +09:00
Dean Herbert	0d32bf91eb	Hardcode hide key handling in ModSelectScreen	2022-05-08 01:35:11 +09:00
Bartłomiej Dach	0c2b4a6c0b	Fix invalid IsLoaded check ... Would fail when `availableMods` would be changed from a different thread while the columns aren't loaded.	2022-05-07 15:44:22 +02:00
Bartłomiej Dach	528342411e	Merge branch 'master' into mod-overlay/integration	2022-05-07 13:52:19 +02:00
Bartłomiej Dach	fe69bd7ed9	Merge branch 'master' into change-mod-scroll-behaviour	2022-05-07 13:29:02 +02:00
Bartłomiej Dach	9a56f6db44	Merge branch 'mod-overlay/back-button' into mod-overlay/integration	2022-05-07 13:15:13 +02:00
Bartłomiej Dach	a716f62a6a	Flash back button when keyboard back binding is pressed	2022-05-07 13:01:36 +02:00
Salman Ahmed	d4c9de8596	Move button width in mod select to constant	2022-05-07 13:23:48 +03:00
Salman Ahmed	8ee3fdd0aa	Change mod scrolling behaviour to not scroll horizontally on columns/settings	2022-05-07 12:15:11 +03:00
Bartłomiej Dach	fd75963ca2	Dismiss mod select if select binding is pressed	2022-05-07 11:01:05 +02:00
Bartłomiej Dach	e7e7486a8e	Merge branch 'mod-overlay/back-button' into mod-overlay/integration	2022-05-07 10:59:30 +02:00
Bartłomiej Dach	b72cf4cd5d	Merge branch 'mod-overlay/localisation-strings' into mod-overlay/back-button	2022-05-07 10:58:09 +02:00
Bartłomiej Dach	f761d4d4d4	Reuse "select/deselect all" localisable string on column toggle	2022-05-07 10:56:03 +02:00
Bartłomiej Dach	fa0a256f48	Add localisable string for difficulty multiplier display	2022-05-07 10:48:15 +02:00
Bartłomiej Dach	271d64fd54	Add back button to mod select overlays	2022-05-07 10:17:32 +02:00
Bartłomiej Dach	6ad990dfc3	Add basic localisation strings for new mod select	2022-05-07 10:17:24 +02:00
Bartłomiej Dach	4ff96f82be	Dim other buttons if customisation panel is open	2022-05-07 09:50:09 +02:00
Bartłomiej Dach	18e4c3ed0f	Update mod columns even if they're not present/offscreen ... Important to make "select/deselect all" operations work on all columns simultaneously, even if they're offscreen. Unfortunately by the nature of how the existing selection animation works, it is hard-tied to the update loop, so we need to compensate.	2022-05-07 09:50:09 +02:00
Bartłomiej Dach	9514a5cef7	Only load panels asynchronously outside of BDL	2022-05-07 09:50:09 +02:00
Bartłomiej Dach	9f96dd47d1	Remove schedule in panel load ... It was causing selection/deselection of all mods to work improperly if a select/deselect all operation was requested before the panel was scrolled into view. In general the schedule was an over-optimisation - the game-global set of available mods shouldn't be changing so often as to warrant such an aggressive debounce.	2022-05-07 09:50:09 +02:00
Bartłomiej Dach	852e4a9766	Add select/deselect all buttons to free mod select screen	2022-05-07 09:29:33 +02:00
Bartłomiej Dach	0b95594f60	Add some more padding between footer and column scroll	2022-05-07 09:29:33 +02:00
Bartłomiej Dach	0c6de331f3	Move footer button padding to a higher level	2022-05-07 09:29:32 +02:00
Dean Herbert	dd63657dfb	Merge pull request #18065 from huoyaoyuan/code-style ... Enforce code style analysis shipped with .NET SDK	2022-05-07 14:58:19 +09:00
Jai Sharma	6fc808be22	Code quality	2022-05-06 23:17:59 +01:00
Jai Sharma	9d62206176	Update new chat overlay day separator colours and spacing ... Updates the `DaySeparator` component to have separately settable colours for the text and the lines. Updates existing overrides of the `DaySeparator` to use the new colour setter. Create new `ChatOverlayDrawableChannel` with adjusted spacing and new `DaySeparator` colours.	2022-05-06 23:06:18 +01:00
Bartłomiej Dach	8c73ed7207	Fix sequence equality check not using reference comparison	2022-05-06 21:47:04 +02:00
Bartłomiej Dach	621f746789	Do not modify selected mods through panel state change during external update	2022-05-06 21:47:04 +02:00
Bartłomiej Dach	c199b8fcb6	Simplify state management in ModColumn ... Bad sign when you can't follow your own code. All of the various state changing methods were flattened into one because it was too hard to follow what was calling what and why.	2022-05-06 21:46:16 +02:00
Salman Ahmed	1409f8ca96	Merge branch 'master' into fix-toolbox-expansion	2022-05-06 18:00:01 +03:00
Bartłomiej Dach	c533c93ffd	Remove leftover border thickness spec in mod settings area ... Was never supposed to be there, it was a vestige of a previous design iteration that went by unnoticed.	2022-05-06 15:34:49 +02:00
Bartłomiej Dach	e527574ede	Merge branch 'master' into fix-toolbox-expansion	2022-05-06 13:47:36 +02:00
Dean Herbert	98eab9668d	Merge pull request #18119 from bdach/mod-overlay/broken-hover ... Fix mod panels not hovering correctly after closing customisation area via mouse on new mod select	2022-05-06 20:42:33 +09:00
Bartłomiej Dach	e9d52aa954	Remove not-accessed field	2022-05-06 13:09:37 +02:00
Bartłomiej Dach	a915b7333c	Remove unused using directive	2022-05-06 13:08:54 +02:00
Dean Herbert	88c190f3e3	Change colour denoting expanded state to be gray rather than yellow ... I always found the yellow colour very non-descript in this case. Gray seems to work better?	2022-05-06 19:45:17 +09:00
Dean Herbert	b432885e5f	Tidy up ordering of SettingsToolboxGroup	2022-05-06 19:39:09 +09:00
Dean Herbert	59add66632	Remove unnecessary autosize workaround (was fixed long ago)	2022-05-06 19:39:00 +09:00
Dean Herbert	949e30c4b4	Remove auto-expansion of individual toolbox groups when parent expanding container expands	2022-05-06 19:36:41 +09:00
Bartłomiej Dach	08fd0ea086	Fix click-to-return container still handling hover when inactive	2022-05-06 12:28:53 +02:00
Dean Herbert	be960eb092	Move dangerous hold specification to base class	2022-05-06 14:34:31 +09:00
Dean Herbert	0d8e42b941	Merge branch 'master' into exit-multiplayer-is-dangerous	2022-05-06 14:25:18 +09:00
Jai Sharma	0974de8fb0	Use BindableFloat for chat height	2022-05-05 23:13:32 +01:00
Jai Sharma	16a6c11bc8	Clamp maximum and minimum height the chat overlay can be resized to	2022-05-05 21:40:37 +01:00
Bartłomiej Dach	34cf4c6a38	Fix mod overlay not closing on toggle hotkey	2022-05-05 22:16:56 +02:00
Bartłomiej Dach	a56eab2c47	Extract interface for overlay management	2022-05-05 22:16:55 +02:00
Bartłomiej Dach	ac08498f35	Use plum colour scheme in multiplayer to match rest of multiplayer screens	2022-05-05 22:16:54 +02:00
Bartłomiej Dach	79e1b93b30	Close customisation area on escape press before exiting	2022-05-05 19:17:36 +02:00
Bartłomiej Dach	2cc56a4b19	Fix hidden issue with automatic customisation panel show logic ... Doesn't cause tests to fail headless, but they do fail in the test browser.	2022-05-05 19:17:36 +02:00
Dean Herbert	9d48bb41c9	Merge branch 'master' into new-chat-overlay	2022-05-05 23:12:31 +09:00
Jai Sharma	5ea6f62951	Ensure RelativePositionAxes is set in BDL for animations to work	2022-05-05 14:20:33 +01:00
Dan Balasescu	e46f99bdba	Merge branch 'master' into dialog-overlay-thread-woes	2022-05-05 20:57:51 +09:00
Dean Herbert	97221d2ef1	Tidy up initialisation	2022-05-05 19:24:18 +09:00
Dean Herbert	e54f5e2d92	Adjust value change variables to avoid e usage	2022-05-05 19:22:20 +09:00
Dean Herbert	74505ba166	Remove ! usage (also seems to fix height saving/loading)	2022-05-05 19:22:12 +09:00
Dean Herbert	25ea660b0b	Replace HandlePositionalInput override with simple hover effect	2022-05-05 19:13:48 +09:00
Dean Herbert	4efaa41670	Merge branch 'master' into new-chat-overlay	2022-05-05 18:57:00 +09:00
Dean Herbert	f6a6a11391	Remove DialogOverlay local fades (is already managed by PopupDialogs themselves)	2022-05-05 15:02:23 +09:00
Dean Herbert	326ff3b6e9	Fix CurrentDialog being updated twice, unsafe variable access	2022-05-05 14:55:05 +09:00
Dean Herbert	a27fcda9f1	Fix failing tests due to CurrentDialog being unexpectedly not set after Push	2022-05-05 01:52:39 +09:00
Salman Ahmed	e294069e2f	Merge branch 'master' into beatmap-selection-keybinding	2022-05-04 16:48:49 +03:00
Salman Ahmed	9416346c94	Globalise beatmap selection key bindings as "group" selection	2022-05-04 16:46:32 +03:00
Jai Sharma	1a85e1267b	Ensure focus is directed to ChatTextBox from ChatOverlay and add tests	2022-05-04 14:43:40 +01:00
Dean Herbert	ddab3c6d80	Tidy up state variables	2022-05-04 21:00:11 +09:00
Dean Herbert	383245f43a	Fix dialoged pushed to DialogOverlay too early potentially doing cross-thread transforms ... As seen at https://github.com/ppy/osu/runs/6287700705?check_suite_focus=true.	2022-05-04 20:23:36 +09:00
Dean Herbert	3eead5a6a3	Rename FlushAnimation to FlushPendingSelections to better match purpose	2022-05-04 19:40:08 +09:00
Jai Sharma	60999e83e0	Ensure ChatTextBox takes/leaves focus on chat overlay pop in/out	2022-05-03 22:33:36 +01:00
Jai Sharma	c17edb2848	Add padding to text in ChatTextBar to separate it from the textbox	2022-05-03 22:32:51 +01:00
Jai Sharma	50aee8b665	Ensure ChannelListSelector text also turns white when selected	2022-05-03 22:32:01 +01:00
Bartłomiej Dach	f5fa41356e	Rewrite mod instance management again to pass tests	2022-05-03 22:31:34 +02:00
Bartłomiej Dach	970361676b	Fix setting items not creating if mods initially not empty	2022-05-03 21:45:40 +02:00
Bartłomiej Dach	e3641213e1	Always hide unimplemented mods on mod select screen	2022-05-03 21:45:40 +02:00
Bartłomiej Dach	f91ee4b042	Reset panel mod instance settings to defaults on deselect	2022-05-03 21:45:40 +02:00
Bartłomiej Dach	7c04bf5c53	Refactor mod reference management to meet test expectations	2022-05-03 21:45:40 +02:00
Bartłomiej Dach	fe59f4ae58	Fix multiselection operation not flushing on close	2022-05-03 21:45:39 +02:00
Bartłomiej Dach	746a4a7403	Fix mod column using wrong equality type	2022-05-03 21:45:39 +02:00
Dean Herbert	2896612c5c	Make exiting multiplayer a dangerous operation, requiring hold	2022-05-03 16:06:04 +09:00
Dean Herbert	04fb0f5e63	Merge pull request #18063 from GSculerlor/split-searchbox ... Split `SearchTextBox` implementation for reusability	2022-05-03 14:12:44 +09:00
Huo Yaoyuan	7cf4dabe29	Fix IDE0005 and IDE0034	2022-05-03 13:09:19 +08:00
Dean Herbert	faeefc5e18	Merge pull request #16576 from frenzibyte/osu-distance-spacing ... Add "distance spacing" support in editor for osu! ruleset	2022-05-03 12:15:18 +09:00
Ganendra Afrasya	81be69e72e	Update search textbox implementation to use BasicSearchTextBox instead	2022-05-03 06:18:42 +07:00
Jai Sharma	a931b1ecc3	Show selected channel text as white in ChannelListItem	2022-05-02 22:32:25 +01:00
Jai Sharma	7f8e00c1e3	Change "Add more channels" to sentence case in "ChannelList"	2022-05-02 21:22:47 +01:00
Jai Sharma	1473762e25	Don't wrap "chatting in.." text in ChatTextBar	2022-05-02 20:57:39 +01:00
Jai Sharma	e6f1ac6bec	Ensure "chatting in..." text is aligned with chat message	2022-05-02 20:45:38 +01:00
Bartłomiej Dach	2b4a49e17f	Merge branch 'master' into move-difficulty-graph-toggle	2022-05-02 16:38:25 +02:00
Dean Herbert	c3e0ba5c8d	Fix clicking anywhere in the beatmap overlay dismissing it	2022-05-02 20:27:00 +09:00
Salman Ahmed	337ee8f4c7	Merge branch 'master' into fix-first-run-ui-scale-applying-rate-adjust	2022-05-02 12:14:24 +03:00
Dean Herbert	53d65e8215	Merge pull request #18021 from frenzibyte/overlay-ruleset-selector-redesign ... Update overlay ruleset selector inline with osu-web design	2022-05-02 17:53:01 +09:00
Dean Herbert	4b30d0e59b	Fix first-run overlay's song select applying track adjustments ... Closes https://github.com/ppy/osu/issues/18041.	2022-05-02 17:42:57 +09:00
Jai Sharma	4bd1d09148	Remove blank line	2022-05-01 12:20:11 +01:00
Jai Sharma	de393f735f	Implement basic layout and behaviour of new chat overlay ... Provides initial implementation of new chat overlay in component `ChatOverlayV2`. Contains only the basic functionality required for a functioning chat overlay according to the new design with the intent of added the rest of the functionality in subsequent PRs. Backports existing tests for the current chat overlay except for ones testing keyboard shortcuts (since they haven't been added) and tab closing behaviour (since no tabs).	2022-04-30 23:59:47 +01:00
Salman Ahmed	ba5da8a52a	Fix tooltips not shown on selected tab	2022-04-30 15:37:44 +03:00
Salman Ahmed	c7ab9a8928	Add ruleset tab item tooltips	2022-04-30 15:37:44 +03:00
Salman Ahmed	3996972867	Remove unnecessary f suffix	2022-04-30 12:23:08 +03:00
Dean Herbert	27ee990359	Update first-run overlay footer buttons to use new sheared design	2022-04-29 23:45:17 +09:00
Salman Ahmed	9ea3e244e7	Adjust ruleset tab item content spacing to match web ... Not too noticeable, but better match web in any case.	2022-04-29 12:48:09 +03:00
Salman Ahmed	4016fe1e19	Adjust profile ruleset selector to new design ... Looks weird with `AlwaysPresent`.	2022-04-29 12:19:55 +03:00
Salman Ahmed	3829d27845	Update overlay ruleset selector design	2022-04-29 12:19:22 +03:00
Salman Ahmed	fef94d49f4	Revert "Convert data type of DistanceSpacing to float" ... This reverts commit 7aaa88cac2.	2022-04-29 08:02:07 +03:00
Salman Ahmed	ef56dc07b5	Hide "modding" tab in user profile until it's implemented	2022-04-29 07:47:10 +03:00
Dean Herbert	c4495dafb6	Merge branch 'master' into move-difficulty-graph-toggle	2022-04-29 13:44:47 +09:00
Dan Balasescu	fc21de8138	Merge pull request #18008 from peppy/add-tutorial ... Add first run "beatmaps" screen	2022-04-29 13:10:45 +09:00
Dean Herbert	652e022fd6	Merge pull request #17973 from bdach/mod-overlay/dim-columns-offscreen ... Dim offscreen columns on new mod select overlay	2022-04-29 11:55:27 +09:00
Dean Herbert	845e7dba95	Reduce padding slightly to restore usability of UI scale screen	2022-04-29 11:27:14 +09:00
Dean Herbert	a75051cd00	Merge branch 'master' into add-tutorial	2022-04-29 11:25:17 +09:00
Bartłomiej Dach	96f6c918a8	Merge branch 'master' into first-run-behaviour-screen	2022-04-29 00:55:30 +02:00
Bartłomiej Dach	a748ad6426	Merge branch 'master' into first-run-header	2022-04-28 22:19:35 +02:00
Dean Herbert	a50dd2ae93	Fix rider failures in nullable	2022-04-28 20:15:40 +09:00
Dean Herbert	f300b62877	Add ScrollIntoView method which accepts an offset to allow usage in mod select	2022-04-28 20:03:54 +09:00
Dean Herbert	34457078eb	Merge pull request #18005 from nekodex/fix-missing-sfx ... Fix some missing/incorrect UI SFX	2022-04-28 19:45:59 +09:00
Dean Herbert	694f33b827	Add localisation of beatmaps screen	2022-04-28 19:33:16 +09:00
Dean Herbert	b6896376e7	Better signal when no beatmaps are loaded	2022-04-28 19:08:16 +09:00
Dean Herbert	88bfd5dece	Show current beatmap count on beatmap screen	2022-04-28 19:01:21 +09:00
Dean Herbert	4e0d70cbf4	Internalise bindable and progress handling to ensure transforms don't go backwards	2022-04-28 19:01:21 +09:00
Dean Herbert	9f6597695c	Only mark stable import complete if it actually completes	2022-04-28 19:01:21 +09:00
Dean Herbert	c860eb46b0	Split out button implementation into its own class	2022-04-28 19:01:21 +09:00
Dean Herbert	081275e0b9	Adjust text and layout	2022-04-28 19:01:21 +09:00
Dean Herbert	3c0bdcaf38	Rename screen, add tests and add stable import step	2022-04-28 19:01:21 +09:00
Dean Herbert	58399a5113	Add tutorial download support and improve the visuals "slightly"	2022-04-28 19:01:21 +09:00
Dean Herbert	973dd4bfa9	Add initial flow for download button / progress display	2022-04-28 19:01:21 +09:00
Dean Herbert	b042f1cad5	Add screen to perform bundled beatmap downloads	2022-04-28 19:01:21 +09:00
Dean Herbert	94a393c9d7	Merge branch 'master' into first-run-header	2022-04-28 19:00:12 +09:00
Salman Ahmed	691bec6f16	Use LocalisableString.Interpolate instead of invalid TranslatableStrings	2022-04-28 11:38:40 +03:00
Jamie Taylor	92cac0b74e	Fix TabControls using the wrong sample	2022-04-28 17:30:24 +09:00
Salman Ahmed	be2d616e34	Fix localisation use cases not falling back to default(LocalisableString) ... Previously such use cases have been returning `null` values just fine since `GetLocalisableString` was returning `LocalisableFormattableString`, and these null values were wrapped in `LocalisableString`s implicitly, therefore not requiring an explicit fallback string and `null` doesn't break anything.	2022-04-28 11:21:00 +03:00
Salman Ahmed	7aaa88cac2	Convert data type of DistanceSpacing to float	2022-04-28 10:24:36 +03:00
Dean Herbert	f3a0e2ed55	Increase fade duration	2022-04-28 14:59:39 +09:00
Dean Herbert	d0ccd6f895	Merge branch 'master' into first-run-header	2022-04-27 19:26:02 +09:00
Dean Herbert	e6bb5e84ec	Merge branch 'master' into move-difficulty-graph-toggle	2022-04-27 17:22:25 +09:00
Dean Herbert	1a345c06c6	Fix regression in nested scroll behaviour due to the top level scroll container's type changing	2022-04-27 17:10:27 +09:00
Dean Herbert	b29af28028	Fix mod panels not ignoring super key presses ... Most other usages have this included. Noticed that the panel was changing state when exiting the game using cmd-w. Would probably be nice to have an exposed `HasAnyModifierPressed` helper property.	2022-04-27 16:55:17 +09:00
Dean Herbert	18e6629161	Merge branch 'master' into first-run-behaviour-screen	2022-04-27 16:02:57 +09:00
Dean Herbert	0354dd5ce6	Add comment regarding section initialisation in ScreenBehaviour	2022-04-27 16:02:39 +09:00
Dean Herbert	0343687b85	Make apply default methods more explicit in behaviour	2022-04-27 15:59:39 +09:00
Bartłomiej Dach	a849bfcf60	Rewrite dim test to pass headless ... Unfortunately neuters the test a touch, but alas.	2022-04-26 23:11:41 +02:00
Bartłomiej Dach	921e8af3b0	Use more lenient column bounds for checking active state	2022-04-26 22:54:54 +02:00
Bartłomiej Dach	21377d2a4d	Fix inactive columns flickering on and off mid-scroll	2022-04-26 22:43:58 +02:00
Bartłomiej Dach	94d07e147f	Move dimming logic to custom scroll container	2022-04-26 22:37:40 +02:00
Bartłomiej Dach	e9c9c764ca	Fix column dim state changing when scrolling past extent	2022-04-26 22:26:58 +02:00
Bartłomiej Dach	13a36f2e51	Scroll to column when mouse is released rather than pressed	2022-04-26 22:01:24 +02:00
Bartłomiej Dach	b0d6e16658	Invert data flow in column dim implementation	2022-04-26 21:57:19 +02:00
Dean Herbert	280cd048f6	Fix joystick settings changing enabled state of config level bindables ... Just copied what we had in place for the mouse sensitivity setting. For tablet settings I believe I avoided this by just hiding the settings when not enabled. Might be a better way forward, but this is simplest for now. Run `TestSceneSettingsPanel` twice to get a crash without this change.	2022-04-26 17:31:28 +09:00
Dean Herbert	01fdb771ee	Add header text to first run setup screens	2022-04-26 16:22:41 +09:00
Dean Herbert	942f4e8ac2	Merge branch 'first-run-show-get-started' into first-run-behaviour-screen	2022-04-26 16:10:16 +09:00
Dean Herbert	a078440012	Show last step on back button as well	2022-04-26 16:03:17 +09:00
Dean Herbert	2c836e2d63	Fix scrollbar overlapping content	2022-04-26 15:55:32 +09:00
Dean Herbert	37ae39f5fe	Move "Next" localisation to common strings	2022-04-26 15:48:40 +09:00
Dean Herbert	71aa7c813e	Fix regressed logic for applying classic defaults	2022-04-26 15:33:39 +09:00
Dean Herbert	b41e273086	Convert function weirdness to property + bool	2022-04-26 15:06:27 +09:00
Bartłomiej Dach	e13d0d02ae	Use better way of calculating whether columns are fully on screen	2022-04-25 23:08:05 +02:00
Bartłomiej Dach	e384e074fb	Fix asymmetric margin of column scroll	2022-04-25 23:08:05 +02:00
Bartłomiej Dach	09c08248c4	Fix bounce when scrolling to first/last column	2022-04-25 23:08:05 +02:00
Bartłomiej Dach	ebc8429495	Dim offscreen columns & scroll to them if clicked	2022-04-25 23:08:04 +02:00
Dean Herbert	5e48b37569	Show "Get Started" text on first run button	2022-04-25 23:59:07 +09:00
Dean Herbert	07462384e8	Merge pull request #17930 from peppy/fix-song-select-music-control ... Fix nested song select in first-run dialog fiddling with global audio	2022-04-24 19:18:27 +09:00
Dean Herbert	d92c905600	Actually use exposed property	2022-04-24 18:15:35 +09:00
Dean Herbert	83970f009c	Merge branch 'master' into settings-filter-regression-fix-2	2022-04-24 17:40:25 +09:00
Dean Herbert	176d263252	Merge pull request #17942 from maromalo/master ... Add joystick/gamepad deadzone setting	2022-04-24 17:39:48 +09:00
Dean Herbert	c5e8f1d4ab	Merge pull request #17958 from peppy/fix-hide-case ... Remove localisation of "hide" string to fix incorrect case	2022-04-24 17:38:49 +09:00
Dean Herbert	66b47d22d7	Also fix case of login form username/password	2022-04-24 17:11:25 +09:00
Dean Herbert	1b2467d3ed	Disable first run screen from appearing on startup until it is more complete	2022-04-24 16:35:41 +09:00
Dean Herbert	2200067c52	Display deadzone as percentage and simplify surrounding code	2022-04-24 16:31:20 +09:00
Salman Ahmed	8ed39009fd	Encapsulate distance spacing control handling to a "distance toolbox composite" ... Encapsulated in a way which can allow further extensibility for the right-side area of toolboxes.	2022-04-24 08:33:03 +03:00
Salman Ahmed	4f8f27a58b	Merge branch 'master' into osu-distance-spacing	2022-04-24 05:23:30 +03:00
maromalo	5addcbf460	Changed KeyboardStep to 0.01	2022-04-23 13:16:20 -03:00
Dean Herbert	5d0842ac44	Add a few more classic defaults to missed settings	2022-04-23 21:53:47 +09:00
maromalo	6a87dfdabb	More Code Quality ... Double whoops.	2022-04-23 02:14:41 -03:00
maromalo	23ef1e194d	Code Quality ... Whoops.	2022-04-23 01:52:59 -03:00
maromalo	85c47e1ba7	Merge branch 'ppy:master' into master	2022-04-23 00:17:40 -03:00
maromalo	27f3499330	Add joystick/gamepad deadzone setting ... Also splits joystick/gamepad into a new sub-section.	2022-04-23 00:17:00 -03:00
Bartłomiej Dach	98b7b156c7	Merge branch 'master' into first-run-setup-sheared-overlay	2022-04-23 00:32:07 +02:00
Salman Ahmed	7be2596312	Fix MatchingFilter being false by default	2022-04-22 23:50:58 +03:00
Bartłomiej Dach	e246357b36	Merge branch 'master' into sheared-overlay-container-click-away	2022-04-22 22:26:35 +02:00
Salman Ahmed	5120faa830	Merge branch 'master' into mod-overlay/incompatibility-panels-clickable	2022-04-22 22:19:42 +03:00
Salman Ahmed	4c7c611218	Fix settings overlay not invalidating presence on filter change	2022-04-22 20:34:00 +03:00
Dean Herbert	1caee38768	Add first-run "behaviour" screen to allow users a choice of more familiar UX	2022-04-22 18:06:56 +09:00
Dean Herbert	e0b9ab022d	Add classic default values against setting controls	2022-04-22 18:05:24 +09:00
Dean Herbert	2a043aa6de	Add a method of finding and applying settings with classic default value	2022-04-22 18:04:43 +09:00
Dean Herbert	7258a09748	Allow SettingsSections to exit without a parent SettingsPanel	2022-04-22 18:04:07 +09:00
Dan Balasescu	b1cf917b49	Merge pull request #17823 from peppy/settings-filter-fixes ... Fix incorrect settings state if searching too quickly (during load process)	2022-04-22 16:38:41 +09:00
Dean Herbert	f735d381a7	Merge branch 'master' into mod-overlay/incompatibility-panels-clickable	2022-04-22 16:26:46 +09:00
Salman Ahmed	33d516eecb	Move guest participation beatmap up to below loved	2022-04-22 09:28:29 +03:00
Dean Herbert	82a1d1cc2e	Fix multiplier display not blocking input	2022-04-22 15:22:58 +09:00
Salman Ahmed	40d823bf69	Use localised string for guest participation beatmaps header	2022-04-22 09:18:46 +03:00
Salman Ahmed	2c21bd89e7	Display beatmap guest participations in user profile	2022-04-22 07:56:01 +03:00
Salman Ahmed	a9ea0ab91b	Add support for fetching user guest participations	2022-04-22 07:55:39 +03:00
Bartłomiej Dach	b7c11cdb8e	Deselect old incompatible mods if any on user mod select screen	2022-04-21 23:49:30 +02:00
Bartłomiej Dach	32722adba9	Allow mod panels to be clicked in incompatible state	2022-04-21 23:37:01 +02:00
Bartłomiej Dach	8fe4443029	Update screen method signatures to match framework API changes	2022-04-21 22:29:23 +02:00
Bartłomiej Dach	8c6864727e	Merge branch 'master' into first-run-setup	2022-04-21 22:14:57 +02:00
Dean Herbert	749b86f0f4	Use new framework exposed event instead of schedule	2022-04-22 00:55:17 +09:00
Dean Herbert	119a81849c	Merge branch 'update-framework' into settings-filter-fixes	2022-04-22 00:55:15 +09:00
Dean Herbert	832d37b2c2	Update screen transition events to use new event args	2022-04-22 00:52:44 +09:00
Dean Herbert	ed6481f708	Also rename Welcome to WelcomeTitle to match other usages	2022-04-21 19:55:51 +09:00
Dean Herbert	1f967ecba3	Update string keys and change "setup" to "set up" to fix grammar	2022-04-21 19:52:28 +09:00
Dean Herbert	d17c16d904	Merge branch 'master' into first-run-setup	2022-04-21 19:50:26 +09:00
Dean Herbert	55270df6fc	Merge pull request #17833 from jai-x/new-chat-channel-list ... Implement `ChannelList` for new chat design	2022-04-21 16:34:35 +09:00
Dean Herbert	0b81ae9de2	Convert to using sheared overlay container ... Add better click-to-dismiss logic for sheader overlays	2022-04-21 16:28:44 +09:00
Dean Herbert	5c21a55e00	Merge branch 'sheared-overlay-container-click-away' into first-run-setup-sheared-overlay	2022-04-21 16:28:33 +09:00
Dean Herbert	0f4b40ab15	Add better click-to-dismiss logic for sheared overlays	2022-04-21 16:27:27 +09:00
Dean Herbert	7d8cf1bbb6	Merge branch 'master' into first-run-setup	2022-04-21 15:49:39 +09:00
Dan Balasescu	54ca4b9d36	Remove unused using	2022-04-21 15:34:14 +09:00
Dean Herbert	5c0e5eb6f4	Merge pull request #17899 from Joehuu/localise-most-strings ... Use existing web localisation for most hardcoded strings	2022-04-21 14:48:12 +09:00
Dean Herbert	9f525ee267	Revert localisation of spectate/watch button	2022-04-21 14:09:51 +09:00
Dean Herbert	56d8de23e2	Replace horse with "more suitable" icon ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2022-04-21 12:18:54 +09:00
Joseph Madamba	5e5c8e78a6	Use existing web localisation for most hardcoded strings	2022-04-20 16:31:11 -07:00
Jai Sharma	5319bce772	Revert DI usage of ChannelSelectorState in favour of directly binding BindableBool SelectorActive	2022-04-20 21:05:33 +01:00
Jai Sharma	e596c9d171	Use Bindable<ChannelSelectorState> to control selector active visibility	2022-04-20 19:12:43 +01:00
Dean Herbert	4466e15bfc	Rename AllowConfiguration to AllowCustomisation and simplify drawable addition	2022-04-20 23:17:29 +09:00
Dean Herbert	b722ff8dc5	Merge branch 'master' into mod-overlay/extension-points	2022-04-20 23:17:04 +09:00
Dean Herbert	8c2d70e93f	Disable forward button when already at end	2022-04-20 17:50:31 +09:00
Dean Herbert	65b2db5e71	Move shear constant to overlay (this is going to likely be used everywhere ever)	2022-04-20 16:30:58 +09:00
Dean Herbert	e17f224793	Fix padding mismatches	2022-04-20 16:28:52 +09:00
Dean Herbert	5c7ff363ce	Move title/description to correct class	2022-04-20 16:08:00 +09:00
Dean Herbert	2ee37aeceb	Reduce nesting and usage of GridContainer	2022-04-20 16:01:15 +09:00
Dean Herbert	1032dc235d	Rename PopupScreenTitle to ShearedOverlayHeader	2022-04-20 16:01:15 +09:00
Dean Herbert	8d31b0bc01	Split out the base design of sheared overlay into its own abstract class ... This will allow for reuse with the first-run overlay.	2022-04-20 15:50:16 +09:00
Dean Herbert	66373bf038	Move back button enable handling to shared method	2022-04-20 14:50:41 +09:00
Dean Herbert	9797e2d887	Rename showLastStep method to avoid ambiguity	2022-04-20 14:49:17 +09:00
Dean Herbert	488fc9db67	Reverse content colours to match design spec	2022-04-20 14:48:51 +09:00
Bartłomiej Dach	f82d58fa6a	Merge branch 'master' into update-paginated-profile-items-count	2022-04-19 22:17:26 +02:00
Jai Sharma	44c822f34d	Use normal OsuScrollContainer for ChannelList	2022-04-19 16:56:55 +01:00
Dean Herbert	ce70c10afa	Tidy up unused dependencies	2022-04-19 18:00:39 +09:00
Dean Herbert	17eaa44af1	Ensure notifications don't interrupt the first run setup process	2022-04-19 17:40:35 +09:00
Dean Herbert	e2da1d76ca	Only show first run setup once per install	2022-04-19 16:59:25 +09:00
Dean Herbert	3378c91901	Fix double applied padding	2022-04-19 16:59:04 +09:00
Dean Herbert	1490502d4c	Improve overall usability of scale adjust screen	2022-04-19 16:59:04 +09:00
Dean Herbert	c27831145c	Add scroll and flow at the FirstRunSetupScreen level	2022-04-19 16:37:29 +09:00
Dean Herbert	6d534046ff	Add keyboard traversal support for first run dialog (and tidy up step traversal logic)	2022-04-19 14:57:15 +09:00
Dean Herbert	e67cc293b8	Add localisation support for all new strings	2022-04-19 14:53:01 +09:00
Dean Herbert	5dc3805005	Fix stack nullability	2022-04-19 14:53:01 +09:00
Dean Herbert	02f8367d66	Improve animation when showing/hiding first run overlay	2022-04-19 14:53:01 +09:00
Dean Herbert	2682373bf2	Use existing blocking / exit logic provided by OsuFocusedOverlayContainer	2022-04-19 14:53:01 +09:00
Dean Herbert	9074eb283d	Show a notification instead of blocking exit of wizard	2022-04-19 14:53:01 +09:00
Dean Herbert	3ea4eabdb6	Ensure button text is updated on going backwards	2022-04-19 14:53:01 +09:00
Dean Herbert	fb7dc89503	Ensure wizard returns to initial screen after completion	2022-04-19 14:53:01 +09:00
Dean Herbert	6716621444	Re-fix clicking inside display also dismissing	2022-04-19 14:53:01 +09:00
Dean Herbert	11395c40b7	Add button to access first run setup on demand	2022-04-19 14:53:01 +09:00
Dean Herbert	ea52fab5b1	Tidy up dependencies and test naming	2022-04-19 14:53:01 +09:00
Dean Herbert	56c4283764	Only exit dialog from click if outside the dialog content	2022-04-19 14:53:01 +09:00
Dean Herbert	288f759bb4	Add test coverage of navigation	2022-04-19 14:53:01 +09:00
Dean Herbert	07da1cd731	Move buttons to top level and add backwards navigation	2022-04-19 14:53:01 +09:00
Dean Herbert	3b94e01fe6	Improve layout of ui scale step	2022-04-19 14:53:01 +09:00
Dean Herbert	e064f2f23e	Improve general layout and allow overlay to be displayed without dependencies for now	2022-04-19 14:53:01 +09:00
Dean Herbert	c2df3465b2	Add ui scaling setup screen, kind of	2022-04-19 14:53:01 +09:00
Dean Herbert	ae07b2b512	Initial setup	2022-04-19 14:53:01 +09:00
Dean Herbert	83e89b3e80	Add unread count to INotificationOverlay and fix toolbar button DI logic	2022-04-19 11:16:45 +09:00
Salman Ahmed	c858ec2483	Pagination -> `PaginationParameters	2022-04-19 02:48:34 +03:00
Salman Ahmed	96d4369cc8	Introduce Pagination and simplify paginated API requests	2022-04-19 02:04:23 +03:00
Dan Balasescu	bb8b94f8ad	Merge branch 'master' into i-notification-overlay	2022-04-19 06:03:56 +09:00
Dan Balasescu	94e892df1c	Merge pull request #17862 from peppy/i-dialog-overlay ... Split out `IDialogOverlay` to allow for easier testing	2022-04-19 05:24:05 +09:00
Salman Ahmed	f08449e432	Update paginated profile subsections to display items inline with web	2022-04-18 23:04:21 +03:00
Salman Ahmed	1fc28552b5	Minor reword inline comment	2022-04-18 21:07:20 +03:00
Salman Ahmed	16a0efc562	Cache IDialogOverlay as its type in interface	2022-04-18 21:06:27 +03:00
Dean Herbert	5d5e46ede7	Fix rider incompetency	2022-04-18 23:10:07 +09:00
Dean Herbert	aaf5577e6a	Remove unnecessary canBeNull specification	2022-04-18 21:48:46 +09:00
Dean Herbert	d29312e070	Fix rider incompetency	2022-04-18 21:47:47 +09:00
Dean Herbert	043599081b	Split out INotificationOverlay to allow for easier testing	2022-04-18 20:14:01 +09:00
Dean Herbert	e315313266	Split out IDialogOverlay to allow for easier testing	2022-04-18 18:36:26 +09:00
Dean Herbert	2202863e1a	Split out IPerformFromScreenRunner to allow for easier testing	2022-04-18 17:49:28 +09:00
Bartłomiej Dach	0d5ce336f4	Hide mod customisation toggle if customisation not permitted	2022-04-17 23:28:53 +02:00
Bartłomiej Dach	881df7663d	Fix filter not taking effect if applied before panel load completion	2022-04-17 23:28:53 +02:00
Bartłomiej Dach	8af865a1c5	Fix incompatibility panel using reference equality	2022-04-17 23:28:53 +02:00
Bartłomiej Dach	ffb5c1e86c	Tweak colours on incompatibility displaying mod panel	2022-04-17 23:28:52 +02:00
Bartłomiej Dach	20c17b8c98	Make base mod select screen abstract	2022-04-17 23:28:51 +02:00
Bartłomiej Dach	7eebc20124	Add replacements for mod overlays used by game	2022-04-17 23:28:51 +02:00
Bartłomiej Dach	67c44db8d5	Add extension points required for replacing old mod overlay	2022-04-17 23:28:51 +02:00
Jai Sharma	47c8b8010f	Use semibold font weight for ChannelListItemFlow label	2022-04-16 23:03:03 +01:00
Jai Sharma	2f41cddb00	Remove redundant Expire call	2022-04-16 23:03:03 +01:00
Jai Sharma	36aea9009e	Move ChannelList scrollbar to the right	2022-04-16 23:03:03 +01:00
Jai Sharma	4a0c5a0781	Remove hover override for ChannelListScrollContainer	2022-04-16 23:02:54 +01:00
Bartłomiej Dach	15c54b38c1	Merge branch 'master' into fix-popup-dialog-handling-exit-sequence	2022-04-16 19:01:18 +02:00
Jai Sharma	b6631fb9f9	Add newline for base class call	2022-04-15 22:22:20 +01:00
Jai Sharma	a0a2f8118e	Code quality fixes	2022-04-15 22:05:20 +01:00
Jai Sharma	f1dd319fd9	Implement ChannelList for new chat design ... Reference design: https://www.figma.com/file/f8b2dHp9LJCMOqYP4mdrPZ/Client%2FChat?node-id=1%3A297 Adds new component `ChannelList` which makes up the sidebar channel selector of the new chat design. Contains two separate fill flows for public and private `ChannelItem` child components. Exposed bindable `SelectorActive` to indicate current state of the "Add more channels" button. Requires `Bindable<Channel>` from parent component. Renames and updates the `TestSceneChannelListItem` to `TestSceneChannelList` to make use of new component and having both tests seemed redundant.	2022-04-15 15:44:38 +01:00
Dean Herbert	423fae52f7	Add back base.IsPresent call	2022-04-15 10:19:36 +09:00
Dean Herbert	c57a918bbb	Mark settings elements as matching filter by default to handle cases where no filtering is provided	2022-04-14 23:02:00 +09:00
Salman Ahmed	da098d071f	Merge branch 'master' into settings-inactive-dim	2022-04-14 15:52:51 +03:00
Dean Herbert	b088959045	Reduce settings fade in duration to higher alpha/colour cross-talk	2022-04-14 21:17:06 +09:00
Dean Herbert	9240148c8e	Avoid initial fade of dim layer	2022-04-14 21:16:54 +09:00
Dean Herbert	f19208a245	Move dim layer to top and only apply dimming at one location	2022-04-14 21:04:52 +09:00
Dean Herbert	316c0845ec	Fix current section not being correct after early search	2022-04-14 20:36:49 +09:00
Dean Herbert	9c7af98982	Fix alpha cross-talk causing settings to potentially not filter when they should	2022-04-14 20:35:00 +09:00
Dean Herbert	296420ae08	Fix settings textbox focus operation running too late	2022-04-14 20:14:02 +09:00
Salman Ahmed	59bb6b8f7c	Add background dim effect to inactive settings sections	2022-04-14 13:43:12 +03:00
Salman Ahmed	566a20a623	Add keyword "delay" to hold-to-confirm activation time setting	2022-04-14 13:27:12 +03:00
Dean Herbert	1fdf742d38	Fix potentially incorrect button being pressed during PopupDialog hide due to flag set too late	2022-04-14 17:51:50 +09:00
Dean Herbert	f9d9e6aa61	Ensure popup dialogs are hidden before running any associated actions	2022-04-14 16:19:34 +09:00
Dan Balasescu	494955aff1	Resolve inspection issues	2022-04-14 13:11:11 +09:00
Salman Ahmed	bad30d9e60	Fix dialog dangerous button being clickable at edges	2022-04-11 21:05:37 +03:00
Salman Ahmed	134d9b5ddf	Perform Show() at the bottom of the method ... Probably not affecting behaviour, but makes more sense.	2022-04-08 19:28:04 +03:00
Dean Herbert	57fb8616b8	Fix potential null reference when attempting to highlight a message before overlay has been displayed	2022-04-09 00:31:00 +09:00
Dean Herbert	ae1e126837	Make HighlightMessage implicitly show chat overlay	2022-04-09 00:30:28 +09:00
Bartłomiej Dach	e658b63dbc	Merge branch 'master' into clock	2022-04-07 20:27:23 +02:00
Salman Ahmed	a616f5bc2a	Fix regressed digital clock width conditional	2022-04-07 19:24:15 +03:00
Salman Ahmed	c323020fcf	Fix Use24HourDisplay conditional flipped	2022-04-07 15:56:28 +03:00
Dean Herbert	b2c0eaeab4	Make string read better	2022-04-07 18:20:15 +09:00
Dean Herbert	555aee7b6a	Remove incorrect and pointless complexity to width changes	2022-04-07 18:16:14 +09:00
Dean Herbert	7530fe5adf	Move default specification to configuration initial value	2022-04-07 18:13:23 +09:00
Dean Herbert	37509e04a9	Rename variable and fix inspections	2022-04-07 18:11:30 +09:00
Perry MacMurray	2525ec0d18	Switch 24H toggle from UI settings to language settings	2022-04-05 17:07:58 -04:00
Perry MacMurray	9d475f7b33	Add config in settings for forcing 24H time, determines default off CurrentCulture	2022-04-05 16:21:28 -04:00
Bartłomiej Dach	9c91e6d8f5	Merge branch 'master' into mod-overlay/full-screen	2022-04-05 21:29:40 +02:00
Perry MacMurray	74706f72e6	Add 12-hour display setting (TODO add toggle)	2022-04-05 15:10:55 -04:00
Dean Herbert	ac799aaf7a	Add missing newline	2022-04-05 19:25:47 +09:00
Dean Herbert	32daf64a31	Use newly exposed framework helper function to find closest parent	2022-04-05 19:24:34 +09:00
Dean Herbert	631aa2a6ec	Remove left padding to allow left-most column to exist further to the.. left	2022-04-05 18:44:25 +09:00
Dean Herbert	54715885af	Adjust animation metrics slightly	2022-04-05 18:41:01 +09:00
Dean Herbert	7a1820e6bb	Fix multiplier display resetting transformations	2022-04-05 18:40:48 +09:00
Dean Herbert	9fdeb20537	Animate individual ModColumns during togle of oerlay	2022-04-05 18:27:34 +09:00
Dean Herbert	901032bfa2	Animate multiplier display	2022-04-05 18:25:27 +09:00
Dan Balasescu	2b59f76b2d	Merge pull request #17596 from peppy/skin-editor-sprites ... Allow importing sprites into a skin via drag-and-drop	2022-04-05 17:38:58 +09:00
Dean Herbert	497e5e3a36	Slightly adjust scroll handling and also apply to ModSettingsContainer	2022-04-05 17:19:33 +09:00
Dean Herbert	a408776734	Limit FillFlow of columns to applicable direction	2022-04-05 17:15:05 +09:00
Dean Herbert	388322cd61	Speed up customisation panel toggle a bit	2022-04-05 16:56:24 +09:00
Dean Herbert	58e9147b12	Simplify and better comment nested scroll conditionals	2022-04-05 16:48:25 +09:00
Dean Herbert	f156cb797d	Improve nested scroll behaviour	2022-04-05 16:46:09 +09:00
Dean Herbert	23dad7bdc4	Move scroll view padding to content level ... Without doing this, there is a non-masked but also non-interactive area to the left or right of the view.	2022-04-05 16:43:00 +09:00
Bartłomiej Dach	9b367d645d	Always play pop in sequence	2022-04-04 20:02:47 +02:00
CenTdemeern1	9a07a95d39	Make several delete confirmation buttons dangerous buttons ... Includes: - Mass deletion - Beatmap deletion - Local score deletion	2022-04-04 19:22:53 +02:00
Dean Herbert	57b8c32f25	Remove unused fields	2022-04-04 20:42:14 +09:00
Dean Herbert	bc53adb72a	Adjust customisation transition slightly	2022-04-04 15:50:40 +09:00
Dean Herbert	b5df350007	Adjust pop in/out transitions	2022-04-04 15:45:44 +09:00
Dean Herbert	d6625413fa	Merge pull request #17617 from ajiiisai/proper-toggable-shortcuts-for-overlays ... Make overlay shortcuts able to be toggled instead of repeatable	2022-04-04 13:46:42 +09:00
Bartłomiej Dach	cd776d21a6	Fix propagation of selected mods to columns	2022-04-03 20:12:34 +02:00
Bartłomiej Dach	e46c2df409	Add testing for customisation panel show/hide logic	2022-04-03 20:12:33 +02:00
Bartłomiej Dach	293ef44836	Implement new mod select screen	2022-04-03 20:12:33 +02:00
Bartłomiej Dach	1393e3628b	Invert operands for better readability	2022-04-03 15:24:00 +02:00
Dean Herbert	969f7e121a	Merge pull request #17545 from jai-x/new-chat-textbox ... Implement `ChatTextBox` for new chat design	2022-04-03 22:12:12 +09:00
Bartłomiej Dach	970b1951ac	Rewrite logic slightly to better convey meaning of textbox clear	2022-04-03 14:26:08 +02:00
Jai Sharma	94fa5e2ef2	Use Action<string> for event OnChatMessageCommitted & clear textbox internally	2022-04-02 21:58:54 +01:00
Ame	35629e9be8	General fix for ToolbarButton toggle repetition	2022-04-02 20:45:00 +02:00
Bartłomiej Dach	28ba437d24	Merge branch 'master' into sucess-rate-tooltip	2022-04-02 19:31:45 +02:00
Jai Sharma	9e152cd3fd	Fix code quality issues	2022-04-02 17:27:44 +01:00
Jai Sharma	2297073b7e	Use OnChatMessageCommit & OnSearchTermsChanged events in ChatTextBar	2022-04-02 17:15:19 +01:00
Jai Sharma	b9421d1415	Simplify text clear and placeholder change in ChatTextBox	2022-04-02 17:14:27 +01:00
Salman Ahmed	beb8426d3b	Save beatmap listing card size to game config	2022-04-02 18:36:49 +03:00
Salman Ahmed	ced5be33e6	Display pass/play count in success rate percentage tooltip	2022-04-02 18:08:57 +03:00
Dean Herbert	6afed5e865	Fix new SettingsItem attribute not playing well with non-Drawables	2022-04-01 16:01:33 +09:00
Dean Herbert	66f5eae530	Hook up a dropdown to show all available sprites for the current skin	2022-04-01 15:01:43 +09:00
Joseph Madamba	d0873d67e1	Move difficulty graph toggle to individual skin settings	2022-03-31 18:56:57 -07:00
CenTdemeern1	86d262a355	Merge branch 'ppy:master' into clock-button	2022-03-31 23:08:30 +02:00
CenTdemeern1	bdb21b17f7	Fix my code according to the changes @bdach requested	2022-03-31 20:39:26 +02:00
CenTdemeern1	c64a90b39e	Remove a newline to comply with codefactor	2022-03-31 17:21:50 +02:00
CenTdemeern1	f1aa60c0f1	Make the clock feel more like a button	2022-03-31 16:26:53 +02:00
Dean Herbert	0a34ce2509	Increase font weight for runtime clock ... Fonts this small are required to be `SemiBold` by design guidelines. Somehow missed this.	2022-03-31 19:07:30 +09:00
Dean Herbert	e8a295a61b	Add test coverage of textbox focus in settings panels when switching between nested panels	2022-03-31 15:24:21 +09:00
Jai Sharma	fff30e8a6e	Simplify show/hide of text and search in ChatTextBar	2022-03-30 21:02:12 +01:00
Bartłomiej Dach	9621a7f9cb	Merge branch 'master' into fix-autoplay-mod-user-id	2022-03-30 21:41:45 +02:00
Jai Sharma	eec3fef7a6	Remove the enter box in ChatTextBar	2022-03-30 20:25:23 +01:00
Dean Herbert	975883da5c	Move all usages of client.realm filename to a single const	2022-03-30 13:34:48 +09:00
Jai Sharma	e7d2d94eee	Fix code quality issues in ChatTextBar	2022-03-30 02:16:50 +01:00
Jai Sharma	f049d7cb67	Implement ChatTextBox for new chat design ... Reference design: https://www.figma.com/file/f8b2dHp9LJCMOqYP4mdrPZ/Client%2FChat?node-id=1%3A297 Adds new component `ChatTextBox`. Exposes `BindableBool` `ShowSearch` to change text input behaviour between normal and search behaviour. Adds new component `ChatTextBar`. Exposes `BindableBool` `ShowSearch` which toggles between showing current chat channel or search icon. Additionally binds to child `ChatTextBox` components. Requires a cached `Bindable<Channel>` instance to be managed by a parent component.	2022-03-29 22:33:38 +01:00
Dean Herbert	4741679a94	Change confirmation message to be more clear about intentions ... Co-authored-by: Henry Lin <henry.ys.lin@gmail.com>	2022-03-29 19:03:50 +09:00
Dean Herbert	1fb3d11591	Add ability to "migrate" data to another folder which has an existing install ... Until now, migrating would always attempt to move files. There's a chance that a user is reinstalling osu! but has their data at a custom location. We want to allow the chance for them to continue using the external data. This seems like the easiest way to make it work. Would be nice if we had a `Game.Restart()` method, but maybe this is enough for now? Note that further down the road we will probably prompt the user to potentially select a custom install path (including one with existing data) before osu! gets to writing anything.	2022-03-29 18:04:31 +09:00
Dean Herbert	dc7dc7f65a	Update UserProfileOverlay and ClickableAvatar to treat system users more correctly	2022-03-28 22:57:16 +09:00
Salman Ahmed	b6822f8190	Remove redundant/outdated Origin line	2022-03-26 14:55:19 +03:00
Dean Herbert	9b7b897b3c	Adjust padding to fit better	2022-03-26 20:34:50 +09:00
Dean Herbert	ab8db3b7dc	Move nested classes to own files	2022-03-26 20:34:17 +09:00
Dean Herbert	4ddf3cb1d9	Add ability to cycle between clock display modes	2022-03-26 19:18:41 +09:00
Dean Herbert	97e9049a2c	Adjust metrics and colours to better match the actual toolbar	2022-03-26 18:56:40 +09:00
Dean Herbert	252d1924e7	Adjust metrics for better legibility at small sizes	2022-03-26 18:13:33 +09:00
Dean Herbert	999ae88af2	Show game time display in clock	2022-03-26 18:13:20 +09:00
Dean Herbert	e8f5a8e3d6	Refactor hands for legibility (visual and code)	2022-03-26 18:13:13 +09:00
Dean Herbert	0d8a7246dd	Add basic implementation of clock	2022-03-26 18:13:13 +09:00
Dean Herbert	1acfbf490b	Merge branch 'master' into mod-overlay/settings-area	2022-03-25 17:37:39 +09:00
Dean Herbert	2938f44e6c	Update PresentExternally usages in line with framework changes	2022-03-24 23:41:07 +09:00
Bartłomiej Dach	8647bebdca	Merge branch 'master' into hold-to-discard-changes	2022-03-22 20:37:43 +01:00
Bartłomiej Dach	8192fb47fe	Merge branch 'master' into skin-editor-eat-input	2022-03-22 19:22:48 +01:00
Dean Herbert	f95bd89166	Revert editor exit behaviour to exit without changes for now	2022-03-22 14:46:57 +09:00
Dan Balasescu	aea03ca21d	Merge pull request #17359 from frenzibyte/fix-score-panel-max-combo ... Improve method of retrieving beatmap maximum combo for results score panels	2022-03-22 06:28:30 +09:00
Dean Herbert	2f18c512cd	Convert SkinEditorOverlay to an OverlayContainer to allow it to block input	2022-03-21 17:33:56 +09:00
Dean Herbert	b42081dd9b	Add DangerousButton for use in popup dialogs	2022-03-21 16:06:45 +09:00
Dean Herbert	3bb01fd595	Fix close button animation not being applied correct on mouse down due to conflicting scales	2022-03-21 14:41:57 +09:00
Dean Herbert	7ca3beb7cc	Also add fade to ChannelItem selected box	2022-03-21 14:41:42 +09:00
Dean Herbert	428e439f40	Remove space between '#' and channel name ... This was in flyte's design (he was following discord) but doesn't feel too correct when it's not aligned with anything else. We can revisit this if/when we have better glyphs to represent channel types.	2022-03-21 14:36:56 +09:00
Dean Herbert	16caf2d30b	Add slight animation when highlighting an unread channel	2022-03-21 14:34:54 +09:00
Dean Herbert	692362131e	Add animation when mention pill appears (or a new message arrives)	2022-03-21 14:31:51 +09:00
Dean Herbert	11b050b66b	Add slight fade when hovering ChannelListItems	2022-03-21 14:28:14 +09:00
Dean Herbert	9eda2f2df1	Remove box surrounding close button	2022-03-21 14:25:29 +09:00
Dean Herbert	f922a6b556	Rename renaming button/pill classes	2022-03-21 14:15:22 +09:00
Dean Herbert	812343b410	Merge branch 'master' into new-chat-channel-control	2022-03-21 14:14:02 +09:00
Salman Ahmed	b9859f9f21	Obsolete BeatmapInfo.MaxCombo and suppress in usages	2022-03-20 16:30:29 +03:00
Jai Sharma	f3702fbefb	Pass correct params to UpdateableAvatar ctor in ChannelListItem	2022-03-19 22:20:17 +00:00
Jai Sharma	ba5a43b526	Rename ControlItem -> ChannelListItem and associated classes	2022-03-19 21:49:14 +00:00
Jai Sharma	653bb47dd5	Use UpdateableAvatar and remove redundant ControlItemAvatar class	2022-03-19 21:36:11 +00:00
Jai Sharma	5373c3066f	Use OsuAnimatedButton as base for ControlItemClose	2022-03-19 21:23:32 +00:00
Jai Sharma	a293e0c766	Remove redundant ControlItemText class	2022-03-19 16:44:58 +00:00
Dean Herbert	dfda093f4b	Rename icon creation method	2022-03-18 14:03:52 +09:00
Dean Herbert	5d940ded09	Fix incorrect usage of nullable in ControlItemMention	2022-03-18 13:59:03 +09:00
Dean Herbert	d1fd14e287	Add missing nullable	2022-03-18 13:57:36 +09:00
Salman Ahmed	7aae9bbd1b	Improve channel bindable logic in ChatOverlay to avoid potential nullrefs	2022-03-17 08:31:38 +03:00
Bartłomiej Dach	624f9fc774	Implement mod settings area component	2022-03-16 23:13:11 +01:00
Bartłomiej Dach	b21fa78cbf	Move dependencies out of fields to BDL args where possible	2022-03-16 21:55:36 +01:00
Dean Herbert	603527d72d	Fix potential crash when highlighting chat messages ... Test failed locally in `TestPublicChannelMention`. This test seems to specify that the same message may arrive twice with the same ID, so rather than overthinking this one I propose we just use `FirstOrDefault`. ```csharp TearDown : System.AggregateException : One or more errors occurred. (Sequence contains more than one matching element) ----> System.InvalidOperationException : Sequence contains more than one matching element --TearDown at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions) at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken) at osu.Framework.Extensions.TaskExtensions.WaitSafely(Task task) at osu.Framework.Testing.TestScene.checkForErrors() --InvalidOperationException at System.Linq.ThrowHelper.ThrowMoreThanOneMatchException() at System.Linq.Enumerable.TryGetSingle[TSource](IEnumerable`1 source, Func`2 predicate, Boolean& found) at System.Linq.Enumerable.SingleOrDefault[TSource](IEnumerable`1 source, Func`2 predicate) at osu.Game.Overlays.Chat.DrawableChannel.<processMessageHighlighting>b__14_0() in /Users/dean/Projects/osu/osu.Game/Overlays/Chat/DrawableChannel.cs:line 102 at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal() ```	2022-03-16 18:38:06 +09:00
Jai Sharma	e38d9eafa0	Use BindTarget instead of caching for ControlItem unread flow	2022-03-15 22:37:15 +00:00
Jai Sharma	49b74d7867	Use BindTarget instead of caching for ControlItem mentions bindable flow	2022-03-15 22:33:36 +00:00
Jai Sharma	481b8fe80b	Use Orange1 for ControlItemMention background colour	2022-03-15 22:22:32 +00:00
Jai Sharma	7621e779fa	Move ControlItem Action assignments into BDL	2022-03-15 22:19:58 +00:00
Jai Sharma	73a0373b4e	Code quality fixes	2022-03-14 21:56:56 +00:00
Jai Sharma	ec61b88ec2	Adjust ControlItem padding	2022-03-14 21:39:57 +00:00
Jai Sharma	75958bf270	Refactor ControlItemText to use bindable flow for unread state	2022-03-14 21:32:30 +00:00
Jai Sharma	b01a809d55	Refactor ControlItemMention to use bindable flow	2022-03-14 21:26:33 +00:00
Jai Sharma	1f0f6990f0	Use ColourProvider.Content1 for ControlItemText colour	2022-03-14 21:16:28 +00:00
Jai Sharma	3aa343b987	Use OsuColour.YellowLight for ControlItemMention background	2022-03-14 21:14:33 +00:00
Jai Sharma	9621ef9437	Use OsuColour.Red1 for ControlItemClose hover colour	2022-03-14 21:10:39 +00:00
Jai Sharma	e91af664ef	Adjust ControlItemAvatar placeholder animation and colour	2022-03-14 20:37:54 +00:00
Jai Sharma	12472593cc	Mark required dependencies as non-nullable	2022-03-14 20:14:04 +00:00
Jai Sharma	c0d82dfb41	Code quality fixes	2022-03-14 19:42:55 +00:00
Jai Sharma	39c30516d0	Implement ChannelControlItem for new chat design ... Adds new component `ChannelControlItem` and it's child components to be used as the clickable control in the new chat sidebar for joined channels. Has public properties `HasUnread` and `MentionCount` to control the display of the channel having unread messages or mentions of the user. Channel select/join requests are exposed via `OnRequestSelect` and `OnRequestLeave` events respectively which should be handled by a parent component. Requires a cached `Bindable<Channel>` instance to be managed by a parent component. Requires a cached `OveralayColourScheme` instance to be provided by a parent component.	2022-03-14 18:55:27 +00:00
Salman Ahmed	53c57661c7	Move implementtaion detail to inline comment	2022-03-11 18:34:22 +03:00
Salman Ahmed	5b70139b33	Avoid running message highlight processing more than once	2022-03-11 18:32:49 +03:00
Salman Ahmed	cc87563d57	Merge branch 'master' into chat-mention-highlight	2022-03-11 17:51:22 +03:00
Salman Ahmed	d07e3101ea	Improve message highlight handling in DrawableChannel	2022-03-10 23:07:15 +03:00
Salman Ahmed	a31611bdec	Improve channel switching flow in HighlightMessage	2022-03-10 23:07:15 +03:00
Salman Ahmed	5315ff794a	Handle non-existing channels on message highlighting gracefully	2022-03-10 21:29:32 +03:00
Salman Ahmed	717ddbba4e	Fix skin components toolbox not autosizing properly	2022-03-10 16:30:20 +03:00
Dean Herbert	46f2db1712	Move ChannelListingItem spacing into item so input is always handled by an item in the list ... Without this change, there would be a couple of pixels between each list item where nothing would be hovered. This is a pretty annoying UX which we should be avoiding we possible.	2022-03-10 15:58:57 +09:00
Dean Herbert	1a187d4dec	Add animation to checkbox when joning/leaving a channel	2022-03-10 15:54:42 +09:00
Dean Herbert	0155519343	Merge branch 'master' into new-chat-channel-listing	2022-03-10 15:49:06 +09:00
Dean Herbert	022dd88aef	Merge branch 'master' into chat-mention-highlight	2022-03-10 14:23:23 +09:00
Salman Ahmed	b25c37ce62	Instantiate highlight background container on animation ... Also removes the necessity of scheduling as it actually never worked as intended, `Scheduler` will still update even when the chat line is masked away, and the animation will never be held anyways. The new duration of the animation should be enough for long scrolls either way.	2022-03-10 03:49:42 +03:00
Salman Ahmed	cf9671cafb	Increase highlight delay to 1500ms	2022-03-10 02:50:15 +03:00
Salman Ahmed	80c0df6af5	Scroll chat line to channel center ... We may eventually want that encapsulated within `ScrollIntoView`, as it would also come in handy for `GameplayLeaderboard`.	2022-03-10 02:50:15 +03:00
Salman Ahmed	93cf93943f	Schedule chat line highlight after children to handle non-loaded lines	2022-03-10 02:48:33 +03:00
Salman Ahmed	2d8983383a	Revert newMessagesArrived changes and always schedule highlight ... In the case a message arrives and the chat overlay is hidden, clicking on the mention notification will not work as the `HighlightedMessage` bindable callback will execute before the scheduled `newMessagesArrived` logic (which was hanging since the message arrived until the chat overlay became open because of the notification). Simplify things by always scheduling the `HighlightedMessage` bindable callback.	2022-03-10 01:11:27 +03:00
Jai Sharma	b67f9269f9	Remove NewChat namespace	2022-03-09 18:13:56 +00:00
Dean Herbert	affcf5180b	Merge pull request #17161 from smoogipoo/fix-listing-score-conversion ... Fix scores not being recalculated in beatmap overlay	2022-03-09 13:32:45 +09:00
Dean Herbert	58aef25ad5	Merge pull request #17152 from bdach/mod-overlay/difficulty-multiplier ... Implement difficulty multiplier display for new mod select design	2022-03-09 12:11:16 +09:00
Jai Sharma	7daa2d0ea4	Use correct fonts and colours in ChannelListingItem	2022-03-09 00:36:19 +00:00
Jai Sharma	7dd51a9c4a	Reorder class attributes	2022-03-09 00:12:44 +00:00
Jai Sharma	a3477c3841	Implement ChannelListing for new chat design ... Adds components `ChannelListing` and `ChannelListing` item with visual test. Essentially a more simplified version of the existing `ChannelSelectionOverlay` component. Correctly implements `IFilterable` behaviour to filter child channel items. Channel joined state is based on the underlying `Joined` bindable of the `Channel` class. Channel join/leave events are exposed via `OnRequestJoin` and `OnRequestLeave` events which should be handled by parent component. Requires a cached `OverlayColourScheme` instance to be provided by the parent overlay component when added.	2022-03-08 22:30:58 +00:00
Dean Herbert	a2ef086c1f	Fix potential crash on rare incorrect firing of skin dropdown update methods ... As brought to light by https://gist.github.com/smoogipoo/56eda7ab56b9d1966556f2ca7a80a847. There's a chance that the dropdown is not populated by the time `updateSelectedSkinFromConfig` is fired via an external means (config changes).	2022-03-09 01:08:13 +09:00
Dan Balasescu	f5cd967635	Fix scores not being recalculated in beatmap listing	2022-03-08 19:07:39 +09:00
Salman Ahmed	5e0882df8d	Simplify message highlighting transforms	2022-03-08 04:00:11 +03:00
Salman Ahmed	d74064b94b	Use Equals instead of reference equality operator	2022-03-08 03:56:27 +03:00
Salman Ahmed	f645869958	Update ChannelManager.CurrentChannel directly to handle non-loaded chat scenario ... `currentChannel` gets instantiated once the chat overlay is open, while `HighlightMessage` could be called while the chat overlay has never been open. This will all be rewritten with the new chat overlay design anyways, so should be fine for now.	2022-03-08 03:42:18 +03:00
Salman Ahmed	7f47be4680	Refactor message highlighting logic to rely on a Channel data bindable	2022-03-08 03:19:37 +03:00
Salman Ahmed	22a2ef42c5	Check channel ID on message highlight using currentDrawableChannel	2022-03-08 01:22:47 +03:00
Bartłomiej Dach	643f68e844	Better annotate initial rolling counter value set	2022-03-07 23:11:20 +01:00
Bartłomiej Dach	019f4d965d	Show two decimal digits on mod multiplier rather than one	2022-03-07 22:55:55 +01:00
Bartłomiej Dach	c25d7a1c75	Use rolling counter for multiplier display	2022-03-07 22:50:51 +01:00
Bartłomiej Dach	78a3b5961e	Implement basic difficulty multiplier display	2022-03-07 22:50:51 +01:00
Salman Ahmed	f4fa80c1e3	Add support to highlight messages in chat overlay	2022-03-07 05:10:49 +03:00
Salman Ahmed	30b38345aa	Add ability to highlight chat lines	2022-03-07 05:08:36 +03:00
Salman Ahmed	a13a087f5d	Add xmldoc to trackNewContent to explain its purpose	2022-03-06 23:51:27 +03:00
Salman Ahmed	9ec0e74813	Move scrolling to UpdateAfterChildren to avoid scheduling ... At least that's what I believe "let FillFlow update to new size" means.	2022-03-06 23:50:58 +03:00
Salman Ahmed	9bc1f3f014	Further refactor and simplify ChannelScrollContainer	2022-03-06 23:34:12 +03:00
Salman Ahmed	5b3ffb12b7	Refactor channel scrolling container to handle manual scrolls resiliently	2022-03-05 23:27:07 +03:00
Dean Herbert	6264dd266d	Merge pull request #17087 from peppy/combine-time-slider-implementation ... Centralise implementation of slider bars which display millisecond time values	2022-03-05 23:48:26 +09:00
Bartłomiej Dach	346cec3577	Merge branch 'add-offset-adjust-tooltip-text' into combine-time-slider-implementation	2022-03-05 14:58:56 +01:00
Bartłomiej Dach	38abfbf4d1	Merge branch 'master' into add-display-choice-dropdown	2022-03-05 14:39:59 +01:00
Bartłomiej Dach	1e34aca984	Rename method to better fit purpose	2022-03-05 14:38:15 +01:00
Dean Herbert	524b8e02ef	Revert "Update all usages of OsuSlider.TooltipText overrides to instead implement GetTooltipText" ... This reverts commit abba49fd8f.	2022-03-05 22:37:36 +09:00
Dean Herbert	bbc2b36117	Merge branch 'master' into add-offset-adjust-tooltip-text	2022-03-05 22:37:04 +09:00
Dean Herbert	6673e456c5	Merge pull request #17090 from miniriley2012/wiki-locale-fix ... Fix wiki links containing locale not loading when opened from chat.	2022-03-04 19:36:14 +09:00
Salman Ahmed	3fdc7ed9d2	Remove brackets surrounding one-line statements	2022-03-04 10:14:19 +03:00
Salman Ahmed	129c290ca0	Dispose cancellation token source on disposal	2022-03-04 10:01:07 +03:00
Salman Ahmed	76c293b9e9	Fix cancellation token source recreated on every medal	2022-03-04 10:00:56 +03:00
Riley Quinn	8491bab77c	Replace string locale with Language	2022-03-04 00:57:13 -06:00