h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-11-15 14:27:51 +08:00
Code Issues Releases Wiki Activity
27,097 Commits 3 Branches 654 Tags 364 MiB
d2b4856d13
Commit Graph

17278 Commits

Author SHA1 Message Date
TheWildTree
393b566966 Make PercentageCounter use FormatAccuracy 2020-02-07 22:16:06 +01:00
Andrei Zavatski
b325725c45 Implement UserHistoryGraph component 2020-02-08 00:10:17 +03:00
TheWildTree
8c10d31af9 Make accuracy formatting more consistent 2020-02-07 22:09:45 +01:00
jorolf
1ba8cc904a Make the caret blink to the beat 2020-02-07 21:42:47 +01:00
Andrei Zavatski
84b7dfb3d6 Implement UserGraph component 
An abstraction for RankGraph
 2020-02-07 23:26:35 +03:00
Andrei Zavatski
fa53bd96a0 Merge dependency 2020-02-07 23:14:46 +03:00
TheWildTree
2770fb71b2 Use SortedStatistics where needed 2020-02-07 21:12:21 +01:00
TheWildTree
59cf2037d0 Introduce SortedStatistics 2020-02-07 21:11:58 +01:00
TheWildTree
7395f01919 Use osu-web font sizes 2020-02-07 20:28:02 +01:00
Dean Herbert
91203c2b12
Merge branch 'master' into placement-display-in-timeline 2020-02-08 01:50:24 +09:00
Dean Herbert
51ae741fc7
Merge pull request #7755 from peppy/fix-spinner-placement 
Fix spinner placement blueprint in multiple ways
 2020-02-08 01:49:48 +09:00
Dan Balasescu
4ad20ccd8b
Merge pull request #7754 from peppy/screen-under-timeline 
Make editor screens display below timeline
 2020-02-08 00:47:20 +09:00
Dan Balasescu
411ab2b190
Merge pull request #7746 from peppy/skin-animation-frame-rate 
Add support for reading skin frame rate from configuration file
 2020-02-08 00:37:01 +09:00
Dean Herbert
678eb8ec31
Reduce accessibility to set 
Co-Authored-By: Dan Balasescu <smoogipoo@smgi.me>
 2020-02-08 00:12:23 +09:00
Dean Herbert
0530ef07bd
Merge pull request #7743 from UselessToucan/make_screenshot_manager_a_drawable 
Make ScreenshotManager a Component
 2020-02-08 00:10:35 +09:00
Dan Balasescu
e4c7b9ebc1
Merge branch 'master' into screen-under-timeline 2020-02-08 00:05:45 +09:00
Dan Balasescu
7c715937ca
Merge branch 'master' into skin-animation-frame-rate 2020-02-07 23:52:45 +09:00
Andrei Zavatski
2d1afb66fb Add history counts to user api 2020-02-07 16:21:47 +03:00
Dean Herbert
2e50e56d7c Seek to previous object endtime after successful placement 2020-02-07 19:12:09 +09:00
Dean Herbert
a6531bf73e Don't show distance snap grid for spinners (for now) 2020-02-07 19:09:23 +09:00
Dean Herbert
2082948f9a Make editor screens display below timeline 2020-02-07 18:23:59 +09:00
Dan Balasescu
476c86f961
Merge branch 'master' into offset-match-stable 2020-02-07 18:21:50 +09:00
Dan Balasescu
71ba3e459b
Merge pull request #7750 from peppy/fix-editor-test-scene 
Fix editor test scene exiting after loading
 2020-02-07 18:07:48 +09:00
Andrei Zavatski
881d192af3 Fix crash when selecting spotlight tab with not-null country 2020-02-07 12:07:16 +03:00
Andrei Zavatski
4ca39135a5 Merge remote-tracking branch 'refs/remotes/ppy/master' into rankings-overlay-spotlights 2020-02-07 12:06:42 +03:00
Dean Herbert
56a091674b Add placement display to timeline 2020-02-07 18:04:10 +09:00
Dean Herbert
e08437c5dc Track placement object in EditorBeatmap 2020-02-07 18:03:14 +09:00
Dean Herbert
e31d69c749 Add commit status to EndPlacement; call BeginPlacement on initial movement 2020-02-07 18:02:48 +09:00
Dean Herbert
b7996f91fc Update the windows platform offset to match stable 2020-02-07 17:51:38 +09:00
Andrei Zavatski
dc8dd24405 Merge remote-tracking branch 'refs/remotes/ppy/master' into rankings-overlay-spotlights 2020-02-07 11:49:31 +03:00
Dan Balasescu
7b70481a10
Merge branch 'master' into fix-editor-test-scene 2020-02-07 17:20:43 +09:00
Dan Balasescu
a6a285bc09
Merge branch 'master' into fix-editor-snapping-inaccuracy 2020-02-07 17:20:42 +09:00
Dan Balasescu
e6060d5ecc
Merge pull request #7749 from peppy/fix-incorrect-distance-snap-grip 
Fix incorrect distance snap grid being displayed when in selection mode
 2020-02-07 17:20:28 +09:00
Dan Balasescu
5d6e007929
Merge branch 'master' into overlapping-scroll-origin 2020-02-07 16:44:34 +09:00
Dan Balasescu
efa7eb70af
Merge branch 'master' into fix-incorrect-distance-snap-grip 2020-02-07 16:44:33 +09:00
Dean Herbert
8990152315 Fix duration snapping still being incorrect 2020-02-07 16:43:50 +09:00
Dean Herbert
9997ae17bc Fix editor test scene exiting after loading 2020-02-07 16:42:56 +09:00
Dean Herbert
3aa18abd99
Fix typo in xmldoc 
Co-Authored-By: Tree <thewildtree@outlook.com>
 2020-02-07 16:22:59 +09:00
Dean Herbert
f63bf06373 Fix incorrect distance snap grid being displayed when in selection mode 2020-02-07 16:09:54 +09:00
Dean Herbert
c392ba6a7e Update framework 2020-02-07 15:46:10 +09:00
Dean Herbert
9181bb41c6 Remove unused using 2020-02-07 15:11:09 +09:00
Dean Herbert
544685be48 Add support for reading skin frame rate from configuration file 2020-02-07 14:58:29 +09:00
Dean Herbert
7460018cd3 Move combo colours to GlobalSkinColours 2020-02-07 14:58:07 +09:00
Dan Balasescu
819973bba3
Merge branch 'master' into make_screenshot_manager_a_drawable 2020-02-07 14:48:50 +09:00
Bartłomiej Dach
5fde4f2c0c Fix lifetime calculation in overlapping algorithm 
Changes to lifetime calculation in scrolling rulesets introduced in
#7367, which aimed to account for the distance between hit objects'
origin and its edge entering the scrolling area, fixed some issues with
hitobjects appearing abruptly, but also regressed some other scenarios.

Upon investigation, the regression was localised to the overlapping
scroll algorithm. The reason for this was two-fold:

* The previous code used TimeAt() to calculate the time of travel from
  the hit object's edge to its origin. For other algorithms, that time
  can be accurately reconstructed, because they don't have periods of
  time where there are multiple hit objects scrolling at different
  velocities.

  That invariant does not hold for the overlapping algorithm, therefore
  it is possible for different values to be technically correct for
  TimeAt(). However, the only value that matters for the adjustment
  is the one that's indicated by the control point that applies to the
  hit object origin, which can be uniquely identified.

* Additionally, the offset returned (even if correct) was applied
  externally to the hit object's start time and passed to
  GetDisplayStartTime(). In the overlapping algorithm, the choice of
  control point used in GetDisplayStartTime() is important, since
  the value of the speed multiplier is read within.

  Externally rewinding the hit object's start time meant that in some
  cases the speed multiplier of the *previous* control point is applied,
  which led to hit objects appearing too late if the scrolling rate
  decreased.

Because of the above, modify GetDisplayStartTime() to take the offset
into account in all algorithms, and apply the adjustment correctly
inside of them. The constant and sequential algorithms needed no
adjustment from the previous logic, since:

* the constant algorithm disregarded control points, and
* the sequential algorithm would effectively rewind to time = 0,
  calculate the absolute distance from time = 0 to the hit object start,
  apply the origin offset *to the absolute distance*, and then convert
  back to time, applying all control points in sequence. Due to this
  it was impossible for control points to get mixed up while
  calculating.

As for the overlapping algorithm, the high-level logic is as follows:

* The distance that the origin has to travel is the length of the scroll
  plus the distance from the origin to the object edge.
* The above distance divided by the scroll length gives the relative
  scroll lengths that the object has to travel.
* As one relative scroll length takes one time range, the relative
  travel length multiplied by the time range gives the absolute travel
  time of the object origin.
* Finally, the control point multiplier applicable at origin time is
  applied to the whole travel time.

Correctness of the above is demonstrated by visual tests added before
and headless unit tests of the algorithms themselves. The sequential
scroll algorithm was not covered by unit tests, and remains uncovered
due to floating-point inaccuracies that should be addressed separately.
 2020-02-06 23:13:28 +01:00
UselessToucan
4495192c25
Make ScreenshotManager a Component 
Co-Authored-By: Salman Ahmed <email@iisalman.me>
 2020-02-06 23:22:30 +03:00
Roman Kapustin
83b2b63d2c Make ScreenshotManager a Drawable 2020-02-06 23:02:03 +03:00
TheWildTree
c09af0052b Revert accuracy display and column sorting changes 2020-02-06 20:21:47 +01:00
Andrei Zavatski
5946ad7d80 Fix possible memory leak and better user change test support 2020-02-06 16:54:02 +03:00
Andrei Zavatski
0840033343 Merge remote-tracking branch 'refs/remotes/ppy/master' into logged-out-comments 2020-02-06 16:38:47 +03:00
Dean Herbert
1613198834 Set a sane default keyboard step for mod settings 2020-02-06 19:43:33 +09:00
Dean Herbert
48350638a2 Hide drag handles of all playlist items not currently being dragged 2020-02-06 18:38:00 +09:00
Dean Herbert
0c30e802c0 Merge remote-tracking branch 'upstream/master' into rearrangeable-playlist 2020-02-06 17:40:28 +09:00
Dean Herbert
6b67b601e9 Update framework 2020-02-06 17:35:13 +09:00
Dan Balasescu
edf20e2c3e
Merge branch 'master' into lounge-ruleset-filtering 2020-02-06 15:35:26 +09:00
Dan Balasescu
8d12d820f1
Merge pull request #7734 from peppy/editor-slider-repeat 
Add the ability to extend hold notes (spinners / sliders etc.) via timeline
 2020-02-06 15:35:16 +09:00
Dan Balasescu
108de6ac56
Merge branch 'master' into editor-slider-repeat 2020-02-06 14:48:45 +09:00
smoogipoo
6ae0efa40d Fix adjustment not working when dragged before object 2020-02-06 14:47:43 +09:00
smoogipoo
c138e3907e Move methods below ctor 2020-02-06 14:35:45 +09:00
Dean Herbert
fd71a53717 Fix test regression 2020-02-06 14:28:09 +09:00
Dean Herbert
a84386ba01 Merge branch 'simplify-mp-subscreen-disables' into lounge-ruleset-filtering 2020-02-06 14:22:52 +09:00
Dean Herbert
81cadb7875 Simplify the way multiple subscreens handle their disable states via a custom stack 2020-02-06 14:22:01 +09:00
Dean Herbert
114fd967c1 Revert "Remove leasing at a Multiplayer screen level" 
This reverts commit 304a071e39.
 2020-02-06 13:47:34 +09:00
Dean Herbert
d00b61de99 Merge branch 'master' into lounge-ruleset-filtering 2020-02-06 13:38:27 +09:00
Dean Herbert
e548a4b8dd Fix missing bind causing regression in filter 2020-02-06 13:36:49 +09:00
Dean Herbert
94b6564b98 Merge branch 'master' into editor-slider-repeat 2020-02-06 13:16:39 +09:00
Dean Herbert
daf5fa9da4 Throw NotSupportedException instead 2020-02-06 13:16:32 +09:00
Dean Herbert
75eb9ca040
Merge pull request #7739 from peppy/fix-rooms-test-scene 
Fix rooms test scene not displaying anything
 2020-02-06 13:12:10 +09:00
Dean Herbert
061b8c389f Fix null search string causing an exception 2020-02-06 13:03:04 +09:00
Dean Herbert
1dc7fc4a33 Fix case where playlist is empty 2020-02-06 13:01:48 +09:00
Dan Balasescu
38bf14a06c
Merge branch 'master' into editor-beatmap-component 2020-02-06 12:25:33 +09:00
Dean Herbert
a79d6ff27a Change transition to better handle mass filter cases 2020-02-06 12:17:20 +09:00
Dean Herbert
304a071e39 Remove leasing at a Multiplayer screen level 2020-02-06 12:17:20 +09:00
Dean Herbert
50c4e34c92 Add ruleset to multiplayer filter criteria 2020-02-06 12:17:20 +09:00
Dean Herbert
00edc7e66f Fix RoomsContainer test scene not displaying 2020-02-06 12:14:17 +09:00
Andrei Zavatski
7757a3a30b Move spotlight layout to it's own method 2020-02-05 23:06:13 +03:00
Andrei Zavatski
4dd25b42ae Move spotlightsRequest to another place 2020-02-05 23:00:42 +03:00
Andrei Zavatski
24e8a2bd69 Make SpotlightSelector.ShowInfo use the full rankings response 2020-02-05 22:59:01 +03:00
TheWildTree
c93d2c7f00 Adjust loading container corner radius 2020-02-05 18:26:01 +01:00
TheWildTree
63df6b8da6 Change accuracy formatting method 2020-02-05 17:42:14 +01:00
TheWildTree
e79ba9a129 Add alwaysShowDecimals param to FormatAccuracy 
This allows us to specify whether we want it to show decimal places if accuracy is 100%.
 2020-02-05 17:41:57 +01:00
TheWildTree
fa3934ddb4 Match osu-web button description 2020-02-05 17:16:20 +01:00
TheWildTree
e1e1c1a11a Match osu-web display accuracy 
Decided to change this only locally instead of modifying FormatAccuracy which would affect everywhere else in the game as well.
 2020-02-05 16:34:39 +01:00
TheWildTree
76037e4ffd Recolour ranked status pill 2020-02-05 16:31:14 +01:00
TheWildTree
f4ee281dd6 Add optional decimal place 2020-02-05 16:15:55 +01:00
Dean Herbert
f5edad16e6 Improve visuals 2020-02-05 19:43:13 +09:00
Andrei Zavatski
6708e271ac Adjust SpotlightSelector animations 2020-02-05 13:01:50 +03:00
Andrei Zavatski
cb30f463fb Update spotlight info based on selected one 2020-02-05 12:48:29 +03:00
Dean Herbert
98ab1f9862 Fix negative spinners 2020-02-05 18:35:31 +09:00
Dean Herbert
3d42973764 Allow scrolling via drag while dragging a hold note handle 2020-02-05 18:35:31 +09:00
Dean Herbert
cef45afbc8 Add a simple hover state 2020-02-05 18:35:31 +09:00
Dean Herbert
d56accaef1 Disallow negative / zero repeat counts (and fix off-by-one) 2020-02-05 18:35:31 +09:00
Dean Herbert
09273d1da9 Fix test scene not correctly building a playable beatmap 2020-02-05 18:35:31 +09:00
Dean Herbert
d04cc0123d Initial implementation of timeline blueprint dragbars 2020-02-05 18:35:31 +09:00
Andrei Zavatski
b83ee6dabf Show beatmap panels for selected spotlight 2020-02-05 12:22:42 +03:00
Andrei Zavatski
2b0b789980 Naming adjustments 2020-02-05 12:14:24 +03:00
Andrei Zavatski
fa65e3a5bb Make spotlight selector work 2020-02-05 12:09:32 +03:00
Dean Herbert
cd6902a312 Make EndTime and RepeatCount settable 2020-02-05 17:52:51 +09:00
Dean Herbert
96986bf5fc Remove beat divisor from ctor and use DI instead 2020-02-05 17:48:21 +09:00
Dean Herbert
63c595ed97 Make EditorBeatmap a component and move UpdateHitObject to it 2020-02-05 17:48:21 +09:00
Andrei Zavatski
a3fd952f74 Use new SpotlightSelector in RankingsHeader 2020-02-05 11:21:23 +03:00
Andrei Zavatski
0bbd95a69c Merge remote-tracking branch 'refs/remotes/ppy/master' into logged-out-comments 2020-02-05 10:57:49 +03:00
Dan Balasescu
af4f3e5fff
Merge branch 'master' into rankings-spotlights-table 2020-02-05 13:42:26 +09:00
Tree
447f31ccfc
Remove using directive 2020-02-04 23:25:21 +01:00
Tree
c2a80119ca
Remove using directives 2020-02-04 23:23:57 +01:00
Tree
23d1d3fdf1
Convert field to local variable 2020-02-04 23:09:10 +01:00
Tree
b606408667
Remove space 2020-02-04 23:02:28 +01:00
TheWildTree
c1b8445b00 Add spacing to match osu-web 
Note: due to osu-web using flex to even out the spacing and me not being able to implement the same behaviour here, I added a static margin to separate the title from the diffname above. This looks better than the previous state in most cases, the only scenario where this differs somehow visibly from web is on mapsets with large numbers of difficulties.
 2020-02-04 21:53:23 +01:00
TheWildTree
86c0b50983 Adjust font once again for readibility 2020-02-04 21:45:45 +01:00
TheWildTree
d7af96a2e5 Adjust corner radius 2020-02-04 21:42:01 +01:00
TheWildTree
82914b5d6e Adjust ScoreTable spacing 2020-02-04 21:41:33 +01:00
TheWildTree
9795897045 Enforce correct column order in ScoreTable 2020-02-04 21:28:31 +01:00
TheWildTree
d23e4a1fa1 Change scoreboard text size 2020-02-04 21:27:51 +01:00
TheWildTree
5458085849 Adjust TopScoreUserSection font and spacing 2020-02-04 21:11:35 +01:00
TheWildTree
3ef6027d57 Show placeholder instead of success rate when beatmap unranked 2020-02-04 21:02:02 +01:00
TheWildTree
48beb9fd6d Recolour PreviewButton 2020-02-04 21:01:02 +01:00
TheWildTree
88e79dfa78 Hide ratings if beatmap has no leaderboard 2020-02-04 21:00:27 +01:00
TheWildTree
85fb4b4a18 Recolour DetailBox 2020-02-04 21:00:00 +01:00
TheWildTree
cbfb90983b Rename variable 2020-02-04 20:17:27 +01:00
TheWildTree
268bb73ac6 Adjust header padding 2020-02-04 20:14:50 +01:00
TheWildTree
2cc1255035 Adjust online status pill font and padding 2020-02-04 20:09:52 +01:00
TheWildTree
d0eb4e4471 Add necessary variable 2020-02-04 20:08:54 +01:00
TheWildTree
86283cc422 Recolour SuccessRate background 2020-02-04 19:55:19 +01:00
TheWildTree
a366a92d4c Use alpha instead of colour opacity 2020-02-04 19:54:51 +01:00
TheWildTree
b6301f6537 Adjust PreviewButton alpha and animation 2020-02-04 19:52:32 +01:00
TheWildTree
5b881568db Adjust header gradient colours 2020-02-04 19:15:02 +01:00
Andrei Zavatski
a9cfade2f4 Adjust null handling 2020-02-04 21:02:10 +03:00
TheWildTree
5eb1619e24 Adjust title / artist font weight 2020-02-04 18:02:49 +01:00
Bartłomiej Dach
4ea9efd92e Enforce column ordering 2020-02-04 17:59:32 +01:00
Andrei Zavatski
a84068448a refetch comments on user change 2020-02-04 19:19:49 +03:00
Andrei Zavatski
5e369534b6 Allow guests to view comments 2020-02-04 19:15:23 +03:00
TheWildTree
9bc45d21f1 Recolour LeaderboardScopeSelector 2020-02-04 17:11:28 +01:00
TheWildTree
b28a1d38a6 Simplify GradientLine and fix colour changing 2020-02-04 17:09:18 +01:00
recapitalverb
833bb28dcf Adjust separator position between top and bottom content 2020-02-04 22:38:25 +07:00
recapitalverb
0cba1a357f Adjust padding on DrawableTopScore 2020-02-04 21:56:22 +07:00
recapitalverb
bd815cd81b Use minWidth on more columns to further match web 2020-02-04 21:55:48 +07:00
recapitalverb
1c16ab1813 Use better colours 2020-02-04 21:55:20 +07:00
recapitalverb
f112760b00 Revert column separator height to 2 2020-02-04 21:55:04 +07:00
Andrei Zavatski
f889f2435b Add test step to TestSceneRankingsTable 2020-02-04 16:20:15 +03:00
Andrei Zavatski
37992e99f9 API implementation 2020-02-04 16:04:06 +03:00
recapitalverb
5030b66092 Adjust width of statistics columns 2020-02-04 19:59:11 +07:00
recapitalverb
a8faee91d8 Use minWidth on pp column 2020-02-04 19:54:57 +07:00
recapitalverb
556a4e64cb Use minimum width on statistics columns 2020-02-04 19:46:14 +07:00
recapitalverb
8f9917238e Add optional minimum width to InfoColumn 2020-02-04 19:45:08 +07:00
recapitalverb
4f312ae6bc Adjust InfoColumn spacing 2020-02-04 19:43:14 +07:00
recapitalverb
c12fc67887 Change InfoColumn title font weight 2020-02-04 19:42:37 +07:00
recapitalverb
3571c2b617 Rearrange children in TopScoreStatisticsSection 2020-02-04 19:41:44 +07:00
Andrei Zavatski
cff619b0e4 Adjust overlay layout 2020-02-04 14:46:22 +03:00
Andrei Zavatski
f30cdab025 Update Scores section 2020-02-04 14:35:04 +03:00
Andrei Zavatski
34091103e3 Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-overlay-recolour 2020-02-04 14:17:24 +03:00
Andrei Zavatski
0e54e0e092 Recolour DrawableTopScore 2020-02-04 14:17:22 +03:00
Andrei Zavatski
873eda3bb5 Recolour info section 2020-02-04 14:00:18 +03:00
Andrei Zavatski
c3bd6c3f7f Remove no longer used field 2020-02-04 11:21:21 +03:00
Andrei Zavatski
524a8ba6c6 Merge remote-tracking branch 'refs/remotes/ppy/master' into rankings-overlay-update 2020-02-04 11:19:13 +03:00
smoogipoo
b6cfb987f3 Make drag handles not pop into existence 2020-02-04 17:00:36 +09:00
smoogipoo
e4e0a26b62 Merge remote-tracking branch 'origin/master' into rearrangeable-playlist 2020-02-04 16:55:55 +09:00
Dan Balasescu
27c24fb08a
Merge pull request #7721 from recapitalverb/display-accuracy 
Add {ScoreInfo,UserStatistics}.Accuracy
 2020-02-04 16:16:33 +09:00
recapitalverb
42060139f8
Merge branch 'master' into display-accuracy 2020-02-04 12:51:48 +07:00
Dan Balasescu
b4a90dc4ea
Merge branch 'master' into fix-key-counter-visible-on-reshowing-hud 2020-02-04 14:43:33 +09:00
recapitalverb
7eec8df2f3
Merge branch 'master' into display-accuracy 2020-02-04 12:17:37 +07:00
Dan Balasescu
0e3c1ed0f7
Merge branch 'master' into fix-key-counter-visible-on-reshowing-hud 2020-02-04 14:06:23 +09:00
Dan Balasescu
75f5cb4871
Merge branch 'master' into rankings-overlay-update 2020-02-04 13:52:57 +09:00
Dan Balasescu
2b471be340
Merge branch 'master' into spotlights_api 2020-02-04 13:48:02 +09:00
Dan Balasescu
e45f759c15
Merge pull request #7723 from EVAST9919/overlay-header-current-value 
Expose TabControlOverlayHeader.Current value
 2020-02-04 13:47:52 +09:00
recapitalverb
79bb476f4c
Merge branch 'master' into display-accuracy 2020-02-04 11:39:47 +07:00
recapitalverb
2bbd12e39a Fix code formatting 2020-02-04 11:36:22 +07:00
recapitalverb
14db813842 Add licence header 2020-02-04 11:18:19 +07:00
Dan Balasescu
549bdea8a3
Merge branch 'master' into overlay-header-current-value 2020-02-04 13:17:44 +09:00
recapitalverb
a8ce50fadd Add FormatUtils.FormatAccuracy and usages 2020-02-04 11:17:23 +07:00
Dan Balasescu
634364863d
Merge branch 'master' into beatmap-overlay-header 2020-02-04 13:13:57 +09:00
smoogipoo
bc9b499de0 Make selector only privately-settable 2020-02-04 12:55:09 +09:00
smoogipoo
68b3dc01df Move property override below ctor 2020-02-04 12:53:57 +09:00
Dan Balasescu
3600b0daf0
Merge branch 'master' into fix-mod-select-overflowing 2020-02-04 11:57:54 +09:00
recapitalverb
ddf9317bec Replace :P2 with :0.00% 2020-02-04 08:25:01 +07:00
Joehu
22e3150f68 Fix comment and remove magic numbers 2020-02-03 17:21:06 -08:00
Andrei Zavatski
5950ba3656 Change the order of colour check 2020-02-04 00:55:41 +03:00
Andrei Zavatski
fe078c244d Expose TabControlOverlayHeader.Current value 2020-02-04 00:43:04 +03:00
Andrei Zavatski
e42b95974a Fix failing test scene 2020-02-03 21:49:21 +03:00
Andrei Zavatski
4abd9cb89a Move Enabled/Disabled state logic to the OverlayRulesetTabItem 2020-02-03 21:45:10 +03:00
Andrei Zavatski
824ee8a888 Recolour rankings tables 2020-02-03 21:22:37 +03:00
Andrei Zavatski
f7cbb8c1f7 Recolour RankingsOverlay background 2020-02-03 21:05:11 +03:00
Andrei Zavatski
2a802307e7 Delete unused components 2020-02-03 20:59:08 +03:00
Andrei Zavatski
3b6ed3fb27 Use new header in the RankingsOverlay 2020-02-03 20:53:30 +03:00
Andrei Zavatski
dc1d0d0f32 Add spotlights selector to new header 2020-02-03 20:47:41 +03:00
Andrei Zavatski
588a77484b Add ContryFilter to new header 2020-02-03 20:32:20 +03:00
Andrei Zavatski
b284170437 Basic implementation of new RankingsOverlayHeader 2020-02-03 20:20:35 +03:00
Salman Ahmed
4cd4055e7c Rename to AlwaysVisible and add XMLDoc 2020-02-03 20:00:43 +03:00
Salman Ahmed
51ed289c59 Revert namings and behaviour changes 2020-02-03 19:59:58 +03:00
Andrei Zavatski
12574111e5 Use ColourProvider colours 2020-02-03 19:44:10 +03:00
Andrei Zavatski
e531570352 Merge remote-tracking branch 'refs/remotes/ppy/master' into spotlights_api 2020-02-03 19:34:35 +03:00
recapitalverb
698408bb6d Remove redundant using directive 2020-02-03 22:36:38 +07:00
recapitalverb
4dfdd98e8b Use UserStatistics.DisplayAccuracy everywhere 2020-02-03 22:12:34 +07:00
recapitalverb
9898a926b2 Use ScoreInfo.DisplayAccuracy everywhere 2020-02-03 22:11:36 +07:00
recapitalverb
257b4052e8 Add {ScoreInfo,UserStatistics}.Accuracy 2020-02-03 22:09:07 +07:00
Salman Ahmed
351cb8ac1a Rename Visible to HasReplayLoaded and change default value 
Doesn't make sense to be true by default
 2020-02-03 15:47:52 +03:00
Andrei Zavatski
2abcc6ad69 Simplify counter addition in BeatmapRulesetTabItem 2020-02-03 15:25:07 +03:00
Salman Ahmed
443063263e Merge remote-tracking branch 'upstream/master' into fix-key-counter-visible-on-reshowing-hud 2020-02-03 15:18:25 +03:00
Andrei Zavatski
fa453bc3e1 Refactor beatmap header 2020-02-03 14:35:07 +03:00
Andrei Zavatski
032c2c2afe Refactor BeatmapRulesetSelector 2020-02-03 14:16:26 +03:00
Dan Balasescu
76ba0b833e
Merge pull request #7716 from EVAST9919/overlay-header-ruleset-selector 
Add ability to create ruleset selector in OverlayHeader
 2020-02-03 19:00:12 +09:00
Dan Balasescu
c6e7603e5e
Merge branch 'master' into safe-screen-lease 2020-02-03 18:18:13 +09:00
Dan Balasescu
ac6518043f
Merge branch 'master' into overlay-header-ruleset-selector 2020-02-03 17:47:50 +09:00
Andrei Zavatski
ce6e97096c Fix broken overlays 
oops
 2020-02-03 11:44:31 +03:00
dependabot-preview[bot]
91aa66bcb2
Bump Sentry from 1.2.0 to 2.0.1 
Bumps [Sentry](https://github.com/getsentry/sentry-dotnet) from 1.2.0 to 2.0.1.
- [Release notes](https://github.com/getsentry/sentry-dotnet/releases)
- [Commits](https://github.com/getsentry/sentry-dotnet/compare/1.2.0...2.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-02-03 08:16:18 +00:00
Andrei Zavatski
81ab6d43b6 Add ability to create ruleset selector in OverlayHeader 2020-02-03 11:09:46 +03:00
Dan Balasescu
098b3ac294
Merge branch 'master' into present-replay-from-ss 2020-02-03 16:28:38 +09:00
Dan Balasescu
1d1a5b26ab
Merge pull request #7678 from peppy/perform-from-screen 
Refactor performFromMenu to work with multiple screen targets
 2020-02-03 16:28:01 +09:00
Dan Balasescu
93952d438f
Merge pull request #7677 from peppy/decouple-mod-select-bindable 
Decouple ModSelectOverlay from global SelectedMods
 2020-02-03 16:27:47 +09:00
Dean Herbert
591c7b6250
Merge pull request #7682 from peppy/fix-timeline-tick-overrun 
Fix too many ticks being displayed on beatmaps with multiple timing sections
 2020-02-03 16:16:23 +09:00
Dean Herbert
9183c78319 Fix crash on exiting song select with ctrl-enter autoplay 2020-02-03 16:04:32 +09:00
Dan Balasescu
7676185bb6
Merge branch 'master' into perform-from-screen 2020-02-03 15:55:45 +09:00
Dean Herbert
d9d8712360 Refactor class layout for readability 2020-02-03 15:13:21 +09:00
Dean Herbert
fae5bf0f18
Merge branch 'master' into overlay-ruleset-selector 2020-02-03 13:48:28 +09:00
Dan Balasescu
c20b14868b
Merge branch 'master' into profile-page-corrections 2020-02-03 13:29:37 +09:00
Dean Herbert
9680c0941f Move private helper methods to botom of file 2020-02-03 12:46:11 +09:00
Dean Herbert
c9143275be
Merge branch 'master' into profile-recent-info 2020-02-03 12:03:00 +09:00
Dean Herbert
98ccfe612b
Merge branch 'master' into no-comments-placeholder 2020-02-03 11:10:06 +09:00
recapitalverb
ff17c76a20 Fix modifiers for performance_background_width 2020-02-03 08:26:12 +07:00
Bartłomiej Dach
c479d0efa4 Simplify show/hide logic 2020-02-02 17:41:42 +01:00
Bartłomiej Dach
72107c27c9 Only add newline if necessary 2020-02-02 17:39:58 +01:00
TheWildTree
3cc1b811ef Make dates non-italic to match osu-web 2020-02-02 17:22:48 +01:00
TheWildTree
d15942d127 Revert containers merge and rework bottomLinkContainer visibility logic 2020-02-02 17:21:22 +01:00
TheWildTree
030d02594c Allow non-italic DrawableDate 2020-02-02 17:10:11 +01:00
recapitalverb
878489651c Make performance_background_width readonly 2020-02-02 23:04:11 +07:00
TheWildTree
1f53778d62 Add explanation to comment 2020-02-02 16:59:17 +01:00
Salman Ahmed
4cdf4b223c Rename to alwaysShow and add XMLDoc 2020-02-02 18:47:12 +03:00
Salman Ahmed
28e340c486 Inherit Container and fade the key flow instead of individual children 2020-02-02 18:46:27 +03:00
recapitalverb
0a186fe722 Avoid calculating constants in load() 2020-02-02 22:37:58 +07:00
recapitalverb
bd3d7a285b Merge branch 'adjust-profile-scores' of https://github.com/recapitalverb/osu into adjust-profile-scores 2020-02-02 21:39:04 +07:00
recapitalverb
aa13b605a4 Fix inconsistent local variable naming 2020-02-02 21:34:35 +07:00
recapitalverb
2a463e2893
Merge branch 'master' into adjust-profile-scores 2020-02-02 21:14:20 +07:00
recapitalverb
79efcbd6f3 Fix performance background width 2020-02-02 21:08:16 +07:00
Dean Herbert
30a5835bdb Combine link flows and simplify new line addition 2020-02-02 23:07:53 +09:00
recapitalverb
a641069ec2 Change profile score background colour 2020-02-02 21:07:23 +07:00
recapitalverb
122fd63ac4 Inline single-use constants 2020-02-02 21:05:20 +07:00
Dean Herbert
aa1daa0ad5
Merge pull request #7703 from bdach/beatmap-stats-precision 
Apply precision when determining bar colour in difficulty statistics
 2020-02-02 22:31:52 +09:00
Tree
c7e281348a
Merge branch 'master' into profile-page-corrections 2020-02-02 13:36:21 +01:00
Salman Ahmed
6a11c3a8f9 Expose ConfigVisibility bindable for testing purposes 2020-02-02 14:48:07 +03:00
Salman Ahmed
abccf05155 Update visibility of each key counter instead of this container 
For isolating changing visibility of the key counter display based on config and internal values from just fading the container.
 2020-02-02 14:47:14 +03:00
recapitalverb
52aae68411
Adjust profile scores to closer match osu-web 2020-02-02 17:52:34 +07:00
Andrei Zavatski
a70385f2b2 Simplify getRulesetName 2020-02-02 12:19:09 +03:00
Andrei Zavatski
36116f8c45 Refactor ruleset presentation 2020-02-02 12:03:51 +03:00
Andrei Zavatski
8786d6264f Merge remote-tracking branch 'refs/remotes/ppy/master' into profile-recent-info 2020-02-02 12:03:33 +03:00
Bartłomiej Dach
434c0d92e4 Use Bindable{Float,Double}s everywhere 
To avoid further floating-point comparison bugs, remove all usages of
Bindable<{float,double}>, replacing them with their
Bindable<Float,Double> counterparts.
 2020-02-01 22:50:29 +01:00
Bartłomiej Dach
e894acf53c Make star filter range bindables BindableDoubles 
Due to using Bindable<double>s previously, song select's filter control
would not apply tolerance when checking IsDefault, therefore wrongly
hiding maps with star ratings above 10.1.
 2020-02-01 22:48:46 +01:00
Joehu
609ee26030 Fix mod select overlay not showing up in test 2020-02-01 11:41:41 -08:00
Joehu
2d42a83bb9 Fix mod select overlay overflowing toolbar at max ui scale 2020-02-01 11:24:29 -08:00
Bartłomiej Dach
0bfadfbbf1 Apply precision when comparing adjusted values 
In some cases, applying the Difficulty Adjust mod without actually
changing any of the settings previously caused the bar in song select
beatmap details to appear red/blue instead of staying white.

This was caused by not accounting for floating-point imprecisions when
determining bar colour in AdvancedStats. To resolve, first check
equality with tolerance, and only then apply blue/red colours if that
equality check does not hold.
 2020-02-01 16:16:15 +01:00
Bartłomiej Dach
a74d22d9e5 Extract beatmap stats test to separate scene 2020-02-01 15:50:33 +01:00
Dean Herbert
5e834b64cd
Merge branch 'master' into use_ElementAtOrDefault 2020-02-01 10:42:40 +09:00
Berkan Diler
6d30e425a1 Revert change to avoid conflict with another PR 2020-01-31 18:51:29 +01:00
Berkan Diler
9596030e1d Make use of ElementAtOrDefault() when possible 2020-01-31 18:32:47 +01:00
Dean Herbert
5312586351 Merge remote-tracking branch 'origin/perform-from-screen' into present-replay-from-ss 2020-02-01 02:14:17 +09:00
Dean Herbert
ed368e44ea
Merge branch 'master' into safe-screen-lease 2020-02-01 02:11:18 +09:00
Dean Herbert
3291d7b6c9
Merge branch 'master' into present-replay-from-ss 2020-02-01 02:08:00 +09:00
Dean Herbert
c5422743e2
Merge branch 'master' into decouple-mod-select-bindable 2020-02-01 02:06:23 +09:00
Dean Herbert
90caa61245
Reverse comparison for readability 
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
 2020-02-01 02:05:26 +09:00
Dean Herbert
8db1a8ddb9
Merge branch 'master' into perform-from-screen 2020-02-01 02:04:30 +09:00
Dean Herbert
b3e63d8869
Merge branch 'master' into fix-chat-tab-shortcuts 2020-02-01 02:03:43 +09:00
Dean Herbert
e728d2be17 Use ElementAtOrDefault 2020-02-01 01:19:04 +09:00
Dean Herbert
c4331f34d5 Consume TearDownSteps 2020-01-31 22:09:39 +09:00
Dean Herbert
3e15265a53 Update framework 2020-01-31 22:09:02 +09:00
Dean Herbert
a66cdee5e9 Fix missed issues 2020-01-31 21:36:19 +09:00
Dean Herbert
19f516e710 Ensure OsuScreen level leases are taken out synchronously 2020-01-31 19:10:44 +09:00
Dean Herbert
a547d2ed5c Don't least at Player just yet 2020-01-31 18:37:16 +09:00
Dean Herbert
2f61d3f5ad Fix song select remaining issue locally 2020-01-31 17:35:53 +09:00
Andrei Zavatski
3b5b799d60 Adjust height of ShowMore button 2020-01-31 09:51:56 +03:00
Andrei Zavatski
4a444face1 Change ShowMoreButton hide logic 2020-01-31 09:46:35 +03:00
Andrei Zavatski
91f7bc6d45 Merge remote-tracking branch 'refs/remotes/ppy/master' into no-comments-placeholder 2020-01-31 09:43:23 +03:00
Dean Herbert
5f48affcba Centralise screen exit logic to ScreenTestScene 2020-01-31 14:19:29 +09:00
Dean Herbert
9a1907d8e0
Apply doc fixes from code review 
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
 2020-01-31 09:48:20 +09:00
Tree
b03e7f12ff
Remove unused directive 2020-01-30 22:51:35 +01:00
TheWildTree
c050eed79b Recolour RankGraphTooltip 2020-01-30 22:05:06 +01:00
TheWildTree
caf76511a7 Remove double negation 2020-01-30 21:45:42 +01:00
Bartłomiej Dach
1553444001 Fix channel tab keyboard shortcut 
Filter out the selector tab item at the point of enumerating tabs to fix
the regression of the Alt+number key shortcut.
 2020-01-30 21:44:53 +01:00
TheWildTree
c38dc81535 Remove unnecessary using 2020-01-30 21:39:06 +01:00
TheWildTree
a3877cc29e Recolour RankGraph circle 2020-01-30 20:55:44 +01:00
TheWildTree
3970151e31 Improve condition check 2020-01-30 20:51:33 +01:00
TheWildTree
1751e96840 Recolour ProfileHeaderButton 2020-01-30 19:45:12 +01:00
TheWildTree
e69d93ae5c Adjust ProfileTabControl height 2020-01-30 19:26:42 +01:00
TheWildTree
de9a1737a5 Recolour LevelProgressBar 2020-01-30 18:18:42 +01:00
TheWildTree
754200d843 Fix padding when user has no additional info 2020-01-30 18:10:40 +01:00
TheWildTree
682d0e6e71 Fix typo in variable 2020-01-30 17:46:59 +01:00
Dean Herbert
f51cfa2220 Fix too many ticks being displayed on beatmaps with multiple timing sections 
Closes https://github.com/ppy/osu/issues/7681.
 2020-01-31 00:24:00 +09:00
Dean Herbert
14f88bb725 Merge branch 'perform-from-screen' into present-replay-from-ss 2020-01-30 23:45:51 +09:00
Dean Herbert
878250056c Remove unused parameter 2020-01-30 23:34:04 +09:00
Andrei Zavatski
3db4c11f29 CI fix 2020-01-30 14:05:55 +03:00
Andrei Zavatski
3002366e70 Adjust mode part 2020-01-30 13:56:19 +03:00
Andrei Zavatski
3f62c40e70 Increase spacing 2020-01-30 13:55:50 +03:00
smoogipoo
0c4540b551 Rename PlaylistItem 2020-01-30 19:23:53 +09:00
smoogipoo
00a7adcdca Further refactorings 2020-01-30 19:21:24 +09:00
Andrei Zavatski
a7a3372a98 Remove redundant empty switch section 2020-01-30 13:01:40 +03:00
smoogipoo
f6ba98eec0 Apply refactorings for framework-side changes 2020-01-30 19:00:59 +09:00
Andrei Zavatski
29ba82ee44 Apply different font styles for different content parts 2020-01-30 12:29:35 +03:00
Andrei Zavatski
9fc886abc3 Merge remote-tracking branch 'refs/remotes/ppy/master' into profile-recent-info 2020-01-30 12:28:39 +03:00
Dean Herbert
8193991445
Merge pull request #7675 from smoogipoo/fix-possible-chat-crash 
Fix possible crash when searching with no channel topic
 2020-01-30 18:22:23 +09:00
Dean Herbert
0975002ef5 Allow presenting scores from PlaySongSelect 2020-01-30 18:16:28 +09:00
Dean Herbert
5d1473aecd Merge branch 'perform-from-screen' into present-replay-from-ss 2020-01-30 18:15:13 +09:00
Dean Herbert
8e0d51766b Update framework 2020-01-30 18:10:19 +09:00
Dean Herbert
f637e0e5a7 Remove unused bypassScreenAllowChecks argument 2020-01-30 18:10:05 +09:00
Dean Herbert
bc21e30b09 Allow specifying a valid list of types to performFromMenu 2020-01-30 18:10:05 +09:00
Dean Herbert
7bf2e9b369 Decouple ModSelectOverlay from global SelectedMods 2020-01-30 17:38:15 +09:00
Andrei Zavatski
2f7076f91c Adjust icons size 2020-01-30 11:16:58 +03:00
Dan Balasescu
3fe84e0ddf
Merge branch 'master' into fix-replay-initial-frames 2020-01-30 16:56:37 +09:00
Andrei Zavatski
b2c501a439 Adjust font size 2020-01-30 10:54:58 +03:00
Andrei Zavatski
1c4650c02c Merge master with conflicts resolved 2020-01-30 10:39:23 +03:00
Andrei Zavatski
ea2f66da1d Simplify OverlayRulesetTabItem.AccentColour 2020-01-30 10:34:22 +03:00
Dean Herbert
d03723303d
Fix typo in comment 2020-01-30 16:29:15 +09:00
Andrei Zavatski
10e8361e7c Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-ruleset-selector 2020-01-30 10:08:39 +03:00
Andrei Zavatski
a8578c1526 Merge master with conflicts resolved 2020-01-30 10:08:02 +03:00
Dan Balasescu
3604730027
Merge branch 'master' into fix-replay-initial-frames 2020-01-30 15:16:24 +09:00
Dan Balasescu
09f6c57b0f
Merge branch 'master' into fix-import-different-ruleset 2020-01-30 15:08:25 +09:00
smoogipoo
2fb640f57f Change to until step + fix CI error 2020-01-30 15:00:39 +09:00
Dean Herbert
7b4a658264 Fix negative replay frames being played back incorrectly 2020-01-30 14:54:57 +09:00
Dan Balasescu
fb51ffc169
Merge pull request #7667 from peppy/editor-match-accessibility 
Fix editor being accessible for multiplayer song select
 2020-01-30 14:38:30 +09:00
smoogipoo
ce36e5458f Fix possible crash with no channel topic 2020-01-30 14:35:03 +09:00
Dan Balasescu
c18b1b302c
Merge branch 'master' into editor-match-accessibility 2020-01-30 13:49:56 +09:00
Dan Balasescu
3d814e7714
Merge branch 'master' into rename-deleted-count 2020-01-30 13:49:54 +09:00
Dan Balasescu
1239dd93dc
Merge branch 'master' into recolor-profile-sections 2020-01-30 13:30:35 +09:00
smoogipoo
17978035ea Fix uncaught inconsistent naming 2020-01-30 12:50:15 +09:00
smoogipoo
da2c245083 Change to pink colour scheme 2020-01-30 12:36:47 +09:00
smoogipoo
d7d7ab48d3 Cleanup 2020-01-30 12:36:38 +09:00
Dean Herbert
c158570249
Fix typo in comment 
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
 2020-01-30 11:31:34 +09:00
Dean Herbert
ebdb425c50 Rename and tidy up DeletedCommentsCounter 2020-01-30 11:17:26 +09:00
Dean Herbert
f72de235cc Remove unnecessary length specifications 2020-01-30 11:00:14 +09:00
Dean Herbert
37ecf8a060 Remove commented line 2020-01-30 10:50:48 +09:00
Dean Herbert
bea20efb64
Merge branch 'master' into mod_content_centering 2020-01-30 10:34:46 +09:00
Andrei Zavatski
d20c48d151 Resolve possible UserVotes issues 2020-01-30 00:53:05 +03:00
Andrei Zavatski
d1ead83c6c Merge remote-tracking branch 'refs/remotes/ppy/master' into no-comments-placeholder 2020-01-30 00:48:43 +03:00
TheWildTree
ef92c26c17 Recolor ProfileSection 2020-01-29 22:26:21 +01:00
TheWildTree
f7c38da030 Match web border height 2020-01-29 22:25:56 +01:00
TheWildTree
87521f35ed Recolor buttons 2020-01-29 22:25:28 +01:00
TheWildTree
06eded16e2 Recolor DetailHeaderContainer 2020-01-29 22:10:58 +01:00
TheWildTree
85990cdcdb Recolor MedalHeaderContainer 2020-01-29 22:10:48 +01:00
TheWildTree
0f9ab7c980 Recolor BottomHeaderContainer 2020-01-29 22:10:19 +01:00
TheWildTree
fa0a96c3f5 Match web margins 2020-01-29 22:05:40 +01:00
TheWildTree
83d5691ba3 Match web border height 2020-01-29 22:00:37 +01:00
TheWildTree
799a86544f Recolor play time border 2020-01-29 21:57:43 +01:00
TheWildTree
088064523b Recolor CentreHeaderContainer 2020-01-29 21:55:41 +01:00
TheWildTree
12a49b74bb Recolor TopHeaderContainer 2020-01-29 21:48:02 +01:00
TheWildTree
c091b31fe8 Recolor basic background boxes 2020-01-29 21:37:51 +01:00
TheWildTree
0ce18256e0 Recolor ProfileTabControl 2020-01-29 21:35:17 +01:00
TheWildTree
65f71b8c12 Make colourProvider accessable from derived classes 2020-01-29 21:23:19 +01:00
Bartłomiej Dach
f130e48c9e Remove leftover negative margin 2020-01-29 19:17:07 +01:00
Andrei Zavatski
786ed03868 Update profile recent activities in line with the web design 2020-01-29 21:01:40 +03:00
Bartłomiej Dach
c9dda78ded Refactor drawable hierarchy to center properly 
* Use FillFlowContainer.Spacing instead of manually applying margins.
* Use Update() for calculating button padding to preserve it after
  mod button expansion and adjust FooterButtonRandom to use this method
  while avoiding flickering.
* Expose mod display margin to clear it in the footer button.
 2020-01-29 18:59:51 +01:00
Dean Herbert
da6952407e Allow null DI 2020-01-29 23:01:57 +09:00
Dean Herbert
13eb32fea2 Fix editor being accessible for multiplayer song select 2020-01-29 22:20:34 +09:00
Dean Herbert
7f59576f13
Fix percentage-formatted displays containing a space (#7664) 
Fix percentage-formatted displays containing a space
 2020-01-29 20:37:32 +09:00
Dean Herbert
9f0f09a844
Add a reverse setting for Winding mods (#7222) 
Add a reverse setting for Winding mods
 2020-01-29 20:29:32 +09:00
Andrei Zavatski
de6a71ffb7 Merge remote-tracking branch 'refs/remotes/ppy/master' into no-comments-placeholder 2020-01-29 14:06:52 +03:00
smoogipoo
76af8bea5d Fix percentage-formatted displays containing a space 2020-01-29 19:51:24 +09:00
Dan Balasescu
30da9981d6
Merge branch 'master' into profile-scores-update-new 2020-01-29 19:40:44 +09:00
Dean Herbert
7588c574a2 Fix presenting a beatmap from a different ruleset not working 2020-01-29 19:37:54 +09:00
smoogipoo
7f946047f9 Adjust styling to closer match osu-web 2020-01-29 19:25:31 +09:00
smoogipoo
d908bc2693 Remove unnecessary extra spritetext 2020-01-29 18:44:30 +09:00
Dan Balasescu
db3e360229
Merge branch 'master' into fix-carousel-missing-import 2020-01-29 18:06:27 +09:00
Dan Balasescu
77b1bf3ee2
Merge pull request #7648 from peppy/keyboard-composition-tools 
Allow selecting composition tools using 1-4 keys
 2020-01-29 17:29:11 +09:00
Dean Herbert
77c06b1c6e Fix beatmap carousel potentially missing beatmap imports 2020-01-29 17:09:12 +09:00
Dan Balasescu
37c7fe30fa
Merge branch 'master' into keyboard-composition-tools 2020-01-29 16:52:47 +09:00
Dan Balasescu
66b8d38d42
Merge branch 'master' into selection-composition-conformity 2020-01-29 16:52:45 +09:00
Dan Balasescu
73f94c0be3
Merge pull request #7643 from peppy/distance-snap-grid-correct-colouring 
Distance snap grid correct colouring
 2020-01-29 16:52:34 +09:00
Dan Balasescu
37036b855b
Merge pull request #7654 from peppy/reset-test-storage 
Add a method to recycle test storage between runs
 2020-01-29 16:37:37 +09:00
Dan Balasescu
e553a9b9e0
Merge branch 'master' into distance-snap-grid-correct-colouring 2020-01-29 16:09:35 +09:00
Dan Balasescu
63501c188a
Merge pull request #7644 from peppy/standardise-zoom-levels 
Standardise editor timeline zoom across maps of all lengths
 2020-01-29 16:04:25 +09:00
Dan Balasescu
9954b67bda
Merge branch 'master' into reset-test-storage 2020-01-29 15:52:52 +09:00
Dean Herbert
849e453c35 Merge remote-tracking branch 'upstream/master' into reset-test-storage 2020-01-29 15:49:05 +09:00
smoogipoo
ec015d750b Merge remote-tracking branch 'origin/master' into reverse-winding 2020-01-29 15:38:06 +09:00
smoogipoo
17294b1b09 Make wind down max value 200% 2020-01-29 15:34:36 +09:00
Dan Balasescu
018c005c71
Merge branch 'master' into distance-snap-grid-correct-colouring 2020-01-29 15:33:07 +09:00
Dan Balasescu
0d6fd0a54a
Merge branch 'master' into standardise-zoom-levels 2020-01-29 15:32:57 +09:00
Dan Balasescu
65ac412ff8
Merge branch 'master' into fix-beat-snap 2020-01-29 15:32:27 +09:00
smoogipoo
391681b7af Separate calculation to follow other examples 2020-01-29 15:16:48 +09:00
Dean Herbert
7d05840ee0
Merge branch 'master' into select-tool 2020-01-29 15:04:22 +09:00
Dan Balasescu
ea2ee53ee3
Merge branch 'master' into timline-beat-lines 2020-01-29 14:44:07 +09:00
smoogipoo
9a47428bfd Remove out of date comment 2020-01-29 14:40:42 +09:00
Dan Balasescu
abe0041b65
Merge branch 'master' into select-tool 2020-01-29 14:29:12 +09:00
Dan Balasescu
4d43833db4
Merge branch 'master' into timline-beat-lines 2020-01-29 14:12:00 +09:00
Dan Balasescu
b10143fdf2
Merge branch 'master' into fix-key-count-mod-affect 2020-01-29 14:11:59 +09:00
Andrei Zavatski
5fcda01346 Cleanup pass 2020-01-29 06:58:53 +03:00
Dean Herbert
aa597c1934 Copy documentation across to SettingsSlider 2020-01-29 12:55:07 +09:00
Dean Herbert
f21142ae50 Merge remote-tracking branch 'upstream/master' into slider-tooltip 2020-01-29 12:50:44 +09:00
Dean Herbert
cfc4eaff59 Fix display being incorrect when MaxValue is not 1 2020-01-29 12:50:21 +09:00
Andrei Zavatski
dc10e58b4f Add tests for CommentsPage 2020-01-29 06:44:39 +03:00
Andrei Zavatski
e7964023ae Implement CommentsPage class 2020-01-29 06:22:08 +03:00
smoogipoo
ebf15c6a1c General work towards completion + framework updates 2020-01-29 12:17:03 +09:00
Andrei Zavatski
c5e0c77bca Refactor NoCommentsPlaceholder 2020-01-29 06:08:11 +03:00
Andrei Zavatski
b947e89a6b Add placeholder for no comments case in CommentsContainer 2020-01-28 16:53:22 +03:00
Dean Herbert
0e0c730095 Add a method to recycle test storage between runs 2020-01-28 19:44:32 +09:00
unknown
894642d588 add xmldoc and formatting 2020-01-28 18:04:00 +08:00
smoogipoo
2b2cfd91a6 Initial re-implementation using rearrangeable list 2020-01-28 17:59:14 +09:00
Dean Herbert
12ff51f686 Fix key count being incorrectly adjusted by hard/easy mods 2020-01-28 17:21:50 +09:00
Andrei Zavatski
5a2fd18bdd Allow better async support for CommentsContainer 2020-01-28 10:21:27 +03:00
Andrei Zavatski
4e884fc6f4 Merge remote-tracking branch 'refs/remotes/ppy/master' into comments-recolour 2020-01-28 10:15:10 +03:00
Dean Herbert
41f55dba91
Merge pull request #7637 from EVAST9919/overlay-header-background 
Refactor background creation in OverlayHeader
 2020-01-28 16:06:31 +09:00
Dean Herbert
40379a5e22 Use foreach 2020-01-28 16:04:13 +09:00
Dean Herbert
dbb89cfde7 Merge remote-tracking branch 'upstream/master' into timline-beat-lines 2020-01-28 16:03:50 +09:00
Dean Herbert
f48c7db827 Use Drawable.Empty instead of container 2020-01-28 15:41:09 +09:00
Dean Herbert
8e2159e4eb Ensure selection tool correctly matches selection state 
- When a selection is made (via the timeline) the selection tool should become the select tool.
- When the selection tool is changed to anything *but* the select tool, the selection should be cleared.
 2020-01-28 15:13:12 +09:00
Dean Herbert
7e0c45de6d Allow selecting composition tools using 1-4 keys 2020-01-28 15:09:03 +09:00
Dean Herbert
e81d3c51ed Move select tool to an actual tool implementation 
Also tidies up radio button action firing so calling Select actually fires the associated action in all cases.
 2020-01-28 15:05:29 +09:00
Dean Herbert
596a01661c Remove 1ms offset and update tests 2020-01-28 13:42:22 +09:00
unknown
a3cfeb08d4 remove unused assignment 2020-01-28 12:34:17 +08:00
unknown
aa264cd2a8 allow tooltip to show as percentage as needed 2020-01-28 12:32:30 +08:00
Dean Herbert
4bb33046ca Standardise editor timeline zoom across maps of all lengths 2020-01-28 13:03:06 +09:00
Dean Herbert
58654f28b6 Fix beat snap implementation being incorrect 2020-01-28 12:48:24 +09:00
Dean Herbert
29daabb40a Fix distance snap grid showing incorrect colouring 
Now matches timeline colours (based on timing point).
 2020-01-28 11:59:21 +09:00
Andrei Zavatski
ce95b4a106 TotalCommentsCounter improvements 2020-01-28 05:57:45 +03:00
Andrei Zavatski
ac904194d3 Merge remote-tracking branch 'refs/remotes/ppy/master' into comments-recolour 2020-01-28 05:52:32 +03:00
unknown
d9e21a572f remove unecessary comment 2020-01-28 07:13:28 +08:00
Huo Yaoyuan
b14c7bd171 Use type switch in SearializationWriter. 2020-01-27 21:49:34 +08:00
Andrei Zavatski
55d78dbc57 CI fix 2020-01-27 16:45:10 +03:00
Andrei Zavatski
e6fa793d56 Refactor background creation in OverlayHeader 2020-01-27 15:36:19 +03:00
Andrei Zavatski
100532845b Recolour CommentsContainer 2020-01-27 15:07:24 +03:00
Andrei Zavatski
68503bf771 Recolour CommentsShowMoreButton 2020-01-27 15:00:56 +03:00
Andrei Zavatski
12ca28ea6d Recolour CommentsHeader 2020-01-27 14:58:27 +03:00
Andrei Zavatski
ed2737e027 Recolour TotalCommentCounter 2020-01-27 14:47:47 +03:00
Dean Herbert
a5a0eaba0d
Merge branch 'master' into fix-ss-click-crash 2020-01-27 19:35:31 +09:00
Andrei Zavatski
79cdfc6dc2 Use OverlayColourProvider 2020-01-27 12:55:19 +03:00
Andrei Zavatski
20268ba45b Merge remote-tracking branch 'refs/remotes/ppy/master' into profile-scores-update-new 2020-01-27 12:37:44 +03:00
Dean Herbert
e37ae589ad
Merge branch 'master' into no-control-overlay-headers 2020-01-27 18:35:33 +09:00
Dean Herbert
d5fda053f4 Use centre origin/anchors 2020-01-27 18:09:54 +09:00
Dean Herbert
493390b750 Rename class to TimelineTickDisplay 2020-01-27 18:08:01 +09:00
Dean Herbert
084fa2f04a Add timeline beat display 2020-01-27 17:38:50 +09:00
Dean Herbert
e24c4ab901 Adjust zoom defaults for timeline to be more useful 2020-01-27 17:34:40 +09:00
Dean Herbert
df665c3a3c Move beat index colour retrieval to static function 2020-01-27 17:34:40 +09:00
Dean Herbert
508b92e611 Update beat divisor colours to be more distinguishable 
Close to osu-stable
 2020-01-27 17:34:40 +09:00
Dan Balasescu
d7b32940bd
Merge branch 'master' into fix-ss-click-crash 2020-01-27 15:40:45 +09:00
Dean Herbert
7aa5e8c23e Limit input propagation correctly 2020-01-27 14:55:47 +09:00
Dean Herbert
1c64b70b06 Revert "Fix crash due to misordered selection events" 
This reverts commit 2d74609f50.
 2020-01-27 14:53:24 +09:00
Dean Herbert
292a82ac27 Fix incorrect propagation of stream/build on initial display with build 2020-01-27 14:52:21 +09:00
Dean Herbert
834e82d543 Add comprehensive tests for changelog overlay 
Includes failing case
 2020-01-27 14:50:41 +09:00
Dan Balasescu
d0ef5a8a8c
Merge branch 'master' into breadcrumb-fix 2020-01-27 13:18:23 +09:00
smoogipoo
431b1489b9 Add test 2020-01-27 13:16:36 +09:00
Dean Herbert
1f0aaabf7b Add tests 2020-01-27 12:21:17 +09:00
smoogipoo
15fd8596c2 Fix cursor not hiding for screenshots 2020-01-27 12:16:00 +09:00
Dean Herbert
df30c4dbeb
Merge pull request #7627 from LeNitrous/scoreprocessor-comment-typo 
Fix typo on ScoreProcessor comment
 2020-01-27 10:18:56 +09:00
unknown
a6124ae499 fix typo on ScoreProcessor xmldoc 2020-01-27 08:24:15 +08:00
unknown
7f538cfa74 allow setting initial rate instead of reversing 2020-01-27 07:56:18 +08:00
Andrei Zavatski
6463a32f58 Split AccentColour setter in two lines 2020-01-26 17:42:07 +03:00
Andrei Zavatski
e54ea92c60 Use virtual property for OsuTabControl.AccentColour 2020-01-26 17:21:22 +03:00
Andrei Zavatski
7cd60e3193 Make OverlayRulesetSelector use colour provider 2020-01-26 17:07:17 +03:00
Andrei Zavatski
a72250acc6 Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-ruleset-selector 2020-01-26 16:52:56 +03:00
Andrei Zavatski
891f9a9b18 Remove unused using 2020-01-26 16:49:39 +03:00
Andrei Zavatski
cd0fcfabd9 Merge master with conflicts resolved 2020-01-26 16:35:07 +03:00
Dean Herbert
97c80529d5 Adjust wave colours slightly 2020-01-26 21:47:40 +09:00
Andrei Zavatski
49c5d5b23d Make colour provider readonly 2020-01-26 14:06:05 +03:00
Andrei Zavatski
1305634c52 Simplify colour provider caching 2020-01-26 14:02:05 +03:00
Andrei Zavatski
852e622f02 Fix broken BreadcrumbControl 2020-01-26 13:12:35 +03:00
Dean Herbert
2d74609f50 Fix crash due to misordered selection events 2020-01-26 19:06:50 +09:00
Andrei Zavatski
e442e8535b Remake OsuTabControl.AccentColour 2020-01-26 12:57:19 +03:00
Andrei Zavatski
6c1fa05804 Merge remote-tracking branch 'refs/remotes/ppy/master' into no-control-overlay-headers 2020-01-26 12:48:01 +03:00
Andrei Zavatski
8e470678c7 Rename convert() to getColour() 2020-01-26 12:42:23 +03:00
Andrei Zavatski
750a4476d8 Simplify getBaseHue function 2020-01-26 12:41:21 +03:00
Andrei Zavatski
6dee287a82 Move private methods below public 2020-01-26 12:39:15 +03:00
Andrei Zavatski
406bc23fde Rename incorrect colours 2020-01-26 12:38:20 +03:00
Andrei Zavatski
ed314ee935 Merge remote-tracking branch 'refs/remotes/ppy/master' into colour-provider-implementation 2020-01-26 12:28:46 +03:00
Dean Herbert
eabb5a8701 Use ToString instead of Substring 2020-01-26 17:40:38 +09:00
Dean Herbert
50ab5a7d07 Merge remote-tracking branch 'upstream/master' into LegacyDecoder_changes 2020-01-26 17:38:44 +09:00
unknown
12b9e8146e Merge remote-tracking branch 'upstream/master' into reverse-winding 2020-01-26 16:19:57 +08:00
TheWildTree
d2a032ca8d Move reverse-order comparer to ChannelTabControl 2020-01-25 22:16:21 +01:00
Salman Ahmed
8aec9e4500 Fix NullReferenceException on main menu for mobile game hsots 2020-01-25 11:41:26 +03:00
Andrei Zavatski
73e822e08d Make waves colour dependent on overlay colour scheme 2020-01-25 06:46:54 +03:00
Dean Herbert
fa595e07a6 Update framework 2020-01-25 12:44:48 +09:00
Andrei Zavatski
448663ae9a Merge remote-tracking branch 'refs/remotes/ppy/master' into colour-provider-implementation 2020-01-25 06:41:49 +03:00
Berkan Diler
219e14baa2 Address review and fix InspectCode 2020-01-24 17:05:27 +01:00
Dean Herbert
bc75290655 Ensure min and max stars are correctly ordered 2020-01-25 00:11:20 +09:00
Dean Herbert
92a5fbe948
Merge branch 'master' into star-filtering 2020-01-24 23:28:36 +09:00
smoogipoo
d1684a3c92 Duplicate keywords for better UX 2020-01-24 19:50:16 +09:00
smoogipoo
75d0fd0bab Rename class 2020-01-24 19:43:23 +09:00
smoogipoo
45a25214ab Make upper and lower bounds inclusive 2020-01-24 19:39:21 +09:00
Dan Balasescu
9be3d7a161
Merge pull request #7591 from peppy/improve-song-select-uiscale 
Improve song select display on ultrawide displays (or when UI scale is set low)
 2020-01-24 19:14:46 +09:00
smoogipoo
ed66ee3ba6 Allow 10.0 stars to be selectable 2020-01-24 19:12:56 +09:00
smoogipoo
2643b6fca3 Add additional keywods 2020-01-24 19:12:48 +09:00
smoogipoo
62fa619ad4 Display "no limit" for maximum stars 2020-01-24 19:08:14 +09:00
smoogipoo
9e0e7be8d0 Modernise filter implementation 2020-01-24 18:57:17 +09:00
Andrei Zavatski
d9af43da4c Remove unused usings 2020-01-24 12:55:51 +03:00
Andrei Zavatski
619c2d6d9c Merge remote-tracking branch 'refs/remotes/ppy/master' into colour-provider-implementation 2020-01-24 12:44:13 +03:00
Andrei Zavatski
e03a085d70 Make overlay elements use OverlayColourProvider 2020-01-24 12:33:34 +03:00
smoogipoo
12cc97ca31 Merge remote-tracking branch 'origin/master' into star-filtering 
# Conflicts:
#	osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapCarousel.cs
#	osu.Game/Screens/Select/Carousel/CarouselBeatmap.cs
#	osu.Game/Screens/Select/FilterControl.cs
#	osu.Game/Screens/Select/FilterCriteria.cs
 2020-01-24 18:30:52 +09:00
Andrei Zavatski
db4cd51d02 Implement OverlayColourProvider 2020-01-24 12:24:35 +03:00
Dan Balasescu
368587fc06
Merge branch 'master' into timeline-maybe 2020-01-24 18:08:29 +09:00
smoogipoo
027778acc1 Fix slider circles not being selected by default 2020-01-24 17:51:24 +09:00
smoogipoo
811ddb02a4 General refactoring 2020-01-24 17:50:36 +09:00
smoogipoo
28727bbafd Fix crash when deselecting via ctrl+click 2020-01-24 17:30:37 +09:00
Dean Herbert
f9e93e2a6a Fix regressed input handling order 2020-01-24 17:15:05 +09:00
Andrei Zavatski
1d549a0c8a Remove unused using 2020-01-24 10:46:27 +03:00
Dean Herbert
827f48c29b Adjust fade 2020-01-24 16:32:39 +09:00
Andrei Zavatski
738980e3f7 Refactor OsuTabControl.AccentColour 2020-01-24 10:31:47 +03:00
Dean Herbert
6f44f8a1ad Ensure only run once when not current screen 2020-01-24 16:27:49 +09:00
Dean Herbert
f9a54dfb1d Tidy up implementation and show on returning with new song 2020-01-24 16:27:37 +09:00
Andrei Zavatski
34ffbcf2ae Adjust xmldoc 2020-01-24 10:24:44 +03:00
Andrei Zavatski
2b941a0d52 Merge remote-tracking branch 'refs/remotes/ppy/master' into no-control-overlay-headers 2020-01-24 10:18:45 +03:00
Dean Herbert
3f6fa93365 Merge remote-tracking branch 'upstream/master' into main-menu-song-ticker 2020-01-24 16:08:34 +09:00
Dean Herbert
f5a3de3187 Merge remote-tracking branch 'upstream/master' into improve-song-select-uiscale 2020-01-24 15:44:40 +09:00
Dean Herbert
fdde4a6858 Tidy up song select hierarchy to be more readable 2020-01-24 15:44:31 +09:00
Dean Herbert
c0a233e8bb Align background wedge with carousel 2020-01-24 15:00:10 +09:00
Dean Herbert
997b49f6dc Change display to always show progress bar, only hiding seeking handle instead 2020-01-24 14:21:22 +09:00
Dean Herbert
da65fff48e Merge remote-tracking branch 'upstream/master' into collapse-graph-option 2020-01-24 13:55:42 +09:00
Dean Herbert
ea2271c905 Merge branch 'master' into timeline-maybe 2020-01-24 13:39:51 +09:00
Dean Herbert
e4702ffe9e Fix editor rate adjustment polluting global beatmap rate 2020-01-24 13:10:02 +09:00
Dean Herbert
eb5abcab8c Rename and simplify circle logic 2020-01-24 12:01:40 +09:00
Dean Herbert
851b891285 Fix incorrect insert logic 2020-01-24 12:01:14 +09:00
Dean Herbert
c390348eab Merge remote-tracking branch 'upstream/master' into colour-score-meter 2020-01-24 11:45:33 +09:00
Dean Herbert
5863576ce4 Add comment as to why counter is zeroes only in Show method 2020-01-24 11:42:33 +09:00
Berkan Diler
6658bdb223 Fix CodeFactor issues 2020-01-23 16:34:43 +01:00
Berkan Diler
316a764f6f Minor cleanups for Legacy Storyboard/Beatmap decoder 2020-01-23 16:23:53 +01:00
Andrei Zavatski
6493f24547 Add TotalCommentsCounter to CommentsContainer 2020-01-23 15:56:01 +03:00
Dean Herbert
f8cb898516 Improve song select display on ultrawide displays (or when UI scale is set low) 2020-01-23 20:03:52 +09:00
Andrei Zavatski
0c3120d965 Fix possible crash due to not loaded api 2020-01-23 12:59:53 +03:00
Andrei Zavatski
667fdb907c Call the method directly rather that trigger a bindable 2020-01-23 12:21:16 +03:00
Dean Herbert
ca94850ce4
Merge branch 'master' into view-comments-via-propery 2020-01-23 17:47:40 +09:00
Dean Herbert
a6d97f8ee6
Merge pull request #7577 from ProTheory8/mod-autoopen 
Make Difficulty Adjust mod customisation menu open automatically
 2020-01-23 17:03:04 +09:00
Dean Herbert
5646f7777e Add comment about custom SelectionHandler 2020-01-23 16:23:42 +09:00
Dean Herbert
5cadbb1ffb Move timeline blueprint to own class 2020-01-23 16:22:43 +09:00
Dean Herbert
9d90799447 Remove useless container 2020-01-23 16:20:42 +09:00
Dean Herbert
143d47ec93
Merge pull request #7538 from peppy/decouple-blueprint-container 
Decouple blueprint container to allow usage in timeline
 2020-01-23 16:13:51 +09:00
Dan Balasescu
0df9703c46
Merge branch 'master' into mod-autoopen 2020-01-23 16:04:43 +09:00
Dean Herbert
02ae92418f Merge remote-tracking branch 'upstream/master' into decouple-blueprint-container 2020-01-23 15:54:46 +09:00
Dean Herbert
289be7a17b Merge branch 'i-beat-snapping' into timeline-maybe 2020-01-23 15:45:33 +09:00
Dan Balasescu
e988976012
Merge branch 'master' into mod-autoopen 2020-01-23 15:34:19 +09:00
Dean Herbert
ccf911884b Remove passed in BaetDivisor 2020-01-23 15:31:56 +09:00
Dean Herbert
098d643955 Move beat snapping to its own interface 2020-01-23 14:39:56 +09:00
Dean Herbert
56c044c44a Move beat snapping to its own interface 2020-01-23 14:30:25 +09:00
Dean Herbert
cb09c2e144 Add support for dragging outside visible extents 2020-01-23 14:30:25 +09:00
Dean Herbert
477e1b7d27 Rename TimelineHitObjectDisplay to TimelineBlueprintContainer 2020-01-23 14:30:25 +09:00
Dean Herbert
9d2a46df89 Add beat snapping to timeline movement 2020-01-23 14:30:25 +09:00
Dean Herbert
c76f76e5aa Fix being able to drag out of the blueprint intending to be moved 2020-01-23 14:30:25 +09:00
Dean Herbert
aa1a226ab7 Remove unused ScreenSpaceStartPosition field 2020-01-23 14:30:25 +09:00
Dean Herbert
53bdf72592 Allow basic timeline selection temporal movement 2020-01-23 14:30:25 +09:00
Dean Herbert
cb6e7425ae Make dragbox stateful to fix blueprint movement 2020-01-23 14:30:25 +09:00
Dean Herbert
f0d810fe20 Follow start time and duration changes 2020-01-23 14:30:08 +09:00
Dean Herbert
63cef8b8b7 Rename nested classes to be more appropriate 2020-01-23 14:30:08 +09:00
Dean Herbert
89d90fdfa0 Fix drag not updating until mouse is moved while scrolling timeline 2020-01-23 14:30:07 +09:00
Dean Herbert
a8ec4907c4 Fix selections while scrolling timeline 2020-01-23 14:27:21 +09:00
Dean Herbert
c4395b1cea Clean up nested class implementations 2020-01-23 14:27:20 +09:00
Dean Herbert
482409e776 Colour extension bars of long objects 2020-01-23 14:26:33 +09:00
Dean Herbert
a6775d1bd3 Implement custom drag box and allow drag seeking once again 2020-01-23 14:26:33 +09:00
Dean Herbert
8ea354571c Update naming 2020-01-22 23:04:37 +09:00
Dean Herbert
8c29093d1c Merge remote-tracking branch 'smoogipoo/void-joystick-release-returns' into update-framework 2020-01-22 22:58:00 +09:00
Dean Herbert
8a7f7c5e46 Merge remote-tracking branch 'smoogipoo/void-key-up-returns' into update-framework 2020-01-22 22:57:56 +09:00
Dean Herbert
7c62cc3ac3 Merge remote-tracking branch 'smoogipoo/void-mouse-up-returns' into update-framework 2020-01-22 22:57:52 +09:00
Dean Herbert
5f8ffd9346 Merge remote-tracking branch 'smoogipoo/void-release-returns' into update-framework 2020-01-22 22:57:40 +09:00
Dean Herbert
e2c4cffc9a Update framework 2020-01-22 22:57:09 +09:00
Dean Herbert
cbba708931
Merge branch 'master' into online-mod-settings 2020-01-22 22:15:41 +09:00
smoogipoo
03b61e4a5a Throw exception rather than returning nulls 2020-01-22 20:00:36 +09:00
ProTheory8
df92b0d3dc Merge branch 'master' into mod-autoopen 2020-01-22 15:01:53 +05:00
Dean Herbert
a28934f9f2
Enforce using get-only auto property where possible (#7566) 
Enforce using get-only auto property where possible
 2020-01-22 16:38:36 +09:00
Andrei Zavatski
bf2b71f7dd Cleanup OsuTabControl.AccentColour 2020-01-22 09:36:16 +03:00
Andrei Zavatski
87af482823 Merge remote-tracking branch 'refs/remotes/ppy/master' into no-control-overlay-headers 2020-01-22 09:34:24 +03:00
smoogipoo
7b2f58eb30 Apply OnRelease method signature refactorings 2020-01-22 13:22:34 +09:00
Andrei Zavatski
14a961c95b Remove invariance in the OverlayTabItem 2020-01-22 04:41:10 +03:00
raouls555
03b6a3ddc3
Allow parsing hex colour codes with alpha 2020-01-21 23:22:08 +01:00
Dean Herbert
e3a2b20f63 Fix SelectionHandler visibility on remote selection 2020-01-22 01:32:11 +09:00
Dean Herbert
98aaf38649 Fix playfield movement regressing 2020-01-21 23:58:51 +09:00
Dean Herbert
83fa4a9bb3 Move circle size to a constant 2020-01-21 22:24:04 +09:00
Dean Herbert
a963d652bc Mark readonly 2020-01-21 20:54:50 +09:00
Dean Herbert
c88bdbd4a0 Share selected hitobjects across multiple blueprint containers 2020-01-21 20:46:39 +09:00
Dean Herbert
1ce78afa98 Disable y offset for now 2020-01-21 19:51:44 +09:00
Dean Herbert
2aa8e7dbc9
Merge branch 'master' into get-only-auto-property 2020-01-21 18:56:44 +09:00
Dean Herbert
f582c42bbd Perform deletion directly via EditorBeatmap 2020-01-21 18:56:09 +09:00
Dean Herbert
a888d148b6 Remove remaining cast 2020-01-21 18:01:10 +09:00
Dean Herbert
6187b2e77c Implement IDistanceSnapProvider in timeline for now 2020-01-21 18:00:36 +09:00
Dean Herbert
353b74b04a Handle selection events in timeline 2020-01-21 17:37:35 +09:00
Dean Herbert
79351976d5 Allow timeline content to get more localised dependencies 2020-01-21 17:37:05 +09:00
Dean Herbert
24a466ab24 Avoid null by calling initial OnDeselected later 2020-01-21 17:36:21 +09:00
Dean Herbert
8f16c1cb04 Add non-hiding selection state 2020-01-21 14:21:00 +09:00
Dean Herbert
53fe0ce790 Use AliveChildren 2020-01-21 14:20:52 +09:00
ProTheory8
61d7b63914
Readability Improvement 2020-01-21 09:30:11 +05:00
Dean Herbert
bd96cf94a6 Begin refactoring SelectionBlueprint to handle non-drawable HitObjects 2020-01-21 12:47:14 +09:00
ProTheory8
02f26e4a4d
Update comment 
Co-Authored-By: Salman Ahmed <email@iisalman.me>
 2020-01-21 08:44:22 +05:00
Andrei Zavatski
327d8c213b Rename Bar to TabControlBar 2020-01-21 06:25:13 +03:00
Andrei Zavatski
8bf19913c0 Add NotNull attribute 2020-01-21 06:03:48 +03:00
Andrei Zavatski
30edd80c8c Refactor OverlayHeader hierarchy 2020-01-21 06:00:12 +03:00
Andrei Zavatski
178a72f9b8 Make OverlayTabControl inherited from OsuTabControl 2020-01-21 05:24:49 +03:00
ProTheory8
41295bc27c Difficulty Adjust mod customisation menu opens automatically now 2020-01-20 21:06:36 +05:00
Dean Herbert
740bdee125 Apply remaining uncaught changes 2020-01-20 23:59:21 +09:00
smoogipoo
b62e3addf3 Apply input method signature refactorings 2020-01-20 20:30:25 +09:00
smoogipoo
40f502c6d1 Apply input method signature refactorings 2020-01-20 19:35:37 +09:00
smoogipoo
1b1003bd73 Refactor 2020-01-20 18:31:25 +09:00
Andrei Zavatski
843feb4e08 Add more xmldoc to ControllableOverlayHeader 2020-01-20 12:26:14 +03:00
smoogipoo
bfb056c612 Apply input method signature refactorings 2020-01-20 18:17:21 +09:00
Dean Herbert
25aff5d96e Merge remote-tracking branch 'upstream/master' into decouple-blueprint-container 2020-01-20 17:08:59 +09:00
Andrei Zavatski
17a7a75707 Merge master with conflicts resolved 2020-01-20 08:52:03 +03:00
Andrei Zavatski
11e7c8be3f Use colour schemes for OverlayRulesetSelector 2020-01-20 08:34:46 +03:00
Andrei Zavatski
6552097866 Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-ruleset-selector 2020-01-20 08:22:30 +03:00
Dean Herbert
aa0d95cdee
Merge branch 'master' into profile-scores-update-new 2020-01-20 14:15:03 +09:00
Dean Herbert
cd5290b030 Enforce using get-only auto property where possible 2020-01-20 13:50:27 +09:00
Andrei Zavatski
6875b41f74 Remove unnecessary setter 2020-01-20 07:47:49 +03:00
Andrei Zavatski
5f11084aed Refactor ProfileItemContainer to not use sounds 2020-01-19 22:57:39 +03:00
Andrei Zavatski
8906416294 ProfileItemBackground -> ProfileItemContainer 2020-01-19 22:48:11 +03:00
Andrei Zavatski
22118b7b22 Merge remote-tracking branch 'refs/remotes/ppy/master' into profile-scores-update-new 2020-01-19 22:44:40 +03:00
Andrei Zavatski
a2a2df0973 Make exception message more descriptive 2020-01-18 23:57:20 +03:00
Andrei Zavatski
1b06957566 Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-header-web-colours 2020-01-18 23:54:12 +03:00
Dean Herbert
3f2512295c
Merge pull request #7555 from peppy/update-framework 
Update framework
 2020-01-18 15:57:16 +09:00
Dean Herbert
9709b80c88 Merge branch 'fix-channeltabcontrol-test' into update-framework 2020-01-18 14:59:40 +09:00
Andrei Zavatski
969cb23671 Add reference comment 2020-01-18 08:55:29 +03:00
Andrei Zavatski
e258489bb5 Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-header-web-colours 2020-01-18 08:51:10 +03:00
Dean Herbert
5b7fd7e3ec Update framework 2020-01-18 14:42:22 +09:00
Andrei Zavatski
bab67eb399 CI fix 2020-01-18 04:12:17 +03:00
Andrei Zavatski
16cfb9310b Naming adjustments 2020-01-18 03:40:31 +03:00
Andrei Zavatski
d5a3d8dbaa Remove no longer used components 2020-01-18 03:35:47 +03:00
Andrei Zavatski
6e776d02f8 Refactor PaginatedScoreContainer to use new components 2020-01-18 03:33:02 +03:00
Andrei Zavatski
4964505c3e Implement ProfileWeightedScore component 2020-01-18 03:19:28 +03:00
Andrei Zavatski
4cdaebb42b Implement ProfileScore component 2020-01-18 02:58:10 +03:00
Andrei Zavatski
59cb93321f Implement ProfileItemBackground component 2020-01-18 01:36:14 +03:00
Lucas A
e1f172e3f8 Fix CI issues 2020-01-17 19:29:42 +01:00
Lucas A
f00938971e Apply review suggestions 2020-01-17 18:54:00 +01:00
Lucas A
0422b326ad Add visual tests 2020-01-17 18:54:00 +01:00
McEndu
159cd9a90b
Merge branch 'master' into mod-text 2020-01-17 21:42:01 +08:00
smoogipoo
2187523bf3 Fix json web requests having incorrect user agents 2020-01-17 19:21:27 +09:00
smoogipoo
2bc7458abf Add mod setting (de)serialization support 2020-01-17 13:27:47 +09:00
McEndu
6579aa144d
Merge branch 'master' into mod-text 2020-01-16 20:11:51 +08:00
mcendu
e096688ac8
simplify some stuff 2020-01-16 17:58:47 +08:00
smoogipoo
d01cc37968 Fix channel tab control test scene 2020-01-16 18:36:27 +09:00
Dean Herbert
0d8b4e7c3e Fix user agent missing in registration 2020-01-16 12:51:43 +09:00
Dean Herbert
ef735f106e
Merge pull request #7534 from revelsix/fix-tooltip-capitalization 
Fix tooltip capitalization
 2020-01-16 12:46:20 +09:00
smoogipoo
9535b3eeba Fix possible nullref on blueprint removal 2020-01-16 12:00:36 +09:00
smoogipoo
5f178b7755 General refactorings 2020-01-16 11:54:03 +09:00
Andrei Zavatski
5d4b9d11cf Throw an excepion for incorerect colourScheme values 2020-01-15 23:35:40 +03:00
Andrei Zavatski
476717e181 Make OverlayHeader use colour schemes 2020-01-15 22:41:22 +03:00
Andrei Zavatski
02af546d3c Implement web colour schemes 2020-01-15 22:22:13 +03:00
Dean Herbert
d57f55f053 Apply remaining changes required to restore previous functionality 2020-01-15 19:09:49 +09:00
mcendu
970653470c
format 2020-01-15 17:49:45 +08:00
Dean Herbert
1ec54eeaf9
Merge branch 'master' into beatmap-export 2020-01-15 15:39:35 +09:00
Dean Herbert
990f5b5f78
Implement editor beatmap saving (#7532) 
Implement editor beatmap saving
 2020-01-15 15:35:26 +09:00
Dean Herbert
6cb8b964fd
Allow changing volume in song select with arrow keys when press… (#7528) 
Allow changing volume in song select with arrow keys when pressing alt
 2020-01-15 15:12:23 +09:00
Dean Herbert
e88e40eec4 Expand on comment 2020-01-15 15:11:36 +09:00
Joehu
b42b23d65b Add comment for alt pressed 
Taken from OsuScrollContainer
 2020-01-14 20:52:15 -08:00
smoogipoo
e49701a215 Save before exporting 2020-01-15 13:48:28 +09:00
Joehu
2060be345d Move alt pressed condition to top of method 2020-01-14 20:44:55 -08:00
smoogipoo
c25fefa3ca Add beatmap package export 2020-01-15 13:44:46 +09:00
Revel
443dedfd07 undo menu item capitalization 2020-01-14 14:54:06 -05:00
Revel
a86fb2113e fix tooltip capitalization 2020-01-14 14:26:54 -05:00
mcendu
12cf304598
Update ModDaycore icon 2020-01-14 21:23:09 +08:00
mcendu
5d160376c0
nullable-ize Mod.Icon 2020-01-14 21:22:00 +08:00
mcendu
abdebcfddc
switch to changing Mod property 2020-01-14 20:11:32 +08:00
mcendu
c08fc62e00
expose setter of Mod 2020-01-14 19:59:43 +08:00
Dean Herbert
e308845faf
Add looping animation to slider reverse arrows (#7434) 
Add looping animation to slider reverse arrows
 2020-01-14 19:18:56 +08:00
smoogipoo
f695b1e055 Merge remote-tracking branch 'origin/master' into editor-beatmap-saving 2020-01-14 19:25:04 +09:00
smoogipoo
0e844b3039 Cleanup / re-protect file store 2020-01-14 19:24:53 +09:00
smoogipoo
b51575b433 Add temporary keybind for saving 2020-01-14 19:24:53 +09:00
smoogipoo
4fe5ea8e92 Clear working beatmap cache on save 2020-01-14 19:24:53 +09:00
smoogipoo
ea7510d2f5 Rename menu option 2020-01-14 19:24:53 +09:00
smoogipoo
1b3bff6fa5 Fix model file infos not being removed 2020-01-14 19:24:53 +09:00
smoogipoo
a255832195 Add beatmapmanager method for saving 2020-01-14 19:24:53 +09:00
smoogipoo
b91bcaccba Remove outdated comment 2020-01-14 19:24:53 +09:00
smoogipoo
5f5878e37e Dereference existing file 2020-01-14 19:24:53 +09:00
smoogipoo
b592b6d80d Improve robustness by always creating a new file 2020-01-14 19:24:53 +09:00
smoogipoo
609102bea3 Initial file updating implementation 2020-01-14 19:24:53 +09:00