Dean Herbert
77592ed15f
Fix comment formatting
2017-12-11 14:52:15 +09:00
Dean Herbert
de1f51269d
Merge branch 'master' into HandleInput
2017-12-11 13:53:33 +09:00
Dean Herbert
c880386fde
Merge branch 'master' into fix-crash-hidden-sets#2
2017-12-11 13:16:30 +09:00
Dean Herbert
7d8fb12332
DrawableScore -> DrawableProfileScore
...
Discern between the other class of the same name
2017-12-11 12:51:02 +09:00
Dean Herbert
0c2158ccbd
Improve display of beatmap thumbnails
2017-12-11 12:47:31 +09:00
Dean Herbert
98ce856de1
Use more sensible names for classes and methods
...
Adds xmldoc in places too.
2017-12-11 12:33:34 +09:00
Dean Herbert
507d0e3252
Use more sensible names for classes
2017-12-11 12:26:48 +09:00
Dean Herbert
9069f1ccba
Merge branch 'master' into most-played-beatmaps-section
2017-12-11 12:12:23 +09:00
Aergwyn
e629cebe31
fix MusicController ignoring Looping property of a Track
...
my fix to prevent the MusicController from constantly trying to restart a track before accidentally removed this
2017-12-10 13:22:46 +01:00
FreezyLemon
8cbd6f32cb
Moved menu music hash property back to intro and changed check (before undeleting) to "Protected" field.
2017-12-10 11:31:37 +01:00
FreezyLemon
1691a74b14
Merge branch 'undelete-button-add' of https://github.com/freezylemon/osu into undelete-button-add
2017-12-10 11:26:31 +01:00
Aergwyn
e4628427cb
moved query into schedule
2017-12-10 08:15:29 +01:00
Dean Herbert
1417dfd67a
Merge branch 'master' into fix-crash-hidden-sets#2
2017-12-10 13:28:46 +09:00
Dean Herbert
6b63452a23
Merge branch 'master' into add-testing-tag
2017-12-10 13:09:09 +09:00
Dean Herbert
668299ef84
Merge branch 'master' into fix-userprofile-unranked
2017-12-10 13:02:32 +09:00
Dean Herbert
d02e1ae896
Update RulesetInfo and add migration
2017-12-10 12:15:55 +09:00
TocoToucan
219bdbc4e1
Populate HandleInput automatically
2017-12-09 22:21:17 +03:00
Aergwyn
cdf9ea0d01
removed unnecessary variable
...
and fixed the test because of new DI letting it fail
2017-12-09 13:39:11 +01:00
Aergwyn
821154d3bb
reverted Beatmaps-setter back to its former glory
2017-12-09 08:42:59 +01:00
Dean Herbert
16b8c9bd11
Merge branch 'master' into fix-crash-hidden-sets#2
2017-12-09 11:51:47 +09:00
ColdVolcano
1f762dc6d8
Fix PreviewBar receiving a NaN Width value
2017-12-08 15:46:09 -06:00
Aergwyn
114604a642
removed unused DI
2017-12-08 14:45:40 +01:00
Aergwyn
c97646bea6
added confirmation dialog for Delete ALL beatmaps
2017-12-08 14:27:07 +01:00
Dean Herbert
c1989dbafe
Merge branch 'master' into direct-relevance-sorting
2017-12-08 22:15:57 +09:00
Dean Herbert
4160c10921
Merge branch 'master' into direct-relevance-sorting
2017-12-08 21:18:18 +09:00
Dean Herbert
40652d2e74
Merge branch 'master' into fix-importing-some-beatmaps
2017-12-08 21:18:01 +09:00
Aergwyn
dde7678095
select beatmap on import/download
2017-12-08 13:09:30 +01:00
FreezyLemon
856b56d79c
Fixed small typo.
2017-12-08 12:54:36 +01:00
FreezyLemon
e1c04a1f44
Added check for "menu music beatmap hash" before undeleting so circles.osu doesn't get imported on Undelete. Also moved the const property to BeatmapManager.
2017-12-08 12:50:04 +01:00
Aergwyn
3e417d8e30
removed specific AddBeatmap method
...
the way UpdateBeatmapSet was extended it can handle all of this and better
2017-12-08 12:47:28 +01:00
FreezyLemon
b1270a84f8
Added handling for rank == 0 (unranked), removed " #0 " from country name if that happens, also display "no rank" when hovering over history instead of " #0 "
2017-12-08 11:31:32 +01:00
FreezyLemon
4a723f7382
Added the "Service Include" tag that is used by Visual Studio's test explorer to the .csproj files
2017-12-08 11:05:00 +01:00
Dean Herbert
679134c030
Add ShortName to rulesets
2017-12-08 18:55:25 +09:00
Dean Herbert
51dc66df12
Add support for relevance based search results in osu!direct
2017-12-08 18:48:36 +09:00
FreezyLemon
d93a1fdaae
Merge branch 'master' of https://github.com/ppy/osu into undelete-button-add
2017-12-08 10:30:42 +01:00
FreezyLemon
4b3cf0773d
Various CI adjustments
2017-12-08 09:52:58 +01:00
smoogipoo
5341e79102
Remove SelectionDragger for now
2017-12-08 17:51:15 +09:00
FreezyLemon
61a6a2919e
Fixed multiple critical bugs and changed allSamples to a normal Dictionary for faster access
2017-12-08 09:41:13 +01:00
smoogipoo
faa921ba05
Fix up post-merge issues
2017-12-08 17:41:10 +09:00
FreezyLemon
9e3d439f0a
Merge branch 'master' of https://github.com/ppy/osu into taiko-hitsounds-fix
2017-12-08 08:30:02 +01:00
Dean Herbert
31884a951a
Remove "redundant" parenthesis
2017-12-08 15:53:59 +09:00
smoogipoo
f41af191ed
Merge remote-tracking branch 'origin/master' into editor-selection-tool
2017-12-08 15:13:18 +09:00
Dean Herbert
2e1dfa16a2
Fix checks disallowing import of older beatmaps with no embedded online IDs
2017-12-08 14:59:32 +09:00
Ninjaprawn
a491710fe4
Override IgnoreTooltip in DisplayableModIcon
2017-12-08 14:10:23 +11:00
Ninjaprawn
9b3e666a07
Added IgnoreTooltip to all classes required
2017-12-08 14:10:23 +11:00
Ninjaprawn
f5bea077a0
Subclass ModIcon to remove the tooltip text
2017-12-08 11:26:34 +11:00
FreezyLemon
d2f3d5a807
Added basic SampleInfo.FromSoundPoint and GetChannel methods
2017-12-07 23:09:51 +01:00
Aergwyn
105d01d85b
fix crash when restoring from any non-SongSelect-screen
...
removed unwanted refresh
2017-12-07 22:02:53 +01:00
FreezyLemon
43c270ea49
Rolled back the bad earlier implementation
2017-12-07 21:18:51 +01:00
FreezyLemon
5546b8c316
Trimmed whitespace (CI)
2017-12-07 19:55:29 +01:00
FreezyLemon
68255095a6
Renamed the IHasHoverSounds interface to ICanDisableHoverSounds and made it so that if the interface is not implemented, it is just ignored (samples will always be played). If it is implemented, the ShouldPlayHoverSound bool is decisive of whether sounds are played or not
2017-12-07 19:52:40 +01:00
FreezyLemon
c5a7f5b163
Renamed the static variables and made them readonly, aswell as other small adjustments (CI)
2017-12-07 19:39:39 +01:00
FreezyLemon
34a37935e3
Removed unused property and unnecessary return statement (CI)
2017-12-07 19:38:59 +01:00
FreezyLemon
908553ffaf
Added parameter for LoadMultiplayerLobby (CI warning for unused int)
2017-12-07 19:38:03 +01:00
FreezyLemon
e05618a415
Removed unnecessary "using" directives
2017-12-07 19:36:56 +01:00
FreezyLemon
6b0b518fd2
*ahem* REVERTED the changes to GetUserRequest because they're not needed (yet)
2017-12-07 16:58:16 +01:00
FreezyLemon
ce9b003e9a
Reverted GetUserRequest because spectating is not implemented yet, and thus the additions are not needed (yet)
2017-12-07 16:52:43 +01:00
FreezyLemon
772bba27be
Small style changes
2017-12-07 16:41:46 +01:00
FreezyLemon
2ceb073b5d
Renamed OnClick to OnLinkClicked to (what should be) obvious reasons
2017-12-07 16:30:15 +01:00
FreezyLemon
d90eb2cdce
Moved "Does this channel exist" check to ChatLine so that if a #name does not exist as a channel, it does not get added as a link (and does not contain a URL or anything else to prevent jankiness)
2017-12-07 16:26:28 +01:00
FreezyLemon
18eabd35f6
Set an empty list as default for AvailableChannels (mostly so that tests don't break, but also so that if no connection exists, the links don't break)
2017-12-07 16:25:30 +01:00
FreezyLemon
2129d6cede
Renamed the "on click" method to OnClick() and moved most of the implementation to ChatLink.
...
Also fixed the tooltip text up
2017-12-07 16:23:43 +01:00
Aergwyn
95955d68ef
rephrased description of local context checking
2017-12-07 14:14:50 +01:00
FreezyLemon
ca40db2b97
Fixed a bug where the hover wouldn't work correctly due to OsuLinkSpriteText assigning Action to a private property.
2017-12-07 13:57:29 +01:00
Aergwyn
1dcbfab18e
removed redundant comment
2017-12-07 13:56:37 +01:00
FreezyLemon
5ded6e877c
Added some tooltip text handling.
...
Also fixed a bug caused by SameLinkSprites where "this" is actually supposed to be included by just adding a manual function call.
2017-12-07 13:49:44 +01:00
Aergwyn
76c09ae59e
added comments for local context checking
2017-12-07 13:44:47 +01:00
FreezyLemon
8ba66015f4
Implemented the new IHasHoverSounds interface in a private "ChatHoverContainer" class which is now used for ChatLink instances.
...
Also moved the overhead for finding all sprites in the same line that reference the same URL to the LoadComplete (used to be every hover, now only once).
2017-12-07 13:17:40 +01:00
FreezyLemon
a8599a1b75
Implemented new interface which allows parent containers to decide on whether a "OnHover" sound should be played.
2017-12-07 13:12:36 +01:00
Dan Balasescu
9e37a122e1
Merge branch 'master' into fix-sensitivityslider
2017-12-07 21:01:53 +09:00
smoogipoo
d52b84df46
Move KeyboardStep assignment to ctor
2017-12-07 20:53:28 +09:00
smoogipoo
46cd6fdb45
Merge remote-tracking branch 'origin/master' into fix-sensitivityslider
2017-12-07 20:49:48 +09:00
Dean Herbert
24b3b10942
Move drawable assignment to load, remove depth overrides
2017-12-07 20:44:55 +09:00
Dean Herbert
8c89354b36
Remove extra whitespace
2017-12-07 20:44:38 +09:00
Dean Herbert
d36982b1d9
Merge branch 'master' into header-button-should-derive
2017-12-07 20:04:41 +09:00
Dean Herbert
f2eef6621a
Merge branch 'master' into fix-missing-metadata
2017-12-07 19:23:51 +09:00
FreezyLemon
f4f1291919
Removed "wiki:" prefix from wiki links (links are visible on tooltips so this is unnecessary now)
2017-12-07 11:23:31 +01:00
FreezyLemon
8a88040ef5
Added tooltip to links
2017-12-07 11:12:21 +01:00
FreezyLemon
bd11124e6d
Removed unnecessary copy (pass-by-reference anyways)
2017-12-07 11:12:12 +01:00
FreezyLemon
1b971c01e6
Fixed a bug where links would be out of order in their List which would cause the game to crash
2017-12-07 10:31:44 +01:00
FreezyLemon
ec8b5c2465
Permitted nulls in ChatOverlay.load() so that in testing, no "OsuGame" instance is required. Also added null checks to the links' on click actions
2017-12-07 10:31:02 +01:00
FreezyLemon
541c25e995
Renamed ChatLinkSpriteText to ChatLink for convenience
2017-12-07 10:28:12 +01:00
FreezyLemon
7bf25bdd4d
Changed it so the ":" character does not appear after usernames when the displayed message is an action (e.g. /np). Just makes more sense imo
2017-12-07 10:23:57 +01:00
Dean Herbert
c35c8263b9
Merge remote-tracking branch 'upstream/master' into input-revamp
2017-12-07 18:07:26 +09:00
Dean Herbert
2a1a9b9f1f
Fix post-merge issue
2017-12-07 17:26:39 +09:00
smoogipoo
bdf283a4e1
A bit more cleanup
2017-12-07 15:55:38 +09:00
smoogipoo
09f54b06ac
Just don't serialize Author altogether for now
2017-12-07 15:55:22 +09:00
smoogipoo
0ba8988580
Don't serialize Author + add SerializableAttributes
2017-12-07 15:32:39 +09:00
Dean Herbert
44ee11e75f
Merge branch 'master' into fix-beatmap-carousel-lag
2017-12-07 15:30:50 +09:00
smoogipoo
e573db04d4
Don't serialize HitObject.Kiai
2017-12-07 14:42:36 +09:00
smoogipoo
f5f7658e90
Don't serialize TotalBreakTime
2017-12-07 14:40:28 +09:00
smoogipoo
245b5f759f
Underscore + lowercase all keys
2017-12-07 14:37:12 +09:00
Dean Herbert
a78441bc5a
Apply changes in line with framework input adjustments
2017-12-07 13:16:59 +09:00
smoogipoo
dfc10d42e8
Merge remote-tracking branch 'origin/master' into beatmap-serialization
2017-12-07 12:49:27 +09:00
smoogipoo
d026587a91
Add flag to explicitly serialize the type version
2017-12-07 12:49:16 +09:00
smoogipoo
9e51480aa3
Cleanup TypedListConverter a bit
2017-12-07 12:27:30 +09:00
smoogipoo
f1dbcc4f1a
Remove misleading comments
2017-12-07 12:23:53 +09:00
smoogipoo
feef4b1890
Add license header
2017-12-07 12:18:00 +09:00
smoogipoo
fcfdbc8e07
Don't show the migrate button on deployed builds for now
2017-12-07 12:02:48 +09:00
smoogipoo
851c20aff0
Add a few comments
2017-12-07 11:17:32 +09:00
smoogipoo
ea2c67ca5f
Fix incorrect serialization condition
2017-12-07 11:10:46 +09:00
smoogipoo
9597f9d46b
Resharper cleanup
2017-12-07 11:10:20 +09:00
smoogipoo
0e3b001b13
Make maps with storyboards decode correctly with OsuJsonDecoder
2017-12-07 10:37:51 +09:00
Dan Balasescu
9c4ca46786
Merge branch 'master' into shader-precompile
2017-12-07 04:15:24 +09:00
smoogipoo
a8db3a9484
Add progress notification to migration
2017-12-07 04:09:03 +09:00
smoogipoo
41b607c165
Dont serialize hitobject sample properties copied from the control point
2017-12-07 03:40:43 +09:00
smoogipoo
9787788081
Revert unintended change
2017-12-07 03:39:43 +09:00
smoogipoo
4232a54b32
Make TypedListConverter not reconstruct serializers
2017-12-07 03:04:56 +09:00
smoogipoo
b6b26cfe25
Add basic method to migrate beatmaps to the new JSON format
2017-12-07 03:04:36 +09:00
FreezyLemon
94eb853d3d
Added centralised handling for some chat links
2017-12-06 16:41:57 +01:00
Dan Balasescu
8e3cce798d
Merge branch 'master' into fix-async-is-loaded
2017-12-06 23:01:38 +09:00
Dean Herbert
34596b3368
Rename and comment for clarification
2017-12-06 21:47:48 +09:00
FreezyLemon
b04ddba2a0
Added basic "on click" actions to the in-chat links
2017-12-06 10:27:30 +01:00
smoogipoo
ed5f7e5353
Make OsuJsonDecoder apply defaults similar to OsuLegacyDecoder
2017-12-06 16:28:34 +09:00
smoogipoo
f9e34dfa3d
Assume that control points are already sequentially-ordered
...
Fixes up deserializing.
2017-12-06 16:24:09 +09:00
Dean Herbert
04ae64e9fd
Add missing IsCompleted check to ensureValid
2017-12-06 16:20:49 +09:00
smoogipoo
887b81148d
Don't ignore RulesetId for now
2017-12-06 14:14:07 +09:00
smoogipoo
44edb8724f
Add JsonIgnores to CommandTimelineGroup
2017-12-06 13:48:44 +09:00
Dean Herbert
15ed3b4aac
Fix IsValueCreated method not cecking whether the async task was completed
...
Caused potential stutters for components that relied on this check.
2017-12-06 09:49:12 +09:00
smoogipoo
e199ee5225
Add a few xmldocs
2017-12-06 00:42:17 +09:00
smoogipoo
d2dc7c8937
Add OsuJsonDecoder
2017-12-06 00:38:12 +09:00
smoogipoo
b584178e85
Make Beatmap ISerializable and add more JsonIgnores
2017-12-06 00:37:37 +09:00
Dean Herbert
fb6408257a
Add shader precompile step
...
Resolves https://github.com/ppy/osu-framework/issues/1180 in a way.
2017-12-05 17:41:47 +09:00
Dean Herbert
c1b607fed9
Wait until track has restarted before continuing operation
...
I removed this from my previous PR thinking it was not required, but it turned out to be required after all. Just isn't so noticeable when it fails.
2017-12-05 14:06:40 +09:00
FreezyLemon
63a6a8b669
Fixed messages sent by yourself not being formatted
2017-12-04 19:31:48 +01:00
FreezyLemon
bb138ccaf7
Added licence header and removed unnecessary whitespace
2017-12-04 13:55:57 +01:00
FreezyLemon
9b866d2248
Made it so the link ID is always added before loading the SpriteTexts (fixed weird bug where some sprites would be white instead of blue). Also improved XML doc on TextColour
2017-12-04 13:46:07 +01:00
Dean Herbert
caee6c1cf1
Use Restart instead of Start
2017-12-04 21:40:26 +09:00
FreezyLemon
fd13bacf4a
Made default link ID -1 (if no link is present) because linkId is currently being set to link.index which can be 0.
2017-12-04 13:34:16 +01:00
FreezyLemon
cf96323980
Added new OsuLinkSpriteText.TextColour property that sets the internal content (OsuHoverContainer)'s colour instead of the whole container, so that text colour is always changed through that (e.g. link colouring, link hover fade).
...
Implemented it to be used when adding text to an OsuLinkTextFlowContainer.
2017-12-04 13:33:42 +01:00
FreezyLemon
319f43e209
Added "getIdFromUrl" call back to content.action because performance impact is small and no unnecessary id calculations are done
2017-12-04 13:29:56 +01:00
Dean Herbert
a83add8540
Tidy up events
2017-12-04 20:30:56 +09:00
Aergwyn
12665fb8cf
remove unnecessary declaration + revert accidental formatting
2017-12-04 12:11:28 +01:00
Aergwyn
011223048b
fix crash if any amount of maps were restored from main menu
...
also fixes preview not playing if an entire set is restored
2017-12-04 11:47:27 +01:00
Dean Herbert
22656233d3
Merge branch 'master' into fix-playlist-audio-issue
2017-12-04 19:24:03 +09:00
Dean Herbert
d75db5046b
Merge branch 'master' into editor-composer
2017-12-04 12:41:40 +09:00
smoogipoo
5f9de399e4
Add keydown override
2017-12-04 11:30:25 +09:00
FreezyLemon
bf97f8b1b1
Added osu.ppy.sh/ss (screenshot) URL handling and calculate ID at assignment so it's not on click anymore
2017-12-03 23:55:34 +01:00
FreezyLemon
a839d0e91d
LoadComponent before assigning URL to ensure dependency loading
2017-12-03 23:55:00 +01:00
FreezyLemon
3f336b8e61
Made the style a bit better, fixed a bug or two
2017-12-03 21:02:05 +01:00
FreezyLemon
2d270a1cfe
Added ability to open other channels from chat links.
2017-12-03 20:45:30 +01:00
Aergwyn
14096c90cc
removed looping if only one song is in the list (temporarily)
...
It had one problem in relation to SongSelect disabling it when left and in general that topic belongs to another PR.
2017-12-03 16:41:21 +01:00
Aergwyn
9d13bf3602
remove redundant expression
2017-12-03 14:35:23 +01:00
Aergwyn
dfa7448716
use ?: expression
2017-12-03 14:25:12 +01:00
Aergwyn
0c9ebcd58c
fix possible NullRef
2017-12-03 14:15:08 +01:00
Aergwyn
a1dbd7916b
fixes MusicController constantly trying to start a track
...
In Detail:
It tried to start a track if the current one ended even if no BeatmapSets were present.
Also if only one BeatmapSet is present if will loop by itself now.
2017-12-03 14:03:43 +01:00
FreezyLemon
c574cc4308
Removed unnecessary "using" statements
2017-12-03 11:16:34 +01:00
FreezyLemon
735dbddd17
Changed URL detection to be more reliable and generally work better
2017-12-03 06:52:57 +01:00
Dean Herbert
7957e55710
Merge branch 'master' into editor-composer
2017-12-03 14:47:07 +09:00
Aergwyn
ad8cd7eb5d
fix possible NullReference?
...
AppVeyor pls?
2017-12-02 17:04:42 +01:00
Aergwyn
cc76c58f5f
fall back to .osu file for storyboard if no .osb file is present
...
+ CI fixes
2017-12-02 16:05:39 +01:00
smoogipoo
2852337b04
Remove unused using
2017-12-02 20:35:47 +09:00
smoogipoo
cd20d6df16
Apply suggested changes
2017-12-02 20:31:15 +09:00
smoogipoo
c14d68e685
Use OsuColour for radio buttons
2017-12-02 20:30:18 +09:00
smoogipoo
a80059032c
Remove PlayfieldOverlay
2017-12-02 20:24:10 +09:00
smoogipoo
5a7c4772bd
Remove PlayfieldUnderlay for now
2017-12-02 19:53:20 +09:00
FreezyLemon
efe6245e53
Fixed a bug where Drawable.Width could potentially be set to NaN (0/0) by checking if last variable > 0.
2017-12-02 10:42:38 +01:00
FreezyLemon
6d9dcc6691
Added all files to the .csproj and also introduced basic action filtering when you set the URL on an OsuLinkSpriteText object
2017-12-02 09:48:55 +01:00
FreezyLemon
0aced85908
Changed the LinkID to the link's own Index instead of the previous one (just makes more sense imo)
2017-12-02 09:47:59 +01:00
FreezyLemon
d22a9df140
Added new request for getting the beatmapset from only a difficulty map ID
2017-12-02 09:47:20 +01:00
Aergwyn
e07b85311b
removed unnecessary using
2017-12-01 22:15:10 +01:00
Aergwyn
c466296b14
reverted split at Decoder, moved logic down
...
I'm done experimenting, sorry
- `Decoder` only returns a "Beatmap"`Decoder` now
- "Storyboard"`Decoder` is retrieved from a "Beatmap"`Decoder`
- moved parse methods down in the hierarchy where I forgot to do that
- renamed `OsuLegacyDecoderTest` to `LegacyDecoderTest`
2017-12-01 22:05:01 +01:00
FreezyLemon
ade7311c15
Updated implementation to be based around a "LinkId" (atm the position of the link, anything unique to a link inside its message will be fine), which does not allow matching (OnHover related) between different links
2017-12-01 21:31:12 +01:00
FreezyLemon
7699a3bb38
Merge branch 'master' of https://github.com/ppy/osu into url-parsing-support
2017-12-01 21:07:31 +01:00
FreezyLemon
7f1f886406
implemented method formatting into chat. Also added all necessary files to the .csproj
2017-12-01 21:04:24 +01:00
FreezyLemon
78ff5d81d3
Fixed casting
2017-12-01 21:03:41 +01:00
FreezyLemon
152eb83c42
Added new class for chat lines, that colour the messages after formatting. URLs will become blue, and on hover (also defined here) be turned yellow-ish
2017-12-01 20:33:27 +01:00
FreezyLemon
86302716a6
Also moved LinkText to its own file so the chat could reuse it (ProfileHeader's private class ProfileLink also still inherits from this, though)
2017-12-01 20:32:08 +01:00
FreezyLemon
1f1c7dd70f
Moved LinkFlowContainer out of ProfileHeader to make it available for other uses too (e.g. chat) and renamed it to LinkTextFlowContainer bc it can contain both links and text, not only one
2017-12-01 20:26:51 +01:00
FreezyLemon
f5f287bed5
Rolled back the idea that there should be a separate class for formatted messages
2017-12-01 20:25:02 +01:00
Aergwyn
a49f3479a2
Split retrieving of beatmap and storyboard decoder
...
Storyboard works again. Not satisfied with the solution though.
2017-12-01 19:11:52 +01:00
gtensha
de94082b1e
Fix filename casing to compile on Linux
2017-12-01 18:10:39 +01:00
Aergwyn
db50ad794e
CI adjustments
...
- removing unnecessary `using`s
- name Fields/Methods according to rules
- removing unnecessary initializations
2017-12-01 17:58:11 +01:00
Aergwyn
806c0e3b26
restructured OsuLegacyDecoder into LegacyDecoder
...
Beatmap works, Storyboard not...
2017-12-01 17:43:33 +01:00
smoogipoo
cf859a6cf2
Make the dragger attach to objects it surrounds
...
Plus a lot more implementation.
2017-12-02 00:26:02 +09:00
Dean Herbert
70b29b8b62
Merge branch 'master' into fix-set-hidden-crash
2017-12-01 23:35:48 +09:00
Dean Herbert
7532795935
Lock during validity checks
2017-12-01 22:43:49 +09:00
Dean Herbert
87b6181a19
Merge remote-tracking branch 'upstream/master' into fix-track-disposal
2017-12-01 22:36:20 +09:00
FreezyLemon
01bea3bada
Re-implemented message formatting (mostly taken from osu-stable code)
2017-12-01 10:56:48 +01:00
smoogipoo
a30270658d
Merge remote-tracking branch 'origin/master' into netstandard
2017-12-01 18:50:28 +09:00
smoogipoo
5be00cb0ec
Add todo
2017-12-01 18:40:55 +09:00
smoogipoo
0b95e36675
Fix RelativeChildSize error temporarily
2017-12-01 18:00:20 +09:00
smoogipoo
f6591851c3
Implement a selection dragger box
2017-12-01 13:15:58 +09:00
Aergwyn
7080711cb2
remove unnecessary using
2017-11-30 20:13:10 +01:00
Aergwyn
be018a63c6
remove unnecessary lines
2017-11-30 19:17:11 +01:00
Aergwyn
c16925059c
split parsing a beatmap and parsing a storyboard
2017-11-30 19:16:13 +01:00
Aergwyn
016057ab01
readd storyboard to beatmap + minor cleanup
2017-11-30 16:49:53 +01:00
smoogipoo
52ba68e25d
Add/fix up license headers
2017-11-30 22:21:02 +09:00
smoogipoo
c0c051aa32
Remove unused parameter for now
2017-11-30 21:58:41 +09:00
smoogipoo
e8cbde3ae1
Add overlay/underlay
2017-11-30 21:56:19 +09:00
smoogipoo
89772f4efd
A few resharper fixes
2017-11-30 19:54:58 +09:00
smoogipoo
7e34b0f08d
Remove SelectionTool, make Select the default tool
2017-11-30 19:53:52 +09:00
smoogipoo
e9cbef88f1
Improve selection/deselection behaviour of RadioButtonCollections
2017-11-30 19:50:07 +09:00
smoogipoo
677f3653eb
Hide osu! playfield cursor
2017-11-30 19:19:34 +09:00
FreezyLemon
b09ba19d3f
Used the already-existing private method to undelete a mapset
2017-11-30 11:02:53 +01:00
FreezyLemon
bf386598b6
Added a new "undelete" button that restores every beatmap with "DeletePending" set to true.
2017-11-30 10:58:32 +01:00
smoogipoo
efa39f38ca
CI fixes
2017-11-30 18:49:08 +09:00
smoogipoo
e5353bb53e
Add border to playfield, add shadow to toolbox buttons
2017-11-30 17:38:55 +09:00
smoogipoo
456bbe25f3
Implement toolbox into HitObjectComposer
2017-11-30 16:58:14 +09:00
smoogipoo
73e41f9dde
Add constructors to RadioButton
2017-11-30 16:57:30 +09:00
Nicolas Brassard
36cfa552f4
Fix SensitivitySlider keyboard control
2017-11-29 23:03:26 -08:00
smoogipoo
ead7456978
Add compose radio buttons + testcase
2017-11-30 15:43:19 +09:00
smoogipoo
abd6125691
Make sure that composerContainer is cleared for testing purposes
2017-11-30 14:00:17 +09:00
smoogipoo
a7a9569aee
Don't exit when we don't have composer for now
2017-11-30 13:53:57 +09:00
smoogipoo
fd3049fd65
Merge remote-tracking branch 'origin/master' into editor-composer
2017-11-30 13:47:47 +09:00
jorolf
22403cac89
Merge branch 'master' of git://github.com/ppy/osu into most-played-beatmaps-section
2017-11-29 23:09:04 +01:00
jorolf
14fdf98abc
rename GetBeatmapSetsResponse
2017-11-29 23:08:46 +01:00
Aergwyn
96f5bd3323
remove Storyboard from Beatmap, add it to WorkingBeatmap
2017-11-29 21:54:04 +01:00
Aergwyn
cd653c1cbc
split storyboard loading into GetStoryboard()
2017-11-29 21:28:02 +01:00
Aergwyn
acb2cafa58
fix wedge not appearing
2017-11-29 21:09:08 +01:00
Dean Herbert
d402222f17
Fix DisposeTrack and improve AsyncLazy to support disposal
2017-11-30 05:05:07 +09:00
smoogipoo
36be171c29
Fix up/clean up csprojs for C#7 support
2017-11-30 02:06:03 +09:00
smoogipoo
a0c3349935
Add LangVer.props and osu.Game.props for common csproj properties
2017-11-30 00:45:37 +09:00
smoogipoo
0ec10ba32d
CI fixes
2017-11-30 00:11:00 +09:00
smoogipoo
267bb75458
Merge remote-tracking branch 'Aergwyn/master' into netstandard
2017-11-29 23:45:29 +09:00
Dean Herbert
28d925dc1d
Merge branch 'master' into random-song-fix
2017-11-29 20:32:10 +09:00
Dean Herbert
b2fc50247c
Hide metadata by default to avoid initial jump when no data present
2017-11-29 20:13:00 +09:00
Dean Herbert
2b7bf285e4
Improve code quality
2017-11-29 20:07:00 +09:00
mattiapette
6dd6f08bd0
Random song selection when entering the select menu with default osu theme or invalid beatmap
2017-11-29 11:51:56 +01:00
Dean Herbert
d4c1359a49
Merge branch 'master' into update-statistics-async
2017-11-29 19:27:22 +09:00
Dean Herbert
801d81ecfc
Add a notice when not logged in
2017-11-29 19:00:08 +09:00
smoogipoo
ee35422efc
Handle rulesets that don't support composition a bit better
2017-11-29 18:38:12 +09:00
Dean Herbert
93d7cd5a6d
Merge branch 'master' into performance-calculator
2017-11-29 18:37:07 +09:00
Dean Herbert
404e7d62ff
Merge branch 'master' into mania-important-frames
2017-11-29 18:12:57 +09:00
smoogipoo
309eb4edd7
Integrate HitObjectComposer into Compose
...
Also removes the other rulesets' HitObjectComposers for now.
2017-11-29 17:46:21 +09:00
Dean Herbert
bad970d1d1
Add wait steps to ensure the player is completely loaded before continuing
2017-11-29 17:25:55 +09:00
smoogipoo
f586cbac32
Restructure Compose to use grids and eventually support HitObjectContainer
2017-11-29 16:47:52 +09:00
smoogipoo
8c30fd490c
Add HitObjectComposer class
2017-11-29 16:22:11 +09:00
FreezyLemon
bc3f11fdb8
Added PlaysSamples property to prevent certain DrawableHitObjects from playing their samples on hit. Also added this to TaikoObjects so their hitsounds won't be played (will be done by the TaikoRulesetContainer)
2017-11-29 06:24:13 +01:00
smoogipoo
1136db1556
Fix mania replays not defining important frames
...
Resolves https://github.com/ppy/osu/issues/1495 .
2017-11-29 14:20:15 +09:00
Dean Herbert
85201ea30c
Merge branch 'master' into performance-calculator
2017-11-29 13:23:40 +09:00
Dean Herbert
d1afbf8055
Load Player-based TestCases asynchronously
2017-11-29 13:10:33 +09:00
Aergwyn
3bdf82d8df
refactor newly added code to be less redundant
2017-11-28 21:38:11 +01:00
Aergwyn
6a4cc93360
fixes crash if all beatmaps of a set are hidden
2017-11-28 21:26:13 +01:00
Santeri
898c49c19d
remove unnecessary assignments
2017-11-28 16:14:32 +02:00
Dean Herbert
66fa108696
Vertically centre the panels in osu!direct
2017-11-28 22:25:20 +09:00
smoogipoo
a9cc156d7a
Merge remote-tracking branch 'origin/master' into performance-calculator
2017-11-28 21:38:26 +09:00
Dean Herbert
23b4d2163c
Fix spelling and grammar
2017-11-28 21:30:03 +09:00
Dean Herbert
bd88df2722
Add note about sequential execution of ConvertHitObject
2017-11-28 18:33:41 +09:00
Unknown
a30cd42ba2
Make retry button not look drunk.
2017-11-28 14:38:35 +05:30
Unknown
e832f163e7
Add failure test case.
...
- Only show failure if request wasn't cancelled
2017-11-28 12:09:32 +05:30
Unknown
ac1fb5118c
Fix line endings and derp that was causing request failures.
2017-11-28 11:35:39 +05:30
Dean Herbert
473eba9776
Remove precision limitation on chat height to allow pixel-perfect dragging
2017-11-28 12:09:44 +09:00
Santeri
e9277d8cb1
last directive error...
2017-11-28 00:27:58 +02:00
Santeri
49949bf698
fix minor param/directive errors
2017-11-28 00:20:44 +02:00
Santeri
86de6f8252
derives from trianglebutton rather than osubutton
2017-11-28 00:09:58 +02:00
Santeri
0a8fa2e6de
Merge branch 'master' into header-button-should-derive
2017-11-27 23:16:42 +02:00
jorolf
7f068c0c68
correct string mistake
2017-11-27 21:13:01 +01:00
Aergwyn
c058065a3a
remove unnecessary using
2017-11-27 20:24:01 +01:00
Aergwyn
d87235a289
prevent inserting duplicate metadata
2017-11-27 20:08:16 +01:00
Santeri Nogelainen
96f782e75a
fix object reference issue maybe?
2017-11-27 13:51:56 +02:00
Santeri Nogelainen
bf8d15108e
headerbutton now derives from osubutton
2017-11-27 13:39:01 +02:00
Dean Herbert
3a01bfc1ef
Remove unnecessary new prefix
2017-11-27 18:53:19 +09:00
Dean Herbert
bf5ea027ef
Add xmldoc to TriangleButton
2017-11-27 18:26:20 +09:00
Dean Herbert
96d42b3e5b
Fix redundant string interpolation
2017-11-27 18:20:13 +09:00
Dean Herbert
51372d7cda
Remove HandleInput override from TriangleButton
2017-11-27 18:19:06 +09:00
Dean Herbert
760f7d02d9
Remove AlwaysPresent (not actually required)
2017-11-27 18:12:52 +09:00
Dean Herbert
7877f42763
Merge remote-tracking branch 'upstream/master' into new-sounds-and-more
2017-11-27 17:59:24 +09:00
FreezyLemon
82a9b57277
Removed unnecessary "using" statement
2017-11-27 08:58:09 +01:00
FreezyLemon
b4513497d6
Added a textContainer reference to MetadataSection so casting is no longer required for setting new text
2017-11-27 08:52:26 +01:00
FreezyLemon
507da0dfb7
Renamed addTextAsync to setTextAsync
2017-11-27 08:48:47 +01:00
FreezyLemon
ac0942df86
Removed unnecessary private method to update the metadata
2017-11-27 08:48:12 +01:00
FreezyLemon
d49ee295d9
Removed unnecessary schedule and null checks
2017-11-27 08:47:36 +01:00
FreezyLemon
b34e724b8d
Changed MetadataSection so that the Text setter loads the new text in async before displaying it.
2017-11-27 08:18:09 +01:00
Dean Herbert
2dcc3b9e74
Merge branch 'master' into fix-missing-metadata
2017-11-27 12:28:33 +09:00
Dean Herbert
3e0f282d52
Merge branch 'master' into global-track-volume-reduction
2017-11-27 12:27:01 +09:00
Dan Balasescu
00c552dea1
Merge branch 'master' into panel-hover-effect
2017-11-27 11:14:04 +09:00
Dan Balasescu
a574b092f6
Merge branch 'master' into change-transition-blur-rate
2017-11-27 10:42:32 +09:00
Dan Balasescu
77bfc6037d
Merge branch 'master' into fix-stuck-in-play
2017-11-27 10:06:34 +09:00
Dean Herbert
c555867aaf
Merge remote-tracking branch 'upstream/master' into panel-hover-effect
2017-11-27 10:01:47 +09:00
Dean Herbert
f189de437a
Simplify blending assignment
2017-11-27 10:01:44 +09:00
Dan Balasescu
98de969b47
Merge branch 'master' into fix-reload-all-panels
2017-11-27 09:56:44 +09:00
Dan Balasescu
bb9e399808
Merge branch 'master' into fix-reload-all-panels
2017-11-27 09:50:17 +09:00
Dan Balasescu
55741f3898
Merge branch 'master' into show-converts-toggle
2017-11-27 09:41:30 +09:00
Dan Balasescu
3f65c19bce
Merge branch 'master' into fix-sprite-icon
2017-11-27 09:32:37 +09:00
jorolf
70b6071898
add license header
2017-11-26 22:13:52 +01:00
jorolf
4c68090e59
separate GetUserBeatmapsRequest and GetUserMostPlayedBeatmapsRequest
2017-11-26 22:06:03 +01:00
jorolf
02fa1f9dd6
move shared stuff between MostPlayedBeatmapDrawable and DrawableScore to DrawableBeatmapRow
2017-11-26 21:52:35 +01:00
Unknown
ae55d392de
only use == for comparion on primitive types
2017-11-26 19:37:46 +01:00
Aergwyn
ba0b16dc0b
setting BeatmapSets as list to prevent endless LINQ query chain
2017-11-26 19:35:58 +01:00
Unknown
ae201f0ef5
R#
2017-11-26 15:03:49 +05:30
Dean Herbert
671b3d01ff
Fix OsuClickableContainer's local content geting overwritten
2017-11-26 17:21:23 +09:00
Dean Herbert
9c90d9ca45
Add panel hover effects
2017-11-26 17:21:23 +09:00
Dean Herbert
5aa6615107
Add confirm-selection sound in song select
2017-11-26 17:21:22 +09:00
Dean Herbert
c5aacb75c6
Add hover sounds to mod buttons
2017-11-26 17:21:22 +09:00
Dean Herbert
880418fd0d
Split out click and hover sound layers
2017-11-26 17:21:22 +09:00
Dean Herbert
0c6a125777
Remove custom colour handling
2017-11-26 17:21:21 +09:00
Dean Herbert
ac7e373f40
Add hover/click sound effects to more stuff everywhere
2017-11-26 17:21:21 +09:00
Dean Herbert
8f57bf2498
Add choices of hover sample sets
2017-11-26 17:17:50 +09:00
Dean Herbert
8d7c891882
Add hover and click sound effects to settings sidebar buttons
2017-11-26 17:17:49 +09:00
Dean Herbert
af499df6dd
Make a base OsuButton class to handle default samples
2017-11-26 17:17:48 +09:00
Dean Herbert
ae48b85827
Don't play logo select sample when actions are playing their own
2017-11-26 17:17:47 +09:00
Dean Herbert
07d6a70028
New sound effects with better names
2017-11-26 17:17:46 +09:00
Dean Herbert
4067b6129b
Add visual highlighting on song select panel hover
...
Prerequisite for adding hover sound effects. Didn't feel right without this change.
2017-11-26 17:14:13 +09:00
Dean Herbert
df16a019ed
Add a global reduction of audio track volume
...
Music is overpowering compared to our current game samples. We will need to do further adjustments on this, but for now let's reduce the track volume globally.
2017-11-26 17:08:58 +09:00
Dean Herbert
69e388dd52
Adjust background blur rate
2017-11-26 17:08:14 +09:00
Unknown
4212315504
Use a single placeholder container for empty and retry.
2017-11-26 12:50:20 +05:30
Unknown
b261d32588
Put retry button in a BeatSyncedContainer and change error message.
2017-11-26 12:25:48 +05:30
Unknown
f4f732ca43
Remove unnecessary null check and tweak transform a bit.
2017-11-26 11:19:42 +05:30
Unknown
7be55df790
fix being stuck in gameplay if exit is pressed too fast
...
The reliance on `pauseOverlay.Alpha == 1` created a race condition that, when you pressed Exit while the pauseoverlay is still fading in, could get you stuck in gameplay.
The game wants to show the pause overlay but also thinks it's already paused and returns early.
2017-11-25 19:09:05 +01:00
Unknown
ae9ce2f122
Unbind ruleset event from leaderboard.
2017-11-25 21:23:36 +05:30
Unknown
0b3f75505e
Don't break VisualTests and add a real beatmap step.
2017-11-25 20:59:03 +05:30
Unknown
5da1466e28
requested changes
...
use IEquatable<T> instead of overriding Equals and `==` operator for primitive types.
2017-11-25 15:05:59 +01:00
Unknown
f6a33b3ea2
fix osu!direct download reloading all panels
...
This fixes the recreation of all panels when a download completes.
Also fixes NullReference when you download without ever opening the details of one Set.
2017-11-25 14:45:57 +01:00
Huo Yaoyuan
d955229ee5
Handle user rating metrics when no maps by using more linq.
2017-11-25 21:29:23 +08:00
jorolf
a1cc18f98c
Merge branch 'master' into most-played-beatmaps-section
2017-11-24 22:51:11 +01:00
jorolf
21d5d10738
replace BeatmapResponse with BeatmapInfo
2017-11-24 22:48:56 +01:00
Unknown
e723e66850
Merge remote-tracking branch 'upstream/master' into leaderboard-scopes
2017-11-24 19:14:50 +05:30
Unknown
c5a78e54e9
Add a retry button for when scores request fails.
2017-11-24 18:40:52 +05:30
Dean Herbert
09facdc838
Add a setting to toggle showing converted beatmaps
2017-11-24 18:34:20 +09:00
Dean Herbert
d6ac724f10
Merge branch 'master' into fix-sprite-icon
2017-11-24 13:41:23 +09:00
smoogipoo
3d8432aecf
Merge branch 'master' into fix-player-testcases
2017-11-24 13:23:42 +09:00
Dean Herbert
7ff39d62a1
Fix SpriteIcon potentially not updating texture during a load race condition
...
Better fix for #1577 .
2017-11-24 12:48:02 +09:00
Aergwyn
e3a230320a
compare metdata and remove duplicate from beatmap to prevent redundant storage
2017-11-23 19:46:58 +01:00
Dean Herbert
95fbe6a4a2
Update framework
2017-11-23 23:43:27 +09:00
Dean Herbert
c7a5a7cd93
Merge remote-tracking branch 'upstream/master' into fix-player-testcases
2017-11-23 23:42:19 +09:00
Dean Herbert
6ddefa5f8c
Merge branch 'master' into improve-user-ratings-calculations
2017-11-23 23:33:05 +09:00
Dean Herbert
dbb03bcff2
Handle the case where a map hasn't been rated yet
2017-11-23 23:30:57 +09:00
Dan Balasescu
dd78479a1a
Merge branch 'master' into fix-ef-issues
2017-11-23 21:18:20 +09:00
Dean Herbert
2f3e4a27c6
Merge branch 'master' into improve-user-ratings-calculations
2017-11-23 20:55:55 +09:00
Dean Herbert
9565a9c352
Fix TestCasePlayer not working as expected
2017-11-23 20:42:07 +09:00
FreezyLemon
00830c190c
Merge branch 'master' of https://github.com/ppy/osu
2017-11-23 12:39:36 +01:00
FreezyLemon
a60e53c382
Changed the text updates into a scheduled (async) operation, and implemented this in the updateStatistics and clearStats methods
2017-11-23 12:31:18 +01:00
Dean Herbert
9db6ef6657
Fix unfixed regressions
2017-11-23 20:23:47 +09:00
Dean Herbert
5ea3292dc5
Merge remote-tracking branch 'upstream/master' into load-optimization
2017-11-23 20:21:44 +09:00
Dean Herbert
292b44d896
Merge branch 'master' into fix-nullref-on-dispose
2017-11-23 19:22:23 +09:00
Dean Herbert
4ab919263d
Merge remote-tracking branch 'upstream/master' into attribute-descriptions
2017-11-23 18:53:22 +09:00
Dean Herbert
4986ad73f7
Merge remote-tracking branch 'upstream/master' into load-optimization
2017-11-23 18:44:17 +09:00
Dean Herbert
38f5c55f80
Remove not-accessed field
2017-11-23 18:11:35 +09:00
Dean Herbert
d93911ae97
Improve user ratings calculations to make more sense
...
Closes #1552 .
2017-11-23 18:10:08 +09:00
naoey
b6de1ce5b6
Handle query params better.
2017-11-23 14:36:12 +05:30
Unknown
096e98b5d3
Add game mode query to request.
...
- Also update scores when game mode is changed
2017-11-23 14:36:12 +05:30
naoey
487483eadd
Move loader hiding to a better place.
2017-11-23 14:36:12 +05:30
naoey
a58bd72c6e
Add placeholder when there are no scores.
2017-11-23 14:36:12 +05:30
naoey
fe559f4b62
Add respective query params to GetScoreRequest based on selected tab.
2017-11-23 14:36:12 +05:30
Dean Herbert
30db2ce18a
Rename KudosuValue to count and remove pointless local storage
2017-11-23 17:37:02 +09:00
Dean Herbert
cf4fc05be3
Fix nullref on disposing BeatmapSetOverlay before load
...
Only affects VisualTests
2017-11-23 17:33:46 +09:00
Dean Herbert
6d9951d9af
Use FillFlow rather than manually specifying positions
2017-11-23 17:32:41 +09:00
Dean Herbert
2ff21bbc6c
Move descriptions to constructor
2017-11-23 17:29:20 +09:00
Dean Herbert
9d481eba96
Merge branch 'master' into kudosu-section
2017-11-23 17:19:42 +09:00
FreezyLemon
2cc2323791
Style changes (removing newline from before second constructor parameter)
2017-11-23 09:12:23 +01:00
FreezyLemon
d6f532171b
Implementation fix (since the default delay is now 500 and not 0 this is necessary to ensure the same functionality)
2017-11-23 09:11:52 +01:00
Dean Herbert
6e51664544
Merge branch 'master' into beatmap-overlay-download
2017-11-23 17:11:28 +09:00
Dean Herbert
85827f83eb
Perform a reload on objects when Refreshing them
...
Previously, it was possible for an object to be "refreshed" with a stale cached state from the current thread's context.
This ensures a check against the database is performed as well.
Resolves #1562 .
2017-11-23 17:04:39 +09:00
Dean Herbert
1824540325
Schedule calls to correct thread
...
These could be fired from an async worker thread (for instance, maintenance operations).
2017-11-23 17:02:54 +09:00
Dean Herbert
288c21dfec
Move TestCase descriptions to attributes
...
Depends on https://github.com/ppy/osu-framework/pull/1186 .
2017-11-23 16:09:32 +09:00
Aergwyn
0df5432f5e
removed line that set metadata per beatmap to null
2017-11-22 21:45:18 +01:00
FreezyLemon
18b0b77f0a
Added requested changes. Mainly changing lambdas to direct function references.
2017-11-22 21:41:50 +01:00
jorolf
22348a3d67
Merge branch 'master' of git://github.com/ppy/osu into most-played-beatmaps-section
2017-11-22 21:14:11 +01:00
FreezyLemon
7d428875b8
Changed LoadWrapper back to DelayedLoadWrapper and fixed the implementation (dependent on framework change, delay now in ctor)
2017-11-22 15:46:04 +01:00
smoogipoo
de7c571be3
Merge remote-tracking branch 'origin/master' into netstandard
2017-11-22 19:46:17 +09:00
Aergwyn
e5dfe4ff2e
Make error more verbose when beatmap import fails ( #1537 )
...
Add name of beatmap set to error message if import fails
2017-11-22 19:35:25 +09:00
Dean Herbert
517a9ec40f
Merge branch 'master' into async-beatmap-panels
2017-11-22 19:05:42 +09:00
Dean Herbert
95275cd2ef
Merge branch 'master' into fix-playback-control
2017-11-22 18:49:25 +09:00
Dan Balasescu
c7a6c90249
Merge branch 'master' into working-beatmap-async-2
2017-11-22 18:32:47 +09:00
Dan Balasescu
4cbdd97ed3
Merge branch 'master' into fix-playback-control
2017-11-22 18:21:35 +09:00
Brayzure
782a739370
Fix Results Screen After Failing Last Note
...
Fixes a bug where if you failed on the last hitobject, the AllJudged event will have already been invoked.
2017-11-21 23:00:00 -05:00
Dean Herbert
36d45f633d
Reorder methods
2017-11-22 11:57:09 +09:00
Dean Herbert
e3c5a599b6
Tidy some regressions
2017-11-22 11:36:29 +09:00
Dean Herbert
27fb598352
Update colours to match design
2017-11-22 11:34:54 +09:00
Dean Herbert
0f8499c580
Rename to PlaybackControl and add a TestCase
2017-11-22 11:22:46 +09:00
Dean Herbert
ff5404e57f
Remove need for AlwaysPresent
...
Also self-contains the tab options inside the tab control.
2017-11-22 11:21:48 +09:00
Dean Herbert
855acc9401
Fix leading space before percent sign
2017-11-22 11:17:10 +09:00
Dean Herbert
c06d6d0bbb
Rename weird method
2017-11-22 10:59:31 +09:00
Dean Herbert
461c8e8be0
Clean up state change logic
2017-11-22 10:55:06 +09:00
Dean Herbert
63d366ea4b
Bindables should be readonly
2017-11-22 10:54:33 +09:00
FreezyLemon
1d41e7cc8a
Removed newline at end
2017-11-21 20:15:42 +01:00
FreezyLemon
bf0184c06d
One more small style fix
2017-11-21 19:34:01 +01:00
FreezyLemon
2203a84300
Small fixes and style corrections
2017-11-21 19:16:44 +01:00
FreezyLemon
fd7ac9b6fc
Switched to the new LoadWrapper class for asynchronous loading (LoadComponentAsync not used here since it's not possible to call that method on a component that has not finished loading, and we're in the constructor where it would be called)
2017-11-21 16:18:32 +01:00
FreezyLemon
870807c265
Switched over to the new LoadWrapper class for all delayed loading.
2017-11-21 16:17:33 +01:00
FreezyLemon
a033eb46d3
Changed to LoadComponentAsync call instead of adding an AsyncLoadWrapper instance.
2017-11-21 16:12:23 +01:00
Dean Herbert
33936b0939
Merge branch 'master' into async-beatmap-panels
2017-11-21 23:33:15 +09:00
Miterosan
b3b1f2018e
Fix osu crashing if a invalid gamerule is given in the game.ini
2017-11-21 15:13:00 +01:00
Dean Herbert
5e70b7a9f7
Add async load methods for WorkingBeatmap properties
2017-11-21 22:34:53 +09:00
Dean Herbert
2603219350
Load beatmap carousel panels asynchronously
2017-11-21 22:30:09 +09:00
smoogipoo
6686fe9ecd
Merge remote-tracking branch 'origin/master' into performance-calculator
2017-11-21 19:55:28 +09:00
smoogipoo
f9ad4b6acb
Make categoryDifficulties return doubles to improve decimal accuracy
2017-11-21 19:55:09 +09:00
Dean Herbert
aff217cd03
Fix early access to beatmap in LogoVisualisation
...
Missed this one..
2017-11-21 19:47:12 +09:00
smoogipoo
0f8d4a455a
Merge remote-tracking branch 'origin/master' into performance-calculator
2017-11-21 19:18:06 +09:00
Dean Herbert
7b916806f9
Merge branch 'master' into fix-info-wedge
2017-11-21 19:12:19 +09:00
Dean Herbert
c2fcb2f9c7
Fix info wedge not displaying
2017-11-21 18:45:12 +09:00
EVAST9919
10f730a004
Merge remote-tracking branch 'refs/remotes/ppy/master' into editor-playback-speed
2017-11-21 12:39:14 +03:00
EVAST9919
41498ffad3
Apply suggestions
2017-11-21 12:22:19 +03:00
smoogipoo
217554f587
Remove redundant interface
2017-11-21 18:06:24 +09:00
smoogipoo
0d1b5ae44f
Adjust bottom bar sizing as suggested
2017-11-21 17:51:07 +09:00
smoogipoo
238756ec5d
Merge remote-tracking branch 'origin/master' into editor-playback-speed
2017-11-21 17:41:16 +09:00
Dan Balasescu
c39e76fdea
Merge branch 'master' into sudden-death
2017-11-21 17:37:40 +09:00
Dan Balasescu
142b74cc47
Merge branch 'master' into sudden-death
2017-11-21 17:32:31 +09:00
smoogipoo
c30d31e037
Remove extra alternateFailConditions function in Player
2017-11-21 17:30:19 +09:00
smoogipoo
fea56322f0
Fix SD not failing for the first note
2017-11-21 17:28:51 +09:00
Dean Herbert
10e835aea6
Merge branch 'master' into async-beatmap-properties
2017-11-21 17:18:19 +09:00
smoogipoo
18b9828c49
Merge UpdateFailed and CheckAlternateFailConditions
2017-11-21 17:11:07 +09:00
smoogipoo
1b27ce6198
Cleanup + renaming
2017-11-21 17:09:22 +09:00
smoogipoo
44168b1654
Fix incorrect license
2017-11-21 16:42:54 +09:00
Dean Herbert
8452446803
Merge branch 'master' into user-panels
2017-11-21 16:41:48 +09:00
smoogipoo
b3bf6e7bee
Merge master into netstandard
2017-11-21 16:39:21 +09:00
smoogipoo
a66edea6dc
Move sqlite batteries to osu.Desktop
...
Fixes e_sqlite.dll not being copied to output on Windows
2017-11-21 15:33:05 +09:00
Dean Herbert
553a7947d7
Remove AsyncLoadWrapper dependence in MusicController
2017-11-21 12:42:28 +09:00
Dean Herbert
66f72baa39
Avoid LogoVisualisation accessing the track before it's loaded
2017-11-21 12:42:28 +09:00
Dean Herbert
bd616c1307
Simplify some property access
2017-11-21 12:42:28 +09:00
Dean Herbert
be9c99ade3
Remove AsyncLoadWrapper dependence
2017-11-21 12:42:28 +09:00
Dean Herbert
e7654254d2
Remove unused code
2017-11-21 12:42:28 +09:00
Dean Herbert
5db2d383ed
Remove temporary variable in beatmap background update
2017-11-21 12:42:28 +09:00
Dean Herbert
2610cadd3c
CI fixes
2017-11-21 12:11:29 +09:00
Dean Herbert
4f6263ef86
Make many internal classes and methods public
...
This is important when using dynamic compiling to rapidly iterate. Until we actually split projects out into pieces (like the abstract ruleset project we have talked about) there is no advantage to using internal in the osu! game code.
2017-11-21 12:06:16 +09:00
Brayzure
2b0295ed86
Proper Public Method Case
...
- onFailCheck to OnFailCheck
2017-11-20 20:49:31 -05:00
Brayzure
6d74fd254c
Remove Extraneous Using Statement
...
- System.Collections.Generic was leftover from a previous attempt
2017-11-20 20:25:14 -05:00
Dean Herbert
881b4aa547
Merge branch 'master' into fix-import-duplicates
2017-11-20 21:20:32 +09:00
smoogipoo
aac41d2de6
Disable resharper inspections on case-by-case basis
2017-11-20 18:55:48 +09:00
Dan Balasescu
2c4a068940
Merge branch 'master' into fix-escape-no-repeat
2017-11-20 18:37:12 +09:00
Dan Balasescu
7906bc030d
Merge branch 'master' into fix-result-screen
2017-11-20 18:19:46 +09:00
Dan Balasescu
a2e45293d6
Merge branch 'master' into fix-result-screen
2017-11-20 18:18:08 +09:00
Dean Herbert
6df18ffb7a
FocusedTextBox should not handle repeated escapes
2017-11-20 18:14:58 +09:00
Brayzure
da30d76f9b
Implement Score Processor Mod Interface
...
- Add a delegate whenever we want to register an additional fail condition
2017-11-20 02:15:29 -05:00
EVAST9919
ecc2877be6
Fix possible null and adjust timeline width
2017-11-20 09:29:26 +03:00
EVAST9919
9fe7ebc0ce
Merge remote-tracking branch 'refs/remotes/ppy/master' into editor-playback-speed
2017-11-20 09:18:22 +03:00
Dean Herbert
8919e98d13
Fix CI issue
2017-11-20 11:32:20 +09:00
smoogipoo
756f6f2d16
Remove net461 targets
2017-11-20 10:10:28 +09:00
jorolf
66c51c7b44
cleanup
2017-11-19 14:33:50 +01:00
jorolf
4281d76bcf
historical section now shows the most played beatmaps
2017-11-19 14:19:05 +01:00
jorolf
48b44e8e4e
add a user most played beatmaps request/response
2017-11-19 14:18:14 +01:00
jorolf
1f379cab8f
move BeatmapMetadataContainer to a separate class
2017-11-19 14:17:14 +01:00
jorolf
fe7f9cccaa
BeatmapSetCover can display other types of covers now
2017-11-19 14:16:00 +01:00
smoogipoo
067c018422
Cleanups
2017-11-19 17:31:35 +09:00
Dean Herbert
492120e88c
Add migration for unique constraint on online id
2017-11-19 16:02:08 +09:00
smoogipoo
d2ab0621f3
Make osu.Game + rulesets compile with netstandard
2017-11-19 13:46:51 +09:00
Aergwyn
0b5614e4ee
fix result screen not showing name of mapper
2017-11-18 22:12:15 +01:00
jorolf
9aaefb5e97
same for PaginatedScoreContainer
2017-11-18 20:09:31 +01:00
jorolf
4264641303
fix missing text appearing when request returns nothing but beatmaps are already there
2017-11-18 18:27:30 +01:00
Dean Herbert
d704e9cf7e
Ensure we correctly handle importing beatmaps/sets when the onlineID already exists locally
2017-11-19 01:45:17 +09:00
Dean Herbert
7d2bbc50a3
Add unique constraint on OnlineBeatmapID
2017-11-19 01:45:17 +09:00
Dean Herbert
9325730f5d
Fix leaderboard fadeout causing constant flow changes
...
Also cleans up logic significantly.
2017-11-19 00:53:59 +09:00
EVAST9919
2ff88c86ea
CI fixes
2017-11-18 18:53:21 +03:00
EVAST9919
915ccf3c84
Fix some layout issues
2017-11-18 18:41:00 +03:00
EVAST9919
87f1368869
Add KudosuInfo container in the kudosu section
2017-11-18 18:19:35 +03:00
Dean Herbert
60778593c3
Make pressing space twice at main menu a bit smoother
2017-11-18 22:24:51 +09:00
Dean Herbert
b835f1b708
Merge branch 'master' into fix-main-menu-osu-logo
2017-11-18 21:53:04 +09:00
Brayzure
de4d8eb196
Implement Sudden Death and Perfect
...
- Two additional fail conditions
2017-11-18 01:28:09 -05:00
EVAST9919
4ee3a89c12
Remove using
2017-11-18 08:35:00 +03:00
EVAST9919
34d8f94f99
Add track timer
2017-11-18 08:24:09 +03:00
Dean Herbert
c2d1de34fc
Fix logo not always returning to the correct state when rapidly changing menus
...
Fixes #1005 for real
2017-11-18 11:19:15 +09:00
EVAST9919
a741d6cea7
Fix incorrect score indexes in leaderboard
2017-11-18 04:46:02 +03:00
Dean Herbert
322dd1bd05
Rename variables to make more sense
2017-11-18 10:35:17 +09:00
Dean Herbert
f6ea5b0590
Remove duplicated code
2017-11-18 10:34:17 +09:00
Dean Herbert
c2b6e958f7
Merge remote-tracking branch 'upstream/master' into fix-main-menu-osu-logo
2017-11-18 10:28:00 +09:00
EVAST9919
58e7263108
CI fixes
2017-11-18 03:09:09 +03:00
EVAST9919
0b8fed4e5a
Remove useless Dimention params
2017-11-18 01:51:23 +03:00
EVAST9919
7492ab6495
Use GridContainer to place the bottom bar objects
2017-11-18 01:48:50 +03:00
EVAST9919
0cad5a5ca3
Merge remote-tracking branch 'refs/remotes/ppy/master' into editor-playback-speed
2017-11-18 01:15:50 +03:00
smoogipoo
ddf402d948
Add nullchecks in Disposal where population methods return nulls
2017-11-17 22:14:28 +09:00
smoogipoo
4ced1b6490
Use more of the properties
2017-11-17 22:10:24 +09:00
smoogipoo
dacabd4a90
Merge branch 'master' into lazy-working-beatmap
2017-11-17 21:46:19 +09:00
smoogipoo
433f4f03a1
Actually initialise DifficultyCalculator with mods
2017-11-17 20:19:49 +09:00
EVAST9919
07e0aba01c
Remove using
2017-11-17 14:10:13 +03:00
EVAST9919
1680c0905f
Fix track tempo could be less than 1 on exiting the editor
2017-11-17 14:02:07 +03:00
EVAST9919
cc04d5bc61
Add all the objects to the PlaybackContainer
2017-11-17 13:35:41 +03:00
Dean Herbert
6b591ac77f
Add missing initialisation
2017-11-17 19:17:00 +09:00
Dean Herbert
b3aae2340b
Avoid accessing beatmaps from BeatSyncedContainer until they are loaded
2017-11-17 18:38:11 +09:00
Dean Herbert
d75e3d8e81
Use lazy for WorkingBeatmap component loading
2017-11-17 18:37:46 +09:00
EVAST9919
d62da4334e
Add and place all the bottom bar objects
2017-11-17 12:26:13 +03:00
Dean Herbert
8bd59ff0b3
Fix osu! logo occasionally being in the wrong state on entering the main menu
2017-11-17 17:40:10 +09:00
smoogipoo
5d753427f6
Fix up DT not affecting hitobject densities
2017-11-17 17:28:22 +09:00
Dean Herbert
ea487861f8
Merge remote-tracking branch 'upstream/master' into optimise-leaderboards
2017-11-17 17:28:01 +09:00
smoogipoo
bf44b3d0ef
Cleanups
2017-11-17 16:54:50 +09:00
smoogipoo
825aa6570e
Fix rebase issues
2017-11-17 14:37:19 +09:00
smoogipoo
1ed2ce324f
Further improvements to TestCasePerformancePoints
2017-11-17 14:37:19 +09:00
smoogipoo
1e023f0419
Implement PerformanceCalculator testcase
2017-11-17 14:37:19 +09:00
smoogipoo
38fe95d94a
Add basic display for pp in TestCasePerformancePoints
2017-11-17 14:37:19 +09:00
smoogipoo
95fd323c6b
Fix ManiaDifficultyCalculator possibly failing due to nullref
2017-11-17 14:37:06 +09:00
smoogipoo
ac6213d1fa
CI fixes
2017-11-17 14:26:33 +09:00
smoogipoo
7892eefd68
Fix up mod application + beatmap/hitobject references
2017-11-17 14:23:52 +09:00
smoogipoo
cc1720241e
Fix DifficultyCalculator using incorrect mods
2017-11-17 12:36:51 +09:00
smoogipoo
5781b45b39
Set TimeRate after mod application
2017-11-17 12:36:17 +09:00
smoogipoo
18f2e92a48
Rework mod applications to hitobject/rulesetcontainer for DifficultyCalculator
2017-11-17 12:36:13 +09:00
smoogipoo
62155e6dd5
Make DifficultyCalculator support mod applications
...
Fixes https://github.com/ppy/osu/issues/476 .
2017-11-17 12:36:07 +09:00
EVAST9919
d301ad1435
Add supporter icon to the user panel
2017-11-16 20:06:49 +03:00
Dean Herbert
6c40cf08cc
Optimise leaderboard display
...
Adds async loading support and cleans up the code quite a bit in the process.
2017-11-16 23:22:25 +09:00
naoey
97c5956083
Make download buttons disappear instead of closing overlay.
...
- Also unbind event handlers
- Remove unused field
2017-11-16 19:17:22 +05:30
smoogipoo
f461f03b08
Make osu! compile with framework changes
2017-11-16 14:51:31 +09:00
Dean Herbert
62358c0b53
Merge branch 'master' into beatmap_scores
2017-11-16 00:45:17 +09:00
Dan Balasescu
d5bbf0fdd2
Merge branch 'master' into fix-select-no-beatmap
2017-11-16 00:26:15 +09:00
Dean Herbert
f912744acc
Fix sizing of ModIcon
2017-11-16 00:15:27 +09:00
naoey
df53b884ea
Removed unused stuff.
2017-11-15 18:00:19 +05:30
naoey
bbe555dc3c
Pass noVideo flag on...
2017-11-15 17:49:41 +05:30
naoey
5aeeb9aac6
Merge remote-tracking branch 'upstream/master' into beatmap-overlay-download
2017-11-15 17:38:38 +05:30
Dean Herbert
8011048540
Fix hard crash when clicking play button with no map selected
...
Resolves #1507 .
2017-11-15 20:03:18 +09:00
Dean Herbert
4b3e7c3613
Merge branch 'master' into overlay-improvements
2017-11-15 19:43:34 +09:00
Dan Balasescu
70d960ba73
Merge branch 'master' into remove-sub-scroll
2017-11-15 19:26:42 +09:00
Dean Herbert
fda810eb8f
Remove scrollability from sub-areas in beatmap overaly
...
The areas that are scrollable inside the beatmap overlay make for a very frustrating experience. Let's disable them for now.
2017-11-15 19:02:56 +09:00
Dean Herbert
af03d883f1
Ensure overlay containers scroll to top when new information is presented
2017-11-15 19:01:30 +09:00
Dean Herbert
8a407a68b3
Ensure only one information overlay is open at once
2017-11-15 18:49:06 +09:00
Dean Herbert
eaf1a60fe1
Merge branch 'master' into beatmap_scores
2017-11-15 17:58:07 +09:00
EVAST9919
60a2d84e09
Make the x position depends on the avatar size
2017-11-15 10:43:32 +03:00
EVAST9919
093ebb8b17
Apply suggested changes
2017-11-15 10:21:07 +03:00
EVAST9919
ea2fa5fa00
Fix wrong ratings calculations
2017-11-15 09:48:40 +03:00
Dean Herbert
7dd2720b4b
Merge branch 'master' into beatmap_scores
2017-11-15 13:41:38 +09:00
Dean Herbert
a30cf27506
Fix incorrect json mapping for preview urls
2017-11-15 13:26:11 +09:00
Dean Herbert
6933a41b75
Add back high resolution cover regressions
2017-11-15 13:26:02 +09:00
Dean Herbert
6ef60d0b4e
Merge branch 'master' into beatmap-overlay-scores
2017-11-15 13:18:32 +09:00
EVAST9919
8688afecde
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap_scores
2017-11-14 20:13:07 +03:00
Dean Herbert
fa4ae72a06
Merge branch 'master' into warning-fixes
2017-11-14 20:43:23 +09:00
Dean Herbert
4b9edc4645
Merge branch 'master' into profile_beatmaps
2017-11-14 20:27:17 +09:00
Dean Herbert
44671ad9cb
Move common width definition to base class
2017-11-14 19:03:50 +09:00
Dean Herbert
f96f7e696d
Tidy up variables a bit
2017-11-14 18:53:09 +09:00
Dean Herbert
160b988735
Reduce number of rqeuests to display beatmaps in profile
...
Comes at the cost of losing some information which should be loaded. This will be fixed at the osu-web end.
2017-11-14 18:51:41 +09:00
smoogipoo
9344502b71
More warning fixes
2017-11-14 18:05:07 +09:00
smoogipoo
bd7a6a90f5
Remove unused fields
2017-11-14 17:43:19 +09:00
EVAST9919
08ce2705c6
Add pending and graveyarded beatmapsets to profile page
2017-11-14 08:26:44 +03:00
smoogipoo
f6cbde95e2
Remove unused files
2017-11-14 13:06:40 +09:00
smoogipoo
cd8d7af9db
Clean up a few warnings in preparation for net-standard
2017-11-14 13:06:25 +09:00
EVAST9919
fa6d3f9792
Reduce isLoading calls
2017-11-13 18:49:10 +03:00
EVAST9919
d157e6baf1
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap_scores
2017-11-13 16:02:44 +03:00
Dean Herbert
0168b7eb88
Merge remote-tracking branch 'upstream/master' into profile-overlay-visual
2017-11-13 21:21:57 +09:00
Dean Herbert
97fc4347e9
Merge branch 'master' into profile-beatmaps-section
2017-11-13 20:44:57 +09:00
Dean Herbert
1a8864fa00
Merge branch 'master' into fix-replay-clock
2017-11-13 20:15:37 +09:00
Dean Herbert
ae6d4aa38d
Merge remote-tracking branch 'upstream/master' into fix-replay-clock
2017-11-13 20:03:29 +09:00
Dean Herbert
46ad986301
Merge branch 'master' into profile-beatmaps-section
2017-11-13 20:02:40 +09:00
Dan Balasescu
dbcf876294
Merge branch 'master' into fix-player-loader-song-playback
2017-11-13 19:52:28 +09:00
Dean Herbert
a2cb9d4086
Fix audio not playing during player loading
...
Regression due to changed audio initialisation logic.
2017-11-13 19:43:00 +09:00
Dean Herbert
e12d0c5875
Merge branch 'master' into rewinding-robustness
2017-11-13 19:35:48 +09:00
smoogipoo
495155874c
Make sure that the clock is only updated once per time value
2017-11-13 19:30:57 +09:00
Dean Herbert
49a5af60e2
Fix multiple order-of-execution issues with osu! logo
...
Also sets better defaults.
2017-11-13 18:43:16 +09:00
smoogipoo
0cec51110a
Fix replay clock always running 1 frame behind
...
* Fixes swells never completing.
* Fixes forward playback missing notes every now and then.
* Probably more stuff.
2017-11-13 17:55:21 +09:00
smoogipoo
ae8407a3f3
Fix nested hitobject judgements not being removed
2017-11-13 14:00:35 +09:00
smoogipoo
8adf0a6db3
Null-check in disposal of DatabasedKeyBindingInputManager
2017-11-13 13:58:44 +09:00
Dean Herbert
ee3a5b38f4
Merge branch 'master' into performance-improvements
2017-11-13 13:50:57 +09:00
Dean Herbert
e006090c5b
Fix SpriteIcon loading textures on the update thread
2017-11-13 13:13:43 +09:00
EVAST9919
51adea2a60
Convert text to a local variable
2017-11-13 05:58:19 +03:00
EVAST9919
89e9f84753
Add padding to the text container
2017-11-13 05:52:05 +03:00
EVAST9919
ec75837965
Replay speed setting visual improvements
2017-11-13 05:04:21 +03:00
Dean Herbert
11077546d1
Load logo async
2017-11-13 09:50:37 +09:00
Unknown
16e48ed187
Hook up download logic with BeatmapSetOverlay download buttons.
...
- Add noVideo option to DownloadBeatmapSetRequest
- Make Download fire an event with new download instead of returning it
2017-11-12 18:41:10 +05:30
EVAST9919
96e99d996b
Add TestCase
2017-11-12 09:01:13 +03:00
EVAST9919
1792075cf9
Loading animation fix
2017-11-12 07:50:01 +03:00
EVAST9919
7c0b13f9ef
CI fixes and minor visual improvements
2017-11-12 07:31:08 +03:00
EVAST9919
569780d37b
Move Api request outside the scores container itself
2017-11-12 07:05:50 +03:00
EVAST9919
36ac002820
Fix incorrect null check
2017-11-11 18:25:16 +03:00
EVAST9919
74bcc61a67
Fix possible overlapping
2017-11-11 07:51:07 +03:00
EVAST9919
057ada0183
Fix nulls
2017-11-11 07:50:40 +03:00
EVAST9919
072e5db6ef
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap_scores
2017-11-11 07:16:26 +03:00
EVAST9919
944bdc1c25
CI fixes
2017-11-11 07:07:41 +03:00
Dean Herbert
7d4e1b6f22
Don't require a local storage variable for restoring playback speed
2017-11-11 13:03:46 +09:00
Dean Herbert
3142832693
Add precision to playback speed
2017-11-11 13:00:29 +09:00
EVAST9919
5bf756c3c6
Add DrawableTopScore
2017-11-11 06:54:52 +03:00
Dean Herbert
3d1d66d886
Merge branch 'master' into replay_speed
2017-11-11 10:41:38 +09:00
EVAST9919
3261af5200
Add scores container
2017-11-11 03:46:06 +03:00
EVAST9919
6def49d6a4
Allow beatmap set response get online id
2017-11-11 01:51:42 +03:00
EVAST9919
4b21c83f35
Merge remote-tracking branch 'refs/remotes/ppy/master' into replay_speed
2017-11-10 17:24:26 +03:00
smoogipoo
5816d25358
Merge remote-tracking branch 'origin/master' into replay-rewinding
2017-11-10 22:19:17 +09:00
smoogipoo
5277c3c164
Set the frame time appropriately to reverse judgements a little better
2017-11-10 22:11:25 +09:00
Dan Balasescu
89fd92c15b
Merge branch 'master' into menu-select-transition-improvements
2017-11-10 21:03:24 +09:00
Dean Herbert
49731f4c05
Remove unused parmeter
2017-11-10 19:32:09 +09:00
Dean Herbert
bd2de89918
Why weren't these fixed previously
2017-11-10 19:26:25 +09:00
Dean Herbert
4a5a293376
Merge branch 'master' into replay-rewinding
2017-11-10 19:08:13 +09:00
Dean Herbert
bc54d4dd4f
Ensure we wait for audio track reset before proceeding with player execution
2017-11-10 18:32:15 +09:00
EVAST9919
7280f77a02
Trim whitespace
2017-11-10 03:06:21 +03:00
EVAST9919
c2f3971188
Extend Beatmap Set Response
2017-11-10 03:01:11 +03:00
EVAST9919
de3aea8715
Merge remote-tracking branch 'refs/remotes/ppy/master' into profile-beatmaps-section
2017-11-09 20:03:34 +03:00
EVAST9919
68c4da0810
Merge remote-tracking branch 'refs/remotes/ppy/master' into profile-beatmaps-section
2017-11-09 20:02:47 +03:00
Dean Herbert
9e82fc21ac
Improve transition when exiting song select
...
Reduces the delay before the main menu appears, but also synchronises the full main menu appearance animation with the logo's apperance.
2017-11-10 01:10:44 +09:00
Dean Herbert
5eb94f7e68
Fix loader pushing children screens before it is displayed itself
2017-11-09 23:29:56 +09:00
EVAST9919
a9b58a2ad2
Drawable score visual improvements
2017-11-09 17:12:06 +03:00
EVAST9919
c9353e3795
Fix humanizer package path
2017-11-09 15:49:17 +03:00
Dean Herbert
724540ceaa
Fix toolbar not appearing at main menu
2017-11-09 20:38:34 +09:00
Dan Balasescu
b6fa871f58
Merge branch 'master' into user-overlay-crash-fix
2017-11-09 19:24:15 +09:00
Dan Balasescu
feca7a00c2
Merge branch 'master' into user-overlay-crash-fix
2017-11-09 19:21:05 +09:00
Dan Balasescu
128143a1f4
Merge branch 'master' into null_check
2017-11-09 18:39:06 +09:00
Dean Herbert
5547348d07
Merge branch 'master' into profile-beatmaps-section
2017-11-09 18:31:46 +09:00
Dean Herbert
598e1652dc
Adjust timings
2017-11-09 18:12:33 +09:00
Dean Herbert
6d56b3c2df
Hide triangles during outro
2017-11-09 17:52:38 +09:00
Dean Herbert
e3a868744e
Merge branch 'master' into intro-v2
2017-11-09 17:48:42 +09:00
Dean Herbert
a1cee2e61e
Merge remote-tracking branch 'upstream/master' into single-osu-logo
2017-11-09 17:39:14 +09:00
Dean Herbert
4874371dbf
Rename methods back
2017-11-09 17:38:20 +09:00
smoogipoo
66ee9d1631
Update in-line with framework changes
2017-11-09 17:04:04 +09:00
smoogipoo
348083f589
Update with framework state transformation
...
Removes explicit initial state setting in DrawableOsuHitObjects.
2017-11-09 14:05:05 +09:00
Dean Herbert
8c0eee84a2
Merge branch 'master' into config-precision
2017-11-09 13:55:52 +09:00
EVAST9919
edeeefea3b
Fix missing text has been shown before api request has been completed
2017-11-08 20:42:24 +03:00
EVAST9919
2e67685762
Merge remote-tracking branch 'refs/remotes/ppy/master' into profile-beatmaps-section
2017-11-08 20:17:49 +03:00
Dean Herbert
e2005c4431
Add comment explaining necessity of AlwaysPresent for now
2017-11-08 20:36:18 +09:00
Dean Herbert
df6c808d28
Adjust animation to designer-san's liking
2017-11-08 17:04:36 +09:00
Dean Herbert
cabb22b6d1
Merge branch 'single-osu-logo' into intro-v2
2017-11-08 16:43:07 +09:00
Dean Herbert
c2d4a213b1
Rename logo-related methods
2017-11-08 16:34:03 +09:00
Dean Herbert
a8bacd1ed4
Remove unnecessary private method /shrug
2017-11-08 14:46:47 +09:00
Dean Herbert
7ad498cb29
Remove unused puzzle pieces
2017-11-08 14:45:01 +09:00
Dean Herbert
90fec5f370
Merge branch 'master' into single-osu-logo
2017-11-08 14:37:20 +09:00
Dean Herbert
41fcecf759
Add intro in to actual game
2017-11-08 14:31:11 +09:00
Dean Herbert
d8d7165164
Add a test case which starts the game
2017-11-08 13:52:44 +09:00
Dean Herbert
713d730d10
Simplify restart process and defaults initialisation
2017-11-08 13:32:03 +09:00
Dean Herbert
1771e003f7
Simplify more
2017-11-08 12:13:30 +09:00
Dean Herbert
419f041291
Fix text alignment
2017-11-08 12:12:27 +09:00
Dean Herbert
f83c095269
Simplify more
2017-11-08 12:10:32 +09:00
Dean Herbert
89426e1c11
Simplify lines
2017-11-08 12:07:52 +09:00
Dean Herbert
7dcdf78608
Make bars and circles better
2017-11-08 12:06:22 +09:00
Dean Herbert
a72e798b85
bar -> line
2017-11-08 11:21:50 +09:00
Dean Herbert
97b238d084
Simplify intro sequence a bit more
2017-11-08 11:20:21 +09:00
Dean Herbert
552a361a24
Merge remote-tracking branch 'upstream/master' into intro-v2
2017-11-08 11:08:42 +09:00
Miterosan
567cd6316c
beatmap can not be null in DifficultyColouredContainer.cs
2017-11-07 23:17:45 +01:00
Miterosan
b2e49c1e71
line can not be null in OsuLegacyDecoder.cs
2017-11-07 23:17:26 +01:00
Miterosan
13e75780d7
beatmap and stream can not be null in OsuLegacyDecoder.cs
2017-11-07 23:17:07 +01:00
Miterosan
1e6f1d07d2
line can not be null in OsuLegacyDecoder.cs
2017-11-07 23:16:42 +01:00
Miterosan
a15ab785f2
palette can not be null in DifficultyColouredContainer.cs
2017-11-07 23:16:19 +01:00
Miterosan
36ce287b88
panels can not be null in BeatmapSetHeader.cs
2017-11-07 23:15:51 +01:00
Miterosan
0f539d24f0
Localisation can not be null in BeatmapSetHeader.cs
2017-11-07 23:15:21 +01:00
Miterosan
dc317139c9
beatmap can not be null in BeatmapSetHeader.cs
2017-11-07 23:15:02 +01:00
Miterosan
bc94179032
workingbeatmap can not be null in BeatmapBackgroundSprite.cs
2017-11-07 23:14:22 +01:00
Miterosan
d7dee57886
set can not be null in BeatmapSetCover.cs
2017-11-07 23:13:56 +01:00
Miterosan
dd3874daa8
beatmap can not be null in BeatmapPanel.cs
2017-11-07 23:13:32 +01:00
Miterosan
289a1346fc
beatmap can not be null in DifficultyIcon.cs
2017-11-07 23:13:09 +01:00
Miterosan
a8acea9cdb
stream can not be null in BeatmapDecoder.cs
2017-11-07 23:12:30 +01:00
Miterosan
8dc24a52a7
beatmap and line can not be null in OsuLegacyDecoder.cs
2017-11-07 23:11:33 +01:00
Miterosan
d27dced3af
beatmap and line can not be null in OsuLegacyDecoder.cs
2017-11-07 23:11:16 +01:00
Miterosan
34083baa4d
beatmap and line can not be null in OsuLegacyDecoder.cs
2017-11-07 23:11:04 +01:00
Miterosan
0287d3d7a0
beatmap and line can not be null in OsuLegacyDecoder.cs
2017-11-07 23:10:54 +01:00
Miterosan
cf296d4bb2
beatmap and line can not be null in OsuLegacyDecoder.cs
2017-11-07 23:10:41 +01:00
Miterosan
2f47b336e2
beatmap and line can not be null in OsuLegacyDecoder.cs
2017-11-07 23:10:30 +01:00
Miterosan
080c3fabba
BeatmapSet and manager can not be null in BeatmapGroup.cs
2017-11-07 23:10:06 +01:00
Miterosan
1f620886cb
beatmap and line can not be null in OsuLegacyDecoder.cs
2017-11-07 23:09:16 +01:00
Miterosan
840946d160
list can not be null in ControlPointInfo.cs
2017-11-07 23:08:24 +01:00
Miterosan
e430256b09
User and colors can not be null in UserPanel.cs
2017-11-07 22:51:06 +01:00
Miterosan
2518b5e9a0
Textures in UserCoverBackground.cs can not be null
2017-11-07 22:50:45 +01:00
Miterosan
d5b275fa53
The TextureStore in Country.cs can noit be null.
2017-11-07 22:50:00 +01:00
Miterosan
e417eceb98
Texture in Avatar.cs can not be null.
2017-11-07 22:49:32 +01:00
EVAST9919
13cc1fcc92
Fix wrong index offset
2017-11-07 14:30:44 +03:00
EVAST9919
8e806cd11c
Simplify moving ball behaviour
2017-11-07 13:43:02 +03:00
EVAST9919
a46dbee532
Add Humanizer package
2017-11-07 12:38:10 +03:00
EVAST9919
5946585a6f
Apply suggested changes
2017-11-07 12:19:23 +03:00
Dean Herbert
5af2cc29f5
Merge branch 'master' into song_select_delete
2017-11-07 16:42:40 +09:00
EVAST9919
1b0e7e7145
Undo some useless changes
2017-11-07 03:44:21 +03:00
EVAST9919
60e6177b7f
Use null propagation
2017-11-07 03:26:47 +03:00
EVAST9919
1063e18566
Don't show graph at all if there's no data to use
2017-11-07 03:16:27 +03:00
EVAST9919
461baf3b97
CI fixes
2017-11-07 03:05:12 +03:00
EVAST9919
28167388d6
Remove useless calls
2017-11-07 02:53:07 +03:00
EVAST9919
d10dcd82bc
Rank Line Graph improvements
2017-11-07 02:39:48 +03:00
EVAST9919
a12052ac51
CI fix
2017-11-06 22:18:37 +03:00
EVAST9919
5d846bff7b
Add (temporarily?) subrequest for each item to provide correct beatmap information
2017-11-06 22:05:04 +03:00
EVAST9919
b8b5c67cd2
Apply suggestion concerning the BeatmapSetType enum
2017-11-06 21:46:28 +03:00
EVAST9919
ebaef86432
Fix hard crash when opening beatmap with zero playcount in beatmap overlay
2017-11-06 21:28:01 +03:00
EVAST9919
21d8a18812
Merge remote-tracking branch 'refs/remotes/ppy/master' into profile-beatmaps-section
2017-11-06 20:20:58 +03:00
Dan Balasescu
09b47db80e
Merge branch 'master' into config-precision
2017-11-06 15:34:19 +09:00
Shane Woolcock
a7c7f7d690
Add precision values to some of the config bindables
2017-11-06 16:58:17 +10:30
smoogipoo
2fbd490626
Make RemainingTimeCounter into a Counter
2017-11-06 14:58:05 +09:00
Dan Balasescu
e5aa0db6f7
Merge branch 'master' into auto-deleting-fix
2017-11-06 13:45:55 +09:00
smoogipoo
d24cd00a01
Merge remote-tracking branch 'origin/master' into settingsitem-getboundcopy
2017-11-06 12:39:35 +09:00
EVAST9919
1afe2c18be
Fix osu! deleting beatmaps on startup if MenuMusic is disabled
2017-11-04 19:42:28 +03:00
EVAST9919
729777a7e0
Remove useless variable
2017-11-04 18:38:02 +03:00
EVAST9919
48c39b1d19
Add "Ranked & Approved Beatmaps" section
2017-11-04 00:53:58 +03:00
EVAST9919
761d885167
Add Favourite Beatmaps section in UserProfileOverlay
2017-11-03 20:25:21 +03:00
smoogipoo
6fba6eddbf
Merge branch 'text-transform' into replay-rewinding
2017-11-04 00:48:42 +09:00
smoogipoo
edd0d166b1
Add text transforms to OsuSpriteText
2017-11-04 00:42:36 +09:00
smoogipoo
3b189c1ffe
Fix BreakOverlay not properly working with rewinding
...
In various ways:
* It wouldn't show up if rewound after the break was complete.
* The time would increase backwards if rewind happened during a break.
* Etc.
* Basically the fix is to use transformations everywhere. BreakOverlay could be refactored further, but this is enough to make it work for now.
2017-11-03 21:20:36 +09:00
Dean Herbert
3adcfa8c38
Many fixes
2017-11-03 17:54:35 +09:00
Dean Herbert
2f205d1f63
Merge branch 'single-osu-logo' into intro-v2
2017-11-03 15:37:24 +09:00
Dean Herbert
6a206c616b
Update in line with framework changes
2017-11-03 14:34:12 +09:00
smoogipoo
0620d0bd7a
AllJudged does not need to be virtual anymore
2017-11-02 21:56:09 +09:00
smoogipoo
326891f51c
Add "Final" to better determine when to stop processing the hitobject
2017-11-02 21:54:28 +09:00
Dean Herbert
8f78d84ad6
Make intro resume slower
2017-11-02 21:52:23 +09:00
Dean Herbert
c99ffb4aa3
Fix potential nullref
2017-11-02 21:52:12 +09:00
Dean Herbert
9b2d41f4eb
Fix quick retry looking bad
2017-11-02 21:52:01 +09:00
smoogipoo
8ee13ef0ae
Properties are unnecessary
2017-11-02 21:33:31 +09:00
smoogipoo
fe00ac7e41
Make DrawableHitObject/ScoreProcessor support rewinding
2017-11-02 21:21:07 +09:00
Dean Herbert
b8b05fe8d2
Make the osu! logo shared game-wide
...
There should only ever be one osu! logo. It is now passed around between screens in a superfluous manner.
2017-11-02 20:38:02 +09:00
Dean Herbert
b0785b2f09
Fix a possible horrendous endless auth loop
2017-11-02 20:26:26 +09:00
smoogipoo
f219b7f9fb
Fix bonusScore being stored locally instead of incrementally changing
2017-11-02 19:31:30 +09:00
Dan Balasescu
05e5e3d279
Merge branch 'master' into fix-visualtests-configuration
2017-11-01 17:33:15 +09:00
Dean Herbert
ed89f03900
Make ParallaxContainer public
2017-11-01 17:10:59 +09:00
Dean Herbert
6fa02ce9bb
Use internal less
...
Allows for more dynamic compilation to succeed. No reason for using internal here anyways.
2017-11-01 17:10:54 +09:00
Dean Herbert
27156aeb93
Fix the shit
2017-11-01 17:07:03 +09:00
Dean Herbert
fd5bc6fe58
Make ParallaxContainer public
2017-11-01 17:06:55 +09:00
Dean Herbert
09e0bd7a78
Remove unused class file
2017-11-01 16:58:12 +09:00
Dean Herbert
15197b9a76
Use internal less
...
Allows for more dynamic compilation to succeed. No reason for using internal here anyways.
2017-11-01 16:57:59 +09:00
Dean Herbert
d6c86ebcb1
Merge branch 'master' into intro
2017-11-01 15:38:14 +09:00
Dean Herbert
8138796ee3
Fix VisualTests configuration being completely wrong
2017-11-01 14:53:33 +09:00
smoogipoo
687a850216
Merge remote-tracking branch 'origin/master' into migrate-osu-game
2017-11-01 12:57:55 +09:00
smoogipoo
3462fdcad9
Remove some apparently unneeded references from osu.Game
2017-10-31 16:57:01 +09:00
smoogipoo
9b1ec83eb4
Propagate sqlite build assets to parent projects
2017-10-31 16:56:50 +09:00
Dean Herbert
ca8afc0c80
Merge remote-tracking branch 'upstream/master' into intro
2017-10-31 15:49:28 +09:00
Dean Herbert
ba7c0695c5
Merge branch 'master' into delayed-load
2017-10-30 22:48:33 +09:00
smoogipoo
7b72c6d811
Merge branch 'master' into webrequest-updates
2017-10-30 22:39:01 +09:00
smoogipoo
04b271cce9
Migrate osu.Game project to VS2017 project structure
2017-10-30 22:24:11 +09:00
smoogipoo
437b6d67a4
Merge branch 'webrequest-updates' into migrate-osu-game
2017-10-30 22:10:30 +09:00
smoogipoo
cd5324f1d1
Update API code to use the new Add* methods on requests
2017-10-30 21:33:44 +09:00
Dean Herbert
f486ab1f6c
Merge branch 'master' into song_select_delete
2017-10-30 21:07:02 +09:00
Dean Herbert
d871c3fdda
Fix test not working due to null refs
2017-10-30 20:55:23 +09:00
Dean Herbert
d8b3f984f5
Merge branch 'master' into webrequest-updates
2017-10-30 19:50:45 +09:00
Dean Herbert
1ae0eff6ad
Add some sanity to request/drawable creation logic
2017-10-30 19:40:42 +09:00
Dean Herbert
23a729c83a
Make avatars use a delayed load wrapper
2017-10-30 19:39:23 +09:00
Dean Herbert
a51e64b2d1
Remove unnecessary schedule
2017-10-30 19:16:16 +09:00
Dean Herbert
069f4b1fcf
Make DrawableScore abstract and move shared class to own file
2017-10-30 19:15:19 +09:00
Dean Herbert
096998d5f4
Fix user bindable being assigned rather than bound
2017-10-30 19:08:15 +09:00
Dean Herbert
b660366d96
ScoreContainer -> PaginatedScoreContainer
2017-10-30 19:06:40 +09:00
Dean Herbert
dce7d1c910
Move pp score representation to own file
2017-10-30 19:05:13 +09:00
Dean Herbert
fcb88de626
Merge branch 'master' into recent-scores
2017-10-30 18:48:26 +09:00
smoogipoo
f94505243d
Use AllowRetryOnTimeout where to maintain previous functionality
2017-10-30 17:28:53 +09:00
Dean Herbert
7bc0ef44f2
Merge branch 'master' into beatmap-preview-fix
2017-10-30 16:22:47 +09:00
Dean Herbert
eccf56a551
Merge branch 'master' into settingsitem-getboundcopy
2017-10-30 16:20:39 +09:00
smoogipoo
b59401357e
Remove singular RetryCount usage, update framework
2017-10-27 12:53:08 +09:00
EVAST9919
a7bcae4869
Add startup value for the slider
2017-10-26 15:18:06 +03:00
EVAST9919
08637253df
Merge remote-tracking branch 'refs/remotes/ppy/master' into replay_speed
2017-10-26 15:04:44 +03:00
EVAST9919
189b51551d
Merge remote-tracking branch 'refs/remotes/ppy/master' into intro
2017-10-26 14:40:40 +03:00
Shane Woolcock
22d222354c
Change SettingsItem to use GetBoundCopy to ensure it has the right class for numeric bindables
2017-10-26 18:45:20 +10:30
smoogipoo
bfee3317aa
Update WebRequest usage in-line with framework
2017-10-26 16:37:44 +09:00
DerpyCrabs
de10300675
Fix case-sensitive linux build
2017-10-26 10:44:38 +07:00
Jorolf
b2c3ba05d7
remove redundant stuff
2017-10-25 20:15:45 +02:00
Jorolf
0449639f41
remove inner classes and make User property a bindable
2017-10-25 20:07:12 +02:00
Dean Herbert
b89112c2a1
Fix incorrect alignment
2017-10-25 23:56:18 +09:00
Dean Herbert
41cc2f725a
Fix incorrect comment
2017-10-25 23:56:10 +09:00
Dean Herbert
4d4b505ef7
Add AsNoTracking to common read-only queries
2017-10-25 23:56:05 +09:00
Dean Herbert
c260b0d2a5
Explicitly return list
2017-10-25 23:53:09 +09:00
Dean Herbert
e62928102c
Merge remote-tracking branch 'upstream/master' into user-iqueryable
2017-10-25 23:49:56 +09:00
Dean Herbert
ead3ca1f27
Merge branch 'master' into fix-threaded-context-issues
2017-10-25 23:42:08 +09:00
Dan Balasescu
e2ee76332f
Merge branch 'master' into fix-threaded-context-issues
2017-10-25 23:30:28 +09:00
Dean Herbert
4ef80ee6c4
Fix potential incorrect update in KeyBindingStore
2017-10-25 23:21:47 +09:00
Dan Balasescu
ffec5dd717
Merge branch 'master' into add-missing-indices
2017-10-25 22:58:26 +09:00
Dean Herbert
6f7ba55f80
Fill out xmldoc
2017-10-25 22:19:47 +09:00
Dean Herbert
c1d133977e
FirstOrDefault -> SingleOrDefault
2017-10-25 22:17:17 +09:00
Dean Herbert
da01e81fc4
Async direct panel lookup
2017-10-25 22:14:47 +09:00
Dean Herbert
ed84cd2035
Greatly improve performance of direct panel loading
...
Still needs to be async'd
2017-10-25 22:14:41 +09:00
Dean Herbert
90af472717
Cache available rulesets as they are pretty static for now
2017-10-25 22:14:36 +09:00
Dean Herbert
2d0f4d3859
Fix OnlineBeatmapSetID not being correctly populated
2017-10-25 22:14:16 +09:00
Dean Herbert
195d75d045
Flip flop let's expose IEnumerables for now
2017-10-25 22:12:20 +09:00
Dean Herbert
4e1922c556
Fix query methods not using IQueryable/Expressions
...
No database-level where clauses were being used in many cases they should be.
2017-10-25 22:10:45 +09:00
Dean Herbert
a5fb700229
Fix KeyBinding updates
2017-10-25 22:08:56 +09:00
Dean Herbert
5001e9f264
Fix Hide/Restore/Delete etc.
2017-10-25 22:08:34 +09:00
Dean Herbert
8452e315f4
Allow "refreshing" instances via DatabaseBackedStore
2017-10-25 22:06:25 +09:00
Dean Herbert
487b888f4f
Add missing database indices
...
Also add missing unique constraints where applicable.
2017-10-25 22:05:10 +09:00
Dan Balasescu
d927e57af6
Merge branch 'master' into fix-direct-import-stall
2017-10-25 21:48:27 +09:00
Dan Balasescu
946288ba2e
Merge branch 'master' into fix-direct-import-stall
2017-10-25 21:46:00 +09:00
Dan Balasescu
05e1a7a5f8
Merge branch 'master' into online-beatmap-id-sanity
2017-10-25 21:38:33 +09:00
TocoToucan
5107489cda
Remove DatabaseBackedStore Reset functions
2017-10-25 15:12:14 +03:00
TocoToucan
63fe569afa
Remove DatabaseBackedStore Prepare functions
2017-10-25 14:53:20 +03:00
Dean Herbert
66f1d2fb2e
Ensure all parsed "Online" IDs are above zero or null
...
Some .osu file sources (or database sources) may be in a bad state. We want to get these ones right as they cannot be enforced by the database itself (via FKs or constraints).
2017-10-25 14:34:39 +09:00
Dean Herbert
f1f7557f6e
Add importing state to download notification
2017-10-25 11:49:00 +09:00
Dean Herbert
040fa3aa15
Fix import after direct download being scheduled to update thread
...
Caused a stall as experienced in #1364 .
2017-10-25 11:43:30 +09:00
Dean Herbert
c765785d00
Mark several long-running tasks as long-running
2017-10-25 11:42:55 +09:00
Jorolf
a2dfef301a
remove unused parameters
2017-10-24 20:56:05 +02:00
Jorolf
f65d4b626e
don't use c# 7 feature
2017-10-24 20:46:15 +02:00
Jorolf
9109b1b3f1
Merge branch 'master' of git://github.com/ppy/osu into recent-scores
2017-10-24 20:34:26 +02:00
Jorolf
aadc699e73
show recent scores
2017-10-24 20:31:38 +02:00
Dean Herbert
15b9307b6c
Fix WaveOverlayContainer appearing incorrectly on first PopIn
2017-10-24 20:26:27 +09:00
Dean Herbert
808c97fcb4
Fix multiple requests potentially being triggered during connect sequence
...
As the Success callbacks happen in a scheduled context, if the Update thread is in a stalled state, this loop can generate many unnecessary API requests.
2017-10-24 17:13:59 +09:00
Dean Herbert
4eef9c0067
Merge branch 'master' into bugfix-nofail-scoreprocessor
2017-10-24 15:48:42 +09:00
Jacob Odgård Tørring
493fe1d621
Makes HasFailed private set and removes alreadyFailed
2017-10-24 08:34:10 +02:00
Jacob Odgård Tørring
86419e0ded
Merge remote-tracking branch 'upstream/master' into bugfix-nofail-scoreprocessor
2017-10-24 08:05:31 +02:00
Dean Herbert
542c6501a7
Fix VolumeControl and OnScreenDisplay being added to the wrong container
2017-10-24 13:10:17 +09:00
Dean Herbert
635f26badc
Remove unnecessary using
2017-10-24 11:59:57 +09:00
Dan Balasescu
ecd641c44a
Merge branch 'master' into startup-load-improvements
2017-10-24 11:54:31 +09:00
Dean Herbert
9ec870a821
Add comment pertaining to why Schedule() is required
2017-10-24 11:50:18 +09:00
Dean Herbert
e98bfec644
Remove Thread.Sleep and tidy up new method
2017-10-24 11:40:38 +09:00
Dean Herbert
00bb82215b
Merge branch 'master' into revert-to-default-glow
2017-10-24 10:48:08 +09:00
Dan Balasescu
9eab2deee7
Merge branch 'master' into config-slider-keyboardstep
2017-10-24 10:10:39 +09:00
Dean Herbert
0e04260b3c
Move ToolbarUserArea initialisation to BDL
2017-10-24 10:08:42 +09:00
Dean Herbert
777cdcbdc1
Load even more components async
2017-10-24 10:08:42 +09:00
Dean Herbert
9b7d569a65
Add a single-file loading sequence for main components
...
This stops aync loading from getting overloaded with tasks, which was happening previously.
2017-10-24 10:08:42 +09:00
Dan Balasescu
cf6079fd07
Merge branch 'master' into import-test-fixes
2017-10-24 09:36:48 +09:00
Dean Herbert
4e4f6c1a47
Merge branch 'master' into update-framework
2017-10-24 08:14:58 +09:00
Dean Herbert
26d8b67f25
Merge branch 'master' into config-slider-keyboardstep
2017-10-24 08:14:56 +09:00
Dean Herbert
b877177b83
Merge branch 'master' into bugfix-nofail-scoreprocessor
2017-10-24 08:14:54 +09:00
Dean Herbert
ffe94ea880
Merge branch 'master' into revert-to-default-glow
2017-10-24 08:14:53 +09:00
Dean Herbert
22b3f5dd19
Merge remote-tracking branch 'upstream/master' into import-test-fixes
2017-10-23 22:03:37 +09:00
Dean Herbert
dc9c474033
Move all TestCases to Testing project
...
This allows tests to successfully retrieve rulesets, as they are referenced.
2017-10-23 19:32:02 +09:00
Dean Herbert
1a3debc91d
Ensure thread safety on shared contexts
...
Let's call this one temporary.
2017-10-23 17:56:04 +09:00
Dean Herbert
e7931ef4c7
Add a default icon when a ruleset isn't present
2017-10-23 17:32:28 +09:00
Dean Herbert
df20845fbb
Share one context per file store for performance reasons
...
There is now a CreateContext method for retrieving a stand-alone context for threaded use.
We may want to add safety against this context being disposed (or just return a fresh one if it is).
2017-10-23 16:35:35 +09:00
Dean Herbert
4a68dd88cb
Centralise BeginTransaction and disable transaction use for now
2017-10-23 14:53:13 +09:00
Dean Herbert
8fab6abf90
Update WebRequest usage in line with framework changes
2017-10-23 14:46:17 +09:00
Shane Woolcock
ea2934d92c
Add KeyboardStep values for configuration options
2017-10-23 16:06:08 +10:30
Dean Herbert
1b455019a8
Merge remote-tracking branch 'upstream/master' into revert-to-default-glow
2017-10-23 11:56:17 +09:00
Nabile Rahmani
5af6fb41f5
Fixed .NET Standard build on Linux.
2017-10-23 02:03:46 +02:00
Jacob Odgård Tørring
9b54e834d9
Implements virtual Failcondition in scoreprocessor and enforces nofail in UpdateFailed
2017-10-22 20:32:59 +02:00
Dean Herbert
c089842adf
Merge branch 'master' into import-test-fixes
2017-10-23 02:21:42 +09:00
DerpyCrabs
cf468d6708
Fix linux build
...
Build is failing on linux because of case sensitive file system. This change fixes it.
2017-10-22 20:14:38 +07:00
Dean Herbert
61c1dd3636
Don't output database logs unless DEBUG_DATABASE is specified compile-time
2017-10-22 19:46:08 +09:00
Dean Herbert
7ba22f0028
Merge remote-tracking branch 'upstream/master' into import-test-fixes
2017-10-22 17:50:03 +09:00
Dan Balasescu
9a005fb63a
Merge branch 'master' into key-binding-store-improvements
2017-10-22 17:33:43 +09:00
Dean Herbert
5b2219a692
Add back test cleanup before run
2017-10-22 16:20:04 +09:00
Dean Herbert
1514d8451e
Use a more elegant method of setting the connection timeout
2017-10-22 16:20:04 +09:00
Dean Herbert
9aa46bfb0d
Add transaction usage for key binding defaults
2017-10-22 16:17:55 +09:00
Dean Herbert
29fcd210aa
Centralise transaction committing
2017-10-22 16:17:40 +09:00
Dean Herbert
39b356880e
Fix typo
2017-10-22 15:32:47 +09:00
Dean Herbert
6818ebdaff
Change the way migrations are checked for
...
This method allows switching between sqlite-net and EF builds without completely breaking. Note that DB migration still only happens in a forward direction, but this will allow switching back and forth without eventually being unable to start the game.
2017-10-22 15:27:16 +09:00
Shane Woolcock
2e6a68d358
Rename indicator class, add colour/fade easing, and add tooltip
2017-10-22 16:12:30 +10:30
Dean Herbert
f45eb96a5b
Merge remote-tracking branch 'upstream/master' into revert-to-default-glow
2017-10-22 13:27:53 +09:00
Shane Woolcock
5785af9f6a
Reenable revert indicator on audio device since the potential crash was addressed in #1101
2017-10-22 14:22:57 +10:30
Dean Herbert
1a7e23b5c1
Don't query database on keypress
2017-10-21 23:39:31 +09:00
Dean Herbert
4f392a867a
Use a transaction for key binding population
2017-10-21 23:39:24 +09:00
Shane Woolcock
59b10981dc
CI fixes
2017-10-21 17:06:28 +10:30
Shane Woolcock
f5946c0e07
Fix wrong license header
2017-10-21 16:28:03 +10:30
Shane Woolcock
840ba9f48e
Allow the default indicator colour to be specified, and fix bug where disabled bindables could be reset
2017-10-21 16:05:37 +10:30
Shane Woolcock
b4d575fbcd
Fix namespace and unnecessary using
2017-10-21 13:22:21 +10:30
Shane Woolcock
290fac8990
Temporarily disable revert functionality for audio device, since it crashes
2017-10-21 13:17:03 +10:30
Shane Woolcock
98044a17d3
Fix misaligned settings buttons
2017-10-21 13:16:06 +10:30
Shane Woolcock
2c7343e965
Add revert-to-default glow for settings items
2017-10-21 12:44:47 +10:30
Dean Herbert
270f984ae7
Merge remote-tracking branch 'upstream/master' into db-migration-fixes
2017-10-21 00:15:21 +09:00
Dean Herbert
47213d2498
Rely on storage.DeleteDatabase for guaranteed database deletion
...
Relies on https://github.com/ppy/osu-framework/pull/1100 being merged for most effectiveness.
2017-10-21 00:15:02 +09:00
Dan Balasescu
a9b9d82b74
Merge branch 'master' into fix-ef-hiding
2017-10-20 17:22:50 +09:00
Dean Herbert
b805174143
Output the inner exception to the log when possible
2017-10-20 14:33:35 +09:00
Dean Herbert
980a6c93b4
Merge branch 'master' into fix-ef-hiding
2017-10-20 14:24:46 +09:00
Dean Herbert
f18a3117a2
Merge branch 'master' into notification-thread-safety
2017-10-20 14:24:33 +09:00
Dean Herbert
f9d5eadd05
Fix TestCase failing in an infinite loop
2017-10-20 12:21:18 +09:00
Dean Herbert
35ce6fd2bd
Merge branch 'master' into notification-thread-safety
2017-10-20 11:48:14 +09:00
Dean Herbert
93b2fc6dc5
Fix issues with deletion
...
Main fix is avoiding nullrefs being thrown when metadata isn't present on a beatmap (quite a common scenario).
2017-10-20 11:18:08 +09:00
Dean Herbert
f69fa0cf1f
Fix selection after hiding all difficulties in a set
2017-10-20 11:16:56 +09:00
Dean Herbert
7f83cf6780
Fix hiding not always working
...
Because we are not sharing a single context, we need to use Update to attach the entity to the local context.
2017-10-20 11:16:45 +09:00
Dean Herbert
d32059a7ba
Ignore include-ignore warnings for now
2017-10-20 09:25:54 +09:00
Dean Herbert
ca78078436
Add more logging output
2017-10-20 08:06:07 +09:00
Dean Herbert
0e1328a30e
Add maximum try count before bailing
2017-10-20 08:01:38 +09:00
Dean Herbert
efaf98c5cf
Allow recovery from a very broken database
2017-10-20 00:48:27 +09:00
Dean Herbert
9b1ed5b3aa
Keep trying until delete succeeds
...
Turns out it can fail if file handles are still open.
2017-10-19 23:33:27 +09:00
Dean Herbert
d9fd05a5af
Hidden cannot be null
2017-10-19 23:19:30 +09:00
Dean Herbert
8aea6068ba
Add fallback logic for the case where previous database can't be migrated
2017-10-19 21:37:09 +09:00
Dan Balasescu
afaf3b4116
Merge branch 'master' into notification-thread-safety
2017-10-19 21:12:53 +09:00
Dean Herbert
1672e0d6b6
Add fallback logic in case migration fails
...
Nuke it all.
2017-10-19 21:11:43 +09:00
Dean Herbert
1fbbee14e4
Allow migration from sqlite-net to EF
...
Bonus stage
2017-10-19 20:04:59 +09:00
Dean Herbert
f7d0df1743
Fix beatmap difficulty and metadata deletion
2017-10-19 17:50:46 +09:00
Dean Herbert
b02dd196f6
Don't make one factory each context
...
A factory is supposed to be re-used.
2017-10-19 17:29:39 +09:00
Dean Herbert
36c00577af
Reduce database log output
...
Also hard-disables it for uninteresting log levels, providing a further performance boost.
2017-10-19 16:35:06 +09:00
Dean Herbert
12900a8b15
Remove unnecessary second call to AutoTransactionsEnabled
2017-10-19 15:53:11 +09:00
Dean Herbert
908c6d827f
ValueTuple please
2017-10-19 14:49:23 +09:00
Dean Herbert
5d5ea5fb2e
Fix all remaining db structure issues
2017-10-19 14:05:11 +09:00
Dean Herbert
71d614b813
FIx missing columns yet again
2017-10-18 21:57:54 +09:00
Dean Herbert
ac4b2797dc
valuetuple nightmare
2017-10-18 20:07:25 +09:00
Dean Herbert
0dac770e38
Remove TestCase cleanup temporarily until context disposal is sorted
2017-10-18 19:52:08 +09:00
Dean Herbert
b73b4755eb
Ignore r# locked context inspection here
2017-10-18 18:41:04 +09:00
Dean Herbert
a85de09c0f
Fix beatmap carousel interactions with deletion when not yet displayed
2017-10-18 18:36:35 +09:00
Dean Herbert
668f68dd63
Remove some unnecessary update calls
2017-10-18 18:27:57 +09:00
Dean Herbert
4841d4a937
Fix deletion and use single context for imports and deletions for now
2017-10-18 18:27:17 +09:00
Dean Herbert
cf5290fead
Remove unnecessary locking; operations are now thread-safe
2017-10-18 13:48:15 +09:00
Dean Herbert
2f3319552d
Merge remote-tracking branch 'upstream/master' into EfCore
2017-10-18 11:43:37 +09:00
EVAST9919
bae91d7de7
Simplify gradient usage in Letterbox Overlay
2017-10-18 05:06:17 +03:00
Dean Herbert
518e5a2245
Make ProgressNotification's status and progress thread-safe
...
Quite regularly a task will hold a reference to a progress notification and udpate it as progress is made. Therefore these operations should be thread-safe.
2017-10-18 10:07:20 +09:00
Dean Herbert
4193004fbf
Improve performance of imports by keeping a context hot
2017-10-17 20:29:47 +09:00
Dean Herbert
4e8019b313
Add some more missing indices
2017-10-17 19:59:22 +09:00
Dean Herbert
e4a066dc5f
Run cleanup tasks only on startup via manual calls
2017-10-17 19:58:33 +09:00
Dean Herbert
b9d0fb96ed
Fix cascade deletions
2017-10-17 18:26:28 +09:00
Dean Herbert
12639c6819
Use a different database name for now to avoid conflicts when switching versions
2017-10-17 17:52:20 +09:00
Dean Herbert
3e415e3269
Fix tooling failures
2017-10-17 17:52:02 +09:00
Dean Herbert
0177fcbe5f
Fix xmldoc
2017-10-17 17:08:47 +09:00
Dean Herbert
7a18d373ec
Improve performance of beatmap imports (still needs revision)
2017-10-17 17:08:42 +09:00
Dean Herbert
64dfce258f
Fix file prefix not being read when calling storage.Exists
2017-10-17 17:08:19 +09:00
Dean Herbert
e02640637a
Fix KeyBindingStore regression
2017-10-17 17:08:01 +09:00
Dean Herbert
ad54ca9268
Fix TestCasePlaySongSelect
2017-10-17 16:04:54 +09:00
Dean Herbert
cf3881b18c
Fix not being able to restore hidden beatmaps via context menu
2017-10-17 15:50:52 +09:00
Dean Herbert
e487b6f82a
Standardise context retrieval
2017-10-17 15:50:42 +09:00
Dean Herbert
cd41862e3b
Add back transaction support for beatmap importing
2017-10-17 15:00:27 +09:00
Dean Herbert
fe44a28d48
Add back startup tasks runner
2017-10-17 12:46:38 +09:00
Dean Herbert
66894d11ea
Connection -> context
2017-10-17 12:46:29 +09:00
Dean Herbert
c92e0e2dc1
Fix username display on beatmap panels
2017-10-17 11:24:59 +09:00
Dean Herbert
0df474accb
Simplify file storing
2017-10-17 11:22:50 +09:00
Dean Herbert
31dc5c97f2
Fix intro and duplicate inserts
2017-10-17 11:22:42 +09:00
