h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-06-06 00:44:18 +08:00
Code Issues Releases Wiki Activity

Reduce isLoading calls

Browse Source
This commit is contained in:
EVAST9919
2017-11-13 18:49:10 +03:00
Unverified
parent d157e6baf1
commit fa6d3f9792
2 changed files with 7 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game/Overlays/BeatmapSet/Scores/ScoresContainer.cs
-6
View File
@@ -105,22 +105,16 @@ namespace osu.Game.Overlays.BeatmapSet.Scores
flow.Clear();
if (scoresAmount < 2)
{
IsLoading = false;
return;
}
for (int i = 1; i < scoresAmount; i++)
flow.Add(new DrawableScore(i, scores.ElementAt(i)));
IsLoading = false;
}
public void CleanAllScores()
{
topScore.Hide();
flow.Clear();
IsLoading = false;
}
}
}
osu.Game/Overlays/BeatmapSetOverlay.cs
+7 -4
View File
@@ -92,8 +92,6 @@ namespace osu.Game.Overlays
private void updateScores(BeatmapInfo beatmap)
{
scores.IsLoading = true;
getScoresRequest?.Cancel();
if (!beatmap.OnlineBeatmapID.HasValue)
@@ -102,9 +100,14 @@ namespace osu.Game.Overlays
return;
}
getScoresRequest = new GetScoresRequest(beatmap);
getScoresRequest.Success += r => scores.Scores = r.Scores;
scores.IsLoading = true;
getScoresRequest = new GetScoresRequest(beatmap);
getScoresRequest.Success += r =>
{
scores.Scores = r.Scores;
scores.IsLoading = false;
};
api.Queue(getScoresRequest);
}