12735 Commits

Author	SHA1	Message	Date
Dean Herbert	f41b79688f	Avoid casting by accepting all Playfields but throwing on a bad choice	2022-10-11 16:54:41 +09:00
Dean Herbert	a44ba579c5	Fix beatmap update button not respecting user "prefer no video" setting ... Closes #20701.	2022-10-11 14:27:40 +09:00
ekrctb	6ab29a62d0	Anchor drag box on time (catch, mania) ... Not done for taiko because I cannot figure out how it should work with the overlapping scroll algorithm.	2022-10-11 14:23:17 +09:00
ekrctb	1a24762f9b	Improve drag box selection logic ... `AllowDeselectionDuringDrag` is remove. Instead, selected hit objects are not automatically deselected when clock is seeked to a later time (the hit object is dead). Update drag box selection even if mouse is not moved (in case clock is running or scroll wheel is used).	2022-10-11 14:11:45 +09:00
Dean Herbert	cb21126623	Merge pull request #20586 from ekrctb/time-based-selection ... Use hit object time for timeline drag selection instead of relying on blueprint	2022-10-11 13:20:15 +09:00
NotGumballer91	ef840e98cf	Update IntroCircles.cs	2022-10-11 01:49:53 +08:00
NotGumballer91	8a4f2efa14	Update IntroScreen.cs	2022-10-11 01:49:49 +08:00
NotGumballer91	9a3689b6e9	Update IntroCircles.cs	2022-10-10 21:04:14 +08:00
Dean Herbert	20adc522b9	Fix HUD components being interactive even when the HUD is visually hidden	2022-10-10 16:05:41 +09:00
Dan Balasescu	c18d4afdcc	Merge branch 'master' into fix-leaderboard-first-place-fade	2022-10-07 19:55:16 +09:00
Dan Balasescu	57e4d6cc4a	Merge pull request #20562 from peppy/fix-score-submission-crash ... Fix potential crash when score submission token retrival fails	2022-10-07 19:24:35 +09:00
ekrctb	6164e0896a	Don't reselect already selected items in SelectAll	2022-10-07 10:46:07 +09:00
ekrctb	29cc554632	Ensure blueprint is added for selected hit object	2022-10-06 13:59:54 +09:00
ekrctb	0d448e6cc8	Fix items without blueprints are not deselected	2022-10-06 13:50:56 +09:00
ekrctb	b0213c29e9	Use mid time instead of start time ... It is closer to the old blueprint-based behavior	2022-10-05 22:19:22 +09:00
ekrctb	6753f6b01a	Move AllowDeselectionDuringDrag down ... Because it is now ignored in the timeline implementation anyways	2022-10-05 22:14:11 +09:00
ekrctb	3108c42ece	Fix inspect issues	2022-10-05 22:04:43 +09:00
ekrctb	00b3d97f69	Improve timeline selection performance ... But selecting a large number of hit objects is still very slow because all DHOs must be added and also `AddBlueprintFor` has quadratic behaviors	2022-10-05 21:58:05 +09:00
ekrctb	0613388aaa	Make sure all selected items get deleted	2022-10-05 21:58:05 +09:00
ekrctb	0ffde02f79	Use hit object time for timeline selection	2022-10-05 21:51:01 +09:00
ekrctb	8d29e9e76b	Move selection logic from DragBox to BlueprintContainer	2022-10-05 21:51:01 +09:00
Dean Herbert	276021dd85	Remove now unnecessary ScheduleAfterChildren	2022-10-05 14:20:01 +09:00
Dean Herbert	c7d645b086	Merge branch 'master' into fix-gameplay-leaderboard-overlap	2022-10-05 14:15:50 +09:00
Dean Herbert	75b9bf2cf9	Merge branch 'master' into intel-exclusive-warning	2022-10-04 19:02:01 +09:00
Dean Herbert	d9f678d942	Change song select random key binding to not handle key repeat	2022-10-03 18:16:54 +09:00
Dean Herbert	42aac16b37	Adjust leaderboard score panels sizing based on accuracy/combo width	2022-10-03 18:12:36 +09:00
Dean Herbert	65369e96eb	Ensure token retrieval failure logic only runs once	2022-10-03 17:29:46 +09:00
Dean Herbert	c4dd23ed15	Log token retrieval failures even when gameplay is allowed to continue	2022-10-03 17:29:34 +09:00
Dean Herbert	4dbac917fc	Merge pull request #20547 from nanashi-1/solo-gameplay-leaderboard-max-combo ... Display highest combo rather than current combo for local play on leaderboard	2022-10-03 16:57:05 +09:00
Salman Ahmed	a810afafb3	Reschedule results display delegate to avoid potential softlocks in the future	2022-10-02 15:37:56 +03:00
Salman Ahmed	59728b0ccb	Fix results display delegate potentially cancelled while not exiting	2022-10-02 15:30:06 +03:00
nanashi-1	2493468800	display highest combo instead of current combo	2022-10-02 18:40:31 +08:00
Dean Herbert	cbbca616c1	Merge branch 'master' into fix-leaderboard-first-place-fade	2022-09-28 17:58:45 +09:00
Dean Herbert	9b3778f226	Merge pull request #20507 from smoogipoo/fix-multiplayer-tests ... Fix failing multiplayer tests	2022-09-28 17:41:55 +09:00
Dan Balasescu	715b1f64f3	Merge pull request #20518 from peppy/fix-leaderboard-wobble ... Fix leaderboard wobble when in first place	2022-09-28 17:03:31 +09:00
Dean Herbert	cdcc8494c9	Fix fade being applied for too long when leaderboard scrolls to start	2022-09-28 16:10:19 +09:00
Dean Herbert	c8643ed265	Set ClampExtension to zero to stop jittering	2022-09-28 15:58:00 +09:00
Dean Herbert	8edb1cb98a	Add test coverage of current score staying on screen	2022-09-28 15:57:50 +09:00
Dan Balasescu	a0d05f5bb7	Merge pull request #20501 from peppy/fix-editor-initial-performance ... Fix editor performance being sub-par on beatmap load	2022-09-27 21:34:04 +09:00
Dan Balasescu	da8d94c4b4	Fix test failures due to scheduled operations	2022-09-27 20:24:44 +09:00
Dean Herbert	58217b6839	Fix weird conditional	2022-09-27 20:09:21 +09:00
Dan Balasescu	8642ed7631	Merge pull request #20504 from peppy/fix-playlist-connectivity-crash ... Fix potential crash when losing network connectivity in multiplayer/playlists screens	2022-09-27 18:36:24 +09:00
Dean Herbert	3ece7205ed	Fix potential crash when losing network connectivity at online play screen ... Addresses #20448.	2022-09-27 17:52:34 +09:00
Dean Herbert	0296685c74	Start key counter / gameplay leaderboard hidden to avoid initial fade out	2022-09-27 17:25:24 +09:00
Dean Herbert	a9088d9231	Add assert/log output when too many ticks are being displayed	2022-09-27 17:18:46 +09:00
Dean Herbert	e227519b09	Don't attempt to render timeline ticks until DrawWidth is above zero	2022-09-27 17:18:46 +09:00
Dean Herbert	ccae721af2	Ensure ZoomableScrollContainer content isn't shown until zoom is set	2022-09-27 17:07:11 +09:00
Dean Herbert	9dc0eb7fd0	Remove unused static	2022-09-27 17:04:56 +09:00
Dean Herbert	320f134634	Use same logic as KeyCounterDisplay	2022-09-27 15:01:18 +09:00
nanashi-1	5d18001d75	move config	2022-09-26 21:11:38 +08:00
nanashi-1	4295d9c169	revert	2022-09-26 21:11:14 +08:00
nanashi-1	ee4d1b2d58	add config visibility	2022-09-26 20:13:07 +08:00
Dan Balasescu	c969afcb71	Merge branch 'master' into leaderboard-nrt	2022-09-26 17:12:19 +09:00
Dan Balasescu	28470bd5c0	Merge pull request #20486 from peppy/gameplay-leaderboard-nrt ... Apply NRT to `GameplayLeaderboard` hierarchy	2022-09-26 17:11:51 +09:00
Dan Balasescu	426ab176d6	Merge pull request #20418 from peppy/fix-leaderboard-crash ... Fix intermittent leaderboard crash due to request finishing after drawable is disposed	2022-09-26 17:10:32 +09:00
Dean Herbert	20da1051d9	Apply NRT to GameplayLeaderboard hierarchy ... Just some cleanup work that I wanted to do as part of my last changes.	2022-09-26 16:21:24 +09:00
Dean Herbert	5fc836d1f0	Apply NRT to BeatmapLeaderboard / MatchLeaderboard	2022-09-26 16:17:28 +09:00
Dean Herbert	32d56fe3a9	Use request cancellation and IsDisposed guard instead of more Schedule	2022-09-26 16:02:33 +09:00
o-dasher	feadac1f79	Cleanup all other leftover binding instantiation	2022-09-25 16:02:40 -04:00
Dean Herbert	0fa5e1b28e	Fix intermittent leaderboard crash due to request finishing after drawable is disposed	2022-09-23 20:18:44 +09:00
Dean Herbert	a65a76f7de	Fix off-thread drawable mutation in multiplayer settings overlay when an error occurs ... Closes #20413.	2022-09-23 20:05:32 +09:00
Dan Balasescu	1d1012e196	Merge pull request #20286 from peppy/gameplay-leaderboards ... Add basic gameplay leaderboard display	2022-09-22 21:16:12 +09:00
Dan Balasescu	6a0047b7a2	Update location of FullscreenCapability bindable	2022-09-22 21:01:23 +09:00
Dan Balasescu	445e026a32	Merge pull request #20389 from peppy/fix-gameplay-leaderboard-layout ... Fix gameplay leaderboard sometimes not showing up	2022-09-22 20:51:54 +09:00
Dean Herbert	8f7a306d81	Inline comment regarding margin necessity	2022-09-22 19:53:16 +09:00
Dean Herbert	f0dcda9acc	Decrease precision of spacing setting	2022-09-22 15:49:02 +09:00
Dean Herbert	26d98323ff	Fix bindable flow, code quality, everything	2022-09-22 15:45:23 +09:00
Dean Herbert	0f663deda0	Fix changing shape causing alpha to be permanently reset to zero	2022-09-22 15:24:57 +09:00
Dean Herbert	ae70b2c32f	Fix other weirdness in variable and description naming	2022-09-22 15:21:27 +09:00
Dean Herbert	19db7c5977	Remove "Opacity" setting ... This should be implemented at a higher level	2022-09-22 15:19:01 +09:00
Dean Herbert	f3898da37a	Rename judgement count to not mention "shape"	2022-09-22 15:18:20 +09:00
Dean Herbert	7d93fa9f65	Merge branch 'master' into Colour_hit_meter_improved	2022-09-22 15:11:58 +09:00
Dean Herbert	5b73f24864	Fix outdated scores being held by BeatmapLeaderboard after external beatmap switch	2022-09-21 15:21:32 +09:00
Dean Herbert	29c4d06d36	Merge branch 'fix-gameplay-leaderboard-layout' into gameplay-leaderboards	2022-09-21 14:58:58 +09:00
Dean Herbert	b04871f40a	Animate scroll for a better visual experience	2022-09-21 14:51:12 +09:00
Dean Herbert	087ca59ebb	Add extra margin space to flow equal to height of leaderboard ... This ensures the content is always on screen, but also accounts for the fact that scroll operations without animation were actually forcing the local score to a location it can't usually reside at. Basically, the local score was in the scroll extension region (due to always trying to scroll the local player to the middle of the display, but there being no other content below the local player to scroll up by).	2022-09-21 14:51:12 +09:00
Dean Herbert	4385001d28	Fix solo leaderboard seeing imported score via realm subscription flow	2022-09-21 13:59:11 +09:00
Dean Herbert	a8338c4efd	Add local score after existing scores to avoid initial re-sort	2022-09-21 13:38:40 +09:00
Dean Herbert	4492a26b59	Merge branch 'master' into argon-skin	2022-09-21 13:00:16 +09:00
Dan Balasescu	8bf196d561	Merge pull request #20354 from peppy/default-skin-refactor ... Rename default skin to make way for new version	2022-09-21 11:48:38 +09:00
Dan Balasescu	7f15dc6e6c	Merge pull request #20321 from HiddenNode/fix_graph_info_overlap ... Fix Progress bar info text overlapping with progress graph	2022-09-20 19:30:51 +09:00
Dan Balasescu	80d8eedb7c	Merge pull request #20366 from peppy/fix-nullable-download-progress ... Fix multiplayer crashes due to incorrect download state	2022-09-20 17:16:11 +09:00
Dean Herbert	68c040175a	Ensure Leaderboard.Scores is updated immediately via request flow	2022-09-20 17:02:57 +09:00
Dean Herbert	b5771ece41	Reduce the amount by which clicking the mute notification incraeses volume	2022-09-20 13:00:08 +09:00
Dean Herbert	a9c120c214	Reduce volume requirement for showing muted notification to 1%	2022-09-20 12:46:35 +09:00
Dean Herbert	1c02fa8399	Update comment to not mention horizontal plane	2022-09-20 00:08:06 +09:00
Dean Herbert	46db3ad96d	Move implementation to individual classes	2022-09-20 00:06:02 +09:00
Dean Herbert	0f7b38f4c3	Add new default skin "argon"	2022-09-19 23:16:46 +09:00
Dean Herbert	0ac28cbecc	Fix potential crash from missing DownloadProgress	2022-09-18 23:42:16 +09:00
Dean Herbert	1914c41d0d	Merge pull request #20353 from Drison64/fix-timelineZoom-zero ... EditorBeatmap's TimelineZoom should never be zero	2022-09-18 18:06:26 +09:00
Dan Balasescu	2dcaf7cfd8	Fix memory leak due to missing event unbind	2022-09-18 14:25:31 +09:00
Drison64	c075d3de08	Create a test and a check if initial zoom value of ZoomableScrollContainer is in range	2022-09-17 22:43:40 +02:00
Ondřej Vajďák	9d94343317	Update osu.Game/Screens/Edit/Compose/Components/Timeline/Timeline.cs ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2022-09-17 19:51:44 +02:00
Drison64	c8768eb399	Changed == to <= on TimelineZoom check	2022-09-17 19:00:50 +02:00
Drison64	3c7ea5c8fa	Update	2022-09-17 18:57:09 +02:00
Dean Herbert	41e69fbca6	Remove "default" prefix from naming	2022-09-18 00:15:26 +09:00
Dean Herbert	51841988bf	Rename references to DefaultSkin to have Triangles suffix	2022-09-17 23:57:25 +09:00
HiddenNode	2dfa89c62e	Clean up	2022-09-17 15:05:25 +01:00
Drison64	0b6a77bc8b	EditorBeatmap's TimelineZoom should never be zero	2022-09-17 15:59:42 +02:00
HiddenNode	d580b07063	Refactor update condition logic	2022-09-17 14:40:36 +01:00
HiddenNode	e3d5ba5301	Check if graph DrawSize changed	2022-09-17 11:44:25 +01:00
HiddenNode	0d76f4501d	Revert "Set InvalidationSource to Self" ... This reverts commit 2092008251.	2022-09-17 10:10:20 +01:00
Dean Herbert	4c4fdfd153	Provide scores directly to Player instance rather than relying on DI	2022-09-16 18:15:17 +09:00
Dean Herbert	0227eddda1	Merge branch 'master' into gameplay-leaderboards	2022-09-16 15:44:58 +09:00
Dan Balasescu	d9499abc33	Refactor to avoid passing around bindables	2022-09-16 13:14:25 +09:00
Drison64	4f208416be	Fixed irresponsiveness of score panel timestamp to time format	2022-09-16 13:50:18 +14:00
HiddenNode	2092008251	Set InvalidationSource to Self	2022-09-15 11:16:00 +01:00
HiddenNode	8286ab0d04	Revert "Fix SongProgress invalidating too often" ... This reverts commit 2b4b14ca99.	2022-09-15 11:11:58 +01:00
Dean Herbert	40a60f7145	Remove all entity framework code and migrations	2022-09-15 16:58:58 +09:00
Dean Herbert	eb18d3661d	Merge pull request #20309 from mk56-spn/dead_class_removal ... Unused class KeyCounterState.cs Removal	2022-09-15 03:38:39 +09:00
Mk-56spn	d6db82283a	Removes unused class	2022-09-14 18:01:29 +02:00
Dean Herbert	fcf54f1bc8	Fix gameplay leaderboard not being sorted correctly in tie situations	2022-09-14 14:18:12 +09:00
Dean Herbert	8a6977213a	Fix displayed scores in gameplay leaderboard not tracking display mode changes	2022-09-14 14:02:35 +09:00
Dean Herbert	b4e6a20846	Fix song select status prefix matching no longer working ... Regressed in #19275 due to weird logic. Closes #20289.	2022-09-14 12:59:05 +09:00
Dean Herbert	81b5e4a865	Fix back-to-front condition on leaderboard always show configuration	2022-09-13 19:57:40 +09:00
Dean Herbert	94693a4667	Fix oversight when making interface implementation explicit	2022-09-13 19:55:57 +09:00
Dean Herbert	e15a25ea49	Fix leaderboard positioning logic to actually consider elements on the left side	2022-09-13 18:45:11 +09:00
Dean Herbert	678eec1c67	Move LeaderboardFlow to HUDOverlay to share positioning logic	2022-09-13 18:45:11 +09:00
Dean Herbert	5894d2f0bc	Ensure gameplay leaderboard hides with rest of HUD when it should	2022-09-13 18:45:11 +09:00
Dean Herbert	6d167070f8	Add back DI leaderboard retrieval via bindable pathway	2022-09-13 18:45:11 +09:00
Dean Herbert	70e6b595f1	Refactor SoloGameplayLeaderboard to not read scores via DI ... Also allows updating scores if they arrive late.	2022-09-13 18:00:21 +09:00
Dean Herbert	d2b80645ab	Change Leaderboard to use IUser instead of APIUser	2022-09-13 18:00:21 +09:00
Dean Herbert	d251c0b2ac	Move leaderboard implementation to Player itself	2022-09-13 18:00:21 +09:00
Dean Herbert	368faa0084	Make constructor protected in base implementation	2022-09-13 18:00:21 +09:00
Dean Herbert	4c669e2bce	Track local Player.Score's user rather than using APIProvider	2022-09-13 18:00:21 +09:00
Salman Ahmed	3490b16056	Add simplified SoloGameplayLeaderboard implementation ... Note that this doesn't support waiting until leaderboard finishes fetching scores.	2022-09-13 18:00:21 +09:00
Dean Herbert	27a81dfb9f	Merge pull request #20270 from OliBomby/fix-selectionblueprint-order ... Fixed HitObjectOrderedSelectionContainer being able to become unsorted and causing crashes	2022-09-13 17:18:58 +09:00
Dan Balasescu	0e2155303e	Merge branch 'master' into fix-song-progress-invalidations	2022-09-13 16:07:05 +09:00
Dean Herbert	f53507828c	Rename event to be more generic (and add comprehensive xmldoc)	2022-09-13 14:59:30 +09:00
Dean Herbert	ac034bffeb	Fix potential crash if multiplayer spectator load is aborted early	2022-09-13 14:21:54 +09:00
OliBomby	fd48249eef	fix with new event	2022-09-13 02:20:52 +02:00
OliBomby	718f8c4ee2	revert the fix	2022-09-13 01:09:42 +02:00
OliBomby	8400de4b2e	invoking hitobject updated before invoking removed	2022-09-12 17:50:11 +02:00
Dean Herbert	2b4b14ca99	Fix SongProgress invalidating too often ... This regressed with https://github.com/ppy/osu/pull/19556. Rather than try and figure whether that new container needs to handle size differently, this is a simple solution. Height was taken from a runtime check (maxes out at about 14.5). Closes #20235.	2022-09-12 20:06:53 +09:00
Dean Herbert	cb6d02ec3a	Merge pull request #19066 from andy840119/remove-the-nullable-disable-in-the-ruleset ... Remove the nullable disable annotation in the ruleset class	2022-09-12 19:07:23 +09:00
Dan Balasescu	4b37330316	Merge pull request #20248 from acid-chicken/fix/stats/td ... Fix new hit distribution graph didn't account for size changes	2022-09-12 18:11:18 +09:00
Dan Balasescu	3cfacb5e39	Merge pull request #20257 from peppy/update-button-show-login ... Show login overlay when attempting to update a beatmap while logged out	2022-09-12 17:51:45 +09:00
Acid Chicken (硫酸鶏)	4f298db066	fix(osu.Game): reset Y axis of the bars in hit distribution graph at the first drawing	2022-09-12 16:25:29 +09:00
Acid Chicken (硫酸鶏)	0d0e2e7bcc	fix(osu.Game): bars in hit distribution graph stretching in the opposite direction when DrawHeight is less than DrawWidth	2022-09-12 16:20:33 +09:00
Dan Balasescu	31225066a1	Merge pull request #19308 from frenzibyte/top-rank-badge-order ... Fix best rank badge not handling legacy scores properly	2022-09-12 16:20:21 +09:00
Dean Herbert	94f8197e22	Show login overlay when attempting to update a beatmap while logged out	2022-09-12 16:15:14 +09:00
Dean Herbert	96951057df	Avoid using bindables	2022-09-12 15:56:06 +09:00
Dean Herbert	bcd2445d9b	Move helper functions down in file	2022-09-12 15:50:10 +09:00
Dean Herbert	0755289ec3	Apply NRT to HitEventTimingDistributionGraph	2022-09-12 15:48:50 +09:00
Acid Chicken (硫酸鶏)	ac324c63e2	fix(osu.Game): handle size changes in timing distribution graph	2022-09-12 04:46:32 +09:00
Mk-56spn	c00bf61273	Framework change adressed	2022-09-10 21:24:29 +02:00
MK56	8661dc3c93	Merge branch 'ppy:master' into Colour_hit_meter_improved	2022-09-10 21:16:23 +02:00
Mk-56spn	f6aef73f9e	fixed shape bindable not working, test creation, removal of Clear(), adjusted settings names	2022-09-10 20:30:43 +02:00
andy840119	3d7367a842	Move the CreateConvertibleReplayFrame() into the base ruleset class for avoid api breaking change in the customized ruleset.	2022-09-10 11:07:23 +08:00
andy840119	e62999fb16	Merge branch 'master' of https://github.com/ppy/osu into remove-the-nullable-disable-in-the-ruleset ... # Conflicts: # osu.Game.Rulesets.Catch/CatchRuleset.cs # osu.Game.Rulesets.Osu/OsuRuleset.cs # osu.Game.Rulesets.Taiko/TaikoRuleset.cs # osu.Game/Rulesets/Ruleset.cs	2022-09-10 10:40:12 +08:00
Salman Ahmed	95062c2cc8	Remove center origin specification to avoid single-frame layout issues	2022-09-09 19:42:58 +03:00
Salman Ahmed	dd10a06e3d	Merge branch 'master' into top-rank-badge-order	2022-09-09 19:38:44 +03:00
solstice23	823078ed2d	Merge branch 'master' into search-filter	2022-09-09 23:12:37 +08:00
Dean Herbert	602ffebd54	Apply NRT and fix code style	2022-09-09 23:29:04 +09:00
Dean Herbert	d961b96897	Merge branch 'master' into search-filter	2022-09-09 23:25:54 +09:00
Dean Herbert	27f745b980	Merge branch 'master' into fix_progress_bar_info	2022-09-09 17:34:13 +09:00
Dean Herbert	05797cb9e5	Fix enum to STRING????????? conversion (and use bindable flow)	2022-09-09 16:30:08 +09:00
Dean Herbert	f1fa442287	Merge pull request #19599 from ItsShamed/kps ... Add clicks/second counter to HUD	2022-09-09 01:50:12 +09:00
Dean Herbert	6945c43e0d	Merge pull request #20178 from smoogipoo/fix-match-creation-beatmap-select ... Fix several weird scenarios with online play song selection	2022-09-08 23:07:09 +09:00
Dean Herbert	45239fc737	Update TrueGameplayRate accessing	2022-09-08 23:03:15 +09:00
Dean Herbert	d4afc3629c	Merge branch 'master' into kps	2022-09-08 23:00:36 +09:00
Dan Balasescu	9aab502adc	Merge pull request #20157 from peppy/true-gameplay-rate ... Refactor `TrueGameplayRate` to account for only gameplay adjustments, no matter what	2022-09-08 19:54:32 +09:00
Dan Balasescu	4fc03998a1	Merge pull request #20189 from peppy/fix-playlist-item-download-button-visibility ... Fix playlist items showing download button briefly during initial display	2022-09-08 19:47:35 +09:00
Dean Herbert	096d1c3ff3	Merge pull request #20143 from acid-chicken/feat/stats/colored-td ... Show judgement colours in hit distribution graph	2022-09-08 19:15:40 +09:00
Dean Herbert	13d9b2188b	Merge pull request #20145 from smoogipoo/multiple-countdowns ... Implement support for multiple active countdowns in multiplayer	2022-09-08 19:15:30 +09:00
Dean Herbert	a98c6b2c1f	Add comment metioning why we need to use DrawableRuleset lookup	2022-09-08 19:14:23 +09:00
Mk-56spn	07c16224d2	Fix Main file issues	2022-09-08 11:58:14 +02:00
Dean Herbert	5c2fb3e434	Simplify calculation method	2022-09-08 18:22:53 +09:00
Dean Herbert	d463bd2f3f	Merge pull request #20130 from Exanc/master ... Display 0 stars instead of infinity for the minimum star slider	2022-09-08 17:51:32 +09:00
Dean Herbert	c6521e4c72	Rename ordering helper method	2022-09-08 17:50:27 +09:00
Dan Balasescu	76eae73fa4	Revert unintended change	2022-09-08 17:41:23 +09:00
Dan Balasescu	c61c596c1f	Expose as readonly IAggregateAudioAdjustment	2022-09-08 17:37:02 +09:00
Dan Balasescu	b559d4ecdf	Rename GameplayAdjustments -> AdjustmentsFromMods	2022-09-08 17:14:06 +09:00
Dean Herbert	ed81297611	Fix playlist items showing download button briefly during initial local presence checks	2022-09-08 17:10:45 +09:00
Dan Balasescu	b0b4da533a	Expose gameplay adjustments via MultiSpectatorPlayer instead	2022-09-08 16:59:20 +09:00
Dean Herbert	d523a2ac33	Rename default value field and make private	2022-09-08 15:53:08 +09:00
Dean Herbert	9ead5e59d3	Fix incorrectly displaying minimum value in placeholder messaging	2022-09-08 15:51:15 +09:00
Salman Ahmed	50923b6e5b	Move track assignment below	2022-09-08 00:25:55 +03:00
Acid Chicken (硫酸鶏)	267465df18	chore(osu.Game): combine Osu.Colour.{Draw,Text}ForHitResult into OsuColour.ForHitResult	2022-09-07 23:34:46 +09:00
Acid Chicken (硫酸鶏)	b560b6f745	refactor(osu.Game): arrange the code for the timing distribution graph	2022-09-07 23:29:10 +09:00
Dan Balasescu	83c0cb1acc	Fix beatmap set to null after exiting song select	2022-09-07 21:34:29 +09:00
Dan Balasescu	fcea244537	Remove initial selection from OnlinePlaySongSelect ... This stuff never really worked anyway - every case except with an already created multiplayer room was broken anyway.	2022-09-07 21:34:29 +09:00
Dan Balasescu	208bd0f391	Give OnlinePlaySongSelect a reference PlaylistItem	2022-09-07 21:34:29 +09:00
Dean Herbert	6a03b4e0de	Merge branch 'master' into true-gameplay-rate	2022-09-07 20:01:03 +09:00
Dan Balasescu	cb9bae1f5c	Enable NRT	2022-09-07 19:54:55 +09:00
Dean Herbert	e6b449fe0b	Fix case of zero rate calculating a zero true gameplay rate	2022-09-07 19:23:44 +09:00
Dean Herbert	1be3b74ff3	Fix multiplayer spectator not getting gameplay adjustments applied	2022-09-07 19:12:34 +09:00
Dean Herbert	fa15502384	Move full track adjustment flow inside MasterGameplayClockContainer	2022-09-07 19:12:16 +09:00
Dean Herbert	75d0deef72	Apply proposed changes to remove inheritance from MasterGameplayClockContainer	2022-09-07 17:49:05 +09:00
Dean Herbert	99ef0c95fe	Simplify children assignment	2022-09-07 16:51:51 +09:00
Dean Herbert	f3bda4e040	Fix weird edge case of nullability in CarouselRoot ... A bit unfortunately, but it's what we get for having ctor level bindings..	2022-09-07 14:27:25 +09:00
Dean Herbert	e18b524f8e	Fix missing null checks on selectedBeatmap fields in BeatmapCarousel	2022-09-07 14:12:35 +09:00
Dean Herbert	241d33d415	Apply NRT to BeatmapCarousel	2022-09-07 14:07:53 +09:00
Acid Chicken (硫酸鶏)	3003fc1061	refactor(osu.Game): improve code quality	2022-09-07 02:29:15 +09:00
Salman Ahmed	90207b6032	Merge branch 'master' into feature/EditorDeleteDiff	2022-09-06 18:48:06 +03:00
Dean Herbert	66c44f5913	Delegate interface to valid target	2022-09-06 22:26:46 +09:00
Dean Herbert	bc1212f4e6	Change NonGameplayAdjustments to GameplayAdjustments and convert TrueGameplayRate to extension method	2022-09-06 22:26:46 +09:00
Dean Herbert	db15bd56e8	Invalidate working beatmap cache when calling DeleteDifficultyImmediately rather than in editor code	2022-09-06 18:12:47 +09:00
Acid Chicken (硫酸鶏)	b109e5de6c	chore(osu.Game): align height of bars on timing distribution graph to basalHeight first and combine their transitions into each one	2022-09-06 00:04:10 +09:00
Dean Herbert	266eb758aa	Use new flow to calcaulate TrueGameplayRate	2022-09-05 23:37:49 +09:00
Dean Herbert	7084aeee05	Add method flow to reset applied adjustments	2022-09-05 23:22:38 +09:00
Dean Herbert	e33486a766	Implement IAdjustableAudioComponent in MasterGameplayClockContainer	2022-09-05 23:20:02 +09:00
Dan Balasescu	2923c10cd8	Rewrite rooms to store multiple active countdowns ... Update test to the new structure	2022-09-05 19:03:26 +09:00
Dean Herbert	57954bb8f5	Enable nullability on TimelineHitObjectBlueprint	2022-09-05 14:50:43 +09:00
Mk-56spn	aace334fb3	Fix some test issues	2022-09-05 04:49:48 +02:00
Dan Balasescu	07d4a025b0	Merge pull request #20109 from frenzibyte/online-play-room-status-inconsistency ... Fix room status dropdown placement inconsistent between multiplayer and playlists	2022-09-05 11:19:56 +09:00
Exanc	4ea7ca4c07	Slight tweak to the StarsSlider ... - MinimumStarsSlider now shows "0" when at it's minimum - Modified and NoResultsPlaceholder the tooltip to stay consistent with the changes	2022-09-05 00:09:20 +02:00
Acid Chicken (硫酸鶏)	7e77c9e8b4	chore(osu.Game): only the first result should be white at zero position on HitEventTimingDistributionGraph	2022-09-05 04:44:27 +09:00
Acid Chicken (硫酸鶏)	b67fd3d880	chore(osu.Game): split transform duration of bars on HitTimingDistributionGraph	2022-09-05 03:45:51 +09:00
Acid Chicken (硫酸鶏)	0af6b3dc0f	chore(osu.Game): colorize bars by OD on HitEventTimingDistributionGraph	2022-09-05 02:02:38 +09:00
Acid Chicken (硫酸鶏)	5f0832ead7	refactor(osu.Game): separate OsuColour.ForHitResult by usage	2022-09-05 01:58:57 +09:00
Mk-56spn	0c6d8efa28	Large code refactor, Implementation of shapes option drop down	2022-09-04 17:24:12 +02:00
Salman Ahmed	e8fa872f61	Fix room status dropdown position inconsistent on online-play screens	2022-09-03 16:14:21 +03:00
Mk-56spn	51061c3a12	Bug fixing and parameter adjustments	2022-09-03 01:27:22 +02:00
Mk-56spn	534c40e18e	Initial version	2022-09-02 23:07:30 +02:00
Dean Herbert	bc5340e33a	Merge branch 'master' into fix_progress_bar_info	2022-09-02 18:00:35 +09:00
Dean Herbert	4f18105e9d	Ensure next beatmap selected matches the menu ordering	2022-09-02 17:57:00 +09:00
Dean Herbert	840d1c4cd5	Disable delete difficulty menu item when only one difficulty is present	2022-09-02 17:14:48 +09:00
Dean Herbert	9fd8067e11	Tidy up dialog and deletion flow	2022-09-02 17:07:09 +09:00
Dean Herbert	605108c938	Refactor/rename deletion method to read better	2022-09-02 16:59:01 +09:00
Dean Herbert	b388428e1c	Merge branch 'master' into feature/EditorDeleteDiff	2022-09-02 16:48:38 +09:00
Dean Herbert	6a35b233e5	Merge branch 'master' into remove-dispose-updates	2022-09-01 23:03:19 +09:00
Dean Herbert	1524623624	Fix back-to-front filter logic ... Was copied across from a place which was checking for `match` and applied verbatim to a place that was `filter`. Which are polar opposites.	2022-09-01 19:59:27 +09:00
HiddenNode	4a630b5384	Implemented SizePreservingSpriteText	2022-08-31 22:05:06 +01:00
Dan Balasescu	c852c54055	Consume auto skip setting during play	2022-08-31 20:24:15 +09:00
Dan Balasescu	b5ec7d06dd	Add auto-skip setting ... Default to auto skip	2022-08-31 20:24:06 +09:00
Dan Balasescu	000412c50f	Merge pull request #20014 from peppy/fix-resume-skip-forward ... Fix gameplay skipping forward during resume operation	2022-08-31 16:30:37 +09:00
Dan Balasescu	ccc08b816c	Merge pull request #20030 from peppy/notification-design-update ... Update notification overlay design	2022-08-31 16:06:59 +09:00
Dean Herbert	7337d4c1aa	Merge branch 'master' into kps	2022-08-31 15:41:42 +09:00
Dan Balasescu	2bf74d2b38	Merge pull request #20039 from peppy/fix-skip-button-permanent-display ... Fix skip button getting stuck on screen for certain beatmaps	2022-08-31 14:17:39 +09:00
Dean Herbert	cfc7c32aff	Merge pull request #20009 from frenzibyte/fix-back-to-front-comparison ... Adjust weirdly back-to-front fallback comparison in `HitObjectOrderedSelectionContainer`	2022-08-31 14:14:10 +09:00
Dean Herbert	51346e0154	Fix skip button getting stuck on screen for certain beatmaps ... Closes #20034.	2022-08-31 13:22:51 +09:00
Dean Herbert	3d93e0ded1	Merge branch 'master' into fix-resume-skip-forward	2022-08-31 12:16:15 +09:00
Dean Herbert	09aa3e065d	Move colouring to full icon content rather than background	2022-08-30 18:06:48 +09:00
Dean Herbert	5d41fdfc89	Remove unnecessary usage of DrawableAudioMixer in ScorePanel	2022-08-30 15:05:21 +09:00
Dean Herbert	27ad224f13	Remove probably unnecessary Seek on start	2022-08-30 01:21:44 +09:00
Dean Herbert	1bff540381	Remove debug changes	2022-08-29 22:14:07 +09:00
Dan Balasescu	0491addbbd	Merge pull request #19974 from peppy/no-gameplay-clock-editor-offset ... Fix editor not applying offsets	2022-08-29 21:10:29 +09:00
Dean Herbert	82b9e1f0eb	Merge pull request #20011 from smoogipoo/scoring-refactor ... Refactor scoring to remove async methods / simplify	2022-08-29 19:55:27 +09:00
Dean Herbert	75531d2d62	Fix gameplay skipping forward during resume operation	2022-08-29 19:51:16 +09:00
Salman Ahmed	f2378d3fde	Merge branch 'master' into carousel-maintain-selection-over-update	2022-08-29 11:23:22 +03:00
Dean Herbert	2dafa041a7	Account for offset being applied to editor clock time in TestSceneEditorClock	2022-08-29 16:42:50 +09:00
Dean Herbert	105aa01e7d	Update usages of RemoveInternal	2022-08-29 15:57:40 +09:00
Dean Herbert	a215d009fe	Update Remove/RemoveRange/RemoveAll calls in line with framework changes	2022-08-29 15:57:40 +09:00
Dan Balasescu	423f6f90f2	Remove async calls from ScoreManager	2022-08-29 15:34:08 +09:00
Salman Ahmed	3ff2058975	Fix back-to-front fallback comparison in HitObjectOrderedSelectionContainer	2022-08-29 09:23:53 +03:00
Dan Balasescu	c0b13c7e1f	Refactor ScoreProcessor ComputeScore() methods	2022-08-29 13:51:10 +09:00
Dan Balasescu	cf6bb3b030	Merge pull request #19958 from peppy/fix-fail-freq-stuck ... Ensure fail animation sequence isn't run after the player exit sequence has started	2022-08-27 00:58:41 +09:00
Dean Herbert	b9d9bf3004	Merge pull request #19938 from frenzibyte/fix-multi-spectator-results-screen ... Fix multi-spectator potentially getting stuck for passed players	2022-08-26 21:53:17 +09:00
Salman Ahmed	a3e595a9aa	Update comment to include inserted indices	2022-08-26 14:51:19 +03:00
Salman Ahmed	81c0a641b4	Fix selection fallback path not updated to check inserted indices	2022-08-26 14:51:08 +03:00
Salman Ahmed	f38194fb40	Merge branch 'master' into carousel-maintain-selection-over-update	2022-08-26 14:35:19 +03:00
Dean Herbert	217fa00a72	Bring logic up-to-date	2022-08-26 19:32:49 +09:00
Dean Herbert	a146db0e35	Merge branch 'master' into carousel-perform-selection	2022-08-26 19:29:00 +09:00
Dean Herbert	cd90536e4b	Remove Track access in Timeline	2022-08-26 18:25:48 +09:00
Dean Herbert	12d6d6793c	Move EditorClock processing to Update and always decouple	2022-08-26 18:08:43 +09:00
Dean Herbert	31e459364b	Use FramedBeatmapClock in EditorClock	2022-08-26 17:28:58 +09:00
Dean Herbert	ed0843aa84	Reword xmldoc regarding final clock source to read better	2022-08-26 16:46:22 +09:00
Dean Herbert	2c780eab5f	Merge branch 'master' into fix_progress_bar_info	2022-08-26 16:14:21 +09:00
Dean Herbert	23efec6505	Fix naming and comment typos	2022-08-26 15:57:36 +09:00
Dean Herbert	9862b79b47	Fix typo in long comment	2022-08-26 15:20:09 +09:00
HiddenNode	d98357aa57	Made text inside SongProgressInfo scale.	2022-08-26 01:30:44 +01:00
Dean Herbert	a546aa2673	Clamp SpectatorPlayerClock's elapsed calculation to avoid player clocks getting too far ahead	2022-08-25 21:33:33 +09:00
Dean Herbert	3a17c6df08	Merge branch 'master' into no-gameplay-clock-gameplay-offset	2022-08-25 16:24:55 +09:00
Dean Herbert	a6ed589db4	Remove guard against RemoveFilters running more than once ... It turns out this is required to remove some filters immediate, and some later. Weird.	2022-08-25 14:47:33 +09:00
Dean Herbert	ad3dd1c700	Fix a couple of oversights regarding track nullability	2022-08-25 14:45:00 +09:00
Dean Herbert	ec60e16439	Apply NRT to FailAnimation	2022-08-25 14:35:42 +09:00
Dean Herbert	8f4a953d11	Ensure fail animation sequence isn't run after the player exit sequence has started	2022-08-25 14:26:42 +09:00
Dean Herbert	4c45f7d938	Ensure FailAnimation can't be Started after filters are already removed	2022-08-25 14:26:20 +09:00
Ryuki	5cddc7ed1f	Code cleanup (CPS)	2022-08-24 17:13:23 +02:00
Dean Herbert	f3847b90fd	Tidy up attach logic	2022-08-24 19:36:01 +09:00
Dean Herbert	5129716612	Merge branch 'master' into kps	2022-08-24 18:18:45 +09:00
Dean Herbert	2af8c4a2ea	Merge pull request #19904 from novialriptide/add-date-created-sort ... Add date submitted sorting	2022-08-24 17:43:28 +09:00
Dean Herbert	27b57947e4	Rename PlayerArea.GameplayClock to SpectatorPlayerClock for clarity	2022-08-24 17:13:14 +09:00
Dean Herbert	5f01f461b3	Ensure elapsed time is always non-zero when advancing SpectatorPlayerClock	2022-08-24 17:13:14 +09:00
Dean Herbert	af56cd0126	Fix merge breakage	2022-08-24 16:52:36 +09:00
Dean Herbert	5079e0d83d	Merge branch 'master' into no-gameplay-clock-gameplay-offset	2022-08-24 16:52:10 +09:00
Salman Ahmed	e378c5b866	Remove no longer necessary switch case	2022-08-24 10:50:40 +03:00
Salman Ahmed	8f4a2b4936	Separate passed/failed states from calling EndGameplay	2022-08-24 10:36:13 +03:00
Andrew Hong	a8867d4245	Merge branch 'master' into add-date-created-sort	2022-08-24 03:23:27 -04:00
Dean Herbert	7f9246637a	Simplify MultiSpectatorScreen hierarchy construction	2022-08-24 16:08:48 +09:00
Dean Herbert	7c1fc4814e	Remove unused CreateMasterGameplayClockContainer method	2022-08-24 16:03:38 +09:00
Dean Herbert	871365bbb0	Inline ReadyToStart action binding for added safety	2022-08-24 16:03:38 +09:00
Dean Herbert	6c50f618a3	Don't use bindable flow for masterState	2022-08-24 16:03:38 +09:00
Dean Herbert	683d49c608	Move MasterClockState handling in to SpectatorSyncManager	2022-08-24 16:03:38 +09:00
Dean Herbert	d33d705684	Make WaitingOnFrames non-bindable	2022-08-24 16:03:38 +09:00
Dean Herbert	d05d8aeb22	Simplify interface implementations	2022-08-24 16:03:38 +09:00
Dean Herbert	2f5be6efca	Tidy up ProcessFrame and privatise const	2022-08-24 16:03:38 +09:00
Dean Herbert	b564c34dbc	Don't process master clock (is a noop)	2022-08-24 16:03:38 +09:00
Salman Ahmed	2fa8b61f3c	Handle completion user state updates during spectating	2022-08-24 10:02:21 +03:00
Dean Herbert	b4eede61fb	Use readonly instead of get-only	2022-08-24 15:28:18 +09:00
Dean Herbert	0b271fe4b3	Fix incorrect IsRunning value	2022-08-24 15:27:31 +09:00
Dean Herbert	b6254a1f25	Remove unnecessary casting	2022-08-24 15:23:31 +09:00
Dean Herbert	a86fc6f248	Change running state of SpectatorPlayerClock using IsRunning	2022-08-24 15:17:56 +09:00
Dean Herbert	0c9a4ec13c	Don't expose MasterClock in SpectatorClockSyncManager	2022-08-24 15:13:08 +09:00
Dean Herbert	995e6664b6	Rename spectator clock sync classes	2022-08-24 15:13:08 +09:00
Dean Herbert	31f657fe01	Remove ISpectatorPlayerClock interface ... Too many levels of redirection. One interface with one implementation is not useful, IMO.	2022-08-24 15:12:57 +09:00
Dean Herbert	882dd93942	Remove ISyncManager interface ... Too many levels of redirection. One interface with one implementation is not useful, IMO.	2022-08-24 15:12:57 +09:00
Dean Herbert	22963ab951	Fix multiplayer spectator getting stuck	2022-08-24 15:12:57 +09:00
Dean Herbert	ec31f37ff7	Accept MasterGameplayClockContainer rather than generic clock	2022-08-24 14:51:14 +09:00
Dean Herbert	85fbe7abca	Fix multiplayer spectator getting stuck	2022-08-24 13:11:53 +09:00
Andrew Hong	3cedd1cd1c	Merge branch 'master' into add-date-created-sort	2022-08-23 12:00:30 -04:00
Dean Herbert	29fed0c4a3	Avoid setting the source clock until gameplay is ready to start ... Without this change, the audio track may audibly seek during load proceedings.	2022-08-23 18:34:17 +09:00
Dean Herbert	ec61a94dc9	Merge branch 'master' into no-gameplay-clock-gameplay-offset	2022-08-23 17:36:06 +09:00
Dean Herbert	553897f2f0	Remove AddClock method to CreateManagedClock	2022-08-23 13:52:43 +09:00
Dean Herbert	1191b6c080	Remove unused Source_Set implementation on ISpectatorPlayerClock	2022-08-23 13:44:41 +09:00
Andrew Hong	55f1b43329	Removed check	2022-08-22 13:41:36 -04:00
HiddenNode	1098e24c40	Improved UprightUnscaledContainer	2022-08-22 14:24:52 +01:00
Dan Balasescu	c59298f0ce	Enable NRT	2022-08-22 21:55:04 +09:00
Dean Herbert	489e172a76	Simplify track start/stop/paused tracking	2022-08-22 19:43:18 +09:00
Dan Balasescu	5d3d8681d4	Invert creation of clocks in multi spectator	2022-08-22 19:14:06 +09:00
Andrew Hong	bcab7aea26	Merge branch 'master' into add-date-created-sort	2022-08-22 04:02:46 -04:00
Andrew Hong	c2036d3893	Moved filter exclusion	2022-08-22 03:39:46 -04:00
Andrew Hong	09ef13908c	Adjust to reviews	2022-08-22 03:20:27 -04:00
Dean Herbert	058d67f8e8	Merge pull request #19695 from naoei/ruleset-localization ... Change most ruleset-accessible string types to Localisable strings	2022-08-22 16:13:23 +09:00
Dan Balasescu	0815b01b75	Merge pull request #19783 from bdach/mod-select/presets-dont-open-customisation ... Fix selecting preset containing Difficulty Adjust automatically opening customisation panel	2022-08-22 15:44:00 +09:00
Dean Herbert	e6b669db8e	Elaborate with example of GameplayClockContainer managing its own Stop state	2022-08-22 14:14:44 +09:00
Dean Herbert	af2e82d7d5	Move operation of setting GameplayClockContainer.StartTime to Reset call	2022-08-22 14:11:06 +09:00
Andrew Hong	c6a739f5a8	Add date submitted sorting	2022-08-21 23:09:33 -04:00
Ryuki	5cf54a788a	Code cleanup for CPS counter	2022-08-21 16:00:58 +02:00
naoei	29ef1c8db8	Check if StatisticItem.Name is null or empty	2022-08-20 21:48:53 -04:00
naoei	9386d352b8	Make StatisticItem.Name not nullable	2022-08-20 21:48:35 -04:00
Nao	189a407cb1	Merge branch 'master' into ruleset-localization	2022-08-20 21:39:10 -04:00
Dean Herbert	8566e93c72	Guard against SubmittingPlayer potentially getting stuck waiting on request forever	2022-08-20 17:19:17 +09:00
Dean Herbert	da407aa827	Merge branch 'master' into kps	2022-08-20 15:24:58 +09:00
Dean Herbert	cbdd870ecf	Merge pull request #19693 from its5Q/editor-localisation ... Add localisation support for beatmap editor setup	2022-08-20 11:51:57 +09:00
Dean Herbert	7bf318541c	Reword comment to hopefully read better	2022-08-19 20:57:55 +09:00
Dean Herbert	3f0da14065	Delay start operation by one frame to allow children to see initial start time	2022-08-19 17:39:51 +09:00
its5Q	4c24d8ed58	Improve string consistency	2022-08-19 03:17:05 +10:00
Dean Herbert	3eb1cda6aa	Reorganise call order of Start / Reset to make more sense	2022-08-19 01:46:36 +09:00
Ryuki	3de35a1518	Update calculator and tests to match changes on clocks	2022-08-18 18:40:02 +02:00
Dean Herbert	1d774f3f12	Remove redundant ProcessFrame calls ... Of note, I'm not sure whether the `IsPaused` check was meaningful, but it's not reimplemented in the new `FramedBeatmapClock`.	2022-08-19 01:39:02 +09:00
Dean Herbert	7bc96431a7	Remove unnecessary virtual spec from GameplayClockContainer.Seek	2022-08-19 01:39:01 +09:00
Dean Herbert	0e228791c0	Remove unnecessary Reset call in MultiSpectatorScreen	2022-08-19 01:39:01 +09:00
Dean Herbert	43879633db	Ensure setting a StartTime on a GameplayClockContainer always resets to the new time	2022-08-18 18:54:10 +09:00
Dean Herbert	343efa1d11	Split OffsetCorrectionClock out of MasterGameplayClockContainer	2022-08-18 18:54:10 +09:00
Dean Herbert	2c6fd1ec6e	Fix `GameplayClockContainer potentially resetting external seeks	2022-08-18 18:54:10 +09:00
Dean Herbert	6003afafc7	Use FramedBeatmapClock in GameplayClockContainer	2022-08-18 18:54:10 +09:00
Dean Herbert	9735728cf6	Reverse conditionals to better define intent in addSourceClockAdjustments	2022-08-18 15:08:09 +09:00
Bartłomiej Dach	d06959e1dd	Update incorrect xmldoc	2022-08-17 22:03:35 +02:00
Dean Herbert	e7ddbc41c8	Merge branch 'master' into no-gameplay-clock	2022-08-17 22:21:10 +09:00
Dan Balasescu	0cf3c5570a	Merge pull request #19800 from peppy/fix-editor-ear-rape ... Fix slider ticks playing back at infinite rate while making changes to a slider in the editor	2022-08-17 15:50:58 +09:00
Dean Herbert	20256aad11	Merge branch 'master' into no-gameplay-clock	2022-08-17 15:21:20 +09:00
Dean Herbert	21b364cd77	Fix nullref in tests as initialBeatmap may be null	2022-08-17 14:48:00 +09:00
Dean Herbert	6b9dec5996	Restore original event flow to allow for OnSuspend case to work correctly	2022-08-17 14:32:21 +09:00
Dean Herbert	8ce50e98a6	Move delegate debounce logic to Editor itself	2022-08-17 14:04:57 +09:00
Dan Balasescu	8b5ac55fca	Remove newline	2022-08-17 13:48:06 +09:00
Dean Herbert	d9346abb9c	Tweak intro timings more and ensure non-theme tracks play from preview point	2022-08-17 13:20:40 +09:00
Dean Herbert	37799e3b31	Allow preparing preview point without looping	2022-08-17 13:20:24 +09:00
Bartłomiej Dach	1861f34427	Merge branch 'master' into editor-setup-no-state-change	2022-08-16 21:46:43 +02:00
Dan Balasescu	24fd411720	Merge pull request #19594 from BlauFx/improve_retry_behaviour ... Skip song intro on quick restart	2022-08-16 20:18:12 +09:00
Dean Herbert	5ac314077a	Improve intro timings when not using osu! theme ... Roughly as proposed in https://github.com/ppy/osu/discussions/19687.	2022-08-16 18:19:30 +09:00
Dean Herbert	ee153a345c	Add a few more overlooked beatmap save states on setup screen modifications	2022-08-16 16:31:56 +09:00
Dean Herbert	5238a5c115	Merge branch 'master' into editor-setup-no-state-change	2022-08-16 16:28:29 +09:00
Dean Herbert	9d2c2b71cf	Change conditional to check for insertions in addition to modifications ... It is possible that the import process itself marks the previous beatmaps as deleted due to an overlap in metadata or otherwise.	2022-08-16 16:21:36 +09:00
Dean Herbert	c8fdfd298c	Merge branch 'master' into carousel-maintain-selection-over-update	2022-08-16 16:04:32 +09:00
Dean Herbert	ea50936d71	Fix slider ticks playing back at infinite rate while making changes to a slider in the editor	2022-08-16 15:27:58 +09:00
its5Q	e870ac6456	Fix code quality for CI	2022-08-16 15:51:54 +10:00
Dean Herbert	63819648df	Fix up flow of actual skip operation	2022-08-16 14:40:02 +09:00
Dean Herbert	9a1a7bae89	Make test actually test things	2022-08-16 14:40:02 +09:00
Dean Herbert	6761f869f9	Modify flow to avoid weird bindable and value resetting	2022-08-16 14:17:35 +09:00
Dean Herbert	c9baadcf88	Merge branch 'master' into improve_retry_behaviour	2022-08-16 13:06:04 +09:00
Bartłomiej Dach	5ff2e41a55	Add preset column to mod select test scene	2022-08-15 18:38:37 +02:00
its5Q	797a8da996	Replace osu-web strings with new strings and merge to single file	2022-08-16 01:14:16 +10:00
Dean Herbert	61a8873266	Ensure GameplayClockContainer's FramedClock is always non-null	2022-08-15 20:22:36 +09:00
Dean Herbert	1696a905ba	Reduce exposed properties in GameplayClockContainer	2022-08-15 20:22:36 +09:00
Dean Herbert	704568ae3b	Remove remaining usage of GameplayClock	2022-08-15 20:22:36 +09:00
Dean Herbert	27569e2ed5	Remove FrameStableClock (and redirect usages to FrameStabilityContainer)	2022-08-15 19:19:19 +09:00
Dean Herbert	cc982d374c	Cache self rather than GameplayClock	2022-08-15 18:30:53 +09:00
Dean Herbert	c5f8529d20	Mark unused methods as NotImplemented for safety	2022-08-15 18:30:53 +09:00
Dean Herbert	f81c7644b4	Make GameplayClockContainer also an IGameplayClock and expose to remaining tests	2022-08-15 18:30:53 +09:00
Dean Herbert	c8764cb333	Move all usage of GameplayClock to IGameplayClock	2022-08-15 18:30:53 +09:00
Dean Herbert	6d78218142	Update usages of GameplayClockContainer.GameplayClock to access properties directly	2022-08-15 18:08:49 +09:00
Dean Herbert	224f3eaa84	Make GameplayClockContainer non-abstract and use in MultiSpectatorPlayer	2022-08-15 18:08:49 +09:00
Dean Herbert	623e90a7b2	Fix div-by-zero in SongProgress when no object duration could be calculated	2022-08-15 15:05:35 +09:00
naoei	18ce784ae0	Allow StatisticItem's name param to be nullable	2022-08-14 14:51:35 -04:00
Ryuki	2aa3a1b50d	Rename all "KeysPerSecond" usages to "ClicksPerSecond"	2022-08-14 20:12:11 +02:00
Ryuki	9dc806506e	Make ActionListener and KeysPerSecondCalculator not rely on events to add timestamps	2022-08-14 19:31:14 +02:00
Ryuki	d5f10cbb9d	Revert 787dee24 and initialize calculator in HUDOverlay	2022-08-14 18:53:00 +02:00
Bartłomiej Dach	05ddfe7522	Merge branch 'master' into editor-setup-no-state-change	2022-08-14 18:21:31 +02:00
Ryuki	e08f71797e	Change displayed metric from "KPS" to "clicks/s"	2022-08-13 04:27:26 +02:00
Ryuki	9b252b1d81	Make KeysPerSecondCalculator dependency in HUDOverlay nullable	2022-08-11 11:58:30 +02:00
Ryuki	d29cba80e9	Remove useless comment in KeysPerSecondCounter	2022-08-11 11:01:16 +02:00
Ryuki	787dee249d	Move KeysPerSecondCalculator instantiation from HUDOverlay to Player ... This prevents messing with *future* Skin (de)serialization	2022-08-11 10:37:16 +02:00
Ryuki	3c6461b9e4	Remove KPS acronym usage	2022-08-11 10:01:39 +02:00
Ryuki	0a94fb4039	Make KPS counter strictly depending only on KPS calculator ... `KeysPerSecondCounter` now depends on `KeysPerSecondCalculator` via the `BackgroundDependencyLoaderAttribute` method, making it appear only in a gameplay context without requiring `GameplayClock` without using it.	2022-08-11 00:46:39 +02:00
Ryuki	46e372cb99	Add more readiness checks in KeysPerSecondCalculator	2022-08-11 00:43:15 +02:00
Ryuki	9e80d3f71c	Re-adjust timespan conditions in KeysPerSecondCalculator	2022-08-11 00:42:22 +02:00
naoei	6e13cf82e8	Don't render statistic header if display string is null	2022-08-10 16:05:34 -04:00
naoei	8cb2e11766	Change most ruleset-accessible string types to Localisable strings	2022-08-10 15:51:11 -04:00
its5Q	2499b7f0cd	Add localisation support for beatmap editor setup	2022-08-11 03:53:20 +10:00
Dean Herbert	ac99c1ad69	Migrate the majority of existing file lookups to use new extension methods	2022-08-10 16:01:16 +09:00
Dean Herbert	a5081826b7	Handle cancellation at more points during Player initialisation ... As discussed in discord, this will help avoid null references during cancellation which can otherwise be quite confusing to debug.	2022-08-09 23:25:19 +09:00
Dan Balasescu	41af03dec5	Merge pull request #19597 from frenzibyte/hotfix-multi-spectator-results-screen ... Fix multi-spectator potentially getting stuck for passed players (hotfix)	2022-08-09 21:11:10 +09:00
Ryuki	b52a07c16a	Use DI to provide dependencies for KPS Calculator and improve input ... gathering KPS Calculator now uses DI to retrieve the clocks. Using `HUDOverlay` it is now cached for `KeysPerSecondCounter`s to resolve it. This also allows to make an "Attach" flow like `KeyCounter`.	2022-08-08 21:54:06 +02:00
BlauFx	0afa3a5ec8	Fix xml doc	2022-08-08 21:20:09 +02:00
BlauFx	f6e65cf1af	Improve implementation	2022-08-08 20:53:05 +02:00
BlauFx	fac2596eee	Change type from BindableBool to IBindable<bool>	2022-08-08 13:38:52 +02:00
BlauFx	cd68134565	Call skip method directly	2022-08-08 13:10:28 +02:00
Dean Herbert	cbe5cb5d03	Merge branch 'master' into carousel-maintain-selection-over-update	2022-08-08 18:01:26 +09:00
Dean Herbert	f1691882e2	Fix incorrect argument passing to ToMod	2022-08-08 12:56:18 +09:00
Dean Herbert	e1189da824	Merge branch 'master' into irenderer-glwrapper	2022-08-08 12:31:53 +09:00
Bartłomiej Dach	839409d7ac	Add preset column to solo mod select overlay	2022-08-07 16:20:31 +02:00
HiddenNode	ed86255e2b	Use UprightUnscaledContainer instead of KeepUprightAndUnscaled	2022-08-07 13:20:22 +01:00
BlauFx	bb344e064f	Add xml docs	2022-08-07 13:31:26 +02:00
BlauFx	09230304a4	Improve implementation	2022-08-07 13:20:29 +02:00
Ryuki	b2557a8d2d	Refactor KPS ... - Remove '#nullable disable' in KeysPerSecondCalculator and KeysPerSecondCounter - Remove KeysPerSecondCalculator IDisposable implementation - Make KeysPerSecondCalculator static instance initialized once by KeysPerSecondCounters - Auto transfer dependencies from KeysPerSecondCounter to KeysPerSecondCalculator using Resolved properties - Add internal reset logic to KeysPerSecondCalculator and make it independent from Player - Use GameplayClock.TrueGameplayRate to get real-time rate. If 0 then it defaults to the last non 0 rate if no such mod is enabled	2022-08-07 00:53:00 +02:00
Bartłomiej Dach	a0d093be5c	Extract common implementation of delete dialog	2022-08-06 21:04:12 +02:00
BlauFx	bd43a9e96e	Add missing type specification	2022-08-06 18:49:07 +02:00
BlauFx	fa6d55b5b5	Remove redundant lambda signature parentheses	2022-08-06 18:47:11 +02:00
BlauFx	0d418559bc	Skip song intro only in case of a quick restart	2022-08-06 17:02:45 +02:00
BlauFx	e411a2d187	Revert reduced wait time commit	2022-08-06 15:12:36 +02:00
Salman Ahmed	84ef24c341	Fix multi-spectator potentially getting stuck for passed players	2022-08-06 05:41:26 +03:00
BlauFx	445f921756	Move IsSkippable event into load method	2022-08-05 23:21:03 +02:00
BlauFx	d8d7423698	Reduce "wait time" in case restarting the map	2022-08-05 23:04:43 +02:00
BlauFx	99e07aa09a	Skip intro if the map gets restarted	2022-08-05 23:01:52 +02:00
BlauFx	6717f0606c	Add property to SkipOverlay	2022-08-05 23:00:37 +02:00
Ryuki	0886137e39	Prevent KeysPerSecondCounter from NRE when no instance is initialized	2022-08-05 21:03:00 +02:00
HiddenNode	b46bc5d65b	Remove empty line	2022-08-05 14:57:33 +01:00
Ryuki	24c29b7e2f	Do not add KPS calculation when gameplay rate is 0	2022-08-05 15:51:07 +02:00
HiddenNode	0243f8d6ac	Clean up	2022-08-05 14:28:15 +01:00
HiddenNode	12ef99a1a1	Fix text position	2022-08-05 12:56:08 +01:00
Dan Balasescu	802dc90cb1	Adjust using directives for vertices	2022-08-05 20:37:33 +09:00
Dan Balasescu	c4b9b2a14b	Merge branch 'master' into irenderer-glwrapper	2022-08-05 20:35:06 +09:00
Ryuki	42d1bdfc95	Move KPS calculation to a standalone class	2022-08-05 04:17:01 +02:00
Salman Ahmed	7c45c571a0	Merge branch 'master' into more-beat-sync-dependence	2022-08-03 20:22:42 +03:00
Dean Herbert	a32149fda1	Convert interface methods to extension methods	2022-08-03 20:07:55 +09:00
Dean Herbert	6ad6561e1c	Fix LegacySongProgress incorrectly blocking mouse input from gameplay ... Closes #19555.	2022-08-03 17:42:29 +09:00
HiddenNode	dbb77705da	Merge branch 'fix_text_orientation' into fix_progress_bar_info	2022-08-02 19:00:43 +01:00
HiddenNode	bc21a2ed56	Remove unnecessary using directive	2022-08-02 17:41:17 +01:00
HiddenNode	78a98cdb9c	Prevent TextSprites inside SongProgressInfo from being stretched or flipped	2022-08-02 17:37:31 +01:00
Dean Herbert	de186f67e0	Limit metadata updates to once per frame	2022-08-02 22:02:30 +09:00
Dan Balasescu	b4e55f7309	Apply IRenderer changes	2022-08-02 19:50:57 +09:00
Dan Balasescu	a2a913ab52	Merge branch 'irenderer-batches' into irenderer-textures	2022-08-02 19:25:08 +09:00
Dean Herbert	258ad7c6b9	Tidy up kiai time access	2022-08-02 18:18:40 +09:00
Dean Herbert	cc4cde2c79	Improve IBeatSyncProvider interface and reduce beatmap track dependence	2022-08-02 17:59:18 +09:00
Dean Herbert	efa3c3b757	Fix multiple cases of mutations at editor setup screen not triggering a state save	2022-08-02 16:47:37 +09:00
Dan Balasescu	fc0914bf77	Merge pull request #19536 from frenzibyte/playlists-settings-leak ... Fix playlist settings reference leak due to unsafe binding	2022-08-02 13:30:55 +09:00
HiddenNode	df85bd74d7	Keep TextSprites in SongProgressInfo upright	2022-08-01 21:46:37 +01:00
Dean Herbert	c0e5f11c90	Merge pull request #19532 from frenzibyte/fix-new-items-sort-stability ... Fix newly imported beatmaps not using correct comparer for sorting	2022-08-02 02:20:51 +09:00
Salman Ahmed	7e9d11ee24	Enable NRT on playlists settings overlay	2022-08-01 20:15:08 +03:00
Salman Ahmed	c851e3d8f3	Fix playlist settings reference leak due to unsafe callback binding	2022-08-01 20:08:18 +03:00
Salman Ahmed	fc7fc3d673	Fix newly imported beatmaps not using correct comparer for sorting	2022-08-01 19:13:57 +03:00
Dean Herbert	01cc9bd7ef	Merge pull request #19479 from frenzibyte/carousel-update-on-resume ... Fix song select not updating selected beatmap card on editor resume	2022-08-02 00:48:18 +09:00
Joseph Madamba	1dbb2a4d37	Fix online play screen only accounting for current sub screen onexiting blocks	2022-08-01 07:57:30 -07:00
Dan Balasescu	d4eec9122f	Merge pull request #19516 from peppy/fix-editor-track-disposal-crash ... Fix editor potentially playing a track post-disposal	2022-08-01 18:12:21 +09:00
Dan Balasescu	1d27c4f020	Merge pull request #19504 from peppy/skin-serialisation-test-coverfage ... Add test coverage of deserialisation of skin layouts	2022-08-01 17:17:16 +09:00
Dean Herbert	6e7c298aaf	Fix changes to audio / background not triggering an editor state change	2022-08-01 16:53:49 +09:00
Dean Herbert	2f60f91a0e	Fix editor potentially using a track post-disposal ... This changes the editor to track the current track as it is *loaded* by `MusicController`, rather than haphazardly following the current global `WorkingBeatmap` (with a potentially unloaded track) or relying on local immediate-load behaviour (as implemented in `ResourcesSection`).	2022-08-01 16:53:49 +09:00
Dean Herbert	5b98a73edc	Apply nullability to SkinComponentToolbox and split out reflection method to get all skinnable components	2022-08-01 14:04:08 +09:00
notmyname	fa3b9ee32f	remove unneded guard	2022-07-31 23:42:20 +02:00
notmyname	57b43e0065	Stop capturing arrow keys on Playlist	2022-07-31 19:12:29 +02:00
Ryuki	89855cc1d6	Change KPS Counter implementation base and add better replay integration ... The counter implementaiton is now list based, and will not invalidate previous hits by removing them but by testing if they are within the 1 second span, allowing better integration with replays and spectators.	2022-07-31 01:29:57 +02:00
Salman Ahmed	faefda9143	Fix song select not updating selected beatmap card on editor resume	2022-07-30 19:47:42 +03:00
Susko3	38a8b9cf0a	Add battery info for desktop platforms	2022-07-30 14:26:19 +02:00
Dean Herbert	43e612f6d4	Merge pull request #19455 from peppy/confirm-playlist-discard ... Add confirmation dialog when about to discard a playlist	2022-07-30 19:17:49 +09:00
Salman Ahmed	8ca8484f0e	Fix failing tests	2022-07-30 11:49:33 +03:00
Salman Ahmed	369ab10212	Fix exit confirmation dialog not blocking all exit cases	2022-07-30 11:00:31 +03:00
Salman Ahmed	2500e5c533	Merge branch 'master' into fix-summary-kiai-ranges	2022-07-29 19:38:28 +03:00
Dan Balasescu	09979d44aa	Apply DrawNode batching changes	2022-07-29 23:32:09 +09:00
Dean Herbert	acf9ad1429	Apply nullability to EffectPointVisualisation	2022-07-29 23:26:38 +09:00
Salman Ahmed	3bc1774c87	Merge branch 'master' into pie-chart-progress	2022-07-29 16:54:59 +03:00
Salman Ahmed	905bbdc8ee	Remove caching of GameplayClockContainer in favour of GameplayClock ... Also fixes `SongProgress` being displayed in skin editor on non-gameplay screens, due to `GameplayClock` not marked as a required dependency.	2022-07-29 16:45:29 +03:00
Dan Balasescu	155dac55d0	Apply DrawNode parameter changes	2022-07-29 22:33:34 +09:00
Salman Ahmed	3f72e76348	Expose StartTime from gameplay clock	2022-07-29 16:18:05 +03:00
Dean Herbert	8f1e3b0154	Fix editor summary timeline not responding to kiai changes correctly	2022-07-29 19:31:49 +09:00
Dean Herbert	9d457535c6	Add confirmation dialog when about to discard a playlist ... The confirmation will only show if items have been added to the playlist. Closes https://github.com/ppy/osu/issues/19444.	2022-07-29 17:11:37 +09:00
Dean Herbert	eb92c35335	Merge pull request #19442 from smoogipoo/fix-beginplaying-misordering ... Move spectator begin/end playing to SubmittingPlayer	2022-07-29 16:09:50 +09:00
Ryuki	2df24019fd	Merge branch 'master' into kps	2022-07-28 18:38:09 +02:00
Ryuki	b2e7da5aa0	Add basic Queue based implementation of KPS	2022-07-28 18:37:12 +02:00
Dean Herbert	3005ff1b9f	Merge branch 'master' into pie-chart-progress	2022-07-28 22:19:27 +09:00
Dan Balasescu	11e0022fad	Merge branch 'master' into realm-collections	2022-07-28 21:00:08 +09:00
Dan Balasescu	ce694123eb	Move spectator begin/end playing to SubmittingPlayer	2022-07-28 20:44:04 +09:00
Dean Herbert	86c2b7e449	Apply nullability to DefaultSongProgress and clean up more stuff	2022-07-28 18:37:17 +09:00
Dean Herbert	ea027eda46	Move initial show to base implementation and add transition for legacy version	2022-07-28 18:29:49 +09:00
Dean Herbert	d5e5761892	Fix DefaultSongProgress graph not resetting if time is in intro	2022-07-28 18:25:24 +09:00
Dean Herbert	7108553883	Tidy up various things everywhere	2022-07-28 18:25:14 +09:00
Nitrous	0d36907cad	apply code quality fixes	2022-07-28 15:30:45 +08:00
Nitrous	bca3994d91	set FirstHitTime and LastHitTime once	2022-07-28 15:25:12 +08:00
Nitrous	db62d4be3a	apply suggestions ... - refactor `SongProgress` - make`UpdateProgress` more readable - enable NRT on new classes - refactor `TestSceneSongProgress` to use `GameplayClockContainer`	2022-07-28 15:15:41 +08:00
Dean Herbert	525e4a2019	Fix crash in DrawableRoomPlaylistItem context menu creation due to incorrect enumeration casting	2022-07-28 15:51:18 +09:00
Dean Herbert	ad482b8afc	Tidy up naming of collection dropdowns	2022-07-28 13:57:21 +09:00
Dean Herbert	67c7f324ee	Simplify CollectionFilterDropdown filter flow weirdness	2022-07-28 13:57:21 +09:00
Nitrous	9088caa377	move LegacyComboCounter to osu.Game.Skinning	2022-07-28 08:36:26 +08:00
Nitrous	45c11f2b7b	account for gameplay start time	2022-07-28 08:01:38 +08:00
Micahel Kelly	dd315ff97b	Adds hard-delete for a beatmap diff	2022-07-27 21:21:16 +10:00
Dean Herbert	438067a18b	Convert realm data propagation to more correctly use Live<T> ... wip	2022-07-27 19:35:09 +09:00
Dean Herbert	41393616d8	Replace BeatmapCollection with RealmBeatmapCollection	2022-07-27 19:35:09 +09:00
Dean Herbert	9c543fef48	Remove CollectionManager	2022-07-27 18:45:33 +09:00
Micahel Kelly	3febd6d644	Dialogue touchups	2022-07-27 19:23:55 +10:00
Micahel Kelly	e6fad601cc	Adds delete difficulty option to editor	2022-07-27 19:15:43 +10:00
Nitrous	37e642b0bd	make SongProgress abstract ... - move unrelated logic to `DefaultSongProgress` - make `LegacySongProgress` inherit `SongProgress`	2022-07-27 15:19:21 +08:00
Dean Herbert	e6a3659581	Guard against NewModifiedIndices being empty	2022-07-27 14:23:47 +09:00
Dean Herbert	24d75612e2	Always attempt to follow selection, even if difficulty name / metadata change	2022-07-27 14:18:53 +09:00
Dean Herbert	8105d4854a	Fix beatmap carousel not maintaining selection if currently selected beatmap is updated	2022-07-27 13:33:48 +09:00
Dan Balasescu	bc60552694	Merge pull request #19402 from peppy/debugger-attached-audio-warning-disable ... Don't show audio playback issue notification if debugger is attached	2022-07-26 18:49:33 +09:00
Dan Balasescu	8f7dff5c2c	Merge pull request #19378 from peppy/beatmap-update-test ... Add separate beatmap update flow to handle edge cases better	2022-07-26 18:49:20 +09:00
Dean Herbert	e782590b3c	Don't show audio playback issue notification if debugger is attached ... I've hit this countless times recently when debugging during the startup procedure.	2022-07-26 18:20:46 +09:00
Dean Herbert	6ff44ed2c6	Merge pull request #19399 from frenzibyte/carousel-order-stability ... Maintain sort stability by using carousel item ID as a fallback	2022-07-26 17:33:30 +09:00
Dean Herbert	7f75184a01	Merge branch 'master' into beatmap-update-test	2022-07-26 17:27:36 +09:00
Dan Balasescu	412d42b907	Merge pull request #19393 from peppy/fix-statistics-panel ... Avoid potential realm fetch after disposal in `StatisticsPanel`	2022-07-26 16:32:59 +09:00
Salman Ahmed	a4f6f2b9eb	Make item ID comparer static	2022-07-26 09:55:37 +03:00
Dean Herbert	8370ca9765	Add ImportAsUpdate method to IModelImporter to avoid otehr changes	2022-07-26 15:49:04 +09:00
Salman Ahmed	693ac8750c	Remove remaining uses of "child" terminology in non-drawable components	2022-07-26 09:43:47 +03:00
Salman Ahmed	d7ef4170be	Maintain sort stability by using carousel item ID as fallback	2022-07-26 09:40:41 +03:00
Dean Herbert	4efe09e7c2	Merge pull request #19377 from frenzibyte/fix-timeline-tests ... Fix intermittent timeline zoom test failures	2022-07-26 15:18:35 +09:00
Dean Herbert	99bdf41717	Avoid potential realm fetch after disposal in StatisticsPanel ... As seen at https://github.com/ppy/osu/runs/7513799859?check_suite_focus=true.	2022-07-26 15:12:23 +09:00
Dan Balasescu	1b2158ff04	Remove unused method	2022-07-26 14:15:59 +09:00
Dean Herbert	ef10145d6f	Rename MenuCursorContainer and clean up code	2022-07-26 14:11:52 +09:00
Dean Herbert	b7f6413bce	Fix old version of beatmap potentially not being deleted during update flow ... This can happen if the online IDs are not present in the `.osu` files. Previously this was only working due to the early logic in the import process (that relies on matching all online IDs perfectly).	2022-07-25 19:51:19 +09:00
Salman Ahmed	48bcf57066	Mark SetupZoom and parameterless ZoomableScrollContainer ctor as protected	2022-07-25 12:07:50 +03:00
Salman Ahmed	07c6b44864	Fix Timeline attempting to setup zoom with unloaded track	2022-07-25 12:07:50 +03:00
Salman Ahmed	123930306b	Refactor ZoomableScrollContainer to allow setting up zoom range and initial zoom after load	2022-07-25 12:07:50 +03:00
Salman Ahmed	fa9daa6899	Fix TestSceneReplayRecorder not using score provided by gameplay state	2022-07-25 05:21:27 +03:00
solstice23	aaad2e474c	Refactor the multiple regex checks in criteria parsing	2022-07-23 21:43:27 +08:00
solstice23	63210d5662	Merge branch 'master' into search-filter	2022-07-23 18:13:53 +08:00
solstice23	3f2c341369	Simplify length parsing	2022-07-23 18:13:19 +08:00
Salman Ahmed	3aecd288e2	Enable NRT on TopLocalRank	2022-07-23 09:27:03 +03:00
Salman Ahmed	1d0306810a	Fix TopLocalRank not handling legacy scores properly	2022-07-23 09:24:38 +03:00
Salman Ahmed	727fe76b60	Fix TopLocalRank hacking around presence to hide on null rank ... Fixed this here because that blocks `Schedule` from running, and I don't want to add another override to the `IsPresent` flag.	2022-07-23 09:22:22 +03:00
Dean Herbert	db632c0d6e	Inline rolling duration	2022-07-23 02:38:00 +09:00
Dean Herbert	475679ca66	Fix DI failure	2022-07-23 02:27:47 +09:00
Dean Herbert	bb46ba66e0	Simplify TotalScoreCounter tick playback logic	2022-07-23 02:27:17 +09:00
Dean Herbert	9f045209b9	Simplify score panel balance adjustment	2022-07-23 02:09:08 +09:00
Jamie Taylor	62d4d4b055	Add dynamic panning fun to score panel sfx	2022-07-22 21:03:47 +09:00
Jamie Taylor	89da21b6de	Add total score counter sfx	2022-07-22 21:03:47 +09:00
Jamie Taylor	6ce8e74e6b	Add panel appearance sounds	2022-07-22 21:03:46 +09:00
Dean Herbert	63fe4f265f	Merge pull request #19263 from frenzibyte/fix-failed-score-statistics ... Populate failed scores with "miss" results for all remaining hitobjects	2022-07-22 20:16:16 +09:00
Dean Herbert	bfafb4480e	Merge pull request #19296 from smoogipoo/fix-timeline-focus-point ... Fix timeline zoom focus point when using zoom buttons	2022-07-22 17:43:36 +09:00
Dan Balasescu	1d69090301	Merge pull request #19295 from frenzibyte/filter-control-available-area ... Fix sorting mode not filling up to usable area in filter control	2022-07-22 17:20:40 +09:00
Dan Balasescu	e1df50c8ff	Fix timeline zoom focus point when using buttons	2022-07-22 17:03:05 +09:00
Dean Herbert	72916d708c	Merge pull request #19294 from peppy/fix-timeline-feedback-loop ... Fix timeline `alt`+`scroll` zoom not correctly zooming to current mouse position	2022-07-22 16:05:38 +09:00
Dean Herbert	1774a96455	Merge pull request #19278 from Cwazywierdo/timeline-relative-zoom ... Make editor timeline zoom relative to song length	2022-07-22 15:37:47 +09:00
Dean Herbert	6eb42d08ce	Fix timeline zoom receiving feedback from bindable changes ... This causes the focal point zooming to not work (as the focal point is lost). There's no need to handle ongoing changes to `BeatmapInfo.TimelineZoom` because it is not a property which is changed at runtime.	2022-07-22 15:25:57 +09:00
solstice23	7c222505e9	Simplify length parsing	2022-07-22 14:24:17 +08:00
Salman Ahmed	3b913bb9ad	Fix sorting mode not filling up to usable area in filter control	2022-07-22 09:15:48 +03:00
Dean Herbert	4cec9a085a	Combine both calls to use same pathway	2022-07-22 14:59:20 +09:00
Dean Herbert	f713253d1b	Fix formatting inconsistencies in empty ctors	2022-07-22 14:00:29 +09:00
LukynkaCZE	ed94d7fce8	Fix requested changes	2022-07-22 02:46:17 +02:00
Adam Baker	997fe00cdc	Fix zoom delta math	2022-07-21 17:29:13 -05:00
Adam Baker	d69dc457ba	Extract zoom delta method	2022-07-21 17:28:43 -05:00
LukynkaCZE	ebe386c288	Merge branch 'ppy:master' into editor-save-toast	2022-07-22 00:25:23 +02:00
solstice23	b36e23c0da	Simplify the regex expression	2022-07-22 03:30:31 +08:00
solstice23	ae0902ca86	Fix lax in search criteria parsing	2022-07-22 02:55:11 +08:00
solstice23	0dcb3644f5	Merge branch 'master' into search-filter	2022-07-22 01:32:25 +08:00
Adam Baker	a4f071fe53	Make zoom sensitivity relative to containers max zoom	2022-07-21 08:26:48 -05:00
solstice23	6baaef432f	Add colon parsing support in search length criteria	2022-07-21 18:49:13 +08:00
solstice23	a5a8fac66f	Add multiple units support in search length criteria	2022-07-21 18:24:31 +08:00
Dean Herbert	fc0c9f76bd	Fix UpdateBeatmapSetButton intermittent test failure ... Carousel would only expire items when off-screen. This meant that for a case (like a test) where items are generally always on-screen, `UpdateBeatmapSet` calls would result in panels remaining hidden but not cleaned up.	2022-07-21 16:24:48 +09:00
Dean Herbert	3cfe624af1	Fix one more missed method with incorrect terminology	2022-07-21 16:16:41 +09:00
Dean Herbert	a05d7f4d8c	Change carousel terminology to not use Children / InternalChildren	2022-07-21 16:06:06 +09:00
Dean Herbert	07e1763a70	Tweak velocity a bit more (and simplify in multiple places)	2022-07-21 14:25:11 +09:00
Salman Ahmed	ad09e728fd	Move Passed assignment inside FailScore	2022-07-21 08:12:06 +03:00
TacoGuyAT	2f16174d3d	Changed control points set to private; Cleanup	2022-07-21 07:25:44 +03:00
TacoGuyAT	d6c3a52494	Added missing braces	2022-07-21 06:38:33 +03:00
TacoGuyAT	ed8e065a86	Logo triangles speed and beat sync tweaks	2022-07-21 06:13:45 +03:00
Salman Ahmed	0f0b19da4a	Populate score with remaining "miss" statistics on fail/exit	2022-07-21 06:01:36 +03:00
Dan Balasescu	7dfc18a0e3	Merge pull request #19208 from frenzibyte/remove-score-multiplier-on-custom-mod-settings ... Remove score multiplier on difficulty-increasing mods with customised settings	2022-07-20 20:12:59 +09:00
Dan Balasescu	2b399ec7ad	Merge branch 'master' into date-submitted-ranked	2022-07-20 18:36:57 +09:00
Dan Balasescu	de29078db2	Remove nullable disables	2022-07-20 15:16:40 +09:00
Dan Balasescu	f9c02c34b6	Merge branch 'master' into beatmap-update-online-flow	2022-07-20 15:15:51 +09:00
Salman Ahmed	6ce6f6f7df	Merge branch 'master' into remove-score-multiplier-on-custom-mod-settings	2022-07-20 08:57:43 +03:00
Adam Baker	cecf654a7b	Update osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerMatchSubScreen.cs ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2022-07-19 18:58:59 -05:00
Salman Ahmed	ae6aab2555	Merge branch 'master' into edit-map-carousel	2022-07-20 02:43:47 +03:00
LukynkaCZE	5987acfbca	Fixed code formatting	2022-07-19 22:59:25 +02:00
LukynkaCZE	a00da279b7	Beatmap Editor Save Toast	2022-07-19 21:38:23 +02:00
Salman Ahmed	4210ec6502	Merge branch 'master' into remove-score-multiplier-on-custom-mod-settings	2022-07-19 19:21:26 +03:00
Adam Baker	4164f260b3	Fix code quality errors	2022-07-19 08:12:12 -05:00
Dean Herbert	30daa0fd44	Add ranked and submitted date storage and filtering	2022-07-19 19:55:56 +09:00
Dean Herbert	17046b0553	Add basic handling of download failures	2022-07-19 19:01:23 +09:00
Dean Herbert	a16bf35581	Rename button class and add basic progress display	2022-07-19 18:29:36 +09:00
Dean Herbert	da360af15a	Fix vertical centering of button	2022-07-19 18:29:36 +09:00
Dean Herbert	eaf4f6dbb7	Add beatmap update button	2022-07-19 18:29:36 +09:00
Adam Baker	5008a73774	Make add item button open to the last beatmap in queue	2022-07-19 02:04:19 -05:00
Dan Balasescu	c07f78409e	Merge pull request #19189 from peppy/peform-actions-after-reconnect ... Fix creating multiplayer game during server migration not joining new room correctly	2022-07-19 14:46:29 +09:00
Adam Baker	59018ab5ba	Fix multiplayer queue edit button opening to the wrong beatmap	2022-07-18 23:21:16 -05:00
Bartłomiej Dach	6f37487528	Replace calls to defective Humanizer methods with correct version	2022-07-18 22:34:58 +02:00
Salman Ahmed	2befcfedbb	Merge branch 'master' into fix-multiplayer-participant-panel-null-ruleset	2022-07-18 12:24:47 +03:00
Dean Herbert	b8c90266de	Merge pull request #19209 from 3stantedja/make-contracted-stats-titlecase ... Make sure stats name are title-cased when score panel is contracted	2022-07-18 16:26:20 +09:00
Dean Herbert	a7f19cc796	Merge pull request #19137 from frenzibyte/country-enum ... Replace `Country` class with enumeration	2022-07-18 16:12:24 +09:00
Salman Ahmed	e86a35fe33	Fix NRE on footer button mods	2022-07-18 10:09:14 +03:00
Dean Herbert	a036632c8b	Fix potential crash when attempting to create mod display using null ruleset	2022-07-18 15:30:21 +09:00
Dean Herbert	21bf7ee448	Turn on nullability in ParticipantPanel	2022-07-18 15:27:55 +09:00
Salman Ahmed	100c53f9ef	Country -> CountryCode	2022-07-18 08:40:34 +03:00
Salman Ahmed	eddae7b143	Fix mod overlay and footer not updating multiplayer on settings change	2022-07-18 07:38:56 +03:00
Fyra Tedja	6ad7723d60	Make sure stats name are title-cased when score panel is contracted	2022-07-17 22:13:08 -06:00
Dean Herbert	55a8a3563b	Change MultiplayerMatchSubScreen to not immediately leave the room on connection loss ... Instead, we can rely on `MultiplayerClient.Room` going `null`.	2022-07-17 21:19:10 +09:00
tsunyoku	bbb2398a8b	change retry button icon from ArrowCircleLeft to Redo	2022-07-17 00:46:29 +01:00
Salman Ahmed	e62049f4a9	Update various usages of Country inline with new enum	2022-07-16 05:04:24 +03:00
Salman Ahmed	e6236ba088	Update save score button to check availability after import ... Previously was relying on whether `SaveReplay` returns null, but since I've changed it to use the standard "prepare score for import" path, the button has to check for local availability after import since that path doesn't return null on fail.	2022-07-15 23:39:52 +03:00
Salman Ahmed	6285442b7d	Fix failed scores not prepared before import	2022-07-15 22:57:12 +03:00
Salman Ahmed	8f7b3cf11a	Merge branch 'master' into Save-Score-Failed	2022-07-15 22:10:19 +03:00
Salman Ahmed	838e9ec12e	Merge branch 'master' into placeholder-fixes	2022-07-15 20:22:25 +03:00
Dean Herbert	cbbc8fdfb1	Merge pull request #19126 from peppy/lazer-leaderboards ... Show leaderboard scores from new data source	2022-07-16 01:53:16 +09:00
Dean Herbert	2beed6d7b7	Allow failed scores to fail in replay playback	2022-07-15 20:45:48 +09:00
Dean Herbert	d325c534ab	Check whether score is already imported and show correct state for save button	2022-07-15 20:45:37 +09:00
Dean Herbert	cf38b15332	Merge pull request #19124 from frenzibyte/song-select-metadata-search ... Change clicking source/tags on song select to filter instead of searching online	2022-07-15 19:16:31 +09:00
Dean Herbert	0200ef1d48	Make delegate firing more safe to being set later than BDL	2022-07-15 19:06:44 +09:00
Dean Herbert	0e788ac714	Simplify bindable logic greatly	2022-07-15 19:02:12 +09:00
Dean Herbert	8a48cb701d	Tidy up implementation and remove unnecessary enum	2022-07-15 19:02:04 +09:00