Joehu
62f2a823f6
Hide toolbar forever when the user hides it
2021-03-12 15:48:50 -08:00
Joehu
6c0734a09f
Handle global action in toolbar instead of osugame
2021-03-12 15:48:49 -08:00
Dean Herbert
3458dcc33a
Use whitelist to avoid exposing settings to user that shouldn't be
2021-03-12 18:40:38 +09:00
Dean Herbert
03230edcb1
Update bindings settings to handle the new structure and show all handlers
2021-03-12 18:38:16 +09:00
Dean Herbert
3c21c83cc8
Rename KeyboardSection to BindingSection
2021-03-12 18:36:28 +09:00
Dean Herbert
e7707eee94
Switch RestoreDefaultsValueButton to use HasPendingTasks to avoid tooltip always showing
2021-03-12 15:23:11 +09:00
Dean Herbert
b1cd01ceb8
Apply ConfigureAwait changes to game side
2021-03-08 14:36:35 +09:00
Dean Herbert
2b1ab3576b
Merge branch 'master' into migrate-country-rank
2021-03-08 11:07:25 +09:00
Salman Ahmed
132fcda089
Force config sensitivity value to local setting bindable
...
Re-enable the local bindable to update the sensitivity value then change back to whatever state it was in previously.
2021-03-04 17:00:44 +03:00
Dan Balasescu
6d4391de15
Merge pull request #11957 from peppy/move-mouse-settings-load-complete
...
Move bindable logic in MouseSettings to LoadComplete
2021-03-03 22:43:24 +09:00
Dean Herbert
534e16237a
Remove unnecessary intial construction of bindable
2021-03-03 20:36:41 +09:00
Dean Herbert
0f5bce70ad
Split confirmation dialog classes apart
2021-03-03 20:34:37 +09:00
Dean Herbert
002646370c
Move bindable logic in MouseSettings to LoadComplete
2021-03-03 16:47:42 +09:00
Dean Herbert
7dce9b04fa
Add a more basic ConfirmDialog implementation
2021-03-03 14:50:45 +09:00
Bartłomiej Dach
3b125a26a8
Add test coverage
2021-03-02 19:21:03 +01:00
Bartłomiej Dach
40a28367c6
Fix restore-to-default buttons never showing if initially hidden
2021-03-02 18:50:33 +01:00
Dean Herbert
6372a0265a
Fix confine mode dropdown becoming visible again after filtering
...
Changes from a hidden to a disabled state, with a tooltip explaining
why.
Closes #11851 .
2021-03-02 17:44:58 +09:00
Salman Ahmed
2609b22d53
Replace usage of CurrentModeRank
in line with API change
2021-03-01 23:07:25 +03:00
Bartłomiej Dach
52e81385a6
Fix restore default button mutating transforms during load
2021-02-27 11:39:18 +01:00
Dean Herbert
3e65dfb9e7
Reduce allocation overhead when notification overlay has visible notifications
2021-02-26 17:11:47 +09:00
Dean Herbert
8004652d27
Merge branch 'master' into optimised-has-flag-checks
2021-02-25 21:24:39 +09:00
Dean Herbert
90e8308716
Merge branch 'master' into localisation-refactor-framework
2021-02-25 17:28:55 +09:00
smoogipoo
dff1d80f39
Update HasFlag usages to HasFlagFast
2021-02-25 15:38:56 +09:00
Dean Herbert
2c8e62ae35
Fix toolbar not completing enough of layout to propagate hotkeys to buttons before initial display
2021-02-25 14:52:51 +09:00
Dean Herbert
e82eaffaed
Flip order back to original for romanisable strings
2021-02-25 14:14:07 +09:00
Dean Herbert
4cdde42228
Remove unnecessary backing field
2021-02-25 14:08:01 +09:00
Dean Herbert
8a97e2e28d
Update LocalisedString usages to RomanisedString
2021-02-22 19:01:42 +09:00
Dean Herbert
1fd76ea3fb
Apply changes to UI components overriding functions with changing signatures
2021-02-22 19:01:42 +09:00
smoogipoo
ccb83ef3a3
Fix checkbox not being updated
2021-02-22 15:47:47 +09:00
Dean Herbert
b68dbbceff
Merge branch 'master' into multiplayer-participant-rank
2021-02-19 13:16:44 +09:00
Dan Balasescu
28550f19e8
Merge branch 'master' into online-overlay-login-placeholder
2021-02-19 10:06:25 +09:00
Dean Herbert
10ec4cd8e0
Revert change to loading layer's default state
2021-02-18 22:38:17 +09:00
Salman Ahmed
a407bfe73b
Privatize UserRanks
and expose a similar CountryRank
field instead
2021-02-18 15:37:52 +03:00
Dean Herbert
990c1b1d6e
Revert accidental removal of newlines
2021-02-18 18:19:57 +09:00
Dean Herbert
0bd1964d8e
Add login placeholder logic to OnlineOverlay
...
A perfect implementation of this would probably leave the filter/header
content visible, but that requires some re-thinking and restructuring to
how the content is displayed in these overlays (ie. the header
component shouldn't be inside the `ScrollContainer` as it is fixed).
Supersedes and closes #10774 .
Closes #933 .
Addresses most pieces of #7417 .
2021-02-18 18:07:24 +09:00
Dean Herbert
c3f66a0c74
Add login placeholder for chat overlay
2021-02-18 17:46:07 +09:00
Salman Ahmed
a845e96b7a
Replace Ranks.Global
completely with a GlobalRank
property
2021-02-17 08:52:04 +03:00
Joehu
e838a5d9f0
Fix comment edited at date not showing tooltip
2021-02-15 19:04:23 -08:00
Dean Herbert
2e646882fa
Merge branch 'master' into non-concurrent-sample-playback
2021-02-15 21:22:21 +09:00
Dean Herbert
de52b8a5ba
Fix test failures in PerformFromScreen tests
2021-02-15 17:14:41 +09:00
smoogipoo
c6ed3efa4a
Merge branch 'master' into non-concurrent-sample-playback
2021-02-15 14:47:32 +09:00
Joehu
982d8e35ed
Fix mod settings showing scrollbar when screen is offset
2021-02-12 10:42:48 -08:00
smoogipoo
d3f0c0730d
Merge branch 'master' into non-concurrent-sample-playback
2021-02-12 17:22:15 +09:00
Dan Balasescu
ca091431f4
Merge pull request #11739 from peppy/settings-item-tooltips
...
Display descriptions in tooltips of mod settings adjustments
2021-02-12 00:18:16 +09:00
Dean Herbert
9fb41dc0b6
Move property to a better place in the class
2021-02-11 16:41:21 +09:00
Dean Herbert
dddd776802
Add the ability for settings items to have tooltips
2021-02-11 16:38:17 +09:00
Dean Herbert
98c5b0220c
Merge pull request #11725 from smoogipoo/freemods-user-settings
...
Add local user customisation for freemod mod settings
2021-02-11 16:02:24 +09:00
Dean Herbert
cbdc189ab2
Merge branch 'new-overlay-sounds' into update-resources
2021-02-11 14:20:23 +09:00
Dean Herbert
e53242c159
Merge branch 'new-toolbar-sounds' into update-resources
2021-02-11 14:20:21 +09:00
Dean Herbert
4ffb7fb753
Merge branch 'osd-toggle-sounds' into update-resources
2021-02-11 14:20:18 +09:00
Dean Herbert
896f318b56
Rename variable for clarity
2021-02-11 14:18:40 +09:00
Dean Herbert
72562070bc
Remove second overload of Close (makes the call structure hard to follow / invoke correctly)
2021-02-11 14:18:00 +09:00
Jamie Taylor
2ee634d173
Create subclass for "Error" notifications to allow them to have a unique pop-in sound
2021-02-11 13:55:43 +09:00
Jamie Taylor
a1ae739a62
Add support for Notification sounds
2021-02-11 13:51:54 +09:00
Jamie Taylor
c12c09ec4d
Move logic to LoadComplete instead
2021-02-11 09:57:14 +09:00
Jamie Taylor
63e6ec1c9f
Add audio feedback for OSD value changes
2021-02-11 09:23:04 +09:00
smoogipoo
822c66033f
Add local-user freemod configuration
2021-02-10 19:56:59 +09:00
Jamie Taylor
4e2ab0bad2
Use a separate sample set for Toolbar buttons
2021-02-10 17:48:36 +09:00
Dean Herbert
9e400acd1a
Merge branch 'master' into fix-mod-settings-fuckery
2021-02-10 17:43:03 +09:00
Jamie Taylor
3eda78c363
Use unique samples for Dialog, NowPlaying, SettingsPanel and WaveOverlay pop-in/pop-out
2021-02-10 16:04:47 +09:00
Dean Herbert
b3b0d97354
Avoid potential feedback from bindable event binds
2021-02-10 15:33:04 +09:00
Dean Herbert
67c1c4c1eb
Copy settings before applying selection
2021-02-10 15:30:17 +09:00
Dean Herbert
435c85a2e7
Avoid executing selection twice on ModSelectOverlay load
2021-02-10 15:13:09 +09:00
Dean Herbert
a39263423c
Fix externally changed settings from being reset when ModSelectOverlay is initialised
2021-02-10 15:12:29 +09:00
Dean Herbert
75bc9f607e
Rename wrongly named method
2021-02-10 14:55:15 +09:00
Dean Herbert
e44667e5e0
Use MinValue instead
...
Co-authored-by: Salman Ahmed <slmanarendo1950@gmail.com>
2021-02-10 11:31:34 +09:00
Andrei Zavatski
d9dcf8a042
Fix incorrect header depth in OnlineOverlay
2021-02-09 20:30:31 +03:00
Dan Balasescu
92599aa02b
Merge branch 'master' into user-beatmap-downloading-states-2
2021-02-09 21:06:09 +09:00
Dan Balasescu
15b3747945
Merge pull request #11716 from peppy/defer-playlist-load
...
Defer playlist load to improve load time of the now playing overlay
2021-02-09 20:59:51 +09:00
Dean Herbert
d8d830db6e
Defer playlist load to improve load time of the now playing overlay
2021-02-09 19:46:57 +09:00
Dean Herbert
1670766633
Avoid unbinding external events
2021-02-09 18:42:15 +09:00
Dean Herbert
178d88bcf1
Change BackgroundColour into a property
2021-02-09 18:32:44 +09:00
Dean Herbert
b5fa950800
Remove unnecessary depth specification
2021-02-09 18:30:05 +09:00
Dean Herbert
3206c7cbae
Merge branch 'master' into overlay-header-refactor
2021-02-09 18:20:07 +09:00
Dean Herbert
8204d360a8
Always reset local user settings when a mod is deselected in ModSelectOverlay
2021-02-09 13:44:42 +09:00
Dean Herbert
f338fa114b
Merge branch 'master' into user-beatmap-downloading-states-2
2021-02-05 18:02:40 +09:00
Dean Herbert
3e750feaa4
Subclass LocalPlayerModSelectOverlay to correctly deselect incompatible mods on free mod selection
2021-02-05 16:42:35 +09:00
Dean Herbert
9e9e382bee
Merge branch 'master' into user-beatmap-downloading-states-2
2021-02-05 15:27:17 +09:00
Dean Herbert
0750c3cb6a
Add back immediate deselection flow to ensure user selections can occur without contention
2021-02-04 23:44:46 +09:00
Dean Herbert
8f2f1a444f
Avoid resetting selection on deselecting incompatibile types
2021-02-04 19:55:09 +09:00
Dean Herbert
bf239f8bef
Flush animation on closing mod overlay
2021-02-04 19:12:37 +09:00
Dean Herbert
a2674f3c3f
Add comments
2021-02-04 18:58:56 +09:00
Dean Herbert
223b858227
Ramp the animation speed
2021-02-04 18:56:40 +09:00
Dean Herbert
f23ca7c7cf
Centralise selection animation logic
2021-02-04 18:10:55 +09:00
Dean Herbert
4bfe3aabdc
Simplify sound debounce logic
2021-02-04 17:06:11 +09:00
smoogipoo
f25535548a
Fix buzzing on select all/deselect all
2021-02-02 21:20:16 +09:00
smoogipoo
643c0605d8
Implement the freemod selection overlay
2021-02-02 21:14:38 +09:00
smoogipoo
8b3a85daa7
Merge branch 'refactor-mod-sections' into freemod-select-overlay
2021-02-02 21:09:51 +09:00
smoogipoo
728f8599b2
Move incompatible mod deselection to SoloModOverlay
2021-02-02 21:06:32 +09:00
smoogipoo
e58ece9e10
Make ModSelectOverlay abstract
2021-02-02 21:06:04 +09:00
smoogipoo
50e92bd0ed
Fix selection not being preserved when IsValidMod changes
2021-02-02 20:50:54 +09:00
smoogipoo
10ceddf3ff
Make IsValidMod adjustable
2021-02-02 20:47:50 +09:00
smoogipoo
75f81bfa06
Add back mod validation
2021-02-02 20:35:41 +09:00
smoogipoo
6d620264f4
Allow mod buttons to not be stacked
2021-02-02 20:27:41 +09:00
smoogipoo
3741f05ab3
Refactor mod sections and make them overridable
2021-02-02 20:11:40 +09:00
Dean Herbert
a76314a876
Use Update instead of UpdateAfterChildren (no need for the latter)
2021-02-02 15:57:17 +09:00
Dean Herbert
bb0753f68d
Use a better method of cancelling user scroll
2021-02-02 15:44:03 +09:00
Dean Herbert
398ab9c2c2
Use UserTrackingScrollContainer instead
2021-02-02 15:29:38 +09:00
Salman Ahmed
5c28c030c8
Unconditionally set "autoscroll" state
2021-02-01 22:08:57 +03:00
Salman Ahmed
15fcabb128
Add documentation to auto-scroll leniency
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-02-01 22:04:44 +03:00
Salman Ahmed
49e62c3a4b
Apply documentation changes
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2021-02-01 11:02:08 +03:00
Salman Ahmed
e806e5bcd1
Improve robustness of chat auto-scrolling logic
...
Fix auto-scrolling state changing by old messages removal logic
2021-01-31 23:45:49 +03:00
Dean Herbert
18e6afbec0
Ensure the item is present before trying to select it
2021-01-29 19:17:12 +09:00
Dean Herbert
1ce383fc20
Merge branch 'master' into fix-skin-dropdown-update-crash
2021-01-29 19:16:20 +09:00
Bartłomiej Dach
2c08ce05fa
Remove game-local enum [Order] attribute
...
In favour of the newly-added framework one.
2021-01-27 22:29:52 +01:00
Dean Herbert
67014018fc
Merge pull request #11589 from MiraiSubject/osu-mod-icon-fallbacks
...
Allow tournament client to use default mod icons if custom icons are not present
2021-01-26 19:57:21 +09:00
Dean Herbert
a5f3418e56
Avoid tooltip display
2021-01-26 19:11:19 +09:00
Dean Herbert
fedcbf79fa
Merge pull request #11572 from EVAST9919/comment-pill
...
Make VotePill background transparent for own comments
2021-01-26 18:57:00 +09:00
Salman Ahmed
93bb2611d6
Merge branch 'fix-beatmap-listing' into fix-beatmap-listing-2
2021-01-26 09:43:49 +03:00
Dean Herbert
ca0242debe
Tidy up logic to correctly expire in cases where expiry is expected
2021-01-26 15:42:48 +09:00
Salman Ahmed
0d8d0d6852
Apply alternative way of fixing
2021-01-26 01:03:29 +03:00
Salman Ahmed
c317d60169
Add offline test scene for beatmap listing overlay
2021-01-26 00:03:20 +03:00
Salman Ahmed
75d6dbdbb7
Fix beatmap listing placeholder potentially getting disposed
2021-01-26 00:03:20 +03:00
Salman Ahmed
9efce5717f
Fix beatmap listing placeholder disappearing on second time display
2021-01-26 00:03:20 +03:00
Dean Herbert
bb8113fb51
Fix mod select footer not animating correctly on first reveal
2021-01-25 14:47:47 +09:00
Salman Ahmed
acfb2d2980
Refactor beatmap set covers into using ModelBackedDrawable<T>
2021-01-24 00:32:33 +03:00
Andrei Zavatski
e9d10bb6e7
Revert "Minor refactoring"
...
This reverts commit 3d42cc1f91
.
2021-01-22 22:49:49 +03:00
Andrei Zavatski
3d42cc1f91
Minor refactoring
2021-01-22 22:27:26 +03:00
Bartłomiej Dach
360f26c13d
Merge branch 'master' into scroll-to-20
2021-01-22 19:58:36 +01:00
Andrei Zavatski
20161aea6a
Show LoginOverlay if not logged-in when clicking on a pill
2021-01-22 21:47:53 +03:00
Andrei Zavatski
6379381f95
Make VotePill background transparent for own comments
2021-01-22 20:46:20 +03:00
Dean Herbert
d69a4914e0
Add method to block all realm access during migration operation
2021-01-22 17:28:47 +09:00
Dean Herbert
fca6b15d2f
Fix local echo messages remaining permanently dimmed when chatting via multiplayer
2021-01-22 16:05:45 +09:00
Andrei Zavatski
2eba2a9abf
Rename FriendsButton to FollowersButton
2021-01-21 23:40:23 +03:00
Andrei Zavatski
c631354b57
Rename property
2021-01-21 23:39:19 +03:00
Andrei Zavatski
4555b9ff70
Make ProfileHeaderButton height defined
2021-01-21 22:56:12 +03:00
Andrei Zavatski
e87197c7fc
Adjust text size
2021-01-21 22:48:31 +03:00
Andrei Zavatski
343166f158
Make CreateIcon a property
2021-01-21 22:47:44 +03:00
Andrei Zavatski
a7c22ebe88
Implement MappingSubscribersButton component
2021-01-21 22:02:54 +03:00
Andrei Zavatski
2aa1df9ea4
Implement ProfileHeaderStatisticsButton component
2021-01-21 21:38:52 +03:00
Andrei Zavatski
05d3914fee
Rename friends tooltip to followers
2021-01-21 21:26:33 +03:00
Dean Herbert
259f6504fb
Merge branch 'master' into realm-key-binding-store
2021-01-21 15:45:59 +09:00
Dean Herbert
a6516e3be5
Merge branch 'master' into scroll-to-20
2021-01-21 14:28:17 +09:00
Andrei Zavatski
65ece1aa72
Mark OverlayHeader as NotNull in FullscreenOverlay
2021-01-21 07:50:41 +03:00
Dean Herbert
7c4a072568
Merge branch 'master' into scroll-to-20
2021-01-21 13:48:26 +09:00
Andrei Zavatski
da0066e7b0
Merge master with conflicts resolved
2021-01-21 07:30:47 +03:00
Dan Balasescu
c3675293fa
Merge branch 'master' into beatmapset-refactor
2021-01-21 12:38:34 +09:00
Dan Balasescu
95f52ae054
Merge pull request #11536 from rednir/sort-skins-alphabetically
...
Sort SkinSection in alphabetical order
2021-01-20 21:49:31 +09:00
Dan Balasescu
455383c3c0
Merge pull request #11528 from peppy/fix-autoplay-in-multiplayer
...
Fix multiplayer mod select showing autoplay as a choice
2021-01-20 21:49:16 +09:00
Dan Balasescu
12f2067357
Merge branch 'master' into sort-skins-alphabetically
2021-01-20 21:15:16 +09:00
Andrei Zavatski
2ca3ccad06
Move all the content to BeatmapSetHeaderContent drawable
2021-01-20 04:56:46 +03:00
Andrei Zavatski
94fee3800d
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmapset-refactor
2021-01-20 04:32:56 +03:00
Bartłomiej Dach
3b49b7461e
Schedule entire operation for safety
...
Also removes a redundant list copy.
2021-01-19 19:35:53 +01:00
Bartłomiej Dach
78e590d25d
Refactor skin sorting method
...
* Rename to `sortUserSkins` to convey meaning better.
* Sort in-place instead of slicing the list.
* Change to `void` to avoid misleading users that the method returns
a new list instance.
* Fix typo in comment.
2021-01-19 18:36:42 +01:00
Bartłomiej Dach
b00c6a1d60
Make first non-default skin index a property
...
The previous code was very brittle - it was not always updating
properly, and seems to have worked either by a carefully crafted set of
circumstances, or just plain coincidence.
Having this be a get-only property avoids potential error in the future
caused by not updating the index properly, at the expense of an added
linear lookup.
2021-01-19 18:31:37 +01:00
rednir
206a0b8bac
Fix firstNonDefault staying as -1
2021-01-19 16:55:50 +00:00
rednir
a880b8d21d
Satisfy AppVeyor
2021-01-19 16:11:16 +00:00
rednir
b265d2dab4
Remove another whitespace
2021-01-19 14:16:22 +00:00
rednir
1d4c813ff6
Merge branch 'sort-skins-alphabetically' of https://github.com/rednir/osu into sort-skins-alphabetically
2021-01-19 14:03:31 +00:00
rednir
31e61326e1
Only user skins are sorted
2021-01-19 14:00:17 +00:00
rednir
f1894a8bac
fixed itemUpdated()
2021-01-19 12:17:56 +00:00
Dean Herbert
f1a785f407
Merge branch 'master' into realm-key-binding-store
2021-01-19 18:22:34 +09:00
smoogipoo
de9d075f94
Initial sample + samplechannel rework
2021-01-19 17:11:40 +09:00
Andrei Zavatski
f0add0a7cf
Make BeatmapSetOverlay use OverlayHeader
2021-01-19 01:34:37 +03:00
rednir
0b65c0cd25
Remove whitespace
2021-01-18 20:17:42 +00:00
rednir
da89426a3b
Merge branch 'master' of https://github.com/ppy/osu into sort-skins-alphabetically
2021-01-18 20:09:15 +00:00
rednir
7476cb3047
Sort SkinSection in alphabetical order
2021-01-18 19:51:42 +00:00
Andrei Zavatski
c6b0f3c247
Implement TabbableOnlineOverlay component
2021-01-18 21:22:50 +03:00
Dean Herbert
0560eb4120
Reduce final fill alpha of main menu confirm-to-exit
2021-01-18 18:22:21 +09:00
Dean Herbert
0b165dce4b
Fix multiplayer mod select showing autoplay as a choice
2021-01-18 17:50:32 +09:00
Andrei Zavatski
6e34ab5d15
Rename WebOverlay to OnlineOverlay
2021-01-18 11:13:38 +03:00
Andrei Zavatski
b27b18f70f
Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-header-refactor
2021-01-18 11:10:55 +03:00
Salman Ahmed
bd44bf8c0b
Extract disabling progress bar user-interactivity
2021-01-18 10:51:39 +03:00
Andrei Zavatski
27ffc98445
Implement WebOverlay component
2021-01-18 10:48:12 +03:00
Dean Herbert
1364de1166
Merge branch 'master' into beatmap-colour-setting
2021-01-18 16:07:46 +09:00
Salman Ahmed
d93a853dfd
Enforce float
type in the download progress path instead
2021-01-17 21:16:48 +03:00
Dean Herbert
5278cad393
Reword setting to make more sense
2021-01-17 22:42:48 +09:00
Dean Herbert
5fd644fc57
Unify variable names
2021-01-17 22:42:48 +09:00
Dean Herbert
addd463d26
Merge branch 'master' into explicit-search-control
2021-01-17 21:44:25 +09:00
Dean Herbert
edb6d3907b
Merge pull request #11472 from frenzibyte/explicit-beatmap-markers
...
Add explicit content markers to beatmap panels and overlay
2021-01-17 21:44:10 +09:00
Bartłomiej Dach
816cc7a59b
Adjust explicit label spacing on beatmap set overlay
2021-01-17 00:35:23 +01:00
Salman Ahmed
adb2605d5d
Enforce double
type in the download progress path
...
Wasn't sure where to exactly put this, or whether to split it, but it's very small change to worry about, so I guess it's fine being here
2021-01-17 00:12:14 +03:00
Dean Herbert
b5e784ed42
Fix possibility of crash when selecting a random skin during skin import
2021-01-15 16:34:28 +09:00
Salman Ahmed
dc8e38cf4d
Remove pointless inline comment
2021-01-15 07:20:13 +03:00
Dean Herbert
2988700bea
Merge branch 'master' into realm-key-binding-store
2021-01-14 16:37:09 +09:00
Dean Herbert
fd582f521c
Reduce lifetime of realm context usage in detach scenario
2021-01-14 16:33:55 +09:00
Dean Herbert
8d071f97fb
Early return
2021-01-14 16:33:03 +09:00
Dean Herbert
e3c5a909e4
Fix known non-null variable
2021-01-14 16:30:57 +09:00
Dean Herbert
8a08d3f4ef
Fix transactions not actually being committed
2021-01-14 16:13:10 +09:00
Salman Ahmed
6281c1086a
Space out explicit marker in beatmap overlay
2021-01-14 05:41:09 +03:00
Salman Ahmed
abf718242b
Make explicit marker font semi-bold
2021-01-14 05:40:43 +03:00
Salman Ahmed
1f12b2bd09
Rename download state Downloaded
to Importing
2021-01-13 18:04:53 +03:00
Salman Ahmed
43daa7c7c0
Use Colour2
of orange theme for explicit pill
2021-01-13 17:07:42 +03:00
Salman Ahmed
e275dd02e0
Create static colour properties for now
2021-01-13 17:07:11 +03:00
Salman Ahmed
9d59d784f8
Add Colour{1-4} properties to OverlayColourProvider
2021-01-13 17:06:44 +03:00
Salman Ahmed
a5f99ed8e6
Merge branch 'explicit-beatmap-markers' into explicit-search-control
2021-01-13 12:53:57 +03:00
Dean Herbert
fcb4a53f37
Rename realm persisted properties to avoid casting necessity
2021-01-13 18:36:37 +09:00
Dean Herbert
9086d75542
Update write usages
2021-01-13 18:36:37 +09:00
Dean Herbert
9d744d629f
Update existing usages to use the main realm context where applicable
2021-01-13 18:36:37 +09:00
Dean Herbert
192e58e0c6
Update all read queries to use direct realm subscriptions/queries
2021-01-13 18:36:37 +09:00
Salman Ahmed
78631323ba
Add explicit pill to beatmap overlay
2021-01-13 12:13:14 +03:00
Salman Ahmed
f6637eec36
Add explicit pill to beatmap panels
2021-01-13 12:13:14 +03:00
Salman Ahmed
ee6baeb57e
Add "explicit" marker pill
2021-01-13 12:13:14 +03:00
Mysfit
5f10bcce02
Added beatmap colour settings checkbox and associated tests.
2021-01-13 00:09:22 -05:00
Salman Ahmed
24c1839739
Add global web setting for allowing explicit content
2021-01-12 11:10:25 +03:00
Salman Ahmed
249be461d5
Add "explicit maps" search filter control
2021-01-12 11:09:55 +03:00
Dean Herbert
8f9b19a76e
Detach at point of usage, rather than point of retrieval
2021-01-12 14:45:36 +09:00
Dean Herbert
536e7229d0
Remove unused EF class and unnecessary interface
2021-01-12 14:45:36 +09:00
Dean Herbert
8765aaf9e6
Use IKeyBinding for all key binding usages (and add update flow via primary key)
2021-01-11 16:31:35 +09:00
Dean Herbert
43f417b53a
Add and consume IKeyBindingStore interface
2021-01-11 15:52:49 +09:00
Dean Herbert
d2ca6da0fd
Remove unused constant
2021-01-11 01:56:09 +09:00
Dean Herbert
bd37723788
Expose as IBindable for added safety
2021-01-11 01:55:54 +09:00
Dean Herbert
e4eb44df6e
Merge branch 'master' into fix-play-button-crashes
2021-01-11 01:46:41 +09:00
Salman Ahmed
375ecf92ed
Merge remote-tracking branch 'upstream/master' into fix-mod-buttons-not-copying-settings
2021-01-09 00:26:18 +03:00
Bartłomiej Dach
274a045d8d
Remove Dispose() override
...
Culls another non-thread-safe mutation of the `Playing` bindable.
It seems to be a weird vestige from an earlier revision of the old
"direct" panel, which relied on `DisposeOnDeathRemoval` to finish track
playback (and then was removed in
6c150c9ed7
). The play button is no longer
responsible for managing preview track lifetime anyway;
`PreviewTrackManager`'s method are intended for that.
2021-01-08 20:08:19 +01:00
Bartłomiej Dach
52789118a3
Schedule play button state update
...
Revealed by the framework-side transform thread safety checks. `Stopped`
is even annotated as not being thread-safe (but was annotated as such
long after the class's nascence).
2021-01-08 20:08:19 +01:00
Bartłomiej Dach
0cf5be3ef4
Fix selection change event being invoked with wrong mod
2021-01-08 17:02:57 +01:00
Dean Herbert
c208800150
Fix auto selection scenario regressing due to scheduling too much
2021-01-08 14:17:14 +09:00
Dean Herbert
4973e23003
Merge branch 'master' into fix-transform-mutation-mod-selection
2021-01-08 11:16:15 +09:00
Bartłomiej Dach
a761ec952a
Merge branch 'master' into remove-osu-direct
2021-01-06 17:32:12 +01:00
Dean Herbert
866fb28d6c
Merge pull request #11411 from LavaDesu/feature/discord-presence-toggle
...
Add ability to toggle discord rich presence
2021-01-07 00:52:38 +09:00
Dean Herbert
283c69a68f
Update enum name in line with changes
2021-01-06 23:12:56 +09:00
Bartłomiej Dach
6572bb18de
Merge branch 'master' into fix-transform-mutation-display-settings
2021-01-06 10:09:14 +01:00
Dean Herbert
15dd7a87a6
Move gameplay preview event binding to LoadComplete
2021-01-06 15:19:12 +09:00
Bartłomiej Dach
52687fc37c
Merge branch 'master' into fix-transform-mutation-loading-layer
2021-01-05 23:10:51 +01:00
Bartłomiej Dach
2b253f6d01
Remove now-unused fields & locals
2021-01-05 22:56:53 +01:00
Dean Herbert
d0d2e41b28
Fix display settings binding to configuration bindables in async load
2021-01-05 18:19:28 +09:00
Dean Herbert
54982dcdd7
Refactor LoadingLayer to avoid applying effects to external drawables
...
In theory this seemed like a good idea (and an optimisation in some
cases, due to lower fill rate), but in practice this leads to weird edge
cases.
This aims to do away with the operations on external drawables by
applying a dim to the area behind the `LoadingLayer` when required.
I went over each usage and ensured they look as good or better than
previously.
The specific bad usage here was the restoration of the colour on dispose
(if the `LoadingLayer` was disposed in a still-visible state).
I'm aware that the `BeatmapListingOverlay` will now dim completely during
load. I think this is fine for the time being.
2021-01-05 17:31:45 +09:00
Dean Herbert
5d8c153c1e
Move schedule logic to buttons rather than section
...
It turns out there's some quite convoluted scheduling / order of
execution requirements of ModSelectOverlay and ModSection. Applying
scheduling causes a runaway condition ending in zero frames after many
mod button changes.
I wanted to avoid rewriting the whole component, so have just moved the
schedule to guard against the part where drawables are actually changed.
2021-01-05 16:41:05 +09:00
Dean Herbert
4d6c13f169
Privatise ModSelectOverlay methods that may be unsafe to be called externally
2021-01-05 16:18:13 +09:00
Dean Herbert
57a8cd7461
Schedule deselection operations for safety
2021-01-05 16:17:58 +09:00
Dean Herbert
962c95dc01
Fix ModSelection making unsafe advances of ModSection
2021-01-05 15:19:37 +09:00
KyeKiller
77e660e426
Should pass all checks again now.
2021-01-04 22:11:52 +00:00
KyeKiller
1234d0fa04
Applied all tooltips to the right
2021-01-04 22:01:12 +00:00
KyeKiller
0e42d415c1
Hit another oopie
2021-01-04 21:05:28 +00:00
KyeKiller
3468df840b
Moved tooltip to the left to stop the overflow
2021-01-04 21:04:30 +00:00
KyeKiller
73f5e5aaf9
Moved "ToolbarSocialButton" back
2021-01-04 21:03:51 +00:00
KyeKiller
2e2b3ab5d4
Should remove codeFactor error
2021-01-04 17:26:42 +00:00
KyeKiller
2d1b52be0d
Moved "ToolbarSocialButton"
...
This will remove it from coming off the screen.
2021-01-04 17:21:31 +00:00
LavaDesu
2e5c67be3f
Add ability to toggle discord rich presence
...
There are 3 modes: enabled, limited, and disabled.
The limited mode hides identifiable information such as username, rank, and
(if participating in one) multiplayer lobby name.
2021-01-03 10:37:28 +07:00
Salman Ahmed
988f9b98a1
Split button mods updating to private method
2021-01-01 16:16:00 +03:00
Salman Ahmed
a031c8e0b6
Apply documentation suggestions
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-01-01 15:34:09 +03:00
Salman Ahmed
2ce9599957
Copy selected mods properties into overlay's buttons
2021-01-01 03:47:13 +03:00
Bartłomiej Dach
d2301068b6
Fix changelog header staying dimmed after build show
2020-12-28 16:35:33 +01:00
Dean Herbert
69fab7de77
Merge pull request #11307 from bdach/fix-account-creation-overlay-after-logout
...
Fix account creation overlay not showing up the first time after a log-out
2020-12-28 11:52:48 +09:00
Dean Herbert
1b7c72f03b
Merge branch 'master' into changelog-refactor
2020-12-28 11:00:14 +09:00
Bartłomiej Dach
0b42b4b955
Rename {Drawable -> Clickable}Avatar
2020-12-26 14:35:11 +01:00
Bartłomiej Dach
0aedc720f2
Extract changelog entry component
2020-12-25 21:06:03 +01:00
Bartłomiej Dach
3ac618778f
Handle all changelog entry types correctly
2020-12-25 21:06:03 +01:00
Bartłomiej Dach
5f43299d37
Fix tests failing due to base logic firing
...
It turns out that the changelog code was semi-intentionally relying on
the request to get release streams to be slow to initially show the
listing of all streams.
Locally suppress the base tab control logic to fix this.
2020-12-25 21:06:03 +01:00
Bartłomiej Dach
83fb7c7a1a
Re-namespace all files in OnlinePlay directory
2020-12-25 16:50:09 +01:00
Bartłomiej Dach
0d8fb83d0a
Ensure account creation overlay is shown after logout
...
Scheduling the entire API state change callback caused the scheduled
hide to fire the first time the user attempted to display the account
creation overlay after a logout, because the drawable wasn't present
before that (so its scheduler wasn't running).
It is not theoretically safe to run `Hide()` unscheduled at its present
call site (as the value change callbacks are fired on the background
API thread). This could also be fixed by setting `AlwaysPresent = true`,
but that's a pretty ugly and unperformant change to make in general.
2020-12-25 15:40:39 +01:00
Bartłomiej Dach
4270c29f60
Trim stray newline
2020-12-24 13:42:08 +01:00
Dean Herbert
66a23c22e5
Fix various tests failing due to dependence on specific online data
2020-12-24 21:28:24 +09:00
Dean Herbert
323da82477
Add website root URL and update most links to use it
...
For what it's worth, I intentionally didn't include news / changelog /
supporter, because these should never change.
2020-12-24 18:11:42 +09:00
Endrik Tombak
78c14fd696
Refactor code into UserTrackingScrollContainer
2020-12-22 17:36:44 +02:00
Dean Herbert
4f02928601
Change sorting to better handle portrait screens
2020-12-22 17:36:56 +09:00
Dean Herbert
3d5783a0ea
Improve variable names
2020-12-22 17:34:51 +09:00
Dean Herbert
a1d67f0cf6
Merge branch 'master' into fix-resolution-dropdown
2020-12-22 17:26:53 +09:00
Salman Ahmed
dab5924a63
Fix resolution dropdown not respecting current display changes
2020-12-22 08:02:42 +03:00
Dean Herbert
7c5964fad8
Revert window modes to previous code to correctly apply framework restrictions
2020-12-22 13:04:39 +09:00
Dean Herbert
ce2b96afc5
Merge branch 'master' into fix-selected-highlight-on-some-dropdowns
2020-12-22 13:00:06 +09:00
Dean Herbert
d096f2f8f6
Fix potential cross-thread operation during chat channel load
...
The callbacks are scheduled to the API thread, but hooked up in BDL
load. This causes a potential case of cross-thread collection
enumeration.
I've tested and it seems like the schedule logic should be fine for
short term. Longer term, we probably want to re-think how this works so
background operations aren't performed on the `DrawableChannel` in the
first place (chat shouldn't have an overhead like this when not
visible).
Closes #11231 .
2020-12-21 16:39:50 +09:00
Joehu
5b8e35c98c
Make settings dropdown abstract
2020-12-19 19:04:14 -08:00
Joehu
b87f89986a
Fix selected item not being highlighted on some setting dropdowns
2020-12-19 19:04:13 -08:00
Dean Herbert
206bf3713e
Make IAPIProvider read-only bindables into IBindables
2020-12-18 15:16:36 +09:00
Salman Ahmed
9c22753f3f
Remove unnecessary inheritance to OverlayView
2020-12-18 02:51:19 +03:00
Salman Ahmed
5e4f667cff
Revert "Allow OverlayView fetching with no API requests required"
...
This reverts commit 449b9a21ae
.
2020-12-18 01:27:58 +03:00
Salman Ahmed
904a4daa98
Add todo comment reminding of updating friends list along
2020-12-17 13:33:49 +03:00
Salman Ahmed
94175d0532
Use global friends list instead of always fetching
2020-12-17 13:33:17 +03:00
Salman Ahmed
449b9a21ae
Allow OverlayView fetching with no API requests required
2020-12-17 13:31:57 +03:00
Angela Zhang
456c0751fd
Merge pull request #8 from angelaz1/jcramos/ctrl_shift_t
...
Ctrl+Shift+t Chat Shortcut
2020-12-15 16:54:11 -06:00
Dean Herbert
3faf7db068
Merge pull request #10882 from PercyDan54/import-screen
...
Add File Import screen
2020-12-15 15:03:15 +09:00
Gagah Pangeran
f0e6b6eaf8
sort by ruleset id first then star diff
2020-12-15 11:09:09 +07:00
Dean Herbert
26fa010fed
Merge branch 'master' into import-screen
2020-12-15 12:37:27 +09:00
Joseph-Ramos-CMU
08a2cdaf8d
Minor formatting changes
2020-12-13 21:02:35 -05:00
Joseph-Ramos-CMU
2d98da0d61
Untested Ctrl+Shift+T shortcut prototype
...
Added a list to the ChannelManager class that tracks
which tabs I closed. Works like a stack, where it adds to the end
every time I close a tab. Then added a function that uses
this list to open the last closed channel, and added a shortcut inside of ChatOverlay,
similar to how jmeng implemented shortcuts.
Code is currently untested.
2020-12-13 13:21:50 -05:00
Angela Zhang
aaca703483
Merge pull request #3 from angelaz1/jmeng1/keyboard_shortcuts
...
Added ctrl + w and ctrl + t keyboard shortcuts
2020-12-12 21:22:12 -06:00
Angela Zhang
084e4ce50b
Removing whitespace
2020-12-12 20:11:57 -06:00
Angela Zhang
b9f687d7f9
Adding in extra blank line
2020-12-12 18:55:17 -06:00
Angela Zhang
4c1e75f101
Small whitespace fix
2020-12-12 18:02:08 -06:00
Jess Meng
3dd6589d6e
Fixed style changes and cleaned up ctrl + t implementation
2020-12-12 15:53:08 -08:00
Jess Meng
92cab12eb7
Added ctrl + w and ctrl + t keyboard shortcuts
2020-12-11 21:52:36 -08:00
smoogipoo
10c1823534
Remove now unused files
2020-12-07 22:07:11 +09:00
Dean Herbert
a5e2509d52
Merge pull request #11105 from Joehuu/mod-settings-fade-in/out
...
Add fade in/out animations to mod settings container
2020-12-07 17:12:29 +09:00
Dean Herbert
454e94574c
Add corner rounding and positional transform
2020-12-07 16:43:07 +09:00
Dean Herbert
7253866e17
Move customisation panel to be in same area as main content
2020-12-07 16:42:55 +09:00
ekrctb
f4eb17d398
Update osu.Game/Overlays/Settings/Sections/Input/MouseSettings.cs
...
Set mouse confine mode at initialization
Co-authored-by: Dean Herbert <pe@ppy.sh>
2020-12-07 16:09:14 +09:00
ekrctb
2469608c10
Fix possible null reference due to bindable change before variable is initialized
2020-12-07 15:19:18 +09:00
Joehu
0f9b38da08
Add fade in/out animations to mod settings container
2020-12-06 11:35:14 -08:00
Bartłomiej Dach
71edada623
Hide confine setting entirely in fullscreen
2020-12-05 22:15:41 +01:00
PercyDan
60d8102a77
Merge branch 'master' into import-screen
2020-12-04 21:20:14 +08:00
Bartłomiej Dach
7fd385efe6
Remove unused using directive
2020-12-02 20:01:58 +01:00
Leon Gebler
a2a10d4e13
Don't use nameof(MouseHandler)
2020-12-02 19:45:59 +01:00
Leon Gebler
bbde1f6b9c
Fix MouseHandler not being ignored when raw input is enabled
2020-12-02 18:56:59 +01:00
Dean Herbert
285e62be9a
Bring code in line with SDL2 defaults
2020-12-01 17:47:07 +09:00
Dean Herbert
965cc1f511
Remove unnecessary usings #2
2020-11-30 17:57:25 +09:00
Dean Herbert
46cab04929
Merge branch 'settings-remove-transparency' into settings-reduce-visual-clutter
2020-11-30 17:57:10 +09:00
Dan Balasescu
a3ef858f3a
Remove unnecessary multiplication
2020-11-30 17:56:04 +09:00
Dean Herbert
fe48b2279c
Adjust various paddings and spacings in settings to make them easier to visually parse
2020-11-30 17:50:35 +09:00
Dean Herbert
a3dd22f5c2
Merge branch 'master' into settings-remove-transparency
2020-11-30 17:50:26 +09:00
Dean Herbert
bf2c6dc241
Remove unused usings rider couldn't see
2020-11-30 17:49:55 +09:00
Dean Herbert
a4e061cb11
Remove semi-transparent backgrounds from settings and notifications overlays
...
I tried also updating the colours to the "new" versions from designs but
they don't match due to colour profile differences (so I'm not yet sure
if they are correct or not) and also don't look great without all the UI
elements also being updated.
2020-11-30 17:19:55 +09:00
Dean Herbert
4e1e45f3e7
Move hold-to-confirm back to UI section
2020-11-30 16:15:35 +09:00
Dean Herbert
55c8aa5d5f
Move menu cursor size to UI section
2020-11-30 16:14:15 +09:00
Dean Herbert
e14db45374
Reorder settings to (probably) feel more correct
2020-11-30 16:09:38 +09:00
Bartłomiej Dach
e0a84ff1dc
Move hold-to-confirm setting back to gameplay section
2020-11-29 22:07:34 +01:00
Bartłomiej Dach
a5c4a8d2e9
Create "User Interface" settings section
2020-11-29 22:07:33 +01:00
PercyDan
579e61eab9
Allow null
2020-11-28 16:31:24 +08:00
Dean Herbert
d5a4d46c6d
Merge pull request #10842 from EVAST9919/profile-overlay-graph-new
...
Implement history charts for Profile Overlay
2020-11-24 18:05:17 +09:00
Dan Balasescu
57ff150051
Merge pull request #10829 from Joehuu/music-osd-bindings
...
Add music bindings to on screen display
2020-11-24 14:36:34 +09:00
Joehu
1fd4b04767
Just set music shortcut text locally
2020-11-23 20:43:46 -08:00
Dean Herbert
e36b1051c1
Add spacing between inline comments
2020-11-24 13:15:59 +09:00
Dean Herbert
82640418ba
Invert hide logic for readability
2020-11-24 13:12:04 +09:00
Dean Herbert
44ca67c534
Simplify fill logic and add xmldoc
2020-11-24 13:10:11 +09:00
Joehu
52f5473cc0
Set global action as a parameter in toast
2020-11-23 15:13:58 -08:00
Bartłomiej Dach
5701b32bae
Handle constant graphs better
2020-11-23 22:12:32 +01:00
Bartłomiej Dach
8347ecf494
Simplify row tick creation code
2020-11-23 21:52:47 +01:00
Bartłomiej Dach
7b0d3dfe0c
Refactor tick calculation code for readability
2020-11-23 21:38:04 +01:00
Bartłomiej Dach
bb5aa9a9c9
Guard against empty values early
2020-11-23 21:24:37 +01:00
Bartłomiej Dach
e9ffeb8b5d
Make missing date check more robust
2020-11-23 21:09:42 +01:00
Andrei Zavatski
1b33d30039
Simplify horizontal ticks creation
2020-11-23 08:52:29 +03:00
Andrei Zavatski
b745fb681a
Fix incorrect static using placement
2020-11-22 04:40:55 +03:00
Andrei Zavatski
4887132947
Adjustments for edge cases support
2020-11-22 04:28:17 +03:00
Andrei Zavatski
f07f8089d6
Adjust monthsPerTick value
2020-11-22 03:58:56 +03:00
Andrei Zavatski
e6c116f0ab
Rework horizontal ticks creation
2020-11-22 03:49:00 +03:00
Andrei Zavatski
6e581902cd
Simplify column ticks creation
2020-11-22 03:11:38 +03:00
Andrei Zavatski
453f0ba675
Make tick lines thicker
2020-11-22 02:34:29 +03:00
Andrei Zavatski
3cb1d04667
Move dates fill into it's own method
2020-11-22 02:25:12 +03:00
Andrei Zavatski
d4b56aac84
Add missing whitespace
2020-11-22 02:17:54 +03:00
Andrei Zavatski
9d7ddf8343
Merge master with conflicts resolved
2020-11-22 02:13:35 +03:00
Andrei Zavatski
fe4c622041
Make OnUserChanged private
2020-11-21 23:13:46 +03:00
Andrei Zavatski
dbfc839df3
Move missing text to PaginatedProfileSubsection
2020-11-21 23:03:54 +03:00
Andrei Zavatski
11c3ccfcaa
Move rulesets property to PaginatedProfileSubsection
2020-11-21 22:49:56 +03:00
Andrei Zavatski
718ba9253b
Implement ProfileSubsection component
2020-11-21 03:18:24 +03:00
Andrei Zavatski
c4cb1440ab
Rename PaginatedContainerHeader to ProfileSubsectionHeader
2020-11-21 02:59:01 +03:00
PercyDan54
9a3dd12f30
Move to debug settings
2020-11-18 18:15:56 +08:00
Andrei Zavatski
a52c98b55c
Fix broken test scene
2020-11-14 21:20:37 +03:00
Andrei Zavatski
fe9d17fc56
Fix CodeFactor issues
2020-11-14 20:31:03 +03:00
Andrei Zavatski
a94546f905
CI fixes
2020-11-14 20:17:32 +03:00
Andrei Zavatski
5354bf1fa5
Ticks distribution improvements
2020-11-14 20:07:52 +03:00
Andrei Zavatski
02168c6c2f
Implement dates with zero count fill
2020-11-14 19:17:01 +03:00
Andrei Zavatski
af174aa653
Implement chart subsections
2020-11-14 18:48:47 +03:00
Andrei Zavatski
ae4a2e74fa
Implement ProfileSubsection
2020-11-14 18:21:10 +03:00
Bartłomiej Dach
610ed99ae3
Add null checks to unguarded resolved-as-null fields
2020-11-14 14:52:58 +01:00
Andrei Zavatski
01f28a35c3
Implement vertical ticks creation
2020-11-14 07:28:01 +03:00
Andrei Zavatski
d98c59f2a4
Implement horizontal ticks creation
2020-11-14 06:38:02 +03:00
Andrei Zavatski
9d8e7e8954
ProfileLineChart layout implementation
2020-11-14 04:46:26 +03:00
Joehu
2071cba944
Add music bindings to on screen display
2020-11-13 13:16:36 -08:00
Dean Herbert
a2c81a3a52
Add back setting to toggle "always play first combo break"
2020-11-13 13:42:00 +09:00
Andrei Zavatski
f753f138c6
Add counter to most played beatmaps section in user overlay
2020-11-12 03:11:29 +03:00
smoogipoo
7df9484458
Merge branch 'master' into add-random-skin-hotkey
2020-11-11 15:48:12 +09:00
Dan Balasescu
09324c4598
Merge pull request #3652 from WebFreak001/shuffle-skin
...
Add "random skin" option to skin setting dropdown
2020-11-11 15:47:00 +09:00
Dan Balasescu
8ad84d6640
Merge branch 'master' into osd-custom-bindings-display
2020-11-11 15:12:31 +09:00
Dean Herbert
f78f2fb59e
Merge branch 'osd-custom-bindings-display' into add-random-skin-hotkey
2020-11-11 13:53:49 +09:00
Dean Herbert
324626e097
Move default config tracking calls out of OnScreenDisplay itself
2020-11-11 13:53:09 +09:00
Dean Herbert
8d38d9cc93
Add hotkey to select random skin
2020-11-11 13:05:03 +09:00
Dean Herbert
6674628bc7
Only include user skins in random choices
2020-11-11 12:03:38 +09:00
Dean Herbert
6b548ef5e4
Split out SkinInfo ID constants and fix random logic
2020-11-11 11:54:40 +09:00
Dean Herbert
6593aac3f2
Merge pull request #7762 from EVAST9919/history-graph
2020-11-11 11:35:34 +09:00
Dean Herbert
a5e13e4d2c
Merge branch 'master' into shuffle-skin
2020-11-11 11:34:48 +09:00
Dean Herbert
53c968e137
Fix user profile best performance weighting being out of order
2020-11-11 10:19:59 +09:00
Andrei Zavatski
6c428d8b11
Merge master with conflicts resolved
2020-11-11 01:37:01 +03:00
Bartłomiej Dach
dd873dbd85
Merge branch 'master' into fix-profile-graph-crash
2020-11-10 12:17:12 +01:00
Dean Herbert
833c0b223e
Clamp index to valid bounds
2020-11-10 18:08:12 +09:00
Dean Herbert
2e3dc6fc46
Merge branch 'master' into fix-profile-graph-crash
2020-11-10 18:06:51 +09:00
Dean Herbert
28daff1716
Stop mod select overlay hotkeys handling input when control is pressed
...
Closes https://github.com/ppy/osu/issues/10766 in about the best way we
can for now.
2020-11-10 17:57:59 +09:00
Dean Herbert
5221a34929
Only handle keys which create characters
2020-11-10 16:32:58 +09:00
Dean Herbert
a2ef3aa21a
Force beatmap listing overlay's textbox back on screen when a key is pressed
...
Not the cleanest solution, but works for now. Will eventually be
replaced after the header is updated to reflect the latest designs
(which keeps it on screen in all cases).
Closes https://github.com/ppy/osu/issues/10703 .
2020-11-10 16:26:30 +09:00
Andrei Zavatski
e464e719ef
Merge remote-tracking branch 'refs/remotes/ppy/master' into history-graph
2020-11-10 10:22:57 +03:00
Dean Herbert
4af390a168
Move hierarchy init to load and remove unnecessary field storage
2020-11-10 12:33:07 +09:00
Joehu
670d6d8719
Make button field readonly
2020-11-09 18:59:54 -08:00
Joehu
c671d97e6f
Disable watch button on the local user
2020-11-09 18:39:35 -08:00
Dean Herbert
37feedae7a
Fix potential crash due to stale index
2020-11-10 07:27:38 +09:00
Dean Herbert
1548c0dc25
Ensure graph hover state is updated after data changes
2020-11-10 07:27:27 +09:00
Dean Herbert
690e69bcc6
Reforamt for legibility
2020-11-09 12:22:54 +09:00
Dean Herbert
90ce1bd5f0
Add missing async suffix
2020-11-09 10:40:16 +09:00
Dean Herbert
f94ac1cbc7
Merge branch 'master' into efficient-user-retrieval
2020-11-07 00:07:29 +09:00
Dean Herbert
c3c288145a
Ignore null results for now
2020-11-06 17:55:29 +09:00
Dean Herbert
1ca8b03aa5
Never disable pause button on now playing overlay
2020-11-06 17:26:23 +09:00
Dean Herbert
c97c6bbf52
Add and consume user cache class
2020-11-06 17:00:29 +09:00
Dean Herbert
2457083d8b
Add padding to currently playing view
2020-11-06 17:00:29 +09:00
Dean Herbert
db039da668
Add and consume multi-lookup API endpoint
2020-11-06 17:00:29 +09:00
Dean Herbert
07166ec819
Fix a couple of remaining unnecessary casts
2020-11-06 13:29:47 +09:00
Dean Herbert
1e1569eb53
Use int instead of long for user_id fields for now
2020-11-06 12:59:46 +09:00
Dean Herbert
487a5ecdba
Replace all usage of IBindableList.GetBoundCopy
2020-11-04 15:29:14 +09:00
Bartłomiej Dach
211510fe9a
Fix undesirable vertical spacing in currently playing display
2020-11-03 19:12:03 +01:00
Bartłomiej Dach
86d283ebf4
Adjust layout slightly to avoid specifying width twice
2020-11-03 19:03:48 +01:00
Dean Herbert
a3c67aabe2
Merge branch 'master' into spectator-listing
2020-11-03 19:56:25 +09:00
Dean Herbert
c1d9a0c92c
Move click action out of user panel
2020-11-02 21:09:47 +09:00
Dean Herbert
ed30756c19
Add test coverage for new display (and remove live version for now)
2020-11-02 20:41:14 +09:00
Dean Herbert
c6de0544d2
Disable display for not
2020-11-02 20:21:23 +09:00
Dean Herbert
5cbfaf3589
Revert "Add (temporary) local user cache to avoid re-querying API each display"
...
This reverts commit 4e17634ee2
.
2020-11-02 20:19:38 +09:00
Dean Herbert
4e17634ee2
Add (temporary) local user cache to avoid re-querying API each display
2020-11-02 17:31:04 +09:00
smoogipoo
6f623d8cca
Rename IsUserPaused -> UserPauseRequested
2020-11-02 16:08:59 +09:00
Dean Herbert
8f2cd0e8c5
Add matching requestedByUser parameter to Play method
2020-11-02 15:01:30 +09:00
Dean Herbert
d2f6303988
Change default value of requestedByUser to false
2020-11-02 14:56:50 +09:00
Bartłomiej Dach
941e8525af
Add flag parameter to allow non-user-pause via music controller
2020-10-31 16:07:54 +01:00
Dean Herbert
f0b80d245e
Merge branch 'master' into spectator-listing
2020-10-31 16:22:49 +09:00
Dean Herbert
a088151e58
Merge branch 'spectator-replay-watcher' into spectator-listing
2020-10-31 16:22:10 +09:00
Max Hübner
4e3fb615d2
Rename "SeasonalBackgrounds" to "SeasonalBackgroundMode"
2020-10-30 15:54:10 +01:00
Dean Herbert
1db8dfd03e
Merge branch 'master' into seasonal-backgrounds
2020-10-30 22:53:51 +09:00
Max Hübner
76c0a790b4
Add separate Seasonal Backgrounds setting (Always, Sometimes, Never)
2020-10-29 17:28:04 +01:00
Bartłomiej Dach
1313ab89e7
Add xmldoc to multiple selection row
2020-10-28 23:37:21 +01:00
Bartłomiej Dach
016e920aa9
Move filter tab item hierarchy construction to BDL
2020-10-28 23:14:52 +01:00
Bartłomiej Dach
a8cefb0d4c
Rename method
2020-10-28 23:12:28 +01:00
Bartłomiej Dach
f5aedc96c4
Rework multiple selection filter
2020-10-28 23:07:54 +01:00
Bartłomiej Dach
e77049eae3
Use discard-like lambda parameter names
2020-10-28 22:58:51 +01:00
Andrei Zavatski
5c2c5f2000
Use existing ScoreRank for rank filter
2020-10-28 23:35:08 +03:00
Andrei Zavatski
4f6081c7f3
Use BindableList<T>
2020-10-28 19:44:13 +03:00
Dean Herbert
93fd913876
Add setting to allow automatically downloading during a spectating session
2020-10-28 19:43:06 +09:00
Dean Herbert
84d854e231
Avoid having the user profile show when clicking a spectator panel
2020-10-28 19:02:38 +09:00
Dean Herbert
32becb6882
Add simple listing of currently playing users
2020-10-28 19:02:38 +09:00
Dean Herbert
ce9dd0c920
Fix enum descriptions not being displayed in OverlayHeaderTabControl
2020-10-28 17:44:15 +09:00
Andrei Zavatski
914bd53788
Add missing blank line
2020-10-28 02:39:51 +03:00
Andrei Zavatski
03c5057a92
Simplify BeatmapSearchMultipleSelectionFilterRow
2020-10-28 02:28:31 +03:00
Andrei Zavatski
fd11346a28
Update button colours
2020-10-28 01:48:24 +03:00
Andrei Zavatski
b4ec3b9fef
Simplify MultipleSelectionFilterTabItem state changes
2020-10-28 01:41:46 +03:00
Andrei Zavatski
008d1d697c
Implement filtering by rank achieved
2020-10-27 23:14:48 +03:00
Andrei Zavatski
1710b396e7
Implement BeatmapSearchMultipleSelectionFilterRow
2020-10-27 22:27:29 +03:00
Andrei Zavatski
1b40b56d41
Add ability to search by play criteria
2020-10-27 21:30:53 +03:00
Andrei Zavatski
26a60d898c
Implement BeatmapSearchExtraFilterRow
2020-10-27 21:22:20 +03:00
Andrei Zavatski
742a96484b
Add ability to set extra parameters to SearchBeatmapSetsRequest
2020-10-27 20:13:18 +03:00
Dean Herbert
5a00a05a95
Add missing schedule call
2020-10-22 14:49:48 +09:00
Dean Herbert
3fe6f77444
Fix cases of multiple bdl methods
2020-10-22 14:30:49 +09:00
Dean Herbert
303975ccb1
Remove unnecessary permitNulls
2020-10-22 14:27:49 +09:00
Dean Herbert
9753dab93b
Remove IOnlineComponent and change existing components to use bindable flow
2020-10-22 14:19:12 +09:00
Dean Herbert
8273715bde
Merge pull request #9484 from FlashyReese/visible-playfield-boundary
2020-10-20 19:43:41 +09:00
Dean Herbert
80b1f816c7
Merge branch 'master' into hide-hud-during-break-time
2020-10-20 14:19:04 +09:00
Bartłomiej Dach
bca0539735
Move setting to osu! ruleset subsection
2020-10-19 21:05:21 +02:00
Bartłomiej Dach
053c7a69a6
Fix code style issues & compilation failures
2020-10-19 20:22:48 +02:00
Dean Herbert
22bde43106
Merge branch 'master' into visible-playfield-boundary
2020-10-19 18:05:28 +09:00
Dean Herbert
e3b47083fc
Add "scoring" as keyword to more easily find score display mode setting
2020-10-19 14:05:41 +09:00
Berkan Diler
fe3a23750c
Use char overloads for string methods
2020-10-16 11:52:29 +02:00
Dean Herbert
703f58bb2f
Remove last.fm support
...
Has been broken for ages, and their service isn't really something
people use these days.
2020-10-16 11:54:11 +09:00
Dean Herbert
3e326a9234
Use bindable flow for event propagation
2020-10-14 15:22:17 +09:00
Dean Herbert
24eff8c66d
Rename container to match "settings" term used everywhere
2020-10-14 15:13:49 +09:00
Leon Gebler
3fd913b13f
rename customisation container class
2020-10-13 19:38:25 +02:00
Leon Gebler
663b806974
move ModSettingsContainer to seperate component
2020-10-13 17:45:40 +02:00
Leon Gebler
1a85123b89
rename container class to be more descriptive
2020-10-12 21:24:42 +02:00
Leon Gebler
7df9282727
CodeAnalysis fixes
2020-10-12 15:58:34 +02:00
Leon Gebler
e5548a1216
Move ModSettingsContainer class inside ModSelectOverlay
2020-10-12 00:16:18 +02:00
Dan Balasescu
a1226ccaa2
Merge pull request #10440 from peppy/fix-editor-song-after-exit
...
Fix editor playing deleted beatmap's track on exit-without-save
2020-10-09 17:58:31 +09:00
Dean Herbert
389ffe7da5
Hide bonus result types from score table for the time being
2020-10-09 13:23:18 +09:00
Dean Herbert
07558b5bc0
Merge branch 'master' into ruleset-result-types
2020-10-09 13:17:05 +09:00
Dean Herbert
c86b37f60d
Add check to ensure MusicController doesn't play a delete pending beatmap's track
2020-10-09 13:11:24 +09:00
Bartłomiej Dach
c867fb4985
Merge branch 'master' into update-check-improvements
2020-10-08 21:32:26 +02:00
Dean Herbert
e281d724b8
Consume display name logic
2020-10-07 15:43:52 +09:00
Shane Woolcock
ec12a21088
Merge branch 'master' into confine-during-gameplay
...
# Conflicts:
# osu.Game/Overlays/Settings/Sections/Input/MouseSettings.cs
2020-10-07 11:07:00 +10:30
Dean Herbert
b2dad67ade
Fix unresolvable dependency in settings test scene
2020-10-06 21:28:59 +09:00
Dean Herbert
e8b34ba4ac
Fix incorrectly committed testing change
2020-10-06 20:57:39 +09:00
Dean Herbert
e64cee10b8
Add obsoleted Bindable property back to SettingsItem for compatibility
2020-10-06 19:07:31 +09:00
Dean Herbert
9d7880afda
Make SettingsItem conform to IHasCurrentValue
2020-10-06 17:18:54 +09:00
Dean Herbert
22b0105d62
Show a notification if checking for updates via button and there are none available
2020-10-06 13:00:02 +09:00
Shane Woolcock
4b6f893408
Merge branch 'master' into confine-during-gameplay
...
# Conflicts:
# osu.Game/Configuration/OsuConfigManager.cs
# osu.Game/OsuGame.cs
# osu.Game/Screens/Play/Player.cs
2020-10-05 10:23:37 +10:30
Dan Balasescu
73edb87363
Merge pull request #10303 from peppy/more-textbox-entry
...
Add textbox entry for speed multiplier and volume
2020-10-01 20:42:14 +09:00
Dean Herbert
61e62929ee
Apply changes in line with framework event logic update
2020-10-01 13:06:01 +09:00
Dean Herbert
9d07dce5e4
Merge pull request #10251 from smoogipoo/additional-hit-results
2020-10-01 12:19:48 +09:00
smoogipoo
2517fffb7e
Fix incorrect display in beatmap overlay table
2020-09-25 20:48:28 +09:00
smoogipoo
a07597c369
Adjust displays to use new results/orderings
2020-09-25 20:22:59 +09:00
Dean Herbert
a17eac3692
Rename reload method to not mention beatmap unnecessarily
2020-09-25 12:27:08 +09:00
Dean Herbert
978f6edf38
Add basic track reloading support while inside the editor
2020-09-24 20:56:35 +09:00
Dean Herbert
937d5870b3
Add a basic file selector with extension filtering support
2020-09-24 20:54:25 +09:00
Dean Herbert
3062fe4411
Add editor key bindings to switch between screens
2020-09-22 15:55:25 +09:00
Joehu
2ad7e6ca88
Fix hovered channel tabs color when unselected
2020-09-17 19:10:58 -07:00
Joehu
83d23c9547
Use new icon in chat overlay
2020-09-17 14:56:08 -07:00
Joehu
9063c60b9c
Fix profile section tab control not absorbing input from behind
2020-09-16 12:00:27 -07:00
Joehu
4dacdb9994
Fix mod select overlay absorbing input from toolbar ruleset selector
2020-09-13 11:50:21 -07:00
smoogipoo
b047fbb8ee
Use bindable value for search text
2020-09-11 17:46:07 +09:00
smoogipoo
6327f12fe4
Disable manage collections item in now playing overlay
2020-09-11 16:58:18 +09:00
smoogipoo
fcc8683629
Hook up now playing overlay to collections
2020-09-11 16:46:11 +09:00
smoogipoo
22c5e9f64f
Rename missing parameter
2020-09-11 12:19:26 +09:00
smoogipoo
be5d143b5a
Reorder params
2020-09-11 12:17:12 +09:00
Andrei Zavatski
cfc6e2175d
Add missing header to MostPlayedBeatmapsContainer
2020-09-10 20:58:37 +03:00
Andrei Zavatski
913e3faf60
Move PaginatedContainerWithHeader logic to a base class
2020-09-10 20:48:06 +03:00
Andrei Zavatski
e5f70d8eae
Simplify counter visibility changes in PaginatedContainerHeader
2020-09-10 20:31:00 +03:00
Andrei Zavatski
931e567c7e
Replace counter font size with an actual value
2020-09-10 20:25:35 +03:00
Andrei Zavatski
9b504272e4
Make Header a property
2020-09-10 20:24:43 +03:00
Andrei Zavatski
e5d0f3b657
Merge remote-tracking branch 'refs/remotes/ppy/master' into profile-sections-update
2020-09-10 20:23:02 +03:00
Dean Herbert
ef44c7d063
Merge branch 'master' into score-recalc
2020-09-10 18:30:41 +09:00
smoogipoo
d7ca2cf1cc
Replace loaded check with better variation
2020-09-09 22:01:09 +09:00
smoogipoo
37a659b2af
Refactor/add xmldocs
2020-09-09 17:36:47 +09:00
smoogipoo
1a023d2c88
Fix a few more tests
2020-09-09 16:33:48 +09:00
smoogipoo
4ddf5f054b
Rename BeatmapCollectionManager -> CollectionManager
2020-09-09 15:31:08 +09:00
smoogipoo
117c7ec6b2
Merge branch 'master' into score-recalc
2020-09-09 14:38:36 +09:00
Dean Herbert
66d3bda962
Merge branch 'master' into collection-database
2020-09-08 23:18:47 +09:00
Andrei Zavatski
95eeebd93f
Fix setting count for recent scores is overcomplicated
2020-09-08 15:31:00 +03:00
Dean Herbert
186507a88e
Merge branch 'fix-music-controller-regressed' into fix-toggle-pause-state
2020-09-08 18:37:52 +09:00
Dan Balasescu
68f3a1ea9a
Merge branch 'master' into collection-database
2020-09-08 18:30:01 +09:00
Dean Herbert
072aab90ab
Merge branch 'master' into fix-music-controller-regressed
2020-09-08 18:26:15 +09:00
Dean Herbert
ad5d6117c7
Remove unnecessary RunTask calls
2020-09-08 18:26:13 +09:00
Dean Herbert
14bf2ab936
Fix grammar in xmldoc
2020-09-08 18:21:26 +09:00
Dean Herbert
a46be45a71
Fix OSD occasionally display incorrect play/pause state
2020-09-08 18:12:03 +09:00
Dean Herbert
b1110e5e3a
Rename class to match derived class
2020-09-08 18:10:14 +09:00
smoogipoo
06328e0000
Add import/deletion progress notifications
2020-09-08 17:59:27 +09:00
Andrei Zavatski
1bc41bcfd7
Move scores counter logic to a better place
2020-09-08 00:04:14 +03:00
Andrei Zavatski
f88b2509f8
Fix ProfileSection header margin is too small
2020-09-07 23:43:26 +03:00
Andrei Zavatski
c72a192cb5
Fix recent plays counter is always zero
2020-09-07 23:33:04 +03:00
Andrei Zavatski
e39609d3ca
Implement PaginatedContainerWithHeader component
2020-09-07 23:08:50 +03:00
Andrei Zavatski
b7bd084296
Remove missing text where not needed
2020-09-07 22:30:43 +03:00
Andrei Zavatski
1c55039994
Remove old header from PaginatedContainer
2020-09-07 22:24:10 +03:00
Andrei Zavatski
5a7e2e96e0
Merge remote-tracking branch 'refs/remotes/ppy/master' into profile-sections-update
2020-09-07 22:19:26 +03:00
Andrei Zavatski
3a24cc1aa9
Implement PaginatedContainerHeader component
2020-09-07 22:13:29 +03:00
Joehu
2b62579488
Lowercase one more toolbar tooltip
2020-09-07 10:18:22 -07:00
smoogipoo
6cc4517600
Merge branch 'master' into collection-database
2020-09-07 20:03:11 +09:00
Dean Herbert
8f8f907fc7
Fix missed string
2020-09-07 13:27:28 +09:00
Joehu
b4b9c71f00
Make all toolbar tooltips lowercase
2020-09-06 10:13:06 -07:00
Salman Ahmed
33b76015d8
Fix MusicActionHandler unnecessarily depending on OnScreenDisplay's existance
2020-09-06 01:54:32 +03:00
Yao Chung Hu
96f39dd350
Merge remote-tracking branch 'upstream/master' into visible-playfield-boundary
2020-09-05 01:50:13 -05:00
smoogipoo
345fb9d8e0
Rename classes
2020-09-05 03:55:43 +09:00
Dean Herbert
b8e5acfef1
Merge branch 'master' into fix-music-controller-regressed
2020-09-04 20:10:43 +09:00
Dean Herbert
a0bc376446
Merge pull request #10062 from frenzibyte/fix-music-controller-propagating-event-twice
...
Fix MusicController raising track changed event twice
2020-09-04 20:09:49 +09:00
Salman Ahmed
3239576a23
Minor rewording of new comment
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2020-09-04 11:50:49 +03:00
Salman Ahmed
4236e5fe71
Replace useless "matching-code" comment with explanation of how it could happen
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2020-09-04 11:31:54 +03:00
Salman Ahmed
65d541456a
Slight rewording
2020-09-04 11:11:07 +03:00
Dean Herbert
ab057e6c65
Remove unnecessary string interpolation
2020-09-04 16:28:35 +09:00
Dean Herbert
644f3375ac
Also catch exceptions in the construction call
2020-09-04 16:28:19 +09:00
Salman Ahmed
001509df55
Move music global action handling to an own component
...
Due to requiring components that are added at an OsuGame-level
2020-09-04 10:24:54 +03:00
Salman Ahmed
42895e27b6
Expose track change results on the methods
2020-09-04 10:24:54 +03:00
Salman Ahmed
54013790fc
Fix MusicController raising TrackChanged event twice
2020-09-04 10:24:31 +03:00
Dean Herbert
a15653c77c
Fix potential hard crash if ruleset settings fail to construct
2020-09-04 16:15:57 +09:00
Dean Herbert
d55c9c3cc2
Fix UserProfile weirdness
2020-09-03 17:11:34 +09:00
Dean Herbert
99e34d8562
Update with missing icons
2020-09-03 17:05:45 +09:00
Dean Herbert
f5a73130e1
Fix regression in sidebar button sizing
2020-09-03 16:34:58 +09:00
Dean Herbert
0d1674ca5e
Combine settings strings to read from same location
2020-09-03 16:34:58 +09:00
Dean Herbert
2fac0a180e
Adjust toolbar button sizing
2020-09-03 16:34:58 +09:00
Dean Herbert
98c5a04a09
Update home button
2020-09-03 16:34:58 +09:00
Dean Herbert
942276d88f
Remove outdated SearchableList classes
2020-09-03 16:34:58 +09:00
Dean Herbert
7bcbac6f45
Move header setting to FullscreenOverlay
2020-09-03 16:34:58 +09:00
Dean Herbert
dbf44fbaf2
Update names and icons to match new designs
2020-09-03 16:34:58 +09:00
Dean Herbert
dceae21bbf
Centralise fetching of overlay component titles and textures
2020-09-03 16:34:58 +09:00
Dean Herbert
fe524ec491
Merge branch 'master' into update-framework
2020-09-03 14:58:32 +09:00
Dan Balasescu
84b3604192
Merge branch 'master' into game-overlay-activation-mode
2020-09-03 13:34:22 +09:00
smoogipoo
a56f9d6770
Implement collection import
2020-09-03 00:08:33 +09:00
Dean Herbert
6a765d2d76
Add smooth fading between audio tracks on transition
2020-09-02 20:04:56 +09:00
smoogipoo
555b2196b7
Add xmldoc to MusicController.ResetTrackAdjustments()
2020-09-02 15:23:50 +09:00
Dean Herbert
d45a1521a1
Update BindableList usages
2020-09-01 11:56:23 +09:00
Lucas A
ad223bc460
Make game bindable immutable.
2020-08-29 19:34:53 +02:00
smoogipoo
c1838902a6
Add to more places
2020-08-28 22:51:48 +09:00
smoogipoo
d7bbb362bf
Separate bindables
2020-08-28 22:51:19 +09:00
smoogipoo
1e5e5cae0c
Add support for standardised -> classic changes
2020-08-28 21:34:34 +09:00
smoogipoo
4d15f0fe52
Implement basic score recalculation
2020-08-28 19:16:46 +09:00
Dean Herbert
f65991f31f
Revert some usages based on review feedback
2020-08-26 23:28:58 +09:00
Dean Herbert
db52260427
Rename and clarify comment regarding "previous" track disposal
2020-08-22 19:44:54 +09:00
Dean Herbert
308d9f5967
Ensure locally executed methods are always loaded before propagation
2020-08-21 18:43:58 +09:00
Dean Herbert
357fb3a10e
Merge branch 'master' into beatmap-track-rework
2020-08-21 12:53:09 +09:00
Lucas A
6aa31dffdb
Fix toolbar not respecting current overlay activation mode.
2020-08-18 15:34:56 +02:00
Dean Herbert
5ade1e8259
Merge branch 'master' into beatmap-track-rework
2020-08-18 13:03:49 +09:00
Dean Herbert
083bcde3cf
Fix beatmap transfer not working
2020-08-18 13:01:35 +09:00
Dean Herbert
d9debef156
Add explicit LoadTrack method
2020-08-17 15:38:16 +09:00
Dean Herbert
948c3cfbf1
Improve visibility of toolbar tooltips against bright backgrounds
2020-08-17 14:56:19 +09:00
Shane Woolcock
322d179076
Replace settings item with osu! confine cursor mode
2020-08-16 11:04:28 +09:30
Dean Herbert
9e7a28002d
Merge branch 'master' into beatmap-track-rework
2020-08-13 17:56:50 +09:00
Dean Herbert
429ad783cf
Merge branch 'update-framework' into beatmap-track-rework
2020-08-12 23:35:46 +09:00
Andrei Zavatski
f3202fb123
Naming adjustments
2020-08-12 11:24:26 +03:00
Andrei Zavatski
84655b0798
Change hover colour for news title
2020-08-11 20:17:29 +03:00
Andrei Zavatski
fdfda453c7
Merge remote-tracking branch 'refs/remotes/ppy/master' into dashboard-news
2020-08-11 20:14:52 +03:00
smoogipoo
688e447950
Fix potential hierarchy mutation from async context
2020-08-12 01:33:06 +09:00
smoogipoo
070d71ec27
More cleanups
2020-08-12 00:48:38 +09:00
smoogipoo
031d29ac34
Inspect current track directly
2020-08-11 13:53:23 +09:00
smoogipoo
b64142dff9
Fix incorrect load state being used
2020-08-11 12:37:00 +09:00
Dean Herbert
dd2f677aa4
Merge pull request #9633 from Joehuu/fix-keybind-clearing
2020-08-11 11:01:03 +09:00
Andrei Zavatski
d8f8930691
Remove HomeNewsPanelFooter
2020-08-09 05:28:43 +03:00
Andrei Zavatski
a72a48624d
Remove NewsPostDrawableDate
2020-08-09 05:16:08 +03:00
smoogipoo
87ce1e3558
Remove impossible null case (DummyWorkingBeatmap)
2020-08-08 00:58:04 +09:00
smoogipoo
b8373e89b7
Move beatmap bind to BDL load()
2020-08-07 23:08:09 +09:00
smoogipoo
e87f50f74f
Rename method
2020-08-07 22:31:41 +09:00
smoogipoo
b6fb7a0d39
Fix possibly setting null track
2020-08-07 22:05:58 +09:00
smoogipoo
5002d69f69
Update inspections
2020-08-07 20:51:56 +09:00
smoogipoo
61b632516e
Ensure CurrentTrack is never null
2020-08-07 19:43:16 +09:00
Andrei Zavatski
cddd4f0a97
Implement HomeShowMoreNewsPanel
2020-08-07 13:18:31 +03:00
Andrei Zavatski
76d35a7667
Implement HomeNewsGroupPanel
2020-08-07 12:59:45 +03:00
smoogipoo
bf21fdd6da
Merge branch 'master' into beatmap-track-rework
2020-08-07 18:41:34 +09:00
Andrei Zavatski
2e0f567d5d
Implement HomeNewsPanel component
2020-08-07 11:33:02 +03:00
Dean Herbert
9685df0eca
Only update key binding on next usage to avoid large blocking calls
2020-08-06 18:24:20 +09:00
Joehu
f9c369b23c
Fix toolbar music button tooltip overflowing off-screen
2020-08-06 01:20:03 -07:00
Joehu
d574cac702
Add keybinding to toolbar button's tooltip
2020-08-06 01:18:45 -07:00
Joehu
7bcb68ffac
Handle overlay toggling with toolbar buttons instead
2020-08-06 01:17:24 -07:00
Joehu
ad959ce523
Make toolbar button abstract
2020-08-06 01:06:51 -07:00
smoogipoo
fe8c462498
Remove intermediate container
2020-08-06 17:00:17 +09:00
smoogipoo
0f7fde5d2c
Revert unnecessary change
2020-08-06 16:24:14 +09:00
smoogipoo
0edd509397
Only change track when audio doesn't equal
2020-08-06 16:24:14 +09:00
smoogipoo
e9fc783b1d
Add back loop-on-completion
2020-08-06 16:24:14 +09:00
smoogipoo
5c05fe3988
Expose track from MusicController
2020-08-06 16:24:14 +09:00
smoogipoo
6e42b8219c
Move track to MusicController, compiles
2020-08-06 16:24:14 +09:00
Dan Balasescu
bba23dc928
Merge pull request #9780 from peppy/add-toolbar-tooltips
...
Add missing toolbar tooltips for right-hand icons
2020-08-06 13:45:01 +09:00
Dean Herbert
e3f314349a
Don't use title case
...
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2020-08-06 12:27:30 +09:00
Dean Herbert
bf1bb32674
Add missing toolbar tooltips for right-hand icons
2020-08-05 19:09:55 +09:00
Dean Herbert
3916d98e52
Add comment for clarity
2020-08-05 18:50:37 +09:00
Dean Herbert
8644d04a84
Merge branch 'master' into news-fix
2020-08-05 18:50:35 +09:00
Andrei Zavatski
af320e4a61
Fix NewsOverlay running request on startup
2020-08-03 10:03:42 +03:00
Andrei Zavatski
630322ff85
Adjust font weights in line with web
2020-08-03 09:55:06 +03:00
Andrei Zavatski
057d6f03e5
Merge remote-tracking branch 'refs/remotes/ppy/master' into dashboard-beatmap-panel
2020-08-03 09:54:47 +03:00
Dan Balasescu
6511d6416b
Merge branch 'master' into fix-keybind-clearing
2020-08-03 15:26:09 +09:00
smoogipoo
435c9de8b9
Re-privatise buttons
2020-08-03 15:25:23 +09:00
Dean Herbert
4189e918a3
Merge branch 'master' into news
2020-08-03 14:16:45 +09:00
Joehu
7aafc018ad
Prevent updating bind target when hovering cancel and clear buttons instead
2020-08-02 12:52:12 -07:00
Joehu
ba77fa2945
Add test for clear button
2020-08-02 12:41:35 -07:00
Joehu
b96e32b0bb
Add xmldoc for updateBindTarget
2020-08-02 12:26:09 -07:00
Andrei Zavatski
dc559093cd
Rename namespace from Dashboard to Home
2020-08-02 21:47:09 +03:00
Andrei Zavatski
bddc61756a
Rework padding
2020-08-02 21:44:34 +03:00
Andrei Zavatski
7d83cdbf1c
Make title in DrawableBeatmapList a property
2020-08-02 21:35:24 +03:00
Andrei Zavatski
ca57c70961
Naming adjustments
2020-08-02 21:33:14 +03:00
Salman Ahmed
2190e6443a
Apply height constraints to all settings dropdown
2020-08-01 10:02:46 +03:00
Andrei Zavatski
5b1e3e8622
Remove redundant FillFlowContainer from DashboardBeatmapPanel
2020-08-01 09:11:53 +03:00
Andrei Zavatski
b5f688e63a
Implement DashboardBeatmapListing component
2020-08-01 07:04:39 +03:00
Andrei Zavatski
7624804edf
Implement DashboardPopularBeatmapPanel component
2020-08-01 06:23:06 +03:00
Andrei Zavatski
ce47a34991
Implement DashboardNewBeatmapPanel component
2020-08-01 06:14:24 +03:00
Andrei Zavatski
74f70136fd
Implement DashboardBeatmapPanel component
2020-08-01 06:00:24 +03:00
Dean Herbert
e8f75a78e8
Also fix second instance of same execution
2020-07-31 22:02:12 +09:00
Dean Herbert
4d2a677080
Fix next track starting before previous one is paused
...
Closes #9651 .
2020-07-31 20:33:18 +09:00
Dean Herbert
e6a2409415
Merge branch 'master' into panel-load-debounce
2020-07-30 16:03:17 +09:00
Andrei Zavatski
e1856503c2
Merge master with conflicts resolved
2020-07-30 08:41:45 +03:00
Dean Herbert
e5991d6e14
Change method structure for hover/unhover state setting (shouldn't be called "Fade")
2020-07-30 13:49:04 +09:00
Andrei Zavatski
45ddc7a2e9
Rename ShowMoreButton in comments namespace to ShowMoreRepliesButton
2020-07-30 05:02:01 +03:00
Andrei Zavatski
d4496eb982
Update ShowMoreButton in line with web
2020-07-30 04:51:09 +03:00
Andrei Zavatski
d7fab98af0
Update comments container footer in line with web
2020-07-29 06:39:23 +03:00
smoogipoo
42e88c53d7
Embed behaviour into UserCoverBackground
2020-07-28 20:50:55 +09:00
Andrei Zavatski
2d502cebda
Update DrawableComment layout
2020-07-28 02:36:25 +03:00
Andrei Zavatski
6737c57e33
Adjust colour of edit info
2020-07-28 01:10:13 +03:00
Andrei Zavatski
69691b3739
Use DrawableDate to represent creation date
2020-07-28 00:53:51 +03:00
Andrei Zavatski
46d1de7fa7
ShowMoreButton rework
2020-07-28 00:43:06 +03:00
Andrei Zavatski
1b5a23311e
Update ChevronButton position/colour
2020-07-28 00:29:17 +03:00
Andrei Zavatski
788395f8bf
Revert changes regarding FrontPageDisplay and OverlayView
2020-07-25 15:08:06 +03:00
Andrei Zavatski
c6ae2f520e
Fix FrontPageDisplay is adding more news posts on api state change
2020-07-25 10:39:10 +03:00
Andrei Zavatski
7e5147761f
Use OverlayView for FrontPageDisplay
2020-07-25 09:26:29 +03:00
Andrei Zavatski
b821d619b5
Merge remote-tracking branch 'refs/remotes/ppy/master' into news
2020-07-25 09:13:12 +03:00
Dean Herbert
dfcd26be2d
Merge pull request #9439 from Game4all/gameplay-disable-winkey
2020-07-24 19:34:48 +09:00
Dean Herbert
11f48ee4db
Merge branch 'master' into overlay-header-padding
2020-07-22 16:22:20 +09:00
Dean Herbert
fea6389f69
Hide HUD elements during break time by default
2020-07-22 12:41:06 +09:00
Andrei Zavatski
ad9492804a
Apply suggestions
2020-07-21 22:56:44 +03:00
Andrei Zavatski
0a71194ea6
Fix SpotlightSelector is a VisibilityContainer without a reason
2020-07-21 22:46:08 +03:00
Andrei Zavatski
0145ca09e5
Apply changes to overlays
2020-07-21 20:11:10 +03:00
Andrei Zavatski
e96f8f1cb6
Make content side padding adjustable for OverlayHeader
2020-07-21 20:02:22 +03:00
Joehu
a8991bb8bf
Fix keybind clear button always clearing first keybind regardless of target
2020-07-20 20:13:09 -07:00
Andrei Zavatski
5cdccd96fe
Merge remote-tracking branch 'refs/remotes/ppy/master' into friends_brick
2020-07-20 22:12:14 +03:00
Andrei Zavatski
a6562be3eb
Remove unused classes from social namespace
2020-07-18 23:27:33 +03:00
Andrei Zavatski
3e773fde27
Remove SocialOverlay component as never being used
2020-07-18 23:15:22 +03:00
Andrei Zavatski
81d95f8584
Implement UserBrickPanel component
2020-07-18 20:24:38 +03:00
Andrei Zavatski
ab23e7dfd4
Protect the NewsCard from clicks while hovering DateContainer
2020-07-16 23:14:51 +03:00
Andrei Zavatski
2d9909cdd8
Make news cards clickable
2020-07-16 15:18:01 +03:00
Andrei Zavatski
68d2888a8c
Add NewsOverlay to the game
2020-07-16 14:48:40 +03:00
Andrei Zavatski
17c598568d
Merge remote-tracking branch 'refs/remotes/ppy/master' into news
2020-07-16 14:38:50 +03:00
Dean Herbert
61b298d74d
Merge pull request #9571 from smoogipoo/fix-mod-selection
2020-07-16 16:04:43 +09:00
smoogipoo
96724bde32
Fix chat name backgrounds not dimming
2020-07-16 15:05:01 +09:00
smoogipoo
94834e4920
Select mods via exact types
2020-07-15 19:35:52 +09:00
Dan Balasescu
4a480d8563
Merge branch 'master' into comments-buttons
2020-07-15 16:42:17 +09:00
Andrei Zavatski
0043bd74ba
Rework SpotlightSelector header layout
2020-07-15 08:27:46 +03:00
Andrei Zavatski
df9ea5cc2f
Merge remote-tracking branch 'refs/remotes/ppy/master' into rankings-spotlights-filter
2020-07-15 08:08:02 +03:00
smoogipoo
d8ebb8e3eb
Move override to a bit better location
2020-07-15 13:17:22 +09:00
Joehu
79f6092344
Fix back button not glowing when closing mod select with escape
2020-07-14 13:31:15 -07:00
Andrei Zavatski
85c8757572
Return true on click
2020-07-14 21:18:46 +03:00
Andrei Zavatski
3d9e174ae8
Make sort changes affect request result
2020-07-14 18:09:09 +03:00
Andrei Zavatski
c2c80d2a98
Refactor SpotlightSelector layout
2020-07-14 17:34:01 +03:00
Andrei Zavatski
28006ac33f
Remove unnecessary action from ShowRepliesButton
2020-07-14 15:12:18 +03:00
Andrei Zavatski
4c2294f0cd
Refactor LoadRepliesButton to inherit LoadingButton
2020-07-14 15:02:29 +03:00
Andrei Zavatski
7c71cc6b61
Remove unneeded class from DrawableComment
2020-07-14 03:06:51 +03:00
Andrei Zavatski
56349e65f3
Rename arrow direction method
2020-07-14 03:01:14 +03:00
Andrei Zavatski
f6e4ecd960
Merge remote-tracking branch 'refs/remotes/ppy/master' into comments-buttons
2020-07-14 02:46:29 +03:00
Dean Herbert
7b7b92aa10
Fix potential crash when trying to ensure music is playing
2020-07-13 17:28:16 +09:00
Andrei Zavatski
6eec2f9429
Implement RankingsSortTabControl component
2020-07-13 01:22:05 +03:00
Andrei Zavatski
598e48678e
Refactor NewsHeader
2020-07-12 15:45:48 +03:00
Andrei Zavatski
3601a2d93f
Merge remote-tracking branch 'refs/remotes/ppy/master' into news
2020-07-12 14:45:48 +03:00
Andrei Zavatski
be36a4b768
Make ctor protected
2020-07-12 12:39:48 +03:00
Andrei Zavatski
c3524cbe57
Make icon private but expose a protected method
2020-07-12 12:32:26 +03:00
Andrei Zavatski
da40f29b44
Make button text a property
2020-07-12 12:27:26 +03:00
Andrei Zavatski
024ccc75ee
Adjust margins/paddings
2020-07-11 09:03:03 +03:00
Andrei Zavatski
84392d0d13
Add loading spinner
2020-07-11 08:50:35 +03:00
Andrei Zavatski
b1b2e961bc
Update arrow colour on hover
2020-07-11 08:13:11 +03:00
Andrei Zavatski
42d3288f17
Update old buttons usage
2020-07-11 08:01:11 +03:00
Andrei Zavatski
0861ee0c8e
Make Icon rotate when clicking ShowRepliesButton
2020-07-11 07:54:37 +03:00
Andrei Zavatski
da249abd19
Implement CommentRepliesButton
2020-07-11 07:47:17 +03:00
Andrei Zavatski
789c921af1
Move replies button to a new line
2020-07-11 06:47:52 +03:00
Yao Chung Hu
d40f209f4b
Move Playfield Border to OsuPlayfield Ruleset
2020-07-10 07:36:21 -05:00
Dan Balasescu
895c129151
Merge pull request #9492 from peppy/ensure-music-playing-mainmenu-lounge
...
Ensure music playing when returning to lounge or main menu
2020-07-10 21:23:24 +09:00
Dan Balasescu
1ee0a8cd6d
Merge pull request #9495 from peppy/download-button-tooltips
...
Add tooltips to download buttons
2020-07-10 20:57:09 +09:00
Dan Balasescu
be2c892c30
Merge branch 'master' into ensure-music-playing-mainmenu-lounge
2020-07-10 20:48:16 +09:00
Dean Herbert
840380e0de
Fix LocallyAvailable state case getting cleared
2020-07-10 20:30:59 +09:00
Dean Herbert
1760cc2427
Fix behavioural regression by splitting methods out
2020-07-10 18:03:56 +09:00
smoogipoo
ed926de77f
Fix up/improve dropdown styling/positioning
2020-07-10 17:25:28 +09:00
smoogipoo
d0c2a1b9d3
Move dropdown out of display style selector
2020-07-10 17:25:07 +09:00
Dean Herbert
49b88971d1
Display all usable beatmaps in playlist, including protected
2020-07-10 17:20:27 +09:00
Yao Chung Hu
321815f535
Add playfield bounds box with toggle and dim slider
2020-07-09 14:01:28 -05:00
Dean Herbert
115bb40816
Select via select action
2020-07-09 18:25:14 +09:00
Dan Balasescu
fcf3d1ca89
Merge branch 'master' into opaque-toolbar
2020-07-09 15:00:17 +09:00
Andrei Zavatski
f663dd1803
Fix incorrect file name
2020-07-09 04:02:14 +03:00
Andrei Zavatski
aeb664aca7
Delete broken file
2020-07-09 04:00:53 +03:00
Andrei Zavatski
3ba8ec0fd7
Don't set null value to show front page
2020-07-09 03:40:14 +03:00
Andrei Zavatski
dfa22b1e4c
Styles improvements
2020-07-09 02:37:42 +03:00
Andrei Zavatski
62e2bc1198
Fix potential double-request situation
2020-07-09 01:29:27 +03:00
Andrei Zavatski
900f2d309b
Classes naming adjustments
2020-07-09 01:26:56 +03:00
Andrei Zavatski
57b935ec50
Remove outdated elements
2020-07-08 20:17:15 +03:00
Andrei Zavatski
0b4213f330
Implement FrontPageDisplay
2020-07-08 20:07:29 +03:00
Andrei Zavatski
49d998c8db
Refactor NewsOverlay to use displays logic
2020-07-08 18:24:13 +03:00
Dean Herbert
12e3a3c38a
Adjust toolbar fade in/out on toggle
2020-07-08 15:11:26 +09:00
Dean Herbert
0684ac90c6
Make toolbar opaque
...
This is the general direction we're going with future designs. Just
applying this now because it makes a lot of screens feel much better
(multiplayer lobby / match, song select etc. where there are elements
adjacent to the bar which cause the transparency to feel a bit awkward).
2020-07-08 14:43:12 +09:00
Bartłomiej Dach
c88a802b05
Adjust font size to match web design
2020-07-07 23:04:39 +02:00
Andrei Zavatski
bdec13d4a4
Move DateTooltip to it's on file
2020-07-07 16:46:17 +03:00
Andrei Zavatski
447cd17cf6
Merge remote-tracking branch 'refs/remotes/ppy/master' into news
2020-07-07 16:36:41 +03:00
Dean Herbert
8152e0791d
Fix potential nullref
2020-07-07 21:48:42 +09:00
Andrei Zavatski
c86bb2e755
Use DrawableDate tooltip for DateContainer
2020-07-07 00:01:06 +03:00
Andrei Zavatski
68d9f9de46
Use DateTimeOffset
2020-07-06 23:55:20 +03:00
Andrei Zavatski
040b2a5aa8
Merge remote-tracking branch 'refs/remotes/ppy/master' into news
2020-07-06 23:51:39 +03:00
smoogipoo
dbbee481f6
Expose dialog body text getter
2020-07-06 22:01:45 +09:00
Lucas A
022e4b6335
Apply review suggestions.
2020-07-06 11:15:56 +02:00
Andrei Zavatski
fdb7727e95
Rename NewsPost to APINewsPost
2020-07-06 07:28:44 +03:00
Andrei Zavatski
7550097eb6
Implement NewsCard
2020-07-06 07:27:53 +03:00
Lucas A
641ea5b950
Make the disabling of the win key during gameplay a toggleable setting.
2020-06-30 13:12:33 +02:00
Dean Herbert
8f7f6881d3
Merge branch 'master' into update-framework
2020-06-16 16:46:22 +09:00
Dean Herbert
c79d8a4251
Update ChannelTabControl in line with TabControl changes
2020-06-16 00:18:09 +09:00