Joseph Madamba
94d6ab1ec7
Continue confirming when rehovering if mouse is still down
2023-02-10 19:09:30 -08:00
Joseph Madamba
bfd83768c1
Fix skin component previews on toolbox buttons having incorrect size for one frame
2023-02-10 17:58:34 -08:00
Joseph Madamba
d30d054b4c
Add ability to abort dangerous dialog button on hover lost
2023-02-10 14:41:44 -08:00
Dean Herbert
28897b6e18
Merge pull request #22566 from Joehuu/profile-tournament-banner
...
Display tournament banner on user profile
2023-02-09 16:06:36 +09:00
Joseph Madamba
f1decb667e
Address todos relating to init-only usages
2023-02-08 17:51:28 -08:00
Joseph Madamba
3b5d573db1
Display tournament banner on user profile
2023-02-08 17:16:09 -08:00
Bartłomiej Dach
0a5c4e04bf
Merge branch 'master' into skin-editor-undo-support
2023-02-08 18:43:59 +01:00
Joseph Madamba
0156ff732f
Fix beatmap cards not showing context menu on user profile
2023-02-07 22:56:09 -08:00
Dean Herbert
17ca26ebee
Remove unnecessary null check on targetScreen
2023-02-08 15:44:24 +09:00
Dean Herbert
3a3c2e78a1
Merge branch 'master' into skin-editor-undo-support
2023-02-08 15:41:58 +09:00
Dean Herbert
78eae171ed
Merge pull request #22507 from Joehuu/fix-comment-padding
...
Fix comments having too much padding at the bottom
2023-02-08 15:01:05 +09:00
Dean Herbert
b6809e156b
Merge pull request #22432 from mk56-spn/sheared_slider_implementation_clean_ii
...
Implement a sheared slider for the updated design
2023-02-08 15:01:00 +09:00
Joseph Madamba
277f71d36a
Expire reply editor instead of clearing container
2023-02-07 15:15:51 -08:00
Dean Herbert
0320ba770f
Handle component changes via ISkinnableTarget.Components rather than inside SkinEditor directly
...
Seems saner? Maybe?
2023-02-07 16:23:25 +09:00
Dean Herbert
dad348111d
Fix holding a selection while changing screens causing a crash
2023-02-07 16:07:33 +09:00
Dean Herbert
71eef238c4
Make OnStateChange non-implemented rather than wrong
2023-02-07 16:04:31 +09:00
Bartłomiej Dach
179db09075
Merge pull request #22531 from peppy/apply-future-rider-inspection
...
Apply single inspection from newer inspectcode versions
2023-02-06 20:05:49 +01:00
Dean Herbert
c691a0d3af
Merge branch 'master' into sheared_slider_implementation_clean_ii
2023-02-06 17:49:33 +09:00
Dean Herbert
c078d3a344
Merge pull request #22357 from EXtremeExploit/groups-probationary-badges
...
Make probationary groups a bit transparent
2023-02-06 17:43:57 +09:00
Dean Herbert
4c868372a2
Correctly handle anchor/origin changes as undo states
2023-02-06 15:05:05 +09:00
Dean Herbert
7445814fc6
Handle changes to SettingSource skin element settings
2023-02-06 14:42:59 +09:00
Dean Herbert
701d21c26f
Apply single inspection from newer inspectcode verisons
...
As found in rider EAPs. Appears as a warning and is annoying me
occasionally.
2023-02-06 13:52:27 +09:00
Dean Herbert
10ab4d572a
Merge branch 'master' into skin-editor-undo-support
2023-02-06 13:46:50 +09:00
Joseph Madamba
cb8458cceb
Use linq and alpha instead
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-02-04 20:11:29 -08:00
Joseph Madamba
4192388b20
Fix expanded beatmap cards getting cut off at the end of profile sections
2023-02-03 21:29:01 -08:00
Bartłomiej Dach
4bd43171e8
Merge branch 'master' into fix-skin-editor-padding-weirdness
2023-02-03 20:28:47 +01:00
Bartłomiej Dach
59656a7286
Merge branch 'master' into skin-editor-dont-show-save-on-no-change
2023-02-03 19:08:33 +01:00
EXtremeExploit
f9809c9481
the comment
2023-02-03 11:48:11 -03:00
Joseph Madamba
461b5c5375
Fix comment cancel button not behaving the same as reply text toggle
...
- Removed the fading animation as it is awkward right now (needs resizing)
2023-02-03 02:04:19 -08:00
Dean Herbert
2cda277c09
Add a basic change handler to the skin editor
2023-02-03 18:57:50 +09:00
Joseph Madamba
94d2799b90
Fix comments having too much padding at the bottom
2023-02-03 00:47:10 -08:00
Dean Herbert
b19047b90b
Fix skin editor component list having uneven padding
2023-02-03 16:55:51 +09:00
Dean Herbert
32207dc9dd
Merge branch 'master' into locale/skin-editor-components
2023-02-03 15:24:00 +09:00
Dean Herbert
5ca5f04794
Add parameter hint for optional bool value
2023-02-03 15:18:40 +09:00
Bartłomiej Dach
e937022b09
Merge branch 'master' into middle-click-replay-pause
2023-02-02 20:52:03 +01:00
Bartłomiej Dach
4d46a8f32d
Merge branch 'master' into skin-editor-dont-show-save-on-no-change
2023-02-02 19:36:23 +01:00
Bartłomiej Dach
f7fa9e3927
Remove outdated comment
2023-02-02 18:41:35 +01:00
mk56-spn
3f0ce75bf5
Rename NormalSliderBar.cs to RoundedSliderBar.cs
2023-02-02 17:24:45 +01:00
Dean Herbert
015f4f2b38
Avoid showing skin save message when changing scenes after making no changes
2023-02-02 18:42:37 +09:00
Dean Herbert
9b6d95b3d6
Adjust skin editor pop in/out to be more snappy
2023-02-02 18:33:45 +09:00
Dean Herbert
26efb8e842
Replace white box legacy placeholder with something that visually fits
2023-02-02 18:33:31 +09:00
Dean Herbert
659b78058f
Move replay specific key bindings to their own section
2023-02-02 15:25:52 +09:00
Dean Herbert
8dc2e6872e
Move skin editor to overlays namespace
2023-02-02 14:00:31 +09:00
Dean Herbert
d54db8de64
Merge branch 'master' into fix-clicking-metadata-relevance-sort
2023-02-01 19:39:13 +09:00
Dean Herbert
524aa9162d
Store search parameters as tuple
2023-02-01 19:38:47 +09:00
Joseph Madamba
1a152452f1
Fix incorrect naming of badge header container
2023-01-31 15:16:29 -08:00
Joseph Madamba
0366a8e348
Only call Reset() if lastCategory and lastHasQuery is null
2023-01-31 12:44:44 -08:00
Dean Herbert
5d22f3d879
Improve inline comment
2023-01-31 17:17:21 +09:00
Cootz
b18652b25f
CreateSubDirectory removed. Fixes the empty root issue
2023-01-31 10:14:21 +03:00
Cootz
54d5d4e7c6
Fix for the issue
2023-01-31 07:06:26 +03:00
Joseph Madamba
610d2f9dc7
Fix beatmap listing potentially not sorting by relevance when searching via metadata
2023-01-28 12:14:35 -08:00
mk56-spn
091cc155d3
Fix nub naming in OsuCheckbox.cs and associated classes
2023-01-26 16:10:02 +01:00
EXtremeExploit
1de0bed83d
fix comment
2023-01-26 11:09:16 -03:00
mk56-spn
374c3b56f6
Rename Nub.cs to NormalNub.cs
2023-01-26 15:03:11 +01:00
mk56-spn
3988131475
Rename OsuSliderBar.cs as NormalSliderBar.cs
2023-01-26 12:12:56 +01:00
EXtremeExploit
0eaebfd40a
Use Alpha instead of opacity on bg color
2023-01-25 10:22:42 -03:00
Dean Herbert
5c888e0c68
Merge branch 'master' into beatmapSelectionBlur
2023-01-25 16:37:19 +09:00
Dean Herbert
01e280eb6b
Add classic default for song select blur setting
2023-01-25 16:32:00 +09:00
Dean Herbert
e333e12b2e
Fix typo in settings enum (seriously)
2023-01-25 16:32:00 +09:00
Dean Herbert
3faab66f39
Merge branch 'master' into beatmapSelectionBlur
2023-01-25 16:32:00 +09:00
Dean Herbert
6bf7773532
Increase duration of expansion transition
2023-01-25 14:28:25 +09:00
Dean Herbert
3e91dd2a16
Update spacing along with expanded state
2023-01-25 14:28:25 +09:00
Bartłomiej Dach
f2df36e6a5
Persist cover visibility to user settings
...
Follows web precedent, wherein the setting is saved to local storage.
2023-01-24 23:30:12 +01:00
Bartłomiej Dach
33e91cf512
Implement cover toggling
2023-01-24 23:06:49 +01:00
Bartłomiej Dach
e74176e5bd
Add cover toggle button
2023-01-24 23:06:46 +01:00
Bartłomiej Dach
ef7812412b
Update top header container appearance
2023-01-24 23:06:44 +01:00
Bartłomiej Dach
ff22a91d52
Move user cover lower down
2023-01-24 23:06:37 +01:00
Bartłomiej Dach
edb9c76edf
Merge pull request #22385 from peppy/touchscreen-settings-keyword
...
Fix touch input handler settings not matching search for "touchscreen"
2023-01-24 20:50:53 +01:00
Jérémiah DÉCOMBE
acb42f7d12
reusing gameplay background blur loc song select background blur
2023-01-24 10:18:00 +01:00
Dean Herbert
b9291cb116
Change some order and assert for positive visibility before scheduling an operation in changelog overlay
2023-01-24 17:59:25 +09:00
Jérémiah DÉCOMBE
e0a7559d85
variable naming + loc
2023-01-24 09:55:08 +01:00
Joseph Madamba
c6bf755e68
Remove IsPresent override from ChangelogOverlay
2023-01-24 00:22:29 -08:00
Joseph Madamba
df895c4fd6
Always make settings footer build display clickable
2023-01-24 00:21:39 -08:00
Jérémiah DÉCOMBE
7ca2a431e6
changing song select background blur setting to boolean
2023-01-24 09:19:53 +01:00
Dean Herbert
fc558278cc
Fix touch input handler settings not matching search for "touchscreen"
2023-01-24 13:37:12 +09:00
Jeremiah DECOMBE
b573e42cc2
BeatmapSelectionBackgroundBlurLevel renamed to SongSelectBackgroundBlurLevel
2023-01-24 00:08:11 +01:00
Jeremiah DECOMBE
f13a5465ba
variable naming and loc modifications
2023-01-23 23:07:50 +01:00
Bartłomiej Dach
9f2ed853eb
Merge pull request #22371 from peppy/more-settings-keywords
...
Add more keywords to settings based on feedback
2023-01-23 20:19:53 +01:00
Jérémiah DÉCOMBE
6daa364779
adding setting to adjust blur of the background of the song select screen
2023-01-23 13:53:31 +01:00
Dean Herbert
432e0a6a37
Merge branch 'master' into level-badge-colour
2023-01-23 15:46:15 +09:00
Dean Herbert
9c2494383f
Rename fetch method to be non-plural to match all others
2023-01-23 15:43:52 +09:00
Dean Herbert
7ebd31d42f
Add more keywords to settings based on feedback
2023-01-23 15:14:16 +09:00
Dean Herbert
2ed9fe3747
Add support for externally specified keywords in SettingsButtons
2023-01-23 15:10:26 +09:00
EXtremeExploit
8d4889d5ce
Cleanup
2023-01-22 17:42:53 -03:00
EXtremeExploit
e60a089f1a
Set alpha on container instead of children
2023-01-22 15:02:02 -03:00
EXtremeExploit
de5eb63ceb
Fix codefactor
2023-01-22 13:38:13 -03:00
EXtremeExploit
933fc8cc83
Fix comment
2023-01-22 13:33:36 -03:00
EXtremeExploit
64c9654910
Make probationary groups a bit transparent
2023-01-22 13:32:05 -03:00
Bartłomiej Dach
e1acf85bb3
Merge branch 'master' into groups-modes
2023-01-22 10:09:34 +01:00
Bartłomiej Dach
9bde1ef9bf
Privatise setter
2023-01-22 10:09:08 +01:00
Bartłomiej Dach
b98da506c1
Fix code quality inspection
2023-01-22 10:07:47 +01:00
Bartłomiej Dach
88d58e8476
Merge pull request #22337 from Joehuu/fix-comment-editor-sounds
...
Fix comment editor text boxes not having sound feedback
2023-01-22 09:10:20 +01:00
Dean Herbert
7040743249
Add search keywords for screen scaling sub-settings
2023-01-22 13:47:31 +09:00
EXtremeExploit
2f3971b6fb
Move code to already existing if block
2023-01-22 01:40:00 -03:00
EXtremeExploit
8c208da324
Cleanup
2023-01-22 01:39:01 -03:00
EXtremeExploit
05f77d2cab
Add modes text to groups tooltip
2023-01-22 01:36:53 -03:00
Joseph Madamba
da03abc812
Fix comment editor text boxes not having sound feedback
2023-01-21 17:32:42 -08:00
Dean Herbert
4916a742d5
Immediately focus the textbox when clicking to reply to a comment
2023-01-19 16:08:27 +09:00
Dean Herbert
81e6c3792c
Remove unused method
2023-01-19 16:03:46 +09:00
Dean Herbert
07af18b8a7
Remove ReplyCommentEditor into its own class
2023-01-19 16:01:37 +09:00
ansel
77bc4fbf70
Integrate editor into comment
2023-01-18 20:50:07 +03:00
ansel
0d91277ea5
Add ability to change number on replies button
2023-01-18 20:49:30 +03:00
ansel
c74500b4b4
Add reply editor
2023-01-18 20:49:07 +03:00
ansel
0f2ca5d5ed
Expose method for drawable comment creation
2023-01-18 18:10:35 +03:00
ansel
18baf3dd5d
Log delete failure
2023-01-18 17:30:34 +03:00
StanR
24ed84aad0
Add tiered level badge colouring
2023-01-18 16:25:11 +03:00
Dean Herbert
39ac7615ec
Merge branch 'master' into registration-loc
2023-01-18 13:41:53 +09:00
Dean Herbert
f7c4199a77
Merge pull request #22262 from Joehuu/chat-mention-user
...
Add ability to easily mention users in chat by right clicking username
2023-01-18 13:30:02 +09:00
Dean Herbert
0a47dc733f
Merge pull request #22268 from Feodor0090/comments-margin
...
Reduce padding for too nested comments
2023-01-18 11:45:41 +09:00
ansel
ca3be71381
Track comment's nesting and reduce padding for too nested
2023-01-18 02:11:07 +03:00
ansel
12544c16ea
Remove canBeNull
2023-01-18 02:10:02 +03:00
Joseph Madamba
dfea42fd16
Add space after username mention
2023-01-17 14:13:50 -08:00
Joseph Madamba
254c881ded
Also check null for bindable channel value
2023-01-17 14:12:48 -08:00
Bartłomiej Dach
f7c942ac10
Move user stats into detail header container
2023-01-17 22:32:24 +01:00
Bartłomiej Dach
7a475d9cf8
Move out stats from top header container
2023-01-17 22:32:15 +01:00
Bartłomiej Dach
350cce1315
Move contents of detail header to separate component
2023-01-17 22:32:12 +01:00
Bartłomiej Dach
f5459909f9
Merge branch 'master' into comment-editor-3
2023-01-17 21:31:08 +01:00
Bartłomiej Dach
3640342805
Add logging on comment post failure
2023-01-17 21:30:46 +01:00
Joseph Madamba
97bd76efc6
Add ability to easily mention users in chat by right clicking username
2023-01-17 10:01:07 -08:00
Feodor0090
99c65af6cd
Merge branch 'master' into registration-loc
2023-01-17 13:38:05 +03:00
ansel
df74bccaaa
Replace 2 strings with one formattable
2023-01-17 13:31:03 +03:00
Dean Herbert
c799375ae0
Merge pull request #20709 from Domilz/toolbar-localisation
...
Localise toolbar home button and ruleset description tooltips
2023-01-17 17:28:34 +09:00
Dean Herbert
a02556d2fa
Move hover logic to SettingsToolboxGroup to avoid expanded state clash
2023-01-17 14:43:22 +09:00
Dean Herbert
1f47def3c4
Merge branch 'master' into skin-editor-loc
2023-01-17 11:53:08 +09:00
Bartłomiej Dach
0c5a436754
Merge pull request #22241 from stanriders/refactor-levelbadge
...
Refactor `LevelBadge` to use `LevelInfo`
2023-01-16 23:33:03 +01:00
Bartłomiej Dach
f79037cefb
Move to LoadComplete() better
2023-01-16 21:47:31 +01:00
StanR
3f75506552
Move binding to LoadComplete
2023-01-16 23:42:07 +03:00
StanR
c5d09c0e2c
Rename variable
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-01-16 23:36:50 +03:00
StanR
6207a96a29
Refactor LevelBadge to use LevelInfo
2023-01-16 23:24:09 +03:00
Bartłomiej Dach
bf58fe21ce
Merge branch 'master' into beatmap-set-converted-beatmaps
2023-01-16 20:46:41 +01:00
ansel
bb3668c769
Reuse existing
2023-01-16 22:24:03 +03:00
ansel
4c341db33f
Localise registration window
2023-01-16 21:31:01 +03:00
ansel
ff5a12fcb4
Localise login form
2023-01-16 20:39:38 +03:00
ansel
26f3b1dbfe
Localise "revert to default" tooltip
2023-01-16 19:37:47 +03:00
Joseph Madamba
0ff143d4c8
Add argument for play some ruleset string
2023-01-15 15:23:26 -08:00
Joseph Madamba
ae49e724e4
Move converted beatmap icons logic locally
2023-01-15 15:09:25 -08:00
Joseph Madamba
b733f46c6f
Apply NRT to BeatmapPicker
2023-01-15 15:09:25 -08:00
Joseph Madamba
27671f0401
Merge remote-tracking branch 'upstream/master' into pr/20709
2023-01-15 15:08:11 -08:00
Joseph Madamba
85c1932851
Mark Converts as nullable
2023-01-15 12:46:41 -08:00
Joseph Madamba
627d1725c3
Fix kudosu wiki link from user profile not linking to in-game overlay
2023-01-14 19:56:51 -08:00
ansel
1480c691ae
Explain empty string in editor's footer
2023-01-14 23:42:56 +03:00
ansel
c36922dd2c
Use clock to obtain a position for comment insertion
2023-01-14 22:57:51 +03:00
ansel
c2bb0949f5
Take type and id from container directly on submit
2023-01-14 22:57:23 +03:00
ansel
cdf3aafddd
Add check for any drawables in content before looking for placeholder
2023-01-14 22:37:05 +03:00
Joseph Madamba
e7ab543799
Add ability to view converted beatmaps on beatmap set overlay
2023-01-14 10:26:21 -08:00
ansel
88c3eef8e1
Add test case with no existing comments
2023-01-14 20:59:13 +03:00
Bartłomiej Dach
67a3ea2c59
Fix wrong date colour of kudosu history items
2023-01-14 17:50:18 +01:00
Bartłomiej Dach
bfca75395b
Adjust colour of top header container
2023-01-14 17:37:33 +01:00
Bartłomiej Dach
6a9d842660
Adjust user profile header detail appearance
2023-01-14 17:37:31 +01:00
Bartłomiej Dach
de077403e9
Adjust visual appearance of profile value displays
2023-01-14 17:37:28 +01:00
Bartłomiej Dach
f80dddbb5e
Rearrange and adjust header components where simple
2023-01-14 17:17:28 +01:00
Bartłomiej Dach
e39eb089ce
Update colouring of some profile section elements
2023-01-14 17:17:26 +01:00
Bartłomiej Dach
5b1111c6b1
Adjust appearance of user profile sections
2023-01-14 17:17:24 +01:00
Bartłomiej Dach
3f81f173fb
Adjust appearance of section navigation
2023-01-14 17:17:21 +01:00
Bartłomiej Dach
49e08c06a6
Adjust general appearance of user profile overlay
2023-01-14 16:59:51 +01:00
Bartłomiej Dach
5e1ea8b34f
Merge branch 'master' into move-overlay-ruleset-selectors
2023-01-14 15:22:14 +01:00
Dean Herbert
2f2ab445c9
Merge pull request #22182 from stanriders/status-icon
...
Update status icon design
2023-01-14 21:05:44 +09:00
Dean Herbert
cfc8fd0aa1
Merge pull request #22188 from Feodor0090/nofs-locale
...
Localise some notifications
2023-01-14 18:12:54 +09:00
StanR
e07c0c7c1f
Using
2023-01-14 02:58:18 +03:00
ansel
bb8bcd7248
Move avatar update bind to LoadComplete
2023-01-14 02:50:30 +03:00
ansel
c95d8645f3
Revert "Use existing string"
...
This reverts commit f950b624ae
2023-01-14 02:42:04 +03:00
ansel
9e7ecbf4a1
Adapt to changes in base class
2023-01-14 02:41:11 +03:00
ansel
e9995410e8
Merge branch 'master' into comment-editor-3
2023-01-14 02:32:06 +03:00
StanR
cb4f32e7bd
Use StatusIcon in UserDropdown
2023-01-14 02:31:27 +03:00
StanR
e2d6e31314
Using
2023-01-14 02:26:26 +03:00
StanR
660bf748d5
Fix GroupBadge crashing on null group colour
2023-01-14 02:23:08 +03:00
Bartłomiej Dach
ab3d39a940
Merge branch 'master' into comment-editor-1
2023-01-13 22:41:41 +01:00
ansel
f950b624ae
Use existing string
2023-01-14 00:26:35 +03:00
Joseph Madamba
5750d82c0a
Move overlay ruleset selectors to tab control
2023-01-13 12:50:35 -08:00
ansel
c62d416680
Add localisation for notification overlay
2023-01-13 22:54:38 +03:00
Dean Herbert
11f630d49d
Prefill username and email
2023-01-13 15:42:34 +09:00
Dean Herbert
4d58e6d8d2
Add UI support for redirecting the user to web registration
2023-01-13 15:36:45 +09:00
Dean Herbert
6daa37bd3e
Merge pull request #22168 from Joehuu/fix-mute-button-closing-overlays
...
Fix mute button not blocking outside overlay closing presses
2023-01-13 12:35:03 +09:00
Joseph Madamba
5a38abe679
Add comment highlighting reason for blocking mouse down
2023-01-12 19:32:53 -08:00
Dean Herbert
55f1c7c49d
Merge pull request #22160 from EVAST9919/ruleset-selector-online
...
Don't display custom rulesets in online overlays
2023-01-13 12:16:42 +09:00
Dean Herbert
464c5eaa2f
Fix grammar
2023-01-13 12:16:35 +09:00
ansel
c554a34eaf
Add "fps" keyword to frame limiter dropdown
2023-01-13 02:11:05 +03:00
Joseph Madamba
a16050534d
Fix mute button not blocking outside overlay closing presses
2023-01-12 14:20:16 -08:00
Andrei Zavatski
d74a5ef9e6
Use property instead of ctor parameter
2023-01-12 23:26:29 +03:00
Andrei Zavatski
a7ac31fa34
Use IsLegacyRuleset extension method
2023-01-12 23:21:33 +03:00
Andrei Zavatski
1dae1149cb
Don't display non-legacy rulesets in beatmap listing
2023-01-12 22:52:45 +03:00
Andrei Zavatski
a9915d6a64
Make OverlayRulesetSelector display only legacy rulesets
2023-01-12 22:44:41 +03:00
ansel
0bd1c46c74
Undo sizing changes
2023-01-12 19:48:11 +03:00
Dean Herbert
7cf58190a9
Merge pull request #22006 from bdach/user-profile/ruleset-switching
...
Add ruleset switching to user profile overlay
2023-01-12 13:54:13 +09:00
Joseph Madamba
2076f9fd08
Fix lookup type being incorrect when fetching beatmap set
2023-01-11 19:08:11 -08:00
Bartłomiej Dach
52eabbf224
Merge branch 'master' into user-profile/ruleset-switching
2023-01-11 19:11:40 +01:00
Dean Herbert
08ca62205a
Merge pull request #22123 from stanriders/group-badges
...
Implement user group badges
2023-01-11 18:42:50 +09:00
Dean Herbert
2dcc61caf5
Add extra level of nullabiliy checking because NRT is not present
2023-01-11 17:38:08 +09:00
Dean Herbert
3b55153609
Merge pull request #22122 from Stedoss/beatmapsetoverlay-fetch-on-login
...
Fix `BeatmapSetOverlay` not showing a pending request after logging in
2023-01-11 16:51:52 +09:00
Dean Herbert
b1a13286a3
Remove some redundancies
2023-01-11 16:50:37 +09:00
Dean Herbert
318867f486
Fix previous badges potentially not being cleared if new user has no badges
2023-01-11 16:48:47 +09:00
Dean Herbert
e0d58d51b6
Split out classes into own files and rename GroupInfoContainer to a flow
2023-01-11 16:47:29 +09:00
Dean Herbert
b710f86d75
Refactor to use tuples and de-duplicate request code
2023-01-11 16:15:28 +09:00
StanR
5441c02a1a
Implement user group badges
2023-01-11 07:11:38 +03:00
Stedoss
44de24f153
BeatmapSetOverlay fetch on login state change
2023-01-10 23:30:09 +00:00
ansel
b38cf8c56c
Use empty string as default
2023-01-11 02:26:25 +03:00
Bartłomiej Dach
62e12277d8
Rename things yet again
2023-01-10 19:30:01 +01:00
Bartłomiej Dach
502478614a
Merge branch 'master' into user-profile/decouple-from-api-user
2023-01-10 19:13:33 +01:00
Dean Herbert
23a78e6fad
Combine commit button enabled handling
2023-01-10 23:59:17 +09:00
ansel
23e4cfb469
Show spinner next to buttons and get rid of EditorCommitButton
2023-01-09 23:37:36 +03:00
Salman Ahmed
dbc19777e0
Move stable import buttons under "debug" section
2023-01-09 21:22:21 +03:00
Bartłomiej Dach
6027e7cc4e
Fix one more missed related symbol
2023-01-09 18:22:49 +01:00
Bartłomiej Dach
0026861bd4
Merge branch 'master' into user-profile/decouple-from-api-user
2023-01-09 17:47:59 +01:00
Bartłomiej Dach
4dec3cae57
Rename UserProfileData-related symbols
2023-01-09 17:46:08 +01:00
Bartłomiej Dach
fdf0d4bd62
Rename UserProfile{ -> Data}
2023-01-09 17:37:28 +01:00
Endrik Tombak
44e9fb638c
Merge branch 'master' of https://github.com/ppy/osu into songs-folder-check
2023-01-09 14:53:40 +02:00
Endrik Tombak
f5c8ba420c
Revert message change
2023-01-09 14:53:16 +02:00
Dean Herbert
07dae7dc21
Merge branch 'master' into overlay-panels-context-menu
2023-01-09 19:04:56 +09:00
Endrik Tombak
15eebd1f50
Only show message about Songs folder
2023-01-09 11:47:13 +02:00
Dean Herbert
13b00928c8
Rename loading spinner bool to reflect that it has a setter
2023-01-09 15:52:18 +09:00
Dean Herbert
d2f4ffcc5b
Merge branch 'master' into comment-editor-1
2023-01-09 15:52:17 +09:00
Joseph Madamba
f6b1dfc7b0
Fix channel listing items overflowing at high ui scaling
2023-01-08 13:27:10 -08:00
Joseph Madamba
0f6735564e
Move and rename nomination response model to singular
2023-01-07 10:54:48 -08:00
ansel
927773d565
Display submitted comments locally
2023-01-07 04:15:43 +03:00
ansel
32e90829e3
Integrate comment editor into container
2023-01-07 02:59:24 +03:00
ansel
387326db0d
Make commit action abstract
2023-01-06 22:51:57 +03:00
Joseph Madamba
7f970f3cd8
Display nominators on beatmap set overlay
2023-01-06 11:33:39 -08:00
Salman Ahmed
3862184f9c
Merge branch 'master' into improve-filter-tab-item-ux
2023-01-06 15:37:21 +03:00
Salman Ahmed
0ade4d92d1
Fix multiple highlighting issues with beatmap listing tab items
2023-01-06 15:13:31 +03:00
Salman Ahmed
3d053ac758
Merge branch 'master' into filter-tab-item-bold
2023-01-06 15:11:57 +03:00
Dean Herbert
0ab1418aa6
Merge pull request #22034 from frenzibyte/fix-toolbox-group-animation
...
Fix settings toolbox group not animating on expansion
2023-01-06 19:59:31 +08:00
Dean Herbert
4319937bc7
Also add an underline to better accent current filters
2023-01-06 20:36:10 +09:00
Dean Herbert
3c74d27deb
Also add an underline to better accent current filters
2023-01-06 20:35:58 +09:00
Dean Herbert
458fe382ed
Make selected tab items more bold
2023-01-06 20:06:41 +09:00
Dean Herbert
464f251c0c
Merge branch 'master' into beatmap-set-link-genre-language
2023-01-06 17:09:06 +08:00
Salman Ahmed
7d8aff8f7e
Fix settings toolbox group not animating on expansion
2023-01-05 14:35:57 +03:00
Bartłomiej Dach
a124c967df
Add proper offline & loading state handling to user profile overlay
2023-01-02 17:23:09 +01:00
Bartłomiej Dach
c759b743dc
Add support for switching rulesets on profile overlay
2023-01-02 17:23:06 +01:00
Bartłomiej Dach
a2e726502f
Add ruleset selector to profile overlay
2023-01-02 17:23:04 +01:00
Bartłomiej Dach
7683ab68b0
Use UserProfile in profile ruleset selector
2023-01-02 17:23:01 +01:00
Bartłomiej Dach
1722f3a125
Add ruleset to UserProfile
2023-01-02 17:22:55 +01:00
Bartłomiej Dach
4dd7727f71
Remove test-specific workaround in overlay
2023-01-02 17:21:14 +01:00
Bartłomiej Dach
d7294ac3e6
Substitute APIUser for UserProfile in overlay
2023-01-02 17:21:09 +01:00
Bartłomiej Dach
608d8ee7d4
Add UserProfile model to be used in user profile overlay
...
As `APIUser` implements `IEquatable`, attempting to replace an `APIUser`
with another `APIUser` with the same online ID has no effect on the user
profile overlay. This is a significant hurdle in implementing support
for viewing the profile for different rulesets, as in that case the
profile is basically reloaded for the same user, but slightly different
data.
To facilitate this, wrap `APIUser` in a new `UserProfile` class. This
will mean that the equality rules can be changed locally to the user
profile overlay without impacting other components that depend on the
`APIUser` equality rules. The ruleset that the user profile is being
displayed with will eventually be added to `UserProfile`, too.
2023-01-02 17:21:00 +01:00
Bartłomiej Dach
88e90d5fa0
Enable NRT in user profile overlay
2023-01-01 23:49:11 +01:00
Bartłomiej Dach
2698d58c46
Merge branch 'master' into remember-chat-textbox-per-channel
2023-01-01 17:29:38 +01:00
Dean Herbert
9a4f0cad2c
Fix incorrect domain root being used for recent activity entries on profile overlay
...
Closes https://github.com/ppy/osu/issues/21980 .
2023-01-01 17:48:05 +08:00
Dean Herbert
87250ad847
Add search keywords for beatmap colours / hitsound overrides
2023-01-01 14:32:28 +08:00
Bartłomiej Dach
0d70f2c0fd
Use alternative workaround
2022-12-30 09:08:17 +01:00
Bartłomiej Dach
f625c5d744
Fix gradient showing when toggling toolbar with mouse above window
2022-12-29 23:35:45 +01:00
Bartłomiej Dach
bf975eb48a
Fix toolbar gradient not showing when mouse is hovered over buttons
2022-12-29 23:03:53 +01:00
Dean Herbert
ccf713c885
Fix incorrect hard link validity check in stable import screen
2022-12-29 23:18:12 +08:00
Dean Herbert
f9f6918fc3
Merge branch 'master' into add_linux_hardlink
2022-12-29 21:29:57 +08:00
Bartłomiej Dach
c5f7da9a4e
Fix hover propagating through toolbar buttons
...
Closes #21920 .
Weirdly enough this was semeingly fixed once before in ancient times in
3891f467a3566e09083f#9447 .
2022-12-29 13:19:14 +01:00
Joseph Madamba
c326745f96
Save / sync chat text box messages per channel
2022-12-28 16:09:40 -08:00
Joseph Madamba
b40d114e76
Remove context menu from news card for now
2022-12-28 15:00:57 -08:00
Bartłomiej Dach
10c11e974d
Fix broken spacing
2022-12-28 22:24:21 +01:00
Bartłomiej Dach
49b0ec9ddb
Fix broken condition
2022-12-28 22:24:18 +01:00
Bartłomiej Dach
d4b3965967
Change warning message about file duplication
...
- It was being glued in an ugly way that would have prevented sanely
localising it.
- Even on Linux, the filesystem (whichever one the user has chosen out
of the multitude available) still needs to support hard links for them
to have a chance of working.
2022-12-28 22:04:08 +01:00
BlauFx
d63be3ff17
Change name of variable
2022-12-28 15:02:44 +01:00
BlauFx
f32564652b
Mention the filesystem should be NTFS on Windows
2022-12-28 14:33:38 +01:00
Feodor0090
930cd15649
Merge branch 'master' into comment-editor-1
2022-12-28 17:46:01 +05:00
BlauFx
b2aa2e1602
Add hardlink support for Linux
2022-12-28 13:32:49 +01:00
Salman Ahmed
b4c5e18da0
Add keywords to ease search of "first object visibility" setting
2022-12-28 13:23:50 +03:00
Dean Herbert
61029b126d
Add link to hard link explanation wiki page
2022-12-27 17:56:23 +08:00
Joseph Madamba
bb58976838
Merge remote-tracking branch 'upstream/master' into overlay-panels-context-menu
2022-12-26 17:54:15 -08:00
Joseph Madamba
8bc8b0d0af
Remove redundant context menu container
2022-12-26 15:38:07 -08:00
Joseph Madamba
84e3858a86
Move context menu / popover container one level to account for header
2022-12-26 15:37:46 -08:00
Berkan Diler
c7ca4bbba5
Use generic Enum methods
2022-12-26 20:36:39 +01:00
Salman Ahmed
ee77b8cad3
Merge branch 'master' into fix-parameters-inspection
2022-12-26 05:17:40 +03:00
Joseph Madamba
973fd90af2
Fix parameters with the same default value inspection
2022-12-25 16:15:02 -08:00
Joseph Madamba
f959b02dc8
Use empty drawables for spacing badges instead
2022-12-25 16:05:59 -08:00
Joseph Madamba
b9dfb8b602
Add localisation for context menu strings
2022-12-25 10:12:02 -08:00
Joseph Madamba
2c2f347e25
Add context menus to overlay panels/cards
2022-12-25 09:57:42 -08:00
Joseph Madamba
b871d6f078
Remove unused fields
2022-12-24 13:35:17 -08:00
Joseph Madamba
ae967e08b0
Add badges when needed instead of using alpha
2022-12-24 13:27:46 -08:00
Joseph Madamba
4f6b3644f3
Fix title/artist overflowing to right side
2022-12-24 12:40:32 -08:00
Joseph Madamba
df645ef3cb
Change title/artist idle colour to white
2022-12-24 11:42:05 -08:00
Joseph Madamba
9d073f4228
Link beatmap set title and artist to listing search
2022-12-24 11:26:09 -08:00
Bartłomiej Dach
301eb71e22
Fix wrong member names
2022-12-24 10:39:05 +01:00
Dean Herbert
2c060ac8d4
Add localisation support for new button's strings
2022-12-24 17:32:04 +08:00
Dean Herbert
91bde14fb3
Add button to settings to show lazer upgrade guide
2022-12-24 15:42:24 +08:00
Joseph Madamba
2dbcf05fe4
Use enum values as ids in fallback instead
2022-12-23 11:13:27 -08:00
Joseph Madamba
494886ef92
Rename Text to Metadata
2022-12-23 11:11:15 -08:00
Bartłomiej Dach
9a2cc04361
Fix wrong path being used in fail handler
2022-12-23 16:44:03 +01:00
Dean Herbert
a677c8be06
Change path on error
2022-12-23 21:17:42 +08:00
Dean Herbert
5eccafe190
Fix wiki overlay showing error message when load is cancelled
2022-12-23 16:45:40 +08:00
Berkan Diler
08d2fbeb8e
Use new ArgumentNullException.ThrowIfNull throw-helper API
2022-12-22 21:27:59 +01:00
Salman Ahmed
28fc2f34b5
Merge branch 'master' into restore-default-button-hit-area
2022-12-22 13:32:57 +03:00
Joseph Madamba
e1e6d76f30
Check id for genre/language instead and fallback to name if not defined
2022-12-21 11:02:04 -08:00
Bartłomiej Dach
3ec31a5f51
Fix language selector in first run dialog not updating after changing language in settings
2022-12-21 19:30:21 +01:00
Joseph Madamba
1d39e8d0ce
Refactor MetadataSection to use generics and inheritance
2022-12-21 10:18:47 -08:00
Dean Herbert
19f66c806e
Fix language dropdown in settings not updating after changing language in first run dialog
...
Closes #21744 .
2022-12-21 16:31:55 +08:00
Bartłomiej Dach
cebd5f6dc2
Fix restore default button having a minuscule hit area
...
Another casualty of edc78205d5
2022-12-20 20:47:58 +01:00
Bartłomiej Dach
378486cbe0
Merge branch 'master' into argon-pro-skin
2022-12-20 19:34:56 +01:00
Bartłomiej Dach
bf074adb13
Remove unused using directive
2022-12-20 18:24:26 +01:00
Bartłomiej Dach
8ead606065
Merge branch 'master' into ui-scale-only-show-one-screen
2022-12-20 18:23:37 +01:00
cdwcgt
ffa32307c3
abstract ReportPopover
2022-12-21 01:37:16 +09:00
cdwcgt
b37f1cce3f
Added ability to report chat
2022-12-20 23:46:05 +09:00
Dean Herbert
2f0c772dcb
Add argon pro skin
2022-12-20 21:18:51 +09:00
wiskerz76
439b8ac56a
Fix file select popup getting stuck when switching first run screens while selecting
...
Closes #21663
Supersedes #21724
2022-12-20 17:59:23 +09:00
Dean Herbert
c119d41a2d
Only show song select for now at ui scale adjust first run screen
...
Having both was a bit too much. Still not happy with this but it's a bit
less sensory overload.
I think while it's cool being able to show nested screens like this, it
needs more thought to actually be a good experience.
2022-12-20 17:52:56 +09:00
Joseph Madamba
01f09529a8
Link beatmap set genre and language to listing filters
2022-12-19 22:54:33 -08:00
Bartłomiej Dach
64a45aa0e0
Merge branch 'master' into wiki-heading-id-attributes
2022-12-20 06:34:47 +01:00
Bartłomiej Dach
7c282d9def
Enable generic attribute support for wiki markdown containers
2022-12-19 21:32:38 +01:00
Bartłomiej Dach
db1380a346
Refactor markdown extension management
2022-12-19 20:19:51 +01:00
Bartłomiej Dach
186ccc64fd
Fix welcome screen language buttons not working
2022-12-19 18:19:26 +01:00
Dean Herbert
b64a5cbda6
Merge branch 'master' into guard-url-protocols
2022-12-19 15:46:45 +09:00
Joseph Madamba
6e62033bc4
Fix some comment actions not being lowercased
2022-12-18 20:20:15 -08:00
Dean Herbert
ba54551313
Merge branch 'master' into guard-url-protocols
2022-12-16 18:23:16 +09:00
Dean Herbert
27c497145f
Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0
2022-12-16 18:16:26 +09:00
Dan Balasescu
cbee72897a
Merge pull request #21654 from Susko3/use-localisable-strings-for-dates-and-times
...
Use `LocalisableString`s for date and time formats
2022-12-16 16:17:14 +09:00
Dean Herbert
232f590ba3
Merge pull request #21628 from peppy/go-hard-file-writes
...
Use hard links on windows when importing beatmaps from a legacy osu! install
2022-12-16 14:52:57 +09:00
Susko3
0f34d908c7
Use LocalisableStrings for date and time formats
2022-12-16 00:05:47 +01:00
Dean Herbert
9813bc9544
Reword disclaimer and fix translation keys
2022-12-15 22:46:31 +09:00
cdwcgt
6ef5b2733f
Export instead of ExportCurrentSkin
2022-12-15 21:41:15 +09:00
Dean Herbert
d2b98b803d
Turn on featured artist filter by default and add disclaimer when toggling for the first time
2022-12-15 18:42:47 +09:00
Dean Herbert
0763b86236
Add more padding around text in dialog popups
2022-12-15 17:32:27 +09:00
Dean Herbert
78bc94d3cb
Set featured artists filter to enabled by default
2022-12-15 16:57:39 +09:00
Dean Herbert
a7f3e13946
Fix MultipleSelectionFilter not correctly handling initial selection
2022-12-15 16:56:09 +09:00
Dean Herbert
f4316a9827
Fix incorrect grammar in hard link explanation text
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-12-14 11:30:01 +09:00
Dean Herbert
b8904fe747
Move ImportParameters to better home
2022-12-13 21:41:26 +09:00
Dean Herbert
cb16d62700
Hook up ImportParameter flow with IModelImporter caller methods
2022-12-13 21:29:32 +09:00
Andrei Zavatski
15bd82add8
Fix DrawableUsername being affected
2022-12-12 18:24:49 +03:00
Dean Herbert
02b3bbf0d3
Merge pull request #21616 from Joehuu/changelog-build-masking
...
Fix changelog single build dates disappearing before being off screen
2022-12-12 18:28:48 +09:00
Dean Herbert
05b5949810
Use explicit casts
2022-12-12 17:38:39 +09:00
Dean Herbert
e2d8909e73
Add link to change folder location if it isn't on the same drive as import path
2022-12-12 13:44:09 +09:00
Dean Herbert
726943cb14
Add information attempting to explain hard links to the end user
2022-12-12 13:44:09 +09:00
Dean Herbert
d8de99bbe4
Check for hard link support in first run overlay
2022-12-12 13:44:09 +09:00
Dean Herbert
731184eb39
Revert "Merge pull request #21614 from EVAST9919/button-fix"
...
This reverts commit 4bd196684fa1d22ef77a
2022-12-12 13:43:01 +09:00
Joseph Madamba
e76c56b03b
Fix changelog single build dates disappearing before being off screen
2022-12-11 20:10:06 -08:00
Andrei Zavatski
1332568796
Fix SettingsButton receiving input at padded area
2022-12-12 03:10:13 +03:00
cdwcgt
e02b8cb199
Group export methods into their respective managers
2022-12-11 18:30:24 +09:00
cdwcgt
a1fc33668c
Merge branch 'master' into export
2022-12-09 23:40:26 +09:00
Bartłomiej Dach
5857471915
Merge branch 'master' into nominated-ranked-beatmaps
2022-12-07 23:54:25 +01:00
Dean Herbert
62b0436bcf
Reverse depth of profile sections to allow for overflowing expanded beatmap cards
...
Closes #21554 .
2022-12-07 16:38:17 +09:00
Joseph Madamba
56e94e49a3
Display nominated ranked beatmaps in user profile
2022-12-06 23:36:11 -08:00
Dean Herbert
49f5ac57b8
Fix first run beatmap screen button colours looking incorrect with new triangle effect
...
Addresses #21500 .
2022-12-03 18:48:54 +09:00
ansel
1763618488
Fix spinner presense check & field click
2022-11-30 13:58:03 +03:00
ansel
43628903a7
Make spinner bigger
2022-11-30 13:57:09 +03:00
ansel
1cc7ffce39
Keep button's text
2022-11-30 13:40:47 +03:00
ansel
bedc771e99
Remove useless check
2022-11-30 13:32:01 +03:00
ansel
a8422961dc
Rename button spinner prop again
2022-11-30 13:30:57 +03:00
ansel
5ea824534b
Use default button
2022-11-30 13:25:59 +03:00
ansel
642e0ac718
Increase footer height to look better with default buttons
2022-11-30 13:25:18 +03:00
ansel
956acbc86f
Use fixed width
2022-11-30 13:11:54 +03:00
Dean Herbert
4a747182b4
Merge branch 'master' into comment-editor-1
2022-11-30 17:22:59 +09:00
Dean Herbert
f7b7b58718
Adjust colour and tween to feel better
2022-11-30 16:20:01 +09:00
Dean Herbert
24ee363563
Only hover when hovering actual text
2022-11-30 16:18:36 +09:00
Dean Herbert
80b0e4a99d
Rename Colour to avoid conflict with Drawable.Colour
2022-11-30 16:15:50 +09:00
Dean Herbert
7fca5ee28d
Move DrawableUsername into own file
...
It's too large at this point to be a nested class.
2022-11-30 16:15:50 +09:00
Dean Herbert
6524914dbd
Merge branch 'master' into chat-profile-highlight-v2
2022-11-30 16:00:52 +09:00
ansel
e30d97c94e
Comments
2022-11-29 14:39:59 +03:00
ansel
84aaf5fedf
Change ways to access submit button state
2022-11-29 14:37:35 +03:00
ansel
6c126f5223
Remove useless local actions on click
2022-11-29 14:25:51 +03:00
Dean Herbert
61c702c02e
Add new IDependencyInjectionCandidate interface to non-drawable cached classes
2022-11-29 14:45:26 +09:00
Bartłomiej Dach
8f78d6179b
Fix multiple issues with settings items unhiding on search
2022-11-29 14:41:49 +09:00
Bartłomiej Dach
24deb5f5f4
Remove all unnecessary usage of IHasFilterableChildren
2022-11-29 14:40:52 +09:00
ansel
16962d9a57
Localize deleted string
2022-11-29 07:02:02 +03:00
ansel
a4819e5c9c
Localize actions
2022-11-29 07:01:52 +03:00
ansel
472d9274b6
Reorder members
2022-11-29 06:23:25 +03:00
ansel
af0ee9dbd6
Make spinner a little bigger
2022-11-29 06:19:54 +03:00
ansel
894fb98fa2
Rebase CommitButton to RoundedButton
2022-11-29 06:17:02 +03:00
ansel
a874345da0
Rebase CancelButton to RoundedButton
2022-11-29 05:46:30 +03:00
ansel
d20dc3668e
Enable nullability
2022-11-29 05:17:44 +03:00
ansel
8b033bf9f7
Allow localisable strings
2022-11-29 05:13:54 +03:00
Alden Wu
8ec4dd046e
Fix InspectCode errors
2022-11-28 18:06:44 -08:00
Alden Wu
0cb7c94c21
Merge branch 'master' of https://github.com/ppy/osu into chat-profile-highlight-v2
2022-11-28 17:59:15 -08:00
Alden Wu
c2d8ffc225
Refactor ChatLine username drawable creation
2022-11-28 17:50:12 -08:00
Bartłomiej Dach
894ef15e79
Merge branch 'master' into update-framework
2022-11-26 16:19:36 +01:00
Dan Balasescu
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
Dean Herbert
2b2beadd06
Merge branch 'master' into update-framework
2022-11-25 01:00:08 +09:00
Dean Herbert
53b03df93d
Combine TriangleButton and RoundedButton classes
2022-11-24 16:26:57 +09:00
Dean Herbert
bea2acc60e
Remove local specifications of triangle colouring
2022-11-24 16:18:15 +09:00
Dean Herbert
40f706155f
Update RoundedButton to have new triangles design
2022-11-24 16:18:15 +09:00
Bartłomiej Dach
2f67199b1c
Merge branch 'master' into fix-missing-day-separator
2022-11-23 18:40:44 +01:00
Dean Herbert
b381b4fd2d
Merge branch 'master' into update-framework
2022-11-24 01:27:58 +09:00
Dean Herbert
5467097387
Fix adjacent day separators potentially being left behind after pending message resolution
2022-11-23 18:49:51 +09:00
Dean Herbert
172e798847
Merge pull request #21228 from Terochi/recent-messages-implementation
...
Add ability to view chat send history in input box
2022-11-23 14:58:42 +09:00
Bartłomiej Dach
76bb529cfa
Add test for local echo adding day separator
2022-11-22 16:46:21 +01:00
Alden Wu
a2b505f4c0
Use a direct Lighten instead of >1f Color4 values
2022-11-22 00:31:22 -08:00
Alden Wu
4084a2b066
Highlight ChatLine username on hover
2022-11-21 18:57:59 -08:00
Bartłomiej Dach
8dbe31a172
Merge branch 'master' into higher-aspect-ratio-max
2022-11-21 19:51:39 +01:00
cdwcgt
c509c5be40
impossible null
2022-11-21 19:45:30 +09:00
cdwcgt
e37d30a373
refactor based on reviews
...
removed LegacyExportManager
Separated the method of CreateZip method and the default export method
2022-11-21 18:58:01 +09:00
Dean Herbert
981264b011
Avoid crashing when a system audio device provides a null name
2022-11-21 14:51:41 +09:00
Dean Herbert
e53b4321ff
Ensure two day separators are not added in a row
2022-11-21 14:01:10 +09:00
Dean Herbert
fa7b45dfb1
Fix chat day separator not being added on pending message resolution
...
Closes #21316 .
2022-11-21 13:52:14 +09:00
Dean Herbert
c7ae837687
Increase maximum aspect ratio for tablet settings to 23:9 / 2.55
2022-11-21 12:45:54 +09:00
Dean Herbert
92aea22cd3
Merge pull request #21340 from vegguid/MetadataLanguage-FirstSetup
...
Added PreferOriginalMetadataLanguage to FirstRunSetup
2022-11-21 12:16:56 +09:00
vegguid
a431b793b9
Added PreferOriginalMetadataLanguage to FirstRunSetup
2022-11-20 23:18:19 +01:00
Bartłomiej Dach
0c671a2a82
Merge branch 'master' into fix-tablet-aspect-ratio-values
2022-11-19 14:32:24 +01:00
cdwcgt
4e457871f3
impossible null and remove storage
2022-11-19 01:03:22 +09:00
cdwcgt
4b29941b47
add LegacyExportManager
2022-11-18 20:00:00 +09:00
Dean Herbert
06ce8130c2
Apply changes in line with framework NRT updates
2022-11-18 18:13:15 +09:00
Dan Balasescu
e4fc14faee
Merge pull request #21270 from peppy/auto-advance-bindings
...
Auto-advance binding for ruleset key bindings
2022-11-18 16:19:54 +09:00
Dean Herbert
e658efbefa
Fix being able to bind two non-modifier keys to the same binding
2022-11-18 15:34:41 +09:00
Dan Balasescu
1b1fed723d
Merge pull request #21269 from peppy/fix-key-bindings-keyword
...
Move "keybindings" keyword to correct section
2022-11-18 14:05:08 +09:00
Dan Balasescu
551192b413
Refactor a bit for readability
2022-11-18 13:55:37 +09:00
Dan Balasescu
a776622ce0
Merge pull request #21284 from peppy/now-playing-overlay-texture-reduction
...
Fix `NowPlayingOverlay` loading background texture too early (and permanently)
2022-11-18 12:09:16 +09:00
Dan Balasescu
baa4fd56e2
Merge pull request #21279 from peppy/news-load-unload
...
Fix news post images never unloading from memory after first display
2022-11-18 11:56:13 +09:00
Dan Balasescu
13fe0d3491
Merge pull request #21278 from peppy/overlay-header-texture-reduction
...
Avoid loading overlay headers until first open
2022-11-18 11:53:46 +09:00
Dean Herbert
b53f9baf6a
Fix NowPlayingOverlay loading background texture too early (and permanently)
2022-11-18 11:21:12 +09:00
Dean Herbert
93c2280754
Fix supporter filters text not being set correctly
2022-11-18 10:35:05 +09:00
Dean Herbert
b37e9c0266
Fix news post images never unloading from memory after first display
2022-11-18 00:01:53 +09:00
Dean Herbert
73e4827d36
Avoid loading overlay headers until first open
...
Also switches them to use non-atlased target as they won't benefit much
from atlasing.
2022-11-17 23:55:43 +09:00
Dean Herbert
63c1855511
Avoid loading beatmap listing placeholders until required
2022-11-17 23:42:21 +09:00
Dean Herbert
a3e8cc1663
Mark beatmap listing placeholder textures as large
2022-11-17 23:41:35 +09:00
Terochi
3d4962e181
Added functioning tests.
2022-11-17 13:07:06 +01:00
Terochi
6d83af01e2
Moved and renamed MessageHistoryTextBox.cs for better fit.
2022-11-17 13:07:06 +01:00
Dragon
b9590320b7
Moved implementation to ChatRecentTextBox.cs and derived ChatTextBox.cs and StandAloneChatDisplay.cs from it.
2022-11-17 13:07:06 +01:00
Dragon
a1af663682
Implemented previous messages lookup in the ChatTextBox.cs
2022-11-17 13:07:06 +01:00
Dean Herbert
d1b2116400
Auto-advance binding for ruleset key bindings
2022-11-17 15:23:20 +09:00
Dean Herbert
bd2e0dc82b
Move "keybindings" keyword to correct section
...
Without this, things like tablet settings would show when searching for
bindings, even though these settings have nothing to do with key
bindings.
2022-11-17 15:09:42 +09:00
cdwcgt
e1a21e0cf9
create a task to export to avoid block main thread
...
Code quality and remove some #nullable disable
2022-11-17 01:08:06 +09:00
Dean Herbert
bb762d8131
Fix "reset to full area" button not always working correctly
2022-11-16 15:45:26 +09:00
Samaoo
4ff17cb4bd
remove unused using directive
2022-11-12 08:52:33 +01:00
Samaoo
7a860fb460
address reviews
2022-11-12 08:49:03 +01:00
Samaoo
268011be9e
use MathF
2022-11-11 17:56:50 +01:00
Samaoo
173f557376
fix tablet aspect ratio values
2022-11-11 17:14:34 +01:00
Dan Balasescu
db25e9e9c8
Merge branch 'master' into combo-colour-brightness-limit
2022-11-11 15:31:28 +09:00
Susko3
5b1e39abd5
Fix parsing of Language when using default system locale
2022-11-10 22:56:24 +01:00
Samaoo
be81c658af
move tablet area calculations to functions
2022-11-09 20:14:01 +01:00
Samaoo
533a2db5ea
fix inaccurate tablet area dimensions when applying aspect ratio
2022-11-09 18:48:47 +01:00
Joseph Madamba
76df61504f
Remove unnecessary timestamp update
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2022-11-06 19:45:59 -08:00
Joseph Madamba
61ec0ba566
Make chat line timestamp adjust to 24-hour time setting
2022-11-06 19:28:01 -08:00
Joseph Madamba
b977fc8181
Use autosize instead of max width on fixed width timestamps
2022-11-06 19:28:01 -08:00
Dean Herbert
ee68f33e3c
Merge pull request #21109 from frenzibyte/fix-beatmap-duplicating-again
...
Fix beatmap cards still potentially showing twice in listing
2022-11-06 18:46:31 +09:00
Bartłomiej Dach
84179fb087
Merge branch 'master' into combo-colour-brightness-limit
2022-11-05 16:48:56 +01:00
Salman Ahmed
ee6f036c44
Add note about using ExceptBy once it's available
2022-11-04 19:35:24 +03:00
Salman Ahmed
ce5aacb760
Filter out duplicated cards using custom equality comparer instead
2022-11-04 19:27:35 +03:00
Joseph Madamba
e11d44d14f
Add url clicking support to profile badges
2022-11-03 18:12:32 -07:00
Dean Herbert
f6c376c090
Minor refactoring
2022-11-03 20:29:27 +09:00
Dean Herbert
1edde8f73c
Merge branch 'master' into disabled-button-sfx
2022-11-03 20:27:41 +09:00
Jamie Taylor
59bbd9c460
Fix some components using wrong sample set
2022-11-03 17:47:49 +09:00
Jamie Taylor
f1c17129eb
Add support for 'disabled' sample variation to HoverClickSounds
2022-11-03 17:47:49 +09:00
Dean Herbert
56ef519cc2
Move PopoverContainer into OnlineOverlay to ensure correct colours
2022-11-03 15:43:06 +09:00
Dean Herbert
e6c45b8ab5
Merge branch 'master' into comment-report
2022-11-03 15:35:42 +09:00
Dean Herbert
3ec9686e58
Fix test failures and rename configuration value to match better
2022-11-02 18:15:18 +09:00
Dan Balasescu
db34f238c0
Fix inverted condition
2022-11-02 15:47:30 +09:00
Dan Balasescu
e5f53b1ad8
Use Interlocked.Exhange() instead
...
Increment isn't correct since it returns the post-incremented value. It
also always increments.
2022-11-02 15:18:48 +09:00
Dean Herbert
e761c0395d
Fix multiple notifications arriving for imports in edge cases
2022-11-02 14:47:56 +09:00
Dean Herbert
50b6fe4acb
Localise new label
2022-11-02 14:01:03 +09:00
Dean Herbert
99ba7c29dd
Change range to 0-100% and rename to "normalisation"
2022-11-02 13:47:11 +09:00
Dean Herbert
2f3c80f884
Remove toggle and change method of application to blend with original colour
2022-11-02 13:08:29 +09:00
Dean Herbert
27af91003b
Merge branch 'master' into combo-colour-brightness-limit
2022-11-01 17:50:26 +09:00
Joseph Madamba
d56786b5ff
Fix toolbar visual bug when toggling clock displays
2022-10-29 15:25:16 -07:00
ansel
9df96aab38
Remove local popover containers
2022-10-28 22:17:45 +03:00
Dean Herbert
f46a9d683a
Fix null reference in headless tests
2022-10-28 18:07:25 +09:00
Dean Herbert
f9d2c30c3e
Add user toggle for application of safe areas
2022-10-28 14:05:45 +09:00
Dean Herbert
14c7cbde38
Fix toggle mute (and volume meter traversal) handling repeat key presses
...
Closes #20953 .
2022-10-27 11:41:00 +09:00
Joseph Madamba
8505848b1a
Scroll beatmap listing to top when searching via tags/source
2022-10-25 18:06:49 -07:00
Salman Ahmed
b0a4cd4f30
Inline content creation in base add method
2022-10-22 03:43:14 +03:00
Salman Ahmed
6c82bc36ed
Encapsulate report logic inside button implementation
...
Avoids complicating the `DrawableComment` class, and allows for isolated
testability.
2022-10-22 02:48:27 +03:00
Salman Ahmed
9b5e35d599
Remove dependency on DrawableComment from report popover and simplify logic
...
Allows for testing the button and popover in isolation.
2022-10-22 02:47:33 +03:00
Salman Ahmed
081cf1cc47
Adjust comment report popover design
2022-10-22 02:45:31 +03:00
ansel
15aeb4a137
Display text in buttons flow instead of toast
2022-10-21 17:25:41 +03:00
Dean Herbert
447d420c99
Fix adjusting volume via settings playing tick samples twice
2022-10-21 21:03:39 +09:00
Jamie Taylor
7b1edff2b3
Add unique hover/select samples to settings sidebar buttons
2022-10-21 18:06:38 +09:00
ansel
81bdf716ef
Change test
2022-10-20 19:56:00 +03:00
ansel
0ef903230c
Make report button a separate component
2022-10-20 18:47:42 +03:00
ansel
da4f04ace7
Make dropdown not resize
2022-10-20 18:22:55 +03:00
ansel
635900085c
Disable button when there is no text
2022-10-20 18:12:20 +03:00
ansel
ed39481932
Use another string for title
2022-10-20 18:11:35 +03:00
ansel
57320074a0
Fix accidental breakage of changelog layout
2022-10-20 01:24:36 +03:00
Dean Herbert
6b42f1931a
Remove autosize easing in SettingsToolboxGroup
...
It just feels like unnecessary motion.
2022-10-18 15:01:26 +09:00
ansel
3258a41ca3
Merge branch 'comment-report' of https://github.com/Feodor0090/osu into comment-report
2022-10-17 20:41:46 +03:00
ansel
cd77ae062e
Localize the button
2022-10-17 20:41:23 +03:00
ansel
797acf334f
Show username in popup
2022-10-17 20:41:13 +03:00
Feodor0090
6efe7b5334
Merge branch 'master' into comment-report
2022-10-17 16:08:13 +03:00
ansel
ceb4d624b5
Delete wip form
2022-10-17 13:43:35 +03:00
ansel
ffa22d8a68
Update popover not to use labelled drawables
2022-10-17 13:42:17 +03:00
ansel
d7e5bcbd3c
Add popover containers to overlays
2022-10-17 13:41:46 +03:00
ansel
7ed26369a3
Make a new report form, closer to web
2022-10-17 12:41:57 +03:00
Bartłomiej Dach
d0a495717e
Merge branch 'master' into comment-copy-link
2022-10-16 19:56:06 +02:00
ansel
4a8d976cb4
Use api's endpoint
2022-10-16 20:20:34 +03:00
ansel
ba595ab8fa
Display toast instead of notification
2022-10-16 19:57:21 +03:00
ansel
9822a092c4
Add localization for enum
2022-10-16 19:50:55 +03:00
Aki
91358f4a6a
Implement tablet button bindings
2022-10-15 15:16:14 +08:00
Feodor0090
fb046e31c1
Merge branch 'master' into comment-report
2022-10-14 16:57:23 +03:00
ansel
dc0aa2295a
Add test
2022-10-14 16:51:48 +03:00
ansel
3e9fd4c08c
Implement reporting flow
2022-10-14 16:26:25 +03:00
ansel
c65a8a83f3
Add basic UI for reporting
2022-10-14 15:52:09 +03:00
Dean Herbert
32c3e35762
Change background colour to a lighter tint to avoid clash with slider bars
2022-10-14 19:38:27 +09:00
Dean Herbert
2404bb42b9
Use 10% alpha rather than 0% when toolbox is not hovered
2022-10-14 19:33:49 +09:00
Dan Balasescu
8a88339e78
Allow combo colour normalisation to be disabled
2022-10-14 14:37:24 +09:00
ansel
8a47628fe1
Use spacer drawable instead of spacing on links container
2022-10-14 00:04:13 +03:00
ansel
295e6f5a68
Move toast to it's namespace
2022-10-13 23:57:25 +03:00
ansel
34ff072a9b
Change text
2022-10-13 22:47:48 +03:00
ansel
a0cca391f6
Add copy link button to comments
2022-10-13 22:18:26 +03:00
Dean Herbert
a93c350ca8
Start settings panels without background visible
2022-10-13 17:11:56 +09:00
Dean Herbert
6608ada925
Fix test failures due to missing colour provider dependency
2022-10-13 17:05:11 +09:00
Dean Herbert
0f4a2a6059
Improve feel of settings toolbox group
2022-10-13 16:36:19 +09:00
Dan Balasescu
4149235e63
Limit minimum brightness of combo colours
2022-10-13 14:05:33 +09:00
Dean Herbert
e43c8e84b0
Use Show instead of Alpha=1
2022-10-12 15:48:42 +09:00
Dean Herbert
47fe4eb0bd
Merge branch 'master' into comment-deletion
2022-10-12 15:48:26 +09:00
Dean Herbert
195ece02c6
Merge branch 'master' into update-displays-in-setting
2022-10-12 14:37:49 +09:00
Daniel Källberg
63e651130a
Grouped localisation strings
2022-10-11 10:59:07 +02:00
Daniel Källberg
9c611019b3
Toolbar localisation
2022-10-11 09:30:32 +02:00
Dean Herbert
6f6290a21a
Use async flow for storing key binding changes to realm
2022-10-11 15:37:22 +09:00
Salman Ahmed
a9aba74351
Add markdown country flag support
2022-10-08 21:50:25 +03:00
ansel
c384093802
Update main test and add failure scenario test
2022-10-08 18:53:41 +03:00
ansel
b697200460
Properly modify comment visual state on deletion
2022-10-08 18:41:08 +03:00
ansel
4e7c30504f
Schedule action buttons visibility changes
2022-10-08 17:15:10 +03:00
ansel
abf56c27a1
Do not requere dialog overlay
2022-10-08 17:11:09 +03:00
Joseph Madamba
b27e70ca47
Fix language settings dropdown not updating when changing language in first run setup
2022-10-06 21:11:00 -07:00
Dean Herbert
e9ab465da6
Merge branch 'master' into localisation-settings
2022-10-06 13:22:08 +09:00
Dean Herbert
4f084664ac
Merge branch 'master' into comment-deletion
2022-10-05 14:34:50 +09:00
Dean Herbert
75b9bf2cf9
Merge branch 'master' into intel-exclusive-warning
2022-10-04 19:02:01 +09:00
Susko3
efc9bed4f0
Use IWindow.DisplaysChanged to update displays
2022-10-03 23:52:04 +02:00
Susko3
31fefc1ee2
Add nullable annotation to LayoutSettings
2022-10-03 23:23:02 +02:00
Susko3
e98b4b4fbd
Make updateDisplayModeDropdowns regular method
2022-10-03 23:14:21 +02:00
ansel
85adfc2df7
Fix DI type
2022-09-28 18:26:36 +03:00
ansel
636befb499
Add visual feedback for deleting process
2022-09-28 17:49:37 +03:00
ansel
ae0d62838b
Move API and DO to fields
2022-09-27 22:46:23 +03:00
ansel
58d9509ce6
Apply NRT to Comment
2022-09-27 22:45:05 +03:00
ansel
60ee813e45
Implement delete button
2022-09-27 18:33:16 +03:00
ansel
31a7ba3f91
Add delete button
2022-09-27 18:23:15 +03:00
Dan Balasescu
ec30050f2c
Merge pull request #20502 from peppy/forward-toasts-on-gameplay
...
Flush toast tray on entering gameplay
2022-09-27 18:35:54 +09:00
Dan Balasescu
5a28174448
Merge pull request #20488 from nanashi-1/toggle-score-overlay
...
Add toggle for solo gameplay leaderboard
2022-09-27 18:09:55 +09:00
Dean Herbert
461ba64bfa
Flush toast tray on entering a no-notification section
2022-09-27 17:32:53 +09:00
Dean Herbert
c61f5403ab
Increase delay back slightly on notifications posting after disabled period
2022-09-27 17:32:30 +09:00
Dean Herbert
bac3108aea
Remove unnecessary keywords
2022-09-27 14:29:59 +09:00
Dan Balasescu
aa3956cfbb
Merge pull request #20495 from Feodor0090/playlist-overflow-fix
...
Fix playlist overlay overflowing at high UI scales
2022-09-27 13:53:14 +09:00
nanashi-1
dc051a8b79
add gameplay leaderboard config
2022-09-26 20:08:58 +08:00
Dan Balasescu
e5894ccd6f
Merge pull request #20478 from peppy/fix-progress-notification-fling
...
Fix progress notifications being able to be flung (and cancelled)
2022-09-26 18:21:12 +09:00
Dan Balasescu
f2eed881bd
Merge pull request #20480 from peppy/fix-drawable-mutation-tablet-settings
...
Fix potential crash from incorrect drawable mutation in tablet settings display
2022-09-26 18:16:52 +09:00
Dan Balasescu
525de8c140
Merge pull request #20479 from peppy/fix-drawable-mutation-misc
...
Fix potential crash on game exit due to incorrect scheduling of realm change handler
2022-09-26 18:02:28 +09:00
Dean Herbert
4e9b25d8b0
Move MusicController binds to LoadComplete for added thread safety
2022-09-26 15:42:37 +09:00
Dean Herbert
43c16cb613
Fix potential crash from incorrect drawable mutation in tablet settings display
2022-09-26 15:10:02 +09:00
Dean Herbert
4bd96108c0
Fix crash on game exit due to incorrect scheduling of realm change handler
2022-09-26 14:45:17 +09:00
Dean Herbert
b6dd8168d2
Fix progress notifications being able to be flung
2022-09-26 14:33:12 +09:00
ansel
5d0b2d34c9
Make playlist to always be in screen bounds
2022-09-24 23:35:06 +03:00
ansel
6c8e587344
Move margin value to constant
2022-09-24 21:52:16 +03:00
Dean Herbert
8a7526aaa3
Merge pull request #20344 from frenzibyte/better-tablet-notifications
...
Improve tablet error/warning notifications messaging
2022-09-22 22:45:27 +09:00
Dan Balasescu
6a0047b7a2
Update location of FullscreenCapability bindable
2022-09-22 21:01:23 +09:00
Dan Balasescu
70bab81282
Merge pull request #20377 from peppy/argon-skin
...
Add new default "argon" skin
2022-09-22 14:50:43 +09:00
Dan Balasescu
2b8b138079
Add "keybindings" search term to settings
2022-09-21 18:46:28 +09:00
Dean Herbert
4492a26b59
Merge branch 'master' into argon-skin
2022-09-21 13:00:16 +09:00
Dan Balasescu
8bf196d561
Merge pull request #20354 from peppy/default-skin-refactor
...
Rename default skin to make way for new version
2022-09-21 11:48:38 +09:00
Salman Ahmed
dcfb6a2f06
Fix progress notifications no longer blocking close on click
2022-09-21 00:15:50 +03:00
アズタケ
d22d009fb3
fix review points. items not included in this localization were reverted.
2022-09-20 14:02:11 +09:00
Dean Herbert
bd28c6f96d
Merge branch 'master' into localisation-settings
2022-09-19 23:37:26 +09:00
Dean Herbert
0f7b38f4c3
Add new default skin "argon"
2022-09-19 23:16:46 +09:00
Salman Ahmed
a413c7a3e6
Merge branch 'master' into fix-notification-count
2022-09-19 02:08:20 +03:00
Dean Herbert
41e69fbca6
Remove "default" prefix from naming
2022-09-18 00:15:26 +09:00
Dean Herbert
1c4e02fae8
Explicitly order default skins in dropdown to get correct order
2022-09-18 00:12:43 +09:00
Salman Ahmed
877165eb98
Allow specifying icon colour on simple notifications
2022-09-16 16:21:43 +03:00
アズタケ
81d582c051
fix review points and fine tuning
2022-09-16 21:08:25 +09:00
Dan Balasescu
e95983cdb4
Merge branch 'master' into fix-skin-flow
2022-09-16 20:15:51 +09:00
アズタケ
c0e2ba419e
Localize non-localizable setting items
2022-09-16 18:31:02 +09:00
Dean Herbert
38d8d457d9
Add back second completion post attempt for case when notification overlay isn't loaded yet
2022-09-16 17:54:44 +09:00
Dean Herbert
0d24fda4b9
Fire Notification.Closed immediately to ensure off-screen notifications are closed
2022-09-16 16:36:56 +09:00
Dan Balasescu
f86bbaae30
Merge branch 'master' into mods-effect-displays
2022-09-15 21:17:58 +09:00
Salman Ahmed
efebe55d22
Display certain sort criterias based on selected category and query
2022-09-15 04:30:09 +03:00
Salman Ahmed
de7dd29d79
Add "Nominations" and "Updated" sorting criteria in beatmap listing
2022-09-15 03:57:05 +03:00
Joseph Madamba
85e3a681b1
Fix notification overlay toast tray background absorbing input from behind
2022-09-13 21:07:30 -07:00
Dan Balasescu
ef6d60ffe9
Merge pull request #20273 from frenzibyte/duplicate-beatmap-listing-cards
...
Fix beatmap listing potentially showing duplicate beatmap cards
2022-09-14 10:25:24 +09:00
Salman Ahmed
04dbb6fc1b
Add inline comment
2022-09-14 00:49:02 +03:00
Dean Herbert
d368f37c3a
Remove redundant second Current set operation
2022-09-13 13:50:59 +09:00
Salman Ahmed
07f577a0c6
Fix beatmap listing potentially showing duplicate beatmap cards
2022-09-13 01:39:21 +03:00
ansel
8cbc0502ae
Inline CalculateEffect
2022-09-12 15:51:18 +03:00
Dean Herbert
88107108ee
Add ability to flick notifications to the right to store for later
2022-09-12 20:20:57 +09:00
Dean Herbert
802c5629c0
Merge branch 'master' into notification-fling
2022-09-12 20:09:21 +09:00
Dean Herbert
f31deaef7c
Simplify skin bindable flow
...
Now, nothing touches the configuration apart from `OsuGame`, making
everything else flow better and avoid weird cyclic set bugs.
Closes https://github.com/ppy/osu/issues/20234 .
2022-09-12 19:51:50 +09:00
Dan Balasescu
5bd0be14ed
Merge pull request #20259 from peppy/fix-changelog-crash
...
Fix potential crash when opening changelog overlay if entry has no URL
2022-09-12 19:47:21 +09:00
Dean Herbert
cb6d02ec3a
Merge pull request #19066 from andy840119/remove-the-nullable-disable-in-the-ruleset
...
Remove the nullable disable annotation in the ruleset class
2022-09-12 19:07:23 +09:00
Dean Herbert
d92e000fe6
Fix flinging a notification not correctly running Close
2022-09-12 19:00:03 +09:00
Dean Herbert
4ee3e8f087
Don't play fling animation when activating a notification
2022-09-12 18:57:18 +09:00
Dean Herbert
58c1ea0321
Fix potential crash when opening changelog overlay if entry has no URL
2022-09-12 17:51:15 +09:00
Dean Herbert
d561fcb126
Don't trigger fling animation when Close is triggered by non-user action
2022-09-12 16:54:25 +09:00
Dean Herbert
5a02e1e713
Use padding instead of FillFlow.Spacing to avoid artifact during animation
2022-09-12 16:46:45 +09:00
Dean Herbert
a506178571
Make bounding box shrink faster to allow for rapid flinging
2022-09-12 16:39:46 +09:00
Dan Balasescu
bcbc867694
Merge branch 'master' into mods-effect-displays
2022-09-12 16:35:28 +09:00
Dean Herbert
931049aec1
Merge branch 'master' into notification-dismiss
2022-09-12 16:27:41 +09:00
Dean Herbert
bd3673baa9
Fix being able to drag after already closing a notification
2022-09-12 16:25:32 +09:00
Dean Herbert
8e6b2796eb
Merge branch 'master' into notification-fling
2022-09-12 16:19:36 +09:00
Dean Herbert
2476cf8fb3
Adjust movement to look less sudden when snapping back to Y=0
2022-09-12 15:37:48 +09:00
Dean Herbert
e06a0f7300
Fix dragged state not being exposed correctly
2022-09-12 15:21:01 +09:00
Dean Herbert
92beb6cbe7
Hide notification read light when in a toast state
...
Also adds test coverage of read state and light.
2022-09-12 15:17:45 +09:00
Dean Herbert
60b0b909a5
Move update icon to background to avoid colour collission with progress spinner
2022-09-12 14:58:46 +09:00
Dean Herbert
9ef23c79ce
Disallow forwarding during a drag operation
2022-09-11 22:05:44 +09:00
Dean Herbert
a56cadcf90
Ensure drag position is reset when transferred to tray
2022-09-11 22:03:29 +09:00
Dean Herbert
b5a2f7003e
Disallow flinging when not in toast state
2022-09-11 21:47:45 +09:00
Dean Herbert
d6f90e3b9f
Add basic fling-to-dismiss support
2022-09-11 21:32:22 +09:00
ansel
324a3723a5
Rewrite DMD
2022-09-10 23:23:04 +03:00
ansel
3f93ec8538
Expose counter to inheritors
2022-09-10 23:20:28 +03:00
ansel
667854b034
Make effect display have a built-in counter
2022-09-10 23:18:48 +03:00
Dean Herbert
a9094c6b03
Add test coverage of clicking close button to dismiss
2022-09-10 15:18:32 +09:00
Dean Herbert
efe3b1aa7b
Allow dismissing notifications without performing action using middle / right click
2022-09-10 15:10:37 +09:00
ansel
b056cac10a
Remove generic and add default implementation for CalculateEffect
2022-09-10 08:34:29 +03:00
andy840119
1398a7e11e
Property should accept the nullable state.
2022-09-10 10:46:40 +08:00
Salman Ahmed
5e4e3dfc2c
Fix markdown container not rendering certain text correctly
2022-09-10 02:55:20 +03:00
Dean Herbert
6e52dbb266
Update IsDisplayingToasts to check the flow count directly
2022-09-06 17:30:24 +09:00
Dean Herbert
9e3228aa65
Fix completion notification not being posted if completion occurs during NotificationOverlay load
2022-09-06 04:07:49 +09:00
Dean Herbert
510972e3ad
Avoid reference counting by using height calculation for IsPresent instead
...
The reference counting was to guarantee performance (zero allocations)
when the notification overlay was not required, but adds extra
complexity.
Instead, the toast tray now uses its ongoing height calculation as a
metric for presence.
2022-09-05 19:38:09 +09:00
Dean Herbert
0514c96191
Fix incorrect count tracking when notification is manually disposed
2022-09-05 19:26:40 +09:00
Dean Herbert
229e1a8ef7
Fix notification overlay being present when it doesn't need to
2022-09-05 19:13:58 +09:00
Dean Herbert
f754686521
Remove necessity of AlwaysPresent for ProgressUpdate completion posting
2022-09-05 19:13:58 +09:00
Dean Herbert
0d4ee6bd80
Centralise ability to fetch all toast tray notifications (including animating ones)
2022-09-05 18:42:20 +09:00
Dean Herbert
eca7b8f988
Fix completion notifications not always showing as toasts
2022-09-05 18:39:11 +09:00
Dean Herbert
4fa6707bf0
Set all progress notifications to non-important
2022-09-05 18:29:35 +09:00
Dean Herbert
7eaa4c5ccd
Update new usages of Remove / RemoveInternal
2022-09-01 23:05:34 +09:00
Dean Herbert
6a35b233e5
Merge branch 'master' into remove-dispose-updates
2022-09-01 23:03:19 +09:00
Dan Balasescu
afe2862df4
Merge branch 'master' into toast-notification-tray
2022-08-31 16:07:11 +09:00
Dan Balasescu
ccc08b816c
Merge pull request #20030 from peppy/notification-design-update
...
Update notification overlay design
2022-08-31 16:06:59 +09:00
Dean Herbert
8b9ccc66b7
Update ProgressNotification font spec to match other notifications
2022-08-31 12:49:28 +09:00
Dean Herbert
85442fe032
Adjust dismiss button background colour to avoid conflict with background
2022-08-31 12:48:30 +09:00
Dean Herbert
7c72c6b43f
Fix unread count potentially missing notifications in a transforming state
2022-08-31 12:46:43 +09:00
Dean Herbert
0558dae917
Mark toasts as read when closing the overlay for added safety
...
I'm not sure how the read status will play out going forward so I'm just
adding this to keep things conforming for now.
2022-08-31 12:46:04 +09:00
Dean Herbert
9eb615f942
Fix remaining test failures by strengthening PlayerLoader tests
...
- Click using `TriggerClick` as notifications move around quite a bit.
- Ensure any notifications from a previous test method are cleaned up.
2022-08-31 01:40:30 +09:00
Dean Herbert
31a9980686
Update remaining test expectations with new behaviour
2022-08-31 00:57:30 +09:00
Dean Herbert
a62ba9e0d9
Remove notification blocking behaviour of first run setup
2022-08-31 00:57:18 +09:00
Dean Herbert
ed11b1ba6f
Improve forwarding flow to not use piling delegates
2022-08-31 00:40:53 +09:00
Dean Herbert
224ab29ef4
Don't dismiss toasts while hovered (and adjust timings slightly)
2022-08-30 21:19:51 +09:00
Dean Herbert
403fc18976
Fix notification completion events not being run when overlay not visible
2022-08-30 21:13:43 +09:00
Dean Herbert
a7110666a0
Play notification appear sample immediately
2022-08-30 21:13:43 +09:00
Dean Herbert
95ce78a50c
Reduce notification post delay now that it's less important
2022-08-30 21:13:43 +09:00
Dean Herbert
b8300ae60a
Add toast notification tray
2022-08-30 21:13:43 +09:00
Dean Herbert
7b006f1f22
Add flash when a new notification is displayed to draw attention
2022-08-30 20:34:27 +09:00
Dean Herbert
60413e3e7b
Enable masking for main content to avoid underlap with close button on word wrap failure.
2022-08-30 19:17:41 +09:00
Dean Herbert
6b71b4656d
Remove ProgressNotification vertical movement and delay
2022-08-30 19:16:59 +09:00
Dean Herbert
d600058c98
Assert non-null in ProfileHeader to appease r#
2022-08-30 18:09:10 +09:00
Dean Herbert
c846bf20a7
Add background hover and adjust remaining metrics
2022-08-30 18:06:48 +09:00
Dean Herbert
bea12ab3c2
Rename NotificationContent to MainContent
2022-08-30 18:06:48 +09:00
Dean Herbert
09aa3e065d
Move colouring to full icon content rather than background
2022-08-30 18:06:48 +09:00
Dean Herbert
0f203531d9
Allow customising the "close" button icon
2022-08-30 18:06:48 +09:00
Dean Herbert
1484ae19f0
Initial design update pass
2022-08-30 18:06:48 +09:00
Dean Herbert
b8fda1a16f
Apply NRT to notification classes
...
and tidy things up a bit.
2022-08-30 15:57:10 +09:00
ansel
545e0bbcef
Adjust inheritors and test
2022-08-29 22:49:25 +03:00
ansel
5343c26452
Control colour via Current bindable
2022-08-29 22:48:27 +03:00
ansel
7faeed88b0
Add ability to override width of value area
2022-08-29 22:08:43 +03:00
Dean Herbert
a215d009fe
Update Remove/RemoveRange/RemoveAll calls in line with framework changes
2022-08-29 15:57:40 +09:00
Dan Balasescu
423f6f90f2
Remove async calls from ScoreManager
2022-08-29 15:34:08 +09:00
ansel
039f009562
Inherit difficulty multiplier display from ModsEffectDiplay
2022-08-27 20:26:05 +03:00
ansel
3e828c3416
Move base layout from DifficultyMultiplierDisplay to another class
2022-08-27 20:11:38 +03:00
Dean Herbert
6dc859973b
Merge branch 'master' into fix-playlist-overlay-test-failures
2022-08-26 20:25:53 +09:00
Bartłomiej Dach
968f656585
Merge branch 'master' into copyexternalurl-dialog
2022-08-24 21:21:11 +02:00
Dean Herbert
6a0d23cf96
Nest dialog class and apply NRT
2022-08-24 17:39:22 +09:00
Dean Herbert
9f9deef438
Reword slightly
2022-08-24 17:37:41 +09:00
Andrew Hong
9ee26c575d
Made button blue
2022-08-24 04:04:44 -04:00
Andrew Hong
b24513038c
Add popupdialog button to copy url
2022-08-24 03:35:19 -04:00
Andrew Hong
edd50dc05b
Add profile url context menu to user container
2022-08-24 03:07:03 -04:00
Dean Herbert
c840977acb
Fix filtering potentially not running after new items added
2022-08-23 20:42:20 +09:00
Dean Herbert
058d67f8e8
Merge pull request #19695 from naoei/ruleset-localization
...
Change most ruleset-accessible string types to Localisable strings
2022-08-22 16:13:23 +09:00
Dan Balasescu
0815b01b75
Merge pull request #19783 from bdach/mod-select/presets-dont-open-customisation
...
Fix selecting preset containing Difficulty Adjust automatically opening customisation panel
2022-08-22 15:44:00 +09:00
Dean Herbert
d199b3b100
Update GetVariantName to also support localisation
2022-08-22 14:51:00 +09:00
Dan Balasescu
e1fa959f0b
Fix language change removing mod column bold text
2022-08-22 13:00:47 +09:00
Bartłomiej Dach
aa15e84bea
Adjust rounding in mod select difficulty multiplier to match song select footer
...
The 0.01 `Precision` spec on `DifficultyMultiplierDisplay.Current` would
cause the difficulty multiplier to use a different midpoint rounding
strategy than `double.ToString()`, which is the one that the song select
footer relies on. For example, a value of 0.015 would be rounded down
to 0.01 by `double.ToString()`, but rounded up to 0.02
by `BindableDouble`.
Fix the discrepancy by just deleting the `Precision` spec. Since the
value of the bindable would go through `ToLocalisableString(@"N2")`
anyway, it was redundant as is.
Fixes #19889 .
2022-08-21 23:15:49 +02:00
Bartłomiej Dach
3d14b14cfe
Use alternative method for checking panel readiness to eliminate bool flag
2022-08-17 21:56:11 +02:00
Bartłomiej Dach
3109066e34
Rename {Requires -> Pending}Configuration
2022-08-16 22:45:24 +02:00
Bartłomiej Dach
6bfdfeb153
Refactor mod panel selection logic to avoid overwriting
2022-08-16 22:41:35 +02:00
Bartłomiej Dach
10daac6752
Only open mod customisation panel on explicit selection of single mod
2022-08-15 20:38:23 +02:00
Bartłomiej Dach
f860bc11ee
Fix several schedule-related issues arising from new column addition
2022-08-15 20:38:16 +02:00
Bartłomiej Dach
5ff2e41a55
Add preset column to mod select test scene
2022-08-15 18:38:37 +02:00
Nao
c940f5abcb
Merge branch 'master' into ruleset-localization
2022-08-14 15:17:44 -04:00
naoei
45e9eda9e7
Localise hit result name
2022-08-14 14:57:02 -04:00
basseX
383afe04f3
Remove not needed override
2022-08-14 15:15:36 +02:00
basseX
932becc4b2
Remove CommentMarkdownTextFlowContainer and rather use base-class OsuMarkdownTextFlowContainer
2022-08-14 10:11:49 +02:00
basseX
b05acb0073
Make CommentMarkdownTextFlowContainer render images
2022-08-13 21:32:24 +02:00
Dean Herbert
b76e5757e1
Fix InSelectedCollection not being applied to newly imported beatmaps
2022-08-12 15:06:34 +09:00
Dean Herbert
5111bad86c
Refactor TestScenePlaylistOverlay to use realm for testing
...
Removes the dual-purpose flow which existed only for testing.
2022-08-12 15:06:34 +09:00
Dan Balasescu
1721a91168
Merge pull request #19661 from peppy/overlay-key-binding-organisation
...
Reorganise global bindings and split out overlay bindings to make things easier to find
2022-08-10 21:18:28 +09:00
Dan Balasescu
76fea25668
Merge pull request #19646 from its5Q/settings-localisation
...
Add missing localisation for settings enums
2022-08-10 18:51:52 +09:00
Dan Balasescu
888c4c8e08
Merge pull request #19662 from peppy/startup-correct-username
...
Use a placeholder user with the correct username during login process
2022-08-10 13:09:37 +09:00
its5Q
abca3d1b2a
Prefix common strings for context
2022-08-10 00:35:19 +10:00
Dean Herbert
beb3d41f0c
Fix unsafe usage of APIAccess.LocalUser in BeatmapListingOverlay
2022-08-09 17:11:44 +09:00
Dean Herbert
a71c2bbe28
Split overlay toggles into own section in key bindings
...
Things were getting hard to find..
2022-08-09 17:01:38 +09:00
Dean Herbert
32852e5b21
Fix potentially thread-unsafe LocalUser usage
2022-08-09 16:01:04 +09:00
Dean Herbert
5d8bd1de28
Share localised strings with expanded display message
2022-08-09 15:57:16 +09:00
Dean Herbert
3f8cedff3a
Add tooltips showing current connecting status
2022-08-09 15:51:27 +09:00
Dean Herbert
c35b4ef914
Display connecting / failing states on toolbar user display
2022-08-09 15:51:10 +09:00
Bartłomiej Dach
f74fb3491e
Use alternative implementation of preset panel cleanup
2022-08-08 21:08:54 +02:00
Bartłomiej Dach
a0a6e1faee
Fix spurious sample playbacks from already-removed panels
2022-08-08 20:30:55 +02:00
Bartłomiej Dach
f21a51aa24
Simplify mirror copy of task logic in ModColumn
2022-08-08 19:20:50 +02:00
Bartłomiej Dach
00333fb0d2
Change ?? false test to == true for legibility
2022-08-08 19:19:13 +02:00
its5Q
5080d62e77
Add missing localisation for settings enums
2022-08-08 21:51:23 +10:00
Dean Herbert
070d156e89
Simplify task logic in ModPresetColumn
2022-08-08 16:13:52 +09:00
Bartłomiej Dach
7d6efaebbe
Add maintenance settings section for mod presets
2022-08-07 16:20:31 +02:00
Bartłomiej Dach
839409d7ac
Add preset column to solo mod select overlay
2022-08-07 16:20:31 +02:00
Bartłomiej Dach
b318bbd5e6
Allow non-homogenous column types in mod select overlay
2022-08-07 16:20:31 +02:00
Bartłomiej Dach
0287c49ca8
Implement user selection logic for mod presets
2022-08-07 16:20:20 +02:00
Bartłomiej Dach
b1dcd7821c
Automatically toggle preset panels if selected mods match
2022-08-07 15:30:20 +02:00
Dean Herbert
4a95638756
Merge branch 'master' into mod-overlay/delete-preset
2022-08-07 12:34:25 +09:00
Dean Herbert
5946124278
Merge pull request #19612 from bdach/mod-overlay/common-delete-dialog
...
Unify implementations of deletion dialogs
2022-08-07 12:18:03 +09:00
Bartłomiej Dach
9b3183b2b4
Implement mod preset deletion flow
2022-08-06 21:58:55 +02:00
Bartłomiej Dach
a0d093be5c
Extract common implementation of delete dialog
2022-08-06 21:04:12 +02:00
Bartłomiej Dach
ab1b38242f
Reorder enum cases to match web order
2022-08-06 18:34:30 +02:00
Bartłomiej Dach
6a9c30c47a
Fix some more wrong icon colours
2022-08-06 18:34:00 +02:00
Bartłomiej Dach
2ba127b6fc
Fix wrong icon for approval event
2022-08-06 18:30:49 +02:00
Bartłomiej Dach
f1e0dd2da3
Match approval type-dependent icon appearance with web
2022-08-06 18:29:24 +02:00
Bartłomiej Dach
f3ecd73e0b
Add references to web source in recent activity icon
2022-08-06 18:23:15 +02:00
LukynkaCZE
3000d9b9c6
Inline everything in RecentActivityIcon
2022-08-06 07:16:34 +02:00
LukynkaCZE
bd27995c71
Merge branch 'ppy:master' into add-missing-icons-to-recent-profile-section
2022-08-06 05:55:51 +02:00
Dean Herbert
6823282604
Fix PlayButton potentially not disposing an unused PreviewTrack during load
2022-08-05 14:15:27 +09:00
Bartłomiej Dach
ca1b4689cb
Automatically focus name textbox upon add preset popover open
2022-08-03 21:26:35 +02:00
Bartłomiej Dach
159d3b032c
Rename locals for legibility
2022-08-03 21:23:31 +02:00
Bartłomiej Dach
82d3fbd51b
Split AddPresetPopover to separate file
2022-08-03 21:22:55 +02:00
Bartłomiej Dach
add2971eb4
Implement preset creation flow with test coverage
2022-08-02 22:05:54 +02:00
Bartłomiej Dach
7251389e43
Add localisations for add preset button
2022-08-02 22:05:34 +02:00
Bartłomiej Dach
059a465fe8
Add border to popover for better visual contrast
2022-08-02 22:03:33 +02:00
Bartłomiej Dach
1b3074d098
Implement popover for creating mod presets
2022-08-02 22:03:33 +02:00
Bartłomiej Dach
085080576a
Add button for creating new mod presets
2022-08-02 22:03:32 +02:00
Dean Herbert
34ffc51c51
Avoid clearing chat overlay textbox when pressing "back" key binding
...
Generally this is expected behaviour for usages of focused text boxes
(ie. to clear search content), but not so much here.
Addresses https://github.com/ppy/osu/discussions/19403#discussioncomment-3230395 .
2022-08-02 13:56:03 +09:00
notmyname
6686b09549
Hide F rank from beatmap overlay
2022-08-01 18:54:00 +02:00
Salman Ahmed
2a127c6ef8
Merge branch 'master' into fix-tags-overflow
2022-08-01 12:40:43 +03:00
Gutyina Gergő
c65747d1b8
Use masking instead of scrollable container to prevent tags overflow
2022-08-01 10:36:53 +02:00
Dean Herbert
2f60f91a0e
Fix editor potentially using a track post-disposal
...
This changes the editor to track the current track as it is *loaded* by
`MusicController`, rather than haphazardly following the current global
`WorkingBeatmap` (with a potentially unloaded track) or relying on local
immediate-load behaviour (as implemented in `ResourcesSection`).
2022-08-01 16:53:49 +09:00
Bartłomiej Dach
85f77abee1
Fix code quality inspection about ambiguous equality
2022-07-31 23:53:46 +02:00
Bartłomiej Dach
345f103119
Migrate mod preset column to use realm
2022-07-31 23:53:45 +02:00
