3090 Commits

Author	SHA1	Message	Date
Bartłomiej Dach	1d6b7e9c9b	Refactor further to address code quality complaints	2024-06-10 10:30:30 +02:00
Bartłomiej Dach	e13e9abda9	Disallow running save-related operations concurrently ... Closes https://github.com/ppy/osu/issues/25426. Different approach to prior ones, this just disables the relevant actions when something related to save/export is going on. Still ends up being convoluted because many things you wouldn't expect to touch save do touch save, so it's not just a concern between export and save specifically.	2024-06-07 08:13:51 +02:00
OliBomby	e873698221	Add some in-depth xmldoc to GetSamples	2024-06-06 14:57:25 +02:00
OliBomby	fcc8671cbd	undo useless change	2024-06-06 14:50:24 +02:00
OliBomby	71ce400359	Fix wasteful recreating of container	2024-06-06 14:48:17 +02:00
Bartłomiej Dach	7a8a37dae6	Use established constants	2024-06-06 13:42:31 +02:00
Bartłomiej Dach	86b13074a0	Merge branch 'master' into edit-nodesample	2024-06-06 13:42:25 +02:00
OliBomby	4f8c167cf9	clean up to match logic in CircularDistanceSnapGrid	2024-06-05 18:56:18 +02:00
OliBomby	d8994786f6	Merge remote-tracking branch 'upstream/master' into grids-2	2024-06-05 17:18:48 +02:00
Dean Herbert	212be6b9a7	Merge branch 'master' into grids-1	2024-06-05 15:20:04 +09:00
Bartłomiej Dach	ecfcf7a2c0	Add xmldoc mention about performance overhead of PerformOnSelection()	2024-06-04 10:36:30 +02:00
Bartłomiej Dach	f13ca28d5e	Fix performance overhead from ternary state bindable callbacks when selection is changing ... Closes https://github.com/ppy/osu/issues/28369. The reporter of the issue was incorrect; it's not the beat snap grid that is causing the problem, it's something far stupider than that. When the current selection changes, `EditorSelectionHandler.UpdateTernaryStates()` is supposed to update the state of ternary bindables to reflect the reality of the current selection. This in turn will fire bindable change callbacks for said ternary toggles, which heavily use `EditorBeatmap.PerformOnSelection()`. The thing about that method is that it will attempt to check whether any changes were actually made to avoid producing empty undo states, *but* to do this, it must *serialise out the entire beatmap to a stream* and then *binary equality check that* to determine whether any changes were actually made: 7b14c77e43/osu.Game/Screens/Edit/EditorChangeHandler.cs (L65-L69) As goes without saying, this is very expensive and unnecessary, which leads to stuff like keeping a selection box active while a taiko beatmap is playing under it dog slow. So to attempt to mitigate that, add precondition checks to every single ternary callback of this sort to avoid this serialisation overhead. And yes, those precondition checks use linq, and that is *still* faster than not having them.	2024-06-04 10:32:12 +02:00
Bartłomiej Dach	4fcb902341	Merge branch 'master' into grids-1	2024-06-03 12:33:51 +02:00
Dean Herbert	fdb47f8dfa	Fix incorrect handling of nested objects when inside parent object's duration	2024-05-29 23:30:47 +09:00
Dean Herbert	126837fadd	Apply results rather than fake a replay frame	2024-05-29 23:28:37 +09:00
Dean Herbert	3b5b7b2f88	Fix the majority of cases where gameplay stil doesn't end due to judgement count mismatch	2024-05-29 22:57:17 +09:00
Dean Herbert	d2c86b0813	Avoid passing beatmap in from editor when it's already present	2024-05-29 21:32:55 +09:00
Dean Herbert	16e2fa2c6a	Merge branch 'master' into fix/editor-test-exit	2024-05-29 21:08:36 +09:00
Bartłomiej Dach	4c881b5633	Use better name if we're renaming	2024-05-29 09:40:29 +02:00
OliBomby	d143a697d2	refactor CanScaleFromPlayfieldOrigin and GetClampedScale to derived class	2024-05-28 17:12:16 +02:00
OliBomby	8eb23f8a60	remove redundant CanScaleFromSelectionOrigin	2024-05-28 16:19:57 +02:00
OliBomby	a89ba33b47	rename CanScaleSelectionOrigin/PlayfieldOrigin to make clear its not the origin being scaled	2024-05-28 16:14:16 +02:00
OliBomby	37530eebcc	Enable scale buttons at the correct times	2024-05-25 20:35:06 +02:00
OliBomby	4eeebdf60c	calculate max scale bounds for scale slider	2024-05-25 20:17:27 +02:00
OliBomby	497701950d	fix nitpick	2024-05-24 18:11:28 +02:00
Bartłomiej Dach	9f19ab092d	Merge branch 'master' into grids-1	2024-05-24 14:39:55 +02:00
Bartłomiej Dach	7255cc3344	Fix tests dying on a nullref	2024-05-24 11:25:29 +02:00
Bartłomiej Dach	807d982a72	Move workaround to subscreen	2024-05-24 10:35:33 +02:00
Bartłomiej Dach	a80dbba9d0	Update to not use obsoleted method	2024-05-24 10:35:31 +02:00
Bartłomiej Dach	4089071299	Merge branch 'master' into fix-editor-didnt-save	2024-05-24 10:16:46 +02:00
Bartłomiej Dach	8a2dd4d816	Merge branch 'master' into scaling	2024-05-23 15:10:40 +02:00
Bartłomiej Dach	128029e2af	Fix aspect ratio lock applying when shift pressed on a non-corner anchor ... It doesn't make sense and it wasn't doing the right thing.	2024-05-23 15:08:43 +02:00
Bartłomiej Dach	9e86a08405	Simplify scale origin computation	2024-05-23 14:07:43 +02:00
Bartłomiej Dach	070668c96f	Use ShiftPressed instead of explicitly checking both physical keys ... Not only is this simpler, but it also is more correct (for explanation why, try holding both shift keys while dragging, and just releasing one of them - the previous code would briefly turn aspect ratio off).	2024-05-23 13:57:34 +02:00
Dean Herbert	66ceda1d67	Update focus specifications in line with framework changes	2024-05-22 21:32:49 +08:00
Dean Herbert	d0b1ebff5a	Revert "Temporary rollback of framework / SDL3" ... This reverts commit d7d569cf4e.	2024-05-22 16:29:39 +08:00
Dean Herbert	d7d569cf4e	Temporary rollback of framework / SDL3	2024-05-21 14:36:16 +08:00
OliBomby	c4ac6d20a0	fix code quality	2024-05-15 23:40:51 +02:00
OliBomby	8df5f22b4e	Merge remote-tracking branch 'upstream/master' into scaling	2024-05-15 23:05:19 +02:00
Dan Balasescu	3b8b56cbcb	Apply required changes after framework masking updates	2024-05-09 20:18:53 +09:00
Dean Herbert	fd3f4a9e7b	Preserve storyboard events when saving a beatmap in the editor ... Until we have full encoding support for storyboards, this stop-gap measure ensures that storyboards don't just disappear from existence.	2024-04-30 00:01:56 +08:00
Dan Balasescu	52addc775e	Merge pull request #27965 from bdach/generic-math ... Apply generic math-related changes	2024-04-26 01:33:54 +09:00
Bartłomiej Dach	19d006d818	Fix deleting modified difficulty via editor leaving user in broken state ... Closes https://github.com/ppy/osu/issues/22783. If the difficulty being edited has unsaved changes, the editor exit flow would prompt for save *after* the deletion method has run. This is undesirable from a UX standpoint, and also leaves the user in a broken state. Thus, just fake an update of the last saved hash of the beatmap to fool the editor into thinking that it's not dirty, so that the exit flow will not show a save dialog.	2024-04-25 12:55:34 +02:00
Joseph Madamba	4f7c9f2970	Remove unused using	2024-04-24 01:00:03 -07:00
Joseph Madamba	f97c519451	Add chevron to distinguish all menus with submenus	2024-04-24 00:19:10 -07:00
Dean Herbert	436203a8c1	Add a chevron to distinguish editor menus with submenus	2024-04-23 21:37:01 +08:00
Bartłomiej Dach	09b0f3005e	Apply generic math-related changes	2024-04-22 10:15:56 +02:00
Andrei Zavatski	1d3fd65d86	Adjust execution order	2024-04-22 07:02:49 +03:00
Andrei Zavatski	722fa228ce	Don't consider editor table content for input	2024-04-21 17:40:35 +03:00
Salman Ahmed	9e69268676	Change editor screen selection logic to use SelectItem for sound feedback	2024-04-17 11:20:17 +03:00
Dean Herbert	aa7b357063	Merge pull request #27768 from 64ArthurAraujo/editor-fix-sliders-same-start-time-merge ... Fix merging sliders with the same `StartTime` causing a Unhandled Exception	2024-04-03 01:45:55 +08:00
Arthur Araujo	2a2a372595	Check if blueprint is in SelectionBlueprints before changing its depth	2024-04-02 07:45:27 -03:00
Nguyên Minh Hồ	5d497ba4a8	Simplify TooltipText for EditorRadioButton	2024-03-30 16:04:22 +07:00
Nguyên Minh Hồ	9950395e5f	Merge branch 'fix-rotate-editor-button-disabled' of https://github.com/honguyenminh/osu into fix-rotate-editor-button-disabled	2024-03-30 13:57:44 +07:00
Nguyên Minh Hồ	113dbcd10f	Merge branch 'master' into fix-rotate-editor-button-disabled	2024-03-30 13:56:31 +07:00
Dean Herbert	fd509c82f5	Adjust code structure slightly	2024-03-20 12:52:54 +08:00
Andrei Zavatski	7ca45c75b3	Don't iterate backwards on children without a reason	2024-03-18 20:46:38 +03:00
Andrei Zavatski	0edc249637	Make Timeline non-nullable	2024-03-18 20:38:19 +03:00
Andrei Zavatski	57399e9899	Merge branch 'master' into editor-performance	2024-03-18 20:34:48 +03:00
Andrei Zavatski	34a5e2d606	Don't update subtree masking in TimelineTickDisplay	2024-03-16 15:20:37 +03:00
Andrei Zavatski	981ee54cdc	Fix transforms overhead in TimelineTickDisplay	2024-03-16 15:05:52 +03:00
Andrei Zavatski	e825db61ee	Fix enumerator allocation	2024-03-16 12:26:56 +03:00
Andrei Zavatski	ea3a9314f9	Improve TimelineControlPointDisplay performance	2024-03-16 11:57:18 +03:00
Andrei Zavatski	6ecef33fd7	Fic incorrect ExtendableCircle gradient	2024-03-10 22:45:29 +03:00
Andrei Zavatski	549a8d678e	Reduce allocations in ControlPointList	2024-03-09 20:50:54 +03:00
Dan Balasescu	ca92a31cf9	Fix missing event unbinds	2024-03-07 21:10:11 +09:00
Salman Ahmed	0fe139a189	Adjust editor screen switcher control design and behaviour	2024-03-07 08:20:46 +03:00
Dean Herbert	6455c0583b	Update usage of CircularProgress.Current	2024-03-06 12:13:10 +08:00
Dean Herbert	c6201ea5de	Remove unused ruleset parameter when testing beatmap in editor	2024-03-01 20:28:52 +08:00
Andrei Zavatski	eb0933c3a5	Fix allocations in EffectPointVisualisation	2024-02-29 20:35:20 +03:00
Bartłomiej Dach	f86b7f0702	Enable NRT in EditorBeatmapSkin	2024-02-23 14:52:44 +01:00
Bartłomiej Dach	d1d32fc16c	Fix editor displaying combo colours in effectively incorrect order ... Addresses https://github.com/ppy/osu/discussions/27316. Stable lies about the first combo colour being first; in the `.osu` file it is actually second. It does a thing in editor itself to correct for this. https://github.com/peppy/osu-stable-reference/blob/master/osu!/GameModes/Edit/Forms/SongSetup.cs#L233-L234	2024-02-23 14:49:46 +01:00
Andrei Zavatski	4cefa8bb8d	Reduce allocations in TimelineBlueprintContainer	2024-02-21 23:13:10 +03:00
Dean Herbert	9c40ff2911	Merge pull request #27278 from EVAST9919/grid-update ... Apply padding to `GridContainer`s directly where possible	2024-02-21 17:29:21 +08:00
Andrei Zavatski	2543a48ac8	Apply padding to GridContainers directly	2024-02-20 23:18:37 +03:00
Andrei Zavatski	871bdb9cf7	Reduce string allocations in TimeInfoContainer	2024-02-20 20:31:18 +03:00
Andrei Zavatski	6678c4783b	Fix PlaybackControl string allocations	2024-02-20 19:31:28 +03:00
Berkan Diler	6adf0ac01e	Use new LINQ Order() instead of OrderBy() when possible	2024-02-08 18:01:00 +01:00
Dan Balasescu	b44f77cee1	Update R# + fix inspections	2024-02-02 21:00:28 +09:00
OliBomby	576d6ff799	Fix masking in circular snap grid	2024-02-01 17:07:57 +01:00
OliBomby	f807a3fd97	Remove Masking from PositionSnapGrid ... This caused issues in rendering the outline of the grid because the outline was getting masked at some resolutions.	2024-02-01 16:57:45 +01:00
OliBomby	1428cbfbc3	Remove Masking from PositionSnapGrid ... This caused issues in rendering the outline of the grid because the outline was getting masked at some resolutions.	2024-02-01 16:56:57 +01:00
Bartłomiej Dach	8a11ff1227	Apply local precision workaround to editor effect section	2024-01-29 11:52:38 +01:00
Dean Herbert	45f2980dc0	Fix potential editor data loss if exiting while a textbox is focused	2024-01-26 13:59:32 +09:00
OliBomby	c2d57dc77c	Merge remote-tracking branch 'upstream/master' into edit-nodesample	2024-01-25 11:33:29 +01:00
Mike Will	a264ac9f38	Change name and description of force parameter in SetArbitraryDivisor	2024-01-25 05:12:54 -05:00
Nguyên Minh Hồ	d5b70ed09a	Move CanRotatePlayfieldOrigin bindable to generic rotation handler	2024-01-25 16:58:44 +07:00
Nguyên Minh Hồ	2fa52de87a	Fix formatting	2024-01-25 16:29:44 +07:00
Nguyên Minh Hồ	94ada87cba	Un-hardcode tooltip from EditorRadioButton and add disabled tooltip for rotation popover	2024-01-25 14:32:48 +07:00
Nguyên Minh Hồ	500bed0121	Split editor toolbox radio button disabling logic from EditorRadioButton, then add disabling logic for rotate popover	2024-01-25 14:24:35 +07:00
Nguyên Minh Hồ	e1f8bc9692	Rename CanRotate property of SelectionRotationHandler to a more descriptive name	2024-01-25 12:10:50 +07:00
Mike Will	9e1c242713	Prevent custom divisor ranges from halting preset cycling ... A custom divisor like 24 or 32 will result in a range containing many divisors that are already in the `Common` and `Triplets` presets. When this happens, it can become impossible to cycle between presets, because the preset can only be changed if the new divisor isn't already contained within the current preset's range.	2024-01-24 18:31:39 -05:00
Salman Ahmed	2bd9cd5d34	Fix blueprint container not handling right clicks correctly while moveing an element	2024-01-22 04:39:08 +03:00
OliBomby	78e87d379b	fix divide by zero	2024-01-20 16:53:11 +01:00
OliBomby	5f40d3aed9	rename variable	2024-01-20 16:29:26 +01:00
OliBomby	9b9485f656	fix adjust axes detection	2024-01-20 15:39:38 +01:00
OliBomby	1596776a81	fix imports	2024-01-20 15:15:49 +01:00
OliBomby	0fc448f4f3	fix adjusting scale from anchor	2024-01-20 15:12:48 +01:00
OliBomby	6a4129dad8	fix aspect ratio transform	2024-01-20 15:11:35 +01:00
OliBomby	fcaa5ec20e	remove debug logs	2024-01-20 13:26:08 +01:00
OliBomby	6a57be0a50	clean up code and fix flipping	2024-01-20 13:04:05 +01:00
OliBomby	a4f771ec08	refactor CanScale properties	2024-01-20 01:13:01 +01:00
OliBomby	26c0d1077a	Refactor scale handling in editor to facilitate reuse	2024-01-20 00:22:53 +01:00
Salman Ahmed	46429c5074	Schedule control point switch for settings modifications to apply first	2024-01-17 08:15:01 +03:00
Nitrous	6cd255f549	Contains + Add to TryAdd	2024-01-11 11:36:58 +08:00
Nitrous	72e302dfac	Enumerate nested hit objects	2024-01-10 15:27:41 +08:00
Nitrous	b74c3b1c5c	Make all hit objects before the start time marked as hit.	2024-01-10 15:19:38 +08:00
Dean Herbert	bdfaa4b583	Fix crash when dragging rotation control in editor with both mouse buttons ... Closes https://github.com/ppy/osu/issues/26325.	2024-01-03 13:34:50 +09:00
OliBomby	6bb72a9fcc	Revert "Remove other grid types" ... This reverts commit de14da95fa.	2024-01-01 15:46:07 +01:00
OliBomby	de14da95fa	Remove other grid types	2024-01-01 15:44:20 +01:00
OliBomby	f649fa106f	Added bindables and binding with BindTo	2024-01-01 15:13:11 +01:00
OliBomby	d0ca3f2b2b	Add circular grid	2024-01-01 15:13:11 +01:00
OliBomby	847f04e63a	reduce opacity of middle cardinal lines	2024-01-01 15:13:10 +01:00
OliBomby	8a331057b0	Make it actually possible to change grid type	2024-01-01 15:13:10 +01:00
OliBomby	f223487e1c	improve code	2024-01-01 15:13:10 +01:00
OliBomby	0ce1a48e68	Add comment	2024-01-01 15:13:10 +01:00
OliBomby	a20c430d6f	fix wrong grid cache being used	2024-01-01 15:13:10 +01:00
OliBomby	d0c8b285ce	clean up code duplication	2024-01-01 15:13:10 +01:00
OliBomby	92c3b142a4	Added Triangular snap grid	2024-01-01 15:11:50 +01:00
OliBomby	f2edd705ea	add rotation to snapped position	2024-01-01 15:11:49 +01:00
OliBomby	f3b88c318b	Add rotation to snap grid visual	2024-01-01 15:11:49 +01:00
iminlikewithyou	5ae5d7f92d	change floor to round	2023-12-30 23:59:47 -06:00
Bartłomiej Dach	99cddb6317	Use alternative workaround	2023-12-29 11:07:45 +01:00
Bartłomiej Dach	cd1f6b46c4	Fix crash after changing audio track in editor ... Closes https://github.com/ppy/osu/issues/26213. Reproduction scenario: switch audio track in editor after timeline loads. Happens because `beatmap.Value.Track.Length` is 0 immediately after a track switch, until BASS computes the actual track length on the audio thread. Yes this is a hack. No I have no better immediate ideas how to address this otherwise.	2023-12-29 10:37:36 +01:00
Bartłomiej Dach	53766285ce	Remove remaining hexacons usages	2023-12-27 17:42:18 +01:00
Bartłomiej Dach	288ac930e4	Use new icons in editor ... Some that exist on figma are purposefully not used due to an editorial request from @peppy.	2023-12-27 17:42:18 +01:00
Dean Herbert	03e2463b06	Add test coverage and refactor to better handle equality edge case	2023-12-26 21:21:08 +09:00
Dean Herbert	1f2f749db6	Fix selection not being retained in control point list when undoing / redoing	2023-12-26 21:04:42 +09:00
Dean Herbert	f2c0e7cf2e	Fix editor's control point list refreshing multiple times for a single change	2023-12-26 21:04:42 +09:00
Dean Herbert	f9e47242db	Add visual offset to better align editor waveforms with expectations	2023-12-26 17:44:49 +09:00
OliBomby	c167f10ad5	fix crash from dragging near zero-length repeating object in timeline	2023-12-19 21:20:45 +01:00
Dean Herbert	0be6743e87	Apply Bindable.Parse refactorings	2023-12-13 14:07:38 +09:00
Dean Herbert	0af16732b8	Change default slider velocity to 1.4 ... This is the default in osu!stable and plays better than 1.0.	2023-12-06 13:38:46 +09:00
Guido	8756dd25c6	Changed file chooser in resource selection to show file name when file is selected	2023-12-04 22:51:56 +01:00
Dean Herbert	340227a06d	Replace all hexacon lookups with strongly typed properties	2023-11-24 13:17:39 +09:00
Dean Herbert	21bf288277	Merge pull request #25520 from peppy/context-menu-spacers ... Allow context menus to have visible spacers	2023-11-21 16:56:36 +09:00
Bartłomiej Dach	d83b2e24e7	Merge pull request #25371 from RatinFX/open-editor-timestamp ... Implement opening editor timestamp links	2023-11-21 15:48:36 +09:00
Dean Herbert	7c5345bf7e	Use SimpleErrorNotification for error display	2023-11-21 15:10:41 +09:00
Dean Herbert	917a68eac3	Adjust localisablel strings and keys	2023-11-21 15:08:15 +09:00
Dean Herbert	405ab499e9	Allow context menus to have visible spacers	2023-11-21 14:24:10 +09:00
Bartłomiej Dach	b6215b2809	Rename and document SelectFromTimestamp	2023-11-20 21:57:14 +09:00
Bartłomiej Dach	234ef6f923	Rectify selection keep-alive logic	2023-11-20 21:57:14 +09:00
Bartłomiej Dach	246aacb216	Remove unnecessary guard ... Setting a bindable's value to something if that value is already there is a no-op (doesn't trigger bindings / callbacks).	2023-11-20 21:57:14 +09:00
Bartłomiej Dach	0e0ab66148	Simplify parsing code ... Less methods, less smeared around logic, saner data types.	2023-11-20 21:57:12 +09:00
ratinfx	4e1e19728c	Refactor HitObject selection in Composer	2023-11-11 14:02:42 +01:00
Dean Herbert	35e11c7c63	Rename diagonal scale variable and update xmldoc	2023-11-10 17:55:02 +09:00
Dean Herbert	ec3b6e47fb	Change selection handling to adjust Size instead of Scale for edge nodes	2023-11-10 14:22:28 +09:00
ratinfx	544d5d1d86	Forgot a clock.Stop call	2023-11-07 12:23:22 +01:00
ratinfx	bdbeb2bce4	Renamed CollectionChanged event handler	2023-11-07 11:11:32 +01:00
ratinfx	aa87e0a44d	HitObject Selection logic and separation for gamemodes ... + moved time_regex into EditorTimestampParser	2023-11-07 01:36:58 +01:00
ratinfx	44f127c8a8	Renamed method and made private	2023-11-07 01:02:45 +01:00
ratinfx	0834b79cc7	Renamed method and moved Notifications inside	2023-11-07 00:56:24 +01:00
Salman Ahmed	b2749943e2	Display "required save" popup when creating another difficulty on a new beatmap	2023-11-06 21:54:40 +03:00
Dean Herbert	51c891e2e4	Automatically refresh the verify screen's issue list on re-entering it ... Addresses https://github.com/ppy/osu/discussions/25365.	2023-11-06 19:34:36 +09:00
ratinfx	277cf7dc12	Ensure every SelectedItem is alive and has Blueprint	2023-11-05 18:26:51 +01:00
ratinfx	7492d953ae	Moved error checks into Editor ... - Invoke Action on error to Notify user - added some comments	2023-11-04 21:17:58 +01:00
ratinfx	60f62faec3	Renamed Editor method	2023-11-04 03:30:38 +01:00
ratinfx	43ab7f4942	Added OpenEditorTimestamp base implementation	2023-11-04 02:01:18 +01:00
Bartłomiej Dach	850866e7f4	Merge pull request #25316 from peppy/metronome-always-play-tick ... Decouple metronome tick playback from pendulum movement	2023-10-31 09:37:29 +01:00
Bartłomiej Dach	144006fbe8	Update autoselect implementation to work correctly with framework changes	2023-10-31 08:38:22 +01:00
Bartłomiej Dach	8a68333425	Merge branch 'master' into beat-divisor-select-text-on-click	2023-10-31 08:36:53 +01:00
Dean Herbert	64efc3d251	Decouple metronome tick playback from pendulum movement ... Not super happy about doing this, but it seems like it's in the best interest of editor usability.	2023-10-31 15:33:46 +09:00
Dean Herbert	f706fd2fca	Merge pull request #25307 from bdach/slider-velocity-undo ... Fix slider velocity changes not being undone correctly	2023-10-31 01:44:18 +09:00
Bartłomiej Dach	cea24298cb	Privatise setters	2023-10-30 12:42:34 +01:00
Bartłomiej Dach	de89b7e53c	Fix slider velocity changes not being undone correctly ... Closes https://github.com/ppy/osu/issues/25239. `LegacyEditorBeatmapPatcher.processHitObjectLocalData()` was already supposed to be handling changes to hitobjects that will show up neither when comparing the hitobjects themselves or the timing point with "legacy" info stripped - so, in other words, changes to slider velocity and samples. However, a change to slider velocity requires default application to take effect, so just resetting the value would visually fix the timeline marker but not change the actual object. Calling `EditorBeatmap.Update()` fixes this by way of triggering default re-application. This could probably be smarter (by only invoking the update when strictly necessary, etc.) - but I'm not sure it's worth the hassle. This is intended to be a quick fix, rather than a complete solution - the complete solution would indeed likely entail a wholesale restructuring of the editor's change handling.	2023-10-30 10:59:02 +01:00
Dean Herbert	63e6eaf538	Fix failing tests	2023-10-30 18:06:11 +09:00
Dean Herbert	57d88a0ac4	Fix right clicks on timeline objects potentially getting eaten by playfield area ... `SelectionHandler` is receiving input from anywhere out of necessity: 19f892687a/osu.Game/Screens/Edit/Compose/Components/SelectionHandler.cs (L119-L125) Also important is that `BlueprintContainer` will selectively not block right clicks to make sure they fall through to the `ContextMenuContainer`: 19f892687a/osu.Game/Screens/Edit/Compose/Components/BlueprintContainer.cs (L122-L126) But because the whole editor is sharing a `ContextMenuContainer` and it's at a higher level than both components, we observe here the playfield's `SelectionHandler` intercepting the right click before it can reach the `ContextMenuContainer`. The fix here is similar to what we're already doing in `TimelineBlueprintContaienr`.	2023-10-30 18:06:11 +09:00
Dean Herbert	6934e045df	Fix editor not prompting before saving beatmap for export	2023-10-25 14:39:46 +09:00
Bartłomiej Dach	12282fff5c	Disallow setting sample volume lower than 5% in editor	2023-10-20 15:50:21 +02:00
Dean Herbert	52c2eb93de	Merge branch 'master' into taiko-beat-snap-grid	2023-10-19 23:53:01 +09:00
Dean Herbert	5341a335a6	Bypass Parent nullability checks for now	2023-10-17 17:48:45 +09:00
Dean Herbert	2a89a25790	Add beat snap grid to osu!taiko editor ... Addresses https://github.com/ppy/osu/discussions/25150.	2023-10-17 16:59:56 +09:00
Dean Herbert	1b9acdf55c	Abstract out common implementation of BeatSnapGrid	2023-10-17 16:42:52 +09:00
Dean Herbert	1005b7ac85	Fix incorrect test assumption in TestSceneEditorClock ... I don't know what this test was trying to do, but it was wrong. Any offset which is applied should be invisible to the clock's final `CurrentTime` (and to the user).	2023-10-06 16:43:28 +09:00
Dean Herbert	354193c53a	Merge branch 'master' into clock-fix-attempt-2	2023-10-06 16:43:27 +09:00
Dean Herbert	61fd4186af	Ensure regenerateDisplay is eventually performed if originally called before load	2023-10-05 22:55:23 +09:00
Dean Herbert	76cc2f9f22	Fix WaveformComparisonDisplay potentially crashing on invalid track length ... As seen at https://github.com/ppy/osu/runs/17415814918#r0s2.	2023-10-05 14:58:55 +09:00
Dean Herbert	5a17a86d1d	Merge branch 'master' into clock-fix-attempt-2	2023-10-04 16:57:49 +09:00
Dean Herbert	7908b36b39	Flash dialog popup when attempting to exit editor while exit is being blocked	2023-09-28 15:25:39 +09:00
Dean Herbert	faa0481fc6	Fix editor operating directly on track rather than decoupled clock	2023-09-22 16:22:36 +09:00
Dean Herbert	df08c4e1ad	Disable decoupling for OsuGameBase's beatmap implementation ... This avoids it ever mutating the underlying track (aka attempting to start it). Resolves the one caveat mentioned in aeef92fa710648d4a00edc523e13c17ac6104125.	2023-09-22 12:49:25 +09:00
Dean Herbert	600651795b	Change FramedBeatmapClock to always be decoupled	2023-09-22 12:49:25 +09:00
Salman Ahmed	9e4a56d64e	Merge branch 'master' into update-framework	2023-09-21 19:49:20 +03:00
Dean Herbert	bf984388b3	Update clocks in line with framework changes	2023-09-20 21:17:08 +09:00
Dean Herbert	c5397bdbb3	Merge branch 'master' into mania-edit-disable-sv	2023-09-20 14:23:07 +09:00
Dean Herbert	1a37543d28	Rename SliderVelocity to SliderVelocityMultiplier to distinguish from Velocity	2023-09-06 19:01:08 +09:00
Hồ Nguyên Minh	d5a89c4c45	Fix formatting	2023-09-04 13:32:42 +07:00
Hồ Nguyên Minh	b17a55d6a8	Add length check for slider velocity	2023-09-04 10:43:05 +07:00
Wleter	fc4069f794	let SelectionBox perform flip with scale handles	2023-09-01 13:01:51 +02:00
Dean Herbert	0f5eff1230	Merge branch 'master' into mania-edit-disable-sv	2023-09-01 19:08:48 +09:00
Wleter	14ee0ee395	Merge branch 'ppy:master' into skin-editor-selection-negative-scaling	2023-08-29 17:30:55 +02:00
Wleter	d56ab0fe9a	change names	2023-08-29 17:25:52 +02:00
Wleter	07e126241d	working negative scaling	2023-08-28 16:41:55 +02:00
Dean Herbert	081fb308e1	Merge branch 'master' into new-overlay-sfx	2023-08-24 18:29:00 +09:00
Dean Herbert	8120c3f87a	Merge branch 'master' into precise-rotation-2	2023-08-19 23:25:42 +09:00
Dan Balasescu	a2fd7707a1	Allow toggling SVs in the editor	2023-08-18 18:55:24 +09:00
Dean Herbert	9023059bc0	Convert to switch statement	2023-08-18 17:27:09 +09:00
OliBomby	360f9750e1	Allow selecting empty control point groups	2023-08-17 16:30:18 +02:00
Jamie Taylor	d10d7b6ea4	Change some component samples to go better with overlay pop-in samples	2023-08-17 18:36:37 +09:00
Jamie Taylor	3d7ba0e18c	Add pop-in/pop-out sfx to more overlays	2023-08-17 18:36:37 +09:00
OliBomby	88e6fe72dc	fix code quality	2023-08-16 23:09:04 +02:00
OliBomby	fd54c329fa	dont focus volume, so keybinds immediately available	2023-08-16 22:08:49 +02:00
OliBomby	a938b810b4	Add keybind for bank setting	2023-08-16 22:07:36 +02:00
OliBomby	02b7c8f27b	Move sliderbody hs to middle of first span	2023-08-16 21:15:47 +02:00
Bartłomiej Dach	19f892687a	Add precise rotation control to osu! editor	2023-08-16 11:37:52 +02:00
Bartłomiej Dach	bdf87e43db	Merge branch 'master' into slider-with-textbox-instantaneous	2023-08-16 10:48:45 +02:00
Dean Herbert	5bd7370439	Add log output when editor is creating a fresh beatmap	2023-08-16 14:23:17 +09:00
Joseph Madamba	49f5d6813e	Block beatmap editor from testing/exiting/exporting when saving fails	2023-08-04 22:08:25 -07:00
Bartłomiej Dach	2e2b0c4e41	Move SliderWithTextBoxInput to more general namespace	2023-08-01 01:01:36 +02:00
Dean Herbert	f06b203067	Merge branch 'master' into edit-nodesample	2023-07-31 14:06:38 +09:00
Bartłomiej Dach	ebe5dd2ac9	Interface with SelectionRotationHandler via DI rather than explicit passing	2023-07-30 20:21:41 +02:00
Bartłomiej Dach	262f25dce8	Make SelectionRotationHandler a Component	2023-07-30 20:18:33 +02:00
Bartłomiej Dach	821cd08f34	Merge branch 'master' into selection-operations-refactor	2023-07-30 19:29:06 +02:00
Bartłomiej Dach	e208f38bcb	Merge pull request #24361 from peppy/fix-editor-global-music-hotkey-conflicts ... Disallow interacting with the global track state in `Player` and `Editor`	2023-07-30 12:28:53 +02:00
Dean Herbert	945d89e955	Move disables to loading screens for better coverage of edge cases	2023-07-30 13:45:42 +09:00
Bartłomiej Dach	c6f0cf50ca	Use better safety in rectangular grid ... - Checking `DrawSize != Vector2.Zero` is too specific. It could also crash on zero-height-but-non-zero-width, or zero-width-but-non-zero-height. - Take the `gridCache.Validate()` call out of the zero checks, because even if the width or height are zero, not generating anything is valid and there is no reason to validate every frame until `gridCache` gets invalidated again.	2023-07-28 22:57:02 +02:00
Dean Herbert	0e4db9b439	Add safety in RectangularPositionSnapGrid that size is greater than zero ... Would crash otherwise	2023-07-28 16:25:40 +09:00
Dean Herbert	7fd6bb9d5f	Fix a couple of code style issues in SelectionBox	2023-07-26 14:04:38 +09:00
Dean Herbert	39c2bb240b	Apply NRT to SelectionBoxRotationHandle.	2023-07-26 14:04:21 +09:00
Bartłomiej Dach	3b9f250c1b	Merge branch 'master' into menu-star-fountains	2023-07-25 21:58:13 +02:00
Dean Herbert	3485b72eaa	Disallow interacting with the global track state in Player and Editor	2023-07-25 20:20:53 +09:00
Dean Herbert	157b1f301b	Rename AllowTrackAdjustments to more understandable ApplyModTrackAdjustments	2023-07-25 20:20:53 +09:00
Dean Herbert	eac6271bd0	Add new property to avoid overlapping usages	2023-07-25 18:14:03 +09:00
Bartłomiej Dach	a201152b04	Add xmldoc to SelectionRotationHandler	2023-07-23 20:56:22 +02:00
Bartłomiej Dach	aec3ca250c	Migrate SelectionHandler to use SelectionRotationHandler	2023-07-23 20:56:22 +02:00
Bartłomiej Dach	ba8ebefb50	Add basic structure for new rotation handler	2023-07-23 20:56:22 +02:00
Bartłomiej Dach	4622255cc7	Move out helper methods to static class	2023-07-23 18:24:20 +02:00
Bartłomiej Dach	9f68bb4e4a	Merge pull request #24333 from peppy/editor-menu-spacer ... Adjust metrics of editor menu spacers (and make visible)	2023-07-23 15:25:27 +02:00
Dean Herbert	4bf300d64d	Merge pull request #24186 from OliBomby/legacy-export ... Add ability to export beatmaps from editor in a stable-compatible format	2023-07-23 15:25:06 +09:00
Dean Herbert	4ea8495c61	Adjust metrics of editor menu spacers (and make visible)	2023-07-23 14:12:37 +09:00
Dean Herbert	fb34ee94c2	Move export/save options to bottom of menu	2023-07-23 14:07:31 +09:00
Dean Herbert	20359c90bc	Adjust localisations slightly	2023-07-23 14:06:00 +09:00
Dean Herbert	d11e56b8bb	Add common Export string and use in editor	2023-07-23 14:03:50 +09:00
Bartłomiej Dach	d1c69283b2	Merge branch 'master' into editor-key-count	2023-07-22 16:11:21 +02:00
Bartłomiej Dach	f985bdc10f	Make difficulty sliders private set	2023-07-22 15:55:20 +02:00
Dean Herbert	fd2bdc10c7	Fix "key count" setting showing as "circle size" in osu!mania editor ... Closes https://github.com/ppy/osu/issues/12904.	2023-07-21 18:52:29 +09:00
Dean Herbert	82a5ba66e1	Align mode switcher with rest of interface	2023-07-21 15:27:42 +09:00
Dean Herbert	cdcb10e0e7	Fix timeline centre point being ever-so-slight off	2023-07-21 15:26:41 +09:00
Dean Herbert	f489dbd7a9	Reduce width of right toolbar ever so slightly (and use more shared constants)	2023-07-21 14:39:15 +09:00
Dean Herbert	870f3e324a	Adjust "test" button to better align with rest of interface	2023-07-21 14:26:33 +09:00
Dean Herbert	ca3d1538ae	Merge branch 'master' into editor-metrics	2023-07-21 14:26:32 +09:00
Dean Herbert	b29a2081ac	Merge branch 'master' into menu-star-fountains	2023-07-21 14:21:16 +09:00
Bartłomiej Dach	07e0a703d7	Adjust inline comment	2023-07-20 20:51:39 +02:00
Bartłomiej Dach	708dd355cd	Merge branch 'master' into editor-cyclic-selection	2023-07-20 20:19:46 +02:00
Bartłomiej Dach	511948ba56	Add xmldoc to ApplySelectionOrder()	2023-07-20 19:16:04 +02:00
Bartłomiej Dach	f3a95d4c13	Merge branch 'master' into menu-star-fountains	2023-07-19 21:26:41 +02:00
Dean Herbert	cf3949c9e2	Fix double-click handling when cyclic selection is enabled ... Removes the limitations of cyclic selection as a result.	2023-07-19 17:21:20 +09:00
Dean Herbert	5ade093c5a	Change editor to always perform selection of closest object	2023-07-19 16:56:16 +09:00
Dean Herbert	55a41b0887	Fix overlap between header text and menu items	2023-07-19 15:13:20 +09:00
Dean Herbert	871056790b	Mark editor tile as non-localisable	2023-07-19 15:01:20 +09:00
OliBomby	395dd23966	Put 'Export package' and 'Export legacy package' in one nested menu	2023-07-18 12:37:37 +02:00
OliBomby	5d82190b70	Merge remote-tracking branch 'upstream/master' into legacy-export	2023-07-18 12:18:49 +02:00
Dean Herbert	fe70f24925	Update design of summary timeline current time marker	2023-07-14 17:00:42 +09:00
Dean Herbert	e6b8cd0c06	Add editor header	2023-07-14 16:55:12 +09:00
Dean Herbert	57abb15724	Update design of timeline centre marker and adjust surrounding paddings	2023-07-14 16:37:57 +09:00
Dean Herbert	00e9746174	Implement longer design for timing point piece	2023-07-14 16:37:56 +09:00
Dean Herbert	6b222cfafd	Fix slight misalignment so timeline is now completely centered	2023-07-14 14:29:13 +09:00
Dean Herbert	01750dd091	Update metrics of checkboxes and backgrounds to match design better	2023-07-14 14:29:02 +09:00
Dean Herbert	5b2e704264	Move beat divisor control inside of TimelineArea and adjust metrics to match design	2023-07-14 14:19:04 +09:00
Dean Herbert	ebaf63b764	Apply NRT to timeline related classes	2023-07-14 14:04:12 +09:00
Dean Herbert	56acc9e3dd	Change BeatDivisorControl to retrive bindable divisor via DI	2023-07-14 14:03:25 +09:00
Dean Herbert	20e4e2581a	Change IBeatSyncProvider.Clock to always be non-null	2023-07-13 22:13:40 +09:00
Susko3	2dcd790442	Resolve Clipboard via DI	2023-07-11 11:42:31 +02:00
OliBomby	06e5ef88c0	legacy export broken	2023-07-11 02:30:16 +02:00
Bartłomiej Dach	45194b2b4a	Fix pressing Ctrl-C in composer not copying timestamp to system clipboard	2023-07-09 18:21:43 +02:00
Bartłomiej Dach	9eec1337b3	Use slightly different condition for better UX	2023-07-01 21:39:08 +02:00
Bartłomiej Dach	183777f8df	Fix edge cases where selection buttons go outside playfield bounds ... Addresses https://github.com/ppy/osu/discussions/23599#discussioncomment-6300885.	2023-07-01 21:27:17 +02:00
Bartłomiej Dach	e4e08c0f5f	Fix selection handlers eating hotkey presses they didn't handle	2023-06-28 20:48:22 +02:00
Dean Herbert	29376ffcc0	Trigger state change when flipping via hotkey in the editor ... This will trigger a change even if nothing happens. But I think that's okay (not easy to avoid) because the change handler should be aware that nothing changed, if anything. Closes https://github.com/ppy/osu/issues/24065.	2023-06-28 13:52:51 +09:00
Bartłomiej Dach	9be2d9d62e	Fix hotkey presses generating unnecessary undo history ... The buttons don't check whether the operation they correspond to is possible to perform in the current state of the selection box, so not checking `Can{Reverse,Rotate}` causes superfluous undo states to be added without any real changes if an attempt is made to reverse or rotate a selection that cannot be reversed or rotated.	2023-06-27 22:25:04 +02:00
Bartłomiej Dach	17ed45d07c	Mention hotkeys in button tooltips	2023-06-27 22:04:15 +02:00
Bartłomiej Dach	54280f06be	Switch to == true	2023-06-27 22:02:15 +02:00
Bartłomiej Dach	ad3a470eaf	Enable NRT in SelectionBox	2023-06-27 22:01:44 +02:00
Dean Herbert	c6d952abe3	Add support for Ctrl + < / > to rotate selection in editor ... As discussed in https://github.com/ppy/osu/discussions/24048.	2023-06-27 17:01:41 +09:00
Dean Herbert	7ddbf4eaa7	Add a visual effect when keyboard shortcuts are used to trigger selection box buttons	2023-06-27 17:01:13 +09:00
Dean Herbert	df5b389629	Manual fixes to reduce warnings to zero	2023-06-24 01:52:53 +09:00
Dean Herbert	0ab0c52ad5	Automated pass	2023-06-24 01:00:03 +09:00
Dean Herbert	84fc6e92db	Fix slightly incorrect calculations	2023-06-19 20:23:46 +09:00
Dean Herbert	4314f9f46a	Merge branch 'master' into fix-distance-snap-grid-centering	2023-06-19 20:22:09 +09:00
Bartłomiej Dach	28696f595f	Privatise setter	2023-06-16 16:24:07 +02:00
Dean Herbert	d965d39c44	Fix distance snap grid circles not correctly being centered on snap point	2023-06-16 17:21:32 +09:00
Dean Herbert	36954e55ad	Fix incorrect mapping when distance spacing is not 1.0x	2023-06-16 17:15:45 +09:00
Dean Herbert	003949ac4e	Merge branch 'master' into limited-distance-spacing	2023-06-16 16:56:22 +09:00
Dean Herbert	f553efba8a	Fix playback controls in editor handling key repeat when they probably shouldn't ... Closes https://github.com/ppy/osu/issues/23903.	2023-06-14 02:30:15 +09:00
Dean Herbert	78b2e6f3df	Add setting to limit distance snapping to current time ... As discussed in https://github.com/ppy/osu/discussions/23815#discussioncomment-6124116.	2023-06-09 15:54:33 +09:00
Bartłomiej Dach	4b3b22f046	Merge branch 'master' into beat-divisor-better-defaults	2023-06-08 20:35:03 +02:00
Bartłomiej Dach	b66d1aa33d	Fix code quality inspection	2023-06-08 20:32:16 +02:00
Dean Herbert	c1743dbe1d	Select all text when popover is initially shown ... Depends on https://github.com/ppy/osu-framework/pull/5823.	2023-06-09 02:27:22 +09:00
Bartłomiej Dach	281aae91ec	Merge pull request #23808 from peppy/working-beatmap-get-background ... Refactor `IWorkingBeatmap.Background` to `GetBackground()`	2023-06-08 12:23:07 +02:00
Dean Herbert	a842f79ad4	Refactor IWorkingBeatmap.Background to GetBackground()	2023-06-08 16:19:32 +09:00
Bartłomiej Dach	b3ce7f7b43	Merge branch 'master' into fix-section-container-scroll-attempt-2	2023-06-08 09:19:26 +02:00
Bartłomiej Dach	3c8f387a6c	Remove unused method	2023-06-07 23:38:06 +02:00
Bartłomiej Dach	d9281ac8c7	Remove unused virtual spec	2023-06-07 23:38:06 +02:00
Bartłomiej Dach	9b665d2e1a	Merge branch 'master' into beat-snap-divisor-hotkeys	2023-06-07 23:38:03 +02:00
Dean Herbert	3a01498789	Use existing next/previous methods (and remove looping behaviour)	2023-06-08 01:01:29 +09:00
Bartłomiej Dach	1f4e79d79d	Merge pull request #23711 from timiimit/add-last-edit-time ... Store timestamp of beatmap's last edit time in local database	2023-06-07 16:57:24 +02:00
Dean Herbert	2c89af608a	Add ability to cycle beat snap divisor using hotkeys ... Defaults to Ctrl+Shift+Wheel (as per stable). Closes #23785.	2023-06-07 17:15:15 +09:00
Dean Herbert	7d49f5d7c6	Apply NRT to SectionsContainer	2023-06-07 16:32:29 +09:00
Salman Ahmed	62cb6a98ca	Remove redundant nullable suppression directives	2023-06-07 08:20:41 +03:00
Dean Herbert	22f7fe1d79	Rename variable and ensure timestamp is updated even when not saving	2023-06-06 15:11:31 +09:00
Dean Herbert	3a50e0fb2f	Merge branch 'master' into add-last-edit-time	2023-06-06 15:07:20 +09:00
OliBomby	3f96795bbf	fix merge conflict	2023-06-02 01:02:35 +02:00
Olivier Schipper	3f7bebfda4	Merge branch 'master' into edit-nodesample	2023-06-02 00:57:15 +02:00
OliBomby	848f0e305e	Change position of sliderbody hitsound piece for less overlap	2023-06-02 00:55:37 +02:00
OliBomby	da516b9039	Change purple to darker pink	2023-06-02 00:50:21 +02:00
Bartłomiej Dach	c2d89a32a9	Adjust inline comment	2023-06-01 21:18:00 +02:00
Andrei Zavatski	03eb7c7830	Fix nullability	2023-06-01 21:21:01 +03:00
Andrei Zavatski	949fe32740	Use combined area of children as a mask instead	2023-06-01 15:32:17 +03:00
Dean Herbert	32207d4112	Remember the last used custom divisor when cycling divisor types	2023-06-01 17:11:49 +09:00
Dean Herbert	bcde2cbc73	Apply NRT to BeatDivisorControl	2023-06-01 16:58:14 +09:00
OliBomby	eb8ac89513	rename sample update logic and add xmldoc for clarity	2023-06-01 09:50:14 +02:00
OliBomby	1eb9b8e135	added xmldoc and renamed GetSamples	2023-06-01 09:34:21 +02:00
Dean Herbert	f52ed41f10	Use better defaults of 1/4 and 1/6 when cycling types	2023-06-01 16:28:03 +09:00
OliBomby	63d9be9523	merge updateAdditionBankPlaceholderText and updateAdditionBankActivated	2023-06-01 09:27:04 +02:00
OliBomby	9e78a6b34e	hide addition bank field when no additions active	2023-05-31 20:00:45 +02:00
OliBomby	fede432969	Make relevantObject and relevantSamples instance variables	2023-05-31 20:00:19 +02:00
timiimit	a58426dab6	Use LastEditTime in Editor	2023-05-31 19:07:04 +02:00
OliBomby	b7bc49b1f4	Fix regressed bank inheriting behaviour on node samples	2023-05-31 16:28:43 +02:00
OliBomby	7a46b7b961	Invert colors	2023-05-31 14:33:06 +02:00
Andrei Zavatski	d119447a10	Fix editor timeline hitobjects popping in	2023-05-30 16:41:42 +03:00
Dean Herbert	114f12a790	Adjust CreateHitSampleInfo to handle additions correctly, rather than implementing locally	2023-05-30 14:04:02 +09:00
Dean Herbert	4a81d068af	Merge branch 'master' into edit-nodesample	2023-05-30 14:03:43 +09:00
Dean Herbert	725734bc03	Merge pull request #23649 from peppy/keep-selection-buttons-on-screen ... Ensure editor selection buttons remain on screen when selection is near edge	2023-05-26 20:51:45 +09:00
Bartłomiej Dach	96fe7cbe54	Merge branch 'master' into sample-set-controls	2023-05-25 21:58:16 +02:00
Bartłomiej Dach	7d8f08c0ea	Fix ComposeBlueprintContainer briefly assigning auto bank ... Seems to have had no consequence due to the way `AutomaticBankAssignment` works (that flag is checked in `PlacementBlueprint.UpdateTimeAndPosition()`, which runs essentially every frame), but let's avoid putting it there at all ever.	2023-05-25 21:49:29 +02:00
Bartłomiej Dach	3ad5f8b9c9	Polish a few extreme edge cases	2023-05-25 16:39:54 +02:00
Dean Herbert	949de35664	Ensure selection is reset after immediately deleting objects ... Closes https://github.com/ppy/osu/issues/23518.	2023-05-25 23:20:32 +09:00
Bartłomiej Dach	beeca5a8dd	Use alternative layouting implementation	2023-05-25 16:17:44 +02:00
Dean Herbert	1049257b56	Simplify SelectionHandler's DeselectAll implementation ... We are already doing other operations in this class directly on `SelectedItems`, so might as well change this one to match	2023-05-25 18:46:31 +09:00
Dean Herbert	1e14b02493	Fix bindable feedback loop	2023-05-25 17:58:38 +09:00
Bartłomiej Dach	578a0e7494	Merge branch 'master' into beat-divisor-visual-improvements	2023-05-24 22:28:26 +02:00
Bartłomiej Dach	6ec4ecfdd7	Mention fallback default in GetDivisorForBeatIndex()	2023-05-24 22:17:51 +02:00
Dean Herbert	b14b1072c2	Allow deselecting any selection in the editor using the Back binding (escape key)	2023-05-24 19:24:14 +09:00
Dean Herbert	3b9e1e8a94	Ensure editor selection buttons remain on screen when selection is near edge ... Addresses https://github.com/ppy/osu/discussions/23599.	2023-05-24 19:16:53 +09:00
Dean Herbert	3a05dffa50	Add "auto" bank selection during placement	2023-05-24 17:11:12 +09:00
Dean Herbert	fc22c75464	Don't use switch for single case statement	2023-05-24 16:14:05 +09:00
Dean Herbert	a9ba16a2be	Update to support non-control-point sample changes	2023-05-24 14:20:38 +09:00
Dean Herbert	298989ffd2	Merge branch 'master' into sample-set-controls	2023-05-24 14:03:04 +09:00
Dean Herbert	561b759bf9	Tidy up implementation and ensure non-solid ticks start at zero alpha	2023-05-24 13:49:29 +09:00
Dean Herbert	8f1f1955df	Merge pull request #66 from Gyoshi/beat-divisor-visual-improvements ... Add ghost ticks to exhibit current divisor on `BeatDivisorControl`	2023-05-24 13:41:48 +09:00
Gyoshi	7fe19d1992	Last instead of Max divisor to match code elsewhere	2023-05-23 18:45:49 +02:00
Gyoshi	c5ef3ae181	Code styling	2023-05-23 18:44:20 +02:00
Gyoshi	b5f8093941	Use RangePadding to align mouse with slider	2023-05-23 18:16:14 +02:00
Gyoshi	7b1e8ede54	Small format	2023-05-23 15:11:27 +02:00
Gyoshi	1b32370c6a	Remove duplicate code by making GetDivisorForBeatIndex method more general	2023-05-23 15:05:38 +02:00
Gyoshi	37a796306d	Small format & comment	2023-05-23 14:30:35 +02:00
Johannes vd Berg	ebda35c3c9	Add ghost ticks to exhibit current divisor on BeatDivisorControl	2023-05-23 12:57:25 +02:00
Bartłomiej Dach	38b4bd8aef	Fix undo not behaving as expected sometimes	2023-05-22 22:45:39 +02:00
Bartłomiej Dach	e0b7539c2a	Fix sample changes not being applied in patcher	2023-05-22 22:45:23 +02:00
Bartłomiej Dach	f253d17a7f	Fix slider velocity changes not being applied in patcher	2023-05-22 22:19:10 +02:00