mirror of
https://github.com/ppy/osu.git
synced 2024-11-15 02:17:46 +08:00
f13ca28d5e
Closes https://github.com/ppy/osu/issues/28369.
The reporter of the issue was incorrect; it's not the beat snap grid
that is causing the problem, it's something far stupider than that.
When the current selection changes,
`EditorSelectionHandler.UpdateTernaryStates()` is supposed to update the
state of ternary bindables to reflect the reality of the current
selection. This in turn will fire bindable change callbacks for said
ternary toggles, which heavily use `EditorBeatmap.PerformOnSelection()`.
The thing about that method is that it will attempt to check whether any
changes were actually made to avoid producing empty undo states, *but*
to do this, it must *serialise out the entire beatmap to a stream* and
then *binary equality check that* to determine whether any changes were
actually made:
|
||
|---|---|---|
| .. | ||
| Components | ||
| Compose | ||
| Design | ||
| GameplayTest | ||
| Setup | ||
| Timing | ||
| Verify | ||
| BackgroundDimMenuItem.cs | ||
| BeatmapEditorChangeHandler.cs | ||
| BindableBeatDivisor.cs | ||
| BottomBar.cs | ||
| ClipboardContent.cs | ||
| CreateNewDifficultyDialog.cs | ||
| DeleteDifficultyConfirmationDialog.cs | ||
| Editor.cs | ||
| EditorBeatmap.cs | ||
| EditorBeatmapSkin.cs | ||
| EditorChangeHandler.cs | ||
| EditorClipboard.cs | ||
| EditorClock.cs | ||
| EditorLoader.cs | ||
| EditorRoundedScreenSettings.cs | ||
| EditorRoundedScreenSettingsSection.cs | ||
| EditorScreen.cs | ||
| EditorScreenMode.cs | ||
| EditorScreenWithTimeline.cs | ||
| EditorSkinProvidingContainer.cs | ||
| EditorState.cs | ||
| EditorTable.cs | ||
| HitAnimationsMenuItem.cs | ||
| IEditorChangeHandler.cs | ||
| LegacyEditorBeatmapPatcher.cs | ||
| PromptForSaveDialog.cs | ||
| SaveRequiredPopupDialog.cs | ||
| TransactionalCommitComponent.cs | ||
| WaveformOpacityMenuItem.cs | ||