h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-11-11 09:07:52 +08:00
Code Issues Releases Wiki Activity

Adjust code structure slightly

Browse Source
This commit is contained in:
Dean Herbert 2024-03-20 12:52:54 +08:00
parent 7ca45c75b3
commit fd509c82f5
No known key found for this signature in database
1 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
osu.Game/Screens/Edit/Compose/Components/Timeline/TimelineControlPointDisplay.cs
View File

@ -32,10 +32,7 @@ namespace osu.Game.Screens.Edit.Compose.Components.Timeline
controlPointGroups.UnbindAll();
controlPointGroups.BindTo(beatmap.ControlPointInfo.Groups);
controlPointGroups.BindCollectionChanged((_, _) =>
{
invalidateGroups();
}, true);
controlPointGroups.BindCollectionChanged((_, _) => groupCache.Invalidate(), true);
}
protected override void Update()
@ -51,19 +48,20 @@ namespace osu.Game.Screens.Edit.Compose.Components.Timeline
if (visibleRange != newRange)
{
visibleRange = newRange;
invalidateGroups();
groupCache.Invalidate();
}
if (!groupCache.IsValid)
{
recreateDrawableGroups();
groupCache.Validate();
}
}
private void invalidateGroups() => groupCache.Invalidate();
private void recreateDrawableGroups()
{
// Remove groups outside the visible range
foreach (var drawableGroup in this)
foreach (TimelineControlPointGroup drawableGroup in this)
{
if (!shouldBeVisible(drawableGroup.Group))
drawableGroup.Expire();
@ -93,8 +91,6 @@ namespace osu.Game.Screens.Edit.Compose.Components.Timeline
Add(new TimelineControlPointGroup(group));
}
groupCache.Validate();
}
private bool shouldBeVisible(ControlPointGroup group) => group.Time >= visibleRange.min && group.Time <= visibleRange.max;