44435 Commits

Author	SHA1	Message	Date
Dean Herbert	def1abaeca	Fix some tests not always waiting long enough for beatmap loading ... These used to work because there was a huge blocking load operation, which is now more asynchronous. Note that the change made in `SongSelect` is not required, but defensive (feels it should have been doing this the whole time).	2024-08-29 18:42:43 +09:00
Joseph Madamba	ef443b0b5d	Hide pinned comment replies initially to match web	2024-08-28 23:05:15 -07:00
Dean Herbert	1776d38809	Remove loadedTestBeatmaps flag	2024-08-28 23:28:44 +09:00
Dean Herbert	e04b5bb3f2	Tidy up test beatmap loading	2024-08-28 23:28:44 +09:00
Dean Herbert	9123d2cb7f	Fix multiple test failures	2024-08-28 23:28:43 +09:00
Bartłomiej Dach	d49cd717d6	Merge pull request #29576 from peppy/allow-seek-in-more-places ... Allow seeking via music controller overlay on more screens	2024-08-28 12:23:09 +02:00
Dean Herbert	dd4a1104e4	Always debounce external Filter requests (except for tests) ... The only exception to the rule here was "when screen isn't active apply without debounce" but I'm not sure we want this. It would cause a stutter on returning to song select and I'm not even sure this is a common scenario. I'd rather remove it and see if someone finds an actual case where this is an issue.	2024-08-28 19:13:50 +09:00
Dean Herbert	336abadbd1	Allow running initial filter criteria asynchronously ... This reverts a portion of https://github.com/ppy/osu/pull/9539. The rearrangement in `SongSelect` is required to get the initial filter into `BeatmapCarousel` (and avoid the `FilterChanged` event firing, causing a delayed/scheduled filter application).	2024-08-28 19:13:50 +09:00
Dean Herbert	5ed0c6e91a	Remove song select preloading ... Really unnecessary now.	2024-08-28 19:13:49 +09:00
Dean Herbert	c2c1dccf2d	Detach beatmap sets asynchronously	2024-08-28 19:13:49 +09:00
Dean Herbert	b1f653899c	Fix enumeration over modified collection	2024-08-28 19:13:49 +09:00
Dean Herbert	81b36d897d	Fix null reference in change handling code	2024-08-28 19:13:49 +09:00
Dean Herbert	081c9eb21b	Fix incorrect cancellation / disposal handling of DetachedBeatmapStore	2024-08-28 17:21:19 +09:00
Fabep	6adaf6a41f	Changed ModCustomisationPanelState names	2024-08-28 10:09:47 +02:00
OliBomby	cadbb0f27a	change sample seek keybind to ctrl shift	2024-08-28 09:57:13 +02:00
Fabep	be0e2efda2	Removed on click event for expanding the Mod Customisation Header.	2024-08-28 09:51:17 +02:00
Dean Herbert	4d42274771	Use bindable list implementation	2024-08-28 16:03:37 +09:00
Dean Herbert	466ed5de78	Add basic detached beatmap store	2024-08-28 16:03:37 +09:00
Dean Herbert	eb70a1b72d	Change middle text to only animate initially	2024-08-28 15:57:42 +09:00
Dean Herbert	47a52d10eb	Revert "Add slight parallax to centre content" ... This reverts commit 90d06d4496.	2024-08-28 15:32:59 +09:00
OliBomby	b5b4f915a9	Automatic seek to sample point on right-click	2024-08-27 19:40:33 +02:00
OliBomby	1117fd56a1	change default seek hotkeys	2024-08-27 19:40:18 +02:00
OliBomby	daad476593	Add float comparison leniency just in case	2024-08-27 19:04:16 +02:00
OliBomby	71044a0766	fix difference in sample time calculation	2024-08-27 19:02:40 +02:00
Bartłomiej Dach	a3b0ff4808	Merge branch 'master' into break-overlay-animation	2024-08-27 11:17:56 +02:00
Bartłomiej Dach	321e509f11	Merge pull request #29615 from peppy/break-overlay-improvements ... Add shadow around break overlay middle content to make sure it remains visible	2024-08-27 11:16:08 +02:00
Dean Herbert	90d06d4496	Add slight parallax to centre content	2024-08-27 16:37:27 +09:00
Bartłomiej Dach	8d7053d367	Merge pull request #29560 from peppy/fix-daily-challenge-intro-mod-display ... Fix mod icons potentially showing incorrectly at daily challenge intro	2024-08-27 09:37:11 +02:00
Dean Herbert	6f1664f0a6	Add beat-synced animation to break overlay ... I've been meaning to make the progress bar synchronise with the beat rather than a continuous countdown, just to give the overlay a bit more of a rhythmic feel. Not completely happy with how this feels but I think it's a start? I had to refactor how the break overlay works in the process. It no longer creates transforms for all breaks ahead-of-time, which could be argued as a better way of doing things. It's more dynamically able to handle breaks now (maybe useful for the future, who knows).	2024-08-27 16:34:37 +09:00
Dean Herbert	98faa07590	Apply NRT to BreakOverlay	2024-08-27 15:01:51 +09:00
Dean Herbert	797b020747	Add shadow around break overlay middle content to make sure it remains visible	2024-08-27 15:01:50 +09:00
Dean Herbert	abdbe510b8	Move break overlay (and cursor) further forward in depth ... I didn't really want to move the cursor in front of the HUD, but we face a bit of an impossible scenario otherwise (it should definitely be in front of the break overlay for visibility). So I'll deal with it for now.	2024-08-27 14:52:11 +09:00
Dean Herbert	84bceca778	Assume we can always fetch the ruleset	2024-08-26 15:38:58 +09:00
clayton	70d08b9e97	Increase mod icon acronym font weight	2024-08-25 20:42:57 -07:00
clayton	2bb72762ad	Use more contrasting color for mod icon foreground	2024-08-25 20:42:34 -07:00
Salman Ahmed	b54487031a	Add DailyChallengeButton for intro played flag reset logic	2024-08-24 22:19:17 +09:00
Jonas Brandstötter	89a4025c01	Fix Daily Challenge play count using a different colour than osu-web	2024-08-24 11:21:28 +02:00
Dean Herbert	885d832e98	Fix deserialise failing with some old skins	2024-08-23 20:44:45 +09:00
Dean Herbert	1e39af8ac5	Add a bit of logging around medal awarding ... Might help with https://github.com/ppy/osu/issues/29119.	2024-08-23 19:49:24 +09:00
Dean Herbert	2a479a84dc	Remove conditional inhibiting seek when beatmap change is not allowed ... In testing I can't find a reason for this to exist. Blaming back shows that it existed before we had `AllowTrackControl` and was likely being used as a stop-gap measure to achieve the same thing. It's existed since over 6 years ago. Let's give removing it a try to fix some usability concerns? Closes https://github.com/ppy/osu/issues/29563.	2024-08-23 18:21:31 +09:00
Dean Herbert	60271fb0f7	Merge pull request #29564 from peppy/skinnable-components-what-2 ... Remove requirement of `base` calls to ensure user skin container layouts are retrieved	2024-08-23 17:52:46 +09:00
Dean Herbert	48cfd77ee8	Component -> Lookup	2024-08-23 14:48:50 +09:00
OliBomby	2de5ecceb8	Merge remote-tracking branch 'upstream/master' into scroll-speed-std	2024-08-22 20:17:14 +02:00
OliBomby	ad8e7f1897	Fix scroll speed visualisation missing on start kiai effect points ... They were being drawn far offscreen because the width of the kiai multiplied with the X coordinate of the scroll speed vis.	2024-08-22 20:17:09 +02:00
OliBomby	998b5fdc12	Add property EditorShowScrollSpeed to Ruleset	2024-08-22 19:53:34 +02:00
OliBomby	adbdb39e9f	move public member to top of file	2024-08-22 19:18:38 +02:00
OliBomby	0db068e423	allow repeating on seek actions	2024-08-22 19:15:53 +02:00
Bartłomiej Dach	bd6943ebc2	Merge pull request #29537 from normalid-awa/feature/song-select/allow-copy-url-from-context-menu ... Allow copying beatmap link in song select carousel context menu	2024-08-22 14:03:39 +02:00
Dean Herbert	46d55d5e61	Remove remaining early base lookup calls which were missed	2024-08-22 20:13:28 +09:00
Bartłomiej Dach	b3e961f6c5	Merge pull request #29562 from peppy/remove-migration-leftover-message ... Remove "leftover files" notification when migration partly fails	2024-08-22 12:32:44 +02:00
Dean Herbert	58552e9768	Add missing user ruleset to link copying for beatmap panels	2024-08-22 19:18:41 +09:00
Dean Herbert	1435fe24ae	Remove requirement of base calls to ensure user skin container layouts are retrieved	2024-08-22 19:14:30 +09:00
Bartłomiej Dach	a32a817305	Merge pull request #29512 from peppy/toolbar-pp-change-weird ... Fix toolbar PP change showing `+0` instead of `0`	2024-08-22 12:08:12 +02:00
Dean Herbert	b57b8168a6	Rename Target lookup to Component	2024-08-22 19:00:28 +09:00
Dean Herbert	9a21174582	Move GlobalSkinnableContainers to global scope	2024-08-22 18:46:07 +09:00
Dean Herbert	36b4013fa6	Rename GameplaySkinComponentLookup -> SkinComponentLookup	2024-08-22 18:46:03 +09:00
Dean Herbert	f37cab0c6e	Rename SkinComponentsContainerLookup to GlobalSkinnableContainerLookup	2024-08-22 18:39:36 +09:00
Bartłomiej Dach	1859e173f2	Fix EVEN MORE code quality inspections!	2024-08-22 11:16:24 +02:00
Bartłomiej Dach	9997271a6a	Fix more code quality inspections	2024-08-22 10:49:24 +02:00
Dean Herbert	41756520b1	Rename SkinComponentsContainer to SkinnableContainer	2024-08-22 17:42:50 +09:00
Bartłomiej Dach	9020739f36	Remove unused using directives	2024-08-22 10:05:45 +02:00
Dean Herbert	67f0ea5d7d	Fix flooring causing delta to not work as expected	2024-08-22 16:22:00 +09:00
Dean Herbert	b3be04aff1	Remove "leftover files" notification when migration partly fails ... People were deleting files they shouldn't, causing osu! to lose track of where the real user files are. For now let's just keep things simple and not let the users know that some files got left behind. Usually the files which are left behind are minimal and it should be fine to leave this up to the user. Closes https://github.com/ppy/osu/issues/29505.	2024-08-22 16:09:11 +09:00
Bartłomiej Dach	df94c22a29	Merge pull request #29545 from peppy/timeline-redesign-in-circles ... Further timeline usability tweaks	2024-08-22 08:39:34 +02:00
Dean Herbert	7e483bbee3	Merge pull request #29541 from frenzibyte/fix-mod-customisation-dragging-outside ... Keep mod customisation panel open when dragging outside	2024-08-22 15:28:32 +09:00
Bartłomiej Dach	d33f4837fa	Merge pull request #29532 from bdach/redesign-timing-table-tracking ... Redesign timing table tracking	2024-08-22 08:21:39 +02:00
Dean Herbert	066c34e950	Merge pull request #29553 from bdach/local-cache-updates ... Add support for retrieving submit/rank date from local metadata cache in version 2	2024-08-22 14:55:43 +09:00
Dean Herbert	9df12e3d87	Move seek button to left to differentiate mutating operations	2024-08-22 14:15:36 +09:00
Dean Herbert	54e5f1c9f0	Merge pull request #29556 from frenzibyte/kiai-star-bursts ... Add star fountains/bursts when entering kiai mode in gameplay	2024-08-22 14:14:25 +09:00
Dean Herbert	f068b7a521	Move copy-to-url method to OsuGame to centralise toast popup support	2024-08-22 14:03:41 +09:00
Dean Herbert	7f5f3a4589	Fix mod icons potentially showing incorrectly at daily challenge intro ... Prefer using the beatmap's rulesets over the current user selection. Closes https://github.com/ppy/osu/issues/29559.	2024-08-22 13:57:19 +09:00
Salman Ahmed	922814fab3	Fix flag reset on connection dropouts	2024-08-22 06:00:37 +09:00
Salman Ahmed	1efa6b7221	Merge if branches	2024-08-22 05:40:43 +09:00
Salman Ahmed	fc02b4b942	Alter NRT usage	2024-08-22 05:39:57 +09:00
Dean Herbert	ac5a3a0959	Remove one unused parameter	2024-08-22 02:17:11 +09:00
Dean Herbert	87123d99bf	Move URL implementation to extension methods and share with other usages	2024-08-22 02:08:01 +09:00
Dean Herbert	18a3ab2ffd	Use "link" instead of "URL"	2024-08-22 01:45:43 +09:00
Dean Herbert	a943000579	Merge pull request #29435 from OliBomby/improve-snaps ... Fix timeline snapping ignoring nearby timing points	2024-08-22 01:36:30 +09:00
Dean Herbert	fb5fb78fd3	Move zero marker below control points to avoid common overlap scenario	2024-08-22 01:09:22 +09:00
Dean Herbert	843b10ef34	Add back incorrectly removed control point display toggle	2024-08-22 01:05:47 +09:00
Dean Herbert	2876cb73bd	Merge pull request #28991 from Layendan/master ... Add collection and favourite buttons to results screen	2024-08-21 23:59:26 +09:00
Bartłomiej Dach	5f88435d96	Add support for retrieving submit/rank date from local metadata cache in version 2 ... Closes https://github.com/ppy/osu/issues/22416.	2024-08-21 15:42:22 +02:00
OliBomby	423feadd64	Revert "add arrow indicator" ... This reverts commit 1ce9e97fd4.	2024-08-21 14:12:58 +02:00
Bartłomiej Dach	28d0a24555	Fix the fix ... The more proper way to do this would be to address the underlying issue, which is https://github.com/ppy/osu/issues/29546, but let's do this locally for now.	2024-08-21 12:27:56 +02:00
OliBomby	eefd7cf083	add back protection against perfect curve segments with > 3 points	2024-08-21 12:03:15 +02:00
Salman Ahmed	c92af71029	Add in-gameplay version of kiai star fountains/burst	2024-08-21 17:34:38 +09:00
jkh675	3d5b57454e	Fix null reference	2024-08-21 16:21:49 +08:00
Dean Herbert	fef56cc29e	Remove expanding behaviour of timeline completely	2024-08-21 16:57:52 +09:00
Dean Herbert	7e6490133d	Adjust visuals of tick display (and fine tune some other timeline elements)	2024-08-21 16:46:14 +09:00
Dean Herbert	1a48a6f654	Reduce size of hit objects on timeline	2024-08-21 16:46:13 +09:00
Dean Herbert	3065f808a7	Simplify timing point display on timeline	2024-08-21 16:46:13 +09:00
Dean Herbert	a0002943a1	Adjust centre marker visuals a bit	2024-08-21 16:46:12 +09:00
Bartłomiej Dach	c4f08b42ab	Use colours to distinguish buttons better	2024-08-21 09:05:33 +02:00
OliBomby	8d72ec8bd6	move timing point binary search back inline	2024-08-21 01:50:52 +02:00
OliBomby	09ca190b8d	re-implement ConvexHull 100% original	2024-08-21 00:10:15 +02:00
OliBomby	1ce9e97fd4	add arrow indicator	2024-08-20 23:38:38 +02:00
OliBomby	ae6d855f8d	Merge remote-tracking branch 'upstream/master' into doubleclick	2024-08-20 23:19:27 +02:00
Salman Ahmed	637c9aeef0	Add DailyChallengeIntroPlayed session static	2024-08-21 03:37:04 +09:00
Salman Ahmed	b7599dd1f8	Keep mod customisation panel open when dragging a drawable	2024-08-21 03:23:23 +09:00
Salman Ahmed	0d358a1dae	Fix resume overlay appearing behind HUD/skip overlays	2024-08-21 02:53:11 +09:00
jkh675	8e273709f1	Implement copy url in beatmap and beatmap set carousel	2024-08-20 22:48:11 +08:00
Dan Balasescu	5bb94000d3	Merge pull request #29534 from bdach/fix-divisor-crash ... Fix crash on attempting to edit particular beatmaps	2024-08-20 22:06:32 +09:00
Dan Balasescu	44213a34ae	Merge pull request #29508 from peppy/hold-for-menu-sometimes ... Change "hold for menu" button to only show for touch by default	2024-08-20 21:45:50 +09:00
Bartłomiej Dach	c2dd2ad978	Clamp beat divisor to sane range when decoding ... In my view this is a nice change, but do note that on its own it does nothing to fix https://github.com/ppy/osu/issues/29492, because of `BeatmapInfo` reference management foibles when opening the editor. See also: https://github.com/ppy/osu/issues/20883#issuecomment-1288149271, https://github.com/ppy/osu/pull/28473.	2024-08-20 13:52:29 +02:00
Bartłomiej Dach	bb964e32fa	Fix crash on attempting to edit particular beatmaps ... Closes https://github.com/ppy/osu/issues/29492. I'm not immediately sure why this happened, but some old locally modified beatmaps in my local realm database have a `BeatDivisor` of 0 stored, which is then passed to `BindableBeatDivisor.SetArbitraryDivisor()`, which then blows up. To stop this from happening, just refuse to use values outside of a sane range.	2024-08-20 13:51:58 +02:00
Bartłomiej Dach	c9f1ef5361	Fix incorrect bank set / sample addition logic ... Closes https://github.com/ppy/osu/issues/29361. Typical case of a few early-returns gone wrong leading to `NodeSamples` not being checked correctly.	2024-08-20 12:37:01 +02:00
Dean Herbert	a633fcdb49	Merge branch 'master' into redesign-timing-table-tracking	2024-08-20 19:16:03 +09:00
Bartłomiej Dach	f0ddb6daa4	Merge pull request #29445 from OliBomby/transparent-break ... Make break periods in bottom timeline transparent	2024-08-20 11:46:02 +02:00
Bartłomiej Dach	a33294ac42	Redesign timing table tracking ... - On entering the screen, the timing point active at the current instant of the map is selected. This is the *only* time where the selected point is changed automatically for the user. - The ongoing automatic tracking of the relevant point after the initial selection is *gone*. Even knowing the fact that it was supposed to track the supposedly relevant "last selected type" of control point, I always found the tracking to be fairly arbitrary in how it works. Removing this behaviour also incidentally fixes https://github.com/ppy/osu/issues/23147. In its stead, to indicate which timing groups are having an effect, they receive an indicator line on the left (coloured using the relevant control points' representing colours), as well as a slight highlight effect. - If there is no control point selected, the table will autoscroll to the latest timing group, unless the user manually scrolled the table before. - If the selected control point changes, the table will autoscroll to the newly selected point, *regardless* of whether the user manually scrolled the table before. - A new button is added which permits the user to select the latest timing group. As per the point above, this will autoscroll the user to that group at the same time.	2024-08-20 11:14:42 +02:00
Dean Herbert	bccc797bcb	Move break display to background of summary timeline	2024-08-20 17:45:44 +09:00
Bartłomiej Dach	373ff47a94	Remove dead row attribute classes ... These aren't shown on the control point table since difficulty and sample control points were moved into objects.	2024-08-20 09:53:40 +02:00
Layendan	59ba48bc81	Fix crash if favourite button api request fails	2024-08-19 07:58:20 -07:00
Bartłomiej Dach	588a36cba3	Remove unused variable	2024-08-19 14:58:12 +02:00
Bartłomiej Dach	7693d4c039	Merge branch 'master' into master	2024-08-19 14:30:20 +02:00
Dean Herbert	610ebc5481	Fix toolbar PP change showing +0 instead of 0	2024-08-19 20:50:11 +09:00
Dean Herbert	6985e2e657	Increase default visibility on touch platforms	2024-08-19 20:32:05 +09:00
Dean Herbert	005b1038a3	Change "hold for menu" button to only show for touch by default	2024-08-19 20:23:25 +09:00
Bartłomiej Dach	24a0a3c47f	Merge pull request #29476 from EVAST9919/buffered-editor-grid ... Improve draw performance of editor grids	2024-08-19 12:44:08 +02:00
Dan Balasescu	03188e40ee	Merge pull request #29504 from peppy/skin-editor-fix-sidebar-reload ... Fix skin editor components sidebar not reloading when changing skins	2024-08-19 18:13:52 +09:00
Bartłomiej Dach	42675be6cf	Merge branch 'master' into additions	2024-08-19 11:13:43 +02:00
Bartłomiej Dach	32821be046	Make "double ternary button" specific to samples ... We can generalise *when* there is the need to generalise. So far the generalisation only looked like *obfuscation*.	2024-08-19 11:13:29 +02:00
Dan Balasescu	c18f7a239c	Merge pull request #29474 from peppy/fix-legacy-combo-counter-animation-dead ... Fix legacy combo counter bounce animation not always playing	2024-08-19 18:09:57 +09:00
Bartłomiej Dach	55e9bb6a5d	Privatise setter	2024-08-19 10:59:47 +02:00
Dean Herbert	1bd2f4c6a2	Fix skin editor components sidebar not reloading when changing skins ... Closes https://github.com/ppy/osu/issues/29098.	2024-08-19 15:45:18 +09:00
Dean Herbert	4a3f4c3a55	Don't duck music when effect volume is set to zero ... Addresses https://github.com/ppy/osu/discussions/28984.	2024-08-19 14:46:50 +09:00
Dean Herbert	e75ae4a37b	More hardening of TestMultiplayerClient to attempt to fix test failures	2024-08-19 04:04:24 +09:00
Joseph Madamba	6dd08e9a96	Fix beatmap carousel panels not blocking hover of other panels in song select	2024-08-17 11:45:54 -07:00
Andrei Zavatski	3cd5820b5b	Make PositionSnapGrid a BufferedContainer	2024-08-17 10:34:39 +03:00
Dean Herbert	04a2d67ca4	Fix legacy combo counter bounce animation not always playing ... As mentioned [in discord](https://discord.com/channels/188630481301012481/1097318920991559880/1274231995261649006).	2024-08-17 15:13:44 +09:00
Andrei Zavatski	f74263db81	Remove extra box in OnlinePlayBackgroundScreen	2024-08-17 01:01:51 +03:00
Dean Herbert	d1d195cf18	Fix incorrect skin lookup shortcutting causing sprites to no longer work	2024-08-17 02:33:52 +09:00
OliBomby	621c4d65a3	Hide scroll speed in effect row attribute	2024-08-16 14:43:33 +02:00
OliBomby	b253d8ecbf	Hide scroll speed in bottom timeline	2024-08-16 14:43:09 +02:00
OliBomby	a2e26ba9ff	Fix perfect curve anchors losing type between reloads	2024-08-16 14:24:55 +02:00
OliBomby	4cc38cea63	fix last anchor converting to implicit segment	2024-08-16 14:24:03 +02:00
OliBomby	5624c1d304	Make break periods in bottom timeline transparent	2024-08-16 13:22:09 +02:00
OliBomby	e5fab9cfbe	Remove select action to end placement	2024-08-16 11:55:07 +02:00
Joseph Madamba	e2bf02cf94	Fix preview play button having incorrect click area	2024-08-15 22:49:12 -07:00
Joseph Madamba	fda17a5a72	Expose BeatmapCardNormal height const	2024-08-15 22:49:12 -07:00
OliBomby	3565a10ea2	fix confusing return statement at the end	2024-08-16 01:45:28 +02:00
OliBomby	3a84409546	Use TimingPointAfter for seeking check	2024-08-16 01:36:51 +02:00
OliBomby	2e11172e8e	Take into account next timing point when snapping time	2024-08-16 01:01:24 +02:00
OliBomby	ac064e814f	Add BinarySearchUtils	2024-08-16 00:15:40 +02:00
Joseph Madamba	c3600467bf	Make collection button test less broken	2024-08-15 11:49:15 -07:00
Dan Balasescu	52c1858bbe	Merge pull request #29428 from peppy/update-editor-menu-items-difficulty-change ... Ensure the "Change Difficulty" menu uses up-to-date difficulty names	2024-08-16 00:44:59 +09:00
Dean Herbert	5710f0f302	Merge pull request #26254 from frenzibyte/mania-combo-counter ... Add argon/classic osu!mania combo counter	2024-08-15 17:56:28 +09:00
Dean Herbert	b5f615882f	Ensure the "Change Difficulty" menu uses up-to-date difficulty names ... Closes https://github.com/ppy/osu/issues/29391.	2024-08-15 17:25:30 +09:00
Dean Herbert	4b279ecaa8	Fix mistake	2024-08-15 16:44:15 +09:00
Dean Herbert	26da2c0637	Update MultiplayerClient test output with new knowledge	2024-08-15 16:16:48 +09:00
Dean Herbert	9dc496d6a7	Merge pull request #29415 from Joehuu/difficulty-name-content ... Implement song select v2 difficulty name content component	2024-08-15 15:20:52 +09:00
Salman Ahmed	3a4546d62d	Remove x symbol from argon mania combo counter	2024-08-15 15:08:35 +09:00
Dean Herbert	054366b25d	Use zero baseline for legacy sprite text display	2024-08-15 13:07:42 +09:00
Dan Balasescu	8bfb5cedc4	Merge pull request #29406 from peppy/fix-skin-change-crash ... Fix crash on changing skins when classic mod is enabled and game is rewound	2024-08-15 01:04:32 +09:00
Dean Herbert	28ab65243d	Remove daily challenge tooltip from main menu ... Now that we have a nice intro screen for the daily challenge, it's generally thought that we want to "spoil" the beatmap until the intro is shown. Also I was never a huge fan of having a tooltip on a main menu button.. just feels a bit odd.	2024-08-14 20:45:27 +09:00
Dean Herbert	58d9a4adba	Merge pull request #29414 from smoogipoo/fix-daily-challenge-2 ... Add localisation for daily challenge day/week units	2024-08-14 18:45:12 +09:00
Joseph Madamba	11bd0c9a61	Inline single-frame layout issue comment instead	2024-08-14 00:41:43 -07:00
Joseph Madamba	c24f1444f9	Directly resolve IBindable<WorkingBeatmap> by making a local variant of DifficultyNameContent	2024-08-13 23:26:18 -07:00
Joseph Madamba	2b41f71fd0	Workaround single-frame layout issues with {Link|Text|Fill}FlowContainers	2024-08-13 23:26:17 -07:00
Joseph Madamba	625c6fc7eb	Implement song select v2 difficulty name content component	2024-08-13 23:26:17 -07:00
Dean Herbert	e465049050	Merge branch 'master' into mania-combo-counter	2024-08-14 15:12:00 +09:00
Dan Balasescu	f882ad4a53	Add localisation for daily challenge day/week units	2024-08-14 15:10:55 +09:00
Dean Herbert	78ef436ea0	Update test debug output to test second scenario	2024-08-14 12:23:47 +09:00
OliBomby	10f2ac6490	fix anti-aliased white leaking out of the button	2024-08-13 22:13:17 +02:00
OliBomby	2abcdd0064	Redesign sample bank toggles	2024-08-13 22:05:01 +02:00
Dean Herbert	2221c4891f	Remove legacy non-pooled pathway to DrawableJudgement	2024-08-13 21:03:00 +09:00
Dean Herbert	bb0c9e2497	Add log output when judgements aren't being pooled	2024-08-13 20:57:23 +09:00
Dean Herbert	d74ac57092	Never call prepareDrawables from unsafe context ... I can't mentally figure out *what* is causing the issue here, but in the case where `prepareDrawables` is called from `JudgementBody.OnSkinChanged` (only happens in a non-pooled scenario), things go very wrong. I think a smell test is enough for anyone to agree that the flow was very bad. Removing this call doesn't seem to cause any issues. `runAnimation` should always be called in `PrepareForUse` (both pooled and non-pooled scenarios) so things should still always be in a correct state. Closes #29398.	2024-08-13 20:57:20 +09:00
OliBomby	b187062747	clarify meaning of flip axis vector	2024-08-13 12:58:52 +02:00
Salman Ahmed	c9b2a5bb9c	Fix user profile overlay colour resetting when changing rulesets	2024-08-13 13:03:31 +03:00
Dan Balasescu	513a666847	Merge pull request #29401 from CloneWith/patch/wiki-locale ... Automatically use in-game language for wiki pages	2024-08-13 17:18:29 +09:00
Dan Balasescu	3f02869bcc	Enable NRT while we're here	2024-08-13 16:08:06 +09:00
Dan Balasescu	4b4f0ecf7d	Merge pull request #29342 from cl8n/remove-mania-action-special ... Remove "Special" `ManiaAction`s for center columns	2024-08-13 15:36:36 +09:00
Dan Balasescu	cd76f474d8	Merge pull request #29388 from cl8n/fix-mania-replay ... Fix error on parsing osu!mania replays with 18 or more keys	2024-08-13 15:29:53 +09:00
CloneWith	ca91726190	Reload wiki page on language change	2024-08-13 13:34:11 +08:00
CloneWith	64468bce6d	Merge github.com:ppy/osu into patch/wiki-locale	2024-08-13 11:51:14 +08:00
CloneWith	7cbb4ab6f1	Get in-game locale for wiki pages	2024-08-13 11:50:33 +08:00
Dean Herbert	16f6e26c2e	Merge pull request #29372 from ArijanJ/song-progress-optional-time ... Add option to hide song progress time/text	2024-08-13 00:57:15 +09:00
Bartłomiej Dach	06c2952fe8	Merge branch 'master' into grids-3	2024-08-12 13:55:35 +02:00
Dean Herbert	b567ab2a39	Fix context menus sometimes not being clickable at song select ... Closes https://github.com/ppy/osu/issues/21602.	2024-08-12 20:31:20 +09:00
Bartłomiej Dach	92bd123ebc	Merge pull request #29363 from peppy/fix-daily-challenge-notification-spam ... Fix daily challenge notification spam	2024-08-12 12:18:38 +02:00
Bartłomiej Dach	96bd374b18	Change notification interval to 30 minutes	2024-08-12 11:24:59 +02:00
Bartłomiej Dach	54a1d79136	Clean up some naming weirdness	2024-08-12 11:23:36 +02:00
Bartłomiej Dach	041c70e4eb	Fix tests	2024-08-12 11:19:02 +02:00
Bartłomiej Dach	306e84c7ac	Move disposal method to more expected location	2024-08-12 10:46:58 +02:00
clayton	9620c58751	Fix mouseX legacy replay parsing for high key counts in mania	2024-08-11 09:45:43 -07:00
ArijanJ	fed5b9d747	Fix one more inspectcode warning	2024-08-10 09:45:30 +02:00
ArijanJ	d01e76d9db	Fix double blank line	2024-08-09 23:08:22 +02:00
ArijanJ	2dee8bef7e	Add option to hide song progress time/text	2024-08-09 22:50:37 +02:00
Dean Herbert	df43263e38	Merge branch 'master' into daily-challenge-intro-sfx	2024-08-10 02:22:48 +09:00
Dean Herbert	c29b40ae65	Update resources	2024-08-10 02:08:02 +09:00
Dean Herbert	81777f22b4	Update framework	2024-08-10 00:11:39 +09:00
Jamie Taylor	c6fa348d82	Add sound design for daily challenge intro animation	2024-08-09 23:05:33 +09:00
Dean Herbert	3896a081a5	Update framework	2024-08-09 22:50:56 +09:00
Dean Herbert	bb7cea2417	Merge pull request #29346 from peppy/move-mute-button ... Move mute button to master volume circle	2024-08-09 21:16:47 +09:00
Dan Balasescu	179a3ad8dd	Hack around the border looking ugly ... This is an o!f issue because borders are applied into the individual sprites of the container via masking, rather than being isolated to the container itself. In this case, it'll be applied to the "flash" sprite, which is using additive blending, causing further issues.	2024-08-09 19:55:57 +09:00
Dean Herbert	fa9a835eb5	Make icon smaller	2024-08-09 19:29:23 +09:00
Dan Balasescu	104942ccf6	Merge pull request #29362 from peppy/dont-truncate-floating-point-positioning ... Fix hit object coordinates being truncated to `int` values	2024-08-09 19:10:24 +09:00
Dan Balasescu	dc3e6c1e6b	Merge pull request #29366 from peppy/editor-inspector-during-placement ... Show object inspector values during placement	2024-08-09 19:03:10 +09:00
Dean Herbert	3e634a14a4	Add temporary debug code for multiplayer test failures	2024-08-09 18:43:37 +09:00
Dean Herbert	8fdd94090b	Show object inspector values during placement	2024-08-09 18:02:37 +09:00
Dean Herbert	f6ada68e47	Fix migration failure due to change in class name	2024-08-09 17:27:39 +09:00
Dean Herbert	e146c8e230	Ensure only one daily challenge notification is fired per room	2024-08-09 17:11:11 +09:00
Dean Herbert	52b2d73e04	Only show daily challenge notification if it started within the last 30 minutes	2024-08-09 17:10:18 +09:00
Dean Herbert	d072c6a743	Fix hit object coordinates being truncated to int values ... Closes https://github.com/ppy/osu/issues/29340.	2024-08-09 16:34:39 +09:00
Dean Herbert	161734af95	Simplify argon mania combo counter implementation by sharing with base counter	2024-08-09 15:46:57 +09:00
Dean Herbert	7666e8b932	Remove SupportsClosestAnchor for the time being ... This may have had a good reason to be added, but I can't find that reason, so let's keep things simple for the time being.	2024-08-09 15:30:21 +09:00
Dean Herbert	80c814008f	Update in line with new changes	2024-08-09 14:55:01 +09:00
Dean Herbert	e645651ef4	Merge branch 'master' into mania-combo-counter	2024-08-09 00:19:17 +09:00
Dean Herbert	0cb3b6a1f8	Add back TrySetDailyChallengeBeatmap call for safety	2024-08-08 22:10:26 +09:00
Dean Herbert	8eb0ef1e33	Merge branch 'master' into daily-challenge-intro-audio-auto-download	2024-08-08 22:09:21 +09:00
Dean Herbert	d84d0310e0	Move mute button to master volume circle	2024-08-08 22:06:13 +09:00
Dan Balasescu	45c1dfde5e	Merge pull request #29349 from peppy/fix-daily-challenge-async-test-woo ... Fix potential test failure in daily challenge tests	2024-08-08 19:05:39 +09:00
Dean Herbert	dcafee7cb7	Merge pull request #26249 from frenzibyte/ruleset-specific-combo-counter ... Move combo counter to ruleset-specific HUD components container	2024-08-08 17:41:58 +09:00
Dean Herbert	03d543ec99	Fix potential test failure in daily challenge tests ... See https://github.com/ppy/osu/actions/runs/10296877688/job/28500580680.	2024-08-08 16:53:22 +09:00
Dean Herbert	88c5997cb3	Add back removed xmldoc	2024-08-08 16:36:54 +09:00
Dean Herbert	60d383448f	Avoid making non-ruleset transformers in Ruleset.CreateSkinTransformer ... This didn't make any sense, so let's do it a better way.	2024-08-08 16:29:54 +09:00
Dean Herbert	3f3145e109	Start playing music during intro if download finishes early	2024-08-08 15:10:18 +09:00
Dean Herbert	5d66eda982	Add support for automatically downloading daily challenge during the intro display	2024-08-08 15:10:18 +09:00
Dean Herbert	e95d61d4c2	Remove accidental double handling of beatmap availability in DailyChallenge	2024-08-08 15:10:18 +09:00
Dean Herbert	f91a3e9a35	Start playing daily challenge track as part of intro sequence	2024-08-08 15:10:17 +09:00
Dean Herbert	5891780427	Show initial text a bit longer	2024-08-08 14:15:40 +09:00
Dean Herbert	7058fedf42	Merge branch 'master' into daily-challenge-intro-screen-part-2	2024-08-08 14:12:16 +09:00
Dean Herbert	1ee5522a25	Merge branch 'master' into daily-challenge-intro-screen-part-2	2024-08-08 14:08:14 +09:00
Dean Herbert	25dddb694a	And then completely change the animation to a new style	2024-08-08 14:02:43 +09:00
Dean Herbert	f72f5ee7e3	More improvements maybe	2024-08-08 13:29:10 +09:00
Dean Herbert	9bafdeeeff	Improve animation	2024-08-08 13:17:25 +09:00
clayton	8e63c17536	Apply CodeFactor lint	2024-08-07 15:02:53 -07:00
clayton	93e193d719	Add realm migration to remap key bindings	2024-08-07 14:36:04 -07:00
Dean Herbert	b5a19707d0	Merge branch 'master' into additions	2024-08-08 03:31:11 +09:00
Dean Herbert	3c572abaa7	Merge branch 'master' into ruleset-specific-combo-counter	2024-08-08 03:21:52 +09:00
Dean Herbert	8773c2f7eb	Merge pull request #29281 from kstefanowicz/multiplayer-chat-focus-hint ... Add "enter" hint to in-gameplay chatbox placeholder text	2024-08-08 01:29:42 +09:00
Dan Balasescu	089ff559d3	Fix inspection	2024-08-08 00:42:31 +09:00
Dan Balasescu	a06cb9a0de	Merge pull request #29322 from peppy/daily-challenge-import-improvement ... Fix clicking the beatmap import notification at the daily challenge screen exiting to main menu	2024-08-08 00:42:03 +09:00
Dan Balasescu	10f704cc41	Fix xmldoc	2024-08-07 23:50:09 +09:00
Dean Herbert	cfd7f96e76	Add missing exit line causing completely incorrect behaviour	2024-08-07 23:29:24 +09:00
Bartłomiej Dach	f83d43c38b	Get rid of weird method	2024-08-07 14:07:20 +02:00
Bartłomiej Dach	e6d5389608	Merge branch 'master' into hover-open-mod-customise	2024-08-07 14:05:19 +02:00
Bartłomiej Dach	518c1aa5a0	Remove weird Expanded / ExpandedState duality	2024-08-07 14:01:30 +02:00
kstefanowicz	775f76f472	Have placeholder text change while focused	2024-08-07 07:47:35 -04:00
Bartłomiej Dach	437812eebe	Merge pull request #29279 from normalid-awa/bugfix/editor/delete-operation-wont-close-the-menu ... Close context menus when deselecting items in editor	2024-08-07 13:25:13 +02:00
Dean Herbert	e52d80a41b	Add more difficulty information and further tweaks to visuals	2024-08-07 19:08:04 +09:00
Dean Herbert	083fe32d20	Improve feel of animation	2024-08-07 19:07:45 +09:00
Salman Ahmed	a0615a8f18	Frenzi's WIP animation	2024-08-07 19:07:45 +09:00
Dean Herbert	cfccd74441	Add daily challenge intro sequence	2024-08-07 19:07:44 +09:00
Dean Herbert	6870311c1e	Remove requirement of specifying animateOnnter in BackgroundScreen ctor	2024-08-07 19:07:44 +09:00
Dean Herbert	3c05b975a0	Fix clicking the beatmap import notification at the daily challenge screen exiting to main menu	2024-08-07 19:07:43 +09:00
Dean Herbert	43f1fe350d	Fix PresentBeatmap sometimes favouring an already DeletePending beatmap	2024-08-07 19:07:43 +09:00
Dean Herbert	227878b67a	Change default for "automatically download beatmaps" to enabled	2024-08-07 19:06:50 +09:00
Dean Herbert	dccf766ff3	Remove obsoleted download setting	2024-08-07 19:06:50 +09:00
Dean Herbert	b1488fd5b7	Merge pull request #29027 from normalid-awa/feature/skin/legacy-input-overlay ... Add legacy key counter support	2024-08-07 17:48:30 +09:00
Dean Herbert	5a63c25f49	Fix clicking the beatmap import notification at the daily challenge screen exiting to main menu	2024-08-07 14:42:34 +09:00
Dean Herbert	06ff858256	Fix PresentBeatmap sometimes favouring an already DeletePending beatmap	2024-08-07 14:40:52 +09:00
Dean Herbert	a61bf670d8	Highlight mentions in chat	2024-08-07 01:33:56 +09:00
Dean Herbert	9ccd8c906d	Merge branch 'master' into hover-open-mod-customise	2024-08-06 18:35:35 +09:00
Dean Herbert	725dc4de9b	Use transformers for per-skin key counter implementation	2024-08-06 18:17:21 +09:00
Dean Herbert	8619bbb943	Fix legacy key counter's background being visible when intended to be hidden	2024-08-06 16:12:00 +09:00
Dan Balasescu	41d84ea56b	Revert all SkinEditor changes (none required)	2024-08-06 16:11:29 +09:00
Dan Balasescu	c26a664b84	Use InternalChild directly	2024-08-06 16:08:42 +09:00
Dan Balasescu	c574551ee0	Simplify caching	2024-08-06 16:02:36 +09:00
Dean Herbert	90395aea13	Fix incorrect colour fallback handling ... Adds a note about `GetConfig` being stupid.	2024-08-06 15:43:39 +09:00
Dan Balasescu	b91461e661	Refactor + CI fixes	2024-08-06 15:17:52 +09:00
Dean Herbert	c4572ec265	Sanitise font sizes / weights	2024-08-06 15:17:43 +09:00
jkh675	cb877b7675	Close the menu when selecting other object	2024-08-06 13:09:48 +08:00
Dean Herbert	60fc02bb9b	Merge branch 'master' into feature/skin/legacy-input-overlay	2024-08-06 14:05:33 +09:00
Dan Balasescu	d637bbf752	Merge pull request #29286 from peppy/middle-click-delete ... Allow object deletion with middle mouse	2024-08-06 13:38:56 +09:00
jkh675	22ab6f577c	Add back the sample into OsuContextMenu	2024-08-06 12:37:46 +08:00
kstefanowicz	54a8f5b306	Shorten TranslatableString	2024-08-05 11:06:27 -04:00
Dean Herbert	f41bab0eb8	Merge pull request #29210 from normalid-awa/bugfix/visual/long-commet-tooltip-overflow ... Limiting the `OsuTooltip` maximum width to prevent overflow	2024-08-05 18:09:07 +09:00
jkh675	75c0c6a5f9	Make the OsuContextMenu nullable in SelectionHandler	2024-08-05 16:32:49 +08:00
jkh675	6d385c6510	Remove the meaningless OpenMenu method	2024-08-05 16:31:15 +08:00
Dean Herbert	c37f617e1d	Adjust song select info icon size slightly ... Not going to PR this it's just a minor tweak.	2024-08-05 17:21:50 +09:00
Dean Herbert	17eb134797	Merge branch 'master' into bugfix/visual/long-commet-tooltip-overflow	2024-08-05 17:01:20 +09:00
Dean Herbert	0557b9ab79	Allow placement deletion with middle mouse ... This is in addition to Shift + Right-click. I thik middle mouse feels more natural and is a good permanent solution to this issue. Note that this also *allows triggering the context menu from placement mode*. Until now it's done nothing. This may be annoying to users with muscle memory but I want to make the change and harvest feedback. I think showing the context menu is more correct behaviour (although arguably it should return to placement mode on dismiss?).	2024-08-05 14:25:09 +09:00
Dan Balasescu	136cdcfb29	Merge pull request #29059 from frenzibyte/fix-results-fetching-twice ... Fix results screen fetching scores twice when scrolled to edge	2024-08-05 14:23:47 +09:00
Dan Balasescu	f92e2094c1	Adjust localisation string name + formatting	2024-08-05 12:34:24 +09:00
Dean Herbert	419d5a76ce	Merge branch 'master' into fix-pause-in-osu-again	2024-08-05 12:00:21 +09:00
AkiraTenchi	a5a392e9fc	Update FilterQueryParser.cs ... Add sr as an alias for star rating in the search parameters	2024-08-04 19:48:29 +02:00
kstefanowicz	b0757a13c2	Add "enter" hint to chatbox placeholder text while in-game	2024-08-04 12:32:08 -04:00
jkh675	b32d97b4c0	Remove decreapted property	2024-08-04 21:27:25 +08:00
jkh675	2145368d17	Merge EditorContextMenuContainer into OsuContextMenuContainer	2024-08-04 21:00:43 +08:00
jkh675	7c83d6a883	Cleanup code	2024-08-04 19:56:41 +08:00
jkh675	5d31171fb0	Fix code quality	2024-08-04 19:43:43 +08:00
jkh675	3cc5466774	Refactor the code to follow IoC principle and more flexible	2024-08-04 19:39:06 +08:00
jkh675	27d6c4cecb	Implement on beatmap editor	2024-08-04 19:16:14 +08:00
jkh675	5c5fcd7e7e	Allow key event pass through selection handler	2024-08-04 19:11:21 +08:00
jkh675	1ff0c7cb46	Replace original menu container with custom one	2024-08-04 19:10:49 +08:00
jkh675	83aeb27c73	Replace original menu container to the custom one	2024-08-04 19:08:31 +08:00
jkh675	de6d8e7eb7	Add the custom context menu to handle the key event	2024-08-04 19:07:35 +08:00
Joseph Madamba	2daf1b58f2	Allow searching enum descriptions from SettingsEnumDropdowns	2024-08-03 14:48:08 -07:00
Dean Herbert	7765d0ff70	Merge pull request #29157 from frenzibyte/user-profile-daily-challenge-streak-display ... Add daily challenge stats display to user profile overlay	2024-08-03 23:57:19 +09:00
Dean Herbert	d95d63d7ee	Undo localisation of Daily Challenge string for now	2024-08-03 22:44:51 +09:00
Dan Balasescu	040f65432e	Rename variables a bit	2024-08-03 19:40:06 +09:00
Joseph Madamba	4ef9f335ee	Fix customise button on mod overlay initially showing flash layer indefinitely	2024-08-02 10:19:59 -07:00
jkh675	a8141bf15f	Only wrap by per word	2024-08-02 21:50:24 +08:00
Dan Balasescu	7bf96ce49a	Merge pull request #29231 from peppy/timeline-break-behind-objects ... Show breaks behind objects in timeline	2024-08-02 21:28:11 +09:00
Dan Balasescu	8a10d63ddf	Merge pull request #29228 from peppy/fix-leaderboard-v2-insane-allocs ... Fix insane transform allocations in new leaderboard display	2024-08-02 21:28:00 +09:00
Dean Herbert	c27b35ad14	Update framework	2024-08-02 20:58:52 +09:00
Dean Herbert	dc73856f76	Fix original date not being restored when no changes are made on an import-as-update operation	2024-08-02 20:46:03 +09:00
jkh675	8265e7ce31	Reduce the tooltip max width	2024-08-02 19:44:55 +08:00
Caiyi Shyu	c85dc40f91	Merge branch 'master' into hover-open-mod-customise	2024-08-02 19:07:27 +08:00
Dan Balasescu	64b7bab4fb	Fix mod panels overflowing into the column borders	2024-08-02 18:59:21 +09:00
Dean Herbert	76904272e6	Allow horizontal scrolling on mod select overlay anywhere on the screen ... Closes https://github.com/ppy/osu/issues/29248.	2024-08-02 16:56:34 +09:00
Dean Herbert	310def64f4	Merge branch 'master' into user-profile-daily-challenge-streak-display	2024-08-02 15:40:46 +09:00
Dean Herbert	729039406b	Add colouring for play count ... Matches https://github.com/ppy/osu-web/pull/11381.	2024-08-02 15:38:17 +09:00
Dean Herbert	816dee181a	Rename classes to remove "streak" terminology ... Since the primary display isn't showing a streak.	2024-08-02 15:33:30 +09:00
Dean Herbert	d76fc34cf8	Update to use localiastions	2024-08-02 15:33:25 +09:00
Dean Herbert	d9c965c47b	Update resources	2024-08-02 15:27:21 +09:00
Dean Herbert	3c1907ced3	Update LocalisationAnalyser to latest version	2024-08-02 14:53:18 +09:00
jkh675	f6ca4b2339	Replace the OsuSpriteText with TextFlowContainer in OsuTooltip and limit the max width	2024-08-02 12:16:50 +08:00
jkh675	5de37f9cd5	Revert changes	2024-08-02 12:02:28 +08:00
jkh675	894c6150c8	Revert "Update resources" ... This reverts commit cbfb569ad4.	2024-08-02 11:59:28 +08:00
Joseph Madamba	1e38d1fa57	Apply corner radius at a higher level so hover click sounds account for it	2024-08-01 18:45:47 -07:00
Joseph Madamba	0fac8148ed	Fix collection delete button not having hover click sounds	2024-08-01 18:30:52 -07:00
Joseph Madamba	b883ff6c7b	Fix click sounds playing twice on OsuRearrangeableListItem	2024-08-01 18:18:00 -07:00
Caiyi Shyu	051d52c23f	Update ModCustomisationPanel to use ExpandedState enum	2024-08-01 19:25:45 +08:00
Dean Herbert	548fd9cbf9	Show breaks behind objects in timeline ... Closes https://github.com/ppy/osu/issues/29227.	2024-08-01 19:47:44 +09:00
Caiyi Shyu	188ddbcad6	pass ModCustomisationPanel through ctor	2024-08-01 18:38:01 +08:00
Layendan	19a4cef113	update var names and test logic	2024-08-01 02:52:41 -07:00
Dean Herbert	dab967e6be	Fix insane transform allocations in new leaderboard display	2024-08-01 18:36:33 +09:00
Bartłomiej Dach	cd28fa7325	Merge pull request #29211 from peppy/always-show-control-points-timing ... Always show timing points in timeline when at the timing screen	2024-07-31 16:46:55 +02:00
Dean Herbert	5098d637b5	Flash customise button on mod overlay when it becomes available	2024-07-31 19:55:20 +09:00
Dean Herbert	2d52bab77b	Always show timing points in timeline when at the timing screen ... Supersedes https://github.com/ppy/osu/pull/29196.	2024-07-31 19:43:08 +09:00
Dean Herbert	e329427d6e	Apply nullability to Timeline	2024-07-31 19:28:32 +09:00
jkh675	54e73acece	Cleanup code	2024-07-31 17:49:03 +08:00
jkh675	04ecefe226	Remove unused using	2024-07-31 17:23:25 +08:00
Caiyi Shyu	5fb364cad6	remove redundant code added accidentally	2024-07-31 16:56:25 +08:00
Caiyi Shyu	5b46597d56	fix click to expand on touch devices	2024-07-31 16:54:32 +08:00
jkh675	9e03dc3b5e	Implement maximum width on CommentTooltip	2024-07-31 16:52:53 +08:00
Dean Herbert	cbfb569ad4	Update resources	2024-07-31 14:37:56 +09:00
Dean Herbert	e9ed9ff58b	Merge pull request #29188 from bdach/daily-challenge/better-messaging ... Add notification on daily challenge conclusion & start of new one	2024-07-31 13:35:25 +09:00
Layendan	8eeb5ae06b	Fix tests	2024-07-30 17:08:56 -07:00
Layendan	36bd83bb80	Update collection state when users add/remove from collection	2024-07-30 15:22:41 -07:00
Dean Herbert	e77489f2a9	Allow notification of new strings	2024-07-31 03:10:36 +09:00
Dean Herbert	bdc465e1c6	Reword notification text slightly	2024-07-31 03:06:35 +09:00
Dean Herbert	5ebb5ad670	Fix test failure due to TestMetadataClient providing null statistics array	2024-07-31 02:53:10 +09:00
Dean Herbert	7f22ade90d	Fix oversight in timekeeping	2024-07-30 21:59:59 +09:00
Dean Herbert	d75c170ba1	Merge branch 'master' into daily-challenge/better-messaging	2024-07-30 19:04:48 +09:00
Dean Herbert	d5f9173288	Remove unused local variable	2024-07-30 19:04:43 +09:00
Dean Herbert	25747fdeb3	Fix edge case where minutes are same but hour is different	2024-07-30 18:06:56 +09:00
Dean Herbert	7229ae83ea	Adjust sizing and distribution of timestamp and username	2024-07-30 18:03:56 +09:00
Dean Herbert	6670f79258	Reduce overall size of chat text	2024-07-30 18:03:56 +09:00
Dean Herbert	4557ad43d5	Reduce padding on chat lines to give more breathing room	2024-07-30 17:52:56 +09:00
Dean Herbert	a2a73232f3	Avoid showing timestamp in chat line when repeated	2024-07-30 17:52:55 +09:00
Dean Herbert	e63080eb2e	Don't show seconds in chat timestamps	2024-07-30 17:52:54 +09:00
Dean Herbert	71acb7e9fc	Merge pull request #29137 from normalid-awa/feature/visual/chatline-background-altering ... Alternate background colour of chat lines to better visually distinguish wrapped lines	2024-07-30 17:51:41 +09:00
Dean Herbert	c80f338893	Merge pull request #29198 from bdach/fix-difficulty-bindable ... Fix incorrect `DifficultyBindable` logic	2024-07-30 17:50:58 +09:00
Bartłomiej Dach	1b57a2a136	Show new daily challenge notification globally	2024-07-30 10:36:26 +02:00
Dean Herbert	d48849040b	Merge pull request #29182 from bdach/revert-present-score ... Force exit to main menu when presenting scores from within playlists / multiplayer	2024-07-30 17:24:27 +09:00
Dean Herbert	fc78dc9f38	Adjust paddings to avoid scrollbar overlap	2024-07-30 16:45:36 +09:00
Dean Herbert	bf10a91082	Adjust colouring to work better across multiple usages	2024-07-30 16:45:35 +09:00
Bartłomiej Dach	6813f5ee0a	Fix incorrect DifficultyBindable logic	2024-07-30 08:39:20 +02:00
Salman Ahmed	91dfe4515b	Fix daily challenge display showing incorrect statistic	2024-07-30 08:12:03 +03:00
Salman Ahmed	dca61eb76c	Remove no longer used dependency	2024-07-30 07:07:11 +03:00
Salman Ahmed	33fc6dfaff	Hide daily challenge display when not selecting osu! ... Also hide when no user is displayed.	2024-07-30 07:06:59 +03:00
Salman Ahmed	8b910e59f6	Reduce tooltip shadow outline	2024-07-30 06:37:29 +03:00
Salman Ahmed	9868fb4aaa	Remove tier-based colour from the condensed piece to match web	2024-07-30 06:36:02 +03:00
Salman Ahmed	78417db06d	Remove stray line	2024-07-30 06:35:09 +03:00
Salman Ahmed	621f4dfece	Enforce new line between X/Y coordinate in editor position inspector	2024-07-30 02:45:21 +03:00
Dean Herbert	aa2515763c	Merge pull request #29184 from bdach/daily-challenge/wrong-mods-after-replay ... Fix mods persisting after watching replay from daily challenge screen	2024-07-29 23:23:45 +09:00
Bartłomiej Dach	48e38bd467	Merge pull request #29186 from peppy/fix-status-config ... Fix online status not persisting correctly	2024-07-29 16:11:05 +02:00
Bartłomiej Dach	5032a149e7	Merge pull request #29187 from peppy/daily-challenge-pieces-not-always-present ... Favour updating daily challenge statistics when they come on screen	2024-07-29 15:48:26 +02:00
Bartłomiej Dach	3a30ff7817	Merge pull request #29172 from kadambishreyas/handle-timestamp-mod-content ... Handle timestamp mod content	2024-07-29 15:34:50 +02:00
Bartłomiej Dach	12e553a290	Merge pull request #29166 from normalid-awa/bugfix/visual/mod-preset-tooltips-text-being-cutoff ... Fix mod preset tooltip's description text being cut off	2024-07-29 15:19:06 +02:00
Bartłomiej Dach	b46f3c97da	Add notification on daily challenge conclusion & start of new one ... Because I wish to stop seeing "DAILY CHALLENGE WHERE" every day on #general. The notifications are constrained to the daily challenge screen only to not spam users who may not care.	2024-07-29 14:30:10 +02:00
Dean Herbert	7afcd72872	Fix potentially too many scores displaying in breakdown while in gameplay	2024-07-29 20:58:42 +09:00
Dean Herbert	05056f0e8a	Remove no longer required AlwaysPresent definition ... This also reverts commit 7fedfd368c as no-longer-necessary.	2024-07-29 20:43:56 +09:00
Dean Herbert	5a1002c1a0	Ensure score breakdown doesn't spam scores when not visible	2024-07-29 20:43:50 +09:00
Dean Herbert	5bc02cc1c6	Fix background alternating not updating on message removal	2024-07-29 20:25:55 +09:00
Dean Herbert	997b3eb498	Fix typos and visuals	2024-07-29 20:24:51 +09:00
Bartłomiej Dach	8b96b0b9e4	Add logging when starting and stopping watch operations in online metadata client ... For future use with debugging issues like https://github.com/ppy/osu/issues/29138, hopefully.	2024-07-29 13:19:01 +02:00
jkh675	d51a53b051	Preventing the mod icon being squashed up	2024-07-29 19:08:14 +08:00
Dean Herbert	11265538c4	Reset online status on logout	2024-07-29 20:06:30 +09:00
Dean Herbert	c142adf926	Fix online status not persisting correctly ... Regressed at some point. I don't see much reason not to link the bindable directly with config. It seems to work as you'd expect. Tested with logout (resets to "Online") and connection failure (persists). Closes https://github.com/ppy/osu/issues/29173.	2024-07-29 20:06:27 +09:00
Bartłomiej Dach	f1a84a5111	Fix mods persisting after watching replay from daily challenge screen ... Closes https://github.com/ppy/osu/issues/29133. Hope I can be forgiven for no tests. I had a brief try but writing them is going to take hours.	2024-07-29 12:52:30 +02:00
jkh675	8f86681110	Replace OsuSpriteText with TextFlowContainer	2024-07-29 18:29:44 +08:00
jkh675	90fdf5599f	Revert changes	2024-07-29 18:14:07 +08:00
Bartłomiej Dach	cebd38c6eb	Merge pull request #29163 from Joehuu/copy-lb-mods-daily ... Add ability to copy leaderboard mods in daily challenge	2024-07-29 12:09:27 +02:00
Bartłomiej Dach	9b96bd1d73	Force exit to main menu when presenting scores from within playlists / multiplayer ... - Closes https://github.com/ppy/osu/issues/29152 - Partially reverts https://github.com/ppy/osu/pull/29097 - Reopens https://github.com/ppy/osu/issues/26666 When testing I failed to predict that in multiplayer there can be a different beatmap in the playlist queue. If this is the case, `PresentScore()` will exit out to `Multiplayer`, whose `RoomSubScreen` will update the selected item - and thus, the global beatmap - to the next item in queue, at which point trying to play games with "not touching the global beatmap bindable if we don't need to" fail to work, because the bindable *must* be touched for correct operation, yet it cannot (because `OnlinePlayScreen`s disable it). I'm not sure what the fix is here: - making replay player somehow independent of the global beatmap? - not exiting out to multiplayer, but instead doing the present from the results screen itself? if so, then how to ensure the screen stack can't overflow to infinity? so I'm just reverting the broken part. The daily challenge part is left in because as is it should not cause issues.	2024-07-29 12:07:45 +02:00
jkh675	5ec46a79b4	Only create a new drawable object when the background is needed	2024-07-29 17:50:23 +08:00
Bartłomiej Dach	2ff0a89b4f	Convert into auto-property even more	2024-07-29 10:59:21 +02:00
Bartłomiej Dach	861b546562	Add vague test coverage	2024-07-29 10:58:05 +02:00
Bartłomiej Dach	54c904d439	Convert into auto-property	2024-07-29 10:40:29 +02:00
Bartłomiej Dach	aa7f6f81ef	Merge pull request #29127 from Joehuu/add-negative-horizontal-padding-daily ... Fix daily challenge background clipping when settings/notifications is opened	2024-07-29 10:28:48 +02:00
jkh675	63757a77a5	Extract update background method	2024-07-29 13:39:08 +08:00
Shreyas Kadambi	dec6b190f2	Add optional 'suffix' to timestamp	2024-07-28 11:31:36 -04:00
normalid	4e65944609	Make the tooltips width be dyanmic with the content, so the long text wont occurs wierd line break	2024-07-28 16:26:18 +08:00
normalid	5db0e36404	Use the TruncatingSpriteText in ModPresetTooltip	2024-07-28 16:18:43 +08:00
Joseph Madamba	f6eb9037df	Add ability to copy leaderboard mods in daily challenge	2024-07-27 23:55:56 -07:00
Salman Ahmed	7fedfd368c	Fix score breakdown tooltips appearing in other feeds	2024-07-28 07:22:58 +03:00
Salman Ahmed	6bdb1107c1	Add shadow over tooltip	2024-07-28 06:35:00 +03:00
Salman Ahmed	31787757ef	Provide colour scheme as part of tooltip data to handle reusing tooltip with different profile hues	2024-07-28 06:21:23 +03:00
Salman Ahmed	e82c54a31c	Integrate daily challenge streak display with user profile overlay	2024-07-28 05:58:30 +03:00
Salman Ahmed	17f5d58be2	Add daily challenge streak display and tooltip	2024-07-28 05:58:27 +03:00
Salman Ahmed	0c89210bd7	Add API models for daily challenge statistics	2024-07-28 05:24:05 +03:00
Joseph Madamba	bc25e5d706	Remove unnecessary depth and padding set	2024-07-27 19:13:11 -07:00
Joseph Madamba	850bcaef7a	Merge remote-tracking branch 'upstream/master' into pr/28991	2024-07-27 19:09:02 -07:00
Joseph Madamba	334f5fda2d	Remove direct margin set in popover that was causing positioning offset	2024-07-27 19:02:57 -07:00
Joseph Madamba	04b15d0d38	Remove unnecessary ReceivePositionalInputAt ... Results is not even using the new footer.	2024-07-27 19:02:43 -07:00
Joseph Madamba	b4ca07300a	Use same size button for everything	2024-07-27 18:43:54 -07:00
Joseph Madamba	b5ff2dab43	Move some properties/bindables around	2024-07-27 18:42:49 -07:00
Joseph Madamba	aed2b3c7c6	Inherit GrayButton instead ... Also fixes hover highlight.	2024-07-27 18:42:49 -07:00
normalid	4e44a6e7f8	Clean up code	2024-07-27 18:55:17 +08:00
normalid	73a98b45e9	FIx code quality	2024-07-27 18:48:45 +08:00
Caiyi Shyu	77d64e0c3d	replace with ReceivePositionalInputAt	2024-07-27 17:59:38 +08:00
normalid	c2711d0c4e	Implement chatline background altering	2024-07-27 17:25:44 +08:00
Caiyi Shyu	fc842868a9	fix code quality	2024-07-27 16:24:20 +08:00
Caiyi Shyu	b97d96fcb0	Fix panel collapse when hovering dropdown menu	2024-07-27 15:15:14 +08:00
Joseph Madamba	d55e861b90	Fix daily challenge background clipping when settings/notifications is opened	2024-07-26 16:55:15 -07:00
Dean Herbert	565107205c	Merge pull request #29097 from bdach/dont-exit-to-menu-when-presenting-score-in-online ... Don't force exit to main menu when presenting scores from within online screens	2024-07-27 02:46:58 +09:00
Dean Herbert	9323f89357	Fix "Beatmap not downloaded" tooltip hint not showing in daily challenge	2024-07-27 02:06:56 +09:00
Caiyi Shyu	aed81d9758	make code inspector happy	2024-07-26 22:56:07 +08:00
Caiyi Shyu	0cc6818b21	allow hover to expand ModCustomisationPanel	2024-07-26 22:44:50 +08:00
Dean Herbert	0421e1e9d0	Reduce number spacing a bit more	2024-07-26 23:21:44 +09:00
Dean Herbert	96049807c4	Adjust weight and text in event feed output ... Just some minor adjustments.	2024-07-26 23:20:32 +09:00
Dean Herbert	4fa6a19409	Merge pull request #29108 from bdach/daily-challenge/better-breakdown ... Improve score breakdown on daily challenge	2024-07-26 23:12:04 +09:00
Dean Herbert	47eca0eb37	Merge pull request #29101 from bdach/daily-challenge/fix-preview-track ... Fix preview tracks not stopping playback when suspending/exiting daily challenge screen	2024-07-26 21:52:26 +09:00
Dean Herbert	6f7d05d5a0	Merge pull request #29104 from bdach/daily-challenge/fix-no-audio-adjustments ... Fix daily challenge screen not applying track adjustments from mods	2024-07-26 21:51:58 +09:00
Bartłomiej Dach	0996f9b0b5	Fix code quality	2024-07-26 14:45:39 +02:00
Dean Herbert	1607075e0c	Merge pull request #29099 from bdach/daily-challenge/totals-display ... Implement component for displaying running totals in daily challenge	2024-07-26 21:44:58 +09:00
Dean Herbert	a870722ea6	Adjust easings and reduce character spacing slightly	2024-07-26 21:43:23 +09:00
Bartłomiej Dach	fc0ade2c61	Highlight where local user's best is on the breakdown	2024-07-26 14:32:01 +02:00
Bartłomiej Dach	2caaebb670	Add tooltip with counts to daily challenge score breakdown chart	2024-07-26 13:47:41 +02:00
Dean Herbert	19affa7062	Rename new property to match true usage (per item) ... Also document a bit more.	2024-07-26 20:45:13 +09:00
Bartłomiej Dach	2e37f3b5de	Hook up score totals display to daily challenge screen	2024-07-26 12:34:23 +02:00
Dean Herbert	1ad0b31217	Add required pieces to MultiplayerPlaylistItemStats for total score tracking	2024-07-26 19:04:04 +09:00
Bartłomiej Dach	1abcf16231	Fix daily challenge screen not applying track adjustments from mods ... Closes https://github.com/ppy/osu/issues/29093.	2024-07-26 11:50:43 +02:00
Bartłomiej Dach	f9cfc7d96c	Fix preview tracks not stopping playback when suspending/exiting daily challenge screen ... Closes https://github.com/ppy/osu/issues/29083.	2024-07-26 10:53:12 +02:00
Cameron Brown	17f00ec0a6	Bind the mod select overlay's Beatmap to OsuScreen.Beatmap in constructor ... Suggested by @bdach!	2024-07-26 18:29:50 +10:00
Cameron Brown	a8851950bc	Update the beatmap of Daily Challenge's mods overlay when beatmap is set - #29094	2024-07-26 18:10:11 +10:00
Bartłomiej Dach	174dc91f4b	Implement component for displaying running totals in daily challenge ... Total pass count and cumulative total score, to be more precise.	2024-07-26 09:51:39 +02:00
Bartłomiej Dach	e489ae8f72	Merge pull request #29055 from peppy/event-feed-improvements ... Improve daily challenge event feed	2024-07-26 08:37:47 +02:00
Bartłomiej Dach	662e9eab8c	Don't force exit to main menu when presenting scores from within online screens ... Struck me as weird when reviewing https://github.com/ppy/osu/pull/29057. Like sure, that PR adds the replay button, but it's a bit terrible that clicking the button quits the daily challenge screen and you're back at main menu when done watching...? Also extended to cover playlists and multiplayer, which have the same issue.	2024-07-26 08:17:39 +02:00
Bartłomiej Dach	09a1fd2cd1	Merge pull request #29057 from frenzibyte/daily-challenge-replay-download-button ... Fix daily challenge not showing a replay button in results screen	2024-07-26 08:03:17 +02:00
Bartłomiej Dach	c17cabd981	Adjust alpha for rows for better visibility	2024-07-26 07:44:02 +02:00
Salman Ahmed	c558dfdf13	Reset download state when score is changed	2024-07-26 05:11:54 +03:00
Dean Herbert	c90e04092a	Merge pull request #29068 from bdach/results-statistics-toggle-crash ... Fix crash when toggling extended statistics visibility during results load	2024-07-25 22:49:41 +09:00
Dean Herbert	6cc3e8aab8	Merge pull request #29067 from bdach/report-daily-challenge ... Fix not being able to send chat reports on daily challenge screen	2024-07-25 22:33:41 +09:00
Bartłomiej Dach	3bb30d7ff9	Fix several missing properties on MultiplayerScore ... You wouldn't think this would be an actual thing that can happen to us, but it is. The most important one by far is `MaximumStatistics`; that is the root cause behind why stuff like spinner ticks or slider tails wasn't showing. On a better day we should probably do cleanup to unify these models better, but today is not that day.	2024-07-25 13:15:45 +02:00
Bartłomiej Dach	8dbd4d70ff	Fix crash when toggling extended statistics visibility during results load ... Closes https://github.com/ppy/osu/issues/29066. Initially I fixed this at where the assert is right now: 9790c5a574/osu.Game/Screens/Ranking/ResultsScreen.cs (L333) but because of the weird way that visible state management is done in this screen that made it possible for the extended statistics to be visible *behind* the score panels, without the score panels making way for it. So this is in a way safer, because it prevents the visibility state of the extended statistics from changing in the first place if there is no score selected (yet). This can be also seen in playlists, at least.	2024-07-25 11:45:17 +02:00
Bartłomiej Dach	8d89557ab8	Fix not being able to send chat reports on daily challenge screen ... Something something some people cannot be trusted with a textbox.	2024-07-25 11:11:54 +02:00
Salman Ahmed	615f07d54c	Fix results screen fetching more scores twice	2024-07-25 09:16:09 +03:00
Salman Ahmed	9d5fbb8b4f	Fix target score selection abruptly discarded after opening results screen	2024-07-25 09:01:43 +03:00
Dean Herbert	f1dda4ab1e	Fix too many event rows displaying after spending a long time in gameplay/results	2024-07-25 14:31:22 +09:00
Dean Herbert	c90d345ff9	Scroll content forever rather than aggressively fading	2024-07-25 14:31:21 +09:00
Salman Ahmed	dad8e28446	Fix replay download button not added when no score is selected initially	2024-07-25 07:40:17 +03:00
Dean Herbert	aac98ab6b2	Debounce leaderboard refetches to stop excessive operations after returning from gameplay	2024-07-25 12:58:35 +09:00
Dean Herbert	9ec687caab	Avoid reloading the daily challenge leaderboard when already requested	2024-07-25 12:55:45 +09:00
Salman Ahmed	6645dac71d	Fix dragging number boxes overwritten by select-all-on-focus feature	2024-07-24 23:19:04 +03:00
Dean Herbert	4983e5f33e	Merge pull request #29039 from bdach/multiple-selection-sample-popover ... Make sample popover change properties of all samples in multiple selection	2024-07-24 22:49:20 +09:00
Bartłomiej Dach	c3dae81935	Only add legacy key overlay to osu! and catch HUD layers	2024-07-24 15:41:20 +02:00
Bartłomiej Dach	26395bd443	Adjust animations further to match stable	2024-07-24 15:26:27 +02:00
Bartłomiej Dach	3c28c116ca	Simplify input overlay text colour decode (and fix incorrect default)	2024-07-24 14:53:01 +02:00
Bartłomiej Dach	087dd759be	Adjust layout to ballpark-match stable ... I dunno what the wiki is claiming with the "24px" figure or why but I'm not playing conversion games either. Dimensions ballparked via screenshots captured at x768 resolution. Also removes a weird homebrew method to keep the text upright. There is one canonical way to do this, namely `UprightAspectMaintainingContainer`. And the other key counters were already using it.	2024-07-24 14:52:56 +02:00
Bartłomiej Dach	1ed7e4b075	Make sample popover change properties of all samples in multiple selection ... Closes https://github.com/ppy/osu/issues/28916. The previous behaviour *may* have been intended, but it was honestly quite baffling. This seems like a saner variant.	2024-07-24 12:15:12 +02:00
Dean Herbert	6e4625609d	Merge pull request #29036 from bdach/hardcode-positions-for-leaderboard ... Fill daily challenge top 50 position numbers client-side	2024-07-24 17:49:51 +09:00
Bartłomiej Dach	788b70469d	Exit daily challenge screen when going offline ... This sort of thing is bound to happen when rewriting screens from scratch without invoking abstract eldritch entities sometimes. Damned if you do, damned if you don't...	2024-07-24 09:15:32 +02:00
Bartłomiej Dach	bf4bf4d39e	Fill daily challenge top 50 position numbers client-side ... Only doing this client-side, because doing this server-side is expensive: https://github.com/ppy/osu-web/pull/11354#discussion_r1689224285	2024-07-24 08:57:11 +02:00
Dean Herbert	aded31bd07	Merge pull request #29021 from bdach/editor-breaks-respect-time-preempt ... Respect pre-empt time when auto-generating breaks	2024-07-24 15:21:12 +09:00
normalid	fede6b3657	Fix indent problems	2024-07-24 13:09:21 +08:00
normalid	b24be96d04	Fix code quality	2024-07-24 12:57:30 +08:00
normalid	56143de2c6	Update offset factor	2024-07-24 12:39:36 +08:00
normalid	e2beacb3dd	Remove logging	2024-07-24 12:31:01 +08:00
normalid	395f8424b5	Match the stable animation	2024-07-24 12:30:08 +08:00
normalid	c52a993607	Support custom input overlay color	2024-07-23 23:35:25 +08:00
normalid	c7b110a471	* Fix the default position ... * Make the font match stable style	2024-07-23 22:11:28 +08:00
normalid	989ac56cbb	Fix the return button being squshed	2024-07-23 21:12:55 +08:00
normalid	9fe369b7f4	Replace SkinnableSprite with Sprite	2024-07-23 21:08:08 +08:00
normalid	a015fde014	Change the default height to match the stable	2024-07-23 20:53:06 +08:00
normalid	dce894108a	Remove unused blending mode	2024-07-23 20:50:08 +08:00
normalid	f7dc0b65da	Clean up the code	2024-07-23 20:47:49 +08:00
normalid	5dcc8b7a8f	Make the text are always horizontal	2024-07-23 19:56:43 +08:00
Dean Herbert	aed7ba9508	Change order of application to avoid bias to side with more room to drag ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2024-07-23 20:56:21 +09:00
normalid	777a0deb0f	Update the offset formula	2024-07-23 19:45:53 +08:00
Bartłomiej Dach	c3062f96ee	Fix autogenerated breaks not invalidating on change to pre-empt time	2024-07-23 13:38:50 +02:00
Bartłomiej Dach	088e8ad0a2	Respect pre-empt time when auto-generating breaks ... Closes https://github.com/ppy/osu/issues/28703.	2024-07-23 13:30:13 +02:00
normalid	ad1a86ebdc	Implement the overlay	2024-07-23 19:05:14 +08:00
Dean Herbert	cc4ed0ff3f	Use non-screen-space coordinates and add time-based drag ramping for better control	2024-07-23 18:59:22 +09:00
Bartłomiej Dach	38fc6f70f6	Add tolerance when drag-scrolling editor timeline ... Closes https://github.com/ppy/osu/issues/28983. While the direct cause of this is most likely mouse confine in full-screen, it shouldn't/can't really be disabled just for this, and I also get this on linux in *windowed* mode. In checking other apps, adding some tolerance to this sort of drag-scroll behaviour seems like a sane UX improvement anyways.	2024-07-23 11:10:18 +02:00
Bartłomiej Dach	57fa502786	Fix editor UI dimming when hovering over expanded part of toolboxes ... Closes https://github.com/ppy/osu/issues/28969.	2024-07-22 11:57:46 +02:00
Bartłomiej Dach	dd8be62d07	Merge pull request #28849 from frenzibyte/custom-profile-colour ... Add custom hue support to user profile overlay	2024-07-22 09:41:32 +02:00
Bartłomiej Dach	088b8aff11	Merge pull request #28881 from smoogipoo/fix-judgement-cut ... Fix judgement animation getting cut early	2024-07-22 09:24:57 +02:00
Layendan	6a4872faa8	Remove nullable disable	2024-07-21 23:56:47 -07:00
Layendan	6bb562db14	Fix collection popover	2024-07-22 12:22:52 +09:00
Layendan	e4cccb5e31	Fix lint errors	2024-07-22 12:22:52 +09:00
Layendan	a575566638	Add tests	2024-07-22 12:22:51 +09:00
Layendan	c16b7c5c70	Update favorite button	2024-07-22 12:22:51 +09:00
Layendan	3296beb003	Added collection button to result screen	2024-07-22 12:22:50 +09:00
Dean Herbert	401c0fe2bf	Merge branch 'master' into fix-pause-input-handling	2024-07-20 15:23:34 +09:00
Dean Herbert	d914b990f3	Update framework	2024-07-20 14:08:00 +09:00
Salman Ahmed	818b60a3d8	Fix pause overlay hiding input from ruleset input manager ... If a key is pressed while the pause overlay is visible, the ruleset input manager will not see it, therefore if the user resumes while the key is held then releases the key, the ruleset input manager will not receive the key up event.	2024-07-19 18:48:35 +03:00
Salman Ahmed	d7651ef387	Add extensive test cases for correct input handling while paused in osu! & non-osu!	2024-07-19 18:48:35 +03:00
Bartłomiej Dach	27000aa8ed	Merge branch 'master' into editor-blah	2024-07-19 13:42:40 +02:00
Dan Balasescu	ad564f31cb	Merge pull request #28947 from peppy/fix-playlist-item-panel ... Fix various visuals of playlist beatmap panels	2024-07-19 20:12:40 +09:00
Dean Herbert	c2cc85e6f0	Use purple again for kiai time specifically	2024-07-19 19:59:38 +09:00
Dean Herbert	c4de2bbb60	Ignore "too many ticks" in timeline (triggers in normal cases)	2024-07-19 19:57:47 +09:00
Dean Herbert	5ee645ac8f	Increase opacity of control points slightly	2024-07-19 19:50:21 +09:00
Dean Herbert	d9297438ba	Merge pull request #28900 from smoogipoo/fix-more-tests ... Fix more test failures	2024-07-19 19:38:52 +09:00
Dean Herbert	f11f01f9b7	Fix various visuals of playlist beatmap panels ... Supersedes https://github.com/ppy/osu/pull/28907. - Fix border being fat - Fix thumbnail not masking correctly - Fix background layer not being correctly fit to the panel - Dim the main background on hover - Minor tweaks to dimming	2024-07-19 19:26:04 +09:00
Dan Balasescu	5af39aad00	Add beatmap name to log string ... Makes it easy to compare this line versus the one in OsuGame.PresentBeatmap(). At the moment it's just GUID which is... not useful!	2024-07-19 19:02:41 +09:00
Dean Herbert	0f29ed618a	Don't attempt to clear the carousel during realm blocking operation	2024-07-19 17:39:47 +09:00
Dean Herbert	0560214d5b	Fix beatmap carousel performance regression with large databases	2024-07-19 17:39:47 +09:00
Dean Herbert	fb5a1ecb4e	Merge pull request #28944 from bdach/mania-crash ... Fix crash when adding mania notes right after changing timing point	2024-07-19 16:58:54 +09:00
Bartłomiej Dach	4dd225fdc8	Fix compose blueprint container not unsubscribing from event ... Closes https://github.com/ppy/osu/issues/28938. This is related to reloading the composer on timing point changes in scrolling rulesets. The lack of unsubscription from this would cause blueprints to be created for disposed composers via the `hitObjectAdded()` flow. The following line looks as if a sync load should be forced on a newly created placement blueprint: da4d37c4ad/osu.Game/Screens/Edit/Compose/Components/ComposeBlueprintContainer.cs (L364) however, it is not the case if the parent (`placementBlueprintContainer`) is disposed, which it would be in this case. Therefore, the blueprint stays `NotLoaded` rather than `Ready`, therefore it never receives its DI dependencies, therefore it dies on an `EditorBeatmap` nullref.	2024-07-19 08:32:36 +02:00
Dan Balasescu	30b5825549	Merge pull request #28942 from bdach/aaaaaaaaaaaaaaaaaaaaaaaa ... Fix skipping to next track not working	2024-07-19 15:23:24 +09:00
Bartłomiej Dach	9fe6354afc	Fix backwards conditional	2024-07-19 07:32:36 +02:00
Bartłomiej Dach	a06bcd74c7	Merge branch 'master' into fix-beatmap-atttributes-display	2024-07-19 07:04:01 +02:00
Salman Ahmed	2ad8eeb918	Fix beatmap attributes display in mod select recreating star difficulty bindable every setting change	2024-07-19 03:25:26 +03:00
Salman Ahmed	a570949459	Fix selection box initialy visible despite no items selected	2024-07-19 03:00:44 +03:00
Dan Balasescu	a7e110f669	Don't rely on single-use properties	2024-07-18 19:07:02 +09:00
Dean Herbert	70985d3b22	Remove margin completely	2024-07-18 19:01:52 +09:00
Dean Herbert	c9517aeebf	Fix tab extension dropdown having dead non-clickable hover area ... Closes https://github.com/ppy/osu/issues/28899.	2024-07-18 18:37:07 +09:00
Salman Ahmed	5317086171	Split content recreation methods	2024-07-18 00:26:37 +03:00
Salman Ahmed	d61a72b8fb	Explicitly define Hue rather than implicitly provide it by enum value	2024-07-18 00:26:24 +03:00
Salman Ahmed	4eb4d35e2f	Make UpdateColours method protected	2024-07-18 00:26:24 +03:00
Salman Ahmed	102da0f98c	Remove incorrect [CanBeNull] attribute	2024-07-17 23:58:38 +03:00
Layendan	0bc14ba646	Add favourite button to results screen	2024-07-17 12:45:20 -07:00
Dean Herbert	99c5025de8	Merge pull request #28892 from bdach/better-client-identifier ... Send client-generated session GUID for identification purposes	2024-07-18 01:07:40 +09:00
Bartłomiej Dach	2a601ce961	Also send version hash header under more accepted convention of name	2024-07-17 16:21:46 +02:00
Bartłomiej Dach	3006bae0d8	Send client-generated session GUID for identification purposes ... This is the first half of a change that *may* fix https://github.com/ppy/osu/issues/26338 (it definitely fixes *one case* where the issue happens, but I'm not sure if it will cover all of them). As described in the issue thread, using the `jti` claim from the JWT used for authorisation seemed like a decent idea. However, upon closer inspection the scheme falls over badly in a specific scenario where: 1. A client instance connects to spectator server using JWT A. 2. At some point, JWT A expires, and is silently rotated by the game in exchange for JWT B. The spectator server knows nothing of this, and continues to only track JWT A, including the old `jti` claim in said JWT. 3. At some later point, the client's connection to one of the spectator server hubs drops out. A reconnection is automatically attempted, *but* it is attempted using JWT B. The spectator server was not aware of JWT B until now, and said JWT has a different `jti` claim than the old one, so to the spectator server, it looks like a completely different client connecting, which boots the user out of their account. This PR adds a per-session GUID which is sent in a HTTP header on every connection attempt to spectator server. This GUID will be used instead of the `jti` claim in JWTs as a persistent identifier of a single user's single lazer session, which bypasses the failure scenario described above. I don't think any stronger primitive than this is required. As far as I can tell this is as strong a protection as the JWT was (which is to say, not *very* strong), and doing this removes a lot of weird complexity that would be otherwise incurred by attempting to have client ferry all of its newly issued JWTs to the server so that it can be aware of them.	2024-07-17 15:56:41 +02:00
Dean Herbert	d32fef8aee	Merge pull request #28891 from frenzibyte/fix-storyboard-positioning ... Fix storyboard sprites leaving gaps on edges when "beatmap skins" is enabled	2024-07-17 22:56:27 +09:00
Salman Ahmed	c4141fff07	Fix storyboard sprites leaving gaps on edges when resolving from an atlas	2024-07-17 14:47:17 +03:00
Bartłomiej Dach	e4ff6b5c8b	Add flags allowing excluding protected beatmaps from consideration in music controller ... This means that the protected beatmap can not be skipped forward/back to. Incidentally closes https://github.com/ppy/osu/issues/23199.	2024-07-17 12:46:24 +02:00
Bartłomiej Dach	1ffc34b651	Do not show protected beatmaps in playlist overlay ... Secondary fix to https://github.com/ppy/osu/issues/28880.	2024-07-17 11:46:59 +02:00
Bartłomiej Dach	4c1f902969	Do not allow working beatmap to switch to protected beatmap in song select ... Principal fix to https://github.com/ppy/osu/issues/28880.	2024-07-17 11:46:19 +02:00
Bartłomiej Dach	7ba1f142e5	Fix rank upgrade path upgrading scores that failed background reprocessing earlier	2024-07-16 14:04:51 +02:00
Bartłomiej Dach	ad2db3f853	Merge pull request #28882 from peppy/update-framework ... Update framework	2024-07-16 12:28:51 +02:00
Dean Herbert	f1325386f0	Fix summary timeline timing points having x position applied twice	2024-07-16 18:32:54 +09:00
OliBomby	ba501a8eb8	fix addition bank toggle can be switched off with selection	2024-07-16 11:30:52 +02:00
Dean Herbert	4ad7d900c1	Fix incorrect editor screen padding	2024-07-16 18:20:33 +09:00
Dean Herbert	063377f47c	Update framework	2024-07-16 17:45:25 +09:00
Dan Balasescu	bd4f3e28d9	Fix judgement animation getting cut early	2024-07-16 17:32:59 +09:00
Dan Balasescu	58ffbd9e1e	Merge pull request #28874 from peppy/fix-editor-toolbox-padding ... Fix editor toolboxes being incorrectly chopped	2024-07-16 10:37:33 +09:00
Dean Herbert	1083e71ce6	Fix potential crash when exiting daily challenge screen ... Without the schedule this will potentially run after disposal of the local drawable hierarchy. Closes https://github.com/ppy/osu/issues/28875.	2024-07-16 03:02:04 +09:00
Dean Herbert	6cdcd6136d	Fix editor toolboxes being incorrectly chopped	2024-07-15 21:02:54 +09:00
OliBomby	9f02a1f1bf	fix addition on node sample not working	2024-07-14 22:50:15 +02:00
OliBomby	df7a42a00e	fix placement samples	2024-07-14 22:33:23 +02:00
OliBomby	5e86a01e5e	allow hotkeys in sample point piece	2024-07-14 20:59:46 +02:00
OliBomby	952540024e	addition bank toggles in compose	2024-07-14 20:43:16 +02:00
OliBomby	58eb7f6fe1	fix rotated scale bounds again	2024-07-14 16:58:05 +02:00
OliBomby	ae38002777	Revert "fix incorrect rotated bound checking" ... This reverts commit 4165ded813.	2024-07-14 15:46:40 +02:00
Salman Ahmed	adb803c7a9	Force recreating sections container when loading new user to avoid weird UX when scrolled away	2024-07-14 15:19:37 +03:00
Salman Ahmed	43d08f702a	Or just use Colour4 where we have that fixed	2024-07-13 18:45:50 +03:00
Salman Ahmed	b12790c684	Fix hue number 360 giving off a gray colour scheme ... They say it's not a bug, it's a feature...I dunno maybe later.	2024-07-13 18:29:06 +03:00
Dean Herbert	c854dfd6fb	Merge pull request #28832 from nekodex/ui-sfx-tweaks ... UI SFX Tweaks/Updates	2024-07-13 23:24:06 +09:00
Dean Herbert	9ed97d03a8	Update resources	2024-07-13 20:22:52 +09:00
Salman Ahmed	b292bf3832	Support using custom hue in user profile overlay	2024-07-13 11:58:54 +03:00
Salman Ahmed	933626a64b	Support using custom hue in OverlayColourProvider	2024-07-13 11:58:54 +03:00
Salman Ahmed	3eaac11b44	Add profile hue attribute to API model	2024-07-13 11:26:45 +03:00
Dean Herbert	eb3f480a2a	Merge pull request #28683 from frenzibyte/footer-v2-integration ... Replace local footer in existing sheared overlays (e.g. mod select & first-run setup) with `ScreenFooter`	2024-07-12 22:45:06 +09:00
Dean Herbert	9a1939a922	Move logoContainer local again	2024-07-12 22:01:20 +09:00
Dean Herbert	e8f7213b3b	Move logo depth to a forward passing	2024-07-12 22:01:20 +09:00
Jamie Taylor	320df7da2b	Use separate samples for scrolling to top and scrolling to previous	2024-07-12 21:01:19 +09:00
Jamie Taylor	ad2b354d9c	Update sample looping behaviour to better suit new sample	2024-07-12 21:01:19 +09:00
Bartłomiej Dach	217b01d303	Apply tooltip to bookmark pieces too ... Bookmarks don't show on real beatmaps, but they do show in test scenes (namely `TestSceneEditorSummaryTimeline`). Also does some more changes to adjust the markers to the latest updates to other markers.	2024-07-12 11:12:20 +02:00
Dean Herbert	2453e2fd00	Fix nullability issue	2024-07-12 18:11:23 +09:00
Bartłomiej Dach	5e00995948	Merge branch 'master' into tooltips	2024-07-12 11:01:03 +02:00
Bartłomiej Dach	518dc17518	Merge pull request #28788 from bdach/timeline-redesign ... Redesign editor timelines to address most frequent user complaints	2024-07-12 10:58:59 +02:00
Bartłomiej Dach	452fbed681	Merge pull request #28808 from frenzibyte/fix-all-notifications ... Fix confirm exit dialog potentially showing incorrect number of ongoing operations	2024-07-12 10:56:29 +02:00
Dean Herbert	4be5d056c5	Reduce opacity of centre marker slightly	2024-07-12 17:23:48 +09:00
Dean Herbert	d2cb07b157	Add a bit more padding between node overlays and hitobjects in timeline	2024-07-12 17:22:36 +09:00
Dean Herbert	2454722601	Add tooltips to summary timeline display	2024-07-12 16:39:41 +09:00
Dean Herbert	275e7aa451	Adjust timeline centre marker visuals and bring in front of ticks	2024-07-12 16:37:03 +09:00
Dean Herbert	ca2fc72959	Adjust timeline centre marker visuals and bring in front of ticks	2024-07-12 16:29:40 +09:00
Dean Herbert	f65ab6736d	Adjust breaks in timeline to be centered with waveform / hitobjects	2024-07-12 15:45:58 +09:00
Dean Herbert	2ad2ae0c16	Add slight offset for timeline BPM display to avoid overlaps	2024-07-12 14:34:01 +09:00
Dean Herbert	9a7a0cdb34	Adjust timeline ticks to add a bit more body back	2024-07-12 14:29:18 +09:00
Dean Herbert	685b19a571	Adjust various visuals of summary timeline in a hope for user acceptance ... .. with a somewhat appealing design.	2024-07-12 13:57:42 +09:00
Dean Herbert	e6b7d2530e	Change red shade for timing control points	2024-07-12 13:39:40 +09:00
Dean Herbert	fb4f620c90	Add back BPM and adjust sizing of bottom bar a bit more	2024-07-12 12:34:43 +09:00
Salman Ahmed	d4a4a059d4	Fix footer content not accessible by overlay when overriden by a subclass	2024-07-11 15:31:02 +03:00
Salman Ahmed	7a5624fd0e	Add screen footer to ScreenTestScene	2024-07-11 15:30:07 +03:00
Salman Ahmed	669e945fc3	Fix ModSelectOverlay not hiding without a footer	2024-07-11 14:56:17 +03:00
Salman Ahmed	bd44c17079	Enable NRT in VolumeOverlay	2024-07-11 14:29:56 +03:00
Salman Ahmed	3190f8bb7e	Remove key arrow handling in VolumeOverlay	2024-07-11 14:29:33 +03:00
Salman Ahmed	7b541d378c	Revert some changes ... I can see `IsDisplayingToast` being removed and `IsPresent` becoming `=> Notifications.Any()` but I'll just leave this for another day.	2024-07-11 14:23:11 +03:00
Bartłomiej Dach	ccc4d288b2	Merge pull request #28821 from peppy/fix-editor-dim ... Fix editor UI transparency being incorrectly opaque when hovering slider control points	2024-07-11 12:05:10 +02:00
Dean Herbert	95464ebf36	Merge branch 'master' into timeline-redesign	2024-07-11 18:38:17 +09:00
Bartłomiej Dach	6801ccbbc5	Fix editor UI remaining transparent when switching away from compose tab ... Could still happen if using the keyboard F-key shortcuts. In that case the composer becomes non-present, so its `Update()` can't really do anything.	2024-07-11 11:23:09 +02:00
Bartłomiej Dach	f1fa34e5d5	Merge pull request #28800 from peppy/file-mounting-v3 ... Add ability to edit beatmap content externally	2024-07-11 10:47:36 +02:00
Dean Herbert	c139478aa2	Merge pull request #28805 from frenzibyte/select-all-on-focus ... Select all text when focusing sample bank/volume textboxes in editor (and number boxes in general)	2024-07-11 17:33:30 +09:00
Dean Herbert	7b0c1e3498	Also apply to timing textboxes	2024-07-11 16:54:27 +09:00
Bartłomiej Dach	cc0d7e9981	Add error logging on failure to begin/end external edit	2024-07-11 09:54:12 +02:00
Bartłomiej Dach	ac467cf73a	Set locally modified state for all externally modified beatmap(sets) that could not be mapped to online	2024-07-11 09:44:33 +02:00
Dean Herbert	fe421edd8f	Fix editor UI transparency being incorrectly opaque when hovering slider control points ... As mentioned at https://github.com/ppy/osu/pull/28787#issuecomment-2221150025.	2024-07-11 16:41:21 +09:00
Dean Herbert	b5bb94e4ec	Merge branch 'master' into file-mounting-v3	2024-07-11 15:54:54 +09:00
Dean Herbert	b1dd2ead30	Merge pull request #28818 from peppy/configure-a-wait-what-the-foo-bar ... Fix incorrect continuation in `ImportAsUpdate` causing UI blockage	2024-07-11 15:54:42 +09:00
Dan Balasescu	00cab0ec0a	Merge pull request #28809 from bdach/mania-timeline-zooms-composer ... Match mania editor playfield time range with timeline zoom	2024-07-11 15:41:26 +09:00
Bartłomiej Dach	bfe34c9671	Merge branch 'master' into fix-all-notifications	2024-07-11 08:35:57 +02:00
Dean Herbert	bdbdc3592e	Move full export async flow inside screen and add error handling	2024-07-11 14:27:12 +09:00
Dean Herbert	2eb6cf57af	Fix incorrect continuation in ImportAsUpdate causing UI blockage	2024-07-11 13:42:24 +09:00
Dean Herbert	599a765fd1	Add confirmation before saving for external edit	2024-07-11 12:20:33 +09:00
Dean Herbert	cd6b0e875a	Simplify save dialogs	2024-07-11 12:15:17 +09:00
Dean Herbert	b0d6c8ca6d	Abort operation on save failure	2024-07-11 11:42:06 +09:00
Bartłomiej Dach	4901fece26	Merge branch 'master' into fix-dialog-overflow	2024-07-10 18:20:18 +02:00
Bartłomiej Dach	55b4dd9b99	Adjust punctuation	2024-07-10 18:17:10 +02:00
Bartłomiej Dach	92dc125d39	Match mania editor playfield time range with timeline zoom	2024-07-10 17:36:39 +02:00
Dean Herbert	b58ba5f5f1	Just give in to silly code quality inspection	2024-07-10 23:02:19 +09:00
Salman Ahmed	bb9a2b705e	Remove unnecessary math min	2024-07-10 16:29:28 +03:00
Salman Ahmed	846fd73ac9	Fix notification toast tray potentially hiding some notifications	2024-07-10 16:15:02 +03:00
Salman Ahmed	7d667ac46b	Fix confirm exit dialog overflowing from too many ongoing operations	2024-07-10 16:06:53 +03:00