1
0
mirror of https://github.com/ppy/osu.git synced 2024-09-22 07:27:25 +08:00
osu-lazer/osu.Game
Bartłomiej Dach 4dd225fdc8
Fix compose blueprint container not unsubscribing from event
Closes https://github.com/ppy/osu/issues/28938.

This is related to reloading the composer on timing point changes in
scrolling rulesets. The lack of unsubscription from this would cause
blueprints to be created for disposed composers via the
`hitObjectAdded()` flow.

The following line looks as if a sync load should be forced on a newly
created placement blueprint:

    da4d37c4ad/osu.Game/Screens/Edit/Compose/Components/ComposeBlueprintContainer.cs (L364)

however, it is not the case if the parent
(`placementBlueprintContainer`) is disposed, which it would be in this
case. Therefore, the blueprint stays `NotLoaded` rather than `Ready`,
therefore it never receives its DI dependencies, therefore it dies on
an `EditorBeatmap` nullref.
2024-07-19 08:32:36 +02:00
..
Audio Adjust AudioFilter to framework-side changes 2024-06-18 07:30:46 +02:00
Beatmaps Change red shade for timing control points 2024-07-12 13:39:40 +09:00
Collections Merge pull request #28762 from frenzibyte/change-chevron-display 2024-07-08 20:05:59 +09:00
Configuration Remove scroll-dropdown-into-view logic 2024-07-04 07:34:19 +03:00
Database Fix rank upgrade path upgrading scores that failed background reprocessing earlier 2024-07-16 14:04:51 +02:00
Extensions Fix date failing to display on leaderboard for some scores with weird datetimes 2024-01-14 13:52:39 +01:00
Graphics Remove margin completely 2024-07-18 19:01:52 +09:00
Input Implement quick exit hotkeys for editor test play 2024-07-02 14:34:36 +02:00
IO Update naming of enum fields in ObjType 2024-05-01 17:24:53 +03:00
IPC
Localisation Merge pull request #28553 from frenzibyte/mod-select-customisation-panel 2024-07-08 11:26:21 +02:00
Models Use native query to avoid huge overheads when cleaning up realm files 2024-01-09 15:37:29 +09:00
Online Also send version hash header under more accepted convention of name 2024-07-17 16:21:46 +02:00
Overlays Add flags allowing excluding protected beatmaps from consideration in music controller 2024-07-17 12:46:24 +02:00
Performance Expose high performance session state 2024-04-16 10:04:38 +08:00
Properties Make medal overlay respect overlay disable via activation mode 2024-02-20 16:31:31 +01:00
Replays Update HasFlag usages 2024-07-03 00:19:04 +09:00
Rulesets Fix editor toolboxes being incorrectly chopped 2024-07-15 21:02:54 +09:00
Scoring Add basic flow for mounting beatmaps for external editing 2024-07-10 18:29:51 +09:00
Screens Fix compose blueprint container not unsubscribing from event 2024-07-19 08:32:36 +02:00
Skinning Add basic flow for mounting beatmaps for external editing 2024-07-10 18:29:51 +09:00
Storyboards Fix storyboard sprites leaving gaps on edges when resolving from an atlas 2024-07-17 14:47:17 +03:00
Tests Add screen footer to ScreenTestScene 2024-07-11 15:30:07 +03:00
Updater Warn about not using an official "deployed" build 2024-03-21 00:47:45 +09:00
Users Fix nullability inspection 2024-05-10 23:26:43 +08:00
Utils Fix code quality and null handling 2024-06-07 00:01:50 +08:00
.editorconfig
FodyWeavers.xml
osu!.res
osu.Game.csproj Update framework 2024-07-16 17:45:25 +09:00
OsuGame.cs Move logoContainer local again 2024-07-12 22:01:20 +09:00
OsuGameBase_Importing.cs
OsuGameBase.cs Revert "Temporary rollback of framework / SDL3" 2024-05-22 16:29:39 +08:00
PerformFromMenuRunner.cs