1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-17 20:52:54 +08:00
osu-lazer/osu.Game/Screens
Bartłomiej Dach 4dd225fdc8
Fix compose blueprint container not unsubscribing from event
Closes https://github.com/ppy/osu/issues/28938.

This is related to reloading the composer on timing point changes in
scrolling rulesets. The lack of unsubscription from this would cause
blueprints to be created for disposed composers via the
`hitObjectAdded()` flow.

The following line looks as if a sync load should be forced on a newly
created placement blueprint:

    da4d37c4ad/osu.Game/Screens/Edit/Compose/Components/ComposeBlueprintContainer.cs (L364)

however, it is not the case if the parent
(`placementBlueprintContainer`) is disposed, which it would be in this
case. Therefore, the blueprint stays `NotLoaded` rather than `Ready`,
therefore it never receives its DI dependencies, therefore it dies on
an `EditorBeatmap` nullref.
2024-07-19 08:32:36 +02:00
..
Backgrounds Fix incorrect background being loaded due to async race 2024-05-01 00:05:14 +08:00
Edit Fix compose blueprint container not unsubscribing from event 2024-07-19 08:32:36 +02:00
Footer Move logo depth to a forward passing 2024-07-12 22:01:20 +09:00
Import Merge branch 'master' into update-framework 2022-11-26 16:19:36 +01:00
Menu Adjust punctuation 2024-07-10 18:17:10 +02:00
OnlinePlay Fix potential crash when exiting daily challenge screen 2024-07-16 03:02:04 +09:00
Play Fix break overlay progress bar becoming a pancake near end of break 2024-07-10 19:28:37 +09:00
Ranking Update HasFlag usages 2024-07-03 00:19:04 +09:00
Select Do not allow working beatmap to switch to protected beatmap in song select 2024-07-17 11:46:19 +02:00
SelectV2 Merge branch 'master' into footer-v2-integration 2024-07-10 15:33:05 +09:00
Spectate Remove managed clocks from SpectatorSyncManager on gameplay completion / abort 2024-04-26 15:29:59 +08:00
Utility Adjust calls to GetContainingInputManager() 2024-06-18 07:41:19 +02:00
BackgroundScreen.cs Unload beatmap storyboard background when no longer present 2023-11-09 17:20:11 +03:00
BackgroundScreenStack.cs Use alternative method of scheduling storyboard unload 2023-11-16 15:37:53 +09:00
IHandlePresentBeatmap.cs Automated pass 2023-06-24 01:00:03 +09:00
IHasSubScreenStack.cs Automated pass 2023-06-24 01:00:03 +09:00
IOsuScreen.cs Move screen footer to OsuGame 2024-05-16 07:48:58 +03:00
IPerformFromScreenRunner.cs
Loader.cs Remove disclaimer screen completely 2023-12-28 17:21:29 +09:00
OsuScreen.cs Move screen footer to OsuGame 2024-05-16 07:48:58 +03:00
OsuScreenDependencies.cs
OsuScreenStack.cs Move screen footer to OsuGame 2024-05-16 07:48:58 +03:00
ScorePresentType.cs Remove redundant nullable suppression directives 2023-06-07 08:20:41 +03:00
ScreenWhiteBox.cs Partial everything 2022-11-27 00:00:27 +09:00
StartupScreen.cs Automated pass 2023-06-24 01:00:03 +09:00