h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-16 14:22:55 +08:00
Code Issues Releases Wiki Activity

Fix judgement animation getting cut early

Browse Source
This commit is contained in:
Dan Balasescu 2024-07-16 17:32:59 +09:00
parent 54cf64d5ce
commit bd4f3e28d9
No known key found for this signature in database
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
osu.Game/Rulesets/Judgements/DrawableJudgement.cs
View File

@ -7,6 +7,7 @@ using osu.Framework.Allocation;
using osu.Framework.Graphics;
using osu.Framework.Graphics.Containers;
using osu.Framework.Graphics.Pooling;
using osu.Game.Rulesets.Objects;
using osu.Game.Rulesets.Objects.Drawables;
using osu.Game.Rulesets.Scoring;
using osu.Game.Skinning;
@ -25,6 +26,8 @@ namespace osu.Game.Rulesets.Judgements
public DrawableHitObject? JudgedObject { get; private set; }
public HitObject? JudgedHitObject { get; private set; }
public override bool RemoveCompletedTransforms => false;
protected SkinnableDrawable? JudgementBody { get; private set; }
@ -98,6 +101,7 @@ namespace osu.Game.Rulesets.Judgements
{
Result = result;
JudgedObject = judgedObject;
JudgedHitObject = judgedObject?.HitObject;
}
protected override void FreeAfterUse()
@ -105,6 +109,7 @@ namespace osu.Game.Rulesets.Judgements
base.FreeAfterUse();
JudgedObject = null;
JudgedHitObject = null;
}
protected override void PrepareForUse()

2
osu.Game/Rulesets/UI/JudgementContainer.cs
View File

@ -16,7 +16,7 @@ namespace osu.Game.Rulesets.UI
// remove any existing judgements for the judged object.
// this can be the case when rewinding.
RemoveAll(c => c.JudgedObject == judgement.JudgedObject, false);
RemoveAll(c => c.JudgedHitObject == judgement.JudgedHitObject, false);
base.Add(judgement);
}