h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-16 09:22:58 +08:00
Code Issues Releases Wiki Activity

Fix crash when toggling extended statistics visibility during results load

Browse Source 
Closes https://github.com/ppy/osu/issues/29066.

Initially I fixed this at where the assert is right now:

	9790c5a574/osu.Game/Screens/Ranking/ResultsScreen.cs (L333)

but because of the weird way that visible state management is done in
this screen that made it possible for the extended statistics to be
visible *behind* the score panels, without the score panels making way
for it. So this is in a way safer, because it prevents the visibility
state of the extended statistics from changing in the first place if
there is no score selected (yet).

This can be also seen in playlists, at least.
This commit is contained in:
Bartłomiej Dach 2024-07-25 11:42:56 +02:00
parent 9790c5a574
commit 8dbd4d70ff
No known key found for this signature in database
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
osu.Game/Screens/Ranking/ResultsScreen.cs
View File

@ -398,7 +398,8 @@ namespace osu.Game.Screens.Ranking
break;
case GlobalAction.Select:
StatisticsPanel.ToggleVisibility();
if (SelectedScore.Value != null)
StatisticsPanel.ToggleVisibility();
return true;
}