h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-17 00:23:22 +08:00
Code Issues Releases Wiki Activity

Fix beatmap carousel performance regression with large databases

Browse Source
This commit is contained in:
Dean Herbert 2024-07-19 15:15:49 +09:00
parent fb5a1ecb4e
commit 0560214d5b
No known key found for this signature in database
1 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
osu.Game/Screens/Select/BeatmapCarousel.cs
View File

@ -278,13 +278,27 @@ namespace osu.Game.Screens.Select
if (changes == null)
{
// Usually we'd handle the initial load case here, but that's already done in load() as an optimisation.
// So the only thing we need to handle here is the edge case where realm blocks-resumes all operations.
realmBeatmapSets.Clear();
realmBeatmapSets.AddRange(sender.Select(r => r.ID));
// Do a full two-way check on missing beatmaps.
// Let's assume that the worst that can happen is deletions or additions.
setsRequiringRemoval.Clear();
setsRequiringUpdate.Clear();
loadBeatmapSets(sender);
foreach (Guid id in realmBeatmapSets)
{
if (!root.BeatmapSetsByID.ContainsKey(id))
setsRequiringUpdate.Add(id);
}
foreach (Guid id in root.BeatmapSetsByID.Keys)
{
if (!realmBeatmapSets.Contains(id))
setsRequiringRemoval.Add(id);
}
}
else
{