2465 Commits

Author	SHA1	Message	Date
Dan Balasescu	13060b8575	Merge branch 'master' into beatmap-carousel-less-diffcalc-stutter	2020-10-20 14:26:16 +09:00
Dean Herbert	d5940193a2	Ensure visible items is greater than zero before trying to display a range	2020-10-19 19:55:20 +09:00
Dean Herbert	9106e97c37	Ensure max value in clamp is at least zero	2020-10-19 19:10:01 +09:00
Dean Herbert	1c2185e969	Replace comment with link to issue	2020-10-19 18:41:28 +09:00
Dean Herbert	044622a7a6	Fix out of bounds issues	2020-10-19 18:41:17 +09:00
Dean Herbert	467bb9b96f	Merge branch 'master' into beatmap-carousel-refactor	2020-10-19 13:17:11 +09:00
Dean Herbert	bff3856c83	Account for panel height when removing as off-screen	2020-10-19 13:13:32 +09:00
Dean Herbert	ee0efa0b4c	Fix off-by-one in display range retrieval logic	2020-10-19 13:05:42 +09:00
Dean Herbert	4590d9b93b	Remove outdated comment logic	2020-10-19 13:04:12 +09:00
Berkan Diler	cc11283143	Use string.Starts-/EndsWith char overloads	2020-10-16 11:27:02 +02:00
Dean Herbert	88ffcb9234	Update EndsWith usages	2020-10-16 12:58:34 +09:00
Dean Herbert	30e1fce7a4	Reduce alloc overhead of DrawableCarouselBeatmapSet using new function-based ctor	2020-10-14 15:10:50 +09:00
Dean Herbert	07e6609e6d	Disable difficulty calculation for set-level difficulty icons	2020-10-14 14:16:22 +09:00
Dean Herbert	e662dc5342	Add missing licence headers	2020-10-13 20:57:26 +09:00
Dean Herbert	8057ea1097	Fix formatting issues	2020-10-13 20:50:36 +09:00
Dean Herbert	3d416f4d64	Clean up beatmapSet resolution in DrawableCarouselBeatmapSet	2020-10-13 19:31:29 +09:00
Dean Herbert	75b6a5e17e	Remove unnecessary hack (fixed via framework update)	2020-10-13 19:31:29 +09:00
Dean Herbert	5d11db7753	Locallise ChildItems to DrawableCarouselBeatmapSet for clarity	2020-10-13 19:31:29 +09:00
Dean Herbert	37daefc2b5	Remove outdated comment	2020-10-13 19:12:33 +09:00
Dean Herbert	8eca28e8bc	Add comment about off-screen loading	2020-10-13 19:10:35 +09:00
Dean Herbert	834b0186f4	Adjust fade duration to be slightly shorter	2020-10-13 18:50:10 +09:00
Dean Herbert	2346644c04	Switch DelayedLoadUnloadWrappers to DelayedLoadWrappers ... Due to pooling usage, there is no time we need to unload. Switching to DelayedLoadWrapper cleans up the code and reduces overhead substantially.	2020-10-13 18:47:40 +09:00
Dean Herbert	a1801f8ae4	Unmark todo for now	2020-10-13 18:47:36 +09:00
Dean Herbert	40a0ab7aaa	Avoid allocating CarouselItems for bounds checks	2020-10-13 18:33:31 +09:00
Dean Herbert	4f4f222514	Remove unnecessary fade (already applied by base DrawableCarouselItem)	2020-10-13 18:28:28 +09:00
Dean Herbert	83358d487f	Remove logging	2020-10-13 18:18:22 +09:00
Dean Herbert	3d9ea852ec	Remove masking override (no longer needed as our size is now correct)	2020-10-13 18:14:23 +09:00
Dean Herbert	69650c16fc	Simplify vertical position calculations by including spacing in height definition	2020-10-13 18:13:36 +09:00
Dean Herbert	b1ddb08a4e	Fix right click context menus appearing in incorrect locations	2020-10-13 18:01:12 +09:00
Dean Herbert	d9a6a6b245	Split content out into own class	2020-10-13 18:01:12 +09:00
Dean Herbert	9b2ebb8f0f	Fix main content DelayedLoadUnloadWrapper not getting a valid size before load	2020-10-13 17:45:41 +09:00
Dean Herbert	f3b937e358	Fix masking issues with certain aspect ratio displays	2020-10-13 17:37:33 +09:00
Dean Herbert	fdd4d95cdc	Fix difficulties being at incorrect vertical positions after filter is applied	2020-10-13 17:37:33 +09:00
Dean Herbert	1f0aa974dd	Fix failing tests	2020-10-13 17:37:33 +09:00
Dean Herbert	b536f571fd	Move header height propagation to update for safety	2020-10-13 17:37:33 +09:00
Dean Herbert	ded09b78cb	Avoid usage of AutoSize for DrawableCarouselItems in general	2020-10-13 17:37:33 +09:00
Dean Herbert	cecdf14f53	Avoid reconstructing beatmap difficulties that were recently displayed	2020-10-13 17:37:33 +09:00
Dean Herbert	1da49073ab	Calculate content height automatically	2020-10-13 17:37:33 +09:00
Dean Herbert	c08b5e8d03	Align beatmap difficulties correctly	2020-10-13 17:37:33 +09:00
Dean Herbert	cfec4f4fc1	Extract header element from base DrawableCarouselItem class	2020-10-13 17:37:33 +09:00
Dean Herbert	2aad482545	Fix x offsets of difficulties not being updated	2020-10-13 17:37:33 +09:00
Dean Herbert	1b7e3397c6	Use expiry to avoid ToArray	2020-10-13 17:37:33 +09:00
Dean Herbert	075bf23714	Better track off-screen drawables (and return to pool less often)	2020-10-13 17:37:33 +09:00
Dean Herbert	29983afcef	Replace pool/cleanup logic with simplest form possible ... This will temporarily break panels that go off-screen, as they will disappear immediately	2020-10-13 17:37:33 +09:00
Dean Herbert	06e84c8eb3	Add comments and split out update steps into a more logical flow	2020-10-13 17:37:33 +09:00
Dean Herbert	20b54fb904	Move transform clean-up to pooling free call	2020-10-13 17:37:33 +09:00
Dean Herbert	f6aa448523	Store y positions inside items rather than in a separate array	2020-10-13 17:37:33 +09:00
Dean Herbert	b92c22ad42	Add logging	2020-10-13 17:37:33 +09:00
Dean Herbert	9814e9ba7f	Split classes out to reduce loc burder on DrawableCarouselBeatmapSet	2020-10-13 17:37:33 +09:00
Dean Herbert	975cd5a840	Add back beatmap difficulty appear/disappear movement	2020-10-13 17:37:33 +09:00
Dean Herbert	fd8654cff3	Add back difficulty panel spacing	2020-10-13 17:37:33 +09:00
Dean Herbert	ce67f65084	Fix single results not showing up	2020-10-13 17:37:33 +09:00
Dean Herbert	220c8ba2c4	Fix incorrect vertical offsets when difficulties are filtered away	2020-10-13 17:37:33 +09:00
Dean Herbert	82f9ca3de9	Bind to filter event changes in base drawable item	2020-10-13 17:37:33 +09:00
Dean Herbert	813ee19728	Use existing event flow for rendering beatmap difficulties	2020-10-13 17:37:33 +09:00
Dean Herbert	8847cedf29	Add initial pass of vertical transforms	2020-10-13 17:37:33 +09:00
Dean Herbert	15325f5f51	Base bounds checks on +1 (to avoid worrying about current item heights)	2020-10-13 17:37:33 +09:00
Dean Herbert	bb03c5d77c	Temporarily disable masking temporarily to fix panels disappearing at extents	2020-10-13 17:37:33 +09:00
Dean Herbert	524419d5e4	Fix filtered items being considered for height calculation	2020-10-13 17:37:33 +09:00
Dean Herbert	0a144a1388	Correctly free panels after use to avoid finalizer disposal of subtree	2020-10-13 17:37:33 +09:00
Dean Herbert	c5a6f4b453	Fix scroll to selected beatmap	2020-10-13 17:37:33 +09:00
Dean Herbert	5c29aa8cce	Fix multiple difficulties being expanded at once	2020-10-13 17:37:33 +09:00
Dean Herbert	5c2f134665	Add back left offset for selected set	2020-10-13 17:37:33 +09:00
Dean Herbert	3cfc0dc82d	Add safeties to beatmap panel loading code	2020-10-13 17:37:33 +09:00
Dean Herbert	954d43ef56	Debounce state application events	2020-10-13 17:37:33 +09:00
Dean Herbert	ca1f5dcada	Add back panel padding	2020-10-13 17:37:33 +09:00
Dean Herbert	0400b34349	Load more components asynchronously after pool resolution	2020-10-13 17:37:33 +09:00
Dean Herbert	f3b24b9bb5	Avoid performing eager selection constantly on adding ranges of new children	2020-10-13 17:37:33 +09:00
Dean Herbert	0a978c6131	Add basic pooling setup	2020-10-13 17:37:33 +09:00
Dean Herbert	f17d661c1a	Add basic range-based invalidation	2020-10-13 17:37:33 +09:00
Dean Herbert	3143224e5b	Refactor how drawable carousel items are constructed	2020-10-13 17:37:33 +09:00
Dean Herbert	9193f5b0ba	Expose panel height from non-drawable models	2020-10-13 17:37:33 +09:00
Dean Herbert	a393bbe8f7	Remove direct drawable storage from carousel models	2020-10-13 17:37:33 +09:00
Dean Herbert	73c238fae3	Add the ability to search for local beatmaps via online IDs ... Closes #10470.	2020-10-10 21:34:11 +09:00
Joehu	c6386ea605	Remember leaderboard mods filter selection in song select	2020-09-15 21:53:35 -07:00
Dean Herbert	3c70b3127c	Fix potential nullref in FilterControl during asynchronous load	2020-09-15 23:19:31 +09:00
Dan Balasescu	6cbff98295	Merge branch 'master' into add-collections-to-beatmap-options	2020-09-15 15:23:33 +09:00
Dean Herbert	2c7492d717	Add null check in SongSelect disposal for safety	2020-09-15 14:34:58 +09:00
Joehu	43daabc982	Remove unused using and move dialog to BDL	2020-09-14 12:10:00 -07:00
Joehu	c833f5fcc4	Reorder buttons to match stable	2020-09-14 11:23:41 -07:00
Joehu	57610ddad5	Fix beatmap options absorbing input from toolbar ruleset selector	2020-09-14 11:22:16 -07:00
Joehu	c30174cea3	Add manage collections button to beatmap options	2020-09-14 11:21:23 -07:00
Joehu	1a8a7ae7f8	Remove hardcoded key param from AddButton	2020-09-14 11:19:18 -07:00
Joehu	368aca015a	Move override methods to bottom	2020-09-14 11:18:00 -07:00
Bartłomiej Dach	a377cccb4d	Unsubscribe from track changed event on disposal	2020-09-14 17:10:35 +02:00
Bartłomiej Dach	f17b2f1359	Ensure track is looping in song select immediately	2020-09-12 20:43:17 +02:00
smoogipoo	5b80a7db5f	Re-namespace collections dropdown	2020-09-11 16:01:01 +09:00
Dean Herbert	033bd82953	Merge branch 'master' into fix-filtercontrol-order	2020-09-11 13:07:41 +09:00
Dean Herbert	b594a2a507	Import collections on initial import-from-stable step	2020-09-11 11:16:00 +09:00
smoogipoo	314cd13b74	Fix song select filter ordering	2020-09-10 23:36:22 +09:00
Dean Herbert	18d96738a1	Fix hard crash on deleting a collection with no collection selected	2020-09-10 19:52:34 +09:00
smoogipoo	6b56c6e83f	Rename to CollectionMenuItem	2020-09-09 23:11:19 +09:00
smoogipoo	43525614ad	Store raw BeatmapCollection in filter control	2020-09-09 23:10:21 +09:00
smoogipoo	1a023d2c88	Fix a few more tests	2020-09-09 16:33:48 +09:00
smoogipoo	0360f7d845	Move CollectionManager to OsuGame	2020-09-09 15:39:15 +09:00
smoogipoo	4ddf5f054b	Rename BeatmapCollectionManager -> CollectionManager	2020-09-09 15:31:08 +09:00
smoogipoo	a5e1e8d043	Rename More... to Manage...	2020-09-08 18:57:18 +09:00
smoogipoo	ae022d7559	Show all items in dropdown, set global max height	2020-09-08 18:55:53 +09:00
smoogipoo	4962213cc4	Rename manage collections filter/text	2020-09-08 18:42:55 +09:00
smoogipoo	f581df47c8	Add "New collection..." item to dropdown	2020-09-08 18:25:09 +09:00
smoogipoo	c2da3d9c84	Fix button input and tests	2020-09-08 14:36:38 +09:00
smoogipoo	8a3c8a6185	Show button when selected or preselected	2020-09-08 14:03:49 +09:00
smoogipoo	32e3f5d091	Adjust button styling	2020-09-08 13:45:26 +09:00
Dean Herbert	8b770626fa	Add missing '...' from some popup menu items	2020-09-08 12:18:08 +09:00
Dean Herbert	b15bbc882a	Move items up in menu	2020-09-08 12:04:35 +09:00
Dean Herbert	3e5ea6c42f	Change "Add to" to "Collections" ... Doesn't make send to be 'add to' when it can also remove	2020-09-08 12:00:00 +09:00
smoogipoo	ca4423af74	Fix tests	2020-09-08 00:07:12 +09:00
smoogipoo	e37c04cb6d	Change back to solid icon	2020-09-08 00:04:03 +09:00
smoogipoo	a1214512bc	Add filter control tests	2020-09-07 23:57:49 +09:00
smoogipoo	98e9c4dc25	General refactorings	2020-09-07 21:08:48 +09:00
smoogipoo	c1d255a04c	Split filter control into separate class	2020-09-07 20:44:39 +09:00
smoogipoo	120dfd50a6	Fix collection names not updating in dropdown	2020-09-07 20:29:28 +09:00
smoogipoo	b91a376f0a	Split dropdown into separate file	2020-09-07 20:06:38 +09:00
smoogipoo	6cc4517600	Merge branch 'master' into collection-database	2020-09-07 20:03:11 +09:00
smoogipoo	4b4dd02942	Make collection name a bindable	2020-09-05 04:43:59 +09:00
smoogipoo	345fb9d8e0	Rename classes	2020-09-05 03:55:43 +09:00
smoogipoo	ebd11ae0b7	Add a collection management dialog	2020-09-05 03:52:07 +09:00
Dan Balasescu	743c888986	Merge branch 'master' into expose-wedge-icons	2020-09-04 16:22:14 +09:00
Dan Balasescu	b631430a5b	Merge pull request #10045 from peppy/add-info-wedge-icons ... Update and add missing beatmap statistic icons to info wedge	2020-09-04 16:22:01 +09:00
smoogipoo	4399f5976c	Fix global mods being retained by rooms	2020-09-04 15:20:55 +09:00
Dean Herbert	25e142965d	Strongly type and expose default beatmap information icon implementations for other rulesets	2020-09-04 15:01:32 +09:00
Dean Herbert	cd253ab055	Further tweaks to get closer to design originals	2020-09-04 13:05:39 +09:00
Dean Herbert	d6b46936a0	Adjust sizing to match updated textures with less padding	2020-09-04 12:55:28 +09:00
Dean Herbert	a99e7a1dc2	Merge branch 'master' into add-info-wedge-icons	2020-09-03 21:57:58 +09:00
Dean Herbert	7a0c1411b6	Merge branch 'master' into timeshift-leaderboard-topscore	2020-09-03 18:11:04 +09:00
Dean Herbert	72cb65c22f	Update and add missing beatmap statistic icons to info wedge	2020-09-03 17:52:22 +09:00
smoogipoo	fca0324264	Disallow being able to add dummy beatmap	2020-09-02 23:34:38 +09:00
smoogipoo	d83264f538	Add max height	2020-09-02 22:56:13 +09:00
smoogipoo	7fcbc3a814	Respond to changes in beatmap	2020-09-02 22:06:17 +09:00
smoogipoo	661eac8f1d	Add add/remove button to dropdown items	2020-09-02 22:03:38 +09:00
smoogipoo	02a908752f	Fix stackoverflow	2020-09-02 21:52:56 +09:00
smoogipoo	5ebead2bfd	Prevent ValueChanged binds to external bindable	2020-09-02 21:44:07 +09:00
smoogipoo	d363a5d164	Add basic ordering	2020-09-02 21:19:15 +09:00
smoogipoo	094ddecc95	Add dropdowns to carousel items	2020-09-02 21:08:31 +09:00
smoogipoo	6d5e155106	Change to BindableList to notify of changes	2020-09-02 20:44:26 +09:00
smoogipoo	9dde37fe40	Hook up collection filter	2020-09-02 20:25:42 +09:00
smoogipoo	bb090a55e0	Add dropdown to filter control	2020-09-02 20:25:25 +09:00
Dan Balasescu	f08e7828da	Merge branch 'master' into beatmap-track-rework	2020-09-01 16:06:38 +09:00
Bartłomiej Dach	876fd21230	Apply shear to right-anchored items	2020-08-31 19:31:47 +02:00
Bartłomiej Dach	2e2f26449d	Change anchoring to TopRight	2020-08-31 19:23:19 +02:00
smoogipoo	8cf26979fb	Allow null user score	2020-08-31 20:16:28 +09:00
smoogipoo	ed74c39b55	Move UserTopScoreContainer into base leaderboard	2020-08-31 19:54:22 +09:00
Bartłomiej Dach	7d273d631b	Do not show star difficulty on wedge if zero	2020-08-31 11:05:42 +02:00
Bartłomiej Dach	4736845318	Add spacing between star rating and beatmap status	2020-08-31 10:56:06 +02:00
smoogipoo	c3bfce6ccf	Add star rating to beatmap wedge	2020-08-31 15:03:41 +09:00
Dean Herbert	b51db90147	Merge branch 'master' into beatmap-track-rework	2020-08-26 23:20:56 +09:00
Bartłomiej Dach	29b4d98aac	Show retry/fail graph when either list is present	2020-08-24 20:41:50 +02:00
Bartłomiej Dach	cc6ae8e3bd	Fix crash if only one count list is received from API	2020-08-24 20:41:31 +02:00
Keijia	b5b2e523ad	change switch cases	2020-08-22 12:10:31 +03:00
Keijia	0b6185cd14	add "hp" filter keyword	2020-08-22 01:09:35 +03:00
Dean Herbert	e465afa280	Merge branch 'master' into beatmap-track-rework	2020-08-14 20:02:43 +09:00
smoogipoo	0500d82b5b	Fix playlist items sharing mod instances	2020-08-13 19:48:41 +09:00
smoogipoo	7d35893ecd	Make MusicController non-nullable	2020-08-11 12:40:58 +09:00
smoogipoo	f058f5e977	Fix incorrect value being set	2020-08-06 16:24:14 +09:00
smoogipoo	5c05fe3988	Expose track from MusicController	2020-08-06 16:24:14 +09:00
smoogipoo	6e42b8219c	Move track to MusicController, compiles	2020-08-06 16:24:14 +09:00
smoogipoo	877b985e90	Remove local cancellation token	2020-07-24 16:11:28 +09:00
smoogipoo	b10b99a670	Change method signatures to remove tracked/untracked	2020-07-24 13:52:43 +09:00
smoogipoo	76284a0f01	Move cancellation out of condition	2020-07-23 23:18:51 +09:00
smoogipoo	107b5ca4f2	Add support for bindable retrieval	2020-07-21 23:13:04 +09:00
smoogipoo	9a52058a7a	Update carousel beatmap SR on mod/ruleset changes	2020-07-16 21:08:24 +09:00
smoogipoo	24f14751ce	Update beatmap details SR on ruleset/mod changes	2020-07-16 21:08:08 +09:00
Joehu	73e1bf0d89	Check sub screen's OnBackButton instead	2020-07-14 13:19:48 -07:00
Joehu	36041fc245	Fix back button not working correctly with multi song select's mod select	2020-07-14 00:29:57 -07:00
Joehu	4caf4d31d4	Fix mod select blocking home and alt f4 in song select	2020-07-14 00:00:10 -07:00
Dean Herbert	0718e9e4b6	Update outdated comment	2020-07-13 13:08:41 +09:00
Dean Herbert	ab11a112b7	Fix correct filter criteria not being applied to beatmap carousel if beatmaps take too long to load	2020-07-12 22:33:41 +09:00
Dean Herbert	f231b5925f	Add "show converted" checkbox to song select for convenience	2020-07-09 13:47:23 +09:00
Dean Herbert	bbbe8d6f68	Remove group selector for now, tidy up code somewhat	2020-07-09 13:47:11 +09:00
smoogipoo	af7494b232	Improve quality of song select beatmap wedge	2020-06-29 13:58:35 +09:00
smoogipoo	099416b4c3	Move check inside next difficulty selection	2020-06-26 21:03:34 +09:00
smoogipoo	8f6d52550f	Fix potential exception if button is pressed before selection	2020-06-26 20:32:13 +09:00
smoogipoo	1b4c31a84f	Remove double schedule	2020-06-26 20:14:08 +09:00
smoogipoo	e3d654d33f	Cleanup	2020-06-26 20:14:02 +09:00
Dean Herbert	d704a4597d	Use existing helper function for key repeat	2020-06-25 21:33:02 +09:00
Dean Herbert	d7742766d0	Add key/press repeat support to carousel	2020-06-25 19:47:23 +09:00
Viktor Rosvall	9e1bf71233	Added text explaining a second copy will be made	2020-06-24 11:29:38 +02:00
Jack Boswell	eb3eb70a65	Merge branch 'master' into rebind-song-select	2020-06-10 22:03:26 +12:00
Jack Boswell (boswelja)	9dc1eab6ae	Improve code readability of FooterButtonRandom OnPressed	2020-06-10 13:05:11 +12:00
Jack Boswell (boswelja)	ea9207e0ad	Clean up FooterButtonRandom ... Removed unnecessary using statements Removed unnecessary constructor	2020-06-08 17:31:31 +12:00
Jack Boswell (boswelja)	bddd2b72ba	Remove secondaryText and related code from FooterButtonRandom	2020-06-08 15:05:53 +12:00
Jack Boswell (boswelja)	8b7718116d	Add missing blank lines	2020-06-07 16:06:18 +12:00
Jack Boswell (boswelja)	0e155c8eb9	Don't switch FooterButtonRandon Action on pressed. ... Instead, create a new Action that invokes either NextRandom or PreviousRandom, depending on rewindSearch	2020-06-07 15:34:19 +12:00
Jack Boswell (boswelja)	a40475e6aa	Remove triggerNextRandom from SongSelect	2020-06-04 21:09:47 +12:00
Jack Boswell (boswelja)	cb6e473910	Remove triggerPreviousRandom from SongSelect	2020-06-04 21:08:07 +12:00
Jack Boswell (boswelja)	cab132673a	Break FooterButtonRandom creation into multiple lines	2020-06-04 21:03:10 +12:00
Jack Boswell (boswelja)	8533d7573d	Rename FooterButtonRandom actions to better describe what they are used for	2020-06-04 21:00:29 +12:00
Jack Boswell (boswelja)	62984cb7f5	Remove unused Hotkey assignment	2020-06-04 20:58:53 +12:00
Jack Boswell (boswelja)	df148cf9d1	Rename secondaryAction to rewindSearch	2020-06-04 20:58:19 +12:00
Jack Boswell (boswelja)	bd3e40a8cf	Move default return out of switch/case	2020-06-04 20:57:24 +12:00
Jack Boswell (boswelja)	a78a8c0d0d	Add missing blank lines	2020-06-04 16:59:04 +12:00
Jack Boswell (boswelja)	7141bed78d	Remove redundant directive from FooterButton	2020-06-04 16:40:16 +12:00
Jack Boswell (boswelja)	eb242085c6	Remove redundant interface from FooterButtonMods	2020-06-04 16:24:32 +12:00
Jack Boswell (boswelja)	aeb736e9d2	Fix CodeFactor code style issues	2020-06-04 16:13:50 +12:00
Jack Boswell (boswelja)	aa08847bc9	Set FooterButtonRandom actions properly when creating the button	2020-06-04 16:08:16 +12:00
Jack Boswell (boswelja)	568503ef99	Update FooterButtonRandom to comply with the changes in FooterButton ... FooterButtonRandom now has 2 Action variables, one for both primary and secondary	2020-06-04 16:07:50 +12:00
Jack Boswell (boswelja)	05e4499bc1	Update FooterButtonOptions to comply with the changes in FooterButton	2020-06-04 15:25:18 +12:00
Jack Boswell (boswelja)	18db31b504	Update FooterButtonMods to comply with the changes in FooterButton	2020-06-04 15:25:05 +12:00
Jack Boswell (boswelja)	782fddb6f1	Modify FooterButton to implement IKeyBindingHandler for responding to hotkeys	2020-06-04 15:21:13 +12:00
smoogipoo	f3b5149648	Move some suggestions to warnings, resolve issues	2020-06-03 16:48:44 +09:00
Dean Herbert	93572fc17d	Merge branch 'master' into present-recommended	2020-06-03 12:31:23 +09:00
Lucas A	275d95082a	Fix crash in testing environment.	2020-06-02 16:01:01 +02:00
Lucas A	f63c66396f	Apply review suggestions.	2020-06-02 13:32:52 +02:00
Lucas A	e9b09373e7	Fix crashing if selected ruleset doesn't have an autoplay mod.	2020-06-01 17:41:04 +02:00
Dean Herbert	d4b7c81f96	Merge branch 'master' into results-screen-condensed-panel	2020-05-30 23:13:52 +09:00
Dean Herbert	f989f1aa00	Change event flow to avoid firing store delete events on update	2020-05-27 16:08:47 +09:00
smoogipoo	de0b6ec9f1	Create abstract implementation	2020-05-26 17:00:41 +09:00
Dean Herbert	052ad79fc6	Convert dangerous events to IBindables	2020-05-19 16:44:22 +09:00
Dean Herbert	a5c1b461f6	Fix null reference in difficulty recommender	2020-05-12 11:14:51 +09:00
smoogipoo	401c516503	Expose searchable terms from beatmap info instead	2020-05-07 13:04:08 +09:00
smoogipoo	5186da8412	Fix potential song select nullref	2020-05-07 11:37:04 +09:00
Dan Balasescu	0eae8d078b	Merge branch 'master' into master	2020-05-05 13:33:29 +09:00
alex	0e2ccac33b	Add spaces to comments	2020-05-04 18:36:24 -07:00
Dean Herbert	06f58dd3e3	Ensure correct beatmap and ruleset when presenting a score from song select	2020-05-04 15:20:43 +09:00
Endrik Tombak	1c04d58d6e	Fix recommender's incorrect usage of current ruleset	2020-05-01 19:44:35 +03:00
Bartłomiej Dach	623611d9dc	Simplify ruleset ordering	2020-05-01 17:15:35 +02:00
Bartłomiej Dach	9f091f3a56	Do not query API for custom rulesets	2020-05-01 17:02:28 +02:00
Endrik Tombak	33a608fd15	Merge branch 'master' of https://github.com/ppy/osu into present-recommended ... Conflicts: osu.Game/Screens/Select/SongSelect.cs	2020-05-01 11:06:20 +03:00
Dean Herbert	000c34dc26	Move recommender to field construction	2020-04-30 21:01:53 +09:00
Dean Herbert	cf4e79cf38	Show loading spinner when carousel is not ready to be displayed	2020-04-30 11:51:06 +09:00
Dean Herbert	119000f1ab	Reduce database includes where possible	2020-04-28 21:43:35 +09:00
Endrik Tombak	657bf5ad86	Merge branch 'master' of https://github.com/ppy/osu into present-recommended	2020-04-25 10:13:57 +03:00
smoogipoo	fcfb2b9026	Merge branch 'master' into fix-select-new-from-sub-screen	2020-04-21 14:36:53 +09:00
Dan Balasescu	3b3a7bdd85	Merge branch 'master' into scroll-to-center	2020-04-21 10:21:08 +09:00
Bartłomiej Dach	e3cd3cf1da	Convert to auto-properties	2020-04-20 21:43:07 +02:00
Bartłomiej Dach	9b6e26583b	Add xmldocs	2020-04-20 21:42:43 +02:00
Dean Herbert	ee1ccb8bcb	Fix in a slightly different and hopefully more understandable way	2020-04-20 14:03:55 +09:00
Endrik Tombak	b57d709d15	Don't use Parent	2020-04-19 18:29:06 +03:00
Endrik Tombak	a8bfd21f3f	Merge branch 'master' of https://github.com/ppy/osu into scroll-to-center	2020-04-19 18:21:34 +03:00
Endrik Tombak	4aaa00e321	Fix CI complaints	2020-04-17 20:33:12 +03:00
Endrik Tombak	1ac9ee5990	Optimize recommender (for custom rulesets)	2020-04-17 18:15:11 +03:00
Dean Herbert	5833a7ac91	Fix presenting new ruleset and beatmap at once causing wedge display desync	2020-04-17 18:56:17 +09:00
Dean Herbert	d62094cd4b	Fix carousel not correctly updating when selection changes to a new beatmap from a child screen	2020-04-16 18:10:35 +09:00
Dean Herbert	03a74a4320	Apply same conditional check changes to DrawableCarouselBeatmapSet	2020-04-16 12:13:26 +09:00
Dean Herbert	91b13f91ea	Add exception disallowing potential edit when disabled at a property level	2020-04-16 12:11:12 +09:00
Dean Herbert	c4caf38feb	Simplify menu item checks (and add for other items)	2020-04-16 12:10:20 +09:00
Joehu	e2b28bfe88	Hide edit context menu item in multiplayer song select	2020-04-15 18:17:12 -07:00
Endrik Tombak	b5c1752f0a	Calculate best ruleset order only once	2020-04-15 18:14:51 +03:00
Endrik Tombak	bbef94b4df	Reset best order on ruleset change	2020-04-14 18:56:20 +03:00
Endrik Tombak	00d1cf1ce2	Recommend from all rulesets	2020-04-14 18:42:18 +03:00
Endrik Tombak	dd6c9173da	Move DifficultyRecommender to OsuGameBase	2020-04-14 18:42:00 +03:00
Endrik Tombak	b475316a4e	Simplify and comment	2020-04-12 20:40:08 +03:00
Endrik Tombak	63a1686dfb	Scroll to screen middle	2020-04-12 12:42:52 +03:00
Dean Herbert	73a3f1fe65	Remove unnecessary DI	2020-04-11 17:30:34 +09:00
Dean Herbert	7aac0e59a8	Reduce dictionary lookups	2020-04-11 17:13:35 +09:00
Dean Herbert	310cf830d4	Simplify api request logic	2020-04-11 17:13:35 +09:00
Dean Herbert	abea7b5299	Tidy up function passing, naming, ordering etc.	2020-04-11 17:13:35 +09:00
Dean Herbert	7f753f6b4d	Remove current ruleset from function call	2020-04-11 16:43:09 +09:00
Dean Herbert	a843793957	Un-nest class	2020-04-11 16:41:11 +09:00
Endrik Tombak	deaf24f141	Fix oversight on null	2020-04-09 19:30:40 +03:00
Endrik Tombak	35f97dfc75	Style changes	2020-04-09 18:59:18 +03:00
Endrik Tombak	f40bdcd34e	Initial rewrite, moving API logic to SongSelect	2020-04-09 18:47:28 +03:00
Dean Herbert	260de77304	Merge branch 'master' into select-recommended	2020-04-09 15:30:35 +09:00
Dean Herbert	4bfc738f5b	Merge pull request #7639 from santerinogelainen/master ... Add top rank to the beatmap carousel	2020-04-08 23:36:47 +09:00
smoogipoo	ed3e0a01e1	Re-namespace into song select	2020-04-07 15:31:22 +09:00
Joehu	57b6a91449	Remove unnecessary input override on footer button mods ... Was used when it expanded on hover, but doesn't anymore.	2020-04-05 14:57:44 -07:00
Santeri Nogelainen	163de36777	Merge remote-tracking branch 'upstream/master'	2020-04-04 22:29:15 +03:00
Santeri Nogelainen	1e8badb14a	Move all logic to TopLocalRank and remove CarouselBeatmapRank	2020-04-04 22:28:36 +03:00
Joehu	493b654011	Remove horizontal margin from mod display ... Can skew center alignment on fill flow containers. Fixes affected areas. Vector2(5, 0) is similar to MarginPadding { Left = 10 }.	2020-04-03 11:30:02 -07:00
Dean Herbert	b47a532df3	Adjust code formatting slightly	2020-03-30 00:07:48 +09:00
Endrik Tombak	b4f0500706	Invert logic	2020-03-28 20:21:21 +02:00
Endrik	2c27894527	Use All instead of ToList Any ... Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2020-03-28 19:58:33 +02:00
Santeri Nogelainen	6bde102207	Merge remote-tracking branch 'upstream/master'	2020-03-28 18:14:17 +02:00
Santeri Nogelainen	faa2b49be4	Fix namespace for CarouselBeatmapRank, make UpdateableRank in TopLocalRank readonly	2020-03-28 18:13:39 +02:00
Santeri Nogelainen	1c711147f3	Move all carousel rank logic into separate classes (TopLocalRank and CarouselBeatmapRank)	2020-03-28 17:22:01 +02:00
Endrik Tombak	87854fc4fa	Rename variable	2020-03-28 13:23:31 +02:00
Endrik Tombak	6a0c5c87aa	Use already existing variable	2020-03-28 13:06:03 +02:00
Endrik Tombak	fc3f9ff6fa	Don't use drawables for select next	2020-03-28 12:54:48 +02:00
Endrik Tombak	bbbaaae3ee	Write tests	2020-03-26 19:18:16 +02:00
Endrik Tombak	ee112c6f50	Move and change logic	2020-03-26 18:42:08 +02:00
Endrik Tombak	2f5dc93d61	Select recommended difficulty	2020-03-26 00:19:54 +02:00
Dean Herbert	b1d4261402	Fix track looping state not being reset when entering editor from song select ... Closes #8432.	2020-03-25 15:50:19 +09:00
Dean Herbert	2a1e7a7ff0	Merge branch 'master' into fix-select-filter-not-absorbing-input	2020-03-24 14:03:58 +09:00
Dan Balasescu	6279c78e3c	Merge branch 'master' into fix-keypad-autoplay-shortcut	2020-03-24 13:34:31 +09:00
Joehu	5bc5119389	Handle OnHover on song select filter and footer	2020-03-23 16:03:33 -07:00
Joehu	96d962ab30	Fix autoplay keyboard shortcut not working with keypad enter key	2020-03-23 11:25:40 -07:00
Joehu	96848405fd	Fix song select filter not absorbing input from carousel	2020-03-23 10:54:45 -07:00
Dean Herbert	47c7673c9e	Fix crash when holding a key down while entering player	2020-03-23 17:04:54 +09:00
Dan Balasescu	d0c7b49376	Merge branch 'master' into fix-carousel-root-selects-from-nothing	2020-03-23 11:34:04 +09:00
Dean Herbert	29009c85c0	Fix typo in comment ... Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2020-03-22 00:32:53 +09:00
Dean Herbert	9b60b535e5	Fix selection not occurring when switching from empty ruleset on first load	2020-03-20 15:01:26 +09:00
Dean Herbert	be4a97c289	Correctly bypass last selected when it is filtered	2020-03-20 13:01:24 +09:00
Dean Herbert	8f9e97b4cc	Fix carousel not remembering last selection correctly	2020-03-19 18:07:39 +09:00
unknown	2340142dc1	Merge branch 'master' of https://github.com/ppy/osu into linkify-metadata	2020-03-18 14:18:53 +08:00
smoogipoo	1c4296f5e7	Implement the new results screen	2020-03-17 17:43:16 +09:00
Dean Herbert	5e3668b2ea	Merge pull request #8260 from smoogipoo/add-workingbeatmap-timeout ... Add beatmap loading timeout to prevent runaway loading scenarios	2020-03-17 11:17:35 +09:00
Dan Balasescu	e835f88c0c	Merge pull request #8255 from peppy/fix-carousel-scroll-while-import ... Fix carousel scrolling being inoperable during beatmap import	2020-03-16 12:50:45 +09:00
Dan Balasescu	3e65f13c67	Merge branch 'master' into fix-carousel-scroll-while-import	2020-03-16 12:06:50 +09:00
Dean Herbert	9bb3a6c677	Merge branch 'master' into click-group-difficulty-icons	2020-03-16 12:01:09 +09:00
Dean Herbert	d6be8eec0c	Merge branch 'master' into click-disabled-difficulty-icons	2020-03-16 11:30:57 +09:00
Dan Balasescu	f390c1995d	Apply comment suggestions ... Co-Authored-By: Dean Herbert <pe@ppy.sh> Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2020-03-16 11:29:28 +09:00
Dan Balasescu	bd05462a7f	Merge branch 'master' into carousel-selection-fallback-improvement	2020-03-16 10:53:10 +09:00
Dan Balasescu	25a35a1370	Merge branch 'master' into always-apply-ruleset-filter	2020-03-16 10:32:36 +09:00
Dean Herbert	340d362d69	Appease inspectcode	2020-03-15 03:51:30 +09:00
smoogipoo	c33ca6e99c	Decorate usages with exception management	2020-03-13 14:28:11 +09:00
Dean Herbert	ac70fcc544	Change logic to be more resilient by identifying user scroll events	2020-03-13 12:30:27 +09:00
Dean Herbert	5f8d180b5e	Fix carousel scrolling being inoperable during beatmap import	2020-03-13 11:51:26 +09:00
Dean Herbert	04f1da04db	Remove incorrect xmldoc from SelectBeatmap function	2020-03-13 10:52:08 +09:00
Dean Herbert	3f8b454ff4	Reword comment to match new filtering behaviour ... Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2020-03-13 10:01:28 +09:00
Dean Herbert	ca9cfbe51d	Move selection fallback logic out of BeatmapCarousel to SongSelect	2020-03-12 18:42:08 +09:00
Dean Herbert	6e11c3014c	Allow grouped difficulty icons to be clicked	2020-03-12 18:42:08 +09:00
Dean Herbert	ce5d01ed19	Allow filtered difficulty icons to be clicked	2020-03-12 18:42:08 +09:00
Dean Herbert	fc058f8896	Remove unnecessary this. prefix	2020-03-12 18:03:18 +09:00
Dean Herbert	933a8ffc8a	Add test coverage	2020-03-12 17:10:51 +09:00
Dean Herbert	28ac5af91c	Fix beatmap carousel tests loading beatmap manager beatmaps in test browser	2020-03-12 16:53:23 +09:00
Dean Herbert	63edcddaf1	Apply ruleset filter in all cases (even when bypassing filter for selection purposes)	2020-03-12 15:06:26 +09:00
Dan Balasescu	e6685c88fc	Merge pull request #8205 from peppy/always-scroll-to-selection ... Fix changing ruleset at song select not scrolling the current selection back into view	2020-03-11 14:38:57 +09:00
Dan Balasescu	f8f8e3628f	Merge branch 'master' into always-scroll-to-selection	2020-03-11 13:38:28 +09:00
Dan Balasescu	9119e32f63	Merge branch 'master' into better-filter-bypass	2020-03-11 13:37:55 +09:00
Dean Herbert	ed837d3115	Use framework extension method for FromHex	2020-03-11 10:18:41 +09:00
Dean Herbert	a2d3f20409	Merge branch 'master' into better-filter-bypass	2020-03-11 02:55:14 +09:00
Dean Herbert	8294dd0b71	Fix changing ruleset at song selectnot scrolling the current selection back into view	2020-03-10 19:59:49 +09:00
Dean Herbert	979988235d	Increase flexibility of StarCounter component	2020-03-08 15:56:22 +09:00
Dean Herbert	0477ef6c13	Force a selection after filtering to ensure correct difficulty is selected	2020-03-05 21:45:19 +09:00
Dean Herbert	332f56a7f8	Fix nullref in tests	2020-03-05 20:34:24 +09:00
Dean Herbert	f8776a0be4	Display all difficulties from overriding selection	2020-03-04 22:59:49 +09:00
Dean Herbert	a62550b323	Reapply filters on next change after a forced beatmap display	2020-03-04 20:14:18 +09:00
Dean Herbert	e890e45420	Fix Ctrl+Enter behaviour regression	2020-03-02 19:44:25 +09:00
Dean Herbert	48f2f615cd	Merge branch 'master' into fix-volume-bninding-handling	2020-03-02 19:28:36 +09:00
Dean Herbert	489bf16bea	Add SelectNext and SelectPrevious global actions	2020-03-02 18:55:28 +09:00
smoogipoo	7ad6ad0bb0	Remove hacks that bypassed layout shortcomings	2020-02-27 13:32:23 +09:00
Dean Herbert	623b78d675	Combine all loading animation implementations	2020-02-21 15:32:46 +09:00
Dean Herbert	cd666166d5	Merge pull request #7809 from voidedWarranties/proposal-difficulty-icon-select ... Allow selecting/playing a specific difficulty using the beatmapset difficulty icons	2020-02-21 10:24:12 +09:00
Dean Herbert	db4fe4f728	Merge branch 'master' into adjust-beatmap-overlay	2020-02-21 09:52:44 +09:00
smoogipoo	f9145ce5b4	Fix playlist items added with the wrong IDs	2020-02-17 17:02:19 +09:00
TheWildTree	64a9b9c6fb	Remove redundant using directives	2020-02-16 21:52:08 +01:00
TheWildTree	4d180a685a	Adjust font sizes and spacing in BeatmapSetOverlay	2020-02-16 21:43:33 +01:00
voidedWarranties	8c81f1e684	Move CarouselBeatmap access to private, test using indices	2020-02-15 17:51:55 -08:00
recapitalverb	2778c6617c	Merge branch 'master' into remove-duplicated-load	2020-02-15 15:13:35 +07:00
Dean Herbert	637c1dc840	In the case of only one playlist item, update with current selection on select	2020-02-15 14:41:16 +09:00
recapitalverb	7c9569c9a3	Merge branch 'master' into remove-duplicated-load	2020-02-15 12:10:34 +07:00
Dean Herbert	da68ae5461	Merge branch 'master' into match-songselect-playlist-logic	2020-02-15 12:27:51 +09:00
voidedWarranties	8e1ecddb1d	Add testing	2020-02-14 17:23:24 -08:00
recapitalverb	c46d828716	Preserve permitNulls	2020-02-14 20:59:51 +07:00
recapitalverb	10798aeab3	Fix code formatting	2020-02-14 20:30:27 +07:00
recapitalverb	c753cb46c5	Use [Resolved] wherever possible	2020-02-14 20:14:00 +07:00
smoogipoo	f31220c1ee	Fix exception when adding duplicate items	2020-02-14 19:56:43 +09:00
Dean Herbert	14f632b532	Merge branch 'master' into match-detail-area	2020-02-14 19:54:17 +09:00
smoogipoo	f0f739707f	Add playlist support to match song select	2020-02-14 17:51:42 +09:00
Dean Herbert	66910f1ee3	Remove unnecessary bindable setter	2020-02-14 17:50:53 +09:00
Dean Herbert	48dcb91118	Merge branch 'master' into custom-detail-area	2020-02-14 17:40:12 +09:00
smoogipoo	5ec9f454d5	Implement the match beatmap detail area	2020-02-14 17:20:38 +09:00
smoogipoo	25e399f11b	Merge branch 'match-playlist' into match-detail-area	2020-02-14 17:04:22 +09:00
voidedWarranties	368e6f9579	Use CarouselBeatmap.State to select	2020-02-13 17:47:16 -08:00
voidedWarranties	c871f07d2e	Use CarouselBeatmap action to select beatmap	2020-02-13 17:14:46 -08:00
Dean Herbert	b9a296d3f9	Merge branch 'master' into remove-current-item	2020-02-13 19:34:15 +09:00
Dean Herbert	49a1725749	Merge pull request #7812 from smoogipoo/playlist-bindables ... Make playlist beatmap and ruleset into bindables	2020-02-13 18:51:42 +09:00
smoogipoo	75bef15583	Remove "current" multiplayer room item	2020-02-13 18:48:28 +09:00
smoogipoo	91edadfe9d	Make playlist beatmap and ruleset into bindables	2020-02-13 18:12:47 +09:00
smoogipoo	d4f14e552a	Improve extensibility of mod display expansion	2020-02-13 18:05:53 +09:00
voidedWarranties	ad0de27964	Safer dependency injection and accessibility levels	2020-02-12 22:11:26 -08:00
smoogipoo	6f7196b0b8	Make beatmap detail area abstractable	2020-02-13 13:46:23 +09:00
voidedWarranties	f8b69fe632	Remove unnecessary carousel variable, fix code formatting	2020-02-12 20:11:39 -08:00
voidedWarranties	b126c00292	Use dependency loader to get SongSelect instance	2020-02-12 19:05:08 -08:00
voidedWarranties	2901ec9f26	Select specific difficulties using their icons	2020-02-11 20:05:26 -08:00
Dean Herbert	8186f72507	Remove unused using	2020-02-10 17:12:45 +09:00
Dean Herbert	66fb72cd8a	Fix song select not showing active beatmap if it is filtered by local criteria	2020-02-10 16:59:54 +09:00
Dean Herbert	81cadb7875	Simplify the way multiple subscreens handle their disable states via a custom stack	2020-02-06 14:22:01 +09:00
recapitalverb	79bb476f4c	Merge branch 'master' into display-accuracy	2020-02-04 11:39:47 +07:00
Dan Balasescu	3600b0daf0	Merge branch 'master' into fix-mod-select-overflowing	2020-02-04 11:57:54 +09:00
Joehu	22e3150f68	Fix comment and remove magic numbers	2020-02-03 17:21:06 -08:00
recapitalverb	9898a926b2	Use ScoreInfo.DisplayAccuracy everywhere	2020-02-03 22:11:36 +07:00
Dan Balasescu	c6e7603e5e	Merge branch 'master' into safe-screen-lease	2020-02-03 18:18:13 +09:00
Dan Balasescu	93952d438f	Merge pull request #7677 from peppy/decouple-mod-select-bindable ... Decouple ModSelectOverlay from global SelectedMods	2020-02-03 16:27:47 +09:00
Dean Herbert	9183c78319	Fix crash on exiting song select with ctrl-enter autoplay	2020-02-03 16:04:32 +09:00
Dean Herbert	aa1daa0ad5	Merge pull request #7703 from bdach/beatmap-stats-precision ... Apply precision when determining bar colour in difficulty statistics	2020-02-02 22:31:52 +09:00
Bartłomiej Dach	e894acf53c	Make star filter range bindables BindableDoubles ... Due to using Bindable<double>s previously, song select's filter control would not apply tolerance when checking IsDefault, therefore wrongly hiding maps with star ratings above 10.1.	2020-02-01 22:48:46 +01:00
Joehu	609ee26030	Fix mod select overlay not showing up in test	2020-02-01 11:41:41 -08:00
Joehu	2d42a83bb9	Fix mod select overlay overflowing toolbar at max ui scale	2020-02-01 11:24:29 -08:00
Bartłomiej Dach	0bfadfbbf1	Apply precision when comparing adjusted values ... In some cases, applying the Difficulty Adjust mod without actually changing any of the settings previously caused the bar in song select beatmap details to appear red/blue instead of staying white. This was caused by not accounting for floating-point imprecisions when determining bar colour in AdvancedStats. To resolve, first check equality with tolerance, and only then apply blue/red colours if that equality check does not hold.	2020-02-01 16:16:15 +01:00
Bartłomiej Dach	a74d22d9e5	Extract beatmap stats test to separate scene	2020-02-01 15:50:33 +01:00
Dean Herbert	ed368e44ea	Merge branch 'master' into safe-screen-lease	2020-02-01 02:11:18 +09:00
Dean Herbert	c5422743e2	Merge branch 'master' into decouple-mod-select-bindable	2020-02-01 02:06:23 +09:00
Dean Herbert	19f516e710	Ensure OsuScreen level leases are taken out synchronously	2020-01-31 19:10:44 +09:00
Dean Herbert	2f61d3f5ad	Fix song select remaining issue locally	2020-01-31 17:35:53 +09:00
unknown	2952fc8cc4	remove unused using	2020-01-31 09:05:13 +08:00
unknown	b916366536	fix formatting	2020-01-31 08:17:39 +08:00
unknown	2274d70dac	apply suggestions	2020-01-31 06:41:50 +08:00
Dean Herbert	7bf2e9b369	Decouple ModSelectOverlay from global SelectedMods	2020-01-30 17:38:15 +09:00
Dan Balasescu	09f6c57b0f	Merge branch 'master' into fix-import-different-ruleset	2020-01-30 15:08:25 +09:00
Dan Balasescu	c18b1b302c	Merge branch 'master' into editor-match-accessibility	2020-01-30 13:49:56 +09:00
unknown	0d3ccae1c2	Merge branch 'master' of https://github.com/ppy/osu into linkify-metadata	2020-01-30 12:31:17 +08:00
unknown	c5995acfff	linkify metadata	2020-01-30 12:30:25 +08:00
Dean Herbert	c158570249	Fix typo in comment ... Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2020-01-30 11:31:34 +09:00
Dean Herbert	f72de235cc	Remove unnecessary length specifications	2020-01-30 11:00:14 +09:00
Dean Herbert	37ecf8a060	Remove commented line	2020-01-30 10:50:48 +09:00
Dean Herbert	bea20efb64	Merge branch 'master' into mod_content_centering	2020-01-30 10:34:46 +09:00
Bartłomiej Dach	f130e48c9e	Remove leftover negative margin	2020-01-29 19:17:07 +01:00
Bartłomiej Dach	c9dda78ded	Refactor drawable hierarchy to center properly ... * Use FillFlowContainer.Spacing instead of manually applying margins. * Use Update() for calculating button padding to preserve it after mod button expansion and adjust FooterButtonRandom to use this method while avoiding flickering. * Expose mod display margin to clear it in the footer button.	2020-01-29 18:59:51 +01:00
Dean Herbert	da6952407e	Allow null DI	2020-01-29 23:01:57 +09:00
Dean Herbert	13eb32fea2	Fix editor being accessible for multiplayer song select	2020-01-29 22:20:34 +09:00
smoogipoo	76af8bea5d	Fix percentage-formatted displays containing a space	2020-01-29 19:51:24 +09:00
Dean Herbert	7588c574a2	Fix presenting a beatmap from a different ruleset not working	2020-01-29 19:37:54 +09:00
Dean Herbert	77c06b1c6e	Fix beatmap carousel potentially missing beatmap imports	2020-01-29 17:09:12 +09:00
Dean Herbert	12ff51f686	Fix key count being incorrectly adjusted by hard/easy mods	2020-01-28 17:21:50 +09:00
Dean Herbert	7aa5e8c23e	Limit input propagation correctly	2020-01-27 14:55:47 +09:00
Dean Herbert	1c64b70b06	Revert "Fix crash due to misordered selection events" ... This reverts commit 2d74609f50.	2020-01-27 14:53:24 +09:00
Dean Herbert	2d74609f50	Fix crash due to misordered selection events	2020-01-26 19:06:50 +09:00
Dean Herbert	92a5fbe948	Merge branch 'master' into star-filtering	2020-01-24 23:28:36 +09:00
smoogipoo	45a25214ab	Make upper and lower bounds inclusive	2020-01-24 19:39:21 +09:00
smoogipoo	9e0e7be8d0	Modernise filter implementation	2020-01-24 18:57:17 +09:00
smoogipoo	12cc97ca31	Merge remote-tracking branch 'origin/master' into star-filtering ... # Conflicts: # osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapCarousel.cs # osu.Game/Screens/Select/Carousel/CarouselBeatmap.cs # osu.Game/Screens/Select/FilterControl.cs # osu.Game/Screens/Select/FilterCriteria.cs	2020-01-24 18:30:52 +09:00
Dean Herbert	fdde4a6858	Tidy up song select hierarchy to be more readable	2020-01-24 15:44:31 +09:00
Dean Herbert	c0a233e8bb	Align background wedge with carousel	2020-01-24 15:00:10 +09:00
Dean Herbert	f8cb898516	Improve song select display on ultrawide displays (or when UI scale is set low)	2020-01-23 20:03:52 +09:00
Dean Herbert	8a7f7c5e46	Merge remote-tracking branch 'smoogipoo/void-key-up-returns' into update-framework	2020-01-22 22:57:56 +09:00
Dean Herbert	7c62cc3ac3	Merge remote-tracking branch 'smoogipoo/void-mouse-up-returns' into update-framework	2020-01-22 22:57:52 +09:00
Dean Herbert	5f8ffd9346	Merge remote-tracking branch 'smoogipoo/void-release-returns' into update-framework	2020-01-22 22:57:40 +09:00
smoogipoo	7b2f58eb30	Apply OnRelease method signature refactorings	2020-01-22 13:22:34 +09:00
smoogipoo	40f502c6d1	Apply input method signature refactorings	2020-01-20 19:35:37 +09:00
smoogipoo	bfb056c612	Apply input method signature refactorings	2020-01-20 18:17:21 +09:00
Dean Herbert	cd5290b030	Enforce using get-only auto property where possible	2020-01-20 13:50:27 +09:00
Dean Herbert	e88e40eec4	Expand on comment	2020-01-15 15:11:36 +09:00
Joehu	b42b23d65b	Add comment for alt pressed ... Taken from OsuScrollContainer	2020-01-14 20:52:15 -08:00
Joehu	2060be345d	Move alt pressed condition to top of method	2020-01-14 20:44:55 -08:00
Joehu	c196e83e75	Allow changing volume in song select with arrow keys when pressing alt	2020-01-13 20:48:39 -08:00
TheWildTree	b5ac707c6c	Remove unnecessary directive	2020-01-12 21:09:48 +01:00
TheWildTree	aa2645502c	Fix adjusted value always being 0	2020-01-12 20:43:48 +01:00
Dean Herbert	56724d2580	Merge branch 'master' into #7146	2020-01-10 01:08:20 +08:00
smoogipoo	91735ff367	Update MathUtils namespace usages	2020-01-09 13:43:44 +09:00
smoogipoo	28510674ac	Shorten body text	2020-01-06 17:48:29 +09:00
smoogipoo	61c269b17b	Leaderboard should not change the model	2020-01-06 17:32:24 +09:00
smoogipoo	4a7f5f98df	Cleanup methods/events	2020-01-06 17:20:09 +09:00
Willy Tu	e23c71be80	Update Resolved and Cached attribute issues	2020-01-03 11:34:26 -08:00
Willy Tu	0a4e180ce7	Merge branch 'master' of github.com:ppy/osu into #7146	2020-01-03 11:32:06 -08:00
Viktor Rosvall	ddec59ec91	Further refactoring. I think this may have polluted the FooterButton too much. Not sure what to do about the centering.	2020-01-01 12:22:19 +01:00
Viktor Rosvall	8695e57f62	Hides mod display when no mods are active to fix issue of invisible margin	2019-12-31 12:21:55 +01:00
Viktor Rosvall	f40ebc83ca	Begun refractorization process of wrapping Button text in a FillFlowContainer	2019-12-30 23:58:49 +01:00
Viktor Rosvall	b0bcbf8b93	Adjusted margin to fix the 1 px increase	2019-12-30 21:55:09 +01:00
Viktor Rosvall	875a25c529	adjusted the margin values	2019-12-29 09:00:59 +01:00
Viktor Rosvall	b3d32710df	Centered button mods by adding padding to FillFlowContainer	2019-12-29 00:19:51 +01:00
Dean Herbert	41d99df73c	Merge branch 'master' into allow-ctrl-tabbing-on-more-tab-controls	2019-12-25 20:49:45 +09:00
Joehu	b038c192d1	Rename property to IsSwitchable	2019-12-22 19:47:47 -08:00
Joehu	1342556894	Allow ctrl tabbing navigation to chat and song select leaderboards	2019-12-21 10:48:11 -08:00
Willy Tu	8e60ae7039	Removed directive is not required	2019-12-20 15:45:20 -08:00
Willy Tu	8353c893c0	Update BodyText of LocalScoreDeleteDialog	2019-12-20 12:00:10 -08:00
Dean Herbert	a6bdf04f6b	Remove unused using	2019-12-20 18:36:39 +09:00
Dean Herbert	822903d5db	Update song select statistics when mod changes settings	2019-12-20 18:01:35 +09:00
Willy Tu	ed07b779b1	Update to use score.ID identify local scores	2019-12-18 21:54:02 -08:00
Willy Tu	27163a5133	Removed unnecessary code for deleting individual local score.	2019-12-18 21:04:10 -08:00
Willy Tu	b67f986058	Fix CodeFactor issues	2019-12-18 19:26:35 -08:00
Willy Tu	531ac16743	Update Scoreboard Refresh Method for deleting individual scores	2019-12-18 19:22:42 -08:00
Willy Tu	d1fcadc700	Merge branch 'master' of github.com:ppy/osu into #7146	2019-12-18 19:16:54 -08:00
smoogipoo	2905a4418d	Fix potential nullref	2019-12-18 21:30:57 +09:00
smoogipoo	cb5a35f8f9	Fix incorrect bindable valuechanged usage	2019-12-18 21:08:49 +09:00
smoogipoo	4e11fb0fd7	Merge remote-tracking branch 'refs/remotes/origin/master' into multiplier-text	2019-12-18 19:36:16 +09:00
Dan Balasescu	6683460240	Merge branch 'master' into update-beatmap-settings	2019-12-18 17:59:27 +09:00
smoogipoo	8e651962c7	Fix incorrectly binding inside BDL load()	2019-12-18 17:41:30 +09:00
Dean Herbert	ada2ae2b2c	Use tuple to avoid potential for incorrect display	2019-12-18 17:12:41 +09:00
Dean Herbert	e87aa281bf	Don't clone beatmap unnecessarily	2019-12-18 17:00:35 +09:00
wltu	4646524bf9	Remove unnecessary library	2019-12-17 13:18:20 -08:00
wltu	8aeef3f59a	Added refresh scoreboard upon deleting local score and formatted the code	2019-12-17 12:56:30 -08:00
wltu	bb2b1475cd	Merge branch 'master' of https://github.com/ppy/osu into #7146	2019-12-17 12:54:47 -08:00
Huo Yaoyuan	caf3f774ba	CA1309: compare strings correctly.	2019-12-17 13:00:15 +08:00
Huo Yaoyuan	ecfc6dfa3d	CA1825: use Array.Empty.	2019-12-17 12:59:48 +08:00
Willy Tu	bef9637fdf	Implemented delete local score individually. Currently does not refresh the score screen after the delete is compelete.	2019-12-16 19:25:28 -08:00
Huo Yaoyuan	ab70abe8bd	Turn off unexpected new warnings.	2019-12-15 20:07:56 +08:00
unknown	3945e7403a	improve tests and refactor AdvancedStats	2019-12-13 09:39:54 +08:00
unknown	ec5b506960	apply mod difficulty settings during song select	2019-12-12 23:41:46 +08:00
Dean Herbert	cdde5d1d69	Fix song select filters not reapplied if in a child screen ... Closes https://github.com/ppy/osu/issues/6980.	2019-12-10 02:30:23 +09:00
Huo Yaoyuan	ad1fb3bda2	Remove IComparable in constraint.	2019-12-09 17:48:41 +08:00
Dean Herbert	48287459a0	Optimise filters to avoid property retrieval ... Also reduces number of instantiations of SearchableTerms array in the case of multiple criteria terms.	2019-12-05 01:52:22 +09:00
Dan Balasescu	19c5848e73	Merge branch 'master' into decouple-legacy-score-info	2019-12-04 11:47:27 +09:00
Huo Yaoyuan	a42f9447e6	Don't use Equals(object) on T?.	2019-12-03 20:07:22 +08:00
Dean Herbert	f0d49d0cdf	Decouple APILegacyScoreInfo from ScoreInfo	2019-12-03 15:31:11 +09:00
Ganendra Afrasya	ada8dabf7e	Add right margin on score multiplier text	2019-11-28 18:48:43 +07:00
Ganendra Afrasya	944835da23	Add multiplier score text on mods footer button	2019-11-28 12:01:40 +07:00
Huo Yaoyuan	c0fe91a84c	Merge branch 'master' into sharpen	2019-11-26 18:21:50 +08:00
Berkan Diler	fccdbffa93	Use MathF instead of Math- functions when possible ... MathF-functions are faster than the Math-counterpart and it looks cleaner, so use MathF when we cast to float or int anyway.	2019-11-25 00:45:42 +01:00
Dean Herbert	d8260f4a65	Reduce carousel scroll motion on initial display	2019-11-22 10:51:49 +09:00
Huo Yaoyuan	818553027b	Merge branch 'master' into sharpen	2019-11-21 23:42:46 +08:00
Dan Balasescu	a7c074ff37	Merge branch 'master' into math_clamp	2019-11-21 11:08:56 +09:00
Berkan Diler	6cab517b2d	.NET Standard 2.1 implements Math.Clamp , use it instead of MathHelper.Clamp from osuTK.	2019-11-20 13:37:47 +01:00
Dean Herbert	3ba9f840fd	Fix song select not always scrolling to the correct location	2019-11-20 19:39:13 +09:00
Huo Yaoyuan	374ef6ff83	Merge branch 'master' into sharpen	2019-11-20 17:30:58 +08:00
Dean Herbert	8c9ed99b1b	Merge remote-tracking branch 'upstream/master' into fix-carousel-double-filter	2019-11-20 17:24:54 +09:00
Dean Herbert	5b416eb7ba	Move initial filter to run on entering	2019-11-20 17:24:43 +09:00
Dean Herbert	e0f59d8e24	Move method	2019-11-20 15:43:00 +09:00
Huo Yaoyuan	b04bca7db6	Reference elements in origin definition.	2019-11-17 20:55:40 +08:00
Dean Herbert	e9e37fc821	Add private setter for FilterControl	2019-11-15 18:23:35 +09:00
Dean Herbert	296fff9243	Merge remote-tracking branch 'upstream/master' into fix-carousel-double-filter	2019-11-15 18:20:36 +09:00
Dean Herbert	2c3109980a	Fix broken merge	2019-11-15 13:51:39 +09:00
Dean Herbert	b8bb97607b	Merge remote-tracking branch 'upstream/master' into fix-mod-retention	2019-11-15 13:46:44 +09:00
Huo Yaoyuan	677717875e	Change a case to EqualityComparer.Default to handle null properly.	2019-11-14 17:35:02 +08:00
Huo Yaoyuan	f25b1ba06f	Merge branch 'master' into equals	2019-11-14 17:33:44 +08:00
Dean Herbert	c15f909d83	Remove local bindable at song select, along with misplaced reset logic	2019-11-14 13:29:06 +09:00
Dean Herbert	d8a5750e5d	Fix typo ... Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2019-11-14 08:38:01 +09:00
Dean Herbert	a580b9079a	Reword comment	2019-11-14 08:28:41 +09:00
Huo Yaoyuan	87d40cf8d0	Resolve equals usages.	2019-11-13 22:35:50 +08:00
Dean Herbert	110c155fa0	Fix background loading twice when entering song select	2019-11-13 19:42:05 +09:00
Dean Herbert	280c1a0eb4	Fix carousel filtering twice on startup due to unpopulated ruleset	2019-11-13 19:04:52 +09:00
Dean Herbert	bca1be0bfa	Add failing test	2019-11-13 18:54:33 +09:00
Huo Yaoyuan	42a98c5d87	Use constants.	2019-11-12 20:07:01 +08:00
Huo Yaoyuan	d60493a961	Use discards.	2019-11-12 20:03:21 +08:00
Huo Yaoyuan	e9b8cbb516	Apply other styles.	2019-11-11 20:27:04 +08:00
Huo Yaoyuan	ccc8aa6fa4	Apply brace style.	2019-11-11 20:13:13 +08:00
Ganendra Afrasya	8da15f6897	Fix all score are highlighted on local scope	2019-11-01 23:19:15 +07:00
Ganendra Afrasya	ce3b34a768	Fix UserTopScoreContainer is also tinted	2019-11-01 23:00:55 +07:00
Bartłomiej Dach	c181edaedf	Replace manual comparer implementation ... Replace manually-implemented CriteriaComparer with a call to Comparer<T>.Create() to decrease verbosity.	2019-10-28 15:07:36 +01:00
Bartłomiej Dach	c8d3dd0e5a	Make carousel item sorting stable ... Migrate beatmap carousel item sorting from List<T>.Sort() to IEnumerable<T>.OrderBy(), as the second variant is documented to be a stable sorting algorithm. This allows for eliminating unnecessary movement of carousel items occurring whenever any set of items is tied when changing sorting criteria.	2019-10-27 23:14:14 +01:00