38173 Commits

Author	SHA1	Message	Date
Maximilian Kruse	f3522c4162	change bindable seekToHitObject to private	2023-02-19 10:18:02 +01:00
Maximilian Kruse	ddd37bb319	Add setting to disable automatic seeking after object placement	2023-02-18 19:43:45 +01:00
Bartłomiej Dach	ea04c487f2	Merge branch 'master' into blueprint-labels-while-hovering	2023-02-18 15:57:30 +01:00
Cootz	5fa75805cc	Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name	2023-02-18 15:52:17 +03:00
Bartłomiej Dach	15d209d17e	Merge branch 'master' into CompletionText-LocalisableString	2023-02-18 13:50:58 +01:00
Bartłomiej Dach	fbea3e312f	Merge branch 'master' into skin-editor-improve-toolbox-hover	2023-02-18 10:02:02 +01:00
Bartłomiej Dach	704dddf14b	Merge branch 'master' into skin-editor-clipboard	2023-02-17 22:59:18 +01:00
Bartłomiej Dach	6b9472c367	Merge branch 'master' into skin-per-ruleset-layouts	2023-02-17 22:58:38 +01:00
Bartłomiej Dach	2aa4481f68	Fix toolbox items spontaneously contracting after briefly losing hover ... Reproduction scenario: 1. Hover a toolbox item 2. Unhover the item, but do not hover any other item (can be done by exiting the toolbox completely to the right) 3. Come back to the item hovered in step (1) 4. The item would spontaneously contract after a second	2023-02-17 22:54:11 +01:00
Bartłomiej Dach	b390fdb8cc	Remove unused field	2023-02-17 21:51:19 +01:00
Bartłomiej Dach	8894a73b07	Merge branch 'master' into blueprint-improve-visuals	2023-02-17 21:40:16 +01:00
Andrei Zavatski	ffcca9fd89	Remove awkward width specification	2023-02-17 23:23:58 +03:00
Bartłomiej Dach	6afa65bd3d	Merge branch 'master' into skinnable-clean-up-documentation	2023-02-17 20:59:18 +01:00
Salman Ahmed	449e5fa6f8	Rename one more left-over skinnable naming	2023-02-17 22:09:55 +03:00
cdwcgt	dbb366e279	CompletionText can be a LocalisableString ... I can't find a reason for not doing this, probably this was forgotten in https://github.com/ppy/osu/pull/15440	2023-02-17 22:32:03 +09:00
Cootz	e3bdb3d852	Align links in one line	2023-02-17 15:32:36 +03:00
Cootz	fd1beaef87	Fix typo	2023-02-17 15:24:27 +03:00
Cootz	a3b440493a	Update xml doc	2023-02-17 15:23:43 +03:00
Andrei Zavatski	51940133df	Adjust width and add comment	2023-02-17 15:18:45 +03:00
Andrei Zavatski	0838fa636f	Make triangles slower	2023-02-17 15:16:00 +03:00
Andrei Zavatski	fa300b5ba0	Merge branch 'master' into mod-overlay-triangles	2023-02-17 15:13:51 +03:00
Cootz	ceed3606cd	Remove redundant comment ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2023-02-17 13:46:06 +03:00
Dean Herbert	0a018514e1	Make skin editor focus only one layer at a time	2023-02-17 19:27:16 +09:00
Dean Herbert	00fcee0c5a	Add per-ruleset component toolbox and placement support	2023-02-17 19:27:16 +09:00
Dean Herbert	ba5a87ca04	Add basic target layer selection in skin editor	2023-02-17 19:27:16 +09:00
Dean Herbert	c03b6cec23	Add IEquatable and ToString support to SkinComponentsContainerLookup	2023-02-17 19:27:16 +09:00
Dean Herbert	a01c3090e4	Fix tests which rely on HUDOverlay's DrawableRuleset being nullable	2023-02-17 19:27:09 +09:00
Dean Herbert	5ed038fbb3	Improve the feel of hovering toolbox component items	2023-02-17 19:26:03 +09:00
Dean Herbert	814080d982	Only show blueprint labels when hovering or selected	2023-02-17 19:23:52 +09:00
Dean Herbert	19d5293ad1	Change early return to also find the earliest nested object	2023-02-17 18:59:31 +09:00
Dean Herbert	209d41ee9d	Use RulesetInfo instead of Ruleset in skin components lookup	2023-02-17 18:24:05 +09:00
Dean Herbert	675e5b81f3	Fix SkinnableLighting showing up as a user placeable component	2023-02-17 18:24:05 +09:00
Dean Herbert	2267aa1ac2	Add ability to retrieve serialisable drawables for specific rulesets	2023-02-17 18:24:05 +09:00
Dean Herbert	ffb99364b9	Ensure skin default component layouts only apply to global layout for now	2023-02-17 18:24:05 +09:00
Dean Herbert	6c61c5f4a8	Fix selection on the edge of blueprints (in the new inflation area) failing	2023-02-17 18:19:46 +09:00
Dean Herbert	16d94b4ea2	Improve visuals of skin blueprint	2023-02-17 18:19:46 +09:00
tsrk	8830e06588	fix: compilation	2023-02-17 09:17:11 +00:00
tsrk	c94e647e21	style(KeyCounterDisplay): remove type check	2023-02-17 09:09:56 +00:00
Dean Herbert	9793774377	Update SkinDeserialisationTest to work with new serialisation structure	2023-02-17 16:22:48 +09:00
Dean Herbert	6b3652f567	Change serialisation format of skin layouts to allow more flexibility ... Also adds per-ruleset storage for each container type.	2023-02-17 14:19:19 +09:00
Dean Herbert	9685fb2114	Always return a non-null container for SkinComponentsContainerLookups	2023-02-17 14:19:19 +09:00
Dean Herbert	4cc6664dc7	Add optional ruleset identifier to SkinComponentsContainerLookup	2023-02-17 14:19:19 +09:00
Dean Herbert	1a63ca9ece	Add xmldoc around SkinComponentsContainerLookup	2023-02-17 14:18:05 +09:00
Dean Herbert	8c772a723f	Expose constant publicly rather than reexposing business	2023-02-17 13:34:19 +09:00
Dean Herbert	96b1498932	Rename max length variable to make sense (it's a filename limit, not path)	2023-02-17 13:33:22 +09:00
tsrk	d0e8d65766	style(KeyCounter): rename IsLit to IsActive	2023-02-17 00:56:17 +00:00
Andrei Zavatski	a84f20bf32	Add triangles to ModSelectColumn	2023-02-17 03:09:32 +03:00
tsrk	e3ca751027	refactor: make FillFlowContainer read-only	2023-02-16 23:17:47 +00:00
tsrk	c61fac578c	style(KeyCounter): rename methods and arguments ... As for the second suggestion in https://github.com/ppy/osu/pull/22654#discussion_r1109047998, I went with the first one as only one Trigger actually uses this argument for rewinding.	2023-02-16 23:15:03 +00:00
Cootz	810712386d	Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name	2023-02-17 01:51:24 +03:00
tsrk	ddd6c1a1c6	refactor(KeyCounter): address bindables issues ... `IsCounting` is back being an auto-property. `countPresses` is now encapsulated and being exposed as an `IBindable<int>` via `CountPresses`	2023-02-16 22:20:34 +00:00
tsrk	6340730427	refactor(KeyCounter): remove circularity	2023-02-16 21:59:39 +00:00
Bartłomiej Dach	3ee046000e	Merge branch 'master' into revert-result-in-playfield	2023-02-16 21:54:29 +01:00
Bartłomiej Dach	66e9bb2581	Merge branch 'master' into hide-resume-overlay	2023-02-16 21:33:23 +01:00
Bartłomiej Dach	b8084a15eb	Revert ResumeOverlay setter accessibility change	2023-02-16 21:26:01 +01:00
Bartłomiej Dach	0186062246	Merge branch 'master' into adjust-song-select-background-dim	2023-02-16 20:52:36 +01:00
Bartłomiej Dach	ad5132ed41	Remove redundant conditional access qualifier ... It is impossible for the callback passed to `ApplyToBackground()` to receive a null reference. See `OsuScreen.ApplyToBackground()` - if the background to call the callback on were `null`, then an `InvalidOperationException` would be thrown instead.	2023-02-16 20:47:51 +01:00
Cootz	f1da213bea	Add tests	2023-02-16 16:26:57 +03:00
Dean Herbert	cb7df7282b	Apply NRT to SerialisedDrawableInfo	2023-02-16 20:01:59 +09:00
Cootz	3057ccb635	Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name	2023-02-16 13:22:11 +03:00
Dean Herbert	394d368f16	Fix song select potentially updating background parameters when not the current screen	2023-02-16 18:45:22 +09:00
Dean Herbert	affa9507a1	Fix GameplaySampleTriggerSource not considering nested objects when determining the best sample to play	2023-02-16 18:21:33 +09:00
Dean Herbert	ce9ef3bc3c	Always create ResumeOverlay, with UseResumeOverlay flag only affecting whether it is displayed or not	2023-02-16 15:47:20 +09:00
Dean Herbert	7afdcb9383	Merge branch 'master' into hide-resume-overlay	2023-02-16 15:42:14 +09:00
Dean Herbert	81dcc105a9	Rename left-over skinnable naming in SerialisedDrawableExtensions	2023-02-16 15:34:41 +09:00
Dean Herbert	76f7accd13	Standardise all local SkinComponentsContainerLookup variables to containerLookup	2023-02-16 15:33:56 +09:00
Dean Herbert	eea0cd3cf8	Reword xmldoc on ISerialisableDrawable to make less skin-centric	2023-02-16 15:31:35 +09:00
Dean Herbert	0b25f7baeb	Reword and fix typos in some new xmldoc ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-02-16 15:27:30 +09:00
Bartłomiej Dach	c315113fde	Merge branch 'master' into maximum-judgement-offset-in-hit-object	2023-02-16 00:15:51 +01:00
tsrk	74e7cc2056	feat: implement new design of key counter	2023-02-15 22:18:02 +00:00
tsrk	e9dcc257b4	reafactor: simplify type checking	2023-02-15 22:06:35 +00:00
tsrk	b0a2e69f95	style: nullable pass on KeyCounterDisplay	2023-02-15 22:06:10 +00:00
tsrk	076eb81b21	refactor: rename trigger classes ... Makes it better to understand their purpose	2023-02-15 21:46:13 +00:00
tsrk	a644fae364	style(KeyCounter): rename (Un)lit methods to (Un)light	2023-02-15 21:41:41 +00:00
tsrk	df0633858c	fix(KeyCounter): don't override Handle ... This caused the Keyboard inputs to register twice, which is not what we want.	2023-02-15 21:41:41 +00:00
tsrk	157bba7830	refactor: rename Trigger class to InputTrigger	2023-02-15 21:41:36 +00:00
Bartłomiej Dach	768eea1ea8	Merge branch 'master' into skinnable-clean-up-documentation	2023-02-15 21:26:11 +01:00
Bartłomiej Dach	1d5d34ba0e	Merge pull request #22647 from peppy/remove-target-component-container ... Simplify and rename `SkinnableTargetComponentsContainer`	2023-02-15 21:25:49 +01:00
Cootz	387a6f1330	Move logic to Export method	2023-02-15 22:43:43 +03:00
Cootz	fb06a77e2b	Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name	2023-02-15 22:29:38 +03:00
Cootz	1f586c129c	fix applied	2023-02-15 22:15:44 +03:00
Dean Herbert	925deb7ca5	Make skin editor clipboard shared between screens and skins to allow moving elements over	2023-02-15 19:35:37 +09:00
Dean Herbert	bc83b0c264	Fix clipboard changes not batching as undo steps	2023-02-15 19:35:22 +09:00
Dean Herbert	bcf2555545	Fix components having incorrect default positions	2023-02-15 19:34:42 +09:00
Dean Herbert	d653335b6f	Add basic skin editor clipboard implementation	2023-02-15 19:28:42 +09:00
Dean Herbert	08ed174f61	Change GameplaySkinComponentLookup's generic to always be an enum ... And document the class better.	2023-02-15 18:48:14 +09:00
Dean Herbert	a92e42bb84	Rename SkinnableTargetContainer to SkinComponentsContainer ... Also use full `SkinComponentsContainerLookup` instead of the sub-type. This will potentially be useful once we bring in per-ruleset targets.	2023-02-15 18:37:41 +09:00
Dean Herbert	b1cf6d83d8	Move extension methods closer to serialisation classes	2023-02-15 18:37:41 +09:00
Dean Herbert	e61d2d571c	Move the lookup type out of ISserialisableDrawableContainer	2023-02-15 18:37:41 +09:00
Dean Herbert	a7b47f6503	Rename ISkinnableTarget to ISerialisableDrawableContainer	2023-02-15 18:37:41 +09:00
Dean Herbert	d159d6b970	Rename ISkinnableDrawable to ISerialisableDrawable	2023-02-15 18:37:41 +09:00
Dean Herbert	8cb5a51aa7	Add further documentation to skin classes	2023-02-15 18:23:19 +09:00
Dean Herbert	856efd9fd9	Rename SkinnableDrawableInfo to SerialisedDrawableInfo	2023-02-15 18:23:19 +09:00
Dean Herbert	9e651a7ca2	Rename SkinnableInfo to SkinnableDrawableInfo	2023-02-15 18:23:17 +09:00
Dean Herbert	6010dde86e	Move SkinnableInfo to better namespace	2023-02-15 18:23:10 +09:00
Dean Herbert	8bbd00822c	Simplify and rename SkinnableTargetComponentsContainer	2023-02-15 17:30:21 +09:00
Dean Herbert	e71dfd7555	Fix skin export failing if a directory exists with the proposed filename	2023-02-15 16:11:16 +09:00
Dean Herbert	da8ab7143b	Merge branch 'master' into maximum-judgement-offset-in-hit-object	2023-02-15 14:48:15 +09:00
Dean Herbert	9ed068c1e6	Only apply dim changes when background blur is disabled	2023-02-15 14:16:34 +09:00
Dean Herbert	19e3c5d33c	Adjust song select background dimming to be more evenly applied	2023-02-15 13:59:24 +09:00
Dean Herbert	5024838f3a	Merge branch 'master' into bubble_mod_implementation_clean	2023-02-15 13:47:18 +09:00
Bartłomiej Dach	99b78c63a0	Merge branch 'master' into fix-mania-long-note-regression	2023-02-14 21:25:31 +01:00
Dean Herbert	5ec5222d8a	Expose and consume OsuInputManager explicitly	2023-02-14 17:36:07 +09:00
Dean Herbert	b42b5f97cf	Use Overlays container rather than KeyBindingInputManager for flashlight	2023-02-14 17:36:07 +09:00
Dean Herbert	970388d4e2	Move Overlays container to accept input and be frame-stable	2023-02-14 17:35:12 +09:00
Dean Herbert	e6f0a1dec9	Merge pull request #22632 from Joehuu/fix-beatmap-preview-progress ... Fix beatmap card song preview progress sometimes showing past progress for one frame	2023-02-14 17:06:50 +09:00
Dean Herbert	7aaaf7fca2	Combine and attempt to simplify the score import / preparation process further	2023-02-14 16:55:35 +09:00
Dean Herbert	8a206234f7	Merge branch 'master' into replay-length-extension	2023-02-14 16:42:26 +09:00
Dean Herbert	0217875f3f	Merge branch 'master' into SkinSetOnNotificationClick	2023-02-14 16:04:03 +09:00
Dean Herbert	0ad245e9e0	Rewrite implementation to match other implementations	2023-02-14 16:00:23 +09:00
Dean Herbert	21429e164f	Fix comment grammar	2023-02-14 15:55:32 +09:00
PC	ca2603324c	Change present from skin selection tab to SkinCollection.First()	2023-02-14 09:43:40 +03:00
Joseph Madamba	ea624b8ad0	Reset preview track when stopping instead	2023-02-13 22:39:34 -08:00
Dean Herbert	63f3498762	Restructure UseResumeOverlay to correctly handle a value change before BDL load	2023-02-14 15:11:33 +09:00
Dean Herbert	9e04a36d86	Move test to a mod test and add more resilient test logic	2023-02-14 15:07:45 +09:00
PC	9064391226	Use ChildrenOfType instead of linq	2023-02-14 08:24:03 +03:00
Dean Herbert	51d4ae5241	Merge branch 'master' into footer_V2_implementation	2023-02-14 14:00:53 +09:00
Dean Herbert	f0ebb920b9	Make Actions nullable	2023-02-14 13:54:00 +09:00
Joseph Madamba	24a5a1061f	Fix OsuClickableContainer sounds not being blocked by nested drawables	2023-02-13 15:36:17 -08:00
PC	f8f485e4c8	Move PresentSkinsImport to OsuGame. Replace switch with if statement	2023-02-14 02:29:50 +03:00
MK56	5006dbe3db	Update osu.Game/Screens/Select/FooterV2/FooterButtonV2.cs ... Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>	2023-02-14 00:07:02 +01:00
Bartłomiej Dach	939144fb6c	Merge pull request #22628 from EVAST9919/letterbox-no-containers ... Remove unnecessary containers in `LetterboxOverlay`	2023-02-13 23:54:48 +01:00
Pasi4K5	e4b84ebd0b	Add UseResumeOverlay and use it for hiding the ResumeOverlay	2023-02-13 23:51:39 +01:00
Joseph Madamba	7f7e72705f	Fix beatmap card song preview progress sometimes showing past progress for one frame	2023-02-13 14:15:37 -08:00
mk56-spn	ae9a17d76b	Add offset to FooterButtonV2.cs shadow	2023-02-13 22:20:41 +01:00
mk56-spn	be52d0a60c	Add note explaining shadow opacity ... pass ColourProvider in from test, instead of hard coding it in `FooterButtonV2.cs`	2023-02-13 22:18:34 +01:00
mk56-spn	61584ba63c	Fix corner_radius missing in some parts of FooterButtonV2.cs. ... Adjust shadow radius value to 5 to match figma.	2023-02-13 22:15:29 +01:00
mk56-spn	6e6421caea	Change FooterV2.cs colour to use ColourProvider instead of OsuColour. ... Remove unnecessary `FillFlowContainer`	2023-02-13 22:12:25 +01:00
PC	10ab228d76	Improve xml doc	2023-02-13 22:47:29 +03:00
PC	46b13f2565	Improve code quality	2023-02-13 22:44:11 +03:00
PC	637b07efe6	Remove Resolved attribute	2023-02-13 22:36:51 +03:00
PC	a22a36bfe0	Add navigation to skin settings on multiple import	2023-02-13 20:31:09 +03:00
Andrei Zavatski	2dee783401	Remove not needed containers	2023-02-13 15:14:25 +03:00
PC	35bc0a29d8	Add setting skin on notification click	2023-02-13 15:11:55 +03:00
Dean Herbert	679df9bf8b	Merge pull request #22604 from Joehuu/abort-dangerous-dialog-button-on-hover-lost ... Add ability to abort dangerous dialog button on hover lost	2023-02-13 20:40:14 +09:00
tsrk	aa2e0028ab	refactor: hide trigger presence from content	2023-02-13 10:59:10 +00:00
Dean Herbert	55358d36c8	Change MinimumColumnWidth to remove setter	2023-02-13 17:50:32 +09:00
Dean Herbert	ca768ca446	Add comment regarding unused enum members in LegacyNoteBodyStyle	2023-02-13 17:43:52 +09:00
tsrk	11d0e185b8	refactor: separate impl of KeyCounterDisplay ... This allows for different layouts of display. Idk, maybe someone would want to mix both variants? (don't do this please). This commit is mostly prep for further changes.	2023-02-13 01:36:12 +00:00
tsrk	74a58fb674	refactor: separate things in KeyCounter ... To implement different different sources of input for KeyCounter, it is now possible to create a Trigger class (to inherit) instead of inheriting KeyCounter. This eases the creation of more input sources (like for tests) while allowing to implement different UI variants. That way, if another variant of the key counter needs to implemented (for whathever reason), this can be done by only inheriting KeyCounter and changing how things are arranged visually.	2023-02-13 01:24:27 +00:00
Joseph Madamba	cb51b9e350	Use existing ModdingBeatmap activity	2023-02-12 15:01:50 -08:00
Joseph Madamba	bbeef53569	Add TestingBeatmap activity	2023-02-12 13:11:42 -08:00
Joseph Madamba	afb66d8af4	Make user activity class names more specific	2023-02-12 12:32:17 -08:00
Dean Herbert	9d09141ab7	Move taiko-specific property out of DrawableHitObject	2023-02-12 16:09:28 +09:00
Joseph Madamba	8d9245c1d4	Make AbortConfirm() virtual and override with filter logic	2023-02-11 12:54:16 -08:00
Bartłomiej Dach	774eae98cc	Merge branch 'master' into editor-select-timing-on-enter	2023-02-11 16:27:22 +01:00
Bartłomiej Dach	a3cc0d23b3	Fix typo in xmldoc	2023-02-11 16:26:32 +01:00
Bartłomiej Dach	7b2c5ab7eb	Merge pull request #22608 from peppy/update-dependencies ... Update realm and other dependencies	2023-02-11 12:37:02 +01:00
Bartłomiej Dach	ebf469272f	Merge pull request #22544 from peppy/fix-change-join-leave-loop ... Attempt to fix channel join / leave loop	2023-02-11 12:26:26 +01:00
Dean Herbert	20f3ab167e	Re-centralise BannedApiAnalysers nuget package	2023-02-11 19:36:40 +09:00
Bartłomiej Dach	8292052dc2	Merge pull request #22598 from peppy/fix-skip-intro-replay ... Fix "skip" key binding no longer working in replay playback	2023-02-11 11:27:10 +01:00
Dean Herbert	0c5dae5f26	Merge pull request #22529 from ItsShamed/dsc/presence ... Add support for `Watching` and `Spectating` activities in `ReplayPlayer` and `SoloSpectatingPlayer`	2023-02-11 17:29:47 +09:00
Dean Herbert	86c8675910	Update realm and other dependencies	2023-02-11 13:52:24 +09:00
Dean Herbert	463e8221e0	Merge pull request #22600 from Terochi/song-progress-time-left-fix ... Song progress incorrectly displaying `timeLeft` counter after rotation	2023-02-11 13:19:06 +09:00
Joseph Madamba	94d6ab1ec7	Continue confirming when rehovering if mouse is still down	2023-02-10 19:09:30 -08:00
Joseph Madamba	bfd83768c1	Fix skin component previews on toolbox buttons having incorrect size for one frame	2023-02-10 17:58:34 -08:00
Joseph Madamba	d30d054b4c	Add ability to abort dangerous dialog button on hover lost	2023-02-10 14:41:44 -08:00
Bartłomiej Dach	75e19bb89f	Merge branch 'master' into fix-clickable-avatar-bloat	2023-02-10 21:30:40 +01:00
Bartłomiej Dach	11296c4ffe	Use better exception type	2023-02-10 21:25:19 +01:00
Terochi	81c3e0da31	Fixed timeLeft counter in SongProgressInfo being out of bounds after rotation	2023-02-10 17:58:48 +01:00
Dean Herbert	bfbffc4a68	Add parsing support for mania NoteBodyStyle	2023-02-10 19:46:59 +09:00
Dean Herbert	635e225d19	Add correct lookup for WidthForNoteHeightScale	2023-02-10 19:18:41 +09:00
Dean Herbert	5c795f492f	Reorder game key bindings to allow skip overlay to have precedence over replay controls	2023-02-10 18:57:21 +09:00
Dean Herbert	96fbd04698	Add failing test coverage of skip no longer working in replay playback	2023-02-10 18:57:04 +09:00
Dean Herbert	4f7d26b776	Actually apply new parameter	2023-02-10 18:29:39 +09:00
Dean Herbert	6d876fdb9a	Automatically select the closest timing point on entering the timing screen	2023-02-10 17:48:56 +09:00
Dean Herbert	03e623d1d2	Move ControlPointList to own file	2023-02-10 17:37:31 +09:00
Dean Herbert	ad8b01b478	Merge pull request #22589 from sw1tchbl4d3r/file_hitsample_additions ... Always add to additions soundbank in `convertSoundType`	2023-02-10 17:14:29 +09:00
Dean Herbert	eccde923e5	Merge pull request #22554 from Walavouchey/ranking-accuracycircle-readability ... Improve readability of `AccuracyCircle`	2023-02-10 17:03:46 +09:00
Dean Herbert	1df6fc6311	Use if statements rather than conditional case	2023-02-10 17:03:27 +09:00
Dean Herbert	199fb0fd85	Apply NRT to ClickableAvatar and UpdateableAvatar	2023-02-10 16:32:58 +09:00
Dean Herbert	5866b67a5b	Simplify tooltip implementation	2023-02-10 16:24:44 +09:00
Dean Herbert	68c37585e5	Use string.Empty instead of default	2023-02-10 16:22:06 +09:00
Joseph Madamba	a86f06df96	Add back Enabled checks to TooltipText and OnClick to fix guest case	2023-02-09 17:00:32 -08:00
Bartłomiej Dach	96c1832af4	Fix grammar in xmldoc ... Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>	2023-02-10 00:07:24 +01:00
sw1tchbl4d3	f0d11f44fc	Always add to additions soundbank in convertSoundType	2023-02-09 22:27:52 +01:00
Joseph Madamba	0b41dbf579	Remove code bloat from ClickableAvatar	2023-02-09 12:59:26 -08:00
Ruki	2c1154afc6	refactor: improve wording ... Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>	2023-02-09 17:15:30 +00:00
Dean Herbert	ab81397119	Merge pull request #22553 from OpenSauce04/taiko-stable-snapping ... Snap Taiko hit objects to match Stable	2023-02-09 23:28:21 +09:00
Dean Herbert	34d1890f1c	Change snapping to only apply to classic mod	2023-02-09 18:22:14 +09:00
ekrctb	258de3b2d8	Store RawTime in JudgementResult	2023-02-09 17:15:37 +09:00
ekrctb	5f0636c330	Merge branch 'maximum-judgement-offset-in-hit-object' into revert-result-in-playfield	2023-02-09 16:47:58 +09:00
Dean Herbert	28897b6e18	Merge pull request #22566 from Joehuu/profile-tournament-banner ... Display tournament banner on user profile	2023-02-09 16:06:36 +09:00
Dean Herbert	cf009432cc	Centralise accuracy cutoff constants and add lookup helper methods	2023-02-09 15:41:58 +09:00
Joseph Madamba	f1decb667e	Address todos relating to init-only usages	2023-02-08 17:51:28 -08:00
Walavouchey	57312279f0	adjust RankNotch gap size to match original value	2023-02-09 02:20:05 +01:00
Joseph Madamba	3b5d573db1	Display tournament banner on user profile	2023-02-08 17:16:09 -08:00
Walavouchey	fd93bd3f50	move rank accuracy requirements to class-local constants	2023-02-09 00:46:24 +01:00
Walavouchey	ee40444fd3	use Precision.AlmostEquals for bounds check	2023-02-08 23:59:19 +01:00
Bartłomiej Dach	0a5c4e04bf	Merge branch 'master' into skin-editor-undo-support	2023-02-08 18:43:59 +01:00
Walavouchey	0531c010eb	display RankBadges on on their sector centres ... the D `RankBadge` does this anyway. the A and S badges are slightly off centre to prevent overlap with the SS badge	2023-02-08 14:01:40 +01:00
Walavouchey	6ace6bfee1	ensure AccuracyCircle doesn't land in gaps created by RankNotches	2023-02-08 13:20:53 +01:00
Joseph Madamba	0156ff732f	Fix beatmap cards not showing context menu on user profile	2023-02-07 22:56:09 -08:00
Dean Herbert	17ca26ebee	Remove unnecessary null check on targetScreen	2023-02-08 15:44:24 +09:00
Dean Herbert	3a3c2e78a1	Merge branch 'master' into skin-editor-undo-support	2023-02-08 15:41:58 +09:00
Dean Herbert	4fdba880b1	Fix xmldoc reference fail at CI	2023-02-08 15:39:18 +09:00
Dean Herbert	78eae171ed	Merge pull request #22507 from Joehuu/fix-comment-padding ... Fix comments having too much padding at the bottom	2023-02-08 15:01:05 +09:00
Dean Herbert	b6809e156b	Merge pull request #22432 from mk56-spn/sheared_slider_implementation_clean_ii ... Implement a sheared slider for the updated design	2023-02-08 15:01:00 +09:00
Dean Herbert	c50ea89bc9	Simplify migration to not rely on old/dynamic schema	2023-02-08 14:24:06 +09:00
Dean Herbert	5c113ddb03	Reword xmldoc to read better	2023-02-08 14:20:58 +09:00
Dean Herbert	5cd111e6f1	Fix ordering of methods in OsuSliderBar	2023-02-08 14:01:50 +09:00
Dean Herbert	cec1f77e6c	Fix glow flash occurring after releasing mouse and adjust transition slightly	2023-02-08 13:59:09 +09:00
Cootz	086b3eb542	Fix minor formating issues	2023-02-08 05:50:52 +03:00
Cootz	4ba915268c	Change a comment into RealmAccess	2023-02-08 05:46:47 +03:00
Cootz	ab7c9a200b	Fix a typo	2023-02-08 05:42:06 +03:00
Cootz	6bf56aff73	Add warning for ScoreInfo	2023-02-08 05:40:20 +03:00
Dean Herbert	ee65c65893	Attempt to fix channel join / leave loop ... I don't have a solid way to repro the issue, but this should hopefully help in resolving it. Either way, I think this change brings more correct behaviour (if a websocket message comes through that we have left the channel, I don't believe we should be sending a request to leave that channel again).	2023-02-08 11:31:30 +09:00
Cootz	391af2791b	Fix CSharpWarnings::CS1574,CS1584,CS1581,CS1580	2023-02-08 05:23:42 +03:00
Joseph Madamba	277f71d36a	Expire reply editor instead of clearing container	2023-02-07 15:15:51 -08:00
PC	7e127dafe2	Update reference	2023-02-07 11:52:47 +03:00
Cootz	957c9e7e27	Update osu.Game/Scoring/ScoreInfo.cs ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2023-02-07 11:23:39 +03:00
Dean Herbert	0320ba770f	Handle component changes via ISkinnableTarget.Components rather than inside SkinEditor directly ... Seems saner? Maybe?	2023-02-07 16:23:25 +09:00
Dean Herbert	e162fd56da	Change the way initial state saving works in EditorChangeHandler to be closer to first change	2023-02-07 16:22:51 +09:00
Dean Herbert	dad348111d	Fix holding a selection while changing screens causing a crash	2023-02-07 16:07:33 +09:00
Dean Herbert	71eef238c4	Make OnStateChange non-implemented rather than wrong	2023-02-07 16:04:31 +09:00
Cootz	a1ee3df453	Improve local variable naming	2023-02-07 03:16:25 +03:00
Cootz	1470ea0a31	Remove unnecessary using directives	2023-02-07 03:07:53 +03:00
Cootz	723f13af25	Add summary for OriginalBeatmapHash	2023-02-07 02:43:27 +03:00
tsrk	da10166628	quality: convert getter property to method so that sensible information can be hidden via an argument	2023-02-06 21:30:55 +00:00
tsrk	1baaae35a9	quality: Simplify string	2023-02-06 20:07:16 +00:00
Bartłomiej Dach	12f6d461b9	Merge pull request #22532 from peppy/fix-long-storyboard-outro ... Fix storyboard outro time potentially running too long	2023-02-06 20:30:36 +01:00
Bartłomiej Dach	179db09075	Merge pull request #22531 from peppy/apply-future-rider-inspection ... Apply single inspection from newer inspectcode versions	2023-02-06 20:05:49 +01:00
tsrk	bc89f8dc5b	feat: add name and rulset verb display support	2023-02-06 12:44:00 +00:00
Cootz	2c7386db39	FIx score appearing on BeatmapLeaderboard and TopLocalRank	2023-02-06 15:14:14 +03:00
Cootz	b00848e742	Fix realm error. Apply OriginalBeatmapHash on import	2023-02-06 13:58:41 +03:00
Dean Herbert	aaf3ad805c	Fix potential nullref in tests	2023-02-06 19:31:45 +09:00
Dean Herbert	b83c8443ea	Ensure pause sample loop is stopped on exiting player	2023-02-06 18:24:31 +09:00
Terochi	43f7665c9e	Improved readability again	2023-02-06 09:49:42 +01:00
Dean Herbert	c691a0d3af	Merge branch 'master' into sheared_slider_implementation_clean_ii	2023-02-06 17:49:33 +09:00
Dean Herbert	c078d3a344	Merge pull request #22357 from EXtremeExploit/groups-probationary-badges ... Make probationary groups a bit transparent	2023-02-06 17:43:57 +09:00
Dean Herbert	a67d5d2a14	Merge branch 'master' into bubble_mod_implementation_clean	2023-02-06 17:24:20 +09:00
Dean Herbert	ddcc02fdfe	Merge pull request #22505 from Joehuu/fix-hover-click-sounds ... Fix some clickable elements having no hover and click sounds	2023-02-06 16:52:19 +09:00
Dean Herbert	eabd1a0cc1	Remove unused Duration property to avoid any misunderstandings	2023-02-06 16:42:39 +09:00
Dean Herbert	679ec986d5	Fix storyboard outro time potentially running too long	2023-02-06 16:39:44 +09:00
Terochi	4f23e096d7	Improved readability	2023-02-06 07:59:37 +01:00
Dean Herbert	4c868372a2	Correctly handle anchor/origin changes as undo states	2023-02-06 15:05:05 +09:00
Dean Herbert	778b8a9bf7	Fix default settings not being serialised / state tracked correctly	2023-02-06 15:00:42 +09:00
Dean Herbert	7445814fc6	Handle changes to SettingSource skin element settings	2023-02-06 14:42:59 +09:00
Dean Herbert	e5f62b0d2e	Remove public access modifier from interface methods	2023-02-06 14:19:25 +09:00
Dean Herbert	e4b17588f5	Add missing xmldoc to new methods in EditorChangeHandler	2023-02-06 14:11:40 +09:00
Dean Herbert	701d21c26f	Apply single inspection from newer inspectcode verisons ... As found in rider EAPs. Appears as a warning and is annoying me occasionally.	2023-02-06 13:52:27 +09:00
Dean Herbert	10ab4d572a	Merge branch 'master' into skin-editor-undo-support	2023-02-06 13:46:50 +09:00
tsrk	b3f38b0f4c	quality: remove redundant Status override	2023-02-06 00:56:11 +00:00
tsrk	bf273597ea	feat: actually support status also for Replays	2023-02-06 00:41:10 +00:00
tsrk	d5b2d9ce97	feat: add support for spectating status	2023-02-05 23:58:08 +00:00
Cootz	d23e787bc1	Update schema_version	2023-02-05 21:55:50 +03:00
Cootz	4598112586	Add OriginalBeatmapHash to ScoreInfo. Update db schema_version, migration	2023-02-05 21:46:38 +03:00
Terochi	f58534f60c	Extended the length of replay at the end of map	2023-02-05 18:51:28 +01:00
Joseph Madamba	cb8458cceb	Use linq and alpha instead ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-02-04 20:11:29 -08:00
Joseph Madamba	191259c050	Use equals instead and update other usage	2023-02-04 19:58:48 -08:00
Bartłomiej Dach	ef900bccdf	Merge branch 'master' into BPM_counter_fix	2023-02-04 23:44:58 +01:00
Bartłomiej Dach	cb7540564a	Merge pull request #22504 from peppy/fix-editor-positional-nudge-undo ... Fix beatmap editor positional nudging not being undoable	2023-02-04 15:52:34 +01:00
Joseph Madamba	4192388b20	Fix expanded beatmap cards getting cut off at the end of profile sections	2023-02-03 21:29:01 -08:00
mk56-spn	88872cf1cf	Use ``GetTrueGameplayRate()`` to remove need for jank	2023-02-04 00:53:54 +01:00
mk56-spn	d9bee958dd	Stop ``BPMCounter.cs``'s value from going to 0 after failing.	2023-02-03 23:56:34 +01:00
Bartłomiej Dach	97afb83394	Merge branch 'master' into carousel	2023-02-03 22:15:44 +01:00
Bartłomiej Dach	63f7d326c2	Merge branch 'master' into fix-editor-positional-nudge-undo	2023-02-03 21:31:05 +01:00
Bartłomiej Dach	4bd43171e8	Merge branch 'master' into fix-skin-editor-padding-weirdness	2023-02-03 20:28:47 +01:00
Bartłomiej Dach	b2a5cf9f2d	Merge branch 'master' into triangles-old-texel	2023-02-03 19:43:34 +01:00
Bartłomiej Dach	59656a7286	Merge branch 'master' into skin-editor-dont-show-save-on-no-change	2023-02-03 19:08:33 +01:00
EXtremeExploit	f9809c9481	the comment	2023-02-03 11:48:11 -03:00
mk56-spn	e1af5e110a	Remove ``RoundedNub.cs` and make `Nub.cs`` non abstract again	2023-02-03 12:19:09 +01:00
mk56-spn	8c11e8e6f4	Extract ShearedNub.cs implementation into its own entirely independent implementation	2023-02-03 11:58:10 +01:00
Joseph Madamba	461b5c5375	Fix comment cancel button not behaving the same as reply text toggle ... - Removed the fading animation as it is awkward right now (needs resizing)	2023-02-03 02:04:19 -08:00
Dean Herbert	2cda277c09	Add a basic change handler to the skin editor	2023-02-03 18:57:50 +09:00
Dean Herbert	2f30306ea2	Expose a method to reload a SkinnableTargetContainer from provided info	2023-02-03 18:53:09 +09:00
Dean Herbert	3345e34544	Move beatmap specific logic out of EditorChangeHandler	2023-02-03 17:53:54 +09:00
Joseph Madamba	94d2799b90	Fix comments having too much padding at the bottom	2023-02-03 00:47:10 -08:00
Joseph Madamba	5a76c1ab9c	Refactor HoverSampleDebounceComponent to inherit Component	2023-02-03 00:29:25 -08:00
Dean Herbert	b437501b0f	Fix beatmap editor positional nudging not being undoable	2023-02-03 17:28:58 +09:00
Dean Herbert	554f14151c	Apply NRT to EditorChangeHandler	2023-02-03 17:13:24 +09:00
Dean Herbert	b19047b90b	Fix skin editor component list having uneven padding	2023-02-03 16:55:51 +09:00
Joseph Madamba	f27bf3ca20	Fix click sounds potentially not working	2023-02-02 23:54:57 -08:00
Joseph Madamba	77569058cb	Alternatively fix hover sounds playing out of clicking bounds	2023-02-02 23:45:54 -08:00
Dean Herbert	60ccf35125	Update resources	2023-02-03 16:44:53 +09:00
Joseph Madamba	6135db6bd7	Revert moving hover sounds to content container	2023-02-02 23:43:08 -08:00
Dean Herbert	7b9239088b	Comment space addition	2023-02-03 16:40:16 +09:00
Andrei Zavatski	14524237ac	Add comment explaining texelSize value	2023-02-03 10:32:41 +03:00
Dean Herbert	4ec46c7476	Merge branch 'master' into footer_V2_implementation	2023-02-03 16:30:16 +09:00
Dean Herbert	48f7e0163c	Adjust comments and formatting of comments	2023-02-03 16:27:20 +09:00
Dean Herbert	4248453616	Use FinishTransforms rather than manual duplication of background colour logic	2023-02-03 16:27:20 +09:00
Dean Herbert	a1200b8fe8	Adjust footer button colour handling to read better and take into account mouse down	2023-02-03 16:27:20 +09:00
Dean Herbert	92306b9123	Combine localisations for abstract skinnable components into a single file ... Generally we don't want localisation files with only one to two translations. It makes it harder for translators to handle in crowdin (a lot of file changes for small results). So for cases like this I believe we should be grouping translations where it makes sense. I've left individual components in their own files as I can see potential for more settings to be added in the future. Plus it gives a bit of extra context.	2023-02-03 16:02:18 +09:00
Dean Herbert	cf8cfe0d2c	Move skin component localisations to namespaces	2023-02-03 15:34:57 +09:00
Dean Herbert	50559643bb	Fix incorrectly applied enum localisation	2023-02-03 15:27:11 +09:00
Dean Herbert	32207dc9dd	Merge branch 'master' into locale/skin-editor-components	2023-02-03 15:24:00 +09:00
Dean Herbert	5ca5f04794	Add parameter hint for optional bool value	2023-02-03 15:18:40 +09:00
Dean Herbert	9c954a93e3	Update Save method xmldoc to make more sense	2023-02-03 15:18:01 +09:00
Dean Herbert	f7094567d7	Rename and document method to limit scope	2023-02-03 15:04:47 +09:00
Bartłomiej Dach	1af898160c	Merge branch 'master' into delete-on-import-android	2023-02-02 21:40:52 +01:00
Bartłomiej Dach	e937022b09	Merge branch 'master' into middle-click-replay-pause	2023-02-02 20:52:03 +01:00
Bartłomiej Dach	4d46a8f32d	Merge branch 'master' into skin-editor-dont-show-save-on-no-change	2023-02-02 19:36:23 +01:00
Bartłomiej Dach	f7fa9e3927	Remove outdated comment	2023-02-02 18:41:35 +01:00
mk56-spn	80fd1a0bc7	Remove leftover comment regarding X axis offsets	2023-02-02 18:29:12 +01:00
Bartłomiej Dach	779c58f9c1	Merge branch 'master' into skin-editor-ux-impovements	2023-02-02 18:16:18 +01:00
Bartłomiej Dach	6c0aada86a	Merge pull request #22490 from peppy/skin-overlay-namespace ... Move skin editor to overlays namespace	2023-02-02 18:14:16 +01:00
mk56-spn	3f0ce75bf5	Rename NormalSliderBar.cs to RoundedSliderBar.cs	2023-02-02 17:24:45 +01:00
mk56-spn	7c5a65bdb7	Rename NormalNub.cs to RoundedNub.cs	2023-02-02 17:23:09 +01:00
Dean Herbert	015f4f2b38	Avoid showing skin save message when changing scenes after making no changes	2023-02-02 18:42:37 +09:00
Dean Herbert	9b6d95b3d6	Adjust skin editor pop in/out to be more snappy	2023-02-02 18:33:45 +09:00
Dean Herbert	26efb8e842	Replace white box legacy placeholder with something that visually fits	2023-02-02 18:33:31 +09:00
tsrk	843d9914c4	quality: remove new line	2023-02-02 08:18:56 +00:00
Dean Herbert	659b78058f	Move replay specific key bindings to their own section	2023-02-02 15:25:52 +09:00
Dean Herbert	edecd2ee25	Merge branch 'master' into middle-click-replay-pause	2023-02-02 15:25:51 +09:00
Dean Herbert	b792dc3af0	Merge pull request #22281 from cdwcgt/editor-check-previewtime ... Add preview time setting check	2023-02-02 15:10:06 +09:00
Dean Herbert	48ef25cbe5	Merge pull request #22421 from EXtremeExploit/misses-animation ... Add movement to legacy misses in osu ruleset	2023-02-02 15:00:57 +09:00
Dean Herbert	91fbf388da	Use localisation strings from ButtonSystem for better consistency	2023-02-02 15:00:24 +09:00
Dean Herbert	500e9c7944	Refactor into a method rather than property	2023-02-02 14:53:58 +09:00
Dean Herbert	942e7729f3	Merge branch 'master' into carousel	2023-02-02 14:41:55 +09:00
Dean Herbert	5b3d7a8f26	Fix typo in missing-preview-point message	2023-02-02 14:34:59 +09:00
Andrei Zavatski	175b9fc5c9	Specify texelSize value in the Triangles background	2023-02-02 08:34:38 +03:00
Dean Herbert	c2cde8361a	Fix message not reading well	2023-02-02 14:33:41 +09:00
Dean Herbert	3a861fd943	Remove multiple cases of excess braces	2023-02-02 14:28:21 +09:00
Dean Herbert	50659f3d52	Merge pull request #22428 from EVAST9919/triangles-new-masking ... Implement Masking property for `TrianglesV2` background	2023-02-02 14:22:16 +09:00
Dean Herbert	229fb518dc	Apply NRT to LegacyJudgementPieceOld	2023-02-02 14:19:00 +09:00
Dean Herbert	183d1c5bd6	Change version comparison to match other existing code as proposed in review	2023-02-02 14:18:49 +09:00
Dean Herbert	263a7e2766	Merge branch 'master' into misses-animation	2023-02-02 14:08:15 +09:00
Dean Herbert	8dc2e6872e	Move skin editor to overlays namespace	2023-02-02 14:00:31 +09:00
Dean Herbert	10df64467a	Merge pull request #22430 from peppy/skin-editor-nrt ... Apply NRT to all skin editor classes	2023-02-02 13:57:57 +09:00
tsrk	0fb6a63709	refactor: change namespacing to allow osu-localisation-analyzer to process all strings	2023-02-02 00:46:14 +00:00
Ruki	89a30d87c7	Merge branch 'ppy:master' into locale/skin-editor-components	2023-02-02 00:02:14 +00:00
tsrk	ddfa95e6ef	refactor: fix typos	2023-02-02 00:01:48 +00:00
tsrk	8645e705fd	feat: add localisation for Skin editor components	2023-02-01 23:48:05 +00:00
Bartłomiej Dach	292016d31e	Merge pull request #22483 from peppy/test-output-gameplay-time ... Output gameplay clock progress in `PlayerTestScene`s	2023-02-01 22:55:10 +01:00
Dean Herbert	a77baf8717	Output gameplay clock progress in PlayerTestScenes	2023-02-01 23:42:44 +09:00
Dean Herbert	d54db8de64	Merge branch 'master' into fix-clicking-metadata-relevance-sort	2023-02-01 19:39:13 +09:00
Dean Herbert	524aa9162d	Store search parameters as tuple	2023-02-01 19:38:47 +09:00
cdwcgt	76296eb35a	Consistent with BeatmapsetVerifier	2023-02-01 11:52:14 +08:00
Joseph Madamba	1a152452f1	Fix incorrect naming of badge header container	2023-01-31 15:16:29 -08:00
Joseph Madamba	0366a8e348	Only call Reset() if lastCategory and lastHasQuery is null	2023-01-31 12:44:44 -08:00
Dean Herbert	7d1b5751fd	Merge pull request #22467 from Cootz/issue#22345 ... Fix migration putting game files in root of disk if no other files exist	2023-01-31 18:41:34 +09:00
Dean Herbert	5d22f3d879	Improve inline comment	2023-01-31 17:17:21 +09:00
Dean Herbert	3d8b35184f	Update framework	2023-01-31 16:24:06 +09:00
Cootz	b18652b25f	CreateSubDirectory removed. Fixes the empty root issue	2023-01-31 10:14:21 +03:00
Cootz	54d5d4e7c6	Fix for the issue	2023-01-31 07:06:26 +03:00
Bartłomiej Dach	b1cbe20cd8	Adjust markdown text flow to framework-side changes	2023-01-30 20:48:52 +01:00
Bartłomiej Dach	c5e1f54185	Fix sample store creation mutating shared resource store	2023-01-30 20:48:52 +01:00
Ruki	96bd79a6f5	Merge branch 'ppy:master' into hud/avatar-thing	2023-01-30 15:43:29 +01:00
mk56-spn	f5d579144b	Remove free mods button	2023-01-30 12:57:24 +01:00
mk56-spn	41f5e5143a	Remove ``onclick` and `mousedown`` override	2023-01-30 12:56:39 +01:00
Joseph Madamba	610d2f9dc7	Fix beatmap listing potentially not sorting by relevance when searching via metadata	2023-01-28 12:14:35 -08:00
Bartłomiej Dach	d38316bf4f	Merge pull request #22429 from peppy/fix-health-display-anchor-point ... Fix default health bar having a very weird anchor point in the skin editor	2023-01-28 10:33:59 +01:00
MK56	c50604f701	Merge branch 'master' into bubble_mod_implementation_clean	2023-01-27 11:58:56 +01:00
ekrctb	27578c48f5	Remove JudgementResultEntry ... It is not needed anymore as TimeAbsolute is stored raw.	2023-01-27 19:35:44 +09:00
Dean Herbert	98c9ba5b6f	Merge branch 'master' into skin-editor-nrt	2023-01-27 19:35:43 +09:00
Dean Herbert	74ab036f3e	Refactor SkinnableSound.Samples to be non-nullable	2023-01-27 19:32:30 +09:00
Dean Herbert	8a9a6c733c	Apply missed cleanup to BackgroundDependencyLoader call ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-01-27 13:55:34 +09:00
Bartłomiej Dach	9bdd43d1b2	Merge pull request #22406 from peppy/fix-storyboard-filename ... Fix beatmaps with multiple `osb` files potentially reading the storyboard from the wrong one	2023-01-26 20:32:16 +01:00
mk56-spn	091cc155d3	Fix nub naming in OsuCheckbox.cs and associated classes	2023-01-26 16:10:02 +01:00
EXtremeExploit	1de0bed83d	fix comment	2023-01-26 11:09:16 -03:00
mk56-spn	a630f1113f	Rename nub object in NormalSliderBar.cs class	2023-01-26 15:03:51 +01:00
mk56-spn	8840694674	Adjust some padding details on ShearedSliderBar.cs as well as colouration tweaks.	2023-01-26 15:03:51 +01:00
mk56-spn	2f90ffccfc	Implement ShearedSliderBar.cs and corresponding TestSceneShearedSliderBar.cs	2023-01-26 15:03:22 +01:00
mk56-spn	6dfb9630d6	Implement ShearedNub.cs as well as tweak the syntax in NormalNub.cs	2023-01-26 15:03:22 +01:00
mk56-spn	b8ae689b31	Re-add Nub.cs and move logic from NormalNub.cs to it.	2023-01-26 15:03:22 +01:00
mk56-spn	63efe79abc	Enable NRT for NormalNub.cs	2023-01-26 15:03:22 +01:00
mk56-spn	374c3b56f6	Rename Nub.cs to NormalNub.cs	2023-01-26 15:03:11 +01:00
EXtremeExploit	758b4c8cfc	Do the thing aka fix the if	2023-01-26 10:01:33 -03:00
mk56-spn	7355397e83	Enable NRT on NormalSliderBar.cs	2023-01-26 12:58:58 +01:00
mk56-spn	fc99165df7	Extract samples into base OsuSliderBar.cs from NormalSliderBar.cs	2023-01-26 12:36:05 +01:00
mk56-spn	9afc8681ef	Extract tooltip implementation into base OsuSliderBar.cs from NormalSliderBar.cs	2023-01-26 12:25:05 +01:00
mk56-spn	ac3ad9cf8d	Implement OsuSliderBar.cs as base ( non framework side ) class from which NormalSliderBar.cs inherits	2023-01-26 12:16:51 +01:00
mk56-spn	3988131475	Rename OsuSliderBar.cs as NormalSliderBar.cs	2023-01-26 12:12:56 +01:00
Dean Herbert	4352c56c3e	Apply NRT to all simple auxiliary skin classes	2023-01-26 17:53:04 +09:00
Dean Herbert	2017ac1135	Apply NRT to all skin editor classes	2023-01-26 17:52:53 +09:00
Dean Herbert	e5d4979bc3	Fix default health bar having a very weird anchor point in the skin editor	2023-01-26 16:56:37 +09:00
Dean Herbert	64e7f6f138	Add more documentation around the implementation of FontAdjustableSkinComponent	2023-01-26 16:05:07 +09:00
Dean Herbert	d63719a602	Move and rename the base component class	2023-01-26 16:04:56 +09:00
Dean Herbert	48885d40cc	Merge branch 'master' into skin-fonts	2023-01-26 15:52:54 +09:00
Andrei Zavatski	7cd21e12f3	Implement masking property for TrianglesV2 background	2023-01-26 09:46:41 +03:00
Dean Herbert	f3c92749bf	Fix code quality issues	2023-01-26 15:43:03 +09:00
Dean Herbert	7cc4fd4efc	Use the exact method stable uses for generating storyboard filenames	2023-01-26 15:09:36 +09:00
Dean Herbert	044234b1ba	Merge pull request #22409 from EVAST9919/triangles-og-masking ... Implement Masking property for `Triangles` background	2023-01-26 14:46:59 +09:00
EXtremeExploit	bcecc49092	Only do misses animations on modern skins	2023-01-25 23:05:11 -03:00
EXtremeExploit	a6fc3ce477	bring comment back	2023-01-25 20:38:55 -03:00
Dan Balasescu	5f4dd19b49	Merge pull request #22389 from peppy/mania-long-note-wang ... Add basic support for stupidly long hold note skin textures	2023-01-26 07:41:27 +09:00
Bartłomiej Dach	fd495e87f7	Fix GetAsync() not limiting texture dimensions	2023-01-25 19:02:35 +01:00
EXtremeExploit	fc968d1d89	del extra newline	2023-01-25 14:38:02 -03:00
EXtremeExploit	a4a94cb96e	Add movement to misses in osu ruleset	2023-01-25 14:34:00 -03:00
EXtremeExploit	0eaebfd40a	Use Alpha instead of opacity on bg color	2023-01-25 10:22:42 -03:00
Andrei Zavatski	1485a6e006	Make masking false by default	2023-01-25 12:54:30 +03:00
Andrei Zavatski	d09d6f31d7	Implement Masking property for TrianglesBackground	2023-01-25 12:20:51 +03:00
Dean Herbert	f0406c34fd	Merge branch 'master' into revert-result-in-playfield	2023-01-25 17:35:33 +09:00
Dean Herbert	efe57f29e0	Merge pull request #22382 from JDECOMBE/beatmapSelectionBlur ... Add ability to disable background blur at song select	2023-01-25 17:34:35 +09:00
Dean Herbert	67e9de43be	Merge pull request #22386 from EVAST9919/triangles-og-shhader ... Use `TriangleBorder` shader in `Triangles` background	2023-01-25 17:25:18 +09:00
Dean Herbert	d15f8c2f3a	Fix beatmaps with multiple osb files potentially reading the storyboard from the wrong one ... In stable, the storyboard filename is fixed. In lazer, we were always looking for the first `.osb` in the database. In the case a beatmap archive housed more than one `.osb` files, this may load the incorrect one. Using `GetDisplayString` here feels like it could potentially go wrong in the future, so I'm open to hard-coding this locally (or using string manipulation to remove the ` [creator_name]` portion of the beatmap's filename). Open to opinions on that. Fixes storyboard playback in https://osu.ppy.sh/beatmapsets/1913687#osu/3947758	2023-01-25 17:11:15 +09:00
Dean Herbert	5c888e0c68	Merge branch 'master' into beatmapSelectionBlur	2023-01-25 16:37:19 +09:00
Dean Herbert	59ee6922b1	Merge pull request #22399 from bdach/user-profile/update-cover ... Update appearance of profile cover area to match web	2023-01-25 16:35:44 +09:00
Dean Herbert	01e280eb6b	Add classic default for song select blur setting	2023-01-25 16:32:00 +09:00
Dean Herbert	e333e12b2e	Fix typo in settings enum (seriously)	2023-01-25 16:32:00 +09:00
Dean Herbert	3faab66f39	Merge branch 'master' into beatmapSelectionBlur	2023-01-25 16:32:00 +09:00
Dean Herbert	1a9ed1ac3f	Remove unnecessary IgnoreUserSettings value change	2023-01-25 16:28:06 +09:00
Dean Herbert	f81dea4166	Remove now unused localisation string	2023-01-25 16:24:52 +09:00
Dean Herbert	7bb6337d2e	Fix nullability (thanks bdach for patch)	2023-01-25 14:43:46 +09:00
Dean Herbert	8caf960f9a	Revert weird nullable changes to Skin.cs	2023-01-25 14:43:46 +09:00
Dean Herbert	0a9b20d5d5	Split lookup store into own file / class	2023-01-25 14:43:46 +09:00
Dean Herbert	c1a5c16973	Reduce maximum texture size to a more commonly-supported 8192	2023-01-25 14:43:46 +09:00
Dean Herbert	d000a4ed28	Make sure to dispose of the original texture upload as we are replacing it	2023-01-25 14:43:46 +09:00
Dean Herbert	598c6fcbad	Add basic support for stupidly long hold note skin textures	2023-01-25 14:43:46 +09:00
Dean Herbert	6bf7773532	Increase duration of expansion transition	2023-01-25 14:28:25 +09:00
Dean Herbert	3e91dd2a16	Update spacing along with expanded state	2023-01-25 14:28:25 +09:00
Dean Herbert	6efab635d8	Merge branch 'master' into fix-copy-difficulty-moving-collections	2023-01-25 14:11:32 +09:00
Dean Herbert	392ff2ffea	Reword comment regarding hash transfer to make more sense	2023-01-25 14:11:02 +09:00
Dean Herbert	741ca96853	Make transferCollections argument to private method explicitly required	2023-01-25 14:09:13 +09:00
Dean Herbert	739ec8d81d	Add argument hint for nondescript bool ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-01-25 14:04:30 +09:00
Bartłomiej Dach	f2df36e6a5	Persist cover visibility to user settings ... Follows web precedent, wherein the setting is saved to local storage.	2023-01-24 23:30:12 +01:00
Bartłomiej Dach	33e91cf512	Implement cover toggling	2023-01-24 23:06:49 +01:00
Bartłomiej Dach	e74176e5bd	Add cover toggle button	2023-01-24 23:06:46 +01:00
Bartłomiej Dach	ef7812412b	Update top header container appearance	2023-01-24 23:06:44 +01:00
Bartłomiej Dach	ff22a91d52	Move user cover lower down	2023-01-24 23:06:37 +01:00
Bartłomiej Dach	edb9c76edf	Merge pull request #22385 from peppy/touchscreen-settings-keyword ... Fix touch input handler settings not matching search for "touchscreen"	2023-01-24 20:50:53 +01:00
Bartłomiej Dach	054938be02	Merge pull request #22387 from peppy/beatmap-leaderboard-cancel-request-eagerly ... Fix beatmap leaderboard potentially showing incorrect leaderboard	2023-01-24 19:49:11 +01:00
Jérémiah DÉCOMBE	acb42f7d12	reusing gameplay background blur loc song select background blur	2023-01-24 10:18:00 +01:00
Dean Herbert	b9291cb116	Change some order and assert for positive visibility before scheduling an operation in changelog overlay	2023-01-24 17:59:25 +09:00
Jérémiah DÉCOMBE	e0a7559d85	variable naming + loc	2023-01-24 09:55:08 +01:00
Joseph Madamba	c6bf755e68	Remove IsPresent override from ChangelogOverlay	2023-01-24 00:22:29 -08:00
Joseph Madamba	df895c4fd6	Always make settings footer build display clickable	2023-01-24 00:21:39 -08:00
Jérémiah DÉCOMBE	7ca2a431e6	changing song select background blur setting to boolean	2023-01-24 09:19:53 +01:00
Jérémiah DÉCOMBE	d783998c81	using BindValueChanged and IsCurrentScreen for setting binding	2023-01-24 09:09:05 +01:00
Dean Herbert	a966d6c330	Merge pull request #18402 from ggliv/mod-accuracy-challenge ... Add accuracy challenge mod	2023-01-24 16:00:55 +09:00
ekrctb	e1702a8ee9	Fix inspection issue	2023-01-24 15:43:57 +09:00
ekrctb	efef97d5be	Store Result.TimeAbsolute separately from offset ... Calculating from TimeOffset is bad because it loses precision. The result time won't change anymore even If `HitObject.GetEndTime()` changes later.	2023-01-24 15:35:06 +09:00
Gabe Livengood	b46ef67a14	increase min minimum accuracy to 60%	2023-01-24 00:31:46 -05:00
ekrctb	cc87923179	Fix OnRevertResult timing	2023-01-24 14:19:24 +09:00
ekrctb	e66e43e17c	Remove unused code	2023-01-24 14:15:17 +09:00
Dean Herbert	bb15ee50e0	Fix beatmap leaderboard potentially showing incorrect leaderboard	2023-01-24 13:52:59 +09:00
Andrei Zavatski	04c96355cb	Use TriangleBorder shader to draw triangles	2023-01-24 07:38:42 +03:00
Dean Herbert	fc558278cc	Fix touch input handler settings not matching search for "touchscreen"	2023-01-24 13:37:12 +09:00
Pasi4K5	8b47af6503	Remove HidesResumeOverlay and set ResumeOverlay to null in OsuModAutopilot	2023-01-24 00:49:09 +01:00
Jeremiah DECOMBE	c1876aac88	removing parameter name abbreviations	2023-01-24 00:36:38 +01:00
Jeremiah DECOMBE	b573e42cc2	BeatmapSelectionBackgroundBlurLevel renamed to SongSelectBackgroundBlurLevel	2023-01-24 00:08:11 +01:00
naoey	e6de167adb	Revert split and make collections boolean internal to BeatmapManager	2023-01-24 07:27:26 +09:00
Jeremiah DECOMBE	26adc28943	missing blank line between methods	2023-01-23 23:15:37 +01:00
Jeremiah DECOMBE	f13a5465ba	variable naming and loc modifications	2023-01-23 23:07:50 +01:00
Bartłomiej Dach	7483967157	Merge branch 'master' into SliderEnd-Snap	2023-01-23 21:33:16 +01:00
Bartłomiej Dach	1f40b2daf6	Clean up xmldocs	2023-01-23 21:22:18 +01:00
Bartłomiej Dach	9f2ed853eb	Merge pull request #22371 from peppy/more-settings-keywords ... Add more keywords to settings based on feedback	2023-01-23 20:19:53 +01:00
Jérémiah DÉCOMBE	6daa364779	adding setting to adjust blur of the background of the song select screen	2023-01-23 13:53:31 +01:00
Dean Herbert	432e0a6a37	Merge branch 'master' into level-badge-colour	2023-01-23 15:46:15 +09:00
Dean Herbert	9c2494383f	Rename fetch method to be non-plural to match all others	2023-01-23 15:43:52 +09:00
Dean Herbert	e3932c077b	Merge pull request #22032 from frenzibyte/fix-potential-difficulty-failure-alt ... Fix advanced statistics display potentially performing invalid difficulty calculation	2023-01-23 15:39:47 +09:00
cdwcgt	5afb733fb2	change IssueTemplatePreviewTimeConflict's text	2023-01-23 15:26:28 +09:00
Dean Herbert	7ebd31d42f	Add more keywords to settings based on feedback	2023-01-23 15:14:16 +09:00
Dean Herbert	2ed9fe3747	Add support for externally specified keywords in SettingsButtons	2023-01-23 15:10:26 +09:00
Dean Herbert	73f083a316	Refactor how additional points are provided to avoid confusion	2023-01-23 14:13:46 +09:00
Susko3	f8537c1cbe	Delegate file deletion to ImportTask to allow overriding it	2023-01-22 22:19:04 +01:00
EXtremeExploit	8d4889d5ce	Cleanup	2023-01-22 17:42:53 -03:00
EXtremeExploit	e60a089f1a	Set alpha on container instead of children	2023-01-22 15:02:02 -03:00
EXtremeExploit	de5eb63ceb	Fix codefactor	2023-01-22 13:38:13 -03:00
EXtremeExploit	933fc8cc83	Fix comment	2023-01-22 13:33:36 -03:00
EXtremeExploit	64c9654910	Make probationary groups a bit transparent	2023-01-22 13:32:05 -03:00
Dean Herbert	f87bb589a2	Merge pull request #22340 from EXtremeExploit/groups-modes ... Add modes text to groups tooltip	2023-01-23 01:10:25 +09:00
Bartłomiej Dach	e1acf85bb3	Merge branch 'master' into groups-modes	2023-01-22 10:09:34 +01:00
Bartłomiej Dach	9bde1ef9bf	Privatise setter	2023-01-22 10:09:08 +01:00
Bartłomiej Dach	b98da506c1	Fix code quality inspection	2023-01-22 10:07:47 +01:00
Bartłomiej Dach	31e7d7333b	Merge branch 'master' into fix-fail-sample-playing-after-leaving-dialog	2023-01-22 09:35:37 +01:00
Bartłomiej Dach	06aa3f7798	Rename Stop{SampleAndRemoveFilters -> }() ... Now that just one method for stopping samples is left, let's just repurpose st as the general "stop global effects" method rather than have it there with a hyperspecific name. It also has good symmetry, as there already was a `Start()` method in the class.	2023-01-22 09:29:22 +01:00
Bartłomiej Dach	9e4e85e3e3	Inline StopSample() into StopSampleAndRemoveFilters() ... The first method no longer has any callers except for the second one.	2023-01-22 09:26:01 +01:00
Bartłomiej Dach	0edfd24410	Remove unnecessary sample stop in Restart() ... It is unnecessary, as a successful restart will exit the current player screen, and `OnExiting()` has another `StopSampleAndRemoveFilters()` call, which means that in the restart flow the sample was actually getting stopped twice. Standard exit flow is fine, it only stopped the sample once.	2023-01-22 09:24:12 +01:00
Bartłomiej Dach	88d58e8476	Merge pull request #22337 from Joehuu/fix-comment-editor-sounds ... Fix comment editor text boxes not having sound feedback	2023-01-22 09:10:20 +01:00
Bartłomiej Dach	b66279c5d7	Merge pull request #22341 from peppy/screen-scaling-keywords ... Add search keywords for screen scaling sub-settings	2023-01-22 08:56:14 +01:00
Matheus Filipe dos Santos Reinert	db0b69db6b	Merge branch 'master' into fix-fail-sample-playing-after-leaving-dialog	2023-01-22 02:12:07 -03:00
Dean Herbert	7040743249	Add search keywords for screen scaling sub-settings	2023-01-22 13:47:31 +09:00
Matheus Filipe dos Santos Reinert	5b1a23c697	Replace RemoveFilters call with StopSampleAndRemoveFilters	2023-01-22 01:44:16 -03:00
Matheus Filipe dos Santos Reinert	2e1ba6ef49	Create StopSampleAndRemoveFilters method and change RemoveFilters to private	2023-01-22 01:43:40 -03:00
EXtremeExploit	2f3971b6fb	Move code to already existing if block	2023-01-22 01:40:00 -03:00
EXtremeExploit	8c208da324	Cleanup	2023-01-22 01:39:01 -03:00
EXtremeExploit	05f77d2cab	Add modes text to groups tooltip	2023-01-22 01:36:53 -03:00
Matheus Filipe dos Santos Reinert	a746cbc6ed	Fix failSample still playing after player left FailOverlay	2023-01-22 01:14:33 -03:00
Pasi4K5	75a1a2ec2f	Hide ResumeOverlay when OsuModAutopilot is enabled	2023-01-22 03:44:59 +01:00
Joseph Madamba	da03abc812	Fix comment editor text boxes not having sound feedback	2023-01-21 17:32:42 -08:00
naoey	1c1c9915bb	Split saving new and existing beatmaps into separate flows	2023-01-22 10:27:33 +09:00
Bartłomiej Dach	718cbf9382	Fix SegmentedGraph draw node calculating segment colours in unsafe manner ... The `SegmentedGraph`'s draw node would call `getSegmentColour()` on the drawable, which would query the `DrawColourInfo` and `tierColours` properties of the drawable. This is a cross-thread access and as such completely unsafe, as due to being cross-thread it can die on invalidations or out-of-bounds accesses. Fix by transferring everything to the draw node first before attempting to draw. `SegmentedGraph.TierColours` setter already correctly invalidates the draw node via `graphNeedsUpdate`, so no further intervention was required there. Closes #22326.	2023-01-21 23:19:34 +01:00
naoey	a1b5c9d910	Don't transfer MD5 hashes in collections when copying beatmaps ... Fixes #22306. Changes beatmap saving so that by default it does not transfer the hashes in collections, and only transfers them when saving the same difficulty in the editor. Issue seems to have been introduced in https://github.com/ppy/osu/pull/20641.	2023-01-22 01:14:18 +09:00
Salman Ahmed	c48af79588	Fix test browsers on longer working after framework update	2023-01-21 14:49:47 +03:00
Dean Herbert	19450bfe12	Update framework	2023-01-20 23:23:25 +09:00
ekrctb	d8f9b7d02f	Use MaximumJudgementOffset for lifetime	2023-01-19 21:25:21 +09:00
ekrctb	11e1b22bf5	Move MaximumJudgementOffset to HitObject ... We want to access this property for computing lifetime	2023-01-19 21:23:55 +09:00
ekrctb	812a4b412a	Move judgement result revert logic to Playfield ... Previously, some judgement results were not reverted when the source DHO is not alive (e.g. frames skipped in editor). Now, all results are reverted in the exact reverse order.	2023-01-19 19:57:13 +09:00
Dean Herbert	2ce32e3209	Refactor update logic to be easier to follow	2023-01-19 19:27:05 +09:00
mk56-spn	b22363ed8c	Fix JudgementCounterDisplay.cs max judgement always showing upon changing display mode	2023-01-19 10:31:02 +01:00
Dean Herbert	4916a742d5	Immediately focus the textbox when clicking to reply to a comment	2023-01-19 16:08:27 +09:00
Dean Herbert	81e6c3792c	Remove unused method	2023-01-19 16:03:46 +09:00
Dean Herbert	56ce8504ae	Merge branch 'master' into comment-reply	2023-01-19 16:01:47 +09:00
Dean Herbert	07af18b8a7	Remove ReplyCommentEditor into its own class	2023-01-19 16:01:37 +09:00
Dean Herbert	db8084570d	Merge pull request #22285 from bdach/segmented-graph-tint ... Apply draw colour to segmented graph	2023-01-19 13:36:19 +09:00
Dean Herbert	e58abf7d1a	Merge pull request #22284 from bdach/judgement-counter-broken ... Fix "show max judgement" setting not applying initially on judgement counter display	2023-01-19 09:09:06 +09:00
Bartłomiej Dach	a0fe71c706	Use alternative segment colour computation method	2023-01-19 00:08:32 +01:00
Bartłomiej Dach	b62ff8d644	Merge branch 'master' into skin/argon-song-progress-cleaner	2023-01-18 23:52:12 +01:00
Bartłomiej Dach	b8b7442eb8	Make SongProgressInfo.ShowProgress init-only (and remove duplicate init)	2023-01-18 23:35:40 +01:00
Bartłomiej Dach	903c37bf32	Apply draw colour to segmented graph segments	2023-01-18 23:17:57 +01:00
Wleter	f8d8a627b8	change property name	2023-01-18 22:00:39 +01:00
Bartłomiej Dach	769f8c6190	Fix ShowMaxJudgement callback conflicting with JudgementCounter.Pop{In,Out} ... Both `JudgementCounterDisplay` (via the `ShowMaxJudgement` callback) and the `JudgementCounter.Pop{In,Out}` methods were operating on the alpha of the `JudgementCounter`. This meant that if the counter display was created with max judgement initially hidden, it would be hidden by the `ShowMaxJudgement` callback first, but then _unhidden_ by `PopIn()`.	2023-01-18 21:46:28 +01:00
Wleter	40e99069fc	fix typos and newlines	2023-01-18 21:43:09 +01:00
Wleter	ab78dd0436	add collection of selection points.	2023-01-18 21:34:23 +01:00
ansel	77bc4fbf70	Integrate editor into comment	2023-01-18 20:50:07 +03:00
ansel	0d91277ea5	Add ability to change number on replies button	2023-01-18 20:49:30 +03:00
ansel	c74500b4b4	Add reply editor	2023-01-18 20:49:07 +03:00
Bartłomiej Dach	761298cd8e	Merge pull request #22275 from peppy/fix-legacy-old-judgement-animation ... Fix legacy judgement animation not matching perfectly	2023-01-18 18:27:13 +01:00
Gabe Livengood	150195b887	use extension method to check accuracy impact	2023-01-18 12:24:41 -05:00