h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-11-14 10:57:30 +08:00
Code Issues Releases Wiki Activity
42,736 Commits 3 Branches 654 Tags 359 MiB
c7274355a4
Commit Graph

27042 Commits

Author SHA1 Message Date
Dean Herbert
3ec7dc3bb9 Update tests in line with thread safety check 2021-07-04 17:59:39 +09:00
Dean Herbert
7a710ceffe Check count as well (statistics can be populated with zero counts) 2021-07-04 16:41:09 +09:00
Dean Herbert
567e9f33a9 Fix thread safety of realm Refresh operation 
Due to the lack of locking, there was a chance the the update thread
`context` was retrieved just before the `flushContexts` call, followed
by `.Refresh()` being run while the blocking behaviour was invoked.

This can be seen in test failures such as
https://ci.appveyor.com/project/peppy/osu/builds/39859786/tests.

As an aside, I tried multiple different methods to avoid `lock()` on the
update thread but they felt flaky. The overhead of lock when there's no
contention is reportedly around 30-50ns, so likely not of concern. We
can address it at a later point if it becomes one.
 2021-07-04 16:24:43 +09:00
Dean Herbert
ef82528309 Don't attempt to submit score when nothing has been hit 2021-07-04 15:16:18 +09:00
Dean Herbert
149a200f34 Fix volume metre not correctly showing volume when initially zero 
Closes https://github.com/ppy/osu/issues/13761.
 2021-07-04 14:56:17 +09:00
Dean Herbert
ec71deec51 Remove some mentions of "lazer" 
I am aware there are more throughout the codebase but intentionally left
the remaining mentioned for one reason or another. The intention here is
to mainly change user-facing versioning to change the positioning of the
"lazer" term (to be where we would expect "cuttingedge" or "beta" to
be).
 2021-07-04 12:41:27 +09:00
PercyDan54
12371f7424
Fix playlist item displays as empty string if no unicode title is present 2021-07-04 08:09:38 +08:00
Bartłomiej Dach
8a23dfa6f5 Fix optimised import path buffering events without flush 2021-07-03 17:58:12 +02:00
Bartłomiej Dach
fbe3b447e5 Merge branch 'master' into linkify-metadata 2021-07-03 15:51:08 +02:00
Bartłomiej Dach
6fb8ed4d07 Trim no longer used constant 2021-07-03 15:47:47 +02:00
Dean Herbert
0be75cc4ed Fix incorrect base call causing import optimisation to not work 2021-07-03 22:35:46 +09:00
Bartłomiej Dach
7dae93ad66 Remove unused using directives 2021-07-03 15:23:26 +02:00
Bartłomiej Dach
16d08df5e2 Remove mention of direct from xmldoc 2021-07-03 15:22:03 +02:00
Salman Ahmed
83578e7c9d Hold a bound copy reference instead 2021-07-02 23:24:51 +03:00
Salman Ahmed
612ed6353c Resolve RestoreDefaultValueButton issue by internal management 2021-07-02 22:30:26 +03:00
Salman Ahmed
2b366e04fd Revert "Fix RestoreDefaultValueButton not behaving correctly on number types" 
This reverts commit bc0ab7dd4f.
 2021-07-02 21:06:57 +03:00
Dan Balasescu
ace57a9ee9
Merge pull request #13727 from peppy/update-disclaimer 
Update disclaimer
 2021-07-02 21:08:43 +09:00
Dan Balasescu
5a7706edee
Merge pull request #13726 from nekodex/notch-tick-sfx 
Add audio feedback for changing volume
 2021-07-02 21:08:31 +09:00
Dean Herbert
6e31c781bb
Merge pull request #13382 from ribbanya/clamp-skin-scale 
Fix skin elements flipping when scaled below zero
 2021-07-02 20:50:47 +09:00
Dan Balasescu
4d85df6bbc
Merge branch 'master' into notch-tick-sfx 2021-07-02 20:38:30 +09:00
Dean Herbert
66240d582f
Merge branch 'master' into consume-bindable-current-factory 2021-07-02 20:28:57 +09:00
Dean Herbert
b0f257fa04
Merge pull request #13685 from gagahpangeran/wiki-image-block 
Fix image overflow in wiki overlay
 2021-07-02 20:21:20 +09:00
Dean Herbert
8847915c6a Update framework 2021-07-02 18:51:14 +09:00
Dan Balasescu
9eb6ae4d45
Merge pull request #13721 from peppy/submit-on-player-exit 
Submit scores on player exit
 2021-07-02 18:25:26 +09:00
Dean Herbert
4e52aee5a0
Merge branch 'master' into wiki-image-block 2021-07-02 18:19:46 +09:00
Dean Herbert
f37e5bdab8
Merge pull request #13742 from aitani9/skin-editor-flipping-reflect 
Make flipping in the skin editor reflect across the axes of the selection box
 2021-07-02 18:19:04 +09:00
Dan Balasescu
211c248692
Merge pull request #13744 from peppy/fix-async-void-calls 
Fix some incorrectly invoked `async` calls
 2021-07-02 18:10:30 +09:00
Dean Herbert
362816492f Move to more friendly namespace 2021-07-02 18:09:16 +09:00
Dean Herbert
1bbf578dfe
Merge pull request #13714 from bdach/colour-picker 
Add osu!-styled colour picker control
 2021-07-02 18:05:19 +09:00
Dean Herbert
eacf867073 Move shared types into their own classes 2021-07-02 18:05:00 +09:00
Dean Herbert
ecb4982281 Add missing blank lines 2021-07-02 17:51:54 +09:00
Henry Lin
6a0c5b54c3 Fix obsolete message in Mod.Ranked 2021-07-02 15:55:25 +08:00
Dean Herbert
35f7966922 Merge conditionals in line with other case of same logic 2021-07-02 15:55:36 +09:00
Dean Herbert
63d2ac66d2 Fix one more instance of incorrect playback/frequency set order 2021-07-02 15:52:20 +09:00
Jamie Taylor
910fe3e9f8 Center pitch randomisation around base pitch 2021-07-02 15:51:23 +09:00
Dean Herbert
bd6664d541 Add note about intentional downward pitch, against expectations 2021-07-02 15:48:16 +09:00
Dean Herbert
13254d51fc Remove usage of bool for initial playback 
Also refactors the whole method to generally clean things up. One more
important fix is setting the frequency on the channel before starting
playback, so avoid the frequency potentially being adjusted after the
playback is already started.
 2021-07-02 15:48:13 +09:00
Dean Herbert
69b1347730 Tidy up weird bind logic 2021-07-02 15:29:51 +09:00
Dean Herbert
9814c24741 Merge branch 'master' into notch-tick-sfx 2021-07-02 15:27:28 +09:00
Dean Herbert
f2d9d78455 Fix some incorrectly invoked async calls 2021-07-02 14:43:48 +09:00
Dean Herbert
f689e788c9 Avoid using game-wide beatmap during score submission 2021-07-02 14:24:27 +09:00
Dean Herbert
0396a03bbc Rename Mod.Ranked back to avoid breaking ruleset API 2021-07-02 12:50:58 +09:00
Dean Herbert
62c125d7a2 Tidy up font formatting methods 2021-07-02 12:21:28 +09:00
Dean Herbert
f0727a63be Reduce usable width 2021-07-02 12:18:52 +09:00
Dean Herbert
a1eaf39645 Slightly change wording to hopefully read better 2021-07-02 12:15:16 +09:00
Bartłomiej Dach
083e463afd Use alternative hue slider nub design 2021-07-02 01:03:02 +02:00
Bartłomiej Dach
434c048d87 Merge branch 'master' into colour-picker 2021-07-02 01:03:00 +02:00
aitani9
9b0fa6d3fc Make flipping reflect across the axes of the selection box 2021-07-01 15:38:38 -07:00
Bartłomiej Dach
6c07f6fecf Merge remote-tracking branch 'upstream/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.MessagePack-5.0.7' into update-dependencies 2021-07-01 19:17:00 +02:00
Bartłomiej Dach
326a46fa84 Merge remote-tracking branch 'upstream/dependabot/nuget/Microsoft.AspNetCore.SignalR.Client-5.0.7' into update-dependencies 2021-07-01 19:16:23 +02:00
Bartłomiej Dach
7f6d6edc46 Merge remote-tracking branch 'upstream/dependabot/nuget/ppy.LocalisationAnalyser-2021.614.0' into update-dependencies 2021-07-01 19:16:16 +02:00
Bartłomiej Dach
8a581fcf7e Merge remote-tracking branch 'upstream/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson-5.0.7' into update-dependencies 2021-07-01 19:16:11 +02:00
Bartłomiej Dach
c34ecc7492 Merge remote-tracking branch 'upstream/dependabot/nuget/Humanizer-2.11.10' into update-dependencies 2021-07-01 19:15:58 +02:00
Bartłomiej Dach
e6b9bcb90c Merge remote-tracking branch 'upstream/dependabot/nuget/HtmlAgilityPack-1.11.34' into update-dependencies 2021-07-01 19:14:27 +02:00
Bartłomiej Dach
503bf092c9 Merge remote-tracking branch 'upstream/dependabot/nuget/SharpCompress-0.28.3' into update-dependencies 2021-07-01 19:14:09 +02:00
Bartłomiej Dach
6f859d66f8 Merge remote-tracking branch 'upstream/dependabot/nuget/Sentry-3.6.0' into update-dependencies 2021-07-01 19:13:15 +02:00
dependabot[bot]
d0ae946cb6
Bump Microsoft.AspNetCore.SignalR.Protocols.MessagePack 
Bumps [Microsoft.AspNetCore.SignalR.Protocols.MessagePack](https://github.com/dotnet/aspnetcore) from 5.0.6 to 5.0.7.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.6...v5.0.7)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Protocols.MessagePack
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:38 +00:00
dependabot[bot]
f6234864cc
Bump Microsoft.AspNetCore.SignalR.Client from 5.0.6 to 5.0.7 
Bumps [Microsoft.AspNetCore.SignalR.Client](https://github.com/dotnet/aspnetcore) from 5.0.6 to 5.0.7.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.6...v5.0.7)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Client
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:33 +00:00
dependabot[bot]
fb2d08b9ee
Bump ppy.LocalisationAnalyser from 2021.608.0 to 2021.614.0 
Bumps [ppy.LocalisationAnalyser](https://github.com/ppy/osu-localisation-analyser) from 2021.608.0 to 2021.614.0.
- [Release notes](https://github.com/ppy/osu-localisation-analyser/releases)
- [Commits](https://github.com/ppy/osu-localisation-analyser/compare/2021.608.0...2021.614.0)

---
updated-dependencies:
- dependency-name: ppy.LocalisationAnalyser
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:29 +00:00
dependabot[bot]
e7c7b8512a
Bump Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson 
Bumps [Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson](https://github.com/dotnet/aspnetcore) from 5.0.6 to 5.0.7.
- [Release notes](https://github.com/dotnet/aspnetcore/releases)
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.6...v5.0.7)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:25 +00:00
dependabot[bot]
b320528eb5
Bump Humanizer from 2.10.1 to 2.11.10 
Bumps [Humanizer](https://github.com/Humanizr/Humanizer) from 2.10.1 to 2.11.10.
- [Release notes](https://github.com/Humanizr/Humanizer/releases)
- [Changelog](https://github.com/Humanizr/Humanizer/blob/main/release_notes.md)
- [Commits](https://github.com/Humanizr/Humanizer/compare/v2.10.1...v2.11.10)

---
updated-dependencies:
- dependency-name: Humanizer
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:22 +00:00
dependabot[bot]
71867337b6
Bump HtmlAgilityPack from 1.11.33 to 1.11.34 
Bumps [HtmlAgilityPack](https://github.com/zzzprojects/html-agility-pack) from 1.11.33 to 1.11.34.
- [Release notes](https://github.com/zzzprojects/html-agility-pack/releases)
- [Commits](https://github.com/zzzprojects/html-agility-pack/compare/v1.11.33...v1.11.34)

---
updated-dependencies:
- dependency-name: HtmlAgilityPack
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:15 +00:00
dependabot[bot]
e5e468e387
Bump SharpCompress from 0.28.2 to 0.28.3 
Bumps [SharpCompress](https://github.com/adamhathcock/sharpcompress) from 0.28.2 to 0.28.3.
- [Release notes](https://github.com/adamhathcock/sharpcompress/releases)
- [Commits](https://github.com/adamhathcock/sharpcompress/compare/0.28.2...0.28.3)

---
updated-dependencies:
- dependency-name: SharpCompress
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:11 +00:00
dependabot[bot]
c976854e24
Bump Sentry from 3.4.0 to 3.6.0 
Bumps [Sentry](https://github.com/getsentry/sentry-dotnet) from 3.4.0 to 3.6.0.
- [Release notes](https://github.com/getsentry/sentry-dotnet/releases)
- [Changelog](https://github.com/getsentry/sentry-dotnet/blob/main/CHANGELOG.md)
- [Commits](https://github.com/getsentry/sentry-dotnet/compare/3.4.0...3.6.0)

---
updated-dependencies:
- dependency-name: Sentry
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:08 +00:00
dependabot[bot]
8ab9ea9926
Bump Realm from 10.2.0 to 10.2.1 
Bumps [Realm](https://github.com/realm/realm-dotnet) from 10.2.0 to 10.2.1.
- [Release notes](https://github.com/realm/realm-dotnet/releases)
- [Changelog](https://github.com/realm/realm-dotnet/blob/master/CHANGELOG.md)
- [Commits](https://github.com/realm/realm-dotnet/compare/10.2.0...10.2.1)

---
updated-dependencies:
- dependency-name: Realm
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:03 +00:00
Dean Herbert
48b36e8940
Merge branch 'master' into star-difficulty-range-display 2021-07-01 22:51:42 +09:00
Dean Herbert
153814626c
Merge pull request #13724 from smoogipoo/update-sr-colours 
Update SR colours to match osu-web
 2021-07-01 22:51:23 +09:00
Dean Herbert
f1c11243e9 Update resources 2021-07-01 22:06:59 +09:00
Jamie Taylor
dad28b2826
Update OsuSliderBar to use new notch-tick sample and tweak pitch ramping 2021-07-01 20:55:55 +09:00
Jamie Taylor
68c5e6a431
Add audio feedback to changing volume 2021-07-01 20:55:04 +09:00
smoogipoo
4c95af4b16 Add star rating range display 2021-07-01 20:35:31 +09:00
Dean Herbert
4c1b8bc427 Update disclaimer 2021-07-01 20:23:12 +09:00
Dean Herbert
0522500a57 Fix a couple of merge oversights 2021-07-01 19:45:17 +09:00
Dean Herbert
31dbc7798b Merge branch 'master' into linkify-metadata 2021-07-01 19:41:33 +09:00
smoogipoo
a78d1b4c2e Update SR colours to match osu-web 2021-07-01 19:37:21 +09:00
Dean Herbert
3816c486d5 Guard against a potential startup crash if user's preferred ruleset has a compatibility issue 
Resolves this issue seen at https://github.com/ppy/osu/issues/13722#issuecomment-872088071.
 2021-07-01 19:03:58 +09:00
Dean Herbert
82fd8b13df
Merge pull request #13720 from Game4all/localise-dashboard-friends 
Localise friends view in dashboard overlay
 2021-07-01 18:20:18 +09:00
Dean Herbert
74c63e15be Mark score failed on fail and exit 2021-07-01 17:48:09 +09:00
Dean Herbert
b00ee67895 Remove excess whitespace 2021-07-01 17:25:47 +09:00
Dean Herbert
04b874bb00 Add flow for submitting score on exiting SubmittingPlayer 2021-07-01 17:02:33 +09:00
Dean Herbert
5bc970af0d Make TestPlayer inherit from SoloPlayer for more flexibility in testing 2021-07-01 16:55:33 +09:00
Bartłomiej Dach
583242d96d Add osu!-styled colour picker control 2021-06-30 23:25:50 +02:00
Lucas A
939b2baafe Localise overlay "Scroll to top" button. 2021-06-30 22:19:04 +02:00
Lucas A
8da6ecf6a9 Localise OverlayPanelDisplayStyle tab control. 2021-06-30 21:28:07 +02:00
Lucas A
f2287ba022 Localise friends online status stream control. 2021-06-30 21:16:21 +02:00
Lucas A
285c49be7e Localise dashboard overlay header. 2021-06-30 20:28:27 +02:00
Dean Herbert
00d3baef11 Exit handling flow 2021-06-30 20:23:48 +09:00
Dean Herbert
57a21dfb1c Update framework 2021-06-30 16:11:18 +09:00
Dean Herbert
4a71a4bb21
Merge pull request #13450 from smoogipoo/spectator-start-at-end-2 
Start spectator at the end of gameplay
 2021-06-30 16:09:35 +09:00
Dean Herbert
094cd31361
Merge pull request #13441 from frenzibyte/ruleset-resources-skin 
Provide access to ruleset resources during `ISkinSource` lookups
 2021-06-30 15:26:37 +09:00
Dean Herbert
a019f2cc5c
Merge branch 'master' into rework-multiplayer-test-scenes 2021-06-30 13:49:05 +09:00
Salman Ahmed
bc0ab7dd4f Fix RestoreDefaultValueButton not behaving correctly on number types 2021-06-29 23:39:46 +03:00
Dean Herbert
825181121d
Merge branch 'master' into spectator-start-at-end-2 2021-06-30 01:50:14 +09:00
Dean Herbert
5031707048
Merge pull request #13690 from smoogipoo/fix-action-posting 
Fix commands posted to the wrong channel
 2021-06-30 00:39:02 +09:00
smoogipoo
6dd3c6fe93 Make MultiSpectatorScreen and tests more resillient to timing 2021-06-29 22:45:51 +09:00
Gagah Pangeran Rosfatiputra
3a002e357a
rename method 2021-06-29 19:28:21 +07:00
Dean Herbert
2f1203085b Also add logging of realm block/flush operations 2021-06-29 20:23:25 +09:00
Dean Herbert
9acc5e38bb Add basic logging for osu! storage migration 
When looking into the test failure at https://github.com/ppy/osu/runs/2940065457, it became apparent that we are not showing the migration process anywhere in logs. It's the cause of many issues, and we would want to see this in CI and user logs when occurring.
 2021-06-29 20:23:25 +09:00
smoogipoo
bfdbe3c3fe Fix clocks getting added a second time 2021-06-29 17:29:25 +09:00
smoogipoo
8e04d73b67 Merge branch 'rework-multiplayer-test-scenes' into spectator-start-at-end-2 2021-06-29 17:06:57 +09:00
smoogipoo
ca0eaab8e2 Add test 2021-06-29 16:30:46 +09:00
smoogipoo
7a86686f40 Make nullable 2021-06-29 16:30:40 +09:00
smoogipoo
9132c42f87 Fix actions posted to the wrong channel 2021-06-29 15:58:07 +09:00
smoogipoo
bcdf36e77b Merge branch 'master' into spectator-start-at-end-2 2021-06-29 15:53:58 +09:00
smoogipoo
92fa99700e Merge branch 'master' into rework-multiplayer-test-scenes 2021-06-29 15:39:59 +09:00
smoogipoo
a3b1e1d5fc Check for null ruleset in FilterCriteria 2021-06-29 15:18:40 +09:00
Gagah Pangeran Rosfatiputra
d88d264491
prevent image sprite exceed its parent width 2021-06-29 09:49:45 +07:00
Dan Balasescu
697b07acb1
Merge branch 'master' into fix-beatmap-import-fk-failure 2021-06-29 11:36:31 +09:00
Dan Balasescu
471bf9a752
Merge pull request #13681 from peppy/score-submit-ruleset-id 
Serialise and send ruleset ID as part of score submission
 2021-06-29 11:27:13 +09:00
Dean Herbert
e4ca6a4266 Serialise and send ruleset ID as part of score submission 2021-06-29 01:55:09 +09:00
Gagah Pangeran Rosfatiputra
e58f690210
centering image sprite 2021-06-28 21:09:00 +07:00
Gagah Pangeran Rosfatiputra
2b8d41c045
add BlockImageContainer 
change from AutoSize Both to AutoSize Y and RelativeSize X
 2021-06-28 21:04:56 +07:00
Gagah Pangeran Rosfatiputra
1c074ff018
add BlockMarkdownImage 
change from AutoSize Both to AutoSize Y and RelativeSize X
 2021-06-28 21:04:13 +07:00
Dan Balasescu
a9084db665
Merge pull request #13673 from peppy/import-early-checksum-abort 
Shortcut import process to speed up duplicate imports
 2021-06-28 19:55:09 +09:00
Dan Balasescu
8950757b61
Merge pull request #13618 from peppy/fix-realm-state-change-crashes 
Fix realm threading issues to make it releaseable
 2021-06-28 19:54:49 +09:00
Dan Balasescu
92fcf90768
Merge branch 'master' into import-early-checksum-abort 2021-06-28 19:29:08 +09:00
Salman Ahmed
66fc95c111 Use LastOrDefault instead 2021-06-28 12:43:58 +03:00
Salman Ahmed
7197998a10 Remove resolution to SkinManager and use pattern matching instead 2021-06-28 12:43:13 +03:00
Salman Ahmed
177bfe1234 Merge branch 'master' into ruleset-resources-skin 2021-06-28 11:16:37 +03:00
Dean Herbert
a8597b6213
Merge pull request #13658 from frenzibyte/fix-initial-ruleset-skin-loading 
Fix `RulesetSkinProvidingContainer` being potentially late in setting up skin sources
 2021-06-28 17:03:56 +09:00
Dean Herbert
d4ea73d727 Simplify disposal exceptions 2021-06-28 16:17:09 +09:00
Dean Herbert
f78cedd0e1 Reorder methods and add xmldoc for BlockAllOperations 2021-06-28 16:16:40 +09:00
Dean Herbert
90f0bc87f5 Add safety against double disposal 2021-06-28 16:12:21 +09:00
Dean Herbert
842f033522 Remove no longer necessary exception 2021-06-28 16:11:55 +09:00
Dean Herbert
f7aba7360a
Merge pull request #13654 from Henry-YSLin/fix-invisible-number-box 
Refactor `SeedSettingsControl` and `SettingsNumberBox`
 2021-06-28 16:07:30 +09:00
Dean Herbert
0d2bc4fc5f Merge branch 'master' into fix-realm-state-change-crashes 2021-06-28 16:03:58 +09:00
Salman Ahmed
779a1b322c
Add comment explaining insertion of ruleset skin before default skin 
Co-authored-by: Dean Herbert <pe@ppy.sh>
 2021-06-28 09:38:42 +03:00
Dean Herbert
e4780d4b06 Update framework 2021-06-28 15:29:47 +09:00
Dean Herbert
f939e2603a Merge branch 'master' into localisable-tooltips 2021-06-28 15:29:42 +09:00
Dean Herbert
eeb56970ef Make OutlinedNumberBox private and nested again 2021-06-28 15:24:55 +09:00
Salman Ahmed
f598de4cdb ResourcesSkin -> ResourceStoreBackedSkin 2021-06-28 09:18:29 +03:00
Salman Ahmed
692f24437e Maintain ruleset resources skin across multiple source changes 2021-06-28 09:11:28 +03:00
Dean Herbert
7dd566dc46
Add null check for safety 
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
 2021-06-28 15:08:49 +09:00
Dean Herbert
c281e43cd8 Remove Dispose() special case and add explicit exception to make debugging issues non-deadlock 2021-06-28 15:04:14 +09:00
Dean Herbert
f777741ca7 Simplify instantiation 2021-06-28 14:51:27 +09:00
Dean Herbert
e387feb1d6 Add inline comment mentioning why CreateChildDependencies is being used in this instance 2021-06-28 14:39:55 +09:00
Dean Herbert
fdd6778f36
Merge branch 'master' into fix-initial-ruleset-skin-loading 2021-06-28 14:35:34 +09:00
Dean Herbert
a3946a1265
Fix typo in newly added xmldoc 
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
 2021-06-28 14:07:21 +09:00
Henry Lin
3d19364a71 Use BindValueChanged instead of setting the value in property setter 2021-06-28 11:20:00 +08:00
Dean Herbert
4d6002ab88 Remove redundant string interpolation (and mark all local logging strings as verbatim) 2021-06-28 12:16:15 +09:00
Henry Lin
0cceef8da5 Moved the string to int? conversion logic into SettingsNumberBox 2021-06-28 11:00:07 +08:00
Dean Herbert
4a557e73a7 Add logging to help understand existing case skips better 2021-06-28 10:42:42 +09:00
Dan Balasescu
9c0840268a
Merge pull request #13598 from JimmyC7834/supporter-only-filter-content 
Add supporter required placeholder in beatmap listing overlay
 2021-06-28 10:27:56 +09:00
Dean Herbert
90b87cbb9e Add back unidirectional online id check 2021-06-28 10:11:27 +09:00
Dean Herbert
9a96cd4a1d Revert "Remove comparison of online beatmap IDs during dedupe checks" 
This reverts commit 15af28d2a0.
 2021-06-28 09:54:18 +09:00
Dean Herbert
a1e8cc5444
Merge pull request #13669 from Naxesss/hitsound-checks 
Add hitsound checks
 2021-06-28 03:13:43 +09:00
Naxess
9f9e96ce9e Add check for spanDuration <= 0 prior to division 2021-06-27 15:40:09 +02:00
Naxess
a4a5325b73 Improve acceptable difference for repeat edges 
Likelihood that `spanDuration` is greater than E+7 is quite low in any realistic case, so this should work fine.
 2021-06-27 15:39:31 +02:00
Dean Herbert
e755dcc34d Add log method for new flow 2021-06-27 20:37:12 +09:00
Dean Herbert
f470b7095d Move private method down in class 2021-06-27 20:36:01 +09:00
Dean Herbert
f216404952 Fix missing undelete call on using existing 2021-06-27 20:22:48 +09:00
Dean Herbert
9120321731 Add comments mentioning shortcomings and avoid potential double check 2021-06-27 19:07:35 +09:00
Dean Herbert
44f875b802 Bypass optimised existing check in SkinManager (due to custom hashing function) 2021-06-27 16:35:13 +09:00
Dean Herbert
e493685c14 Add optimised existing check earlier in import process 2021-06-27 16:34:40 +09:00
Dean Herbert
15af28d2a0 Remove comparison of online beatmap IDs during dedupe checks 2021-06-27 14:48:57 +09:00
Dean Herbert
46f8100f43 Remove overly verbose logging during beatmap imports 2021-06-27 14:29:02 +09:00
Dean Herbert
d1f852d102 Make Populate abstract to avoid unnecessary base call async complexity 2021-06-27 14:29:02 +09:00
Naxess
4cfa0ae5ec Improve precision for repeat edges 2021-06-27 03:26:35 +02:00
Naxess
2cd7eda3c4 Add "or equal to" to volume threshold xmldocs 2021-06-27 02:30:12 +02:00
Naxess
0c0fd291d9 Order hitobjects by endtime 2021-06-27 01:25:03 +02:00
Naxess
4796b1b208 Use local variables for hasHitsound & couldHaveHitsound 2021-06-27 00:04:30 +02:00
Naxess
5bc08ebadb Rename hasHitsounds -> mapHasHitsounds 2021-06-26 23:49:25 +02:00
Naxess
d29e6f4695 Add negligible template to PossibleTemplates 2021-06-26 23:49:06 +02:00
Naxess
1913084342 Use HitSampleInfo.AllAdditions instead of new list 2021-06-26 23:48:28 +02:00
Naxess
f78cc9397e Factor out edge type logic 2021-06-26 20:45:31 +02:00
Naxess
51147405c5 Make || and && priority explicit 2021-06-26 20:44:39 +02:00
Bartłomiej Dach
9061ab0a27 Update/reword comments in listing overlay 2021-06-26 20:42:13 +02:00
Bartłomiej Dach
b56dd7ff25 Fix naming and xmldocs in new beatmap search result structures 2021-06-26 20:35:07 +02:00
Naxess
4b436b774d Add few hitsounds check 2021-06-26 19:20:46 +02:00
Naxess
d8117fa730 Add muted objects check 2021-06-26 19:20:34 +02:00
Gagah Pangeran Rosfatiputra
2b1d3c8e9c
add od filter in search filter 2021-06-26 21:05:01 +07:00
Gagah Pangeran Rosfatiputra
8e1bcc4d6b
add overall difficulty in filter criteria 2021-06-26 21:02:31 +07:00
Salman Ahmed
e8e9fdd533 Dispose ResourcesSkin before clearing skin sources 2021-06-26 12:34:30 +03:00
Salman Ahmed
e5eea503db Remove finalizer logic from ResourcesSkin 2021-06-26 12:21:49 +03:00
Henry Lin
3b822cd5cf Refactor SeedSettingsControl and related controls 2021-06-26 11:19:14 +08:00
Bartłomiej Dach
ea384332c3
Merge branch 'master' into logo-transition-sound 2021-06-25 21:12:48 +02:00
Bartłomiej Dach
50c27d2635 Update usages of IHasTooltip in line with framework localisation changes 2021-06-25 19:10:04 +02:00
aitani9
6bc71590c5 Disable logo click sound when exiting 2021-06-25 09:21:26 -07:00
smoogipoo
c93c615f5e Also fix up interface names 2021-06-25 20:15:30 +09:00
smoogipoo
1ed61b9b98 Fix up dependencies class names 2021-06-25 20:11:38 +09:00
Salman Ahmed
8387acfe15
Merge branch 'master' into fix-initial-ruleset-skin-loading 2021-06-25 12:22:51 +03:00
smoogipoo
a27a647ae7 Rename RoomDependencies -> OnlinePlayDependencies 2021-06-25 18:07:47 +09:00
smoogipoo
04279e7f5c Add some xmldocs 2021-06-25 18:02:53 +09:00
smoogipoo
c0d2b41d4c Move SpectatorClient into multiplayer dependencies 2021-06-25 17:55:16 +09:00
Dean Herbert
51dd7fc238
Merge pull request #13622 from aitani9/mod-settings-dropdown-height 
Decrease the max dropdown height in mod settings
 2021-06-25 17:42:47 +09:00
smoogipoo
7aefbe3da1 Move UserLookupCache inside dependencies 2021-06-25 17:37:02 +09:00
Dean Herbert
5883922177 Remove mod multiplier completely 2021-06-25 16:36:31 +09:00
Salman Ahmed
f07008a0a2 Fix RulesetSkinProvidingContainer potentially late in setting up skin sources 2021-06-25 10:05:51 +03:00
Dean Herbert
57ae87956a Update execution state change blocking logic in line with framework changes 2021-06-25 15:27:40 +09:00
smoogipoo
81a812e216 Rework MultiplayerTestScene to make use of OnlinePlayTestScene 2021-06-25 15:00:10 +09:00
smoogipoo
aa5d22d04a Remove "test container", make everything go through OnlinePlayTestScene 2021-06-25 13:02:19 +09:00
Henry Lin
31c786e1c3 Use SettingsNumberBox.NumberBox instead of OsuNumberBox 2021-06-25 09:51:34 +08:00
aitani9
93edb25ace Override CreateMenu instead of using a property 2021-06-24 14:32:43 -07:00
aitani9
34ace2553e Revert "Refactor the menu's max height to be a property" 
This reverts commit 9cb9ef5c
 2021-06-24 14:32:00 -07:00
aitani9
62566f2a4a Remove "Score Multiplier" text 2021-06-24 14:29:47 -07:00
Bartłomiej Dach
4fe30ca923 Remove Traditional Chinese (HK) language option 
Due to no actual existing translations it was falling back to Simplified
Chinese instead, making the option actively wrong/confusing.
 2021-06-24 18:32:17 +02:00
smoogipoo
5820793d11 Make TestMultiplayerRoomContainer inherit TestRoomContainer 2021-06-24 21:02:29 +09:00
smoogipoo
9cf2c9ddae Fix incorrect dependency creation 2021-06-24 21:02:21 +09:00
smoogipoo
a21cf87b5f Split room manager and allow overrides 2021-06-24 19:14:05 +09:00
smoogipoo
5115299e9a Merge RoomManagerTestScene into OnlinePlaySubScreenTestScene 2021-06-24 19:09:31 +09:00
Dean Herbert
6922de12c6 Add extra null safety in dispose call 2021-06-24 17:17:12 +09:00
smoogipoo
a7b5c3bed1 Add OnlinePlaySubScreenTestScene 2021-06-24 17:01:28 +09:00
smoogipoo
9287fae5f7 Simplify 2021-06-24 16:54:09 +09:00
smoogipoo
4af119a407 Re-namespace 2021-06-24 16:29:06 +09:00
Salman Ahmed
a98b5618b8 Convert RulesetResourcesSkin to plain ResourcesSkin and pass non-null resources 2021-06-24 10:07:38 +03:00
smoogipoo
c9ec4b9da4 Remove RoomTestScene inheritance from simple test scenes 2021-06-24 16:02:20 +09:00
JimmyC7834
27735eeedb fixed code 2021-06-24 13:45:38 +08:00
Dean Herbert
63ab40ec24 Fix potential deadlocking behaviour (and convert ResetEvent to Semaphore) 2021-06-24 14:37:26 +09:00
Nathan Alo
812624a502 use .Equals() instead 2021-06-24 10:45:20 +08:00
Nathan Alo
564c72bf74 compare directly instead of comparing IDs 2021-06-24 10:10:57 +08:00
Nathan Alo
73590bfca1 Return an empty array when the sender is from system. 2021-06-24 07:20:31 +08:00
aitani9
c8022126dc Add logo sound case for transitioning to song select 2021-06-23 13:39:12 -07:00
Dan Balasescu
3a96f9bd14
Merge pull request #13637 from Game4all/localise-beatmap-listing-ruleset-filter 
Localize beatmap listing ruleset filter `Any` button
 2021-06-24 00:57:48 +09:00
Lucas A
263370e1ff Localize ruleset filter any filter button. 2021-06-23 16:42:14 +02:00
Dean Herbert
b6555c10f8
Merge pull request #13630 from smoogipoo/more-collection-safety 
Make collection database even more safe
 2021-06-23 22:07:52 +09:00
smoogipoo
8a2026e305 Schedule callback instead 2021-06-23 21:26:52 +09:00
smoogipoo
c85edd2b55 Merge branch 'master' into fix-realm-state-change-crashes 2021-06-23 21:20:53 +09:00
Dean Herbert
01a5d998a5 Update framework 2021-06-23 20:29:02 +09:00
Dean Herbert
d148656108 Update in line with framework event structural changes (and add unbind) 2021-06-23 18:08:34 +09:00
Dean Herbert
dcba7bf779 Fix import flow potentially hitting foreign key constraint 2021-06-23 17:34:56 +09:00
Dan Balasescu
b6793aadb4
Merge pull request #13628 from ekrctb/add-IApplicableToBeatmapProcessor 
Add `IApplicableToBeatmapProcessor` mod interface
 2021-06-23 17:08:40 +09:00
Salman Ahmed
d484469906 Handle case where SkinManager sources aren't part of AllSources 
In tests.
 2021-06-23 10:44:23 +03:00
Dean Herbert
28f4c56cd6 Fix minor typo in comment 2021-06-23 16:30:28 +09:00
smoogipoo
e7981eae9b Safeguard load procedure a bit more 2021-06-23 16:14:08 +09:00
Salman Ahmed
53fa229880 Add ruleset resources skin before SkinManager.DefaultSkin 2021-06-23 10:09:25 +03:00
Salman Ahmed
2e6800f586 Enable NRT in RulesetResourcesSkin 2021-06-23 09:52:00 +03:00
Salman Ahmed
0db06c727b Dispose resource stores on finalizer 2021-06-23 09:41:45 +03:00
smoogipoo
0510282dcb Add missing ctor 2021-06-23 15:10:03 +09:00
smoogipoo
5828606c13 Prefer using the backup file if it exists 2021-06-23 15:09:42 +09:00
Dean Herbert
e4d17bd757 Remove commented code 
This will be reverted in a future change, no need to keep it around.
 2021-06-23 15:06:29 +09:00
smoogipoo
c9a203cc11 Move collections db in-place 2021-06-23 15:03:34 +09:00
Dean Herbert
151dfdfb79
Merge pull request #13627 from Joehuu/fix-multiplayer-exit-logic 
Fix multiplayer leave dialog not working on all exit operations
 2021-06-23 14:56:57 +09:00
ekrctb
e1b2c63e09 Add IApplicableToBeatmapProcessor mod interface 2021-06-23 14:46:30 +09:00
Dean Herbert
cb6fbd88c7 Merge branch 'master' into mod-settings-dropdown-height 2021-06-23 14:14:17 +09:00
Dean Herbert
a1da9c5ee3
Merge pull request #13626 from Henry-YSLin/IHasSeed-interface 
Extract `SeedSettingsControl` to `IHasSeed` interface
 2021-06-23 14:10:34 +09:00
Dean Herbert
bae42a8908 Add inline comment explaining why the height is set lower 2021-06-23 14:07:37 +09:00
Dean Herbert
f62b4f2d24
Merge pull request #13617 from ekrctb/catch-editor 
Add "placeholder" (pre-MVP) implementation of osu!catch editor
 2021-06-23 14:00:34 +09:00
Dean Herbert
54084f8a9c Move SeedSettingsControl to own file 2021-06-23 13:40:05 +09:00
smoogipoo
6fd020d91d Remove unnecessary public accessibility 
All interface members are implicitly public.
 2021-06-23 12:00:57 +09:00
Joseph Madamba
49000b9501 Add multiplayer leave navigation tests 2021-06-22 19:30:40 -07:00
ekrctb
0b351c9922 Fix "possible NRE" inspection 2021-06-23 10:57:04 +09:00
ekrctb
eec4457473 Add [CanBeNull] to methods returning null by default 2021-06-23 09:40:07 +09:00
aitani9
59928a7d91 Decrease the max height of dropdown menus in mod settings 2021-06-22 13:32:45 -07:00
aitani9
9cb9ef5c56 Refactor the menu's max height to be a property 2021-06-22 13:31:41 -07:00
Salman Ahmed
ee84364d7c Resolve conflict issues 2021-06-22 20:38:24 +03:00
Salman Ahmed
896c1dc202 Merge branch 'master' into ruleset-resources-skin 2021-06-22 20:36:49 +03:00
Dean Herbert
f03c2bab48 Update event name in line with framework changes 2021-06-22 22:45:13 +09:00
Dan Balasescu
bdc440f11c
Merge pull request #13605 from aitani9/overlay-item-sound-edge 
Empty the space between `OverlayStreamItem`s
 2021-06-22 22:13:39 +09:00
Dean Herbert
4cb9c6a842
Merge pull request #13423 from frenzibyte/transformers-per-skin 
Refactor ruleset skin transforming logic to be per-`ISkin` rather than one `ISkinSource`
 2021-06-22 21:24:56 +09:00
Dan Balasescu
e39ce6cc67
Merge pull request #13610 from gagahpangeran/markdown-heading-font-size 
Change osu markdown heading to use actual font size
 2021-06-22 20:58:48 +09:00
Dan Balasescu
c436f9f0fa
Merge pull request #13615 from peppy/mod-utils-check-duplicate-mods 
Ensure duplicate mods cannot be defined
 2021-06-22 20:28:40 +09:00
Dan Balasescu
883b3e56f4
Merge branch 'master' into markdown-heading-font-size 2021-06-22 20:21:25 +09:00
Salman Ahmed
2b1f461d79 Pass empty resource store for FallbackShaderManager base constructor 2021-06-22 12:36:45 +03:00
Dean Herbert
b9a9174168 Remove live realm bindings for now 2021-06-22 18:26:42 +09:00
Dean Herbert
a4b66bec2e Ensure realm contexts are flushed when update thread changes native thread 2021-06-22 18:18:25 +09:00
Salman Ahmed
71e2815e7e
Update and improve code documentation 
Co-authored-by: Dean Herbert <pe@ppy.sh>
 2021-06-22 12:05:17 +03:00
Salman Ahmed
31cbb36a64 Implement FindProvider and AllSources properly on all test ISkinSources 2021-06-22 12:03:14 +03:00
Dean Herbert
804a0433cc Update framework 2021-06-22 17:59:55 +09:00
Dean Herbert
d1aac743ad Merge branch 'master' into ruleset-shaders 2021-06-22 17:59:51 +09:00
Dean Herbert
b8126e3ca8 Update framework 2021-06-22 17:59:24 +09:00
Dean Herbert
c4fde635c6 Ensure duplicate mods cannot be defined 2021-06-22 17:41:20 +09:00
ekrctb
a9c7830252 Fix NRE when hit object blueprint is not implemented 2021-06-22 17:20:13 +09:00
Salman Ahmed
c1284940e1 Fix potentially providing the same skin instance twice in AllSources 2021-06-22 10:49:37 +03:00
Salman Ahmed
d0cdc07b11 Reuse AllSources when looking up on FindProvider 2021-06-22 10:49:21 +03:00
Salman Ahmed
b12adc6073 Remove all test skinning changes in favour of the ISkinSource.AllSources path 2021-06-22 10:48:03 +03:00
Dean Herbert
1fff9a93b9 Merge branch 'master' into skin-editor-closest-anchor 2021-06-22 16:41:51 +09:00
Dean Herbert
4b3165084d Move scoped functionality into local function 2021-06-22 16:40:56 +09:00
Dean Herbert
ffac32a848 Reword xmldoc 2021-06-22 16:40:48 +09:00
Dean Herbert
14bdcef26b Add missing newline 2021-06-22 16:20:09 +09:00
Dean Herbert
0ad189e357 Expose skin sources via ISkinSource and revert to consuming based on hierarchy 2021-06-22 16:19:55 +09:00
Dean Herbert
1b0aadcc6f Merge branch 'master' into transformers-per-skin 2021-06-22 16:03:15 +09:00
Henry Lin
fc224c53f4 Remove extra usings 2021-06-22 14:49:37 +08:00
Henry Lin
3745101f32 Extract seed setting control to IHasSeed 2021-06-22 14:43:41 +08:00
JimmyC7834
0d17fb4259 fixed code 2021-06-22 13:53:21 +08:00
Gagah Pangeran Rosfatiputra
5c3129f1a2
add font size in HeadingTextFlowContainer 2021-06-22 12:24:56 +07:00
Gagah Pangeran Rosfatiputra
f89c154e18
change GetFontSizeByLevel to return actual font size 2021-06-22 12:24:25 +07:00
Joseph Madamba
2cdbada87e Fix screen breadcrumb control updating on click 2021-06-21 21:10:24 -07:00
Joseph Madamba
db86098062 Fix dialog not closing after spamming OS window close 2021-06-21 20:23:11 -07:00
Joseph Madamba
9bcd1e6922 Move confirm dialog logic to OnExiting 2021-06-21 20:22:18 -07:00
Joseph Madamba
00b4cf1829 Handle sub screen OnExiting logic on main screen 2021-06-21 20:20:43 -07:00
Salman Ahmed
ec040ff3fc Fix leak due to not properly unbinding SourceChanged event on disposal 2021-06-22 05:05:41 +03:00
Salman Ahmed
caa90bccc6 Fix default skin potentially added twice in RulesetSkinProvidingContainer 2021-06-22 03:45:43 +03:00
Salman Ahmed
627c857da8 Propagate SourceChanged events from SkinManager down in the ruleset skin container 2021-06-22 03:45:24 +03:00
Salman Ahmed
9e5bb146d3 Add xmldoc to SkinManager 
The `<summary>` part comes from `BeatmapManager`, which I believe works correctly here as well, as this does handle the "storage and retrieval" of skins.
 2021-06-22 03:07:31 +03:00
Salman Ahmed
97dbc7f20e Add back SkinManager.DefaultSkin to the ruleset skin lookup sources 2021-06-22 02:54:34 +03:00
Salman Ahmed
d53a43cf3c Isolate RulesetSkinProvidingContainer from falling back to parent skin sources 
For simplicity of lookup order, and which sources are used for the lookup.
 2021-06-22 02:53:22 +03:00
Salman Ahmed
ebe0d43790 Add ability to disallow falling back to parent skins 2021-06-22 02:51:17 +03:00
aitani9
36e459e97e Use margin instead of padding 2021-06-21 13:42:15 -07:00
JimmyC7834
b162da5ee0 minor code change 2021-06-21 15:47:47 +08:00
JimmyC7834
22cc1e1452 fixed code style base on code analysis 2021-06-21 15:31:47 +08:00
JimmyC7834
3367456304 fixed SupporterRequiredDrawable style 2021-06-21 14:30:54 +08:00
JimmyC7834
044c2aa99d Merge branch 'master' of https://github.com/JimmyC7834/osu into supporter-only-filter-content 2021-06-21 14:27:54 +08:00
JimmyC7834
0707642b76 fixed SupporterRequiredDrawable 2021-06-21 14:25:20 +08:00
Joseph Madamba
6fda5e569a Fix beatmap discussion links wrongly leading to beatmap page 2021-06-20 21:37:00 -07:00
Salman Ahmed
11b78ad849 Make TestPlayer skin assigning logic not flaky 2021-06-21 06:46:00 +03:00
Salman Ahmed
5cfd0e3223 Remove implicit LegacySkin check and refactor anything using it 2021-06-21 04:16:58 +03:00
Salman Ahmed
67f0344c0c Add support for loading shaders from ruleset resources 2021-06-20 23:07:44 +03:00
JimmyC7834
d0a8b74823 fixed filter text order 2021-06-20 21:28:57 +08:00
JimmyC7834
996503eb2d fixed filter text display, added visual tests 2021-06-20 21:23:54 +08:00
Dean Herbert
c624ec79b1
Merge pull request #13575 from bdach/realm-on-xamarin 
Add direct references to Realm from Xamarin projects
 2021-06-20 21:51:25 +09:00
JimmyC7834
e7aeba8d03 added more visual tests 2021-06-20 18:28:43 +08:00
JimmyC7834
42fdfbb9a1 added visual tests 2021-06-20 17:17:07 +08:00
smoogipoo
32bd3107e1 Remove high performance GC setting 2021-06-20 17:07:41 +09:00
Bartłomiej Dach
1f383532f2 Move FodyWeavers configuration to solution root 2021-06-20 10:05:49 +02:00
Bartłomiej Dach
46b9fd9ac8 Remove and ignore FodyWeavers schema files 2021-06-20 10:05:42 +02:00
JimmyC7834
27da3dc75a added supporter-only-filter content 2021-06-19 20:54:24 +08:00
Dean Herbert
b6e07ff59c
Merge pull request #13572 from bdach/fix-unsupported-locales 
Fix game crashes due to attempting localisation load for unsupported locales
 2021-06-19 17:09:39 +09:00
Dean Herbert
afcc3e14f4
m 2021-06-19 16:16:29 +09:00
Bartłomiej Dach
b47774b55a Remove Tagalog language for now 
Rationale given in inline comment.
 2021-06-19 08:07:37 +02:00
Bartłomiej Dach
76db87f9cb Try-catch around localisation store registration 
Some platforms (android, older windows versions) will throw exceptions
at runtime when an unsupported `CultureInfo` is attempted to be
instantiated, leading to nasty crashes. Add a preventative try-catch
registration to prevent the crash, and log the errors for visibility.
 2021-06-19 08:02:30 +02:00
Dean Herbert
3f336d88ec
Merge pull request #11461 from peppy/realm-key-binding-store 
Add initial realm database implementation with KeyBindingStore migration
 2021-06-19 02:49:41 +09:00
Dean Herbert
89c27dcb10
Merge pull request #13517 from ekrctb/initial-entry 
Allow setting `Entry` of `PoolableDrawableWithLifetime` (including `DrawableHitObject`)
 2021-06-19 00:03:41 +09:00
Dean Herbert
fa838ba253
Merge pull request #13528 from gagahpangeran/last-lang 
Add remaining non-rtl language
 2021-06-19 00:00:33 +09:00
smoogipoo
acb47b1606 Merge branch 'master' into last-lang 2021-06-18 23:30:59 +09:00
Dean Herbert
b1fd812805
Merge branch 'master' into more-ui-sfx 2021-06-18 23:24:19 +09:00
Dean Herbert
36f0769f83
Merge branch 'master' into inter-font 2021-06-18 22:38:20 +09:00
Dean Herbert
1ec03bf6fa Update resources 2021-06-18 22:25:24 +09:00
Dean Herbert
1f6b4b10ab Update resources 2021-06-18 22:16:15 +09:00
Dean Herbert
390abccb4b Add workaround for dropdowns playing close animation on first display 2021-06-18 22:08:59 +09:00
Jamie Taylor
5ce52b2669
fix ModButton duplicate click sound 2021-06-18 21:41:07 +09:00
Jamie Taylor
6e4fc26e16
replace 'songselect' hover/click sounds with 'button' ones for now 2021-06-18 21:03:46 +09:00
Jamie Taylor
953683044f
fix checkbox sounds not being used for certain checkboxes 2021-06-18 21:00:08 +09:00
Dean Herbert
5897475708
Merge pull request #13552 from peppy/fix-ruleset-dll-rename 
Fix loading a ruleset with an updated internal name causing a potential startup crash
 2021-06-18 20:18:54 +09:00
Dean Herbert
2dadc9d686 Remove unused using statement 2021-06-18 19:39:01 +09:00
Dan Balasescu
846647b5c5
Merge pull request #13549 from peppy/storyboard-outro-logic-refactor 
Separate out storyboard outro logic as much as possible from score completion flow
 2021-06-18 19:38:00 +09:00
Dean Herbert
78c5ccda60 Fix renaming a ruleset DLL causing a startup crash 2021-06-18 19:32:40 +09:00
smoogipoo
42c5a962fb Add xmldoc remark 2021-06-18 19:27:10 +09:00
smoogipoo
36d51d5117 Don't set entry immediately 2021-06-18 19:23:37 +09:00
smoogipoo
36d2199a02 Add exception on Apply() while loading 2021-06-18 19:20:57 +09:00
Jamie Taylor
d462394635
add sound to dropdowns 2021-06-18 19:16:28 +09:00
Jamie Taylor
4feb7c848f
add sound to tab controls 2021-06-18 19:16:00 +09:00
Dan Balasescu
e0f4c792b8
Merge pull request #13546 from peppy/mods-can-specify-self-in-incompatible-list 
Allow mods to specify incompatibility types which they implement themselves
 2021-06-18 19:07:38 +09:00
Dean Herbert
c751e087ca
Merge branch 'master' into skin-editor-closest-anchor 2021-06-18 18:54:07 +09:00
Dean Herbert
36b5414b1d Update comment to hopefully explain a weird conditional better 2021-06-18 17:46:01 +09:00
Dean Herbert
d5a1524eb0 Add missing rulesetID check for global action matching 2021-06-18 17:12:01 +09:00
Dean Herbert
d06e52505a Fix thread safety of KeyBindingStore.GetReadableKeyCombinationsFor 2021-06-18 17:11:39 +09:00
Dean Herbert
c369beeaaa Merge branch 'master' into realm-key-binding-store 2021-06-18 16:52:35 +09:00
Dean Herbert
0bc68a7018 Move xmldoc to method 2021-06-18 16:50:31 +09:00
Dean Herbert
19507e107e Reorder methods to make more sense 2021-06-18 16:46:40 +09:00
Dean Herbert
a7f40dc6d4 Merge branch 'remove-synchronous-prepare-score-method' into storyboard-outro-logic-refactor 2021-06-18 16:45:01 +09:00
Dean Herbert
45122594e5 Remove the synchronous version of PrepareScoreForResults 
Replaces all existing usages with the `async` version.
 2021-06-18 16:24:08 +09:00
Dean Herbert
f3426e38b4 Add note about delay parameter 2021-06-18 16:18:20 +09:00
Dean Herbert
3819a1f03b Remove exit override behaviour 
I don't actually know under what scenario this could have been hit, and
actually caused expected behaviour. Consider that in the scenario I
describe in the comment (which I added yesterday), the user is
requesting a pause or exit which would be "cancelled showing the results
instead". But in such a scenario, `PerformExit` would first be run,
which cancels the `resultsDisplayDelegate` in the first place.

The only special case would be pressing the close button on the window
decoration? Which I don't think should be a special case in the first
place, so I'm just going to remove this for the time being to keep
things simple.
 2021-06-18 16:12:35 +09:00
Dean Herbert
06d1bd971c Default DrawableStoryboard to a completed state to avoid state change on empty storyboards 2021-06-18 16:08:49 +09:00
Dean Herbert
7ef8eac773 Remove unnecessary (and no longer correct) exception 2021-06-18 16:08:31 +09:00
Jamie Taylor
752d0a9f0b
add sound to scroll-to-top button 2021-06-18 16:08:14 +09:00
Dean Herbert
2bf855fcca Move all storyboard outro skip logic out of updateCompletionState 
This method should only be called to trigger the score completion
portion of player progression. The storyboard skip/end logic is now
handled separately in `progressToResults`.
 2021-06-18 15:50:43 +09:00
smoogipoo
5cf2ac78fc Adjust font namespaces 2021-06-18 15:40:35 +09:00
Dan Balasescu
2cd72a92e8
Merge pull request #13499 from ekrctb/fix-mania-editor-crash 
Rewrite mania selection blueprint to use only `HitObject` (no `DrawableHitObject`) for layout
 2021-06-18 15:10:28 +09:00
Dan Balasescu
cdc1c60fab
Merge branch 'master' into fix-mania-editor-crash 2021-06-18 13:49:25 +09:00
Dean Herbert
4de27429bc Change ModSelectOverlay to never deselect the user triggered selection 2021-06-18 13:17:55 +09:00
Dean Herbert
5933e0d2d9 Change CheckCompatibleSet to never deselect the current candidat when checking incompatibility 2021-06-18 13:17:32 +09:00
smoogipoo
97cd1217a4 Move IApplicableToDrawableHitObjects to its own file 2021-06-18 13:06:13 +09:00
Bartłomiej Dach
f282326f9a Move score preparations back below ShowResults check 2021-06-17 19:04:52 +02:00
Bartłomiej Dach
3a1444e75d Fix malformed xmldoc tag 
Oops. Made a typo in the PR suggestion.
 2021-06-17 19:02:56 +02:00
Dean Herbert
9facfe8964
Apply suggestions from code review 
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
 2021-06-18 01:07:54 +09:00
Dean Herbert
e0a3696145
Merge branch 'master' into player-completion-refactoring 2021-06-17 23:51:42 +09:00
Bartłomiej Dach
aae2923e14 Merge branch 'master' into player-pause-exit-results-flow-refactoring 2021-06-17 16:05:09 +02:00
Bartłomiej Dach
10b0d066be Reword comments slightly 2021-06-17 16:04:58 +02:00
Bartłomiej Dach
561dbea9e1 Use xmldoc-specific syntax for nicer formatting 2021-06-17 15:26:50 +02:00
Dan Balasescu
6cec1145e3
Merge pull request #13523 from ekrctb/applicable-to-dho 
Reduce boilerplate of `IApplicableToDrawableHitObjects` by taking a single DHO instead of an enumerable
 2021-06-17 19:59:06 +09:00
Dan Balasescu
77a0e9145d
Merge pull request #13539 from peppy/improve-updateable-avatar-tooltip-handling 
Fix edges of participant tiles showing incorrect tooltip
 2021-06-17 19:14:40 +09:00
Dean Herbert
d03c6da60c Refactor and redocument updateCompletionState() and surrounding methods 2021-06-17 19:13:53 +09:00
Dean Herbert
246ab41cc6 Remove special casing for user exit during storyboard outro 2021-06-17 18:11:15 +09:00
Dean Herbert
7cbebe6d11 Rewrite xmldoc and inline comments for PerformExit 2021-06-17 18:10:59 +09:00
Dan Balasescu
79af80833f
Merge pull request #13537 from peppy/fix-author-info 
Improve code quality of `AuthorInfo`
 2021-06-17 16:34:45 +09:00
Dean Herbert
a0e5301c9f Update usages of showGuestOnNull 2021-06-17 16:33:43 +09:00
Dean Herbert
808b2baa41 Consume new behaviour to fix UserTile discrepancy 
Closes https://github.com/ppy/osu/issues/13522.
 2021-06-17 16:31:12 +09:00
Dean Herbert
d9cc1c227b Allow UpdateableAvatar to handle displaying username as tooltip 2021-06-17 16:31:12 +09:00
Dean Herbert
9495f87f04 Remove redundant NotNull attributes in nullable classes 2021-06-17 16:07:32 +09:00
Dean Herbert
8da0431fa0 Improve code quality of AuthorInfo 2021-06-17 16:05:50 +09:00
Dean Herbert
8e45f26617
Merge branch 'master' into applicable-to-dho 2021-06-17 15:23:56 +09:00
ekrctb
e7954ecb60 Use property instead of backing field consistently 2021-06-17 10:31:20 +09:00
ekrctb
9dcd0bf311 Remove IPlayfieldProvider by caching Playfield 2021-06-17 10:15:24 +09:00
Salman Ahmed
780388d174 Fix incorrect return value 2021-06-17 03:48:29 +03:00
Bartłomiej Dach
418dbf3f3e
Merge branch 'master' into fix-mania-editor-crash 2021-06-16 18:26:33 +02:00
Bartłomiej Dach
191f47f5ee
Merge branch 'master' into beatmap-listing-enum-localisation 2021-06-16 17:44:16 +02:00
Salman Ahmed
74ad6f9117 Remove default skin from the ruleset skin sources 
That one doesn't need any changes to it, can be fetched from the `SkinManager` instead.
 2021-06-16 17:24:31 +03:00
Salman Ahmed
52ddf08532 Consider not adding legacy skin transformers to non-legacy skins 2021-06-16 17:24:16 +03:00
Dean Herbert
a8b65d8417
Merge pull request #13430 from pavlukivan/taiko-hd-mod 
Add osu!taiko "Hidden" mod
 2021-06-16 23:24:04 +09:00
Gagah Pangeran Rosfatiputra
0e9ca3df3c
add remaining non-rtl language 2021-06-16 21:14:48 +07:00
Gagah Pangeran Rosfatiputra
4b926791b5
add inter font 2021-06-16 21:13:01 +07:00
Salman Ahmed
5ebf570ec4 Revert GetRulesetTransformedSkin accessibility change 
This reverts commit 521077b714.

Forgot to do it when I made this `protected`, but subclasses in test scenes require this.
 2021-06-16 16:49:38 +03:00
ekrctb
b6a9fa9999 Merge branch 'master' into applicable-to-dho 2021-06-16 22:04:10 +09:00
Dean Herbert
bacb916c03
Merge pull request #13524 from smoogipoo/fix-hud-test-failure 
Fix intermittent HUD test failure
 2021-06-16 21:53:58 +09:00
smoogipoo
19f0e3d695 Add HighPerformanceSession 2021-06-16 20:53:48 +09:00
Bartłomiej Dach
a295421b64 Use language-specific lookup key for Other filter 2021-06-16 13:27:02 +02:00
Bartłomiej Dach
69a474e4ab Merge branch 'master' into beatmap-listing-enum-localisation 2021-06-16 13:16:58 +02:00
Dan Balasescu
382de42438
Merge pull request #13498 from ekrctb/refactor-scrolling-hoc-2 
Change coordinate used in newly added `ScrollingHitObjectContainer` methods
 2021-06-16 20:02:32 +09:00
smoogipoo
2155a4da0a Fix intermittent HUD test failure 2021-06-16 19:52:58 +09:00
Dan Balasescu
6613301588
Merge branch 'master' into refactor-scrolling-hoc-2 2021-06-16 19:20:11 +09:00
smoogipoo
37babbde6a Simplify score filter row 2021-06-16 19:09:11 +09:00
Bartłomiej Dach
dc2e3ff89e Fix wrong language codes 
Confused them with the flags from the web-side source used.

Tagalog (`tl`) still has no discernible effect, but that's because there
are actually no localisation files in `osu-resources` for that language.
Leave it be for now, as web has that entry, so it might mean that
translations might be coming at some point in the future.
 2021-06-16 12:01:58 +02:00
ekrctb
c59a3ce83f Obsolete plural IApplicableToDrawableHitObjects 2021-06-16 18:52:16 +09:00
ekrctb
af80418ee8 Implement IApplicableToDrawableHitObject for mods 
A breaking change in `ModWithVisibilityAdjustment` if the method was overriden.
 2021-06-16 18:52:01 +09:00
Dean Herbert
379b84ba22 Update framework 2021-06-16 18:51:17 +09:00
Dean Herbert
f4fb2e127d
Merge pull request #13518 from smoogipoo/sort-by-localisation 
Localise "sort by" text in overlays
 2021-06-16 18:50:53 +09:00
Dan Balasescu
537cbd1214
Merge pull request #13520 from bdach/add-more-language-enum-values 
Add more languages to settings dropdown
 2021-06-16 18:49:42 +09:00
ekrctb
67d8e0059f Use singular IApplicableToDrawableHitObject for consumers 2021-06-16 18:47:04 +09:00
ekrctb
e69bb67afe Add IApplicableToDrawableHitObject that is taking a single DHO 
Less cumbersome to implement than old version taking an enumerable. The implementation was always using `foreach` for the enumerable.
The new interface is not used yet.
 2021-06-16 18:42:28 +09:00
Bartłomiej Dach
cc5145a131 Fix languages with a sub-language part not working properly 2021-06-16 11:10:03 +02:00
ekrctb
2b0e6b6b51 Don't invoke "completed" action for test scene virtual track 
`MusicController` tries to play the next music when a track is completed.
In test scenes, we want to keep the virtual track, not random songs.
 2021-06-16 17:44:21 +09:00
Dean Herbert
521077b714 Make getRulesetTransformedSkin private 2021-06-16 17:44:18 +09:00
Bartłomiej Dach
d298e95df7 Limit maximum height of settings enum dropdowns 2021-06-16 10:25:50 +02:00
Bartłomiej Dach
64bb1f381b Add more languages to settings dropdown 2021-06-16 10:25:30 +02:00
Dean Herbert
4b45d8318e
Merge branch 'master' into transformers-per-skin 2021-06-16 16:37:28 +09:00
Dean Herbert
5944c45f55 Specify types explicitly and don't handle non-nullable values with fallbacks 2021-06-16 16:24:30 +09:00
smoogipoo
fafd936c93 Localise "sort by" string in overlays 2021-06-16 16:21:41 +09:00
smoogipoo
6d6604e2f0 Fix incorrect indentation 
I used this for the o!f example.
 2021-06-16 16:19:47 +09:00
Dean Herbert
b24730efdb
Merge pull request #13512 from smoogipoo/add-localisation-example 
Localise parts of the beatmap listing overlay
 2021-06-16 16:03:40 +09:00
ekrctb
117e94bc94 Allow setting Entry of PoolableDrawableWithLifetime 
It is more convenient than using the constructor because the only limited kind of expression is allowed in a base constructor call.
Also, the object initializer syntax can be used.
 2021-06-16 16:00:08 +09:00
smoogipoo
3c3ff8be0d Localise beatmap listing enum values 2021-06-16 15:58:07 +09:00
Dean Herbert
cb80577922
Merge pull request #13509 from bdach/fix-seasonal-backgrounds 
Fix seasonal backgrounds not cycling
 2021-06-16 15:26:46 +09:00
Dean Herbert
68fa7d68cc
Merge pull request #13511 from smoogipoo/fix-possible-nullref-2 
Fix possible nullref in difficulty recommender
 2021-06-16 15:20:45 +09:00
Dean Herbert
f802679d38
Merge pull request #13497 from smoogipoo/fix-present-score 
Make PresentScore() use replay hash as fallback
 2021-06-16 15:18:01 +09:00
smoogipoo
4c5268694e Localise some of the BeatmapListingOverlay 2021-06-16 13:46:13 +09:00
smoogipoo
fa00d07107 Upgrade osu-resources 2021-06-16 13:26:36 +09:00
Dean Herbert
66efc3c4de
Merge branch 'master' into realm-key-binding-store 2021-06-16 13:23:13 +09:00
smoogipoo
a5261f0cb3 Add difficulty recommender instantly 2021-06-16 11:48:49 +09:00
smoogipoo
6be41e497a Fix possible nullref in difficulty recommender 2021-06-16 11:27:38 +09:00
emu1337
be68950c30 refactoring 2021-06-16 03:34:46 +02:00
Bartłomiej Dach
022b1a28d5 Add missing equality implementation for seasonal backgrounds 
The equality operator is used to determine whether the next background
in the cycle should be loaded, to avoid pointless loads of the same
background several times (see #13362 and #13393). Its omission in the
latter pull caused seasonal backgrounds to no longer cycle.

Closes #13508.
 2021-06-15 23:21:48 +02:00
Dean Herbert
9d168b19c9 Switch to non-beta release 2021-06-16 02:15:25 +09:00
Dean Herbert
acc06ca398 Merge branch 'master' into realm-key-binding-store 2021-06-16 02:14:58 +09:00
Dan Balasescu
e9d4ee3c87
Merge branch 'master' into enhance-mod-settings-text-box-visibility 2021-06-15 16:09:55 +09:00
ekrctb
ef96ceb4ab Introduce IPlayfieldProvider 2021-06-15 14:43:04 +09:00
smoogipoo
579a4aa9c8 Remove comment 2021-06-15 14:10:09 +09:00
smoogipoo
eb4c093371 Use hash as fallback 2021-06-15 14:06:17 +09:00
ekrctb
bbf0022689 Use natural anchor for TimeAtPosition and PositionAtTime 
The natural anchor is the end of the scrolling direction (e.g. Bottom for Down scrolling).
 2021-06-15 13:15:20 +09:00
smoogipoo
f6c6eea6dc Make PresentScore() only consider replay hash 2021-06-15 11:16:35 +09:00
Bartłomiej Dach
cb1e2e3d97 Improve xmldoc 2021-06-14 21:54:55 +02:00
Dan Balasescu
84ec378be1
Merge branch 'master' into refactor-scrolling-hoc-1 2021-06-14 20:42:38 +09:00
Dan Balasescu
980afd6a04
Merge branch 'master' into fix-song-select-leaderboard-events 2021-06-14 20:03:36 +09:00
Dan Balasescu
15a20ed9d6
Merge pull request #13486 from peppy/revert-nested-platform-container 
Revert "Add nested `PlatformActionContainer` to allow testing of platform actions in visual tests"
 2021-06-14 19:53:14 +09:00
Dean Herbert
75b5b50aee
Merge pull request #13490 from smoogipoo/arbitrary-localisation-assembly 
Match any arbitrary assembly for localisations
 2021-06-14 19:05:22 +09:00
Dean Herbert
13d0eaa9fe Update framework 2021-06-14 19:03:31 +09:00
smoogipoo
b327baa4de Match any arbitrary assembly for localisations 2021-06-14 17:47:31 +09:00
smoogipoo
aa5dae84b2 Make all localisation class strings verbatim 2021-06-14 16:51:17 +09:00
Dean Herbert
83402a70db Fix potential null ref when no beatmap is selected 2021-06-14 15:06:24 +09:00
Dean Herbert
f8b09b7c81 Avoid refresh if score is not related to current display 2021-06-14 14:28:14 +09:00
Dean Herbert
fc442713bb Debounce schedule at base class 2021-06-14 14:26:40 +09:00
Dean Herbert
8dd48d48f6 Add support for song select leaderboard to handle newly imported scores 2021-06-14 14:20:23 +09:00
Dean Herbert
564682270a Revert "Add nested PlatformActionContainer to allow testing of platform actions in visual tests" 
This reverts commit be91203c92.
 2021-06-14 13:18:52 +09:00
ekrctb
660bf50dc7 Clarify multiple coordinate systems 
- Fix wrong position is set for DHOs for down/right scrolling direction.
 2021-06-14 13:13:27 +09:00
ekrctb
09f1cbde7e Fix TimeAtPosition doc comment 2021-06-14 13:13:27 +09:00
ekrctb
fdb09ef4d7 Simplify flipPositionIfRequired using scrollLength 2021-06-14 13:13:27 +09:00
ekrctb
8cf4454780 Use Direction enum instead of int 
The property is named `scrollingAxis` to distinguish from `direction`, which is of `ScrollingDirection` type (unfortunate name crash).
 2021-06-14 13:13:27 +09:00
Dean Herbert
17347401cf Remove unused RankingType enum 
We have `BeatmapLeaderboardScope` instead.
 2021-06-14 11:27:46 +09:00
Pasi4K5
ef9cb2c958 Rename nested classes 2021-06-12 18:37:31 +02:00
Pasi4K5
b79d57b68c Move OsuSettingsNumberBox into SettingsNumberBox 2021-06-12 17:57:40 +02:00
Pasi4K5
c728f673d6 Rename classes 2021-06-12 17:37:01 +02:00
Pasi4K5
29f3880415 Move classes into SettingsTextBox 2021-06-12 17:34:02 +02:00
Pasi4K5
bb661abfa6 Clean up OsuModSettingsTextBox 2021-06-12 17:25:22 +02:00
Pasi4K5
fe39a47797 Add OsuModSettingsTextBox and OsuModSettingsNumberBox 2021-06-12 00:34:53 +02:00
Bartłomiej Dach
902bb84ca8
Merge branch 'master' into fix-wave-overlay-sound-on-switch 2021-06-11 22:05:08 +02:00
Dean Herbert
f773ea475d Update framework 2021-06-12 01:37:13 +09:00
Dean Herbert
c2759121b9
Merge pull request #13454 from nekodex/change-default-hover-click-sample 
Change default HoverSounds/HoverClickSounds samples
 2021-06-12 01:01:35 +09:00
Dean Herbert
121df57dca Fix focused overlays playing their "appear" sound when not necessarily changing state 2021-06-12 00:26:33 +09:00
Dean Herbert
0dbe5dd219 Remove unused using statement 2021-06-12 00:23:18 +09:00
Dean Herbert
d9ea8d64d4 Remove weird local sample logic in ChangelogOverlay 2021-06-12 00:05:49 +09:00
Salman Ahmed
8de0d33c5a Revert "Move collection change bind to LoadComplete" 
This reverts commit d6d87e1975.

Actually that broke things due to the "disableable" instances not added early enough, revert for now.
 2021-06-11 17:59:29 +03:00
Salman Ahmed
b6947c25ec Fix potentially adding the same skin multiple times 2021-06-11 17:55:07 +03:00
Dean Herbert
e098cac1cf Minor code reformatting / moving 2021-06-11 23:49:14 +09:00
Dean Herbert
5887b4a27c Update stand-alone usage of hover/select sounds in DrawableOsuMenuItem 2021-06-11 23:46:42 +09:00
Salman Ahmed
d6d87e1975 Move collection change bind to LoadComplete 
Best practice anyways
 2021-06-11 17:35:33 +03:00
Dean Herbert
97bb3de1c9 Update resources 2021-06-11 23:03:27 +09:00
Dean Herbert
9c6c1dd237 Merge branch 'master' into change-default-hover-click-sample 2021-06-11 23:03:23 +09:00
Salman Ahmed
108a3deb27 Also handle null Ruleset.CreateLegacySkinProvider values 
Let's just go this way for now, maybe it's a better choice to always create transformers and disallow null, but it's too much work and out of scope at this point
 2021-06-11 16:26:54 +03:00
smoogipoo
dca001a72d Upgraed localisation analyser packages 2021-06-11 22:22:47 +09:00
Bartłomiej Dach
550d566bf9 Simplify member access 2021-06-11 14:24:17 +02:00
Bartłomiej Dach
876a357bf2 Add support for animated colour fill in new style legacy health bar 2021-06-11 14:24:17 +02:00
Jamie Taylor
0b95d07390
Change 'default' hover/click samples into 'button' samples and make 'soft' the new 'default' 2021-06-11 20:47:57 +09:00
Dan Balasescu
3389c4830b
Merge branch 'master' into refactor-scrolling-hoc-1 2021-06-11 20:35:19 +09:00
Jamie Taylor
4f80a3b66d
Add fallback-to-default logic for HoverSounds and HoverClickSounds 2021-06-11 20:14:35 +09:00
Robin Avery
0c8851f4b7
Extract drawable.ScreenSpaceDrawQuad to a variable 2021-06-11 07:06:22 -04:00
Dean Herbert
26312bf60a
Merge branch 'master' into chat-mention 2021-06-11 20:03:44 +09:00
Robin Avery
a6774eb5b5
Inline getOriginPositionFromQuad 2021-06-11 06:59:00 -04:00
Robin Avery
c9b4f9eb71
Make getOriginPositionFromQuad local 2021-06-11 06:55:47 -04:00
Robin Avery
1bc8460902
Rename getTieredComponent to getAnchorFromPosition 
Also rename parameter `component` to `xOrY`.
 2021-06-11 06:53:40 -04:00
Robin Avery
6e181a6b63
Rename parameters of getTieredComponent 2021-06-11 06:53:04 -04:00
Robin Avery
a76eaeb52d
Make getTieredComponent local 2021-06-11 06:51:12 -04:00
Jamie Taylor
15d3b4444d
Rename HoverSounds and HoverClickSounds samples 2021-06-11 19:34:54 +09:00
Robin Avery
635300b311
Recalculate closest anchor when origin is changed 2021-06-11 06:28:30 -04:00
smoogipoo
9f163f7f20 Use switch statement to be more explicit about state 2021-06-11 19:23:25 +09:00
Robin Avery
a506f2a776
Revert rename of lambda variables 2021-06-11 06:22:24 -04:00
smoogipoo
0a8daab4f7 Pause master clock when too far ahead 2021-06-11 19:15:53 +09:00
Salman Ahmed
f20146d446 Fix potentially adding null skin sources 2021-06-11 12:58:38 +03:00
Salman Ahmed
e59beffc4e Forward all base transformer lookup methods to Skin 2021-06-11 12:44:25 +03:00
smoogipoo
59eda70c12 Seek to the least most-recent frame instead 2021-06-11 18:40:56 +09:00
Salman Ahmed
9e16359f18 Refactor disallowing in SkinProvidingContainer to become per source 
Fixes `FindProvider` becoming completely broken, because of no way to perform the checks on one skin source.
 2021-06-11 12:29:29 +03:00
ekrctb
af3f253b21 Refactor ScrollingHitObjectContainer and expose more useful methods 2021-06-11 18:28:48 +09:00
smoogipoo
263b8ff097 Wait for full player load 2021-06-11 18:14:37 +09:00
Dean Herbert
8eab7df955 Move BindCollectionChanged out of async load 2021-06-11 17:51:58 +09:00
Salman Ahmed
2e01e61177 Move TODO comment to correct location 2021-06-11 11:46:30 +03:00
Salman Ahmed
8132852753 Add other affectable change action cases 2021-06-11 11:34:22 +03:00
Salman Ahmed
a985e3b8d3
Apply documentation settings for better readability 
Co-authored-by: Dean Herbert <pe@ppy.sh>
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
 2021-06-11 11:25:07 +03:00
Dean Herbert
20759657de Rename configuration variables and refactor lots more 2021-06-11 16:37:31 +09:00
Dean Herbert
3d645608eb Remove nullability of DI dependencies and fix incorrect load order 2021-06-11 16:28:53 +09:00
Dean Herbert
139401a04a Inline and refactor overly verbose MessageNotifier code 2021-06-11 16:27:31 +09:00
smoogipoo
a99cb79738 Seek master clock on multi-spectator start 2021-06-11 16:25:45 +09:00
smoogipoo
75d825c85c Dont control master clock from sync manager 2021-06-11 16:24:52 +09:00
smoogipoo
1c67ef7c91 Make catchup clock support seeking 2021-06-11 16:23:59 +09:00
Bartłomiej Dach
296761ade5 Add missing CurrentSkin null check in DHO disposal 2021-06-11 09:18:58 +02:00
Dean Herbert
c00f9ae4b7 Reword settings text 2021-06-11 16:11:37 +09:00
Dean Herbert
04413f1634
Merge pull request #13444 from peppy/editor-timeline-taiko-hit-colouring 
Show osu!taiko centre/rim colouring in editor timeline
 2021-06-11 15:10:24 +09:00
Dean Herbert
debd359d2e Update xmldoc 2021-06-11 14:50:21 +09:00
Dean Herbert
b9050f91a4 Expose as Skins and consume SkinInfo from instances 2021-06-11 14:49:35 +09:00
Dean Herbert
562cfe8703 Fix filename not matching type rename 2021-06-11 14:34:18 +09:00
Dan Balasescu
97375d9625
Merge pull request #13438 from bdach/more-metadata-fields 
Add remaining metadata fields to editor setup screen
 2021-06-11 14:17:34 +09:00
Dean Herbert
bc3b7233ab Show osu!taiko centre/rim colouring in editor timeline 
Closes #13443.
 2021-06-11 14:17:30 +09:00
Bartłomiej Dach
375f64ffd1 Check empty string more explicitly in IsRomanised() 
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
 2021-06-11 06:38:53 +02:00
Bartłomiej Dach
7fd26ff3b0 Merge branch 'master' into more-metadata-fields 2021-06-11 06:35:51 +02:00
Dean Herbert
38bf04d7ff Give more space for time values to allow for negative offsets 2021-06-11 13:25:09 +09:00
Salman Ahmed
169c98f963 Add skin providing ruleset resources in RulesetSkinProvidingContainer 2021-06-11 00:25:22 +03:00
Bartłomiej Dach
417aaacc53 Add test coverage for romanised data transfer 2021-06-10 22:18:39 +02:00
Bartłomiej Dach
e41a5a0fcd Add romanised author & title fields 2021-06-10 22:17:45 +02:00
ilsubyeega-desu
f65f074131
Add star keyword to FilterQueryParser criteria 2021-06-11 02:46:29 +09:00
Salman Ahmed
2240e2c39c Refrain from attempting to clear skin sources in disposal 
`Drawable.Dispose` is usually in an asynchronous context (async disposals stuff) and therefore this could cause a "collection was modified; enumeration opeartion may not execute" exception.
 2021-06-10 17:23:16 +03:00
smoogipoo
58d71e4aea Remove local "next frame" storage 2021-06-10 22:41:38 +09:00
Salman Ahmed
680791301f Consume new method rather than caching skin sources on top of Player 2021-06-10 16:36:46 +03:00
Salman Ahmed
23d6c366ac Add method for assigning arbitrary skins to player in test scenes 2021-06-10 16:36:46 +03:00
Salman Ahmed
ef2c4fd0d8 Make RulesetSkinProvidingContainer able to be overriden for testing purposes 2021-06-10 16:36:46 +03:00
Salman Ahmed
09a2d008d2 Refrain from attempting to transform null skins 2021-06-10 16:36:45 +03:00
smoogipoo
e18f4cd4ba Combine methods 2021-06-10 22:01:39 +09:00
smoogipoo
5073ede115 Clear existing frames when starting gameplay 2021-06-10 21:38:46 +09:00
smoogipoo
9eecb23fef Only seek to the end on first frame arrival 2021-06-10 21:35:52 +09:00
Bartłomiej Dach
252fe0a6cc Add source and tags text boxes to metadata section 2021-06-10 14:13:59 +02:00
Bartłomiej Dach
5a2e710095 Split common method for metadata textbox creation 2021-06-10 13:55:34 +02:00
Salman Ahmed
5c9c424a0d Switch state case placements for consistency 
Tickled me.
 2021-06-10 13:15:18 +03:00
Salman Ahmed
c3a2f2c2a4 Expose default SkinManager providers for use in RulesetSkinProvidingContainer 2021-06-10 13:07:32 +03:00
Salman Ahmed
59be3588eb Change SkinSources to a bindable list for binding SourceChanged events 2021-06-10 13:07:32 +03:00
Dan Balasescu
35d5632355
Merge pull request #13378 from Syriiin/diffcalc/refactor/auto-properties 
Refactor DifficultyAttributes to use auto properties over public fields
 2021-06-10 18:42:11 +09:00
Dan Balasescu
1505534c7e
Merge pull request #13428 from peppy/fix-pm-tab-avatars 
Fix avatars missing in private message channel tabs / local leaderboards
 2021-06-10 18:34:23 +09:00
Dean Herbert
4a4a561ca4
Merge pull request #13330 from nekodex/results-screen-sfx 
Add sound effects to the results screen
 2021-06-10 18:27:17 +09:00
Salman Ahmed
dde84e5cbd Merge branch 'master' into transformers-per-skin 2021-06-10 11:58:52 +03:00
Salman Ahmed
58cca9da06 Revert "Expose the skin lookup layers of SkinManager to a property" 
This reverts commit 9e652715ce.
 2021-06-10 11:57:28 +03:00
Salman Ahmed
530026b675 Add simple xmldoc to ctors explaining their deal with SkinSources 2021-06-10 11:56:13 +03:00
Salman Ahmed
18edbdd135 Remove mentioning of "layer" in skin providers 
`SkinSources` sounds better.
 2021-06-10 11:55:26 +03:00
Dan Balasescu
3cd7d45b0f
Merge pull request #13401 from peppy/no-unranked-display 
Remove the concept of "unranked" mods
 2021-06-10 17:51:31 +09:00
Dean Herbert
6a40ef581c Fix avatars missing in private message channel tabs / local leaderboards 
Regressed in https://github.com/ppy/osu/pull/12204.

Adding this back in a central location for now, as each of the remaining cases will
need a local solution.
 2021-06-10 17:47:17 +09:00
Dean Herbert
0667354fbd Remove unused resolved skin 2021-06-10 17:30:04 +09:00
Dean Herbert
4f8000a574 Combine cases which return the same value 2021-06-10 17:29:36 +09:00
Dean Herbert
5e80f454ce
Merge branch 'master' into results-screen-sfx 2021-06-10 17:25:35 +09:00
Dan Balasescu
a44fd887ee
Merge branch 'master' into no-unranked-display 2021-06-10 17:09:46 +09:00
Dan Balasescu
479d6d3fc5
Merge branch 'master' into fix-beatmap-skin-disables 2021-06-10 16:37:58 +09:00
Dan Balasescu
4eab717a80
Merge pull request #13408 from peppy/default-skin-fallback 
Add fallback lookup support for `DefaultSkin`
 2021-06-10 16:37:48 +09:00
Joseph Madamba
cc38556f61 Fix background being dimmed forever after toggling statistics in results screen 2021-06-09 23:26:57 -07:00
Dean Herbert
9a3ca09501
Merge pull request #13384 from bdach/fixed-label-width 
Align label widths of editor setup screen controls
 2021-06-10 14:55:49 +09:00
Dean Herbert
b55a4053cf
Merge pull request #13426 from gagahpangeran/wiki-image-title 
Fix wiki image tooltips not showing inside table views
 2021-06-10 14:28:49 +09:00
Dean Herbert
9044a20120 Merge branch 'master' into realm-key-binding-store 2021-06-10 13:58:08 +09:00