h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-13 13:32:54 +08:00
Code Issues Releases Wiki Activity

Use HitSampleInfo.AllAdditions instead of new list

Browse Source
This commit is contained in:
Naxess 2021-06-26 23:48:28 +02:00
parent 5642d321b7
commit 1913084342
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game/Rulesets/Edit/Checks/CheckFewHitsounds.cs
View File

@ -32,8 +32,6 @@ namespace osu.Game.Rulesets.Edit.Checks
private const int warning_threshold_objects = 4;
private const int problem_threshold_objects = 16;
private static readonly string[] hitsound_types = { HitSampleInfo.HIT_CLAP, HitSampleInfo.HIT_WHISTLE, HitSampleInfo.HIT_FINISH };
public CheckMetadata Metadata { get; } = new CheckMetadata(CheckCategory.Audio, "Few or no hitsounds");
public IEnumerable<IssueTemplate> PossibleTemplates => new IssueTemplate[]
@ -111,7 +109,7 @@ namespace osu.Game.Rulesets.Edit.Checks
private bool hasHitsound(HitObject hitObject) => hitObject.Samples.Any(isHitsound);
private bool couldHaveHitsound(HitObject hitObject) => hitObject.Samples.Any(isHitnormal);
private bool isHitsound(HitSampleInfo sample) => hitsound_types.Any(sample.Name.Contains);
private bool isHitsound(HitSampleInfo sample) => HitSampleInfo.AllAdditions.Any(sample.Name.Contains);
private bool isHitnormal(HitSampleInfo sample) => sample.Name.Contains(HitSampleInfo.HIT_NORMAL);
public abstract class IssueTemplateLongPeriod : IssueTemplate