Bartłomiej Dach
58220481db
Rename I{-> Animatable}HitExplosion
2021-03-15 20:39:02 +01:00
Bartłomiej Dach
8b74666cc3
Add support for pooling explosions in taiko
2021-03-14 16:15:33 +01:00
Bartłomiej Dach
f5a80e6269
Merge branch 'master' into taiko-judgement-pooling
2021-03-07 13:35:25 +01:00
Bartłomiej Dach
ad1b86e33a
Change LifetimeEnd
idiom to Expire()
for readability
2021-03-06 18:54:25 +01:00
Bartłomiej Dach
8f4dadb06a
Enable pooling for taiko judgements
2021-03-06 17:38:04 +01:00
Bartłomiej Dach
06e42b4b4c
Fix taiko leaving behind empty judgements on legacy skins
2021-03-06 16:02:20 +01:00
Dan Balasescu
5b6018295d
Merge branch 'master' into diffcalc/skill-mods
2021-03-04 13:06:26 +09:00
Dean Herbert
cd1c1bf534
Centralise cases of performing actions on the current selection
...
By moving this to a central location, we can avoid invoking the
EditorChangeHandler when there is no selection made. This helps
alleviate the issue pointed out in
https://github.com/ppy/osu/issues/11901 , but not fix it completely.
2021-02-26 14:15:13 +09:00
smoogipoo
dff1d80f39
Update HasFlag usages to HasFlagFast
2021-02-25 15:38:56 +09:00
Samuel Cattini-Schultz
66643a97b0
Add a list of mods to Skill class
...
Although this isn't necessary for existing official rulesets and calculators, custom calculators can have use cases for accessing mods in difficulty calculation.
For example, accounting for the effects of visual mods.
2021-02-20 20:37:44 +11:00
Dean Herbert
00574a5288
Use ISample everywhere in Skin GetSample lookup path
2021-02-18 18:32:28 +09:00
smoogipoo
d3f0c0730d
Merge branch 'master' into non-concurrent-sample-playback
2021-02-12 17:22:15 +09:00
Bartłomiej Dach
68c20a2a37
Allow autoplay score generation to access mod list
2021-02-07 18:35:34 +01:00
Firmatorenio
37ef5c7072
rename SliderVelocity to ScrollSpeed
2021-01-29 15:04:55 +06:00
Firmatorenio
449f883be1
add SV multiplier adjustment to TaikoModDifficultyAdjust
2021-01-29 11:48:51 +06:00
Dean Herbert
dee0d3c33a
Merge branch 'master' into apply-sv-to-taiko-hr-ez
2021-01-25 14:28:06 +09:00
smoogipoo
de9d075f94
Initial sample + samplechannel rework
2021-01-19 17:11:40 +09:00
smoogipoo
1b166d809e
Adjust package titles
2021-01-18 11:08:03 +09:00
smoogipoo
ec00aaef90
Add nuget deploys for all rulesets
2021-01-18 10:53:31 +09:00
smoogipoo
9a22df2b88
Fix BPM multiplier not working in all cases
2021-01-12 17:50:22 +09:00
smoogipoo
22a0f99f35
Add failing test
2021-01-12 17:49:21 +09:00
Firmatorenio
669c42a38d
add remarks explaining HR SV multiplier
2020-12-30 20:57:41 +06:00
Firmatorenio
013b9b62a1
add SV multipliers to taiko difficulty mods
2020-12-29 20:22:56 +06:00
Bartłomiej Dach
b24fc1922e
Enable pooling for taiko DHOs
2020-12-20 18:44:47 +01:00
Bartłomiej Dach
5d575d2a9b
Accept proxied content via OnNewDrawableHitObject
...
In the non-pooled case, `OnNewDrawableHitObject()` will be called
automatically on each new DHO via `Playfield.Add(DrawableHitObject)`.
In the pooled case, it will be called via `Playfield`'s implementation
of `GetPooledDrawableRepresentation(HitObject, DrawableHitObject)`.
2020-12-20 18:26:45 +01:00
Bartłomiej Dach
62da4eff37
Route new result callback via playfield
...
Follows route taken by osu! and catch (and required for proper pooling
support).
2020-12-20 18:26:45 +01:00
Bartłomiej Dach
370f56eadb
Make strong hit DHOs public for pool registration
2020-12-20 18:02:34 +01:00
Bartłomiej Dach
0c5333bd58
Adjust top-level hitobjects to support nested pooling
2020-12-20 17:57:19 +01:00
Bartłomiej Dach
ae6dedacaf
Implement nested strong hit application
2020-12-20 16:26:39 +01:00
Bartłomiej Dach
d823c77a63
Implement swell tick application
2020-12-20 16:26:39 +01:00
Bartłomiej Dach
3bd4279589
Implement drum roll tick application
2020-12-20 16:26:39 +01:00
Bartłomiej Dach
e3b6eaa390
Implement swell application
...
Also removes a weird sizing application that seems to have no effect
(introduced in 27e63eb; compare removals for other taiko DHO types in
9d00e5b
and 58bf288
).
2020-12-20 16:26:39 +01:00
Bartłomiej Dach
8b6bc09b8f
Implement drum roll application
2020-12-20 16:26:16 +01:00
Bartłomiej Dach
e32b1c34ca
Implement hit application
2020-12-20 16:26:16 +01:00
Bartłomiej Dach
7b350fc8e5
Prepare strongable DHO for HO application
2020-12-20 15:42:24 +01:00
Bartłomiej Dach
a25cd910f8
Prepare base DHO for HO application
2020-12-20 15:42:24 +01:00
Dean Herbert
88b3bf06e8
Merge branch 'master' into add-bundle-header
2020-12-16 13:40:15 +09:00
Dan Balasescu
48805a82f9
Merge branch 'master' into taiko-strong-state-refactor
2020-12-15 11:46:52 +09:00
Dan Balasescu
52d9864818
Merge pull request #11179 from bdach/swell-rewind-crash
...
Fix swells crashing on rapid seeks in editor
2020-12-15 11:21:37 +09:00
Bartłomiej Dach
523e803440
Fix swells crashing on rapid seeks in editor
2020-12-15 00:28:00 +01:00
Bartłomiej Dach
2051f49f78
Ensure correct initial state of taiko bar lines
2020-12-14 21:58:17 +01:00
Bartłomiej Dach
512549b4ea
Rename DrawableTaikoStrong{-> able}HitObject
2020-12-14 21:47:31 +01:00
Bartłomiej Dach
5af1ac1b53
Rename TaikoStrong{-> able}HitObject
2020-12-14 21:46:02 +01:00
Bartłomiej Dach
7ba04a2cc3
Merge branch 'master' into taiko-strong-state-refactor
2020-12-14 21:44:50 +01:00
Dean Herbert
1793385e96
Pass a score to the replay recorder to allow reading more general scoring data
2020-12-14 16:52:14 +09:00
Dean Herbert
7041503063
Avoid intermediary delegate
2020-12-14 15:34:32 +09:00
Bartłomiej Dach
ea09cbddc6
Register bar line pool & use in drawable ruleset
2020-12-13 22:31:33 +01:00
Bartłomiej Dach
a8e86a20e1
Unify bar line types & prepare for pooling
2020-12-13 22:31:33 +01:00
Bartłomiej Dach
f83c5fa81d
Add backing bindable for major field
2020-12-13 22:12:26 +01:00
Bartłomiej Dach
beee9b89d5
Change bar line SHOC to nested playfield
2020-12-13 22:12:26 +01:00
Bartłomiej Dach
080f7a3e32
Add/fix up xmldocs with clarifications
2020-12-13 14:39:32 +01:00
Bartłomiej Dach
091b08b507
Scope drawable nested hits more closely to models
2020-12-13 14:38:16 +01:00
Bartłomiej Dach
61c488cd5e
Create HO-specific nested hit types
2020-12-13 13:08:32 +01:00
Bartłomiej Dach
4d444df6b3
Rename DHO CreateStrong{-> Nested}Hit
2020-12-13 13:08:32 +01:00
Bartłomiej Dach
b1635ecd16
Reflect can-be-strong split in DHO structure
2020-12-13 13:08:30 +01:00
Bartłomiej Dach
f74567e8eb
Introduce base class for hitobjects that can be strong
2020-12-13 12:36:39 +01:00
Bartłomiej Dach
1ddc896b76
Rename Strong{-> Nested}HitObject
2020-12-13 12:34:14 +01:00
ekrctb
c70b13ecc2
Adjust namespace
2020-12-07 12:30:25 +09:00
ekrctb
f78bd7c739
Move piece files of Taiko ruleset
2020-12-07 12:29:14 +09:00
smoogipoo
5760e1c1fc
Make HitSampleInfo immutable
2020-12-01 15:37:51 +09:00
Bartłomiej Dach
5fbe1823a0
Merge branch 'master' into editor-beat-snap-always
2020-11-30 18:39:22 +01:00
Dean Herbert
c17d67bc7d
Merge branch 'master' into editor-beat-snap-always
2020-11-30 18:34:38 +09:00
smoogipoo
8f48389f89
Merge branch 'master' into improve-dho-time-offsets
2020-11-30 18:01:48 +09:00
Dean Herbert
f29aa9c4fc
Move taiko barlines to their own ScrollingHitObjectContainer to avoid being considered as a selectable object
2020-11-27 14:35:12 +09:00
Dean Herbert
9811c46e35
Rename application method to better describe what it actually does
2020-11-26 19:16:18 +09:00
smoogipoo
0414e5c550
Add MaximumJudgementOffset to DrawableHitObject, use in more places
2020-11-26 01:12:42 +09:00
Bartłomiej Dach
827a089810
Merge branch 'master' into change-taiko-ez
2020-11-22 13:29:02 +01:00
Bartłomiej Dach
80d81c3044
Reword taiko easy mod description to fit others better
...
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2020-11-16 20:24:04 +01:00
Bartłomiej Dach
128adce017
Merge branch 'master' into change-taiko-ez
2020-11-16 19:37:47 +01:00
PercyDan54
017a6b7153
Fix checks
2020-11-16 18:22:17 +08:00
PercyDan54
d7acfd5413
Remove retires from ModEasy
2020-11-16 18:15:15 +08:00
Dean Herbert
dc38aeac43
Remove unnecessary local definition of colour logic from taiko judgement
2020-11-16 17:23:02 +09:00
Bartłomiej Dach
7736d1ae85
Fix taiko-specific missing cases
2020-11-15 15:41:58 +01:00
PercyDan54
3406b0d74f
Fix checks
2020-11-15 14:54:04 +08:00
PercyDan54
cf7ac6d5e3
Remove import
2020-11-15 13:38:21 +08:00
PercyDan54
a4b20d2117
Make EZ mod able to fail in Taiko
2020-11-15 13:00:07 +08:00
smoogipoo
4ef2e9548c
Pass HitObjectComposer to BlueprintContainer via ctor
2020-11-13 16:59:37 +09:00
Bartłomiej Dach
1f83769bb2
Inline empty explosion in legacy transformer
2020-11-12 18:29:22 +09:00
Bartłomiej Dach
0d5cac89b3
Explicitly set lifetime to ensure empty drawables are cleaned up
2020-11-12 18:29:22 +09:00
Bartłomiej Dach
21709ba4bc
Do not lookup default kiai explosion if skin has own
2020-11-12 18:29:22 +09:00
Bartłomiej Dach
00a486ab51
Reintroduce KiaiHitExplosion as skinnable
2020-11-12 18:29:22 +09:00
Bartłomiej Dach
81c9663e76
Move {-> Default}KiaiHitExplosion
2020-11-12 18:29:22 +09:00
Dean Herbert
0cadb31947
Merge branch 'master' into drawable-hit-object-hit-state-fix
2020-11-05 17:07:52 +09:00
Dean Herbert
a3dc1d5730
Update existing implementations
2020-11-04 17:14:23 +09:00
Dean Herbert
487a5ecdba
Replace all usage of IBindableList.GetBoundCopy
2020-11-04 15:29:14 +09:00
Dean Herbert
3adf451e82
Handle changes via SamplePoints list for simplicity
2020-11-02 14:40:40 +09:00
Dean Herbert
bfa6ae1b66
Fix taiko drum not correct handling sample / group point changes
...
Closes https://github.com/ppy/osu/issues/10642
2020-11-02 14:40:40 +09:00
Dan Balasescu
1b53e6c782
Merge branch 'master' into sample-lookup-improvements
2020-11-02 13:04:35 +09:00
Dean Herbert
2ec2749cb4
Fix taiko lookup logic
2020-10-30 11:59:41 +09:00
Dean Herbert
3ea27e23e8
Update namespace references
2020-10-29 15:20:10 +09:00
Dean Herbert
681e88af40
Merge branch 'master' into editor-fix-button-states-after-paste
2020-10-09 20:51:09 +09:00
Dan Balasescu
ecfb7e94c5
Merge branch 'master' into fix-editor-batch-handling
2020-10-09 20:06:06 +09:00
Dean Herbert
3838f405dd
Fix missed usages
2020-10-09 18:50:05 +09:00
Dean Herbert
cb96a40dd6
Fix bindable propagation potentially making swells strong
2020-10-09 17:12:10 +09:00
Dean Herbert
144726e3c6
Better guard against taiko swells becoming strong
2020-10-09 17:12:01 +09:00
Dean Herbert
07558b5bc0
Merge branch 'master' into ruleset-result-types
2020-10-09 13:17:05 +09:00
Dean Herbert
c9f069d7ed
Fix taiko's HitObjectComposer not allowing movement o
...
f selected hitobjects
2020-10-08 18:17:57 +09:00
Dean Herbert
afed832b19
Tidy up EditorBeatmap slightly
2020-10-08 18:06:49 +09:00
Dean Herbert
38babf3de5
Update usages of ChangeHandler to EditorBeatmap where relevant
2020-10-08 18:04:07 +09:00
Dean Herbert
d9089ef93c
Add missing bonus type for taiko ruleset
2020-10-08 12:52:52 +09:00
Dean Herbert
1566882dc4
Merge pull request #10338 from Game4all/perf-calculator-remove-working-beatmap
...
Remove WorkingBeatmap from PerformanceCalculator
2020-10-07 20:04:24 +09:00
Dean Herbert
8c528c8910
Fix legacy taiko skins showing double judgements
2020-10-07 18:36:40 +09:00
Dean Herbert
f1a3b6d0ba
Merge branch 'master' into perf-calculator-remove-working-beatmap
2020-10-07 17:43:17 +09:00
Dean Herbert
6020ec9ca3
Add valid result types for all rulesets
2020-10-07 15:43:52 +09:00
Dean Herbert
2a46f905ff
Remove unnecessary IsSeeking checks from taiko drum implementation
2020-10-05 14:27:51 +09:00
Dean Herbert
5dea37792c
Merge branch 'master' into health-adjustments
2020-10-04 21:38:40 +09:00
Lucas A
d7747ebb2d
Remove unused WorkingBeatmap argument.
2020-10-03 16:51:22 +02:00
Bartłomiej Dach
682b5fb056
Adjust health increase for drum roll tick to match new max result
2020-10-03 12:16:22 +02:00
Bartłomiej Dach
1f0620ffd4
Replace assignment references to HitResult.Miss with Judgement.MinResult
2020-10-02 23:31:24 +02:00
Bartłomiej Dach
2b1ef16f89
Replace comparison references to HitResult.Miss with IsHit
2020-10-02 23:31:24 +02:00
Lucas A
abd395a030
Remove unecessary using references.
2020-10-02 19:41:24 +02:00
Lucas A
0163688a17
Remove IBeatmap from PerformanceCalculator.
2020-10-02 19:24:30 +02:00
smoogipoo
7890319802
Merge branch 'master' into adjust-hit-result-types
2020-10-01 16:19:07 +09:00
smoogipoo
cb6b35116a
Merge branch 'master' into scoring-standardisation
2020-10-01 12:28:51 +09:00
Dan Balasescu
a6c7bc0cdb
Merge branch 'master' into taiko-explosion-rework
2020-09-30 23:02:46 +09:00
Dean Herbert
414c40d298
Reverse inheritance order of SkinnableSound's pause logic
2020-09-30 15:45:14 +09:00
smoogipoo
f439c1afbc
Make osu/taiko/catch use Ok+Great
2020-09-29 17:16:55 +09:00
smoogipoo
903bcd747e
Revert unintended changes
2020-09-29 16:39:29 +09:00
smoogipoo
bad48d6d44
Merge branch 'master' into scoring-standardisation
2020-09-29 16:33:38 +09:00
smoogipoo
31fae045fa
Update judgement processors with new hit results
2020-09-29 16:33:38 +09:00
smoogipoo
c45b5690cf
Use new hit results in taiko
2020-09-29 16:33:38 +09:00
Bartłomiej Dach
2fb9a5d734
Remove no longer required field
2020-09-28 17:53:32 +02:00
Bartłomiej Dach
f6f267a43a
Switch to strong sprite exactly once
2020-09-28 17:53:12 +02:00
Bartłomiej Dach
0900661b23
Use IsHit for strong hit instead of checking result type
2020-09-28 16:34:04 +02:00
Bartłomiej Dach
40dea0e2db
Merge branch 'master' into taiko-explosion-rework
2020-09-28 16:32:15 +02:00
Dan Balasescu
895828c06a
Merge pull request #10274 from peppy/autoplay-fix-empty-generation
...
Fix autoplay generators failing on empty hitobjects lists
2020-09-28 16:34:10 +09:00
Dean Herbert
6095446f10
Fix autoplay generators failing on empty hitobjects lists
2020-09-28 15:38:54 +09:00
Dean Herbert
1aa8b400d4
Avoid unnecessary object updates from SelectionHandlers
2020-09-28 15:33:49 +09:00
Bartłomiej Dach
4944128631
Ensure both sprites are centered
2020-09-27 18:11:12 +02:00
Bartłomiej Dach
2f7c0b4934
Allow switching between legacy sprites
2020-09-27 16:07:19 +02:00
Bartłomiej Dach
eb62ad4e55
Look up both sprites for legacy explosions
2020-09-27 16:06:59 +02:00
Bartłomiej Dach
d5f1d94b51
Allow specifying two sprites for legacy hit explosions
2020-09-27 15:52:40 +02:00
Bartłomiej Dach
deb207001a
Remove schedule causing default skin explosion regression
2020-09-27 15:23:34 +02:00
Bartłomiej Dach
d61a8327da
Fix rim flying hits changing colour
2020-09-26 20:59:55 +02:00
smoogipoo
480eeb5fbe
Add back caching
2020-09-25 19:37:34 +09:00
smoogipoo
acfa62bb50
Fix potential taiko crash on rewind
2020-09-25 19:25:58 +09:00
Dan Balasescu
9b29c9e185
Merge branch 'master' into editor-ternary-states
2020-09-25 16:58:15 +09:00
Dean Herbert
727ab98d22
Update taiko selection handler with new logic
2020-09-25 15:32:45 +09:00
Dean Herbert
33fad27ec2
Avoid API change to DrawableHitObject
2020-09-24 13:28:29 +09:00
Dean Herbert
156edf24c2
Change properties to methods and improve naming
2020-09-24 13:22:31 +09:00
Dean Herbert
00b0228b61
Merge branch 'master' into fix-taiko-editor-type-stats
2020-09-24 13:18:13 +09:00
Dean Herbert
9a0e5ac154
Handle type/strength changes from samples changes
2020-09-23 18:09:40 +09:00
Dean Herbert
8f3eb9a422
Fix taiko sample selection not updating when changing strong/rim type
2020-09-23 17:59:11 +09:00
Dean Herbert
487fc2a2c6
Add missing change handler scopings to taiko context menu operations
2020-09-23 16:58:22 +09:00
Bartłomiej Dach
4072abaed8
Allow miss explosions to be displayed
2020-09-20 19:40:30 +02:00
Bartłomiej Dach
1c7556ea5d
Schedule explosion addition to ensure both hits are processed
2020-09-20 19:40:30 +02:00
Bartłomiej Dach
074387c676
Show strong hit explosion where applicable
2020-09-20 19:40:30 +02:00
Bartłomiej Dach
919b19612f
Add lookups for strong hit explosions
2020-09-20 19:40:30 +02:00
smoogipoo
847ec8c248
Fix n^2 characteristic in taiko diffcalc
2020-09-19 14:52:05 +09:00
smoogipoo
c62e4ef5e5
Allow one hitobject in taiko beatmap converter edge case
2020-09-18 13:06:41 +09:00
Dean Herbert
fdbd7b8a05
Merge branch 'master' into fix-taiko-endless-conversion
2020-09-17 22:31:35 +09:00
smoogipoo
c7d24203ce
Make beatmap conversion support cancellation tokens
2020-09-17 17:40:05 +09:00
smoogipoo
81f0a06fc4
Fix potential endless taiko beatmap conversion
2020-09-17 16:30:34 +09:00
Dean Herbert
7f2ce14f36
Merge pull request #9294 from smoogipoo/morth-taiko-changes
2020-09-15 16:11:17 +09:00
Bartłomiej Dach
a350802158
Fix wrong mono streak length handling in corner case
2020-09-10 20:50:26 +02:00
Bartłomiej Dach
6e5c5ab901
Fix invalid initial value of currentMonoLength
2020-09-10 18:22:49 +02:00
smoogipoo
74eea8900b
Remove unnecessary check for negative durations
2020-09-10 20:00:57 +09:00
Dean Herbert
ef44c7d063
Merge branch 'master' into score-recalc
2020-09-10 18:30:41 +09:00
smoogipoo
d700ae55fb
Merge branch 'master' into morth-taiko-changes
2020-09-10 16:34:09 +09:00
Dean Herbert
a65f564e45
Add icons for other ruleset editors
2020-09-09 18:40:01 +09:00
smoogipoo
117c7ec6b2
Merge branch 'master' into score-recalc
2020-09-09 14:38:36 +09:00
Dean Herbert
4680728b9c
Merge branch 'master' into update-dcc-exclusions
2020-09-07 18:01:44 +09:00
smoogipoo
1143d5d992
Update class exclusion for dynamic compilation
2020-09-04 20:41:08 +09:00
Dean Herbert
25e142965d
Strongly type and expose default beatmap information icon implementations for other rulesets
2020-09-04 15:01:32 +09:00
Dean Herbert
72cb65c22f
Update and add missing beatmap statistic icons to info wedge
2020-09-03 17:52:22 +09:00
smoogipoo
d387c0cba0
Merge branch 'master' into morth-taiko-changes
2020-09-03 17:35:26 +09:00
Dean Herbert
cd0a73883d
Merge pull request #9945 from smoogipoo/skin-colour-fix-2
...
Exactly reproduce osu!stable skin colour alphas
2020-08-29 20:06:26 +09:00
smoogipoo
1c1afa1c96
Move MaxCombo to base DifficultyAttributes
2020-08-28 19:16:20 +09:00
Bartłomiej Dach
43d6d2b2e8
Add back unstable rate display
2020-08-27 20:46:49 +02:00
Bartłomiej Dach
f152e1b924
Revert IStatisticRow changes
2020-08-27 20:13:44 +02:00
Bartłomiej Dach
05e725d59f
Add unstable rate statistic to rulesets in which it makes sense
2020-08-26 22:06:29 +02:00
Bartłomiej Dach
bbb3d7522e
Scope up return type to IStatisticRow
2020-08-26 19:24:12 +02:00
smoogipoo
2cf2ba8fc5
Store computed accent colour to local
2020-08-26 14:24:04 +09:00
smoogipoo
ab8d9be095
Move out into a separate method
2020-08-25 15:16:41 +09:00
Bartłomiej Dach
7c9fae55ad
Hopefully fix off-by-one errors
2020-08-22 22:50:58 +02:00
Bartłomiej Dach
5afe9b73d2
Fix invalid cref
2020-08-22 21:27:08 +02:00
Bartłomiej Dach
a080774799
Add xmldoc to taiko difficulty calculation code
2020-08-22 19:44:58 +02:00
Bartłomiej Dach
8ace7df0fd
Reorder members for better readability
2020-08-22 19:34:49 +02:00
Bartłomiej Dach
7e2bef3b9f
Split conditional for readability
2020-08-22 19:34:49 +02:00
Bartłomiej Dach
bcf3cd5657
Remove unnecessary yield iteration
2020-08-22 19:34:49 +02:00
Bartłomiej Dach
cb3fef7616
Inline same parity penalty
2020-08-22 19:34:49 +02:00
Bartłomiej Dach
ec99fcd7ab
Avoid passing down rhythm list every time
2020-08-22 19:34:49 +02:00
smoogipoo
9fbc5f3aeb
Update taiko with legacy colour setters
2020-08-22 00:23:08 +09:00
Bartłomiej Dach
27f97973ee
Add more proper typing to skills
2020-08-18 20:19:58 +02:00
Bartłomiej Dach
cb5ea6aa9a
Generalise p-norm function
2020-08-18 20:19:58 +02:00
Bartłomiej Dach
51d41515ef
Simplify expression with ternary
2020-08-18 20:19:58 +02:00
Bartłomiej Dach
c827e21506
Extract helper method to reset rhythm strain
2020-08-18 20:19:58 +02:00
Bartłomiej Dach
80e4c15727
Use Math.Clamp
2020-08-18 20:19:58 +02:00
Bartłomiej Dach
ce0e5cf9a1
Slightly optimise and de-branch rhythm pattern recognition
2020-08-18 20:19:58 +02:00
Bartłomiej Dach
d7ff3d77eb
Slightly optimise and de-branch repetition pattern recognition
2020-08-18 20:19:58 +02:00
Bartłomiej Dach
00ae456f08
Remove unnecessary null check
2020-08-18 20:19:58 +02:00
Bartłomiej Dach
c6a640db55
Remove superfluous IsRepeat field
2020-08-18 20:19:58 +02:00
Bartłomiej Dach
f22050c975
Remove unnecessary initialiser
2020-08-18 20:19:58 +02:00
Bartłomiej Dach
ff44437706
Extract method for marking cheese
2020-08-18 20:19:58 +02:00
Bartłomiej Dach
292d38362c
De-nest cheese detection logic
2020-08-18 20:19:58 +02:00
Bartłomiej Dach
6c759f31f1
Add and use limited capacity queue
2020-08-18 20:19:58 +02:00
Bartłomiej Dach
9fb494d5d3
Eliminate unnecessary loop
2020-08-18 17:36:23 +02:00
Bartłomiej Dach
cd2280b5bf
Fix cheese indexing bug
2020-08-18 17:36:21 +02:00
smoogipoo
8ded5925ff
Xmldoc colour strain
2020-08-13 13:47:35 +09:00
smoogipoo
5010d2044a
Replace IsKat with HitType
2020-08-13 01:35:56 +09:00
smoogipoo
d2a03f1146
Refactor TaikoDifficultyHitObject
2020-08-13 00:59:22 +09:00
smoogipoo
4c00c11541
Remove unnecessary change
2020-07-29 20:53:14 +09:00
smoogipoo
e09a5ac835
Merge branch 'master' into morth-taiko-changes
2020-07-29 20:52:54 +09:00
Bartłomiej Dach
8e6a0493b4
Adjust InputDrum usage
2020-07-26 17:50:25 +02:00
Bartłomiej Dach
648f9204f5
Add sample lifetime constraints for taiko
2020-07-26 17:50:25 +02:00
Bartłomiej Dach
ea3ef37f9a
Add support for indexless mascot texture lookups
2020-07-25 12:03:54 +02:00
Dan Balasescu
2997fb3f4e
Merge pull request #9635 from peppy/perfect-mod-combo-objects-only
...
Make perfect mod ignore all non-combo-affecting hitobjects
2020-07-23 20:54:39 +09:00
Dean Herbert
2c62b23d85
Update naming
2020-07-22 19:53:45 +09:00
Dean Herbert
c1442568b9
Make perfect mod ignore all non-combo-affecting hitobjects
2020-07-21 17:04:45 +09:00
Dean Herbert
648e414c14
Update InputHandlers in line with framework changes
2020-07-19 11:39:11 +09:00
smoogipoo
fc0f3f9171
Fix taiko drumroll bodies behaving badly with edge alphas
2020-07-17 16:55:01 +09:00
smoogipoo
c44ac9104f
Fix post-merge error
2020-07-17 14:19:43 +09:00
smoogipoo
98accf2777
Merge branch 'master' into morth-taiko-changes
2020-07-17 14:19:32 +09:00
Dean Herbert
5049977395
Merge pull request #9578 from smoogipoo/accuracy-based-mania
2020-07-16 16:12:48 +09:00
smoogipoo
87713215dc
Remove redundant parens
2020-07-16 14:30:17 +09:00
smoogipoo
35d6501478
Also adjust taiko
2020-07-16 14:13:46 +09:00
smoogipoo
dcd345eed9
Add a few tests
2020-07-16 01:35:38 +09:00
smoogipoo
0ea13dea55
Introduce legacy timing point fp errors
2020-07-13 17:06:00 +09:00
smoogipoo
352f59942e
Fix incorrect time delta in taiko strain
2020-07-13 16:50:54 +09:00
Dean Herbert
bd5957bc0a
Add dynamic compilation exclusion rules for ruleset types
2020-07-10 14:49:44 +09:00
smoogipoo
5db103dc61
Improve quality of taiko hit target
2020-06-29 14:42:20 +09:00
Dean Herbert
9119f41604
Merge branch 'master' into results-screen-statistics-overlapping-transition
2020-06-24 18:22:51 +09:00
Dean Herbert
14ad3835ff
Update naming
2020-06-23 21:27:01 +09:00
smoogipoo
988baad16f
Expand statistics to fill more of the screen
2020-06-22 19:20:43 +09:00
smoogipoo
261adfc4e6
Create a local playable beatmap instead
2020-06-22 18:38:41 +09:00
smoogipoo
33fdd7466c
Merge branch 'master' into results-screen-statistics-overlapping-transition
2020-06-22 15:38:48 +09:00
Bartłomiej Dach
ad85c5f538
Add base legacy skin transformer
2020-06-21 23:06:55 +02:00
smoogipoo
486b899e8f
Rename method
2020-06-19 22:11:29 +09:00
smoogipoo
83e6c3efdb
Adjust API for returning statistics
2020-06-19 20:31:52 +09:00
smoogipoo
68027fcc2c
Update with latest changes
2020-06-08 16:30:26 +09:00
Dean Herbert
61f906d9c4
Fix span piece being incorrect in some drag scenarios
2020-06-02 21:02:09 +09:00
Dean Herbert
665530f1c3
Remove excess newline
2020-06-02 17:22:59 +09:00
Dean Herbert
816f721f3d
Move selection blueprint to correct namespace
2020-05-30 15:24:44 +09:00
Dean Herbert
b068992a15
Add missing licence headers
2020-05-29 18:58:34 +09:00
Dean Herbert
e0aae15c0a
Hard type incoming ruleset
2020-05-29 16:45:47 +09:00
Dean Herbert
da289c474e
Split files out
2020-05-29 16:45:47 +09:00
Dean Herbert
7f8f41715d
Remove stray whitespace
2020-05-29 16:45:47 +09:00
Dean Herbert
7b52faa76d
Update override
2020-05-29 16:45:47 +09:00
Dean Herbert
3e973c176f
Remove unnecessary overrides
2020-05-29 16:45:47 +09:00
Dean Herbert
b2fad91589
Add swell and drumroll blueprints
2020-05-29 16:45:47 +09:00
Dean Herbert
dd7dbfd548
Rename to IHasDuration
2020-05-29 16:45:47 +09:00
Dean Herbert
534dccc0c3
Move sett from EndTime to Duration
2020-05-29 16:45:47 +09:00
Dean Herbert
a953f9e422
Add drum roll composition support
2020-05-29 16:45:47 +09:00
Dean Herbert
280b0adb1d
Split out IHasPath from IHasCurve to better define hitobjects
2020-05-29 16:45:47 +09:00
Dean Herbert
a2eec5d963
Fix strong bindable changes for DrumRolls
2020-05-29 16:45:47 +09:00
Dean Herbert
910326623c
Place rim hits using right mosue for now
2020-05-29 16:45:47 +09:00
Dean Herbert
50fcd4149f
Support Strong bindable changes
2020-05-29 16:45:47 +09:00
Dean Herbert
4e9631b546
Support HitType bindable changes
2020-05-29 16:45:47 +09:00
Dean Herbert
3487c1fd1b
Add menus to mark as rim and strong
2020-05-29 16:45:47 +09:00
Dean Herbert
4b1a2b5bc2
Fix offsets
2020-05-29 16:45:47 +09:00
Dean Herbert
90acba8c36
Introduce initial placement blueprint logic
2020-05-29 16:45:39 +09:00
Dean Herbert
7d4e60f05e
Add basic setup for TaikoHitObjectComposer
2020-05-29 16:45:39 +09:00
smoogipoo
bc35bc5efb
Merge branch 'master' into applydefaults-cancellation
2020-05-25 16:45:30 +09:00
smoogipoo
5852a37eb7
Update with latest changes
2020-05-24 11:48:56 +09:00
smoogipoo
9461097b00
Update with latest changes
2020-05-22 20:50:21 +09:00
smoogipoo
d04da46522
Merge branch 'master' into morth-taiko-changes
2020-05-22 20:48:04 +09:00
Dean Herbert
c0e68f9854
Also support taiko drum
2020-05-21 11:08:06 +09:00
Dean Herbert
db4e3047dd
Add test for final sample output
2020-05-19 23:28:13 +09:00
Dean Herbert
e9710b6f83
Add taiko type conversion test coverage
2020-05-19 09:43:05 +09:00
Dean Herbert
013683c23b
Fix taiko rim markers incorrectly playing as whistle samples
2020-05-19 00:17:13 +09:00
smoogipoo
1865cd0762
Fix possible exceptions in performance calculators
2020-05-18 15:10:59 +09:00
smoogipoo
6534510999
Use cancellation token in taiko swell/drumroll
2020-05-15 19:25:14 +09:00
smoogipoo
98125102a7
Add cancellation token support to CreateNestedHitObjects()
2020-05-15 18:07:41 +09:00
Dan Balasescu
f761c5e119
Merge branch 'master' into reposition-taiko-playfield
2020-05-14 19:37:05 +09:00
smoogipoo
4bf5477252
Merge branch 'master' into fix-taiko-scroller-time-control
2020-05-14 17:04:09 +09:00
Dean Herbert
134a94e86d
Rename enum members (no idea what a TaikoDon is)
2020-05-14 10:02:47 +09:00
Dean Herbert
9ba1a8af88
Fix mascot getting stuck in clear state on rewind
2020-05-14 09:44:21 +09:00
Bartłomiej Dach
0933217389
Simplify mascot scaling
2020-05-13 18:53:47 +02:00
Dean Herbert
6f2cc23a43
Merge branch 'master' into taiko-don
2020-05-13 19:27:54 +09:00
Dean Herbert
00efeb7cc6
Fix spawning too many sprites due to not yet populated sizing
2020-05-13 19:19:58 +09:00
Bartłomiej Dach
942cc48e99
Improve mascot scaling
2020-05-12 20:26:11 +02:00
Dean Herbert
e28e89213f
Fix incorrect spawning when scale adjustments are applied to child sprites
2020-05-12 16:58:47 +09:00
Dean Herbert
c04f2b0840
Reposition taiko playfield to be closer to the top of the screen
2020-05-12 15:51:59 +09:00
Dean Herbert
c7d8793c1d
Remove unnecessary overlap
2020-05-12 15:44:14 +09:00
Dean Herbert
949e17cc0e
Rework scroller to support backwards playback
2020-05-12 15:23:47 +09:00
Dean Herbert
3b1680583e
Fix taiko scroller not following gameplay time
2020-05-12 11:31:08 +09:00
Bartłomiej Dach
e5821ff2b2
Integrate GameplayBeatmap changes
2020-05-11 22:53:05 +02:00
Dean Herbert
77041bdbb5
Move implementation to DrawableHit to avoid "breaking" legacy encoding
2020-05-11 16:29:50 +09:00
smoogipoo
b0ed39f32b
Do not use statics
2020-05-11 14:57:47 +09:00
smoogipoo
779af48802
Resolve errors + auto-format
2020-05-11 14:53:42 +09:00
smoogipoo
d613888803
Add initial changes
2020-05-11 14:50:02 +09:00
Craftplacer
43342c57b8
Fix switch case
...
... caused by a poor merge
2020-05-11 07:13:06 +02:00
Dan Balasescu
d697de29a6
Merge branch 'master' into taiko-don
2020-05-11 13:24:27 +09:00
Dean Herbert
b4d790c076
Fix taiko sample mapping for strong hits
2020-05-11 12:53:54 +09:00
Dean Herbert
8243dc239a
Merge branch 'master' into taiko-don
2020-05-10 22:34:47 +09:00
Dean Herbert
5902cd81a4
Move passing transforms to post-load for safety
2020-05-10 07:52:54 +09:00
Dean Herbert
3565fe1cb2
Fix incorrect passing logic
2020-05-10 07:51:39 +09:00
Dean Herbert
115cbf25ae
Fix new sprites not getting spawned with correct passing state
2020-05-08 19:15:19 +09:00
Dean Herbert
1a31e1f10f
Also check for AffectsCombo to avoid too many passing switches
2020-05-08 19:13:41 +09:00
Dean Herbert
cea6be5e52
Expose as JudgementResult instead of "passing" state
2020-05-03 23:55:44 +09:00
Dean Herbert
ff1d63060d
Add and consume passing state in GameplayBeatmap
2020-05-01 20:08:18 +09:00
Dean Herbert
3033ab80ce
Add passing/failing test
2020-05-01 19:49:30 +09:00
Dean Herbert
6ff31fb786
Fix sizing when gameplay scale is adjusted
2020-05-01 19:49:23 +09:00
Dean Herbert
510df8b282
Improve tiling logic
2020-05-01 19:49:01 +09:00
Dean Herbert
afcb45f28b
Move to playfield
2020-05-01 19:48:31 +09:00
Dean Herbert
8955b98cbb
Add basic taiko scroller implementation
2020-05-01 17:56:09 +09:00
Bartłomiej Dach
d021e213b2
Reword comment
2020-05-01 00:29:03 +02:00
Bartłomiej Dach
1e7b10320f
Adjust mascot positioning in playfield layout
2020-05-01 00:19:12 +02:00
Bartłomiej Dach
f5526890cc
Add comment about animation presence
2020-04-30 22:51:22 +02:00
Bartłomiej Dach
db4c8b2ba5
Fix transition out of clear state
2020-04-30 22:16:25 +02:00
Bartłomiej Dach
5cfc05e12a
Ensure correct initial state
2020-04-30 22:03:39 +02:00
Bartłomiej Dach
22fde8d2a0
Implement partial clear transition logic
2020-04-30 21:58:05 +02:00
Dan Balasescu
68efdd145d
Merge pull request #8909 from peppy/fix-legacy-explosion-rewind
...
Fix skinned taiko hit explosions not being removed on rewind
2020-04-30 21:00:41 +09:00
Dean Herbert
d0a8c0fa71
Add kiai support to osu!taiko skinned playfields
2020-04-30 16:43:00 +09:00
Dean Herbert
48af4d4eb4
Fix skinned taiko hit explosions not being removed on rewind
2020-04-30 16:18:15 +09:00
Dean Herbert
49a98fde73
Move to non-legacy class
2020-04-30 09:57:14 +09:00
Dean Herbert
783dc58ef0
Move taiko additive blending locally to avoid applying to legacy skins
2020-04-30 09:41:56 +09:00
Bartłomiej Dach
b0e97793b6
Implement transitions into and from clear state
2020-04-30 00:14:27 +02:00
Bartłomiej Dach
0d917ca339
Ensure correct behaviour for clear animation
2020-04-29 21:52:09 +02:00
Bartłomiej Dach
9d6720e7e6
Scope up parameter
2020-04-29 21:30:13 +02:00
Bartłomiej Dach
e81d33dcec
Refactor mascot animations to split logic paths
2020-04-29 21:27:02 +02:00
Bartłomiej Dach
6e2ed0c4f3
Refactor mascot to only contain state transitions
2020-04-29 20:28:46 +02:00
Dean Herbert
48733a7e2f
Change taiko hit explosion animation to match stable for skins
2020-04-29 17:53:37 +09:00
Bartłomiej Dach
5f0a4103c2
Merge branch 'master' into taiko-don
2020-04-28 23:46:42 +02:00
Dan Balasescu
79e1b16119
Merge branch 'master' into taiko-explosion-skinning
2020-04-28 12:17:09 +09:00
Dean Herbert
84641765c5
Adjust exceptions and fix capitalisation
2020-04-28 11:08:19 +09:00
Craftplacer
6de6f068fd
Merge branch 'taiko-don' of https://github.com/Craftplacer/osu into taiko-don
2020-04-27 23:19:22 +02:00
Craftplacer
74d36cad78
Change state variables
2020-04-27 23:19:18 +02:00
Craftplacer
96660b2cca
Flip frame count check
2020-04-27 23:18:40 +02:00
Craftplacer
834eeb6d98
Reduce duplicate texture retrieval code
2020-04-27 23:18:26 +02:00
Craftplacer
9b3c1e4126
Remove unused bindables
2020-04-27 23:17:52 +02:00
Craftplacer
5caa4dedc2
Update osu.Game.Rulesets.Taiko/UI/DrawableTaikoMascot.cs
...
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2020-04-27 22:27:03 +02:00
Craftplacer
c049302650
Update osu.Game.Rulesets.Taiko/UI/TaikoMascotTextureAnimation.cs
...
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2020-04-27 22:23:04 +02:00
Dean Herbert
be59ee945a
Add taiko hit explosion skinning support
2020-04-27 22:36:27 +09:00
Craftplacer
e8a0b77729
Merge remote-tracking branch 'upstream/master' into taiko-don
2020-04-27 12:43:51 +02:00
Dean Herbert
ca055581af
Fix taiko hit target alpha on legacy skins
2020-04-27 18:18:11 +09:00
Dean Herbert
52cf1e1859
Fix hit type not being provided and hit time offset not being considered
2020-04-27 16:48:27 +09:00
Dean Herbert
b9f28c8373
Combine hit types and remove old drumroll hits using a more efficient method
2020-04-27 16:13:28 +09:00
Dean Herbert
ff736a22dd
Fix typos in comment
2020-04-27 14:41:19 +09:00
Dean Herbert
1cd4fd2ac4
Merge branch 'master' into taiko-drumroll-party
2020-04-27 13:27:10 +09:00
smoogipoo
20ae973e4a
Use max result instead of GOOD
2020-04-27 12:29:11 +09:00
smoogipoo
2630fc1405
Break instead of return for consistency
2020-04-27 12:27:43 +09:00
smoogipoo
7dc090cc24
Add support for hit explosions
2020-04-27 12:23:53 +09:00
smoogipoo
dd36b839b9
Refactor
2020-04-27 12:01:31 +09:00
Craftplacer
e830c7d833
Merge remote-tracking branch 'upstream/master' into taiko-don
2020-04-27 02:13:09 +02:00
Craftplacer
d46643ec52
Rework special case for strong hits
2020-04-27 02:10:12 +02:00
Craftplacer
dc6acf6ec9
Various code changes, fixes
2020-04-27 01:40:57 +02:00
Dean Herbert
4ca7ce7715
Merge branch 'master' into taiko-barline-skinning
2020-04-25 18:58:44 +09:00
Tim Oliver
c1c930c472
Fixed linting warnings
2020-04-25 13:47:20 +08:00
Tim Oliver
2a197db481
Merge branch 'master' into taiko-drumroll-party
...
# Conflicts:
# osu.Game.Rulesets.Taiko/UI/TaikoPlayfield.cs
2020-04-25 13:31:50 +08:00
Tim Oliver
3cc0b21eae
Added more smart checking to removing rewound drumroll hits
2020-04-25 13:18:02 +08:00
Craftplacer
364f5bf788
Update osu.Game.Rulesets.Taiko/UI/TaikoMascotTextureAnimation.cs
...
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2020-04-24 22:57:23 +02:00
Tim Oliver
477fe72fcf
Changed note playback to happen on new result
2020-04-25 00:15:59 +08:00
Tim Oliver
2be3a8184d
Removed modifications to drum roll object
2020-04-25 00:15:37 +08:00
Dan Balasescu
b3175f9dfa
Merge branch 'master' into taiko-playfield-background-skinning
2020-04-24 19:27:38 +09:00
Dean Herbert
05b3db0147
Remove masking
2020-04-24 16:56:18 +09:00
Craftplacer
8ae119ab62
Fix last formatting error
2020-04-24 08:05:57 +02:00
Craftplacer
84aa37d7c3
Fix all local tests
2020-04-24 07:57:16 +02:00
Craftplacer
ac44185f09
Fix formatting
2020-04-24 07:09:20 +02:00
Craftplacer
dbf39be607
Decide on the name "Mascot", add testing, bug fixed, etc.
2020-04-24 06:59:05 +02:00