1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-06 06:57:39 +08:00

Fix incorrect passing logic

This commit is contained in:
Dean Herbert 2020-05-10 07:51:39 +09:00
parent 7ce78d8ce4
commit 3565fe1cb2

View File

@ -39,7 +39,11 @@ namespace osu.Game.Rulesets.Taiko.Skinning
{
var r = result.NewValue;
passing = r == null || (r.Judgement.AffectsCombo && r.Type > HitResult.Miss);
// always ignore hitobjects that don't affect combo (drumroll ticks etc.)
if (r?.Judgement.AffectsCombo == false)
return;
passing = r == null || r.Type > HitResult.Miss;
foreach (var sprite in InternalChildren.OfType<ScrollerSprite>())
sprite.Passing = passing;