Fix incorrect passing logic

2026-05-25 01:39:55 +08:00 · 2020-05-10 07:51:39 +09:00
parent 7ce78d8ce4
commit 3565fe1cb2
1 changed files with 5 additions and 1 deletions
@@ -39,7 +39,11 @@ namespace osu.Game.Rulesets.Taiko.Skinning
            {
                var r = result.NewValue;

-                passing = r == null || (r.Judgement.AffectsCombo && r.Type > HitResult.Miss);
+                // always ignore hitobjects that don't affect combo (drumroll ticks etc.)
+                if (r?.Judgement.AffectsCombo == false)
+                    return;
+
+                passing = r == null || r.Type > HitResult.Miss;

                foreach (var sprite in InternalChildren.OfType<ScrollerSprite>())
                    sprite.Passing = passing;