794 Commits

Author	SHA1	Message	Date
Dean Herbert	e9ef4aaf88	Add test covering expectations of external mod changes	2021-02-10 14:34:45 +09:00
Dean Herbert	0efad9ded1	Add test coverage of setting reset on deselection	2021-02-09 13:54:13 +09:00
Dean Herbert	3e750feaa4	Subclass LocalPlayerModSelectOverlay to correctly deselect incompatible mods on free mod selection	2021-02-05 16:42:35 +09:00
Dean Herbert	cef16a9f61	Add test coverage of animation / selection flushing	2021-02-04 19:55:15 +09:00
Dean Herbert	15062cc63f	Fix intermittent test failures	2021-02-04 19:29:48 +09:00
Dean Herbert	b06f4ee124	Merge branch 'master' into solo-mod-select-overlay	2021-02-03 23:44:08 +09:00
Dean Herbert	2a52851e68	Merge branch 'master' into modselect-dynamic-isvalid	2021-02-03 22:11:33 +09:00
Dean Herbert	77735ac9dc	Merge pull request #11663 from smoogipoo/modselect-disable-stacking ... Allow mod buttons to not be stacked	2021-02-03 22:11:02 +09:00
smoogipoo	921f008217	Fix ModIcon not updating background colour correctly	2021-02-02 21:35:08 +09:00
smoogipoo	e58ece9e10	Make ModSelectOverlay abstract	2021-02-02 21:06:04 +09:00
smoogipoo	50e92bd0ed	Fix selection not being preserved when IsValidMod changes	2021-02-02 20:50:54 +09:00
smoogipoo	10ceddf3ff	Make IsValidMod adjustable	2021-02-02 20:47:50 +09:00
smoogipoo	6d620264f4	Allow mod buttons to not be stacked	2021-02-02 20:27:41 +09:00
Salman Ahmed	d034728443	Remove conditional compilation symbols for such case	2021-01-24 01:05:45 +03:00
Salman Ahmed	85b8b00b8c	Fix forgotten modulo	2021-01-24 01:04:56 +03:00
Salman Ahmed	faa2210274	Use old-style Enum.GetValues method for older than .NET 5	2021-01-24 00:55:58 +03:00
Salman Ahmed	acfb2d2980	Refactor beatmap set covers into using ModelBackedDrawable<T>	2021-01-24 00:32:33 +03:00
Salman Ahmed	d83abfa7d2	Add test scene with failing test case	2021-01-24 00:32:20 +03:00
Bartłomiej Dach	360f26c13d	Merge branch 'master' into scroll-to-20	2021-01-22 19:58:36 +01:00
smoogipoo	54dbb43f79	Fix more potential failures	2021-01-21 14:03:35 +09:00
Dean Herbert	7c4a072568	Merge branch 'master' into scroll-to-20	2021-01-21 13:48:26 +09:00
smoogipoo	163a937e41	Fix mod test failing intermittently	2021-01-21 13:30:53 +09:00
Dean Herbert	5fd644fc57	Unify variable names	2021-01-17 22:42:48 +09:00
Salman Ahmed	268f9d661f	Dispose of local config on disposal	2021-01-13 13:00:14 +03:00
Salman Ahmed	80fa2cf693	Add test coverage	2021-01-12 11:14:05 +03:00
Salman Ahmed	375ecf92ed	Merge remote-tracking branch 'upstream/master' into fix-mod-buttons-not-copying-settings	2021-01-09 00:26:18 +03:00
Dean Herbert	0639429a23	Fix test (and remove no longer valid test)	2021-01-05 18:10:39 +09:00
Dean Herbert	54982dcdd7	Refactor LoadingLayer to avoid applying effects to external drawables ... In theory this seemed like a good idea (and an optimisation in some cases, due to lower fill rate), but in practice this leads to weird edge cases. This aims to do away with the operations on external drawables by applying a dim to the area behind the `LoadingLayer` when required. I went over each usage and ensured they look as good or better than previously. The specific bad usage here was the restoration of the colour on dispose (if the `LoadingLayer` was disposed in a still-visible state). I'm aware that the `BeatmapListingOverlay` will now dim completely during load. I think this is fine for the time being.	2021-01-05 17:31:45 +09:00
Salman Ahmed	ee664ad571	Add test coverage	2021-01-01 03:47:18 +03:00
Endrik Tombak	668f89d8b2	Copy test from #11019	2020-12-22 17:33:11 +02:00
Dean Herbert	eb38bc4b4c	Add the ability to import into ArchiveModelManagers from a stream	2020-12-07 18:09:18 +09:00
Joehu	15e0ea332b	Check state instead of alpha in tests	2020-12-06 13:18:19 -08:00
Andrei Zavatski	c4cb1440ab	Rename PaginatedContainerHeader to ProfileSubsectionHeader	2020-11-21 02:59:01 +03:00
Joehu	ef3c918a3c	Simplify input buttons/keys in tests	2020-11-09 14:18:20 -08:00
Andrei Zavatski	4f6081c7f3	Use BindableList<T>	2020-10-28 19:44:13 +03:00
Andrei Zavatski	c4efceceb2	Use char instead of sting for request parameter creation	2020-10-27 23:57:11 +03:00
Andrei Zavatski	008d1d697c	Implement filtering by rank achieved	2020-10-27 23:14:48 +03:00
Andrei Zavatski	1710b396e7	Implement BeatmapSearchMultipleSelectionFilterRow	2020-10-27 22:27:29 +03:00
Andrei Zavatski	1b40b56d41	Add ability to search by play criteria	2020-10-27 21:30:53 +03:00
Andrei Zavatski	26a60d898c	Implement BeatmapSearchExtraFilterRow	2020-10-27 21:22:20 +03:00
Bartłomiej Dach	c3f1a30447	Merge branch 'master' into mod-customisation-absorb-mouse-input	2020-10-15 00:40:27 +02:00
smoogipoo	f04aec538f	Fix MultiMod throwing exceptions when creating copies	2020-10-14 18:12:19 +09:00
Leon Gebler	28d3295f9f	Test Class Fixes	2020-10-13 19:20:15 +02:00
Leon Gebler	7df9282727	CodeAnalysis fixes	2020-10-12 15:58:34 +02:00
Leon Gebler	8768891b12	Add testing for clicking mods through customisation menu	2020-10-12 14:41:05 +02:00
Dean Herbert	87bf3bdc16	Add the most basic implementation of LabelledSliderBar feasible	2020-10-06 17:26:06 +09:00
Dan Balasescu	54520faa7e	Merge pull request #10082 from EVAST9919/profile-sections-update ... Update section headers in ProfileOverlay in line with web	2020-09-11 14:53:17 +09:00
Bartłomiej Dach	97690c818c	Add regression test coverage	2020-09-11 00:12:05 +02:00
Andrei Zavatski	e5d0f3b657	Merge remote-tracking branch 'refs/remotes/ppy/master' into profile-sections-update	2020-09-10 20:23:02 +03:00
Andrei Zavatski	e39609d3ca	Implement PaginatedContainerWithHeader component	2020-09-07 23:08:50 +03:00
Andrei Zavatski	3a24cc1aa9	Implement PaginatedContainerHeader component	2020-09-07 22:13:29 +03:00
Salman Ahmed	0500f24a1d	Remove now-redundant test case	2020-09-04 10:24:54 +03:00
Dean Herbert	e465afa280	Merge branch 'master' into beatmap-track-rework	2020-08-14 20:02:43 +09:00
smoogipoo	3cb22fad82	Fix mods sharing bindable instances	2020-08-13 19:48:31 +09:00
smoogipoo	91e28b849d	Fix incorrect BeatmapManager construction	2020-08-13 00:29:23 +09:00
smoogipoo	322d08af1b	Remove more local music controller caches	2020-08-11 13:11:59 +09:00
smoogipoo	2351701ade	Fix test not having a long enough track	2020-08-07 23:08:51 +09:00
smoogipoo	5002d69f69	Update inspections	2020-08-07 20:51:56 +09:00
smoogipoo	61b632516e	Ensure CurrentTrack is never null	2020-08-07 19:43:16 +09:00
smoogipoo	5c05fe3988	Expose track from MusicController	2020-08-06 16:24:14 +09:00
smoogipoo	6e42b8219c	Move track to MusicController, compiles	2020-08-06 16:24:14 +09:00
Dean Herbert	d7e82efb67	Fix tests	2020-08-04 21:16:59 +09:00
Andrei Zavatski	dc559093cd	Rename namespace from Dashboard to Home	2020-08-02 21:47:09 +03:00
Andrei Zavatski	bddc61756a	Rework padding	2020-08-02 21:44:34 +03:00
Andrei Zavatski	b5f688e63a	Implement DashboardBeatmapListing component	2020-08-01 07:04:39 +03:00
Andrei Zavatski	7624804edf	Implement DashboardPopularBeatmapPanel component	2020-08-01 06:23:06 +03:00
Andrei Zavatski	ce47a34991	Implement DashboardNewBeatmapPanel component	2020-08-01 06:14:24 +03:00
Andrei Zavatski	74f70136fd	Implement DashboardBeatmapPanel component	2020-08-01 06:00:24 +03:00
Dean Herbert	c1b9b847ec	Merge branch 'master' into grey-logo-animation	2020-07-27 14:10:52 +09:00
jorolf	50f72ac9cb	rename classes	2020-07-22 22:10:59 +02:00
Andrei Zavatski	ad9492804a	Apply suggestions	2020-07-21 22:56:44 +03:00
Andrei Zavatski	e96f8f1cb6	Make content side padding adjustable for OverlayHeader	2020-07-21 20:02:22 +03:00
Dean Herbert	61b298d74d	Merge pull request #9571 from smoogipoo/fix-mod-selection	2020-07-16 16:04:43 +09:00
smoogipoo	1a6ae3194e	Add test	2020-07-15 19:45:48 +09:00
Dean Herbert	fe68e8276d	Merge branch 'master' into logo-shader	2020-07-15 19:06:35 +09:00
Dean Herbert	19ab973bb9	Add second layer to test scene	2020-07-15 18:48:20 +09:00
Andrei Zavatski	4c2294f0cd	Refactor LoadRepliesButton to inherit LoadingButton	2020-07-14 15:02:29 +03:00
Andrei Zavatski	56349e65f3	Rename arrow direction method	2020-07-14 03:01:14 +03:00
Andrei Zavatski	f6e4ecd960	Merge remote-tracking branch 'refs/remotes/ppy/master' into comments-buttons	2020-07-14 02:46:29 +03:00
Andrei Zavatski	6eec2f9429	Implement RankingsSortTabControl component	2020-07-13 01:22:05 +03:00
Andrei Zavatski	0d6dbb6523	Clean up exposed icon for tests	2020-07-12 13:36:42 +03:00
Andrei Zavatski	c9d21894e5	Add test for icon toggle	2020-07-12 13:19:28 +03:00
Andrei Zavatski	da40f29b44	Make button text a property	2020-07-12 12:27:26 +03:00
Andrei Zavatski	b1b2e961bc	Update arrow colour on hover	2020-07-11 08:13:11 +03:00
Andrei Zavatski	da249abd19	Implement CommentRepliesButton	2020-07-11 07:47:17 +03:00
Dean Herbert	664ab6d5f6	Merge branch 'master' into add-textbox-samples-and-fix-distingushing-passwords	2020-07-10 17:14:46 +09:00
jorolf	52b313f290	change textures	2020-07-04 19:06:26 +02:00
jorolf	6f0ec36407	remove size from hue animation	2020-06-24 16:27:00 +02:00
jorolf	768e28faba	generalize and simplify animation	2020-06-24 14:11:38 +02:00
Dean Herbert	14ad3835ff	Update naming	2020-06-23 21:27:01 +09:00
smoogipoo	ab10732a78	Remove usages of null-forgiving operator	2020-06-09 22:13:48 +09:00
Salman Ahmed	495f89ddae	Expand number text box test scene to one holding all OsuTextBox's types	2020-06-05 06:45:42 +03:00
smoogipoo	8aa8d2c880	Resolve NREs	2020-06-03 16:59:37 +09:00
smoogipoo	648999a2de	Remove all RequiredTypes usages	2020-05-16 18:17:12 +09:00
Dan Balasescu	e915f22516	Merge branch 'master' into schedule-music-controller-operations	2020-04-28 14:09:56 +09:00
Dean Herbert	0d752dc7b8	Remove redundant initialisation	2020-04-28 12:55:57 +09:00
Dean Herbert	743a92bbbe	Use a local database for now playing test	2020-04-28 12:42:08 +09:00
Dean Herbert	81e73acb1a	Fix tests failing when not run in certain order	2020-04-28 12:21:27 +09:00
Dan Balasescu	4fff08d241	Remove unused using	2020-04-28 12:19:39 +09:00
Dean Herbert	62be138aa9	Avoid calls on MusicController executing before it may have finished loading	2020-04-28 11:46:08 +09:00
Joehu	7731d45f13	Remove unnecessary usings	2020-04-26 20:30:56 -07:00
Joehu	8a47a615db	Remove unranked label from footer	2020-04-26 19:29:22 -07:00
Dean Herbert	c2ed6491a9	Move and shorten enum names	2020-04-21 15:39:15 +09:00
Dean Herbert	89320b510c	Apply class renaming	2020-04-21 15:13:19 +09:00
Dean Herbert	86e8aaa2f4	Merge branch 'master' into beatmap-listing-expanded	2020-04-16 16:15:40 +09:00
smoogipoo	9e2be6f2f4	Remove bindable to promote one-way access	2020-04-16 13:25:08 +09:00
Dean Herbert	06e25091f6	Fix typo	2020-04-16 10:44:08 +09:00
smoogipoo	102c1d9095	Add disabled state to menu items	2020-04-15 16:17:17 +09:00
Dean Herbert	c0a1aae63a	Merge branch 'master' into beatmap-listing-expanded	2020-04-15 13:26:16 +09:00
Andrei Zavatski	29dd225205	Make button protected	2020-04-13 10:45:15 +03:00
Andrei Zavatski	bdce79ed5b	Fix incorrect test step name	2020-04-13 09:57:05 +03:00
Andrei Zavatski	0eaff00787	Fix typo in test	2020-04-13 09:45:49 +03:00
Andrei Zavatski	99fa145847	Add test for potential failing case	2020-04-13 08:38:34 +03:00
Andrei Zavatski	518acf03e9	Remove BeatmapSearchSmallFilterRow component	2020-04-09 19:41:35 +03:00
Andrei Zavatski	b6d8e487d2	Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-listing-expanded	2020-04-09 19:18:59 +03:00
Andrei Zavatski	134feefa14	Remove bindable	2020-04-09 13:10:09 +03:00
Andrei Zavatski	2d3ea95469	Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-scroll-container	2020-04-09 13:06:22 +03:00
Dean Herbert	e10576325c	Merge branch 'master' into update-overlay-headers	2020-04-09 16:29:34 +09:00
Dean Herbert	53b2f58eda	Merge branch 'master' into overlay-scroll-container	2020-04-09 15:05:49 +09:00
Joehu	493b654011	Remove horizontal margin from mod display ... Can skew center alignment on fill flow containers. Fixes affected areas. Vector2(5, 0) is similar to MarginPadding { Left = 10 }.	2020-04-03 11:30:02 -07:00
Andrei Zavatski	e26fbd5ed8	Remove overcomplicated stuff	2020-03-31 13:45:59 +03:00
Andrei Zavatski	2dc81bbcfa	Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-scroll-container	2020-03-30 13:37:25 +03:00
Dean Herbert	35647d59a6	Add failing test	2020-03-30 19:09:05 +09:00
Andrei Zavatski	7b24cc325f	Implement OverlayScrollContainer component	2020-03-27 20:57:57 +03:00
TheWildTree	9a30ff5a00	Fix code quality issues	2020-03-26 16:11:58 +01:00
TheWildTree	a5781d7fc5	Replace ScreenTitle with OverlayTitle and update titles to match new design	2020-03-24 22:08:20 +01:00
杜Nate	9ea0137b01	Merge branch 'master' into spun-out	2020-03-23 18:13:53 +08:00
Dean Herbert	680d058f3f	Merge branch 'master' into friends-layout-split	2020-03-23 15:36:04 +09:00
Dean Herbert	bfd643dd16	Rename classes	2020-03-23 10:47:27 +09:00
Dean Herbert	0b728f483f	Rename base test class to help avoid incorrect reference	2020-03-23 10:01:33 +09:00
Andrei Zavatski	4ac740b12b	Remove APIFriend	2020-03-17 08:51:54 +03:00
Andrei Zavatski	544dfe7dd3	Implement FriendsLayout component	2020-03-16 09:42:21 +03:00
Andrei Zavatski	1318f242c1	Revert changes to basic implementation and remove redundant stuff	2020-03-06 02:12:30 +03:00
Andrei Zavatski	c08e16d97f	Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-listing-expanded	2020-03-06 01:27:51 +03:00
Andrei Zavatski	bd03dd9b70	Adjust class naming	2020-03-04 23:08:58 +03:00
杜Nate	cf88e3ff19	Merge branch 'master' into spun-out	2020-03-04 17:38:35 +08:00
Andrei Zavatski	4d5445b5dc	Rename Amount to Count	2020-03-04 00:31:06 +03:00
Andrei Zavatski	06b23b626e	Simplify test scene setup	2020-03-04 00:15:10 +03:00
Andrei Zavatski	83dad93b6d	Make Populate() accept list of users	2020-03-03 18:08:51 +03:00
Andrei Zavatski	160d64eecf	FriendsOnlineStatusControl basic implementation	2020-03-03 17:37:01 +03:00
Andrei Zavatski	7bc9a9b3d8	Implement OverlayPanelDisplayStyleControl and UserListToolbar components	2020-02-24 07:28:33 +03:00
Andrei Zavatski	0cfe1ac823	Implement UserSortTabControl component	2020-02-24 05:47:21 +03:00
Dean Herbert	7d145a7470	Add test for loading spinner with box	2020-02-21 16:21:44 +09:00
Dean Herbert	bbac95958c	Fix incorrect test scene name	2020-02-21 16:20:55 +09:00
Dean Herbert	38d9a46ffb	Add test for relative sizing scenarios	2020-02-21 16:20:17 +09:00
Dean Herbert	92f6f0207c	Rename LoadingAnimation to LoadingSpinner	2020-02-21 15:33:31 +09:00
Dean Herbert	623b78d675	Combine all loading animation implementations	2020-02-21 15:32:46 +09:00
smoogipoo	2cb218c9c4	Merge remote-tracking branch 'origin/master' into comment-editor	2020-02-21 12:27:34 +09:00
Andrei Zavatski	3c56118f45	Implement BeatmapSearchParameters and refactor all the components	2020-02-21 02:28:33 +03:00
Dean Herbert	3380dbbd71	Improve visual appearance of ProcessingOverlay	2020-02-20 19:49:22 +09:00
Andrei Zavatski	37003e11b9	Make fields readonly	2020-02-18 18:04:39 +03:00
Andrei Zavatski	bb22243903	TestScene improvements	2020-02-18 17:47:44 +03:00
Andrei Zavatski	7228900361	Implement BeatmapListingSearchSection component	2020-02-18 17:25:12 +03:00
Dan Balasescu	75e0668b4e	Merge branch 'master' into new-direct-sort	2020-02-18 10:17:26 +09:00
Andrei Zavatski	410686c8b9	Use dropdown in BeatmapSearchFilterRow	2020-02-18 01:04:25 +03:00
Andrei Zavatski	19872d9e24	Simplify test scene	2020-02-17 22:05:10 +03:00
Andrei Zavatski	d985a22f77	Add missing blank line	2020-02-17 03:52:26 +03:00
Andrei Zavatski	fe7923b7e8	Add SortDirection Bindable and refactor to make everything work	2020-02-17 03:38:14 +03:00
Andrei Zavatski	2ba0bd872b	Implement basic BeatmapListingSortTabControl	2020-02-17 02:35:46 +03:00
Andrei Zavatski	ea285fd005	Refactor with including headers	2020-02-17 00:44:55 +03:00
Andrei Zavatski	e62fec58c1	Add ability to override text size	2020-02-16 16:38:05 +03:00
Andrei Zavatski	a71e410e5d	Make the filter autosized	2020-02-16 15:04:21 +03:00
Andrei Zavatski	3888911eee	Implement BeatmapSearchFilter component	2020-02-16 14:19:49 +03:00
Bartłomiej Dach	0f25864fae	Textbox -> TextBox rename pass	2020-02-13 21:04:53 +01:00
Bartłomiej Dach	5646083ed9	Adjust code style in test	2020-02-13 21:01:25 +01:00
Bartłomiej Dach	09b2e7beed	Encapsulate test editors	2020-02-13 20:56:34 +01:00
Bartłomiej Dach	cc625e3b89	Move initialisation logic to [SetUp]	2020-02-13 20:44:02 +01:00
smoogipoo	d4f14e552a	Improve extensibility of mod display expansion	2020-02-13 18:05:53 +09:00
Andrei Zavatski	c391a464a5	Add tests	2020-02-13 04:06:34 +03:00
Andrei Zavatski	9ac6c271ac	Naming adjustments	2020-02-12 02:05:45 +03:00
Andrei Zavatski	c022cf72b5	Implement CancellableCommentEditor	2020-02-11 20:47:51 +03:00
Andrei Zavatski	829152c8e8	Implement EditorTextbox	2020-02-11 20:08:24 +03:00
Andrei Zavatski	482f622c94	CommentEditor basic implementation	2020-02-11 18:46:49 +03:00
Bartłomiej Dach	7e28f2fe6a	Rename test to better reflect its purpose	2020-02-09 14:41:02 +01:00
Bartłomiej Dach	404cb61342	Open mod select in a more reliable way	2020-02-09 14:39:27 +01:00
ProTheory8	590429b43b	Now TestAutoOpenOnModSelect checks if customisation closes after deselecting mod	2020-02-09 14:15:32 +05:00
杜Nate	8d480c794a	Merge branch 'master' into spun-out	2020-02-08 13:54:39 +08:00
mcendu	a4637a24a6	fix test scene crash	2020-02-08 12:08:44 +08:00
mcendu	2d67215931	make target practice subject of unimplemented mod test	2020-02-08 12:07:21 +08:00
smoogipoo	e4e0a26b62	Merge remote-tracking branch 'origin/master' into rearrangeable-playlist	2020-02-04 16:55:55 +09:00
Dan Balasescu	3600b0daf0	Merge branch 'master' into fix-mod-select-overflowing	2020-02-04 11:57:54 +09:00
Dan Balasescu	76ba0b833e	Merge pull request #7716 from EVAST9919/overlay-header-ruleset-selector ... Add ability to create ruleset selector in OverlayHeader	2020-02-03 19:00:12 +09:00
Dan Balasescu	c6e7603e5e	Merge branch 'master' into safe-screen-lease	2020-02-03 18:18:13 +09:00
Andrei Zavatski	81ab6d43b6	Add ability to create ruleset selector in OverlayHeader	2020-02-03 11:09:46 +03:00
Dan Balasescu	93952d438f	Merge pull request #7677 from peppy/decouple-mod-select-bindable ... Decouple ModSelectOverlay from global SelectedMods	2020-02-03 16:27:47 +09:00
Joehu	583fee074f	Fix mod select not showing up in mod settings test	2020-02-01 11:50:24 -08:00
Joehu	609ee26030	Fix mod select overlay not showing up in test	2020-02-01 11:41:41 -08:00
Dean Herbert	19f516e710	Ensure OsuScreen level leases are taken out synchronously	2020-01-31 19:10:44 +09:00
Dean Herbert	8e966624e0	Fix regressing tests	2020-01-30 19:55:25 +09:00
smoogipoo	00a7adcdca	Further refactorings	2020-01-30 19:21:24 +09:00
Andrei Zavatski	10e8361e7c	Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-ruleset-selector	2020-01-30 10:08:39 +03:00
Dean Herbert	bea20efb64	Merge branch 'master' into mod_content_centering	2020-01-30 10:34:46 +09:00
smoogipoo	ebf15c6a1c	General work towards completion + framework updates	2020-01-29 12:17:03 +09:00
smoogipoo	2b2cfd91a6	Initial re-implementation using rearrangeable list	2020-01-28 17:59:14 +09:00
Andrei Zavatski	97fb7a5593	Add test scene	2020-01-27 15:42:46 +03:00
Andrei Zavatski	e6fa793d56	Refactor background creation in OverlayHeader	2020-01-27 15:36:19 +03:00
Dean Herbert	e37ae589ad	Merge branch 'master' into no-control-overlay-headers	2020-01-27 18:35:33 +09:00
smoogipoo	431b1489b9	Add test	2020-01-27 13:16:36 +09:00
Andrei Zavatski	7cd60e3193	Make OverlayRulesetSelector use colour provider	2020-01-26 17:07:17 +03:00
Andrei Zavatski	a72250acc6	Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-ruleset-selector	2020-01-26 16:52:56 +03:00
Andrei Zavatski	cd0fcfabd9	Merge master with conflicts resolved	2020-01-26 16:35:07 +03:00
Andrei Zavatski	2b941a0d52	Merge remote-tracking branch 'refs/remotes/ppy/master' into no-control-overlay-headers	2020-01-24 10:18:45 +03:00
ProTheory8	9de4424aec	Removed TestModCustomisable3	2020-01-21 19:32:53 +05:00
ProTheory8	b8d2012fc3	Added test	2020-01-21 15:26:51 +05:00
Andrei Zavatski	30edd80c8c	Refactor OverlayHeader hierarchy	2020-01-21 06:00:12 +03:00
Andrei Zavatski	4a5e855953	Rename test scene	2020-01-20 12:21:21 +03:00
Andrei Zavatski	17a7a75707	Merge master with conflicts resolved	2020-01-20 08:52:03 +03:00
Andrei Zavatski	11e7c8be3f	Use colour schemes for OverlayRulesetSelector	2020-01-20 08:34:46 +03:00
Andrei Zavatski	6552097866	Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-ruleset-selector	2020-01-20 08:22:30 +03:00
Dean Herbert	3f2512295c	Merge pull request #7555 from peppy/update-framework ... Update framework	2020-01-18 15:57:16 +09:00
Dean Herbert	e8e6897603	Remove unnecessary linq count usage	2020-01-18 15:27:21 +09:00
mcendu	e096688ac8	simplify some stuff	2020-01-16 17:58:47 +08:00
mcendu	4c18a67268	add test step	2020-01-15 18:24:43 +08:00
mcendu	052772cce7	add test case	2020-01-15 18:15:56 +08:00
mcendu	62615fb8c1	format	2020-01-15 18:00:14 +08:00
mcendu	a0b6cadab5	add test scene	2020-01-15 17:36:27 +08:00
Dean Herbert	14829837c4	Update namespace specifications	2020-01-10 01:38:03 +08:00
Dean Herbert	56724d2580	Merge branch 'master' into #7146	2020-01-10 01:08:20 +08:00
Dean Herbert	26c80e35fb	Fix missing namespace	2020-01-09 17:17:08 +08:00
Dean Herbert	ab9603b06a	Merge remote-tracking branch 'upstream/master' into #7146	2020-01-09 17:08:12 +08:00
smoogipoo	91735ff367	Update MathUtils namespace usages	2020-01-09 13:43:44 +09:00
Andrei Zavatski	351aaf41d9	Fix parameter naming	2020-01-08 00:54:02 +03:00
Andrei Zavatski	eb828154ee	Allow any type to be used to create TabControl	2020-01-08 00:41:52 +03:00
Bartłomiej Dach	e0cfc2f405	Merge branch 'master' into prev-button-revamp	2020-01-07 21:49:53 +01:00
smoogipoo	4a68c79137	Make tests safer against async loads / transforms	2020-01-07 13:21:25 +09:00
smoogipoo	20ab415838	Reword tests	2020-01-06 18:08:53 +09:00
smoogipoo	ee15967c4a	Rewrite test scene to be automated	2020-01-06 17:15:59 +09:00
Andrei Zavatski	d3c2dc43bd	TestScene improvements	2020-01-04 22:25:08 +03:00
Andrei Zavatski	9af9da039d	Implement proper PageSelectorItem	2020-01-04 21:14:56 +03:00
Andrei Zavatski	70387c19f3	Implement proper DrawablePage component	2020-01-04 19:36:05 +03:00
Andrei Zavatski	6fbbee3093	Move PageSelector to another namespace and organize TestScene	2020-01-04 19:03:39 +03:00
Andrei Zavatski	6eebb11a92	Merge remote-tracking branch 'refs/remotes/ppy/master' into page-selector	2020-01-04 18:48:27 +03:00
Andrei Zavatski	53c8592cb9	Add test scene	2020-01-03 23:54:56 +03:00
Willy Tu	e23c71be80	Update Resolved and Cached attribute issues	2020-01-03 11:34:26 -08:00
Willy Tu	0a4e180ce7	Merge branch 'master' of github.com:ppy/osu into #7146	2020-01-03 11:32:06 -08:00
Andrei Zavatski	55777c24ce	Merge remote-tracking branch 'refs/remotes/ppy/master' into overlay-ruleset-selector	2020-01-03 20:25:28 +03:00
Dean Herbert	43903b2fea	Make test scene usable	2020-01-02 14:24:58 +09:00
Andrei Zavatski	2d6a07e970	Fix OverlayRulesetSelector don't have default colour	2020-01-01 23:14:26 +03:00
Andrei Zavatski	af248457b0	Implement OverlayRulesetSelector	2020-01-01 22:49:04 +03:00
Viktor Rosvall	f40ebc83ca	Begun refractorization process of wrapping Button text in a FillFlowContainer	2019-12-30 23:58:49 +01:00
Viktor Rosvall	e85910c4e4	removed unnecessary test code	2019-12-29 09:18:27 +01:00
Viktor Rosvall	bf463fe5e0	adjusted the margin values	2019-12-29 08:57:14 +01:00
Bartłomiej Dach	fd8c5d7706	Improve notification overlay test robustness ... Stress testing one of the notification overlay tests by running it 10000 times on repeat has shown that it is susceptible to intermittent failures due to races between delays and asserts checking the number of currently progressing notifications and the actual progress update, which contains a random generation factor. Replace step sequences checking for notification completion by waiting and asserting with explicit until steps that don't terminate unless there are zero progressing notifications.	2019-12-26 23:01:31 +01:00
Willy Tu	8353c893c0	Update BodyText of LocalScoreDeleteDialog	2019-12-20 12:00:10 -08:00
Willy Tu	a55e5c5c43	Removed unnecessary code	2019-12-20 11:16:54 -08:00
Willy Tu	ba2cff60ca	Removed Automation Testing steps for delete local scores. Only manual testing now.	2019-12-20 02:13:49 -08:00
Willy Tu	afc11aa547	Fixed issues caused by renaming variables	2019-12-19 22:37:09 -08:00
Willy Tu	6672cf6059	Update variable name	2019-12-19 22:22:46 -08:00
Willy Tu	6abbd33b51	Fixed CI issues	2019-12-19 21:57:14 -08:00
Willy Tu	e42894cfcf	Fixed error for CodeFactor	2019-12-19 21:32:54 -08:00
Willy Tu	8ab26e8889	Update Tests with dependencies on LeaderboardScore. Added its dependency on DialogOverlay for the tests. Added test for deleting individual local score	2019-12-19 21:29:54 -08:00
smoogipoo	4e11fb0fd7	Merge remote-tracking branch 'refs/remotes/origin/master' into multiplier-text	2019-12-18 19:36:16 +09:00
Ganendra Afrasya	0e658790c1	Add function to assert multiplier value instead of hardcoded string	2019-12-15 22:42:44 +07:00
Huo Yaoyuan	c457571da6	Use index and range expressions	2019-12-15 20:17:35 +08:00
Dean Herbert	244eb56455	Fix test ruleset availability	2019-12-15 03:01:37 +09:00
Dean Herbert	bc31146560	Mods -> SelectedMods	2019-12-13 21:45:38 +09:00
Dean Herbert	76aa4f9fb2	Fix code style issues	2019-12-13 21:36:50 +09:00
Dean Herbert	7fdaf338f3	Fix test logic and add regression test	2019-12-13 21:36:50 +09:00
Dean Herbert	f349e7ff78	Fix non-null ?? usage	2019-12-13 20:35:34 +09:00
Dean Herbert	0bbaf9b7fb	Fix mod select overlay tests not running individually	2019-12-13 20:21:35 +09:00
Dean Herbert	7033974733	Fix test regressions (incorrect from the start)	2019-12-13 20:13:32 +09:00
Dean Herbert	138b83c9ea	Merge branch 'master' into customized-mods	2019-12-10 19:13:32 +09:00
Dean Herbert	f65866648e	Use Array.Empty	2019-12-06 20:14:56 +09:00
Dean Herbert	347373a3ba	Fix test failures	2019-12-06 19:04:55 +09:00
Dean Herbert	46d055604a	Customize -> Customise	2019-12-06 18:59:45 +09:00
Dean Herbert	680b2653ae	Improve animation of popup dialog buttons	2019-12-06 18:51:30 +09:00
Dean Herbert	a5d5099868	Use SettingsSource for mod cusomisation	2019-12-06 17:09:48 +09:00
Dean Herbert	af35df4077	Add multiple mod testing and update test code style	2019-12-06 15:42:11 +09:00
Dean Herbert	65201cf635	Merge branch 'master' into page-selector	2019-12-05 14:31:19 +09:00
Ganendra Afrasya	af5c5a3000	Apply reviews ... Also rename the class name to match with the others	2019-11-28 20:06:15 +07:00
Ganendra Afrasya	6149482b5d	Add test	2019-11-28 12:03:11 +07:00
Dean Herbert	01a37771bc	Merge branch 'master' into customized-mods	2019-11-27 19:44:32 +09:00
Dean Herbert	5da5abdb05	Merge branch 'master' into prev-button-revamp	2019-11-22 02:57:22 +09:00
unknown	15e85234e4	remove unecessary step	2019-11-15 11:12:51 +08:00
Dean Herbert	5bb65d0716	Rename button class	2019-11-12 10:21:06 +09:00
Dean Herbert	54da8e4035	Combine similar tests	2019-11-11 19:09:38 +09:00
Dean Herbert	82cc6aa0c5	Remove unused constructor	2019-11-11 19:00:14 +09:00
Dean Herbert	bed62e0d2f	Rename ThreeState -> TernaryState and add basic tests	2019-11-11 18:56:18 +09:00
Dean Herbert	ce4843be22	Move tests to parent namespace for now	2019-11-11 18:42:32 +09:00
smoogipoo	92d8526370	Adjust test namespaces	2019-11-08 13:34:27 +09:00
smoogipoo	e574aa0e94	Add toggle menu item test	2019-11-08 13:33:15 +09:00
smoogipoo	011bf09516	Add xmldocs and cleanup	2019-11-08 13:23:13 +09:00
smoogipoo	0a15a13fab	Reorder parameters	2019-11-08 13:23:13 +09:00
smoogipoo	30f877c4ab	Implement a three-state menu item	2019-11-08 13:23:13 +09:00
smoogipoo	ce08d664a5	Abstract statefulness of new menu item type	2019-11-08 13:23:13 +09:00
smoogipoo	c3a3b4091b	Add basic implementation of a toggleable menu item	2019-11-07 22:26:35 +09:00
Bartłomiej Dach	963215ccbe	Wait for track reset in tests ... Add a wait step in tests for the "now playing" overlay to make sure the current track was restarted before trying to call PreviousTrack() again.	2019-11-06 22:43:13 +01:00
Bartłomiej Dach	70feab8316	Merge branch 'master' into prev-button-revamp	2019-11-06 22:41:33 +01:00
unknown	a92b32f6dc	add basic tests	2019-11-05 00:56:09 +08:00
smoogipoo	45af796943	Remove usages of EF internals	2019-10-30 17:05:15 +09:00
Dan Balasescu	514c9f1eef	Merge branch 'master' into bindable-control-points	2019-10-30 16:20:54 +09:00
Dean Herbert	ecf14bc7b9	Rename class to match	2019-10-29 01:21:17 +09:00
Dean Herbert	08040adfad	Expose Current bindable in LabelledComponents ... Adds a `LabelledDrawable` class for usages where bindables are not present.	2019-10-28 16:24:28 +09:00
Dean Herbert	e987db37ec	Add grouping of ControlPoints	2019-10-25 19:52:02 +09:00
Dean Herbert	7f64012cfc	Remove seek	2019-10-24 14:35:45 +09:00
Dean Herbert	f32b84d07d	Fix tests not working on CI (where no beatmaps were present)	2019-10-24 14:05:56 +09:00
Dean Herbert	42e33dde0c	Make tests actually test	2019-10-24 13:18:31 +09:00
Dean Herbert	967551fec0	Renames and xmldoc	2019-10-24 13:10:17 +09:00
Ganendra Afrasya	736a36a326	Fix failed testcase	2019-10-16 14:30:09 +07:00
Ganendra Afrasya	b07c477aad	Add test case on TestSceneNowPlayingOverlay	2019-10-11 01:24:03 +07:00
Dean Herbert	4446a2972c	Move WaveContainer test out of editor namespace	2019-10-08 18:08:05 +09:00
Dean Herbert	193a9b0dd7	Merge branch 'master' into labelled-switch-button	2019-09-29 14:56:26 +08:00
smoogipoo	9f77a1ef35	Adjust namespaces	2019-09-25 17:53:08 +09:00
smoogipoo	d32a0acd10	Merge remote-tracking branch 'origin/master' into labelled-switch-button	2019-09-25 17:51:12 +09:00
smoogipoo	c9e39c124e	Add a labelled switch button	2019-09-25 17:42:35 +09:00
smoogipoo	261ba5c80a	Fix button not transforming correctly in some cases	2019-09-25 17:42:27 +09:00
Dean Herbert	654b815b36	Merge remote-tracking branch 'upstream/master' into back-button-part-2	2019-09-25 14:38:39 +09:00
Dean Herbert	f493f1c71d	Move new components to v2 namespace	2019-09-24 19:00:26 +09:00
smoogipoo	028c958431	Initial implementation of a switch button	2019-09-24 18:39:11 +09:00
smoogipoo	6b702eb6de	Update with generic labelledcomponent	2019-09-24 18:25:17 +09:00
smoogipoo	5212c50654	Merge branch 'generic-labelledcomponent' into labelled-textbox-improvements	2019-09-24 18:23:01 +09:00
smoogipoo	df692b091c	Make LabelledComponent generic	2019-09-24 18:22:02 +09:00
smoogipoo	2bbf4ca4b5	Update LabelledTextBox to use LabelledComponent	2019-09-20 18:50:50 +09:00
smoogipoo	e0a97cfac5	Add a LabelledComponent base class	2019-09-20 18:35:15 +09:00
Andrei Zavatski	41be9b3f8f	Add asserts to the test scene	2019-09-19 16:45:38 +03:00
Andrei Zavatski	708dfa2bdc	Merge remote-tracking branch 'refs/remotes/ppy/master' into page-selector	2019-09-19 16:37:51 +03:00
Dean Herbert	23c5cb6367	Expand tests to cover new behaviour	2019-09-19 22:35:14 +09:00
Dean Herbert	50d4206c45	Fix exit scenarios	2019-09-19 20:17:58 +09:00
Dean Herbert	a7c59098ce	Fix missing assignment	2019-09-13 17:38:04 +09:00
Dean Herbert	7cb79dd760	Fix incorrect DI usage of IAPIProvider in many tests	2019-09-13 17:15:33 +09:00
Dean Herbert	44947aa9ed	Make PopupDialog abstract	2019-09-13 15:27:29 +09:00
Andrei Zavatski	bee7760d29	Make MaxPages value a bindable	2019-09-10 01:36:25 +03:00
Andrei Zavatski	b97f4a81db	Add more testing	2019-09-08 00:27:40 +03:00
Andrei Zavatski	cea26baaef	Implement placeholder and correct redraw algorithm	2019-09-07 08:46:16 +03:00
Andrei Zavatski	508b26ac69	Implement basic layout	2019-09-07 07:31:07 +03:00
Dean Herbert	4df6bd5477	Merge branch 'master' into use-dummy-api-for-overall-tests	2019-09-05 14:27:01 +09:00
Dean Herbert	53fe290ef3	Merge branch 'master' into back-button-part-2	2019-09-03 19:44:30 +09:00
jorolf	3b769128a8	Add a 60bpm beat when no beatmap is playing	2019-09-03 00:57:29 +02:00
Dean Herbert	fd26ef739a	Merge remote-tracking branch 'upstream/master' into back-button-part-2	2019-08-21 15:23:54 +09:00
Dean Herbert	48716f8f2b	Update framework	2019-08-21 13:29:50 +09:00
Dean Herbert	3949d46383	Add test fix to other test	2019-08-16 13:46:08 +09:00
Dean Herbert	ef5ed915e5	Reduce delay for hold-to-confirm controls	2019-08-15 17:14:00 +09:00
Dean Herbert	5886420a5d	Merge branch 'master' into back-button-part-2	2019-08-13 21:38:31 +09:00
Dean Herbert	ad24265730	Split visual component out of MusicController	2019-08-13 14:30:18 +09:00
David Zhao	4a28bdd384	Merge remote-tracking branch 'upstream/master' into back-button-part-2	2019-08-13 12:26:12 +09:00
Dean Herbert	4ccac60337	Merge remote-tracking branch 'upstream/master' into refactor-osd	2019-08-13 11:35:54 +09:00
Lucas A	5e49d0fb28	Fix CI issues	2019-08-12 12:11:01 +02:00
Lucas A	6533f114d4	Apply review suggestions	2019-08-12 12:09:09 +02:00
Dean Herbert	31fe121fe9	Merge remote-tracking branch 'RedMindZ/master' into autopilot	2019-08-12 14:40:52 +09:00
Dean Herbert	c2e2c1e67e	Merge branch 'master' into refactor-osd	2019-08-11 13:13:12 +09:00
iiSaLMaN	849ed0c69d	Acquire api access for online tests	2019-07-31 22:44:44 +03:00
David Zhao	f81e691bf5	Merge remote-tracking branch 'upstream/master' into back-button-part-2	2019-07-31 16:03:14 +09:00
David Zhao	6d1203a599	Move screen pushes into function, rename receptor	2019-07-30 12:00:04 +09:00
David Zhao	e8c039bb8a	Use a receptor model instead	2019-07-29 18:45:16 +09:00
Dean Herbert	c514cbe2b7	Add basic skinning test	2019-07-29 17:27:00 +09:00
Dean Herbert	a24e57dd3d	Merge branch 'master' into refactor-osd	2019-07-28 13:10:01 +09:00
Lucas A	09d679de8d	Move text display layout to Toast.	2019-07-12 08:50:53 +02:00
Dean Herbert	2c62891c48	Make Toast base class abstract	2019-07-11 15:15:34 +09:00
Dean Herbert	3bc789fca8	Remove osd prefix and prefer upper-case OSD	2019-07-11 15:09:54 +09:00
Dean Herbert	72362d92d4	Fix a few inspections from EAP r#	2019-07-08 16:34:11 +09:00
Lucas A	bc60b1dc13	Add test for empty OsdToast	2019-07-05 16:04:47 +02:00
David Zhao	4eb01b12be	Convert to method	2019-07-05 13:10:59 +09:00
David Zhao	9eeafa0861	Merge branch 'buttonsystem-entermode' of https://github.com/nyquillerium/osu into buttonsystem-entermode	2019-07-05 13:08:48 +09:00
David Zhao	79d6670dc5	Expose durations from MainMenu and reorder	2019-07-05 13:08:45 +09:00
Dean Herbert	29bc2a2751	Split out tests	2019-07-05 11:29:47 +09:00
David Zhao	07078b735c	use new vector2	2019-07-04 17:06:28 +09:00
David Zhao	8e951d423f	Merge branch 'buttonsystem-entermode' of https://github.com/nyquillerium/osu into buttonsystem-entermode	2019-07-04 17:05:47 +09:00
David Zhao	530675f364	Add tests as separate steps	2019-07-04 17:05:29 +09:00
smoogipoo	f6f547a91b	Fix ruleset selector line not moving on first display	2019-06-27 18:25:38 +09:00
Dan Balasescu	f06aabad5f	Merge branch 'master' into toolbar-rulesets-refactor	2019-06-26 18:33:45 +09:00
Andrei Zavatski	08e31159fc	Make testcase even more useful	2019-06-25 14:27:29 +03:00
Dean Herbert	e87e4077e8	Add testability of dismissal	2019-06-25 20:23:43 +09:00
smoogipoo	5b294ba419	Adjust backbutton animation	2019-06-25 18:33:35 +09:00
smoogipoo	4ed14a295d	Make TLB test scene test TLB and not back button	2019-06-25 18:33:30 +09:00
Andrei Zavatski	35516e7304	Merge remote-tracking branch 'refs/remotes/ppy/master' into toolbar-rulesets-refactor	2019-06-24 22:52:24 +03:00
Dan Balasescu	18d64df0c4	Merge branch 'master' into add-numberbox	2019-06-24 15:22:30 +09:00
Andrei Zavatski	60ff497add	Merge remote-tracking branch 'refs/remotes/ppy/master' into toolbar-rulesets-refactor	2019-06-24 01:06:54 +03:00
Unknown	16a4805f1f	add OsuNumberBox with basic tests	2019-06-21 15:04:52 +02:00
Dean Herbert	c2b451a55f	Fix ModSelectOverlay tests failing due to asynchronous loading	2019-06-21 17:51:25 +09:00
Dan Balasescu	73d307114f	Merge branch 'master' into notification-overlay-always-present	2019-06-21 13:12:04 +09:00
Dean Herbert	fa94f063be	Use correct button type	2019-06-21 00:26:55 +09:00
Dean Herbert	fa263b91a7	Attempt to fix tests	2019-06-21 00:12:39 +09:00
Dean Herbert	7b4180ce86	Fix failing test	2019-06-20 23:51:47 +09:00
Dean Herbert	8c383ddc27	Fix dodgy test scheduling to other tests	2019-06-20 19:23:27 +09:00
Dean Herbert	21a1fd738b	Remove the necessity for NotificationOverlay to always be present ... Now it will only become present when there is a pending notification.	2019-06-20 19:06:21 +09:00
Dean Herbert	cd2999d0d1	Rename mod select test scene	2019-06-20 01:40:58 +09:00
Andrei Zavatski	cecbcd21b2	Merge remote-tracking branch 'upstream/master' into toolbar-rulesets-refactor	2019-06-17 23:12:55 +03:00
Dean Herbert	1b75fbed9a	Merge remote-tracking branch 'upstream/master' into update-scrollcontainer	2019-06-14 23:25:17 +09:00
Dean Herbert	bc574520bf	Update ScrollContainer usages in line with framework changes	2019-06-14 15:55:32 +09:00
Dean Herbert	15b9b53d35	Fix IconButtons not being scaled correctly	2019-06-14 13:40:32 +09:00
EVAST9919	3150b5cfb4	Naming adjustments	2019-06-12 20:51:21 +03:00
EVAST9919	065b4cd055	Merge remote-tracking branch 'refs/remotes/ppy/master' into toolbar-rulesets-refactor	2019-06-12 20:35:51 +03:00
Dean Herbert	606be3d7ce	Merge branch 'master' into backgrounded-beatmap-status-lookups	2019-06-12 00:22:47 +09:00
Dean Herbert	00ee45fe46	Merge remote-tracking branch 'origin/update-visibility-container' into update-framework	2019-06-11 19:36:13 +09:00
Arphox	07e17518e9	Fix all "Maintainability" CodeFactor issues	2019-06-11 10:28:16 +02:00
Dean Herbert	609a82bc94	Update VisibilityContainer usage in line with framework	2019-06-11 15:13:58 +09:00
smoogipoo	f090e292c9	Move ArchiveModelManager import process to async flow	2019-06-10 13:42:22 +09:00
EVAST9919	ff9dc18928	TestCaseImprovements	2019-06-10 03:54:15 +03:00
EVAST9919	9b8540d818	Add a testcase	2019-06-10 03:35:00 +03:00
Dean Herbert	011ccffde7	Add an input source toggle on manual input test scenes (#4945) ... Add an input source toggle on manual input test scenes	2019-06-07 20:26:26 +09:00
Dean Herbert	1374da7c41	Remove all calls to return user input	2019-06-07 12:54:57 +09:00
Dean Herbert	6f6b134ec8	Remove return user input calls	2019-06-07 12:52:49 +09:00
Dean Herbert	748c0e5c01	Set default state of test to enabled	2019-06-07 12:42:01 +09:00
Dean Herbert	58174425ed	Make visual test more visible	2019-06-07 12:37:10 +09:00
Dean Herbert	694f2e3a4f	Tidy up test scene's setup usage	2019-06-07 11:59:07 +09:00
Dean Herbert	64d5aa318f	Apply rebased changes	2019-06-07 11:45:58 +09:00
RedMindZ	e9592b1ebe	Merge branch 'master' into autopilot	2019-06-05 15:56:30 +03:00
Dean Herbert	2538f32fae	Merge branch 'osu-clickable-container' into OsuHoverContainer	2019-06-05 10:34:20 +09:00
Dean Herbert	1d9274427b	Merge branch 'master' into osu-clickable-container	2019-06-04 21:55:14 +09:00
smoogipoo	ff647940ca	Fix incorrect assertion	2019-06-04 19:25:34 +09:00