Merge branch 'master' into notification-overlay-always-present

osu.Desktop/Overlays/VersionManager.cs

@@ -2,6 +2,7 @@
 // See the LICENCE file in the repository root for full licence text.
 
 using osu.Framework.Allocation;
+using osu.Framework.Development;
 using osu.Framework.Graphics;
 using osu.Framework.Graphics.Containers;
 using osu.Framework.Graphics.Sprites;
@@ -12,7 +13,6 @@ using osu.Game.Graphics;
 using osu.Game.Graphics.Sprites;
 using osu.Game.Overlays;
 using osu.Game.Overlays.Notifications;
-using osu.Game.Utils;
 using osuTK;
 using osuTK.Graphics;
 
@@ -61,7 +61,7 @@ namespace osu.Desktop.Overlays
                                 },
                                 new OsuSpriteText
                                 {
-                                    Colour = DebugUtils.IsDebug ? colours.Red : Color4.White,
+                                    Colour = DebugUtils.IsDebugBuild ? colours.Red : Color4.White,
                                     Text = game.Version
                                 },
                             }

osu.Game.Tests/Visual/UserInterface/TestSceneModSelectOverlay.cs

@@ -216,13 +216,13 @@ namespace osu.Game.Tests.Visual.UserInterface
 
         private void testRankedText(Mod mod)
         {
-            AddWaitStep("wait for fade", 1);
+            waitForLoad();
             AddAssert("check for ranked", () => modSelect.UnrankedLabel.Alpha == 0);
             selectNext(mod);
-            AddWaitStep("wait for fade", 1);
+            waitForLoad();
             AddAssert("check for unranked", () => modSelect.UnrankedLabel.Alpha != 0);
             selectPrevious(mod);
-            AddWaitStep("wait for fade", 1);
+            waitForLoad();
             AddAssert("check for ranked", () => modSelect.UnrankedLabel.Alpha == 0);
         }
 
@@ -232,6 +232,7 @@ namespace osu.Game.Tests.Visual.UserInterface
 
         private void checkSelected(Mod mod)
         {
+            waitForLoad();
             AddAssert($"check {mod.Name} is selected", () =>
             {
                 var button = modSelect.GetModButton(mod);
@@ -239,8 +240,14 @@ namespace osu.Game.Tests.Visual.UserInterface
             });
         }
 
+        private void waitForLoad()
+        {
+            AddUntilStep("wait for icons to load", () => modSelect.AllLoaded);
+        }
+
         private void checkNotSelected(Mod mod)
         {
+            waitForLoad();
             AddAssert($"check {mod.Name} is not selected", () =>
             {
                 var button = modSelect.GetModButton(mod);
@@ -254,6 +261,8 @@ namespace osu.Game.Tests.Visual.UserInterface
         {
             public new Bindable<IReadOnlyList<Mod>> SelectedMods => base.SelectedMods;
 
+            public bool AllLoaded => ModSectionsContainer.Children.All(c => c.ModIconsLoaded);
+
             public ModButton GetModButton(Mod mod)
             {
                 var section = ModSectionsContainer.Children.Single(s => s.ModType == mod.Type);

osu.Game/Online/Chat/StandAloneChatDisplay.cs

@@ -130,6 +130,11 @@ namespace osu.Game.Online.Chat
 
             public StandAloneDrawableChannel(Channel channel)
                 : base(channel)
+            {
+            }
+
+            [BackgroundDependencyLoader]
+            private void load()
             {
                 ChatLineFlow.Padding = new MarginPadding { Horizontal = 0 };
             }

osu.Game/OsuGame.cs

@@ -184,6 +184,8 @@ namespace osu.Game
             LocalConfig.BindWith(OsuSetting.VolumeInactive, userInactiveVolume);
 
             IsActive.BindValueChanged(active => updateActiveState(active.NewValue), true);
+
+            Beatmap.BindValueChanged(beatmapChanged, true);
         }
 
         private ExternalLinkOpener externalLinkOpener;
@@ -284,6 +286,23 @@ namespace osu.Game
             }, $"watch {databasedScoreInfo}", bypassScreenAllowChecks: true);
         }
 
+        #region Beatmap jukebox progression
+
+        private void beatmapChanged(ValueChangedEvent<WorkingBeatmap> beatmap)
+        {
+            var nextBeatmap = beatmap.NewValue;
+            if (nextBeatmap?.Track != null)
+                nextBeatmap.Track.Completed += currentTrackCompleted;
+        }
+
+        private void currentTrackCompleted()
+        {
+            if (!Beatmap.Value.Track.Looping && !Beatmap.Disabled)
+                musicController.NextTrack();
+        }
+
+        #endregion
+
         private ScheduledDelegate performFromMainMenuTask;
 
         /// <summary>
@@ -446,7 +465,7 @@ namespace osu.Game
                 Origin = Anchor.TopRight,
             }, rightFloatingOverlayContent.Add, true);
 
-            loadComponentSingleFile(new MusicController
+            loadComponentSingleFile(musicController = new MusicController
             {
                 GetToolbarHeight = () => ToolbarOffset,
                 Anchor = Anchor.TopRight,
@@ -719,8 +738,11 @@ namespace osu.Game
         private Container topMostOverlayContent;
 
         private FrameworkConfigManager frameworkConfig;
+
         private ScalingContainer screenContainer;
 
+        private MusicController musicController;
+
         protected override bool OnExiting()
         {
             if (screenStack.CurrentScreen is Loader)

osu.Game/OsuGameBase.cs

@@ -10,6 +10,7 @@ using System.Threading.Tasks;
 using osu.Framework.Allocation;
 using osu.Framework.Audio;
 using osu.Framework.Bindables;
+using osu.Framework.Development;
 using osu.Framework.Graphics;
 using osu.Framework.Graphics.Containers;
 using osu.Framework.IO.Stores;
@@ -34,7 +35,6 @@ using osu.Game.Rulesets.Mods;
 using osu.Game.Scoring;
 using osu.Game.Skinning;
 using osuTK.Input;
-using DebugUtils = osu.Game.Utils.DebugUtils;
 
 namespace osu.Game
 {
@@ -97,7 +97,7 @@ namespace osu.Game
             get
             {
                 if (!IsDeployedBuild)
-                    return @"local " + (DebugUtils.IsDebug ? @"debug" : @"release");
+                    return @"local " + (DebugUtils.IsDebugBuild ? @"debug" : @"release");
 
                 var version = AssemblyVersion;
                 return $@"{version.Major}.{version.Minor}.{version.Build}";

osu.Game/Overlays/Chat/ChatLine.cs

@@ -74,17 +74,12 @@ namespace osu.Game.Overlays.Chat
             }
         }
 
+        private bool senderHasBackground => !string.IsNullOrEmpty(message.Sender.Colour);
+
         [BackgroundDependencyLoader]
         private void load(OsuColour colours)
         {
             customUsernameColour = colours.ChatBlue;
-        }
-
-        private bool senderHasBackground => !string.IsNullOrEmpty(message.Sender.Colour);
-
-        protected override void LoadComplete()
-        {
-            base.LoadComplete();
 
             bool hasBackground = senderHasBackground;
 
@@ -179,6 +174,11 @@ namespace osu.Game.Overlays.Chat
             };
 
             updateMessageContent();
+        }
+
+        protected override void LoadComplete()
+        {
+            base.LoadComplete();
             FinishTransforms(true);
         }
 

osu.Game/Overlays/Chat/DrawableChannel.cs

@@ -5,6 +5,7 @@ using System;
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Linq;
+using osu.Framework.Allocation;
 using osuTK.Graphics;
 using osu.Framework.Graphics;
 using osu.Framework.Graphics.Containers;
@@ -17,15 +18,18 @@ namespace osu.Game.Overlays.Chat
     public class DrawableChannel : Container
     {
         public readonly Channel Channel;
-        protected readonly ChatLineContainer ChatLineFlow;
-        private readonly OsuScrollContainer scroll;
+        protected ChatLineContainer ChatLineFlow;
+        private OsuScrollContainer scroll;
 
         public DrawableChannel(Channel channel)
         {
             Channel = channel;
-
             RelativeSizeAxes = Axes.Both;
+        }
 
+        [BackgroundDependencyLoader]
+        private void load()
+        {
             Children = new Drawable[]
             {
                 scroll = new OsuScrollContainer
@@ -48,18 +52,17 @@ namespace osu.Game.Overlays.Chat
                     },
                 }
             };
-        }
-
-        protected override void LoadComplete()
-        {
-            base.LoadComplete();
 
             newMessagesArrived(Channel.Messages);
 
             Channel.NewMessagesArrived += newMessagesArrived;
             Channel.MessageRemoved += messageRemoved;
             Channel.PendingMessageResolved += pendingMessageResolved;
+        }
 
+        protected override void LoadComplete()
+        {
+            base.LoadComplete();
             scrollToEnd();
         }
 

osu.Game/Overlays/ChatOverlay.cs

@@ -31,12 +31,13 @@ namespace osu.Game.Overlays
 
         private ChannelManager channelManager;
 
-        private readonly Container<DrawableChannel> currentChannelContainer;
+        private Container<DrawableChannel> currentChannelContainer;
+
         private readonly List<DrawableChannel> loadedChannels = new List<DrawableChannel>();
 
-        private readonly LoadingAnimation loading;
+        private LoadingAnimation loading;
 
-        private readonly FocusedTextBox textbox;
+        private FocusedTextBox textbox;
 
         private const int transition_length = 500;
 
@@ -44,17 +45,17 @@ namespace osu.Game.Overlays
 
         public const float TAB_AREA_HEIGHT = 50;
 
-        private readonly ChannelTabControl channelTabControl;
+        private ChannelTabControl channelTabControl;
 
-        private readonly Container chatContainer;
-        private readonly TabsArea tabsArea;
-        private readonly Box chatBackground;
-        private readonly Box tabBackground;
+        private Container chatContainer;
+        private TabsArea tabsArea;
+        private Box chatBackground;
+        private Box tabBackground;
 
         public Bindable<double> ChatHeight { get; set; }
 
-        private readonly Container channelSelectionContainer;
-        private readonly ChannelSelectionOverlay channelSelectionOverlay;
+        private Container channelSelectionContainer;
+        private ChannelSelectionOverlay channelSelectionOverlay;
 
         public override bool Contains(Vector2 screenSpacePos) => chatContainer.ReceivePositionalInputAt(screenSpacePos) || (channelSelectionOverlay.State.Value == Visibility.Visible && channelSelectionOverlay.ReceivePositionalInputAt(screenSpacePos));
 
@@ -64,7 +65,11 @@ namespace osu.Game.Overlays
             RelativePositionAxes = Axes.Both;
             Anchor = Anchor.BottomLeft;
             Origin = Anchor.BottomLeft;
+        }
 
+        [BackgroundDependencyLoader]
+        private void load(OsuConfigManager config, OsuColour colours, ChannelManager channelManager)
+        {
             const float padding = 5;
 
             Children = new Drawable[]
@@ -154,7 +159,7 @@ namespace osu.Game.Overlays
                                     Anchor = Anchor.BottomLeft,
                                     Origin = Anchor.BottomLeft,
                                     RelativeSizeAxes = Axes.Both,
-                                    OnRequestLeave = channel => channelManager.LeaveChannel(channel)
+                                    OnRequestLeave = channelManager.LeaveChannel
                                 },
                             }
                         },
@@ -186,9 +191,45 @@ namespace osu.Game.Overlays
             };
 
             channelSelectionOverlay.OnRequestJoin = channel => channelManager.JoinChannel(channel);
-            channelSelectionOverlay.OnRequestLeave = channel => channelManager.LeaveChannel(channel);
+            channelSelectionOverlay.OnRequestLeave = channelManager.LeaveChannel;
+
+            ChatHeight = config.GetBindable<double>(OsuSetting.ChatDisplayHeight);
+            ChatHeight.ValueChanged += height =>
+            {
+                chatContainer.Height = (float)height.NewValue;
+                channelSelectionContainer.Height = 1f - (float)height.NewValue;
+                tabBackground.FadeTo(height.NewValue == 1 ? 1 : 0.8f, 200);
+            };
+            ChatHeight.TriggerChange();
+
+            chatBackground.Colour = colours.ChatBlue;
+
+            this.channelManager = channelManager;
+
+            loading.Show();
+
+            // This is a relatively expensive (and blocking) operation.
+            // Scheduling it ensures that it won't be performed unless the user decides to open chat.
+            // TODO: Refactor OsuFocusedOverlayContainer / OverlayContainer to support delayed content loading.
+            Schedule(() =>
+            {
+                // TODO: consider scheduling bindable callbacks to not perform when overlay is not present.
+                channelManager.JoinedChannels.ItemsAdded += onChannelAddedToJoinedChannels;
+                channelManager.JoinedChannels.ItemsRemoved += onChannelRemovedFromJoinedChannels;
+                foreach (Channel channel in channelManager.JoinedChannels)
+                    channelTabControl.AddChannel(channel);
+
+                channelManager.AvailableChannels.ItemsAdded += availableChannelsChanged;
+                channelManager.AvailableChannels.ItemsRemoved += availableChannelsChanged;
+                channelSelectionOverlay.UpdateAvailableChannels(channelManager.AvailableChannels);
+
+                currentChannel = channelManager.CurrentChannel.GetBoundCopy();
+                currentChannel.BindValueChanged(currentChannelChanged, true);
+            });
         }
 
+        private Bindable<Channel> currentChannel;
+
         private void currentChannelChanged(ValueChangedEvent<Channel> e)
         {
             if (e.NewValue == null)
@@ -331,35 +372,6 @@ namespace osu.Game.Overlays
             base.PopOut();
         }
 
-        [BackgroundDependencyLoader]
-        private void load(OsuConfigManager config, OsuColour colours, ChannelManager channelManager)
-        {
-            ChatHeight = config.GetBindable<double>(OsuSetting.ChatDisplayHeight);
-            ChatHeight.ValueChanged += height =>
-            {
-                chatContainer.Height = (float)height.NewValue;
-                channelSelectionContainer.Height = 1f - (float)height.NewValue;
-                tabBackground.FadeTo(height.NewValue == 1 ? 1 : 0.8f, 200);
-            };
-            ChatHeight.TriggerChange();
-
-            chatBackground.Colour = colours.ChatBlue;
-
-            loading.Show();
-
-            this.channelManager = channelManager;
-            channelManager.CurrentChannel.ValueChanged += currentChannelChanged;
-            channelManager.JoinedChannels.ItemsAdded += onChannelAddedToJoinedChannels;
-            channelManager.JoinedChannels.ItemsRemoved += onChannelRemovedFromJoinedChannels;
-            channelManager.AvailableChannels.ItemsAdded += availableChannelsChanged;
-            channelManager.AvailableChannels.ItemsRemoved += availableChannelsChanged;
-
-            //for the case that channelmanager was faster at fetching the channels than our attachment to CollectionChanged.
-            channelSelectionOverlay.UpdateAvailableChannels(channelManager.AvailableChannels);
-            foreach (Channel channel in channelManager.JoinedChannels)
-                channelTabControl.AddChannel(channel);
-        }
-
         private void onChannelAddedToJoinedChannels(IEnumerable<Channel> channels)
         {
             foreach (Channel channel in channels)

osu.Game/Overlays/Mods/ModSection.cs

@@ -10,6 +10,7 @@ using osu.Game.Rulesets.Mods;
 using System;
 using System.Linq;
 using System.Collections.Generic;
+using System.Threading;
 using osu.Framework.Input.Events;
 using osu.Game.Graphics;
 
@@ -33,6 +34,13 @@ namespace osu.Game.Overlays.Mods
 
         public IEnumerable<Mod> SelectedMods => buttons.Select(b => b.SelectedMod).Where(m => m != null);
 
+        private CancellationTokenSource modsLoadCts;
+
+        /// <summary>
+        /// True when all mod icons have completed loading.
+        /// </summary>
+        public bool ModIconsLoaded { get; private set; } = true;
+
         public IEnumerable<Mod> Mods
         {
             set
@@ -48,7 +56,15 @@ namespace osu.Game.Overlays.Mods
                     };
                 }).ToArray();
 
-                ButtonsContainer.Children = modContainers;
+                modsLoadCts?.Cancel();
+                ModIconsLoaded = false;
+
+                LoadComponentsAsync(modContainers, c =>
+                {
+                    ModIconsLoaded = true;
+                    ButtonsContainer.ChildrenEnumerable = c;
+                }, (modsLoadCts = new CancellationTokenSource()).Token);
+
                 buttons = modContainers.OfType<ModButton>().ToArray();
 
                 if (value.Any())

osu.Game/Overlays/MusicController.cs

@@ -70,9 +70,6 @@ namespace osu.Game.Overlays
         {
             Width = 400;
             Margin = new MarginPadding(10);
-
-            // required to let MusicController handle beatmap cycling.
-            AlwaysPresent = true;
         }
 
         [BackgroundDependencyLoader]
@@ -349,18 +346,11 @@ namespace osu.Game.Overlays
 
                     direction = last > next ? TransformDirection.Prev : TransformDirection.Next;
                 }
-
-                //current.Track.Completed -= currentTrackCompleted;
             }
 
-            current = beatmap.NewValue;
-
-            if (current != null)
-                current.Track.Completed += currentTrackCompleted;
-
             progressBar.CurrentTime = 0;
 
-            updateDisplay(current, direction);
+            updateDisplay(current = beatmap.NewValue, direction);
             updateAudioAdjustments();
 
             queuedDirection = null;
@@ -378,12 +368,6 @@ namespace osu.Game.Overlays
                 mod.ApplyToClock(track);
         }
 
-        private void currentTrackCompleted() => Schedule(() =>
-        {
-            if (!current.Track.Looping && !beatmap.Disabled && beatmapSets.Any())
-                next();
-        });
-
         private ScheduledDelegate pendingBeatmapSwitch;
 
         private void updateDisplay(WorkingBeatmap beatmap, TransformDirection direction)
@@ -447,10 +431,6 @@ namespace osu.Game.Overlays
         {
             base.PopOut();
 
-            // This is here mostly as a performance fix.
-            // If the playlist is not hidden it will update children even when the music controller is hidden (due to AlwaysPresent).
-            playlist.Hide();
-
             this.FadeOut(transition_length, Easing.OutQuint);
             dragContainer.ScaleTo(0.9f, transition_length, Easing.OutQuint);
         }
@@ -548,5 +528,10 @@ namespace osu.Game.Overlays
                 return base.OnDragEnd(e);
             }
         }
+
+        /// <summary>
+        /// Play the next random or playlist track.
+        /// </summary>
+        public void NextTrack() => next();
     }
 }

osu.Game/Overlays/Settings/SettingsFooter.cs

@@ -3,6 +3,7 @@
 
 using System.Collections.Generic;
 using osu.Framework.Allocation;
+using osu.Framework.Development;
 using osu.Framework.Graphics;
 using osu.Framework.Graphics.Containers;
 using osu.Game.Graphics;
@@ -12,7 +13,6 @@ using osu.Game.Graphics.UserInterface;
 using osu.Game.Rulesets;
 using osuTK;
 using osuTK.Graphics;
-using DebugUtils = osu.Game.Utils.DebugUtils;
 
 namespace osu.Game.Overlays.Settings
 {
@@ -59,7 +59,7 @@ namespace osu.Game.Overlays.Settings
                     Text = game.Name,
                     Font = OsuFont.GetFont(size: 18, weight: FontWeight.Bold),
                 },
-                new BuildDisplay(game.Version, DebugUtils.IsDebug)
+                new BuildDisplay(game.Version, DebugUtils.IsDebugBuild)
                 {
                     Anchor = Anchor.TopCentre,
                     Origin = Anchor.TopCentre,

osu.Game/Screens/Select/Carousel/DrawableCarouselBeatmapSet.cs

@@ -143,10 +143,10 @@ namespace osu.Game.Screens.Select.Carousel
                         Origin = Anchor.Centre,
                         FillMode = FillMode.Fill,
                     },
-                    new FillFlowContainer
+                    // Todo: This should be a fill flow, but has invalidation issues (see https://github.com/ppy/osu-framework/issues/223)
+                    new Container
                     {
                         Depth = -1,
-                        Direction = FillDirection.Horizontal,
                         RelativeSizeAxes = Axes.Both,
                         // This makes the gradient not be perfectly horizontal, but diagonal at a ~40° angle
                         Shear = new Vector2(0.8f, 0),
@@ -157,6 +157,7 @@ namespace osu.Game.Screens.Select.Carousel
                             new Box
                             {
                                 RelativeSizeAxes = Axes.Both,
+                                RelativePositionAxes = Axes.Both,
                                 Colour = Color4.Black,
                                 Width = 0.4f,
                             },
@@ -164,20 +165,26 @@ namespace osu.Game.Screens.Select.Carousel
                             new Box
                             {
                                 RelativeSizeAxes = Axes.Both,
+                                RelativePositionAxes = Axes.Both,
                                 Colour = ColourInfo.GradientHorizontal(Color4.Black, new Color4(0f, 0f, 0f, 0.9f)),
                                 Width = 0.05f,
+                                X = 0.4f,
                             },
                             new Box
                             {
                                 RelativeSizeAxes = Axes.Both,
+                                RelativePositionAxes = Axes.Both,
                                 Colour = ColourInfo.GradientHorizontal(new Color4(0f, 0f, 0f, 0.9f), new Color4(0f, 0f, 0f, 0.1f)),
                                 Width = 0.2f,
+                                X = 0.45f,
                             },
                             new Box
                             {
                                 RelativeSizeAxes = Axes.Both,
+                                RelativePositionAxes = Axes.Both,
                                 Colour = ColourInfo.GradientHorizontal(new Color4(0f, 0f, 0f, 0.1f), new Color4(0, 0, 0, 0)),
                                 Width = 0.05f,
+                                X = 0.65f,
                             },
                         }
                     },

osu.Game/Utils/DebugUtils.cs

@@ -1,21 +0,0 @@
-// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
-// See the LICENCE file in the repository root for full licence text.
-
-namespace osu.Game.Utils
-{
-    public static class DebugUtils
-    {
-        public static bool IsDebug
-        {
-            get
-            {
-                // ReSharper disable once RedundantAssignment
-                bool isDebug = false;
-                // Debug.Assert conditions are only evaluated in debug mode
-                System.Diagnostics.Debug.Assert(isDebug = true);
-                // ReSharper disable once ConditionIsAlwaysTrueOrFalse
-                return isDebug;
-            }
-        }
-    }
-}