1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-18 03:05:10 +08:00
Commit Graph

1989 Commits

Author SHA1 Message Date
Dean Herbert
8745c2f016 Split out taiko DefaultJudgementPiece and move animations across 2022-11-07 17:19:32 +09:00
Dean Herbert
1975385cc7 Move first tick tracking logic inside TickPiece 2022-11-07 15:26:34 +09:00
Dean Herbert
c69a4f9333 Move major barline portion to default implementation to allow for further customisation
Of note, this removes the "major" barline triangles from legacy skins. I
think this is more correct, as they did not display in stable.
2022-11-07 14:29:58 +09:00
Dan Balasescu
a2b4e5b658
Merge pull request #20558 from vunyunt/stamina-available-fingers
Basic tl-tapping consideration for stamina
2022-11-07 09:55:54 +09:00
Dan Balasescu
819027d61c Rename to isConvert 2022-11-04 16:17:49 +09:00
Dan Balasescu
993439d30b Fix missed nullability 2022-11-03 11:28:39 +09:00
Dean Herbert
bfa5d41d89 Fix one more case 2022-11-02 17:39:45 +09:00
Dan Balasescu
5dfaf27722 A bit more cleanup 2022-11-02 17:23:45 +09:00
Dean Herbert
bc3382f373 Apply NRT to many taiko classes 2022-11-02 17:15:25 +09:00
Dean Herbert
910dd3ad01 Move more default classes to correct namespace 2022-11-02 17:15:25 +09:00
Dean Herbert
2407eb063d Simplify Circle usage in default CentreHitCirclePiece 2022-11-02 17:15:25 +09:00
Dean Herbert
9c758e5425 Move DefaultInputDrum to correct location 2022-11-02 17:15:25 +09:00
Dan Balasescu
5448c0209e Rename var 2022-11-02 10:14:40 +09:00
Dan Balasescu
9065cb0526 Merge branch 'master' into stamina-available-fingers 2022-11-01 13:05:25 +09:00
Dan Balasescu
4342521bc1 Merge branch 'master' into stamina-available-fingers 2022-10-28 13:07:48 +09:00
Dan Balasescu
707b9eaa50 Remove unnecessary null-forgiving 2022-10-28 13:07:44 +09:00
sw1tchbl4d3
446a9c1b05 Make added effect points inherit previous effect point settings 2022-10-27 23:41:17 +02:00
sw1tchbl4d3
93ffe3d7ad Revert to first approach 2022-10-27 07:25:50 +02:00
Bartłomiej Dach
974f22dd97
Attempt to make flashlight code slightly more legible 2022-10-25 20:15:19 +02:00
Bartłomiej Dach
e3bc1126d7
Fix invalid flashlight size calculation
This regressed in #20714. One usage of `getSizeFor(0)` was replaced by
`adjustSize(GetSize())`, but another usage of `getSizeFor(Combo.Value)`
was replaced by `adjustSize(Combo.Value)`, which is not correct, since
`adjustSize()` is expecting to receive a combo-based size, rather than a
combo value directly.
2022-10-25 20:03:22 +02:00
Bartłomiej Dach
93e9b4a2c5
Add failing test case 2022-10-25 20:02:28 +02:00
Dean Herbert
995216cced
Merge pull request #20819 from Joppe27/taiko-kiai-flashing
Implement taiko hitobject kiai flashing
2022-10-24 15:31:13 +09:00
cdwcgt
f14d871f97
let TaikoSpan show in timeline before placed 2022-10-23 01:32:22 +09:00
cdwcgt
a74e873b98
remove useless using 2022-10-23 01:13:29 +09:00
Dean Herbert
d441e98af7 Adjust kiai flash period in line with stable 2022-10-21 15:34:25 +09:00
cdwcgt
42bb9dc3e3
revert EndPlacement change 2022-10-20 22:17:26 +09:00
Joppe27
d83c398b58 Apply review: changed DelayUntilTransformsFinished to ArmedState check 2022-10-19 23:31:23 +02:00
Joppe27
9b123e7365 Adjust flash intensity and fade values to feel better 2022-10-19 00:51:44 +02:00
Joppe27
003e4247f9 Implement kiai flashing for "triangles" taiko skin 2022-10-18 23:55:40 +02:00
Joppe27
a21acdb5bc Implement kiai flashing for legacy taiko skins 2022-10-18 23:55:02 +02:00
cdwcgt
d6ed561280
make EndPlacement virtual 2022-10-19 00:31:21 +09:00
cdwcgt
3b1769c54e
Merge branch 'master' into taiko-compose 2022-10-19 00:00:20 +09:00
Dean Herbert
8bf4ca4b53 Add legacy skin fallback when beatmap skin is providing resources 2022-10-12 17:47:20 +09:00
Salman Ahmed
84fdd2e107 Improve flashlight display on break periods 2022-10-11 17:16:57 +03:00
vun
122064d03f Minor refactoring to reduce amount of looping 2022-10-09 07:09:05 +08:00
Dan Balasescu
bce20e0a59 Merge branch 'master' into adjust-flashlight 2022-10-07 14:45:30 +09:00
Dan Balasescu
5f3b58b7e0 Adjust taiko flashlight to closely match classic 2022-10-07 14:44:45 +09:00
Dan Balasescu
234c6ac799 Pin taiko PP calculator accuracy to osu-stable values 2022-10-05 20:21:15 +09:00
vun
47781a8f94 Fix code inspect issues and SR test cases 2022-10-03 17:31:45 +08:00
vun
25976e1f10 Correct xmldocs 2022-10-03 14:20:01 +08:00
vun
c933b62df6 Correct xmldoc 2022-10-03 14:16:53 +08:00
Jay L
6752655b5a xml, remove speedbonus cap 2022-10-02 16:08:14 +10:00
Jay L
4b562f782f decrease finger count 2022-10-02 15:28:39 +10:00
Jay L
a276e40033 reintroduce fl bonus to converts 2022-10-02 09:05:58 +10:00
vun
e6093f94df Apply nerfs to HD/FL bonuses with converts 2022-09-30 20:56:16 +08:00
vun
02092ede64 Refactor previous and next colour change into TaikoDifficultyHitObjectColour 2022-09-30 11:42:48 +08:00
vun
09a38fec94 Implement mono tl nerf for stamina, disable convert specific nerfs 2022-09-30 09:10:56 +08:00
vun
d84c956af9 Refactor to move first-object detection to evaluation 2022-09-29 15:27:26 +08:00
Dan Balasescu
1890a66b28
Merge pull request #20509 from o-dasher/cleanup-setting-sources
Removes unnecessary setting sources specifications
2022-09-28 17:55:42 +09:00
Dan Balasescu
cbed268ac9
Merge pull request #20510 from sw1tchbl4d3r/high_bpm_judgements
Clamp `LifetimeStart` of `HitObject`s to their judgement windows
2022-09-28 17:49:35 +09:00
sw1tchbl4d3
0cffbb7562 Clamp LifetimeStart of HitObject's to their judgement windows 2022-09-27 16:54:24 +02:00
o-dasher
f3e25eacad Removes unnecessary setting sources specifications 2022-09-27 09:25:58 -04:00
cdwcgt
344015a6e6
do not move timeline when EndPlacement 2022-09-27 20:12:40 +09:00
cdwcgt
9c4ae768f1
show object in timeline before placed
just BeginPlacement()
2022-09-27 20:08:32 +09:00
o-dasher
537796c3a1 Cleanup mod bindings 2022-09-25 15:49:22 -04:00
Dean Herbert
c7f8f948b9 Rename CreateLegacySkinProvider to CreateSkinTransformer and apply to all skins 2022-09-15 20:18:10 +09:00
andy840119
3d7367a842 Move the CreateConvertibleReplayFrame() into the base ruleset class for avoid api breaking change in the customized ruleset. 2022-09-10 11:07:23 +08:00
andy840119
2f91b5c846 Add missing import. 2022-09-10 10:46:10 +08:00
andy840119
e62999fb16 Merge branch 'master' of https://github.com/ppy/osu into remove-the-nullable-disable-in-the-ruleset
# Conflicts:
#	osu.Game.Rulesets.Catch/CatchRuleset.cs
#	osu.Game.Rulesets.Osu/OsuRuleset.cs
#	osu.Game.Rulesets.Taiko/TaikoRuleset.cs
#	osu.Game/Rulesets/Ruleset.cs
2022-09-10 10:40:12 +08:00
Dan Balasescu
a2f8ff825e Also ignore drum roll strong judgement 2022-09-06 23:26:25 +09:00
Dan Balasescu
792b410c04 Merge branch 'master' into classic_drumrolls 2022-09-06 16:29:45 +09:00
Salman Ahmed
ff4a051c05
Merge branch 'master' into remove-dispose-updates 2022-09-03 16:14:50 +03:00
Dan Balasescu
9645bfe708 Bump difficulty calculator versions 2022-09-02 16:27:25 +09:00
Dean Herbert
6a35b233e5 Merge branch 'master' into remove-dispose-updates 2022-09-01 23:03:19 +09:00
sw1tchbl4d3
a9aa928ce6 Fix test, make strong hits have LargeBonus judgement 2022-08-30 15:00:46 +02:00
sw1tchbl4d3
b185194d07 Apply comments by smoogi 2022-08-30 14:44:44 +02:00
Dan Balasescu
e3e204001e
Merge pull request #19907 from peppy/ruleset-api-versioning
Add ruleset API versioning
2022-08-29 18:50:01 +09:00
Dean Herbert
a215d009fe Update Remove/RemoveRange/RemoveAll calls in line with framework changes 2022-08-29 15:57:40 +09:00
Dean Herbert
90b9c02ac6 Remove "internal" identifier as unnecessary 2022-08-29 14:01:15 +09:00
Dan Balasescu
85705d97a5
Merge pull request #19853 from Lawtrohux/pp-rescale-effective-misses
osu!taiko performance point adjustments & effective misses
2022-08-25 14:43:03 +09:00
Dan Balasescu
8eab36f8c9 Actually fix possible NaN value 2022-08-25 14:02:10 +09:00
Dan Balasescu
136dcee3b5
Merge pull request #19571 from vunyunt/colour-encoding-2
Rewrite of the colour skill & refactoring of difficulty calculation within osu!taiko
2022-08-25 13:56:50 +09:00
vun
fb9bb2d42d Declare Parent as non-nullable 2022-08-24 08:57:13 +08:00
Jay L
3acbcac4d1 fix NaN PP on 0 object count 2022-08-22 19:45:51 +10:00
Dean Herbert
f5710d8000 Add ruleset API versioning 2022-08-22 16:35:08 +09:00
naoei
9386d352b8 Make StatisticItem.Name not nullable 2022-08-20 21:48:35 -04:00
Nao
189a407cb1
Merge branch 'master' into ruleset-localization 2022-08-20 21:39:10 -04:00
Jay L
c1da509119 round numerical value
this is painfully annoying me
2022-08-19 23:23:40 +10:00
Jay L
faf143b11a fix comment 2022-08-19 23:15:38 +10:00
Jay L
b30fba1430 emc attribute 2022-08-19 22:57:40 +10:00
Jay L
fea31cc895 introduce effective misscount, accuracy rescale 2022-08-19 22:57:28 +10:00
vun
f3e1287f04 Remove redundant using statement 2022-08-19 16:19:45 +08:00
vun
684efefb50 Add FirstHitObject as a property of encoding classes 2022-08-19 16:13:36 +08:00
vun
a26de0a10f Add HitType property to MonoStreak 2022-08-19 16:05:34 +08:00
vun
51176e9577 Naming changes 2022-08-19 15:45:43 +08:00
vun
5dcd4ce7c5 Naming changes 2022-08-19 15:31:03 +08:00
Dan Balasescu
c4dee1cf6d
Merge pull request #19832 from peppy/fix-taiko-span-blueprint-overlay
Fix taiko blueprints displaying incorrectly for drum rolls
2022-08-18 17:57:14 +09:00
Dean Herbert
ad28bfc9b2 Fix taiko blueprints displaying incorrectly for drum rolls 2022-08-18 17:18:11 +09:00
Dean Herbert
48fac9f8a5 Fix taiko drum rolls with zero length being placeable in editor
Addresses https://github.com/ppy/osu/discussions/19808.
2022-08-18 16:50:36 +09:00
vun
40b1554fea Change FindRepetitionInterval to start with one previous encoding 2022-08-18 14:12:03 +08:00
Dan Balasescu
8e0049c005 Add back null check 2022-08-15 21:57:41 +09:00
Dan Balasescu
c03e47317a Fix notes not being added to list 2022-08-15 21:56:03 +09:00
Dan Balasescu
4d4ee05981 Whoops I meant to remove these 2022-08-15 21:56:03 +09:00
Dan Balasescu
78283ce3c5 Remove TaikoDifficultyPreprocessor 2022-08-15 21:43:09 +09:00
Dan Balasescu
21d2998032 Privatise internals of TaikoColourDifficultyPreprocessor 2022-08-15 21:35:57 +09:00
Dan Balasescu
94c6beeaf7 Use ctor in a place that looks visually weird
I read through this thinking "why doesn't Previous get assigned to
currentEncoding here? But it's because the initializer runs right after
the ctor and before the "method" returns. So really there's 3 operations
running on one line here - ctor, init, and assignment.
2022-08-15 21:30:46 +09:00
Dan Balasescu
502e31dd37 General refactoring 2022-08-15 21:26:54 +09:00
Dan Balasescu
d686e841c5 Merge branch 'master' into colour-encoding-2 2022-08-15 20:56:50 +09:00
naoei
45e9eda9e7 Localise hit result name 2022-08-14 14:57:02 -04:00
naoei
18ce784ae0 Allow StatisticItem's name param to be nullable 2022-08-14 14:51:35 -04:00
naoei
3e38baca3c Change ruleset mod description types 2022-08-10 16:09:11 -04:00
sw1tchbl4d3
e0426836c1 Make swells and drumrolls optional by default 2022-08-05 16:30:07 +02:00
Justin
e6761ef6b1
Merge branch 'master' into classic_drumrolls 2022-08-05 12:17:44 +00:00
Dan Balasescu
b4e55f7309 Apply IRenderer changes 2022-08-02 19:50:57 +09:00
andy840119
eb73f9e88c Remove un-need using. 2022-08-02 10:23:52 +08:00
andy840119
b1d320bf67 Use non-nullable instead in the taiko ruleset. 2022-08-02 00:48:23 +08:00
Salman Ahmed
b32ff68a95 Enable NRT on taiko legacy skin transformer and tests 2022-07-30 09:43:51 +03:00
Salman Ahmed
0940e703b3 Fix normal skin hitsounds prioritised over default taiko hitsounds 2022-07-30 09:15:28 +03:00
Salman Ahmed
e0107fc3dc Use RequiredParentSizeToFit to handle misc geometry changes 2022-07-29 21:11:43 +03:00
NaiPofo
4e32d510c3
Invalidate flashlightProperties on DrawInfo 2022-07-29 20:08:32 +02:00
為什麼
860e9d42ff Mark the property as nullable and add some assert check. 2022-07-27 22:31:48 +08:00
為什麼
d766052be4 Remove nullable disable annotation in the Taiko ruleset. 2022-07-27 22:28:13 +08:00
sw1tchbl4d3
0a0f3c93dd Rename OkResult, rephrase "strong bonus" 2022-07-24 20:55:13 +02:00
Justin
a4f3a0d201
Merge branch 'master' into classic_drumrolls 2022-07-24 18:33:04 +00:00
Dan Balasescu
27ec8f3ae6
Merge pull request #17200 from hongaaronc/master
Add basic touch support for osu!taiko
2022-07-22 20:58:42 +09:00
Dean Herbert
7baa1a7e85 Attempt to fix crashing from weird input interactions 2022-07-22 20:19:13 +09:00
vun
fc08d77090 Remove review-specific comment 2022-07-22 18:31:59 +08:00
vun
7d4593eb6d Fix comments 2022-07-22 18:20:35 +08:00
Dean Herbert
ee5e27638e Fix method name not matching actual implementation 2022-07-22 18:19:33 +09:00
Dean Herbert
9e5e03af5d Adjust colours to match default skin for now 2022-07-22 18:16:01 +09:00
Dean Herbert
ec98693cca Add back standard mouse bindings support and only handle mouse when inside the visible zone 2022-07-22 18:09:19 +09:00
Dean Herbert
4279ac866c Tidy up unnecessary changes and remove unused classes 2022-07-22 17:58:52 +09:00
Dean Herbert
2d2d98ab6e Add final design pass 2022-07-22 17:53:25 +09:00
vun
17d418d319 Merge remote-tracking branch 'ppy/master' into colour-encoding-2 2022-07-22 16:31:28 +08:00
vun
6359c1a4fe Fix outdated comment 2022-07-22 16:31:19 +08:00
Dean Herbert
aeeedc40b4 Add first pass design 2022-07-22 17:17:38 +09:00
Dean Herbert
bd6ff40b43 Combine touch and mouse handling into single path 2022-07-22 17:03:08 +09:00
Dean Herbert
b604eb6262 Simplify implementation 2022-07-22 16:59:09 +09:00
Dean Herbert
7015cf0b1b Move touch input drum to own file for now 2022-07-22 16:39:26 +09:00
Dean Herbert
c32af3c041 Merge branch 'master' into hongaaronc/master 2022-07-22 15:55:38 +09:00
vun
4433f902ea Fix and add comments 2022-07-22 10:49:53 +08:00
vun
e4086b058b Implement stateless colour evaluator and required encoding changes 2022-07-21 19:15:22 +08:00
Dean Herbert
aca19a005e Add versioning to difficulty calculators 2022-07-21 18:15:25 +09:00
vun
7917a60e3c Move TaikoDifficultyHitObject creation back to TaikoDifficultyCalculator 2022-07-21 15:45:03 +08:00
Jay L
b7567f7db2 Share sigmoid, Fix Preprocessor XML 2022-07-21 10:52:41 +10:00
Jay L
08dd9c79db Fix Convert-related nerf
This addresses recent player unsatisfaction with converts being underweighted.
2022-07-21 09:55:19 +10:00
Jay L
cb63ec282e Partial Review changes 2022-07-20 23:33:38 +10:00
Dan Balasescu
7dfc18a0e3
Merge pull request #19208 from frenzibyte/remove-score-multiplier-on-custom-mod-settings
Remove score multiplier on difficulty-increasing mods with customised settings
2022-07-20 20:12:59 +09:00
Dean Herbert
f6e46da117
Merge branch 'master' into taiko-target-classic-position 2022-07-20 19:09:57 +09:00
Salman Ahmed
4210ec6502 Merge branch 'master' into remove-score-multiplier-on-custom-mod-settings 2022-07-19 19:21:26 +03:00
Dan Balasescu
471e1b935d
Merge pull request #19181 from taiko-pp-committee/performance-balancing-merge
osu!taiko performance points balancing
2022-07-19 21:01:12 +09:00
Salman Ahmed
1051009827 Change bindable properties in all HitObjects to be lazily initialised 2022-07-19 05:39:10 +03:00
Salman Ahmed
28150dc15d Merge branch 'master' into taiko-target-classic-position 2022-07-18 20:45:29 +03:00
Salman Ahmed
32ba58109b Remove score multiplier on difficulty-increasing mods with customised settings 2022-07-18 07:29:03 +03:00
Jay L
e82e11ead5 Fix SpeedBonus xml 2022-07-17 14:56:07 +10:00
Jay L
5532f56a30 performance points balancing 2022-07-17 14:10:49 +10:00
vun
a66fd87274 Fix speed bonus comment 2022-07-16 19:48:29 +08:00
vun
8beb5568b8 Fix speed bonus 2022-07-16 19:45:35 +08:00
Jay L
8a17b509d9 Increase SpeedBonus Cap to 600BPM 2022-07-16 21:20:25 +10:00
vunyunt
9994f13031
Merge branch 'ppy:master' into colour-encoding-2 2022-07-15 21:19:49 +08:00
Jay L
c8b7902a63 Reintroduce Convert Nerf, Rescale Multiplier 2022-07-15 22:10:20 +10:00
Jay L
7e3f62a5a5 Codequality parse 2022-07-15 21:07:01 +10:00
vun
45c055bfa1 Move rhythm preprocessing to its own folder 2022-07-14 17:25:21 +08:00
vun
1cb18f8474 Refactor colour encoding to avoid circular dependencies 2022-07-14 16:29:23 +08:00
為什麼
1725a76fa0 Remove the nullable disable annotation for all rulesets. 2022-07-10 10:15:27 +08:00
為什麼
857377e145 Move CreateConvertibleReplayFrame() into legacy ruleset interface because technically only legacy ruleset use it to convert the legacy frame.
But seems some of the customized ruleset use it for save the replay frame.
2022-07-10 10:15:27 +08:00
vun
6660379a0e TAIKO-6 Tweak encoding and parameters, reduce rhythm weight 2022-07-07 16:04:46 +08:00
vun
f6dedc77fb Fixed encoding logic, parameter adjustments 2022-07-05 17:01:11 +08:00
vun
505a24a68e Implement new colour encoding and evaluator 2022-07-05 14:41:40 +08:00
andy840119
0a1543c6e8 Use AsNonNull() instead. 2022-07-02 19:48:32 +08:00
andy840119
59c83a3423 Mark as non-null because next object in here will always has value. 2022-07-02 13:33:51 +08:00
andy840119
19721a9bbb Remove the nullable disable annotation and fix the breaking api. 2022-07-02 13:33:05 +08:00
vun
5f8d21f33d Per encoding evaluation 2022-07-01 14:27:23 +08:00
vun
cba47f8202 [WIP] Colour evaluator for new colour encoding 2022-06-28 10:38:58 +08:00
Dan Balasescu
0fd2c010e5 Remove NRT disables from attributes classes 2022-06-27 16:07:15 +09:00
Dan Balasescu
0579780bb8 Add IBeatmapOnlineInfo parameter and use to extract more data 2022-06-27 16:07:15 +09:00
vunyunt
55e5b41c03
Merge branch 'ppy:master' into colour-encoding-2 2022-06-25 22:50:06 +08:00
vun
8c162585b8 Comment out logging for debugging purposes 2022-06-25 22:49:19 +08:00
vun
15372267e1 Implement new colour encoding 2022-06-25 22:42:56 +08:00
Dean Herbert
31a447fda0 Update parameter discards 2022-06-24 21:26:19 +09:00
Bartłomiej Dach
3497e966fd
Revert no longer needed access modifier change 2022-06-24 13:01:16 +02:00
Bartłomiej Dach
f47b74a938
Move OkResult from drawable swell to judgement 2022-06-24 13:00:12 +02:00
Bartłomiej Dach
bcb9cba2d7
Reorder classes for legibility, group into regions 2022-06-24 12:56:47 +02:00
Bartłomiej Dach
52de8bae9b
Apply NRT to TaikoModClassic 2022-06-24 12:54:33 +02:00
Bartłomiej Dach
26c5b59f6d
Replace usages of string.To{Lower,Upper}() 2022-06-24 11:57:45 +02:00
vun
f42aac9954 TAIKO-6 Pre-evaluate colour to avoid per-note evaluation 2022-06-23 17:10:30 +08:00
vun
c5fd48372b Flatten speed bonus for stamina 2022-06-22 17:17:19 +08:00
sw1tchbl4d3
6c8042642a Reduce code duplication 2022-06-20 17:22:41 +02:00
sw1tchbl4d3
98527fec26 Make mod selfcontained 2022-06-19 15:11:12 +02:00
vun
3529514587 Disablle nullable in TaikoDifficultyHitObjectColour 2022-06-19 17:26:11 +08:00
vun
57964311be Revert performance calculator to upstream 2022-06-19 17:20:53 +08:00
vun
95c43d9384 Merge remote-tracking branch 'ppy/master' into colour-rework 2022-06-19 17:18:05 +08:00
vun
da1d99d5b6 Parameter tweaks, change repetition interval definition 2022-06-19 17:14:31 +08:00
sw1tchbl4d3
a5bf16e873 Make drum rolls and swells optional with Classic mod 2022-06-19 02:10:23 +02:00
Dan Balasescu
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
vun
319d0aa036 Merge remote-tracking branch 'ppy/master' into colour-rework 2022-06-13 17:29:26 +08:00
vun
2b2150ac04 Refactor TaikoDifficultyHitObject creation into the class as a static method 2022-06-10 14:58:50 +08:00
vun
2881406f6b Nerf alternating pattern slightly, value rescale 2022-06-09 19:41:59 +08:00
Dan Balasescu
6d2a2ba7d6 Rename Position -> Index 2022-06-09 18:49:11 +09:00
vun
54f41ab4fa Merge branch 'colour-rework-huismet' of https://github.com/Lawtrohux/osu into colour-rework 2022-06-09 17:34:48 +08:00
vun
4c574eb044 Rescale multipliers (values unaffected) 2022-06-09 17:31:54 +08:00
Dan Balasescu
f0ef2e610e Merge branch 'master' into dho 2022-06-09 18:29:14 +09:00
Jay L
6dbaf0a030 Refactor 2022-06-09 19:22:55 +10:00
vunyunt
2e004bf551
Merge branch 'ppy:master' into colour-rework 2022-06-09 12:39:52 +08:00
vun
5793ca5534 Parameter tweaks 2022-06-09 12:35:26 +08:00
Nostril
5cbd3bd67e
Merge branch 'ppy:master' into master 2022-06-08 19:29:14 -07:00
vun
d8d4ac431e Refactor LocallyCombinedDifficulty to an external skill 2022-06-08 13:24:51 +08:00
Dan Balasescu
8578f12a58 Fix taiko circle fills missing after rewind 2022-06-07 18:35:12 +09:00
vun
fd49a27cf9 Fix encoding repetition, parameter adjustments 2022-06-07 13:30:24 +08:00
vun
07d3a7bd2e Fix logic error, minor stamina changes 2022-06-06 16:11:26 +08:00
vun
bfada36554 Merge branch 'taiko-evaluators' into colour-rework 2022-06-06 12:45:48 +08:00
vun
3dd0c4aec8 [WIP] Colour rework 2022-06-06 12:42:49 +08:00
vun
56a4034c22 Change RepetitionInterval to have max_repetition_interval + 1 when no repetition is found. 2022-06-02 18:48:36 +08:00
vun
c9877084c4 Merge remote-tracking branch 'apollo/dho' into colour-rework 2022-06-02 18:34:46 +08:00
Dean Herbert
859a83ac90 Remove unused field and fix typo 2022-06-02 14:48:26 +09:00
Dean Herbert
45adca17da Make DrumSamplePlayer a CompositeDrawable 2022-06-02 14:39:57 +09:00
Dean Herbert
f3d4cd3f95 Fix various code inspection issues 2022-06-02 14:36:07 +09:00
Aaron Hong
f6e9dfe7bf Fix naming rule violations 2022-06-01 01:03:21 -07:00
Aaron Hong
fcc05396bc Remove unused import 2022-06-01 00:57:24 -07:00
Aaron Hong
2471c242b4 Merge branch 'master' of https://github.com/ppy/osu into ppy-master 2022-05-31 21:01:04 -07:00
vun
0a21f7c30d Implement mono history in TaikoDifficultyHitObject 2022-06-01 05:20:08 +08:00
vun
8bbe70bff0 Fix NullPointerReference 2022-06-01 04:33:37 +08:00
vun
86ffa810a9 Implement stamina evaluator (untested yet) 2022-05-31 23:17:39 +08:00
apollo-dw
66a6467403 Pass object position to the object 2022-05-26 19:26:14 +01:00
vun
1972bdd6c7 Working colour encoding 2022-05-26 18:04:25 +08:00
apollo-dw
30b9e0e7ab Use object list size for object position 2022-05-24 16:30:25 +01:00
Gabe Livengood
252bacc8d4 revert more testing leftovers... 2022-05-24 10:56:31 -04:00
Gabe Livengood
dde0756bed add accuracy challenge mod 2022-05-24 10:23:44 -04:00
vun
f01deae428 Colour compression preprocessing implementation 2022-05-24 17:38:52 +08:00
apollo-dw
5dbec92d9e Update comments 2022-05-23 22:17:29 +01:00
apollo-dw
903c4f7b3d Merge remote-tracking branch 'master/master' into dho 2022-05-23 13:39:04 +01:00
Dan Balasescu
6cfe35360a Refactor key indexing 2022-05-23 14:36:06 +09:00
Dan Balasescu
63a3829768 Split out SingleKeyStamina class 2022-05-23 14:19:25 +09:00
apollo-dw
26985ca8af Store hitobject history in the hitobject 2022-05-22 16:26:22 +01:00
Jay L
db6abd86f0 Rectify null value call
tired programming is never a good idea
2022-05-17 09:10:52 +10:00
Jay L
c7ec95c0d0 Rectify Review Changes 2022-05-17 09:10:52 +10:00
Jay L
94294ba351 Apply Review Changes 2022-05-17 09:10:52 +10:00
Jay L
d94e30bed3 Rewrite Performance difficultyValue Calculation
To change values in line with the community survey, pp has been rescaled immensely, with changes on both the lower and upper end.
2022-05-17 09:10:52 +10:00
Jay L
b44afb19b1 Include Convert Penalty
For low colour variance
2022-05-17 09:10:52 +10:00
Jay L
d174099016 Refactor and Cleanup of Stamina.cs 2022-05-17 09:10:52 +10:00
Jay L
f15738fded Remove Redundant Detection
Not needed, as nerf is not required anymore and has negative effect.
2022-05-17 09:10:52 +10:00
Jay L
48b7e0f090 Stamina Skill Rewrite and Refactor 2022-05-17 09:10:52 +10:00
Dan Balasescu
637f817696 Ignore zero-sections on a per-case basis 2022-05-03 16:06:20 +09:00
Salman Ahmed
61078910a6 Handle all skin component types explicitly 2022-04-23 03:34:05 +03:00
Salman Ahmed
f48533b8a2 Inline input drum proxying logic 2022-04-13 04:38:41 +03:00
Salman Ahmed
b84a3b7834 Rewrite input drum measurements to autosize on X axis 2022-04-07 21:39:53 +03:00
Salman Ahmed
ce70957fbf Remove redundant code 2022-04-06 02:38:56 +03:00
Salman Ahmed
ec5ad995f8 Reorder taiko playfield elements to fix hit explosion Z-ordering 2022-04-06 02:37:57 +03:00
Salman Ahmed
e4f6e842b0 Expose input drum SkinnableDrawable in InputDrum for width consumption
This is probably not a good way to approach this, but I'm unsure about
any other way.
2022-04-06 02:35:00 +03:00
Salman Ahmed
55c56c03a5 Propagate legacy input drum size to main piece 2022-04-06 02:34:07 +03:00
Salman Ahmed
3408f2bbe0 Merge branch 'master' into taiko-target-classic-position 2022-04-05 23:22:46 +03:00
Dean Herbert
2d020e756d
Merge pull request #17621 from frenzibyte/taiko-target-size
Adjust osu!taiko legacy hit target size to match osu!(stable)
2022-04-05 12:37:40 +09:00
Salman Ahmed
117d81d84f
Use perfect osu!(stable) strong scale value
Co-authored-by: Dean Herbert <pe@ppy.sh>
2022-04-05 03:04:53 +03:00
Salman Ahmed
ac32966427 Replicate osu!(stable)'s hit target position with "Classic" mod 2022-04-03 02:02:20 +03:00
Salman Ahmed
534cc18ff9 Adjust osu!taiko legacy hit target size to match osu!(stable) 2022-04-03 01:21:48 +03:00
Salman Ahmed
4ce69890d4 Use TaikoHitObject.DEFAULT_SIZE for default circle piece symbol size 2022-04-03 00:21:23 +03:00
Salman Ahmed
01b10e68d2 Adjust taiko hit objects sizes to match osu!(stable) 2022-04-02 23:47:20 +03:00
Dean Herbert
0cac935939 Shorten class name of ModCreatedReplayUser 2022-03-31 11:34:23 +09:00
Dean Herbert
4b2c01a8c1 Bring all mod implementations up-to-date 2022-03-29 16:59:03 +09:00
Dean Herbert
d2d88015e3 Update all cinema/autoplay mods to specify the system user ID 2022-03-28 22:22:56 +09:00
Dean Herbert
6fb06d69cc
Merge branch 'master' into pp-counter-alloc-reduction 2022-03-15 13:31:57 +09:00
Dan Balasescu
523f668c8c Remove unnecessary ctor argument 2022-03-15 12:37:39 +09:00
Dan Balasescu
daac933498 Remove unnecessary ctor arguments 2022-03-15 12:34:58 +09:00
Dan Balasescu
59d57a44d4 Prevent incorrect usages by hard-typing ctor type 2022-03-15 09:11:59 +09:00
Dan Balasescu
3fff7f4b7e Require ScoreProcessor to receive ruleset 2022-03-14 15:51:10 +09:00
Dan Balasescu
4a3e3aba65 Restructure PerformanceCalculator to not require ScoreInfo argument 2022-03-14 14:25:28 +09:00
Dean Herbert
2c47c4a2e9
Merge branch 'master' into taiko-classic-aspect-ratio 2022-03-14 10:40:35 +09:00
Salman Ahmed
4a8aa72d1b Nudge osu!taiko playfield's height to perfectly match with osu!(stable) 2022-03-14 01:03:08 +03:00
Salman Ahmed
0b74bde653 Disable taiko playfield aspect ratio lock on "Classic" mod 2022-03-13 08:21:58 +03:00
Aaron Hong
b628a65cfa Revert "Adjust default touch drum overlay size to be more comfortable on phones"
This reverts commit 2de6bb033b.
2022-03-12 08:03:24 -08:00
Aaron Hong
2de6bb033b Adjust default touch drum overlay size to be more comfortable on phones 2022-03-12 07:51:40 -08:00
Aaron Hong
9db80c3335 Code cleanup 2022-03-12 05:32:02 -08:00
Aaron Hong
6f99455d94 Improve centre input size fitting for legacy skins 2022-03-12 05:17:45 -08:00
Aaron Hong
ac17c047f6 Code formatting 2022-03-12 05:01:40 -08:00
Aaron Hong
848b005097 Remove unneccessary whitespace 2022-03-11 04:48:57 -08:00
Aaron Hong
35053eaeba Show and hide osu!taiko touch controls overlay based on most recent input type detected 2022-03-11 04:43:57 -08:00
Aaron Hong
c33a661a49 osu!taiko touch implementation syntax formatting cleanup 2022-03-11 03:36:03 -08:00
Aaron Hong
1ed06f30e7 osu!Taiko touch implementation code cleanup 2022-03-11 03:33:03 -08:00
Aaron Hong
7336c2c0bd Fix osu!taiko alignment issue with legacy skins on Touch Controls 2022-03-11 02:48:08 -08:00
Aaron Hong
38c61b2c1d Fix crash when loading legacy osu!taiko skins with touch input 2022-03-11 00:14:33 -08:00
Aaron Hong
5ce57fa34a Improve readability for getTaikoActionFromInput 2022-03-10 06:17:06 -08:00
Aaron Hong
317869078f Basic functionality for Taiko touch input now complete 2022-03-10 05:09:07 -08:00
Nostril
fc2cd78fa2
Merge branch 'ppy:master' into master 2022-03-10 00:52:56 -08:00
Aaron Hong
a25b6e6a09 Proof of Concept draft for Taiko touch input 2022-03-10 00:42:58 -08:00
Dan Balasescu
c36badab4b Add per-ruleset score multipliers for classic scoring 2022-03-10 10:26:09 +09:00
Henry Lin
76d257fbe4
Merge branch 'master' into mod-adaptive-speed 2022-03-04 15:16:37 +08:00
Dean Herbert
1a47459262 Fix taiko difficulty adjust scroll speed being shown with too low precision 2022-03-02 18:38:17 +09:00
Henry Lin
c9b205afeb Add adaptive speed mod 2022-03-02 09:57:52 +08:00
Dean Herbert
a41e1c80f1 Show hit error on results screen
Leading up to implementation of "local offset", this feels like a good
thing to have visible first and foremost.
2022-02-28 19:11:06 +09:00
Dan Balasescu
84e82ef5e4 Add XMLDocs to difficulty attribute properties 2022-02-16 14:09:19 +09:00
Henry Lin
ee6d4b2583 Move performance breakdown to the top to prevent re-ordering after watching replay 2022-02-05 21:39:01 +08:00
Henry Lin
0b1fef38af Use the playable beatmap provided in CreateStatisticsForScore 2022-02-05 21:36:34 +08:00
Henry Lin
440b674bb0 Add statistic item for mania & taiko 2022-02-05 21:30:35 +08:00
Henry Lin
f29301cd1e
Merge branch 'master' into display-performance-attributes 2022-02-05 16:59:46 +08:00
Dean Herbert
df9d99f5aa Merge branch 'master' into extended-statistics-without-replay 2022-02-03 18:59:48 +09:00
Bartłomiej Dach
82f9ad63f5
Fix flashlight size multiplier printing with too many decimal digits 2022-02-02 20:41:25 +01:00
Dean Herbert
19eb9ad8a7 Reorder StatisticsItem constructor to make a touch more sense 2022-02-02 23:02:38 +09:00
Henry Lin
6a482827fe Fix weird line breaking 2022-02-02 17:23:03 +08:00
Henry Lin
c5c4c85006 Lazily create content of StatisticItem 2022-02-02 13:29:18 +08:00
Dan Balasescu
0458d408bb Add replay statistics frames to FramedReplayInputHandler 2022-01-31 18:53:47 +09:00
Dean Herbert
5288eedd31 Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID 2022-01-27 15:38:03 +09:00
Bartłomiej Dach
8c3fbb6eb4
Merge branch 'master' into Liswiera-FL-changes 2022-01-24 21:32:36 +01:00
Bartłomiej Dach
2375420d4c
Tweak allowable ranges of size multiplier 2022-01-24 21:32:31 +01:00
Bartłomiej Dach
4a13c93ca7
Disallow zero size multiplier in flashlight implementations 2022-01-24 21:03:03 +01:00
Bartłomiej Dach
a227af75ed
Simplify flashlight parameter passing flow 2022-01-24 21:03:02 +01:00
Bartłomiej Dach
5874475dff
Extract DefaultFlashlightSize to base flashlight class 2022-01-24 21:03:02 +01:00
Bartłomiej Dach
a7c0d507ce
Rename flashlight settings to be more accurate 2022-01-24 21:03:02 +01:00
mk-56
948867898c ModeMultiplier rename 2022-01-24 11:38:52 +01:00
mk-56
161a2a321e Remove bindable from ModeMultiplier 2022-01-24 09:07:07 +01:00
mk-56
ed84ae0ac0 Adjust values to Bdach's refined taste 2022-01-24 00:42:43 +01:00
Bartłomiej Dach
735414bc49
Replace TimeSignatures enum with struct for storage of arbitrary meter 2022-01-22 20:50:31 +01:00
mk-56
955bab926f Separate the settings for each modes radiuses 2022-01-22 19:38:56 +01:00
MK56
b5f813a949
Merge branch 'ppy:master' into Liswiera-FL-changes 2022-01-22 19:04:39 +01:00
Bartłomiej Dach
1ce0b18003
Merge branch 'master' into display-performance-attributes 2022-01-22 14:12:57 +01:00
Dean Herbert
1b62a685f3 Merge branch 'master' into realm-integration/score-and-beatmaps 2022-01-18 15:07:59 +09:00
MK56
31592e2995
Merge branch 'ppy:master' into Liswiera-FL-changes 2022-01-17 15:19:29 +01:00
mk-56
bd308ca38c Cleanup 2022-01-17 15:15:25 +01:00
Henry Lin
b81fc675e8 Include PropertyName in PerformanceDisplayAttribute 2022-01-17 20:45:25 +08:00
Henry Lin
511a607599 Display performance breakdown in a tooltip 2022-01-17 18:28:17 +08:00
Bartłomiej Dach
c6adbdd46f
Fix drum rolls nested objects not applying min result on kill 2022-01-16 17:53:37 +01:00
mk-56
ee4331dda4 Merge remote-tracking branch 'origin/Liswiera-FL-changes' into Liswiera-FL-changes 2022-01-15 21:44:03 +01:00
mk-56
2a59735525 Initial commit 2022-01-15 21:43:28 +01:00
Bartłomiej Dach
03e4ec4214
Merge branch 'master' into realm-integration/score-and-beatmaps 2022-01-15 14:45:42 +01:00
Susko3
19467e58c1 Remove unused params from BDL methods 2022-01-15 01:06:39 +01:00
Dean Herbert
b77cb344d5 Use ctor rather than MemberwiseClone to guarantee a safer clone of BeatmapDifficulty 2022-01-13 13:23:41 +09:00
Dean Herbert
286994a808 Fix BeatmapDifficulty cloning regression 2022-01-12 17:49:11 +09:00
Joseph Madamba
7de43e3aba Fix most open compound words in identifiers being closed 2021-12-27 20:26:28 -08:00
StanR
40b3ce0ade Clean up comments 2021-12-21 14:03:24 +03:00
StanR
cca02a8016 Create PerformanceAttributes 2021-12-21 13:08:31 +03:00
StanR
2f2006715e Slightly refactor difficulty and pp calculators 2021-12-17 23:40:23 +03:00
Dean Herbert
1eed2436e6 Clean up unused resolved properties 2021-12-03 18:49:49 +09:00
Dean Herbert
9f688f6291 Stop persisting Skills in DifficultyAttributes 2021-11-21 12:15:32 +09:00
Dean Herbert
fd0cae2bfb
Merge branch 'master' into difficulty-attribute-helpers 2021-11-17 20:49:31 +09:00
Dan Balasescu
815179f713 Use consts for attribute IDs 2021-11-17 20:31:18 +09:00
Dean Herbert
369b4ba789 Update DifficultyCalculator to take an IRulesetInfo 2021-11-15 19:16:48 +09:00
Dean Herbert
62d670a3ca Update DifficultyCalculator to take an IWorkingBeatmap 2021-11-15 19:16:48 +09:00
Dan Balasescu
c8a01c35f7 Remove extra members from FromDatabaseAttributes 2021-11-15 18:11:07 +09:00
Dan Balasescu
0cfd6fdf04 Add to/from database mapping functions to difficulty attributes 2021-11-15 16:06:50 +09:00
Dan Balasescu
907499f73a Add json properties to difficulty attributes 2021-11-15 16:06:29 +09:00
Bartłomiej Dach
540b7e1b38
Fix taiko editor not unapplying slider multiplier changes on save 2021-11-08 13:28:42 +01:00
Bartłomiej Dach
d88fd1bfd7
Add failing test case 2021-11-08 13:23:24 +01:00
Dean Herbert
0ecf5f201c Rename User to APIUser and move to correct namespace 2021-11-07 11:26:01 +09:00
Dean Herbert
5c7623e68e
Merge pull request #15255 from goodtrailer/node-samples-ilist
Change IHasRepeats.NodeSamples to IList from List
2021-10-28 14:24:26 +09:00
Dean Herbert
add39fbd4f Merge branch 'master' into fix-skin-layout-editor-crash 2021-10-28 06:24:24 +09:00
Dean Herbert
6944151486 Apply batch fixing of built-in types using var 2021-10-27 13:04:41 +09:00
goodtrailer
4440b9ca11 Change IHasRepeats.NodeSamples to IList from List 2021-10-23 01:59:07 -07:00
Dean Herbert
93482414d6 Remove SkinConfiguration subclasses and allow configuration parsing for all skin types 2021-10-22 14:42:23 +09:00
Dan Balasescu
e49f1f6e6b
Merge branch 'master' into no-more-difficulty-control-points-info 2021-10-13 20:17:57 +09:00
Dean Herbert
b8fe744d2b
Merge pull request #15008 from stanriders/remove-int-casts
Remove int casts in difficulty calculation
2021-10-10 16:48:37 +09:00
smoogipoo
e30e5bd214 Remove int casts in other calculators 2021-10-10 16:23:35 +09:00
Bartłomiej Dach
8007ba93eb
Fix typo in TaikoMultiplierAppliedDifficulty class name 2021-10-09 14:25:40 +02:00
smoogipoo
bc37cb6f43 Merge branch 'master' into no-more-difficulty-control-points-info 2021-10-08 18:41:17 +09:00
Dean Herbert
0ab8dcc2a0 Fix taiko weird difficulty multiplier failing on double convert 2021-10-06 15:18:06 +09:00
Dean Herbert
b339c149d8 Copy BaseDifficulty to Beatmap<T> and move all write operations across 2021-10-06 15:10:45 +09:00
Dean Herbert
bd84a8b749 Merge branch 'new-interfaces' into beatmap-difficulty-more-interface-usage 2021-10-05 18:21:21 +09:00
Dean Herbert
1d99bc280f Merge branch 'master' into new-interfaces 2021-10-04 20:42:40 +09:00
Dean Herbert
32afd3f426 Replace all basic usages 2021-10-02 02:22:23 +09:00
Dean Herbert
05996cc2e9 Add changes that got forgotted in branch surgery 2021-10-01 17:04:53 +09:00
Dean Herbert
a92d499d7a Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo 2021-10-01 16:55:50 +09:00
Dean Herbert
46bafb6252 Merge branch 'master' into no-more-difficulty-control-points-info 2021-09-28 13:53:56 +09:00
smoogipoo
430ecc5409 Adjust to make HD slightly harder and not obsolete 2021-09-21 15:20:04 +09:00
Dean Herbert
491430e88e
Merge branch 'master' into fix-taiko-hd 2021-09-17 23:20:57 +09:00
Dean Herbert
be7346d0b7 Refactor getSizeFor to read a touch better 2021-09-17 19:18:37 +09:00
smoogipoo
35c3d75cb8 Preserve flashlight size through aspect adjustment 2021-09-17 18:51:43 +09:00
smoogipoo
2d39131202 Refactor taiko flashlight a bit 2021-09-17 18:41:03 +09:00
smoogipoo
f584d6593a Fix flashlight alignment 2021-09-17 18:10:53 +09:00
smoogipoo
a4238e49a7 Revert "Don't apply normal visibility to increased visibility state"
This reverts commit 5dd0e0d961.
2021-09-17 17:39:34 +09:00
smoogipoo
5dd0e0d961 Don't apply normal visibility to increased visibility state 2021-09-17 17:33:32 +09:00
smoogipoo
ea68be08cb Split magic values into named constants 2021-09-17 17:27:54 +09:00
smoogipoo
c9e76783e6 Fix taiko HD not calculating pre-empt correctly 2021-09-17 17:24:03 +09:00
smoogipoo
f9d5abff8a Update with keybinding changes 2021-09-16 18:26:12 +09:00
Dean Herbert
693ecdf62a Refactor some incorrect/outdated terminology 2021-09-06 21:32:43 +09:00
Dean Herbert
a3d9ab1e2e Move approach rate to EffectControlPoint 2021-09-03 16:58:16 +09:00
Dean Herbert
071c56e90b Update usages of DifficultyPointAt 2021-09-03 16:58:16 +09:00
Dean Herbert
b907c2f4f6 Fix osu! judgements getting scaled twice over different durations 2021-09-02 16:31:43 +09:00
Dan Balasescu
c4da966ad9
Merge pull request #14575 from peppy/add-legacy-convert-encode-stability-tests
Fix multiple conversions of a beatmap to taiko ruleset applying speed multiplier multiple times
2021-08-30 18:47:09 +09:00
Dean Herbert
6a6dac609c Fix instability of taiko double conversion
Until now, the taiko speed multiplier was potentially applied more than
once if conversion was run multiple times.
2021-08-30 15:30:18 +09:00
Dean Herbert
ee49305cad Move taiko legacy speed multiplier to osu.Game project
Allows it to be used in local case in `LegacyBeatmapEncoder`.
2021-08-30 15:13:31 +09:00
Salman Ahmed
cea632463e Remove empty newline 2021-08-26 22:30:20 +03:00
Dean Herbert
90e81a595d Move DrumSampleTriggerSource into its own class to avoid nested references 2021-08-26 17:19:46 +09:00
Dean Herbert
8e0a04c4e5 Update taiko InputDrum to use new trigger logic 2021-08-25 16:56:44 +09:00
Xexxar
176b3e7533 changed decay system to allow for customizing the currentStrain 2021-08-16 22:14:29 +00:00
Dean Herbert
6bbc23c831
Merge pull request #14106 from smoogipoo/taiko-classic-mod
Make taiko classic mod emulate the classic "4:3" scroll speed
2021-08-02 22:22:26 +09:00
smoogipoo
8d999d30f6 Remove interface definition 2021-08-02 20:38:49 +09:00
smoogipoo
455666ed94 Remove taiko HD mod 4:3 scaling 2021-08-02 20:18:01 +09:00
smoogipoo
9327bc169b Make TaikoModClassic use classic-like scroll speed 2021-08-02 20:01:46 +09:00
smoogipoo
c023ce78d7 Match osu!stable taiko playfield size at 16:9 2021-08-02 18:48:32 +09:00
Henry Lin
e89f33483d Code formatting fixes 2021-07-28 21:52:01 +08:00
Henry Lin
22d83c75e3 Revert imports re-ordering
Out of the scope of this PR
2021-07-28 18:32:38 +08:00
Henry Lin
58bbe9db7e Added muted mod 2021-07-28 18:21:08 +08:00
Bartłomiej Dach
fb5d25405e
Replace calls to obsoleted GetOrDefault() extension 2021-07-18 21:52:16 +02:00
Dean Herbert
90326f8864 Standardise variables 2021-07-09 13:24:26 +09:00
Dean Herbert
bd7c334588 Avoid the need for per-settings control classes 2021-07-08 17:49:00 +09:00
Dean Herbert
a6e94dd491 Add back extended limits support 2021-07-08 17:49:00 +09:00
Dean Herbert
0e4f4a6fde Initial storage changes 2021-07-08 14:28:13 +09:00
PercyDan54
e1c646b9b2
Remove redundant arguments 2021-07-05 23:52:39 +08:00
Dean Herbert
1b0aadcc6f Merge branch 'master' into transformers-per-skin 2021-06-22 16:03:15 +09:00
Dean Herbert
4b45d8318e
Merge branch 'master' into transformers-per-skin 2021-06-16 16:37:28 +09:00
Dean Herbert
98e0e89d3f Nest adjustments for readability 2021-06-16 16:32:59 +09:00
Dean Herbert
18343160cf Reword comments slightly 2021-06-16 16:31:38 +09:00
Dean Herbert
5944c45f55 Specify types explicitly and don't handle non-nullable values with fallbacks 2021-06-16 16:24:30 +09:00
Dean Herbert
a5c09454e6 Remove unnecessary configuration 2021-06-16 16:16:18 +09:00
Bartłomiej Dach
8c558610ab Fix hitobjects expiring before fully judged with hidden 2021-06-16 00:34:39 +02:00
Bartłomiej Dach
57f0c47ded Ezplain slider multiplier adjustment 2021-06-15 23:00:11 +02:00
Bartłomiej Dach
b0549187df Apply pre-empt formula which is closer to stable 2021-06-15 22:57:20 +02:00
Bartłomiej Dach
259e6cad4d Rearrange and rename member 2021-06-15 22:34:07 +02:00
Bartłomiej Dach
a549aebb3f Reword HD scale multiplier comment 2021-06-15 22:32:26 +02:00
Bartłomiej Dach
6d2b5252c6 Attempt to reword setting to be more understandable 2021-06-11 13:07:09 +02:00
Bartłomiej Dach
e194f8b34a Replace lifetime workaround with explicit set 2021-06-11 12:26:58 +02:00
Salman Ahmed
fbb856d84b Call base when overriding lookup methods
Rather than arbitrarily accessing `Skin` here and there.
2021-06-11 12:44:44 +03:00
Ivan Pavluk
6d06066dde forgot to run code inspection 2021-06-11 15:54:48 +07:00
Ivan Pavluk
e34e26ae52 remove outdated comment 2021-06-11 15:12:05 +07:00
Ivan Pavluk
09df23e2a6 improve reasoning for hd_sv_scale 2021-06-11 15:07:41 +07:00
Ivan Pavluk
46b379899e add taiko hd mod (2nd attempt) 2021-06-11 14:09:23 +07:00
Dean Herbert
9c34cb0777 Share colour constants with default drawable piece implementations 2021-06-11 14:20:08 +09:00
Dean Herbert
bc3b7233ab Show osu!taiko centre/rim colouring in editor timeline
Closes #13443.
2021-06-11 14:17:30 +09:00
Dan Balasescu
35d5632355
Merge pull request #13378 from Syriiin/diffcalc/refactor/auto-properties
Refactor DifficultyAttributes to use auto properties over public fields
2021-06-10 18:42:11 +09:00
Salman Ahmed
dde84e5cbd Merge branch 'master' into transformers-per-skin 2021-06-10 11:58:52 +03:00
Salman Ahmed
cf40282f1f Convert LegacySkinTransformers to accept raw ISkins rather than a full ISkinSource 2021-06-09 22:49:31 +03:00
Dean Herbert
85abee5fc7 Remove difficulty calculator exceptions
I don't think there's any reason difficulty calculators shouldn't be
able to calculate for autoplays.
2021-06-09 14:33:35 +09:00
Dean Herbert
d0e9f8ef90 Replace and obsolete Ranked flag with IsUserPlayable 2021-06-09 14:17:03 +09:00
Samuel Cattini-Schultz
f1bef989b7 Refactor DifficultyAttributes to use auto properties over public fields 2021-06-08 19:43:59 +10:00
Dan Balasescu
791855dfa0
Merge branch 'master' into legacy-skin-default-fallback 2021-06-08 16:54:26 +09:00
Dean Herbert
273d66a0e0 Fix TaikoMascot texture animation lookups 2021-06-08 00:42:34 +09:00
Dean Herbert
06275a6a7d Merge branch 'master' into legacy-skin-default-fallback 2021-06-04 16:00:30 +09:00
Dan Balasescu
b283c48abb
Merge branch 'master' into factor-out-hoc 2021-06-04 15:31:35 +09:00
Pasi4K5
7a4fc9ffc8 Move seed to base class 2021-06-03 18:16:11 +02:00
Dan Balasescu
15b43beef1
Merge pull request #11857 from Syriiin/diffcalc/refactor/catch-clockrate-effects
Refactor catch Movement skill to not require explicit clockrate usage
2021-06-03 17:29:27 +09:00
Samuel Cattini-Schultz
f51413ead9 Refactor to pass clockrate in constructor rather than deriving from mods 2021-06-03 16:09:42 +10:00
ekrctb
2c9e5b6c7e Replace EntryCrossedBoundary with more useful RemoveRewoundEntry property
It can be used for dynamically added entries.
2021-06-03 15:00:16 +09:00
Dean Herbert
2e2281c7d2 Revert disabling taiko sample tests and fix logic 2021-06-01 18:57:19 +09:00
Dean Herbert
14570b6fb1 Merge branch 'master' into autoplay-pause-support 2021-06-01 14:19:21 +09:00
Dean Herbert
17574833fb Update other transformers with similar refactored logic 2021-05-30 19:15:59 +09:00
Salman Ahmed
fbc316ea1d Fix legacy skin transformers potentially ignoring source implementations 2021-05-29 21:23:22 +03:00
Dean Herbert
cbad7bb7f0 Move taiko Type to Hit and localise all bind handling 2021-05-26 13:40:36 +09:00
Dean Herbert
912748b428 Avoid bindable feedback causing overwrites 2021-05-26 13:24:22 +09:00
Dean Herbert
9223d85f37 Remove all local type update logic from TaikoBeatmapConverter
I believe the original goal was to keep this in the converter with the
idea that samples may not always be hard coupled to the strong/rim
states. But for now I think we can assume this coupling is going to
continue into the near future, so let's keep all the logic in
`TaikoHitObject`.
2021-05-26 13:23:01 +09:00
Dean Herbert
a3c78674a1 Add new interface for autoplay mods 2021-05-25 18:09:24 +09:00
Dean Herbert
4c9d72e62a Ensure EditorBeatmap.Update is called inside PerformOnSelection calls 2021-05-23 21:22:35 +09:00
Dean Herbert
dc322d1c63 Run all type and sample mutations through standardising methods 2021-05-23 20:22:48 +09:00
Dean Herbert
6471ce902d Run RecreatePieces using AddOnce to avoid multiple unnecessary calls 2021-05-21 16:45:28 +09:00
Dean Herbert
0bcd0cda6b Fix taiko drawable hit content not correctly being removed on regeneration 2021-05-21 16:41:40 +09:00
Dean Herbert
7bc8a4bb5f Apply same logic changes to IsStrong status 2021-05-21 16:15:27 +09:00
Dean Herbert
a5ca736e37 Fix RecreatePieces being called more than once 2021-05-21 16:10:48 +09:00
Dean Herbert
40c8378d81 Fix type-to-sample mapping being applied too late 2021-05-21 14:37:22 +09:00
Dean Herbert
c00e6e29a6 Remove static usage 2021-05-21 14:21:56 +09:00
Dean Herbert
df5970fab4 Create base implementations of the two most common TernaryStateMenuItems 2021-05-20 19:34:53 +09:00
Dean Herbert
a96603f025
Merge pull request #12782 from smoogipoo/rework-hitobject-blueprints
Rename hitobject blueprints and tie them to HitObjects
2021-05-18 16:30:58 +09:00
Dean Herbert
de2900bc7c
Merge pull request #12834 from Henry-YSLin/flip-mod
Added "invert" mod for taiko
2021-05-17 12:47:05 +09:00
Henry Lin
f34637ea9c Renamed TaikoModFlip to TaikoModSwap 2021-05-17 11:04:01 +08:00
Henry Lin
c4ae70a827 Revert "Renamed TaikoModFlip to TaikoModInvert"
This reverts commit 5972e43bc2.
2021-05-17 10:59:56 +08:00
Dean Herbert
a32f1ef35a
Merge pull request #12811 from PercyDan54/hidden-code-cleanup
Remove obsolete methods in `ModHidden` and apply few touches
2021-05-16 22:07:45 +09:00
Henry Lin
5972e43bc2 Renamed TaikoModFlip to TaikoModInvert 2021-05-16 12:51:40 +08:00
Dean Herbert
422a3b76b6 Remove unused using statements 2021-05-16 13:21:19 +09:00
Dean Herbert
cbc2a38b59 Move new mod to end to avoid reordering 2021-05-16 13:21:06 +09:00
Henry Lin
3d83741a23 Separate Flip and Random 2021-05-16 12:03:03 +08:00
Henry Lin
da13be6dd0 Trimmed trailing white space 2021-05-16 11:28:11 +08:00
Henry Lin
3519398a22 Added "flip" mod for taiko 2021-05-16 11:16:12 +08:00
PercyDan54
166974506e
Duplicate implementions 2021-05-15 11:55:50 +08:00
Bartłomiej Dach
f716fb0968 Remove bogus InternalChildren null-check
`InternalChildren` can't viably be `null`, and if it were, we have
bigger problems. The removed null-check was triggering false-positive
inspections further down.
2021-05-15 00:09:34 +02:00