37510 Commits

Author	SHA1	Message	Date
Dean Herbert	c0cfa66510	Merge pull request #21754 from Feodor0090/waveform-invalidate ... Reload waveform on track replacement in editor	2023-01-06 19:57:27 +08:00
Dean Herbert	4319937bc7	Also add an underline to better accent current filters	2023-01-06 20:36:10 +09:00
Dean Herbert	3c74d27deb	Also add an underline to better accent current filters	2023-01-06 20:35:58 +09:00
Dean Herbert	458fe382ed	Make selected tab items more bold	2023-01-06 20:06:41 +09:00
Dean Herbert	938658649e	Merge pull request #22043 from frenzibyte/fix-solo-leaderboard-hyphen ... Fix gameplay leaderboard showing "-" on non-tracked scores	2023-01-06 18:12:00 +08:00
Dean Herbert	464f251c0c	Merge branch 'master' into beatmap-set-link-genre-language	2023-01-06 17:09:06 +08:00
Salman Ahmed	408356d05e	Fix gameplay leaderboard showing "-" on non-tracked scores	2023-01-06 12:06:47 +03:00
ansel	c6e2104ec2	Refresh waveforms instead of recreating the whole component	2023-01-06 03:46:49 +03:00
Salman Ahmed	88148567c0	Merge branch 'master' into fix-playlist-item-regressions	2023-01-05 15:31:27 +03:00
Salman Ahmed	7d8aff8f7e	Fix settings toolbox group not animating on expansion	2023-01-05 14:35:57 +03:00
Salman Ahmed	8da7667b0b	Decrease transition duration of extended difficulty list during hide	2023-01-05 14:22:17 +03:00
Salman Ahmed	8f37e69dc4	Schedule difficulty calculation to avoid performing with incomplete state updates	2023-01-05 12:52:08 +03:00
Salman Ahmed	39221a52da	Fix advanced statistics display using decoupled ruleset bindable for difficulty calculation	2023-01-05 12:52:08 +03:00
Joseph Madamba	5fb6f220e6	Fix playlist items not animating when rearranging	2023-01-03 11:10:02 -08:00
Joseph Madamba	5dfd4180c8	Fix playlist selecting random item when not allowed after deleting	2023-01-03 11:10:02 -08:00
Bartłomiej Dach	4ead7ea33f	Merge branch 'master' into fix-leaderboard-fetch-wrong	2023-01-03 20:01:30 +01:00
Bartłomiej Dach	3d425c93e6	Merge branch 'master' into fix-combo-colour-export	2023-01-03 19:21:24 +01:00
Dean Herbert	beb3b96aca	Harden request equality checks	2023-01-04 01:44:00 +08:00
Dean Herbert	96e81e7f41	Switch on NRT and add IEquatable to GetScoresRequest	2023-01-04 01:41:21 +08:00
Salman Ahmed	4491a5ba9f	Fix editor exporting beatmap combo colours in wrong order	2023-01-03 13:41:08 +03:00
Dean Herbert	ac85433178	Fix default volume control keys not working when chat textbox is focused ... Closes #22004.	2023-01-03 09:44:35 +08:00
Dean Herbert	8f7ae0395a	Fix song select leaderboard potentially showing wrong scores on quick beatmap changes ... Closes #22002.	2023-01-03 00:55:09 +08:00
Bartłomiej Dach	a124c967df	Add proper offline & loading state handling to user profile overlay	2023-01-02 17:23:09 +01:00
Bartłomiej Dach	c759b743dc	Add support for switching rulesets on profile overlay	2023-01-02 17:23:06 +01:00
Bartłomiej Dach	a2e726502f	Add ruleset selector to profile overlay	2023-01-02 17:23:04 +01:00
Bartłomiej Dach	7683ab68b0	Use UserProfile in profile ruleset selector	2023-01-02 17:23:01 +01:00
Bartłomiej Dach	1722f3a125	Add ruleset to UserProfile	2023-01-02 17:22:55 +01:00
Bartłomiej Dach	4dd7727f71	Remove test-specific workaround in overlay	2023-01-02 17:21:14 +01:00
Bartłomiej Dach	d7294ac3e6	Substitute APIUser for UserProfile in overlay	2023-01-02 17:21:09 +01:00
Bartłomiej Dach	608d8ee7d4	Add UserProfile model to be used in user profile overlay ... As `APIUser` implements `IEquatable`, attempting to replace an `APIUser` with another `APIUser` with the same online ID has no effect on the user profile overlay. This is a significant hurdle in implementing support for viewing the profile for different rulesets, as in that case the profile is basically reloaded for the same user, but slightly different data. To facilitate this, wrap `APIUser` in a new `UserProfile` class. This will mean that the equality rules can be changed locally to the user profile overlay without impacting other components that depend on the `APIUser` equality rules. The ruleset that the user profile is being displayed with will eventually be added to `UserProfile`, too.	2023-01-02 17:21:00 +01:00
Joseph Madamba	d79ee29f29	Make replays pause with middle mouse button instead of exiting	2023-01-01 21:01:12 -08:00
Bartłomiej Dach	88e90d5fa0	Enable NRT in user profile overlay	2023-01-01 23:49:11 +01:00
Bartłomiej Dach	b689ad6d80	Fix changing preview point not prompting for save	2023-01-01 19:54:26 +01:00
Bartłomiej Dach	efdd557f3b	Adjust binding logic	2023-01-01 19:45:23 +01:00
Bartłomiej Dach	452ebddfd2	Adjust visual appearance of preview time part ... - Use slightly different hue of green to distinguish from difficulty control points. The colour is still not ideal, but picking a distinctive enough hue is pretty hard. - Place the preview time part at the bottom rather at the top. Not sure why it was at the top; not only could it overlap with the control points, but it also looked quite badly misaligned there when bookmarks were displayed at the bottom.	2023-01-01 19:42:55 +01:00
Bartłomiej Dach	a82f1a6abd	Adjust method naming and copy	2023-01-01 18:50:47 +01:00
Bartłomiej Dach	0e59b55a12	Merge branch 'master' into previewTime	2023-01-01 18:38:19 +01:00
Bartłomiej Dach	2698d58c46	Merge branch 'master' into remember-chat-textbox-per-channel	2023-01-01 17:29:38 +01:00
Dean Herbert	7e39ee3982	Merge pull request #21945 from cdwcgt/acc-UI ... Add new display modes for accuracy counter	2023-01-01 23:20:12 +08:00
Dean Herbert	9a4f0cad2c	Fix incorrect domain root being used for recent activity entries on profile overlay ... Closes https://github.com/ppy/osu/issues/21980.	2023-01-01 17:48:05 +08:00
Dean Herbert	87250ad847	Add search keywords for beatmap colours / hitsound overrides	2023-01-01 14:32:28 +08:00
Bartłomiej Dach	6509d3538c	Fix counter initially rolling down from 100% to 0% in minimum achievable mode	2022-12-30 21:13:41 +01:00
Bartłomiej Dach	7580ab78be	Move binding to LoadComplete()	2022-12-30 21:08:48 +01:00
Bartłomiej Dach	6ed474d4fb	Rearrange formula for maximum accuracy ... Feels like it's easier to understand this way. The difference of the maximum scoring values for the entire beatmap and the max values for the part of the beatmap that has already been played represents the act of filling the rest of the unjudged objects with maximum results.	2022-12-30 20:56:54 +01:00
Bartłomiej Dach	8ace635249	Adjust minimum values	2022-12-30 20:55:51 +01:00
Bartłomiej Dach	bb2822a175	xmldoc pass	2022-12-30 20:55:48 +01:00
Bartłomiej Dach	6d42cc5a36	Naming pass	2022-12-30 20:30:58 +01:00
cdwcgt	d60349c7c6	add description	2022-12-30 23:24:41 +09:00
cdwcgt	8beb168be9	remove nullable disabled	2022-12-30 23:24:20 +09:00
cdwcgt	784fe7ecf2	rename AccType to AccuracyDisplay	2022-12-30 23:06:10 +09:00
cdwcgt	23c485c763	readonly	2022-12-30 22:59:56 +09:00
cdwcgt	a91da2284d	safe way to pass bindable	2022-12-30 22:58:46 +09:00
cdwcgt	3c32a50c12	add new accuracy counter display	2022-12-30 21:19:46 +09:00
Bartłomiej Dach	0d70f2c0fd	Use alternative workaround	2022-12-30 09:08:17 +01:00
Bartłomiej Dach	f625c5d744	Fix gradient showing when toggling toolbar with mouse above window	2022-12-29 23:35:45 +01:00
Bartłomiej Dach	bf975eb48a	Fix toolbar gradient not showing when mouse is hovered over buttons	2022-12-29 23:03:53 +01:00
Dean Herbert	ccf713c885	Fix incorrect hard link validity check in stable import screen	2022-12-29 23:18:12 +08:00
Dean Herbert	0fcf10e10a	Also support hard links on macOS	2022-12-29 22:35:13 +08:00
Dean Herbert	f9f6918fc3	Merge branch 'master' into add_linux_hardlink	2022-12-29 21:29:57 +08:00
Bartłomiej Dach	c5f7da9a4e	Fix hover propagating through toolbar buttons ... Closes #21920. Weirdly enough this was semeingly fixed once before in ancient times in 3891f467a3, but then unfixed again in 566e09083f. The second change is no longer needed since the toolbar became opaque in #9447.	2022-12-29 13:19:14 +01:00
Joseph Madamba	70dbb8edac	Fix stand alone chat display textbox not binding to local channel	2022-12-29 01:37:37 -08:00
Joseph Madamba	c326745f96	Save / sync chat text box messages per channel	2022-12-28 16:09:40 -08:00
Joseph Madamba	b40d114e76	Remove context menu from news card for now	2022-12-28 15:00:57 -08:00
Bartłomiej Dach	74bc5d4666	Disable naming rule inspection on struct stat definition	2022-12-28 22:38:42 +01:00
Bartłomiej Dach	10c11e974d	Fix broken spacing	2022-12-28 22:24:21 +01:00
Bartłomiej Dach	49b0ec9ddb	Fix broken condition	2022-12-28 22:24:18 +01:00
Bartłomiej Dach	8d79fa93ac	Implement GetFileLinkCount() for Linux	2022-12-28 22:14:56 +01:00
Bartłomiej Dach	d4b3965967	Change warning message about file duplication ... - It was being glued in an ugly way that would have prevented sanely localising it. - Even on Linux, the filesystem (whichever one the user has chosen out of the multitude available) still needs to support hard links for them to have a chance of working.	2022-12-28 22:04:08 +01:00
Bartłomiej Dach	04d4b4a6ce	Rename and xmldoc hard link creation method	2022-12-28 22:04:05 +01:00
Bartłomiej Dach	cadd487c75	Use switch statement in AttemptHardLink()	2022-12-28 21:20:49 +01:00
Bartłomiej Dach	2c346eae0d	Revert inlining of hard link creation into condition ... Just feels bad. Mixing data access with actual underlying logic.	2022-12-28 21:19:28 +01:00
BlauFx	d63be3ff17	Change name of variable	2022-12-28 15:02:44 +01:00
BlauFx	c6da7248ba	Remove unnecessary directive	2022-12-28 14:40:32 +01:00
BlauFx	53bca947d1	Move duplicated code into its own method	2022-12-28 14:34:27 +01:00
BlauFx	f32564652b	Mention the filesystem should be NTFS on Windows	2022-12-28 14:33:38 +01:00
BlauFx	5c5e84f931	Fix formatiing	2022-12-28 14:06:50 +01:00
Dean Herbert	ea8beffa61	Merge pull request #21871 from bdach/solo-statistics-watcher-reliability ... Improve reliability of solo statistics watcher	2022-12-28 21:05:38 +08:00
BlauFx	16165b1f67	Remove blank line	2022-12-28 13:58:52 +01:00
Feodor0090	930cd15649	Merge branch 'master' into comment-editor-1	2022-12-28 17:46:01 +05:00
Bartłomiej Dach	e4c060fc3a	Merge pull request #21854 from peppy/fix-website-root ... Fix `osu.ppy.sh` links no longer opening in-game	2022-12-28 13:43:24 +01:00
BlauFx	b2aa2e1602	Add hardlink support for Linux	2022-12-28 13:32:49 +01:00
Bartłomiej Dach	4b71ccf315	Merge pull request #21879 from frenzibyte/first-object-visbility-keywords ... Add keywords to ease search of "first object visibility" setting	2022-12-28 12:15:34 +01:00
Salman Ahmed	b4c5e18da0	Add keywords to ease search of "first object visibility" setting	2022-12-28 13:23:50 +03:00
Bartłomiej Dach	3c0b8af8f1	Allow unsubscribing from solo statistics updates ... This is more of a safety item. To avoid potential duplicate key in dictionary errors (and also avoid being slightly memory-leaky), allow `SoloStatisticsWatcher` consumers to dispose of the subscriptions they take out.	2022-12-28 08:07:48 +01:00
Bartłomiej Dach	04f9a354c3	Convert SoloResultsScreen to NRT	2022-12-28 07:54:36 +01:00
Bartłomiej Dach	a0a26b1e8c	Ignore statistics update subscriptions with invalid score ID ... If score submission fails, the score will not receive a correct online ID from web, but will still be passed on to the solo statistics watcher on the results screen. This could lead to the watcher subscribing to changes with score ID equal to the default of -1. If this happened more than once, that would cause a crash due to duplicate keys in the `callbacks` dictionary. Closes #21837.	2022-12-28 07:54:01 +01:00
Bartłomiej Dach	e9d32fca18	Fix various failures in initial statistics fetch ... - If the local user is restricted, then attempting to fetch their data from the `/users` endpoint would result in an empty response. - Even if the user was successfully fetched, their `RulesetsStatistics` may not be populated (and instead be `null`). Curiously this was not picked up by static analysis until the first issue was fixed. Closes #21839.	2022-12-28 07:31:36 +01:00
Dean Herbert	0d78bc2248	Fix osu.ppy.sh links no longer opening in-game ... Addresses https://github.com/ppy/osu/discussions/21838.	2022-12-28 06:42:35 +08:00
Bartłomiej Dach	e90619244d	Fix incorrect accuracy display on overall ranking view	2022-12-27 19:51:51 +01:00
Bartłomiej Dach	ae2058b55e	Merge branch 'master' into split_trimentries	2022-12-27 18:07:36 +01:00
Salman Ahmed	1a4489edb2	Move version pinning of system packages to osu.Game	2022-12-27 14:58:18 +03:00
Dean Herbert	61029b126d	Add link to hard link explanation wiki page	2022-12-27 17:56:23 +08:00
Dean Herbert	b3e44f20bc	Use new lazer API endpoint ... This is a temporary change to target the new experimental/next deploy. The main change that should result from this is having the user profile show the pp^next values from the new domain.	2022-12-27 17:20:40 +08:00
Berkan Diler	182f36c434	Use StringSplitOptions.TrimEntries for string.Split() when possible	2022-12-27 09:41:58 +01:00
Dean Herbert	df6f2ad0a1	Merge pull request #21804 from bdach/hide-global-rankings-when-presenting-scores ... Only show global rankings on solo results screen when progressing from gameplay	2022-12-27 16:39:26 +08:00
Joseph Madamba	777ffcf805	Highlight "open" option on external link button context menu	2022-12-26 20:47:24 -08:00
Joseph Madamba	bb58976838	Merge remote-tracking branch 'upstream/master' into overlay-panels-context-menu	2022-12-26 17:54:15 -08:00
integer	a0690e7ffb	replay menus remembers expanded state ... no messing with readonly fields	2022-12-27 00:13:46 +00:00
Joseph Madamba	8bc8b0d0af	Remove redundant context menu container	2022-12-26 15:38:07 -08:00
Joseph Madamba	84e3858a86	Move context menu / popover container one level to account for header	2022-12-26 15:37:46 -08:00
Bartłomiej Dach	01cf96e240	Only show global rankings on results screen when progressing from gameplay	2022-12-26 23:35:45 +01:00
Bartłomiej Dach	cb2b0d4178	Remove redundant type specs	2022-12-26 23:12:53 +01:00
Berkan Diler	fcbb21c75e	Fix typo	2022-12-26 20:38:35 +01:00
Berkan Diler	c7ca4bbba5	Use generic Enum methods	2022-12-26 20:36:39 +01:00
Bartłomiej Dach	e416bdd06b	Merge branch 'master' into remove_obsolete_star_colours	2022-12-26 16:35:47 +01:00
mk56-spn	fbff5d8d69	Remove obsoleted "ForDifficultyRating" method	2022-12-26 16:16:52 +01:00
Dean Herbert	5dd03c6c60	Update framework	2022-12-26 21:53:52 +08:00
Dan Balasescu	786d94c149	Merge pull request #21792 from Joehuu/fix-parameters-inspection ... Fix parameters with the same default value inspection	2022-12-26 15:41:54 +09:00
Joseph Madamba	0dba25e0ab	Refactor to just exit sub screens until lounge sub screen ... Co-Authored-By: Salman Ahmed <frenzibyte@gmail.com>	2022-12-25 21:56:22 -08:00
Dean Herbert	09cc41604f	Merge branch 'master' into score-stats-on-results	2022-12-26 13:37:36 +08:00
Joseph Madamba	144144c40c	Revert removing redundant font parameter	2022-12-25 20:47:05 -08:00
Salman Ahmed	ee77b8cad3	Merge branch 'master' into fix-parameters-inspection	2022-12-26 05:17:40 +03:00
Salman Ahmed	2d57ea6f15	Merge branch 'master' into link-title-and-artist	2022-12-26 03:23:05 +03:00
Joseph Madamba	973fd90af2	Fix parameters with the same default value inspection	2022-12-25 16:15:02 -08:00
Joseph Madamba	f959b02dc8	Use empty drawables for spacing badges instead	2022-12-25 16:05:59 -08:00
Joseph Madamba	8e899c2e92	Use localisation parameters to find preferred string instead	2022-12-25 16:03:44 -08:00
Joseph Madamba	1a571e1c7f	Remove nullable disable on user panel	2022-12-25 15:03:08 -08:00
integer	272288c9aa	fix code style and naming	2022-12-25 21:50:56 +00:00
Joseph Madamba	b9dfb8b602	Add localisation for context menu strings	2022-12-25 10:12:02 -08:00
Joseph Madamba	2c2f347e25	Add context menus to overlay panels/cards	2022-12-25 09:57:42 -08:00
Joseph Madamba	5232588a1f	Use PerformFromScreen to exit sub screens instead	2022-12-24 20:04:45 -08:00
integer	d392d1a5c0	override a sub-method instead of the whole Export()	2022-12-24 22:18:42 +00:00
Joseph Madamba	00ed5d6f92	Merge remote-tracking branch 'upstream/master' into fix-op-non-current-onexiting	2022-12-24 14:01:11 -08:00
Joseph Madamba	b871d6f078	Remove unused fields	2022-12-24 13:35:17 -08:00
Joseph Madamba	ae967e08b0	Add badges when needed instead of using alpha	2022-12-24 13:27:46 -08:00
Joseph Madamba	4f6b3644f3	Fix title/artist overflowing to right side	2022-12-24 12:40:32 -08:00
Joseph Madamba	df645ef3cb	Change title/artist idle colour to white	2022-12-24 11:42:05 -08:00
Joseph Madamba	9d073f4228	Link beatmap set title and artist to listing search	2022-12-24 11:26:09 -08:00
Bartłomiej Dach	36a6f3685e	Don't show global rankings display when not logged in	2022-12-24 14:35:11 +01:00
Bartłomiej Dach	145130ba80	Register solo statistics watcher at game level	2022-12-24 14:35:07 +01:00
Bartłomiej Dach	da519acb20	Add overall ranking display to solo results	2022-12-24 14:35:04 +01:00
Bartłomiej Dach	3abdf557ea	Add protected method for customising statistics panel rows	2022-12-24 14:35:00 +01:00
Bartłomiej Dach	600ada46be	Add protected method for customising statistics panel	2022-12-24 14:34:54 +01:00
Bartłomiej Dach	cf0b3ec879	Merge branch 'master' into score-stats-display	2022-12-24 14:32:08 +01:00
Dean Herbert	209d44746a	Merge pull request #21762 from bdach/score-stats-updates ... Add solo statistics watcher component to deliver incremental global user statistics updates	2022-12-24 21:30:34 +08:00
Bartłomiej Dach	e961af20cc	Merge branch 'score-stats-updates' into score-stats-display	2022-12-24 13:56:10 +01:00
Bartłomiej Dach	78c47a3695	Add callback to dictionary rather than overwrite ... Attempting to overwrite will henceforth throw an exception.	2022-12-24 13:45:04 +01:00
Bartłomiej Dach	6c4ca387e0	Fix wrong handling of missing ruleset statistics	2022-12-24 13:44:11 +01:00
Bartłomiej Dach	3c26016b61	Ensure latest stats are cleared on successful profile fetch	2022-12-24 13:44:08 +01:00
Bartłomiej Dach	fd9110a61e	Fix solo statistics watcher firing requests for invalid user with id 1 ... Can happen during login flow (see `APIAccess.attemptConnect()`).	2022-12-24 13:44:05 +01:00
Bartłomiej Dach	d6e079a2b4	Ignore statistics update requests from third-party rulesets for now	2022-12-24 13:43:57 +01:00
Bartłomiej Dach	83a50816b6	Remove unused constructor param	2022-12-24 10:44:38 +01:00
Bartłomiej Dach	4bcc2b832c	Merge branch 'master' into add-help-button	2022-12-24 10:40:35 +01:00
Bartłomiej Dach	301eb71e22	Fix wrong member names	2022-12-24 10:39:05 +01:00
Dean Herbert	2c060ac8d4	Add localisation support for new button's strings	2022-12-24 17:32:04 +08:00
Bartłomiej Dach	4e5109a649	Use plain bindable flow instead of binding to watcher directly	2022-12-24 10:27:28 +01:00
Bartłomiej Dach	75ddeaeeb8	Merge branch 'master' into argon-pro-skin-hide-highest-judgement	2022-12-24 09:41:18 +01:00
Bartłomiej Dach	80de5dac66	Fix judgement text never being added to hierarchy	2022-12-24 09:37:40 +01:00
Bartłomiej Dach	f973befcd4	Remove unused resolved member	2022-12-24 09:34:30 +01:00
Dean Herbert	91bde14fb3	Add button to settings to show lazer upgrade guide	2022-12-24 15:42:24 +08:00
Dean Herbert	5e9fb1063a	Move judgement text creation to base class and tidy things up	2022-12-24 12:22:36 +08:00
Bartłomiej Dach	c7f248e13c	Implement overall ranking display for solo results screen	2022-12-24 00:30:38 +01:00
integer	498d00935b	limit date appending to LegacyScoreExporter only	2022-12-23 23:01:04 +00:00
Bartłomiej Dach	3e782c5f5f	Extract interface for solo statistics watcher	2022-12-23 23:46:41 +01:00
Dean Herbert	727ac00f6d	Combine base class for JudgementPiece	2022-12-24 03:32:13 +08:00
Joseph Madamba	2dbcf05fe4	Use enum values as ids in fallback instead	2022-12-23 11:13:27 -08:00
Joseph Madamba	494886ef92	Rename Text to Metadata	2022-12-23 11:11:15 -08:00
Bartłomiej Dach	94d78a47a4	Merge branch 'master' into upgrade-guide-help	2022-12-23 17:22:04 +01:00
Bartłomiej Dach	9a2cc04361	Fix wrong path being used in fail handler	2022-12-23 16:44:03 +01:00
Bartłomiej Dach	67aea34e7e	Merge branch 'master' into fix-breadcrumb-tab-item-click-area	2022-12-23 16:36:58 +01:00
Dean Herbert	a677c8be06	Change path on error	2022-12-23 21:17:42 +08:00
Dean Herbert	5eccafe190	Fix wiki overlay showing error message when load is cancelled	2022-12-23 16:45:40 +08:00
ansel	f25439e359	Move track change subscription to LoadComplete	2022-12-23 01:54:49 +03:00
Bartłomiej Dach	676d4a0d6d	Merge branch 'master' into fix-waveform-zoom-reload	2022-12-22 23:48:50 +01:00
Salman Ahmed	0cb9b79834	Fix ZoomableScrollContainer potentially not updating content width on setup	2022-12-23 00:56:38 +03:00
Salman Ahmed	30de9ba795	Dispose previous waveform on track reload	2022-12-23 00:35:59 +03:00
Berkan Diler	08d2fbeb8e	Use new ArgumentNullException.ThrowIfNull throw-helper API	2022-12-22 21:27:59 +01:00
Bartłomiej Dach	fa2d50fe31	Limit tracking unhandled scores to just the last one	2022-12-22 19:59:39 +01:00
Bartłomiej Dach	48dc2332fd	Refactor test to be easier to work with	2022-12-22 19:59:35 +01:00
Bartłomiej Dach	ac872fac9e	Implement solo statistics watcher	2022-12-22 19:59:07 +01:00
ansel	20370bd5ae	Invalidate waveform on track load	2022-12-22 20:49:09 +03:00
Salman Ahmed	8be6350c01	Remove no longer necessary assert	2022-12-22 20:07:53 +03:00
Flutterish	5df440e20e	dont use is..or syntax	2022-12-22 17:27:55 +01:00
Flutterish	422fdd8ae5	dont post notifications from custom log targets	2022-12-22 16:56:27 +01:00
ansel	d0645ce151	Rewrite waveform invalidation	2022-12-22 15:59:51 +03:00
ansel	f2e8776529	Bind to clock instead of music controller	2022-12-22 15:35:53 +03:00
Salman Ahmed	28fc2f34b5	Merge branch 'master' into restore-default-button-hit-area	2022-12-22 13:32:57 +03:00
Bartłomiej Dach	f5b3988dd2	Add data structure for delivering statistics updates	2022-12-22 08:01:59 +01:00
Dean Herbert	11321f1a41	Merge pull request #21738 from bdach/spectator-user-score-processed ... Add score processed callback to spectator client	2022-12-22 13:55:43 +08:00
ansel	a18ece8610	Listen for track reload in timing screen	2022-12-22 01:24:23 +03:00
ansel	7089bb6c23	Listen for track reload in timeline	2022-12-22 01:23:59 +03:00
ansel	66a02374da	Clear cached waveform on track change in editor	2022-12-22 01:23:24 +03:00
Bartłomiej Dach	6948035a3c	Ensure score submission attempt completion before notifying spectator server when exiting play early ... When a `SubmittingPlayer` gameplay session ends with the successful completion of a beatmap, `PrepareScoreForResultsAsync()` ensures that the score submission request is sent to and responded to by osu-web before calling `ISpectatorClient.EndPlaying()`. While previously this was mostly an implementation detail, this becomes important when considering that more and more server-side flows (replay upload, notifying about score processing completion) hook into `EndPlaying()`, and assume that by the point that message arrives at osu-spectator-server, the score has already been submitted and has been assigned a score ID that corresponds to the score submission token. As it turns out, in the early-exit path (when the user exits the play midway through, retries, or just fails), the same ordering guarantees were not provided. The score's submission ran concurrently to the spectator client `EndPlaying()` call, therefore creating a network race. osu-server-spectator components that implciitly relied on the ordering provided by the happy path, could therefore fail to unmap the score submission token to a score ID. Note that as written, the osu-server-spectator replay upload flow is not really affected by this, as it self-corrects by essentially polling the database and trying to unmap the score submission token to a score ID for up to 30 seconds. However, this change would have the benefit of reducing the polls required in such cases to just one DB retrieval.	2022-12-21 22:23:26 +01:00
Joseph Madamba	e1e6d76f30	Check id for genre/language instead and fallback to name if not defined	2022-12-21 11:02:04 -08:00
Bartłomiej Dach	3ec31a5f51	Fix language selector in first run dialog not updating after changing language in settings	2022-12-21 19:30:21 +01:00
Joseph Madamba	1d39e8d0ce	Refactor MetadataSection to use generics and inheritance	2022-12-21 10:18:47 -08:00
Dean Herbert	19f66c806e	Fix language dropdown in settings not updating after changing language in first run dialog ... Closes #21744.	2022-12-21 16:31:55 +08:00
integer	b06a7daf26	append date to score export filename	2022-12-20 23:40:00 +00:00
Bartłomiej Dach	b03291330f	Add score processed callback to spectator client	2022-12-20 21:23:50 +01:00
Bartłomiej Dach	cebd5f6dc2	Fix restore default button having a minuscule hit area ... Another casualty of edc78205d5. This particular button was actually *relying* on receiving positional events from its entire bounding box rather than `Content`, in order for the button to be htitable more easily, which broke as other buttons were fixed to behave more in line with expectations. Upon closer inspection this is another case of a weird carried-over construction. The button doesn't really need to inherit `OsuButton` or do any of the arcane stuff that it was doing, so it's now a plain `OsuClickableContainer` with less `Content` hackery.	2022-12-20 20:47:58 +01:00
Bartłomiej Dach	378486cbe0	Merge branch 'master' into argon-pro-skin	2022-12-20 19:34:56 +01:00
Bartłomiej Dach	bf074adb13	Remove unused using directive	2022-12-20 18:24:26 +01:00
Bartłomiej Dach	8ead606065	Merge branch 'master' into ui-scale-only-show-one-screen	2022-12-20 18:23:37 +01:00
Dean Herbert	2c402d4740	Update resources	2022-12-21 01:24:41 +09:00
Jamie Taylor	f7c854f1b0	Change asset folder	2022-12-20 21:18:51 +09:00
Dean Herbert	2f0c772dcb	Add argon pro skin	2022-12-20 21:18:51 +09:00
wiskerz76	439b8ac56a	Fix file select popup getting stuck when switching first run screens while selecting ... Closes #21663 Supersedes #21724	2022-12-20 17:59:23 +09:00
Dean Herbert	c119d41a2d	Only show song select for now at ui scale adjust first run screen ... Having both was a bit too much. Still not happy with this but it's a bit less sensory overload. I think while it's cool being able to show nested screens like this, it needs more thought to actually be a good experience.	2022-12-20 17:52:56 +09:00
Joseph Madamba	01f09529a8	Link beatmap set genre and language to listing filters	2022-12-19 22:54:33 -08:00
Bartłomiej Dach	64a45aa0e0	Merge branch 'master' into wiki-heading-id-attributes	2022-12-20 06:34:47 +01:00
Dean Herbert	4a9b58adda	Merge branch 'master' into markdown-footnote-support	2022-12-20 13:48:35 +09:00
Bartłomiej Dach	7c282d9def	Enable generic attribute support for wiki markdown containers	2022-12-19 21:32:38 +01:00
Bartłomiej Dach	db1380a346	Refactor markdown extension management	2022-12-19 20:19:51 +01:00
Bartłomiej Dach	a88812861e	Implement bidirectional footnote link navigation	2022-12-19 19:34:47 +01:00
Bartłomiej Dach	73a4310935	Add styling for footnote groups	2022-12-19 19:34:40 +01:00
Bartłomiej Dach	112613c2f0	Add styling for footnote links	2022-12-19 19:28:01 +01:00
Bartłomiej Dach	0dce899634	Throw on OsuClickableContainer.ClearInternal() invocations ... As they may cause critical failure due to getting rid of the `Content`.	2022-12-19 18:25:45 +01:00
Bartłomiej Dach	186ccc64fd	Fix welcome screen language buttons not working	2022-12-19 18:19:26 +01:00
Dean Herbert	ecac6299c6	Update framework	2022-12-19 22:01:20 +09:00
Dean Herbert	4a7d7c6ed9	Use MaxBy in all locations that can and update inspection level to match dotnet-build	2022-12-19 16:47:10 +09:00
Dean Herbert	8a01a22612	Fix two null refrences in OsuGame	2022-12-19 16:47:10 +09:00
Dean Herbert	877413524f	Cherry-picked android changes from #17462	2022-12-19 15:46:54 +09:00
Dean Herbert	b64a5cbda6	Merge branch 'master' into guard-url-protocols	2022-12-19 15:46:45 +09:00
Joseph Madamba	6e62033bc4	Fix some comment actions not being lowercased	2022-12-18 20:20:15 -08:00
Bartłomiej Dach	fea0895f16	Call spectator EndPlaying() immediately after score submission ... As it turns out, in current `master`, if a gameplay session ends normally (i.e. by the player completing the beatmap in full), then the spectator server `EndPlaying()` method will not be called until `SubmittingPlayer.OnExiting()`, which in practice turns out to be the moment where the user exits from the post-gameplay results screen back to song select. There is seemingly no reasonable cause for not calling this earlier. In fact the solo spectator flow looks more broken without this call than with, because without it the spectator view just hangs until the spectated player exits gameplay, and *only then* shows results, rather than do it upon normal gameplay completion.	2022-12-17 21:35:43 +01:00
Joseph Madamba	813c351607	Fix breadcrumb tab item click area not extending to background height	2022-12-16 21:44:10 -08:00
mk56-spn	f3873b73e3	Clean up syntax for readability	2022-12-16 20:56:34 +01:00
Dean Herbert	192536643c	Fix some more inspections	2022-12-16 20:21:19 +09:00
Dean Herbert	dd9a418549	Fix assembly location lookups	2022-12-16 19:19:59 +09:00
Dean Herbert	de079e08dc	Fix incorrect ConfigureAwait call in ImportAsUpdate	2022-12-16 18:54:56 +09:00
Dean Herbert	ba54551313	Merge branch 'master' into guard-url-protocols	2022-12-16 18:23:16 +09:00
Dean Herbert	27c497145f	Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0	2022-12-16 18:16:26 +09:00
Jamie Taylor	d5b2c7dfe9	Clamp SFX panning on results screen	2022-12-16 17:19:07 +09:00
Dean Herbert	d6cae991da	Update netstandard2.1 references to net6.0	2022-12-16 17:16:13 +09:00
Dean Herbert	e63b544167	Update framework	2022-12-16 17:02:51 +09:00
Dean Herbert	ce408eaac0	Merge branch 'net6-ios' into guard-url-protocols	2022-12-16 17:02:32 +09:00
Dan Balasescu	cbee72897a	Merge pull request #21654 from Susko3/use-localisable-strings-for-dates-and-times ... Use `LocalisableString`s for date and time formats	2022-12-16 16:17:14 +09:00
Dean Herbert	232f590ba3	Merge pull request #21628 from peppy/go-hard-file-writes ... Use hard links on windows when importing beatmaps from a legacy osu! install	2022-12-16 14:52:57 +09:00
cdwcgt	a4d28aff6d	fix typo	2022-12-16 10:48:56 +09:00
cdwcgt	79e27c2d9d	PreviewTimePart will not show if preview time is -1	2022-12-16 10:44:07 +09:00
cdwcgt	f0246df1a9	only get;	2022-12-16 09:58:58 +09:00
Susko3	0f34d908c7	Use LocalisableStrings for date and time formats	2022-12-16 00:05:47 +01:00
Salman Ahmed	5fbd4ad3b4	Update usages of SupportsJIT in line with framework changes	2022-12-16 00:22:11 +03:00
Salman Ahmed	660cc72f2a	Avoid configuring web proxies on iOS for now	2022-12-16 00:22:11 +03:00
cdwcgt	984f0b5fa9	Add test for set preview point	2022-12-16 01:35:54 +09:00
cdwcgt	c164744064	Add ability to set preview time	2022-12-16 01:03:30 +09:00
mk56-spn	0c177aa7de	Improve tests, simplify "updateDisplay" method	2022-12-15 16:12:34 +01:00
mk56-spn	9a235b3213	remove rolling duration, fix issue with loading	2022-12-15 15:21:03 +01:00
Dean Herbert	9813bc9544	Reword disclaimer and fix translation keys	2022-12-15 22:46:31 +09:00
Dean Herbert	91adf2e80f	Apply the wala-hyphen ... Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>	2022-12-15 22:44:47 +09:00
Dean Herbert	d2b98b803d	Turn on featured artist filter by default and add disclaimer when toggling for the first time	2022-12-15 18:42:47 +09:00
Dean Herbert	0763b86236	Add more padding around text in dialog popups	2022-12-15 17:32:27 +09:00
Dean Herbert	78bc94d3cb	Set featured artists filter to enabled by default	2022-12-15 16:57:39 +09:00
Dean Herbert	a7f3e13946	Fix MultipleSelectionFilter not correctly handling initial selection	2022-12-15 16:56:09 +09:00
Dean Herbert	6bf1477939	Fix some hard links not being created due to missing directory structure ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2022-12-15 14:17:28 +09:00
Dan Balasescu	fb85eaee95	Add description for lazer score version 30000001	2022-12-14 18:30:33 +09:00
Dean Herbert	50dc76d579	Merge pull request #21618 from smoogipoo/multi-spec-only-local-results ... Only show local results in multi-spectator results screen	2022-12-14 14:00:02 +09:00
Dean Herbert	a3c3112f89	Add SetLastError hint to CreateHardLink pinvoke method ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2022-12-14 11:34:06 +09:00
Dean Herbert	f4316a9827	Fix incorrect grammar in hard link explanation text ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2022-12-14 11:30:01 +09:00
Bartłomiej Dach	849245b90c	Merge branch 'master' into beginplaying-score-token	2022-12-13 17:15:24 +01:00
Bartłomiej Dach	dfb8f4fdd9	Merge branch 'master' into buttons-fix	2022-12-13 16:35:03 +01:00
Dean Herbert	3d65984a89	Update framework	2022-12-13 22:34:01 +09:00
Dean Herbert	bf56f5f8c0	Show error message on attempting to open a URL with an unsupported protocol	2022-12-13 22:33:56 +09:00
Dean Herbert	efe057176e	Make OsuButton abstract	2022-12-13 22:13:48 +09:00
Dean Herbert	edc78205d5	Add comments about why both positional input checks are required in OsuClickableContainer	2022-12-13 22:12:52 +09:00
Dean Herbert	b8904fe747	Move ImportParameters to better home	2022-12-13 21:41:26 +09:00
Dean Herbert	cb16d62700	Hook up ImportParameter flow with IModelImporter caller methods	2022-12-13 21:29:32 +09:00
Dean Herbert	6bb612ce69	Move hard link availability check to helper class	2022-12-13 20:20:42 +09:00
Dean Herbert	bbf931c746	Move hard link helper functions to their own class	2022-12-13 19:55:18 +09:00
Dean Herbert	1d4230993d	Hook up parameter with RealmFileStore to complete the chain	2022-12-13 19:55:18 +09:00
Dean Herbert	cf2719d4c0	Convert batchImport parameter to parameters class to allow further import configuration	2022-12-13 19:55:18 +09:00
Dan Balasescu	ad7554cc7d	Allow keeping stream open after encoding scores	2022-12-13 16:15:14 +09:00
Andrei Zavatski	15bd82add8	Fix DrawableUsername being affected	2022-12-12 18:24:49 +03:00
mk56-spn	edb46e422c	Fix "using" name in HUD overlay	2022-12-12 15:15:30 +01:00
mk56-spn	99d83315c1	change settings order	2022-12-12 15:10:45 +01:00
mk56-spn	8efe7528e3	change ruleset source to avoid issues with converted beatmaps	2022-12-12 15:10:10 +01:00
Andrei Zavatski	890dd9cd06	Fix input doesn't take original drawable modifications into account	2022-12-12 15:10:03 +03:00
Andrei Zavatski	b0d475cd8b	CI fix	2022-12-12 14:57:07 +03:00
Andrei Zavatski	d2b3533356	Fix OsuClickableContainer input receiving	2022-12-12 14:42:54 +03:00
Andrei Zavatski	7e39f171fb	Fix OsuButton input receiving	2022-12-12 14:42:54 +03:00
Dean Herbert	5800734589	Merge pull request #21587 from smoogipoo/spectatorstate-maximum-statistics ... Store maximum statistics to spectator state	2022-12-12 20:00:52 +09:00
mk56-spn	4d592184ca	temp cmt	2022-12-12 11:53:07 +01:00
Dean Herbert	df94af4495	Inline ScoringValues and make some more methods private inside ScoreProcessor	2022-12-12 19:22:09 +09:00
Dan Balasescu	7b48c91fe2	Only show local results in multi-spectator results screen	2022-12-12 18:56:43 +09:00
mk56-spn	58bf081096	Fix judgement counter not loading after first attempt in gameplay, Fix typo in Display	2022-12-12 10:52:55 +01:00
Dean Herbert	02b3bbf0d3	Merge pull request #21616 from Joehuu/changelog-build-masking ... Fix changelog single build dates disappearing before being off screen	2022-12-12 18:28:48 +09:00
Dean Herbert	05b5949810	Use explicit casts	2022-12-12 17:38:39 +09:00
Dan Balasescu	caa0b7c290	Move score token to BeginPlaying	2022-12-12 13:59:27 +09:00
Dean Herbert	e2d8909e73	Add link to change folder location if it isn't on the same drive as import path	2022-12-12 13:44:09 +09:00
Dean Herbert	726943cb14	Add information attempting to explain hard links to the end user	2022-12-12 13:44:09 +09:00
Dean Herbert	d8de99bbe4	Check for hard link support in first run overlay	2022-12-12 13:44:09 +09:00
Dean Herbert	902dff15e3	Add todo regarding validity check	2022-12-12 13:44:09 +09:00
Dean Herbert	3b1920c060	Add code to check whether a file is a hard link	2022-12-12 13:44:09 +09:00
Dean Herbert	f27603dd6d	Use hard links instead of file copy when available	2022-12-12 13:44:09 +09:00
Dean Herbert	731184eb39	Revert "Merge pull request #21614 from EVAST9919/button-fix" ... This reverts commit 4bd196684f, reversing changes made to a1d22ef77a.	2022-12-12 13:43:01 +09:00
Joseph Madamba	e76c56b03b	Fix changelog single build dates disappearing before being off screen	2022-12-11 20:10:06 -08:00
Dan Balasescu	7a54bcac57	Remove unused using	2022-12-12 11:41:07 +09:00
Dan Balasescu	6e41efede8	Simplify dictionary construction	2022-12-12 11:40:47 +09:00
Dan Balasescu	5e8d75bbbf	Remove unused overload	2022-12-12 11:39:03 +09:00
Andrei Zavatski	1332568796	Fix SettingsButton receiving input at padded area	2022-12-12 03:10:13 +03:00
mk56-spn	f0c780f1f6	Fix tally header	2022-12-12 00:48:35 +01:00
mk56-spn	a107fca5d0	Hide "Full" option from counter flow directions	2022-12-12 00:33:28 +01:00
mk56-spn	161894da3b	Add more test checks and fix deserialisation test	2022-12-11 23:58:10 +01:00
mk56-spn	4c17b27273	Add Display, Counter, Tests	2022-12-11 23:47:17 +01:00
mk56-spn	f798951f09	Create Judgement Info struct	2022-12-11 22:09:14 +01:00
mk56-spn	ffbe68bd26	Add judgementTally to HUD overlay	2022-12-11 22:08:48 +01:00
Dean Herbert	85039209f8	Fix parsing of ruleset configuration values being incorrect on some locales ... Closes #21611.	2022-12-12 01:56:36 +09:00
Dean Herbert	0372e38f57	Add nullability assertion to appease CI	2022-12-11 13:00:12 +09:00
Dean Herbert	061f7d4857	Merge branch 'master' into osr-scoreinfo-data	2022-12-11 12:24:03 +09:00
Dan Balasescu	e9998f1690	Store maximum statistics to spectator state	2022-12-09 20:15:07 +09:00
Dan Balasescu	4a65f5c864	Add score token to spectator state	2022-12-09 19:09:51 +09:00
Dan Balasescu	3570fa8d93	Fix hub clients not reconnecting after connection error	2022-12-09 17:12:20 +09:00
dependabot[bot]	cdf76077b2	Bump Newtonsoft.Json from 13.0.1 to 13.0.2 in /osu.Game ... Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 13.0.1 to 13.0.2. - [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases) - [Commits](https://github.com/JamesNK/Newtonsoft.Json/compare/13.0.1...13.0.2) --- updated-dependencies: - dependency-name: Newtonsoft.Json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>	2022-12-08 05:38:06 +00:00
Dean Herbert	f21e903a94	Update framework	2022-12-08 14:06:38 +09:00
Dan Balasescu	313f6e2f10	Merge pull request #21558 from peppy/fix-wrong-di ... Fix incorrect resolution of `GameHost` in `LegacyImportManager`	2022-12-08 12:59:31 +09:00
Dan Balasescu	2406b8dfc8	Merge pull request #21557 from Joehuu/nominated-ranked-beatmaps ... Display nominated ranked beatmaps in user profile	2022-12-08 11:40:24 +09:00
Dan Balasescu	e00c075482	Fix incorrectly modified first lazer version	2022-12-08 11:30:18 +09:00
Dean Herbert	f6e0aba53d	Merge pull request #21564 from Loreos7/master ... Fix stale keybinding in "today's tip"	2022-12-08 11:23:09 +09:00
Bartłomiej Dach	5857471915	Merge branch 'master' into nominated-ranked-beatmaps	2022-12-07 23:54:25 +01:00
Bartłomiej Dach	3f4cab9ad1	Merge branch 'master' into fix-profile-beatmap-expand	2022-12-07 21:10:07 +01:00
Loreos7	0aeee8d6ab	fix typo in today's tip	2022-12-07 17:47:37 +03:00
Dean Herbert	819fd5f950	Fix incorrect resolution of GameHost in LegacyImportManager	2022-12-07 17:53:14 +09:00
OliBomby	98a312ca96	Fix segmentEnds incorrect on shortened paths	2022-12-07 09:52:09 +01:00
OliBomby	cd46ca31f9	Add segmend end completions to SliderPath	2022-12-07 09:51:22 +01:00
Dean Herbert	62b0436bcf	Reverse depth of profile sections to allow for overflowing expanded beatmap cards ... Closes #21554.	2022-12-07 16:38:17 +09:00
Joseph Madamba	56e94e49a3	Display nominated ranked beatmaps in user profile	2022-12-06 23:36:11 -08:00
Dean Herbert	0497e433b1	Change SectionsContainer to use flowing children for section update logic	2022-12-07 16:30:15 +09:00
Dean Herbert	c5e461e734	Update framework	2022-12-07 16:28:51 +09:00
Dean Herbert	e8766570c5	Update resources	2022-12-07 16:06:53 +09:00
Dean Herbert	d8d25c704f	Merge pull request #21551 from peppy/fix-latency-certifier-butons ... Remove triangle effect from latency certifier buttons	2022-12-07 15:55:39 +09:00
Dean Herbert	70e0a04af8	Merge pull request #21541 from bdach/difficulty-bindable-regression ... Fix extended values in difficulty adjust being truncated to 10 on beatmap change	2022-12-07 15:05:07 +09:00
Dean Herbert	eea7984ba9	Remove triangle effect from latency certifier buttons	2022-12-07 14:53:56 +09:00
Dan Balasescu	8709b1f2ea	Immediately send ack request when joining new channels	2022-12-07 14:24:20 +09:00
Dan Balasescu	df181acffe	Append lazer score data to .osr files	2022-12-07 12:12:32 +09:00
Bartłomiej Dach	81a42dc05d	Fix extended values in difficulty adjust being truncated to 10 on beatmap change	2022-12-06 23:25:48 +01:00
mk56-spn	fc630165fd	Adjust formatting of BPM text	2022-12-06 15:08:21 +01:00
Dan Balasescu	e47f933cdc	Merge pull request #21520 from frenzibyte/fix-preview-track-disposal ... Fix preview track disposal potentially leaving game track muted	2022-12-06 14:19:21 +09:00
Dan Balasescu	9ddc2f4804	Merge pull request #21523 from Feodor0090/rewind-click-fix ... Perform rewind with right click only if cursor didn't leave the button	2022-12-06 13:38:20 +09:00
ansel	b66409bd37	Perform rewind with right click only if cursor didn't leave the button	2022-12-05 23:38:45 +03:00
mk56-spn	f69c084969	Add roll duration	2022-12-05 17:08:00 +01:00
Salman Ahmed	a457a2fbbf	Fix disposal of playing preview track not unmuting game track	2022-12-05 14:45:32 +03:00
mk56-spn	b6a6db1160	Add dynamic BPM counter to SkinEditor	2022-12-05 12:29:23 +01:00
Dan Balasescu	9e64f8dab1	Fix loss of precision when computing accuracy	2022-12-05 19:08:50 +09:00
Dean Herbert	c288873365	Merge pull request #21502 from EVAST9919/smooth-progress-remove ... Remove SmoothCircularProgress component as being replaced	2022-12-05 14:49:32 +09:00
Salman Ahmed	af000c6e92	Fix RangeSlider potentially throwing exception on mobile platforms	2022-12-04 21:58:00 +03:00
ansel	7d7b824f56	Add description for torus alt	2022-12-03 23:42:16 +03:00
ansel	b240d15731	Fix numeric font	2022-12-03 23:38:50 +03:00
ansel	8174f6be64	Get rid of dublicated enum	2022-12-03 23:32:17 +03:00
Bartłomiej Dach	cb64919947	Merge branch 'master' into fix-exported-replay-overwrite	2022-12-03 21:09:19 +01:00
ansel	b41f30c868	Allow changing font of text elements	2022-12-03 22:44:54 +03:00
ansel	0db6c2ada1	Add enum with font types	2022-12-03 22:38:11 +03:00
Dean Herbert	36ab6bc64e	Update framework ... Update framework	2022-12-04 01:30:27 +09:00
Bartłomiej Dach	7f0d366d01	Extract common part of regex to separate method	2022-12-03 16:59:43 +01:00
Andrei Zavatski	41f7dad8e9	Delete SmoothCircularProgress.cs	2022-12-03 16:40:41 +03:00
Andrei Zavatski	97b6d88f00	Remove SmoothCircularProgress usage in AccuracyCircle	2022-12-03 16:39:44 +03:00
Andrei Zavatski	94cfcdb338	Remove SmoothCircularProgress usage in BeatmapCardThumbnail	2022-12-03 16:16:21 +03:00
Dean Herbert	49f5ac57b8	Fix first run beatmap screen button colours looking incorrect with new triangle effect ... Addresses #21500.	2022-12-03 18:48:54 +09:00
Dean Herbert	5a69656764	Merge pull request #21496 from peppy/fix-zero-length-spinners ... Fix being able to place zero-length spinners	2022-12-02 19:25:00 +09:00
Dan Balasescu	850931120d	Merge pull request #21479 from peppy/fix-wrong-last-hit-object-time ... Fix some components not accounting for final hold notes in osu!mania beatmaps	2022-12-02 18:12:00 +09:00
Dean Herbert	d1296a22ce	Update timeline blueprint's end time logic to better match new blueprint implementation	2022-12-02 17:57:15 +09:00
Dean Herbert	ba99f1288c	Update IBeatSnapProvider documentation to mention the pre-divided BeatSnap	2022-12-02 17:57:15 +09:00
Dan Balasescu	eea9bd3898	Merge pull request #21463 from peppy/fix-chat-system-message-ordering ... Fix system messages appearing out of order in chat display	2022-12-02 17:39:20 +09:00
Dan Balasescu	a39bd634c4	Merge pull request #21405 from LumpBloom7/Editor-DrawableRuleset-Dependencies ... Provide DrawableRulesetDependencies from HitObjectComposer	2022-12-02 17:31:31 +09:00
Dan Balasescu	d684aa75b8	Merge pull request #21477 from peppy/fix-mania-timeline-blueprint-colour ... Fix osu!mania editor timeline showing bright-white blueprints	2022-12-02 16:55:29 +09:00
Dean Herbert	25120060aa	Use new helper method in ModTimeRamp	2022-12-02 16:09:46 +09:00
Dean Herbert	a2db0afe19	Avoid querying GetLastObjectTime twice in editor seek flow	2022-12-02 16:07:24 +09:00
Dean Herbert	809d02cda0	Fix two implementation oversights	2022-12-02 16:05:14 +09:00
Dean Herbert	8cf89fcb81	Use Highlight1 instead of dull grey	2022-12-02 15:30:47 +09:00
Piggey	75cf7bd1d2	change GetNextBestFilename()'s parameters	2022-12-01 18:44:02 +01:00
Piggey	5de01686a9	extract findBestNumber() from GetNextBestName() into private method	2022-12-01 18:42:52 +01:00
Dean Herbert	d8dd7e7e0f	Fix test failures when no hitobjects are present in a scrolling ruleset	2022-12-01 21:42:03 +09:00
Dean Herbert	896f2d8f74	Fix multiple instances of last hitobject time being calculated incorrectly	2022-12-01 18:04:06 +09:00
Dean Herbert	f34a79b1a9	Set a better default colour for timeline blueprints when no colour information is available	2022-12-01 17:03:53 +09:00
Dean Herbert	bbf023cf68	Fix incorrect culture used when parsing timeline popup textbox content	2022-12-01 16:12:29 +09:00
Dean Herbert	c5bc071c4b	Merge pull request #21439 from LumpBloom7/Fix-DHO-load-state ... Update DrawableHitObject state based on entry result during LoadComplete	2022-12-01 15:36:36 +09:00
Bartłomiej Dach	2e19e93036	Rename method	2022-11-30 22:54:14 +01:00
Bartłomiej Dach	6ebde9a747	Annotate Playfield.Mods as maybe-null	2022-11-30 20:00:25 +01:00
Piggey	8f59aad91c	unnecessary includes	2022-11-30 18:37:50 +01:00
Piggey	8b856f1c89	make LegacyExporter use NamingUtils.GetNextBestFilename()	2022-11-30 18:32:53 +01:00
Piggey	8412a44179	create NamingUtils.GetNextBestFilename()	2022-11-30 18:32:14 +01:00
Piggey	b99ddc2acf	use .Select() to trim the file extension from filename	2022-11-30 15:36:08 +01:00
Derrick Timmermans	5c8fce1c08	Remove extra blank line	2022-11-30 13:05:14 +01:00
Derrick Timmermans	6a61e70766	Expose Ruleset from HitObjectComposer instead	2022-11-30 12:17:58 +01:00
ansel	1763618488	Fix spinner presense check & field click	2022-11-30 13:58:03 +03:00
ansel	43628903a7	Make spinner bigger	2022-11-30 13:57:09 +03:00
ansel	1cc7ffce39	Keep button's text	2022-11-30 13:40:47 +03:00
ansel	bedc771e99	Remove useless check	2022-11-30 13:32:01 +03:00
ansel	a8422961dc	Rename button spinner prop again	2022-11-30 13:30:57 +03:00
ansel	5ea824534b	Use default button	2022-11-30 13:25:59 +03:00
ansel	642e0ac718	Increase footer height to look better with default buttons	2022-11-30 13:25:18 +03:00
ansel	f4a8ac60a8	Revert autosizing in OsuButton	2022-11-30 13:12:10 +03:00
ansel	956acbc86f	Use fixed width	2022-11-30 13:11:54 +03:00
Piggey	660ad913ec	oh wait this affects all of the legacy exporters	2022-11-30 11:06:44 +01:00
Dawid Sośnia	f0b8b53e81	Merge branch 'ppy:master' into fix-exported-replay-overwrite	2022-11-30 10:54:12 +01:00
Piggey	5e74c4e3b7	override LegacyScoreExporter.Export() to not overwrite files	2022-11-30 10:52:41 +01:00
Piggey	f5d85f5774	make ExportStorage protected	2022-11-30 10:51:42 +01:00
Dean Herbert	5ce2d6f54a	Hide the game mouse cursor when playing osu!catch with relax mod	2022-11-30 18:13:53 +09:00
Dean Herbert	bb0237d4a9	Fix nullability inspection on disposal path	2022-11-30 17:49:08 +09:00
Dean Herbert	4215f4f5d7	Merge branch 'master' into Editor-DrawableRuleset-Dependencies	2022-11-30 17:42:46 +09:00
Dean Herbert	4a747182b4	Merge branch 'master' into comment-editor-1	2022-11-30 17:22:59 +09:00
Dean Herbert	b1ce93e7bf	Add fallback stable sort to avoid any change of misordered local messages	2022-11-30 16:55:39 +09:00
Dean Herbert	f7b7b58718	Adjust colour and tween to feel better	2022-11-30 16:20:01 +09:00
Dean Herbert	24ee363563	Only hover when hovering actual text	2022-11-30 16:18:36 +09:00
Dean Herbert	80b0e4a99d	Rename Colour to avoid conflict with Drawable.Colour	2022-11-30 16:15:50 +09:00
Dean Herbert	7fca5ee28d	Move DrawableUsername into own file ... It's too large at this point to be a nested class.	2022-11-30 16:15:50 +09:00
Dean Herbert	9ab4664fcc	Merge branch 'master' into chat-profile-highlight-v2	2022-11-30 16:15:48 +09:00
Dean Herbert	b7f0310070	Merge pull request #21353 from peppy/no-initial-presence ... Stop requesting messages as part of initial chat presence	2022-11-30 16:15:23 +09:00
Dean Herbert	6524914dbd	Merge branch 'master' into chat-profile-highlight-v2	2022-11-30 16:00:52 +09:00
Dean Herbert	78f70dae75	Merge pull request #21420 from cdwcgt/NowPlaying ... Show mods, ruleset and unicode metadata in "now playing" chat command	2022-11-30 15:57:52 +09:00
Dean Herbert	2d8854cbac	Change message comparator to always use timestamp comparison if either message has a missing Id	2022-11-30 15:46:58 +09:00
Dean Herbert	9e34fe360a	Ensure all LocalMessages get a timestamp	2022-11-30 15:46:36 +09:00
Dean Herbert	c84f011bb7	Improve ToString output of Message	2022-11-30 15:46:14 +09:00
Dean Herbert	b29054d30d	Merge pull request #21434 from jai-x/control-point-scroll-into-view ... Ensure currently selected control point will scroll into view	2022-11-30 15:14:14 +09:00
Dean Herbert	d5301c75c1	Merge pull request #21460 from EVAST9919/triangles-v2-remove-texture ... Remove texture usage in TrianglesV2 component	2022-11-30 15:13:08 +09:00
Dean Herbert	8bf5d6884d	Add ruleset to now playing string	2022-11-30 14:47:16 +09:00
Dean Herbert	b453eecebe	Ensure empty pieces do not result in whitespace between elements	2022-11-30 14:43:21 +09:00
Dean Herbert	2df6ccf33e	Tidy up code	2022-11-30 14:31:54 +09:00
Dean Herbert	b5c514a8f0	Make incoming Channel target non-nullable	2022-11-30 14:30:20 +09:00
Dean Herbert	69bf0df179	Merge branch 'master' into NowPlaying	2022-11-30 14:27:37 +09:00
Dean Herbert	2a3b24d058	Avoid need for implicit null casting	2022-11-30 14:21:04 +09:00
Dean Herbert	0659c84341	Rename method to be more in line with project naming	2022-11-30 14:17:49 +09:00
Dean Herbert	63ba40ff39	Merge branch 'master' into control-point-scroll-into-view	2022-11-30 14:12:19 +09:00
Dan Balasescu	fcd7c27bc2	Merge pull request #21451 from peppy/update-framework ... Update framework	2022-11-30 13:39:08 +09:00
Dan Balasescu	3f4d8b39ca	Update package again	2022-11-30 12:55:45 +09:00
Andrei Zavatski	2eaefcad30	Remove unused renderer	2022-11-30 04:56:07 +03:00
Andrei Zavatski	3b13ca1167	Remove texture from TrianglesV2	2022-11-30 04:09:46 +03:00
Jai Sharma	7dbf379351	Don't use verbatim string literals	2022-11-29 18:22:07 +00:00
ansel	e30d97c94e	Comments	2022-11-29 14:39:59 +03:00
ansel	84aaf5fedf	Change ways to access submit button state	2022-11-29 14:37:35 +03:00
ansel	6c126f5223	Remove useless local actions on click	2022-11-29 14:25:51 +03:00
Dean Herbert	08a403cb33	Merge pull request #21428 from mk56-spn/RangeSlider_implementation ... Refactor star "DifficultyRangeFilterControl" into generic range slider	2022-11-29 16:08:13 +09:00
Dean Herbert	56a694fb04	Add automated test coverage of simple scenarios for RangeSlider	2022-11-29 15:10:21 +09:00
Dean Herbert	61c702c02e	Add new IDependencyInjectionCandidate interface to non-drawable cached classes	2022-11-29 14:45:26 +09:00
Dean Herbert	b5b79e09e4	Remove unnecessary CQ disable	2022-11-29 14:45:08 +09:00
Bartłomiej Dach	8f78d6179b	Fix multiple issues with settings items unhiding on search	2022-11-29 14:41:49 +09:00
Bartłomiej Dach	24deb5f5f4	Remove all unnecessary usage of IHasFilterableChildren	2022-11-29 14:40:52 +09:00
Dean Herbert	96e19d4d84	Update framework	2022-11-29 14:36:23 +09:00
Dan Balasescu	198303513b	Merge pull request #21450 from Feodor0090/comments-btns-loc ... Add missing localization in `DrawableComment`	2022-11-29 13:47:46 +09:00
ansel	16962d9a57	Localize deleted string	2022-11-29 07:02:02 +03:00
ansel	a4819e5c9c	Localize actions	2022-11-29 07:01:52 +03:00
ansel	472d9274b6	Reorder members	2022-11-29 06:23:25 +03:00
ansel	af0ee9dbd6	Make spinner a little bigger	2022-11-29 06:19:54 +03:00
ansel	894fb98fa2	Rebase CommitButton to RoundedButton	2022-11-29 06:17:02 +03:00
ansel	a874345da0	Rebase CancelButton to RoundedButton	2022-11-29 05:46:30 +03:00
ansel	25ddd20b2e	Allow OsuButton be auto-sized	2022-11-29 05:44:40 +03:00
ansel	d20dc3668e	Enable nullability	2022-11-29 05:17:44 +03:00
ansel	8b033bf9f7	Allow localisable strings	2022-11-29 05:13:54 +03:00
Alden Wu	8ec4dd046e	Fix InspectCode errors	2022-11-28 18:06:44 -08:00
Alden Wu	0cb7c94c21	Merge branch 'master' of https://github.com/ppy/osu into chat-profile-highlight-v2	2022-11-28 17:59:15 -08:00
Alden Wu	c2d8ffc225	Refactor ChatLine username drawable creation	2022-11-28 17:50:12 -08:00
Andrei Zavatski	3e277a92e9	Fix incorrect texel size calculation	2022-11-29 03:21:59 +03:00
Andrei Zavatski	ba1717c2ca	Don't draw 0 thickness triangles	2022-11-29 02:36:27 +03:00
Derrick Timmermans	93ba84e5ff	Fix code style	2022-11-27 21:48:44 +01:00
Derrick Timmermans	70c320b2e8	Provide ruleset dependencies only to Compose Placement Blueprints	2022-11-27 21:43:33 +01:00
Derrick Timmermans	cff3e06ad6	Update state based on result during LoadComplete	2022-11-27 20:57:00 +01:00
mk56-spn	db7f429e39	Fix partial class issues and adjust test slightly	2022-11-27 10:44:05 +01:00
mk56-spn	0aba119056	Merge remote-tracking branch 'origin/RangeSlider_implementation' into RangeSlider_implementation ... # Conflicts: # osu.Game.Tests/Visual/SongSelect/TestSceneDifficultyRangeFilterControl.cs # osu.Game/Screens/Select/DifficultyRangeFilterControl.cs	2022-11-27 10:40:29 +01:00
Jai Sharma	218c04c174	Code quality	2022-11-27 03:23:08 +00:00
Jai Sharma	6000e14668	Correctly select issue row	2022-11-27 03:08:54 +00:00
Jai Sharma	3c56b9c93a	Add OnRowSelected event to EditorTable	2022-11-27 02:47:54 +00:00
Jai Sharma	792334a190	Move Control Group timing data into it's own component	2022-11-27 02:47:02 +00:00
Jai Sharma	b6d7bec240	Remove #nullable disabled from EditorTable and it's derived classes	2022-11-27 02:45:56 +00:00
Jai Sharma	1a914d0df7	Remove #nullable disable from TimingScreen	2022-11-27 02:43:22 +00:00
cdwcgt	e16f8a4410	Merge branch 'master' into NowPlaying	2022-11-27 08:48:49 +08:00
cdwcgt	02e3ebe1a0	DifficultyIncrease use + and other all - ... mod.Name to mod.Acronym	2022-11-27 09:44:09 +09:00
cdwcgt	653875bbb4	only post mod when ingame	2022-11-27 09:41:41 +09:00
cdwcgt	8ecb4aa30b	better method name	2022-11-27 09:41:08 +09:00
Bartłomiej Dach	fd16e5992b	Merge branch 'master' into triangles-fix	2022-11-26 19:28:55 +01:00
Dean Herbert	d1eedd081c	Update resources	2022-11-27 02:46:11 +09:00
Andrei Zavatski	7ab5136e12	Compute texel size in the DrawNode	2022-11-26 20:05:34 +03:00
Bartłomiej Dach	c42720acd4	Temporarily disable "partial class with one part" inspection	2022-11-26 18:05:08 +01:00
Bartłomiej Dach	212d78865a	Add a few more missing partial specs	2022-11-26 16:30:52 +01:00
Bartłomiej Dach	894ef15e79	Merge branch 'master' into update-framework	2022-11-26 16:19:36 +01:00
Dan Balasescu	7bc8908ca9	Partial everything	2022-11-27 00:00:27 +09:00
Dean Herbert	a1c559ae05	Update framework	2022-11-27 00:00:12 +09:00
mk56-spn	92ed2ed4ef	Refactor star "DifficultyRangeFilterControl" into generic range slider class	2022-11-26 12:19:08 +01:00
Bartłomiej Dach	ca0597b38e	Merge branch 'master' into dont-change-ruleset-convert	2022-11-25 19:23:36 +01:00
Bartłomiej Dach	73176a1315	Merge branch 'master' into triangle-button-v2	2022-11-25 18:35:59 +01:00
Bartłomiej Dach	bbbc1d0428	Darken colour of playlists create button ... To match d0c4637683.	2022-11-25 18:23:28 +01:00
cdwcgt	13f86f3e53	Merge branch 'master' into NowPlaying	2022-11-25 23:22:52 +09:00
cdwcgt	a2ea7a3f58	show selected mod and use ILocalisedBindableString in np	2022-11-25 23:20:44 +09:00
Dean Herbert	5ada9efa60	Update outdated comment regarding colour choices	2022-11-25 22:10:20 +09:00
Dean Herbert	76e9382e0b	Fix triangles showing on ExpandableButtons when in contracted state	2022-11-25 20:18:35 +09:00
Dean Herbert	d0c4637683	Lighten colour of multiplayer create game button	2022-11-25 20:18:21 +09:00
Dean Herbert	b0f14d4963	Clamp AimCount to ensure at least one triangle is spawned	2022-11-25 20:14:21 +09:00
Dean Herbert	4cb068ceb9	Change AimCount to not consider height	2022-11-25 20:10:04 +09:00
Dean Herbert	25410c9962	Avoid changing ruleset when presenting a beatmap if it can be converted ... Closes #21415.	2022-11-25 19:48:01 +09:00
Derrick Timmermans	65e5c9a3ae	Dispose DrawableRulesetDependencies in HitObjectComposer	2022-11-25 08:27:22 +01:00
Bartłomiej Dach	fca3e7e39f	Merge branch 'master' into editor-seek-control-points	2022-11-24 21:53:47 +01:00
Dean Herbert	f6e229c24d	"Fix" mod copy failure	2022-11-25 01:15:11 +09:00
Dean Herbert	2b2beadd06	Merge branch 'master' into update-framework	2022-11-25 01:00:08 +09:00
Derrick Timmermans	7b620392fe	Provide DrawableRulesetDependencies from HitObjectComposer	2022-11-24 13:13:45 +01:00
Dean Herbert	6ad432b311	Use RoundedButton in more places	2022-11-24 16:33:01 +09:00
Dean Herbert	53b03df93d	Combine TriangleButton and RoundedButton classes	2022-11-24 16:26:57 +09:00
Dean Herbert	bea2acc60e	Remove local specifications of triangle colouring	2022-11-24 16:18:15 +09:00
Dean Herbert	4fbca4037c	Update existing triangle buttons to use RoundedButton	2022-11-24 16:18:15 +09:00
Dean Herbert	40f706155f	Update RoundedButton to have new triangles design	2022-11-24 16:18:15 +09:00
Dean Herbert	44a71741e4	Merge pull request #21225 from EVAST9919/triangles-v2 ... Implement TrianglesV2 component	2022-11-24 16:15:25 +09:00
Dean Herbert	8914a871c1	Merge pull request #21065 from C0D3-M4513R/beatmap-info ... Add Beatmap Information elements	2022-11-24 15:22:04 +09:00
Dean Herbert	2e277ef40a	Update resources	2022-11-24 15:18:49 +09:00
Dean Herbert	a2438428a2	Move base call to end	2022-11-24 13:57:43 +09:00
Dean Herbert	37f725bfa2	Reverse directionality of up/down traversal keys to match scroll	2022-11-24 13:55:58 +09:00
C0D3 M4513R	4b44f31b5e	Use LocaliseableStings in BeatmapAttributeText	2022-11-23 21:02:43 +01:00
Bartłomiej Dach	2f67199b1c	Merge branch 'master' into fix-missing-day-separator	2022-11-23 18:40:44 +01:00
Bartłomiej Dach	60422be9af	Merge branch 'master' into fix-editor-tap-timing-crash	2022-11-23 17:51:50 +01:00
Dean Herbert	b381b4fd2d	Merge branch 'master' into update-framework	2022-11-24 01:27:58 +09:00
Dean Herbert	3acf15c7b8	Update framework	2022-11-24 01:26:49 +09:00
Bartłomiej Dach	30f9cc46a7	Protect offset and bpm adjustments from null selection too	2022-11-23 17:25:43 +01:00
Bartłomiej Dach	508f1f488c	Merge branch 'master' into limit-barline-generation-sanity	2022-11-23 17:12:36 +01:00
Dean Herbert	5467097387	Fix adjacent day separators potentially being left behind after pending message resolution	2022-11-23 18:49:51 +09:00
Dean Herbert	f9d952220f	Fix barlines being misaligned if generation start time is clamped	2022-11-23 18:12:03 +09:00
Dean Herbert	774f70e380	Simplify class structure	2022-11-23 16:56:40 +09:00
Dean Herbert	0749a7bb07	Simplify attribute assignment	2022-11-23 16:53:36 +09:00
Dean Herbert	0f034606fd	Use LocalisableDescription from BeatmapOnlineStatus enum instead of locally defined	2022-11-23 16:49:51 +09:00
Dean Herbert	a8af83e62a	Move label initialisation out of ctor	2022-11-23 16:49:39 +09:00
Dean Herbert	27473262af	Rename attributes in enum to match better with user expectations	2022-11-23 16:45:46 +09:00
Dean Herbert	b89689a34a	Rename class and reword settings text/tooltips to avoid clashing with other naming	2022-11-23 16:31:50 +09:00
Dean Herbert	a9192c32ea	Merge branch 'master' into beatmap-info	2022-11-23 16:10:12 +09:00
Dean Herbert	9b9b8a5977	Add ability to seek between control points in editor using down/up arrows ... Matches stable. Addresses #21376.	2022-11-23 15:59:32 +09:00
Dean Herbert	d146f86511	Fix crash when hitting 'T' to tap timing while no timing point is selected	2022-11-23 15:39:56 +09:00
Dean Herbert	172e798847	Merge pull request #21228 from Terochi/recent-messages-implementation ... Add ability to view chat send history in input box	2022-11-23 14:58:42 +09:00
Bartłomiej Dach	8dbc38e17a	Remove unused setter	2022-11-22 20:14:22 +01:00
Bartłomiej Dach	76bb529cfa	Add test for local echo adding day separator	2022-11-22 16:46:21 +01:00
Dean Herbert	de163b2bb5	Change song select to only allow volume adjusting if alt is held while scrolling	2022-11-22 19:48:55 +09:00
Alden Wu	a2b505f4c0	Use a direct Lighten instead of >1f Color4 values	2022-11-22 00:31:22 -08:00
Dean Herbert	1632df1f4d	Update DifficultyBindable to match new bindable spec	2022-11-22 14:51:19 +09:00
Dan Balasescu	985781bc3b	Merge pull request #21356 from peppy/standardise-broken-storyboard-paths ... Add support for storyboards with incorrect path specifications (`\\` instead of `\`)	2022-11-22 14:33:51 +09:00
Alden Wu	4084a2b066	Highlight ChatLine username on hover	2022-11-21 18:57:59 -08:00
Bartłomiej Dach	8dbe31a172	Merge branch 'master' into higher-aspect-ratio-max	2022-11-21 19:51:39 +01:00
Bartłomiej Dach	c0f65d83b3	Merge branch 'master' into hide-no-spin-bonus	2022-11-21 19:14:54 +01:00
Bartłomiej Dach	206aece77b	Merge branch 'master' into avoid-null-audio-device-name-crahs	2022-11-21 16:37:13 +01:00
Bartłomiej Dach	7944d9cefa	Merge pull request #21304 from EVAST9919/beatmap-bar ... Rework BarGraph to use Quads	2022-11-21 16:24:18 +01:00
Terochi	d81ef541bc	Variant 5: cannot change history, edit resets index	2022-11-21 10:17:28 +01:00
Terochi	7dc7729ac2	Variant 4: cannot change history, empty text/everything selected resets index (current with bug fix)	2022-11-21 10:11:26 +01:00
C0D3 M4513R	93ab1c9432	Merge branch 'master' into beatmap-info	2022-11-21 09:01:24 +00:00
Terochi	58288275a6	Variant 3: cannot change history, cannot reset index (the "default")	2022-11-21 09:43:36 +01:00
Terochi	672e1cd45b	Variant 2: edit changes history, cannot reset index (similar to stable)	2022-11-21 09:41:29 +01:00
Terochi	8f942f130b	Variant 1: edit changes history, empty text resets index	2022-11-21 09:36:31 +01:00
Andrei Zavatski	ec8532951c	Make Thickness property auto	2022-11-21 10:32:19 +03:00
Dean Herbert	2774c1ea49	Merge pull request #21215 from jai-x/triangles-bundled-beatmap ... Add winner of Triangles mapping competition as a bundled beatmap	2022-11-21 16:22:23 +09:00
Andrei Zavatski	14a4de36f4	Expose thickness property	2022-11-21 10:20:35 +03:00
Dean Herbert	3da21e596a	Add support for storyboards with incorrect path specifications (\\ instead of \) ... Closes https://github.com/ppy/osu/issues/21204.	2022-11-21 16:12:01 +09:00
Dean Herbert	462a213ffc	Add TODO note about handling initial silences	2022-11-21 15:23:04 +09:00
Dean Herbert	efd73ea9da	Rename method to suit better	2022-11-21 15:22:57 +09:00
Dean Herbert	5c640d15a0	Stop requesting messages as part of initial chat presence	2022-11-21 15:17:54 +09:00
Dean Herbert	9a330c3cdb	Apply nullability and clean up conditionals	2022-11-21 15:02:45 +09:00
Dean Herbert	a07b033d22	Merge branch 'master' into triangles-v2	2022-11-21 14:55:01 +09:00
Dean Herbert	981264b011	Avoid crashing when a system audio device provides a null name	2022-11-21 14:51:41 +09:00
Dean Herbert	40f2da364c	Limit how far before the first hitobject that barlines can be generated	2022-11-21 14:40:25 +09:00
Dean Herbert	93a189603a	Hide spinner ticks / bonus from results screen when not applicable to score	2022-11-21 14:20:36 +09:00
Dean Herbert	4a79141824	Merge pull request #21338 from RATCM/fix-leaderboard-filter ... Match leaderboard filter behaviour to web	2022-11-21 14:01:55 +09:00
Dean Herbert	e53b4321ff	Ensure two day separators are not added in a row	2022-11-21 14:01:10 +09:00
Dean Herbert	fa7b45dfb1	Fix chat day separator not being added on pending message resolution ... Closes #21316.	2022-11-21 13:52:14 +09:00
Dean Herbert	dfa92b3de9	Merge pull request #21326 from bdach/fix-phantom-beatmap-sets ... Fix phantom beatmap sets appearing on carousel after delete/update	2022-11-21 13:25:14 +09:00
Dean Herbert	c7ae837687	Increase maximum aspect ratio for tablet settings to 23:9 / 2.55	2022-11-21 12:45:54 +09:00
Dean Herbert	92aea22cd3	Merge pull request #21340 from vegguid/MetadataLanguage-FirstSetup ... Added PreferOriginalMetadataLanguage to FirstRunSetup	2022-11-21 12:16:56 +09:00
vegguid	a431b793b9	Added PreferOriginalMetadataLanguage to FirstRunSetup	2022-11-20 23:18:19 +01:00
Andrei Zavatski	18c79dfda3	Move all the logic into BarsInfo class	2022-11-20 23:00:13 +03:00
RATCM	f5fbb7c8de	Changed comments	2022-11-20 19:27:40 +01:00
RATCM	d20a357c0e	Fixed ordering bug	2022-11-20 19:24:51 +01:00
RATCM	9040dfbd4e	Match leaderboard filter behaviour to web	2022-11-20 17:39:46 +01:00
Bartłomiej Dach	1269afd0c5	Merge pull request #21307 from frenzibyte/disable-scroll-speed-on-osu ... Hide scroll speed control from effects section on rulesets which don't support it	2022-11-20 16:17:55 +01:00
Bartłomiej Dach	0f382590e6	Remove unnecessary #nullable disable	2022-11-20 15:31:51 +01:00
Bartłomiej Dach	33b2fe46d9	Add xmldoc to HistoryTextBox	2022-11-20 12:29:47 +01:00
Bartłomiej Dach	7b274083d3	Fix phantom beatmap sets appearing on carousel after delete/update ... Regressed in c40c70509e. As it turns out, `item.Item.Filtered.Value` is not the only condition that should be checked to determine if a carousel item should be hidden or not - `item.Item.State.Value != CarouselItemState.Collapsed` should also be true. This was even available as the `item.Item.Visible` convenience property, which is used in this commit. Failing to check `item.Item.State.Value` led to setting non-zero alpha on collapsed carousel items, leading to phantom beatmap sets appearing, as the alpha was set in the entire carousel's `Update()` method, thus firing every frame.	2022-11-20 10:08:34 +01:00
Andrei Zavatski	36141cb2a4	Make BarsInfo a class	2022-11-20 05:14:07 +03:00
Salman Ahmed	4b0ba86bd0	Identify scrolling rulesets using temporary DrawableRuleset instances	2022-11-20 04:12:52 +03:00
Salman Ahmed	58296bd4f0	Introduce IDrawableScrollingRuleset for editor consumption	2022-11-20 04:11:10 +03:00
Andrei Zavatski	fcb52ee237	Make BarsInfo a readonly struct	2022-11-20 02:28:07 +03:00
Andrei Zavatski	fbfcf49ea6	Remove readonly modifier from struct fields	2022-11-20 02:13:54 +03:00
Andrei Zavatski	2cb966b47c	Rework BarsInfo struct	2022-11-20 01:48:54 +03:00
Andrei Zavatski	6c62cfb830	Store barBreadth as a separate float	2022-11-19 23:40:02 +03:00
Andrei Zavatski	67ee9f3915	Naming adjustments	2022-11-19 23:34:55 +03:00
Andrei Zavatski	f1201454b7	Use value tuples	2022-11-19 23:29:50 +03:00
Andrei Zavatski	6f449a583e	Handle empty values as a separate case	2022-11-19 23:27:48 +03:00
Terochi	eff6c7be64	Removed unnecessary methods, changed tests, and moved LimitedCapacityQueue.cs to a more generic namespace.	2022-11-19 16:53:35 +01:00
Bartłomiej Dach	0c671a2a82	Merge branch 'master' into fix-tablet-aspect-ratio-values	2022-11-19 14:32:24 +01:00
Bartłomiej Dach	c05c1625f2	Merge branch 'master' into editor-test-play-dont-retain-test-time	2022-11-19 12:09:04 +01:00
Salman Ahmed	60c424837b	Merge branch 'master' into disable-scroll-speed-on-osu	2022-11-19 12:13:45 +03:00
Salman Ahmed	2e3af97892	Remove unused using	2022-11-19 12:13:36 +03:00
Andrei Zavatski	0239103b6b	Fix BeatmapOverlay crashing test scene	2022-11-19 11:33:14 +03:00
Andrei Zavatski	05992d3aa8	CI fix	2022-11-19 10:23:37 +03:00
Andrei Zavatski	9b8f98735c	Use struct for bars description	2022-11-19 10:16:58 +03:00
Andrei Zavatski	7d02cbafed	Merge branch 'master' into beatmap-bar	2022-11-19 09:58:10 +03:00
Andrei Zavatski	11f5fddc1f	Remove redundant returns	2022-11-19 09:57:52 +03:00
Dean Herbert	130f776427	Merge pull request #21267 from peppy/catch-file-enumeration-errors ... Catch and gracefully handle file/directory enumeration failures during stable import	2022-11-19 15:38:40 +09:00
Salman Ahmed	290369db47	Hide scroll speed slider on rulesets which don't support it	2022-11-19 06:42:27 +03:00
Salman Ahmed	016de2f5a0	Fix editor not always playing hitsounds with clock offsets applied	2022-11-19 05:15:22 +03:00
Andrei Zavatski	e8ca9f5dc5	Rework BarGraph to use Quads	2022-11-19 00:22:57 +03:00
Salman Ahmed	1be8c6bd9c	Fix "perform from screen" not considering screen load state	2022-11-18 17:23:10 +03:00
Dawid Sośnia	9ad484a0f4	Merge branch 'ppy:master' into gameplay-leaderboard-fix	2022-11-18 12:11:22 +01:00
Dean Herbert	06ce8130c2	Apply changes in line with framework NRT updates	2022-11-18 18:13:15 +09:00
Dean Herbert	95908ec023	Update framework	2022-11-18 18:13:00 +09:00
Dan Balasescu	e4fc14faee	Merge pull request #21270 from peppy/auto-advance-bindings ... Auto-advance binding for ruleset key bindings	2022-11-18 16:19:54 +09:00
Dan Balasescu	9d33a6568e	Merge pull request #21292 from peppy/fix-binding-two-keys-single-binding ... Fix being able to bind two non-modifier keys to the same binding	2022-11-18 16:19:38 +09:00
Dan Balasescu	d8e99d811d	Merge pull request #21293 from frenzibyte/fix-timeline-extent-scrolling ... Fix timeline potentially scrolling at extents while not dragging	2022-11-18 16:19:30 +09:00
Dean Herbert	d59befc9d3	Fix initial visual state of positions before sort runs	2022-11-18 16:08:27 +09:00
Dean Herbert	aff218dfd5	Redirect through validity function rather than overriding Sort	2022-11-18 16:03:40 +09:00
Dean Herbert	20af8217f4	Tidy up bindable flow	2022-11-18 15:50:41 +09:00
Dean Herbert	e4f522aad1	Fix inspections / typos	2022-11-18 15:47:37 +09:00
Dean Herbert	d17c091d63	Move constant to a better location	2022-11-18 15:47:31 +09:00
Dean Herbert	3faa7f5f74	Merge branch 'master' into gameplay-leaderboard-fix	2022-11-18 15:44:30 +09:00
Salman Ahmed	90cd386323	Fix timeline potentially scrolling at extents while not dragging	2022-11-18 09:43:16 +03:00
Dean Herbert	bab5be8dee	Merge pull request #21290 from smoogipoo/multiplayer-test-debug ... Add some debugging for multiplayer test failures	2022-11-18 15:39:33 +09:00
Dean Herbert	e658efbefa	Fix being able to bind two non-modifier keys to the same binding	2022-11-18 15:34:41 +09:00
Dan Balasescu	c2a127dc68	Merge pull request #21289 from peppy/fix-triangle-button-flash ... Fix triangle button flash effect looking incorrect	2022-11-18 15:26:43 +09:00
Dan Balasescu	219d049edf	Merge pull request #21140 from maromalo/long-standard ... Standardise scores to `long` type	2022-11-18 15:26:33 +09:00
Dan Balasescu	cc434c9113	Merge pull request #21288 from peppy/fix-no-network-slow-gameplay-load ... Fix entering gameplay while network connection is in a bad state taking too long	2022-11-18 15:24:31 +09:00
Dan Balasescu	7e9d2ecaf5	Merge pull request #21287 from peppy/fix-null-ref-persistent-endpoint-connector ... Fix potential incorrect connection state resulting in null reference	2022-11-18 15:08:33 +09:00
Dan Balasescu	b0faa009c1	Add some debugging for multiplayer test failures	2022-11-18 14:52:11 +09:00
Dean Herbert	5fc0d45675	Fix triangle button flash effect looking incorrect	2022-11-18 14:30:59 +09:00
Dan Balasescu	57b8495c7a	Merge branch 'master' into long-standard	2022-11-18 14:24:04 +09:00
Dan Balasescu	d47c46d144	Compute raw score in-line ... Saves on an allocation (though it seems to only be a ValueType so it shouldn't be a big deal) and a tail-call.	2022-11-18 14:22:28 +09:00
Dean Herbert	964ceddf83	Fix API queue only being flushed once while in a failing state	2022-11-18 14:21:37 +09:00
Dean Herbert	e4d134a820	Reduce time waited on a score submission token from 60 to 30s	2022-11-18 14:07:40 +09:00
Dan Balasescu	1b1fed723d	Merge pull request #21269 from peppy/fix-key-bindings-keyword ... Move "keybindings" keyword to correct section	2022-11-18 14:05:08 +09:00
Dan Balasescu	551192b413	Refactor a bit for readability	2022-11-18 13:55:37 +09:00
Dean Herbert	a5d22195f2	Fix potential incorrect connection state resulting in null reference	2022-11-18 13:45:46 +09:00
Dean Herbert	1ff1738988	Merge pull request #21244 from nanashi-1/beatmapoptions-disabled ... Disable certain beatmap option buttons when there are no beatmaps selected	2022-11-18 12:55:07 +09:00
Dan Balasescu	a776622ce0	Merge pull request #21284 from peppy/now-playing-overlay-texture-reduction ... Fix `NowPlayingOverlay` loading background texture too early (and permanently)	2022-11-18 12:09:16 +09:00
Dan Balasescu	c34dd27674	Merge pull request #21276 from peppy/eager-triangles-disposal ... Eagerly dispose of triangles intro textures to avoid holding for full length of game session	2022-11-18 11:58:39 +09:00
Dan Balasescu	baa4fd56e2	Merge pull request #21279 from peppy/news-load-unload ... Fix news post images never unloading from memory after first display	2022-11-18 11:56:13 +09:00
Dan Balasescu	13fe0d3491	Merge pull request #21278 from peppy/overlay-header-texture-reduction ... Avoid loading overlay headers until first open	2022-11-18 11:53:46 +09:00
Dean Herbert	b53f9baf6a	Fix NowPlayingOverlay loading background texture too early (and permanently)	2022-11-18 11:21:12 +09:00
Dean Herbert	93c2280754	Fix supporter filters text not being set correctly	2022-11-18 10:35:05 +09:00
Dawid Sośnia	0dbf491872	Merge branch 'master' into gameplay-leaderboard-fix	2022-11-17 22:06:51 +01:00
Piggey	eb691266c1	cleanup	2022-11-17 21:50:39 +01:00
Dean Herbert	b37e9c0266	Fix news post images never unloading from memory after first display	2022-11-18 00:01:53 +09:00
Dean Herbert	73e4827d36	Avoid loading overlay headers until first open ... Also switches them to use non-atlased target as they won't benefit much from atlasing.	2022-11-17 23:55:43 +09:00
Dean Herbert	63c1855511	Avoid loading beatmap listing placeholders until required	2022-11-17 23:42:21 +09:00
Dean Herbert	a3e8cc1663	Mark beatmap listing placeholder textures as large	2022-11-17 23:41:35 +09:00
Dean Herbert	20d87fbed4	Eagerly dispose of triangles intro textures to avoid holding for full length of game session	2022-11-17 23:05:34 +09:00
Piggey	fa00fc5c6d	change scoresType to be a bindable	2022-11-17 13:27:56 +01:00
Dragon	a25c94d567	Replacing structure to use LimitedCapacityQueue.cs	2022-11-17 13:07:06 +01:00
Dragon	a9747d367c	Cleaning up	2022-11-17 13:07:06 +01:00
Terochi	0100c01b82	Implemented finite limit of stored history.	2022-11-17 13:07:06 +01:00
Terochi	5253f5309e	Added more tests for new features	2022-11-17 13:07:06 +01:00
Terochi	44c3e71746	Reversed indexing	2022-11-17 13:07:06 +01:00
Terochi	3d4962e181	Added functioning tests.	2022-11-17 13:07:06 +01:00
Terochi	6d83af01e2	Moved and renamed MessageHistoryTextBox.cs for better fit.	2022-11-17 13:07:06 +01:00
Dragon	b9590320b7	Moved implementation to ChatRecentTextBox.cs and derived ChatTextBox.cs and StandAloneChatDisplay.cs from it.	2022-11-17 13:07:06 +01:00
Dragon	a1af663682	Implemented previous messages lookup in the ChatTextBox.cs	2022-11-17 13:07:06 +01:00
Piggey	dea2a6ed8d	override sort() function in SoloGameplayLeaderboard	2022-11-17 12:12:36 +01:00
nanashi-1	4773979e52	add condition	2022-11-17 16:15:34 +08:00
Dean Herbert	d1b2116400	Auto-advance binding for ruleset key bindings	2022-11-17 15:23:20 +09:00
Dean Herbert	bd2e0dc82b	Move "keybindings" keyword to correct section ... Without this, things like tablet settings would show when searching for bindings, even though these settings have nothing to do with key bindings.	2022-11-17 15:09:42 +09:00
Dan Balasescu	5ceb7ecc41	Remove unused using	2022-11-17 13:56:27 +09:00
Dean Herbert	1050d7da34	Use more generic exception type (issue reported AggegateException)	2022-11-17 13:36:16 +09:00
Dean Herbert	adab9f0e48	Catch and gracefully handle file/directory enumeration failures during stable import ... Closes https://github.com/ppy/osu/issues/21214.	2022-11-17 13:34:42 +09:00
Dean Herbert	a4e713a61f	When returning to the editor after test play, use the original editor time rather than the point of exit	2022-11-17 12:36:24 +09:00
Dean Herbert	bfcd9e0f45	Don't seek to current editor location when location is close to (or before) the first object	2022-11-17 12:32:35 +09:00
Dan Balasescu	bdfc317a8e	Merge pull request #21255 from peppy/fix-full-area-reset ... Fix "reset to full area" button not always working correctly	2022-11-17 11:13:06 +09:00
Dan Balasescu	b23b5ebce9	Merge pull request #21257 from peppy/fix-test-mode ... Fix combo colour normalisation setting not applying to editor test play	2022-11-17 10:44:44 +09:00
Salman Ahmed	87b4fee10f	Remove leftover constant	2022-11-17 04:05:21 +03:00
Salman Ahmed	55beaf5d93	Revert buttons order change	2022-11-17 04:05:15 +03:00
Salman Ahmed	039ab83a46	Disable beatmap options button when none selected	2022-11-17 04:00:23 +03:00
Salman Ahmed	0e46614c57	Revert beatmap option button state changes	2022-11-17 03:57:01 +03:00
Salman Ahmed	c1673771eb	Merge branch 'master' into fix-full-area-reset	2022-11-17 01:57:56 +03:00
Salman Ahmed	7a28a7f2a0	Move IGameplaySettings override to compose screen to keep test mode unaffected	2022-11-17 01:45:16 +03:00
Andrei Zavatski	13cf3fc40c	Make SpawnRatio public	2022-11-16 15:17:50 +03:00
Andrei Zavatski	cc4f05f3d3	Replace Scale with SpeedMultiplier	2022-11-16 15:12:57 +03:00
Andrei Zavatski	109aa37dd8	Apply fixes from original Triangles	2022-11-16 15:02:09 +03:00
Andrei Zavatski	d94c624ee4	Merge branch 'master' into triangles-v2	2022-11-16 14:53:32 +03:00
Dean Herbert	ee6fffec5f	Fix combo colour normalisation setting not applying to editor test play	2022-11-16 17:54:49 +09:00
Dean Herbert	bb762d8131	Fix "reset to full area" button not always working correctly	2022-11-16 15:45:26 +09:00
nanashi-1	5d8d8ffce5	fix naming	2022-11-16 10:09:51 +08:00
nanashi-1	55edd6c907	add space	2022-11-16 09:58:49 +08:00
nanashi-1	1fb8357e93	change disabledAlpha from readonly to const	2022-11-16 09:58:32 +08:00
nanashi-1	9101ad0cbd	fixed naming	2022-11-16 09:42:40 +08:00
Dean Herbert	52ecd894db	Move equilateral triangle ratio to constant	2022-11-15 22:20:08 +09:00
nanashi-1	5973bb1956	AddButton now returns the button	2022-11-15 20:57:31 +08:00
nanashi-1	1186ed3e32	add disable	2022-11-15 20:56:18 +08:00
nanashi-1	e8d170e772	disable certain options when no beatmap is selected	2022-11-15 20:55:55 +08:00
Andrei Zavatski	f27a5f977d	Improve triangles distribution	2022-11-15 11:49:53 +03:00
Andrei Zavatski	c7dc6db124	Fix incorrect number of added triangles	2022-11-15 11:32:05 +03:00
Andrei Zavatski	ebff844334	Reset triangles on scale change	2022-11-15 11:06:28 +03:00
Dean Herbert	489dca79a1	Remove upper limit for pooling	2022-11-15 12:31:25 +09:00
Dean Herbert	308ed1abd1	Fix number of judgements shown potentially exceeding upper limit	2022-11-15 12:31:25 +09:00
Dean Herbert	59a8603728	Ensure flowing animation starts correctly from zero	2022-11-15 12:04:40 +09:00
Dean Herbert	aef6ee23eb	Apply pooling support to ColourHitErrorMeter	2022-11-15 12:04:40 +09:00
Dean Herbert	a86b50d62a	Apply nullability to BarHitErrorMeter	2022-11-15 11:33:27 +09:00
Dean Herbert	576f462f59	Add pooling support to BarHitErrorMeter	2022-11-15 11:33:27 +09:00
Dan Balasescu	e43593a164	Merge pull request #21227 from Susko3/fix-FallbackSampleStore-async-fallback-logic ... Fix `FallbackSampleStore.GetAsync` fallback logic	2022-11-14 10:17:42 +09:00
Susko3	56fd1f95b1	Fix FallbackSampleStore.GetAsync fallback logic	2022-11-13 18:47:28 +01:00
Joseph Madamba	4578a96813	Fix beatmap card expanded content not blocking clicks from behind	2022-11-13 08:18:44 -08:00
Andrei Zavatski	81c9ea98e2	Implement TrianglesV2 component	2022-11-13 15:31:48 +03:00
Dean Herbert	efe42f701a	Merge branch 'master' into only-rounded-shader	2022-11-13 16:34:48 +09:00
Dean Herbert	236cc0bdaf	Update resources	2022-11-13 16:21:28 +09:00
Dean Herbert	887b6832c9	Update framework	2022-11-13 16:15:30 +09:00
Dean Herbert	eae8530722	Fix SkinnableSprite lookups broken in lazer-first skins ... Regressed with removal of local `GetTexture` calls in e19ba65f91	2022-11-13 12:46:21 +09:00
Jai Sharma	c5cb4e4e7d	Add winner of Triangles mapping competition as a bundled beatmap ... https://osu.ppy.sh/home/news/2022-10-06-results-triangles	2022-11-12 17:48:40 +00:00
Dean Herbert	f343ba6111	Add xmldoc for chat ack request	2022-11-13 00:10:06 +09:00
Dean Herbert	22d8a1160e	Fix last silence ID being updated too often, causing most silences to be missed	2022-11-13 00:10:06 +09:00
Dean Herbert	143c946128	Simplify ack re-perform flow	2022-11-12 23:02:37 +09:00
Dean Herbert	bfb939cbd0	Expand on why call needs to be made every 10 minutes	2022-11-12 22:24:27 +09:00
Dean Herbert	6a3665a6fd	Remove excess logging on WebSocketNotificaitonsClient	2022-11-12 22:09:27 +09:00
maromalo	1911120afe	Merge branch 'master' into long-standard	2022-11-12 09:52:11 -03:00
Dean Herbert	ace4099079	Update ack code after incorrect merge	2022-11-12 21:41:10 +09:00
Thomas Müller-Höhne	9ef43ebd83	Fix compilation after framework-side PR updates	2022-11-12 21:24:12 +09:00
Dean Herbert	dde09d409b	Merge branch 'master' into chat-silences	2022-11-12 21:00:56 +09:00
Thomas Müller-Höhne	fa8e38d9d6	Target rounded fragment shader ... Compatibility with osu-framework change https://github.com/ppy/osu-framework/pull/5512	2022-11-12 17:18:23 +09:00
Samaoo	4ff17cb4bd	remove unused using directive	2022-11-12 08:52:33 +01:00
Samaoo	7a860fb460	address reviews	2022-11-12 08:49:03 +01:00
Samaoo	268011be9e	use MathF	2022-11-11 17:56:50 +01:00
Samaoo	173f557376	fix tablet aspect ratio values	2022-11-11 17:14:34 +01:00
Dean Herbert	19876ca0fb	Merge branch 'master' into websocket-chat-2	2022-11-11 23:53:42 +09:00
Dean Herbert	151dd7c62f	Fix one more reverted change	2022-11-11 22:21:38 +09:00
Dean Herbert	0af4bdaf5c	Add back removed configuration elements	2022-11-11 18:29:15 +09:00
Dean Herbert	106f1cf90b	Merge branch 'master' into combo-colour-brightness-limit	2022-11-11 18:24:39 +09:00
Dean Herbert	392d4e778e	Change default beatmap listing key binding to Ctrl+B	2022-11-11 17:10:46 +09:00