42526 Commits

Author	SHA1	Message	Date
Bartłomiej Dach	51568ba06a	Add background to disclaimers	2024-03-15 11:31:45 +01:00
Bartłomiej Dach	5513a72748	Improve hiding transition when multiple disclaimers are visible	2024-03-15 11:01:34 +01:00
Bartłomiej Dach	49a087f7fc	Add localisation support	2024-03-15 10:59:49 +01:00
Bartłomiej Dach	4688a53cf4	Stay on player loader a bit longer if disclaimers are present ... Just to make reading the text easier.	2024-03-15 09:53:20 +01:00
Bartłomiej Dach	f3a444b7ac	Add disclaimer for loved/qualified status	2024-03-15 09:53:20 +01:00
Bartłomiej Dach	42ae18976f	Replace existing epilepsy warning with inline display	2024-03-15 09:53:20 +01:00
Bartłomiej Dach	1aa695add9	Implement alternate design of player loader disclaimers	2024-03-15 09:53:18 +01:00
Dean Herbert	23975d4dd1	Add flash and reduce overall time for countdown to 2 seconds	2024-03-14 22:49:53 +08:00
Dean Herbert	2845303a74	Fix non-matching scale outwards animation	2024-03-14 22:45:05 +08:00
Dean Herbert	888245b44f	Reorder methods	2024-03-14 22:44:26 +08:00
Dean Herbert	d7769ec3e2	Adjust animation	2024-03-14 22:44:23 +08:00
Dean Herbert	42bd558d7c	Only update text when necessary (reducing unnecessary string allocadtions)	2024-03-14 22:43:08 +08:00
Joseph Madamba	f8a841e907	Add comment explaining why width is limited to the button area ... Same comment as a47ccb8edd/osu.Game/Screens/Select/BeatmapInfoWedgeV2.cs (L91-L92).	2024-03-14 00:17:22 -07:00
Salman Ahmed	b4cee12db9	Use defined colours for counter background	2024-03-14 09:22:03 +03:00
Joseph Madamba	b309aad895	Fix noticeable masking artifact of beatmap cards when already downloaded ... Had a similar fix before seeing https://github.com/ppy/osu/pull/20743#discussion_r994955470, but using that diff instead so co-authoring. Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2024-03-13 22:36:52 -07:00
Dan Balasescu	b431bb1176	Resolve post-merge issues	2024-03-14 12:24:12 +09:00
Dan Balasescu	0beaa8e8c5	Merge branch 'master' into tcm-resume	2024-03-14 12:22:46 +09:00
Dan Balasescu	789a9f4dfa	Initial redesign following flyte's design	2024-03-14 11:38:16 +09:00
Dean Herbert	a47ccb8edd	Merge pull request #27600 from bdach/dont-die-on-audio-in-video-check ... Fix audio in video check crashing on unexpected failures	2024-03-14 10:28:45 +08:00
Bartłomiej Dach	d32f19b546	Fix first word bold not applying correctly after first language change ... Closes https://github.com/ppy/osu/issues/27549. I'm not entirely sure why the old solution failed exactly, but also think it's unimportant because I think past me was an idiot and was playing stupid games with the juggling of indices between two callbacks with no ordering guarantees and expecting not to win stupid prizes. I'm not sure this requires any follow-up reconsiderations of that entire text flow API, but if opinions differ, I'll re-examine.	2024-03-13 15:18:20 +01:00
Bartłomiej Dach	20c760835a	Fix audio in video check crashing on unexpected failures	2024-03-13 13:55:49 +01:00
Joseph Madamba	e2e99fc5cc	Rearrange rankings overlay tabs to match web	2024-03-12 21:15:59 -07:00
Dean Herbert	a4a433b92a	Remember login by default ... Kinda what is expected from a user's perspective	2024-03-12 20:14:50 +08:00
Dean Herbert	5b2dd95fd6	Merge pull request #27586 from bdach/ignore-directory-zip-entries ... Fix exports containing zero byte files after import from specific ZIP archives	2024-03-12 17:18:39 +08:00
Bartłomiej Dach	83e47b3c4c	Fix exports containing zero byte files after import from specific ZIP archives ... Closes https://github.com/ppy/osu/issues/27540. As it turns out, some ZIP archivers (like 7zip) will decide to add fake entries for directories, and some (like windows zipfolders) won't. The "directory" entries aren't really properly supported using any actual data or attributes, they're detected by sharpcompress basically by heuristics: ab5535eba3/src/SharpCompress/Common/Zip/Headers/ZipFileEntry.cs (L19-L31) When importing into realm we have thus far presumed that these directory entries will not be a thing. Having them be a thing breaks multiple things, like: - When importing from ZIPs with separate directory entries, a separate `RealmFile` is created for a directory entry even though it doesn't represent a real file - As a result, when re-exporting a model with files imported from such an archive, a zero-byte file would be created because to the database it looks like it was originally a zero-byte file. If you want to have fun, google "zip empty directories". You'll see a whole gamut of languages, libraries, and developers stepping on this rake. Yet another episode of underspecced mistakes from decades ago that were somebody's "good idea" but continue to wreak havoc forevermore because now there are two competing conventions you can't just pick one.	2024-03-12 09:06:24 +01:00
Dean Herbert	83052fe1d9	Downgrade realm to work around crashes on latest release ... See https://github.com/ppy/osu/issues/27577.	2024-03-12 15:41:50 +08:00
Bartłomiej Dach	f30dfcb728	Fix ruleset medals not displaying due to deserialisation failure ... 🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦 Reported in https://discord.com/channels/188630481301012481/188630652340404224/1216812697589518386.	2024-03-11 21:34:10 +01:00
Bartłomiej Dach	9bc55be515	Merge pull request #27564 from EVAST9919/editor-blueprint-gradient ... Fix incorrect gradient application in `TimelineHitObjectBlueprint`	2024-03-11 16:02:05 +01:00
Bartłomiej Dach	09179f99c0	Merge branch 'master' into wrap-beatmap-listing-filters	2024-03-11 14:59:48 +01:00
Bartłomiej Dach	e5e7c8f268	Wrap beatmap listing filter names too ... While we're here fixing... Addresses https://github.com/ppy/osu/discussions/15452#discussioncomment-2734237.	2024-03-11 14:58:28 +01:00
Andrei Zavatski	6ecef33fd7	Fic incorrect ExtendableCircle gradient	2024-03-10 22:45:29 +03:00
Andrei Zavatski	549a8d678e	Reduce allocations in ControlPointList	2024-03-09 20:50:54 +03:00
Dean Herbert	31739be499	Update resources	2024-03-09 20:48:57 +08:00
Dean Herbert	b8a362fcb6	Simplify assignment by using an auto property	2024-03-09 20:17:27 +08:00
Andrei Zavatski	58b6acde10	Further simplify tooltip text creation	2024-03-09 14:10:32 +03:00
Andrei Zavatski	dd36942508	Reduce allocations in DrawableFlag tooltip	2024-03-09 13:58:05 +03:00
Andrei Zavatski	26c97ef733	Fix WikiPanelContainer causing poor performance	2024-03-09 00:51:33 +03:00
Joseph Madamba	db1c59475b	Wrap beatmap listing filters and match web spacing	2024-03-08 12:13:54 -08:00
Salman Ahmed	9f71eac1db	Remove extra end line	2024-03-08 23:09:50 +03:00
Salman Ahmed	8c92bb0595	Remove unused using directive	2024-03-08 23:09:16 +03:00
Salman Ahmed	1942d46a38	Remove leftover debugging code	2024-03-08 22:37:27 +03:00
Salman Ahmed	6861d9a302	Expose storyboard command lists as read-only and remove unnecessary memory footprint ... Mutation should be done only with the methods exposed by `StoryboardCommandGroup`.	2024-03-08 22:29:49 +03:00
Salman Ahmed	0efa12a86a	Fix parameter commands applying initial value before start time	2024-03-08 21:56:25 +03:00
Salman Ahmed	c1649b76d6	Reorder command properties to match general format ... I had them shuffled around in the middle of the refactor.	2024-03-08 21:33:53 +03:00
Dean Herbert	612bc66e86	Merge pull request #27535 from nekodex/argon-hitsounds ... Add support for argon hitsounds	2024-03-09 01:47:35 +08:00
Salman Ahmed	a85be2a46d	Fix merge conflicts	2024-03-08 20:22:26 +03:00
Salman Ahmed	8d3e502262	Merge branch 'master' into storyboard-loops-v2	2024-03-08 20:22:19 +03:00
Jamie Taylor	27d78fdb08	Add fallback to find spinner samples without a bank prefix	2024-03-09 01:10:28 +09:00
Jamie Taylor	ad842b60f5	Add support for Argon hitsounds	2024-03-08 21:43:18 +09:00
Bartłomiej Dach	44d0dc6113	Fix 1px flashlight gaps when gameplay scaling mode is active ... Closes https://github.com/ppy/osu/issues/27522. Concerns mostly taiko and catch. Not much of a proper fix rather than a workaround but it is what it is. I tried a few other things, including setting `MaskingSmoothness = 0` on the scaling container itself, to no avail.	2024-03-08 11:07:30 +01:00
Dean Herbert	c9b4c684e5	Merge pull request #27403 from Gabixel/increase-modselect-initial-scroll ... Change initial scroll effect to mod columns	2024-03-08 14:00:40 +08:00
Dean Herbert	5e7d9ea04a	Adjust scroll speed back to original	2024-03-08 13:59:04 +08:00
Dean Herbert	d9cc619693	Merge branch 'master' into argon-pp-counter	2024-03-08 10:32:16 +08:00
Dean Herbert	9286398633	Move naming migrations to more correct place	2024-03-08 10:26:08 +08:00
Dean Herbert	0ebb12f67f	Move skinnable interface specification to non-abstract classes	2024-03-08 10:23:46 +08:00
Dean Herbert	ae2ef8ee1e	Fix typo in wireframe description	2024-03-08 10:19:00 +08:00
Dean Herbert	f2753ef7a2	Decrease size of pp display relative to accuracy	2024-03-08 09:41:38 +08:00
Dean Herbert	87b4406bdc	Pad at minimum three digits for argon pp display	2024-03-08 09:41:28 +08:00
Salman Ahmed	79da6d8613	Fix refactor error on EndTimeForDisplay ... Not sure when this happened >.>	2024-03-08 03:08:03 +03:00
Salman Ahmed	fa9b2f0cd5	Add generics to ApplyInitialValue/ApplyTransforms for ability to return custom transform sequences ... *sigh*	2024-03-08 03:07:39 +03:00
Salman Ahmed	b450abb687	Support applying initial values of storyboard commands	2024-03-08 02:02:48 +03:00
Salman Ahmed	2ca36254f4	Fix comparison interface not implemented on storyboard command classes	2024-03-08 02:02:25 +03:00
Salman Ahmed	3755dd059a	Calculate loop delays at point of transform application	2024-03-08 02:01:02 +03:00
Salman Ahmed	87b065b8c3	Fix incorrect start time calculations ... `LoopStartTime` is now baked into each `IStoryboardCommand`.	2024-03-08 02:01:02 +03:00
Salman Ahmed	6c257e5159	Fix HasCommands property not set at all	2024-03-08 01:59:44 +03:00
Salman Ahmed	9b77d8c972	Fix group start/end time not calculating correctly	2024-03-08 01:59:28 +03:00
Salman Ahmed	585ab59768	Apply major refactor to the storyboard commands flow structrure	2024-03-08 01:10:09 +03:00
Dan Balasescu	ca92a31cf9	Fix missing event unbinds	2024-03-07 21:10:11 +09:00
Bartłomiej Dach	fba44e67a0	Merge pull request #27214 from Givikap120/freemod_mapinfo_fix ... Fix mod selection in online-play rooms not accounting for mods of selected item	2024-03-07 12:45:14 +01:00
Bartłomiej Dach	3d8fdc52a4	Merge pull request #27501 from turbedi/throw_helper ... Use ThrowHelper methods in more places	2024-03-07 11:36:21 +01:00
Bartłomiej Dach	e99030c515	Merge pull request #27516 from frenzibyte/editor-screen-selector ... Change editor screen switcher control design and behaviour to act like a button	2024-03-07 11:04:18 +01:00
Bartłomiej Dach	644553d5b4	Merge branch 'master' into freemod_mapinfo_fix	2024-03-07 09:24:44 +01:00
Dan Balasescu	1cafb09977	Increase border thickness	2024-03-07 17:22:38 +09:00
Joseph Madamba	c36232bc02	Fix results screen accuracy circle not showing correctly for failed S with no flair	2024-03-07 00:10:30 -08:00
Dan Balasescu	e0fe33a7a7	Merge pull request #27513 from bdach/osu-score-conversion-bad-very-not-good ... Fix osu! standardised score estimation algorithm violating basic invariants	2024-03-07 17:05:32 +09:00
Salman Ahmed	0fe139a189	Adjust editor screen switcher control design and behaviour	2024-03-07 08:20:46 +03:00
Salman Ahmed	336a6180e5	Expose TRANSITION_LENGTH from tab control	2024-03-07 08:20:20 +03:00
Bartłomiej Dach	aa3cd402ca	Fix broken english	2024-03-06 21:30:31 +01:00
Bartłomiej Dach	3121cf81e6	Bump score version	2024-03-06 21:30:09 +01:00
Dean Herbert	13f7480d79	Merge branch 'master' into sb-lifetime-improvements	2024-03-06 19:27:40 +08:00
Dean Herbert	5b6703ec0d	Move optimisation to isolated method	2024-03-06 19:25:13 +08:00
Dean Herbert	29a37e3585	Merge pull request #27491 from bdach/f-rank-appearance ... Update F rank badge colours to match latest designs	2024-03-06 18:55:20 +08:00
Bartłomiej Dach	08609e19d6	Fix osu! standardised score estimation algorithm violating basic invariants ... As it turns out, the "lower" and "upper" estimates of the combo portion of the score being converted were misnomers. In selected cases (scores with high accuracy but combo being lower than max by more than a few objects) the janky score-based math could overestimate the count of remaining objects in a map. For instance, in one case the numbers worked out something like this: - Accuracy: practically 100% - Max combo on beatmap: 571x - Max combo for score: 551x The score-based estimation attempts to extract a "remaining object count" from score, by doing something along of sqrt(571^2 - 551^2). That comes out to _almost 150_. Which leads to the estimation overshooting the total max combo count on the beatmap by some hundred objects. To curtail this nonsense, enforce some basic invariants: - Neither estimate is allowed to exceed maximum achievable - Ensure that lower estimate is really lower and upper is really upper by just looking at the values and making sure that is so rather than just saying that it is.	2024-03-06 11:40:10 +01:00
Dan Balasescu	d8003ab8e8	Merge pull request #27489 from bdach/fix-catch-pp-mismatch ... Fix catch pp calculator not matching live with respect to miss handling	2024-03-06 19:39:20 +09:00
Bartłomiej Dach	b740481eaf	Merge pull request #27504 from peppy/replay-state-sanity-1 ... Never set `waitingOnFrames` if a replay is not attached	2024-03-06 09:51:09 +01:00
Bartłomiej Dach	53fffc6a75	Remove unused using directives	2024-03-06 07:57:59 +01:00
Dean Herbert	06c7483347	Merge branch 'master' into update-framework	2024-03-06 12:36:05 +08:00
Dean Herbert	85364d25dc	Merge pull request #27276 from bdach/medals ... Add flow for displaying achieved medals	2024-03-06 12:31:55 +08:00
Dean Herbert	3a224211aa	Update various packages which shouldn't cause issues	2024-03-06 12:17:00 +08:00
Dean Herbert	4c7678225e	Update framework	2024-03-06 12:13:41 +08:00
Dean Herbert	0696e7de52	Update ImageSharp usages	2024-03-06 12:13:12 +08:00
Dean Herbert	b53b752e54	Update usage of MathUtils	2024-03-06 12:13:12 +08:00
Dean Herbert	6455c0583b	Update usage of CircularProgress.Current	2024-03-06 12:13:10 +08:00
Andrei Zavatski	07392a4d3e	Further simplify transform application	2024-03-06 01:10:22 +03:00
Andrei Zavatski	1c8ede854d	Remove blank lines	2024-03-06 00:17:56 +03:00
Andrei Zavatski	8b03acd27b	Implement StoryboardElementWithDuration	2024-03-06 00:16:06 +03:00
Dean Herbert	65ce4ca390	Never set waitingOnFrames if a replay is not attached	2024-03-06 04:37:11 +08:00
Dean Herbert	57daaa7fed	Add logging for GameplayClockContainer starting or stopping	2024-03-06 04:37:11 +08:00
Bartłomiej Dach	09c6c5d79b	Merge pull request #27497 from frenzibyte/mod-select-overlay-fix-ux ... Fix mod select overlay settings order not always matching mod panels	2024-03-05 19:40:13 +01:00
Bartłomiej Dach	429fa8dfae	Merge pull request #27242 from Susko3/log-global-statistics ... Log `GlobalStatistics` when exporting logs from settings	2024-03-05 19:32:54 +01:00
Bartłomiej Dach	e6f1a722cb	Remove unused field and commented-out code	2024-03-05 18:49:19 +01:00
Berkan Diler	d0f7ab3316	Revert some changes	2024-03-05 17:18:59 +01:00
Berkan Diler	6fabbe2616	Use new ToDictionary() overload without delegates	2024-03-05 10:27:12 +01:00
Berkan Diler	5965db4fd7	Use ArgumentException.ThrowIfNullOrEmpty throw helper	2024-03-05 10:20:57 +01:00
Berkan Diler	a891303484	Use ArgumentOutOfRangeException throw helper methods	2024-03-05 10:20:30 +01:00
Berkan Diler	9bac60a98f	Use ArgumentNullException.ThrowIfNull in more places	2024-03-05 10:19:47 +01:00
Berkan Diler	43841e210d	Use ObjectDisposedException.ThrowIf throw helper	2024-03-05 09:58:46 +01:00
Salman Ahmed	49b3e81e8a	Migrate DefaultPerformancePointsCounter and rename it	2024-03-05 04:35:39 +03:00
Salman Ahmed	0cbcfcecdc	Integrate "Argon" performance points counter with HUD layout	2024-03-05 03:58:43 +03:00
Salman Ahmed	d7f1e50d66	Add "Argon" performance points counter	2024-03-05 03:34:29 +03:00
Salman Ahmed	3ee57cdfba	Refactor performance points test scene to support skinning	2024-03-05 03:34:25 +03:00
Salman Ahmed	92f455f199	Abstractify performance points calculation to a base class	2024-03-05 03:33:48 +03:00
Salman Ahmed	9543908c7a	Fix mod select overlay settings order not always matching panels order	2024-03-04 23:36:45 +03:00
Bartłomiej Dach	6080c14dd5	Update F rank badge colours to match latest designs	2024-03-04 14:47:49 +01:00
Bartłomiej Dach	dcd6b02809	Fix incorrect implementation of GetCountMiss() for catch	2024-03-04 11:49:12 +01:00
Dan Balasescu	6635d9be04	Add countdown display	2024-03-04 16:50:24 +09:00
Dan Balasescu	bce3bd55e5	Fix catch by moving cursor-specific handling local	2024-03-04 16:08:17 +09:00
Dan Balasescu	5bd037fe8f	Merge branch 'master' into catch-fail-on-banana	2024-03-04 13:13:26 +09:00
Andrei Zavatski	f5d24e6804	Remove unused transform extensions	2024-03-03 21:54:37 +03:00
Andrei Zavatski	7193ec66a4	Make use of framework's transform loops	2024-03-03 21:47:03 +03:00
Andrei Zavatski	c05007804f	Use more direct way to apply transforms	2024-03-03 20:50:28 +03:00
Salman Ahmed	85f131d2f8	Fix "unranked explaination" tooltip text using incorrect translation key	2024-03-02 22:45:15 +03:00
Andrei Zavatski	77b3055978	Improve sb sprite end time guessing	2024-03-01 22:30:44 +03:00
Salman Ahmed	17e167cc1e	Merge branch 'master' into hide-beatmap-details	2024-03-01 16:21:03 +03:00
Dean Herbert	c6201ea5de	Remove unused ruleset parameter when testing beatmap in editor	2024-03-01 20:28:52 +08:00
Dan Balasescu	14519b9982	Merge pull request #27426 from peppy/disallow-backwards-seeks-gameplay ... Fix gameplay seeking backwards for a single frame for some users	2024-03-01 20:08:23 +09:00
Dean Herbert	963c0af814	Fix beatmap information still showing when testing a beatmap	2024-03-01 16:43:47 +08:00
Dean Herbert	19ed78eef5	Log backwards seeks to sentry	2024-03-01 12:40:05 +08:00
cdwcgt	4ad8bbb9e2	remove useless DrawablePool	2024-03-01 13:20:37 +09:00
Dean Herbert	00527da27d	When discord is set to privacy mode, don't show beatmap being edited	2024-03-01 11:42:35 +08:00
Dean Herbert	91483bdc2f	Merge pull request #27001 from Susko3/windows-file-uri-association ... Associate with files and URIs on windows	2024-03-01 11:26:44 +08:00
Dean Herbert	4b3a5bde28	Merge pull request #27424 from frenzibyte/taiko-slider-storyboard ... Hide osu!taiko scroller when the beatmap has storyboard	2024-03-01 10:49:12 +08:00
Andrei Zavatski	eb0933c3a5	Fix allocations in EffectPointVisualisation	2024-02-29 20:35:20 +03:00
Dean Herbert	cc8b838bd4	Add comprehensive log output to help figure out problematic clocks	2024-02-29 23:05:28 +08:00
Dean Herbert	4184a5c1ef	Add flag to allow backwards seeks in tests	2024-02-29 23:05:28 +08:00
Huo Yaoyuan	a11e63b184	Make the code more clear	2024-02-29 20:02:04 +08:00
Dean Herbert	3a780e2b67	Add logging when workaround is hit	2024-02-29 18:27:50 +08:00
Dean Herbert	3355764a68	"Fix" tests	2024-02-29 18:21:44 +08:00
Bartłomiej Dach	9a40a4f700	Merge branch 'master' into convert-path-string-new	2024-02-29 08:51:04 +01:00
Bartłomiej Dach	ee2dac35e0	Merge branch 'master' into taiko-slider-storyboard	2024-02-29 08:50:58 +01:00
Dean Herbert	76e8aee9cc	Disallow backwards seeks during frame stable operation when a replay is not attached	2024-02-29 14:15:32 +08:00
Dean Herbert	f44aadaaa8	Merge pull request #27331 from bdach/statistics-updates-in-multi ... Show user statistics updates on multiplayer and playlists results screens	2024-02-29 12:26:48 +08:00
Dean Herbert	5c404d0f61	Merge pull request #27361 from bdach/difficulty-peppy-stars-zero-osu ... Fix incorrect standardised score estimation on selected beatmaps in osu! ruleset	2024-02-29 11:45:53 +08:00
Huo Yaoyuan	f28f19ed7e	Fix method indent size ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2024-02-29 10:47:16 +08:00
Salman Ahmed	7f5f3804f1	Expose beatmap storyboard as part of GameplayState	2024-02-29 05:39:36 +03:00
Salman Ahmed	a7a758400c	Merge branch 'master' into fix-wireframe	2024-02-29 01:56:50 +03:00
Salman Ahmed	8f97f0503f	Move away from Solo namespace	2024-02-29 01:21:17 +03:00
Salman Ahmed	de48c51715	Apply renaming in remaining usages	2024-02-29 01:11:08 +03:00
Salman Ahmed	c3a7e99849	Remove unnecessary max operation	2024-02-29 01:01:55 +03:00
Salman Ahmed	4a4ef91bc9	Simplify active mods computation ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2024-02-29 00:42:52 +03:00
Salman Ahmed	92eb206b49	Merge branch 'master' into spectator-remove-back-button	2024-02-29 00:12:24 +03:00
Joseph Madamba	5ca6e8c68a	Fix some NRT changes	2024-02-28 11:03:09 -08:00
Bartłomiej Dach	a5948d38ac	Merge pull request #27380 from frenzibyte/fix-advanced-stats-display ... Fix advanced stats in beatmap info overlay showing "key count" on non-mania beatmaps	2024-02-28 18:02:48 +01:00
Huo Yaoyuan	e86ebd6cdb	Fix formatting	2024-02-29 00:24:24 +08:00
Huo Yaoyuan	470d2be2e1	The overhead of LINQ is not ignorable	2024-02-29 00:07:00 +08:00
Bartłomiej Dach	6a3a7cca58	Merge branch 'master' into adjust-carousel-padding	2024-02-28 16:00:43 +01:00
Bartłomiej Dach	c10ba6ece9	Fix right mouse scroll clamping not going along well with padding ... Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>	2024-02-28 15:59:22 +01:00
Huo Yaoyuan	bcb91f348d	Use ArrayPool instead of stackalloc	2024-02-28 22:51:36 +08:00
Huo Yaoyuan	fe34577ee2	Update parsing.	2024-02-28 22:42:08 +08:00
Huo Yaoyuan	4bff54d35d	Add ToString on PathControlPoint for debugging	2024-02-28 22:37:14 +08:00
Bartłomiej Dach	9902dad4c6	Merge branch 'master' into log-global-statistics	2024-02-28 15:09:24 +01:00
Huo Yaoyuan	f49aa4d815	Parse points and segments for path string	2024-02-28 22:01:39 +08:00
Bartłomiej Dach	ce994a7a73	Fix wireframe misalignment in argon accuracy counter ... - Closes https://github.com/ppy/osu/issues/27385. - Supersedes / closes https://github.com/ppy/osu/pull/27392.	2024-02-28 13:42:45 +01:00
Bartłomiej Dach	3fb2662d74	Update framework ... Mainly for the sake of https://github.com/ppy/osu-framework/pull/6196.	2024-02-28 12:05:33 +01:00
Joseph Madamba	6e03384c6b	Apply NRT to SoloSpectatorPlayer	2024-02-28 00:01:16 -08:00
Joseph Madamba	8e462fbb38	Apply NRT to touched files	2024-02-27 23:58:28 -08:00
Joseph Madamba	dee57c7e72	Refactor test to only allow init of actions	2024-02-27 23:24:16 -08:00
Joseph Madamba	351160f94e	Move back/quit button from bottom left to fail overlay when spectating	2024-02-27 23:24:16 -08:00
Dean Herbert	31f667224f	Merge branch 'master' into medals	2024-02-28 13:48:57 +08:00
Salman Ahmed	d83aeb73e4	Fix menu cursor tracing rotation while override by gameplay cursor	2024-02-28 01:02:36 +03:00
Bartłomiej Dach	2889cf39d7	Merge pull request #27391 from smoogipoo/high-performance-session-redux ... Use high performance session during gameplay	2024-02-27 16:28:04 +01:00
Gabriel Del Nero	09dee50372	Change initial scroll animation to mod columns ... Starting from the end (which should be fine with the current number of columns, even on different/wider screen resolutions), and with a custom decay value when it reaches zero offset.	2024-02-27 15:35:51 +01:00
Dean Herbert	189c680555	Add basic xmldoc on interface type	2024-02-27 20:46:25 +08:00
Dan Balasescu	069b400dd0	Move manager to desktop game	2024-02-27 19:36:03 +09:00
Dan Balasescu	dc3b41865c	Add logging	2024-02-27 19:17:34 +09:00
Dan Balasescu	f2d52fbaa2	Make class not overrideable	2024-02-27 17:33:24 +09:00
Dean Herbert	7f0a552b86	Merge pull request #27366 from EVAST9919/mod-overlay-performnce ... Reduce allocations when `ModSelectOverlay` is visible	2024-02-27 08:54:18 +08:00
Salman Ahmed	3f9fbb9318	Introduce the concept of ActiveMods in mod select overlay and rewrite once more	2024-02-26 22:25:06 +03:00
Salman Ahmed	2b73d816a7	Bring back mod setting tracker in BeatmapAttributesDisplay	2024-02-26 22:24:45 +03:00
Bartłomiej Dach	3833f2cfa7	Merge pull request #27393 from peppy/main-menu-key-delay ... Fix main menu eating keys if user presses too fast	2024-02-26 16:22:27 +01:00
Dean Herbert	fe59a3b9be	Merge branch 'master' into medals	2024-02-26 22:49:55 +08:00
Dean Herbert	4c6e8a606f	Fix main menu eating keys if user presses too fast	2024-02-26 22:24:39 +08:00
Dan Balasescu	bfb5098238	Use high performance session during gameplay	2024-02-26 22:32:48 +09:00
Dean Herbert	c686dfd361	Apply safeties for AudioFilter usage around drawables which go non-present	2024-02-26 21:22:25 +08:00
Dean Herbert	7a96cf1289	Expose AudioFilter.IsAttached publicly	2024-02-26 21:15:44 +08:00
Dan Balasescu	3e9425fdf2	Adjust API of HighPerformanceSession + rename	2024-02-26 22:12:46 +09:00
Bartłomiej Dach	09b420a083	Merge pull request #27234 from brandondong/delete_none_message ... Add feedback to delete button even when no-op	2024-02-26 13:13:53 +01:00
Bartłomiej Dach	119a373285	Merge pull request #27389 from peppy/menu-hotkeys ... Allow better menu navigation using same hotkey to progress to destination	2024-02-26 12:31:22 +01:00
Bartłomiej Dach	46ec477191	Merge pull request #27386 from peppy/fix-use-current-distance-snap ... Fix "Use current" snap not working	2024-02-26 12:30:35 +01:00
Dean Herbert	8e336610d0	Add xmldoc explaining Ruleset bindable's usage	2024-02-26 18:31:40 +08:00
Bartłomiej Dach	353485a707	Merge branch 'master' into flashlight-playfield-based-size-	2024-02-26 10:55:06 +01:00
Bartłomiej Dach	115d82664b	Assert proportional scaling rather than assume average ... Because if scaling is ever actually non-proportional then this should be somewhat loud. Also use the absolute value to prevent funny things happening if/when someone does negative scale.	2024-02-26 10:53:04 +01:00
Dean Herbert	8962be2ed5	Allow better menu navigation using same hotkey to progress to destination ... As touched on in https://github.com/ppy/osu/discussions/27102. You can now use: - `L L L` to get to playlists - `M M M` to get to multiplayer - `S` to get to settings	2024-02-26 17:24:04 +08:00
Dean Herbert	9a46e738bd	Fix inspections	2024-02-26 15:45:29 +08:00
Dean Herbert	4c744ccb69	Fix "Use current" snap not working ... Regressed with https://github.com/ppy/osu/pull/27249. I was suspicious of this specific operation at the time but didn't test properly.	2024-02-26 14:11:54 +08:00
Dean Herbert	4421ff975b	Add local function to perform iteration to better explain the "why"	2024-02-26 09:04:39 +08:00
Salman Ahmed	5c049feca1	Fix advanced stats in beatmap info overlay showing "key count" on non-mania beatmaps	2024-02-25 21:18:15 +03:00
Andrei Zavatski	9e3defebda	Remove unused using	2024-02-25 19:05:40 +03:00
Andrei Zavatski	c3fa97d062	Reduce allocations in HitObjectLifetimeEntry	2024-02-25 18:02:42 +03:00
Andrei Zavatski	f948f8ee5c	Fix HUDOverlay allocations	2024-02-25 17:59:20 +03:00
Andrei Zavatski	081aa84718	Simplify last footer button selection	2024-02-25 10:36:15 +03:00
Dean Herbert	e8d2abc4f7	Merge pull request #27364 from EVAST9919/spinner-alloc ... Reduce osu spinner allocations	2024-02-25 09:36:02 +08:00
Andrei Zavatski	6d2187e079	Reduce allocations in ModSelectOverlay	2024-02-24 22:58:23 +03:00
Andrei Zavatski	3b53ed3c3a	Reduce allocations in ModColumn	2024-02-24 22:44:58 +03:00
Andrei Zavatski	1fb19e7129	Reduce allocations in DrawableSpinner	2024-02-24 20:18:30 +03:00
Dan Balasescu	006416057b	Merge pull request #27144 from cdwcgt/allow-muted-ranked ... Allow pp for muted mod for any combination of settings	2024-02-25 00:31:37 +09:00
Bartłomiej Dach	f6ceedc7a6	Inline last version which touched ranks when checking for upgrade	2024-02-24 13:55:44 +01:00
Bartłomiej Dach	4bc92a263f	Bump score version	2024-02-24 13:20:42 +01:00
Bartłomiej Dach	e80b08c46f	Fix incorrect standardised score estimation on selected beatmaps	2024-02-24 09:56:58 +01:00
Dean Herbert	05f0b4796c	Merge pull request #27344 from bdach/editor-combo-colours-rotate ... Fix editor displaying combo colours in effectively incorrect order	2024-02-24 10:44:02 +08:00
Salman Ahmed	d4bc3090e7	Fix incorrect conflict resolution	2024-02-23 18:42:07 +03:00
Salman Ahmed	618819ba9f	Merge branch 'master' into freemod_mapinfo_fix	2024-02-23 18:34:41 +03:00
Salman Ahmed	c1db9d7819	Add test coverage	2024-02-23 18:16:44 +03:00
Bartłomiej Dach	869f0a82de	Use hashset for faster lookup	2024-02-23 15:38:52 +01:00
Salman Ahmed	fdc0636554	General code cleanup	2024-02-23 17:31:54 +03:00
Salman Ahmed	9ce07a96b2	Rewrite mods flow and remove RoomBeatmapAttributesDisplay	2024-02-23 17:30:13 +03:00
Salman Ahmed	323d7f8e2d	Change BeatmapAttributesDisplay retrieval to proper method	2024-02-23 16:59:43 +03:00
Salman Ahmed	918577d530	Compute required mods list once per update	2024-02-23 16:53:41 +03:00
Bartłomiej Dach	f86b7f0702	Enable NRT in EditorBeatmapSkin	2024-02-23 14:52:44 +01:00
Salman Ahmed	f94cd4483c	Avoid relying on game-wide ruleset bindable	2024-02-23 16:50:33 +03:00
Salman Ahmed	ae9c58be30	Remove "multiplayer" references from subclass and move to appropriate place	2024-02-23 16:50:33 +03:00
Bartłomiej Dach	d1d32fc16c	Fix editor displaying combo colours in effectively incorrect order ... Addresses https://github.com/ppy/osu/discussions/27316. Stable lies about the first combo colour being first; in the `.osu` file it is actually second. It does a thing in editor itself to correct for this. https://github.com/peppy/osu-stable-reference/blob/master/osu!/GameModes/Edit/Forms/SongSetup.cs#L233-L234	2024-02-23 14:49:46 +01:00
Dean Herbert	157819c199	Materialise realm collection hashes during song select search process ... Without this, there's a large overhead to do a realm-live `Contains` search when a collection is selected. This may also help considerably alleviate https://github.com/ppy/osu/discussions/27298#discussioncomment-8552508 as we will be performing the native realm search much less.	2024-02-23 11:41:27 +08:00
Brandon	6c8204f9a3	Update delete collections message when none	2024-02-22 19:40:02 -08:00
Brandon	d6beae2ce1	Update delete/restore mod presets message when none	2024-02-22 19:10:15 -08:00
Brandon	01d0ad506d	Merge branch 'master' into delete_none_message	2024-02-22 17:37:26 -08:00
Bartłomiej Dach	eac4c5f69d	Rename {Solo -> User}StatisticsWatcher et al. ... The "solo" prefix is a bit unbecoming now. The updates are not only for solo.	2024-02-22 20:36:24 +01:00
Bartłomiej Dach	1e53503608	Show user statistics after completing a playlists / multiplayer score	2024-02-22 20:35:50 +01:00
Bartłomiej Dach	0074bdc5a1	Change ResultsScreen constructor boolean params to init-only properties	2024-02-22 20:15:03 +01:00
Bartłomiej Dach	f9e92c69a8	Merge branch 'master' into fix-skin-editor-init-fail	2024-02-22 14:08:38 +01:00
Bartłomiej Dach	82b2edd4b7	Merge pull request #26769 from EVAST9919/results-clean ... Rework `AccuracyCircle` to not use `BufferedContainer`s	2024-02-22 13:46:28 +01:00
Bartłomiej Dach	49b7f0e3a7	Merge pull request #26531 from smallketchup82/multiplayer-difficulty-tooltip ... Implement difficulty tooltips for multiplayer lobbies	2024-02-22 12:57:35 +01:00
Bartłomiej Dach	7861125e7a	Swap AR and OD on tooltips ... Matches everything else.	2024-02-22 12:11:49 +01:00
Bartłomiej Dach	46c8560ca5	Merge branch 'master' into multiplayer-difficulty-tooltip	2024-02-22 12:08:29 +01:00
Bartłomiej Dach	d06c67ad8f	Substitute two jank interdependent bool flags for single tri-state enums	2024-02-22 12:05:50 +01:00
Bartłomiej Dach	6770b73e4e	Merge pull request #27192 from smoogipoo/mod-search-ignore-whitespace ... Adjust search terms for mods	2024-02-22 11:41:31 +01:00
Bartłomiej Dach	84fdcd24ef	Remove description from mod search terms ... Closes https://github.com/ppy/osu/issues/27111.	2024-02-22 11:02:08 +01:00
Bartłomiej Dach	1a831145ce	Merge branch 'master' into fix-bpm-differences	2024-02-22 10:41:22 +01:00
Dean Herbert	8b24c6a905	Merge pull request #27299 from BoudewijnPopkema/27272-clear-remembered-username ... Clear stored username/token from config when relevant checkboxes are unticked on login panel	2024-02-22 17:29:36 +08:00
Bartłomiej Dach	81a9908c60	Extract common helper for BPM rounding	2024-02-22 10:27:37 +01:00
Bartłomiej Dach	01f6ab0336	Use more correct implementation	2024-02-22 09:44:59 +01:00
Bartłomiej Dach	a1046f0a86	Revert "clear remembered username when checkbox is unticked" ... This reverts commit d01421b951.	2024-02-22 09:40:27 +01:00
Bartłomiej Dach	57bb0b85a1	Merge pull request #27107 from Joehuu/rank-highest-tooltip ... Add highest rank tooltip to global rank display	2024-02-22 09:08:22 +01:00
Boudewijn Popkema	d01421b951	clear remembered username when checkbox is unticked	2024-02-21 23:15:37 +01:00
Andrei Zavatski	4cefa8bb8d	Reduce allocations in TimelineBlueprintContainer	2024-02-21 23:13:10 +03:00
Dean Herbert	fc30abc7b0	Merge branch 'indented-code-block' into update-framework	2024-02-21 21:44:25 +08:00
Dean Herbert	9d732bd9b1	Merge branch 'remove-legacy-gl' into update-framework	2024-02-21 21:44:19 +08:00
Dean Herbert	6d32cfb7ee	Update framework	2024-02-21 21:39:33 +08:00
Dean Herbert	fb593470d5	Use DEFAULT instead of INSTANCE or static field ... Matches other similar comparers.	2024-02-21 21:02:20 +08:00
Bartłomiej Dach	929858226a	Use custom comparer in beatmap carousel for expected sort behaviour	2024-02-21 12:43:18 +01:00
Bartłomiej Dach	59235d6c50	Implement custom comparer for expected carousel sort behaviour ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2024-02-21 12:43:17 +01:00
Dean Herbert	9c40ff2911	Merge pull request #27278 from EVAST9919/grid-update ... Apply padding to `GridContainer`s directly where possible	2024-02-21 17:29:21 +08:00
Andrei Zavatski	2543a48ac8	Apply padding to GridContainers directly	2024-02-20 23:18:37 +03:00
Andrei Zavatski	871bdb9cf7	Reduce string allocations in TimeInfoContainer	2024-02-20 20:31:18 +03:00
Bartłomiej Dach	33a0dcaf20	NRT-annotate MedalAnimation and fix possible nullref	2024-02-20 17:59:21 +01:00
Andrei Zavatski	6678c4783b	Fix PlaybackControl string allocations	2024-02-20 19:31:28 +03:00
Bartłomiej Dach	9b938f333d	Fix test failures	2024-02-20 17:25:11 +01:00
Bartłomiej Dach	1db5cd3aba	Move medal overlay to topmost container	2024-02-20 16:31:31 +01:00
Bartłomiej Dach	611e3fe76b	Delay medal display when wanting to show results animation	2024-02-20 16:31:31 +01:00
Bartłomiej Dach	96825915f7	Fix threading failure ... Implicitly showing the medal overlay fires off some transforms, and the websocket listener runs on a TPL thread. That's a recipe for disaster, so schedule the show call.	2024-02-20 16:31:31 +01:00
Bartłomiej Dach	8abcc70b93	Add medal overlay to game	2024-02-20 16:31:31 +01:00
Bartłomiej Dach	b334b78b63	Make medal overlay respect overlay disable via activation mode	2024-02-20 16:31:31 +01:00
Bartłomiej Dach	e4971ae121	Add display queueing when multiple medals are granted in quick succession	2024-02-20 16:31:31 +01:00
Bartłomiej Dach	2e5b61302a	Implement basic medal display flow	2024-02-20 16:31:31 +01:00
Bartłomiej Dach	4f321e242b	Enable NRT in OsuFocusedOverlayContainer	2024-02-20 16:31:31 +01:00
Bartłomiej Dach	4911f5208b	Demote medal "overlay" to animation ... I need the actual overlay to be doing way more things (receiving the actual websocket events, queueing the medals for display, handling activation mode), so the pre-existing API design of the overlay just will not fly.	2024-02-20 16:31:31 +01:00
Bartłomiej Dach	48bf9680e1	Add new structures for receiving new medal data	2024-02-20 16:31:31 +01:00
Bartłomiej Dach	4a314a8e31	Namespacify data structures used in websocket communications	2024-02-20 16:31:31 +01:00
Givikap120	ed028e8d26	Update MultiplayerModSelectOverlay.cs	2024-02-20 13:13:13 +02:00
Givikap120	8199a49ee2	minor look changes	2024-02-20 13:11:19 +02:00
Givikap120	a4288e7ecc	removed unnecessary changes	2024-02-20 13:00:59 +02:00
Givikap120	54ef397d56	Changed override method ... now it overrides mods getter instead of calculate fuctions	2024-02-20 12:57:28 +02:00
Dean Herbert	ef413c08f1	Merge pull request #27249 from EVAST9919/editor-alloc ... Reduce osu editor allocations with many objects selected	2024-02-20 15:06:25 +08:00
Dan Balasescu	40d6e8ce85	Remove legacy OpenGL renderer option, it's now just OpenGL	2024-02-20 15:14:30 +09:00
Dean Herbert	3ea47e64f0	Merge pull request #27258 from Loreos7/storage-error-localisation ... Localise storage error popup dialog	2024-02-20 13:37:10 +08:00
Joseph Madamba	2ff8667dd2	Revert "Centralise global rank display logic to new class" ... Also don't show on `LoginOverlay` usage for now.	2024-02-19 12:11:12 -08:00
Andrei Zavatski	c758640311	Reduce allocations in ComposerDistanceSnapProvider	2024-02-19 20:49:56 +03:00
Susko3	24e3fe79a4	Log GlobalStatistics when exporting logs from settings	2024-02-19 17:02:53 +01:00
Mike Will	012d6b7fe1	Change userBeatmapOffsetClock to a FramedOffsetClock ... Assuming that the global audio offset is set perfectly, such that any audio latency is fully accounted for, if a specific beatmap still sounds out of sync, that would no longer be a latency issue. Instead, it would indicate a misalignment between the beatmap's track and time codes, the correction for which should be a virtual-time offset, not a real-time offset.	2024-02-19 09:14:49 -05:00
Dean Herbert	c87bc8b597	Merge pull request #27180 from bdach/better-submission-failure-messaging ... Add better submission failure messaging	2024-02-19 21:38:23 +08:00
Bartłomiej Dach	ec26ab51d1	Use different wording	2024-02-19 13:56:21 +01:00
Bartłomiej Dach	d7b1e3ba50	Merge pull request #27226 from peppy/no-audio-filter-funny-business ... Ensure audio filters can't be attached before load (or post-disposal)	2024-02-19 13:01:34 +01:00
Dean Herbert	398eaee5d0	Merge pull request #27238 from bdach/disable-nested-managers-when-skin-editor-open ... Disable nested input managers on edited screen when skin editor is open	2024-02-19 19:27:26 +08:00
Bartłomiej Dach	f5666185ab	Merge pull request #27239 from peppy/fix-cached-beatmap ... Fix `WorkingBeatmapCache` caching beatmap in wrong state leading to crash	2024-02-19 12:06:45 +01:00
Bartłomiej Dach	1ca566c6b0	Disable nested input managers on edited screen when skin editor is open	2024-02-19 10:19:25 +01:00
Dean Herbert	7f82f10317	Fix beatmap potentially loading in a bad state ... Over-caching could mean that a beatmap could load and cause a late crash. Let's catch it early to avoid such a crash occurring.	2024-02-19 17:18:07 +08:00
Brandon	413b7aab60	Switch to const string	2024-02-18 22:12:03 -08:00
Brandon	c6ca812ea0	Add feedback to delete button even when no-op	2024-02-18 21:52:23 -08:00
maromalo	5a448ce02f	Turn BPMDisplay to RollingCounter<int>	2024-02-18 19:59:56 -03:00
Dean Herbert	998d820666	Ensure audio filters can't be attached before load (or post-disposal) ... Will probably fix https://github.com/ppy/osu/issues/27225?	2024-02-19 00:25:01 +08:00
Dean Herbert	6b6a6aea54	Apply NRT to LogoTrackingContainer	2024-02-18 23:35:26 +08:00
Dean Herbert	882f11bf79	Fix logo tracking container being off by one frame ... This was especially visible at the main menu when running in single thread mode.	2024-02-18 23:19:57 +08:00
Dean Herbert	415a65bf59	Add failing tests for beatmap inconsistencies	2024-02-18 19:32:21 +08:00
Dean Herbert	4d4d69521f	Merge pull request #27114 from EVAST9919/judgements-rework ... Cache created judgement in `HitObject`	2024-02-18 18:07:58 +08:00
Dean Herbert	9655e8c48a	Adjust xmldoc slightly	2024-02-18 17:54:29 +08:00
Dean Herbert	715236765a	Merge pull request #27206 from EVAST9919/selection-enumerators ... Reduce allocations during beatmap selection	2024-02-18 10:02:35 +08:00
Givikap120	24171bd02b	Update MultiplayerModSelectOverlay.cs	2024-02-18 03:34:02 +02:00
Givikap120	a6b63efe7d	Fixed NVika code quality errors	2024-02-18 03:28:24 +02:00
Givikap120	9070e973d3	Update BeatmapAttributesDisplay.cs	2024-02-18 03:16:18 +02:00
Givikap120	4aaf016ee0	quality improvements	2024-02-18 03:15:53 +02:00
Givikap120	6fb3192648	Update BeatmapAttributesDisplay.cs	2024-02-18 03:14:36 +02:00
Givikap120	2df5787dc7	Packed changes into separate class	2024-02-18 03:13:57 +02:00
Salman Ahmed	91675e0970	Update markdown code block implementation in line with framework changes	2024-02-18 02:00:55 +03:00
Givikap120	ed819fde15	Fixed bugs and added ranked status update	2024-02-17 23:01:31 +02:00
Givikap120	cd8ac6a722	Update BeatmapAttributesDisplay.cs	2024-02-17 22:12:15 +02:00
Dean Herbert	6960f87509	Merge pull request #26895 from vmfunc/ordinal-sorting ... Consider case sensitivity when sorting beatmaps in song select	2024-02-18 04:05:22 +08:00
Dean Herbert	71afb8881a	Merge pull request #27199 from EVAST9919/link-compiler-alloc ... Fix `DrawableLinkCompiler` allocations	2024-02-18 04:04:34 +08:00
Dean Herbert	520576a0fd	Merge pull request #27193 from bdach/fix-not-working-metadata-hub-cleanup ... Fix a few issues in metadata hub's disconnection requested flow	2024-02-18 03:46:02 +08:00
Andrei Zavatski	dd82de473a	Revert BeatmapCarousel changes	2024-02-17 22:42:47 +03:00
Dean Herbert	62a7e315bf	Update framework	2024-02-18 03:11:29 +08:00
Andrei Zavatski	22f5a66c02	Reduce allocations during beatmap selection	2024-02-17 15:46:38 +03:00
Joseph Madamba	7a74eaa2de	Fix star counter decrease animation being delayed when current is over displayed star count	2024-02-16 22:47:38 -08:00
Joseph Madamba	6e8d8b977e	Move ternary inside Math.Max()	2024-02-16 22:47:38 -08:00
Andrei Zavatski	b0f334c39e	Fix DrawableLinkCompiler allocations	2024-02-17 00:45:30 +03:00
Andrei Zavatski	060b01eee8	Make CreateJudgement public again and add remarks	2024-02-16 20:24:02 +03:00
Andrei Zavatski	dd32c0a226	Merge branch 'master' into judgements-rework	2024-02-16 20:08:57 +03:00
Bartłomiej Dach	1049be7d72	Add extended xmldoc to DisconnectRequested() ... Just expounds on what the previous commit message said.	2024-02-16 13:09:36 +01:00
Bartłomiej Dach	b4aa247032	Do not attempt to stop watching user presence when requested to disconnect ... First of all, this sort of cleanup isn't really the client's responsibility, and secondly, at the point the client received this request to disconnect, *none of its requests will be honored anymore* (currently the only scenario of this if another client has connected - the server-side concurrency filter will reject this request). When disconnection is requested, the only valid thing to do with respect to talking to the server is to stop doing it. This will be moved server-side in a follow-up change, although I'm not even strictly sure that's required - I'd like to think signalr would know to clean up a disconnecting client from all groups they were in.	2024-02-16 13:08:39 +01:00
Bartłomiej Dach	9fa60b169e	Actually disconnect from metadata hub when requested to ... Nothing in this override, on in the base implementation, would actually attempt to disconnect.	2024-02-16 12:58:50 +01:00
Bartłomiej Dach	171270d99c	Fix missing RPC method mapping ... Thanks, signalr.	2024-02-16 12:58:13 +01:00
Dan Balasescu	0fff9d4937	Add non-whitespace search term for mods	2024-02-16 19:17:41 +09:00
Salman Ahmed	583e71634f	Always bring master/music volume to 50%	2024-02-16 11:20:07 +03:00
Salman Ahmed	952c5b0d18	Use Precision.AlmostBigger	2024-02-16 11:13:41 +03:00
Salman Ahmed	9f53185fa9	Revert changes to muted notification action	2024-02-16 10:47:56 +03:00
Salman Ahmed	df40f55c07	Merge branch 'master' into mute_detection	2024-02-16 01:35:02 +03:00
Salman Ahmed	7530b1f362	Adjust comment again	2024-02-16 01:31:52 +03:00
Salman Ahmed	5431781f80	Bring back target volume to 50%	2024-02-16 01:23:26 +03:00
Salman Ahmed	d81b148b09	Remove mention of decibel units in comment ... Decibels are irrelevant in the volume bindables, as mentioned in PR already.	2024-02-16 01:23:18 +03:00
Salman Ahmed	a9eac5924d	Remove seemingly unnecessary float casts	2024-02-16 01:18:13 +03:00
Dean Herbert	c1d9f53ab4	Merge pull request #27068 from smoogipoo/mania-hd-fi-progression ... Add progressive coverage for mania's Hidden and FadeIn mods	2024-02-16 01:00:53 +08:00
Dean Herbert	e91d38872d	Update framework	2024-02-15 18:28:59 +08:00
Bartłomiej Dach	898d5ce88b	Show selected submission failure messages even in solo ... Previously, if a `SubmittingPlayer` instance deemed it okay to proceed with gameplay despite submission failure, it would silently log all errors and proceed, but the score would still not be submitted. This feels a bit anti-user in the cases wherein something is genuinely wrong with either the client or web, so things like token verification failures or API failures are now shown as notifications to give the user an indication that something went wrong at all. Selected cases (non-user-playable mod, logged out, beatmap is not online) are still logged silently because those are either known and expected, or someone is messing with things.	2024-02-15 10:55:08 +01:00
Bartłomiej Dach	95e745c6fb	Use better messaging for selected submission failure reasons ... These have been cropping up rather often lately, mostly courtesy of linux users, but not only: https://github.com/ppy/osu/issues/26840 https://github.com/ppy/osu/issues/27008 https://github.com/ppy/osu/discussions/26962 so this is a proposal for slightly improved messaging for such cases to hopefully get users on the right track. The original error is still logged to network log, so there's no information loss.	2024-02-15 10:51:27 +01:00
Bartłomiej Dach	e10c4c7079	Merge pull request #27176 from peppy/document-classic-mod-no-rank ... Add inline documentation as to why classic mod is not ranked	2024-02-15 09:22:05 +01:00
Dean Herbert	409dfd33e7	Merge pull request #27178 from Joehuu/truncate-osu-dropdown-items ... Truncate long dropdown menu item text and show tooltip	2024-02-15 16:11:36 +08:00
Joseph Madamba	3d08bc5605	Truncate long dropdown menu item text and show tooltip	2024-02-14 23:01:51 -08:00
Dean Herbert	9e9297bfb3	Add inline documentation as to why classic mod is not ranked ... See https://github.com/ppy/osu/pull/27149#issuecomment-1939509941.	2024-02-15 13:22:54 +08:00
Dean Herbert	728f65b6d3	Merge pull request #27173 from EVAST9919/song-select-sort ... Reduce allocations during aggregate beatmap sorts in song-select screen	2024-02-15 12:50:16 +08:00
Joseph Madamba	a03835bf1c	Improve comments	2024-02-14 20:13:27 -08:00
Dean Herbert	674ee91bb5	Define aggregate max delegates as static to further reduce allocations	2024-02-15 11:40:50 +08:00
Dean Herbert	80abf6aab3	Avoid some further enumerator allocations	2024-02-15 09:45:24 +08:00
Andrei Zavatski	6e1b4152c0	Redice allocations during aggregate beatmap sort	2024-02-15 00:01:55 +03:00
Dean Herbert	59efd22ba2	Merge branch 'master' into score-statistics-updates-working-2	2024-02-15 02:55:12 +08:00
Dean Herbert	9ec79755fb	Standardise font specs	2024-02-15 02:54:28 +08:00
Dean Herbert	c175e03600	Inline rolling duration variable	2024-02-15 02:53:38 +08:00
Bartłomiej Dach	c588b81cee	Merge pull request #27163 from frenzibyte/ignore-soft-deleted-beatmaps-in-notification ... Ignore soft-deleted beatmaps when trying to present from notification	2024-02-14 18:07:59 +01:00
Bartłomiej Dach	aae431e8f6	Cancel rolling properly	2024-02-14 16:48:31 +01:00
Bartłomiej Dach	53884f61c3	Apply suggested changes	2024-02-14 16:41:41 +01:00
Bartłomiej Dach	ae9a2661ac	Sprinkle some raw string prefixes	2024-02-14 16:20:47 +01:00
Bartłomiej Dach	414066fd34	Inline problematic function (and rename things to make more sense)	2024-02-14 16:07:42 +01:00
Bartłomiej Dach	a8ae0a032f	Simplify parsing	2024-02-14 15:58:38 +01:00
Dean Herbert	3da1d05d98	Merge branch 'master' into ignore-soft-deleted-beatmaps-in-notification	2024-02-14 22:56:47 +08:00
Bartłomiej Dach	c24328dda3	Abandon date filter if no meaningful time bound found during parsing	2024-02-14 15:56:32 +01:00
Bartłomiej Dach	f0f37df67f	Revert unnecessary change	2024-02-14 15:37:02 +01:00
Bartłomiej Dach	1113355753	Merge branch 'master' into add-last-played-filter	2024-02-14 15:36:19 +01:00
Bartłomiej Dach	2c0a5b7ef5	Fix missing tiny droplet not triggering fail with perfect on ... Stable does this: 46cd3a10af/osu!/GameplayElements/HitObjectManagerFruits.cs#L98-L102 I'd rather not say what I think about it doing that, since it's likely to be unpublishable, but to approximate that, just make it so that only the "default fail condition" is beholden to the weird ebbs and flows of what the ruleset wants. This appears to fix the problem case and I'm hoping it doesn't break something else but I'm like 50/50 on it happening anyway at this point. Just gotta add tests add nauseam.	2024-02-14 14:21:48 +01:00
Bartłomiej Dach	68247fa022	Fix typo in json property name ... Would cause the mapper badge to never actually be shown in the real world.	2024-02-14 13:21:37 +01:00
Bartłomiej Dach	8312f92b4e	Use better value for alignment	2024-02-14 12:24:28 +01:00
Bartłomiej Dach	153024e61b	Increase transition durations slightly ... Maybe slightly better readability. Dunno.	2024-02-14 10:16:10 +01:00
Bartłomiej Dach	6baa099906	Fix broken delay	2024-02-14 10:12:01 +01:00
Salman Ahmed	4d3b605e04	Add support for displaying "mapper" badges in comments	2024-02-14 04:17:55 +03:00
Salman Ahmed	72c6134dbf	Include commentable object metadata in comments	2024-02-14 04:16:36 +03:00
Salman Ahmed	c4e358044a	Add API models for comment page metadata	2024-02-14 04:16:36 +03:00
Salman Ahmed	5267e0abf7	Move comment author line to separate component	2024-02-14 04:16:36 +03:00
Salman Ahmed	35649d137c	Ignore soft-deleted beatmaps when trying to present from notification	2024-02-14 02:04:20 +03:00
Bartłomiej Dach	eae43f5fd9	Consume SoloStatisticsWatcher updates in toolbar button	2024-02-13 14:28:24 +01:00
Bartłomiej Dach	14052ae1cc	Implement transient stats display on user toolbar button	2024-02-13 14:28:24 +01:00
Bartłomiej Dach	21b9fb95e2	Move SoloStatisticsWatcher to OsuGame ... Doesn't feel like it needs to be in base, and it being in base was causing problems elsewhere before.	2024-02-13 14:28:24 +01:00
Bartłomiej Dach	da4ebd0681	Refactor SoloStatisticsWatcher to no longer require explicit subscription callbacks	2024-02-13 13:49:01 +01:00
Bartłomiej Dach	16d893d40c	Fix draining processor failing gameplay on bonus misses and ignore hits	2024-02-13 13:06:19 +01:00
Dean Herbert	f7a223f328	Merge pull request #27053 from frenzibyte/unranked-pp-placeholder ... Add support for displaying "unranked PP" placeholder	2024-02-13 18:59:55 +08:00
Dan Balasescu	833997bf1d	Merge pull request #27143 from bdach/more-stringent-metadata-checks ... Use more stringent checks when applying online metadata	2024-02-13 17:10:52 +09:00
Salman Ahmed	2d65dfbf09	Fix Rider EAP whoopsie	2024-02-12 22:10:36 +03:00
Salman Ahmed	4f0f07d55a	Remove placeholder classes and inline everything	2024-02-12 21:30:10 +03:00
Bartłomiej Dach	5d81d83fb2	Merge branch 'master' into alias-author-creator	2024-02-12 18:02:42 +01:00
cdwcgt	1944a12634	allow ModMuted to ranked when setting adjusted	2024-02-12 21:18:31 +09:00
Bartłomiej Dach	138fea8c38	Only apply set-level metadata after all difficulties have been processed	2024-02-12 12:08:51 +01:00
Bartłomiej Dach	87702b3312	Only check online matching when determining whether to save online metadata ... After https://github.com/ppy/osu/pull/23362 I'm not sure the `LocallyModified` check is doing anything useful. It was confusing me really hard when trying to parse this logic, and it can misbehave (as `None` will also pass the check).	2024-02-12 12:07:20 +01:00
Bartłomiej Dach	4f0ae4197a	Refuse to apply online metadata in the most dodgy scenarios	2024-02-12 11:43:41 +01:00
Salman Ahmed	2ae616a88e	Combine other cases of displaying dash in scores PP	2024-02-12 12:29:33 +03:00
Stoppedpuma	ca0819cf7a	Alias "mapper" as well	2024-02-11 20:28:16 +01:00
Andrei Zavatski	5e692345de	Don't convert pixel data to array	2024-02-11 17:44:54 +03:00
Dean Herbert	1df38b54a1	Merge branch 'master' into refactor-metadata-lookup-sources	2024-02-11 20:10:41 +08:00
Dean Herbert	7dba21fdac	Move init method to bottom of file	2024-02-11 20:05:58 +08:00
tsunyoku	901b82384d	replace linq usage in Previous and Next with more direct computation	2024-02-10 15:42:55 +00:00
Dean Herbert	32bfd875d9	Merge pull request #26930 from Susko3/suggest-update-only-if-available ... Suggest to update only if the latest release is available for the current platform	2024-02-10 22:08:56 +08:00
Bartłomiej Dach	4a516cbccd	Merge pull request #27077 from peppy/log-fire-and-forget-better ... Improve exception logging of unobserved exceptions via `FireAndForget`	2024-02-10 13:43:50 +01:00
Bartłomiej Dach	c3f0d3ad5c	Merge branch 'master' into match-profile-icons	2024-02-10 13:08:42 +01:00
Dan Balasescu	bfeb90c1b6	Add additional gameplay metadata to room score request	2024-02-10 17:20:17 +09:00
Stoppedpuma	7c04e8bfba	Alias author to creator ... Allows "author" to show the results of "creator"	2024-02-10 07:48:24 +01:00
Dean Herbert	01501f3b82	Merge branch 'master' into refactor-metadata-lookup-sources	2024-02-10 14:43:51 +08:00
Joseph Madamba	7b0b39dbaa	Fix total play time tooltip area including label	2024-02-09 16:06:16 -08:00
Joseph Madamba	ffd0d9bb39	Add highest rank tooltip to global rank display	2024-02-09 16:06:16 -08:00
Joseph Madamba	ae89b89928	Centralise global rank display logic to new class	2024-02-09 16:06:16 -08:00
Joseph Madamba	8d1d65a469	Add ContentTooltipText to ProfileValueDisplay	2024-02-09 16:06:16 -08:00
Joseph Madamba	c9c39ecb2f	Add RankHighest to APIUser	2024-02-09 16:06:16 -08:00
Joseph Madamba	ed2362b63d	Fix icon family and weight not transferring to text conversion	2024-02-09 14:31:38 -08:00
Joseph Madamba	666c57da50	Fix profile current location and interests icons not matching web	2024-02-09 14:31:37 -08:00
Andrei Zavatski	c500264306	Cache created judgement in HitObject	2024-02-09 23:20:31 +03:00
Berkan Diler	6adf0ac01e	Use new LINQ Order() instead of OrderBy() when possible	2024-02-08 18:01:00 +01:00