42526 Commits

Author	SHA1	Message	Date
Dan Balasescu	48f8d9c916	Merge pull request #27756 from bdach/pp-on-results-provisional ... Apply partial fade on pp display on results screen when score will not give pp	2024-03-29 19:57:59 +09:00
Bartłomiej Dach	5371141d3b	Merge pull request #27755 from peppy/fix-import-weirdness ... Avoid reporting an import as successful when all beatmaps failed to import	2024-03-29 11:25:41 +01:00
Bartłomiej Dach	e06df34a1c	Apply partial fade on pp display on results screen when score will not give pp	2024-03-29 11:16:31 +01:00
Bartłomiej Dach	2d3b273974	Remove redundant string interpolation	2024-03-29 10:37:49 +01:00
Dean Herbert	233b9eb172	Avoid reporting an import as successful when all beatmaps failed to import	2024-03-29 17:11:55 +08:00
Dean Herbert	d9cf5b5440	Fix bindable not being correctly re-bound across local user changes	2024-03-29 15:50:10 +08:00
Dean Herbert	fef8afb833	Fix double binding causing game crash after API enters failing state ... See https://sentry.ppy.sh/organizations/ppy/issues/33406/?alert_rule_id=4&alert_timestamp=1711655107332&alert_type=email&environment=production&project=2&referrer=alert_email	2024-03-29 12:19:14 +08:00
Dan Balasescu	6e746a0fa0	Fix carousel reoder on initial enter	2024-03-28 23:56:46 +09:00
Dan Balasescu	9fd6449fd8	Add mods to FilterCriteria, pass to ruleset method	2024-03-28 23:03:26 +09:00
Dan Balasescu	10edb54614	Add ability to query key count with mods	2024-03-28 22:51:12 +09:00
Dan Balasescu	5febd40bd9	Add HP and AR to LegacyBeatmapConversionDifficultyInfo	2024-03-28 22:30:39 +09:00
Susko3	53900d5472	Fix tests failing locally due to not using invariant culture	2024-03-27 18:56:26 +01:00
Dan Balasescu	600098d845	Fix bulbs on Catmull sliders	2024-03-27 04:05:04 +09:00
Bartłomiej Dach	6ef54321c4	Merge pull request #26707 from peppy/beat-sync-container-early-adjust ... Adjust `BeatSyncContainer`'s early animate offset based on source's rate	2024-03-26 18:43:25 +01:00
Bartłomiej Dach	0b29a762b8	Add precautionary guard to avoid potential div-by-zero ... Probably wouldn't happen outside of tests, but I'd rather not find out next release.	2024-03-26 17:36:40 +01:00
Dean Herbert	a5f15a119e	Apply rate adjust fix in all cases rather than specifically for Clock.Rate == 1	2024-03-26 22:51:54 +08:00
Dean Herbert	eae8e243c6	Merge branch 'master' into beat-sync-container-early-adjust	2024-03-26 21:31:33 +08:00
Bartłomiej Dach	bc1ffb0b6e	Merge branch 'master' into shared-menu-content	2024-03-26 13:47:44 +01:00
Dean Herbert	e77d4c8cfa	Remove unnecessary Math.Max	2024-03-26 20:28:03 +08:00
Dean Herbert	fd649edaba	Also don't rotate images during a drag operation	2024-03-26 20:21:48 +08:00
Dean Herbert	9474156df4	Improve equality implementations	2024-03-26 20:21:12 +08:00
Bartłomiej Dach	56dc6bb192	Merge branch 'master' into feat/support-filtering-for-multiple-types	2024-03-26 12:39:51 +01:00
Bartłomiej Dach	e52d51cd0a	Update OptionalSet implementation to intersect across multiple filters rather than union	2024-03-26 12:32:03 +01:00
Bartłomiej Dach	b74f8dba41	Merge branch 'master' into verify-abnormal-difficulty-settings	2024-03-26 11:13:16 +01:00
Bartłomiej Dach	1866b4b6b1	Refactor abstract check to reduce duplication	2024-03-26 11:13:03 +01:00
Bartłomiej Dach	73926592b9	Bump legacy score version to recalculate all scores	2024-03-25 19:27:38 +01:00
Bartłomiej Dach	4979305b2d	Ensure TryDisableCustomRulesetsCausing() never actually crashes itself	2024-03-25 11:34:29 +01:00
Bartłomiej Dach	fb08d6816b	Only attempt to disable rulesets when decidedly crashing out	2024-03-25 11:33:15 +01:00
Dean Herbert	bb9fa52fda	Fix displayIndex not being correctly set to -1 after last expiry date	2024-03-25 14:53:05 +08:00
Dean Herbert	057f86dd14	Add handling of expiration	2024-03-25 14:31:05 +08:00
Dean Herbert	f0614928b1	Read from new location	2024-03-25 13:19:12 +08:00
Dean Herbert	e9f15534ed	Improve test coverage	2024-03-25 12:33:32 +08:00
Dean Herbert	3847aae57d	Don't rotate when hovering	2024-03-25 12:14:40 +08:00
Dean Herbert	d0b164b44f	Add automatic rotation support	2024-03-25 11:41:50 +08:00
Dean Herbert	a4c619ea97	Add basic support for loading multiple images	2024-03-24 15:14:56 +08:00
Dean Herbert	ec4a9a5fdd	Make work again for simple case	2024-03-24 14:55:45 +08:00
Dean Herbert	ef2a16dd8f	Various renaming and class updates to allow multiple menu banners	2024-03-24 14:55:43 +08:00
Arthur Araujo	8a05fecad5	Fix formatting issue	2024-03-23 23:28:55 -03:00
Arthur Araujo	6fbe1a5b8d	Add video resolution check	2024-03-23 19:22:47 -03:00
Bartłomiej Dach	c7c0330265	Attempt to disable rulesets that can be linked to an unhandled crash	2024-03-22 19:05:58 +01:00
Bartłomiej Dach	a1880e89c2	Use title as tiebreaker when sorting beatmap carousel by artist ... Closes https://github.com/ppy/osu/issues/27548. Reference: e53980dd76/osu!/GameplayElements/Beatmaps/BeatmapTreeManager.cs#L341-L347	2024-03-22 08:41:10 +01:00
Arthur Araujo	a4822fd615	Make CheckAbnormalDifficultySettings abstract	2024-03-22 01:37:06 -03:00
Salman Ahmed	1efa08a1b8	Merge branch 'master' into convert-path-string-new	2024-03-22 05:15:04 +03:00
Dean Herbert	970e45ff24	Merge pull request #26937 from frenzibyte/fix-osu-logo-blocking-load ... Stop blocking player load when hovering over osu! logo	2024-03-21 21:52:25 +08:00
Bartłomiej Dach	3e764ae4f0	Merge pull request #27639 from 64ArthurAraujo/verify-unused-audio-at-end ... Add verify checks to unused audio at the end	2024-03-21 12:19:53 +01:00
Bartłomiej Dach	983385bafc	Merge pull request #27677 from smoogipoo/fix-catch-banana-fail ... Fix catch banana shower judgement causing fail when at 0 HP	2024-03-21 11:23:51 +01:00
Dean Herbert	c081cc7d77	Merge pull request #27681 from smoogipoo/add-deployed-build-attribute ... Warn about not using an official "deployed" build	2024-03-21 14:13:40 +08:00
Dean Herbert	b99b0337cf	Adjust text slightly	2024-03-21 13:06:25 +08:00
Dean Herbert	0589924dc6	Merge pull request #27079 from smoogipoo/tcm-resume ... Add delayed resume for taiko/catch/mania	2024-03-21 12:48:53 +08:00
Dean Herbert	55d66d4615	Add sounds to countdown	2024-03-21 11:45:48 +08:00
Dean Herbert	a07d5115bf	Update resources	2024-03-21 11:42:22 +08:00
Arthur Araujo	b132734f9c	Fix codefactor issues	2024-03-20 18:54:38 -03:00
Arthur Araujo	c605e463a4	Add mania keycount check	2024-03-20 15:52:16 -03:00
Dan Balasescu	ac7fca10d6	Warn about not using an official "deployed" build	2024-03-21 00:47:45 +09:00
Arthur Araujo	4904c49c38	Add abnormal difficulty settings checks	2024-03-20 09:31:58 -03:00
Dan Balasescu	c78e203df5	Fix infinite health processor loop when no top-level objects ... This is unlikely to occur in actual gameplay, but occurs in the follow-up test.	2024-03-20 17:30:37 +09:00
Bartłomiej Dach	1f343b7545	Add extended logging when discarding online metadata lookup results ... Related to: https://github.com/ppy/osu/issues/27674 Relevant log output for that particular case: [network] 2024-03-20 07:25:30 [verbose]: Performing request osu.Game.Online.API.Requests.GetBeatmapRequest [network] 2024-03-20 07:25:30 [verbose]: Request to https://dev.ppy.sh/api/v2/beatmaps/lookup successfully completed! [network] 2024-03-20 07:25:30 [verbose]: GetBeatmapRequest finished with response size of 3,170 bytes [database] 2024-03-20 07:25:30 [verbose]: [4fe02] [APIBeatmapMetadataSource] Online retrieval mapped Tsukiyama Sae - Hana Saku Iro wa Koi no Gotoshi (Log Off Now) [Destiny] to 744883 / 1613507. [database] 2024-03-20 07:25:30 [verbose]: Discarding metadata lookup result due to mismatching online ID (expected: 1570982 actual: 1613507) [network] 2024-03-20 07:25:30 [verbose]: Performing request osu.Game.Online.API.Requests.GetBeatmapRequest [network] 2024-03-20 07:25:30 [verbose]: Request to https://dev.ppy.sh/api/v2/beatmaps/lookup successfully completed! [network] 2024-03-20 07:25:30 [verbose]: GetBeatmapRequest finished with response size of 2,924 bytes [database] 2024-03-20 07:25:30 [verbose]: [4fe02] [APIBeatmapMetadataSource] Online retrieval mapped Tsukiyama Sae - Hana Saku Iro wa Koi no Gotoshi (Log Off Now) [Easy] to 744883 / 1570982. [database] 2024-03-20 07:25:30 [verbose]: Discarding metadata lookup result due to mismatching online ID (expected: 1613507 actual: 1570982) Note that the online IDs are swapped.	2024-03-20 08:28:11 +01:00
Bartłomiej Dach	8ee391530f	Merge pull request #27675 from peppy/remove-breadcrumb-control ... Remove unused `ScreenBreadcrumbControl`	2024-03-20 08:02:36 +01:00
Dean Herbert	1f70019009	Merge pull request #27630 from EVAST9919/editor-performance ... Improve editor performance for maps with many control points	2024-03-20 13:20:21 +08:00
Dean Herbert	fd509c82f5	Adjust code structure slightly	2024-03-20 12:52:54 +08:00
Dean Herbert	d83a53fc94	Remove unused ScreenBreadcrumbControl ... See https://github.com/ppy/osu-framework/pull/6218#discussion_r1529932798.	2024-03-20 12:10:05 +08:00
Bartłomiej Dach	e4418547fe	Document GetLastObjectTime() exception on empty beatmap	2024-03-19 19:19:07 +01:00
Bartłomiej Dach	2b83e6bc4c	Fix check crash on empty beatmap	2024-03-19 19:17:22 +01:00
Bartłomiej Dach	af3f7dcbbf	Retouch update criteria method	2024-03-19 18:33:35 +01:00
Bartłomiej Dach	320373e3e0	Rename method to match convention better	2024-03-19 18:28:13 +01:00
Bartłomiej Dach	feaf59e15f	Use HashSet instead of SortedSet ... No need for it to be sorted.	2024-03-19 18:26:58 +01:00
Dean Herbert	0de5ca8d2d	Update incorrect xmldoc	2024-03-20 01:26:39 +08:00
Dean Herbert	35df381717	Merge branch 'master' into tcm-resume	2024-03-20 01:25:40 +08:00
Bartłomiej Dach	0180b25546	Merge pull request #27064 from smoogipoo/heatmap-misses ... Display misses in the hit accuracy heatmap	2024-03-19 16:20:25 +01:00
Dan Balasescu	f6069d8d93	Compare against MaxCombo instead	2024-03-19 17:46:18 +09:00
Dan Balasescu	6e33509417	Remove added property, use local decoding instead	2024-03-19 17:44:37 +09:00
Dan Balasescu	af713a7869	Fix incorrectly encoded score IsPerfect value	2024-03-19 17:20:59 +09:00
Salman Ahmed	bbdcb38f5d	Merge branch 'master' into convert-path-string-new	2024-03-19 02:51:24 +03:00
Salman Ahmed	a8ce6a0bba	Use Slice method instead of index range operators for readability	2024-03-19 02:43:36 +03:00
Arthur Araujo	5241c999c1	Add different warning to maps with storyboard/video	2024-03-18 16:08:41 -03:00
Arthur Araujo	f6d7f18f25	Remove unused localisation file	2024-03-18 15:59:19 -03:00
Andrei Zavatski	7ca45c75b3	Don't iterate backwards on children without a reason	2024-03-18 20:46:38 +03:00
Andrei Zavatski	0edc249637	Make Timeline non-nullable	2024-03-18 20:38:19 +03:00
Andrei Zavatski	57399e9899	Merge branch 'master' into editor-performance	2024-03-18 20:34:48 +03:00
Arthur Araujo	c23212f4ef	Use GetLastObjectTime to calculate mapped length	2024-03-18 14:02:33 -03:00
Arthur Araujo	915a9682b5	Fix issue type and display percentage left	2024-03-18 13:51:36 -03:00
Arthur Araujo	a3f3dcf853	Inline percentage calculation	2024-03-18 13:27:43 -03:00
Vlad Frangu	77119b2cdb	chore: correct doc string	2024-03-18 16:44:42 +02:00
Bartłomiej Dach	c9bbeeb49a	Merge branch 'master' into heatmap-misses	2024-03-18 14:43:24 +01:00
Vlad Frangu	d0678bfbee	chore: requested changes	2024-03-18 15:30:43 +02:00
Dean Herbert	498948f17d	Merge pull request #27607 from Joehuu/fix-beatmap-card-lime-artifact ... Fix noticeable masking artifact of beatmap cards when already downloaded	2024-03-18 00:38:56 +08:00
Arthur Araujo	f7aff76592	Fix codefactor issues	2024-03-16 23:03:06 -03:00
Arthur Araujo	63816adbc0	Add verify checks to unused audio at the end	2024-03-16 21:20:12 -03:00
Vlad Frangu	e1c1609271	chore: correct equal logic	2024-03-16 21:48:44 +02:00
Vlad Frangu	0a6960296e	feat: Support filtering for multiple statuses	2024-03-16 21:32:55 +02:00
Andrei Zavatski	34a5e2d606	Don't update subtree masking in TimelineTickDisplay	2024-03-16 15:20:37 +03:00
Andrei Zavatski	981ee54cdc	Fix transforms overhead in TimelineTickDisplay	2024-03-16 15:05:52 +03:00
Andrei Zavatski	e825db61ee	Fix enumerator allocation	2024-03-16 12:26:56 +03:00
Andrei Zavatski	854d7c6fb4	Merge branch 'master' into editor-performance	2024-03-16 12:26:39 +03:00
Andrei Zavatski	ea3a9314f9	Improve TimelineControlPointDisplay performance	2024-03-16 11:57:18 +03:00
Dean Herbert	15c0b1a2ec	Remove redundant cast	2024-03-16 13:18:42 +08:00
Dean Herbert	a49c4ebea6	Match settings panels' backgrounds visually and behaviourally	2024-03-16 10:23:21 +08:00
Dean Herbert	0f8d526453	Adjust timings and delay disclaimers the same as settings	2024-03-16 10:09:49 +08:00
Bartłomiej Dach	a78210c88f	Handle hover so that users can hover disclaimer to block load & read it	2024-03-15 11:45:27 +01:00
Bartłomiej Dach	e6883b8418	Tweak visuals further	2024-03-15 11:38:51 +01:00
Bartłomiej Dach	51568ba06a	Add background to disclaimers	2024-03-15 11:31:45 +01:00
Bartłomiej Dach	5513a72748	Improve hiding transition when multiple disclaimers are visible	2024-03-15 11:01:34 +01:00
Bartłomiej Dach	49a087f7fc	Add localisation support	2024-03-15 10:59:49 +01:00
Bartłomiej Dach	4688a53cf4	Stay on player loader a bit longer if disclaimers are present ... Just to make reading the text easier.	2024-03-15 09:53:20 +01:00
Bartłomiej Dach	f3a444b7ac	Add disclaimer for loved/qualified status	2024-03-15 09:53:20 +01:00
Bartłomiej Dach	42ae18976f	Replace existing epilepsy warning with inline display	2024-03-15 09:53:20 +01:00
Bartłomiej Dach	1aa695add9	Implement alternate design of player loader disclaimers	2024-03-15 09:53:18 +01:00
Dean Herbert	23975d4dd1	Add flash and reduce overall time for countdown to 2 seconds	2024-03-14 22:49:53 +08:00
Dean Herbert	2845303a74	Fix non-matching scale outwards animation	2024-03-14 22:45:05 +08:00
Dean Herbert	888245b44f	Reorder methods	2024-03-14 22:44:26 +08:00
Dean Herbert	d7769ec3e2	Adjust animation	2024-03-14 22:44:23 +08:00
Dean Herbert	42bd558d7c	Only update text when necessary (reducing unnecessary string allocadtions)	2024-03-14 22:43:08 +08:00
Joseph Madamba	f8a841e907	Add comment explaining why width is limited to the button area ... Same comment as a47ccb8edd/osu.Game/Screens/Select/BeatmapInfoWedgeV2.cs (L91-L92).	2024-03-14 00:17:22 -07:00
Salman Ahmed	b4cee12db9	Use defined colours for counter background	2024-03-14 09:22:03 +03:00
Joseph Madamba	b309aad895	Fix noticeable masking artifact of beatmap cards when already downloaded ... Had a similar fix before seeing https://github.com/ppy/osu/pull/20743#discussion_r994955470, but using that diff instead so co-authoring. Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2024-03-13 22:36:52 -07:00
Dan Balasescu	b431bb1176	Resolve post-merge issues	2024-03-14 12:24:12 +09:00
Dan Balasescu	0beaa8e8c5	Merge branch 'master' into tcm-resume	2024-03-14 12:22:46 +09:00
Dan Balasescu	789a9f4dfa	Initial redesign following flyte's design	2024-03-14 11:38:16 +09:00
Dean Herbert	a47ccb8edd	Merge pull request #27600 from bdach/dont-die-on-audio-in-video-check ... Fix audio in video check crashing on unexpected failures	2024-03-14 10:28:45 +08:00
Bartłomiej Dach	d32f19b546	Fix first word bold not applying correctly after first language change ... Closes https://github.com/ppy/osu/issues/27549. I'm not entirely sure why the old solution failed exactly, but also think it's unimportant because I think past me was an idiot and was playing stupid games with the juggling of indices between two callbacks with no ordering guarantees and expecting not to win stupid prizes. I'm not sure this requires any follow-up reconsiderations of that entire text flow API, but if opinions differ, I'll re-examine.	2024-03-13 15:18:20 +01:00
Bartłomiej Dach	20c760835a	Fix audio in video check crashing on unexpected failures	2024-03-13 13:55:49 +01:00
Joseph Madamba	e2e99fc5cc	Rearrange rankings overlay tabs to match web	2024-03-12 21:15:59 -07:00
Dean Herbert	a4a433b92a	Remember login by default ... Kinda what is expected from a user's perspective	2024-03-12 20:14:50 +08:00
Dean Herbert	5b2dd95fd6	Merge pull request #27586 from bdach/ignore-directory-zip-entries ... Fix exports containing zero byte files after import from specific ZIP archives	2024-03-12 17:18:39 +08:00
Bartłomiej Dach	83e47b3c4c	Fix exports containing zero byte files after import from specific ZIP archives ... Closes https://github.com/ppy/osu/issues/27540. As it turns out, some ZIP archivers (like 7zip) will decide to add fake entries for directories, and some (like windows zipfolders) won't. The "directory" entries aren't really properly supported using any actual data or attributes, they're detected by sharpcompress basically by heuristics: ab5535eba3/src/SharpCompress/Common/Zip/Headers/ZipFileEntry.cs (L19-L31) When importing into realm we have thus far presumed that these directory entries will not be a thing. Having them be a thing breaks multiple things, like: - When importing from ZIPs with separate directory entries, a separate `RealmFile` is created for a directory entry even though it doesn't represent a real file - As a result, when re-exporting a model with files imported from such an archive, a zero-byte file would be created because to the database it looks like it was originally a zero-byte file. If you want to have fun, google "zip empty directories". You'll see a whole gamut of languages, libraries, and developers stepping on this rake. Yet another episode of underspecced mistakes from decades ago that were somebody's "good idea" but continue to wreak havoc forevermore because now there are two competing conventions you can't just pick one.	2024-03-12 09:06:24 +01:00
Dean Herbert	83052fe1d9	Downgrade realm to work around crashes on latest release ... See https://github.com/ppy/osu/issues/27577.	2024-03-12 15:41:50 +08:00
Bartłomiej Dach	f30dfcb728	Fix ruleset medals not displaying due to deserialisation failure ... 🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦 Reported in https://discord.com/channels/188630481301012481/188630652340404224/1216812697589518386.	2024-03-11 21:34:10 +01:00
Bartłomiej Dach	9bc55be515	Merge pull request #27564 from EVAST9919/editor-blueprint-gradient ... Fix incorrect gradient application in `TimelineHitObjectBlueprint`	2024-03-11 16:02:05 +01:00
Bartłomiej Dach	09179f99c0	Merge branch 'master' into wrap-beatmap-listing-filters	2024-03-11 14:59:48 +01:00
Bartłomiej Dach	e5e7c8f268	Wrap beatmap listing filter names too ... While we're here fixing... Addresses https://github.com/ppy/osu/discussions/15452#discussioncomment-2734237.	2024-03-11 14:58:28 +01:00
Andrei Zavatski	6ecef33fd7	Fic incorrect ExtendableCircle gradient	2024-03-10 22:45:29 +03:00
Andrei Zavatski	549a8d678e	Reduce allocations in ControlPointList	2024-03-09 20:50:54 +03:00
Dean Herbert	31739be499	Update resources	2024-03-09 20:48:57 +08:00
Dean Herbert	b8a362fcb6	Simplify assignment by using an auto property	2024-03-09 20:17:27 +08:00
Andrei Zavatski	58b6acde10	Further simplify tooltip text creation	2024-03-09 14:10:32 +03:00
Andrei Zavatski	dd36942508	Reduce allocations in DrawableFlag tooltip	2024-03-09 13:58:05 +03:00
Andrei Zavatski	26c97ef733	Fix WikiPanelContainer causing poor performance	2024-03-09 00:51:33 +03:00
Joseph Madamba	db1c59475b	Wrap beatmap listing filters and match web spacing	2024-03-08 12:13:54 -08:00
Salman Ahmed	9f71eac1db	Remove extra end line	2024-03-08 23:09:50 +03:00
Salman Ahmed	8c92bb0595	Remove unused using directive	2024-03-08 23:09:16 +03:00
Salman Ahmed	1942d46a38	Remove leftover debugging code	2024-03-08 22:37:27 +03:00
Salman Ahmed	6861d9a302	Expose storyboard command lists as read-only and remove unnecessary memory footprint ... Mutation should be done only with the methods exposed by `StoryboardCommandGroup`.	2024-03-08 22:29:49 +03:00
Salman Ahmed	0efa12a86a	Fix parameter commands applying initial value before start time	2024-03-08 21:56:25 +03:00
Salman Ahmed	c1649b76d6	Reorder command properties to match general format ... I had them shuffled around in the middle of the refactor.	2024-03-08 21:33:53 +03:00
Dean Herbert	612bc66e86	Merge pull request #27535 from nekodex/argon-hitsounds ... Add support for argon hitsounds	2024-03-09 01:47:35 +08:00
Salman Ahmed	a85be2a46d	Fix merge conflicts	2024-03-08 20:22:26 +03:00
Salman Ahmed	8d3e502262	Merge branch 'master' into storyboard-loops-v2	2024-03-08 20:22:19 +03:00
Jamie Taylor	27d78fdb08	Add fallback to find spinner samples without a bank prefix	2024-03-09 01:10:28 +09:00
Jamie Taylor	ad842b60f5	Add support for Argon hitsounds	2024-03-08 21:43:18 +09:00
Bartłomiej Dach	44d0dc6113	Fix 1px flashlight gaps when gameplay scaling mode is active ... Closes https://github.com/ppy/osu/issues/27522. Concerns mostly taiko and catch. Not much of a proper fix rather than a workaround but it is what it is. I tried a few other things, including setting `MaskingSmoothness = 0` on the scaling container itself, to no avail.	2024-03-08 11:07:30 +01:00
Dean Herbert	c9b4c684e5	Merge pull request #27403 from Gabixel/increase-modselect-initial-scroll ... Change initial scroll effect to mod columns	2024-03-08 14:00:40 +08:00
Dean Herbert	5e7d9ea04a	Adjust scroll speed back to original	2024-03-08 13:59:04 +08:00
Dean Herbert	d9cc619693	Merge branch 'master' into argon-pp-counter	2024-03-08 10:32:16 +08:00
Dean Herbert	9286398633	Move naming migrations to more correct place	2024-03-08 10:26:08 +08:00
Dean Herbert	0ebb12f67f	Move skinnable interface specification to non-abstract classes	2024-03-08 10:23:46 +08:00
Dean Herbert	ae2ef8ee1e	Fix typo in wireframe description	2024-03-08 10:19:00 +08:00
Dean Herbert	f2753ef7a2	Decrease size of pp display relative to accuracy	2024-03-08 09:41:38 +08:00
Dean Herbert	87b4406bdc	Pad at minimum three digits for argon pp display	2024-03-08 09:41:28 +08:00
Salman Ahmed	79da6d8613	Fix refactor error on EndTimeForDisplay ... Not sure when this happened >.>	2024-03-08 03:08:03 +03:00
Salman Ahmed	fa9b2f0cd5	Add generics to ApplyInitialValue/ApplyTransforms for ability to return custom transform sequences ... *sigh*	2024-03-08 03:07:39 +03:00
Salman Ahmed	b450abb687	Support applying initial values of storyboard commands	2024-03-08 02:02:48 +03:00
Salman Ahmed	2ca36254f4	Fix comparison interface not implemented on storyboard command classes	2024-03-08 02:02:25 +03:00
Salman Ahmed	3755dd059a	Calculate loop delays at point of transform application	2024-03-08 02:01:02 +03:00
Salman Ahmed	87b065b8c3	Fix incorrect start time calculations ... `LoopStartTime` is now baked into each `IStoryboardCommand`.	2024-03-08 02:01:02 +03:00
Salman Ahmed	6c257e5159	Fix HasCommands property not set at all	2024-03-08 01:59:44 +03:00
Salman Ahmed	9b77d8c972	Fix group start/end time not calculating correctly	2024-03-08 01:59:28 +03:00
Salman Ahmed	585ab59768	Apply major refactor to the storyboard commands flow structrure	2024-03-08 01:10:09 +03:00
Dan Balasescu	ca92a31cf9	Fix missing event unbinds	2024-03-07 21:10:11 +09:00
Bartłomiej Dach	fba44e67a0	Merge pull request #27214 from Givikap120/freemod_mapinfo_fix ... Fix mod selection in online-play rooms not accounting for mods of selected item	2024-03-07 12:45:14 +01:00
Bartłomiej Dach	3d8fdc52a4	Merge pull request #27501 from turbedi/throw_helper ... Use ThrowHelper methods in more places	2024-03-07 11:36:21 +01:00
Bartłomiej Dach	e99030c515	Merge pull request #27516 from frenzibyte/editor-screen-selector ... Change editor screen switcher control design and behaviour to act like a button	2024-03-07 11:04:18 +01:00
Bartłomiej Dach	644553d5b4	Merge branch 'master' into freemod_mapinfo_fix	2024-03-07 09:24:44 +01:00
Dan Balasescu	1cafb09977	Increase border thickness	2024-03-07 17:22:38 +09:00
Joseph Madamba	c36232bc02	Fix results screen accuracy circle not showing correctly for failed S with no flair	2024-03-07 00:10:30 -08:00
Dan Balasescu	e0fe33a7a7	Merge pull request #27513 from bdach/osu-score-conversion-bad-very-not-good ... Fix osu! standardised score estimation algorithm violating basic invariants	2024-03-07 17:05:32 +09:00
Salman Ahmed	0fe139a189	Adjust editor screen switcher control design and behaviour	2024-03-07 08:20:46 +03:00
Salman Ahmed	336a6180e5	Expose TRANSITION_LENGTH from tab control	2024-03-07 08:20:20 +03:00
Bartłomiej Dach	aa3cd402ca	Fix broken english	2024-03-06 21:30:31 +01:00
Bartłomiej Dach	3121cf81e6	Bump score version	2024-03-06 21:30:09 +01:00
Dean Herbert	13f7480d79	Merge branch 'master' into sb-lifetime-improvements	2024-03-06 19:27:40 +08:00
Dean Herbert	5b6703ec0d	Move optimisation to isolated method	2024-03-06 19:25:13 +08:00
Dean Herbert	29a37e3585	Merge pull request #27491 from bdach/f-rank-appearance ... Update F rank badge colours to match latest designs	2024-03-06 18:55:20 +08:00
Bartłomiej Dach	08609e19d6	Fix osu! standardised score estimation algorithm violating basic invariants ... As it turns out, the "lower" and "upper" estimates of the combo portion of the score being converted were misnomers. In selected cases (scores with high accuracy but combo being lower than max by more than a few objects) the janky score-based math could overestimate the count of remaining objects in a map. For instance, in one case the numbers worked out something like this: - Accuracy: practically 100% - Max combo on beatmap: 571x - Max combo for score: 551x The score-based estimation attempts to extract a "remaining object count" from score, by doing something along of sqrt(571^2 - 551^2). That comes out to _almost 150_. Which leads to the estimation overshooting the total max combo count on the beatmap by some hundred objects. To curtail this nonsense, enforce some basic invariants: - Neither estimate is allowed to exceed maximum achievable - Ensure that lower estimate is really lower and upper is really upper by just looking at the values and making sure that is so rather than just saying that it is.	2024-03-06 11:40:10 +01:00
Dan Balasescu	d8003ab8e8	Merge pull request #27489 from bdach/fix-catch-pp-mismatch ... Fix catch pp calculator not matching live with respect to miss handling	2024-03-06 19:39:20 +09:00
Bartłomiej Dach	b740481eaf	Merge pull request #27504 from peppy/replay-state-sanity-1 ... Never set `waitingOnFrames` if a replay is not attached	2024-03-06 09:51:09 +01:00
Bartłomiej Dach	53fffc6a75	Remove unused using directives	2024-03-06 07:57:59 +01:00
Dean Herbert	06c7483347	Merge branch 'master' into update-framework	2024-03-06 12:36:05 +08:00
Dean Herbert	85364d25dc	Merge pull request #27276 from bdach/medals ... Add flow for displaying achieved medals	2024-03-06 12:31:55 +08:00
Dean Herbert	3a224211aa	Update various packages which shouldn't cause issues	2024-03-06 12:17:00 +08:00
Dean Herbert	4c7678225e	Update framework	2024-03-06 12:13:41 +08:00
Dean Herbert	0696e7de52	Update ImageSharp usages	2024-03-06 12:13:12 +08:00
Dean Herbert	b53b752e54	Update usage of MathUtils	2024-03-06 12:13:12 +08:00
Dean Herbert	6455c0583b	Update usage of CircularProgress.Current	2024-03-06 12:13:10 +08:00
Andrei Zavatski	07392a4d3e	Further simplify transform application	2024-03-06 01:10:22 +03:00
Andrei Zavatski	1c8ede854d	Remove blank lines	2024-03-06 00:17:56 +03:00
Andrei Zavatski	8b03acd27b	Implement StoryboardElementWithDuration	2024-03-06 00:16:06 +03:00
Dean Herbert	65ce4ca390	Never set waitingOnFrames if a replay is not attached	2024-03-06 04:37:11 +08:00
Dean Herbert	57daaa7fed	Add logging for GameplayClockContainer starting or stopping	2024-03-06 04:37:11 +08:00
Bartłomiej Dach	09c6c5d79b	Merge pull request #27497 from frenzibyte/mod-select-overlay-fix-ux ... Fix mod select overlay settings order not always matching mod panels	2024-03-05 19:40:13 +01:00
Bartłomiej Dach	429fa8dfae	Merge pull request #27242 from Susko3/log-global-statistics ... Log `GlobalStatistics` when exporting logs from settings	2024-03-05 19:32:54 +01:00
Bartłomiej Dach	e6f1a722cb	Remove unused field and commented-out code	2024-03-05 18:49:19 +01:00
Berkan Diler	d0f7ab3316	Revert some changes	2024-03-05 17:18:59 +01:00
Berkan Diler	6fabbe2616	Use new ToDictionary() overload without delegates	2024-03-05 10:27:12 +01:00
Berkan Diler	5965db4fd7	Use ArgumentException.ThrowIfNullOrEmpty throw helper	2024-03-05 10:20:57 +01:00
Berkan Diler	a891303484	Use ArgumentOutOfRangeException throw helper methods	2024-03-05 10:20:30 +01:00
Berkan Diler	9bac60a98f	Use ArgumentNullException.ThrowIfNull in more places	2024-03-05 10:19:47 +01:00
Berkan Diler	43841e210d	Use ObjectDisposedException.ThrowIf throw helper	2024-03-05 09:58:46 +01:00
Salman Ahmed	49b3e81e8a	Migrate DefaultPerformancePointsCounter and rename it	2024-03-05 04:35:39 +03:00
Salman Ahmed	0cbcfcecdc	Integrate "Argon" performance points counter with HUD layout	2024-03-05 03:58:43 +03:00
Salman Ahmed	d7f1e50d66	Add "Argon" performance points counter	2024-03-05 03:34:29 +03:00
Salman Ahmed	3ee57cdfba	Refactor performance points test scene to support skinning	2024-03-05 03:34:25 +03:00
Salman Ahmed	92f455f199	Abstractify performance points calculation to a base class	2024-03-05 03:33:48 +03:00
Salman Ahmed	9543908c7a	Fix mod select overlay settings order not always matching panels order	2024-03-04 23:36:45 +03:00
Bartłomiej Dach	6080c14dd5	Update F rank badge colours to match latest designs	2024-03-04 14:47:49 +01:00
Bartłomiej Dach	dcd6b02809	Fix incorrect implementation of GetCountMiss() for catch	2024-03-04 11:49:12 +01:00
Dan Balasescu	6635d9be04	Add countdown display	2024-03-04 16:50:24 +09:00
Dan Balasescu	bce3bd55e5	Fix catch by moving cursor-specific handling local	2024-03-04 16:08:17 +09:00
Dan Balasescu	5bd037fe8f	Merge branch 'master' into catch-fail-on-banana	2024-03-04 13:13:26 +09:00
Andrei Zavatski	f5d24e6804	Remove unused transform extensions	2024-03-03 21:54:37 +03:00
Andrei Zavatski	7193ec66a4	Make use of framework's transform loops	2024-03-03 21:47:03 +03:00
Andrei Zavatski	c05007804f	Use more direct way to apply transforms	2024-03-03 20:50:28 +03:00
Salman Ahmed	85f131d2f8	Fix "unranked explaination" tooltip text using incorrect translation key	2024-03-02 22:45:15 +03:00
Andrei Zavatski	77b3055978	Improve sb sprite end time guessing	2024-03-01 22:30:44 +03:00
Salman Ahmed	17e167cc1e	Merge branch 'master' into hide-beatmap-details	2024-03-01 16:21:03 +03:00
Dean Herbert	c6201ea5de	Remove unused ruleset parameter when testing beatmap in editor	2024-03-01 20:28:52 +08:00
Dan Balasescu	14519b9982	Merge pull request #27426 from peppy/disallow-backwards-seeks-gameplay ... Fix gameplay seeking backwards for a single frame for some users	2024-03-01 20:08:23 +09:00
Dean Herbert	963c0af814	Fix beatmap information still showing when testing a beatmap	2024-03-01 16:43:47 +08:00
Dean Herbert	19ed78eef5	Log backwards seeks to sentry	2024-03-01 12:40:05 +08:00
cdwcgt	4ad8bbb9e2	remove useless DrawablePool	2024-03-01 13:20:37 +09:00
Dean Herbert	00527da27d	When discord is set to privacy mode, don't show beatmap being edited	2024-03-01 11:42:35 +08:00
Dean Herbert	91483bdc2f	Merge pull request #27001 from Susko3/windows-file-uri-association ... Associate with files and URIs on windows	2024-03-01 11:26:44 +08:00
Dean Herbert	4b3a5bde28	Merge pull request #27424 from frenzibyte/taiko-slider-storyboard ... Hide osu!taiko scroller when the beatmap has storyboard	2024-03-01 10:49:12 +08:00
Andrei Zavatski	eb0933c3a5	Fix allocations in EffectPointVisualisation	2024-02-29 20:35:20 +03:00
Dean Herbert	cc8b838bd4	Add comprehensive log output to help figure out problematic clocks	2024-02-29 23:05:28 +08:00
Dean Herbert	4184a5c1ef	Add flag to allow backwards seeks in tests	2024-02-29 23:05:28 +08:00
Huo Yaoyuan	a11e63b184	Make the code more clear	2024-02-29 20:02:04 +08:00
Dean Herbert	3a780e2b67	Add logging when workaround is hit	2024-02-29 18:27:50 +08:00
Dean Herbert	3355764a68	"Fix" tests	2024-02-29 18:21:44 +08:00
Bartłomiej Dach	9a40a4f700	Merge branch 'master' into convert-path-string-new	2024-02-29 08:51:04 +01:00
Bartłomiej Dach	ee2dac35e0	Merge branch 'master' into taiko-slider-storyboard	2024-02-29 08:50:58 +01:00
Dean Herbert	76e8aee9cc	Disallow backwards seeks during frame stable operation when a replay is not attached	2024-02-29 14:15:32 +08:00
Dean Herbert	f44aadaaa8	Merge pull request #27331 from bdach/statistics-updates-in-multi ... Show user statistics updates on multiplayer and playlists results screens	2024-02-29 12:26:48 +08:00
Dean Herbert	5c404d0f61	Merge pull request #27361 from bdach/difficulty-peppy-stars-zero-osu ... Fix incorrect standardised score estimation on selected beatmaps in osu! ruleset	2024-02-29 11:45:53 +08:00
Huo Yaoyuan	f28f19ed7e	Fix method indent size ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2024-02-29 10:47:16 +08:00
Salman Ahmed	7f5f3804f1	Expose beatmap storyboard as part of GameplayState	2024-02-29 05:39:36 +03:00
Salman Ahmed	a7a758400c	Merge branch 'master' into fix-wireframe	2024-02-29 01:56:50 +03:00
Salman Ahmed	8f97f0503f	Move away from Solo namespace	2024-02-29 01:21:17 +03:00
Salman Ahmed	de48c51715	Apply renaming in remaining usages	2024-02-29 01:11:08 +03:00
Salman Ahmed	c3a7e99849	Remove unnecessary max operation	2024-02-29 01:01:55 +03:00
Salman Ahmed	4a4ef91bc9	Simplify active mods computation ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2024-02-29 00:42:52 +03:00
Salman Ahmed	92eb206b49	Merge branch 'master' into spectator-remove-back-button	2024-02-29 00:12:24 +03:00
Joseph Madamba	5ca6e8c68a	Fix some NRT changes	2024-02-28 11:03:09 -08:00
Bartłomiej Dach	a5948d38ac	Merge pull request #27380 from frenzibyte/fix-advanced-stats-display ... Fix advanced stats in beatmap info overlay showing "key count" on non-mania beatmaps	2024-02-28 18:02:48 +01:00
Huo Yaoyuan	e86ebd6cdb	Fix formatting	2024-02-29 00:24:24 +08:00
Huo Yaoyuan	470d2be2e1	The overhead of LINQ is not ignorable	2024-02-29 00:07:00 +08:00
Bartłomiej Dach	6a3a7cca58	Merge branch 'master' into adjust-carousel-padding	2024-02-28 16:00:43 +01:00
Bartłomiej Dach	c10ba6ece9	Fix right mouse scroll clamping not going along well with padding ... Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>	2024-02-28 15:59:22 +01:00
Huo Yaoyuan	bcb91f348d	Use ArrayPool instead of stackalloc	2024-02-28 22:51:36 +08:00
Huo Yaoyuan	fe34577ee2	Update parsing.	2024-02-28 22:42:08 +08:00
Huo Yaoyuan	4bff54d35d	Add ToString on PathControlPoint for debugging	2024-02-28 22:37:14 +08:00
Bartłomiej Dach	9902dad4c6	Merge branch 'master' into log-global-statistics	2024-02-28 15:09:24 +01:00
Huo Yaoyuan	f49aa4d815	Parse points and segments for path string	2024-02-28 22:01:39 +08:00
Bartłomiej Dach	ce994a7a73	Fix wireframe misalignment in argon accuracy counter ... - Closes https://github.com/ppy/osu/issues/27385. - Supersedes / closes https://github.com/ppy/osu/pull/27392.	2024-02-28 13:42:45 +01:00
Bartłomiej Dach	3fb2662d74	Update framework ... Mainly for the sake of https://github.com/ppy/osu-framework/pull/6196.	2024-02-28 12:05:33 +01:00
Joseph Madamba	6e03384c6b	Apply NRT to SoloSpectatorPlayer	2024-02-28 00:01:16 -08:00
Joseph Madamba	8e462fbb38	Apply NRT to touched files	2024-02-27 23:58:28 -08:00
Joseph Madamba	dee57c7e72	Refactor test to only allow init of actions	2024-02-27 23:24:16 -08:00
Joseph Madamba	351160f94e	Move back/quit button from bottom left to fail overlay when spectating	2024-02-27 23:24:16 -08:00
Dean Herbert	31f667224f	Merge branch 'master' into medals	2024-02-28 13:48:57 +08:00
Salman Ahmed	d83aeb73e4	Fix menu cursor tracing rotation while override by gameplay cursor	2024-02-28 01:02:36 +03:00
Bartłomiej Dach	2889cf39d7	Merge pull request #27391 from smoogipoo/high-performance-session-redux ... Use high performance session during gameplay	2024-02-27 16:28:04 +01:00
Gabriel Del Nero	09dee50372	Change initial scroll animation to mod columns ... Starting from the end (which should be fine with the current number of columns, even on different/wider screen resolutions), and with a custom decay value when it reaches zero offset.	2024-02-27 15:35:51 +01:00
Dean Herbert	189c680555	Add basic xmldoc on interface type	2024-02-27 20:46:25 +08:00
Dan Balasescu	069b400dd0	Move manager to desktop game	2024-02-27 19:36:03 +09:00
Dan Balasescu	dc3b41865c	Add logging	2024-02-27 19:17:34 +09:00
Dan Balasescu	f2d52fbaa2	Make class not overrideable	2024-02-27 17:33:24 +09:00
Dean Herbert	7f0a552b86	Merge pull request #27366 from EVAST9919/mod-overlay-performnce ... Reduce allocations when `ModSelectOverlay` is visible	2024-02-27 08:54:18 +08:00
Salman Ahmed	3f9fbb9318	Introduce the concept of ActiveMods in mod select overlay and rewrite once more	2024-02-26 22:25:06 +03:00
Salman Ahmed	2b73d816a7	Bring back mod setting tracker in BeatmapAttributesDisplay	2024-02-26 22:24:45 +03:00
Bartłomiej Dach	3833f2cfa7	Merge pull request #27393 from peppy/main-menu-key-delay ... Fix main menu eating keys if user presses too fast	2024-02-26 16:22:27 +01:00
Dean Herbert	fe59a3b9be	Merge branch 'master' into medals	2024-02-26 22:49:55 +08:00
Dean Herbert	4c6e8a606f	Fix main menu eating keys if user presses too fast	2024-02-26 22:24:39 +08:00
Dan Balasescu	bfb5098238	Use high performance session during gameplay	2024-02-26 22:32:48 +09:00
Dean Herbert	c686dfd361	Apply safeties for AudioFilter usage around drawables which go non-present	2024-02-26 21:22:25 +08:00
Dean Herbert	7a96cf1289	Expose AudioFilter.IsAttached publicly	2024-02-26 21:15:44 +08:00
Dan Balasescu	3e9425fdf2	Adjust API of HighPerformanceSession + rename	2024-02-26 22:12:46 +09:00
Bartłomiej Dach	09b420a083	Merge pull request #27234 from brandondong/delete_none_message ... Add feedback to delete button even when no-op	2024-02-26 13:13:53 +01:00
Bartłomiej Dach	119a373285	Merge pull request #27389 from peppy/menu-hotkeys ... Allow better menu navigation using same hotkey to progress to destination	2024-02-26 12:31:22 +01:00
Bartłomiej Dach	46ec477191	Merge pull request #27386 from peppy/fix-use-current-distance-snap ... Fix "Use current" snap not working	2024-02-26 12:30:35 +01:00
Dean Herbert	8e336610d0	Add xmldoc explaining Ruleset bindable's usage	2024-02-26 18:31:40 +08:00
Bartłomiej Dach	353485a707	Merge branch 'master' into flashlight-playfield-based-size-	2024-02-26 10:55:06 +01:00
Bartłomiej Dach	115d82664b	Assert proportional scaling rather than assume average ... Because if scaling is ever actually non-proportional then this should be somewhat loud. Also use the absolute value to prevent funny things happening if/when someone does negative scale.	2024-02-26 10:53:04 +01:00
Dean Herbert	8962be2ed5	Allow better menu navigation using same hotkey to progress to destination ... As touched on in https://github.com/ppy/osu/discussions/27102. You can now use: - `L L L` to get to playlists - `M M M` to get to multiplayer - `S` to get to settings	2024-02-26 17:24:04 +08:00
Dean Herbert	9a46e738bd	Fix inspections	2024-02-26 15:45:29 +08:00
Dean Herbert	4c744ccb69	Fix "Use current" snap not working ... Regressed with https://github.com/ppy/osu/pull/27249. I was suspicious of this specific operation at the time but didn't test properly.	2024-02-26 14:11:54 +08:00
Dean Herbert	4421ff975b	Add local function to perform iteration to better explain the "why"	2024-02-26 09:04:39 +08:00
Salman Ahmed	5c049feca1	Fix advanced stats in beatmap info overlay showing "key count" on non-mania beatmaps	2024-02-25 21:18:15 +03:00
Andrei Zavatski	9e3defebda	Remove unused using	2024-02-25 19:05:40 +03:00
Andrei Zavatski	c3fa97d062	Reduce allocations in HitObjectLifetimeEntry	2024-02-25 18:02:42 +03:00
Andrei Zavatski	f948f8ee5c	Fix HUDOverlay allocations	2024-02-25 17:59:20 +03:00