h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-12 17:43:05 +08:00
Code Issues Releases Wiki Activity

Add local function to perform iteration to better explain the "why"

Browse Source
This commit is contained in:
Dean Herbert 2024-02-26 09:04:39 +08:00
parent 9e3defebda
commit 4421ff975b
No known key found for this signature in database
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
osu.Game/Screens/Play/HUDOverlay.cs
View File

@ -258,14 +258,10 @@ namespace osu.Game.Screens.Play
Vector2? highestBottomScreenSpace = null;
for (int i = 0; i < mainComponents.Components.Count; i++)
processDrawable(mainComponents.Components[i]);
processDrawables(mainComponents);
if (rulesetComponents != null)
{
for (int i = 0; i < rulesetComponents.Components.Count; i++)
processDrawable(rulesetComponents.Components[i]);
}
processDrawables(rulesetComponents);
if (lowestTopScreenSpaceRight.HasValue)
topRightElements.Y = MathHelper.Clamp(ToLocalSpace(new Vector2(0, lowestTopScreenSpaceRight.Value)).Y, 0, DrawHeight - topRightElements.DrawHeight);
@ -282,6 +278,14 @@ namespace osu.Game.Screens.Play
else
bottomRightElements.Y = 0;
void processDrawables(SkinComponentsContainer components)
{
// Avoid using foreach due to missing GetEnumerator implementation.
// See https://github.com/ppy/osu-framework/blob/e10051e6643731e393b09de40a3a3d209a545031/osu.Framework/Bindables/IBindableList.cs#L41-L44.
for (int i = 0; i < components.Components.Count; i++)
processDrawable(components.Components[i]);
}
void processDrawable(ISerialisableDrawable element)
{
// Cast can be removed when IDrawable interface includes Anchor / RelativeSizeAxes.